mirror of
https://github.com/twentyhq/twenty.git
synced 2024-11-25 20:00:34 +03:00
Fix explicit boolean predicates rule not working with boolean constants (#5009)
### Description Fix explicit boolean predicates rule not working with boolean constants ### Refs #4881 ### Demo Fixes #4881 Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com>
This commit is contained in:
parent
6cf3ade300
commit
d54e690f0d
@ -23,7 +23,6 @@ export const usePreviousHotkeyScope = () => {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// eslint-disable-next-line @nx/workspace-explicit-boolean-predicates-in-if
|
|
||||||
if (DEBUG_HOTKEY_SCOPE) {
|
if (DEBUG_HOTKEY_SCOPE) {
|
||||||
logDebug('DEBUG: goBackToPreviousHotkeyScope', previousHotkeyScope);
|
logDebug('DEBUG: goBackToPreviousHotkeyScope', previousHotkeyScope);
|
||||||
}
|
}
|
||||||
@ -45,7 +44,6 @@ export const usePreviousHotkeyScope = () => {
|
|||||||
.getLoadable(currentHotkeyScopeState)
|
.getLoadable(currentHotkeyScopeState)
|
||||||
.getValue();
|
.getValue();
|
||||||
|
|
||||||
// eslint-disable-next-line @nx/workspace-explicit-boolean-predicates-in-if
|
|
||||||
if (DEBUG_HOTKEY_SCOPE) {
|
if (DEBUG_HOTKEY_SCOPE) {
|
||||||
logDebug('DEBUG: setHotkeyScopeAndMemorizePreviousScope', {
|
logDebug('DEBUG: setHotkeyScopeAndMemorizePreviousScope', {
|
||||||
currentHotkeyScope,
|
currentHotkeyScope,
|
||||||
|
@ -28,7 +28,6 @@ export const useScopedHotkeyCallback = () =>
|
|||||||
.getValue();
|
.getValue();
|
||||||
|
|
||||||
if (!currentHotkeyScopes.includes(scope)) {
|
if (!currentHotkeyScopes.includes(scope)) {
|
||||||
// eslint-disable-next-line @nx/workspace-explicit-boolean-predicates-in-if
|
|
||||||
if (DEBUG_HOTKEY_SCOPE) {
|
if (DEBUG_HOTKEY_SCOPE) {
|
||||||
logDebug(
|
logDebug(
|
||||||
`DEBUG: %cI can't call hotkey (${
|
`DEBUG: %cI can't call hotkey (${
|
||||||
@ -43,7 +42,6 @@ export const useScopedHotkeyCallback = () =>
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// eslint-disable-next-line @nx/workspace-explicit-boolean-predicates-in-if
|
|
||||||
if (DEBUG_HOTKEY_SCOPE) {
|
if (DEBUG_HOTKEY_SCOPE) {
|
||||||
logDebug(
|
logDebug(
|
||||||
`DEBUG: %cI can call hotkey (${
|
`DEBUG: %cI can call hotkey (${
|
||||||
|
@ -79,9 +79,6 @@ export const useSetHotkeyScope = () =>
|
|||||||
|
|
||||||
scopesToSet.push(newHotkeyScope.scope);
|
scopesToSet.push(newHotkeyScope.scope);
|
||||||
|
|
||||||
// TODO: fix eslint rule not understanding a boolean constant
|
|
||||||
// See issue https://github.com/twentyhq/twenty/issues/4881
|
|
||||||
// eslint-disable-next-line @nx/workspace-explicit-boolean-predicates-in-if
|
|
||||||
if (DEBUG_HOTKEY_SCOPE) {
|
if (DEBUG_HOTKEY_SCOPE) {
|
||||||
logDebug('DEBUG: set new hotkey scope', {
|
logDebug('DEBUG: set new hotkey scope', {
|
||||||
scopesToSet,
|
scopesToSet,
|
||||||
|
@ -1,4 +1,3 @@
|
|||||||
/* eslint-disable @nx/workspace-explicit-boolean-predicates-in-if */
|
|
||||||
import { isNull, isNumber, isString } from '@sniptt/guards';
|
import { isNull, isNumber, isString } from '@sniptt/guards';
|
||||||
|
|
||||||
import { logError } from './logError';
|
import { logError } from './logError';
|
||||||
|
@ -1,7 +1,13 @@
|
|||||||
import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils';
|
import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils';
|
||||||
|
import ts from 'typescript';
|
||||||
|
|
||||||
export const RULE_NAME = 'explicit-boolean-predicates-in-if';
|
export const RULE_NAME = 'explicit-boolean-predicates-in-if';
|
||||||
|
|
||||||
|
const isBooleanType = (type: ts.Type) => {
|
||||||
|
// check if boolean flag(s) is set on the type (e.g. boolean, true, false, etc.)
|
||||||
|
return type && (type.flags & ts.TypeFlags.BooleanLike) !== 0;
|
||||||
|
};
|
||||||
|
|
||||||
export const rule = ESLintUtils.RuleCreator(() => __filename)({
|
export const rule = ESLintUtils.RuleCreator(() => __filename)({
|
||||||
name: RULE_NAME,
|
name: RULE_NAME,
|
||||||
meta: {
|
meta: {
|
||||||
@ -27,9 +33,8 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
|
|||||||
const tsNode = parserServices.esTreeNodeToTSNodeMap.get(node.test);
|
const tsNode = parserServices.esTreeNodeToTSNodeMap.get(node.test);
|
||||||
const type = typeChecker.getTypeAtLocation(tsNode);
|
const type = typeChecker.getTypeAtLocation(tsNode);
|
||||||
|
|
||||||
if (typeChecker.typeToString(type) !== 'boolean') {
|
if (!isBooleanType(type)) {
|
||||||
const { test } = node;
|
const { test } = node;
|
||||||
|
|
||||||
context.report({
|
context.report({
|
||||||
node: test,
|
node: test,
|
||||||
messageId: 'nonExplicitPredicate',
|
messageId: 'nonExplicitPredicate',
|
||||||
|
Loading…
Reference in New Issue
Block a user