mirror of
https://github.com/twentyhq/twenty.git
synced 2024-12-04 05:32:38 +03:00
17422b7690
## Context Fixes #4808 TL;DR Introducing pure stateless modal component ("UI modal") for our auth modal not to have default hotkeyScope overriding our create-profile hotkeyScope + we dont want the shortcut to be available for all the modal content, only for the input that should not be using a hotkeyscope, so we are using onKeyDown for the specific issue on create profile. Explanation create-profile hotkey scope is set by PageChangeEffect; CreateProfile component adds enter key shortcut; but this scope is overwritten by the default scope by the Modal component that expects a hotkeyScope to reset to (and defaults to the default hotkeyScope if none indicated). In the auth flow we were using that Modal component to give a modal look to the flow but it is not a modal per say, it's a set of pages contained within a modal look. By creating this UI component we are escaping that hotkeyScope overriding that does not make sense in our context. ## How was it tested Locally Storybook |
||
|---|---|---|
| .. | ||
| __mocks__ | ||
| .storybook | ||
| public | ||
| scripts | ||
| src | ||
| .env.example | ||
| .eslintrc-ci.cjs | ||
| .eslintrc.cjs | ||
| .gitignore | ||
| .swcrc | ||
| codegen-metadata.cjs | ||
| codegen.cjs | ||
| index.html | ||
| jest.config.ts | ||
| nyc.config.cjs | ||
| package.json | ||
| README.md | ||
| setupTests.ts | ||
| tsconfig.app.json | ||
| tsconfig.json | ||
| tsconfig.spec.json | ||
| tsup.config.ts | ||
| tsup.ui.index.tsx | ||
| vite.config.ts | ||
Run yarn dev while server running on port 3000