twentyhq/twenty
1
1
Fork 0
mirror of https://github.com/twentyhq/twenty.git synced 2024-12-23 12:02:10 +03:00
Code Issues Packages Projects Releases Wiki Activity
183fd877c4
twenty/packages/twenty-front
History
khuddite 183fd877c4
Add a confirmation modal for relation object deletion (#8818) 
Fixes #8698 

1. Summary
We decided to add a confirmation modal for the relation object deletion.
It's gonna a bit of safety to the user interactions because this action
can be disruptive even though it can be restored.

2. Solution
Used `createPortal` function to address the issue where the vertical
scrollbar shows over the modal. Added a logic that displays a
confirmation modal for deletion in [this
file](d284419d66/packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx).
I can update the text(title, description, and CTA) as necessary based on
the feedback.

_**However, I observed an issue that the deleted object still shows up
under the list until hard-refresh. I figured that can be addressed as a
separate issue.**_

3. Recording


https://github.com/user-attachments/assets/1a64b702-a915-49f3-a226-2c2d5af8a1d7
2024-12-11 18:23:27 +01:00
..
__mocks__ Fix overlay scroll gaps (#4512) 2024-03-31 10:53:37 +02:00
.storybook feat: view groups (#7176) 2024-10-24 15:38:52 +02:00
public Swap dark placeholders (#8956) 2024-12-09 14:21:10 +01:00
scripts feat: add SENTRY_RELEASE env (#4912) 2024-04-11 16:53:15 +02:00
src Add a confirmation modal for relation object deletion (#8818) 2024-12-11 18:23:27 +01:00
.env.example review(front): refacto url-manager (#8861) 2024-12-05 11:47:51 +01:00
.eslintrc-ci.cjs chore: enable no-console eslint rule for tests and stories (#4816) 2024-04-04 18:36:39 +02:00
.eslintrc.cjs 6071 return only updated fields of records in zapier update trigger (#8193) 2024-11-04 17:44:36 +01:00
.gitignore folderStructure.json refactor (#8088) 2024-10-28 12:06:58 +01:00
.prettierignore Update twenty-front commands (#4667) 2024-04-17 18:06:02 +02:00
.swcrc Migrate to a monorepo structure (#2909) 2023-12-10 18:10:54 +01:00
codegen-metadata.cjs Serverless function UI (#6388) 2024-07-29 13:03:09 +02:00
codegen.cjs Serverless function UI (#6388) 2024-07-29 13:03:09 +02:00
folderStructure.json folderStructure.json refactor (#8088) 2024-10-28 12:06:58 +01:00
index.html Prevent automatic zoom when focusing inputs on iOS (#8477) 2024-11-13 15:34:20 +01:00
jest.config.ts Feat: Advanced filter (#7700) 2024-10-24 16:59:59 +02:00
nyc.config.cjs Fix front tests (#8207) 2024-10-30 15:50:56 +01:00
package.json Bump 0.34.0-canary (#8675) 2024-11-22 11:53:33 +01:00
project.json 8723 workflow add editor in serverless function code step (#8805) 2024-12-03 08:41:13 +00:00
README.md Migrate to a monorepo structure (#2909) 2023-12-10 18:10:54 +01:00
setupTests.ts Create new steps in workflow editor (#6764) 2024-08-30 15:51:36 +02:00
tsconfig.build.json added typechecking for all ts files (#6466) 2024-08-20 11:05:13 +02:00
tsconfig.dev.json added typechecking for all ts files (#6466) 2024-08-20 11:05:13 +02:00
tsconfig.json Activate/Deactivate workflow and Discard Draft (#7022) 2024-09-25 18:09:31 +02:00
tsconfig.spec.json fix: fix root start script (#5032) 2024-04-19 18:28:02 +02:00
tsconfig.storybook.json fix: fix root start script (#5032) 2024-04-19 18:28:02 +02:00
tsup.config.ts Fix frontend tests (#6585) 2024-08-09 08:38:01 +02:00
tsup.ui.index.tsx Migrate to twenty-ui - navigation/menu-item (#8213) 2024-11-07 16:51:39 +00:00
vite.config.ts Fix login issue (#9012) 2024-12-11 15:42:53 +01:00

README.md

Run yarn dev while server running on port 3000