mirror of
https://github.com/twentyhq/twenty.git
synced 2024-12-27 22:32:49 +03:00
bb7d94a455
### Description Create ESLint rule to discourage usage of navigate() and prefer Link ### Refs #5468 ### Demo ![Capture-2024-05-29-112852](https://github.com/twentyhq/twenty/assets/140154534/28378c09-86bb-49d3-9e9a-49aa1c07ad11) ![Capture-2024-05-29-112843](https://github.com/twentyhq/twenty/assets/140154534/2c05ea92-e19b-49ae-acb9-07f6ec9182ab) Fixes #5468 --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com> Co-authored-by: Félix Malfait <felix.malfait@gmail.com>
102 lines
3.0 KiB
TypeScript
102 lines
3.0 KiB
TypeScript
import { ESLintUtils, TSESTree } from '@typescript-eslint/utils';
|
|
|
|
// NOTE: The rule will be available in ESLint configs as "@nx/workspace-no-navigate-prefer-link"
|
|
export const RULE_NAME = 'no-navigate-prefer-link';
|
|
|
|
export const rule = ESLintUtils.RuleCreator(() => __filename)({
|
|
name: RULE_NAME,
|
|
meta: {
|
|
type: 'suggestion',
|
|
docs: {
|
|
description:
|
|
'Discourage usage of navigate() where a simple <Link> component would suffice.',
|
|
},
|
|
messages: {
|
|
preferLink: 'Use <Link> instead of navigate() for pure navigation.',
|
|
},
|
|
schema: [],
|
|
},
|
|
defaultOptions: [],
|
|
create: (context) => {
|
|
const functionMap: Record<string, TSESTree.ArrowFunctionExpression> = {};
|
|
|
|
const checkFunctionBodyHasSingleNavigateCall = (
|
|
func: TSESTree.ArrowFunctionExpression,
|
|
) => {
|
|
// Check for simple arrow function with single navigate call
|
|
if (
|
|
func.body.type === 'CallExpression' &&
|
|
func.body.callee.type === 'Identifier' &&
|
|
func.body.callee.name === 'navigate'
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
// Check for block arrow function with single navigate call
|
|
if (
|
|
func.body.type === 'BlockStatement' &&
|
|
func.body.body.length === 1 &&
|
|
func.body.body[0].type === 'ExpressionStatement' &&
|
|
func.body.body[0].expression.type === 'CallExpression' &&
|
|
func.body.body[0].expression.callee.type === 'Identifier' &&
|
|
func.body.body[0].expression.callee.name === 'navigate'
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
};
|
|
|
|
return {
|
|
VariableDeclarator: (node) => {
|
|
// Check for function declaration on onClick
|
|
if (
|
|
node.init &&
|
|
node.init.type === 'ArrowFunctionExpression' &&
|
|
node.id.type === 'Identifier'
|
|
) {
|
|
const func = node.init;
|
|
functionMap[node.id.name] = func;
|
|
|
|
if (checkFunctionBodyHasSingleNavigateCall(func)) {
|
|
context.report({
|
|
node: func,
|
|
messageId: 'preferLink',
|
|
});
|
|
}
|
|
}
|
|
},
|
|
JSXAttribute: (node) => {
|
|
// Check for navigate call directly on onClick
|
|
if (
|
|
node.name.name === 'onClick' &&
|
|
node.value.type === 'JSXExpressionContainer'
|
|
) {
|
|
const expression = node.value.expression;
|
|
|
|
if (
|
|
expression.type === 'ArrowFunctionExpression' &&
|
|
checkFunctionBodyHasSingleNavigateCall(expression)
|
|
) {
|
|
context.report({
|
|
node: expression,
|
|
messageId: 'preferLink',
|
|
});
|
|
} else if (
|
|
expression.type === 'Identifier' &&
|
|
functionMap[expression.name]
|
|
) {
|
|
const func = functionMap[expression.name];
|
|
if (checkFunctionBodyHasSingleNavigateCall(func)) {
|
|
context.report({
|
|
node: expression,
|
|
messageId: 'preferLink',
|
|
});
|
|
}
|
|
}
|
|
}
|
|
},
|
|
};
|
|
},
|
|
});
|