mirror of
https://github.com/twentyhq/twenty.git
synced 2024-12-23 20:13:21 +03:00
dfb966d47e
Fixes #8591 1. Summary We disabled hide/dnd(drag-and-drop) options for `No value` view group intentionally in the first implementation. We want to change it to behave like normal view groups, so enable hide/dnd for `No value` view group as well. 2. Solution I have removed the code that filters the `No value` group out of view groups, so `No value` is stored in the same array as other view groups. I have removed the `No value` flag check for `Hide` button on the hamburger menu of the Kanban header. I had to update the code in `packages/twenty-front/src/modules/views/utils/mapViewGroupsToRecordGroupDefinitions.ts` because it was ignoring the visibility flag of the `No value` view group and set it always to true. Also, it was always putting the `No value` group last ignoring the previous position. >**_I am not 100% confident in the changes I made in `packages/twenty-front/src/modules/views/utils/mapViewGroupsToRecordGroupDefinitions.ts`. I'd like to have a review from someone more familiar with that part._** 3. Recording https://github.com/user-attachments/assets/e135e22e-6e3a-4f94-a898-aafc03bba060 |
||
|---|---|---|
| .. | ||
| __mocks__ | ||
| .storybook | ||
| public | ||
| scripts | ||
| src | ||
| .env.example | ||
| .eslintrc-ci.cjs | ||
| .eslintrc.cjs | ||
| .gitignore | ||
| .prettierignore | ||
| .swcrc | ||
| codegen-metadata.cjs | ||
| codegen.cjs | ||
| folderStructure.json | ||
| index.html | ||
| jest.config.ts | ||
| nyc.config.cjs | ||
| package.json | ||
| project.json | ||
| README.md | ||
| setupTests.ts | ||
| tsconfig.build.json | ||
| tsconfig.dev.json | ||
| tsconfig.json | ||
| tsconfig.spec.json | ||
| tsconfig.storybook.json | ||
| tsup.config.ts | ||
| tsup.ui.index.tsx | ||
| vite.config.ts | ||
Run yarn dev while server running on port 3000