mirror of
https://github.com/twentyhq/twenty.git
synced 2024-11-29 19:10:19 +03:00
f4bc0c687e
## Context Because we can't create GIN indexes on primitive types and in this case both tsvector and deletedAt (date), we had to create an index on the tsvector only and had to make sure it wouldn't return results for deleted records. To handle this, we added a CASE in the generated expression to generate an empty value if the row has been soft-deleted. This is a bit too complex and won't allow search on softDeleted records in the future. What we want to do is to make sure deleted records are not returned by default by adding a WHERE clause in the search and still keep good performances by also adding a BTREE index on deletedAt column. When this was implemented, soft-deleted was not handled properly but now typeorm query builder exclude soft deleted records by default which means the WHERE clause is not necessary. As for the BTREE index on deletedAt, this should be part on a broader effort to add it to all tables and can be added in a later PR. This PR simply updates the complex tsVectorExpression to only return the expression regardless of the deletedAt column. Search won't return soft-deleted records as explained above and perfs will be improved in an upcoming version. ## Test tested locally with reset db + created a new workspace. Since the feature is not launched yet no more effort should be made. <img width="1289" alt="Screenshot 2024-10-10 at 15 16 16" src="https://github.com/user-attachments/assets/d9a6f06b-d738-4f1d-8053-2fa93bd8b4f8"> ## Note Some issues with optimistic rendering, we need to refresh once a record has been deleted otherwise it will still be returned by the search |
||
|---|---|---|
| .. | ||
| @types | ||
| patches | ||
| scripts | ||
| src | ||
| test | ||
| .env.example | ||
| .env.test | ||
| .eslintrc.cjs | ||
| .gitignore | ||
| .prettierignore | ||
| .prettierrc | ||
| .swcrc | ||
| jest-integration.config.ts | ||
| jest.config.ts | ||
| nest-cli.json | ||
| package.json | ||
| project.json | ||
| tsconfig.build.json | ||
| tsconfig.json | ||
| tsconfig.scripts.json | ||