on master help sign in
Merge pull request #539 from jprider63/master

Added myself to security review comment. #537

commite92c3dc8fe77abc8cd7fe76191ac8aa667b86941 authorAdam Bergmark <adam@bergmark.nl> dateTue 4 Apr 2017, 18:09 (10 years ago) parent7b8d3ce66080da
1 file changed+3−3
pure/Data/Aeson/Parser/UnescapePure.hs+3−3
pure/Data/Aeson/Parser/UnescapePure.hs+3−3
@@ -1,7 +1,7 @@
11-- WARNING: This file is security sensitive as it uses unsafeWrite which does
2−-- not check bounds. Any changes should be made with care and I would love to
3−-- get informed about them, just cc me in any PR targetting this file: @eskimor
4−-- I would be happy to review the changes!
2+-- not check bounds. Any changes should be made with care and we would love to
3+-- get informed about them, just cc us in any PR targetting this file: @eskimor @jprider63
4+-- We would be happy to review the changes!
55
66-- The security check at the end (pos > length) only works if pos grows
77-- monotonously, if this condition does not hold, the check is flawed.