on master help sign in
28 files changed+417−264
since splitsnapshots
unifiedsplit
.gitignore+1 .travis.yml+15−12 CONTRIBUTING.md+38 Data/Aeson/Compat.hs−16 Data/Aeson/TH.hs+24−38 Data/Aeson/Types.hs+3 Data/Aeson/Types/FromJSON.hs+90−66 Data/Aeson/Types/Internal.hs+22−2 Data/Aeson/Types/ToJSON.hs+3−42 aeson.cabal+7−13 attoparsec-iso8601/Data/Attoparsec/Time/Internal.hs−20 attoparsec-iso8601/attoparsec-iso8601.cabal+1−1 benchmarks/aeson-benchmarks.cabal−1 cabal.project+1 changelog.md+13 stack-bench.yaml+2−8 stack-ffi-unescape.yaml+2−7 stack-nightly.yaml+2−4 tests/Encoders.hs+25−6 tests/ErrorMessages.hs+27−1 tests/Instances.hs+1−4 tests/Options.hs+11 tests/PropertyGeneric.hs−8 tests/PropertyKeys.hs−3 tests/SerializationFormatSpec.hs−4 tests/Types.hs−2 tests/UnitTests.hs+118−3 tests/golden/generic.expected+11−3
.gitignore+1
@@ -5,6 +5,7 @@ dist-newstyle
55cabal.sandbox.config
66.stack-work/
77.stack-work-bench/
8+*.yaml.lock
89
910*.o
1011*.hi
.travis.yml+15−12
@@ -24,43 +24,46 @@ before_cache:
2424
2525matrix:
2626 include:
27+
2728 - env: BUILD=hlint CABALVER=2.2 GHCVER=8.4.4
2829 compiler: ": #GHC 8.4.4"
2930 addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4], sources: [hvr-ghc]}}
30− - env: BUILD=stack CABALVER=2.2 GHCVER=8.4.4 STACK_YAML=stack-bench.yaml
31− compiler: ": #GHC 8.4.4"
32− addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4], sources: [hvr-ghc]}}
33− - env: BUILD=stack CABALVER=2.2 GHCVER=8.4.4 STACK_YAML=stack-ffi-unescape.yaml
34− compiler: ": #GHC 8.4.4"
35− addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4], sources: [hvr-ghc]}}
31+
32+ - env: BUILD=stack CABALVER=2.4 GHCVER=8.6.5 STACK_YAML=stack-bench.yaml
33+ compiler: ": #GHC 8.6.5"
34+ addons: {apt: {packages: [cabal-install-2.4,ghc-8.6.5], sources: [hvr-ghc]}}
35+
36+ - env: BUILD=stack CABALVER=2.2 GHCVER=8.6.5 STACK_YAML=stack-ffi-unescape.yaml
37+ compiler: ": #GHC 8.6.5"
38+ addons: {apt: {packages: [cabal-install-2.2,ghc-8.6.5], sources: [hvr-ghc]}}
3639
3740 - env: BUILD=cabal2 CABALVER=3.0 GHCVER=8.8.1
3841 compiler: ": #GHC 8.8.1"
3942 addons: {apt: {packages: [cabal-install-3.0,ghc-8.8.1], sources: [hvr-ghc]}}
43+
4044 - env: BUILD=cabal CABALVER=2.4 GHCVER=8.6.5
4145 compiler: ": #GHC 8.6.5"
4246 addons: {apt: {packages: [cabal-install-2.4,ghc-8.6.5], sources: [hvr-ghc]}}
47+
4348 - env: BUILD=cabal CABALVER=2.2 GHCVER=8.4.4
4449 compiler: ": #GHC 8.4.4"
4550 addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4], sources: [hvr-ghc]}}
51+
4652 - env: BUILD=cabal CABALVER=2.0 GHCVER=8.2.2
4753 compiler: ": #GHC 8.2.2"
4854 addons: {apt: {packages: [cabal-install-2.0,ghc-8.2.2], sources: [hvr-ghc]}}
55+
4956 - env: BUILD=cabal CABALVER=2.0 GHCVER=8.0.2
5057 compiler: ": #GHC 8.0.2"
5158 addons: {apt: {packages: [cabal-install-2.0,ghc-8.0.2], sources: [hvr-ghc]}}
59+
5260 - env: BUILD=cabal CABALVER=1.22 GHCVER=7.10.3
5361 compiler: ": #GHC 7.10.3"
5462 addons: {apt: {packages: [cabal-install-1.22,ghc-7.10.3], sources: [hvr-ghc]}}
63+
5564 - env: BUILD=cabal CABALVER=1.18 GHCVER=7.8.4
5665 compiler: ": #GHC 7.8.4"
5766 addons: {apt: {packages: [cabal-install-1.18,ghc-7.8.4], sources: [hvr-ghc]}}
58− - env: BUILD=cabal CABALVER=1.18 GHCVER=7.6.3
59− compiler: ": #GHC 7.6.3"
60− addons: {apt: {packages: [cabal-install-1.18,ghc-7.6.3], sources: [hvr-ghc]}}
61− - env: BUILD=cabal CABALVER=1.18 GHCVER=7.4.2
62− compiler: ": #GHC 7.4.2"
63− addons: {apt: {packages: [cabal-install-1.18,ghc-7.4.2], sources: [hvr-ghc]}}
6467
6568before_install:
6669 - unset CC
CONTRIBUTING.md+38
@@ -58,3 +58,41 @@ import Foo as F
5858import Qux (Q(..), q)
5959import qualified A
6060```
61+
62+## Development Workflow (If you plan on using Stack)
63+
64+Here we outline a general workflow new contributors could adopt for a nice incremental development experience.
65+
66+The root folder consists of two stack-*.yaml config files.
67+
68+1. stack-nightly.yaml - Config file defines all the settings to build and test any changes.
69+2. stack-bench.yaml - Used to run benchmark tests.
70+3. stack-ffi-unescape.yaml - This is for replacing certain parts with a C-implementation.
71+
72+Therefore, a ghci development experience would be:
73+
74+1. `stack ghci --stack-yaml stack-nightly.yaml --test`
75+2. :r to recompile
76+3. `main` to run all tests, or `:main --pattern Foo` to run specific tests matched by pattern.
77+
78+Some discussion on this topic can also be found here [here](https://github.com/bos/aeson/issues/733)
79+
80+Of course before submitting a PR, the following steps are recommended:
81+
82+1. 'stack test --stack-yaml stack-nightly.yaml` - Run the entire suite of tests
83+2. `make hlint` - Run hlint on the source folders.
84+3. 'stack test --stack-yaml stack-bench.yaml` - Run the benchmark tests if you believe your changes could affect the benchmarks.
85+
86+## Development Workflow (If you plan on using Cabal)
87+
88+A ghci development experience would be:
89+
90+1. `cabal new-repl test:tests`
91+2. `:r` to recompile
92+3. `Main.main` to run all tests, or `:m Main; :main --pattern Foo` to run specific tests matched by pattern.
93+
94+Of course before submitting a PR, the following steps are recommended:
95+
96+1. `cabal new-test` - Run the entire suite of tests
97+2. `make hlint` - Run hlint on the source folders.
98+3. Uncomment the `benchmarks` line in `cabal.project` - Run the benchmark tests if you believe your changes could affect the benchmarks.
Data/Aeson/Compat.hsdeleted−16
@@ -1,16 +0,0 @@
1−{-# LANGUAGE CPP #-}
2−
3−module Data.Aeson.Compat
4− (
5− fromStrict
6− ) where
7−
8−import qualified Data.ByteString as S
9−import qualified Data.ByteString.Lazy as L
10−
11−fromStrict :: S.ByteString -> L.ByteString
12−#if MIN_VERSION_bytestring(0, 9, 2)
13−fromStrict = L.fromChunks . (:[])
14−#else
15−fromStrict = L.fromStrict
16−#endif
Data/Aeson/TH.hs+24−38
@@ -135,22 +135,15 @@ import Data.Map (Map)
135135import Data.Maybe (catMaybes, fromMaybe, mapMaybe)
136136import qualified Data.Monoid as Monoid
137137import Data.Set (Set)
138−#if MIN_VERSION_template_haskell(2,8,0)
139138import Language.Haskell.TH hiding (Arity)
140−#else
141−import Language.Haskell.TH
142−#endif
143139import Language.Haskell.TH.Datatype
144−#if MIN_VERSION_template_haskell(2,7,0) && !(MIN_VERSION_template_haskell(2,8,0))
145−import Language.Haskell.TH.Lib (starK)
146−#endif
147140#if MIN_VERSION_template_haskell(2,8,0) && !(MIN_VERSION_template_haskell(2,10,0))
148141import Language.Haskell.TH.Syntax (mkNameG_tc)
149142#endif
150143import Text.Printf (printf)
151144import qualified Data.Aeson.Encoding.Internal as E
152145import qualified Data.Foldable as F (all)
153−import qualified Data.HashMap.Strict as H (lookup, toList)
146+import qualified Data.HashMap.Strict as H (difference, fromList, keys, lookup, toList)
154147import qualified Data.List.NonEmpty as NE (length, reverse)
155148import qualified Data.Map as M (fromList, keys, lookup , singleton, size)
156149import qualified Data.Semigroup as Semigroup (Option(..))
@@ -929,12 +922,32 @@ parseRecord :: JSONClass
929922 -> Name
930923 -> [Name]
931924 -> Name
925+ -> Bool
932926 -> ExpQ
933−parseRecord jc tvMap argTys opts tName conName fields obj =
927+parseRecord jc tvMap argTys opts tName conName fields obj inTaggedObject =
928+ (if rejectUnknownFields opts
929+ then infixApp checkUnknownRecords [|(>>)|]
930+ else id) $
934931 foldl' (\a b -> infixApp a [|(<*>)|] b)
935932 (infixApp (conE conName) [|(<$>)|] x)
936933 xs
937934 where
935+ tagFieldNameAppender =
936+ if inTaggedObject then (tagFieldName (sumEncoding opts) :) else id
937+ knownFields = appE [|H.fromList|] $ listE $
938+ map (\knownName -> tupE [appE [|T.pack|] $ litE $ stringL knownName, [|()|]]) $
939+ tagFieldNameAppender $ map nameBase fields
940+ checkUnknownRecords =
941+ caseE (appE [|H.keys|] $ infixApp (varE obj) [|H.difference|] knownFields)
942+ [ match (listP []) (normalB [|return ()|]) []
943+ , newName "unknownFields" >>=
944+ \unknownFields -> match (varP unknownFields)
945+ (normalB $ appE [|fail|] $ infixApp
946+ (litE (stringL "Unknown fields: "))
947+ [|(++)|]
948+ (appE [|show|] (varE unknownFields)))
949+ []
950+ ]
938951 x:xs = [ [|lookupField|]
939952 `appE` dispatchParseJSON jc conName tvMap argTy
940953 `appE` litE (stringL $ show tName)
@@ -1009,7 +1022,7 @@ parseArgs jc tvMap tName opts
10091022 , constructorFields = argTys }
10101023 (Left (_, obj)) = do
10111024 argTys' <- mapM resolveTypeSynonyms argTys
1012− parseRecord jc tvMap argTys' opts tName conName fields obj
1025+ parseRecord jc tvMap argTys' opts tName conName fields obj True
10131026parseArgs jc tvMap tName opts
10141027 info@ConstructorInfo { constructorName = conName
10151028 , constructorVariant = RecordConstructor fields
@@ -1024,7 +1037,7 @@ parseArgs jc tvMap tName opts
10241037 argTys' <- mapM resolveTypeSynonyms argTys
10251038 caseE (varE valName)
10261039 [ match (conP 'Object [varP obj]) (normalB $
1027− parseRecord jc tvMap argTys' opts tName conName fields obj) []
1040+ parseRecord jc tvMap argTys' opts tName conName fields obj False) []
10281041 , matchFailed tName conName "Object"
10291042 ]
10301043
@@ -1590,21 +1603,13 @@ type TyVarMap = Map Name (Name, Name)
15901603-- | Returns True if a Type has kind *.
15911604hasKindStar :: Type -> Bool
15921605hasKindStar VarT{} = True
1593−#if MIN_VERSION_template_haskell(2,8,0)
15941606hasKindStar (SigT _ StarT) = True
1595−#else
1596−hasKindStar (SigT _ StarK) = True
1597−#endif
15981607hasKindStar _ = False
15991608
16001609-- Returns True is a kind is equal to *, or if it is a kind variable.
16011610isStarOrVar :: Kind -> Bool
1602−#if MIN_VERSION_template_haskell(2,8,0)
16031611isStarOrVar StarT = True
16041612isStarOrVar VarT{} = True
1605−#else
1606−isStarOrVar StarK = True
1607−#endif
16081613isStarOrVar _ = False
16091614
16101615-- Generate a list of fresh names with a common prefix, and numbered suffixes.
@@ -1662,9 +1667,7 @@ isTyFamily (ConT n) = do
16621667#else
16631668 FamilyI (FamilyD TypeFam _ _ _) _ -> True
16641669#endif
1665−#if MIN_VERSION_template_haskell(2,9,0)
16661670 FamilyI ClosedTypeFamilyD{} _ -> True
1667−#endif
16681671 _ -> False
16691672isTyFamily _ = return False
16701673
@@ -1692,9 +1695,7 @@ mentionsName = go
16921695 go :: Type -> [Name] -> Bool
16931696 go (AppT t1 t2) names = go t1 names || go t2 names
16941697 go (SigT t _k) names = go t names
1695−#if MIN_VERSION_template_haskell(2,8,0)
16961698 || go _k names
1697−#endif
16981699 go (VarT n) names = n `elem` names
16991700 go _ _ = False
17001701
@@ -1750,23 +1751,14 @@ uncurryTy t = ([], t :| [])
17501751
17511752-- | Like uncurryType, except on a kind level.
17521753uncurryKind :: Kind -> NonEmpty Kind
1753−#if MIN_VERSION_template_haskell(2,8,0)
17541754uncurryKind = snd . uncurryTy
1755−#else
1756−uncurryKind (ArrowK k1 k2) = k1 <| uncurryKind k2
1757−uncurryKind k = k :| []
1758−#endif
17591755
17601756createKindChain :: Int -> Kind
17611757createKindChain = go starK
17621758 where
17631759 go :: Kind -> Int -> Kind
17641760 go k 0 = k
1765−#if MIN_VERSION_template_haskell(2,8,0)
17661761 go k !n = go (AppT (AppT ArrowT StarT) k) (n - 1)
1767−#else
1768− go k !n = go (ArrowK StarK k) (n - 1)
1769−#endif
17701762
17711763-- | Makes a string literal expression from a constructor's name.
17721764conNameExp :: Options -> ConstructorInfo -> Q Exp
@@ -1820,11 +1812,7 @@ canEtaReduce remaining dropped =
18201812-------------------------------------------------------------------------------
18211813
18221814applySubstitutionKind :: Map Name Kind -> Type -> Type
1823−#if MIN_VERSION_template_haskell(2,8,0)
18241815applySubstitutionKind = applySubstitution
1825−#else
1826−applySubstitutionKind _ t = t
1827−#endif
18281816
18291817substNameWithKind :: Name -> Kind -> Type -> Type
18301818substNameWithKind n k = applySubstitutionKind (M.singleton n k)
@@ -1988,9 +1976,7 @@ data StarKindStatus = NotKindStar
19881976canRealizeKindStar :: Type -> StarKindStatus
19891977canRealizeKindStar t = case t of
19901978 _ | hasKindStar t -> KindStar
1991−#if MIN_VERSION_template_haskell(2,8,0)
19921979 SigT _ (VarT k) -> IsKindVar k
1993−#endif
19941980 _ -> NotKindStar
19951981
19961982-- | Returns 'Just' the kind variable 'Name' of a 'StarKindStatus' if it exists.
Data/Aeson/Types.hs+3
@@ -124,6 +124,7 @@ module Data.Aeson.Types
124124 , sumEncoding
125125 , unwrapUnaryRecords
126126 , tagSingleConstructors
127+ , rejectUnknownFields
127128
128129 -- ** Options utilities
129130 , SumEncoding(..)
@@ -141,6 +142,8 @@ module Data.Aeson.Types
141142 , (<?>)
142143 , JSONPath
143144 , JSONPathElement(..)
145+ , formatPath
146+ , formatRelativePath
144147 ) where
145148
146149import Prelude.Compat
Data/Aeson/Types/FromJSON.hs+90−66
@@ -7,16 +7,14 @@
77{-# LANGUAGE MultiParamTypeClasses #-}
88{-# LANGUAGE NoImplicitPrelude #-}
99{-# LANGUAGE OverloadedStrings #-}
10+{-# LANGUAGE PolyKinds #-}
1011{-# LANGUAGE RecordWildCards #-}
1112{-# LANGUAGE ScopedTypeVariables #-}
1213{-# LANGUAGE TypeOperators #-}
14+{-# LANGUAGE TupleSections #-}
1315{-# LANGUAGE UndecidableInstances #-}
1416{-# LANGUAGE ViewPatterns #-}
1517
16−#if __GLASGOW_HASKELL__ >= 706
17−{-# LANGUAGE PolyKinds #-}
18−#endif
19−
2018#include "incoherent-compat.h"
2119#include "overlapping-compat.h"
2220
@@ -120,9 +118,9 @@ import GHC.Generics
120118import Numeric.Natural (Natural)
121119import Text.ParserCombinators.ReadP (readP_to_S)
122120import Unsafe.Coerce (unsafeCoerce)
123−import qualified Data.Aeson.Compat as Compat
124121import qualified Data.Aeson.Parser.Time as Time
125122import qualified Data.Attoparsec.ByteString.Char8 as A (endOfInput, parseOnly, scientific)
123+import qualified Data.ByteString.Lazy as L
126124import qualified Data.DList as DList
127125import qualified Data.HashMap.Strict as H
128126import qualified Data.HashSet as HashSet
@@ -157,18 +155,8 @@ import qualified Data.Primitive.UnliftedArray as PM
157155import qualified Data.Primitive.PrimArray as PM
158156#endif
159157
160−#ifndef HAS_COERCIBLE
161−#define HAS_COERCIBLE (__GLASGOW_HASKELL__ >= 707)
162−#endif
163158
164−#if HAS_COERCIBLE
165159import Data.Coerce (Coercible, coerce)
166−coerce' :: Coercible a b => a -> b
167−coerce' = coerce
168−#else
169−coerce' :: a -> b
170−coerce' = unsafeCoerce
171−#endif
172160
173161parseIndexedJSON :: (Value -> Parser a) -> Int -> Value -> Parser a
174162parseIndexedJSON p idx value = p value <?> Index idx
@@ -440,11 +428,7 @@ class FromJSONKey a where
440428-- At the moment this type is intentionally not exported. 'FromJSONKeyFunction'
441429-- can be inspected, but cannot be constructed.
442430data CoerceText a where
443−#if HAS_COERCIBLE
444431 CoerceText :: Coercible Text a => CoerceText a
445−#else
446− CoerceText :: CoerceText a
447−#endif
448432
449433-- | This type is related to 'ToJSONKeyFunction'. If 'FromJSONKeyValue' is used in the
450434-- 'FromJSONKey' instance, then 'ToJSONKeyValue' should be used in the 'ToJSONKey'
@@ -464,7 +448,7 @@ data FromJSONKeyFunction a
464448
465449-- | Only law abiding up to interpretation
466450instance Functor FromJSONKeyFunction where
467− fmap h (FromJSONKeyCoerce CoerceText) = FromJSONKeyText (h . coerce')
451+ fmap h (FromJSONKeyCoerce CoerceText) = FromJSONKeyText (h . coerce)
468452 fmap h (FromJSONKeyText f) = FromJSONKeyText (h . f)
469453 fmap h (FromJSONKeyTextParser f) = FromJSONKeyTextParser (fmap h . f)
470454 fmap h (FromJSONKeyValue f) = FromJSONKeyValue (fmap h . f)
@@ -478,9 +462,7 @@ instance Functor FromJSONKeyFunction where
478462--
479463-- On pre GHC 7.8 this is unconstrainted function.
480464fromJSONKeyCoerce ::
481−#if HAS_COERCIBLE
482465 Coercible Text a =>
483−#endif
484466 FromJSONKeyFunction a
485467fromJSONKeyCoerce = FromJSONKeyCoerce CoerceText
486468
@@ -488,29 +470,18 @@ fromJSONKeyCoerce = FromJSONKeyCoerce CoerceText
488470--
489471-- See note on 'fromJSONKeyCoerce'.
490472coerceFromJSONKeyFunction ::
491−#if HAS_COERCIBLE
492473 Coercible a b =>
493−#endif
494474 FromJSONKeyFunction a -> FromJSONKeyFunction b
495−#if HAS_COERCIBLE
496475coerceFromJSONKeyFunction = coerce
497−#else
498−coerceFromJSONKeyFunction (FromJSONKeyCoerce CoerceText) = FromJSONKeyCoerce CoerceText
499−coerceFromJSONKeyFunction (FromJSONKeyText f) = FromJSONKeyText (coerce' . f)
500−coerceFromJSONKeyFunction (FromJSONKeyTextParser f) = FromJSONKeyTextParser (fmap coerce' . f)
501−coerceFromJSONKeyFunction (FromJSONKeyValue f) = FromJSONKeyValue (fmap coerce' . f)
502−#endif
503476
504477{-# RULES
505478 "FromJSONKeyCoerce: fmap id" forall (x :: FromJSONKeyFunction a).
506479 fmap id x = x
507480 #-}
508−#if HAS_COERCIBLE
509481{-# RULES
510482 "FromJSONKeyCoerce: fmap coerce" forall x .
511483 fmap coerce x = coerceFromJSONKeyFunction x
512484 #-}
513−#endif
514485
515486-- | Same as 'fmap'. Provided for the consistency with 'ToJSONKeyFunction'.
516487mapFromJSONKeyFunction :: (a -> b) -> FromJSONKeyFunction a -> FromJSONKeyFunction b
@@ -797,13 +768,13 @@ withBoundedScientific' f v = withBoundedScientific_ id f v
797768-- | A variant of 'withBoundedScientific_' parameterized by a function to apply
798769-- to the 'Parser' in case of failure.
799770withBoundedScientific_ :: (Parser a -> Parser a) -> (Scientific -> Parser a) -> Value -> Parser a
800−withBoundedScientific_ whenFail f v@(Number scientific) =
801− if exponent > 1024
771+withBoundedScientific_ whenFail f (Number scientific) =
772+ if exp10 > 1024
802773 then whenFail (fail msg)
803774 else f scientific
804775 where
805− exponent = base10Exponent scientific
806− msg = "found a number with exponent " ++ show exponent ++ ", but it must not be greater than 1024"
776+ exp10 = base10Exponent scientific
777+ msg = "found a number with exponent " ++ show exp10 ++ ", but it must not be greater than 1024"
807778withBoundedScientific_ whenFail _ v =
808779 whenFail (typeMismatch "Number" v)
809780{-# INLINE withBoundedScientific_ #-}
@@ -823,7 +794,7 @@ withBool name _ v = prependContext name (typeMismatch "Boolean" v)
823794-- | Decode a nested JSON-encoded string.
824795withEmbeddedJSON :: String -> (Value -> Parser a) -> Value -> Parser a
825796withEmbeddedJSON _ innerParser (String txt) =
826− either fail innerParser $ eitherDecode (Compat.fromStrict $ T.encodeUtf8 txt)
797+ either fail innerParser $ eitherDecode (L.fromStrict $ T.encodeUtf8 txt)
827798 where
828799 eitherDecode = eitherFormatError . eitherDecodeWith jsonEOF ifromJSON
829800 eitherFormatError = either (Left . uncurry formatError) Right
@@ -892,7 +863,7 @@ parseFieldMaybe' = (.:!)
892863-- E.g. @'explicitParseField' 'parseJSON1' :: ('FromJSON1' f, 'FromJSON' a) -> 'Object' -> 'Text' -> 'Parser' (f a)@
893864explicitParseField :: (Value -> Parser a) -> Object -> Text -> Parser a
894865explicitParseField p obj key = case H.lookup key obj of
895− Nothing -> fail $ "key " ++ show key ++ " not present"
866+ Nothing -> fail $ "key " ++ show key ++ " not found"
896867 Just v -> p v <?> Key key
897868{-# INLINE explicitParseField #-}
898869
@@ -951,6 +922,16 @@ type ConName = String
951922contextType :: TypeName -> Parser a -> Parser a
952923contextType = prependContext
953924
925+-- | Add the tagKey that will be looked up while building an ADT
926+-- | Produce the error equivalent to
927+-- | Left "Error in $: parsing T failed, expected an object with keys "tag" and
928+-- | "contents", where "tag" i-- |s associated to one of ["Foo", "Bar"],
929+-- | The parser returned error was: could not find key "tag"
930+contextTag :: Text -> [String] -> Parser a -> Parser a
931+contextTag tagKey cnames = prependFailure
932+ ("expected Object with key \"" ++ unpack tagKey ++ "\"" ++
933+ " containing one of " ++ show cnames ++ ", ")
934+
954935-- | Add the name of the constructor being parsed to a parser's error messages.
955936contextCons :: ConName -> TypeName -> Parser a -> Parser a
956937contextCons cname tname = prependContext (showCons cname tname)
@@ -1129,8 +1110,8 @@ instance ConstructorNames a => ConstructorNames (D1 d a) where
11291110 retag (Tagged2 x) = Tagged2 x
11301111
11311112--------------------------------------------------------------------------------
1132−
1133−parseNonAllNullarySum :: ( FromPair arity f
1113+parseNonAllNullarySum :: forall f c arity.
1114+ ( FromPair arity f
11341115 , FromTaggedObject arity f
11351116 , FromUntaggedValue arity f
11361117 , ConstructorNames f
@@ -1140,7 +1121,7 @@ parseNonAllNullarySum p@(tname :* opts :* _) =
11401121 case sumEncoding opts of
11411122 TaggedObject{..} ->
11421123 withObject tname $ \obj -> do
1143− tag <- contextType tname $ obj .: tagKey
1124+ tag <- contextType tname . contextTag tagKey cnames_ $ obj .: tagKey
11441125 fromMaybe (badTag tag <?> Key tagKey) $
11451126 parseFromTaggedObject (tag :* contentsFieldName :* p) obj
11461127 where
@@ -1148,6 +1129,7 @@ parseNonAllNullarySum p@(tname :* opts :* _) =
11481129 badTag tag = failWith_ $ \cnames ->
11491130 "expected tag field to be one of " ++ show cnames ++
11501131 ", but found tag " ++ show tag
1132+ cnames_ = unTagged2 (constructorTags (constructorTagModifier opts) :: Tagged2 f [String])
11511133
11521134 ObjectWithSingleField ->
11531135 withObject tname $ \obj -> case H.toList obj of
@@ -1219,9 +1201,9 @@ class FromTaggedObject' arity f isRecord where
12191201 :: String :* ConName :* TypeName :* Options :* FromArgs arity a
12201202 -> Object -> Tagged isRecord (Parser (f a))
12211203
1222−instance (RecordFromJSON arity f) => FromTaggedObject' arity f True where
1204+instance (RecordFromJSON arity f, FieldNames f) => FromTaggedObject' arity f True where
12231205 -- Records are unpacked in the tagged object
1224− parseFromTaggedObject' (_ :* p) = Tagged . recordParseJSON p
1206+ parseFromTaggedObject' (_ :* p) = Tagged . recordParseJSON (True :* p)
12251207
12261208instance (ConsFromJSON arity f) => FromTaggedObject' arity f False where
12271209 -- Nonnullary nonrecords are encoded in the contents field
@@ -1262,11 +1244,11 @@ instance OVERLAPPING_
12621244 ) => ConsFromJSON' arity (S1 s a) True where
12631245 consParseJSON' p@(cname :* tname :* opts :* fargs)
12641246 | unwrapUnaryRecords opts = Tagged . fmap M1 . gParseJSON opts fargs
1265− | otherwise = Tagged . withObject (showCons cname tname) (recordParseJSON p)
1247+ | otherwise = Tagged . withObject (showCons cname tname) (recordParseJSON (False :* p))
12661248
12671249instance RecordFromJSON arity f => ConsFromJSON' arity f True where
12681250 consParseJSON' p@(cname :* tname :* _) =
1269− Tagged . withObject (showCons cname tname) (recordParseJSON p)
1251+ Tagged . withObject (showCons cname tname) (recordParseJSON (False :* p))
12701252
12711253instance OVERLAPPING_
12721254 ConsFromJSON' arity U1 False where
@@ -1292,21 +1274,55 @@ instance (ProductFromJSON arity f, ProductSize f
12921274
12931275--------------------------------------------------------------------------------
12941276
1277+class FieldNames f where
1278+ fieldNames :: f a -> [Text] -> [Text]
1279+
1280+instance (FieldNames a, FieldNames b) => FieldNames (a :*: b) where
1281+ fieldNames _ =
1282+ fieldNames (undefined :: a x) .
1283+ fieldNames (undefined :: b y)
1284+
1285+instance (Selector s) => FieldNames (S1 s f) where
1286+ fieldNames _ = (pack (selName (undefined :: M1 _i s _f _p)) :)
1287+
12951288class RecordFromJSON arity f where
12961289 recordParseJSON
1290+ :: Bool :* ConName :* TypeName :* Options :* FromArgs arity a
1291+ -> Object -> Parser (f a)
1292+
1293+instance ( FieldNames f
1294+ , RecordFromJSON' arity f
1295+ ) => RecordFromJSON arity f where
1296+ recordParseJSON (fromTaggedSum :* p@(cname :* tname :* opts :* _)) =
1297+ \obj -> checkUnknown obj >> recordParseJSON' p obj
1298+ where
1299+ knownFields :: H.HashMap Text ()
1300+ knownFields = H.fromList $ map (,()) $
1301+ fieldNames (undefined :: f a)
1302+ [pack (tagFieldName (sumEncoding opts)) | fromTaggedSum]
1303+ checkUnknown =
1304+ if not (rejectUnknownFields opts)
1305+ then \_ -> return ()
1306+ else \obj -> case H.keys (H.difference obj knownFields) of
1307+ [] -> return ()
1308+ unknownFields -> contextCons cname tname $
1309+ fail ("unknown fields: " ++ show unknownFields)
1310+
1311+class RecordFromJSON' arity f where
1312+ recordParseJSON'
12971313 :: ConName :* TypeName :* Options :* FromArgs arity a
12981314 -> Object -> Parser (f a)
12991315
1300−instance ( RecordFromJSON arity a
1301− , RecordFromJSON arity b
1302− ) => RecordFromJSON arity (a :*: b) where
1303− recordParseJSON p obj =
1304− (:*:) <$> recordParseJSON p obj
1305− <*> recordParseJSON p obj
1316+instance ( RecordFromJSON' arity a
1317+ , RecordFromJSON' arity b
1318+ ) => RecordFromJSON' arity (a :*: b) where
1319+ recordParseJSON' p obj =
1320+ (:*:) <$> recordParseJSON' p obj
1321+ <*> recordParseJSON' p obj
13061322
13071323instance OVERLAPPABLE_ (Selector s, GFromJSON arity a) =>
1308− RecordFromJSON arity (S1 s a) where
1309− recordParseJSON (cname :* tname :* opts :* fargs) obj = do
1324+ RecordFromJSON' arity (S1 s a) where
1325+ recordParseJSON' (cname :* tname :* opts :* fargs) obj = do
13101326 fv <- contextCons cname tname (obj .: label)
13111327 M1 <$> gParseJSON opts fargs fv <?> Key label
13121328 where
@@ -1314,16 +1330,16 @@ instance OVERLAPPABLE_ (Selector s, GFromJSON arity a) =>
13141330 sname = selName (undefined :: M1 _i s _f _p)
13151331
13161332instance INCOHERENT_ (Selector s, FromJSON a) =>
1317− RecordFromJSON arity (S1 s (K1 i (Maybe a))) where
1318− recordParseJSON (_ :* _ :* opts :* _) obj = M1 . K1 <$> obj .:? pack label
1333+ RecordFromJSON' arity (S1 s (K1 i (Maybe a))) where
1334+ recordParseJSON' (_ :* _ :* opts :* _) obj = M1 . K1 <$> obj .:? pack label
13191335 where
13201336 label = fieldLabelModifier opts sname
13211337 sname = selName (undefined :: M1 _i s _f _p)
13221338
13231339-- Parse an Option like a Maybe.
13241340instance INCOHERENT_ (Selector s, FromJSON a) =>
1325− RecordFromJSON arity (S1 s (K1 i (Semigroup.Option a))) where
1326− recordParseJSON p obj = wrap <$> recordParseJSON p obj
1341+ RecordFromJSON' arity (S1 s (K1 i (Semigroup.Option a))) where
1342+ recordParseJSON' p obj = wrap <$> recordParseJSON' p obj
13271343 where
13281344 wrap :: S1 s (K1 i (Maybe a)) p -> S1 s (K1 i (Semigroup.Option a)) p
13291345 wrap (M1 (K1 a)) = M1 (K1 (Semigroup.Option a))
@@ -1560,12 +1576,22 @@ instance FromJSONKey Float where
15601576 _ -> Scientific.toRealFloat <$> parseScientificText t
15611577
15621578instance (FromJSON a, Integral a) => FromJSON (Ratio a) where
1563− parseJSON = withObject "Rational" $ \obj -> do
1564− numerator <- obj .: "numerator"
1565− denominator <- obj .: "denominator"
1566− if denominator == 0
1567− then fail "Ratio denominator was 0"
1568− else pure $ numerator % denominator
1579+ parseJSON (Number x)
1580+ | exp10 <= 1024
1581+ , exp10 >= -1024 = return $! realToFrac x
1582+ | otherwise = prependContext "Ratio" $ fail msg
1583+ where
1584+ exp10 = base10Exponent x
1585+ msg = "found a number with exponent " ++ show exp10
1586+ ++ ", but it must not be greater than 1024 or less than -1024"
1587+ parseJSON o = objParser o
1588+ where
1589+ objParser = withObject "Rational" $ \obj -> do
1590+ numerator <- obj .: "numerator"
1591+ denominator <- obj .: "denominator"
1592+ if denominator == 0
1593+ then fail "Ratio denominator was 0"
1594+ else pure $ numerator % denominator
15691595 {-# INLINE parseJSON #-}
15701596
15711597-- | This instance includes a bounds check to prevent maliciously
@@ -1980,7 +2006,6 @@ instance FromJSON DotNetTime where
19802006-- primitive
19812007-------------------------------------------------------------------------------
19822008
1983−#if MIN_VERSION_base(4,7,0)
19842009instance FromJSON a => FromJSON (PM.Array a) where
19852010 -- note: we could do better than this if vector exposed the data
19862011 -- constructor in Data.Vector.
@@ -1998,7 +2023,6 @@ instance (PM.PrimUnlifted a,FromJSON a) => FromJSON (PM.UnliftedArray a) where
19982023 parseJSON = fmap Exts.fromList . parseJSON
19992024#endif
20002025#endif
2001−#endif
20022026
20032027-------------------------------------------------------------------------------
20042028-- time
Data/Aeson/Types/Internal.hs+22−2
@@ -49,6 +49,8 @@ module Data.Aeson.Types.Internal
4949 , parserThrowError
5050 , parserCatchError
5151 , formatError
52+ , formatPath
53+ , formatRelativePath
5254 , (<?>)
5355 -- * Constructors and accessors
5456 , object
@@ -62,6 +64,7 @@ module Data.Aeson.Types.Internal
6264 , sumEncoding
6365 , unwrapUnaryRecords
6466 , tagSingleConstructors
67+ , rejectUnknownFields
6568 )
6669
6770 , SumEncoding(..)
@@ -458,7 +461,17 @@ parseEither m v = runParser (m v) [] onError Right
458461-- | Annotate an error message with a
459462-- <http://goessner.net/articles/JsonPath/ JSONPath> error location.
460463formatError :: JSONPath -> String -> String
461−formatError path msg = "Error in " ++ format "$" path ++ ": " ++ msg
464+formatError path msg = "Error in " ++ formatPath path ++ ": " ++ msg
465+
466+-- | Format a <http://goessner.net/articles/JsonPath/ JSONPath> as a 'String',
467+-- representing the root object as @$@.
468+formatPath :: JSONPath -> String
469+formatPath path = "$" ++ formatRelativePath path
470+
471+-- | Format a <http://goessner.net/articles/JsonPath/ JSONPath> as a 'String'
472+-- which represents the path relative to some root object.
473+formatRelativePath :: JSONPath -> String
474+formatRelativePath path = format "" path
462475 where
463476 format :: String -> JSONPath -> String
464477 format pfx [] = pfx
@@ -612,10 +625,14 @@ data Options = Options
612625 , tagSingleConstructors :: Bool
613626 -- ^ Encode types with a single constructor as sums,
614627 -- so that `allNullaryToStringTag` and `sumEncoding` apply.
628+ , rejectUnknownFields :: Bool
629+ -- ^ Applies only to 'Data.Aeson.FromJSON' instances. If a field appears in
630+ -- the parsed object map, but does not appear in the target object, parsing
631+ -- will fail, with an error message indicating which fields were unknown.
615632 }
616633
617634instance Show Options where
618− show (Options f c a o s u t) =
635+ show (Options f c a o s u t r) =
619636 "Options {"
620637 ++ intercalate ", "
621638 [ "fieldLabelModifier =~ " ++ show (f "exampleField")
@@ -625,6 +642,7 @@ instance Show Options where
625642 , "sumEncoding = " ++ show s
626643 , "unwrapUnaryRecords = " ++ show u
627644 , "tagSingleConstructors = " ++ show t
645+ , "rejectUnknownFields = " ++ show r
628646 ]
629647 ++ "}"
630648
@@ -706,6 +724,7 @@ data JSONKeyOptions = JSONKeyOptions
706724-- , 'sumEncoding' = 'defaultTaggedObject'
707725-- , 'unwrapUnaryRecords' = False
708726-- , 'tagSingleConstructors' = False
727+-- , 'rejectUnknownFields' = False
709728-- }
710729-- @
711730defaultOptions :: Options
@@ -717,6 +736,7 @@ defaultOptions = Options
717736 , sumEncoding = defaultTaggedObject
718737 , unwrapUnaryRecords = False
719738 , tagSingleConstructors = False
739+ , rejectUnknownFields = False
720740 }
721741
722742-- | Default 'TaggedObject' 'SumEncoding' options:
Data/Aeson/Types/ToJSON.hs+3−42
@@ -8,15 +8,12 @@
88{-# LANGUAGE NoImplicitPrelude #-}
99{-# LANGUAGE OverloadedStrings #-}
1010{-# LANGUAGE PatternGuards #-}
11+{-# LANGUAGE PolyKinds #-}
1112{-# LANGUAGE RecordWildCards #-}
1213{-# LANGUAGE ScopedTypeVariables #-}
1314{-# LANGUAGE TypeOperators #-}
1415{-# LANGUAGE UndecidableInstances #-}
1516
16−#if __GLASGOW_HASKELL__ >= 706
17−{-# LANGUAGE PolyKinds #-}
18−#endif
19−
2017#include "overlapping-compat.h"
2118#include "incoherent-compat.h"
2219
@@ -103,7 +100,6 @@ import GHC.Generics
103100import Numeric.Natural (Natural)
104101import qualified Data.Aeson.Encoding as E
105102import qualified Data.Aeson.Encoding.Internal as E (InArray, comma, econcat, retagEncoding)
106−import qualified Data.ByteString as S
107103import qualified Data.ByteString.Lazy as L
108104import qualified Data.DList as DList
109105import qualified Data.HashMap.Strict as H
@@ -144,14 +140,6 @@ import qualified Data.Primitive.UnliftedArray as PM
144140import qualified Data.Primitive.PrimArray as PM
145141#endif
146142
147−#if !(MIN_VERSION_bytestring(0,10,0))
148−import Foreign.ForeignPtr (withForeignPtr)
149−import Foreign.Marshal.Utils (copyBytes)
150−import Foreign.Ptr (plusPtr)
151−import qualified Data.ByteString.Internal as S
152−import qualified Data.ByteString.Lazy.Internal as L
153−#endif
154−
155143toJSONPair :: (a -> Value) -> (b -> Value) -> (a, b) -> Value
156144toJSONPair a b = liftToJSON2 a (listValue a) b (listValue b)
157145{-# INLINE toJSONPair #-}
@@ -515,7 +503,7 @@ toJSONKeyTextEnc e = ToJSONKeyText tot e
515503 -- TODO: dropAround is also used in stringEncoding, which is unfortunate atm
516504 tot = T.dropAround (== '"')
517505 . T.decodeLatin1
518− . lazyToStrictByteString
506+ . L.toStrict
519507 . E.encodingToLazyByteString
520508 . e
521509
@@ -1982,7 +1970,6 @@ formatMillis = take 3 . formatTime defaultTimeLocale "%q"
19821970-- primitive
19831971-------------------------------------------------------------------------------
19841972
1985−#if MIN_VERSION_base(4,7,0)
19861973instance ToJSON a => ToJSON (PM.Array a) where
19871974 -- note: we could do better than this if vector exposed the data
19881975 -- constructor in Data.Vector.
@@ -2004,7 +1991,6 @@ instance (PM.PrimUnlifted a,ToJSON a) => ToJSON (PM.UnliftedArray a) where
20041991 toEncoding = toEncoding . Exts.toList
20051992#endif
20061993#endif
2007−#endif
20081994
20091995-------------------------------------------------------------------------------
20101996-- time
@@ -2054,7 +2040,7 @@ stringEncoding :: Encoding' Text -> Value
20542040stringEncoding = String
20552041 . T.dropAround (== '"')
20562042 . T.decodeLatin1
2057− . lazyToStrictByteString
2043+ . L.toStrict
20582044 . E.encodingToLazyByteString
20592045{-# INLINE stringEncoding #-}
20602046
@@ -2861,31 +2847,6 @@ instance (ToJSON a, ToJSON b, ToJSON c, ToJSON d, ToJSON e, ToJSON f, ToJSON g,
28612847 toEncoding = toEncoding2
28622848 {-# INLINE toEncoding #-}
28632849
2864−-------------------------------------------------------------------------------
2865−-- pre-bytestring-0.10 compatibility
2866−-------------------------------------------------------------------------------
2867−
2868−{-# INLINE lazyToStrictByteString #-}
2869−lazyToStrictByteString :: L.ByteString -> S.ByteString
2870−#if MIN_VERSION_bytestring(0,10,0)
2871−lazyToStrictByteString = L.toStrict
2872−#else
2873−lazyToStrictByteString = packChunks
2874−
2875−-- packChunks is taken from the blaze-builder package.
2876−
2877−-- | Pack the chunks of a lazy bytestring into a single strict bytestring.
2878−packChunks :: L.ByteString -> S.ByteString
2879−packChunks lbs =
2880− S.unsafeCreate (fromIntegral $ L.length lbs) (copyChunks lbs)
2881− where
2882− copyChunks L.Empty _pf = return ()
2883− copyChunks (L.Chunk (S.PS fpbuf o l) lbs') pf = do
2884− withForeignPtr fpbuf $ \pbuf ->
2885− copyBytes pf (pbuf `plusPtr` o) l
2886− copyChunks lbs' (pf `plusPtr` l)
2887−#endif
2888−
28892850--------------------------------------------------------------------------------
28902851
28912852-- | Wrap a list of pairs as an object.
aeson.cabal+7−13
@@ -1,5 +1,5 @@
11name: aeson
2−version: 1.4.5.0
2+version: 1.4.6.0
33license: BSD3
44license-file: LICENSE
55category: Text, Web, JSON
@@ -88,7 +88,6 @@ library
8888 Data.Aeson.Encode
8989
9090 other-modules:
91− Data.Aeson.Compat
9291 Data.Aeson.Encoding.Builder
9392 Data.Aeson.Internal.Functions
9493 Data.Aeson.Parser.Unescape
@@ -103,11 +102,12 @@ library
103102
104103 -- GHC bundled libs
105104 build-depends:
106− base >= 4.5.0.0 && < 5,
107− containers >= 0.4.2.1 && < 0.7,
105+ base >= 4.7.0.0 && < 5,
106+ bytestring >= 0.10.4.0 && < 0.11,
107+ containers >= 0.5.5.1 && < 0.7,
108108 deepseq >= 1.3.0.0 && < 1.5,
109109 ghc-prim >= 0.2 && < 0.6,
110− template-haskell >= 2.7.0.0 && < 2.16,
110+ template-haskell >= 2.9.0.0 && < 2.16,
111111 text >= 1.2.3.0 && < 1.3,
112112 time >= 1.4 && < 1.10
113113
@@ -119,12 +119,6 @@ library
119119 base-compat >= 0.9.1 && < 0.12,
120120 time-compat >= 1.9.2.2 && < 1.10
121121
122− if flag(bytestring-builder)
123− build-depends: bytestring >= 0.9.2.1 && < 0.10.4,
124− bytestring-builder >= 0.10.4 && < 1
125− else
126− build-depends: bytestring >= 0.10.4 && < 0.11
127−
128122 if !impl(ghc >= 8.6)
129123 build-depends:
130124 contravariant >=1.4.1 && <1.6
@@ -225,9 +219,9 @@ test-suite tests
225219 containers,
226220 directory,
227221 dlist,
228− Diff,
222+ Diff >= 0.4 && < 0.5,
229223 filepath,
230− generic-deriving >= 1.10 && < 1.13,
224+ generic-deriving >= 1.10 && < 1.14,
231225 ghc-prim >= 0.2,
232226 hashable >= 1.2.4.0,
233227 scientific,
attoparsec-iso8601/Data/Attoparsec/Time/Internal.hs−20
@@ -29,16 +29,8 @@ import Data.Time.Clock (diffTimeToPicoseconds)
2929
3030#endif
3131
32−#if MIN_VERSION_base(4,7,0)
33−
3432import Data.Fixed (Pico, Fixed(MkFixed))
3533
36−#else
37−
38−import Data.Fixed (Pico)
39−
40−#endif
41−
4234#if !MIN_VERSION_time(1,6,0)
4335
4436diffTimeToPicoseconds :: DiffTime -> Integer
@@ -46,24 +38,12 @@ diffTimeToPicoseconds = unsafeCoerce
4638
4739#endif
4840
49−#if MIN_VERSION_base(4,7,0)
50−
5141toPico :: Integer -> Pico
5242toPico = MkFixed
5343
5444fromPico :: Pico -> Integer
5545fromPico (MkFixed i) = i
5646
57−#else
58−
59−toPico :: Integer -> Pico
60−toPico = unsafeCoerce
61−
62−fromPico :: Pico -> Integer
63−fromPico = unsafeCoerce
64−
65−#endif
66−
6747-- | Like TimeOfDay, but using a fixed-width integer for seconds.
6848data TimeOfDay64 = TOD {-# UNPACK #-} !Int
6949 {-# UNPACK #-} !Int
attoparsec-iso8601/attoparsec-iso8601.cabal+1−1
@@ -36,7 +36,7 @@ library
3636 Data.Attoparsec.Time
3737 build-depends:
3838 attoparsec >= 0.13.0.1,
39− base >= 4.5 && < 5,
39+ base >= 4.7 && < 5,
4040 base-compat >= 0.9.1 && < 0.12,
4141 text >= 1.1.1.0,
4242 time >= 1.1.1.4
benchmarks/aeson-benchmarks.cabal−1
@@ -72,7 +72,6 @@ library
7272
7373 exposed-modules:
7474 Data.Aeson
75− Data.Aeson.Compat
7675 Data.Aeson.Encoding
7776 Data.Aeson.Encoding.Builder
7877 Data.Aeson.Encoding.Internal
cabal.project+1
@@ -2,3 +2,4 @@ with-compiler: ghc
22packages: .
33packages: attoparsec-iso8601
44-- packages: benchmarks
5+tests: true
changelog.md+13
@@ -1,5 +1,18 @@
11For the latest version of this document, please see [https://github.com/bos/aeson/blob/master/changelog.md](https://github.com/bos/aeson/blob/master/changelog.md).
22
3+### upcoming
4+
5+* `FromJSON` instance of `Ratio a` now parses numbers in addtion to
6+ standard `{numerator=..., denumerator=...}` encoding.
7+
8+### 1.4.6.0
9+
10+* Provide a clearer error message when a required tagKey for a constructor is missing, thanks to Guru Devanla.
11+ The error message now looks like this: `Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found`
12+
13+* Add `formatPath` and `formatRelativePath` functions to turn a `JSONPath` into a `String`, thanks to Robbie McMichael
14+
15+
316### 1.4.5.0
417
518* Expose `(<?>)`, `JSONPath` and `JSONPathElement(..)` from `Data.Aeson.Types`. Previously only available through internal modules. Thanks to Luke Clifton.
stack-bench.yaml+2−8
@@ -1,4 +1,4 @@
1−resolver: lts-12.26
1+resolver: nightly-2019-09-21
22# We use aeson in the snapshot to
33# - avoid recompilation of criterion
44# - compare against it
@@ -9,10 +9,4 @@ resolver: lts-12.26
99work-dir: .stack-work-bench
1010packages:
1111- benchmarks
12−extra-deps:
13−- base-orphans-0.8.1
14−- hashable-time-0.2.0.1
15−- QuickCheck-2.13.1
16−- quickcheck-instances-0.3.21
17−- splitmix-0.0.2
18−- time-compat-1.9.2.2
12+extra-deps: []
stack-ffi-unescape.yaml+2−7
@@ -1,4 +1,4 @@
1−resolver: lts-12.26
1+resolver: nightly-2019-09-21
22packages:
33- '.'
44flags:
@@ -6,9 +6,4 @@ flags:
66 fast: true
77 cffi: true
88extra-deps:
9−- base-orphans-0.8.1
10−- hashable-time-0.2.0.1
11−- QuickCheck-2.13.1
12−- quickcheck-instances-0.3.21
13−- splitmix-0.0.2
14−- time-compat-1.9.2.2
9+- Diff-0.4.0
stack-nightly.yaml+2−4
@@ -1,4 +1,4 @@
1−resolver: nightly-2019-05-13
1+resolver: nightly-2019-10-14
22packages:
33- '.'
44- attoparsec-iso8601
@@ -8,6 +8,4 @@ flags:
88 attoparsec-iso8601:
99 fast: true
1010extra-deps:
11−- hlint-2.1.18
12−- time-compat-1.9.2.2
13−- quickcheck-instances-0.3.21
11+- generic-deriving-1.12.4
tests/Encoders.hs+25−6
@@ -188,7 +188,6 @@ gSomeTypeToEncoding2ElemArray = genericToEncoding opts2ElemArray
188188gSomeTypeParseJSON2ElemArray :: Value -> Parser (SomeType Int)
189189gSomeTypeParseJSON2ElemArray = genericParseJSON opts2ElemArray
190190
191−#if __GLASGOW_HASKELL__ >= 706
192191gSomeTypeLiftToEncoding2ElemArray :: LiftToEncoding SomeType a
193192gSomeTypeLiftToEncoding2ElemArray = genericLiftToEncoding opts2ElemArray
194193
@@ -197,7 +196,6 @@ gSomeTypeLiftToJSON2ElemArray = genericLiftToJSON opts2ElemArray
197196
198197gSomeTypeLiftParseJSON2ElemArray :: LiftParseJSON SomeType a
199198gSomeTypeLiftParseJSON2ElemArray = genericLiftParseJSON opts2ElemArray
200−#endif
201199
202200
203201gSomeTypeToJSONTaggedObject :: SomeType Int -> Value
@@ -209,7 +207,6 @@ gSomeTypeToEncodingTaggedObject = genericToEncoding optsTaggedObject
209207gSomeTypeParseJSONTaggedObject :: Value -> Parser (SomeType Int)
210208gSomeTypeParseJSONTaggedObject = genericParseJSON optsTaggedObject
211209
212−#if __GLASGOW_HASKELL__ >= 706
213210gSomeTypeLiftToEncodingTaggedObject :: LiftToEncoding SomeType a
214211gSomeTypeLiftToEncodingTaggedObject = genericLiftToEncoding optsTaggedObject
215212
@@ -218,7 +215,6 @@ gSomeTypeLiftToJSONTaggedObject = genericLiftToJSON optsTaggedObject
218215
219216gSomeTypeLiftParseJSONTaggedObject :: LiftParseJSON SomeType a
220217gSomeTypeLiftParseJSONTaggedObject = genericLiftParseJSON optsTaggedObject
221−#endif
222218
223219
224220gSomeTypeToJSONObjectWithSingleField :: SomeType Int -> Value
@@ -230,7 +226,6 @@ gSomeTypeToEncodingObjectWithSingleField = genericToEncoding optsObjectWithSingl
230226gSomeTypeParseJSONObjectWithSingleField :: Value -> Parser (SomeType Int)
231227gSomeTypeParseJSONObjectWithSingleField = genericParseJSON optsObjectWithSingleField
232228
233−#if __GLASGOW_HASKELL__ >= 706
234229gSomeTypeLiftToEncodingObjectWithSingleField :: LiftToEncoding SomeType a
235230gSomeTypeLiftToEncodingObjectWithSingleField = genericLiftToEncoding optsObjectWithSingleField
236231
@@ -239,7 +234,6 @@ gSomeTypeLiftToJSONObjectWithSingleField = genericLiftToJSON optsObjectWithSingl
239234
240235gSomeTypeLiftParseJSONObjectWithSingleField :: LiftParseJSON SomeType a
241236gSomeTypeLiftParseJSONObjectWithSingleField = genericLiftParseJSON optsObjectWithSingleField
242−#endif
243237
244238
245239gSomeTypeToJSONOmitNothingFields :: SomeType Int -> Value
@@ -249,6 +243,31 @@ gSomeTypeToEncodingOmitNothingFields :: SomeType Int -> Encoding
249243gSomeTypeToEncodingOmitNothingFields = genericToEncoding optsOmitNothingFields
250244
251245
246+thSomeTypeParseJSONRejectUnknownFields :: Value -> Parser (SomeType Int)
247+thSomeTypeParseJSONRejectUnknownFields = $(mkParseJSON optsRejectUnknownFields ''SomeType)
248+
249+gSomeTypeParseJSONRejectUnknownFields :: Value -> Parser (SomeType Int)
250+gSomeTypeParseJSONRejectUnknownFields = genericParseJSON optsRejectUnknownFields
251+
252+
253+--------------------------------------------------------------------------------
254+-- Foo decoders
255+--------------------------------------------------------------------------------
256+
257+thFooParseJSONRejectUnknownFields :: Value -> Parser Foo
258+thFooParseJSONRejectUnknownFields = $(mkParseJSON optsRejectUnknownFields ''Foo)
259+
260+gFooParseJSONRejectUnknownFields :: Value -> Parser Foo
261+gFooParseJSONRejectUnknownFields = genericParseJSON optsRejectUnknownFields
262+
263+
264+thFooParseJSONRejectUnknownFieldsTagged :: Value -> Parser Foo
265+thFooParseJSONRejectUnknownFieldsTagged = $(mkParseJSON optsRejectUnknownFieldsTagged ''Foo)
266+
267+gFooParseJSONRejectUnknownFieldsTagged :: Value -> Parser Foo
268+gFooParseJSONRejectUnknownFieldsTagged = genericParseJSON optsRejectUnknownFieldsTagged
269+
270+
252271--------------------------------------------------------------------------------
253272-- Option fields
254273--------------------------------------------------------------------------------
tests/ErrorMessages.hs+27−1
@@ -13,7 +13,7 @@ import Data.Aeson (FromJSON(..), Value, json)
1313import Data.Aeson.Types (Parser)
1414import Data.Aeson.Parser (eitherDecodeWith)
1515import Data.Aeson.Internal (formatError, iparse)
16−import Data.Algorithm.Diff (Diff(..), getGroupedDiff)
16+import Data.Algorithm.Diff (PolyDiff (..), getGroupedDiff)
1717import Data.Proxy (Proxy(..))
1818import Data.Semigroup ((<>))
1919import Data.Sequence (Seq)
@@ -136,6 +136,29 @@ outputGeneric choice = concat
136136 , "[1,"
137137 ]
138138
139+ , testWithSomeType "SomeType (reject unknown fields)"
140+ (select
141+ thSomeTypeParseJSONRejectUnknownFields
142+ gSomeTypeParseJSONRejectUnknownFields)
143+ [ "{\"tag\": \"record\", \"testOne\": 1.0, \"testZero\": 1}"
144+ , "{\"testZero\": 1}"
145+ , "{\"tag\": \"record\", \"testone\": true, \"testtwo\": null, \"testthree\": null}"
146+ ]
147+
148+ , testWithFoo "Foo (reject unknown fields)"
149+ (select
150+ thFooParseJSONRejectUnknownFields
151+ gFooParseJSONRejectUnknownFields)
152+ [ "{\"tag\": \"foo\"}"
153+ ]
154+
155+ , testWithFoo "Foo (reject unknown fields, tagged single)"
156+ (select
157+ thFooParseJSONRejectUnknownFieldsTagged
158+ gFooParseJSONRejectUnknownFieldsTagged)
159+ [ "{\"tag\": \"foo\", \"unknownField\": 0}"
160+ ]
161+
139162 , testWith "EitherTextInt"
140163 (select
141164 thEitherTextIntParseJSONUntaggedValue
@@ -196,3 +219,6 @@ testFor name _ = testWith name (parseJSON :: Value -> Parser a)
196219
197220testWithSomeType :: String -> (Value -> Parser (SomeType Int)) -> [L.ByteString] -> Output
198221testWithSomeType = testWith
222+
223+testWithFoo :: String -> (Value -> Parser Foo) -> [L.ByteString] -> Output
224+testWithFoo = testWith
tests/Instances.hs+1−4
@@ -1,4 +1,3 @@
1−{-# LANGUAGE CPP #-}
21{-# LANGUAGE FlexibleContexts #-}
32{-# LANGUAGE FlexibleInstances #-}
43{-# LANGUAGE NoImplicitPrelude #-}
@@ -25,14 +24,12 @@ import qualified Data.HashMap.Strict as HM
2524
2625import Data.Orphans ()
2726import Test.QuickCheck.Instances ()
28−#if MIN_VERSION_base(4,7,0)
2927import Data.Hashable.Time ()
30−#endif
3128
3229-- "System" types.
3330
3431instance Arbitrary DotNetTime where
35− arbitrary = DotNetTime `liftM` arbitrary
32+ arbitrary = DotNetTime `fmap` arbitrary
3633 shrink = map DotNetTime . shrink . fromDotNetTime
3734
3835-- | Compare timezone part only on 'timeZoneMinutes'
tests/Options.hs+11
@@ -55,3 +55,14 @@ optsOptionField = optsDefault
5555 { fieldLabelModifier = const "field"
5656 , omitNothingFields = True
5757 }
58+
59+optsRejectUnknownFields :: Options
60+optsRejectUnknownFields = optsDefault
61+ { rejectUnknownFields = True
62+ }
63+
64+optsRejectUnknownFieldsTagged :: Options
65+optsRejectUnknownFieldsTagged = optsDefault
66+ { rejectUnknownFields = True
67+ , tagSingleConstructors = True
68+ }
tests/PropertyGeneric.hs−8
@@ -44,11 +44,9 @@ genericTests =
4444 , testProperty "TaggedObject" (toParseJSON gSomeTypeParseJSONTaggedObject gSomeTypeToJSONTaggedObject)
4545 , testProperty "ObjectWithSingleField" (toParseJSON gSomeTypeParseJSONObjectWithSingleField gSomeTypeToJSONObjectWithSingleField)
4646
47−#if __GLASGOW_HASKELL__ >= 706
4847 , testProperty "2ElemArray unary" (toParseJSON1 gSomeTypeLiftParseJSON2ElemArray gSomeTypeLiftToJSON2ElemArray)
4948 , testProperty "TaggedObject unary" (toParseJSON1 gSomeTypeLiftParseJSONTaggedObject gSomeTypeLiftToJSONTaggedObject)
5049 , testProperty "ObjectWithSingleField unary" (toParseJSON1 gSomeTypeLiftParseJSONObjectWithSingleField gSomeTypeLiftToJSONObjectWithSingleField)
51−#endif
5250 ]
5351 ]
5452 , testGroup "OneConstructor" [
@@ -85,30 +83,24 @@ genericTests =
8583
8684 , testProperty "SomeType2ElemArray" $
8785 gSomeTypeToJSON2ElemArray `sameAs` gSomeTypeToEncoding2ElemArray
88−#if __GLASGOW_HASKELL__ >= 706
8986 , testProperty "SomeType2ElemArray unary" $
9087 gSomeTypeLiftToJSON2ElemArray `sameAs1` gSomeTypeLiftToEncoding2ElemArray
9188 , testProperty "SomeType2ElemArray unary agree" $
9289 gSomeTypeToEncoding2ElemArray `sameAs1Agree` gSomeTypeLiftToEncoding2ElemArray
93−#endif
9490
9591 , testProperty "SomeTypeTaggedObject" $
9692 gSomeTypeToJSONTaggedObject `sameAs` gSomeTypeToEncodingTaggedObject
97−#if __GLASGOW_HASKELL__ >= 706
9893 , testProperty "SomeTypeTaggedObject unary" $
9994 gSomeTypeLiftToJSONTaggedObject `sameAs1` gSomeTypeLiftToEncodingTaggedObject
10095 , testProperty "SomeTypeTaggedObject unary agree" $
10196 gSomeTypeToEncodingTaggedObject `sameAs1Agree` gSomeTypeLiftToEncodingTaggedObject
102−#endif
10397
10498 , testProperty "SomeTypeObjectWithSingleField" $
10599 gSomeTypeToJSONObjectWithSingleField `sameAs` gSomeTypeToEncodingObjectWithSingleField
106−#if __GLASGOW_HASKELL__ >= 706
107100 , testProperty "SomeTypeObjectWithSingleField unary" $
108101 gSomeTypeLiftToJSONObjectWithSingleField `sameAs1` gSomeTypeLiftToEncodingObjectWithSingleField
109102 , testProperty "SomeTypeObjectWithSingleField unary agree" $
110103 gSomeTypeToEncodingObjectWithSingleField `sameAs1Agree` gSomeTypeLiftToEncodingObjectWithSingleField
111−#endif
112104
113105 , testProperty "SomeTypeOmitNothingFields" $
114106 gSomeTypeToJSONOmitNothingFields `sameAs` gSomeTypeToEncodingOmitNothingFields
tests/PropertyKeys.hs−3
@@ -1,4 +1,3 @@
1−{-# LANGUAGE CPP #-}
21{-# LANGUAGE NoImplicitPrelude #-}
32
43module PropertyKeys ( keysTests ) where
@@ -31,12 +30,10 @@ keysTests =
3130 , testProperty "Natural" $ roundTripKey (undefined :: Natural)
3231 , testProperty "Float" $ roundTripKey (undefined :: Float)
3332 , testProperty "Double" $ roundTripKey (undefined :: Double)
34−#if MIN_VERSION_base(4,7,0)
3533 , testProperty "Day" $ roundTripKey (undefined :: Day)
3634 , testProperty "LocalTime" $ roundTripKey (undefined :: LocalTime)
3735 , testProperty "TimeOfDay" $ roundTripKey (undefined :: TimeOfDay)
3836 , testProperty "UTCTime" $ roundTripKey (undefined :: UTCTime)
39−#endif
4037 , testProperty "Version" $ roundTripKey (undefined :: Version)
4138 , testProperty "Lazy Text" $ roundTripKey (undefined :: LT.Text)
4239 , testProperty "UUID" $ roundTripKey UUID.nil
tests/SerializationFormatSpec.hs−4
@@ -3,9 +3,7 @@
33{-# LANGUAGE GADTs #-}
44{-# LANGUAGE NoImplicitPrelude #-}
55{-# LANGUAGE OverloadedStrings #-}
6−#if __GLASGOW_HASKELL__ >= 708
76{-# LANGUAGE DataKinds #-}
8−#endif
97
108------------------------------------------------------------------------------
119-- These tests assert that the JSON serialization doesn't change by accident.
@@ -77,10 +75,8 @@ jsonExamples =
7775 , example "Just" "1" (Just 1 :: Maybe Int)
7876 , example "Proxy Int" "null" (Proxy :: Proxy Int)
7977 , example "Tagged Char Int" "1" (Tagged 1 :: Tagged Char Int)
80−#if __GLASGOW_HASKELL__ >= 708
8178 -- Test Tagged instance is polykinded
8279 , example "Tagged 123 Int" "1" (Tagged 1 :: Tagged 123 Int)
83−#endif
8480 , example "Const Char Int" "\"c\"" (Const 'c' :: Const Char Int)
8581 , example "Tuple" "[1,2]" ((1, 2) :: (Int, Int))
8682 , example "NonEmpty" "[1,2,3]" (1 :| [2, 3] :: NonEmpty Int)
tests/Types.hs−2
@@ -119,9 +119,7 @@ deriving instance Generic (Sum4 a b c d)
119119deriving instance Generic (Approx a)
120120deriving instance Generic Nullary
121121deriving instance Generic (SomeType a)
122−#if __GLASGOW_HASKELL__ >= 706
123122deriving instance Generic1 SomeType
124−#endif
125123deriving instance Generic OptionField
126124deriving instance Generic EitherTextInt
127125
tests/UnitTests.hs+118−3
@@ -33,14 +33,15 @@ import Data.Aeson.Parser
3333 ( json, jsonLast, jsonAccum, jsonNoDup
3434 , json', jsonLast', jsonAccum', jsonNoDup')
3535import Data.Aeson.Types
36− ( Options(..), Result(Success), ToJSON(..), Value(Array, Bool, Null, Object)
37− , camelTo, camelTo2, defaultOptions, omitNothingFields, parse)
36+ ( Options(..), Result(Success, Error), ToJSON(..)
37+ , Value(Array, Bool, Null, Number, Object, String), camelTo, camelTo2
38+ , defaultOptions, formatPath, formatRelativePath, omitNothingFields, parse)
3839import Data.Attoparsec.ByteString (Parser, parseOnly)
3940import Data.Char (toUpper)
4041import Data.Either.Compat (isLeft, isRight)
4142import Data.Hashable (hash)
4243import Data.HashMap.Strict (HashMap)
43−import Data.List (sort)
44+import Data.List (sort, isSuffixOf)
4445import Data.Maybe (fromMaybe)
4546import Data.Scientific (Scientific, scientific)
4647import Data.Tagged (Tagged(..))
@@ -111,8 +112,12 @@ tests = testGroup "unit" [
111112 , testGroup "SingleMaybeField" singleMaybeField
112113 , testCase "withEmbeddedJSON" withEmbeddedJSONTest
113114 , testCase "SingleFieldCon" singleFieldCon
115+ , testGroup "UnknownFields" unknownFields
114116 , testGroup "Ordering of object keys" keyOrdering
115117 , testCase "Ratio with denominator 0" ratioDenominator0
118+ , testCase "Rational parses number" rationalNumber
119+ , testCase "Big rational" bigRationalDecoding
120+ , testCase "Small rational" smallRationalDecoding
116121 , testCase "Big scientific exponent" bigScientificExponent
117122 , testCase "Big integer decoding" bigIntegerDecoding
118123 , testCase "Big natural decading" bigNaturalDecoding
@@ -253,6 +258,18 @@ formatErrorExample =
253258 lhs = "Error in $[0].foo.bar['a.b.c']['']['\\'\\\\'].end: error msg"
254259 in assertEqual "formatError example" lhs rhs
255260
261+formatPathExample :: Assertion
262+formatPathExample =
263+ let rhs = formatPath [Key "x", Index 0]
264+ lhs = "$.x[0]"
265+ in assertEqual "formatPath example" lhs rhs
266+
267+formatRelativePathExample :: Assertion
268+formatRelativePathExample =
269+ let rhs = formatPath [Key "x", Index 0]
270+ lhs = ".x[0]"
271+ in assertEqual "formatRelativePath example" lhs rhs
272+
256273------------------------------------------------------------------------------
257274-- Comparison (.:?) and (.:!)
258275------------------------------------------------------------------------------
@@ -523,6 +540,7 @@ showOptions =
523540 ++ ", sumEncoding = TaggedObject {tagFieldName = \"tag\", contentsFieldName = \"contents\"}"
524541 ++ ", unwrapUnaryRecords = False"
525542 ++ ", tagSingleConstructors = False"
543+ ++ ", rejectUnknownFields = False"
526544 ++ "}")
527545 (show defaultOptions)
528546
@@ -567,6 +585,79 @@ singleFieldCon :: Assertion
567585singleFieldCon =
568586 assertEqual "fromJSON" (Right (SingleFieldCon 0)) (eitherDecode "0")
569587
588+newtype UnknownFields = UnknownFields { knownField :: Int }
589+ deriving (Eq, Show, Generic)
590+newtype UnknownFieldsTag = UnknownFieldsTag { tag :: Int }
591+ deriving (Eq, Show, Generic)
592+newtype UnknownFieldsUnaryTagged = UnknownFieldsUnaryTagged { knownFieldUnaryTagged :: Int }
593+ deriving (Eq, Show, Generic)
594+data UnknownFieldsSum
595+ = UnknownFields1 { knownField1 :: Int }
596+ | UnknownFields2 { knownField2 :: Int }
597+ deriving (Eq, Show, Generic)
598+
599+unknownFields :: [TestTree]
600+unknownFields = concat
601+ [ testsUnary
602+ "unary-unknown"
603+ (object [("knownField", Number 1), ("unknownField", Number 1)])
604+ (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFields)
605+ , testsUnary
606+ "unary-unknown-tag"
607+ (object [("knownField", Number 1), ("tag", String "UnknownFields")])
608+ (Error "nknown fields: [\"tag\"]" :: Result UnknownFields)
609+ , testsUnaryTag
610+ "unary-explicit-tag"
611+ (object [("tag", Number 1)])
612+ (Success $ UnknownFieldsTag 1)
613+ , testsSum
614+ "sum-tag"
615+ (object [("knownField1", Number 1), ("tag", String "UnknownFields1")])
616+ (Success $ UnknownFields1 1)
617+ , testsSum
618+ "sum-unknown-in-branch"
619+ (object [("knownField1", Number 1), ("knownField2", Number 1), ("tag", String "UnknownFields1")])
620+ (Error "nknown fields: [\"knownField2\"]" :: Result UnknownFieldsSum)
621+ , testsSum
622+ "sum-unknown"
623+ (object [("knownField1", Number 1), ("unknownField", Number 1), ("tag", String "UnknownFields1")])
624+ (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFieldsSum)
625+ , testsTagged
626+ "unary-tagged"
627+ (object [("knownFieldUnaryTagged", Number 1), ("tag", String "UnknownFieldsUnaryTagged")])
628+ (Success $ UnknownFieldsUnaryTagged 1)
629+ , -- Just a case to verify that the tag isn't optional, this is likely already tested by other unit tests
630+ testsTagged
631+ "unary-tagged-notag"
632+ (object [("knownFieldUnaryTagged", Number 1)])
633+ (Error "key \"tag\" not found" :: Result UnknownFieldsUnaryTagged)
634+ , testsTagged
635+ "unary-tagged-unknown"
636+ (object [ ("knownFieldUnaryTagged", Number 1), ("unknownField", Number 1)
637+ , ("tag", String "UnknownFieldsUnaryTagged")])
638+ (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFieldsUnaryTagged)
639+ ]
640+ where
641+ opts = defaultOptions{rejectUnknownFields=True}
642+ taggedOpts = opts{tagSingleConstructors=True}
643+ assertApprox :: (Show a, Eq a) => Result a -> Result a -> IO ()
644+ assertApprox (Error expected) (Error actual) | expected `isSuffixOf` actual = return ()
645+ assertApprox expected actual = assertEqual "fromJSON" expected actual
646+ testsBase :: (Show a, Eq a) => (Value -> Result a) -> (Value -> Result a)
647+ -> String -> Value -> Result a -> [TestTree]
648+ testsBase th g name value expected =
649+ [ testCase (name ++ "-th") $ assertApprox expected (th value)
650+ , testCase (name ++ "-generic") $ assertApprox expected (g value)
651+ ]
652+ testsUnary :: String -> Value -> Result UnknownFields -> [TestTree]
653+ testsUnary = testsBase fromJSON (parse (genericParseJSON opts))
654+ testsUnaryTag :: String -> Value -> Result UnknownFieldsTag -> [TestTree]
655+ testsUnaryTag = testsBase fromJSON (parse (genericParseJSON opts))
656+ testsSum :: String -> Value -> Result UnknownFieldsSum -> [TestTree]
657+ testsSum = testsBase fromJSON (parse (genericParseJSON opts))
658+ testsTagged :: String -> Value -> Result UnknownFieldsUnaryTagged -> [TestTree]
659+ testsTagged = testsBase fromJSON (parse (genericParseJSON taggedOpts))
660+
570661testParser :: (Eq a, Show a)
571662 => String -> Parser a -> S.ByteString -> Either String a -> TestTree
572663testParser name json_ s expected =
@@ -607,6 +698,25 @@ ratioDenominator0 =
607698 (Left "Error in $: Ratio denominator was 0")
608699 (eitherDecode "{ \"numerator\": 1, \"denominator\": 0 }" :: Either String Rational)
609700
701+rationalNumber :: Assertion
702+rationalNumber =
703+ assertEqual "Ratio with denominator 0"
704+ (Right 1.37)
705+ (eitherDecode "1.37" :: Either String Rational)
706+
707+bigRationalDecoding :: Assertion
708+bigRationalDecoding =
709+ assertEqual "Decoding an Integer with a large exponent should fail"
710+ (Left "Error in $: parsing Ratio failed, found a number with exponent 2000, but it must not be greater than 1024 or less than -1024")
711+ ((eitherDecode :: L.ByteString -> Either String Rational) "1e2000")
712+
713+smallRationalDecoding :: Assertion
714+smallRationalDecoding =
715+ assertEqual "Decoding an Integer with a large exponent should fail"
716+ (Left "Error in $: parsing Ratio failed, found a number with exponent -2000, but it must not be greater than 1024 or less than -1024")
717+ ((eitherDecode :: L.ByteString -> Either String Rational) "1e-2000")
718+
719+
610720bigScientificExponent :: Assertion
611721bigScientificExponent =
612722 assertEqual "Encoding an integral scientific with a large exponent should normalize it"
@@ -643,3 +753,8 @@ deriveToJSON defaultOptions ''Foo
643753deriveToJSON1 defaultOptions ''Foo
644754
645755deriveJSON defaultOptions{omitNothingFields=True,unwrapUnaryRecords=True} ''SingleMaybeField
756+
757+deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFields
758+deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFieldsTag
759+deriveJSON defaultOptions{tagSingleConstructors=True,rejectUnknownFields=True} ''UnknownFieldsUnaryTagged
760+deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFieldsSum
tests/golden/generic.expected+11−3
@@ -6,11 +6,11 @@ Error in $: parsing Types.Nullary failed, expected one of the tags ["C1","C2","C
66Error in $: parsing Types.Nullary failed, expected String, but encountered Array
77SomeType (tagged)
88Error in $.contents: parsing Int failed, expected Number, but encountered Boolean
9−Error in $: parsing Types.SomeType(Unary) failed, key "contents" not present
10−Error in $: parsing Types.SomeType(Record) failed, key "testone" not present
9+Error in $: parsing Types.SomeType(Unary) failed, key "contents" not found
10+Error in $: parsing Types.SomeType(Record) failed, key "testone" not found
1111Error in $.testone: parsing Double failed, unexpected Boolean
1212Error in $.tag: parsing Types.SomeType failed, expected tag field to be one of ["nullary","unary","product","record","list"], but found tag "X"
13−Error in $: parsing Types.SomeType failed, key "tag" not present
13+Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found
1414Error in $: parsing Types.SomeType failed, expected Object, but encountered Array
1515SomeType (single-field)
1616Error in $.unary: parsing Int failed, expected Number, but encountered Object
@@ -31,6 +31,14 @@ Error in $: parsing Types.SomeType failed, expected a 2-element Array, but encou
3131Error in $: parsing Types.SomeType failed, expected Array, but encountered Object
3232Error in $: not enough input. Expecting ',' or ']'
3333Error in $: not enough input. Expecting json list value
34+SomeType (reject unknown fields)
35+Error in $: parsing Types.SomeType(Record) failed, unknown fields: ["testZero"]
36+Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found
37+Error in $: parsing Types.SomeType(Record) failed, unknown fields: ["testtwo","testone","testthree"]
38+Foo (reject unknown fields)
39+Error in $: parsing Types.Foo(Foo) failed, unknown fields: ["tag"]
40+Foo (reject unknown fields, tagged single)
41+Error in $: parsing Types.Foo(Foo) failed, unknown fields: ["unknownField"]
3442EitherTextInt
3543Error in $: parsing Types.EitherTextInt(NoneNullary) failed, expected tag "nonenullary", but found tag "X"
3644Error in $: parsing Types.EitherTextInt(NoneNullary) failed, expected String, but encountered Array