on master help sign in
115 files changed+5900−3452
since splitsnapshots
unifiedsplit
.gitignore+6 .hlint.yaml+11 .travis.yml+42−21 CONTRIBUTING.md+39−1 Data/Aeson.hs+77−5 Data/Aeson/Encode.hs+2−1 Data/Aeson/Encoding.hs+2−1 Data/Aeson/Encoding/Builder.hs+6−80 Data/Aeson/Encoding/Internal.hs+3−2 Data/Aeson/Internal.hs+1−1 Data/Aeson/Internal/Functions.hs+1−1 Data/Aeson/Internal/Time.hs+1−42 Data/Aeson/Parser.hs+13−4 Data/Aeson/Parser/Internal.hs+253−65 Data/Aeson/Parser/Time.hs+18−103 Data/Aeson/QQ/Simple.hs+25 Data/Aeson/TH.hs+436−860 Data/Aeson/Text.hs+5−4 Data/Aeson/Types.hs+41−3 Data/Aeson/Types/Class.hs+8−3 Data/Aeson/Types/FromJSON.hs+863−420 Data/Aeson/Types/Generic.hs+12−8 Data/Aeson/Types/Internal.hs+155−13 Data/Aeson/Types/ToJSON.hs+262−84 HLint.hs−10 Makefile+1−1 README.markdown+1−2 aeson.cabal+69−54 attoparsec-iso8601/Data/Attoparsec/Time.hs+148 attoparsec-iso8601/Data/Attoparsec/Time/Internal.hs+64 attoparsec-iso8601/LICENSE+30 attoparsec-iso8601/README.md+19 attoparsec-iso8601/attoparsec-iso8601.cabal+55 attoparsec-iso8601/changelog.md+5 benchmarks/AesonCompareAutoInstances.hs−282 benchmarks/AesonEncode.hs+2−2 benchmarks/AesonFoldable.hs+14−42 benchmarks/AesonMap.hs+39−56 benchmarks/AesonParse.hs+2−3 benchmarks/AesonTuples.hs+2−1 benchmarks/Auto/G/BigProduct.hs+33 benchmarks/Auto/G/BigRecord.hs+33 benchmarks/Auto/G/BigSum.hs+28 benchmarks/Auto/G/D.hs+44 benchmarks/Auto/T/BigProduct.hs+27 benchmarks/Auto/T/BigRecord.hs+27 benchmarks/Auto/T/BigSum.hs+22 benchmarks/Auto/T/D.hs+38 benchmarks/AutoCompare.hs+73 benchmarks/Compare.hs+10−5 benchmarks/Compare/BufferBuilder.hs+2−3 benchmarks/Compare/JsonBench.hs+18−9 benchmarks/Compare/JsonBuilder.hs+2−3 benchmarks/CompareWithJSON.hs+32−17 benchmarks/Dates.hs+2−1 benchmarks/Escape.hs+32 benchmarks/Issue673.hs+165 benchmarks/JsonParse.hs+3−2 benchmarks/Micro.hs+8−6 benchmarks/Options.hs+1−4 benchmarks/ReadFile.hs+1−1 benchmarks/Typed.hs+5−1 benchmarks/Typed/Common.hs+1−10 benchmarks/Typed/Generic.hs+27−25 benchmarks/Typed/Manual.hs+26−24 benchmarks/Typed/TH.hs+26−24 benchmarks/aeson-benchmarks.cabal+183−64 cabal.project+5 changelog.md+173 examples/Generic.hs+1−1 examples/Simplest.hs+1−1 examples/TemplateHaskell.hs+1−1 examples/Twitter.hs+1−2 examples/Twitter/Generic.hs+31−36 examples/Twitter/Manual.hs+3−139 examples/Twitter/Options.hs+10 examples/Twitter/TH.hs+7−19 ffi/Data/Aeson/Parser/UnescapeFFI.hs+1−1 pure/Data/Aeson/Parser/UnescapePure.hs+16−39 run-hlint.sh+7 stack-bench.yaml+10−2 stack-lts7.yaml → stack-ffi-unescape.yaml+4−3 stack-lts12.yaml+15 stack-lts6.yaml−11 stack-lts8.yaml−6 stack-nightly.yaml+6−3 stack-pure-unescape.yaml−7 tests/DataFamilies/Encoders.hs+2−2 tests/DataFamilies/Instances.hs+2−1 tests/DataFamilies/Properties.hs+6−5 tests/DataFamilies/Types.hs+2−2 tests/Encoders.hs+82−8 tests/ErrorMessages.hs+208−41 tests/Functions.hs+2−1 tests/Instances.hs+7−69 tests/JSONTestSuite/parsers/test_haskell-aeson/src/Main.hs+1−1 tests/JSONTestSuite/parsers/test_haskell-aeson/testaeson.cabal+5−3 tests/Options.hs+20−2 tests/PropUtils.hs+208 tests/Properties.hs+17−488 tests/PropertyGeneric.hs+116 tests/PropertyKeys.hs+40 tests/PropertyRTFunctors.hs+51 tests/PropertyRoundTrip.hs+74 tests/PropertyTH.hs+130 tests/SerializationFormatSpec.hs+181−132 tests/Tests.hs+5−3 tests/Types.hs+11−6 tests/UnitTests.hs+295−38 tests/UnitTests/NullaryConstructors.hs+8−3 tests/golden/generic.expected+48 tests/golden/simple.expected+22 travis/cabal_macros.h+448 travis/install.sh+11 travis/script.sh+4−2
.gitignore+6
@@ -1,8 +1,11 @@
11dist
22dist-newstyle
3+.ghc.environment.*
34.cabal-sandbox/
45cabal.sandbox.config
56.stack-work/
7+.stack-work-bench/
8+*.yaml.lock
69
710*.o
811*.hi
@@ -11,6 +14,9 @@ cabal.sandbox.config
1114.\#*
1215\#*
1316
17+# Emacs backup files
18+*~
19+
1420benchmarks/AesonEncode
1521
1622tests/qc
.hlint.yamlnew file+11
@@ -0,0 +1,11 @@
1+# Ignore some builtin hints
2+- ignore:
3+ name: "Reduce duplication"
4+ within:
5+ - Data.Aeson.Types.ToJSON
6+- ignore:
7+ name: "Eta reduce"
8+- ignore:
9+ name: "Use newtype instead of data"
10+ within:
11+ - Data.Aeson.Types.Internal
.travis.yml+42−21
@@ -12,38 +12,59 @@ cache:
1212 - $HOME/.stack
1313 - $HOME/.cabsnap
1414 - $HOME/.cabal/packages
15+ - $HOME/.cabal/store
1516
1617before_cache:
1718 - rm -fv $HOME/.cabal/packages/hackage.haskell.org/build-reports.log
18− - rm -fv $HOME/.cabal/packages/hackage.haskell.org/00-index.tar
19+ - rm -fv $HOME/.cabal/packages/hackage.haskell.org/00-index.*
20+ - rm -fv $HOME/.cabal/packages/hackage.haskell.org/*.json
21+ - rm -fv $HOME/.cabal/packages/hackage.haskell.org/01-index.cache
22+ - rm -fv $HOME/.cabal/packages/hackage.haskell.org/01-index.tar
23+ - rm -fv $HOME/.cabal/packages/hackage.haskell.org/01-index.tar.idx
1924
2025matrix:
2126 include:
22− - env: BUILD=hlint CABALVER=1.24 GHCVER=8.0.2
23− compiler: ": #GHC 8.0.2"
24− addons: {apt: {packages: [cabal-install-1.24,ghc-8.0.2], sources: [hvr-ghc]}}
25− - env: BUILD=stack CABALVER=1.24 GHCVER=8.0.2 STACK_YAML=stack-bench.yaml
26− compiler: ": #GHC 8.0.2"
27− addons: {apt: {packages: [cabal-install-1.24,ghc-8.0.2], sources: [hvr-ghc]}}
28− - env: BUILD=stack CABALVER=1.24 GHCVER=8.0.2 STACK_YAML=stack-pure-unescape.yaml
29− compiler: ": #GHC 8.0.2"
30− addons: {apt: {packages: [cabal-install-1.24,ghc-8.0.2], sources: [hvr-ghc]}}
31− - env: BUILD=cabal CABALVER=1.24 GHCVER=8.0.2
27+
28+ - env: BUILD=hlint CABALVER=2.2 GHCVER=8.4.4
29+ compiler: ": #GHC 8.4.4"
30+ addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4], sources: [hvr-ghc]}}
31+
32+ - env: BUILD=stack CABALVER=2.4 GHCVER=8.6.5 STACK_YAML=stack-bench.yaml
33+ compiler: ": #GHC 8.6.5"
34+ addons: {apt: {packages: [cabal-install-2.4,ghc-8.6.5], sources: [hvr-ghc]}}
35+
36+ - env: BUILD=stack CABALVER=2.2 GHCVER=8.6.5 STACK_YAML=stack-ffi-unescape.yaml
37+ compiler: ": #GHC 8.6.5"
38+ addons: {apt: {packages: [cabal-install-2.2,ghc-8.6.5], sources: [hvr-ghc]}}
39+
40+ - env: BUILD=cabal2 CABALVER=3.0 GHCVER=8.8.1
41+ compiler: ": #GHC 8.8.1"
42+ addons: {apt: {packages: [cabal-install-3.0,ghc-8.8.1], sources: [hvr-ghc]}}
43+
44+ - env: BUILD=cabal CABALVER=2.4 GHCVER=8.6.5
45+ compiler: ": #GHC 8.6.5"
46+ addons: {apt: {packages: [cabal-install-2.4,ghc-8.6.5], sources: [hvr-ghc]}}
47+
48+ - env: BUILD=cabal CABALVER=2.2 GHCVER=8.4.4
49+ compiler: ": #GHC 8.4.4"
50+ addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4], sources: [hvr-ghc]}}
51+
52+ - env: BUILD=cabal CABALVER=2.0 GHCVER=8.2.2
53+ compiler: ": #GHC 8.2.2"
54+ addons: {apt: {packages: [cabal-install-2.0,ghc-8.2.2], sources: [hvr-ghc]}}
55+
56+ - env: BUILD=cabal CABALVER=2.0 GHCVER=8.0.2
3257 compiler: ": #GHC 8.0.2"
33− addons: {apt: {packages: [cabal-install-1.24,ghc-8.0.2], sources: [hvr-ghc]}}
34− - env: BUILD=cabal CABALVER=1.18 GHCVER=7.4.2
35− compiler: ": #GHC 7.4.2"
36− addons: {apt: {packages: [cabal-install-1.18,ghc-7.4.2], sources: [hvr-ghc]}}
37− - env: BUILD=cabal CABALVER=1.18 GHCVER=7.6.3
38− compiler: ": #GHC 7.6.3"
39− addons: {apt: {packages: [cabal-install-1.18,ghc-7.6.3], sources: [hvr-ghc]}}
40− - env: BUILD=cabal CABALVER=1.18 GHCVER=7.8.4
41− compiler: ": #GHC 7.8.4"
42− addons: {apt: {packages: [cabal-install-1.18,ghc-7.8.4], sources: [hvr-ghc]}}
58+ addons: {apt: {packages: [cabal-install-2.0,ghc-8.0.2], sources: [hvr-ghc]}}
59+
4360 - env: BUILD=cabal CABALVER=1.22 GHCVER=7.10.3
4461 compiler: ": #GHC 7.10.3"
4562 addons: {apt: {packages: [cabal-install-1.22,ghc-7.10.3], sources: [hvr-ghc]}}
4663
64+ - env: BUILD=cabal CABALVER=1.18 GHCVER=7.8.4
65+ compiler: ": #GHC 7.8.4"
66+ addons: {apt: {packages: [cabal-install-1.18,ghc-7.8.4], sources: [hvr-ghc]}}
67+
4768before_install:
4869 - unset CC
4970 - export PATH=$HOME/.local/bin:/opt/ghc/$GHCVER/bin:/opt/cabal/$CABALVER/bin:$PATH
CONTRIBUTING.md+39−1
@@ -8,7 +8,7 @@ Changes that affect users of aeson should be mentioned in `changelog.md`. It sho
88 * When it should be used
99 * What it supersedes
1010
11−Add this entry under an `# Upcoming` header above existing releases.
11+Add this entry under an `## Upcoming` header above existing releases.
1212
1313The exact format of entries is not important as we'll go through everything before a release is made.
1414
@@ -58,3 +58,41 @@ import Foo as F
5858import Qux (Q(..), q)
5959import qualified A
6060```
61+
62+## Development Workflow (If you plan on using Stack)
63+
64+Here we outline a general workflow new contributors could adopt for a nice incremental development experience.
65+
66+The root folder consists of two stack-*.yaml config files.
67+
68+1. stack-nightly.yaml - Config file defines all the settings to build and test any changes.
69+2. stack-bench.yaml - Used to run benchmark tests.
70+3. stack-ffi-unescape.yaml - This is for replacing certain parts with a C-implementation.
71+
72+Therefore, a ghci development experience would be:
73+
74+1. `stack ghci --stack-yaml stack-nightly.yaml --test`
75+2. :r to recompile
76+3. `main` to run all tests, or `:main --pattern Foo` to run specific tests matched by pattern.
77+
78+Some discussion on this topic can also be found here [here](https://github.com/bos/aeson/issues/733)
79+
80+Of course before submitting a PR, the following steps are recommended:
81+
82+1. 'stack test --stack-yaml stack-nightly.yaml` - Run the entire suite of tests
83+2. `make hlint` - Run hlint on the source folders.
84+3. 'stack test --stack-yaml stack-bench.yaml` - Run the benchmark tests if you believe your changes could affect the benchmarks.
85+
86+## Development Workflow (If you plan on using Cabal)
87+
88+A ghci development experience would be:
89+
90+1. `cabal new-repl test:tests`
91+2. `:r` to recompile
92+3. `Main.main` to run all tests, or `:m Main; :main --pattern Foo` to run specific tests matched by pattern.
93+
94+Of course before submitting a PR, the following steps are recommended:
95+
96+1. `cabal new-test` - Run the entire suite of tests
97+2. `make hlint` - Run hlint on the source folders.
98+3. Uncomment the `benchmarks` line in `cabal.project` - Run the benchmark tests if you believe your changes could affect the benchmarks.
Data/Aeson.hs+77−5
@@ -1,3 +1,4 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12-- |
23-- Module: Data.Aeson
34-- Copyright: (c) 2011-2016 Bryan O'Sullivan
@@ -38,11 +39,16 @@ module Data.Aeson
3839 , eitherDecode
3940 , eitherDecode'
4041 , encode
42+ , encodeFile
4143 -- ** Variants for strict bytestrings
4244 , decodeStrict
45+ , decodeFileStrict
4346 , decodeStrict'
47+ , decodeFileStrict'
4448 , eitherDecodeStrict
49+ , eitherDecodeFileStrict
4550 , eitherDecodeStrict'
51+ , eitherDecodeFileStrict'
4652 -- * Core JSON types
4753 , Value(..)
4854 , Encoding
@@ -57,11 +63,18 @@ module Data.Aeson
5763 , fromJSON
5864 , ToJSON(..)
5965 , KeyValue(..)
66+ , (<?>)
67+ , JSONPath
6068 -- ** Keys for maps
6169 , ToJSONKey(..)
6270 , ToJSONKeyFunction(..)
6371 , FromJSONKey(..)
6472 , FromJSONKeyFunction(..)
73+ -- *** Generic keys
74+ , GToJSONKey()
75+ , genericToJSONKey
76+ , GFromJSONKey()
77+ , genericFromJSONKey
6578 -- ** Liftings to unary and binary type constructors
6679 , FromJSON1(..)
6780 , parseJSON1
@@ -87,15 +100,34 @@ module Data.Aeson
87100 , genericLiftToEncoding
88101 , genericParseJSON
89102 , genericLiftParseJSON
103+ -- ** Generic and TH encoding configuration
104+ , Options
90105 , defaultOptions
106+ -- *** Options fields
107+ -- $optionsFields
108+ , fieldLabelModifier
109+ , constructorTagModifier
110+ , allNullaryToStringTag
111+ , omitNothingFields
112+ , sumEncoding
113+ , unwrapUnaryRecords
114+ , tagSingleConstructors
115+ -- *** Options utilities
116+ , SumEncoding(..)
117+ , camelTo2
118+ , defaultTaggedObject
119+ -- ** Options for object keys
120+ , JSONKeyOptions
121+ , keyModifier
122+ , defaultJSONKeyOptions
91123
92124 -- * Inspecting @'Value's@
93125 , withObject
94126 , withText
95127 , withArray
96− , withNumber
97128 , withScientific
98129 , withBool
130+ , withEmbeddedJSON
99131 -- * Constructors and accessors
100132 , Series
101133 , pairs
@@ -108,16 +140,16 @@ module Data.Aeson
108140 -- * Parsing
109141 , json
110142 , json'
143+ , parseIndexedJSON
111144 ) where
112145
113−import Prelude ()
114146import Prelude.Compat
115147
116−import Data.Aeson.Types.FromJSON (ifromJSON)
148+import Data.Aeson.Types.FromJSON (ifromJSON, parseIndexedJSON)
117149import Data.Aeson.Encoding (encodingToLazyByteString)
118150import Data.Aeson.Parser.Internal (decodeWith, decodeStrictWith, eitherDecodeWith, eitherDecodeStrictWith, jsonEOF, json, jsonEOF', json')
119151import Data.Aeson.Types
120−import Data.Aeson.Types.Internal (JSONPath, formatError)
152+import Data.Aeson.Types.Internal (JSONPath, formatError, (<?>))
121153import qualified Data.ByteString as B
122154import qualified Data.ByteString.Lazy as L
123155
@@ -127,6 +159,10 @@ import qualified Data.ByteString.Lazy as L
127159encode :: (ToJSON a) => a -> L.ByteString
128160encode = encodingToLazyByteString . toEncoding
129161
162+-- | Efficiently serialize a JSON value as a lazy 'L.ByteString' and write it to a file.
163+encodeFile :: (ToJSON a) => FilePath -> a -> IO ()
164+encodeFile fp = L.writeFile fp . encode
165+
130166-- | Efficiently deserialize a JSON value from a lazy 'L.ByteString'.
131167-- If this fails due to incomplete or invalid input, 'Nothing' is
132168-- returned.
@@ -153,6 +189,18 @@ decodeStrict :: (FromJSON a) => B.ByteString -> Maybe a
153189decodeStrict = decodeStrictWith jsonEOF fromJSON
154190{-# INLINE decodeStrict #-}
155191
192+-- | Efficiently deserialize a JSON value from a file.
193+-- If this fails due to incomplete or invalid input, 'Nothing' is
194+-- returned.
195+--
196+-- The input file's content must consist solely of a JSON document,
197+-- with no trailing data except for whitespace.
198+--
199+-- This function parses immediately, but defers conversion. See
200+-- 'json' for details.
201+decodeFileStrict :: (FromJSON a) => FilePath -> IO (Maybe a)
202+decodeFileStrict = fmap decodeStrict . B.readFile
203+
156204-- | Efficiently deserialize a JSON value from a lazy 'L.ByteString'.
157205-- If this fails due to incomplete or invalid input, 'Nothing' is
158206-- returned.
@@ -179,6 +227,18 @@ decodeStrict' :: (FromJSON a) => B.ByteString -> Maybe a
179227decodeStrict' = decodeStrictWith jsonEOF' fromJSON
180228{-# INLINE decodeStrict' #-}
181229
230+-- | Efficiently deserialize a JSON value from a file.
231+-- If this fails due to incomplete or invalid input, 'Nothing' is
232+-- returned.
233+--
234+-- The input file's content must consist solely of a JSON document,
235+-- with no trailing data except for whitespace.
236+--
237+-- This function parses and performs conversion immediately. See
238+-- 'json'' for details.
239+decodeFileStrict' :: (FromJSON a) => FilePath -> IO (Maybe a)
240+decodeFileStrict' = fmap decodeStrict' . B.readFile
241+
182242eitherFormatError :: Either (JSONPath, String) a -> Either String a
183243eitherFormatError = either (Left . uncurry formatError) Right
184244{-# INLINE eitherFormatError #-}
@@ -194,6 +254,12 @@ eitherDecodeStrict =
194254 eitherFormatError . eitherDecodeStrictWith jsonEOF ifromJSON
195255{-# INLINE eitherDecodeStrict #-}
196256
257+-- | Like 'decodeFileStrict' but returns an error message when decoding fails.
258+eitherDecodeFileStrict :: (FromJSON a) => FilePath -> IO (Either String a)
259+eitherDecodeFileStrict =
260+ fmap (eitherFormatError . eitherDecodeStrictWith jsonEOF ifromJSON) . B.readFile
261+{-# INLINE eitherDecodeFileStrict #-}
262+
197263-- | Like 'decode'' but returns an error message when decoding fails.
198264eitherDecode' :: (FromJSON a) => L.ByteString -> Either String a
199265eitherDecode' = eitherFormatError . eitherDecodeWith jsonEOF' ifromJSON
@@ -205,6 +271,12 @@ eitherDecodeStrict' =
205271 eitherFormatError . eitherDecodeStrictWith jsonEOF' ifromJSON
206272{-# INLINE eitherDecodeStrict' #-}
207273
274+-- | Like 'decodeFileStrict'' but returns an error message when decoding fails.
275+eitherDecodeFileStrict' :: (FromJSON a) => FilePath -> IO (Either String a)
276+eitherDecodeFileStrict' =
277+ fmap (eitherFormatError . eitherDecodeStrictWith jsonEOF' ifromJSON) . B.readFile
278+{-# INLINE eitherDecodeFileStrict' #-}
279+
208280-- $use
209281--
210282-- This section contains basic information on the different ways to
@@ -366,7 +438,7 @@ eitherDecodeStrict' =
366438-- The 'Object' type contains JSON objects:
367439--
368440-- > λ> decode "{\"name\":\"Dave\",\"age\":2}" :: Maybe Object
369−-- > Just (fromList) [("name",String "Dave"),("age",Number 2)]
441+-- > Just (fromList [("name",String "Dave"),("age",Number 2)])
370442--
371443-- You can extract values from it with a parser using 'parse',
372444-- 'parseEither' or, in this example, 'parseMaybe':
Data/Aeson/Encode.hs+2−1
@@ -1,3 +1,4 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12-- |
23-- Module: Data.Aeson.Encode
34-- Copyright: (c) 2012-2016 Bryan O'Sullivan
@@ -8,13 +9,13 @@
89-- Portability: portable
910--
1011-- This module is left to supply limited backwards-compatibility.
12+
1113module Data.Aeson.Encode {-# DEPRECATED "Use Data.Aeson or Data.Aeson.Text instead" #-}
1214 (
1315 encode
1416 , encodeToTextBuilder
1517 ) where
1618
17−import Prelude ()
1819
1920import Data.ByteString.Lazy (ByteString)
2021import Data.Text.Lazy.Builder (Builder)
Data/Aeson/Encoding.hs+2−1
@@ -1,8 +1,10 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12-- |
23--
34-- Functions in this module return well-formed 'Encoding''.
45-- Polymorphic variants, which return @'Encoding' a@, return a textual JSON
56-- value, so it can be used as both @'Encoding'' 'Text'@ and @'Encoding' = 'Encoding'' 'Value'@.
7+
68module Data.Aeson.Encoding
79 (
810 -- * Encoding
@@ -49,6 +51,5 @@ module Data.Aeson.Encoding
4951 , value
5052 ) where
5153
52−import Prelude ()
5354
5455import Data.Aeson.Encoding.Internal
Data/Aeson/Encoding/Builder.hs+6−80
@@ -1,7 +1,6 @@
11{-# LANGUAGE BangPatterns #-}
2−{-# LANGUAGE CPP #-}
3−{-# LANGUAGE OverloadedStrings #-}
4−
2+{-# LANGUAGE NoImplicitPrelude #-}
3+{-# LANGUAGE TupleSections #-}
54-- |
65-- Module: Data.Aeson.Encoding.Builder
76-- Copyright: (c) 2011 MailRank, Inc.
@@ -37,7 +36,6 @@ module Data.Aeson.Encoding.Builder
3736 , ascii5
3837 ) where
3938
40−import Prelude ()
4139import Prelude.Compat
4240
4341import Data.Aeson.Internal.Time
@@ -46,8 +44,9 @@ import Data.ByteString.Builder as B
4644import Data.ByteString.Builder.Prim as BP
4745import Data.ByteString.Builder.Scientific (scientificBuilder)
4846import Data.Char (chr, ord)
49−import Data.Monoid ((<>))
47+import Data.Semigroup ((<>))
5048import Data.Scientific (Scientific, base10Exponent, coefficient)
49+import Data.Text.Encoding (encodeUtf8BuilderEscaped)
5150import Data.Time (UTCTime(..))
5251import Data.Time.Calendar (Day(..), toGregorian)
5352import Data.Time.LocalTime
@@ -56,20 +55,6 @@ import qualified Data.HashMap.Strict as HMS
5655import qualified Data.Text as T
5756import qualified Data.Vector as V
5857
59−#if MIN_VERSION_bytestring(0,10,4)
60−import Data.Text.Encoding (encodeUtf8BuilderEscaped)
61−#else
62−import Data.Bits ((.&.))
63−import Data.Text.Internal (Text(..))
64−import Data.Text.Internal.Unsafe.Shift (shiftR)
65−import Foreign.Ptr (minusPtr, plusPtr)
66−import Foreign.Storable (poke)
67−import qualified Data.ByteString.Builder.Internal as B
68−import qualified Data.ByteString.Builder.Prim.Internal as BP
69−import qualified Data.Text.Array as A
70−import qualified Data.Text.Internal.Encoding.Utf16 as U16
71−#endif
72−
7358-- | Encode a JSON value to a "Data.ByteString" 'B.Builder'.
7459--
7560-- Use this function if you are encoding over the wire, or need to
@@ -148,7 +133,7 @@ c2w c = fromIntegral (ord c)
148133-- | Encode a JSON number.
149134scientific :: Scientific -> Builder
150135scientific s
151− | e < 0 = scientificBuilder s
136+ | e < 0 || e > 1024 = scientificBuilder s
152137 | otherwise = B.integerDec (coefficient s * 10 ^ e)
153138 where
154139 e = base10Exponent s
@@ -216,7 +201,7 @@ timeOfDay64 (TOD h m s)
216201 !(T mh ml) = twoDigits m
217202 !(T sh sl) = twoDigits (fromIntegral real)
218203 (real,frac) = s `quotRem` pico
219− showFrac = (\x -> ('.', x)) >$< (BP.liftFixedToBounded BP.char7 >*< trunc12)
204+ showFrac = ('.',) >$< (BP.liftFixedToBounded BP.char7 >*< trunc12)
220205 trunc12 = (`quotRem` micro) >$<
221206 BP.condB (\(_,y) -> y == 0) (fst >$< trunc6) (digits6 >*< trunc6)
222207 digits6 = ((`quotRem` milli) . fromIntegral) >$< (digits3 >*< digits3)
@@ -269,62 +254,3 @@ twoDigits a = T (digit hi) (digit lo)
269254
270255digit :: Int -> Char
271256digit x = chr (x + 48)
272−
273−#if !(MIN_VERSION_bytestring(0,10,4))
274−-- | Encode text using UTF-8 encoding and escape the ASCII characters using
275−-- a 'BP.BoundedPrim'.
276−--
277−-- Use this function is to implement efficient encoders for text-based formats
278−-- like JSON or HTML.
279−{-# INLINE encodeUtf8BuilderEscaped #-}
280−-- TODO: Extend documentation with references to source code in @blaze-html@
281−-- or @aeson@ that uses this function.
282−encodeUtf8BuilderEscaped :: BP.BoundedPrim Word8 -> Text -> B.Builder
283−encodeUtf8BuilderEscaped be =
284− -- manual eta-expansion to ensure inlining works as expected
285− \txt -> B.builder (mkBuildstep txt)
286− where
287− bound = max 4 $ BP.sizeBound be
288−
289− mkBuildstep (Text arr off len) !k =
290− outerLoop off
291− where
292− iend = off + len
293−
294− outerLoop !i0 br@(B.BufferRange op0 ope)
295− | i0 >= iend = k br
296− | outRemaining > 0 = goPartial (i0 + min outRemaining inpRemaining)
297− -- TODO: Use a loop with an integrated bound's check if outRemaining
298− -- is smaller than 8, as this will save on divisions.
299− | otherwise = return $ B.bufferFull bound op0 (outerLoop i0)
300− where
301− outRemaining = (ope `minusPtr` op0) `div` bound
302− inpRemaining = iend - i0
303−
304− goPartial !iendTmp = go i0 op0
305− where
306− go !i !op
307− | i < iendTmp = case A.unsafeIndex arr i of
308− w | w <= 0x7F ->
309− BP.runB be (fromIntegral w) op >>= go (i + 1)
310− | w <= 0x7FF -> do
311− poke8 0 $ (w `shiftR` 6) + 0xC0
312− poke8 1 $ (w .&. 0x3f) + 0x80
313− go (i + 1) (op `plusPtr` 2)
314− | 0xD800 <= w && w <= 0xDBFF -> do
315− let c = ord $ U16.chr2 w (A.unsafeIndex arr (i+1))
316− poke8 0 $ (c `shiftR` 18) + 0xF0
317− poke8 1 $ ((c `shiftR` 12) .&. 0x3F) + 0x80
318− poke8 2 $ ((c `shiftR` 6) .&. 0x3F) + 0x80
319− poke8 3 $ (c .&. 0x3F) + 0x80
320− go (i + 2) (op `plusPtr` 4)
321− | otherwise -> do
322− poke8 0 $ (w `shiftR` 12) + 0xE0
323− poke8 1 $ ((w `shiftR` 6) .&. 0x3F) + 0x80
324− poke8 2 $ (w .&. 0x3F) + 0x80
325− go (i + 1) (op `plusPtr` 3)
326− | otherwise =
327− outerLoop i (B.BufferRange op ope)
328− where
329− poke8 j v = poke (op `plusPtr` j) (fromIntegral v :: Word8)
330−#endif
Data/Aeson/Encoding/Internal.hs+3−2
@@ -1,7 +1,9 @@
11{-# LANGUAGE DeriveDataTypeable #-}
22{-# LANGUAGE EmptyDataDecls #-}
3+{-# LANGUAGE NoImplicitPrelude #-}
34{-# LANGUAGE OverloadedStrings #-}
45{-# LANGUAGE RankNTypes #-}
6+
57module Data.Aeson.Encoding.Internal
68 (
79 -- * Encoding
@@ -55,7 +57,6 @@ module Data.Aeson.Encoding.Internal
5557 , comma, colon, openBracket, closeBracket, openCurly, closeCurly
5658 ) where
5759
58−import Prelude ()
5960import Prelude.Compat
6061
6162import Data.Aeson.Types.Internal (Value)
@@ -81,7 +82,7 @@ newtype Encoding' tag = Encoding {
8182 -- ^ Acquire the underlying bytestring builder.
8283 } deriving (Typeable)
8384
84−-- | Often used synonnym for 'Encoding''.
85+-- | Often used synonym for 'Encoding''.
8586type Encoding = Encoding' Value
8687
8788-- | Make Encoding from Builder.
Data/Aeson/Internal.hs+1−1
@@ -1,3 +1,4 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12-- |
23-- Module: Data.Aeson.Internal
34-- Copyright: (c) 2015-2016 Bryan O'Sullivan
@@ -22,7 +23,6 @@ module Data.Aeson.Internal
2223 , iparse
2324 ) where
2425
25−import Prelude ()
2626
2727import Data.Aeson.Types.Internal
2828import Data.Aeson.Types.FromJSON (ifromJSON)
Data/Aeson/Internal/Functions.hs+1−1
@@ -1,3 +1,4 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12-- |
23-- Module: Data.Aeson.Functions
34-- Copyright: (c) 2011-2016 Bryan O'Sullivan
@@ -14,7 +15,6 @@ module Data.Aeson.Internal.Functions
1415 , mapKey
1516 ) where
1617
17−import Prelude ()
1818import Prelude.Compat
1919
2020import Data.Hashable (Hashable)
Data/Aeson/Internal/Time.hs+1−42
@@ -17,45 +17,4 @@ module Data.Aeson.Internal.Time
1717 , toTimeOfDay64
1818 ) where
1919
20−import Prelude ()
21−import Prelude.Compat
22−
23−import Data.Int (Int64)
24−import Data.Time
25−import Unsafe.Coerce (unsafeCoerce)
26−
27−#if MIN_VERSION_base(4,7,0)
28−
29−import Data.Fixed (Pico, Fixed(MkFixed))
30−
31−toPico :: Integer -> Pico
32−toPico = MkFixed
33−
34−fromPico :: Pico -> Integer
35−fromPico (MkFixed i) = i
36−
37−#else
38−
39−import Data.Fixed (Pico)
40−
41−toPico :: Integer -> Pico
42−toPico = unsafeCoerce
43−
44−fromPico :: Pico -> Integer
45−fromPico = unsafeCoerce
46−
47−#endif
48−
49−-- | Like TimeOfDay, but using a fixed-width integer for seconds.
50−data TimeOfDay64 = TOD {-# UNPACK #-} !Int
51− {-# UNPACK #-} !Int
52− {-# UNPACK #-} !Int64
53−
54−diffTimeOfDay64 :: DiffTime -> TimeOfDay64
55−diffTimeOfDay64 t = TOD (fromIntegral h) (fromIntegral m) s
56− where (h,mp) = fromIntegral pico `quotRem` 3600000000000000
57− (m,s) = mp `quotRem` 60000000000000
58− pico = unsafeCoerce t :: Integer
59−
60−toTimeOfDay64 :: TimeOfDay -> TimeOfDay64
61−toTimeOfDay64 (TimeOfDay h m s) = TOD h m (fromIntegral (fromPico s))
20+import Data.Attoparsec.Time.Internal
Data/Aeson/Parser.hs+13−4
@@ -1,5 +1,4 @@
1−{-# LANGUAGE OverloadedStrings #-}
2−
1+{-# LANGUAGE NoImplicitPrelude #-}
32-- |
43-- Module: Data.Aeson.Parser
54-- Copyright: (c) 2012-2016 Bryan O'Sullivan
@@ -35,10 +34,21 @@ module Data.Aeson.Parser
3534 json
3635 , value
3736 , jstring
37+ , scientific
38+ -- ** Handling objects with duplicate keys
39+ , jsonWith
40+ , jsonLast
41+ , jsonAccum
42+ , jsonNoDup
3843 -- * Strict parsers
3944 -- $strict
4045 , json'
4146 , value'
47+ -- ** Handling objects with duplicate keys
48+ , jsonWith'
49+ , jsonLast'
50+ , jsonAccum'
51+ , jsonNoDup'
4252 -- * Decoding without FromJSON instances
4353 , decodeWith
4454 , decodeStrictWith
@@ -46,9 +56,8 @@ module Data.Aeson.Parser
4656 , eitherDecodeStrictWith
4757 ) where
4858
49−import Prelude ()
5059
51−import Data.Aeson.Parser.Internal (decodeStrictWith, decodeWith, eitherDecodeStrictWith, eitherDecodeWith, json, json', jstring, value, value')
60+import Data.Aeson.Parser.Internal
5261
5362-- $lazy
5463--
Data/Aeson/Parser/Internal.hs+253−65
@@ -1,10 +1,14 @@
11{-# LANGUAGE BangPatterns #-}
22{-# LANGUAGE CPP #-}
3+{-# LANGUAGE NoImplicitPrelude #-}
34{-# LANGUAGE OverloadedStrings #-}
45#if MIN_VERSION_ghc_prim(0,3,1)
56{-# LANGUAGE MagicHash #-}
67#endif
7−
8+#if __GLASGOW_HASKELL__ <= 710 && __GLASGOW_HASKELL__ >= 706
9+-- Work around a compiler bug
10+{-# OPTIONS_GHC -fsimpl-tick-factor=200 #-}
11+#endif
812-- |
913-- Module: Data.Aeson.Parser.Internal
1014-- Copyright: (c) 2011-2016 Bryan O'Sullivan
@@ -21,28 +25,43 @@ module Data.Aeson.Parser.Internal
2125 (
2226 -- * Lazy parsers
2327 json, jsonEOF
28+ , jsonWith
29+ , jsonLast
30+ , jsonAccum
31+ , jsonNoDup
2432 , value
2533 , jstring
34+ , jstring_
35+ , scientific
2636 -- * Strict parsers
2737 , json', jsonEOF'
38+ , jsonWith'
39+ , jsonLast'
40+ , jsonAccum'
41+ , jsonNoDup'
2842 , value'
2943 -- * Helpers
3044 , decodeWith
3145 , decodeStrictWith
3246 , eitherDecodeWith
3347 , eitherDecodeStrictWith
48+ -- ** Handling objects with duplicate keys
49+ , fromListAccum
50+ , parseListNoDup
3451 ) where
3552
36−import Prelude ()
3753import Prelude.Compat
3854
3955import Control.Applicative ((<|>))
4056import Control.Monad (void, when)
41−import Data.Aeson.Types.Internal (IResult(..), JSONPath, Result(..), Value(..))
57+import Data.Aeson.Types.Internal (IResult(..), JSONPath, Object, Result(..), Value(..))
4258import Data.Attoparsec.ByteString.Char8 (Parser, char, decimal, endOfInput, isDigit_w8, signed, string)
59+import Data.Function (fix)
60+import Data.Functor.Compat (($>))
4361import Data.Scientific (Scientific)
4462import Data.Text (Text)
45−import Data.Vector as Vector (Vector, empty, fromListN, reverse)
63+import Data.Vector (Vector)
64+import qualified Data.Vector as Vector (empty, fromList, fromListN, reverse)
4665import qualified Data.Attoparsec.ByteString as A
4766import qualified Data.Attoparsec.Lazy as L
4867import qualified Data.ByteString as B
@@ -53,8 +72,9 @@ import qualified Data.Scientific as Sci
5372import Data.Aeson.Parser.Unescape (unescapeText)
5473
5574#if MIN_VERSION_ghc_prim(0,3,1)
56−import GHC.Base (Int#, (==#), isTrue#, word2Int#)
75+import GHC.Base (Int#, (==#), isTrue#, word2Int#, orI#, andI#)
5776import GHC.Word (Word8(W8#))
77+import qualified Data.Text.Encoding as TE
5878#endif
5979
6080#define BACKSLASH 92
@@ -73,7 +93,7 @@ import GHC.Word (Word8(W8#))
7393#define C_n 110
7494#define C_t 116
7595
76−-- | Parse a top-level JSON value.
96+-- | Parse any JSON value.
7797--
7898-- The conversion of a parsed value to a Haskell value is deferred
7999-- until the Haskell value is needed. This may improve performance if
@@ -83,10 +103,15 @@ import GHC.Word (Word8(W8#))
83103-- This function is an alias for 'value'. In aeson 0.8 and earlier, it
84104-- parsed only object or array types, in conformance with the
85105-- now-obsolete RFC 4627.
106+--
107+-- ==== Warning
108+--
109+-- If an object contains duplicate keys, only the first one will be kept.
110+-- For a more flexible alternative, see 'jsonWith'.
86111json :: Parser Value
87112json = value
88113
89−-- | Parse a top-level JSON value.
114+-- | Parse any JSON value.
90115--
91116-- This is a strict version of 'json' which avoids building up thunks
92117-- during parsing; it performs all conversions immediately. Prefer
@@ -95,23 +120,35 @@ json = value
95120-- This function is an alias for 'value''. In aeson 0.8 and earlier, it
96121-- parsed only object or array types, in conformance with the
97122-- now-obsolete RFC 4627.
123+--
124+-- ==== Warning
125+--
126+-- If an object contains duplicate keys, only the first one will be kept.
127+-- For a more flexible alternative, see 'jsonWith''.
98128json' :: Parser Value
99129json' = value'
100130
101−object_ :: Parser Value
102−object_ = {-# SCC "object_" #-} Object <$> objectValues jstring value
131+-- Open recursion: object_, object_', array_, array_' are parameterized by the
132+-- toplevel Value parser to be called recursively, to keep the parameter
133+-- mkObject outside of the recursive loop for proper inlining.
103134
104−object_' :: Parser Value
105−object_' = {-# SCC "object_'" #-} do
106− !vals <- objectValues jstring' value'
135+object_ :: ([(Text, Value)] -> Either String Object) -> Parser Value -> Parser Value
136+object_ mkObject val = {-# SCC "object_" #-} Object <$> objectValues mkObject jstring val
137+{-# INLINE object_ #-}
138+
139+object_' :: ([(Text, Value)] -> Either String Object) -> Parser Value -> Parser Value
140+object_' mkObject val' = {-# SCC "object_'" #-} do
141+ !vals <- objectValues mkObject jstring' val'
107142 return (Object vals)
108143 where
109144 jstring' = do
110145 !s <- jstring
111146 return s
147+{-# INLINE object_' #-}
112148
113−objectValues :: Parser Text -> Parser Value -> Parser (H.HashMap Text Value)
114−objectValues str val = do
149+objectValues :: ([(Text, Value)] -> Either String Object)
150+ -> Parser Text -> Parser Value -> Parser (H.HashMap Text Value)
151+objectValues mkObject str val = do
115152 skipSpace
116153 w <- A.peekWord8'
117154 if w == CLOSE_CURLY
@@ -121,22 +158,26 @@ objectValues str val = do
121158 -- Why use acc pattern here, you may ask? because 'H.fromList' use 'unsafeInsert'
122159 -- and it's much faster because it's doing in place update to the 'HashMap'!
123160 loop acc = do
124− k <- str <* skipSpace <* char ':'
125− v <- val <* skipSpace
126− ch <- A.satisfy $ \w -> w == COMMA || w == CLOSE_CURLY
161+ k <- (str A.<?> "object key") <* skipSpace <* (char ':' A.<?> "':'")
162+ v <- (val A.<?> "object value") <* skipSpace
163+ ch <- A.satisfy (\w -> w == COMMA || w == CLOSE_CURLY) A.<?> "',' or '}'"
127164 let acc' = (k, v) : acc
128165 if ch == COMMA
129166 then skipSpace >> loop acc'
130− else return (H.fromList acc')
167+ else case mkObject acc' of
168+ Left err -> fail err
169+ Right obj -> pure obj
131170{-# INLINE objectValues #-}
132171
133−array_ :: Parser Value
134−array_ = {-# SCC "array_" #-} Array <$> arrayValues value
172+array_ :: Parser Value -> Parser Value
173+array_ val = {-# SCC "array_" #-} Array <$> arrayValues val
174+{-# INLINE array_ #-}
135175
136−array_' :: Parser Value
137−array_' = {-# SCC "array_'" #-} do
138− !vals <- arrayValues value'
176+array_' :: Parser Value -> Parser Value
177+array_' val = {-# SCC "array_'" #-} do
178+ !vals <- arrayValues val
139179 return (Array vals)
180+{-# INLINE array_' #-}
140181
141182arrayValues :: Parser Value -> Parser (Vector Value)
142183arrayValues val = do
@@ -147,57 +188,133 @@ arrayValues val = do
147188 else loop [] 1
148189 where
149190 loop acc !len = do
150− v <- val <* skipSpace
151− ch <- A.satisfy $ \w -> w == COMMA || w == CLOSE_SQUARE
191+ v <- (val A.<?> "json list value") <* skipSpace
192+ ch <- A.satisfy (\w -> w == COMMA || w == CLOSE_SQUARE) A.<?> "',' or ']'"
152193 if ch == COMMA
153194 then skipSpace >> loop (v:acc) (len+1)
154195 else return (Vector.reverse (Vector.fromListN len (v:acc)))
155196{-# INLINE arrayValues #-}
156197
157−-- | Parse any JSON value. You should usually 'json' in preference to
158−-- this function, as this function relaxes the object-or-array
159−-- requirement of RFC 4627.
160−--
161−-- In particular, be careful in using this function if you think your
162−-- code might interoperate with Javascript. A na&#xef;ve Javascript
163−-- library that parses JSON data using @eval@ is vulnerable to attack
164−-- unless the encoded data represents an object or an array. JSON
165−-- implementations in other languages conform to that same restriction
166−-- to preserve interoperability and security.
198+-- | Parse any JSON value. Synonym of 'json'.
167199value :: Parser Value
168−value = do
200+value = jsonWith (pure . H.fromList)
201+
202+-- | Parse any JSON value.
203+--
204+-- This parser is parameterized by a function to construct an 'Object'
205+-- from a raw list of key-value pairs, where duplicates are preserved.
206+-- The pairs appear in __reverse order__ from the source.
207+--
208+-- ==== __Examples__
209+--
210+-- 'json' keeps only the first occurence of each key, using 'HashMap.Lazy.fromList'.
211+--
212+-- @
213+-- 'json' = 'jsonWith' ('Right' '.' 'H.fromList')
214+-- @
215+--
216+-- 'jsonLast' keeps the last occurence of each key, using
217+-- @'HashMap.Lazy.fromListWith' ('const' 'id')@.
218+--
219+-- @
220+-- 'jsonLast' = 'jsonWith' ('Right' '.' 'HashMap.Lazy.fromListWith' ('const' 'id'))
221+-- @
222+--
223+-- 'jsonAccum' keeps wraps all values in arrays to keep duplicates, using
224+-- 'fromListAccum'.
225+--
226+-- @
227+-- 'jsonAccum' = 'jsonWith' ('Right' . 'fromListAccum')
228+-- @
229+--
230+-- 'jsonNoDup' fails if any object contains duplicate keys, using 'parseListNoDup'.
231+--
232+-- @
233+-- 'jsonNoDup' = 'jsonWith' 'parseListNoDup'
234+-- @
235+jsonWith :: ([(Text, Value)] -> Either String Object) -> Parser Value
236+jsonWith mkObject = fix $ \value_ -> do
169237 skipSpace
170238 w <- A.peekWord8'
171239 case w of
172240 DOUBLE_QUOTE -> A.anyWord8 *> (String <$> jstring_)
173− OPEN_CURLY -> A.anyWord8 *> object_
174− OPEN_SQUARE -> A.anyWord8 *> array_
175− C_f -> string "false" *> pure (Bool False)
176− C_t -> string "true" *> pure (Bool True)
177− C_n -> string "null" *> pure Null
241+ OPEN_CURLY -> A.anyWord8 *> object_ mkObject value_
242+ OPEN_SQUARE -> A.anyWord8 *> array_ value_
243+ C_f -> string "false" $> Bool False
244+ C_t -> string "true" $> Bool True
245+ C_n -> string "null" $> Null
178246 _ | w >= 48 && w <= 57 || w == 45
179247 -> Number <$> scientific
180248 | otherwise -> fail "not a valid json value"
249+{-# INLINE jsonWith #-}
250+
251+-- | Variant of 'json' which keeps only the last occurence of every key.
252+jsonLast :: Parser Value
253+jsonLast = jsonWith (Right . H.fromListWith (const id))
254+
255+-- | Variant of 'json' wrapping all object mappings in 'Array' to preserve
256+-- key-value pairs with the same keys.
257+jsonAccum :: Parser Value
258+jsonAccum = jsonWith (Right . fromListAccum)
181259
182−-- | Strict version of 'value'. See also 'json''.
260+-- | Variant of 'json' which fails if any object contains duplicate keys.
261+jsonNoDup :: Parser Value
262+jsonNoDup = jsonWith parseListNoDup
263+
264+-- | @'fromListAccum' kvs@ is an object mapping keys to arrays containing all
265+-- associated values from the original list @kvs@.
266+--
267+-- >>> fromListAccum [("apple", Bool True), ("apple", Bool False), ("orange", Bool False)]
268+-- fromList [("apple", [Bool False, Bool True]), ("orange", [Bool False])]
269+fromListAccum :: [(Text, Value)] -> Object
270+fromListAccum =
271+ fmap (Array . Vector.fromList . ($ [])) . H.fromListWith (.) . (fmap . fmap) (:)
272+
273+-- | @'fromListNoDup' kvs@ fails if @kvs@ contains duplicate keys.
274+parseListNoDup :: [(Text, Value)] -> Either String Object
275+parseListNoDup =
276+ H.traverseWithKey unwrap . H.fromListWith (\_ _ -> Nothing) . (fmap . fmap) Just
277+ where
278+ unwrap k Nothing = Left $ "found duplicate key: " ++ show k
279+ unwrap _ (Just v) = Right v
280+
281+-- | Strict version of 'value'. Synonym of 'json''.
183282value' :: Parser Value
184−value' = do
283+value' = jsonWith' (pure . H.fromList)
284+
285+-- | Strict version of 'jsonWith'.
286+jsonWith' :: ([(Text, Value)] -> Either String Object) -> Parser Value
287+jsonWith' mkObject = fix $ \value_ -> do
185288 skipSpace
186289 w <- A.peekWord8'
187290 case w of
188291 DOUBLE_QUOTE -> do
189292 !s <- A.anyWord8 *> jstring_
190293 return (String s)
191− OPEN_CURLY -> A.anyWord8 *> object_'
192− OPEN_SQUARE -> A.anyWord8 *> array_'
193− C_f -> string "false" *> pure (Bool False)
194− C_t -> string "true" *> pure (Bool True)
195− C_n -> string "null" *> pure Null
294+ OPEN_CURLY -> A.anyWord8 *> object_' mkObject value_
295+ OPEN_SQUARE -> A.anyWord8 *> array_' value_
296+ C_f -> string "false" $> Bool False
297+ C_t -> string "true" $> Bool True
298+ C_n -> string "null" $> Null
196299 _ | w >= 48 && w <= 57 || w == 45
197300 -> do
198301 !n <- scientific
199302 return (Number n)
200303 | otherwise -> fail "not a valid json value"
304+{-# INLINE jsonWith' #-}
305+
306+-- | Variant of 'json'' which keeps only the last occurence of every key.
307+jsonLast' :: Parser Value
308+jsonLast' = jsonWith' (pure . H.fromListWith (const id))
309+
310+-- | Variant of 'json'' wrapping all object mappings in 'Array' to preserve
311+-- key-value pairs with the same keys.
312+jsonAccum' :: Parser Value
313+jsonAccum' = jsonWith' (pure . fromListAccum)
314+
315+-- | Variant of 'json'' which fails if any object contains duplicate keys.
316+jsonNoDup' :: Parser Value
317+jsonNoDup' = jsonWith' parseListNoDup
201318
202319-- | Parse a quoted JSON string.
203320jstring :: Parser Text
@@ -207,23 +324,39 @@ jstring = A.word8 DOUBLE_QUOTE *> jstring_
207324jstring_ :: Parser Text
208325{-# INLINE jstring_ #-}
209326jstring_ = {-# SCC "jstring_" #-} do
327+#if MIN_VERSION_ghc_prim(0,3,1)
328+ (s, S _ escaped) <- A.runScanner startState go <* A.anyWord8
329+ -- We escape only if there are
330+ -- non-ascii (over 7bit) characters or backslash present.
331+ --
332+ -- Note: if/when text will have fast ascii -> text conversion
333+ -- (e.g. uses utf8 encoding) we can have further speedup.
334+ if isTrue# escaped
335+ then case unescapeText s of
336+ Right r -> return r
337+ Left err -> fail $ show err
338+ else return (TE.decodeUtf8 s)
339+ where
340+ startState = S 0# 0#
341+ go (S skip escaped) (W8# c)
342+ | isTrue# skip = Just (S 0# escaped')
343+ | isTrue# (w ==# 34#) = Nothing -- double quote
344+ | otherwise = Just (S skip' escaped')
345+ where
346+ w = word2Int# c
347+ skip' = w ==# 92# -- backslash
348+ escaped' = escaped
349+ `orI#` (w `andI#` 0x80# ==# 0x80#) -- c >= 0x80
350+ `orI#` skip'
351+ `orI#` (w `andI#` 0x1f# ==# w) -- c < 0x20
352+
353+data S = S Int# Int#
354+#else
210355 s <- A.scan startState go <* A.anyWord8
211356 case unescapeText s of
212357 Right r -> return r
213358 Left err -> fail $ show err
214359 where
215−#if MIN_VERSION_ghc_prim(0,3,1)
216− startState = S 0#
217− go (S a) (W8# c)
218− | isTrue# a = Just (S 0#)
219− | isTrue# (word2Int# c ==# 34#) = Nothing -- double quote
220− | otherwise = let a' = word2Int# c ==# 92# -- backslash
221− in Just (S a')
222−
223−data S = S Int#
224−-- This hint will no longer trigger once hlint > 1.9.41 is released.
225−{-# ANN S ("HLint: ignore Use newtype instead of data" :: String) #-}
226−#else
227360 startState = False
228361 go a c
229362 | a = Just False
@@ -257,7 +390,12 @@ eitherDecodeWith p to s =
257390 L.Done _ v -> case to v of
258391 ISuccess a -> Right a
259392 IError path msg -> Left (path, msg)
260− L.Fail _ _ msg -> Left ([], msg)
393+ L.Fail _ ctx msg -> Left ([], buildMsg ctx msg)
394+ where
395+ buildMsg :: [String] -> String -> String
396+ buildMsg [] msg = msg
397+ buildMsg (expectation:_) msg =
398+ msg ++ ". Expecting " ++ expectation
261399{-# INLINE eitherDecodeWith #-}
262400
263401eitherDecodeStrictWith :: Parser Value -> (Value -> IResult a) -> B.ByteString
@@ -310,14 +448,13 @@ data SP = SP !Integer {-# UNPACK #-}!Int
310448
311449decimal0 :: Parser Integer
312450decimal0 = do
313− let step a w = a * 10 + fromIntegral (w - zero)
314− zero = 48
451+ let zero = 48
315452 digits <- A.takeWhile1 isDigit_w8
316453 if B.length digits > 1 && B.unsafeHead digits == zero
317454 then fail "leading zero"
318− else return (B.foldl' step 0 digits)
455+ else return (bsToInteger digits)
319456
320−{-# INLINE scientific #-}
457+-- | Parse a JSON number.
321458scientific :: Parser Scientific
322459scientific = do
323460 let minus = 45
@@ -347,3 +484,54 @@ scientific = do
347484 (A.satisfy (\ex -> ex == littleE || ex == bigE) *>
348485 fmap (Sci.scientific signedCoeff . (e +)) (signed decimal)) <|>
349486 return (Sci.scientific signedCoeff e)
487+{-# INLINE scientific #-}
488+
489+------------------ Copy-pasted and adapted from base ------------------------
490+
491+bsToInteger :: B.ByteString -> Integer
492+bsToInteger bs
493+ | l > 40 = valInteger 10 l [ fromIntegral (w - 48) | w <- B.unpack bs ]
494+ | otherwise = bsToIntegerSimple bs
495+ where
496+ l = B.length bs
497+
498+bsToIntegerSimple :: B.ByteString -> Integer
499+bsToIntegerSimple = B.foldl' step 0 where
500+ step a b = a * 10 + fromIntegral (b - 48) -- 48 = '0'
501+
502+-- A sub-quadratic algorithm for Integer. Pairs of adjacent radix b
503+-- digits are combined into a single radix b^2 digit. This process is
504+-- repeated until we are left with a single digit. This algorithm
505+-- performs well only on large inputs, so we use the simple algorithm
506+-- for smaller inputs.
507+valInteger :: Integer -> Int -> [Integer] -> Integer
508+valInteger = go
509+ where
510+ go :: Integer -> Int -> [Integer] -> Integer
511+ go _ _ [] = 0
512+ go _ _ [d] = d
513+ go b l ds
514+ | l > 40 = b' `seq` go b' l' (combine b ds')
515+ | otherwise = valSimple b ds
516+ where
517+ -- ensure that we have an even number of digits
518+ -- before we call combine:
519+ ds' = if even l then ds else 0 : ds
520+ b' = b * b
521+ l' = (l + 1) `quot` 2
522+
523+ combine b (d1 : d2 : ds) = d `seq` (d : combine b ds)
524+ where
525+ d = d1 * b + d2
526+ combine _ [] = []
527+ combine _ [_] = errorWithoutStackTrace "this should not happen"
528+
529+-- The following algorithm is only linear for types whose Num operations
530+-- are in constant time.
531+valSimple :: Integer -> [Integer] -> Integer
532+valSimple base = go 0
533+ where
534+ go r [] = r
535+ go r (d : ds) = r' `seq` go r' ds
536+ where
537+ r' = r * base + fromIntegral d
Data/Aeson/Parser/Time.hs+18−103
@@ -1,15 +1,4 @@
1−{-# LANGUAGE BangPatterns #-}
2−{-# LANGUAGE ScopedTypeVariables #-}
3−
4−-- |
5−-- Module: Data.Aeson.Parser.Time
6−-- Copyright: (c) 2015-2016 Bryan O'Sullivan
7−-- License: BSD3
8−-- Maintainer: Bryan O'Sullivan <bos@serpentine.com>
9−-- Stability: experimental
10−-- Portability: portable
11−--
12−-- Parsers for parsing dates and times.
1+{-# LANGUAGE NoImplicitPrelude #-}
132
143module Data.Aeson.Parser.Time
154 (
@@ -22,123 +11,51 @@ module Data.Aeson.Parser.Time
2211 , zonedTime
2312 ) where
2413
25−import Prelude ()
2614import Prelude.Compat
2715
28−import Control.Applicative ((<|>))
29−import Control.Monad (void, when)
30−import Data.Aeson.Internal.Time (toPico)
31−import Data.Attoparsec.Text as A
32−import Data.Bits ((.&.))
33−import Data.Char (isDigit, ord)
34−import Data.Fixed (Pico)
35−import Data.Int (Int64)
36−import Data.Maybe (fromMaybe)
16+import Data.Attoparsec.Text (Parser)
3717import Data.Text (Text)
38−import Data.Time.Calendar (Day, fromGregorianValid)
18+import Data.Time.Calendar (Day)
3919import Data.Time.Clock (UTCTime(..))
4020import qualified Data.Aeson.Types.Internal as Aeson
41−import qualified Data.Text as T
21+import qualified Data.Attoparsec.Text as A
22+import qualified Data.Attoparsec.Time as T
4223import qualified Data.Time.LocalTime as Local
4324
4425-- | Run an attoparsec parser as an aeson parser.
4526run :: Parser a -> Text -> Aeson.Parser a
46−run p t = case A.parseOnly (p <* endOfInput) t of
27+run p t = case A.parseOnly (p <* A.endOfInput) t of
4728 Left err -> fail $ "could not parse date: " ++ err
4829 Right r -> return r
4930
5031-- | Parse a date of the form @[+,-]YYYY-MM-DD@.
5132day :: Parser Day
52−day = do
53− absOrNeg <- negate <$ char '-' <|> id <$ char '+' <|> pure id
54− y <- decimal <* char '-'
55− m <- twoDigits <* char '-'
56− d <- twoDigits
57− maybe (fail "invalid date") return (fromGregorianValid (absOrNeg y) m d)
58−
59−-- | Parse a two-digit integer (e.g. day of month, hour).
60−twoDigits :: Parser Int
61−twoDigits = do
62− a <- digit
63− b <- digit
64− let c2d c = ord c .&. 15
65− return $! c2d a * 10 + c2d b
33+day = T.day
34+{-# INLINE day #-}
6635
6736-- | Parse a time of the form @HH:MM[:SS[.SSS]]@.
6837timeOfDay :: Parser Local.TimeOfDay
69−timeOfDay = do
70− h <- twoDigits
71− m <- char ':' *> twoDigits
72− s <- option 0 (char ':' *> seconds)
73− if h < 24 && m < 60 && s < 61
74− then return (Local.TimeOfDay h m s)
75− else fail "invalid time"
76−
77−data T = T {-# UNPACK #-} !Int {-# UNPACK #-} !Int64
78−
79−-- | Parse a count of seconds, with the integer part being two digits
80−-- long.
81−seconds :: Parser Pico
82−seconds = do
83− real <- twoDigits
84− mc <- peekChar
85− case mc of
86− Just '.' -> do
87− t <- anyChar *> takeWhile1 isDigit
88− return $! parsePicos real t
89− _ -> return $! fromIntegral real
90− where
91− parsePicos a0 t = toPico (fromIntegral (t' * 10^n))
92− where T n t' = T.foldl' step (T 12 (fromIntegral a0)) t
93− step ma@(T m a) c
94− | m <= 0 = ma
95− | otherwise = T (m-1) (10 * a + fromIntegral (ord c) .&. 15)
38+timeOfDay = T.timeOfDay
39+{-# INLINE timeOfDay #-}
9640
9741-- | Parse a time zone, and return 'Nothing' if the offset from UTC is
9842-- zero. (This makes some speedups possible.)
9943timeZone :: Parser (Maybe Local.TimeZone)
100−timeZone = do
101− let maybeSkip c = do ch <- peekChar'; when (ch == c) (void anyChar)
102− maybeSkip ' '
103− ch <- satisfy $ \c -> c == 'Z' || c == '+' || c == '-'
104− if ch == 'Z'
105− then return Nothing
106− else do
107− h <- twoDigits
108− mm <- peekChar
109− m <- case mm of
110− Just ':' -> anyChar *> twoDigits
111− Just d | isDigit d -> twoDigits
112− _ -> return 0
113− let off | ch == '-' = negate off0
114− | otherwise = off0
115− off0 = h * 60 + m
116− case undefined of
117− _ | off == 0 ->
118− return Nothing
119− | off < -720 || off > 840 || m > 59 ->
120− fail "invalid time zone offset"
121− | otherwise ->
122− let !tz = Local.minutesToTimeZone off
123− in return (Just tz)
44+timeZone = T.timeZone
45+{-# INLINE timeZone #-}
12446
12547-- | Parse a date and time, of the form @YYYY-MM-DD HH:MM[:SS[.SSS]]@.
12648-- The space may be replaced with a @T@. The number of seconds is optional
12749-- and may be followed by a fractional component.
12850localTime :: Parser Local.LocalTime
129−localTime = Local.LocalTime <$> day <* daySep <*> timeOfDay
130− where daySep = satisfy (\c -> c == 'T' || c == ' ')
51+localTime = T.localTime
52+{-# INLINE localTime #-}
13153
13254-- | Behaves as 'zonedTime', but converts any time zone offset into a
13355-- UTC time.
13456utcTime :: Parser UTCTime
135−utcTime = do
136− lt@(Local.LocalTime d t) <- localTime
137− mtz <- timeZone
138− case mtz of
139− Nothing -> let !tt = Local.timeOfDayToTime t
140− in return (UTCTime d tt)
141− Just tz -> return $! Local.localTimeToUTC tz lt
57+utcTime = T.utcTime
58+{-# INLINE utcTime #-}
14259
14360-- | Parse a date with time zone info. Acceptable formats:
14461--
@@ -152,7 +69,5 @@ utcTime = do
15269-- two digits are hours, the @:@ is optional and the second two digits
15370-- (also optional) are minutes.
15471zonedTime :: Parser Local.ZonedTime
155−zonedTime = Local.ZonedTime <$> localTime <*> (fromMaybe utc <$> timeZone)
156−
157−utc :: Local.TimeZone
158−utc = Local.TimeZone 0 False ""
72+zonedTime = T.zonedTime
73+{-# INLINE zonedTime #-}
Data/Aeson/QQ/Simple.hsnew file+25
@@ -0,0 +1,25 @@
1+-- | Like "Data.Aeson.QQ" but without interpolation.
2+module Data.Aeson.QQ.Simple (aesonQQ) where
3+
4+import Data.Aeson
5+import qualified Data.Text as T
6+import qualified Data.Text.Encoding as TE
7+import Language.Haskell.TH
8+import Language.Haskell.TH.Quote
9+import Language.Haskell.TH.Syntax (Lift (..))
10+import Prelude ()
11+import Prelude.Compat
12+
13+aesonQQ :: QuasiQuoter
14+aesonQQ = QuasiQuoter
15+ { quoteExp = aesonExp
16+ , quotePat = const $ error "No quotePat defined for jsonQQ"
17+ , quoteType = const $ error "No quoteType defined for jsonQQ"
18+ , quoteDec = const $ error "No quoteDec defined for jsonQQ"
19+ }
20+
21+aesonExp :: String -> ExpQ
22+aesonExp txt =
23+ case eitherDecodeStrict $ TE.encodeUtf8 $ T.pack txt of
24+ Left err -> error $ "Error in aesonExp: " ++ show err
25+ Right val -> lift (val :: Value)
Data/Aeson/TH.hs+436−860
@@ -85,7 +85,6 @@ $('deriveJSON' 'defaultOptions' ''(,,,))
8585@
8686
8787-}
88−
8988module Data.Aeson.TH
9089 (
9190 -- * Encoding configuration
@@ -117,49 +116,42 @@ module Data.Aeson.TH
117116 , mkLiftParseJSON2
118117 ) where
119118
120−import Prelude ()
121−import Prelude.Compat hiding (exp)
119+import Prelude.Compat
122120
123121import Control.Applicative ((<|>))
124−import Data.Aeson (Object, (.=), (.:), FromJSON(..), FromJSON1(..), FromJSON2(..), ToJSON(..), ToJSON1(..), ToJSON2(..))
122+import Data.Aeson (Object, (.:), FromJSON(..), FromJSON1(..), FromJSON2(..), ToJSON(..), ToJSON1(..), ToJSON2(..))
125123import Data.Aeson.Types (Options(..), Parser, SumEncoding(..), Value(..), defaultOptions, defaultTaggedObject)
126−import Data.Aeson.Types.Internal ((<?>), Pair, JSONPathElement(Key))
124+import Data.Aeson.Types.Internal ((<?>), JSONPathElement(Key))
127125import Data.Aeson.Types.FromJSON (parseOptionalFieldWith)
126+import Data.Aeson.Types.ToJSON (fromPairs, pair)
128127import Control.Monad (liftM2, unless, when)
129128import Data.Foldable (foldr')
130129#if MIN_VERSION_template_haskell(2,8,0) && !MIN_VERSION_template_haskell(2,10,0)
131130import Data.List (nub)
132131#endif
133−import Data.List (find, foldl', genericLength , intercalate , intersperse, partition, union)
132+import Data.List (foldl', genericLength, intercalate, partition, union)
134133import Data.List.NonEmpty ((<|), NonEmpty((:|)))
135134import Data.Map (Map)
136135import Data.Maybe (catMaybes, fromMaybe, mapMaybe)
136+import qualified Data.Monoid as Monoid
137137import Data.Set (Set)
138−#if MIN_VERSION_template_haskell(2,8,0)
139138import Language.Haskell.TH hiding (Arity)
140−#else
141−import Language.Haskell.TH
142−#endif
143−import Language.Haskell.TH.Syntax (VarStrictType)
144−#if MIN_VERSION_template_haskell(2,7,0) && !(MIN_VERSION_template_haskell(2,8,0))
145−import Language.Haskell.TH.Lib (starK)
146−#endif
139+import Language.Haskell.TH.Datatype
147140#if MIN_VERSION_template_haskell(2,8,0) && !(MIN_VERSION_template_haskell(2,10,0))
148141import Language.Haskell.TH.Syntax (mkNameG_tc)
149142#endif
150143import Text.Printf (printf)
151−import qualified Data.Aeson as A
152144import qualified Data.Aeson.Encoding.Internal as E
153145import qualified Data.Foldable as F (all)
154−import qualified Data.HashMap.Strict as H (lookup, toList)
155−import qualified Data.List.NonEmpty as NE (drop, length, reverse, splitAt)
156−import qualified Data.Map as M (fromList, findWithDefault, keys, lookup , singleton, size)
146+import qualified Data.HashMap.Strict as H (difference, fromList, keys, lookup, toList)
147+import qualified Data.List.NonEmpty as NE (length, reverse)
148+import qualified Data.Map as M (fromList, keys, lookup , singleton, size)
149+import qualified Data.Semigroup as Semigroup (Option(..))
157150import qualified Data.Set as Set (empty, insert, member)
158151import qualified Data.Text as T (Text, pack, unpack)
159−import qualified Data.Vector as V (unsafeIndex, null, length, create, fromList)
152+import qualified Data.Vector as V (unsafeIndex, null, length, create, empty)
160153import qualified Data.Vector.Mutable as VM (unsafeNew, unsafeWrite)
161154
162−
163155--------------------------------------------------------------------------------
164156-- Convenience
165157--------------------------------------------------------------------------------
@@ -253,8 +245,8 @@ deriveToJSONCommon :: JSONClass
253245 -> Name
254246 -- ^ Name of the type for which to generate an instance.
255247 -> Q [Dec]
256−deriveToJSONCommon = deriveJSONClass [ (ToJSON, \jc _ -> consToValue jc)
257− , (ToEncoding, \jc _ -> consToEncoding jc)
248+deriveToJSONCommon = deriveJSONClass [ (ToJSON, \jc _ -> consToValue Value jc)
249+ , (ToEncoding, \jc _ -> consToValue Encoding jc)
258250 ]
259251
260252-- | Generates a lambda expression which encodes the given data type or
@@ -284,7 +276,7 @@ mkToJSONCommon :: JSONClass -- ^ Which class's method is being derived.
284276 -> Options -- ^ Encoding options.
285277 -> Name -- ^ Name of the encoded type.
286278 -> Q Exp
287−mkToJSONCommon = mkFunCommon (\jc _ -> consToValue jc)
279+mkToJSONCommon = mkFunCommon (\jc _ -> consToValue Value jc)
288280
289281-- | Generates a lambda expression which encodes the given data type or
290282-- data family instance constructor as a JSON string.
@@ -313,385 +305,272 @@ mkToEncodingCommon :: JSONClass -- ^ Which class's method is being derived.
313305 -> Options -- ^ Encoding options.
314306 -> Name -- ^ Name of the encoded type.
315307 -> Q Exp
316−mkToEncodingCommon = mkFunCommon (\jc _ -> consToEncoding jc)
308+mkToEncodingCommon = mkFunCommon (\jc _ -> consToValue Encoding jc)
317309
318310-- | Helper function used by both 'deriveToJSON' and 'mkToJSON'. Generates
319−-- code to generate a 'Value' of a number of constructors. All constructors
320−-- must be from the same type.
321−consToValue :: JSONClass
311+-- code to generate a 'Value' or 'Encoding' of a number of constructors. All
312+-- constructors must be from the same type.
313+consToValue :: ToJSONFun
314+ -- ^ The method ('toJSON' or 'toEncoding') being derived.
315+ -> JSONClass
322316 -- ^ The ToJSON variant being derived.
323317 -> Options
324318 -- ^ Encoding options.
325− -> [Con]
319+ -> [Type]
320+ -- ^ The types from the data type/data family instance declaration
321+ -> [ConstructorInfo]
326322 -- ^ Constructors for which to generate JSON generating code.
327323 -> Q Exp
328324
329−consToValue _ _ [] = error $ "Data.Aeson.TH.consToValue: "
330− ++ "Not a single constructor given!"
325+consToValue _ _ _ _ [] = error $ "Data.Aeson.TH.consToValue: "
326+ ++ "Not a single constructor given!"
331327
332−consToValue jc opts cons = do
328+consToValue target jc opts instTys cons = do
333329 value <- newName "value"
334330 tjs <- newNameList "_tj" $ arityInt jc
335331 tjls <- newNameList "_tjl" $ arityInt jc
336332 let zippedTJs = zip tjs tjls
337333 interleavedTJs = interleave tjs tjls
334+ lastTyVars = map varTToName $ drop (length instTys - arityInt jc) instTys
335+ tvMap = M.fromList $ zip lastTyVars zippedTJs
338336 lamE (map varP $ interleavedTJs ++ [value]) $
339− caseE (varE value) (matches zippedTJs)
337+ caseE (varE value) (matches tvMap)
340338 where
341− matches tjs = case cons of
339+ matches tvMap = case cons of
342340 -- A single constructor is directly encoded. The constructor itself may be
343341 -- forgotten.
344− [con] | not (tagSingleConstructors opts) -> [argsToValue jc tjs opts False con]
342+ [con] | not (tagSingleConstructors opts) -> [argsToValue target jc tvMap opts False con]
345343 _ | allNullaryToStringTag opts && all isNullary cons ->
346− [ match (conP conName []) (normalB $ conStr opts conName) []
344+ [ match (conP conName []) (normalB $ conStr target opts conName) []
347345 | con <- cons
348− , let conName = getConName con
346+ , let conName = constructorName con
349347 ]
350− | otherwise -> [argsToValue jc tjs opts True con | con <- cons]
348+ | otherwise -> [argsToValue target jc tvMap opts True con | con <- cons]
351349
352−conStr :: Options -> Name -> Q Exp
353−conStr opts = appE [|String|] . conTxt opts
350+-- | Name of the constructor as a quoted 'Value' or 'Encoding'.
351+conStr :: ToJSONFun -> Options -> Name -> Q Exp
352+conStr Value opts = appE [|String|] . conTxt opts
353+conStr Encoding opts = appE [|E.text|] . conTxt opts
354354
355+-- | Name of the constructor as a quoted 'Text'.
355356conTxt :: Options -> Name -> Q Exp
356−conTxt opts = appE [|T.pack|] . conStringE opts
357−
358−conStringE :: Options -> Name -> Q Exp
359−conStringE opts = stringE . constructorTagModifier opts . nameBase
360−
361−-- | Helper function used by both 'deriveToJSON' and 'mkToEncoding'. Generates
362−-- code to write out a value for a number of constructors. All constructors
363−-- must be from the same type.
364−consToEncoding :: JSONClass
365− -- ^ The ToJSON variant being derived.
366− -> Options
367− -- ^ Encoding options.
368− -> [Con]
369− -- ^ Constructors for which to generate JSON generating code.
370− -> Q Exp
371−
372−consToEncoding _ _ [] = error $ "Data.Aeson.TH.consToEncoding: "
373− ++ "Not a single constructor given!"
374−
375−consToEncoding jc opts cons = do
376− value <- newName "value"
377− tes <- newNameList "_te" $ arityInt jc
378− tels <- newNameList "_tel" $ arityInt jc
379− let zippedTEs = zip tes tels
380− interleavedTEs = interleave tes tels
381− lamE (map varP $ interleavedTEs ++ [value]) $
382− caseE (varE value) (matches zippedTEs)
383− where
384− matches tes = case cons of
385− -- A single constructor is directly encoded. The constructor itself may be
386− -- forgotten.
387− [con] | not (tagSingleConstructors opts) -> [argsToEncoding jc tes opts False con]
388− -- Encode just the name of the constructor of a sum type iff all the
389− -- constructors are nullary.
390− _ | allNullaryToStringTag opts && all isNullary cons ->
391− [ match (conP conName [])
392− (normalB $ encStr opts conName) []
393− | con <- cons
394− , let conName = getConName con
395− ]
396− | otherwise -> [argsToEncoding jc tes opts True con | con <- cons]
357+conTxt opts = appE [|T.pack|] . stringE . conString opts
397358
398−encStr :: Options -> Name -> Q Exp
399−encStr opts = appE [|E.text|] . conTxt opts
359+-- | Name of the constructor.
360+conString :: Options -> Name -> String
361+conString opts = constructorTagModifier opts . nameBase
400362
401363-- | If constructor is nullary.
402−isNullary :: Con -> Bool
403−isNullary (NormalC _ []) = True
364+isNullary :: ConstructorInfo -> Bool
365+isNullary ConstructorInfo { constructorVariant = NormalConstructor
366+ , constructorFields = tys } = null tys
404367isNullary _ = False
405368
406−sumToValue :: Options -> Bool -> Bool -> Name -> Q Exp -> Q Exp
407−sumToValue opts multiCons nullary conName exp
369+-- | Wrap fields of a non-record constructor. See 'sumToValue'.
370+opaqueSumToValue :: ToJSONFun -> Options -> Bool -> Bool -> Name -> ExpQ -> ExpQ
371+opaqueSumToValue target opts multiCons nullary conName value =
372+ sumToValue target opts multiCons nullary conName
373+ value
374+ pairs
375+ where
376+ pairs contentsFieldName = pairE contentsFieldName value
377+
378+-- | Wrap fields of a record constructor. See 'sumToValue'.
379+recordSumToValue :: ToJSONFun -> Options -> Bool -> Bool -> Name -> ExpQ -> ExpQ
380+recordSumToValue target opts multiCons nullary conName pairs =
381+ sumToValue target opts multiCons nullary conName
382+ (fromPairsE pairs)
383+ (const pairs)
384+
385+-- | Wrap fields of a constructor.
386+sumToValue
387+ :: ToJSONFun
388+ -- ^ The method being derived.
389+ -> Options
390+ -- ^ Deriving options.
391+ -> Bool
392+ -- ^ Does this type have multiple constructors.
393+ -> Bool
394+ -- ^ Is this constructor nullary.
395+ -> Name
396+ -- ^ Constructor name.
397+ -> ExpQ
398+ -- ^ Fields of the constructor as a 'Value' or 'Encoding'.
399+ -> (String -> ExpQ)
400+ -- ^ Representation of an 'Object' fragment used for the 'TaggedObject'
401+ -- variant; of type @[(Text,Value)]@ or @[Encoding]@, depending on the method
402+ -- being derived.
403+ --
404+ -- - For non-records, produces a pair @"contentsFieldName":value@,
405+ -- given a @contentsFieldName@ as an argument. See 'opaqueSumToValue'.
406+ -- - For records, produces the list of pairs corresponding to fields of the
407+ -- encoded value (ignores the argument). See 'recordSumToValue'.
408+ -> ExpQ
409+sumToValue target opts multiCons nullary conName value pairs
408410 | multiCons =
409411 case sumEncoding opts of
410412 TwoElemArray ->
411− [|Array|] `appE` ([|V.fromList|] `appE` listE [conStr opts conName, exp])
413+ array target [conStr target opts conName, value]
412414 TaggedObject{tagFieldName, contentsFieldName} ->
413− let tag = infixApp [|T.pack tagFieldName|] [|(.=)|] (conStr opts conName)
414− contents = infixApp [|T.pack contentsFieldName|] [|(.=)|] exp
415− in
416− [|A.object|] `appE` listE (if nullary then [tag] else [tag, contents])
415+ -- TODO: Maybe throw an error in case
416+ -- tagFieldName overwrites a field in pairs.
417+ let tag = pairE tagFieldName (conStr target opts conName)
418+ content = pairs contentsFieldName
419+ in fromPairsE $
420+ if nullary then tag else infixApp tag [|(Monoid.<>)|] content
417421 ObjectWithSingleField ->
418− [|A.object|] `appE` listE
419− [ infixApp (conTxt opts conName) [|(.=)|] exp
420− ]
421− UntaggedValue | nullary -> conStr opts conName
422− UntaggedValue -> exp
423− | otherwise = exp
422+ objectE [(conString opts conName, value)]
423+ UntaggedValue | nullary -> conStr target opts conName
424+ UntaggedValue -> value
425+ | otherwise = value
424426
425427-- | Generates code to generate the JSON encoding of a single constructor.
426−argsToValue :: JSONClass -> [(Name, Name)] -> Options -> Bool -> Con -> Q Match
428+argsToValue :: ToJSONFun -> JSONClass -> TyVarMap -> Options -> Bool -> ConstructorInfo -> Q Match
427429
428430-- Polyadic constructors with special case for unary constructors.
429−argsToValue jc tjs opts multiCons (NormalC conName ts) = do
430− (argTys, tvMap) <- reifyConTys jc tjs conName
431− let len = length ts
431+argsToValue target jc tvMap opts multiCons
432+ ConstructorInfo { constructorName = conName
433+ , constructorVariant = NormalConstructor
434+ , constructorFields = argTys } = do
435+ argTys' <- mapM resolveTypeSynonyms argTys
436+ let len = length argTys'
432437 args <- newNameList "arg" len
433− js <- case [ dispatchToJSON jc conName tvMap argTy
434− `appE` varE arg
435− | (arg, argTy) <- zip args argTys
436− ] of
437− -- Single argument is directly converted.
438− [e] -> return e
439− -- Multiple arguments are converted to a JSON array.
440− es -> do
441− mv <- newName "mv"
442− let newMV = bindS (varP mv)
443− ([|VM.unsafeNew|] `appE`
444− litE (integerL $ fromIntegral len))
445− stmts = [ noBindS $
446− [|VM.unsafeWrite|] `appE`
447− varE mv `appE`
448− litE (integerL ix) `appE`
449− e
450− | (ix, e) <- zip [(0::Integer)..] es
451− ]
452− ret = noBindS $ [|return|] `appE` varE mv
453− return $ [|Array|] `appE`
454− (varE 'V.create `appE`
455− doE (newMV:stmts++[ret]))
438+ let js = case [ dispatchToJSON target jc conName tvMap argTy
439+ `appE` varE arg
440+ | (arg, argTy) <- zip args argTys'
441+ ] of
442+ -- Single argument is directly converted.
443+ [e] -> e
444+ -- Zero and multiple arguments are converted to a JSON array.
445+ es -> array target es
446+
456447 match (conP conName $ map varP args)
457− (normalB $ sumToValue opts multiCons (null ts) conName js)
448+ (normalB $ opaqueSumToValue target opts multiCons (null argTys') conName js)
458449 []
459450
460451-- Records.
461−argsToValue jc tjs opts multiCons (RecC conName ts) = case (unwrapUnaryRecords opts, not multiCons, ts) of
462− (True,True,[(_,st,ty)]) -> argsToValue jc tjs opts multiCons (NormalC conName [(st,ty)])
463− _ -> do
464− (argTys, tvMap) <- reifyConTys jc tjs conName
465− args <- newNameList "arg" $ length ts
466− let exp = [|A.object|] `appE` pairs
467−
468− pairs | omitNothingFields opts = infixApp maybeFields
469− [|(++)|]
470− restFields
471− | otherwise = listE $ map toPair argCons
472−
473− argCons = zip3 args argTys ts
474−
475− maybeFields = [|catMaybes|] `appE` listE (map maybeToPair maybes)
476−
477− restFields = listE $ map toPair rest
478−
479− (maybes, rest) = partition isMaybe argCons
480−
481− maybeToPair (arg, argTy, (field, _, _)) =
482− infixApp ([|keyValuePairWith|]
483− `appE` dispatchToJSON jc conName tvMap argTy
484− `appE` toFieldName field)
485− [|(<$>)|]
486− (varE arg)
487−
488− toPair (arg, argTy, (field, _, _)) =
489− [|keyValuePairWith|]
490− `appE` dispatchToJSON jc conName tvMap argTy
491− `appE` toFieldName field
492− `appE` varE arg
493−
494− toFieldName field = [|T.pack|] `appE` fieldLabelExp opts field
495−
496− match (conP conName $ map varP args)
497− ( normalB
498− $ if multiCons
499− then case sumEncoding opts of
500− TwoElemArray -> [|toJSON|] `appE` tupE [conStr opts conName, exp]
501− TaggedObject{tagFieldName} ->
502− [|A.object|] `appE`
503− -- TODO: Maybe throw an error in case
504− -- tagFieldName overwrites a field in pairs.
505− infixApp (infixApp [|T.pack tagFieldName|]
506− [|(.=)|]
507− (conStr opts conName))
508− [|(:)|]
509− pairs
510− ObjectWithSingleField ->
511− [|A.object|] `appE` listE
512− [ infixApp (conTxt opts conName) [|(.=)|] exp ]
513− UntaggedValue -> exp
514− else exp
515− ) []
452+argsToValue target jc tvMap opts multiCons
453+ info@ConstructorInfo { constructorName = conName
454+ , constructorVariant = RecordConstructor fields
455+ , constructorFields = argTys } =
456+ case (unwrapUnaryRecords opts, not multiCons, argTys) of
457+ (True,True,[_]) -> argsToValue target jc tvMap opts multiCons
458+ (info{constructorVariant = NormalConstructor})
459+ _ -> do
460+ argTys' <- mapM resolveTypeSynonyms argTys
461+ args <- newNameList "arg" $ length argTys'
462+ let pairs | omitNothingFields opts = infixApp maybeFields
463+ [|(Monoid.<>)|]
464+ restFields
465+ | otherwise = mconcatE (map pureToPair argCons)
466+
467+ argCons = zip3 (map varE args) argTys' fields
468+
469+ maybeFields = mconcatE (map maybeToPair maybes)
470+
471+ restFields = mconcatE (map pureToPair rest)
472+
473+ (maybes0, rest0) = partition isMaybe argCons
474+ (options, rest) = partition isOption rest0
475+ maybes = maybes0 ++ map optionToMaybe options
476+
477+ maybeToPair = toPairLifted True
478+ pureToPair = toPairLifted False
479+
480+ toPairLifted lifted (arg, argTy, field) =
481+ let toValue = dispatchToJSON target jc conName tvMap argTy
482+ fieldName = fieldLabel opts field
483+ e arg' = pairE fieldName (toValue `appE` arg')
484+ in if lifted
485+ then do
486+ x <- newName "x"
487+ [|maybe mempty|] `appE` lam1E (varP x) (e (varE x)) `appE` arg
488+ else e arg
489+
490+ match (conP conName $ map varP args)
491+ (normalB $ recordSumToValue target opts multiCons (null argTys) conName pairs)
492+ []
516493
517494-- Infix constructors.
518−argsToValue jc tjs opts multiCons (InfixC _ conName _) = do
519− ([alTy, arTy], tvMap) <- reifyConTys jc tjs conName
495+argsToValue target jc tvMap opts multiCons
496+ ConstructorInfo { constructorName = conName
497+ , constructorVariant = InfixConstructor
498+ , constructorFields = argTys } = do
499+ [alTy, arTy] <- mapM resolveTypeSynonyms argTys
520500 al <- newName "argL"
521501 ar <- newName "argR"
522502 match (infixP (varP al) conName (varP ar))
523503 ( normalB
524− $ sumToValue opts multiCons False conName
525− $ [|toJSON|] `appE` listE [ dispatchToJSON jc conName tvMap aTy
526− `appE` varE a
527− | (a, aTy) <- [(al,alTy), (ar,arTy)]
528− ]
504+ $ opaqueSumToValue target opts multiCons False conName
505+ $ array target
506+ [ dispatchToJSON target jc conName tvMap aTy
507+ `appE` varE a
508+ | (a, aTy) <- [(al,alTy), (ar,arTy)]
509+ ]
529510 )
530511 []
531−-- Existentially quantified constructors.
532−argsToValue jc tjs opts multiCons (ForallC _ _ con) =
533− argsToValue jc tjs opts multiCons con
534512
535−#if MIN_VERSION_template_haskell(2,11,0)
536−-- GADTs.
537−argsToValue jc tjs opts multiCons (GadtC conNames ts _) =
538− argsToValue jc tjs opts multiCons $ NormalC (head conNames) ts
513+isMaybe :: (a, Type, b) -> Bool
514+isMaybe (_, AppT (ConT t) _, _) = t == ''Maybe
515+isMaybe _ = False
539516
540−argsToValue jc tjs opts multiCons (RecGadtC conNames ts _) =
541− argsToValue jc tjs opts multiCons $ RecC (head conNames) ts
542−#endif
517+isOption :: (a, Type, b) -> Bool
518+isOption (_, AppT (ConT t) _, _) = t == ''Semigroup.Option
519+isOption _ = False
543520
544−isMaybe :: (a, b, (c, d, Type)) -> Bool
545−isMaybe (_, _, (_, _, AppT (ConT t) _)) = t == ''Maybe
546−isMaybe _ = False
521+optionToMaybe :: (ExpQ, b, c) -> (ExpQ, b, c)
522+optionToMaybe (a, b, c) = ([|Semigroup.getOption|] `appE` a, b, c)
547523
548524(<^>) :: ExpQ -> ExpQ -> ExpQ
549525(<^>) a b = infixApp a [|(E.><)|] b
550526infixr 6 <^>
551527
552−(<:>) :: ExpQ -> ExpQ -> ExpQ
553−(<:>) a b = a <^> [|E.colon|] <^> b
554−infixr 5 <:>
555−
556528(<%>) :: ExpQ -> ExpQ -> ExpQ
557529(<%>) a b = a <^> [|E.comma|] <^> b
558530infixr 4 <%>
559531
560−array :: ExpQ -> ExpQ
561−array exp = [|E.wrapArray|] `appE` exp
562−
563−object :: ExpQ -> ExpQ
564−object exp = [|E.wrapObject|] `appE` exp
565−
566−sumToEncoding :: Options -> Bool -> Bool -> Name -> Q Exp -> Q Exp
567−sumToEncoding opts multiCons nullary conName exp
568− | multiCons =
569− let fexp = exp in
570− case sumEncoding opts of
571− TwoElemArray ->
572− array (encStr opts conName <%> fexp)
573− TaggedObject{tagFieldName, contentsFieldName} ->
574− let tag = [|E.text (T.pack tagFieldName)|] <:> encStr opts conName
575− contents = [|E.text (T.pack contentsFieldName)|] <:> fexp
576− in
577− object $
578− if nullary then tag else tag <%> contents
579− ObjectWithSingleField ->
580− object (encStr opts conName <:> fexp)
581− UntaggedValue | nullary -> encStr opts conName
582− UntaggedValue -> exp
583− | otherwise = exp
584−
585−-- | Generates code to generate the JSON encoding of a single constructor.
586−argsToEncoding :: JSONClass -> [(Name, Name)] -> Options -> Bool -> Con -> Q Match
587−
588−-- Polyadic constructors with special case for unary constructors.
589−argsToEncoding jc tes opts multiCons (NormalC conName ts) = do
590− (argTys, tvMap) <- reifyConTys jc tes conName
591− let len = length ts
592− args <- newNameList "arg" len
593− js <- case zip args argTys of
594− -- Nullary constructors are converted to an empty array.
595− [] -> return [| E.emptyArray_ |]
596−
597− -- Single argument is directly converted.
598− [(e,eTy)] -> return (dispatchToEncoding jc conName tvMap eTy
599− `appE` varE e)
600− -- Multiple arguments are converted to a JSON array.
601− es ->
602− return (array (foldr1 (<%>) [ dispatchToEncoding jc conName tvMap xTy
603− `appE` varE x
604− | (x,xTy) <- es
605− ]))
606− match (conP conName $ map varP args)
607− (normalB $ sumToEncoding opts multiCons (null ts) conName js)
608− []
609−
610−-- Records.
611−argsToEncoding jc tes opts multiCons (RecC conName ts) = case (unwrapUnaryRecords opts, not multiCons, ts) of
612− (True,True,[(_,st,ty)]) -> argsToEncoding jc tes opts multiCons (NormalC conName [(st,ty)])
613− _ -> do
614− args <- newNameList "arg" $ length ts
615− (argTys, tvMap) <- reifyConTys jc tes conName
616− let exp = object objBody
617−
618− objBody = [|E.econcat|] `appE`
619− ([|intersperse E.comma|] `appE` pairs)
620− pairs | omitNothingFields opts = infixApp maybeFields
621− [|(++)|]
622− restFields
623− | otherwise = listE (map toPair argCons)
624−
625− argCons = zip3 args argTys ts
626−
627− maybeFields = [|catMaybes|] `appE` listE (map maybeToPair maybes)
628−
629− restFields = listE (map toPair rest)
630−
631− (maybes, rest) = partition isMaybe argCons
632−
633− maybeToPair (arg, argTy, (field, _, _)) =
634− infixApp
635− (infixApp
636− (infixE
637− (Just $ toFieldName field <^> [|E.colon|])
638− [|(E.><)|]
639− Nothing)
640− [|(.)|]
641− (dispatchToEncoding jc conName tvMap argTy))
642− [|(<$>)|]
643− (varE arg)
644−
645− toPair (arg, argTy, (field, _, _)) =
646− toFieldName field
647− <:> dispatchToEncoding jc conName tvMap argTy
648− `appE` varE arg
649−
650− toFieldName field = [|E.text|] `appE`
651− ([|T.pack|] `appE` fieldLabelExp opts field)
532+-- | Wrap a list of quoted 'Value's in a quoted 'Array' (of type 'Value').
533+array :: ToJSONFun -> [ExpQ] -> ExpQ
534+array Encoding [] = [|E.emptyArray_|]
535+array Value [] = [|Array V.empty|]
536+array Encoding es = [|E.wrapArray|] `appE` foldr1 (<%>) es
537+array Value es = do
538+ mv <- newName "mv"
539+ let newMV = bindS (varP mv)
540+ ([|VM.unsafeNew|] `appE`
541+ litE (integerL $ fromIntegral (length es)))
542+ stmts = [ noBindS $
543+ [|VM.unsafeWrite|] `appE`
544+ varE mv `appE`
545+ litE (integerL ix) `appE`
546+ e
547+ | (ix, e) <- zip [(0::Integer)..] es
548+ ]
549+ ret = noBindS $ [|return|] `appE` varE mv
550+ [|Array|] `appE`
551+ (varE 'V.create `appE`
552+ doE (newMV:stmts++[ret]))
652553
653− match (conP conName $ map varP args)
654− ( normalB
655− $ if multiCons
656− then case sumEncoding opts of
657− TwoElemArray -> array $
658− encStr opts conName <%> exp
659− TaggedObject{tagFieldName} -> object $
660− ([|E.text (T.pack tagFieldName)|] <:>
661− encStr opts conName) <%>
662− objBody
663− ObjectWithSingleField -> object $
664− encStr opts conName <:> exp
665− UntaggedValue -> exp
666− else exp
667− ) []
554+-- | Wrap an associative list of keys and quoted values in a quoted 'Object'.
555+objectE :: [(String, ExpQ)] -> ExpQ
556+objectE = fromPairsE . mconcatE . fmap (uncurry pairE)
668557
669−-- Infix constructors.
670−argsToEncoding jc tes opts multiCons (InfixC _ conName _) = do
671− al <- newName "argL"
672− ar <- newName "argR"
673− ([alTy,arTy], tvMap) <- reifyConTys jc tes conName
674− match (infixP (varP al) conName (varP ar))
675− ( normalB
676− $ sumToEncoding opts multiCons False conName
677− $ array (foldr1 (<%>) [ dispatchToEncoding jc conName tvMap aTy
678− `appE` varE a
679− | (a,aTy) <- [(al,alTy), (ar,arTy)]
680− ])
681− )
682− []
683−-- Existentially quantified constructors.
684−argsToEncoding jc tes opts multiCons (ForallC _ _ con) =
685− argsToEncoding jc tes opts multiCons con
558+-- | 'mconcat' a list of fixed length.
559+--
560+-- > mconcatE [ [|x|], [|y|], [|z|] ] = [| x <> (y <> z) |]
561+mconcatE :: [ExpQ] -> ExpQ
562+mconcatE [] = [|Monoid.mempty|]
563+mconcatE [x] = x
564+mconcatE (x : xs) = infixApp x [|(Monoid.<>)|] (mconcatE xs)
686565
687−#if MIN_VERSION_template_haskell(2,11,0)
688−-- GADTs.
689−argsToEncoding jc tes opts multiCons (GadtC conNames ts _) =
690− argsToEncoding jc tes opts multiCons $ NormalC (head conNames) ts
566+fromPairsE :: ExpQ -> ExpQ
567+fromPairsE = ([|fromPairs|] `appE`)
691568
692−argsToEncoding jc tes opts multiCons (RecGadtC conNames ts _) =
693− argsToEncoding jc tes opts multiCons $ RecC (head conNames) ts
694−#endif
569+-- | Create (an encoding of) a key-value pair.
570+--
571+-- > pairE "k" [|v|] = [|pair "k" v|]
572+pairE :: String -> ExpQ -> ExpQ
573+pairE k v = [|pair k|] `appE` v
695574
696575--------------------------------------------------------------------------------
697576-- FromJSON
@@ -775,33 +654,41 @@ consFromJSON :: JSONClass
775654 -- ^ Name of the type to which the constructors belong.
776655 -> Options
777656 -- ^ Encoding options
778− -> [Con]
657+ -> [Type]
658+ -- ^ The types from the data type/data family instance declaration
659+ -> [ConstructorInfo]
779660 -- ^ Constructors for which to generate JSON parsing code.
780661 -> Q Exp
781662
782−consFromJSON _ _ _ [] = error $ "Data.Aeson.TH.consFromJSON: "
783− ++ "Not a single constructor given!"
663+consFromJSON _ _ _ _ [] = error $ "Data.Aeson.TH.consFromJSON: "
664+ ++ "Not a single constructor given!"
784665
785−consFromJSON jc tName opts cons = do
666+consFromJSON jc tName opts instTys cons = do
786667 value <- newName "value"
787668 pjs <- newNameList "_pj" $ arityInt jc
788669 pjls <- newNameList "_pjl" $ arityInt jc
789670 let zippedPJs = zip pjs pjls
790671 interleavedPJs = interleave pjs pjls
791− lamE (map varP $ interleavedPJs ++ [value]) $ lamExpr value zippedPJs
672+ lastTyVars = map varTToName $ drop (length instTys - arityInt jc) instTys
673+ tvMap = M.fromList $ zip lastTyVars zippedPJs
674+ lamE (map varP $ interleavedPJs ++ [value]) $ lamExpr value tvMap
792675
793676 where
794− lamExpr value pjs = case cons of
677+ checkExi tvMap con = checkExistentialContext jc tvMap
678+ (constructorContext con)
679+ (constructorName con)
680+
681+ lamExpr value tvMap = case cons of
795682 [con]
796683 | not (tagSingleConstructors opts)
797− -> parseArgs jc pjs tName opts con (Right value)
684+ -> checkExi tvMap con $ parseArgs jc tvMap tName opts con (Right value)
798685 _ | sumEncoding opts == UntaggedValue
799− -> parseUntaggedValue pjs cons value
686+ -> parseUntaggedValue tvMap cons value
800687 | otherwise
801688 -> caseE (varE value) $
802689 if allNullaryToStringTag opts && all isNullary cons
803690 then allNullaryMatches
804− else mixedMatches pjs
691+ else mixedMatches tvMap
805692
806693 allNullaryMatches =
807694 [ do txt <- newName "txt"
@@ -810,12 +697,11 @@ consFromJSON jc tName opts cons = do
810697 [ liftM2 (,) (normalG $
811698 infixApp (varE txt)
812699 [|(==)|]
813− ([|T.pack|] `appE`
814− conStringE opts conName)
700+ (conTxt opts conName)
815701 )
816702 ([|pure|] `appE` conE conName)
817703 | con <- cons
818− , let conName = getConName con
704+ , let conName = constructorName con
819705 ]
820706 ++
821707 [ liftM2 (,)
@@ -836,13 +722,13 @@ consFromJSON jc tName opts cons = do
836722 []
837723 ]
838724
839− mixedMatches pjs =
725+ mixedMatches tvMap =
840726 case sumEncoding opts of
841727 TaggedObject {tagFieldName, contentsFieldName} ->
842− parseObject $ parseTaggedObject pjs tagFieldName contentsFieldName
728+ parseObject $ parseTaggedObject tvMap tagFieldName contentsFieldName
843729 UntaggedValue -> error "UntaggedValue: Should be handled already"
844730 ObjectWithSingleField ->
845− parseObject $ parseObjectWithSingleField pjs
731+ parseObject $ parseObjectWithSingleField tvMap
846732 TwoElemArray ->
847733 [ do arr <- newName "array"
848734 match (conP 'Array [varP arr])
@@ -850,7 +736,7 @@ consFromJSON jc tName opts cons = do
850736 [ liftM2 (,) (normalG $ infixApp ([|V.length|] `appE` varE arr)
851737 [|(==)|]
852738 (litE $ integerL 2))
853− (parse2ElemArray pjs arr)
739+ (parse2ElemArray tvMap arr)
854740 , liftM2 (,) (normalG [|otherwise|])
855741 ([|not2ElemArray|]
856742 `appE` litE (stringL $ show tName)
@@ -881,25 +767,29 @@ consFromJSON jc tName opts cons = do
881767 []
882768 ]
883769
884− parseTaggedObject pjs typFieldName valFieldName obj = do
770+ parseTaggedObject tvMap typFieldName valFieldName obj = do
885771 conKey <- newName "conKey"
886772 doE [ bindS (varP conKey)
887773 (infixApp (varE obj)
888774 [|(.:)|]
889775 ([|T.pack|] `appE` stringE typFieldName))
890− , noBindS $ parseContents pjs conKey (Left (valFieldName, obj)) 'conNotFoundFailTaggedObject
776+ , noBindS $ parseContents tvMap conKey (Left (valFieldName, obj)) 'conNotFoundFailTaggedObject
891777 ]
892778
893− parseUntaggedValue pjs cons' conVal =
779+ parseUntaggedValue tvMap cons' conVal =
894780 foldr1 (\e e' -> infixApp e [|(<|>)|] e')
895− (map (\x -> parseValue pjs x conVal) cons')
781+ (map (\x -> parseValue tvMap x conVal) cons')
896782
897− parseValue _pjs (NormalC conName []) conVal = do
783+ parseValue _tvMap
784+ ConstructorInfo { constructorName = conName
785+ , constructorVariant = NormalConstructor
786+ , constructorFields = [] }
787+ conVal = do
898788 str <- newName "str"
899789 caseE (varE conVal)
900790 [ match (conP 'String [varP str])
901791 (guardedB
902− [ liftM2 (,) (normalG $ infixApp (varE str) [|(==)|] ([|T.pack|] `appE` conStringE opts conName)
792+ [ liftM2 (,) (normalG $ infixApp (varE str) [|(==)|] (conTxt opts conName)
903793 )
904794 ([|pure|] `appE` conE conName)
905795 ]
@@ -907,11 +797,11 @@ consFromJSON jc tName opts cons = do
907797 []
908798 , matchFailed tName conName "String"
909799 ]
910− parseValue pjs con conVal =
911− parseArgs jc pjs tName opts con (Right conVal)
800+ parseValue tvMap con conVal =
801+ checkExi tvMap con $ parseArgs jc tvMap tName opts con (Right conVal)
912802
913803
914− parse2ElemArray pjs arr = do
804+ parse2ElemArray tvMap arr = do
915805 conKey <- newName "conKey"
916806 conVal <- newName "conVal"
917807 let letIx n ix =
@@ -926,7 +816,7 @@ consFromJSON jc tName opts cons = do
926816 (caseE (varE conKey)
927817 [ do txt <- newName "txt"
928818 match (conP 'String [varP txt])
929− (normalB $ parseContents pjs
819+ (normalB $ parseContents tvMap
930820 txt
931821 (Right conVal)
932822 'conNotFoundFail2ElemArray
@@ -943,12 +833,12 @@ consFromJSON jc tName opts cons = do
943833 ]
944834 )
945835
946− parseObjectWithSingleField pjs obj = do
836+ parseObjectWithSingleField tvMap obj = do
947837 conKey <- newName "conKey"
948838 conVal <- newName "conVal"
949839 caseE ([e|H.toList|] `appE` varE obj)
950840 [ match (listP [tupP [varP conKey, varP conVal]])
951− (normalB $ parseContents pjs conKey (Right conVal) 'conNotFoundFailObjectSingleField)
841+ (normalB $ parseContents tvMap conKey (Right conVal) 'conNotFoundFailObjectSingleField)
952842 []
953843 , do other <- newName "other"
954844 match (varP other)
@@ -959,7 +849,7 @@ consFromJSON jc tName opts cons = do
959849 []
960850 ]
961851
962− parseContents pjs conKey contents errorFun =
852+ parseContents tvMap conKey contents errorFun =
963853 caseE (varE conKey)
964854 [ match wildP
965855 ( guardedB $
@@ -967,7 +857,8 @@ consFromJSON jc tName opts cons = do
967857 [|(==)|]
968858 ([|T.pack|] `appE`
969859 conNameExp opts con)
970− e <- parseArgs jc pjs tName opts con contents
860+ e <- checkExi tvMap con $
861+ parseArgs jc tvMap tName opts con contents
971862 return (g, e)
972863 | con <- cons
973864 ]
@@ -980,7 +871,7 @@ consFromJSON jc tName opts cons = do
980871 . stringL
981872 . constructorTagModifier opts
982873 . nameBase
983− . getConName
874+ . constructorName
984875 ) cons
985876 )
986877 `appE` ([|T.unpack|] `appE` varE conKey)
@@ -1029,22 +920,42 @@ parseRecord :: JSONClass
1029920 -> Options
1030921 -> Name
1031922 -> Name
1032− -> [VarStrictType]
923+ -> [Name]
1033924 -> Name
925+ -> Bool
1034926 -> ExpQ
1035−parseRecord jc tvMap argTys opts tName conName ts obj =
927+parseRecord jc tvMap argTys opts tName conName fields obj inTaggedObject =
928+ (if rejectUnknownFields opts
929+ then infixApp checkUnknownRecords [|(>>)|]
930+ else id) $
1036931 foldl' (\a b -> infixApp a [|(<*>)|] b)
1037932 (infixApp (conE conName) [|(<$>)|] x)
1038933 xs
1039934 where
935+ tagFieldNameAppender =
936+ if inTaggedObject then (tagFieldName (sumEncoding opts) :) else id
937+ knownFields = appE [|H.fromList|] $ listE $
938+ map (\knownName -> tupE [appE [|T.pack|] $ litE $ stringL knownName, [|()|]]) $
939+ tagFieldNameAppender $ map nameBase fields
940+ checkUnknownRecords =
941+ caseE (appE [|H.keys|] $ infixApp (varE obj) [|H.difference|] knownFields)
942+ [ match (listP []) (normalB [|return ()|]) []
943+ , newName "unknownFields" >>=
944+ \unknownFields -> match (varP unknownFields)
945+ (normalB $ appE [|fail|] $ infixApp
946+ (litE (stringL "Unknown fields: "))
947+ [|(++)|]
948+ (appE [|show|] (varE unknownFields)))
949+ []
950+ ]
1040951 x:xs = [ [|lookupField|]
1041952 `appE` dispatchParseJSON jc conName tvMap argTy
1042953 `appE` litE (stringL $ show tName)
1043954 `appE` litE (stringL $ constructorTagModifier opts $ nameBase conName)
1044955 `appE` varE obj
1045− `appE` ( [|T.pack|] `appE` fieldLabelExp opts field
956+ `appE` ( [|T.pack|] `appE` stringE (fieldLabel opts field)
1046957 )
1047− | ((field, _, _), argTy) <- zip ts argTys
958+ | (field, argTy) <- zip fields argTys
1048959 ]
1049960
1050961getValField :: Name -> String -> [MatchQ] -> Q Exp
@@ -1063,67 +974,82 @@ matchCases (Right valName) = caseE (varE valName)
1063974
1064975-- | Generates code to parse the JSON encoding of a single constructor.
1065976parseArgs :: JSONClass -- ^ The FromJSON variant being derived.
1066− -> [(Name, Name)] -- ^ The names of the encoding/decoding function arguments.
977+ -> TyVarMap -- ^ Maps the last type variables to their decoding
978+ -- function arguments.
1067979 -> Name -- ^ Name of the type to which the constructor belongs.
1068980 -> Options -- ^ Encoding options.
1069− -> Con -- ^ Constructor for which to generate JSON parsing code.
981+ -> ConstructorInfo -- ^ Constructor for which to generate JSON parsing code.
1070982 -> Either (String, Name) Name -- ^ Left (valFieldName, objName) or
1071983 -- Right valName
1072984 -> Q Exp
1073985-- Nullary constructors.
1074−parseArgs jc pjs _ _ (NormalC conName []) (Left _) = do
1075− ([], _) <- reifyConTys jc pjs conName
1076− [|pure|] `appE` conE conName
1077−parseArgs jc pjs tName _ (NormalC conName []) (Right valName) = do
1078− ([], _) <- reifyConTys jc pjs conName
1079− caseE (varE valName) $ parseNullaryMatches tName conName
986+parseArgs _ _ _ _
987+ ConstructorInfo { constructorName = conName
988+ , constructorVariant = NormalConstructor
989+ , constructorFields = [] }
990+ (Left _) =
991+ [|pure|] `appE` conE conName
992+parseArgs _ _ tName _
993+ ConstructorInfo { constructorName = conName
994+ , constructorVariant = NormalConstructor
995+ , constructorFields = [] }
996+ (Right valName) =
997+ caseE (varE valName) $ parseNullaryMatches tName conName
1080998
1081999-- Unary constructors.
1082−parseArgs jc pjs _ _ (NormalC conName [_]) contents = do
1083− ([argTy], tvMap) <- reifyConTys jc pjs conName
1084− matchCases contents $ parseUnaryMatches jc tvMap argTy conName
1000+parseArgs jc tvMap _ _
1001+ ConstructorInfo { constructorName = conName
1002+ , constructorVariant = NormalConstructor
1003+ , constructorFields = [argTy] }
1004+ contents = do
1005+ argTy' <- resolveTypeSynonyms argTy
1006+ matchCases contents $ parseUnaryMatches jc tvMap argTy' conName
10851007
10861008-- Polyadic constructors.
1087−parseArgs jc pjs tName _ (NormalC conName ts) contents = do
1088− (argTys, tvMap) <- reifyConTys jc pjs conName
1089− let len = genericLength ts
1090− matchCases contents $ parseProduct jc tvMap argTys tName conName len
1009+parseArgs jc tvMap tName _
1010+ ConstructorInfo { constructorName = conName
1011+ , constructorVariant = NormalConstructor
1012+ , constructorFields = argTys }
1013+ contents = do
1014+ argTys' <- mapM resolveTypeSynonyms argTys
1015+ let len = genericLength argTys'
1016+ matchCases contents $ parseProduct jc tvMap argTys' tName conName len
10911017
10921018-- Records.
1093−parseArgs jc pjs tName opts (RecC conName ts) (Left (_, obj)) = do
1094− (argTys, tvMap) <- reifyConTys jc pjs conName
1095− parseRecord jc tvMap argTys opts tName conName ts obj
1096−parseArgs jc pjs tName opts (RecC conName ts) (Right valName) = case (unwrapUnaryRecords opts,ts) of
1097− (True,[(_,st,ty)])-> parseArgs jc pjs tName opts (NormalC conName [(st,ty)]) (Right valName)
1098− _ -> do
1099− obj <- newName "recObj"
1100− (argTys, tvMap) <- reifyConTys jc pjs conName
1101− caseE (varE valName)
1102− [ match (conP 'Object [varP obj]) (normalB $
1103− parseRecord jc tvMap argTys opts tName conName ts obj) []
1104− , matchFailed tName conName "Object"
1105− ]
1019+parseArgs jc tvMap tName opts
1020+ ConstructorInfo { constructorName = conName
1021+ , constructorVariant = RecordConstructor fields
1022+ , constructorFields = argTys }
1023+ (Left (_, obj)) = do
1024+ argTys' <- mapM resolveTypeSynonyms argTys
1025+ parseRecord jc tvMap argTys' opts tName conName fields obj True
1026+parseArgs jc tvMap tName opts
1027+ info@ConstructorInfo { constructorName = conName
1028+ , constructorVariant = RecordConstructor fields
1029+ , constructorFields = argTys }
1030+ (Right valName) =
1031+ case (unwrapUnaryRecords opts,argTys) of
1032+ (True,[_])-> parseArgs jc tvMap tName opts
1033+ (info{constructorVariant = NormalConstructor})
1034+ (Right valName)
1035+ _ -> do
1036+ obj <- newName "recObj"
1037+ argTys' <- mapM resolveTypeSynonyms argTys
1038+ caseE (varE valName)
1039+ [ match (conP 'Object [varP obj]) (normalB $
1040+ parseRecord jc tvMap argTys' opts tName conName fields obj False) []
1041+ , matchFailed tName conName "Object"
1042+ ]
11061043
11071044-- Infix constructors. Apart from syntax these are the same as
11081045-- polyadic constructors.
1109−parseArgs jc pjs tName _ (InfixC _ conName _) contents = do
1110− (argTys, tvMap) <- reifyConTys jc pjs conName
1111− matchCases contents $ parseProduct jc tvMap argTys tName conName 2
1112−
1113−-- Existentially quantified constructors. We ignore the quantifiers
1114−-- and proceed with the contained constructor.
1115−parseArgs jc pjs tName opts (ForallC _ _ con) contents =
1116− parseArgs jc pjs tName opts con contents
1117−
1118−#if MIN_VERSION_template_haskell(2,11,0)
1119−-- GADTs. We ignore the refined return type and proceed as if it were a
1120−-- NormalC or RecC.
1121−parseArgs jc pjs tName opts (GadtC conNames ts _) contents =
1122− parseArgs jc pjs tName opts (NormalC (head conNames) ts) contents
1123−
1124−parseArgs jc pjs tName opts (RecGadtC conNames ts _) contents =
1125− parseArgs jc pjs tName opts (RecC (head conNames) ts) contents
1126−#endif
1046+parseArgs jc tvMap tName _
1047+ ConstructorInfo { constructorName = conName
1048+ , constructorVariant = InfixConstructor
1049+ , constructorFields = argTys }
1050+ contents = do
1051+ argTys' <- mapM resolveTypeSynonyms argTys
1052+ matchCases contents $ parseProduct jc tvMap argTys' tName conName 2
11271053
11281054-- | Generates code to parse the JSON encoding of an n-ary
11291055-- constructor.
@@ -1200,6 +1126,11 @@ instance OVERLAPPABLE_ LookupField a where
12001126instance INCOHERENT_ LookupField (Maybe a) where
12011127 lookupField pj _ _ = parseOptionalFieldWith pj
12021128
1129+instance INCOHERENT_ LookupField (Semigroup.Option a) where
1130+ lookupField pj tName rec obj key =
1131+ fmap Semigroup.Option
1132+ (lookupField (fmap Semigroup.getOption . pj) tName rec obj key)
1133+
12031134lookupFieldWith :: (Value -> Parser a) -> String -> String
12041135 -> Object -> T.Text -> Parser a
12051136lookupFieldWith pj tName rec obj key =
@@ -1207,9 +1138,6 @@ lookupFieldWith pj tName rec obj key =
12071138 Nothing -> unknownFieldFail tName rec (T.unpack key)
12081139 Just v -> pj v <?> Key key
12091140
1210−keyValuePairWith :: (v -> Value) -> T.Text -> v -> Pair
1211−keyValuePairWith tj name value = (name, tj value)
1212−
12131141unknownFieldFail :: String -> String -> String -> Parser fail
12141142unknownFieldFail tName rec key =
12151143 fail $ printf "When parsing the record %s of type %s the key %s was not present."
@@ -1278,7 +1206,8 @@ deriveJSONBoth dtj dfj opts name =
12781206 liftM2 (++) (dtj opts name) (dfj opts name)
12791207
12801208-- | Functionality common to @deriveToJSON(1)(2)@ and @deriveFromJSON(1)(2)@.
1281−deriveJSONClass :: [(JSONFun, JSONClass -> Name -> Options -> [Con] -> Q Exp)]
1209+deriveJSONClass :: [(JSONFun, JSONClass -> Name -> Options -> [Type]
1210+ -> [ConstructorInfo] -> Q Exp)]
12821211 -- ^ The class methods and the functions which derive them.
12831212 -> JSONClass
12841213 -- ^ The class for which to generate an instance.
@@ -1288,27 +1217,34 @@ deriveJSONClass :: [(JSONFun, JSONClass -> Name -> Options -> [Con] -> Q Exp)]
12881217 -- ^ Name of the type for which to generate a class instance
12891218 -- declaration.
12901219 -> Q [Dec]
1291−deriveJSONClass consFuns jc opts name =
1292− withType name $ \name' ctxt tvbs cons mbTys ->
1293− (:[]) <$> fromCons name' ctxt tvbs cons mbTys
1294− where
1295− fromCons :: Name -> Cxt -> [TyVarBndr] -> [Con] -> Maybe [Type] -> Q Dec
1296− fromCons name' ctxt tvbs cons mbTys = do
1220+deriveJSONClass consFuns jc opts name = do
1221+ info <- reifyDatatype name
1222+ case info of
1223+ DatatypeInfo { datatypeContext = ctxt
1224+ , datatypeName = parentName
1225+#if MIN_VERSION_th_abstraction(0,3,0)
1226+ , datatypeInstTypes = instTys
1227+#else
1228+ , datatypeVars = instTys
1229+#endif
1230+ , datatypeVariant = variant
1231+ , datatypeCons = cons
1232+ } -> do
12971233 (instanceCxt, instanceType)
1298− <- buildTypeInstance name' jc ctxt tvbs mbTys
1299− instanceD (return instanceCxt)
1300− (return instanceType)
1301− (methodDecs name' cons)
1302−
1303− methodDecs :: Name -> [Con] -> [Q Dec]
1304− methodDecs name' cons = flip map consFuns $ \(jf, jfMaker) ->
1234+ <- buildTypeInstance parentName jc ctxt instTys variant
1235+ (:[]) <$> instanceD (return instanceCxt)
1236+ (return instanceType)
1237+ (methodDecs parentName instTys cons)
1238+ where
1239+ methodDecs :: Name -> [Type] -> [ConstructorInfo] -> [Q Dec]
1240+ methodDecs parentName instTys cons = flip map consFuns $ \(jf, jfMaker) ->
13051241 funD (jsonFunValName jf (arity jc))
13061242 [ clause []
1307− (normalB $ jfMaker jc name' opts cons)
1243+ (normalB $ jfMaker jc parentName opts instTys cons)
13081244 []
13091245 ]
13101246
1311−mkFunCommon :: (JSONClass -> Name -> Options -> [Con] -> Q Exp)
1247+mkFunCommon :: (JSONClass -> Name -> Options -> [Type] -> [ConstructorInfo] -> Q Exp)
13121248 -- ^ The function which derives the expression.
13131249 -> JSONClass
13141250 -- ^ Which class's method is being derived.
@@ -1317,15 +1253,24 @@ mkFunCommon :: (JSONClass -> Name -> Options -> [Con] -> Q Exp)
13171253 -> Name
13181254 -- ^ Name of the encoded type.
13191255 -> Q Exp
1320−mkFunCommon consFun jc opts name = withType name fromCons
1321− where
1322− fromCons :: Name -> Cxt -> [TyVarBndr] -> [Con] -> Maybe [Type] -> Q Exp
1323− fromCons name' ctxt tvbs cons mbTys = do
1324− -- We force buildTypeInstance here since it performs some checks for whether
1325− -- or not the provided datatype's kind matches the derived method's
1326− -- typeclass, and produces errors if it can't.
1327− !_ <- buildTypeInstance name' jc ctxt tvbs mbTys
1328− consFun jc name' opts cons
1256+mkFunCommon consFun jc opts name = do
1257+ info <- reifyDatatype name
1258+ case info of
1259+ DatatypeInfo { datatypeContext = ctxt
1260+ , datatypeName = parentName
1261+#if MIN_VERSION_th_abstraction(0,3,0)
1262+ , datatypeInstTypes = instTys
1263+#else
1264+ , datatypeVars = instTys
1265+#endif
1266+ , datatypeVariant = variant
1267+ , datatypeCons = cons
1268+ } -> do
1269+ -- We force buildTypeInstance here since it performs some checks for whether
1270+ -- or not the provided datatype's kind matches the derived method's
1271+ -- typeclass, and produces errors if it can't.
1272+ !_ <- buildTypeInstance parentName jc ctxt instTys variant
1273+ consFun jc parentName opts instTys cons
13291274
13301275dispatchFunByType :: JSONClass
13311276 -> JSONFun
@@ -1370,200 +1315,37 @@ dispatchFunByType jc jf conName tvMap list ty = do
13701315 (interleave rhsArgs rhsArgs)
13711316 else varE $ jsonFunValOrListName list jf Arity0
13721317
1373−dispatchToJSON, dispatchToEncoding, dispatchParseJSON
1318+dispatchToJSON
1319+ :: ToJSONFun -> JSONClass -> Name -> TyVarMap -> Type -> Q Exp
1320+dispatchToJSON target jc n tvMap =
1321+ dispatchFunByType jc (targetToJSONFun target) n tvMap False
1322+
1323+dispatchParseJSON
13741324 :: JSONClass -> Name -> TyVarMap -> Type -> Q Exp
1375−dispatchToJSON jc n tvMap = dispatchFunByType jc ToJSON n tvMap False
1376−dispatchToEncoding jc n tvMap = dispatchFunByType jc ToEncoding n tvMap False
13771325dispatchParseJSON jc n tvMap = dispatchFunByType jc ParseJSON n tvMap False
13781326
13791327--------------------------------------------------------------------------------
13801328-- Utility functions
13811329--------------------------------------------------------------------------------
13821330
1383−-- | Boilerplate for top level splices.
1384−--
1385−-- The given 'Name' must meet one of two criteria:
1386−--
1387−-- 1. It must be the name of a type constructor of a plain data type or newtype.
1388−-- 2. It must be the name of a data family instance or newtype instance constructor.
1389−
1390−-- Any other value will result in an exception.
1391−withType :: Name
1392− -> (Name -> Cxt -> [TyVarBndr] -> [Con] -> Maybe [Type] -> Q a)
1393− -- ^ Function that generates the actual code. Will be applied
1394− -- to the datatype/data family 'Name', datatype context, type
1395− -- variable binders and constructors extracted from the given
1396− -- 'Name'. If the 'Name' is from a data family instance
1397− -- constructor, it will also have its instantiated types;
1398− -- otherwise, it will be 'Nothing'.
1399− -> Q a
1400− -- ^ Resulting value in the 'Q'uasi monad.
1401−withType name f = do
1402− info <- reify name
1403− case info of
1404− TyConI dec ->
1405− case dec of
1406−#if MIN_VERSION_template_haskell(2,11,0)
1407− DataD ctxt _ tvbs _ cons _ -> f name ctxt tvbs cons Nothing
1408− NewtypeD ctxt _ tvbs _ con _ -> f name ctxt tvbs [con] Nothing
1409−#else
1410− DataD ctxt _ tvbs cons _ -> f name ctxt tvbs cons Nothing
1411− NewtypeD ctxt _ tvbs con _ -> f name ctxt tvbs [con] Nothing
1412−#endif
1413− other -> fail $ ns ++ "Unsupported type: " ++ show other
1414−#if MIN_VERSION_template_haskell(2,11,0)
1415− DataConI _ _ parentName -> do
1416−#else
1417− DataConI _ _ parentName _ -> do
1418−#endif
1419− parentInfo <- reify parentName
1420− case parentInfo of
1421−#if MIN_VERSION_template_haskell(2,11,0)
1422− FamilyI (DataFamilyD _ tvbs _) decs ->
1423−#else
1424− FamilyI (FamilyD DataFam _ tvbs _) decs ->
1425−#endif
1426− let instDec = flip find decs $ \dec -> case dec of
1427−#if MIN_VERSION_template_haskell(2,11,0)
1428− DataInstD _ _ _ _ cons _ -> any ((name ==) . getConName) cons
1429− NewtypeInstD _ _ _ _ con _ -> name == getConName con
1430−#else
1431− DataInstD _ _ _ cons _ -> any ((name ==) . getConName) cons
1432− NewtypeInstD _ _ _ con _ -> name == getConName con
1433−#endif
1434− _ -> error $ ns ++ "Must be a data or newtype instance."
1435− in case instDec of
1436−#if MIN_VERSION_template_haskell(2,11,0)
1437− Just (DataInstD ctxt _ instTys _ cons _) -> f parentName ctxt tvbs cons $ Just instTys
1438− Just (NewtypeInstD ctxt _ instTys _ con _) -> f parentName ctxt tvbs [con] $ Just instTys
1439−#else
1440− Just (DataInstD ctxt _ instTys cons _) -> f parentName ctxt tvbs cons $ Just instTys
1441− Just (NewtypeInstD ctxt _ instTys con _) -> f parentName ctxt tvbs [con] $ Just instTys
1442−#endif
1443− _ -> fail $ ns ++
1444− "Could not find data or newtype instance constructor."
1445− _ -> fail $ ns ++ "Data constructor " ++ show name ++
1446− " is not from a data family instance constructor."
1447−#if MIN_VERSION_template_haskell(2,11,0)
1448− FamilyI DataFamilyD{} _ ->
1449−#else
1450− FamilyI (FamilyD DataFam _ _ _) _ ->
1451−#endif
1452− fail $ ns ++
1453− "Cannot use a data family name. Use a data family instance constructor instead."
1454− _ -> fail $ ns ++ "I need the name of a plain data type constructor, "
1455− ++ "or a data family instance constructor."
1456− where
1457− ns :: String
1458− ns = "Data.Aeson.TH.withType: "
1459−
1460−-- | Infer the context and instance head needed for a FromJSON or ToJSON instance.
1331+-- For the given Types, generate an instance context and head.
14611332buildTypeInstance :: Name
14621333 -- ^ The type constructor or data family name
14631334 -> JSONClass
14641335 -- ^ The typeclass to derive
14651336 -> Cxt
14661337 -- ^ The datatype context
1467− -> [TyVarBndr]
1468− -- ^ The type variables from the data type/data family declaration
1469− -> Maybe [Type]
1470− -- ^ 'Just' the types used to instantiate a data family instance,
1471− -- or 'Nothing' if it's a plain data type
1338+ -> [Type]
1339+ -- ^ The types to instantiate the instance with
1340+ -> DatatypeVariant
1341+ -- ^ Are we dealing with a data family instance or not
14721342 -> Q (Cxt, Type)
1473− -- ^ The resulting 'Cxt' and 'Type' to use in a class instance
1474−-- Plain data type/newtype case
1475−buildTypeInstance tyConName jc dataCxt tvbs Nothing =
1476− let varTys :: [Type]
1477− varTys = map tvbToType tvbs
1478− in buildTypeInstanceFromTys tyConName jc dataCxt varTys False
1479−-- Data family instance case
1480−--
1481−-- The CPP is present to work around a couple of annoying old GHC bugs.
1482−-- See Note [Polykinded data families in Template Haskell]
1483−buildTypeInstance dataFamName jc dataCxt tvbs (Just instTysAndKinds) = do
1484−#if !(MIN_VERSION_template_haskell(2,8,0)) || MIN_VERSION_template_haskell(2,10,0)
1485− let instTys :: [Type]
1486− instTys = zipWith stealKindForType tvbs instTysAndKinds
1487−#else
1488− let kindVarNames :: [Name]
1489− kindVarNames = nub $ concatMap (tyVarNamesOfType . tvbKind) tvbs
1490−
1491− numKindVars :: Int
1492− numKindVars = length kindVarNames
1493−
1494− givenKinds, givenKinds' :: [Kind]
1495− givenTys :: [Type]
1496− (givenKinds, givenTys) = splitAt numKindVars instTysAndKinds
1497− givenKinds' = map sanitizeStars givenKinds
1498−
1499− -- A GHC 7.6-specific bug requires us to replace all occurrences of
1500− -- (ConT GHC.Prim.*) with StarT, or else Template Haskell will reject it.
1501− -- Luckily, (ConT GHC.Prim.*) only seems to occur in this one spot.
1502− sanitizeStars :: Kind -> Kind
1503− sanitizeStars = go
1504− where
1505− go :: Kind -> Kind
1506− go (AppT t1 t2) = AppT (go t1) (go t2)
1507− go (SigT t k) = SigT (go t) (go k)
1508− go (ConT n) | n == starKindName = StarT
1509− go t = t
1510−
1511− -- It's quite awkward to import * from GHC.Prim, so we'll just
1512− -- hack our way around it.
1513− starKindName :: Name
1514− starKindName = mkNameG_tc "ghc-prim" "GHC.Prim" "*"
1515−
1516− -- If we run this code with GHC 7.8, we might have to generate extra type
1517− -- variables to compensate for any type variables that Template Haskell
1518− -- eta-reduced away.
1519− -- See Note [Polykinded data families in Template Haskell]
1520− xTypeNames <- newNameList "tExtra" (length tvbs - length givenTys)
1521−
1522− let xTys :: [Type]
1523− xTys = map VarT xTypeNames
1524− -- ^ Because these type variables were eta-reduced away, we can only
1525− -- determine their kind by using stealKindForType. Therefore, we mark
1526− -- them as VarT to ensure they will be given an explicit kind annotation
1527− -- (and so the kind inference machinery has the right information).
1528−
1529− substNamesWithKinds :: [(Name, Kind)] -> Type -> Type
1530− substNamesWithKinds nks t = foldr' (uncurry substNameWithKind) t nks
1531−
1532− -- The types from the data family instance might not have explicit kind
1533− -- annotations, which the kind machinery needs to work correctly. To
1534− -- compensate, we use stealKindForType to explicitly annotate any
1535− -- types without kind annotations.
1536− instTys :: [Type]
1537− instTys = map (substNamesWithKinds (zip kindVarNames givenKinds'))
1538− -- Note that due to a GHC 7.8-specific bug
1539− -- (see Note [Polykinded data families in Template Haskell]),
1540− -- there may be more kind variable names than there are kinds
1541− -- to substitute. But this is OK! If a kind is eta-reduced, it
1542− -- means that is was not instantiated to something more specific,
1543− -- so we need not substitute it. Using stealKindForType will
1544− -- grab the correct kind.
1545− $ zipWith stealKindForType tvbs (givenTys ++ xTys)
1546−#endif
1547− buildTypeInstanceFromTys dataFamName jc dataCxt instTys True
1548−
1549−-- For the given Types, generate an instance context and head.
1550−buildTypeInstanceFromTys :: Name
1551− -- ^ The type constructor or data family name
1552− -> JSONClass
1553− -- ^ The typeclass to derive
1554− -> Cxt
1555− -- ^ The datatype context
1556− -> [Type]
1557− -- ^ The types to instantiate the instance with
1558− -> Bool
1559− -- ^ True if it's a data family, False otherwise
1560− -> Q (Cxt, Type)
1561−buildTypeInstanceFromTys tyConName jc dataCxt varTysOrig isDataFamily = do
1343+buildTypeInstance tyConName jc dataCxt varTysOrig variant = do
15621344 -- Make sure to expand through type/kind synonyms! Otherwise, the
15631345 -- eta-reduction check might get tripped up over type variables in a
15641346 -- synonym that are actually dropped.
15651347 -- (See GHC Trac #11416 for a scenario where this actually happened.)
1566− varTysExp <- mapM expandSyn varTysOrig
1348+ varTysExp <- mapM resolveTypeSynonyms varTysOrig
15671349
15681350 let remainingLength :: Int
15691351 remainingLength = length varTysOrig - arityInt jc
@@ -1593,7 +1375,7 @@ buildTypeInstanceFromTys tyConName jc dataCxt varTysOrig isDataFamily = do
15931375 -- All of the type variables mentioned in the dropped types
15941376 -- (post-synonym expansion)
15951377 droppedTyVarNames :: [Name]
1596− droppedTyVarNames = concatMap tyVarNamesOfType droppedTysExpSubst
1378+ droppedTyVarNames = freeVariables droppedTysExpSubst
15971379
15981380 -- If any of the dropped types were polykinded, ensure that they are of kind *
15991381 -- after substituting * for the dropped kind variables. If not, throw an error.
@@ -1634,6 +1416,13 @@ buildTypeInstanceFromTys tyConName jc dataCxt varTysOrig isDataFamily = do
16341416 map (substNamesWithKindStar (droppedKindVarNames `union` kvNames'))
16351417 $ take remainingLength varTysOrig
16361418
1419+ isDataFamily :: Bool
1420+ isDataFamily = case variant of
1421+ Datatype -> False
1422+ Newtype -> False
1423+ DataInstance -> True
1424+ NewtypeInstance -> True
1425+
16371426 remainingTysOrigSubst' :: [Type]
16381427 -- See Note [Kind signatures in derived instances] for an explanation
16391428 -- of the isDataFamily check.
@@ -1687,55 +1476,6 @@ deriveConstraint jc t
16871476 jcConstraint = jsonClassName . JSONClass (direction jc)
16881477
16891478{-
1690−Note [Polykinded data families in Template Haskell]
1691−~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1692−
1693−In order to come up with the correct instance context and head for an instance, e.g.,
1694−
1695− instance C a => C (Data a) where ...
1696−
1697−We need to know the exact types and kinds used to instantiate the instance. For
1698−plain old datatypes, this is simple: every type must be a type variable, and
1699−Template Haskell reliably tells us the type variables and their kinds.
1700−
1701−Doing the same for data families proves to be much harder for three reasons:
1702−
1703−1. On any version of Template Haskell, it may not tell you what an instantiated
1704− type's kind is. For instance, in the following data family instance:
1705−
1706− data family Fam (f :: * -> *) (a :: *)
1707− data instance Fam f a
1708−
1709− Then if we use TH's reify function, it would tell us the TyVarBndrs of the
1710− data family declaration are:
1711−
1712− [KindedTV f (AppT (AppT ArrowT StarT) StarT),KindedTV a StarT]
1713−
1714− and the instantiated types of the data family instance are:
1715−
1716− [VarT f1,VarT a1]
1717−
1718− We can't just pass [VarT f1,VarT a1] to buildTypeInstanceFromTys, since we
1719− have no way of knowing their kinds. Luckily, the TyVarBndrs tell us what the
1720− kind is in case an instantiated type isn't a SigT, so we use the stealKindForType
1721− function to ensure all of the instantiated types are SigTs before passing them
1722− to buildTypeInstanceFromTys.
1723−2. On GHC 7.6 and 7.8, a bug is present in which Template Haskell lists all of
1724− the specified kinds of a data family instance efore any of the instantiated
1725− types. Fortunately, this is easy to deal with: you simply count the number of
1726− distinct kind variables in the data family declaration, take that many elements
1727− from the front of the Types list of the data family instance, substitute the
1728− kind variables with their respective instantiated kinds (which you took earlier),
1729− and proceed as normal.
1730−3. On GHC 7.8, an even uglier bug is present (GHC Trac #9692) in which Template
1731− Haskell might not even list all of the Types of a data family instance, since
1732− they are eta-reduced away! And yes, kinds can be eta-reduced too.
1733−
1734− The simplest workaround is to count how many instantiated types are missing from
1735− the list and generate extra type variables to use in their place. Luckily, we
1736− needn't worry much if its kind was eta-reduced away, since using stealKindForType
1737− will get it back.
1738−
17391479Note [Kind signatures in derived instances]
17401480~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
17411481
@@ -1813,50 +1553,14 @@ things we can do to make instance contexts that work for 80% of use cases:
18131553 and perform kind substitution as in the other cases.
18141554-}
18151555
1816−-- Determines the types of a constructor's arguments as well as the last type
1817−-- parameters (mapped to their encoding/decoding functions), expanding through
1818−-- any type synonyms.
1819−--
1820−-- The type parameters are determined on a constructor-by-constructor basis since
1821−-- they may be refined to be particular types in a GADT.
1822−reifyConTys :: JSONClass
1823− -> [(Name, Name)]
1824− -> Name
1825− -> Q ([Type], TyVarMap)
1826−reifyConTys jc tpjs conName = do
1827− info <- reify conName
1828− (ctxt, uncTy) <- case info of
1829− DataConI _ ty _
1830−#if !(MIN_VERSION_template_haskell(2,11,0))
1831− _
1832−#endif
1833− -> fmap uncurryTy (expandSyn ty)
1834− _ -> error "Must be a data constructor"
1835− let (argTys, [resTy]) = NE.splitAt (NE.length uncTy - 1) uncTy
1836− unapResTy = unapplyTy resTy
1837− -- If one of the last type variables is refined to a particular type
1838− -- (i.e., not truly polymorphic), we mark it with Nothing and filter
1839− -- it out later, since we only apply encoding/decoding functions to
1840− -- arguments of a type that it (1) one of the last type variables,
1841− -- and (2) of a truly polymorphic type.
1842− jArity = arityInt jc
1843− mbTvNames = map varTToNameMaybe $
1844− NE.drop (NE.length unapResTy - jArity) unapResTy
1845− -- We use M.fromList to ensure that if there are any duplicate type
1846− -- variables (as can happen in a GADT), the rightmost type variable gets
1847− -- associated with the show function.
1848− --
1849− -- See Note [Matching functions with GADT type variables]
1850− tvMap = M.fromList
1851− . catMaybes -- Drop refined types
1852− $ zipWith (\mbTvName tpj ->
1853− fmap (\tvName -> (tvName, tpj)) mbTvName)
1854− mbTvNames tpjs
1855− if (any (`predMentionsName` M.keys tvMap) ctxt
1856− || M.size tvMap < jArity)
1857− && not (allowExQuant jc)
1858− then existentialContextError conName
1859− else return (argTys, tvMap)
1556+checkExistentialContext :: JSONClass -> TyVarMap -> Cxt -> Name
1557+ -> Q a -> Q a
1558+checkExistentialContext jc tvMap ctxt conName q =
1559+ if (any (`predMentionsName` M.keys tvMap) ctxt
1560+ || M.size tvMap < arityInt jc)
1561+ && not (allowExQuant jc)
1562+ then existentialContextError conName
1563+ else q
18601564
18611565{-
18621566Note [Matching functions with GADT type variables]
@@ -1896,69 +1600,22 @@ Both.
18961600-- are the function arguments of types (b -> Value) and ([b] -> Value).
18971601type TyVarMap = Map Name (Name, Name)
18981602
1899−-- | If a VarT is missing an explicit kind signature, steal it from a TyVarBndr.
1900−stealKindForType :: TyVarBndr -> Type -> Type
1901−stealKindForType tvb t@VarT{} = SigT t (tvbKind tvb)
1902−stealKindForType _ t = t
1903−
1904−-- | Extracts the kind from a type variable binder.
1905−tvbKind :: TyVarBndr -> Kind
1906−#if MIN_VERSION_template_haskell(2,8,0)
1907−tvbKind (PlainTV _ ) = StarT
1908−#else
1909−tvbKind (PlainTV _ ) = StarK
1910−#endif
1911−tvbKind (KindedTV _ k) = k
1912−
1913−tvbToType :: TyVarBndr -> Type
1914−tvbToType (PlainTV n) = VarT n
1915−tvbToType (KindedTV n k) = SigT (VarT n) k
1916−
19171603-- | Returns True if a Type has kind *.
19181604hasKindStar :: Type -> Bool
19191605hasKindStar VarT{} = True
1920−#if MIN_VERSION_template_haskell(2,8,0)
19211606hasKindStar (SigT _ StarT) = True
1922−#else
1923−hasKindStar (SigT _ StarK) = True
1924−#endif
19251607hasKindStar _ = False
19261608
19271609-- Returns True is a kind is equal to *, or if it is a kind variable.
19281610isStarOrVar :: Kind -> Bool
1929−#if MIN_VERSION_template_haskell(2,8,0)
19301611isStarOrVar StarT = True
19311612isStarOrVar VarT{} = True
1932−#else
1933−isStarOrVar StarK = True
1934−#endif
19351613isStarOrVar _ = False
19361614
19371615-- Generate a list of fresh names with a common prefix, and numbered suffixes.
19381616newNameList :: String -> Int -> Q [Name]
19391617newNameList prefix len = mapM newName [prefix ++ show n | n <- [1..len]]
19401618
1941−-- Gets all of the type/kind variable names mentioned somewhere in a Type.
1942−tyVarNamesOfType :: Type -> [Name]
1943−tyVarNamesOfType = go
1944− where
1945− go :: Type -> [Name]
1946− go (AppT t1 t2) = go t1 ++ go t2
1947− go (SigT t _k) = go t
1948−#if MIN_VERSION_template_haskell(2,8,0)
1949− ++ go _k
1950−#endif
1951− go (VarT n) = [n]
1952− go _ = []
1953−
1954−-- | Gets all of the type/kind variable names mentioned somewhere in a Kind.
1955−tyVarNamesOfKind :: Kind -> [Name]
1956−#if MIN_VERSION_template_haskell(2,8,0)
1957−tyVarNamesOfKind = tyVarNamesOfType
1958−#else
1959−tyVarNamesOfKind _ = [] -- There are no kind variables
1960−#endif
1961−
19621619-- | @hasKindVarChain n kind@ Checks if @kind@ is of the form
19631620-- k_0 -> k_1 -> ... -> k_(n-1), where k0, k1, ..., and k_(n-1) can be * or
19641621-- kind variables.
@@ -1966,7 +1623,7 @@ hasKindVarChain :: Int -> Type -> Maybe [Name]
19661623hasKindVarChain kindArrows t =
19671624 let uk = uncurryKind (tyKind t)
19681625 in if (NE.length uk - 1 == kindArrows) && F.all isStarOrVar uk
1969− then Just (concatMap tyVarNamesOfKind uk)
1626+ then Just (concatMap freeVariables uk)
19701627 else Nothing
19711628
19721629-- | If a Type is a SigT, returns its kind signature. Otherwise, return *.
@@ -1986,17 +1643,6 @@ varTToNameMaybe _ = Nothing
19861643varTToName :: Type -> Name
19871644varTToName = fromMaybe (error "Not a type variable!") . varTToNameMaybe
19881645
1989−-- | Extracts the name from a constructor.
1990−getConName :: Con -> Name
1991−getConName (NormalC name _) = name
1992−getConName (RecC name _) = name
1993−getConName (InfixC _ name _) = name
1994−getConName (ForallC _ _ con) = getConName con
1995−#if MIN_VERSION_template_haskell(2,11,0)
1996−getConName (GadtC names _ _) = head names
1997−getConName (RecGadtC names _ _) = head names
1998−#endif
1999−
20001646interleave :: [a] -> [a] -> [a]
20011647interleave (a1:a1s) (a2:a2s) = a1:a2:interleave a1s a2s
20021648interleave _ _ = []
@@ -2021,9 +1667,7 @@ isTyFamily (ConT n) = do
20211667#else
20221668 FamilyI (FamilyD TypeFam _ _ _) _ -> True
20231669#endif
2024−#if MIN_VERSION_template_haskell(2,9,0)
20251670 FamilyI ClosedTypeFamilyD{} _ -> True
2026−#endif
20271671 _ -> False
20281672isTyFamily _ = return False
20291673
@@ -2051,9 +1695,7 @@ mentionsName = go
20511695 go :: Type -> [Name] -> Bool
20521696 go (AppT t1 t2) names = go t1 names || go t2 names
20531697 go (SigT t _k) names = go t names
2054−#if MIN_VERSION_template_haskell(2,8,0)
20551698 || go _k names
2056−#endif
20571699 go (VarT n) names = n `elem` names
20581700 go _ _ = False
20591701
@@ -2109,37 +1751,28 @@ uncurryTy t = ([], t :| [])
21091751
21101752-- | Like uncurryType, except on a kind level.
21111753uncurryKind :: Kind -> NonEmpty Kind
2112−#if MIN_VERSION_template_haskell(2,8,0)
21131754uncurryKind = snd . uncurryTy
2114−#else
2115−uncurryKind (ArrowK k1 k2) = k1 <| uncurryKind k2
2116−uncurryKind k = k :| []
2117−#endif
21181755
21191756createKindChain :: Int -> Kind
21201757createKindChain = go starK
21211758 where
21221759 go :: Kind -> Int -> Kind
21231760 go k 0 = k
2124−#if MIN_VERSION_template_haskell(2,8,0)
21251761 go k !n = go (AppT (AppT ArrowT StarT) k) (n - 1)
2126−#else
2127− go k !n = go (ArrowK StarK k) (n - 1)
2128−#endif
21291762
21301763-- | Makes a string literal expression from a constructor's name.
2131−conNameExp :: Options -> Con -> Q Exp
1764+conNameExp :: Options -> ConstructorInfo -> Q Exp
21321765conNameExp opts = litE
21331766 . stringL
21341767 . constructorTagModifier opts
21351768 . nameBase
2136− . getConName
1769+ . constructorName
21371770
2138−-- | Creates a string literal expression from a record field label.
2139−fieldLabelExp :: Options -- ^ Encoding options
2140− -> Name
2141− -> Q Exp
2142−fieldLabelExp opts = litE . stringL . fieldLabelModifier opts . nameBase
1771+-- | Extracts a record field label.
1772+fieldLabel :: Options -- ^ Encoding options
1773+ -> Name
1774+ -> String
1775+fieldLabel opts = fieldLabelModifier opts . nameBase
21431776
21441777-- | The name of the outermost 'Value' constructor.
21451778valueConName :: Value -> String
@@ -2178,73 +1811,11 @@ canEtaReduce remaining dropped =
21781811-- Expanding type synonyms
21791812-------------------------------------------------------------------------------
21801813
2181−-- | Expands all type synonyms in a type. Written by Dan Rosén in the
2182−-- @genifunctors@ package (licensed under BSD3).
2183−expandSyn :: Type -> Q Type
2184−expandSyn (ForallT tvs ctx t) = ForallT tvs ctx <$> expandSyn t
2185−expandSyn t@AppT{} = expandSynApp t []
2186−expandSyn t@ConT{} = expandSynApp t []
2187−expandSyn (SigT t k) = do t' <- expandSyn t
2188− k' <- expandSynKind k
2189− return (SigT t' k')
2190−expandSyn t = return t
2191−
2192−expandSynKind :: Kind -> Q Kind
2193−#if MIN_VERSION_template_haskell(2,8,0)
2194−expandSynKind = expandSyn
2195−#else
2196−expandSynKind = return -- There are no kind synonyms to deal with
2197−#endif
2198−
2199−expandSynApp :: Type -> [Type] -> Q Type
2200−expandSynApp (AppT t1 t2) ts = do
2201− t2' <- expandSyn t2
2202− expandSynApp t1 (t2':ts)
2203−expandSynApp (ConT n) ts | nameBase n == "[]" = return $ foldl' AppT ListT ts
2204−expandSynApp t@(ConT n) ts = do
2205− info <- reify n
2206− case info of
2207− TyConI (TySynD _ tvs rhs) ->
2208− let (ts', ts'') = splitAt (length tvs) ts
2209− subs = mkSubst tvs ts'
2210− rhs' = substType subs rhs
2211− in expandSynApp rhs' ts''
2212− _ -> return $ foldl' AppT t ts
2213−expandSynApp t ts = do
2214− t' <- expandSyn t
2215− return $ foldl' AppT t' ts
2216−
2217−type TypeSubst = Map Name Type
2218−type KindSubst = Map Name Kind
2219−
2220−mkSubst :: [TyVarBndr] -> [Type] -> TypeSubst
2221−mkSubst vs ts =
2222− let vs' = map un vs
2223− un (PlainTV v) = v
2224− un (KindedTV v _) = v
2225− in M.fromList $ zip vs' ts
2226−
2227−substType :: TypeSubst -> Type -> Type
2228−substType subs (ForallT v c t) = ForallT v c $ substType subs t
2229−substType subs t@(VarT n) = M.findWithDefault t n subs
2230−substType subs (AppT t1 t2) = AppT (substType subs t1) (substType subs t2)
2231−substType subs (SigT t k) = SigT (substType subs t)
2232−#if MIN_VERSION_template_haskell(2,8,0)
2233− (substType subs k)
2234−#else
2235− k
2236−#endif
2237−substType _ t = t
2238−
2239−substKind :: KindSubst -> Type -> Type
2240−#if MIN_VERSION_template_haskell(2,8,0)
2241−substKind = substType
2242−#else
2243−substKind _ t = t -- There are no kind variables!
2244−#endif
1814+applySubstitutionKind :: Map Name Kind -> Type -> Type
1815+applySubstitutionKind = applySubstitution
22451816
22461817substNameWithKind :: Name -> Kind -> Type -> Type
2247−substNameWithKind n k = substKind (M.singleton n k)
1818+substNameWithKind n k = applySubstitutionKind (M.singleton n k)
22481819
22491820substNamesWithKindStar :: [Name] -> Type -> Type
22501821substNamesWithKindStar ns t = foldr' (`substNameWithKind` starK) t ns
@@ -2330,6 +1901,13 @@ data Direction = To | From
23301901-- | A representation of which typeclass method is being spliced in.
23311902data JSONFun = ToJSON | ToEncoding | ParseJSON
23321903
1904+-- | A refinement of JSONFun to [ToJSON, ToEncoding].
1905+data ToJSONFun = Value | Encoding
1906+
1907+targetToJSONFun :: ToJSONFun -> JSONFun
1908+targetToJSONFun Value = ToJSON
1909+targetToJSONFun Encoding = ToEncoding
1910+
23331911-- | A representation of which typeclass is being derived.
23341912data JSONClass = JSONClass { direction :: Direction, arity :: Arity }
23351913
@@ -2398,9 +1976,7 @@ data StarKindStatus = NotKindStar
23981976canRealizeKindStar :: Type -> StarKindStatus
23991977canRealizeKindStar t = case t of
24001978 _ | hasKindStar t -> KindStar
2401−#if MIN_VERSION_template_haskell(2,8,0)
24021979 SigT _ (VarT k) -> IsKindVar k
2403−#endif
24041980 _ -> NotKindStar
24051981
24061982-- | Returns 'Just' the kind variable 'Name' of a 'StarKindStatus' if it exists.
Data/Aeson/Text.hs+5−4
@@ -1,4 +1,5 @@
11{-# LANGUAGE BangPatterns #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
23{-# LANGUAGE OverloadedStrings #-}
34-- |
45-- Module: Data.Aeson.Text
@@ -14,18 +15,18 @@
1415--
1516-- You can use the conversions to 'Builder's when embedding JSON messages as
1617-- parts of a protocol.
18+
1719module Data.Aeson.Text
1820 (
1921 encodeToLazyText
2022 , encodeToTextBuilder
2123 ) where
2224
23−import Prelude ()
2425import Prelude.Compat
2526
2627import Data.Aeson.Types (Value(..), ToJSON(..))
2728import Data.Aeson.Encoding (encodingToLazyByteString)
28−import Data.Monoid ((<>))
29+import Data.Semigroup ((<>))
2930import Data.Scientific (FPFormat(..), Scientific, base10Exponent)
3031import Data.Text.Lazy.Builder
3132import Data.Text.Lazy.Builder.Scientific (formatScientificBuilder)
@@ -46,8 +47,8 @@ encodeToLazyText = LT.decodeUtf8 . encodingToLazyByteString . toEncoding
4647-- embedded efficiently in a text-based protocol.
4748--
4849-- If you are going to immediately encode straight to a
49−-- 'L.ByteString', it is more efficient to use 'encodeToBuilder'
50−-- instead.
50+-- 'L.ByteString', it is more efficient to use 'encode' (lazy ByteString)
51+-- or @'fromEncoding' . 'toEncoding'@ (ByteString.Builder) instead.
5152--
5253-- /Note:/ Uses 'toJSON'
5354encodeToTextBuilder :: ToJSON a => a -> Builder
Data/Aeson/Types.hs+41−3
@@ -1,3 +1,4 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12-- |
23-- Module: Data.Aeson.Types
34-- Copyright: (c) 2011-2016 Bryan O'Sullivan
@@ -25,6 +26,7 @@ module Data.Aeson.Types
2526 -- * Convenience types and functions
2627 , DotNetTime(..)
2728 , typeMismatch
29+ , unexpected
2830 -- * Type conversion
2931 , Parser
3032 , Result(..)
@@ -36,6 +38,9 @@ module Data.Aeson.Types
3638 , ToJSON(..)
3739 , KeyValue(..)
3840 , modifyFailure
41+ , prependFailure
42+ , parserThrowError
43+ , parserCatchError
3944
4045 -- ** Keys for maps
4146 , ToJSONKey(..)
@@ -48,6 +53,12 @@ module Data.Aeson.Types
4853 , coerceFromJSONKeyFunction
4954 , mapFromJSONKeyFunction
5055
56+ -- *** Generic keys
57+ , GToJSONKey()
58+ , genericToJSONKey
59+ , GFromJSONKey()
60+ , genericFromJSONKey
61+
5162 -- ** Liftings to unary and binary type constructors
5263 , FromJSON1(..)
5364 , parseJSON1
@@ -79,9 +90,9 @@ module Data.Aeson.Types
7990 , withObject
8091 , withText
8192 , withArray
82− , withNumber
8393 , withScientific
8494 , withBool
95+ , withEmbeddedJSON
8596
8697 , pairs
8798 , foldable
@@ -102,15 +113,39 @@ module Data.Aeson.Types
102113 , listParser
103114
104115 -- * Generic and TH encoding configuration
105− , Options(..)
116+ , Options
117+
118+ -- ** Options fields
119+ -- $optionsFields
120+ , fieldLabelModifier
121+ , constructorTagModifier
122+ , allNullaryToStringTag
123+ , omitNothingFields
124+ , sumEncoding
125+ , unwrapUnaryRecords
126+ , tagSingleConstructors
127+ , rejectUnknownFields
128+
129+ -- ** Options utilities
106130 , SumEncoding(..)
107131 , camelTo
108132 , camelTo2
109133 , defaultOptions
110134 , defaultTaggedObject
135+
136+ -- ** Options for object keys
137+ , JSONKeyOptions
138+ , keyModifier
139+ , defaultJSONKeyOptions
140+
141+ -- * Parsing context
142+ , (<?>)
143+ , JSONPath
144+ , JSONPathElement(..)
145+ , formatPath
146+ , formatRelativePath
111147 ) where
112148
113−import Prelude ()
114149import Prelude.Compat
115150
116151import Data.Aeson.Encoding (Encoding, unsafeToEncoding, fromEncoding, Series, pairs)
@@ -122,3 +157,6 @@ import Data.Foldable (toList)
122157foldable :: (Foldable t, ToJSON a) => t a -> Encoding
123158foldable = toEncoding . toList
124159{-# INLINE foldable #-}
160+
161+-- $optionsFields
162+-- The functions here are in fact record fields of the 'Options' type.
Data/Aeson/Types/Class.hs+8−3
@@ -4,8 +4,8 @@
44{-# LANGUAGE FlexibleInstances #-}
55{-# LANGUAGE GADTs #-}
66{-# LANGUAGE MultiParamTypeClasses #-}
7+{-# LANGUAGE NoImplicitPrelude #-}
78{-# LANGUAGE ScopedTypeVariables #-}
8−{-# LANGUAGE TypeSynonymInstances #-}
99
1010-- |
1111-- Module: Data.Aeson.Types.Class
@@ -58,6 +58,11 @@ module Data.Aeson.Types.Class
5858 , fromJSONKeyCoerce
5959 , coerceFromJSONKeyFunction
6060 , mapFromJSONKeyFunction
61+ -- ** Generic keys
62+ , GToJSONKey()
63+ , genericToJSONKey
64+ , GFromJSONKey()
65+ , genericFromJSONKey
6166 -- * Object key-value pairs
6267 , KeyValue(..)
6368
@@ -70,14 +75,15 @@ module Data.Aeson.Types.Class
7075 , withObject
7176 , withText
7277 , withArray
73− , withNumber
7478 , withScientific
7579 , withBool
80+ , withEmbeddedJSON
7681
7782 -- * Functions
7883 , fromJSON
7984 , ifromJSON
8085 , typeMismatch
86+ , unexpected
8187 , parseField
8288 , parseFieldMaybe
8389 , parseFieldMaybe'
@@ -91,7 +97,6 @@ module Data.Aeson.Types.Class
9197 , (.!=)
9298 ) where
9399
94−import Prelude ()
95100
96101import Data.Aeson.Types.FromJSON
97102import Data.Aeson.Types.Generic (One, Zero)
Data/Aeson/Types/FromJSON.hs+863−420
@@ -5,19 +5,16 @@
55{-# LANGUAGE FlexibleInstances #-}
66{-# LANGUAGE GADTs #-}
77{-# LANGUAGE MultiParamTypeClasses #-}
8−{-# LANGUAGE NamedFieldPuns #-}
8+{-# LANGUAGE NoImplicitPrelude #-}
99{-# LANGUAGE OverloadedStrings #-}
10+{-# LANGUAGE PolyKinds #-}
1011{-# LANGUAGE RecordWildCards #-}
1112{-# LANGUAGE ScopedTypeVariables #-}
1213{-# LANGUAGE TypeOperators #-}
13−{-# LANGUAGE TypeSynonymInstances #-}
14+{-# LANGUAGE TupleSections #-}
1415{-# LANGUAGE UndecidableInstances #-}
1516{-# LANGUAGE ViewPatterns #-}
1617
17−#if __GLASGOW_HASKELL__ >= 706
18−{-# LANGUAGE PolyKinds #-}
19−#endif
20−
2118#include "incoherent-compat.h"
2219#include "overlapping-compat.h"
2320
@@ -45,6 +42,9 @@ module Data.Aeson.Types.FromJSON
4542 , coerceFromJSONKeyFunction
4643 , mapFromJSONKeyFunction
4744
45+ , GFromJSONKey()
46+ , genericFromJSONKey
47+
4848 -- * List functions
4949 , listParser
5050
@@ -52,20 +52,22 @@ module Data.Aeson.Types.FromJSON
5252 , withObject
5353 , withText
5454 , withArray
55− , withNumber
5655 , withScientific
5756 , withBool
57+ , withEmbeddedJSON
5858
5959 -- * Functions
6060 , fromJSON
6161 , ifromJSON
6262 , typeMismatch
63+ , unexpected
6364 , parseField
6465 , parseFieldMaybe
6566 , parseFieldMaybe'
6667 , explicitParseField
6768 , explicitParseFieldMaybe
6869 , explicitParseFieldMaybe'
70+ , parseIndexedJSON
6971 -- ** Operators
7072 , (.:)
7173 , (.:?)
@@ -76,17 +78,16 @@ module Data.Aeson.Types.FromJSON
7678 , parseOptionalFieldWith
7779 ) where
7880
79−import Prelude ()
8081import Prelude.Compat
8182
82−import Control.Applicative ((<|>), Const(..))
83−import Control.Monad ((<=<), zipWithM)
83+import Control.Applicative ((<|>), Const(..), liftA2)
84+import Control.Monad (zipWithM)
8485import Data.Aeson.Internal.Functions (mapKey)
86+import Data.Aeson.Parser.Internal (eitherDecodeWith, jsonEOF)
8587import Data.Aeson.Types.Generic
8688import Data.Aeson.Types.Internal
87−import Data.Attoparsec.Number (Number(..))
8889import Data.Bits (unsafeShiftR)
89−import Data.Fixed (Fixed, HasResolution)
90+import Data.Fixed (Fixed, HasResolution (resolution), Nano)
9091import Data.Functor.Compose (Compose(..))
9192import Data.Functor.Identity (Identity(..))
9293import Data.Functor.Product (Product(..))
@@ -95,26 +96,31 @@ import Data.Hashable (Hashable(..))
9596import Data.Int (Int16, Int32, Int64, Int8)
9697import Data.List.NonEmpty (NonEmpty(..))
9798import Data.Maybe (fromMaybe)
98−import Data.Monoid ((<>))
99+import Data.Semigroup ((<>))
99100import Data.Proxy (Proxy(..))
100101import Data.Ratio ((%), Ratio)
101−import Data.Scientific (Scientific)
102+import Data.Scientific (Scientific, base10Exponent)
102103import Data.Tagged (Tagged(..))
103104import Data.Text (Text, pack, unpack)
104−import Data.Time (Day, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
105−import Data.Time.Format (parseTime)
106−import Data.Time.Locale.Compat (defaultTimeLocale)
105+import Data.Time (Day, DiffTime, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
106+import Data.Time.Calendar.Compat (CalendarDiffDays (..), DayOfWeek (..))
107+import Data.Time.LocalTime.Compat (CalendarDiffTime (..))
108+import Data.Time.Clock.System.Compat (SystemTime (..))
109+import Data.Time.Format.Compat (parseTimeM, defaultTimeLocale)
107110import Data.Traversable as Tr (sequence)
108111import Data.Vector (Vector)
109112import Data.Version (Version, parseVersion)
113+import Data.Void (Void)
110114import Data.Word (Word16, Word32, Word64, Word8)
111115import Foreign.Storable (Storable)
116+import Foreign.C.Types (CTime (..))
112117import GHC.Generics
113118import Numeric.Natural (Natural)
114119import Text.ParserCombinators.ReadP (readP_to_S)
115120import Unsafe.Coerce (unsafeCoerce)
116121import qualified Data.Aeson.Parser.Time as Time
117122import qualified Data.Attoparsec.ByteString.Char8 as A (endOfInput, parseOnly, scientific)
123+import qualified Data.ByteString.Lazy as L
118124import qualified Data.DList as DList
119125import qualified Data.HashMap.Strict as H
120126import qualified Data.HashSet as HashSet
@@ -137,18 +143,20 @@ import qualified Data.Vector.Primitive as VP
137143import qualified Data.Vector.Storable as VS
138144import qualified Data.Vector.Unboxed as VU
139145
140−#ifndef HAS_COERCIBLE
141−#define HAS_COERCIBLE (__GLASGOW_HASKELL__ >= 707)
146+import qualified GHC.Exts as Exts
147+import qualified Data.Primitive.Array as PM
148+import qualified Data.Primitive.SmallArray as PM
149+import qualified Data.Primitive.Types as PM
150+
151+#if MIN_VERSION_primitive(0,6,4)
152+#if !MIN_VERSION_primitive(0,7,0)
153+import qualified Data.Primitive.UnliftedArray as PM
142154#endif
155+import qualified Data.Primitive.PrimArray as PM
156+#endif
157+
143158
144−#if HAS_COERCIBLE
145159import Data.Coerce (Coercible, coerce)
146−coerce' :: Coercible a b => a -> b
147−coerce' = coerce
148−#else
149−coerce' :: a -> b
150−coerce' = unsafeCoerce
151−#endif
152160
153161parseIndexedJSON :: (Value -> Parser a) -> Int -> Value -> Parser a
154162parseIndexedJSON p idx value = p value <?> Index idx
@@ -157,7 +165,7 @@ parseIndexedJSON p idx value = p value <?> Index idx
157165parseIndexedJSONPair :: (Value -> Parser a) -> (Value -> Parser b) -> Int -> Value -> Parser (a, b)
158166parseIndexedJSONPair keyParser valParser idx value = p value <?> Index idx
159167 where
160− p = withArray "(k,v)" $ \ab ->
168+ p = withArray "(k, v)" $ \ab ->
161169 let n = V.length ab
162170 in if n == 2
163171 then (,) <$> parseJSONElemAtIndex keyParser 0 ab
@@ -169,43 +177,34 @@ parseIndexedJSONPair keyParser valParser idx value = p value <?> Index idx
169177parseJSONElemAtIndex :: (Value -> Parser a) -> Int -> V.Vector Value -> Parser a
170178parseJSONElemAtIndex p idx ary = p (V.unsafeIndex ary idx) <?> Index idx
171179
172−scientificToNumber :: Scientific -> Number
173−scientificToNumber s
174− | e < 0 = D $ Scientific.toRealFloat s
175− | otherwise = I $ c * 10 ^ e
176− where
177− e = Scientific.base10Exponent s
178− c = Scientific.coefficient s
179−{-# INLINE scientificToNumber #-}
180−
181180parseRealFloat :: RealFloat a => String -> Value -> Parser a
182−parseRealFloat _ (Number s) = pure $ Scientific.toRealFloat s
183−parseRealFloat _ Null = pure (0/0)
184−parseRealFloat expected v = typeMismatch expected v
181+parseRealFloat _ (Number s) = pure $ Scientific.toRealFloat s
182+parseRealFloat _ Null = pure (0/0)
183+parseRealFloat name v = prependContext name (unexpected v)
185184{-# INLINE parseRealFloat #-}
186185
187−parseIntegralFromScientific :: forall a. Integral a => String -> Scientific -> Parser a
188−parseIntegralFromScientific expected s =
186+parseIntegralFromScientific :: forall a. Integral a => Scientific -> Parser a
187+parseIntegralFromScientific s =
189188 case Scientific.floatingOrInteger s :: Either Double a of
190189 Right x -> pure x
191− Left _ -> fail $ "Floating number specified for " ++ expected ++ ": " ++ show s
190+ Left _ -> fail $ "unexpected floating number " ++ show s
192191{-# INLINE parseIntegralFromScientific #-}
193192
194193parseIntegral :: Integral a => String -> Value -> Parser a
195−parseIntegral expected =
196− withScientific expected $ parseIntegralFromScientific expected
194+parseIntegral name =
195+ prependContext name . withBoundedScientific' parseIntegralFromScientific
197196{-# INLINE parseIntegral #-}
198197
199−parseBoundedIntegralFromScientific :: (Bounded a, Integral a) => String -> Scientific -> Parser a
200−parseBoundedIntegralFromScientific expected s = maybe
201− (fail $ expected ++ " is either floating or will cause over or underflow: " ++ show s)
198+parseBoundedIntegralFromScientific :: (Bounded a, Integral a) => Scientific -> Parser a
199+parseBoundedIntegralFromScientific s = maybe
200+ (fail $ "value is either floating or will cause over or underflow " ++ show s)
202201 pure
203202 (Scientific.toBoundedInteger s)
204203{-# INLINE parseBoundedIntegralFromScientific #-}
205204
206205parseBoundedIntegral :: (Bounded a, Integral a) => String -> Value -> Parser a
207−parseBoundedIntegral expected =
208− withScientific expected $ parseBoundedIntegralFromScientific expected
206+parseBoundedIntegral name =
207+ prependContext name . withScientific' parseBoundedIntegralFromScientific
209208{-# INLINE parseBoundedIntegral #-}
210209
211210parseScientificText :: Text -> Parser Scientific
@@ -215,13 +214,20 @@ parseScientificText
215214 . T.encodeUtf8
216215
217216parseIntegralText :: Integral a => String -> Text -> Parser a
218−parseIntegralText expected t =
219− parseScientificText t >>= parseIntegralFromScientific expected
217+parseIntegralText name t =
218+ prependContext name $
219+ parseScientificText t
220+ >>= rejectLargeExponent
221+ >>= parseIntegralFromScientific
222+ where
223+ rejectLargeExponent :: Scientific -> Parser Scientific
224+ rejectLargeExponent s = withBoundedScientific' pure (Number s)
220225{-# INLINE parseIntegralText #-}
221226
222227parseBoundedIntegralText :: (Bounded a, Integral a) => String -> Text -> Parser a
223−parseBoundedIntegralText expected t =
224− parseScientificText t >>= parseBoundedIntegralFromScientific expected
228+parseBoundedIntegralText name t =
229+ prependContext name $
230+ parseScientificText t >>= parseBoundedIntegralFromScientific
225231
226232parseOptionalFieldWith :: (Value -> Parser (Maybe a))
227233 -> Object -> Text -> Parser (Maybe a)
@@ -281,14 +287,21 @@ genericLiftParseJSON opts pj pjl = fmap to1 . gParseJSON opts (From1Args pj pjl)
281287--
282288-- The basic ways to signal a failed conversion are as follows:
283289--
284−-- * 'empty' and 'mzero' work, but are terse and uninformative;
290+-- * 'fail' yields a custom error message: it is the recommended way of
291+-- reporting a failure;
285292--
286−-- * 'fail' yields a custom error message;
293+-- * 'Control.Applicative.empty' (or 'Control.Monad.mzero') is uninformative:
294+-- use it when the error is meant to be caught by some @('<|>')@;
287295--
288−-- * 'typeMismatch' produces an informative message for cases when the
289−-- value encountered is not of the expected type.
296+-- * 'typeMismatch' can be used to report a failure when the encountered value
297+-- is not of the expected JSON type; 'unexpected' is an appropriate alternative
298+-- when more than one type may be expected, or to keep the expected type
299+-- implicit.
290300--
291−-- An example type and instance using 'typeMismatch':
301+-- 'prependFailure' (or 'modifyFailure') add more information to a parser's
302+-- error messages.
303+--
304+-- An example type and instance using 'typeMismatch' and 'prependFailure':
292305--
293306-- @
294307-- \-- Allow ourselves to write 'Text' literals.
@@ -302,20 +315,22 @@ genericLiftParseJSON opts pj pjl = fmap to1 . gParseJSON opts (From1Args pj pjl)
302315-- '<*>' v '.:' \"y\"
303316--
304317-- \-- We do not expect a non-'Object' value here.
305−-- \-- We could use 'mzero' to fail, but 'typeMismatch'
318+-- \-- We could use 'Control.Applicative.empty' to fail, but 'typeMismatch'
306319-- \-- gives a much more informative error message.
307−-- 'parseJSON' invalid = 'typeMismatch' \"Coord\" invalid
320+-- 'parseJSON' invalid =
321+-- 'prependFailure' "parsing Coord failed, "
322+-- ('typeMismatch' \"Object\" invalid)
308323-- @
309324--
310325-- For this common case of only being concerned with a single
311−-- type of JSON value, the functions 'withObject', 'withNumber', etc.
326+-- type of JSON value, the functions 'withObject', 'withScientific', etc.
312327-- are provided. Their use is to be preferred when possible, since
313328-- they are more terse. Using 'withObject', we can rewrite the above instance
314329-- (assuming the same language extension and data type) as:
315330--
316331-- @
317332-- instance 'FromJSON' Coord where
318−-- 'parseJSON' = 'withObject' \"Coord\" $ \v -> Coord
333+-- 'parseJSON' = 'withObject' \"Coord\" $ \\v -> Coord
319334-- '<$>' v '.:' \"x\"
320335-- '<*>' v '.:' \"y\"
321336-- @
@@ -347,7 +362,7 @@ genericLiftParseJSON opts pj pjl = fmap to1 . gParseJSON opts (From1Args pj pjl)
347362-- @
348363--
349364-- The default implementation will be equivalent to
350−-- @parseJSON = 'genericParseJSON' 'defaultOptions'@; If you need different
365+-- @parseJSON = 'genericParseJSON' 'defaultOptions'@; if you need different
351366-- options, you can customize the generic decoding by defining:
352367--
353368-- @
@@ -365,13 +380,11 @@ class FromJSON a where
365380 parseJSON = genericParseJSON defaultOptions
366381
367382 parseJSONList :: Value -> Parser [a]
368− parseJSONList (Array a)
369− = zipWithM (parseIndexedJSON parseJSON) [0..]
383+ parseJSONList = withArray "[]" $ \a ->
384+ zipWithM (parseIndexedJSON parseJSON) [0..]
370385 . V.toList
371386 $ a
372387
373− parseJSONList v = typeMismatch "[a]" v
374−
375388-------------------------------------------------------------------------------
376389-- Classes and types for map keys
377390-------------------------------------------------------------------------------
@@ -383,6 +396,16 @@ class FromJSON a where
383396-- > newtype SomeId = SomeId { getSomeId :: Text }
384397-- > deriving (Eq,Ord,Hashable,FromJSONKey)
385398--
399+-- If you have a sum of nullary constructors, you may use the generic
400+-- implementation:
401+--
402+-- @
403+-- data Color = Red | Green | Blue
404+-- deriving Generic
405+--
406+-- instance 'FromJSONKey' Color where
407+-- 'fromJSONKey' = 'genericFromJSONKey' 'defaultJSONKeyOptions'
408+-- @
386409class FromJSONKey a where
387410 -- | Strategy for parsing the key of a map-like container.
388411 fromJSONKey :: FromJSONKeyFunction a
@@ -405,11 +428,7 @@ class FromJSONKey a where
405428-- At the moment this type is intentionally not exported. 'FromJSONKeyFunction'
406429-- can be inspected, but cannot be constructed.
407430data CoerceText a where
408−#if HAS_COERCIBLE
409431 CoerceText :: Coercible Text a => CoerceText a
410−#else
411− CoerceText :: CoerceText a
412−#endif
413432
414433-- | This type is related to 'ToJSONKeyFunction'. If 'FromJSONKeyValue' is used in the
415434-- 'FromJSONKey' instance, then 'ToJSONKeyValue' should be used in the 'ToJSONKey'
@@ -429,7 +448,7 @@ data FromJSONKeyFunction a
429448
430449-- | Only law abiding up to interpretation
431450instance Functor FromJSONKeyFunction where
432− fmap h (FromJSONKeyCoerce CoerceText) = FromJSONKeyText (h . coerce')
451+ fmap h (FromJSONKeyCoerce CoerceText) = FromJSONKeyText (h . coerce)
433452 fmap h (FromJSONKeyText f) = FromJSONKeyText (h . f)
434453 fmap h (FromJSONKeyTextParser f) = FromJSONKeyTextParser (fmap h . f)
435454 fmap h (FromJSONKeyValue f) = FromJSONKeyValue (fmap h . f)
@@ -443,9 +462,7 @@ instance Functor FromJSONKeyFunction where
443462--
444463-- On pre GHC 7.8 this is unconstrainted function.
445464fromJSONKeyCoerce ::
446−#if HAS_COERCIBLE
447465 Coercible Text a =>
448−#endif
449466 FromJSONKeyFunction a
450467fromJSONKeyCoerce = FromJSONKeyCoerce CoerceText
451468
@@ -453,60 +470,91 @@ fromJSONKeyCoerce = FromJSONKeyCoerce CoerceText
453470--
454471-- See note on 'fromJSONKeyCoerce'.
455472coerceFromJSONKeyFunction ::
456−#if HAS_COERCIBLE
457473 Coercible a b =>
458−#endif
459474 FromJSONKeyFunction a -> FromJSONKeyFunction b
460−#if HAS_COERCIBLE
461475coerceFromJSONKeyFunction = coerce
462−#else
463−coerceFromJSONKeyFunction (FromJSONKeyCoerce CoerceText) = FromJSONKeyCoerce CoerceText
464−coerceFromJSONKeyFunction (FromJSONKeyText f) = FromJSONKeyText (coerce' . f)
465−coerceFromJSONKeyFunction (FromJSONKeyTextParser f) = FromJSONKeyTextParser (fmap coerce' . f)
466−coerceFromJSONKeyFunction (FromJSONKeyValue f) = FromJSONKeyValue (fmap coerce' . f)
467−#endif
468476
469477{-# RULES
470478 "FromJSONKeyCoerce: fmap id" forall (x :: FromJSONKeyFunction a).
471479 fmap id x = x
472480 #-}
473−#if HAS_COERCIBLE
474481{-# RULES
475482 "FromJSONKeyCoerce: fmap coerce" forall x .
476483 fmap coerce x = coerceFromJSONKeyFunction x
477484 #-}
478−#endif
479485
480486-- | Same as 'fmap'. Provided for the consistency with 'ToJSONKeyFunction'.
481487mapFromJSONKeyFunction :: (a -> b) -> FromJSONKeyFunction a -> FromJSONKeyFunction b
482488mapFromJSONKeyFunction = fmap
483489
490+-- | 'fromJSONKey' for 'Generic' types.
491+-- These types must be sums of nullary constructors, whose names will be used
492+-- as keys for JSON objects.
493+--
494+-- See also 'genericToJSONKey'.
495+--
496+-- === __Example__
497+--
498+-- @
499+-- data Color = Red | Green | Blue
500+-- deriving 'Generic'
501+--
502+-- instance 'FromJSONKey' Color where
503+-- 'fromJSONKey' = 'genericFromJSONKey' 'defaultJSONKeyOptions'
504+-- @
505+genericFromJSONKey :: forall a. (Generic a, GFromJSONKey (Rep a))
506+ => JSONKeyOptions
507+ -> FromJSONKeyFunction a
508+genericFromJSONKey opts = FromJSONKeyTextParser $ \t ->
509+ case parseSumFromString (keyModifier opts) t of
510+ Nothing -> fail $
511+ "invalid key " ++ show t ++ ", expected one of " ++ show cnames
512+ Just k -> pure (to k)
513+ where
514+ cnames = unTagged2 (constructorTags (keyModifier opts) :: Tagged2 (Rep a) [String])
515+
516+class (ConstructorNames f, SumFromString f) => GFromJSONKey f where
517+instance (ConstructorNames f, SumFromString f) => GFromJSONKey f where
518+
484519-------------------------------------------------------------------------------
485520-- Functions needed for documentation
486521-------------------------------------------------------------------------------
487522
488523-- | Fail parsing due to a type mismatch, with a descriptive message.
489524--
490−-- Example usage:
525+-- The following wrappers should generally be prefered:
526+-- 'withObject', 'withArray', 'withText', 'withBool'.
491527--
492−-- @
493−-- instance FromJSON Coord where
494−-- parseJSON ('Object' v) = {- type matches, life is good -}
495−-- parseJSON wat = 'typeMismatch' \"Coord\" wat
496−-- @
497−typeMismatch :: String -- ^ The name of the type you are trying to parse.
528+-- ==== Error message example
529+--
530+-- > typeMismatch "Object" (String "oops")
531+-- > -- Error: "expected Object, but encountered String"
532+typeMismatch :: String -- ^ The name of the JSON type being parsed
533+ -- (@\"Object\"@, @\"Array\"@, @\"String\"@, @\"Number\"@,
534+ -- @\"Boolean\"@, or @\"Null\"@).
498535 -> Value -- ^ The actual value encountered.
499536 -> Parser a
500537typeMismatch expected actual =
501− fail $ "expected " ++ expected ++ ", encountered " ++ name
502− where
503− name = case actual of
504− Object _ -> "Object"
505− Array _ -> "Array"
506− String _ -> "String"
507− Number _ -> "Number"
508− Bool _ -> "Boolean"
509− Null -> "Null"
538+ fail $ "expected " ++ expected ++ ", but encountered " ++ typeOf actual
539+
540+-- | Fail parsing due to a type mismatch, when the expected types are implicit.
541+--
542+-- ==== Error message example
543+--
544+-- > unexpected (String "oops")
545+-- > -- Error: "unexpected String"
546+unexpected :: Value -> Parser a
547+unexpected actual = fail $ "unexpected " ++ typeOf actual
548+
549+-- | JSON type of a value, name of the head constructor.
550+typeOf :: Value -> String
551+typeOf v = case v of
552+ Object _ -> "Object"
553+ Array _ -> "Array"
554+ String _ -> "String"
555+ Number _ -> "Number"
556+ Bool _ -> "Boolean"
557+ Null -> "Null"
510558
511559-------------------------------------------------------------------------------
512560-- Lifings of FromJSON and ToJSON to unary and binary type constructors
@@ -587,9 +635,8 @@ class FromJSON2 f where
587635 -> (Value -> Parser b)
588636 -> (Value -> Parser [b])
589637 -> Value -> Parser [f a b]
590− liftParseJSONList2 fa ga fb gb v = case v of
591− Array vals -> fmap V.toList (V.mapM (liftParseJSON2 fa ga fb gb) vals)
592− _ -> typeMismatch "[a]" v
638+ liftParseJSONList2 fa ga fb gb = withArray "[]" $ \vals ->
639+ fmap V.toList (V.mapM (liftParseJSON2 fa ga fb gb) vals)
593640
594641-- | Lift the standard 'parseJSON' function through the type constructor.
595642parseJSON2 :: (FromJSON2 f, FromJSON a, FromJSON b) => Value -> Parser (f a b)
@@ -603,7 +650,7 @@ parseJSON2 = liftParseJSON2 parseJSON parseJSONList parseJSON parseJSONList
603650-- | Helper function to use with 'liftParseJSON'. See 'Data.Aeson.ToJSON.listEncoding'.
604651listParser :: (Value -> Parser a) -> Value -> Parser [a]
605652listParser f (Array xs) = fmap V.toList (V.mapM f xs)
606−listParser _ v = typeMismatch "[a]" v
653+listParser _ v = typeMismatch "Array" v
607654{-# INLINE listParser #-}
608655
609656-------------------------------------------------------------------------------
@@ -621,49 +668,139 @@ instance (FromJSON a) => FromJSON [a] where
621668-- Functions
622669-------------------------------------------------------------------------------
623670
624−-- | @'withObject' expected f value@ applies @f@ to the 'Object' when @value@
625−-- is an 'Object' and fails using @'typeMismatch' expected@ otherwise.
671+-- | Add context to a failure message, indicating the name of the structure
672+-- being parsed.
673+--
674+-- > prependContext "MyType" (fail "[error message]")
675+-- > -- Error: "parsing MyType failed, [error message]"
676+prependContext :: String -> Parser a -> Parser a
677+prependContext name = prependFailure ("parsing " ++ name ++ " failed, ")
678+
679+-- | @'withObject' name f value@ applies @f@ to the 'Object' when @value@
680+-- is an 'Data.Aeson.Object' and fails otherwise.
681+--
682+-- ==== Error message example
683+--
684+-- > withObject "MyType" f (String "oops")
685+-- > -- Error: "parsing MyType failed, expected Object, but encountered String"
626686withObject :: String -> (Object -> Parser a) -> Value -> Parser a
627−withObject _ f (Object obj) = f obj
628−withObject expected _ v = typeMismatch expected v
687+withObject _ f (Object obj) = f obj
688+withObject name _ v = prependContext name (typeMismatch "Object" v)
629689{-# INLINE withObject #-}
630690
631−-- | @'withText' expected f value@ applies @f@ to the 'Text' when @value@ is a
632−-- 'String' and fails using @'typeMismatch' expected@ otherwise.
691+-- | @'withText' name f value@ applies @f@ to the 'Text' when @value@ is a
692+-- 'Data.Aeson.String' and fails otherwise.
693+--
694+-- ==== Error message example
695+--
696+-- > withText "MyType" f Null
697+-- > -- Error: "parsing MyType failed, expected String, but encountered Null"
633698withText :: String -> (Text -> Parser a) -> Value -> Parser a
634−withText _ f (String txt) = f txt
635−withText expected _ v = typeMismatch expected v
699+withText _ f (String txt) = f txt
700+withText name _ v = prependContext name (typeMismatch "String" v)
636701{-# INLINE withText #-}
637702
638703-- | @'withArray' expected f value@ applies @f@ to the 'Array' when @value@ is
639−-- an 'Array' and fails using @'typeMismatch' expected@ otherwise.
704+-- an 'Data.Aeson.Array' and fails otherwise.
705+--
706+-- ==== Error message example
707+--
708+-- > withArray "MyType" f (String "oops")
709+-- > -- Error: "parsing MyType failed, expected Array, but encountered String"
640710withArray :: String -> (Array -> Parser a) -> Value -> Parser a
641−withArray _ f (Array arr) = f arr
642−withArray expected _ v = typeMismatch expected v
711+withArray _ f (Array arr) = f arr
712+withArray name _ v = prependContext name (typeMismatch "Array" v)
643713{-# INLINE withArray #-}
644714
645−-- | @'withNumber' expected f value@ applies @f@ to the 'Number' when @value@
646−-- is a 'Number' and fails using @'typeMismatch' expected@ otherwise.
647−withNumber :: String -> (Number -> Parser a) -> Value -> Parser a
648−withNumber expected f = withScientific expected (f . scientificToNumber)
649−{-# INLINE withNumber #-}
650−{-# DEPRECATED withNumber "Use withScientific instead" #-}
651−
652−-- | @'withScientific' expected f value@ applies @f@ to the 'Scientific' number
653−-- when @value@ is a 'Number' and fails using @'typeMismatch' expected@
715+-- | @'withScientific' name f value@ applies @f@ to the 'Scientific' number
716+-- when @value@ is a 'Data.Aeson.Number' and fails using 'typeMismatch'
654717-- otherwise.
718+--
719+-- /Warning/: If you are converting from a scientific to an unbounded
720+-- type such as 'Integer' you may want to add a restriction on the
721+-- size of the exponent (see 'withBoundedScientific') to prevent
722+-- malicious input from filling up the memory of the target system.
723+--
724+-- ==== Error message example
725+--
726+-- > withScientific "MyType" f (String "oops")
727+-- > -- Error: "parsing MyType failed, expected Number, but encountered String"
655728withScientific :: String -> (Scientific -> Parser a) -> Value -> Parser a
656−withScientific _ f (Number scientific) = f scientific
657−withScientific expected _ v = typeMismatch expected v
729+withScientific _ f (Number scientific) = f scientific
730+withScientific name _ v = prependContext name (typeMismatch "Number" v)
658731{-# INLINE withScientific #-}
659732
733+-- | A variant of 'withScientific' which doesn't use 'prependContext', so that
734+-- such context can be added separately in a way that also applies when the
735+-- continuation @f :: Scientific -> Parser a@ fails.
736+--
737+-- /Warning/: If you are converting from a scientific to an unbounded
738+-- type such as 'Integer' you may want to add a restriction on the
739+-- size of the exponent (see 'withBoundedScientific') to prevent
740+-- malicious input from filling up the memory of the target system.
741+--
742+-- ==== Error message examples
743+--
744+-- > withScientific' f (String "oops")
745+-- > -- Error: "unexpected String"
746+-- >
747+-- > prependContext "MyType" (withScientific' f (String "oops"))
748+-- > -- Error: "parsing MyType failed, unexpected String"
749+withScientific' :: (Scientific -> Parser a) -> Value -> Parser a
750+withScientific' f v = case v of
751+ Number n -> f n
752+ _ -> typeMismatch "Number" v
753+{-# INLINE withScientific' #-}
754+
755+-- | @'withBoundedScientific' name f value@ applies @f@ to the 'Scientific' number
756+-- when @value@ is a 'Number' with exponent less than or equal to 1024.
757+withBoundedScientific :: String -> (Scientific -> Parser a) -> Value -> Parser a
758+withBoundedScientific name f v = withBoundedScientific_ (prependContext name) f v
759+{-# INLINE withBoundedScientific #-}
760+
761+-- | A variant of 'withBoundedScientific' which doesn't use 'prependContext',
762+-- so that such context can be added separately in a way that also applies
763+-- when the continuation @f :: Scientific -> Parser a@ fails.
764+withBoundedScientific' :: (Scientific -> Parser a) -> Value -> Parser a
765+withBoundedScientific' f v = withBoundedScientific_ id f v
766+{-# INLINE withBoundedScientific' #-}
767+
768+-- | A variant of 'withBoundedScientific_' parameterized by a function to apply
769+-- to the 'Parser' in case of failure.
770+withBoundedScientific_ :: (Parser a -> Parser a) -> (Scientific -> Parser a) -> Value -> Parser a
771+withBoundedScientific_ whenFail f (Number scientific) =
772+ if exp10 > 1024
773+ then whenFail (fail msg)
774+ else f scientific
775+ where
776+ exp10 = base10Exponent scientific
777+ msg = "found a number with exponent " ++ show exp10 ++ ", but it must not be greater than 1024"
778+withBoundedScientific_ whenFail _ v =
779+ whenFail (typeMismatch "Number" v)
780+{-# INLINE withBoundedScientific_ #-}
781+
660782-- | @'withBool' expected f value@ applies @f@ to the 'Bool' when @value@ is a
661−-- 'Bool' and fails using @'typeMismatch' expected@ otherwise.
783+-- 'Boolean' and fails otherwise.
784+--
785+-- ==== Error message example
786+--
787+-- > withBool "MyType" f (String "oops")
788+-- > -- Error: "parsing MyType failed, expected Boolean, but encountered String"
662789withBool :: String -> (Bool -> Parser a) -> Value -> Parser a
663−withBool _ f (Bool arr) = f arr
664−withBool expected _ v = typeMismatch expected v
790+withBool _ f (Bool arr) = f arr
791+withBool name _ v = prependContext name (typeMismatch "Boolean" v)
665792{-# INLINE withBool #-}
666793
794+-- | Decode a nested JSON-encoded string.
795+withEmbeddedJSON :: String -> (Value -> Parser a) -> Value -> Parser a
796+withEmbeddedJSON _ innerParser (String txt) =
797+ either fail innerParser $ eitherDecode (L.fromStrict $ T.encodeUtf8 txt)
798+ where
799+ eitherDecode = eitherFormatError . eitherDecodeWith jsonEOF ifromJSON
800+ eitherFormatError = either (Left . uncurry formatError) Right
801+withEmbeddedJSON name _ v = prependContext name (typeMismatch "String" v)
802+{-# INLINE withEmbeddedJSON #-}
803+
667804-- | Convert a value from JSON, failing if the types do not match.
668805fromJSON :: (FromJSON a) => Value -> Result a
669806fromJSON = parse parseJSON
@@ -726,7 +863,7 @@ parseFieldMaybe' = (.:!)
726863-- E.g. @'explicitParseField' 'parseJSON1' :: ('FromJSON1' f, 'FromJSON' a) -> 'Object' -> 'Text' -> 'Parser' (f a)@
727864explicitParseField :: (Value -> Parser a) -> Object -> Text -> Parser a
728865explicitParseField p obj key = case H.lookup key obj of
729− Nothing -> fail $ "key " ++ show key ++ " not present"
866+ Nothing -> fail $ "key " ++ show key ++ " not found"
730867 Just v -> p v <?> Key key
731868{-# INLINE explicitParseField #-}
732869
@@ -766,11 +903,47 @@ pmval .!= val = fromMaybe val <$> pmval
766903-- Generic parseJSON
767904-------------------------------------------------------------------------------
768905
906+instance GFromJSON arity V1 where
907+ -- Whereof we cannot format, thereof we cannot parse:
908+ gParseJSON _ _ _ = fail "Attempted to parse empty type"
909+
910+
769911instance OVERLAPPABLE_ (GFromJSON arity a) => GFromJSON arity (M1 i c a) where
770912 -- Meta-information, which is not handled elsewhere, is just added to the
771913 -- parsed value:
772914 gParseJSON opts fargs = fmap M1 . gParseJSON opts fargs
773915
916+-- Information for error messages
917+
918+type TypeName = String
919+type ConName = String
920+
921+-- | Add the name of the type being parsed to a parser's error messages.
922+contextType :: TypeName -> Parser a -> Parser a
923+contextType = prependContext
924+
925+-- | Add the tagKey that will be looked up while building an ADT
926+-- | Produce the error equivalent to
927+-- | Left "Error in $: parsing T failed, expected an object with keys "tag" and
928+-- | "contents", where "tag" i-- |s associated to one of ["Foo", "Bar"],
929+-- | The parser returned error was: could not find key "tag"
930+contextTag :: Text -> [String] -> Parser a -> Parser a
931+contextTag tagKey cnames = prependFailure
932+ ("expected Object with key \"" ++ unpack tagKey ++ "\"" ++
933+ " containing one of " ++ show cnames ++ ", ")
934+
935+-- | Add the name of the constructor being parsed to a parser's error messages.
936+contextCons :: ConName -> TypeName -> Parser a -> Parser a
937+contextCons cname tname = prependContext (showCons cname tname)
938+
939+-- | Render a constructor as @\"MyType(MyConstructor)\"@.
940+showCons :: ConName -> TypeName -> String
941+showCons cname tname = tname ++ "(" ++ cname ++ ")"
942+
943+--------------------------------------------------------------------------------
944+
945+-- Parsing single fields
946+
774947instance (FromJSON a) => GFromJSON arity (K1 i a) where
775948 -- Constant values are decoded using their FromJSON instance:
776949 gParseJSON _opts _ = fmap K1 . parseJSON
@@ -785,326 +958,499 @@ instance (FromJSON1 f) => GFromJSON One (Rec1 f) where
785958 -- FromJSON1 instance:
786959 gParseJSON _opts (From1Args pj pjl) = fmap Rec1 . liftParseJSON pj pjl
787960
788−instance GFromJSON arity U1 where
789− -- Empty constructors are expected to be encoded as an empty array:
790− gParseJSON _opts _ v
791− | isEmptyArray v = pure U1
792− | otherwise = typeMismatch "unit constructor (U1)" v
793−
794−instance (ConsFromJSON arity a) => GFromJSON arity (C1 c a) where
795− -- Constructors need to be decoded differently depending on whether they're
796− -- a record or not. This distinction is made by consParseJSON:
797− gParseJSON opts fargs = fmap M1 . consParseJSON opts fargs
798−
799−instance ( FromProduct arity a, FromProduct arity b
800− , ProductSize a, ProductSize b
801− ) => GFromJSON arity (a :*: b) where
802− -- Products are expected to be encoded to an array. Here we check whether we
803− -- got an array of the same size as the product, then parse each of the
804− -- product's elements using parseProduct:
805− gParseJSON opts fargs = withArray "product (:*:)" $ \arr ->
806− let lenArray = V.length arr
807− lenProduct = (unTagged2 :: Tagged2 (a :*: b) Int -> Int)
808− productSize in
809− if lenArray == lenProduct
810− then parseProduct opts fargs arr 0 lenProduct
811− else fail $ "When expecting a product of " ++ show lenProduct ++
812− " values, encountered an Array of " ++ show lenArray ++
813− " elements instead"
814−
815−instance ( AllNullary (a :+: b) allNullary
816− , ParseSum arity (a :+: b) allNullary
817− ) => GFromJSON arity (a :+: b) where
818− -- If all constructors of a sum datatype are nullary and the
819− -- 'allNullaryToStringTag' option is set they are expected to be
820− -- encoded as strings. This distinction is made by 'parseSum':
821− gParseJSON opts fargs =
822− (unTagged :: Tagged allNullary (Parser ((a :+: b) d)) ->
823− Parser ((a :+: b) d))
824− . parseSum opts fargs
825−
826961instance (FromJSON1 f, GFromJSON One g) => GFromJSON One (f :.: g) where
827962 -- If an occurrence of the last type parameter is nested inside two
828963 -- composed types, it is decoded by using the outermost type's FromJSON1
829964 -- instance to generically decode the innermost type:
830965 gParseJSON opts fargs =
831− let gpj = gParseJSON opts fargs in
832− fmap Comp1 . liftParseJSON gpj (listParser gpj)
966+ let gpj = gParseJSON opts fargs in
967+ fmap Comp1 . liftParseJSON gpj (listParser gpj)
968+
969+--------------------------------------------------------------------------------
970+
971+instance (GFromJSON' arity a, Datatype d) => GFromJSON arity (D1 d a) where
972+ -- Meta-information, which is not handled elsewhere, is just added to the
973+ -- parsed value:
974+ gParseJSON opts fargs = fmap M1 . gParseJSON' (tname :* opts :* fargs)
975+ where
976+ tname = moduleName proxy ++ "." ++ datatypeName proxy
977+ proxy = undefined :: M1 _i d _f _p
978+
979+-- | 'GFromJSON', after unwrapping the 'D1' constructor, now carrying the data
980+-- type's name.
981+class GFromJSON' arity f where
982+ gParseJSON' :: TypeName :* Options :* FromArgs arity a
983+ -> Value
984+ -> Parser (f a)
985+
986+-- | Single constructor.
987+instance ( ConsFromJSON arity a
988+ , AllNullary (C1 c a) allNullary
989+ , ParseSum arity (C1 c a) allNullary
990+ , Constructor c
991+ ) => GFromJSON' arity (C1 c a) where
992+ -- The option 'tagSingleConstructors' determines whether to wrap
993+ -- a single-constructor type.
994+ gParseJSON' p@(_ :* opts :* _)
995+ | tagSingleConstructors opts
996+ = (unTagged :: Tagged allNullary (Parser (C1 c a p)) -> Parser (C1 c a p))
997+ . parseSum p
998+ | otherwise = fmap M1 . consParseJSON (cname :* p)
999+ where
1000+ cname = conName (undefined :: M1 _i c _f _p)
1001+
1002+-- | Multiple constructors.
1003+instance ( AllNullary (a :+: b) allNullary
1004+ , ParseSum arity (a :+: b) allNullary
1005+ ) => GFromJSON' arity (a :+: b) where
1006+ -- If all constructors of a sum datatype are nullary and the
1007+ -- 'allNullaryToStringTag' option is set they are expected to be
1008+ -- encoded as strings. This distinction is made by 'parseSum':
1009+ gParseJSON' p =
1010+ (unTagged :: Tagged allNullary (Parser ((a :+: b) _d)) ->
1011+ Parser ((a :+: b) _d))
1012+ . parseSum p
8331013
8341014--------------------------------------------------------------------------------
8351015
8361016class ParseSum arity f allNullary where
837− parseSum :: Options -> FromArgs arity a
838− -> Value -> Tagged allNullary (Parser (f a))
839−
840−instance ( SumFromString (a :+: b)
841− , FromPair arity (a :+: b)
842− , FromTaggedObject arity (a :+: b)
843− , FromUntaggedValue arity (a :+: b)
844− ) => ParseSum arity (a :+: b) True where
845− parseSum opts fargs
846− | allNullaryToStringTag opts = Tagged . parseAllNullarySum opts
847− | otherwise = Tagged . parseNonAllNullarySum opts fargs
848−
849−instance ( FromPair arity (a :+: b)
850− , FromTaggedObject arity (a :+: b)
851− , FromUntaggedValue arity (a :+: b)
852− ) => ParseSum arity (a :+: b) False where
853− parseSum opts fargs = Tagged . parseNonAllNullarySum opts fargs
1017+ parseSum :: TypeName :* Options :* FromArgs arity a
1018+ -> Value
1019+ -> Tagged allNullary (Parser (f a))
1020+
1021+instance ( ConstructorNames f
1022+ , SumFromString f
1023+ , FromPair arity f
1024+ , FromTaggedObject arity f
1025+ , FromUntaggedValue arity f
1026+ ) => ParseSum arity f True where
1027+ parseSum p@(tname :* opts :* _)
1028+ | allNullaryToStringTag opts = Tagged . parseAllNullarySum tname opts
1029+ | otherwise = Tagged . parseNonAllNullarySum p
1030+
1031+instance ( ConstructorNames f
1032+ , FromPair arity f
1033+ , FromTaggedObject arity f
1034+ , FromUntaggedValue arity f
1035+ ) => ParseSum arity f False where
1036+ parseSum p = Tagged . parseNonAllNullarySum p
8541037
8551038--------------------------------------------------------------------------------
8561039
857−parseAllNullarySum :: SumFromString f => Options -> Value -> Parser (f a)
858−parseAllNullarySum opts = withText "Text" $ \key ->
859− maybe (notFound key) return $
860− parseSumFromString opts key
1040+parseAllNullarySum :: (SumFromString f, ConstructorNames f)
1041+ => TypeName -> Options -> Value -> Parser (f a)
1042+parseAllNullarySum tname opts =
1043+ withText tname $ \tag ->
1044+ maybe (badTag tag) return $
1045+ parseSumFromString modifier tag
1046+ where
1047+ badTag tag = failWithCTags tname modifier $ \cnames ->
1048+ "expected one of the tags " ++ show cnames ++
1049+ ", but found tag " ++ show tag
1050+ modifier = constructorTagModifier opts
1051+
1052+-- | Fail with an informative error message about a mismatched tag.
1053+-- The error message is parameterized by the list of expected tags,
1054+-- to be inferred from the result type of the parser.
1055+failWithCTags
1056+ :: forall f a t. ConstructorNames f
1057+ => TypeName -> (String -> t) -> ([t] -> String) -> Parser (f a)
1058+failWithCTags tname modifier f =
1059+ contextType tname . fail $ f cnames
1060+ where
1061+ cnames = unTagged2 (constructorTags modifier :: Tagged2 f [t])
8611062
8621063class SumFromString f where
863− parseSumFromString :: Options -> Text -> Maybe (f a)
1064+ parseSumFromString :: (String -> String) -> Text -> Maybe (f a)
8641065
8651066instance (SumFromString a, SumFromString b) => SumFromString (a :+: b) where
8661067 parseSumFromString opts key = (L1 <$> parseSumFromString opts key) <|>
8671068 (R1 <$> parseSumFromString opts key)
8681069
8691070instance (Constructor c) => SumFromString (C1 c U1) where
870− parseSumFromString opts key | key == name = Just $ M1 U1
871− | otherwise = Nothing
872− where
873− name = pack $ constructorTagModifier opts $
874− conName (undefined :: t c U1 p)
1071+ parseSumFromString modifier key
1072+ | key == name = Just $ M1 U1
1073+ | otherwise = Nothing
1074+ where
1075+ name = pack $ modifier $ conName (undefined :: M1 _i c _f _p)
8751076
876−--------------------------------------------------------------------------------
1077+-- For genericFromJSONKey
1078+instance SumFromString a => SumFromString (D1 d a) where
1079+ parseSumFromString modifier key = M1 <$> parseSumFromString modifier key
1080+
1081+-- | List of all constructor tags.
1082+constructorTags :: ConstructorNames a => (String -> t) -> Tagged2 a [t]
1083+constructorTags modifier =
1084+ fmap DList.toList (constructorNames' modifier)
1085+
1086+-- | List of all constructor names of an ADT, after a given conversion
1087+-- function. (Better inlining.)
1088+class ConstructorNames a where
1089+ constructorNames' :: (String -> t) -> Tagged2 a (DList.DList t)
1090+
1091+instance (ConstructorNames a, ConstructorNames b) => ConstructorNames (a :+: b) where
1092+ constructorNames' = liftA2 append constructorNames' constructorNames'
1093+ where
1094+ append
1095+ :: Tagged2 a (DList.DList t)
1096+ -> Tagged2 b (DList.DList t)
1097+ -> Tagged2 (a :+: b) (DList.DList t)
1098+ append (Tagged2 xs) (Tagged2 ys) = Tagged2 (DList.append xs ys)
1099+
1100+instance Constructor c => ConstructorNames (C1 c a) where
1101+ constructorNames' f = Tagged2 (pure (f cname))
1102+ where
1103+ cname = conName (undefined :: M1 _i c _f _p)
8771104
878−parseNonAllNullarySum :: ( FromPair arity (a :+: b)
879− , FromTaggedObject arity (a :+: b)
880− , FromUntaggedValue arity (a :+: b)
881− ) => Options -> FromArgs arity c
882− -> Value -> Parser ((a :+: b) c)
883−parseNonAllNullarySum opts fargs =
1105+-- For genericFromJSONKey
1106+instance ConstructorNames a => ConstructorNames (D1 d a) where
1107+ constructorNames' = retag . constructorNames'
1108+ where
1109+ retag :: Tagged2 a u -> Tagged2 (D1 d a) u
1110+ retag (Tagged2 x) = Tagged2 x
1111+
1112+--------------------------------------------------------------------------------
1113+parseNonAllNullarySum :: forall f c arity.
1114+ ( FromPair arity f
1115+ , FromTaggedObject arity f
1116+ , FromUntaggedValue arity f
1117+ , ConstructorNames f
1118+ ) => TypeName :* Options :* FromArgs arity c
1119+ -> Value -> Parser (f c)
1120+parseNonAllNullarySum p@(tname :* opts :* _) =
8841121 case sumEncoding opts of
8851122 TaggedObject{..} ->
886− withObject "Object" $ \obj -> do
887− tag <- obj .: pack tagFieldName
888− fromMaybe (notFound tag) $
889− parseFromTaggedObject opts fargs contentsFieldName obj tag
1123+ withObject tname $ \obj -> do
1124+ tag <- contextType tname . contextTag tagKey cnames_ $ obj .: tagKey
1125+ fromMaybe (badTag tag <?> Key tagKey) $
1126+ parseFromTaggedObject (tag :* contentsFieldName :* p) obj
1127+ where
1128+ tagKey = pack tagFieldName
1129+ badTag tag = failWith_ $ \cnames ->
1130+ "expected tag field to be one of " ++ show cnames ++
1131+ ", but found tag " ++ show tag
1132+ cnames_ = unTagged2 (constructorTags (constructorTagModifier opts) :: Tagged2 f [String])
8901133
8911134 ObjectWithSingleField ->
892− withObject "Object" $ \obj ->
893− case H.toList obj of
894− [pair@(tag, _)] -> fromMaybe (notFound tag) $
895− parsePair opts fargs pair
896− _ -> fail "Object doesn't have a single field"
1135+ withObject tname $ \obj -> case H.toList obj of
1136+ [(tag, v)] -> maybe (badTag tag) (<?> Key tag) $
1137+ parsePair (tag :* p) v
1138+ _ -> contextType tname . fail $
1139+ "expected an Object with a single pair, but found " ++
1140+ show (H.size obj) ++ " pairs"
1141+ where
1142+ badTag tag = failWith_ $ \cnames ->
1143+ "expected an Object with a single pair where the tag is one of " ++
1144+ show cnames ++ ", but found tag " ++ show tag
8971145
8981146 TwoElemArray ->
899− withArray "Array" $ \arr ->
900− if V.length arr == 2
901− then case V.unsafeIndex arr 0 of
902− String tag -> fromMaybe (notFound tag) $
903− parsePair opts fargs (tag, V.unsafeIndex arr 1)
904− _ -> fail "First element is not a String"
905− else fail "Array doesn't have 2 elements"
1147+ withArray tname $ \arr -> case V.length arr of
1148+ 2 | String tag <- V.unsafeIndex arr 0 ->
1149+ maybe (badTag tag <?> Index 0) (<?> Index 1) $
1150+ parsePair (tag :* p) (V.unsafeIndex arr 1)
1151+ | otherwise ->
1152+ contextType tname $
1153+ fail "tag element is not a String" <?> Index 0
1154+ len -> contextType tname . fail $
1155+ "expected a 2-element Array, but encountered an Array of length " ++
1156+ show len
1157+ where
1158+ badTag tag = failWith_ $ \cnames ->
1159+ "expected tag of the 2-element Array to be one of " ++
1160+ show cnames ++ ", but found tag " ++ show tag
9061161
907− UntaggedValue -> parseUntaggedValue opts fargs
1162+ UntaggedValue -> parseUntaggedValue p
1163+ where
1164+ failWith_ = failWithCTags tname (constructorTagModifier opts)
9081165
9091166--------------------------------------------------------------------------------
9101167
9111168class FromTaggedObject arity f where
912− parseFromTaggedObject :: Options -> FromArgs arity a
913− -> String -> Object
914− -> Text -> Maybe (Parser (f a))
1169+ -- The first two components of the parameter tuple are: the constructor tag
1170+ -- to match against, and the contents field name.
1171+ parseFromTaggedObject
1172+ :: Text :* String :* TypeName :* Options :* FromArgs arity a
1173+ -> Object
1174+ -> Maybe (Parser (f a))
9151175
9161176instance ( FromTaggedObject arity a, FromTaggedObject arity b) =>
9171177 FromTaggedObject arity (a :+: b) where
918− parseFromTaggedObject opts fargs contentsFieldName obj tag =
919− (fmap L1 <$> parseFromTaggedObject opts fargs contentsFieldName obj tag) <|>
920− (fmap R1 <$> parseFromTaggedObject opts fargs contentsFieldName obj tag)
1178+ parseFromTaggedObject p obj =
1179+ (fmap L1 <$> parseFromTaggedObject p obj) <|>
1180+ (fmap R1 <$> parseFromTaggedObject p obj)
9211181
922−instance ( FromTaggedObject' arity f
1182+instance ( IsRecord f isRecord
1183+ , FromTaggedObject' arity f isRecord
9231184 , Constructor c
9241185 ) => FromTaggedObject arity (C1 c f) where
925− parseFromTaggedObject opts fargs contentsFieldName obj tag
926− | tag == name = Just $ M1 <$> parseFromTaggedObject'
927− opts fargs contentsFieldName obj
928− | otherwise = Nothing
929− where
930− name = pack $ constructorTagModifier opts $
931− conName (undefined :: t c f p)
1186+ parseFromTaggedObject (tag :* contentsFieldName :* p@(_ :* opts :* _))
1187+ | tag == tag'
1188+ = Just . fmap M1 .
1189+ (unTagged :: Tagged isRecord (Parser (f a)) -> Parser (f a)) .
1190+ parseFromTaggedObject' (contentsFieldName :* cname :* p)
1191+ | otherwise = const Nothing
1192+ where
1193+ tag' = pack $ constructorTagModifier opts cname
1194+ cname = conName (undefined :: M1 _i c _f _p)
9321195
9331196--------------------------------------------------------------------------------
9341197
935−class FromTaggedObject' arity f where
936− parseFromTaggedObject' :: Options -> FromArgs arity a -> String
937− -> Object -> Parser (f a)
938−
939−class FromTaggedObject'' arity f isRecord where
940− parseFromTaggedObject'' :: Options -> FromArgs arity a -> String
941− -> Object -> Tagged isRecord (Parser (f a))
942−
943−instance ( IsRecord f isRecord
944− , FromTaggedObject'' arity f isRecord
945− ) => FromTaggedObject' arity f where
946− parseFromTaggedObject' opts fargs contentsFieldName =
947− (unTagged :: Tagged isRecord (Parser (f a)) -> Parser (f a)) .
948− parseFromTaggedObject'' opts fargs contentsFieldName
949−
950−instance (FromRecord arity f) => FromTaggedObject'' arity f True where
951− parseFromTaggedObject'' opts fargs _ =
952− Tagged . parseRecord opts fargs Nothing
953−
954−instance (GFromJSON arity f) => FromTaggedObject'' arity f False where
955− parseFromTaggedObject'' opts fargs contentsFieldName = Tagged .
956− (gParseJSON opts fargs <=< (.: pack contentsFieldName))
1198+class FromTaggedObject' arity f isRecord where
1199+ -- The first component of the parameter tuple is the contents field name.
1200+ parseFromTaggedObject'
1201+ :: String :* ConName :* TypeName :* Options :* FromArgs arity a
1202+ -> Object -> Tagged isRecord (Parser (f a))
1203+
1204+instance (RecordFromJSON arity f, FieldNames f) => FromTaggedObject' arity f True where
1205+ -- Records are unpacked in the tagged object
1206+ parseFromTaggedObject' (_ :* p) = Tagged . recordParseJSON (True :* p)
1207+
1208+instance (ConsFromJSON arity f) => FromTaggedObject' arity f False where
1209+ -- Nonnullary nonrecords are encoded in the contents field
1210+ parseFromTaggedObject' p obj = Tagged $ do
1211+ contents <- contextCons cname tname (obj .: key)
1212+ consParseJSON p' contents <?> Key key
1213+ where
1214+ key = pack contentsFieldName
1215+ contentsFieldName :* p'@(cname :* tname :* _) = p
9571216
958−instance OVERLAPPING_ FromTaggedObject'' arity U1 False where
959− parseFromTaggedObject'' _ _ _ _ = Tagged (pure U1)
1217+instance OVERLAPPING_ FromTaggedObject' arity U1 False where
1218+ -- Nullary constructors don't need a contents field
1219+ parseFromTaggedObject' _ _ = Tagged (pure U1)
9601220
9611221--------------------------------------------------------------------------------
9621222
1223+-- | Constructors need to be decoded differently depending on whether they're
1224+-- a record or not. This distinction is made by 'ConsParseJSON'.
9631225class ConsFromJSON arity f where
964− consParseJSON :: Options -> FromArgs arity a
965− -> Value -> Parser (f a)
1226+ consParseJSON
1227+ :: ConName :* TypeName :* Options :* FromArgs arity a
1228+ -> Value -> Parser (f a)
9661229
9671230class ConsFromJSON' arity f isRecord where
968− consParseJSON' :: Options -> FromArgs arity a
969− -> Maybe Text -- ^ A dummy label
970− -- (Nothing to use proper label)
971− -> Value -> Tagged isRecord (Parser (f a))
1231+ consParseJSON'
1232+ :: ConName :* TypeName :* Options :* FromArgs arity a
1233+ -> Value -> Tagged isRecord (Parser (f a))
9721234
9731235instance ( IsRecord f isRecord
9741236 , ConsFromJSON' arity f isRecord
9751237 ) => ConsFromJSON arity f where
976− consParseJSON opts fargs v = let
977− (v2,lab) = case (unwrapUnaryRecords opts,isUnary (undefined :: f a)) of
978− -- use a dummy object with a dummy label
979− (True,True) -> (object [(pack "dummy",v)], Just $ pack "dummy")
980− _ ->(v,Nothing)
981− in (unTagged :: Tagged isRecord (Parser (f a)) -> Parser (f a))
982− $ consParseJSON' opts fargs lab v2
1238+ consParseJSON p =
1239+ (unTagged :: Tagged isRecord (Parser (f a)) -> Parser (f a))
1240+ . consParseJSON' p
9831241
1242+instance OVERLAPPING_
1243+ ( GFromJSON arity a, RecordFromJSON arity (S1 s a)
1244+ ) => ConsFromJSON' arity (S1 s a) True where
1245+ consParseJSON' p@(cname :* tname :* opts :* fargs)
1246+ | unwrapUnaryRecords opts = Tagged . fmap M1 . gParseJSON opts fargs
1247+ | otherwise = Tagged . withObject (showCons cname tname) (recordParseJSON (False :* p))
9841248
985−instance (FromRecord arity f) => ConsFromJSON' arity f True where
986− consParseJSON' opts fargs mlab = Tagged . withObject "record (:*:)"
987− (parseRecord opts fargs mlab)
1249+instance RecordFromJSON arity f => ConsFromJSON' arity f True where
1250+ consParseJSON' p@(cname :* tname :* _) =
1251+ Tagged . withObject (showCons cname tname) (recordParseJSON (False :* p))
9881252
989−instance (GFromJSON arity f) => ConsFromJSON' arity f False where
990− consParseJSON' opts fargs _ = Tagged . gParseJSON opts fargs
1253+instance OVERLAPPING_
1254+ ConsFromJSON' arity U1 False where
1255+ -- Empty constructors are expected to be encoded as an empty array:
1256+ consParseJSON' (cname :* tname :* _) v =
1257+ Tagged . contextCons cname tname $ case v of
1258+ Array a | V.null a -> pure U1
1259+ | otherwise -> fail_ a
1260+ _ -> typeMismatch "Array" v
1261+ where
1262+ fail_ a = fail $
1263+ "expected an empty Array, but encountered an Array of length " ++
1264+ show (V.length a)
1265+
1266+instance OVERLAPPING_
1267+ GFromJSON arity f => ConsFromJSON' arity (S1 s f) False where
1268+ consParseJSON' (_ :* _ :* opts :* fargs) =
1269+ Tagged . fmap M1 . gParseJSON opts fargs
1270+
1271+instance (ProductFromJSON arity f, ProductSize f
1272+ ) => ConsFromJSON' arity f False where
1273+ consParseJSON' p = Tagged . productParseJSON0 p
9911274
9921275--------------------------------------------------------------------------------
9931276
994−class FromRecord arity f where
995− parseRecord :: Options -> FromArgs arity a
996− -> Maybe Text -- ^ A dummy label
997− -- (Nothing to use proper label)
998− -> Object -> Parser (f a)
1277+class FieldNames f where
1278+ fieldNames :: f a -> [Text] -> [Text]
9991279
1000−instance ( FromRecord arity a
1001− , FromRecord arity b
1002− ) => FromRecord arity (a :*: b) where
1003− parseRecord opts fargs _ obj =
1004− (:*:) <$> parseRecord opts fargs Nothing obj
1005− <*> parseRecord opts fargs Nothing obj
1280+instance (FieldNames a, FieldNames b) => FieldNames (a :*: b) where
1281+ fieldNames _ =
1282+ fieldNames (undefined :: a x) .
1283+ fieldNames (undefined :: b y)
10061284
1007−instance OVERLAPPABLE_ (Selector s, GFromJSON arity a) =>
1008− FromRecord arity (S1 s a) where
1009− parseRecord opts fargs lab =
1010− (<?> Key label) . gParseJSON opts fargs <=< (.: label)
1285+instance (Selector s) => FieldNames (S1 s f) where
1286+ fieldNames _ = (pack (selName (undefined :: M1 _i s _f _p)) :)
1287+
1288+class RecordFromJSON arity f where
1289+ recordParseJSON
1290+ :: Bool :* ConName :* TypeName :* Options :* FromArgs arity a
1291+ -> Object -> Parser (f a)
1292+
1293+instance ( FieldNames f
1294+ , RecordFromJSON' arity f
1295+ ) => RecordFromJSON arity f where
1296+ recordParseJSON (fromTaggedSum :* p@(cname :* tname :* opts :* _)) =
1297+ \obj -> checkUnknown obj >> recordParseJSON' p obj
10111298 where
1012− label = fromMaybe defLabel lab
1013− defLabel = pack . fieldLabelModifier opts $
1014− selName (undefined :: t s a p)
1299+ knownFields :: H.HashMap Text ()
1300+ knownFields = H.fromList $ map (,()) $
1301+ fieldNames (undefined :: f a)
1302+ [pack (tagFieldName (sumEncoding opts)) | fromTaggedSum]
1303+ checkUnknown =
1304+ if not (rejectUnknownFields opts)
1305+ then \_ -> return ()
1306+ else \obj -> case H.keys (H.difference obj knownFields) of
1307+ [] -> return ()
1308+ unknownFields -> contextCons cname tname $
1309+ fail ("unknown fields: " ++ show unknownFields)
1310+
1311+class RecordFromJSON' arity f where
1312+ recordParseJSON'
1313+ :: ConName :* TypeName :* Options :* FromArgs arity a
1314+ -> Object -> Parser (f a)
1315+
1316+instance ( RecordFromJSON' arity a
1317+ , RecordFromJSON' arity b
1318+ ) => RecordFromJSON' arity (a :*: b) where
1319+ recordParseJSON' p obj =
1320+ (:*:) <$> recordParseJSON' p obj
1321+ <*> recordParseJSON' p obj
1322+
1323+instance OVERLAPPABLE_ (Selector s, GFromJSON arity a) =>
1324+ RecordFromJSON' arity (S1 s a) where
1325+ recordParseJSON' (cname :* tname :* opts :* fargs) obj = do
1326+ fv <- contextCons cname tname (obj .: label)
1327+ M1 <$> gParseJSON opts fargs fv <?> Key label
1328+ where
1329+ label = pack $ fieldLabelModifier opts sname
1330+ sname = selName (undefined :: M1 _i s _f _p)
10151331
10161332instance INCOHERENT_ (Selector s, FromJSON a) =>
1017− FromRecord arity (S1 s (K1 i (Maybe a))) where
1018− parseRecord _ _ (Just lab) obj = (M1 . K1) <$> obj .:? lab
1019− parseRecord opts _ Nothing obj = (M1 . K1) <$> obj .:? pack label
1020− where
1021− label = fieldLabelModifier opts $
1022− selName (undefined :: t s (K1 i (Maybe a)) p)
1333+ RecordFromJSON' arity (S1 s (K1 i (Maybe a))) where
1334+ recordParseJSON' (_ :* _ :* opts :* _) obj = M1 . K1 <$> obj .:? pack label
1335+ where
1336+ label = fieldLabelModifier opts sname
1337+ sname = selName (undefined :: M1 _i s _f _p)
1338+
1339+-- Parse an Option like a Maybe.
1340+instance INCOHERENT_ (Selector s, FromJSON a) =>
1341+ RecordFromJSON' arity (S1 s (K1 i (Semigroup.Option a))) where
1342+ recordParseJSON' p obj = wrap <$> recordParseJSON' p obj
1343+ where
1344+ wrap :: S1 s (K1 i (Maybe a)) p -> S1 s (K1 i (Semigroup.Option a)) p
1345+ wrap (M1 (K1 a)) = M1 (K1 (Semigroup.Option a))
10231346
10241347--------------------------------------------------------------------------------
10251348
1026−class FromProduct arity f where
1027− parseProduct :: Options -> FromArgs arity a
1349+productParseJSON0
1350+ :: forall f arity a. (ProductFromJSON arity f, ProductSize f)
1351+ => ConName :* TypeName :* Options :* FromArgs arity a
1352+ -> Value -> Parser (f a)
1353+ -- Products are expected to be encoded to an array. Here we check whether we
1354+ -- got an array of the same size as the product, then parse each of the
1355+ -- product's elements using productParseJSON:
1356+productParseJSON0 p@(cname :* tname :* _ :* _) =
1357+ withArray (showCons cname tname) $ \arr ->
1358+ let lenArray = V.length arr
1359+ lenProduct = (unTagged2 :: Tagged2 f Int -> Int)
1360+ productSize in
1361+ if lenArray == lenProduct
1362+ then productParseJSON p arr 0 lenProduct
1363+ else contextCons cname tname $
1364+ fail $ "expected an Array of length " ++ show lenProduct ++
1365+ ", but encountered an Array of length " ++ show lenArray
1366+
1367+--
1368+
1369+class ProductFromJSON arity f where
1370+ productParseJSON :: ConName :* TypeName :* Options :* FromArgs arity a
10281371 -> Array -> Int -> Int
10291372 -> Parser (f a)
10301373
1031−instance ( FromProduct arity a
1032− , FromProduct arity b
1033− ) => FromProduct arity (a :*: b) where
1034− parseProduct opts fargs arr ix len =
1035− (:*:) <$> parseProduct opts fargs arr ix lenL
1036− <*> parseProduct opts fargs arr ixR lenR
1374+instance ( ProductFromJSON arity a
1375+ , ProductFromJSON arity b
1376+ ) => ProductFromJSON arity (a :*: b) where
1377+ productParseJSON p arr ix len =
1378+ (:*:) <$> productParseJSON p arr ix lenL
1379+ <*> productParseJSON p arr ixR lenR
10371380 where
10381381 lenL = len `unsafeShiftR` 1
10391382 ixR = ix + lenL
10401383 lenR = len - lenL
10411384
1042−instance (GFromJSON arity a) => FromProduct arity (S1 s a) where
1043− parseProduct opts fargs arr ix _ =
1044− gParseJSON opts fargs $ V.unsafeIndex arr ix
1385+instance (GFromJSON arity a) => ProductFromJSON arity (S1 s a) where
1386+ productParseJSON (_ :* _ :* opts :* fargs) arr ix _ =
1387+ M1 <$> gParseJSON opts fargs (V.unsafeIndex arr ix) <?> Index ix
10451388
10461389--------------------------------------------------------------------------------
10471390
10481391class FromPair arity f where
1049− parsePair :: Options -> FromArgs arity a
1050− -> Pair -> Maybe (Parser (f a))
1392+ -- The first component of the parameter tuple is the tag to match.
1393+ parsePair :: Text :* TypeName :* Options :* FromArgs arity a
1394+ -> Value
1395+ -> Maybe (Parser (f a))
10511396
10521397instance ( FromPair arity a
10531398 , FromPair arity b
10541399 ) => FromPair arity (a :+: b) where
1055− parsePair opts fargs pair = (fmap L1 <$> parsePair opts fargs pair) <|>
1056− (fmap R1 <$> parsePair opts fargs pair)
1400+ parsePair p pair =
1401+ (fmap L1 <$> parsePair p pair) <|>
1402+ (fmap R1 <$> parsePair p pair)
10571403
10581404instance ( Constructor c
1059− , GFromJSON arity a
10601405 , ConsFromJSON arity a
10611406 ) => FromPair arity (C1 c a) where
1062− parsePair opts fargs (tag, value)
1063− | tag == tag' = Just $ gParseJSON opts fargs value
1407+ parsePair (tag :* p@(_ :* opts :* _)) v
1408+ | tag == tag' = Just $ M1 <$> consParseJSON (cname :* p) v
10641409 | otherwise = Nothing
1065− where
1066− tag' = pack $ constructorTagModifier opts $
1067− conName (undefined :: t c a p)
1410+ where
1411+ tag' = pack $ constructorTagModifier opts cname
1412+ cname = conName (undefined :: M1 _i c _a _p)
10681413
10691414--------------------------------------------------------------------------------
10701415
10711416class FromUntaggedValue arity f where
1072− parseUntaggedValue :: Options -> FromArgs arity a
1073− -> Value -> Parser (f a)
1417+ parseUntaggedValue :: TypeName :* Options :* FromArgs arity a
1418+ -> Value
1419+ -> Parser (f a)
10741420
10751421instance
10761422 ( FromUntaggedValue arity a
10771423 , FromUntaggedValue arity b
10781424 ) => FromUntaggedValue arity (a :+: b)
10791425 where
1080− parseUntaggedValue opts fargs value =
1081− L1 <$> parseUntaggedValue opts fargs value <|>
1082− R1 <$> parseUntaggedValue opts fargs value
1426+ parseUntaggedValue p value =
1427+ L1 <$> parseUntaggedValue p value <|>
1428+ R1 <$> parseUntaggedValue p value
10831429
10841430instance OVERLAPPABLE_
1085− ( GFromJSON arity a
1086− , ConsFromJSON arity a
1431+ ( ConsFromJSON arity a
1432+ , Constructor c
10871433 ) => FromUntaggedValue arity (C1 c a)
10881434 where
1089− parseUntaggedValue = gParseJSON
1435+ parseUntaggedValue p = fmap M1 . consParseJSON (cname :* p)
1436+ where
1437+ cname = conName (undefined :: M1 _i c _f _p)
10901438
10911439instance OVERLAPPING_
10921440 ( Constructor c )
10931441 => FromUntaggedValue arity (C1 c U1)
10941442 where
1095− parseUntaggedValue opts _ (String s)
1096− | s == pack (constructorTagModifier opts (conName (undefined :: t c U1 p))) =
1097− pure $ M1 U1
1098− | otherwise =
1099− fail $ "Invalid tag: " ++ unpack s
1100− parseUntaggedValue _ _ v = typeMismatch (conName (undefined :: t c U1 p)) v
1101−
1102−
1103−--------------------------------------------------------------------------------
1104−
1105−notFound :: Text -> Parser a
1106−notFound key = fail $ "The key \"" ++ unpack key ++ "\" was not found"
1107−{-# INLINE notFound #-}
1443+ parseUntaggedValue (tname :* opts :* _) v =
1444+ contextCons cname tname $ case v of
1445+ String tag
1446+ | tag == tag' -> pure $ M1 U1
1447+ | otherwise -> fail_ tag
1448+ _ -> typeMismatch "String" v
1449+ where
1450+ tag' = pack $ constructorTagModifier opts cname
1451+ cname = conName (undefined :: M1 _i c _f _p)
1452+ fail_ tag = fail $
1453+ "expected tag " ++ show tag' ++ ", but found tag " ++ show tag
11081454
11091455-------------------------------------------------------------------------------
11101456-- Instances
@@ -1162,17 +1508,20 @@ instance (FromJSON a, FromJSON b) => FromJSON (Either a b) where
11621508 parseJSON = parseJSON2
11631509 {-# INLINE parseJSON #-}
11641510
1165−
1511+instance FromJSON Void where
1512+ parseJSON _ = fail "Cannot parse Void"
1513+ {-# INLINE parseJSON #-}
11661514
11671515instance FromJSON Bool where
1168− parseJSON = withBool "Bool" pure
1516+ parseJSON (Bool b) = pure b
1517+ parseJSON v = typeMismatch "Bool" v
11691518 {-# INLINE parseJSON #-}
11701519
11711520instance FromJSONKey Bool where
11721521 fromJSONKey = FromJSONKeyTextParser $ \t -> case t of
11731522 "true" -> pure True
11741523 "false" -> pure False
1175− _ -> fail $ "Cannot parse key into Bool: " ++ T.unpack t
1524+ _ -> fail $ "cannot parse key " ++ show t ++ " into Bool"
11761525
11771526instance FromJSON Ordering where
11781527 parseJSON = withText "Ordering" $ \s ->
@@ -1180,25 +1529,30 @@ instance FromJSON Ordering where
11801529 "LT" -> return LT
11811530 "EQ" -> return EQ
11821531 "GT" -> return GT
1183− _ -> fail "Parsing Ordering value failed: expected \"LT\", \"EQ\", or \"GT\""
1532+ _ -> fail $ "parsing Ordering failed, unexpected " ++ show s ++
1533+ " (expected \"LT\", \"EQ\", or \"GT\")"
11841534
11851535instance FromJSON () where
11861536 parseJSON = withArray "()" $ \v ->
11871537 if V.null v
11881538 then pure ()
1189− else fail "Expected an empty array"
1539+ else prependContext "()" $ fail "expected an empty array"
11901540 {-# INLINE parseJSON #-}
11911541
11921542instance FromJSON Char where
1193− parseJSON = withText "Char" $ \t ->
1194− if T.compareLength t 1 == EQ
1195− then pure $ T.head t
1196− else fail "Expected a string of length 1"
1543+ parseJSON = withText "Char" parseChar
11971544 {-# INLINE parseJSON #-}
11981545
1199− parseJSONList = withText "String" $ pure . T.unpack
1546+ parseJSONList (String s) = pure (T.unpack s)
1547+ parseJSONList v = typeMismatch "String" v
12001548 {-# INLINE parseJSONList #-}
12011549
1550+parseChar :: Text -> Parser Char
1551+parseChar t =
1552+ if T.compareLength t 1 == EQ
1553+ then pure $ T.head t
1554+ else prependContext "Char" $ fail "expected a string of length 1"
1555+
12021556instance FromJSON Double where
12031557 parseJSON = parseRealFloat "Double"
12041558 {-# INLINE parseJSON #-}
@@ -1210,12 +1564,6 @@ instance FromJSONKey Double where
12101564 "-Infinity" -> pure (negate 1/0)
12111565 _ -> Scientific.toRealFloat <$> parseScientificText t
12121566
1213−instance FromJSON Number where
1214− parseJSON (Number s) = pure $ scientificToNumber s
1215− parseJSON Null = pure (D (0/0))
1216− parseJSON v = typeMismatch "Number" v
1217− {-# INLINE parseJSON #-}
1218−
12191567instance FromJSON Float where
12201568 parseJSON = parseRealFloat "Float"
12211569 {-# INLINE parseJSON #-}
@@ -1228,17 +1576,30 @@ instance FromJSONKey Float where
12281576 _ -> Scientific.toRealFloat <$> parseScientificText t
12291577
12301578instance (FromJSON a, Integral a) => FromJSON (Ratio a) where
1231− parseJSON = withObject "Rational" $ \obj ->
1232− (%) <$> obj .: "numerator"
1233− <*> obj .: "denominator"
1234− {-# INLINE parseJSON #-}
1235−
1236−-- | /WARNING:/ Only parse fixed-precision numbers from trusted input
1237−-- since an attacker could easily fill up the memory of the target
1238−-- system by specifying a scientific number with a big exponent like
1239−-- @1e1000000000@.
1579+ parseJSON (Number x)
1580+ | exp10 <= 1024
1581+ , exp10 >= -1024 = return $! realToFrac x
1582+ | otherwise = prependContext "Ratio" $ fail msg
1583+ where
1584+ exp10 = base10Exponent x
1585+ msg = "found a number with exponent " ++ show exp10
1586+ ++ ", but it must not be greater than 1024 or less than -1024"
1587+ parseJSON o = objParser o
1588+ where
1589+ objParser = withObject "Rational" $ \obj -> do
1590+ numerator <- obj .: "numerator"
1591+ denominator <- obj .: "denominator"
1592+ if denominator == 0
1593+ then fail "Ratio denominator was 0"
1594+ else pure $ numerator % denominator
1595+ {-# INLINE parseJSON #-}
1596+
1597+-- | This instance includes a bounds check to prevent maliciously
1598+-- large inputs to fill up the memory of the target system. You can
1599+-- newtype 'Scientific' and provide your own instance using
1600+-- 'withScientific' if you want to allow larger inputs.
12401601instance HasResolution a => FromJSON (Fixed a) where
1241− parseJSON = withScientific "Fixed" $ pure . realToFrac
1602+ parseJSON = prependContext "Fixed" . withBoundedScientific' (pure . realToFrac)
12421603 {-# INLINE parseJSON #-}
12431604
12441605instance FromJSON Int where
@@ -1248,10 +1609,10 @@ instance FromJSON Int where
12481609instance FromJSONKey Int where
12491610 fromJSONKey = FromJSONKeyTextParser $ parseBoundedIntegralText "Int"
12501611
1251−-- | /WARNING:/ Only parse Integers from trusted input since an
1252−-- attacker could easily fill up the memory of the target system by
1253−-- specifying a scientific number with a big exponent like
1254−-- @1e1000000000@.
1612+-- | This instance includes a bounds check to prevent maliciously
1613+-- large inputs to fill up the memory of the target system. You can
1614+-- newtype 'Scientific' and provide your own instance using
1615+-- 'withScientific' if you want to allow larger inputs.
12551616instance FromJSON Integer where
12561617 parseJSON = parseIntegral "Integer"
12571618 {-# INLINE parseJSON #-}
@@ -1260,16 +1621,21 @@ instance FromJSONKey Integer where
12601621 fromJSONKey = FromJSONKeyTextParser $ parseIntegralText "Integer"
12611622
12621623instance FromJSON Natural where
1263− parseJSON = withScientific "Natural" $ \s ->
1264− if Scientific.coefficient s < 0
1265− then fail $ "Expected a Natural number but got the negative number: " <> show s
1266− else pure $ truncate s
1624+ parseJSON value = do
1625+ integer <- parseIntegral "Natural" value
1626+ parseNatural integer
12671627
12681628instance FromJSONKey Natural where
1269− fromJSONKey = FromJSONKeyTextParser $ \t -> parseScientificText t >>= \s ->
1270− if Scientific.coefficient s < 0
1271− then fail $ "Expected a Natural number but got the negative number: " <> show s
1272− else pure $ truncate s
1629+ fromJSONKey = FromJSONKeyTextParser $ \text -> do
1630+ integer <- parseIntegralText "Natural" text
1631+ parseNatural integer
1632+
1633+parseNatural :: Integer -> Parser Natural
1634+parseNatural integer =
1635+ if integer < 0 then
1636+ fail $ "parsing Natural failed, unexpected negative number " <> show integer
1637+ else
1638+ pure $ fromIntegral integer
12731639
12741640instance FromJSON Int8 where
12751641 parseJSON = parseBoundedIntegral "Int8"
@@ -1334,6 +1700,9 @@ instance FromJSON Word64 where
13341700instance FromJSONKey Word64 where
13351701 fromJSONKey = FromJSONKeyTextParser $ parseBoundedIntegralText "Word64"
13361702
1703+instance FromJSON CTime where
1704+ parseJSON = fmap CTime . parseJSON
1705+ {-# INLINE parseJSON #-}
13371706
13381707instance FromJSON Text where
13391708 parseJSON = withText "Text" pure
@@ -1363,17 +1732,17 @@ parseVersionText = go . readP_to_S parseVersion . unpack
13631732 where
13641733 go [(v,[])] = return v
13651734 go (_ : xs) = go xs
1366− go _ = fail "could not parse Version"
1735+ go _ = fail "parsing Version failed"
13671736
13681737-------------------------------------------------------------------------------
13691738-- semigroups NonEmpty
13701739-------------------------------------------------------------------------------
13711740
13721741instance FromJSON1 NonEmpty where
1373− liftParseJSON p _ = withArray "NonEmpty a" $
1742+ liftParseJSON p _ = withArray "NonEmpty" $
13741743 (>>= ne) . Tr.sequence . zipWith (parseIndexedJSON p) [0..] . V.toList
13751744 where
1376− ne [] = fail "Expected a NonEmpty but got an empty list"
1745+ ne [] = fail "parsing NonEmpty failed, unexpected empty list"
13771746 ne (x:xs) = pure (x :| xs)
13781747 {-# INLINE liftParseJSON #-}
13791748
@@ -1394,7 +1763,7 @@ instance FromJSON Scientific where
13941763-------------------------------------------------------------------------------
13951764
13961765instance FromJSON1 DList.DList where
1397− liftParseJSON p _ = withArray "DList a" $
1766+ liftParseJSON p _ = withArray "DList" $
13981767 fmap DList.fromList .
13991768 Tr.sequence . zipWith (parseIndexedJSON p) [0..] . V.toList
14001769 {-# INLINE liftParseJSON #-}
@@ -1471,7 +1840,7 @@ instance (FromJSON1 f, FromJSON1 g) => FromJSON1 (Sum f g) where
14711840 inr = "InR"
14721841
14731842 liftParseJSON _ _ _ = fail $
1474− "expected an object with a single property " ++
1843+ "parsing Sum failed, expected an object with a single property " ++
14751844 "where the property key should be either " ++
14761845 "\"InL\" or \"InR\""
14771846 {-# INLINE liftParseJSON #-}
@@ -1485,7 +1854,7 @@ instance (FromJSON1 f, FromJSON1 g, FromJSON a) => FromJSON (Sum f g a) where
14851854-------------------------------------------------------------------------------
14861855
14871856instance FromJSON1 Seq.Seq where
1488− liftParseJSON p _ = withArray "Seq a" $
1857+ liftParseJSON p _ = withArray "Seq" $
14891858 fmap Seq.fromList .
14901859 Tr.sequence . zipWith (parseIndexedJSON p) [0..] . V.toList
14911860 {-# INLINE liftParseJSON #-}
@@ -1519,15 +1888,15 @@ instance FromJSON a => FromJSON (IntMap.IntMap a) where
15191888
15201889instance (FromJSONKey k, Ord k) => FromJSON1 (M.Map k) where
15211890 liftParseJSON p _ = case fromJSONKey of
1522− FromJSONKeyCoerce _-> withObject "Map k v" $
1891+ FromJSONKeyCoerce _ -> withObject "Map" $
15231892 fmap (H.foldrWithKey (M.insert . unsafeCoerce) M.empty) . H.traverseWithKey (\k v -> p v <?> Key k)
1524− FromJSONKeyText f -> withObject "Map k v" $
1893+ FromJSONKeyText f -> withObject "Map" $
15251894 fmap (H.foldrWithKey (M.insert . f) M.empty) . H.traverseWithKey (\k v -> p v <?> Key k)
1526− FromJSONKeyTextParser f -> withObject "Map k v" $
1895+ FromJSONKeyTextParser f -> withObject "Map" $
15271896 H.foldrWithKey (\k v m -> M.insert <$> f k <?> Key k <*> p v <?> Key k <*> m) (pure M.empty)
1528− FromJSONKeyValue f -> withArray "Map k v" $ \arr ->
1529− M.fromList <$> (Tr.sequence .
1530− zipWith (parseIndexedJSONPair f p) [0..] . V.toList $ arr)
1897+ FromJSONKeyValue f -> withArray "Map" $ \arr ->
1898+ fmap M.fromList . Tr.sequence .
1899+ zipWith (parseIndexedJSONPair f p) [0..] . V.toList $ arr
15311900 {-# INLINE liftParseJSON #-}
15321901
15331902instance (FromJSONKey k, Ord k, FromJSON v) => FromJSON (M.Map k v) where
@@ -1553,18 +1922,18 @@ instance (FromJSON v) => FromJSON (Tree.Tree v) where
15531922
15541923instance FromJSON UUID.UUID where
15551924 parseJSON = withText "UUID" $
1556− maybe (fail "Invalid UUID") pure . UUID.fromText
1925+ maybe (fail "invalid UUID") pure . UUID.fromText
15571926
15581927instance FromJSONKey UUID.UUID where
15591928 fromJSONKey = FromJSONKeyTextParser $
1560− maybe (fail "Invalid UUID") pure . UUID.fromText
1929+ maybe (fail "invalid UUID") pure . UUID.fromText
15611930
15621931-------------------------------------------------------------------------------
15631932-- vector
15641933-------------------------------------------------------------------------------
15651934
15661935instance FromJSON1 Vector where
1567− liftParseJSON p _ = withArray "Vector a" $
1936+ liftParseJSON p _ = withArray "Vector" $
15681937 V.mapM (uncurry $ parseIndexedJSON p) . V.indexed
15691938 {-# INLINE liftParseJSON #-}
15701939
@@ -1578,14 +1947,14 @@ vectorParseJSON s = withArray s $ fmap V.convert . V.mapM (uncurry $ parseIndexe
15781947{-# INLINE vectorParseJSON #-}
15791948
15801949instance (Storable a, FromJSON a) => FromJSON (VS.Vector a) where
1581− parseJSON = vectorParseJSON "Data.Vector.Storable.Vector a"
1950+ parseJSON = vectorParseJSON "Data.Vector.Storable.Vector"
15821951
15831952instance (VP.Prim a, FromJSON a) => FromJSON (VP.Vector a) where
1584− parseJSON = vectorParseJSON "Data.Vector.Primitive.Vector a"
1953+ parseJSON = vectorParseJSON "Data.Vector.Primitive.Vector"
15851954 {-# INLINE parseJSON #-}
15861955
15871956instance (VG.Vector VU.Vector a, FromJSON a) => FromJSON (VU.Vector a) where
1588− parseJSON = vectorParseJSON "Data.Vector.Unboxed.Vector a"
1957+ parseJSON = vectorParseJSON "Data.Vector.Unboxed.Vector"
15891958 {-# INLINE parseJSON #-}
15901959
15911960-------------------------------------------------------------------------------
@@ -1599,15 +1968,15 @@ instance (Eq a, Hashable a, FromJSON a) => FromJSON (HashSet.HashSet a) where
15991968
16001969instance (FromJSONKey k, Eq k, Hashable k) => FromJSON1 (H.HashMap k) where
16011970 liftParseJSON p _ = case fromJSONKey of
1602− FromJSONKeyCoerce _ -> withObject "HashMap ~Text v" $
1971+ FromJSONKeyCoerce _ -> withObject "HashMap ~Text" $
16031972 uc . H.traverseWithKey (\k v -> p v <?> Key k)
1604− FromJSONKeyText f -> withObject "HashMap k v" $
1973+ FromJSONKeyText f -> withObject "HashMap" $
16051974 fmap (mapKey f) . H.traverseWithKey (\k v -> p v <?> Key k)
1606− FromJSONKeyTextParser f -> withObject "HashMap k v" $
1975+ FromJSONKeyTextParser f -> withObject "HashMap" $
16071976 H.foldrWithKey (\k v m -> H.insert <$> f k <?> Key k <*> p v <?> Key k <*> m) (pure H.empty)
1608− FromJSONKeyValue f -> withArray "Map k v" $ \arr ->
1609− H.fromList <$> (Tr.sequence .
1610− zipWith (parseIndexedJSONPair f p) [0..] . V.toList $ arr)
1977+ FromJSONKeyValue f -> withArray "Map" $ \arr ->
1978+ fmap H.fromList . Tr.sequence .
1979+ zipWith (parseIndexedJSONPair f p) [0..] . V.toList $ arr
16111980 where
16121981 uc :: Parser (H.HashMap Text v) -> Parser (H.HashMap k v)
16131982 uc = unsafeCoerce
@@ -1628,11 +1997,33 @@ instance FromJSON DotNetTime where
16281997 parseJSON = withText "DotNetTime" $ \t ->
16291998 let (s,m) = T.splitAt (T.length t - 5) t
16301999 t' = T.concat [s,".",m]
1631− in case parseTime defaultTimeLocale "/Date(%s%Q)/" (unpack t') of
2000+ in case parseTimeM True defaultTimeLocale "/Date(%s%Q)/" (unpack t') of
16322001 Just d -> pure (DotNetTime d)
16332002 _ -> fail "could not parse .NET time"
16342003 {-# INLINE parseJSON #-}
16352004
2005+-------------------------------------------------------------------------------
2006+-- primitive
2007+-------------------------------------------------------------------------------
2008+
2009+instance FromJSON a => FromJSON (PM.Array a) where
2010+ -- note: we could do better than this if vector exposed the data
2011+ -- constructor in Data.Vector.
2012+ parseJSON = fmap Exts.fromList . parseJSON
2013+
2014+instance FromJSON a => FromJSON (PM.SmallArray a) where
2015+ parseJSON = fmap Exts.fromList . parseJSON
2016+
2017+#if MIN_VERSION_primitive(0,6,4)
2018+instance (PM.Prim a,FromJSON a) => FromJSON (PM.PrimArray a) where
2019+ parseJSON = fmap Exts.fromList . parseJSON
2020+
2021+#if !MIN_VERSION_primitive(0,7,0)
2022+instance (PM.PrimUnlifted a,FromJSON a) => FromJSON (PM.UnliftedArray a) where
2023+ parseJSON = fmap Exts.fromList . parseJSON
2024+#endif
2025+#endif
2026+
16362027-------------------------------------------------------------------------------
16372028-- time
16382029-------------------------------------------------------------------------------
@@ -1658,6 +2049,17 @@ instance FromJSONKey LocalTime where
16582049 fromJSONKey = FromJSONKeyTextParser (Time.run Time.localTime)
16592050
16602051
2052+-- | Supported string formats:
2053+--
2054+-- @YYYY-MM-DD HH:MM Z@
2055+-- @YYYY-MM-DD HH:MM:SS Z@
2056+-- @YYYY-MM-DD HH:MM:SS.SSS Z@
2057+--
2058+-- The first space may instead be a @T@, and the second space is
2059+-- optional. The @Z@ represents UTC. The @Z@ may be replaced with a
2060+-- time zone offset of the form @+0000@ or @-08:00@, where the first
2061+-- two digits are hours, the @:@ is optional and the second two digits
2062+-- (also optional) are minutes.
16612063instance FromJSON ZonedTime where
16622064 parseJSON = withText "ZonedTime" (Time.run Time.zonedTime)
16632065
@@ -1672,14 +2074,57 @@ instance FromJSONKey UTCTime where
16722074 fromJSONKey = FromJSONKeyTextParser (Time.run Time.utcTime)
16732075
16742076
1675−-- | /WARNING:/ Only parse lengths of time from trusted input
1676−-- since an attacker could easily fill up the memory of the target
1677−-- system by specifying a scientific number with a big exponent like
1678−-- @1e1000000000@.
2077+-- | This instance includes a bounds check to prevent maliciously
2078+-- large inputs to fill up the memory of the target system. You can
2079+-- newtype 'Scientific' and provide your own instance using
2080+-- 'withScientific' if you want to allow larger inputs.
16792081instance FromJSON NominalDiffTime where
1680− parseJSON = withScientific "NominalDiffTime" $ pure . realToFrac
2082+ parseJSON = withBoundedScientific "NominalDiffTime" $ pure . realToFrac
2083+ {-# INLINE parseJSON #-}
2084+
2085+
2086+-- | This instance includes a bounds check to prevent maliciously
2087+-- large inputs to fill up the memory of the target system. You can
2088+-- newtype 'Scientific' and provide your own instance using
2089+-- 'withScientific' if you want to allow larger inputs.
2090+instance FromJSON DiffTime where
2091+ parseJSON = withBoundedScientific "DiffTime" $ pure . realToFrac
16812092 {-# INLINE parseJSON #-}
16822093
2094+instance FromJSON SystemTime where
2095+ parseJSON v = prependContext "SystemTime" $ do
2096+ n <- parseJSON v
2097+ let n' = floor (n * fromInteger (resolution n) :: Nano)
2098+ let (secs, nano) = n' `divMod` resolution n
2099+ return (MkSystemTime (fromInteger secs) (fromInteger nano))
2100+
2101+instance FromJSON CalendarDiffTime where
2102+ parseJSON = withObject "CalendarDiffTime" $ \obj -> CalendarDiffTime
2103+ <$> obj .: "months"
2104+ <*> obj .: "time"
2105+
2106+instance FromJSON CalendarDiffDays where
2107+ parseJSON = withObject "CalendarDiffDays" $ \obj -> CalendarDiffDays
2108+ <$> obj .: "months"
2109+ <*> obj .: "days"
2110+
2111+instance FromJSON DayOfWeek where
2112+ parseJSON = withText "DaysOfWeek" parseDayOfWeek
2113+
2114+parseDayOfWeek :: T.Text -> Parser DayOfWeek
2115+parseDayOfWeek t = case T.toLower t of
2116+ "monday" -> return Monday
2117+ "tuesday" -> return Tuesday
2118+ "wednesday" -> return Wednesday
2119+ "thursday" -> return Thursday
2120+ "friday" -> return Friday
2121+ "saturday" -> return Saturday
2122+ "sunday" -> return Sunday
2123+ _ -> fail "Invalid week day"
2124+
2125+instance FromJSONKey DayOfWeek where
2126+ fromJSONKey = FromJSONKeyTextParser parseDayOfWeek
2127+
16832128-------------------------------------------------------------------------------
16842129-- base Monoid/Semigroup
16852130-------------------------------------------------------------------------------
@@ -1800,14 +2245,15 @@ instance FromJSON a => FromJSON (Semigroup.Option a) where
18002245
18012246instance FromJSON1 Proxy where
18022247 {-# INLINE liftParseJSON #-}
1803− liftParseJSON _ _ Null = pure Proxy
1804− liftParseJSON _ _ v = typeMismatch "Proxy" v
2248+ liftParseJSON _ _ = fromNull "Proxy" Proxy
18052249
18062250instance FromJSON (Proxy a) where
18072251 {-# INLINE parseJSON #-}
1808− parseJSON Null = pure Proxy
1809− parseJSON v = typeMismatch "Proxy" v
2252+ parseJSON = fromNull "Proxy" Proxy
18102253
2254+fromNull :: String -> a -> Value -> Parser a
2255+fromNull _ a Null = pure a
2256+fromNull c _ v = prependContext c (typeMismatch "Null" v)
18112257
18122258instance FromJSON2 Tagged where
18132259 liftParseJSON2 _ _ p _ = fmap Tagged . p
@@ -1834,10 +2280,7 @@ instance (FromJSON a, FromJSON b, FromJSON c) => FromJSONKey (a,b,c)
18342280instance (FromJSON a, FromJSON b, FromJSON c, FromJSON d) => FromJSONKey (a,b,c,d)
18352281
18362282instance FromJSONKey Char where
1837− fromJSONKey = FromJSONKeyTextParser $ \t ->
1838− if T.length t == 1
1839− then return (T.index t 0)
1840− else typeMismatch "Expected Char but String didn't contain exactly one character" (String t)
2283+ fromJSONKey = FromJSONKeyTextParser parseChar
18412284 fromJSONKeyList = FromJSONKeyText T.unpack
18422285
18432286instance (FromJSONKey a, FromJSON a) => FromJSONKey [a] where
Data/Aeson/Types/Generic.hs+12−8
@@ -1,10 +1,11 @@
11{-# LANGUAGE CPP #-}
22{-# LANGUAGE DataKinds #-}
3+{-# LANGUAGE DeriveFunctor #-}
34{-# LANGUAGE EmptyDataDecls #-}
45{-# LANGUAGE FlexibleInstances #-}
56{-# LANGUAGE FunctionalDependencies #-}
67{-# LANGUAGE KindSignatures #-}
7−{-# LANGUAGE MultiParamTypeClasses #-}
8+{-# LANGUAGE NoImplicitPrelude #-}
89{-# LANGUAGE ScopedTypeVariables #-}
910{-# LANGUAGE TypeOperators #-}
1011{-# LANGUAGE UndecidableInstances #-}
@@ -25,7 +26,7 @@
2526
2627module Data.Aeson.Types.Generic
2728 (
28− IsRecord(..)
29+ IsRecord
2930 , AllNullary
3031 , Tagged2(..)
3132 , True
@@ -34,9 +35,9 @@ module Data.Aeson.Types.Generic
3435 , Zero
3536 , One
3637 , ProductSize(..)
38+ , (:*)(..)
3739 ) where
3840
39−import Prelude ()
4041import Prelude.Compat
4142
4243import GHC.Generics
@@ -44,12 +45,8 @@ import GHC.Generics
4445--------------------------------------------------------------------------------
4546
4647class IsRecord (f :: * -> *) isRecord | f -> isRecord
47− where
48− isUnary :: f a -> Bool
49− isUnary = const True
5048
5149instance (IsRecord f isRecord) => IsRecord (f :*: g) isRecord
52− where isUnary = const False
5350#if MIN_VERSION_base(4,9,0)
5451instance OVERLAPPING_ IsRecord (M1 S ('MetaSel 'Nothing u ss ds) f) False
5552#else
@@ -61,7 +58,6 @@ instance IsRecord Par1 True
6158instance IsRecord (Rec1 f) True
6259instance IsRecord (f :.: g) True
6360instance IsRecord U1 False
64− where isUnary = const False
6561
6662--------------------------------------------------------------------------------
6763
@@ -80,6 +76,7 @@ instance AllNullary (Rec1 f) False
8076instance AllNullary U1 True
8177
8278newtype Tagged2 (s :: * -> *) b = Tagged2 {unTagged2 :: b}
79+ deriving Functor
8380
8481--------------------------------------------------------------------------------
8582
@@ -112,3 +109,10 @@ instance (ProductSize a, ProductSize b) => ProductSize (a :*: b) where
112109
113110instance ProductSize (S1 s a) where
114111 productSize = Tagged2 1
112+
113+--------------------------------------------------------------------------------
114+
115+-- | Simple extensible tuple type to simplify passing around many parameters.
116+data a :* b = a :* b
117+
118+infixr 1 :*
Data/Aeson/Types/Internal.hs+155−13
@@ -1,6 +1,8 @@
11{-# LANGUAGE CPP #-}
22{-# LANGUAGE DeriveDataTypeable #-}
3+{-# LANGUAGE DeriveGeneric #-}
34{-# LANGUAGE GeneralizedNewtypeDeriving #-}
5+{-# LANGUAGE NoImplicitPrelude #-}
46{-# LANGUAGE Rank2Types #-}
57#if __GLASGOW_HASKELL__ >= 800
68-- a) THQ works on cross-compilers and unregisterised GHCs
@@ -43,16 +45,33 @@ module Data.Aeson.Types.Internal
4345 , parseEither
4446 , parseMaybe
4547 , modifyFailure
48+ , prependFailure
49+ , parserThrowError
50+ , parserCatchError
4651 , formatError
52+ , formatPath
53+ , formatRelativePath
4754 , (<?>)
4855 -- * Constructors and accessors
4956 , object
5057
5158 -- * Generic and TH encoding configuration
52− , Options(..)
59+ , Options(
60+ fieldLabelModifier
61+ , constructorTagModifier
62+ , allNullaryToStringTag
63+ , omitNothingFields
64+ , sumEncoding
65+ , unwrapUnaryRecords
66+ , tagSingleConstructors
67+ , rejectUnknownFields
68+ )
69+
5370 , SumEncoding(..)
71+ , JSONKeyOptions(keyModifier)
5472 , defaultOptions
5573 , defaultTaggedObject
74+ , defaultJSONKeyOptions
5675
5776 -- * Used for changing CamelCase names into something else.
5877 , camelTo
@@ -62,7 +81,6 @@ module Data.Aeson.Types.Internal
6281 , DotNetTime(..)
6382 ) where
6483
65−import Prelude ()
6684import Prelude.Compat
6785
6886import Control.Applicative (Alternative(..))
@@ -83,6 +101,8 @@ import Data.Time (UTCTime)
83101import Data.Time.Format (FormatTime)
84102import Data.Typeable (Typeable)
85103import Data.Vector (Vector)
104+import GHC.Generics (Generic)
105+import qualified Control.Monad as Monad
86106import qualified Control.Monad.Fail as Fail
87107import qualified Data.HashMap.Strict as H
88108import qualified Data.Scientific as S
@@ -101,7 +121,7 @@ data JSONPathElement = Key Text
101121 | Index {-# UNPACK #-} !Int
102122 -- ^ JSON path element of an index into an
103123 -- array, \"array[index]\".
104− deriving (Eq, Show, Typeable)
124+ deriving (Eq, Show, Typeable, Ord)
105125type JSONPath = [JSONPathElement]
106126
107127-- | The internal result of running a 'Parser'.
@@ -136,7 +156,7 @@ instance Functor Result where
136156 fmap _ (Error err) = Error err
137157 {-# INLINE fmap #-}
138158
139−instance Monad IResult where
159+instance Monad.Monad IResult where
140160 return = pure
141161 {-# INLINE return #-}
142162
@@ -144,14 +164,16 @@ instance Monad IResult where
144164 IError path err >>= _ = IError path err
145165 {-# INLINE (>>=) #-}
146166
167+#if !(MIN_VERSION_base(4,13,0))
147168 fail = Fail.fail
148169 {-# INLINE fail #-}
170+#endif
149171
150172instance Fail.MonadFail IResult where
151173 fail err = IError [] err
152174 {-# INLINE fail #-}
153175
154−instance Monad Result where
176+instance Monad.Monad Result where
155177 return = pure
156178 {-# INLINE return #-}
157179
@@ -159,8 +181,10 @@ instance Monad Result where
159181 Error err >>= _ = Error err
160182 {-# INLINE (>>=) #-}
161183
184+#if !(MIN_VERSION_base(4,13,0))
162185 fail = Fail.fail
163186 {-# INLINE fail #-}
187+#endif
164188
165189instance Fail.MonadFail Result where
166190 fail err = Error err
@@ -257,7 +281,9 @@ type Failure f r = JSONPath -> String -> f r
257281-- | Success continuation.
258282type Success a f r = a -> f r
259283
260−-- | A JSON parser.
284+-- | A JSON parser. N.B. This might not fit your usual understanding of
285+-- "parser". Instead you might like to think of 'Parser' as a "parse result",
286+-- i.e. a parser to which the input has already been applied.
261287newtype Parser a = Parser {
262288 runParser :: forall f r.
263289 JSONPath
@@ -266,14 +292,17 @@ newtype Parser a = Parser {
266292 -> f r
267293 }
268294
269−instance Monad Parser where
295+instance Monad.Monad Parser where
270296 m >>= g = Parser $ \path kf ks -> let ks' a = runParser (g a) path kf ks
271297 in runParser m path kf ks'
272298 {-# INLINE (>>=) #-}
273299 return = pure
274300 {-# INLINE return #-}
301+
302+#if !(MIN_VERSION_base(4,13,0))
275303 fail = Fail.fail
276304 {-# INLINE fail #-}
305+#endif
277306
278307instance Fail.MonadFail Parser where
279308 fail msg = Parser $ \path kf _ks -> kf (reverse path) msg
@@ -316,8 +345,7 @@ instance Monoid (Parser a) where
316345apP :: Parser (a -> b) -> Parser a -> Parser b
317346apP d e = do
318347 b <- d
319− a <- e
320− return (b a)
348+ b <$> e
321349{-# INLINE apP #-}
322350
323351-- | A JSON \"object\" (key\/value map).
@@ -333,7 +361,7 @@ data Value = Object !Object
333361 | Number !Scientific
334362 | Bool !Bool
335363 | Null
336− deriving (Eq, Read, Show, Typeable, Data)
364+ deriving (Eq, Read, Show, Typeable, Data, Generic)
337365
338366-- | A newtype wrapper for 'UTCTime' that uses the same non-standard
339367-- serialization format as Microsoft .NET, whose
@@ -433,7 +461,17 @@ parseEither m v = runParser (m v) [] onError Right
433461-- | Annotate an error message with a
434462-- <http://goessner.net/articles/JsonPath/ JSONPath> error location.
435463formatError :: JSONPath -> String -> String
436−formatError path msg = "Error in " ++ format "$" path ++ ": " ++ msg
464+formatError path msg = "Error in " ++ formatPath path ++ ": " ++ msg
465+
466+-- | Format a <http://goessner.net/articles/JsonPath/ JSONPath> as a 'String',
467+-- representing the root object as @$@.
468+formatPath :: JSONPath -> String
469+formatPath path = "$" ++ formatRelativePath path
470+
471+-- | Format a <http://goessner.net/articles/JsonPath/ JSONPath> as a 'String'
472+-- which represents the path relative to some root object.
473+formatRelativePath :: JSONPath -> String
474+formatRelativePath path = format "" path
437475 where
438476 format :: String -> JSONPath -> String
439477 format pfx [] = pfx
@@ -496,13 +534,40 @@ p <?> pathElem = Parser $ \path kf ks -> runParser p (pathElem:path) kf ks
496534--
497535-- Since 0.6.2.0
498536modifyFailure :: (String -> String) -> Parser a -> Parser a
499−modifyFailure f (Parser p) = Parser $ \path kf ks -> p path (\p' m -> kf p' (f m)) ks
537+modifyFailure f (Parser p) = Parser $ \path kf ks ->
538+ p path (\p' m -> kf p' (f m)) ks
539+
540+-- | If the inner 'Parser' failed, prepend the given string to the failure
541+-- message.
542+--
543+-- @
544+-- 'prependFailure' s = 'modifyFailure' (s '++')
545+-- @
546+prependFailure :: String -> Parser a -> Parser a
547+prependFailure = modifyFailure . (++)
548+
549+-- | Throw a parser error with an additional path.
550+--
551+-- @since 1.2.1.0
552+parserThrowError :: JSONPath -> String -> Parser a
553+parserThrowError path' msg = Parser $ \path kf _ks ->
554+ kf (reverse path ++ path') msg
555+
556+-- | A handler function to handle previous errors and return to normal execution.
557+--
558+-- @since 1.2.1.0
559+parserCatchError :: Parser a -> (JSONPath -> String -> Parser a) -> Parser a
560+parserCatchError (Parser p) handler = Parser $ \path kf ks ->
561+ p path (\e msg -> runParser (handler e msg) path kf ks) ks
500562
501563--------------------------------------------------------------------------------
502564-- Generic and TH encoding configuration
503565--------------------------------------------------------------------------------
504566
505567-- | Options that specify how to encode\/decode your datatype to\/from JSON.
568+--
569+-- Options can be set using record syntax on 'defaultOptions' with the fields
570+-- below.
506571data Options = Options
507572 { fieldLabelModifier :: String -> String
508573 -- ^ Function applied to field labels.
@@ -519,6 +584,39 @@ data Options = Options
519584 -- ^ If 'True' record fields with a 'Nothing' value will be
520585 -- omitted from the resulting object. If 'False' the resulting
521586 -- object will include those fields mapping to @null@.
587+ --
588+ -- === Note
589+ --
590+ -- Setting 'omitNothingFields' to 'True' only affects fields which are of
591+ -- type 'Maybe' /uniformly/ in the 'ToJSON' or 'FromJSON' instance. In
592+ -- particular, if the type of a field is declared as a type variable, it
593+ -- will not be omitted from the JSON object, unless the field is
594+ -- specialized upfront in the instance.
595+ --
596+ -- ==== __Example__
597+ --
598+ -- The generic instance for the following type @Fruit@ depends on whether
599+ -- the instance head is @Fruit a@ or @Fruit (Maybe a)@.
600+ --
601+ -- @
602+ -- data Fruit a =
603+ -- { apples :: a -- A field whose type is a type variable.
604+ -- , oranges :: 'Maybe' Int
605+ -- }
606+ --
607+ -- options :: 'Options'
608+ -- options = 'defaultOptions' { 'omitNothingFields' = 'True' }
609+ --
610+ -- -- apples required, oranges optional
611+ -- -- Even if 'Data.Aeson.fromJSON' is then specialized to (Fruit ('Maybe' a)).
612+ -- instance 'Data.Aeson.FromJSON' a => 'Data.Aeson.FromJSON' (Fruit a) where
613+ -- 'Data.Aeson.fromJSON' = 'Data.Aeson.genericFromJSON' options
614+ --
615+ -- -- apples optional, oranges optional
616+ -- -- In this instance, the field apples is uniformly of type ('Maybe' a).
617+ -- instance 'Data.Aeson.FromJSON' a => 'Data.Aeson.FromJSON' (Fruit ('Maybe' a)) where
618+ -- 'Data.Aeson.fromJSON' = 'Data.Aeson.genericFromJSON' options
619+ -- @
522620 , sumEncoding :: SumEncoding
523621 -- ^ Specifies how to encode constructors of a sum datatype.
524622 , unwrapUnaryRecords :: Bool
@@ -527,10 +625,14 @@ data Options = Options
527625 , tagSingleConstructors :: Bool
528626 -- ^ Encode types with a single constructor as sums,
529627 -- so that `allNullaryToStringTag` and `sumEncoding` apply.
628+ , rejectUnknownFields :: Bool
629+ -- ^ Applies only to 'Data.Aeson.FromJSON' instances. If a field appears in
630+ -- the parsed object map, but does not appear in the target object, parsing
631+ -- will fail, with an error message indicating which fields were unknown.
530632 }
531633
532634instance Show Options where
533− show (Options f c a o s u t) =
635+ show (Options f c a o s u t r) =
534636 "Options {"
535637 ++ intercalate ", "
536638 [ "fieldLabelModifier =~ " ++ show (f "exampleField")
@@ -540,6 +642,7 @@ instance Show Options where
540642 , "sumEncoding = " ++ show s
541643 , "unwrapUnaryRecords = " ++ show u
542644 , "tagSingleConstructors = " ++ show t
645+ , "rejectUnknownFields = " ++ show r
543646 ]
544647 ++ "}"
545648
@@ -583,6 +686,33 @@ data SumEncoding =
583686 -- contents of the constructor.
584687 deriving (Eq, Show)
585688
689+-- | Options for encoding keys with 'Data.Aeson.Types.genericFromJSONKey' and
690+-- 'Data.Aeson.Types.genericToJSONKey'.
691+data JSONKeyOptions = JSONKeyOptions
692+ { keyModifier :: String -> String
693+ -- ^ Function applied to keys. Its result is what goes into the encoded
694+ -- 'Value'.
695+ --
696+ -- === __Example__
697+ --
698+ -- The following instances encode the constructor @Bar@ to lower-case keys
699+ -- @\"bar\"@.
700+ --
701+ -- @
702+ -- data Foo = Bar
703+ -- deriving 'Generic'
704+ --
705+ -- opts :: 'JSONKeyOptions'
706+ -- opts = 'defaultJSONKeyOptions' { 'keyModifier' = 'toLower' }
707+ --
708+ -- instance 'ToJSONKey' Foo where
709+ -- 'toJSONKey' = 'genericToJSONKey' opts
710+ --
711+ -- instance 'FromJSONKey' Foo where
712+ -- 'fromJSONKey' = 'genericFromJSONKey' opts
713+ -- @
714+ }
715+
586716-- | Default encoding 'Options':
587717--
588718-- @
@@ -594,6 +724,7 @@ data SumEncoding =
594724-- , 'sumEncoding' = 'defaultTaggedObject'
595725-- , 'unwrapUnaryRecords' = False
596726-- , 'tagSingleConstructors' = False
727+-- , 'rejectUnknownFields' = False
597728-- }
598729-- @
599730defaultOptions :: Options
@@ -605,6 +736,7 @@ defaultOptions = Options
605736 , sumEncoding = defaultTaggedObject
606737 , unwrapUnaryRecords = False
607738 , tagSingleConstructors = False
739+ , rejectUnknownFields = False
608740 }
609741
610742-- | Default 'TaggedObject' 'SumEncoding' options:
@@ -621,6 +753,16 @@ defaultTaggedObject = TaggedObject
621753 , contentsFieldName = "contents"
622754 }
623755
756+-- | Default 'JSONKeyOptions':
757+--
758+-- @
759+-- defaultJSONKeyOptions = 'JSONKeyOptions'
760+-- { 'keyModifier' = 'id'
761+-- }
762+-- @
763+defaultJSONKeyOptions :: JSONKeyOptions
764+defaultJSONKeyOptions = JSONKeyOptions id
765+
624766-- | Converts from CamelCase to another lower case, interspersing
625767-- the character between all capital letters and their previous
626768-- entries, except those capital letters that appear together,
Data/Aeson/Types/ToJSON.hs+262−84
@@ -5,21 +5,17 @@
55{-# LANGUAGE FlexibleInstances #-}
66{-# LANGUAGE FunctionalDependencies #-}
77{-# LANGUAGE GADTs #-}
8−{-# LANGUAGE MultiParamTypeClasses #-}
9−{-# LANGUAGE NamedFieldPuns #-}
8+{-# LANGUAGE NoImplicitPrelude #-}
109{-# LANGUAGE OverloadedStrings #-}
1110{-# LANGUAGE PatternGuards #-}
11+{-# LANGUAGE PolyKinds #-}
1212{-# LANGUAGE RecordWildCards #-}
1313{-# LANGUAGE ScopedTypeVariables #-}
1414{-# LANGUAGE TypeOperators #-}
15−{-# LANGUAGE TypeSynonymInstances #-}
1615{-# LANGUAGE UndecidableInstances #-}
1716
18−#if __GLASGOW_HASKELL__ >= 706
19−{-# LANGUAGE PolyKinds #-}
20−#endif
21−
2217#include "overlapping-compat.h"
18+#include "incoherent-compat.h"
2319
2420-- TODO: Drop this when we remove support for Data.Attoparsec.Number
2521{-# OPTIONS_GHC -fno-warn-deprecations #-}
@@ -47,15 +43,20 @@ module Data.Aeson.Types.ToJSON
4743 , ToJSONKeyFunction(..)
4844 , toJSONKeyText
4945 , contramapToJSONKeyFunction
46+
47+ , GToJSONKey()
48+ , genericToJSONKey
49+
5050 -- * Object key-value pairs
5151 , KeyValue(..)
52+ , KeyValuePair(..)
53+ , FromPairs(..)
5254 -- * Functions needed for documentation
5355 -- * Encoding functions
5456 , listEncoding
5557 , listValue
5658 ) where
5759
58−import Prelude ()
5960import Prelude.Compat
6061
6162import Control.Applicative (Const(..))
@@ -63,38 +64,42 @@ import Control.Monad.ST (ST)
6364import Data.Aeson.Encoding (Encoding, Encoding', Series, dict, emptyArray_)
6465import Data.Aeson.Encoding.Internal ((>*<))
6566import Data.Aeson.Internal.Functions (mapHashKeyVal, mapKeyVal)
66−import Data.Aeson.Types.Generic (AllNullary, False, IsRecord(..), One, ProductSize, Tagged2(..), True, Zero, productSize)
67+import Data.Aeson.Types.Generic (AllNullary, False, IsRecord, One, ProductSize, Tagged2(..), True, Zero, productSize)
6768import Data.Aeson.Types.Internal
6869import Data.Attoparsec.Number (Number(..))
6970import Data.Bits (unsafeShiftR)
7071import Data.DList (DList)
71−import Data.Fixed (Fixed, HasResolution)
72+import Data.Fixed (Fixed, HasResolution, Nano)
7273import Data.Foldable (toList)
7374import Data.Functor.Compose (Compose(..))
75+import Data.Functor.Contravariant (Contravariant (..))
7476import Data.Functor.Identity (Identity(..))
7577import Data.Functor.Product (Product(..))
7678import Data.Functor.Sum (Sum(..))
7779import Data.Int (Int16, Int32, Int64, Int8)
7880import Data.List (intersperse)
7981import Data.List.NonEmpty (NonEmpty(..))
80−import Data.Monoid ((<>))
82+import Data.Semigroup ((<>))
8183import Data.Proxy (Proxy(..))
8284import Data.Ratio (Ratio, denominator, numerator)
8385import Data.Scientific (Scientific)
8486import Data.Tagged (Tagged(..))
8587import Data.Text (Text, pack)
86−import Data.Time (Day, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
87−import Data.Time.Format (FormatTime, formatTime)
88−import Data.Time.Locale.Compat (defaultTimeLocale)
88+import Data.Time (Day, DiffTime, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
89+import Data.Time.Calendar.Compat (CalendarDiffDays (..), DayOfWeek (..))
90+import Data.Time.LocalTime.Compat (CalendarDiffTime (..))
91+import Data.Time.Clock.System.Compat (SystemTime (..))
92+import Data.Time.Format.Compat (FormatTime, formatTime, defaultTimeLocale)
8993import Data.Vector (Vector)
9094import Data.Version (Version, showVersion)
95+import Data.Void (Void, absurd)
9196import Data.Word (Word16, Word32, Word64, Word8)
9297import Foreign.Storable (Storable)
98+import Foreign.C.Types (CTime (..))
9399import GHC.Generics
94100import Numeric.Natural (Natural)
95101import qualified Data.Aeson.Encoding as E
96102import qualified Data.Aeson.Encoding.Internal as E (InArray, comma, econcat, retagEncoding)
97−import qualified Data.ByteString as S
98103import qualified Data.ByteString.Lazy as L
99104import qualified Data.DList as DList
100105import qualified Data.HashMap.Strict as H
@@ -123,15 +128,17 @@ import qualified Data.Vector.Unboxed as VU
123128import qualified Data.Aeson.Encoding.Builder as EB
124129import qualified Data.ByteString.Builder as B
125130
126−#if !(MIN_VERSION_bytestring(0,10,0))
127−import Foreign.ForeignPtr (withForeignPtr)
128−import Foreign.Marshal.Utils (copyBytes)
129−import Foreign.Ptr (plusPtr)
130−import qualified Data.ByteString.Internal as S
131−import qualified Data.ByteString.Lazy.Internal as L
132−#endif
131+import qualified GHC.Exts as Exts
132+import qualified Data.Primitive.Array as PM
133+import qualified Data.Primitive.SmallArray as PM
134+import qualified Data.Primitive.Types as PM
133135
134−{-# ANN module ("HLint: ignore Reduce duplication"::String) #-}
136+#if MIN_VERSION_primitive(0,6,4)
137+#if !MIN_VERSION_primitive(0,7,0)
138+import qualified Data.Primitive.UnliftedArray as PM
139+#endif
140+import qualified Data.Primitive.PrimArray as PM
141+#endif
135142
136143toJSONPair :: (a -> Value) -> (b -> Value) -> (a, b) -> Value
137144toJSONPair a b = liftToJSON2 a (listValue a) b (listValue b)
@@ -260,7 +267,7 @@ genericLiftToEncoding opts te tel = gToJSON opts (To1Args te tel) . from1
260267-- @
261268--
262269-- Previous versions of this library only had the 'toJSON' method. Adding
263−-- 'toEncoding' had to reasons:
270+-- 'toEncoding' had two reasons:
264271--
265272-- 1. toEncoding is more efficient for the common case that the output of
266273-- 'toJSON' is directly serialized to a @ByteString@.
@@ -331,6 +338,13 @@ instance KeyValue Pair where
331338 name .= value = (name, toJSON value)
332339 {-# INLINE (.=) #-}
333340
341+-- | Constructs a singleton 'H.HashMap'. For calling functions that
342+-- demand an 'Object' for constructing objects. To be used in
343+-- conjunction with 'mconcat'. Prefer to use 'object' where possible.
344+instance KeyValue Object where
345+ name .= value = H.singleton name (toJSON value)
346+ {-# INLINE (.=) #-}
347+
334348-------------------------------------------------------------------------------
335349-- Classes and types for map keys
336350-------------------------------------------------------------------------------
@@ -388,7 +402,7 @@ instance KeyValue Pair where
388402-- newtype wrapper around 'Text'. The recommended approach is to use
389403-- generalized newtype deriving:
390404--
391−-- > newtype RecordId = RecordId { getRecordId :: Text}
405+-- > newtype RecordId = RecordId { getRecordId :: Text }
392406-- > deriving (Eq,Ord,ToJSONKey)
393407--
394408-- Then we may write:
@@ -403,8 +417,18 @@ instance KeyValue Pair where
403417--
404418-- It is possible to get the 'ToJSONKey' instance for free as we did
405419-- with 'Foo'. However, in this case, we have a natural way to go to
406−-- and from 'Text' that does not require any escape sequences. So, in
407−-- this example, 'ToJSONKeyText' will be used instead of 'ToJSONKeyValue'.
420+-- and from 'Text' that does not require any escape sequences. So
421+-- 'ToJSONKeyText' can be used instead of 'ToJSONKeyValue' to encode maps
422+-- as objects instead of arrays of pairs. This instance may be
423+-- implemented using generics as follows:
424+--
425+-- @
426+-- instance 'ToJSONKey' Color where
427+-- 'toJSONKey' = 'genericToJSONKey' 'defaultJSONKeyOptions'
428+-- @
429+--
430+-- === __Low-level implementations__
431+--
408432-- The 'Show' instance can be used to help write 'ToJSONKey':
409433--
410434-- > instance ToJSONKey Color where
@@ -479,16 +503,42 @@ toJSONKeyTextEnc e = ToJSONKeyText tot e
479503 -- TODO: dropAround is also used in stringEncoding, which is unfortunate atm
480504 tot = T.dropAround (== '"')
481505 . T.decodeLatin1
482− . lazyToStrictByteString
506+ . L.toStrict
483507 . E.encodingToLazyByteString
484508 . e
485509
510+instance Contravariant ToJSONKeyFunction where
511+ contramap = contramapToJSONKeyFunction
512+
486513-- | Contravariant map, as 'ToJSONKeyFunction' is a contravariant functor.
487514contramapToJSONKeyFunction :: (b -> a) -> ToJSONKeyFunction a -> ToJSONKeyFunction b
488515contramapToJSONKeyFunction h x = case x of
489516 ToJSONKeyText f g -> ToJSONKeyText (f . h) (g . h)
490517 ToJSONKeyValue f g -> ToJSONKeyValue (f . h) (g . h)
491518
519+-- 'toJSONKey' for 'Generic' types.
520+-- Deriving is supported for enumeration types, i.e. the sums of nullary
521+-- constructors. The names of constructors will be used as keys for JSON
522+-- objects.
523+--
524+-- See also 'genericFromJSONKey'.
525+--
526+-- === __Example__
527+--
528+-- @
529+-- data Color = Red | Green | Blue
530+-- deriving 'Generic'
531+--
532+-- instance 'ToJSONKey' Color where
533+-- 'toJSONKey' = 'genericToJSONKey' 'defaultJSONKeyOptions'
534+-- @
535+genericToJSONKey :: (Generic a, GToJSONKey (Rep a))
536+ => JSONKeyOptions -> ToJSONKeyFunction a
537+genericToJSONKey opts = toJSONKeyText (pack . keyModifier opts . getConName . from)
538+
539+class GetConName f => GToJSONKey f
540+instance GetConName f => GToJSONKey f
541+
492542-------------------------------------------------------------------------------
493543-- Lifings of FromJSON and ToJSON to unary and binary type constructors
494544-------------------------------------------------------------------------------
@@ -653,16 +703,32 @@ instance (ToJSON a) => ToJSON [a] where
653703instance OVERLAPPABLE_ (GToJSON enc arity a) => GToJSON enc arity (M1 i c a) where
654704 -- Meta-information, which is not handled elsewhere, is ignored:
655705 gToJSON opts targs = gToJSON opts targs . unM1
706+ {-# INLINE gToJSON #-}
656707
657708instance GToJSON enc One Par1 where
658709 -- Direct occurrences of the last type parameter are encoded with the
659710 -- function passed in as an argument:
660711 gToJSON _opts (To1Args tj _) = tj . unPar1
712+ {-# INLINE gToJSON #-}
713+
714+instance ( ConsToJSON enc arity a
715+ , AllNullary (C1 c a) allNullary
716+ , SumToJSON enc arity (C1 c a) allNullary
717+ ) => GToJSON enc arity (D1 d (C1 c a)) where
718+ -- The option 'tagSingleConstructors' determines whether to wrap
719+ -- a single-constructor type.
720+ gToJSON opts targs
721+ | tagSingleConstructors opts = (unTagged :: Tagged allNullary enc -> enc)
722+ . sumToJSON opts targs
723+ . unM1
724+ | otherwise = consToJSON opts targs . unM1 . unM1
725+ {-# INLINE gToJSON #-}
661726
662727instance (ConsToJSON enc arity a) => GToJSON enc arity (C1 c a) where
663728 -- Constructors need to be encoded differently depending on whether they're
664729 -- a record or not. This distinction is made by 'consToJSON':
665730 gToJSON opts targs = consToJSON opts targs . unM1
731+ {-# INLINE gToJSON #-}
666732
667733instance ( AllNullary (a :+: b) allNullary
668734 , SumToJSON enc arity (a :+: b) allNullary
@@ -673,6 +739,7 @@ instance ( AllNullary (a :+: b) allNullary
673739 -- strings. This distinction is made by 'sumToJSON':
674740 gToJSON opts targs = (unTagged :: Tagged allNullary enc -> enc)
675741 . sumToJSON opts targs
742+ {-# INLINE gToJSON #-}
676743
677744--------------------------------------------------------------------------------
678745-- Generic toJSON
@@ -681,18 +748,27 @@ instance ( AllNullary (a :+: b) allNullary
681748-- possible but makes error messages a bit harder to understand for missing
682749-- instances.
683750
751+instance GToJSON Value arity V1 where
752+ -- Empty values do not exist, which makes the job of formatting them
753+ -- rather easy:
754+ gToJSON _ _ x = x `seq` error "case: V1"
755+ {-# INLINE gToJSON #-}
756+
684757instance ToJSON a => GToJSON Value arity (K1 i a) where
685758 -- Constant values are encoded using their ToJSON instance:
686759 gToJSON _opts _ = toJSON . unK1
760+ {-# INLINE gToJSON #-}
687761
688762instance ToJSON1 f => GToJSON Value One (Rec1 f) where
689763 -- Recursive occurrences of the last type parameter are encoded using their
690764 -- ToJSON1 instance:
691765 gToJSON _opts (To1Args tj tjl) = liftToJSON tj tjl . unRec1
766+ {-# INLINE gToJSON #-}
692767
693768instance GToJSON Value arity U1 where
694769 -- Empty constructors are encoded to an empty array:
695770 gToJSON _opts _ _ = emptyArray
771+ {-# INLINE gToJSON #-}
696772
697773instance ( WriteProduct arity a, WriteProduct arity b
698774 , ProductSize a, ProductSize b
@@ -709,6 +785,7 @@ instance ( WriteProduct arity a, WriteProduct arity b
709785 where
710786 lenProduct = (unTagged2 :: Tagged2 (a :*: b) Int -> Int)
711787 productSize
788+ {-# INLINE gToJSON #-}
712789
713790instance ( ToJSON1 f
714791 , GToJSON Value One g
@@ -720,6 +797,7 @@ instance ( ToJSON1 f
720797 gToJSON opts targs =
721798 let gtj = gToJSON opts targs in
722799 liftToJSON gtj (listValue gtj) . unComp1
800+ {-# INLINE gToJSON #-}
723801
724802--------------------------------------------------------------------------------
725803-- Generic toEncoding
@@ -727,15 +805,18 @@ instance ( ToJSON1 f
727805instance ToJSON a => GToJSON Encoding arity (K1 i a) where
728806 -- Constant values are encoded using their ToJSON instance:
729807 gToJSON _opts _ = toEncoding . unK1
808+ {-# INLINE gToJSON #-}
730809
731810instance ToJSON1 f => GToJSON Encoding One (Rec1 f) where
732811 -- Recursive occurrences of the last type parameter are encoded using their
733812 -- ToEncoding1 instance:
734813 gToJSON _opts (To1Args te tel) = liftToEncoding te tel . unRec1
814+ {-# INLINE gToJSON #-}
735815
736816instance GToJSON Encoding arity U1 where
737817 -- Empty constructors are encoded to an empty array:
738818 gToJSON _opts _ _ = E.emptyArray_
819+ {-# INLINE gToJSON #-}
739820
740821instance ( EncodeProduct arity a
741822 , EncodeProduct arity b
@@ -745,6 +826,7 @@ instance ( EncodeProduct arity a
745826 -- the same size as the product and write the product's elements to it using
746827 -- 'encodeProduct':
747828 gToJSON opts targs p = E.list E.retagEncoding [encodeProduct opts targs p]
829+ {-# INLINE gToJSON #-}
748830
749831instance ( ToJSON1 f
750832 , GToJSON Encoding One g
@@ -756,6 +838,7 @@ instance ( ToJSON1 f
756838 gToJSON opts targs =
757839 let gte = gToJSON opts targs in
758840 liftToEncoding gte (listEncoding gte) . unComp1
841+ {-# INLINE gToJSON #-}
759842
760843--------------------------------------------------------------------------------
761844
@@ -839,14 +922,14 @@ instance ( IsRecord a isRecord
839922 , TaggedObject' enc pairs arity a isRecord
840923 , FromPairs enc pairs
841924 , FromString enc
842− , GKeyValue enc pairs
925+ , KeyValuePair enc pairs
843926 , Constructor c
844927 ) => TaggedObject enc arity (C1 c a)
845928 where
846929 taggedObject opts targs tagFieldName contentsFieldName =
847− fromPairs . (tag <>) . contents
930+ fromPairs . mappend tag . contents
848931 where
849− tag = tagFieldName `gPair`
932+ tag = tagFieldName `pair`
850933 (fromString (constructorTagModifier opts (conName (undefined :: t c a p)))
851934 :: enc)
852935 contents =
@@ -858,11 +941,11 @@ class TaggedObject' enc pairs arity f isRecord where
858941 -> String -> f a -> Tagged isRecord pairs
859942
860943instance ( GToJSON enc arity f
861− , GKeyValue enc pairs
944+ , KeyValuePair enc pairs
862945 ) => TaggedObject' enc pairs arity f False
863946 where
864947 taggedObject' opts targs contentsFieldName =
865− Tagged . (contentsFieldName `gPair`) . gToJSON opts targs
948+ Tagged . (contentsFieldName `pair`) . gToJSON opts targs
866949
867950instance OVERLAPPING_ Monoid pairs => TaggedObject' enc pairs arity U1 False where
868951 taggedObject' _ _ _ _ = Tagged mempty
@@ -885,6 +968,9 @@ instance (GetConName a, GetConName b) => GetConName (a :+: b) where
885968instance (Constructor c) => GetConName (C1 c a) where
886969 getConName = conName
887970
971+-- For genericToJSONKey
972+instance GetConName a => GetConName (D1 d a) where
973+ getConName (M1 x) = getConName x
888974
889975--------------------------------------------------------------------------------
890976
@@ -940,7 +1026,6 @@ class ConsToJSON enc arity f where
9401026
9411027class ConsToJSON' enc arity f isRecord where
9421028 consToJSON' :: Options -> ToArgs enc arity a
943− -> Bool -- ^ Are we a record with one field?
9441029 -> f a -> Tagged isRecord enc
9451030
9461031instance ( IsRecord f isRecord
@@ -949,23 +1034,29 @@ instance ( IsRecord f isRecord
9491034 where
9501035 consToJSON opts targs =
9511036 (unTagged :: Tagged isRecord enc -> enc)
952− . consToJSON' opts targs (isUnary (undefined :: f a))
1037+ . consToJSON' opts targs
9531038 {-# INLINE consToJSON #-}
9541039
955−instance ( RecordToPairs enc pairs arity f
1040+instance OVERLAPPING_
1041+ ( RecordToPairs enc pairs arity (S1 s f)
9561042 , FromPairs enc pairs
9571043 , GToJSON enc arity f
1044+ ) => ConsToJSON' enc arity (S1 s f) True
1045+ where
1046+ consToJSON' opts targs
1047+ | unwrapUnaryRecords opts = Tagged . gToJSON opts targs
1048+ | otherwise = Tagged . fromPairs . recordToPairs opts targs
1049+ {-# INLINE consToJSON' #-}
1050+
1051+instance ( RecordToPairs enc pairs arity f
1052+ , FromPairs enc pairs
9581053 ) => ConsToJSON' enc arity f True
9591054 where
960− consToJSON' opts targs isUn =
961− Tagged .
962− case (isUn, unwrapUnaryRecords opts) of
963− (True, True) -> gToJSON opts targs
964− _ -> fromPairs . recordToPairs opts targs
1055+ consToJSON' opts targs = Tagged . fromPairs . recordToPairs opts targs
9651056 {-# INLINE consToJSON' #-}
9661057
9671058instance GToJSON enc arity f => ConsToJSON' enc arity f False where
968− consToJSON' opts targs _ = Tagged . gToJSON opts targs
1059+ consToJSON' opts targs = Tagged . gToJSON opts targs
9691060 {-# INLINE consToJSON' #-}
9701061
9711062--------------------------------------------------------------------------------
@@ -983,7 +1074,7 @@ instance ( Monoid pairs
9831074 ) => RecordToPairs enc pairs arity (a :*: b)
9841075 where
9851076 recordToPairs opts (targs :: ToArgs enc arity p) (a :*: b) =
986− pairsOf a <> pairsOf b
1077+ pairsOf a `mappend` pairsOf b
9871078 where
9881079 pairsOf :: (RecordToPairs enc pairs arity f) => f p -> pairs
9891080 pairsOf = recordToPairs opts targs
@@ -991,16 +1082,16 @@ instance ( Monoid pairs
9911082
9921083instance ( Selector s
9931084 , GToJSON enc arity a
994− , GKeyValue enc pairs
1085+ , KeyValuePair enc pairs
9951086 ) => RecordToPairs enc pairs arity (S1 s a)
9961087 where
9971088 recordToPairs = fieldToPair
9981089 {-# INLINE recordToPairs #-}
9991090
1000−instance OVERLAPPING_
1091+instance INCOHERENT_
10011092 ( Selector s
10021093 , GToJSON enc arity (K1 i (Maybe a))
1003− , GKeyValue enc pairs
1094+ , KeyValuePair enc pairs
10041095 , Monoid pairs
10051096 ) => RecordToPairs enc pairs arity (S1 s (K1 i (Maybe a)))
10061097 where
@@ -1009,15 +1100,28 @@ instance OVERLAPPING_
10091100 recordToPairs opts targs m1 = fieldToPair opts targs m1
10101101 {-# INLINE recordToPairs #-}
10111102
1103+instance INCOHERENT_
1104+ ( Selector s
1105+ , GToJSON enc arity (K1 i (Maybe a))
1106+ , KeyValuePair enc pairs
1107+ , Monoid pairs
1108+ ) => RecordToPairs enc pairs arity (S1 s (K1 i (Semigroup.Option a)))
1109+ where
1110+ recordToPairs opts targs = recordToPairs opts targs . unwrap
1111+ where
1112+ unwrap :: S1 s (K1 i (Semigroup.Option a)) p -> S1 s (K1 i (Maybe a)) p
1113+ unwrap (M1 (K1 (Semigroup.Option a))) = M1 (K1 a)
1114+ {-# INLINE recordToPairs #-}
1115+
10121116fieldToPair :: (Selector s
10131117 , GToJSON enc arity a
1014− , GKeyValue enc pairs)
1118+ , KeyValuePair enc pairs)
10151119 => Options -> ToArgs enc arity p
10161120 -> S1 s a p -> pairs
10171121fieldToPair opts targs m1 =
10181122 let key = fieldLabelModifier opts (selName m1)
10191123 value = gToJSON opts targs (unM1 m1)
1020− in key `gPair` value
1124+ in key `pair` value
10211125{-# INLINE fieldToPair #-}
10221126
10231127--------------------------------------------------------------------------------
@@ -1041,10 +1145,12 @@ instance ( WriteProduct arity a
10411145 lenL = len `unsafeShiftR` 1
10421146 lenR = len - lenL
10431147 ixR = ix + lenL
1148+ {-# INLINE writeProduct #-}
10441149
10451150instance OVERLAPPABLE_ (GToJSON Value arity a) => WriteProduct arity a where
10461151 writeProduct opts targs mv ix _ =
10471152 VM.unsafeWrite mv ix . gToJSON opts targs
1153+ {-# INLINE writeProduct #-}
10481154
10491155--------------------------------------------------------------------------------
10501156
@@ -1062,21 +1168,23 @@ instance ( EncodeProduct arity a
10621168 encodeProduct opts targs (a :*: b) =
10631169 encodeProduct opts targs a >*<
10641170 encodeProduct opts targs b
1171+ {-# INLINE encodeProduct #-}
10651172
10661173instance OVERLAPPABLE_ (GToJSON Encoding arity a) => EncodeProduct arity a where
10671174 encodeProduct opts targs a = E.retagEncoding $ gToJSON opts targs a
1175+ {-# INLINE encodeProduct #-}
10681176
10691177--------------------------------------------------------------------------------
10701178
10711179instance ( GToJSON enc arity a
10721180 , ConsToJSON enc arity a
10731181 , FromPairs enc pairs
1074− , GKeyValue enc pairs
1182+ , KeyValuePair enc pairs
10751183 , Constructor c
10761184 ) => SumToJSON' ObjectWithSingleField enc arity (C1 c a)
10771185 where
10781186 sumToJSON' opts targs =
1079− Tagged . fromPairs . (typ `gPair`) . gToJSON opts targs
1187+ Tagged . fromPairs . (typ `pair`) . gToJSON opts targs
10801188 where
10811189 typ = constructorTagModifier opts $
10821190 conName (undefined :: t c a p)
@@ -1168,6 +1276,13 @@ instance (ToJSON a, ToJSON b) => ToJSON (Either a b) where
11681276 toEncoding = toEncoding2
11691277 {-# INLINE toEncoding #-}
11701278
1279+instance ToJSON Void where
1280+ toJSON = absurd
1281+ {-# INLINE toJSON #-}
1282+
1283+ toEncoding = absurd
1284+ {-# INLINE toEncoding #-}
1285+
11711286
11721287instance ToJSON Bool where
11731288 toJSON = Bool
@@ -1353,7 +1468,6 @@ instance ToJSONKey Int64 where
13531468 toJSONKey = toJSONKeyTextEnc E.int64Text
13541469 {-# INLINE toJSONKey #-}
13551470
1356−
13571471instance ToJSON Word where
13581472 toJSON = Number . fromIntegral
13591473 {-# INLINE toJSON #-}
@@ -1413,6 +1527,12 @@ instance ToJSONKey Word64 where
14131527 toJSONKey = toJSONKeyTextEnc E.word64Text
14141528 {-# INLINE toJSONKey #-}
14151529
1530+instance ToJSON CTime where
1531+ toJSON (CTime i) = toJSON i
1532+ {-# INLINE toJSON #-}
1533+
1534+ toEncoding (CTime i) = toEncoding i
1535+ {-# INLINE toEncoding #-}
14161536
14171537instance ToJSON Text where
14181538 toJSON = String
@@ -1846,6 +1966,32 @@ dotNetTime (DotNetTime t) = secs ++ formatMillis t ++ ")/"
18461966formatMillis :: (FormatTime t) => t -> String
18471967formatMillis = take 3 . formatTime defaultTimeLocale "%q"
18481968
1969+-------------------------------------------------------------------------------
1970+-- primitive
1971+-------------------------------------------------------------------------------
1972+
1973+instance ToJSON a => ToJSON (PM.Array a) where
1974+ -- note: we could do better than this if vector exposed the data
1975+ -- constructor in Data.Vector.
1976+ toJSON = toJSON . Exts.toList
1977+ toEncoding = toEncoding . Exts.toList
1978+
1979+instance ToJSON a => ToJSON (PM.SmallArray a) where
1980+ toJSON = toJSON . Exts.toList
1981+ toEncoding = toEncoding . Exts.toList
1982+
1983+#if (MIN_VERSION_primitive(0,6,4))
1984+instance (PM.Prim a,ToJSON a) => ToJSON (PM.PrimArray a) where
1985+ toJSON = toJSON . Exts.toList
1986+ toEncoding = toEncoding . Exts.toList
1987+
1988+#if !MIN_VERSION_primitive(0,7,0)
1989+instance (PM.PrimUnlifted a,ToJSON a) => ToJSON (PM.UnliftedArray a) where
1990+ toJSON = toJSON . Exts.toList
1991+ toEncoding = toEncoding . Exts.toList
1992+#endif
1993+#endif
1994+
18491995-------------------------------------------------------------------------------
18501996-- time
18511997-------------------------------------------------------------------------------
@@ -1894,10 +2040,11 @@ stringEncoding :: Encoding' Text -> Value
18942040stringEncoding = String
18952041 . T.dropAround (== '"')
18962042 . T.decodeLatin1
1897− . lazyToStrictByteString
2043+ . L.toStrict
18982044 . E.encodingToLazyByteString
18992045{-# INLINE stringEncoding #-}
19002046
2047+
19012048instance ToJSON NominalDiffTime where
19022049 toJSON = Number . realToFrac
19032050 {-# INLINE toJSON #-}
@@ -1905,6 +2052,58 @@ instance ToJSON NominalDiffTime where
19052052 toEncoding = E.scientific . realToFrac
19062053 {-# INLINE toEncoding #-}
19072054
2055+
2056+instance ToJSON DiffTime where
2057+ toJSON = Number . realToFrac
2058+ {-# INLINE toJSON #-}
2059+
2060+ toEncoding = E.scientific . realToFrac
2061+ {-# INLINE toEncoding #-}
2062+
2063+-- | Encoded as number
2064+instance ToJSON SystemTime where
2065+ toJSON (MkSystemTime secs nsecs) =
2066+ toJSON (fromIntegral secs + fromIntegral nsecs / 1000000000 :: Nano)
2067+ toEncoding (MkSystemTime secs nsecs) =
2068+ toEncoding (fromIntegral secs + fromIntegral nsecs / 1000000000 :: Nano)
2069+
2070+instance ToJSON CalendarDiffTime where
2071+ toJSON (CalendarDiffTime m nt) = object
2072+ [ "months" .= m
2073+ , "time" .= nt
2074+ ]
2075+ toEncoding (CalendarDiffTime m nt) = E.pairs
2076+ ("months" .= m <> "time" .= nt)
2077+
2078+instance ToJSON CalendarDiffDays where
2079+ toJSON (CalendarDiffDays m d) = object
2080+ [ "months" .= m
2081+ , "days" .= d
2082+ ]
2083+ toEncoding (CalendarDiffDays m d) = E.pairs
2084+ ("months" .= m <> "days" .= d)
2085+
2086+instance ToJSON DayOfWeek where
2087+ toJSON Monday = "monday"
2088+ toJSON Tuesday = "tuesday"
2089+ toJSON Wednesday = "wednesday"
2090+ toJSON Thursday = "thursday"
2091+ toJSON Friday = "friday"
2092+ toJSON Saturday = "saturday"
2093+ toJSON Sunday = "sunday"
2094+
2095+toEncodingDayOfWeek :: DayOfWeek -> E.Encoding' Text
2096+toEncodingDayOfWeek Monday = E.unsafeToEncoding "\"monday\""
2097+toEncodingDayOfWeek Tuesday = E.unsafeToEncoding "\"tuesday\""
2098+toEncodingDayOfWeek Wednesday = E.unsafeToEncoding "\"wednesday\""
2099+toEncodingDayOfWeek Thursday = E.unsafeToEncoding "\"thursday\""
2100+toEncodingDayOfWeek Friday = E.unsafeToEncoding "\"friday\""
2101+toEncodingDayOfWeek Saturday = E.unsafeToEncoding "\"saturday\""
2102+toEncodingDayOfWeek Sunday = E.unsafeToEncoding "\"sunday\""
2103+
2104+instance ToJSONKey DayOfWeek where
2105+ toJSONKey = toJSONKeyTextEnc toEncodingDayOfWeek
2106+
19082107-------------------------------------------------------------------------------
19092108-- base Monoid/Semigroup
19102109-------------------------------------------------------------------------------
@@ -2648,47 +2847,26 @@ instance (ToJSON a, ToJSON b, ToJSON c, ToJSON d, ToJSON e, ToJSON f, ToJSON g,
26482847 toEncoding = toEncoding2
26492848 {-# INLINE toEncoding #-}
26502849
2651−-------------------------------------------------------------------------------
2652−-- pre-bytestring-0.10 compatibility
2653−-------------------------------------------------------------------------------
2654−
2655−{-# INLINE lazyToStrictByteString #-}
2656−lazyToStrictByteString :: L.ByteString -> S.ByteString
2657−#if MIN_VERSION_bytestring(0,10,0)
2658−lazyToStrictByteString = L.toStrict
2659−#else
2660−lazyToStrictByteString = packChunks
2661−
2662−-- packChunks is taken from the blaze-builder package.
2663−
2664−-- | Pack the chunks of a lazy bytestring into a single strict bytestring.
2665−packChunks :: L.ByteString -> S.ByteString
2666−packChunks lbs =
2667− S.unsafeCreate (fromIntegral $ L.length lbs) (copyChunks lbs)
2668− where
2669− copyChunks L.Empty _pf = return ()
2670− copyChunks (L.Chunk (S.PS fpbuf o l) lbs') pf = do
2671− withForeignPtr fpbuf $ \pbuf ->
2672− copyBytes pf (pbuf `plusPtr` o) l
2673− copyChunks lbs' (pf `plusPtr` l)
2674−#endif
2675−
26762850--------------------------------------------------------------------------------
26772851
2852+-- | Wrap a list of pairs as an object.
26782853class Monoid pairs => FromPairs enc pairs | enc -> pairs where
26792854 fromPairs :: pairs -> enc
26802855
2681−instance FromPairs Encoding Series where
2856+instance (a ~ Value) => FromPairs (Encoding' a) Series where
26822857 fromPairs = E.pairs
26832858
26842859instance FromPairs Value (DList Pair) where
26852860 fromPairs = object . toList
26862861
2687−class Monoid kv => GKeyValue v kv where
2688− gPair :: String -> v -> kv
2862+-- | Like 'KeyValue' but the value is already converted to JSON
2863+-- ('Value' or 'Encoding'), and the result actually represents lists of pairs
2864+-- so it can be readily concatenated.
2865+class Monoid kv => KeyValuePair v kv where
2866+ pair :: String -> v -> kv
26892867
2690−instance ToJSON v => GKeyValue v (DList Pair) where
2691− gPair k v = DList.singleton (pack k .= v)
2868+instance (v ~ Value) => KeyValuePair v (DList Pair) where
2869+ pair k v = DList.singleton (pack k .= v)
26922870
2693−instance GKeyValue Encoding Series where
2694− gPair = E.pairStr
2871+instance (e ~ Encoding) => KeyValuePair e Series where
2872+ pair = E.pairStr
HLint.hsdeleted−10
@@ -1,10 +0,0 @@
1−module HLint.HLint where
2−
3−import "hint" HLint.Default
4−import "hint" HLint.Builtin.All
5−import "hint" HLint.Dollar
6−
7−ignore "Avoid lambda"
8−ignore "Eta reduce"
9−ignore "Functor law"
10−ignore "Use >=>"
Makefile+1−1
@@ -1,2 +1,2 @@
11lint:
2− hlint --cpp-include include/ --cpp-file .stack-work/dist/*/*Cabal-*/build/autogen/cabal_macros.h .
2+ ./run-hlint.sh --cpp-include include/ --cpp-file travis/cabal_macros.h Data/ attoparsec-iso8601/ benchmarks/ examples/ ffi/ pure/ tests/
README.markdown+1−2
@@ -24,5 +24,4 @@ See what's changed in recent (and upcoming) releases:
2424
2525# Authors
2626
27−This library is written and maintained by Bryan O'Sullivan,
28−<bos@serpentine.com>.
27+This library was originally written by Bryan O'Sullivan.
aeson.cabal+69−54
@@ -1,5 +1,5 @@
11name: aeson
2−version: 1.1.2.0
2+version: 1.4.6.0
33license: BSD3
44license-file: LICENSE
55category: Text, Web, JSON
@@ -21,20 +21,6 @@ description:
2121 To get started, see the documentation for the @Data.Aeson@ module
2222 below.
2323 .
24− Parsing performance on a late 2013 MacBook Pro (2.6GHz Core i7),
25− running 64-bit GHC 7.10.1, for mostly-English tweets from Twitter's
26− JSON search API:
27− .
28− * 6.4 KB payloads, English: 7570 msg\/sec (47.6 MB\/sec)
29− .
30− * 14.6 KB payloads, Japanese: 3261 msg\/sec (46.6 MB\/sec)
31− .
32− Encoding performance on the same machine and data:
33− .
34− * 6.4 KB payloads, English: 22738 msg\/sec (142.9 MB\/sec)
35− .
36− * 14.6 KB payloads, Japanese: 15911 msg\/sec (227.4 MB\/sec)
37− .
3824 (A note on naming: in Greek mythology, Aeson was the father of Jason.)
3925
4026extra-source-files:
@@ -56,6 +42,7 @@ extra-source-files:
5642 include/*.h
5743 tests/JSONTestSuite/test_parsing/*.json
5844 tests/JSONTestSuite/test_transform/*.json
45+ tests/golden/*.expected
5946 pure/Data/Aeson/Parser/*.hs
6047
6148flag developer
@@ -80,7 +67,7 @@ flag cffi
8067
8168library
8269 default-language: Haskell2010
83− hs-source-dirs: .
70+ hs-source-dirs: . attoparsec-iso8601/
8471
8572 exposed-modules:
8673 Data.Aeson
@@ -89,10 +76,12 @@ library
8976 Data.Aeson.Text
9077 Data.Aeson.Types
9178 Data.Aeson.TH
79+ Data.Aeson.QQ.Simple
9280
9381 Data.Aeson.Encoding.Internal
9482 Data.Aeson.Internal
9583 Data.Aeson.Internal.Time
84+ Data.Aeson.Parser.Internal
9685
9786 -- Deprecated modules
9887 exposed-modules:
@@ -101,7 +90,6 @@ library
10190 other-modules:
10291 Data.Aeson.Encoding.Builder
10392 Data.Aeson.Internal.Functions
104− Data.Aeson.Parser.Internal
10593 Data.Aeson.Parser.Unescape
10694 Data.Aeson.Parser.Time
10795 Data.Aeson.Types.FromJSON
@@ -109,43 +97,62 @@ library
10997 Data.Aeson.Types.ToJSON
11098 Data.Aeson.Types.Class
11199 Data.Aeson.Types.Internal
100+ Data.Attoparsec.Time
101+ Data.Attoparsec.Time.Internal
112102
103+ -- GHC bundled libs
113104 build-depends:
114− attoparsec >= 0.13.0.1,
115− base >= 4.5 && < 5,
116− base-compat >= 0.9.1 && < 0.10,
117− containers >= 0.4.2,
118− deepseq >= 1.3 && < 1.5,
119− dlist >= 0.6,
120− ghc-prim >= 0.2,
121− hashable >= 1.1.2.0,
122− scientific >= 0.3.4.7 && < 0.4,
123− tagged >=0.8.3 && <0.9,
124− template-haskell >= 2.7,
125− text >= 1.1.1.0,
126− time >= 1.1.1.4,
127− time-locale-compat >= 0.1.1 && < 0.2,
128− unordered-containers >= 0.2.5.0 && < 0.3,
129− uuid-types >= 1.0.3 && <1.1,
130− vector >= 0.8
105+ base >= 4.7.0.0 && < 5,
106+ bytestring >= 0.10.4.0 && < 0.11,
107+ containers >= 0.5.5.1 && < 0.7,
108+ deepseq >= 1.3.0.0 && < 1.5,
109+ ghc-prim >= 0.2 && < 0.6,
110+ template-haskell >= 2.9.0.0 && < 2.16,
111+ text >= 1.2.3.0 && < 1.3,
112+ time >= 1.4 && < 1.10
131113
132− if flag(bytestring-builder)
133− build-depends: bytestring >= 0.9.2 && < 0.10.4,
134− bytestring-builder >= 0.10.4 && < 1
135− else
136− build-depends: bytestring >= 0.10.4 && < 0.11
114+ if impl(ghc >= 8.0)
115+ build-depends: bytestring >= 0.10.8.1
116+
117+ -- Compat
118+ build-depends:
119+ base-compat >= 0.9.1 && < 0.12,
120+ time-compat >= 1.9.2.2 && < 1.10
121+
122+ if !impl(ghc >= 8.6)
123+ build-depends:
124+ contravariant >=1.4.1 && <1.6
137125
138126 if !impl(ghc >= 8.0)
139127 -- `Data.Semigroup` and `Control.Monad.Fail` and `Control.Monad.IO.Class` are available in base only since GHC 8.0 / base 4.9
140128 build-depends:
141− semigroups >= 0.18.2 && < 0.19,
142− transformers >= 0.2.2.0,
143− transformers-compat >= 0.3,
129+ semigroups >= 0.18.5 && < 0.20,
130+ transformers >= 0.3.0.0 && < 0.6,
131+ transformers-compat >= 0.6.2 && < 0.7,
144132 fail == 4.9.*
145133
146134 if !impl(ghc >= 7.10)
147135 -- `Numeric.Natural` is available in base only since GHC 7.10 / base 4.8
148− build-depends: nats >= 1 && < 1.2
136+ build-depends: nats >= 1.1.1 && < 1.2,
137+ void >= 0.7.2 && < 0.8
138+
139+ -- cannot use latest version
140+ build-depends:
141+ unordered-containers >= 0.2.8.0 && < 0.3,
142+
143+ -- not in LTS-12.10
144+ tagged >= 0.8.5 && < 0.9,
145+ primitive >= 0.6.3.0 && < 0.8
146+
147+ -- Other dependencies
148+ build-depends:
149+ attoparsec >= 0.13.2.2 && < 0.14,
150+ dlist >= 0.8.0.4 && < 0.9,
151+ hashable >= 1.2.7.0 && < 1.4,
152+ scientific >= 0.3.6.2 && < 0.4,
153+ th-abstraction >= 0.2.8.0 && < 0.4,
154+ uuid-types >= 1.0.3 && < 1.1,
155+ vector >= 0.12.0.1 && < 0.13
149156
150157 ghc-options: -Wall
151158
@@ -188,42 +195,49 @@ test-suite tests
188195 Functions
189196 Instances
190197 Options
198+ PropUtils
191199 Properties
200+ PropertyGeneric
201+ PropertyKeys
202+ PropertyRoundTrip
203+ PropertyRTFunctors
204+ PropertyTH
192205 SerializationFormatSpec
193206 Types
194207 UnitTests
195208 UnitTests.NullaryConstructors
196209
197210 build-depends:
198− HUnit,
199− QuickCheck >= 2.8 && <2.9.3,
211+ QuickCheck >= 2.10.0.1 && < 2.14,
200212 aeson,
201213 integer-logarithms >= 1 && <1.1,
202214 attoparsec,
203215 base,
204216 base-compat,
205− base-orphans >= 0.5.3 && <0.6,
217+ base-orphans >= 0.5.3 && <0.9,
206218 base16-bytestring,
207219 containers,
208220 directory,
209221 dlist,
222+ Diff >= 0.4 && < 0.5,
210223 filepath,
211− generic-deriving >= 1.10 && < 1.12,
224+ generic-deriving >= 1.10 && < 1.14,
212225 ghc-prim >= 0.2,
213226 hashable >= 1.2.4.0,
214227 scientific,
215228 tagged,
216229 template-haskell,
217− test-framework,
218− test-framework-hunit,
219− test-framework-quickcheck2,
230+ tasty,
231+ tasty-golden,
232+ tasty-hunit,
233+ tasty-quickcheck,
220234 text,
221235 time,
222− time-locale-compat,
236+ time-compat,
223237 unordered-containers,
224238 uuid-types,
225239 vector,
226− quickcheck-instances >=0.3.12
240+ quickcheck-instances >= 0.3.21 && <0.4
227241
228242 if flag(bytestring-builder)
229243 build-depends: bytestring >= 0.9 && < 0.10.4,
@@ -233,12 +247,13 @@ test-suite tests
233247
234248 if !impl(ghc >= 8.0)
235249 build-depends:
236− semigroups >= 0.18.2 && < 0.19,
250+ semigroups >= 0.18.2 && < 0.20,
237251 transformers >= 0.2.2.0,
238252 transformers-compat >= 0.3
239253
240254 if !impl(ghc >= 7.10)
241− build-depends: nats >=1 && <1.2
255+ build-depends: nats >=1 && <1.2,
256+ void >=0.7.2 && <0.8
242257
243258 if impl(ghc >= 7.8)
244259 build-depends: hashable-time >= 0.2 && <0.3
attoparsec-iso8601/Data/Attoparsec/Time.hsnew file+148
@@ -0,0 +1,148 @@
1+{-# LANGUAGE BangPatterns #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
3+{-# LANGUAGE ScopedTypeVariables #-}
4+-- |
5+-- Module: Data.Aeson.Parser.Time
6+-- Copyright: (c) 2015-2016 Bryan O'Sullivan
7+-- License: BSD3
8+-- Maintainer: Bryan O'Sullivan <bos@serpentine.com>
9+-- Stability: experimental
10+-- Portability: portable
11+--
12+-- Parsers for parsing dates and times.
13+
14+module Data.Attoparsec.Time
15+ (
16+ day
17+ , localTime
18+ , timeOfDay
19+ , timeZone
20+ , utcTime
21+ , zonedTime
22+ ) where
23+
24+import Prelude.Compat
25+
26+import Control.Applicative ((<|>))
27+import Control.Monad (void, when)
28+import Data.Attoparsec.Text as A
29+import Data.Attoparsec.Time.Internal (toPico)
30+import Data.Bits ((.&.))
31+import Data.Char (isDigit, ord)
32+import Data.Fixed (Pico)
33+import Data.Int (Int64)
34+import Data.Maybe (fromMaybe)
35+import Data.Time.Calendar (Day, fromGregorianValid)
36+import Data.Time.Clock (UTCTime(..))
37+import qualified Data.Text as T
38+import qualified Data.Time.LocalTime as Local
39+
40+-- | Parse a date of the form @[+,-]YYYY-MM-DD@.
41+day :: Parser Day
42+day = do
43+ absOrNeg <- negate <$ char '-' <|> id <$ char '+' <|> pure id
44+ y <- (decimal <* char '-') <|> fail "date must be of form [+,-]YYYY-MM-DD"
45+ m <- (twoDigits <* char '-') <|> fail "date must be of form [+,-]YYYY-MM-DD"
46+ d <- twoDigits <|> fail "date must be of form [+,-]YYYY-MM-DD"
47+ maybe (fail "invalid date") return (fromGregorianValid (absOrNeg y) m d)
48+
49+-- | Parse a two-digit integer (e.g. day of month, hour).
50+twoDigits :: Parser Int
51+twoDigits = do
52+ a <- digit
53+ b <- digit
54+ let c2d c = ord c .&. 15
55+ return $! c2d a * 10 + c2d b
56+
57+-- | Parse a time of the form @HH:MM[:SS[.SSS]]@.
58+timeOfDay :: Parser Local.TimeOfDay
59+timeOfDay = do
60+ h <- twoDigits
61+ m <- char ':' *> twoDigits
62+ s <- option 0 (char ':' *> seconds)
63+ if h < 24 && m < 60 && s < 61
64+ then return (Local.TimeOfDay h m s)
65+ else fail "invalid time"
66+
67+data T = T {-# UNPACK #-} !Int {-# UNPACK #-} !Int64
68+
69+-- | Parse a count of seconds, with the integer part being two digits
70+-- long.
71+seconds :: Parser Pico
72+seconds = do
73+ real <- twoDigits
74+ mc <- peekChar
75+ case mc of
76+ Just '.' -> do
77+ t <- anyChar *> takeWhile1 isDigit
78+ return $! parsePicos real t
79+ _ -> return $! fromIntegral real
80+ where
81+ parsePicos a0 t = toPico (fromIntegral (t' * 10^n))
82+ where T n t' = T.foldl' step (T 12 (fromIntegral a0)) t
83+ step ma@(T m a) c
84+ | m <= 0 = ma
85+ | otherwise = T (m-1) (10 * a + fromIntegral (ord c) .&. 15)
86+
87+-- | Parse a time zone, and return 'Nothing' if the offset from UTC is
88+-- zero. (This makes some speedups possible.)
89+timeZone :: Parser (Maybe Local.TimeZone)
90+timeZone = do
91+ let maybeSkip c = do ch <- peekChar'; when (ch == c) (void anyChar)
92+ maybeSkip ' '
93+ ch <- satisfy $ \c -> c == 'Z' || c == '+' || c == '-'
94+ if ch == 'Z'
95+ then return Nothing
96+ else do
97+ h <- twoDigits
98+ mm <- peekChar
99+ m <- case mm of
100+ Just ':' -> anyChar *> twoDigits
101+ Just d | isDigit d -> twoDigits
102+ _ -> return 0
103+ let off | ch == '-' = negate off0
104+ | otherwise = off0
105+ off0 = h * 60 + m
106+ case undefined of
107+ _ | off == 0 ->
108+ return Nothing
109+ | off < -720 || off > 840 || m > 59 ->
110+ fail "invalid time zone offset"
111+ | otherwise ->
112+ let !tz = Local.minutesToTimeZone off
113+ in return (Just tz)
114+
115+-- | Parse a date and time, of the form @YYYY-MM-DD HH:MM[:SS[.SSS]]@.
116+-- The space may be replaced with a @T@. The number of seconds is optional
117+-- and may be followed by a fractional component.
118+localTime :: Parser Local.LocalTime
119+localTime = Local.LocalTime <$> day <* daySep <*> timeOfDay
120+ where daySep = satisfy (\c -> c == 'T' || c == ' ')
121+
122+-- | Behaves as 'zonedTime', but converts any time zone offset into a
123+-- UTC time.
124+utcTime :: Parser UTCTime
125+utcTime = do
126+ lt@(Local.LocalTime d t) <- localTime
127+ mtz <- timeZone
128+ case mtz of
129+ Nothing -> let !tt = Local.timeOfDayToTime t
130+ in return (UTCTime d tt)
131+ Just tz -> return $! Local.localTimeToUTC tz lt
132+
133+-- | Parse a date with time zone info. Acceptable formats:
134+--
135+-- @YYYY-MM-DD HH:MM Z@
136+-- @YYYY-MM-DD HH:MM:SS Z@
137+-- @YYYY-MM-DD HH:MM:SS.SSS Z@
138+--
139+-- The first space may instead be a @T@, and the second space is
140+-- optional. The @Z@ represents UTC. The @Z@ may be replaced with a
141+-- time zone offset of the form @+0000@ or @-08:00@, where the first
142+-- two digits are hours, the @:@ is optional and the second two digits
143+-- (also optional) are minutes.
144+zonedTime :: Parser Local.ZonedTime
145+zonedTime = Local.ZonedTime <$> localTime <*> (fromMaybe utc <$> timeZone)
146+
147+utc :: Local.TimeZone
148+utc = Local.TimeZone 0 False ""
attoparsec-iso8601/Data/Attoparsec/Time/Internal.hsnew file+64
@@ -0,0 +1,64 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
3+-- |
4+-- Module: Data.Aeson.Internal.Time
5+-- Copyright: (c) 2015-2016 Bryan O'Sullivan
6+-- License: BSD3
7+-- Maintainer: Bryan O'Sullivan <bos@serpentine.com>
8+-- Stability: experimental
9+-- Portability: portable
10+
11+module Data.Attoparsec.Time.Internal
12+ (
13+ TimeOfDay64(..)
14+ , fromPico
15+ , toPico
16+ , diffTimeOfDay64
17+ , toTimeOfDay64
18+ ) where
19+
20+import Prelude.Compat
21+
22+import Data.Int (Int64)
23+import Data.Time
24+import Unsafe.Coerce (unsafeCoerce)
25+
26+#if MIN_VERSION_time(1,6,0)
27+
28+import Data.Time.Clock (diffTimeToPicoseconds)
29+
30+#endif
31+
32+import Data.Fixed (Pico, Fixed(MkFixed))
33+
34+#if !MIN_VERSION_time(1,6,0)
35+
36+diffTimeToPicoseconds :: DiffTime -> Integer
37+diffTimeToPicoseconds = unsafeCoerce
38+
39+#endif
40+
41+toPico :: Integer -> Pico
42+toPico = MkFixed
43+
44+fromPico :: Pico -> Integer
45+fromPico (MkFixed i) = i
46+
47+-- | Like TimeOfDay, but using a fixed-width integer for seconds.
48+data TimeOfDay64 = TOD {-# UNPACK #-} !Int
49+ {-# UNPACK #-} !Int
50+ {-# UNPACK #-} !Int64
51+
52+posixDayLength :: DiffTime
53+posixDayLength = 86400
54+
55+diffTimeOfDay64 :: DiffTime -> TimeOfDay64
56+diffTimeOfDay64 t
57+ | t >= posixDayLength = TOD 23 59 (60000000000000 + pico (t - posixDayLength))
58+ | otherwise = TOD (fromIntegral h) (fromIntegral m) s
59+ where (h,mp) = pico t `quotRem` 3600000000000000
60+ (m,s) = mp `quotRem` 60000000000000
61+ pico = fromIntegral . diffTimeToPicoseconds
62+
63+toTimeOfDay64 :: TimeOfDay -> TimeOfDay64
64+toTimeOfDay64 (TimeOfDay h m s) = TOD h m (fromIntegral (fromPico s))
attoparsec-iso8601/LICENSEnew file+30
@@ -0,0 +1,30 @@
1+Copyright (c) 2011, MailRank, Inc.
2+
3+All rights reserved.
4+
5+Redistribution and use in source and binary forms, with or without
6+modification, are permitted provided that the following conditions
7+are met:
8+
9+1. Redistributions of source code must retain the above copyright
10+ notice, this list of conditions and the following disclaimer.
11+
12+2. Redistributions in binary form must reproduce the above copyright
13+ notice, this list of conditions and the following disclaimer in the
14+ documentation and/or other materials provided with the distribution.
15+
16+3. Neither the name of the author nor the names of his contributors
17+ may be used to endorse or promote products derived from this software
18+ without specific prior written permission.
19+
20+THIS SOFTWARE IS PROVIDED BY THE CONTRIBUTORS ``AS IS'' AND ANY EXPRESS
21+OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
22+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
23+DISCLAIMED. IN NO EVENT SHALL THE AUTHORS OR CONTRIBUTORS BE LIABLE FOR
24+ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
25+DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
26+OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
27+HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
28+STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
29+ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
30+POSSIBILITY OF SUCH DAMAGE.
attoparsec-iso8601/README.mdnew file+19
@@ -0,0 +1,19 @@
1+Parsing of ISO 8601 dates.
2+
3+This package is used to parse dates in aeson. It is split into a
4+separate package to be shared by other projects that want to parse
5+dates like aeson does.
6+
7+For now, this project is located in the aeson repository and aeson
8+itself uses the source of this package without pulling in the package
9+as a dependency.
10+
11+## Stability
12+
13+Since aeson depends on this package we want to be very careful about
14+changing the format.
15+
16+There may be breaking changes if we find that the format is
17+incorrectly too lenient. We consider widening of the allowed input a
18+non-breaking addition since all previously valid input will still
19+parse correctly.
attoparsec-iso8601/attoparsec-iso8601.cabalnew file+55
@@ -0,0 +1,55 @@
1+name: attoparsec-iso8601
2+version: 1.0.1.0
3+synopsis: Parsing of ISO 8601 dates, originally from aeson.
4+description: Parsing of ISO 8601 dates, originally from aeson.
5+license: BSD3
6+license-file: LICENSE
7+category: Parsing
8+copyright: (c) 2011-2016 Bryan O'Sullivan
9+ (c) 2011 MailRank, Inc.
10+author: Bryan O'Sullivan <bos@serpentine.com>
11+maintainer: Adam Bergmark <adam@bergmark.nl>
12+stability: experimental
13+cabal-version: >=1.10
14+homepage: https://github.com/bos/aeson
15+bug-reports: https://github.com/bos/aeson/issues
16+build-type: Simple
17+extra-source-files:
18+ README.md
19+
20+flag developer
21+ description: operate in developer mode
22+ default: False
23+ manual: True
24+
25+flag fast
26+ description: compile without optimizations
27+ default: False
28+ manual: True
29+
30+library
31+ hs-source-dirs: .
32+ default-language: Haskell2010
33+ ghc-options: -Wall
34+ exposed-modules:
35+ Data.Attoparsec.Time.Internal
36+ Data.Attoparsec.Time
37+ build-depends:
38+ attoparsec >= 0.13.0.1,
39+ base >= 4.7 && < 5,
40+ base-compat >= 0.9.1 && < 0.12,
41+ text >= 1.1.1.0,
42+ time >= 1.1.1.4
43+
44+ if flag(fast)
45+ ghc-options: -O0
46+ else
47+ ghc-options: -O2
48+
49+ if flag(developer)
50+ ghc-options: -Werror
51+ ghc-prof-options: -auto-all
52+
53+source-repository head
54+ type: git
55+ location: git://github.com/bos/aeson.git
attoparsec-iso8601/changelog.mdnew file+5
@@ -0,0 +1,5 @@
1+For the latest version of this document, please see [https://github.com/bos/aeson/blob/master/attoparsec-iso8601/changelog.md](https://github.com/bos/aeson/blob/master/attoparsec-iso8601/changelog.md).
2+
3+### 1.0.1.0
4+
5+* Fixes handling of `UTCTime` wrt. leap seconds , thanks to Adam Schønemann
benchmarks/AesonCompareAutoInstances.hsdeleted−282
@@ -1,282 +0,0 @@
1−{-# LANGUAGE DeriveGeneric #-}
2−{-# LANGUAGE FlexibleContexts #-}
3−{-# LANGUAGE TemplateHaskell #-}
4−
5−module Main (main) where
6−
7−import Prelude ()
8−import Prelude.Compat
9−
10−import Control.Monad
11−import Control.DeepSeq (NFData, rnf, deepseq)
12−import Criterion.Main hiding (defaultOptions)
13−import Data.Aeson
14−import Data.Aeson.Encoding
15−import Data.Aeson.TH
16−import Data.Aeson.Types
17−import Data.ByteString.Lazy (ByteString)
18−import Data.Data (Data)
19−import Data.Typeable (Typeable)
20−import GHC.Generics (Generic, Rep)
21−import Options
22−
23−toBS :: Encoding -> ByteString
24−toBS = encodingToLazyByteString
25−
26−gEncode :: (Generic a, GToEncoding Zero (Rep a)) => a -> ByteString
27−gEncode = toBS . genericToEncoding opts
28−
29−--------------------------------------------------------------------------------
30−
31−data D a = Nullary
32− | Unary Int
33− | Product String Char a
34− | Record { testOne :: Double
35− , testTwo :: Bool
36− , testThree :: D a
37− }
38− deriving (Show, Eq)
39−
40−deriveJSON opts ''D
41−
42−instance NFData a => NFData (D a) where
43− rnf Nullary = ()
44− rnf (Unary n) = rnf n
45− rnf (Product s c x) = s `deepseq` c `deepseq` rnf x
46− rnf (Record d b y) = d `deepseq` b `deepseq` rnf y
47−
48−type T = D (D (D ()))
49−
50−d :: T
51−d = Record
52− { testOne = 1234.56789
53− , testTwo = True
54− , testThree = Product "Hello World!" 'a'
55− Record
56− { testOne = 9876.54321
57− , testTwo = False
58− , testThree = Product "Yeehaa!!!" '\n' Nullary
59− }
60− }
61−
62−--------------------------------------------------------------------------------
63−
64−data D' a = Nullary'
65− | Unary' Int
66− | Product' String Char a
67− | Record' { testOne' :: Double
68− , testTwo' :: Bool
69− , testThree' :: D' a
70− }
71− deriving (Show, Eq, Generic)
72−
73−instance ToJSON a => ToJSON (D' a) where
74− toJSON = genericToJSON opts
75−
76−instance FromJSON a => FromJSON (D' a) where
77− parseJSON = genericParseJSON opts
78−
79−instance NFData a => NFData (D' a) where
80− rnf Nullary' = ()
81− rnf (Unary' n) = rnf n
82− rnf (Product' s c x) = s `deepseq` c `deepseq` rnf x
83− rnf (Record' d b y) = d `deepseq` b `deepseq` rnf y
84−
85−type T' = D' (D' (D' ()))
86−
87−d' :: T'
88−d' = Record'
89− { testOne' = 1234.56789
90− , testTwo' = True
91− , testThree' = Product' "Hello World!" 'a'
92− Record'
93− { testOne' = 9876.54321
94− , testTwo' = False
95− , testThree' = Product' "Yeehaa!!!" '\n' Nullary'
96− }
97− }
98−
99−--------------------------------------------------------------------------------
100−
101−data BigRecord = BigRecord
102− { field01 :: !Int, field02 :: !Int, field03 :: !Int, field04 :: !Int, field05 :: !Int
103− , field06 :: !Int, field07 :: !Int, field08 :: !Int, field09 :: !Int, field10 :: !Int
104− , field11 :: !Int, field12 :: !Int, field13 :: !Int, field14 :: !Int, field15 :: !Int
105− , field16 :: !Int, field17 :: !Int, field18 :: !Int, field19 :: !Int, field20 :: !Int
106− , field21 :: !Int, field22 :: !Int, field23 :: !Int, field24 :: !Int, field25 :: !Int
107− } deriving (Show, Eq, Generic)
108−
109−instance NFData BigRecord
110−
111−bigRecord = BigRecord 1 2 3 4 5
112− 6 7 8 9 10
113− 11 12 13 14 15
114− 16 17 18 19 20
115− 21 22 23 24 25
116−
117−return []
118−
119−gBigRecordToJSON :: BigRecord -> Value
120−gBigRecordToJSON = genericToJSON opts
121−
122−gBigRecordEncode :: BigRecord -> ByteString
123−gBigRecordEncode = gEncode
124−
125−gBigRecordFromJSON :: Value -> Result BigRecord
126−gBigRecordFromJSON = parse $ genericParseJSON opts
127−
128−thBigRecordToJSON :: BigRecord -> Value
129−thBigRecordToJSON = $(mkToJSON opts ''BigRecord)
130−
131−thBigRecordEncode :: BigRecord -> ByteString
132−thBigRecordEncode = toBS . $(mkToEncoding opts ''BigRecord)
133−
134−thBigRecordFromJSON :: Value -> Result BigRecord
135−thBigRecordFromJSON = parse $(mkParseJSON opts ''BigRecord)
136−
137−--------------------------------------------------------------------------------
138−
139−data BigProduct = BigProduct
140− !Int !Int !Int !Int !Int
141− !Int !Int !Int !Int !Int
142− !Int !Int !Int !Int !Int
143− !Int !Int !Int !Int !Int
144− !Int !Int !Int !Int !Int
145− deriving (Show, Eq, Generic)
146−
147−instance NFData BigProduct
148−
149−bigProduct = BigProduct 1 2 3 4 5
150− 6 7 8 9 10
151− 11 12 13 14 15
152− 16 17 18 19 20
153− 21 22 23 24 25
154−
155−return []
156−
157−gBigProductToJSON :: BigProduct -> Value
158−gBigProductToJSON = genericToJSON opts
159−
160−gBigProductEncode :: BigProduct -> ByteString
161−gBigProductEncode = gEncode
162−
163−gBigProductFromJSON :: Value -> Result BigProduct
164−gBigProductFromJSON = parse $ genericParseJSON opts
165−
166−thBigProductToJSON :: BigProduct -> Value
167−thBigProductToJSON = $(mkToJSON opts ''BigProduct)
168−
169−thBigProductEncode :: BigProduct -> ByteString
170−thBigProductEncode = toBS . $(mkToEncoding opts ''BigProduct)
171−
172−thBigProductFromJSON :: Value -> Result BigProduct
173−thBigProductFromJSON = parse $(mkParseJSON opts ''BigProduct)
174−
175−--------------------------------------------------------------------------------
176−
177−data BigSum = F01 | F02 | F03 | F04 | F05
178− | F06 | F07 | F08 | F09 | F10
179− | F11 | F12 | F13 | F14 | F15
180− | F16 | F17 | F18 | F19 | F20
181− | F21 | F22 | F23 | F24 | F25
182− deriving (Show, Eq, Generic)
183−
184−instance NFData BigSum
185−
186−bigSum = F25
187−
188−return []
189−
190−gBigSumToJSON :: BigSum -> Value
191−gBigSumToJSON = genericToJSON opts
192−
193−gBigSumEncode :: BigSum -> ByteString
194−gBigSumEncode = gEncode
195−
196−gBigSumFromJSON :: Value -> Result BigSum
197−gBigSumFromJSON = parse $ genericParseJSON opts
198−
199−thBigSumToJSON :: BigSum -> Value
200−thBigSumToJSON = $(mkToJSON opts ''BigSum)
201−
202−thBigSumEncode :: BigSum -> ByteString
203−thBigSumEncode = toBS . $(mkToEncoding opts ''BigSum)
204−
205−thBigSumFromJSON :: Value -> Result BigSum
206−thBigSumFromJSON = parse $(mkParseJSON opts ''BigSum)
207−
208−--------------------------------------------------------------------------------
209−
210−type FJ a = Value -> Result a
211−
212−runBench :: IO ()
213−runBench = defaultMain
214− [ let v = toJSON d
215− in (d, d', v) `deepseq`
216− bgroup "D"
217− [ group "toJSON" (nf toJSON d)
218− (nf toJSON d')
219− , group "encode" (nf encode d)
220− (nf encode d')
221− , group "fromJSON" (nf ( fromJSON :: FJ T ) v)
222− (nf ( fromJSON :: FJ T') v)
223− ]
224− , let v = thBigRecordToJSON bigRecord
225− in bigRecord `deepseq` v `deepseq`
226− bgroup "BigRecord"
227− [ group "toJSON" (nf thBigRecordToJSON bigRecord)
228− (nf gBigRecordToJSON bigRecord)
229− , group "encode" (nf thBigRecordEncode bigRecord)
230− (nf gBigRecordEncode bigRecord)
231− , group "fromJSON" (nf (thBigRecordFromJSON :: FJ BigRecord) v)
232− (nf ( gBigRecordFromJSON :: FJ BigRecord) v)
233− ]
234− , let v = thBigProductToJSON bigProduct
235− in bigProduct `deepseq` v `deepseq`
236− bgroup "BigProduct"
237− [ group "toJSON" (nf thBigProductToJSON bigProduct)
238− (nf gBigProductToJSON bigProduct)
239− , group "encode" (nf thBigProductEncode bigProduct)
240− (nf gBigProductEncode bigProduct)
241− , group "fromJSON" (nf (thBigProductFromJSON :: FJ BigProduct) v)
242− (nf (gBigProductFromJSON :: FJ BigProduct) v)
243− ]
244− , let v = thBigSumToJSON bigSum
245− in bigSum `deepseq` v `deepseq`
246− bgroup "BigSum"
247− [ group "toJSON" (nf thBigSumToJSON bigSum)
248− (nf gBigSumToJSON bigSum)
249− , group "encode" (nf thBigSumEncode bigSum)
250− (nf gBigSumEncode bigSum)
251− , group "fromJSON" (nf (thBigSumFromJSON :: FJ BigSum) v)
252− (nf (gBigSumFromJSON :: FJ BigSum) v)
253− ]
254− ]
255−
256−group n th gen = bgroup n [ bench "th" th
257− , bench "generic" gen
258− ]
259−
260−sanityCheck = do
261− check d toJSON fromJSON encode
262− check d' toJSON fromJSON encode
263− check bigRecord thBigRecordToJSON thBigRecordFromJSON thBigRecordEncode
264− check bigRecord gBigRecordToJSON gBigRecordFromJSON gBigRecordEncode
265− check bigProduct thBigProductToJSON thBigProductFromJSON thBigProductEncode
266− check bigProduct gBigProductToJSON gBigProductFromJSON gBigProductEncode
267− check bigSum thBigSumToJSON thBigSumFromJSON thBigSumEncode
268− check bigSum gBigSumToJSON gBigSumFromJSON gBigSumEncode
269−
270−check :: (Show a, Eq a)
271− => a -> (a -> Value) -> (Value -> Result a) -> (a -> ByteString) -> IO ()
272−check x toJSON fromJSON encode = do
273− unless (Success x == (fromJSON . toJSON) x) $ fail $ "toJSON: " ++ show x
274− unless (Success x == (decode' . encode) x) $ fail $ "encode: " ++ show x
275− where
276− decode' s = case decode s of
277− Just v -> fromJSON v
278− Nothing -> fail ""
279−
280−main = do
281− sanityCheck
282− runBench
benchmarks/AesonEncode.hs+2−2
@@ -1,13 +1,13 @@
11{-# LANGUAGE BangPatterns #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
23{-# LANGUAGE OverloadedStrings #-}
34
45module Main (main) where
56
6−import Prelude ()
77import Prelude.Compat
88
99import Control.DeepSeq
10−import Control.Monad
10+import Control.Monad (forM_)
1111import Data.Aeson
1212import Data.Attoparsec.ByteString (IResult(..), parseWith)
1313import Data.Char (isDigit)
benchmarks/AesonFoldable.hs+14−42
@@ -1,16 +1,14 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12{-# LANGUAGE OverloadedStrings #-}
2−{-# LANGUAGE PackageImports #-}
33
44module Main (main) where
55
66import Criterion.Main
77
8−import Prelude ()
98import Prelude.Compat
109
1110import Data.Foldable (toList)
12−import qualified "aeson" Data.Aeson as A
13−import qualified "aeson-benchmarks" Data.Aeson as B
11+import qualified Data.Aeson as A
1412import qualified Data.Sequence as S
1513import qualified Data.Vector as V
1614import qualified Data.Vector.Unboxed as U
@@ -21,10 +19,6 @@ import qualified Data.Vector.Unboxed as U
2119
2220newtype L f = L { getL :: f Int }
2321
24−instance Foldable f => B.ToJSON (L f) where
25− toJSON = error "do not use this"
26− toEncoding = B.toEncoding . toList . getL
27−
2822instance Foldable f => A.ToJSON (L f) where
2923 toJSON = error "do not use this"
3024 toEncoding = A.toEncoding . toList . getL
@@ -35,10 +29,6 @@ instance Foldable f => A.ToJSON (L f) where
3529
3630newtype F f = F { getF :: f Int }
3731
38−instance Foldable f => B.ToJSON (F f) where
39− toJSON = error "do not use this"
40− toEncoding = B.foldable . getF
41−
4232instance Foldable f => A.ToJSON (F f) where
4333 toJSON = error "do not use this"
4434 toEncoding = A.foldable . getF
@@ -63,52 +53,34 @@ valueUVector = U.fromList valueList
6353-- Main
6454-------------------------------------------------------------------------------
6555
66−benchEncodeA
56+benchEncode
6757 :: A.ToJSON a
6858 => String
6959 -> a
7060 -> Benchmark
71−benchEncodeA name val
61+benchEncode name val
7262 = bench ("A " ++ name) $ nf A.encode val
7363
74−benchEncodeB
75− :: B.ToJSON a
76− => String
77− -> a
78− -> Benchmark
79−benchEncodeB name val
80− = bench ("B " ++ name) $ nf B.encode val
81−
8264main :: IO ()
8365main = defaultMain
8466 [ bgroup "encode"
8567 [ bgroup "List"
86− [ benchEncodeB "-" valueList
87− , benchEncodeB "L" $ L valueList
88− , benchEncodeB "F" $ F valueList
89− , benchEncodeA "-" valueList
90− , benchEncodeA "L" $ L valueList
91− , benchEncodeA "F" $ F valueList
68+ [ benchEncode "-" valueList
69+ , benchEncode "L" $ L valueList
70+ , benchEncode "F" $ F valueList
9271 ]
9372 , bgroup "Seq"
94− [ benchEncodeB "-" valueSeq
95− , benchEncodeB "L" $ L valueSeq
96− , benchEncodeB "F" $ F valueSeq
97− , benchEncodeA "-" valueSeq
98− , benchEncodeA "L" $ L valueSeq
99− , benchEncodeA "F" $ F valueSeq
73+ [ benchEncode "-" valueSeq
74+ , benchEncode "L" $ L valueSeq
75+ , benchEncode "F" $ F valueSeq
10076 ]
10177 , bgroup "Vector"
102− [ benchEncodeB "-" valueVector
103− , benchEncodeB "L" $ L valueVector
104− , benchEncodeB "F" $ F valueVector
105− , benchEncodeA "-" valueVector
106− , benchEncodeA "L" $ L valueVector
107− , benchEncodeA "F" $ F valueVector
78+ [ benchEncode "-" valueVector
79+ , benchEncode "L" $ L valueVector
80+ , benchEncode "F" $ F valueVector
10881 ]
10982 , bgroup "Vector.Unboxed"
110− [ benchEncodeB "-" valueUVector
111− , benchEncodeA "-" valueUVector
83+ [ benchEncode "-" valueUVector
11284 ]
11385 ]
11486 ]
benchmarks/AesonMap.hs+39−56
@@ -1,13 +1,11 @@
11{-# LANGUAGE FlexibleContexts #-}
2−{-# LANGUAGE OverloadedStrings #-}
3−{-# LANGUAGE PackageImports #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
43{-# LANGUAGE RankNTypes #-}
54
65{-# OPTIONS_GHC -fno-warn-orphans #-}
76
87module Main (main) where
98
10−import Prelude ()
119import Prelude.Compat
1210
1311import Control.DeepSeq
@@ -15,9 +13,8 @@ import Criterion.Main
1513import Data.Hashable
1614import Data.Proxy (Proxy (..))
1715import Data.Tagged (Tagged (..))
18−import qualified "aeson" Data.Aeson as A
19−import qualified "aeson-benchmarks" Data.Aeson as B
20−import qualified "aeson-benchmarks" Data.Aeson.Types as B (fromJSONKeyCoerce)
16+import Data.Aeson
17+import Data.Aeson.Types (fromJSONKeyCoerce)
2118import qualified Data.ByteString.Lazy as LBS
2219import qualified Data.HashMap.Strict as HM
2320import qualified Data.Map as M
@@ -47,10 +44,10 @@ instance NFData T1 where
4744instance Hashable T1 where
4845 hashWithSalt salt (T1 t) = hashWithSalt salt t
4946
50−instance B.FromJSON T1 where
51− parseJSON = B.withText "T1" $ pure . T1
52−instance B.FromJSONKey T1 where
53− fromJSONKey = B.FromJSONKeyText T1
47+instance FromJSON T1 where
48+ parseJSON = withText "T1" $ pure . T1
49+instance FromJSONKey T1 where
50+ fromJSONKey = FromJSONKeyText T1
5451
5552-------------------------------------------------------------------------------
5653-- Coerce
@@ -64,10 +61,10 @@ instance NFData T2 where
6461instance Hashable T2 where
6562 hashWithSalt salt (T2 t) = hashWithSalt salt t
6663
67−instance B.FromJSON T2 where
68− parseJSON = B.withText "T2" $ pure . T2
69−instance B.FromJSONKey T2 where
70− fromJSONKey = B.fromJSONKeyCoerce
64+instance FromJSON T2 where
65+ parseJSON = withText "T2" $ pure . T2
66+instance FromJSONKey T2 where
67+ fromJSONKey = fromJSONKeyCoerce
7168
7269-------------------------------------------------------------------------------
7370-- TextParser
@@ -81,10 +78,10 @@ instance NFData T3 where
8178instance Hashable T3 where
8279 hashWithSalt salt (T3 t) = hashWithSalt salt t
8380
84−instance B.FromJSON T3 where
85− parseJSON = B.withText "T3" $ pure . T3
86−instance B.FromJSONKey T3 where
87− fromJSONKey = B.FromJSONKeyTextParser (pure . T3)
81+instance FromJSON T3 where
82+ parseJSON = withText "T3" $ pure . T3
83+instance FromJSONKey T3 where
84+ fromJSONKey = FromJSONKeyTextParser (pure . T3)
8885
8986-------------------------------------------------------------------------------
9087-- Values
@@ -97,40 +94,30 @@ value1000 = value 1000
9794value10000 = value 10000
9895
9996encodedValue10 :: LBS.ByteString
100−encodedValue10 = B.encode value10
97+encodedValue10 = encode value10
10198
10299encodedValue100 :: LBS.ByteString
103−encodedValue100 = B.encode value100
100+encodedValue100 = encode value100
104101
105102encodedValue1000 :: LBS.ByteString
106−encodedValue1000 = B.encode value1000
103+encodedValue1000 = encode value1000
107104
108105encodedValue10000 :: LBS.ByteString
109−encodedValue10000 = B.encode value10000
106+encodedValue10000 = encode value10000
110107
111108-------------------------------------------------------------------------------
112109-- Helpers
113110-------------------------------------------------------------------------------
114111
115−decodeHMB
116− :: (B.FromJSONKey k, Eq k, Hashable k)
112+decodeHM
113+ :: (FromJSON (HM.HashMap k T.Text), Eq k, Hashable k)
117114 => Proxy k -> LBS.ByteString -> Maybe (HM.HashMap k T.Text)
118−decodeHMB _ = B.decode
115+decodeHM _ = decode
119116
120−decodeHMA
121− :: (A.FromJSON (HM.HashMap k T.Text), Eq k, Hashable k)
122− => Proxy k -> LBS.ByteString -> Maybe (HM.HashMap k T.Text)
123−decodeHMA _ = A.decode
124−
125−decodeMapB
126− :: (B.FromJSONKey k, Ord k)
127− => Proxy k -> LBS.ByteString -> Maybe (M.Map k T.Text)
128−decodeMapB _ = B.decode
129−
130−decodeMapA
131− :: (A.FromJSON (M.Map k T.Text), Ord k)
117+decodeMap
118+ :: (FromJSON (M.Map k T.Text), Ord k)
132119 => Proxy k -> LBS.ByteString -> Maybe (M.Map k T.Text)
133−decodeMapA _ = A.decode
120+decodeMap _ = decode
134121
135122proxyText :: Proxy T.Text
136123proxyText = Proxy
@@ -156,15 +143,14 @@ benchDecodeHM
156143 -> LBS.ByteString
157144 -> Benchmark
158145benchDecodeHM name val = bgroup name
159− [ bench "Text" $ nf (decodeHMB proxyText) val
160− , bench "Identity" $ nf (decodeHMB proxyT1) val
161− , bench "Coerce" $ nf (decodeHMB proxyT2) val
162− , bench "Parser" $ nf (decodeHMB proxyT3) val
163− , bench "aeson-0.11" $ nf (decodeHMA proxyText) val
164− , bench "Tagged Text" $ nf (decodeHMB $ proxyTagged proxyText) val
165− , bench "Tagged Identity" $ nf (decodeHMB $ proxyTagged proxyT1) val
166− , bench "Tagged Coerce" $ nf (decodeHMB $ proxyTagged proxyT2) val
167− , bench "Tagged Parser" $ nf (decodeHMB $ proxyTagged proxyT3) val
146+ [ bench "Text" $ nf (decodeHM proxyText) val
147+ , bench "Identity" $ nf (decodeHM proxyT1) val
148+ , bench "Coerce" $ nf (decodeHM proxyT2) val
149+ , bench "Parser" $ nf (decodeHM proxyT3) val
150+ , bench "Tagged Text" $ nf (decodeHM $ proxyTagged proxyText) val
151+ , bench "Tagged Identity" $ nf (decodeHM $ proxyTagged proxyT1) val
152+ , bench "Tagged Coerce" $ nf (decodeHM $ proxyTagged proxyT2) val
153+ , bench "Tagged Parser" $ nf (decodeHM $ proxyTagged proxyT3) val
168154 ]
169155
170156benchDecodeMap
@@ -172,11 +158,10 @@ benchDecodeMap
172158 -> LBS.ByteString
173159 -> Benchmark
174160benchDecodeMap name val = bgroup name
175− [ bench "Text" $ nf (decodeMapB proxyText) val
176− , bench "Identity" $ nf (decodeMapB proxyT1) val
177− , bench "Coerce" $ nf (decodeMapB proxyT2) val
178− , bench "Parser" $ nf (decodeMapB proxyT3) val
179− , bench "aeson-0.11" $ nf (decodeMapA proxyText) val
161+ [ bench "Text" $ nf (decodeMap proxyText) val
162+ , bench "Identity" $ nf (decodeMap proxyT1) val
163+ , bench "Coerce" $ nf (decodeMap proxyT2) val
164+ , bench "Parser" $ nf (decodeMap proxyT3) val
180165 ]
181166
182167benchEncodeHM
@@ -184,8 +169,7 @@ benchEncodeHM
184169 -> HM.HashMap T.Text T.Text
185170 -> Benchmark
186171benchEncodeHM name val = bgroup name
187− [ bench "Text" $ nf B.encode val
188− , bench "aeson-0.11" $ nf A.encode val
172+ [ bench "Text" $ nf encode val
189173 ]
190174
191175benchEncodeMap
@@ -193,8 +177,7 @@ benchEncodeMap
193177 -> HM.HashMap T.Text T.Text
194178 -> Benchmark
195179benchEncodeMap name val = bgroup name
196− [ bench "Text" $ nf B.encode val'
197− , bench "aeson-0.11" $ nf A.encode val'
180+ [ bench "Text" $ nf encode val'
198181 ]
199182 where
200183 val' :: M.Map T.Text T.Text
benchmarks/AesonParse.hs+2−3
@@ -1,13 +1,12 @@
11{-# LANGUAGE BangPatterns #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
23{-# LANGUAGE OverloadedStrings #-}
3−{-# LANGUAGE PackageImports #-}
44
55module Main (main) where
66
7−import Prelude ()
87import Prelude.Compat
98
10−import "aeson-benchmarks" Data.Aeson
9+import Data.Aeson
1110import Control.Monad
1211import Data.Attoparsec.ByteString (IResult(..), parseWith)
1312import Data.Time.Clock
benchmarks/AesonTuples.hs+2−1
@@ -1,6 +1,7 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
13module Main (main) where
24
3−import Prelude ()
45import Prelude.Compat
56
67import Control.DeepSeq (deepseq)
benchmarks/Auto/G/BigProduct.hsnew file+33
@@ -0,0 +1,33 @@
1+{-# LANGUAGE DeriveGeneric #-}
2+
3+module Auto.G.BigProduct where
4+
5+import Control.DeepSeq
6+import Data.Aeson
7+import GHC.Generics (Generic)
8+import Options
9+
10+data BigProduct = BigProduct
11+ !Int !Int !Int !Int !Int
12+ !Int !Int !Int !Int !Int
13+ !Int !Int !Int !Int !Int
14+ !Int !Int !Int !Int !Int
15+ !Int !Int !Int !Int !Int
16+ deriving (Show, Eq, Generic)
17+
18+instance NFData BigProduct where
19+ rnf a = a `seq` ()
20+
21+instance ToJSON BigProduct where
22+ toJSON = genericToJSON opts
23+ toEncoding = genericToEncoding opts
24+
25+instance FromJSON BigProduct where
26+ parseJSON = genericParseJSON opts
27+
28+bigProduct :: BigProduct
29+bigProduct = BigProduct 1 2 3 4 5
30+ 6 7 8 9 10
31+ 11 12 13 14 15
32+ 16 17 18 19 20
33+ 21 22 23 24 25
benchmarks/Auto/G/BigRecord.hsnew file+33
@@ -0,0 +1,33 @@
1+{-# LANGUAGE DeriveGeneric #-}
2+
3+module Auto.G.BigRecord where
4+
5+import Control.DeepSeq
6+import Data.Aeson
7+import GHC.Generics (Generic)
8+import Options
9+
10+data BigRecord = BigRecord
11+ { field01 :: !Int, field02 :: !Int, field03 :: !Int, field04 :: !Int, field05 :: !Int
12+ , field06 :: !Int, field07 :: !Int, field08 :: !Int, field09 :: !Int, field10 :: !Int
13+ , field11 :: !Int, field12 :: !Int, field13 :: !Int, field14 :: !Int, field15 :: !Int
14+ , field16 :: !Int, field17 :: !Int, field18 :: !Int, field19 :: !Int, field20 :: !Int
15+ , field21 :: !Int, field22 :: !Int, field23 :: !Int, field24 :: !Int, field25 :: !Int
16+ } deriving (Show, Eq, Generic)
17+
18+instance NFData BigRecord where
19+ rnf a = a `seq` ()
20+
21+instance ToJSON BigRecord where
22+ toJSON = genericToJSON opts
23+ toEncoding = genericToEncoding opts
24+
25+instance FromJSON BigRecord where
26+ parseJSON = genericParseJSON opts
27+
28+bigRecord :: BigRecord
29+bigRecord = BigRecord 1 2 3 4 5
30+ 6 7 8 9 10
31+ 11 12 13 14 15
32+ 16 17 18 19 20
33+ 21 22 23 24 25
benchmarks/Auto/G/BigSum.hsnew file+28
@@ -0,0 +1,28 @@
1+{-# LANGUAGE DeriveGeneric #-}
2+
3+module Auto.G.BigSum where
4+
5+import Control.DeepSeq
6+import Data.Aeson
7+import GHC.Generics (Generic)
8+import Options
9+
10+data BigSum = F01 | F02 | F03 | F04 | F05
11+ | F06 | F07 | F08 | F09 | F10
12+ | F11 | F12 | F13 | F14 | F15
13+ | F16 | F17 | F18 | F19 | F20
14+ | F21 | F22 | F23 | F24 | F25
15+ deriving (Show, Eq, Generic)
16+
17+instance NFData BigSum where
18+ rnf a = a `seq` ()
19+
20+instance ToJSON BigSum where
21+ toJSON = genericToJSON opts
22+ toEncoding = genericToEncoding opts
23+
24+instance FromJSON BigSum where
25+ parseJSON = genericParseJSON opts
26+
27+bigSum :: BigSum
28+bigSum = F25
benchmarks/Auto/G/D.hsnew file+44
@@ -0,0 +1,44 @@
1+{-# LANGUAGE DeriveGeneric #-}
2+
3+module Auto.G.D where
4+
5+import Control.DeepSeq
6+import Data.Aeson
7+import GHC.Generics (Generic)
8+import Options
9+
10+data D a = Nullary
11+ | Unary Int
12+ | Product String Char a
13+ | Record { testOne :: Double
14+ , testTwo :: Bool
15+ , testThree :: D a
16+ }
17+ deriving (Show, Eq, Generic)
18+
19+instance NFData a => NFData (D a) where
20+ rnf Nullary = ()
21+ rnf (Unary n) = rnf n
22+ rnf (Product s c x) = s `deepseq` c `deepseq` rnf x
23+ rnf (Record a b y) = a `deepseq` b `deepseq` rnf y
24+
25+instance ToJSON a => ToJSON (D a) where
26+ toJSON = genericToJSON opts
27+ toEncoding = genericToEncoding opts
28+
29+instance FromJSON a => FromJSON (D a) where
30+ parseJSON = genericParseJSON opts
31+
32+type T = D (D (D ()))
33+
34+d :: T
35+d = Record
36+ { testOne = 1234.56789
37+ , testTwo = True
38+ , testThree = Product "Hello World!" 'a'
39+ Record
40+ { testOne = 9876.54321
41+ , testTwo = False
42+ , testThree = Product "Yeehaa!!!" '\n' Nullary
43+ }
44+ }
benchmarks/Auto/T/BigProduct.hsnew file+27
@@ -0,0 +1,27 @@
1+{-# LANGUAGE TemplateHaskell #-}
2+
3+module Auto.T.BigProduct where
4+
5+import Control.DeepSeq
6+import Data.Aeson.TH
7+import Options
8+
9+data BigProduct = BigProduct
10+ !Int !Int !Int !Int !Int
11+ !Int !Int !Int !Int !Int
12+ !Int !Int !Int !Int !Int
13+ !Int !Int !Int !Int !Int
14+ !Int !Int !Int !Int !Int
15+ deriving (Show, Eq)
16+
17+instance NFData BigProduct where
18+ rnf a = a `seq` ()
19+
20+deriveJSON opts ''BigProduct
21+
22+bigProduct :: BigProduct
23+bigProduct = BigProduct 1 2 3 4 5
24+ 6 7 8 9 10
25+ 11 12 13 14 15
26+ 16 17 18 19 20
27+ 21 22 23 24 25
benchmarks/Auto/T/BigRecord.hsnew file+27
@@ -0,0 +1,27 @@
1+{-# LANGUAGE TemplateHaskell #-}
2+
3+module Auto.T.BigRecord where
4+
5+import Control.DeepSeq
6+import Data.Aeson.TH
7+import Options
8+
9+data BigRecord = BigRecord
10+ { field01 :: !Int, field02 :: !Int, field03 :: !Int, field04 :: !Int, field05 :: !Int
11+ , field06 :: !Int, field07 :: !Int, field08 :: !Int, field09 :: !Int, field10 :: !Int
12+ , field11 :: !Int, field12 :: !Int, field13 :: !Int, field14 :: !Int, field15 :: !Int
13+ , field16 :: !Int, field17 :: !Int, field18 :: !Int, field19 :: !Int, field20 :: !Int
14+ , field21 :: !Int, field22 :: !Int, field23 :: !Int, field24 :: !Int, field25 :: !Int
15+ } deriving (Show, Eq)
16+
17+instance NFData BigRecord where
18+ rnf a = a `seq` ()
19+
20+deriveJSON opts ''BigRecord
21+
22+bigRecord :: BigRecord
23+bigRecord = BigRecord 1 2 3 4 5
24+ 6 7 8 9 10
25+ 11 12 13 14 15
26+ 16 17 18 19 20
27+ 21 22 23 24 25
benchmarks/Auto/T/BigSum.hsnew file+22
@@ -0,0 +1,22 @@
1+{-# LANGUAGE TemplateHaskell #-}
2+
3+module Auto.T.BigSum where
4+
5+import Control.DeepSeq
6+import Data.Aeson.TH
7+import Options
8+
9+data BigSum = F01 | F02 | F03 | F04 | F05
10+ | F06 | F07 | F08 | F09 | F10
11+ | F11 | F12 | F13 | F14 | F15
12+ | F16 | F17 | F18 | F19 | F20
13+ | F21 | F22 | F23 | F24 | F25
14+ deriving (Show, Eq)
15+
16+instance NFData BigSum where
17+ rnf a = a `seq` ()
18+
19+deriveJSON opts ''BigSum
20+
21+bigSum :: BigSum
22+bigSum = F25
benchmarks/Auto/T/D.hsnew file+38
@@ -0,0 +1,38 @@
1+{-# LANGUAGE TemplateHaskell #-}
2+
3+module Auto.T.D where
4+
5+import Control.DeepSeq
6+import Data.Aeson.TH
7+import Options
8+
9+data D a = Nullary
10+ | Unary Int
11+ | Product String Char a
12+ | Record { testOne :: Double
13+ , testTwo :: Bool
14+ , testThree :: D a
15+ }
16+ deriving (Show, Eq)
17+
18+instance NFData a => NFData (D a) where
19+ rnf Nullary = ()
20+ rnf (Unary n) = rnf n
21+ rnf (Product s c x) = s `deepseq` c `deepseq` rnf x
22+ rnf (Record a b y) = a `deepseq` b `deepseq` rnf y
23+
24+deriveJSON opts ''D
25+
26+type T = D (D (D ()))
27+
28+d :: T
29+d = Record
30+ { testOne = 1234.56789
31+ , testTwo = True
32+ , testThree = Product "Hello World!" 'a'
33+ Record
34+ { testOne = 9876.54321
35+ , testTwo = False
36+ , testThree = Product "Yeehaa!!!" '\n' Nullary
37+ }
38+ }
benchmarks/AutoCompare.hsnew file+73
@@ -0,0 +1,73 @@
1+{-# LANGUAGE RankNTypes #-}
2+{-# LANGUAGE ScopedTypeVariables #-}
3+
4+module Main (main) where
5+
6+import Control.DeepSeq
7+import Control.Monad
8+import Criterion.Main
9+import Data.Aeson
10+
11+import qualified Auto.T.D as T
12+import qualified Auto.T.BigRecord as T
13+import qualified Auto.T.BigProduct as T
14+import qualified Auto.T.BigSum as T
15+import qualified Auto.G.D as G
16+import qualified Auto.G.BigRecord as G
17+import qualified Auto.G.BigProduct as G
18+import qualified Auto.G.BigSum as G
19+
20+--------------------------------------------------------------------------------
21+
22+runBench :: IO ()
23+runBench = defaultMain
24+ [ compareBench "D" T.d G.d
25+ , compareBench "BigRecord" T.bigRecord G.bigRecord
26+ , compareBench "BigProduct" T.bigProduct G.bigProduct
27+ , compareBench "BigSum" T.bigSum G.bigSum
28+ ]
29+
30+group :: String -> Benchmarkable -> Benchmarkable -> Benchmark
31+group n th gen = bgroup n [ bench "th" th
32+ , bench "generic" gen
33+ ]
34+
35+compareBench
36+ :: forall a b
37+ . (ToJSON a, FromJSON a, NFData a, ToJSON b, FromJSON b, NFData b)
38+ => String -> a -> b -> Benchmark
39+compareBench name a b = v `deepseq` bgroup name
40+ [ group "toJSON" (nf toJSON a)
41+ (nf toJSON b)
42+ , group "encode" (nf encode a)
43+ (nf encode b)
44+ , group "fromJSON" (nf (fromJSON :: Value -> Result a) v)
45+ (nf (fromJSON :: Value -> Result b) v)
46+ ] where
47+ v = toJSON a -- == toJSON b
48+
49+sanityCheck :: IO ()
50+sanityCheck = do
51+ check T.d
52+ check G.d
53+ check T.bigRecord
54+ check G.bigRecord
55+ check T.bigProduct
56+ check G.bigProduct
57+ check T.bigSum
58+ check G.bigSum
59+
60+check :: (Show a, Eq a, FromJSON a, ToJSON a)
61+ => a -> IO ()
62+check x = do
63+ unless (Success x == (fromJSON . toJSON) x) $ fail $ "toJSON: " ++ show x
64+ unless (Success x == (decode_ . encode) x) $ fail $ "encode: " ++ show x
65+ where
66+ decode_ s = case decode s of
67+ Just v -> fromJSON v
68+ Nothing -> fail ""
69+
70+main :: IO ()
71+main = do
72+ sanityCheck
73+ runBench
benchmarks/Compare.hs+10−5
@@ -1,22 +1,25 @@
1−{-# LANGUAGE PackageImports #-}
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
23{-# LANGUAGE ScopedTypeVariables #-}
34
45module Main (main) where
56
6−import Prelude ()
77import Prelude.Compat
88
99import Compare.BufferBuilder ()
10−import Compare.JsonBuilder ()
1110import Criterion.Main
1211import Data.BufferBuilder.Json
13−import Data.Json.Builder
1412import Twitter
1513import Twitter.Manual ()
1614import Typed.Common
17−import qualified "aeson-benchmarks" Data.Aeson as Aeson
15+import qualified Data.Aeson as Aeson
1816import qualified Compare.JsonBench as JsonBench
1917
18+#ifdef MIN_VERSION_json_builder
19+import Data.Json.Builder
20+import Compare.JsonBuilder ()
21+#endif
22+
2023main :: IO ()
2124main =
2225 defaultMain [
@@ -24,7 +27,9 @@ main =
2427 bgroup "twitter" [
2528 bench "aeson" $ nf Aeson.encode twtr
2629 , bench "buffer-builder" $ nf encodeJson twtr
30+#ifdef MIN_VERSION_json_builder
2731 , bench "json-builder" $ nf toJsonLBS twtr
32+#endif
2833 ]
2934 , JsonBench.benchmarks
3035 ]
benchmarks/Compare/BufferBuilder.hs+2−3
@@ -1,3 +1,4 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12{-# LANGUAGE OverloadedStrings #-}
23{-# LANGUAGE RecordWildCards #-}
34
@@ -6,13 +7,11 @@
67
78module Compare.BufferBuilder () where
89
9−import Prelude ()
10−import Prelude.Compat
10+import Prelude.Compat hiding ((<>))
1111
1212import Data.BufferBuilder.Json
1313import Data.Int (Int64)
1414import Data.Monoid ((<>))
15−import Prelude hiding (id)
1615import Twitter
1716import qualified Data.BufferBuilder.Utf8 as UB
1817
benchmarks/Compare/JsonBench.hs+18−9
@@ -1,17 +1,18 @@
1−-- Adapted from a buffer-builder benchmark:
2−--
3−-- https://github.com/chadaustin/buffer-builder/blob/master/test.json
4−
1+{-# LANGUAGE CPP #-}
52{-# LANGUAGE BangPatterns #-}
63{-# LANGUAGE MagicHash #-}
4+{-# LANGUAGE NoImplicitPrelude #-}
75{-# LANGUAGE OverloadedStrings #-}
86{-# LANGUAGE RecordWildCards #-}
97{-# LANGUAGE ScopedTypeVariables #-}
108
9+-- Adapted from a buffer-builder benchmark:
10+--
11+-- https://github.com/chadaustin/buffer-builder/blob/master/test.json
12+
1113module Compare.JsonBench (benchmarks) where
1214
13−import Prelude ()
14−import Prelude.Compat
15+import Prelude.Compat hiding ((<>))
1516
1617import Control.DeepSeq (NFData(..))
1718import Criterion
@@ -19,9 +20,13 @@ import Data.Aeson ((.:))
1920import Data.Monoid ((<>))
2021import Data.Text (Text)
2122import Typed.Common (load)
23+import qualified Control.Monad.Fail as Fail
2224import qualified Data.Aeson as Aeson
2325import qualified Data.BufferBuilder.Json as Json
26+
27+#ifdef MIN_VERSION_json_builder
2428import qualified Data.Json.Builder as JB
29+#endif
2530
2631data EyeColor = Green | Blue | Brown
2732 deriving (Eq, Show)
@@ -64,10 +69,10 @@ instance NFData Gender where rnf !_ = ()
6469instance NFData Fruit where rnf !_ = ()
6570
6671instance NFData Friend where
67− rnf Friend {..} = rnf fId `seq` rnf fName `seq` ()
72+ rnf Friend {..} = rnf fId `seq` rnf fName
6873
6974instance NFData User where
70− rnf User {..} = rnf uId `seq` rnf uIndex `seq` rnf uGuid `seq` rnf uIsActive `seq` rnf uBalance `seq` rnf uPicture `seq` rnf uAge `seq` rnf uEyeColor `seq` rnf uName `seq` rnf uGender `seq` rnf uCompany `seq` rnf uEmail `seq` rnf uPhone `seq` rnf uAddress `seq` rnf uAbout `seq` rnf uRegistered `seq` rnf uLatitude `seq` rnf uLongitude `seq` rnf uTags `seq` rnf uFriends `seq` rnf uGreeting `seq` rnf uFavouriteFruit `seq` ()
75+ rnf User {..} = rnf uId `seq` rnf uIndex `seq` rnf uGuid `seq` rnf uIsActive `seq` rnf uBalance `seq` rnf uPicture `seq` rnf uAge `seq` rnf uEyeColor `seq` rnf uName `seq` rnf uGender `seq` rnf uCompany `seq` rnf uEmail `seq` rnf uPhone `seq` rnf uAddress `seq` rnf uAbout `seq` rnf uRegistered `seq` rnf uLatitude `seq` rnf uLongitude `seq` rnf uTags `seq` rnf uFriends `seq` rnf uGreeting `seq` rnf uFavouriteFruit
7176
7277eyeColorTable :: [(Text, EyeColor)]
7378eyeColorTable = [("brown", Brown), ("green", Green), ("blue", Blue)]
@@ -78,7 +83,7 @@ genderTable = [("male", Male), ("female", Female)]
7883fruitTable :: [(Text, Fruit)]
7984fruitTable = [("apple", Apple), ("strawberry", Strawberry), ("banana", Banana)]
8085
81−enumFromJson :: Monad m => String -> [(Text, enum)] -> (json -> m Text) -> json -> m enum
86+enumFromJson :: Fail.MonadFail m => String -> [(Text, enum)] -> (json -> m Text) -> json -> m enum
8287enumFromJson enumName table extract v = do
8388 s <- extract v
8489 case lookup s table of
@@ -268,6 +273,7 @@ instance Json.ToJson User where
268273 <> "greeting"# Json..=# uGreeting
269274 <> "favoriteFruit"# Json..=# uFavouriteFruit
270275
276+#ifdef MIN_VERSION_json_builder
271277---- json-builder instances ----
272278
273279instance JB.Value EyeColor where
@@ -319,6 +325,7 @@ instance JB.Value User where
319325 <> t "friends" `JB.row` uFriends
320326 <> t "greeting" `JB.row` uGreeting
321327 <> t "favoriteFruit" `JB.row` uFavouriteFruit
328+#endif
322329
323330benchmarks :: Benchmark
324331benchmarks = env (load "json-data/buffer-builder.json") $
@@ -326,5 +333,7 @@ benchmarks = env (load "json-data/buffer-builder.json") $
326333 bgroup "json-bench" [
327334 bench "aeson" $ nf Aeson.encode parsedUserList
328335 , bench "buffer-builder" $ nf Json.encodeJson parsedUserList
336+#ifdef MIN_VERSION_json_builder
329337 , bench "json-builder" $ nf JB.toJsonLBS parsedUserList
338+#endif
330339 ]
benchmarks/Compare/JsonBuilder.hs+2−3
@@ -1,3 +1,4 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12{-# LANGUAGE RecordWildCards #-}
23
34{-# OPTIONS_GHC -fno-warn-name-shadowing #-}
@@ -5,12 +6,10 @@
56
67module Compare.JsonBuilder () where
78
8−import Prelude ()
9−import Prelude.Compat
9+import Prelude.Compat hiding ((<>))
1010
1111import Data.Json.Builder
1212import Data.Monoid ((<>))
13−import Prelude hiding (id)
1413import Twitter
1514
1615instance JsObject Metadata where
benchmarks/CompareWithJSON.hs+32−17
@@ -1,8 +1,9 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
13{-# OPTIONS_GHC -fno-warn-orphans #-}
24
35module Main (main) where
46
5−import Prelude ()
67import Prelude.Compat
78
89import Blaze.ByteString.Builder (toLazyByteString)
@@ -12,6 +13,8 @@ import Criterion.Main
1213import Data.Maybe (fromMaybe)
1314import qualified Data.Aeson as A
1415import qualified Data.Aeson.Text as A
16+import qualified Data.Aeson.Parser.Internal as I
17+import qualified Data.ByteString as BS
1518import qualified Data.ByteString.Lazy as BL
1619import qualified Data.Text.Lazy as TL
1720import qualified Data.Text.Lazy.Builder as TLB
@@ -24,7 +27,7 @@ instance (NFData v) => NFData (J.JSObject v) where
2427instance NFData J.JSValue where
2528 rnf J.JSNull = ()
2629 rnf (J.JSBool b) = rnf b
27− rnf (J.JSRational a b) = rnf a `seq` rnf b `seq` ()
30+ rnf (J.JSRational a b) = rnf a `seq` rnf b
2831 rnf (J.JSString s) = rnf (J.fromJSString s)
2932 rnf (J.JSArray lst) = rnf lst
3033 rnf (J.JSObject o) = rnf o
@@ -35,11 +38,18 @@ decodeJ s =
3538 J.Ok v -> v
3639 J.Error _ -> error "fail to parse via JSON"
3740
38−decodeA :: BL.ByteString -> A.Value
39−decodeA s = fromMaybe (error "fail to parse via Aeson") $ A.decode s
41+decode :: BL.ByteString -> A.Value
42+decode s = fromMaybe (error "fail to parse via Aeson") $ A.decode s
43+
44+decode' :: BL.ByteString -> A.Value
45+decode' s = fromMaybe (error "fail to parse via Aeson") $ A.decode' s
46+
47+decodeS :: BS.ByteString -> A.Value
48+decodeS s = fromMaybe (error "fail to parse via Aeson") $ A.decodeStrict' s
4049
41−decodeA' :: BL.ByteString -> A.Value
42−decodeA' s = fromMaybe (error "fail to parse via Aeson") $ A.decode' s
50+decodeIP :: BL.ByteString -> A.Value
51+decodeIP s = fromMaybe (error "fail to parse via Parser.decodeWith") $
52+ I.decodeWith I.jsonEOF A.fromJSON s
4353
4454encodeJ :: J.JSValue -> BL.ByteString
4555encodeJ = toLazyByteString . fromString . J.encode
@@ -55,32 +65,37 @@ main = do
5565 let enFile = "json-data/twitter100.json"
5666 jpFile = "json-data/jp100.json"
5767 enA <- BL.readFile enFile
68+ enS <- BS.readFile enFile
5869 enJ <- readFile enFile
5970 jpA <- BL.readFile jpFile
71+ jpS <- BS.readFile jpFile
6072 jpJ <- readFile jpFile
6173 defaultMain [
6274 bgroup "decode" [
6375 bgroup "en" [
64− bench "aeson/lazy" $ nf decodeA enA
65− , bench "aeson/strict" $ nf decodeA' enA
66− , bench "json" $ nf decodeJ enJ
76+ bench "aeson/lazy" $ nf decode enA
77+ , bench "aeson/strict" $ nf decode' enA
78+ , bench "aeson/stricter" $ nf decodeS enS
79+ , bench "aeson/parser" $ nf decodeIP enA
80+ , bench "json" $ nf decodeJ enJ
6781 ]
6882 , bgroup "jp" [
69− bench "aeson" $ nf decodeA jpA
70− , bench "json" $ nf decodeJ jpJ
83+ bench "aeson" $ nf decode jpA
84+ , bench "aeson/stricter" $ nf decodeS jpS
85+ , bench "json" $ nf decodeJ jpJ
7186 ]
7287 ]
7388 , bgroup "encode" [
7489 bgroup "en" [
75− bench "aeson-to-bytestring" $ nf A.encode (decodeA enA)
76− , bench "aeson-via-text-to-bytestring" $ nf encodeViaText (decodeA enA)
77− , bench "aeson-to-text" $ nf encodeToText (decodeA enA)
90+ bench "aeson-to-bytestring" $ nf A.encode (decode enA)
91+ , bench "aeson-via-text-to-bytestring" $ nf encodeViaText (decode enA)
92+ , bench "aeson-to-text" $ nf encodeToText (decode enA)
7893 , bench "json" $ nf encodeJ (decodeJ enJ)
7994 ]
8095 , bgroup "jp" [
81− bench "aeson-to-bytestring" $ nf A.encode (decodeA jpA)
82− , bench "aeson-via-text-to-bytestring" $ nf encodeViaText (decodeA jpA)
83− , bench "aeson-to-text" $ nf encodeToText (decodeA jpA)
96+ bench "aeson-to-bytestring" $ nf A.encode (decode jpA)
97+ , bench "aeson-via-text-to-bytestring" $ nf encodeViaText (decode jpA)
98+ , bench "aeson-to-text" $ nf encodeToText (decode jpA)
8499 , bench "json" $ nf encodeJ (decodeJ jpJ)
85100 ]
86101 ]
benchmarks/Dates.hs+2−1
@@ -1,6 +1,7 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
13module Main (main) where
24
3−import Prelude ()
45import Prelude.Compat
56
67import Criterion.Main
benchmarks/Escape.hsnew file+32
@@ -0,0 +1,32 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+{-# LANGUAGE ScopedTypeVariables #-}
3+
4+{-# OPTIONS_GHC -fno-warn-name-shadowing #-}
5+
6+module Main (main) where
7+
8+import Prelude.Compat
9+
10+import Criterion.Main
11+import qualified Data.Aeson.Parser.UnescapeFFI as FFI
12+import qualified Data.Aeson.Parser.UnescapePure as Pure
13+
14+import qualified Data.ByteString.Char8 as BS
15+import System.Environment (getArgs, withArgs)
16+
17+main :: IO ()
18+main = do
19+ args_ <- getArgs
20+ let (args, p, n) =
21+ case args_ of
22+ "--pattern" : p : args_ -> k p args_
23+ _ -> k "\\\"" args_
24+ k p args_ =
25+ case args_ of
26+ "--repeat" : n : args_ -> (args_, p, read n)
27+ args_ -> (args_, p, 10000)
28+ input = BS.concat $ replicate n $ BS.pack p
29+ withArgs args $ defaultMain
30+ [ bench "ffi" $ whnf FFI.unescapeText input
31+ , bench "pure" $ whnf Pure.unescapeText input
32+ ]
benchmarks/Issue673.hsnew file+165
@@ -0,0 +1,165 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+{-# LANGUAGE OverloadedStrings #-}
3+
4+module Main (
5+ main,
6+ input17,
7+ input32,
8+ input64,
9+ input128,
10+ input256,
11+ input2048,
12+ input4096,
13+ input8192,
14+ input16384,
15+ ) where
16+
17+import Criterion.Main
18+import Prelude.Compat
19+import Data.Int (Int64)
20+import Data.Scientific (Scientific)
21+import Data.Semigroup ((<>))
22+import Data.Aeson.Parser (scientific)
23+
24+import qualified Data.Attoparsec.ByteString.Lazy as AttoL
25+import qualified Data.Attoparsec.ByteString.Char8 as Atto8
26+import qualified Data.Aeson as A
27+import qualified Data.ByteString as BS
28+import qualified Data.ByteString.Lazy as LBS
29+import qualified Data.ByteString.Lazy.Char8 as LBS8
30+
31+decodeInt :: LBS.ByteString -> Maybe Int
32+decodeInt = A.decode
33+
34+decodeString :: LBS.ByteString -> Maybe String
35+decodeString = A.decode
36+
37+decodeScientific :: LBS.ByteString -> Maybe Scientific
38+decodeScientific = A.decode
39+
40+decodeViaRead :: LBS.ByteString -> Integer
41+decodeViaRead = read . LBS8.unpack
42+
43+decodeAtto :: LBS.ByteString -> Maybe Scientific
44+decodeAtto
45+ = parseOnly (scientific <* AttoL.endOfInput)
46+ where
47+ parseOnly p lbs = case AttoL.parse p lbs of
48+ AttoL.Done _ r -> Just r
49+ AttoL.Fail {} -> Nothing
50+
51+decodeAtto8 :: LBS.ByteString -> Maybe Scientific
52+decodeAtto8
53+ = parseOnly (Atto8.scientific <* AttoL.endOfInput)
54+ where
55+ parseOnly p lbs = case AttoL.parse p lbs of
56+ AttoL.Done _ r -> Just r
57+ AttoL.Fail {} -> Nothing
58+
59+generate :: Int64 -> LBS.ByteString
60+generate n = LBS8.replicate n '1'
61+
62+input17 :: LBS.ByteString
63+input17 = generate 17
64+
65+input32 :: LBS.ByteString
66+input32 = generate 32
67+
68+input64 :: LBS.ByteString
69+input64 = generate 64
70+
71+input128 :: LBS.ByteString
72+input128 = generate 128
73+
74+input256 :: LBS.ByteString
75+input256 = generate 256
76+
77+input2048 :: LBS.ByteString
78+input2048 = generate 2048
79+
80+input4096 :: LBS.ByteString
81+input4096 = generate 4096
82+
83+input8192 :: LBS.ByteString
84+input8192 = generate 8192
85+
86+input16384 :: LBS.ByteString
87+input16384 = generate 16384
88+
89+
90+main :: IO ()
91+main = defaultMain
92+ -- works on 64bit
93+ [ benchPair "17" input17
94+ -- , benchPair "32" input32
95+ -- , benchPair "64" input64
96+ -- , benchPair "128" input128
97+ -- , benchPair "256" input256
98+ , benchPair "2048" input2048
99+ , benchPair "4096" input4096
100+ , benchPair "8192" input8192
101+ , benchPair "16384" input16384
102+ ]
103+ where
104+ benchPair name input = bgroup name
105+ [ bench "Int" $ whnf decodeInt input
106+ , bench "Simple" $ whnf bsToIntegerSimple (LBS.toStrict input)
107+ , bench "Optim" $ whnf bsToInteger (LBS.toStrict input)
108+ , bench "Read" $ whnf decodeViaRead input
109+ , bench "Scientific" $ whnf decodeScientific input
110+ , bench "parserA" $ whnf decodeAtto input
111+ , bench "parserS" $ whnf decodeAtto8 input
112+ , bench "String" $ whnf decodeString $ "\"" <> input <> "\""
113+ ]
114+
115+-------------------------------------------------------------------------------
116+-- better fromInteger
117+-------------------------------------------------------------------------------
118+
119+bsToInteger :: BS.ByteString -> Integer
120+bsToInteger bs
121+ | l > 40 = valInteger 10 l [ fromIntegral (w - 48) | w <- BS.unpack bs ]
122+ | otherwise = bsToIntegerSimple bs
123+ where
124+ l = BS.length bs
125+
126+bsToIntegerSimple :: BS.ByteString -> Integer
127+bsToIntegerSimple = BS.foldl' step 0 where
128+ step a b = a * 10 + fromIntegral (b - 48) -- 48 = '0'
129+
130+-- A sub-quadratic algorithm for Integer. Pairs of adjacent radix b
131+-- digits are combined into a single radix b^2 digit. This process is
132+-- repeated until we are left with a single digit. This algorithm
133+-- performs well only on large inputs, so we use the simple algorithm
134+-- for smaller inputs.
135+valInteger :: Integer -> Int -> [Integer] -> Integer
136+valInteger = go
137+ where
138+ go :: Integer -> Int -> [Integer] -> Integer
139+ go _ _ [] = 0
140+ go _ _ [d] = d
141+ go b l ds
142+ | l > 40 = b' `seq` go b' l' (combine b ds')
143+ | otherwise = valSimple b ds
144+ where
145+ -- ensure that we have an even number of digits
146+ -- before we call combine:
147+ ds' = if even l then ds else 0 : ds
148+ b' = b * b
149+ l' = (l + 1) `quot` 2
150+
151+ combine b (d1 : d2 : ds) = d `seq` (d : combine b ds)
152+ where
153+ d = d1 * b + d2
154+ combine _ [] = []
155+ combine _ [_] = errorWithoutStackTrace "this should not happen"
156+
157+-- The following algorithm is only linear for types whose Num operations
158+-- are in constant time.
159+valSimple :: Integer -> [Integer] -> Integer
160+valSimple base = go 0
161+ where
162+ go r [] = r
163+ go r (d : ds) = r' `seq` go r' ds
164+ where
165+ r' = r * base + fromIntegral d
benchmarks/JsonParse.hs+3−2
@@ -1,10 +1,11 @@
11{-# LANGUAGE BangPatterns #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
23{-# LANGUAGE ScopedTypeVariables #-}
4+
35{-# OPTIONS_GHC -fno-warn-orphans #-}
46
57module Main (main) where
68
7−import Prelude ()
89import Prelude.Compat
910
1011import Control.DeepSeq
@@ -16,7 +17,7 @@ import Text.JSON
1617instance NFData JSValue where
1718 rnf JSNull = ()
1819 rnf (JSBool b) = rnf b
19− rnf (JSRational b r) = rnf b `seq` rnf r `seq` ()
20+ rnf (JSRational b r) = rnf b `seq` rnf r
2021 rnf (JSString s) = rnf (fromJSString s)
2122 rnf (JSArray vs) = rnf vs
2223 rnf (JSObject kvs) = rnf (fromJSObject kvs)
benchmarks/Micro.hs+8−6
@@ -1,11 +1,13 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
13module Main (main) where
24
3−import Prelude ()
45import Prelude.Compat
56
67import Criterion.Main
7−import qualified Data.Aeson.Encoding.Builder as AB
8−import qualified Data.ByteString.Builder as B
8+
9+-- Encoding is a newtype wrapper around Builder
10+import Data.Aeson.Encoding (text, string, encodingToLazyByteString)
911import qualified Data.Text as T
1012
1113main :: IO ()
@@ -13,8 +15,8 @@ main = do
1315 let txt = "append (append b (primBounded w1 x1)) (primBounded w2 x2)"
1416 defaultMain [
1517 bgroup "string" [
16− bench "text" $ nf (B.toLazyByteString . AB.text) (T.pack txt)
17− , bench "string direct" $ nf (B.toLazyByteString . AB.string) txt
18− , bench "string via text" $ nf (B.toLazyByteString . AB.text . T.pack) txt
18+ bench "text" $ nf (encodingToLazyByteString . text) (T.pack txt)
19+ , bench "string direct" $ nf (encodingToLazyByteString . string) txt
20+ , bench "string via text" $ nf (encodingToLazyByteString . text . T.pack) txt
1921 ]
2022 ]
benchmarks/Options.hs+1−4
@@ -1,7 +1,4 @@
1−module Options where
2−
3−import Prelude ()
4−import Prelude.Compat
1+module Options (opts) where
52
63import Data.Aeson.Types
74
benchmarks/ReadFile.hs+1−1
@@ -1,9 +1,9 @@
11{-# LANGUAGE BangPatterns #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
23{-# LANGUAGE OverloadedStrings #-}
34
45module Main (main) where
56
6−import Prelude ()
77import Prelude.Compat
88
99import Control.DeepSeq
benchmarks/Typed.hs+5−1
@@ -1,6 +1,7 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
13module Main (main) where
24
3−import Prelude ()
45import Prelude.Compat
56
67import Criterion.Main
@@ -13,4 +14,7 @@ main = defaultMain [
1314 Generic.benchmarks
1415 , Manual.benchmarks
1516 , TH.benchmarks
17+ , Generic.decodeBenchmarks
18+ , Manual.decodeBenchmarks
19+ , TH.decodeBenchmarks
1620 ]
benchmarks/Typed/Common.hs+1−10
@@ -1,25 +1,16 @@
1−{-# LANGUAGE CPP #-}
2−#ifdef HAS_BOTH_AESON_AND_BENCHMARKS
3−{-# LANGUAGE PackageImports #-}
4−#endif
1+{-# LANGUAGE NoImplicitPrelude #-}
52
63{-# OPTIONS_GHC -fno-warn-unused-imports #-}
74
85module Typed.Common (load) where
96
10−import Prelude ()
117import Prelude.Compat
128
139import Data.ByteString.Lazy as L
1410import System.Exit
1511import System.IO
1612
17−#ifndef HAS_BOTH_AESON_AND_BENCHMARKS
1813import Data.Aeson hiding (Result)
19−#else
20−import "aeson" Data.Aeson hiding (Result)
21−import qualified "aeson-benchmarks" Data.Aeson as B
22−#endif
2314
2415load :: FromJSON a => FilePath -> IO a
2516load fileName = do
benchmarks/Typed/Generic.hs+27−25
@@ -1,42 +1,44 @@
1−{-# LANGUAGE PackageImports #-}
2−module Typed.Generic (benchmarks) where
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
3+module Typed.Generic (benchmarks, decodeBenchmarks) where
34
4−import Prelude ()
55import Prelude.Compat
66
7−import "aeson" Data.Aeson hiding (Result)
7+import Data.Aeson hiding (Result)
88import Criterion
99import Data.ByteString.Lazy as L
10−import Twitter.TH
10+import Twitter.Generic
1111import Typed.Common
12−import qualified "aeson-benchmarks" Data.Aeson as B
13−
14−encodeDirectA :: Result -> L.ByteString
15−encodeDirectA = encode
1612
17−encodeViaValueA :: Result -> L.ByteString
18−encodeViaValueA = encode . toJSON
13+encodeDirect :: Result -> L.ByteString
14+encodeDirect = encode
1915
20−encodeDirectB :: Result -> L.ByteString
21−encodeDirectB = B.encode
22−
23−encodeViaValueB :: Result -> L.ByteString
24−encodeViaValueB = B.encode . B.toJSON
16+encodeViaValue :: Result -> L.ByteString
17+encodeViaValue = encode . toJSON
2518
2619benchmarks :: Benchmark
2720benchmarks =
2821 env ((,) <$> load "json-data/twitter100.json" <*> load "json-data/jp100.json") $ \ ~(twitter100, jp100) ->
29− bgroup "generic" [
22+ bgroup "encodeGeneric" [
3023 bgroup "direct" [
31− bench "twitter100" $ nf encodeDirectB twitter100
32− , bench "jp100" $ nf encodeDirectB jp100
33− , bench "twitter100 baseline" $ nf encodeDirectA twitter100
34− , bench "jp100 baseline" $ nf encodeDirectA jp100
24+ bench "twitter100" $ nf encodeDirect twitter100
25+ , bench "jp100" $ nf encodeDirect jp100
3526 ]
3627 , bgroup "viaValue" [
37− bench "twitter100" $ nf encodeViaValueB twitter100
38− , bench "jp100" $ nf encodeViaValueB jp100
39− , bench "twitter100 baseline" $ nf encodeViaValueA twitter100
40− , bench "jp100 baseline" $ nf encodeViaValueA jp100
28+ bench "twitter100" $ nf encodeViaValue twitter100
29+ , bench "jp100" $ nf encodeViaValue jp100
30+ ]
31+ ]
32+
33+decodeDirect :: L.ByteString -> Maybe Result
34+decodeDirect = decode
35+
36+decodeBenchmarks :: Benchmark
37+decodeBenchmarks =
38+ env ((,) <$> L.readFile "json-data/twitter100.json" <*> L.readFile "json-data/jp100.json") $ \ ~(twitter100, jp100) ->
39+ bgroup "decodeGeneric"
40+ [ bgroup "direct"
41+ [ bench "twitter100" $ nf decodeDirect twitter100
42+ , bench "jp100" $ nf decodeDirect jp100
4143 ]
4244 ]
benchmarks/Typed/Manual.hs+26−24
@@ -1,42 +1,44 @@
1−{-# LANGUAGE PackageImports #-}
2−module Typed.Manual (benchmarks) where
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
3+module Typed.Manual (benchmarks, decodeBenchmarks) where
34
4−import Prelude ()
55import Prelude.Compat
66
7−import "aeson" Data.Aeson hiding (Result)
7+import Data.Aeson hiding (Result)
88import Criterion
99import Data.ByteString.Lazy as L
1010import Twitter.Manual
1111import Typed.Common
12−import qualified "aeson-benchmarks" Data.Aeson as B
13−
14−encodeDirectA :: Result -> L.ByteString
15−encodeDirectA = encode
1612
17−encodeViaValueA :: Result -> L.ByteString
18−encodeViaValueA = encode . toJSON
13+encodeDirect :: Result -> L.ByteString
14+encodeDirect = encode
1915
20−encodeDirectB :: Result -> L.ByteString
21−encodeDirectB = B.encode
22−
23−encodeViaValueB :: Result -> L.ByteString
24−encodeViaValueB = B.encode . B.toJSON
16+encodeViaValue :: Result -> L.ByteString
17+encodeViaValue = encode . toJSON
2518
2619benchmarks :: Benchmark
2720benchmarks =
2821 env ((,) <$> load "json-data/twitter100.json" <*> load "json-data/jp100.json") $ \ ~(twitter100, jp100) ->
29− bgroup "manual" [
22+ bgroup "encodeManual" [
3023 bgroup "direct" [
31− bench "twitter100" $ nf encodeDirectB twitter100
32− , bench "jp100" $ nf encodeDirectB jp100
33− , bench "twitter100 baseline" $ nf encodeDirectA twitter100
34− , bench "jp100 baseline" $ nf encodeDirectA jp100
24+ bench "twitter100" $ nf encodeDirect twitter100
25+ , bench "jp100" $ nf encodeDirect jp100
3526 ]
3627 , bgroup "viaValue" [
37− bench "twitter100" $ nf encodeViaValueB twitter100
38− , bench "jp100" $ nf encodeViaValueB jp100
39− , bench "twitter100 baseline" $ nf encodeViaValueA twitter100
40− , bench "jp100 baseline" $ nf encodeViaValueA jp100
28+ bench "twitter100" $ nf encodeViaValue twitter100
29+ , bench "jp100" $ nf encodeViaValue jp100
30+ ]
31+ ]
32+
33+decodeDirect :: L.ByteString -> Maybe Result
34+decodeDirect = decode
35+
36+decodeBenchmarks :: Benchmark
37+decodeBenchmarks =
38+ env ((,) <$> L.readFile "json-data/twitter100.json" <*> L.readFile "json-data/jp100.json") $ \ ~(twitter100, jp100) ->
39+ bgroup "decodeManual"
40+ [ bgroup "direct"
41+ [ bench "twitter100" $ nf decodeDirect twitter100
42+ , bench "jp100" $ nf decodeDirect jp100
4143 ]
4244 ]
benchmarks/Typed/TH.hs+26−24
@@ -1,42 +1,44 @@
1−{-# LANGUAGE PackageImports #-}
2−module Typed.TH (benchmarks) where
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
3+module Typed.TH (benchmarks, decodeBenchmarks) where
34
4−import Prelude ()
55import Prelude.Compat
66
7−import "aeson" Data.Aeson hiding (Result)
7+import Data.Aeson hiding (Result)
88import Criterion
99import Data.ByteString.Lazy as L
1010import Twitter.TH
1111import Typed.Common
12−import qualified "aeson-benchmarks" Data.Aeson as B
13−
14−encodeDirectA :: Result -> L.ByteString
15−encodeDirectA = encode
1612
17−encodeViaValueA :: Result -> L.ByteString
18−encodeViaValueA = encode . toJSON
13+encodeDirect :: Result -> L.ByteString
14+encodeDirect = encode
1915
20−encodeDirectB :: Result -> L.ByteString
21−encodeDirectB = B.encode
22−
23−encodeViaValueB :: Result -> L.ByteString
24−encodeViaValueB = B.encode . B.toJSON
16+encodeViaValue :: Result -> L.ByteString
17+encodeViaValue = encode . toJSON
2518
2619benchmarks :: Benchmark
2720benchmarks =
2821 env ((,) <$> load "json-data/twitter100.json" <*> load "json-data/jp100.json") $ \ ~(twitter100, jp100) ->
29− bgroup "th" [
22+ bgroup "encodeTH" [
3023 bgroup "direct" [
31− bench "twitter100" $ nf encodeDirectB twitter100
32− , bench "jp100" $ nf encodeDirectB jp100
33− , bench "twitter100 baseline" $ nf encodeDirectA twitter100
34− , bench "jp100 baseline" $ nf encodeDirectA jp100
24+ bench "twitter100" $ nf encodeDirect twitter100
25+ , bench "jp100" $ nf encodeDirect jp100
3526 ]
3627 , bgroup "viaValue" [
37− bench "twitter100" $ nf encodeViaValueA twitter100
38− , bench "jp100" $ nf encodeViaValueA jp100
39− , bench "twitter100 baseline" $ nf encodeViaValueB twitter100
40− , bench "jp100 baseline" $ nf encodeViaValueB jp100
28+ bench "twitter100" $ nf encodeViaValue twitter100
29+ , bench "jp100" $ nf encodeViaValue jp100
30+ ]
31+ ]
32+
33+decodeDirect :: L.ByteString -> Maybe Result
34+decodeDirect = decode
35+
36+decodeBenchmarks :: Benchmark
37+decodeBenchmarks =
38+ env ((,) <$> L.readFile "json-data/twitter100.json" <*> L.readFile "json-data/jp100.json") $ \ ~(twitter100, jp100) ->
39+ bgroup "decodeTH"
40+ [ bgroup "direct"
41+ [ bench "twitter100" $ nf decodeDirect twitter100
42+ , bench "jp100" $ nf decodeDirect jp100
4143 ]
4244 ]
benchmarks/aeson-benchmarks.cabal+183−64
@@ -1,62 +1,21 @@
11name: aeson-benchmarks
22version: 0
33build-type: Simple
4−
5−cabal-version: >=1.8
4+cabal-version: >=1.10
65
76flag bytestring-builder
87 description: Depend on the bytestring-builder package for backwards compatibility.
98 default: False
109 manual: False
1110
12−library
13− hs-source-dirs: .. . ../ffi ../pure
14− c-sources: ../cbits/unescape_string.c
15− exposed-modules:
16− Data.Aeson
17− Data.Aeson.Encoding
18− Data.Aeson.Encoding.Builder
19− Data.Aeson.Encoding.Internal
20− Data.Aeson.Internal
21− Data.Aeson.Internal.Functions
22− Data.Aeson.Internal.Time
23− Data.Aeson.Parser
24− Data.Aeson.Parser.Internal
25− Data.Aeson.Parser.Time
26− Data.Aeson.Parser.Unescape
27− Data.Aeson.Parser.UnescapeFFI
28− Data.Aeson.Parser.UnescapePure
29− Data.Aeson.TH
30− Data.Aeson.Text
31− Data.Aeson.Types
32− Data.Aeson.Types.Class
33− Data.Aeson.Types.FromJSON
34− Data.Aeson.Types.Generic
35− Data.Aeson.Types.Internal
36− Data.Aeson.Types.ToJSON
11+flag local-aeson
12+ description: Build the local version of aeson, to avoid rebuilding aeson's
13+ reverse dependencies for benchmarking (statistics, criterion).
14+ default: True
15+ manual: True
3716
38− build-depends:
39− attoparsec >= 0.13.0.1,
40− base == 4.*,
41− base-compat >= 0.9.1 && <0.10,
42− time-locale-compat >=0.1.1 && <0.2,
43− containers,
44− deepseq,
45− dlist >= 0.2,
46− fail == 4.9.*,
47− ghc-prim >= 0.2,
48− hashable >= 1.1.2.0,
49− mtl,
50− scientific >= 0.3.4.7 && < 0.4,
51− syb,
52− tagged >=0.8.3 && <0.9,
53− template-haskell >= 2.4,
54− text >= 1.1.1.0,
55− time,
56− transformers,
57− unordered-containers >= 0.2.3.0,
58− uuid-types >= 1.0.3 && <1.1,
59− vector >= 0.7.1
17+library
18+ default-language: Haskell2010
6019
6120 if flag(bytestring-builder)
6221 build-depends: bytestring >= 0.9 && < 0.10.4,
@@ -64,22 +23,142 @@ library
6423 else
6524 build-depends: bytestring >= 0.10.4
6625
67− if impl(ghc >=7.8)
68− cpp-options: -DHAS_COERCIBLE
26+ if flag(local-aeson)
27+
28+ hs-source-dirs: .. ../ffi ../pure ../attoparsec-iso8601
29+ c-sources: ../cbits/unescape_string.c
30+ build-depends:
31+ attoparsec,
32+ base,
33+ base-compat,
34+ containers,
35+ deepseq,
36+ dlist,
37+ fail,
38+ ghc-prim,
39+ hashable,
40+ mtl,
41+ primitive,
42+ scientific,
43+ syb,
44+ tagged,
45+ template-haskell,
46+ text,
47+ th-abstraction,
48+ time-compat,
49+ time,
50+ transformers,
51+ unordered-containers,
52+ uuid-types,
53+ vector
54+
55+ if !impl(ghc >= 8.6)
56+ build-depends: contravariant
57+
58+ if !impl(ghc >= 8.0)
59+ -- `Data.Semigroup` is available in base only since GHC 8.0 / base 4.9
60+ build-depends: semigroups,
61+ transformers-compat
6962
70− if !impl(ghc >= 8.0)
71− -- `Data.Semigroup` is available in base only since GHC 8.0 / base 4.9
72− build-depends: semigroups >= 0.18.2 && < 0.19
63+ if !impl(ghc >= 7.10)
64+ -- `Numeric.Natural` is available in base only since GHC 7.10 / base 4.8
65+ build-depends: nats,
66+ void
7367
74− include-dirs: ../include
68+ include-dirs: ../include
7569
76− ghc-options: -O2 -Wall
77− cpp-options: -DGENERICS
70+ ghc-options: -O2 -Wall
71+ cpp-options: -DGENERICS
72+
73+ exposed-modules:
74+ Data.Aeson
75+ Data.Aeson.Encoding
76+ Data.Aeson.Encoding.Builder
77+ Data.Aeson.Encoding.Internal
78+ Data.Aeson.Internal
79+ Data.Aeson.Internal.Functions
80+ Data.Aeson.Internal.Time
81+ Data.Aeson.Parser
82+ Data.Aeson.Parser.Internal
83+ Data.Aeson.Parser.Time
84+ Data.Aeson.Parser.Unescape
85+ Data.Aeson.Parser.UnescapeFFI
86+ Data.Aeson.Parser.UnescapePure
87+ Data.Aeson.TH
88+ Data.Aeson.Text
89+ Data.Aeson.Types
90+ Data.Aeson.Types.Class
91+ Data.Aeson.Types.FromJSON
92+ Data.Aeson.Types.Generic
93+ Data.Aeson.Types.Internal
94+ Data.Aeson.Types.ToJSON
95+ Data.Attoparsec.Time
96+ Data.Attoparsec.Time.Internal
97+
98+ else
99+
100+ build-depends: aeson
101+
102+ reexported-modules:
103+ Data.Aeson,
104+ Data.Aeson.Encoding,
105+ Data.Aeson.Parser.Internal,
106+ Data.Aeson.Text,
107+ Data.Aeson.TH,
108+ Data.Aeson.Types
109+
110+executable aeson-benchmark-auto-compare
111+ default-language: Haskell2010
112+ main-is: AutoCompare.hs
113+ hs-source-dirs: .
114+ ghc-options: -Wall -O2 -rtsopts
115+ other-modules:
116+ Auto.T.D
117+ Auto.T.BigRecord
118+ Auto.T.BigProduct
119+ Auto.T.BigSum
120+ Auto.G.D
121+ Auto.G.BigRecord
122+ Auto.G.BigProduct
123+ Auto.G.BigSum
124+ Options
125+ build-depends:
126+ aeson-benchmarks,
127+ base,
128+ criterion,
129+ deepseq,
130+ template-haskell
131+
132+executable aeson-benchmark-escape
133+ default-language: Haskell2010
134+ main-is: Escape.hs
135+ hs-source-dirs: ../examples .
136+ ghc-options: -Wall -O2 -rtsopts
137+ if flag(local-aeson)
138+ build-depends:
139+ aeson-benchmarks,
140+ base,
141+ base-compat,
142+ bytestring,
143+ criterion >= 1.0,
144+ deepseq,
145+ ghc-prim,
146+ text
147+ else
148+ -- Disabled because of inaccessible internals
149+ buildable: False
78150
79151executable aeson-benchmark-compare
152+ default-language: Haskell2010
80153 main-is: Compare.hs
81154 hs-source-dirs: ../examples .
82155 ghc-options: -Wall -O2 -rtsopts
156+ other-modules:
157+ Compare.BufferBuilder
158+ Compare.JsonBench
159+ Twitter
160+ Twitter.Manual
161+ Typed.Common
83162 build-depends:
84163 aeson-benchmarks,
85164 base,
@@ -89,10 +168,19 @@ executable aeson-benchmark-compare
89168 criterion >= 1.0,
90169 deepseq,
91170 ghc-prim,
92− json-builder,
93171 text
94172
173+ if impl(ghc < 8.4)
174+ other-modules:
175+ Compare.JsonBuilder
176+ build-depends:
177+ json-builder
178+ if impl(ghc < 8.0)
179+ build-depends:
180+ semigroups
181+
95182executable aeson-benchmark-micro
183+ default-language: Haskell2010
96184 main-is: Micro.hs
97185 hs-source-dirs: ../examples .
98186 ghc-options: -Wall -O2 -rtsopts
@@ -107,14 +195,21 @@ executable aeson-benchmark-micro
107195 text
108196
109197executable aeson-benchmark-typed
198+ default-language: Haskell2010
110199 main-is: Typed.hs
111200 hs-source-dirs: ../examples .
112201 ghc-options: -Wall -O2 -rtsopts
113− -- We must help ourself in situations when there is both
114− -- aeson and aeson-benchmakrs
115− cpp-options: -DHAS_BOTH_AESON_AND_BENCHMARKS
202+ other-modules:
203+ Twitter
204+ Twitter.Generic
205+ Twitter.Manual
206+ Twitter.Options
207+ Twitter.TH
208+ Typed.Common
209+ Typed.Generic
210+ Typed.Manual
211+ Typed.TH
116212 build-depends:
117− aeson,
118213 aeson-benchmarks,
119214 base,
120215 base-compat,
@@ -129,8 +224,11 @@ executable aeson-benchmark-typed
129224 bytestring-builder >= 0.10.4 && < 1
130225 else
131226 build-depends: bytestring >= 0.10.4
227+ if impl(ghc < 8.0)
228+ build-depends: semigroups
132229
133230executable aeson-benchmark-compare-with-json
231+ default-language: Haskell2010
134232 main-is: CompareWithJSON.hs
135233 ghc-options: -Wall -O2 -rtsopts
136234 build-depends:
@@ -145,6 +243,7 @@ executable aeson-benchmark-compare-with-json
145243 text
146244
147245executable aeson-benchmark-aeson-encode
246+ default-language: Haskell2010
148247 main-is: AesonEncode.hs
149248 ghc-options: -Wall -O2 -rtsopts
150249 build-depends:
@@ -157,6 +256,7 @@ executable aeson-benchmark-aeson-encode
157256 time
158257
159258executable aeson-benchmark-aeson-parse
259+ default-language: Haskell2010
160260 main-is: AesonParse.hs
161261 ghc-options: -Wall -O2 -rtsopts
162262 build-depends:
@@ -168,6 +268,7 @@ executable aeson-benchmark-aeson-parse
168268 time
169269
170270executable aeson-benchmark-json-parse
271+ default-language: Haskell2010
171272 main-is: JsonParse.hs
172273 ghc-options: -Wall -O2 -rtsopts
173274 build-depends:
@@ -178,6 +279,7 @@ executable aeson-benchmark-json-parse
178279 time
179280
180281executable aeson-benchmark-dates
282+ default-language: Haskell2010
181283 main-is: Dates.hs
182284 ghc-options: -Wall -O2 -rtsopts
183285 build-depends:
@@ -189,12 +291,14 @@ executable aeson-benchmark-dates
189291 aeson-benchmarks,
190292 text,
191293 time
294+ if impl(ghc >= 8.2)
295+ ghc-options: -Wno-simplifiable-class-constraints
192296
193297executable aeson-benchmark-map
298+ default-language: Haskell2010
194299 main-is: AesonMap.hs
195300 ghc-options: -Wall -O2 -rtsopts
196301 build-depends:
197− aeson,
198302 aeson-benchmarks,
199303 base,
200304 base-compat,
@@ -208,10 +312,10 @@ executable aeson-benchmark-map
208312 unordered-containers
209313
210314executable aeson-benchmark-foldable
315+ default-language: Haskell2010
211316 main-is: AesonFoldable.hs
212317 ghc-options: -Wall -O2 -rtsopts
213318 build-depends:
214− aeson,
215319 aeson-benchmarks,
216320 base,
217321 base-compat,
@@ -224,3 +328,18 @@ executable aeson-benchmark-foldable
224328 text,
225329 unordered-containers,
226330 vector
331+
332+executable aeson-issue-673
333+ default-language: Haskell2010
334+ main-is: Issue673.hs
335+ ghc-options: -Wall -O1 -rtsopts
336+ build-depends:
337+ aeson-benchmarks,
338+ attoparsec,
339+ base,
340+ bytestring,
341+ scientific,
342+ base-compat,
343+ criterion >= 1.0
344+ if impl(ghc < 8.0)
345+ build-depends: semigroups
cabal.projectnew file+5
@@ -0,0 +1,5 @@
1+with-compiler: ghc
2+packages: .
3+packages: attoparsec-iso8601
4+-- packages: benchmarks
5+tests: true
changelog.md+173
@@ -1,5 +1,178 @@
11For the latest version of this document, please see [https://github.com/bos/aeson/blob/master/changelog.md](https://github.com/bos/aeson/blob/master/changelog.md).
22
3+### upcoming
4+
5+* `FromJSON` instance of `Ratio a` now parses numbers in addtion to
6+ standard `{numerator=..., denumerator=...}` encoding.
7+
8+### 1.4.6.0
9+
10+* Provide a clearer error message when a required tagKey for a constructor is missing, thanks to Guru Devanla.
11+ The error message now looks like this: `Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found`
12+
13+* Add `formatPath` and `formatRelativePath` functions to turn a `JSONPath` into a `String`, thanks to Robbie McMichael
14+
15+
16+### 1.4.5.0
17+
18+* Expose `(<?>)`, `JSONPath` and `JSONPathElement(..)` from `Data.Aeson.Types`. Previously only available through internal modules. Thanks to Luke Clifton.
19+
20+* Support for base-compat 0.11, thanks to Ryan Scott.
21+
22+* Travis build for GHC 8.8, thanks to Oleg Grenrus.
23+
24+### 1.4.4.0
25+
26+**New features**:
27+
28+* Adds a parameterized parser `jsonWith` that can be used to choose how to handle duplicate keys in objects, thanks to Xia Li-Yao.
29+
30+* Add generic implementations of `FromJSONKey` and `ToJSONKey`, thanks to Xia Li-Yao. Example:
31+
32+```haskell
33+data Foo = Bar
34+ deriving Generic
35+
36+opts :: JSONKeyOptions
37+opts = defaultJSONKeyOptions { keyModifier = toLower }
38+
39+instance ToJSONKey Foo where
40+ toJSONKey = genericToJSONKey opts
41+
42+instance FromJSONKey Foo where
43+ fromJSONKey = genericFromJSONKey opts
44+```
45+
46+**Minor**:
47+* aeson now uses `time-compat` instead of `time-locale-compat`, thanks to Oleg Grenrus.
48+* Prepare for `MonadFail` breakages in GHC 8.8, thanks to Oleg Grenrus.
49+* Require `bytestring >= 0.10.8.1` for newer GHCs to avoid build failures, thanks to Oleg Grenrus.
50+* Support `primitive 0.7.*`, thanks to Adam Bergmark.
51+* Allow `semigroups 0.19.*` and `hashable 1.3.*`, thanks to Oleg Grenrus.
52+* Fix a typo in the error message when parsing `NonEmpty`, thanks to Colin Woodbury.
53+* Document surprising behavior when using `omitNothingFields` with type variables, thanks to Xia Li-Yao.
54+
55+**Internal changes**:
56+* Code cleanup by Oleg Grenrus
57+* Fix dependencies of the benchmarks on older GHC's, thanks to Xia Li-Yao.
58+
59+### 1.4.3.0
60+* Improve error messages for FromJSON in existing instances and GHC Generic implementation. Thanks to Xia Li-Yao & Igor Pashev.
61+* Tweak error-reporting combinators and their documentation. Thanks to Xia Li-Yao.
62+ * `typeMismatch` is now about comparing JSON types (i.e., the expected and actual names of the Value constructor).
63+ * `withObject` and other `with*` combinators now also mention the JSON types they expect
64+ * New `unexpected` and `prependFailure` combinators.
65+* Add `Contravariant` `ToJSONKeyFunction` instance. Thanks to Oleg Grenrus.
66+* Add `KeyValue` instance for `Object`. Thanks to Robert Hensing.
67+* Improve performance when parsing certain large numbers, thanks to Oleg Grenrus.
68+* Add `Data.Aeson.QQ.Simple` - A limited version of aeson-qq. Thanks to Oleg Grenrus.
69+* Exposes internal helper functions like `<?>`, `JSONPath`, and `parseIndexedJSON` from `Data.Aeson` module. Thanks to Abid Uzair.
70+* Better error messages when there are syntax errors parsing objects and arrays. Thanks to Fintan Halpenny.
71+* Support building with `th-abstraction-0.3.0.0` or later. Thanks to Ryan Scott.
72+
73+### 1.4.2.0
74+
75+* Add `Data.Aeson.QQ.Simple` which is a simpler version of the `aeson-qq` package, it does not support interpolation, thanks to Oleg Grenrus.
76+* Add `Contravariant ToJSONKeyFunction` instance, thanks to Oleg Grenrus.
77+* Add `KeyValue Object` instance, thanks to Robert Hensing
78+* Improved performance when parsing large numbers, thanks to Oleg Grenrus.
79+
80+### 1.4.1.0
81+
82+* Optimizations of generics, thanks to Rémy Oudompheng, here are some numbers for GHC 8.4:
83+ * Compilation time: G/BigProduct.hs is 25% faster, G/BigRecord.hs is 2x faster.
84+ * Runtime performance: BigRecord/toJSON/generic and BigProduct/encode/generic are more than 2x faster.
85+* Added To/FromJSON instances for `Void` and Generics's `V1`, thanks to Will Yager
86+* Added To/FromJSON instances for `primitive`'s `Array`, `SmallArray`, `PrimArray` and `UnliftedArray`, thanks to Andrew Thad.
87+* Fixes handling of `UTCTime` wrt. leap seconds , thanks to Adam Schønemann
88+* Warning and documentation fixes thanks to tom-bop, Gabor Greif, Ian Jeffries, and Mateusz Curyło.
89+
90+## 1.4.0.0
91+
92+This release introduces bounds on the size of `Scientific` numbers when they are converted to other arbitrary precision types that do not represent them efficiently in memory.
93+
94+This means that trying to decode a number such as `1e1000000000` into an `Integer` will now fail instead of using a lot of memory. If you need to represent large numbers you can add a newtype (preferably over `Scientific`) and providing a parser using `withScientific`.
95+
96+The following instances are affected by this:
97+* `FromJSON Natural`
98+* `FromJSONKey Natural`
99+* `FromJSON Integer`
100+* `FromJSONKey Integer`
101+* `FromJSON NominalDiffTime`
102+
103+For the same reasons the following instances & functions have been removed:
104+* Remove `FromJSON Data.Attoparsec.Number` instance. Note that `Data.Attoparsec.Number` is deprecated.
105+* Remove deprecated `withNumber`, use `withScientific` instead.
106+
107+Finally, encoding integral values with large exponents now uses scientific notation, this saves space for large numbers.
108+
109+#### 1.3.1.1
110+
111+* Catch 0 denominators when parsing Ratio
112+
113+### 1.3.1.0
114+
115+* Fix bug in generically derived `FromJSON` instances that are using `unwrapUnaryRecords`, thanks to Xia Li-yao
116+* Allow base-compat 0.10.*, thanks to Oleg Grenrus
117+
118+## 1.3.0.0
119+
120+Breaking changes:
121+* `GKeyValue` has been renamed to `KeyValuePair`, thanks to Xia Li-yao
122+* Removed unused `FromJSON` constraint in `withEmbeddedJson`, thanks to Tristan Seligmann
123+
124+Other improvements:
125+* Optimizations of TH toEncoding, thanks to Xia Li-yao
126+* Optimizations of hex decoding when using the default/pure unescape implementation, thanks to Xia Li-yao
127+* Improved error message on `Day` parse failures, thanks to Gershom Bazerman
128+* Add `encodeFile` as well as `decodeFile*` variants, thanks to Markus Hauck
129+* Documentation fixes, thanks to Lennart Spitzner
130+* CPP cleanup, thanks to Ryan Scott
131+
132+### 1.2.4.0
133+
134+* Add `Ord` instance for `JSONPathElement`, thanks to Simon Hengel.
135+
136+
137+### 1.2.3.0
138+
139+* Added `withEmbeddedJSON` to help parse JSON embedded inside a JSON string, thanks to Jesse Kempf.
140+* Memory usage improvements to the default (pure) parser, thanks to Jonathan Paugh. Also thanks to Neil Mitchell & Oleg Grenrus for contributing a benchmark.
141+* `omitNothingFields` now works for the `Option` newtype, thanks to Xia Li-yao.
142+* Some documentation fixes, thanks to Jonathan Paug & Philippe Crama.
143+
144+### 1.2.2.0
145+
146+* Add `FromJSON` and `ToJSON` instances for
147+ * `DiffTime`, thanks to Víctor López Juan.
148+ * `CTime`, thanks to Daniel Díaz.
149+* Fix handling of fractions when parsing Natural, thanks to Yuriy Syrovetskiy.
150+* Change text in error messages for Integral types to make them follow the common pattern, thanks to Yuriy Syrovetskiy.
151+* Add missing `INCOHERENT` pragma for `RecordToPair`, thanks to Xia Li-yao.
152+* Everything related to `Options` is now exported from `Data.Aeson`, thanks to Xia Li-yao.
153+* Optimizations to not escape text in clear cases, thanks to Oleg Grenrus.
154+* Some documentation fixes, thanks to Phil de Joux & Xia Li-yao.
155+
156+### 1.2.1.0
157+
158+* Add `parserThrowError` and `parserCatchError` combinators, thanks to Oleg Grenrus.
159+
160+* Add `Generic` instance for `Value`, thanks to Xia Li-yao.
161+
162+* Fix a mistake in the 1.2.0.0 changelog, the `cffi` flag is disabled by default! Thanks to dbaynard.
163+
164+## 1.2.0.0
165+
166+* `tagSingleConstructors`, an option to encode single-constructor types as tagged sums was added to `Options`. It is disabled by default for backward compatibility.
167+
168+* The `cffi` flag is now turned off (`False`) by default, this means C FFI code is no longer used by default. You can flip the flag to get C implementation.
169+
170+* The `Options` constructor is no longer exposed to prevent new options from being breaking changes, use `defaultOptions` instead.
171+
172+* The contents of `GToJSON` and `GToEncoding` are no longer exposed.
173+
174+* Some INLINE pragmas were removed to avoid GHC running out of simplifier ticks.
175+
3176### 1.1.2.0
4177
5178* Fix an accidental change in the format of `deriveJSON`. Thanks to Xia Li-yao!
examples/Generic.hs+1−1
@@ -6,11 +6,11 @@
66-- automatically derive the Generic class for us.
77
88{-# LANGUAGE DeriveGeneric #-}
9+{-# LANGUAGE NoImplicitPrelude #-}
910{-# LANGUAGE OverloadedStrings #-}
1011
1112module Main (main) where
1213
13−import Prelude ()
1414import Prelude.Compat
1515
1616import Data.Aeson (FromJSON, ToJSON, decode, encode)
examples/Simplest.hs+1−1
@@ -1,9 +1,9 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12{-# LANGUAGE OverloadedStrings #-}
23{-# LANGUAGE RecordWildCards #-}
34
45module Main (main) where
56
6−import Prelude ()
77import Prelude.Compat
88
99import Control.Applicative (empty)
examples/TemplateHaskell.hs+1−1
@@ -1,12 +1,12 @@
11-- We can use Template Haskell (TH) to generate instances of the
22-- FromJSON and ToJSON classes automatically. This is the fastest way
33-- to add JSON support for a type.
4+{-# LANGUAGE NoImplicitPrelude #-}
45{-# LANGUAGE OverloadedStrings #-}
56{-# LANGUAGE TemplateHaskell #-}
67
78module Main (main) where
89
9−import Prelude ()
1010import Prelude.Compat
1111
1212import Data.Aeson (decode, encode)
examples/Twitter.hs+1−2
@@ -10,6 +10,7 @@
1010
1111{-# LANGUAGE DeriveDataTypeable #-}
1212{-# LANGUAGE DeriveGeneric #-}
13+{-# LANGUAGE NoImplicitPrelude #-}
1314
1415module Twitter
1516 (
@@ -19,7 +20,6 @@ module Twitter
1920 , Result(..)
2021 ) where
2122
22−import Prelude ()
2323import Prelude.Compat
2424
2525import Control.DeepSeq
@@ -27,7 +27,6 @@ import Data.Data (Typeable, Data)
2727import Data.Int (Int64)
2828import Data.Text (Text)
2929import GHC.Generics (Generic)
30−import Prelude hiding (id)
3130
3231{-# ANN module "Hlint: ignore Use camelCase" #-}
3332{-# ANN module "Hlint: ignore Use newtype instead of data" #-}
examples/Twitter/Generic.hs+31−36
@@ -1,5 +1,7 @@
11-- Use GHC generics to automatically generate good instances.
2−{-# LANGUAGE CPP #-}
2+
3+{-# LANGUAGE NoImplicitPrelude #-}
4+
35{-# OPTIONS_GHC -fno-warn-orphans #-}
46
57module Twitter.Generic
@@ -10,40 +12,33 @@ module Twitter.Generic
1012 , Result(..)
1113 ) where
1214
13−import Prelude ()
14−import Prelude.Compat
15+import Prelude.Compat ()
1516
1617import Twitter
17−
18−#ifndef HAS_BOTH_AESON_AND_BENCHMARKS
19−import Data.Aeson (ToJSON, FromJSON)
20−#else
21−import "aeson" Data.Aeson (ToJSON, FromJSON)
22−import qualified "aeson-benchmarks" Data.Aeson as B
23−#endif
24−
25−instance ToJSON Metadata
26−instance FromJSON Metadata
27−
28−instance ToJSON Geo
29−instance FromJSON Geo
30−
31−instance ToJSON Story
32−instance FromJSON Story
33−
34−instance ToJSON Result
35−instance FromJSON Result
36−
37−#ifdef HAS_BOTH_AESON_AND_BENCHMARKS
38−instance B.ToJSON Metadata
39−instance B.FromJSON Metadata
40−
41−instance B.ToJSON Geo
42−instance B.FromJSON Geo
43−
44−instance B.ToJSON Story
45−instance B.FromJSON Story
46−
47−instance B.ToJSON Result
48−instance B.FromJSON Result
49−#endif
18+import Twitter.Options
19+
20+import Data.Aeson (ToJSON (..), FromJSON (..), genericToJSON, genericToEncoding, genericParseJSON)
21+
22+instance ToJSON Metadata where
23+ toJSON = genericToJSON twitterOptions
24+ toEncoding = genericToEncoding twitterOptions
25+instance FromJSON Metadata where
26+ parseJSON = genericParseJSON twitterOptions
27+
28+instance ToJSON Geo where
29+ toJSON = genericToJSON twitterOptions
30+ toEncoding = genericToEncoding twitterOptions
31+instance FromJSON Geo where
32+ parseJSON = genericParseJSON twitterOptions
33+
34+instance ToJSON Story where
35+ toJSON = genericToJSON twitterOptions
36+ toEncoding = genericToEncoding twitterOptions
37+instance FromJSON Story where
38+ parseJSON = genericParseJSON twitterOptions
39+
40+instance ToJSON Result where
41+ toJSON = genericToJSON twitterOptions
42+ toEncoding = genericToEncoding twitterOptions
43+instance FromJSON Result where
44+ parseJSON = genericParseJSON twitterOptions
examples/Twitter/Manual.hs+3−139
@@ -1,13 +1,9 @@
11-- Manually write instances.
2−
3−{-# LANGUAGE CPP #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
43{-# LANGUAGE OverloadedStrings #-}
54{-# LANGUAGE RecordWildCards #-}
6−{-# OPTIONS_GHC -fno-warn-orphans #-}
75
8−#ifdef HAS_BOTH_AESON_AND_BENCHMARKS
9−{-# LANGUAGE PackageImports #-}
10−#endif
6+{-# OPTIONS_GHC -fno-warn-orphans #-}
117
128module Twitter.Manual
139 (
@@ -17,20 +13,13 @@ module Twitter.Manual
1713 , Result(..)
1814 ) where
1915
20−import Prelude ()
2116import Prelude.Compat
2217
2318import Control.Applicative
24−import Data.Monoid ((<>))
25−import Prelude hiding (id)
19+import Data.Semigroup ((<>))
2620import Twitter
2721
28−#ifndef HAS_BOTH_AESON_AND_BENCHMARKS
2922import Data.Aeson hiding (Result)
30−#else
31−import "aeson" Data.Aeson hiding (Result)
32−import qualified "aeson-benchmarks" Data.Aeson as B
33−#endif
3423
3524instance ToJSON Metadata where
3625
@@ -155,128 +144,3 @@ instance FromJSON Result where
155144 <*> v .: "max_id_str"
156145 <*> v .: "query"
157146 parseJSON _ = empty
158−
159−#ifdef HAS_BOTH_AESON_AND_BENCHMARKS
160−instance B.ToJSON Metadata where
161− toJSON Metadata{..} = B.object [
162− "result_type" B..= result_type
163− ]
164−
165− toEncoding Metadata{..} = B.pairs $
166− "result_type" B..= result_type
167−
168−instance B.FromJSON Metadata where
169− parseJSON (B.Object v) = Metadata <$> v B..: "result_type"
170− parseJSON _ = empty
171−
172−instance B.ToJSON Geo where
173− toJSON Geo{..} = B.object [
174− "type_" B..= type_
175− , "coordinates" B..= coordinates
176− ]
177−
178− toEncoding Geo{..} = B.pairs $
179− "type_" B..= type_
180− <> "coordinates" B..= coordinates
181−
182−instance B.FromJSON Geo where
183− parseJSON (B.Object v) = Geo <$>
184− v B..: "type_"
185− <*> v B..: "coordinates"
186− parseJSON _ = empty
187−
188−instance B.ToJSON Story where
189− toJSON Story{..} = B.object [
190− "from_user_id_str" B..= from_user_id_str
191− , "profile_image_url" B..= profile_image_url
192− , "created_at" B..= created_at
193− , "from_user" B..= from_user
194− , "id_str" B..= id_str
195− , "metadata" B..= metadata
196− , "to_user_id" B..= to_user_id
197− , "text" B..= text
198− , "id" B..= id_
199− , "from_user_id" B..= from_user_id
200− , "geo" B..= geo
201− , "iso_language_code" B..= iso_language_code
202− , "to_user_id_str" B..= to_user_id_str
203− , "source" B..= source
204− ]
205−
206− toEncoding Story{..} = B.pairs $
207− "from_user_id_str" B..= from_user_id_str
208− <> "profile_image_url" B..= profile_image_url
209− <> "created_at" B..= created_at
210− <> "from_user" B..= from_user
211− <> "id_str" B..= id_str
212− <> "metadata" B..= metadata
213− <> "to_user_id" B..= to_user_id
214− <> "text" B..= text
215− <> "id" B..= id_
216− <> "from_user_id" B..= from_user_id
217− <> "geo" B..= geo
218− <> "iso_language_code" B..= iso_language_code
219− <> "to_user_id_str" B..= to_user_id_str
220− <> "source" B..= source
221−
222−instance B.FromJSON Story where
223− parseJSON (B.Object v) = Story <$>
224− v B..: "from_user_id_str"
225− <*> v B..: "profile_image_url"
226− <*> v B..: "created_at"
227− <*> v B..: "from_user"
228− <*> v B..: "id_str"
229− <*> v B..: "metadata"
230− <*> v B..: "to_user_id"
231− <*> v B..: "text"
232− <*> v B..: "id"
233− <*> v B..: "from_user_id"
234− <*> v B..: "geo"
235− <*> v B..: "iso_language_code"
236− <*> v B..: "to_user_id_str"
237− <*> v B..: "source"
238− parseJSON _ = empty
239−
240−instance B.ToJSON Result where
241− toJSON Result{..} = B.object [
242− "results" B..= results
243− , "max_id" B..= max_id
244− , "since_id" B..= since_id
245− , "refresh_url" B..= refresh_url
246− , "next_page" B..= next_page
247− , "results_per_page" B..= results_per_page
248− , "page" B..= page
249− , "completed_in" B..= completed_in
250− , "since_id_str" B..= since_id_str
251− , "max_id_str" B..= max_id_str
252− , "query" B..= query
253− ]
254−
255− toEncoding Result{..} = B.pairs $
256− "results" B..= results
257− <> "max_id" B..= max_id
258− <> "since_id" B..= since_id
259− <> "refresh_url" B..= refresh_url
260− <> "next_page" B..= next_page
261− <> "results_per_page" B..= results_per_page
262− <> "page" B..= page
263− <> "completed_in" B..= completed_in
264− <> "since_id_str" B..= since_id_str
265− <> "max_id_str" B..= max_id_str
266− <> "query" B..= query
267−
268−instance B.FromJSON Result where
269− parseJSON (B.Object v) = Result <$>
270− v B..: "results"
271− <*> v B..: "max_id"
272− <*> v B..: "since_id"
273− <*> v B..: "refresh_url"
274− <*> v B..: "next_page"
275− <*> v B..: "results_per_page"
276− <*> v B..: "page"
277− <*> v B..: "completed_in"
278− <*> v B..: "since_id_str"
279− <*> v B..: "max_id_str"
280− <*> v B..: "query"
281− parseJSON _ = empty
282−#endif
examples/Twitter/Options.hsnew file+10
@@ -0,0 +1,10 @@
1+module Twitter.Options (module Twitter.Options) where
2+
3+import Data.Aeson
4+
5+twitterOptions :: Options
6+twitterOptions = defaultOptions
7+ { fieldLabelModifier = \x -> case x of
8+ "id_" -> "id"
9+ _ -> x
10+ }
examples/Twitter/TH.hs+7−19
@@ -1,8 +1,8 @@
11-- Use Template Haskell to generate good instances.
22
3−{-# LANGUAGE CPP #-}
4−{-# LANGUAGE PackageImports #-}
3+{-# LANGUAGE NoImplicitPrelude #-}
54{-# LANGUAGE TemplateHaskell #-}
5+
66{-# OPTIONS_GHC -fno-warn-orphans #-}
77
88module Twitter.TH
@@ -13,25 +13,13 @@ module Twitter.TH
1313 , Result(..)
1414 ) where
1515
16−import Prelude ()
1716
1817import Twitter
18+import Twitter.Options
1919
20−#ifndef HAS_BOTH_AESON_AND_BENCHMARKS
2120import Data.Aeson.TH
22−#else
23−import "aeson" Data.Aeson.TH
24−import qualified "aeson-benchmarks" Data.Aeson.TH as B
25−#endif
26−
27−$(deriveJSON defaultOptions ''Metadata)
28−$(deriveJSON defaultOptions ''Geo)
29−$(deriveJSON defaultOptions ''Story)
30−$(deriveJSON defaultOptions ''Result)
3121
32−#ifdef HAS_BOTH_AESON_AND_BENCHMARKS
33−$(B.deriveJSON B.defaultOptions ''Metadata)
34−$(B.deriveJSON B.defaultOptions ''Geo)
35−$(B.deriveJSON B.defaultOptions ''Story)
36−$(B.deriveJSON B.defaultOptions ''Result)
37−#endif
22+$(deriveJSON twitterOptions ''Metadata)
23+$(deriveJSON twitterOptions ''Geo)
24+$(deriveJSON twitterOptions ''Story)
25+$(deriveJSON twitterOptions ''Result)
ffi/Data/Aeson/Parser/UnescapeFFI.hs+1−1
@@ -10,7 +10,7 @@ module Data.Aeson.Parser.UnescapeFFI
1010import Control.Exception (evaluate, throw, try)
1111import Control.Monad.ST.Unsafe (unsafeIOToST, unsafeSTToIO)
1212import Data.ByteString as B
13−import Data.ByteString.Internal as B hiding (c2w)
13+import Data.ByteString.Internal as B
1414import Data.Text.Encoding.Error (UnicodeException (..))
1515import Data.Text.Internal (Text (..))
1616import Data.Text.Internal.Private (runText)
pure/Data/Aeson/Parser/UnescapePure.hs+16−39
@@ -1,7 +1,7 @@
11-- WARNING: This file is security sensitive as it uses unsafeWrite which does
2−-- not check bounds. Any changes should be made with care and I would love to
3−-- get informed about them, just cc me in any PR targetting this file: @eskimor
4−-- I would be happy to review the changes!
2+-- not check bounds. Any changes should be made with care and we would love to
3+-- get informed about them, just cc us in any PR targetting this file: @eskimor @jprider63
4+-- We would be happy to review the changes!
55
66-- The security check at the end (pos > length) only works if pos grows
77-- monotonously, if this condition does not hold, the check is flawed.
@@ -119,38 +119,18 @@ decode UtfTail1 point word = case word of
119119 w | 0x80 <= w && w <= 0xbf -> (UtfGround, setByte1 point word)
120120 _ -> throwDecodeError
121121
122−{-# INLINE decode #-}
123−
124122decodeHex :: Word8 -> Word16
125−decodeHex 48 = 0 -- '0'
126−decodeHex 49 = 1 -- '1'
127−decodeHex 50 = 2 -- '2'
128−decodeHex 51 = 3 -- '3'
129−decodeHex 52 = 4 -- '4'
130−decodeHex 53 = 5 -- '5'
131−decodeHex 54 = 6 -- '6'
132−decodeHex 55 = 7 -- '7'
133−decodeHex 56 = 8 -- '8'
134−decodeHex 57 = 9 -- '9'
135−decodeHex 65 = 10 -- 'A'
136−decodeHex 97 = 10 -- 'a'
137−decodeHex 66 = 11 -- 'B'
138−decodeHex 98 = 11 -- 'b'
139−decodeHex 67 = 12 -- 'C'
140−decodeHex 99 = 12 -- 'c'
141−decodeHex 68 = 13 -- 'D'
142−decodeHex 100 = 13 -- 'd'
143−decodeHex 69 = 14 -- 'E'
144−decodeHex 101 = 14 -- 'e'
145−decodeHex 70 = 15 -- 'F'
146−decodeHex 102 = 15 -- 'f'
147−decodeHex _ = throwDecodeError
148−{-# INLINE decodeHex #-}
123+decodeHex x
124+ | 48 <= x && x <= 57 = fromIntegral x - 48 -- 0-9
125+ | 65 <= x && x <= 70 = fromIntegral x - 55 -- A-F
126+ | 97 <= x && x <= 102 = fromIntegral x - 87 -- a-f
127+ | otherwise = throwDecodeError
149128
150129unescapeText' :: ByteString -> Text
151130unescapeText' bs = runText $ \done -> do
152131 dest <- A.new len
153− (pos, finalState) <- B.foldl' (f' dest) (return (0, StateNone)) bs
132+
133+ (pos, finalState) <- loop dest (0, StateNone) 0
154134
155135 -- Check final state. Currently pos gets only increased over time, so this check should catch overflows.
156136 when ( finalState /= StateNone || pos > len)
@@ -172,11 +152,12 @@ unescapeText' bs = runText $ \done -> do
172152 (st', p) ->
173153 return (pos, StateUtf st' p)
174154
175− {-# INLINE runUtf #-}
176−
177− f' dest m c = m >>= \s -> f dest s c
178−
179− {-# INLINE f' #-}
155+ loop :: A.MArray s -> (Int, State) -> Int -> ST s (Int, State)
156+ loop _ ps i | i >= len = return ps
157+ loop dest ps i = do
158+ let c = B.index bs i -- JP: We can use unsafe index once we prove bounds with Liquid Haskell.
159+ ps' <- f dest ps c
160+ loop dest ps' $ i+1
180161
181162 -- No pending state.
182163 f dest (pos, StateNone) c = runUtf dest pos UtfGround 0 c
@@ -253,8 +234,6 @@ unescapeText' bs = runText $ \done -> do
253234 else
254235 writeAndReturn dest pos u StateNone
255236
256− {-# INLINE f #-}
257−
258237write :: A.MArray s -> Int -> Word16 -> ST s ()
259238write dest pos char =
260239 A.unsafeWrite dest pos char
@@ -270,8 +249,6 @@ throwDecodeError :: a
270249throwDecodeError =
271250 let desc = "Data.Text.Internal.Encoding.decodeUtf8: Invalid UTF-8 stream" in
272251 throw (DecodeError desc Nothing)
273−{-# INLINE throwDecodeError #-}
274252
275253unescapeText :: ByteString -> Either UnicodeException Text
276254unescapeText = unsafeDupablePerformIO . try . evaluate . unescapeText'
277−{-# INLINE unescapeText #-}
run-hlint.shnew file+7
@@ -0,0 +1,7 @@
1+#!/bin/bash
2+
3+if hash hlint 2>/dev/null; then
4+ hlint "$@"
5+else
6+ ./hlint.sh "$@"
7+fi
stack-bench.yaml+10−2
@@ -1,4 +1,12 @@
1−resolver: lts-8.5
1+resolver: nightly-2019-09-21
2+# We use aeson in the snapshot to
3+# - avoid recompilation of criterion
4+# - compare against it
5+# - '.'
6+#
7+# Also we use separate working directory to avoid "unregistering aeson"
8+# caused recompilations
9+work-dir: .stack-work-bench
210packages:
3−- '.'
411- benchmarks
12+extra-deps: []
stack-lts7.yaml → stack-ffi-unescape.yamlrenamed+4−3
@@ -1,8 +1,9 @@
1−resolver: lts-7.19
1+resolver: nightly-2019-09-21
22packages:
33- '.'
4−extra-deps:
5−- integer-logarithms-1
64flags:
75 aeson:
86 fast: true
7+ cffi: true
8+extra-deps:
9+- Diff-0.4.0
stack-lts12.yamlnew file+15
@@ -0,0 +1,15 @@
1+resolver: lts-12.26
2+packages:
3+- '.'
4+- attoparsec-iso8601
5+flags:
6+ aeson:
7+ fast: true
8+ cffi: true
9+extra-deps:
10+- base-orphans-0.8.1
11+- hashable-time-0.2.0.1
12+- QuickCheck-2.13.1
13+- quickcheck-instances-0.3.21
14+- splitmix-0.0.2
15+- time-compat-1.9.2.2
stack-lts6.yamldeleted−11
@@ -1,11 +0,0 @@
1−resolver: lts-6.30
2−packages:
3−- '.'
4−extra-deps:
5−- semigroups-0.18.2
6−- integer-logarithms-1
7−flags:
8− aeson:
9− fast: true
10− semigroups:
11− bytestring-builder: false
stack-lts8.yamldeleted−6
@@ -1,6 +0,0 @@
1−resolver: lts-8.1
2−packages:
3−- '.'
4−flags:
5− aeson:
6− fast: true
stack-nightly.yaml+6−3
@@ -1,8 +1,11 @@
1−resolver: nightly-2017-02-29
1+resolver: nightly-2019-10-14
22packages:
33- '.'
4−extra-deps:
5−- integer-logarithms-1
4+- attoparsec-iso8601
65flags:
76 aeson:
87 fast: true
8+ attoparsec-iso8601:
9+ fast: true
10+extra-deps:
11+- generic-deriving-1.12.4
stack-pure-unescape.yamldeleted−7
@@ -1,7 +0,0 @@
1−resolver: lts-8.1
2−packages:
3−- '.'
4−flags:
5− aeson:
6− fast: true
7− cffi: false
tests/DataFamilies/Encoders.hs+2−2
@@ -1,10 +1,10 @@
11{-# LANGUAGE CPP #-}
22{-# LANGUAGE GADTs #-}
3+{-# LANGUAGE NoImplicitPrelude #-}
34{-# LANGUAGE TemplateHaskell #-}
45
5−module DataFamilies.Encoders where
6+module DataFamilies.Encoders (module DataFamilies.Encoders) where
67
7−import Prelude ()
88import Prelude.Compat
99
1010import Data.Aeson.TH
tests/DataFamilies/Instances.hs+2−1
@@ -1,12 +1,13 @@
11{-# LANGUAGE FlexibleInstances #-}
22{-# LANGUAGE GADTs #-}
3+{-# LANGUAGE NoImplicitPrelude #-}
34{-# LANGUAGE TemplateHaskell #-}
45{-# LANGUAGE TypeFamilies #-}
6+
57{-# OPTIONS_GHC -fno-warn-orphans #-}
68
79module DataFamilies.Instances () where
810
9−import Prelude ()
1011import Prelude.Compat
1112
1213import Data.Aeson.TH
tests/DataFamilies/Properties.hs+6−5
@@ -1,20 +1,21 @@
11{-# LANGUAGE CPP #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
23
34module DataFamilies.Properties (tests) where
45
5−import Prelude ()
66import Prelude.Compat
77
88import DataFamilies.Encoders
99import DataFamilies.Instances ()
10−import Properties hiding (tests)
10+import PropUtils
1111
12−import Test.Framework (Test, testGroup)
13−import Test.Framework.Providers.QuickCheck2 (testProperty)
12+
13+import Test.Tasty (TestTree, testGroup)
14+import Test.Tasty.QuickCheck (testProperty)
1415
1516--------------------------------------------------------------------------------
1617
17−tests :: Test
18+tests :: TestTree
1819tests = testGroup "data families" [
1920 testGroup "template-haskell" [
2021 testGroup "toJSON" [
tests/DataFamilies/Types.hs+2−2
@@ -4,13 +4,13 @@
44{-# LANGUAGE FlexibleInstances #-}
55{-# LANGUAGE GADTs #-}
66{-# LANGUAGE GeneralizedNewtypeDeriving #-}
7+{-# LANGUAGE NoImplicitPrelude #-}
78{-# LANGUAGE StandaloneDeriving #-}
89{-# LANGUAGE TemplateHaskell #-}
910{-# LANGUAGE TypeFamilies #-}
1011
11−module DataFamilies.Types where
12+module DataFamilies.Types (module DataFamilies.Types) where
1213
13−import Prelude ()
1414import Prelude.Compat
1515
1616import Generics.Deriving.TH (deriveAll0)
tests/Encoders.hs+82−8
@@ -1,11 +1,12 @@
11{-# LANGUAGE CPP #-}
22{-# LANGUAGE GADTs #-}
3+{-# LANGUAGE NoImplicitPrelude #-}
34{-# LANGUAGE TemplateHaskell #-}
45
5−module Encoders where
6+module Encoders (module Encoders) where
67
7−import Prelude ()
88import Prelude.Compat
9+import Data.Text (Text)
910
1011import Data.Aeson.TH
1112import Data.Aeson.Types
@@ -96,6 +97,18 @@ gNullaryToEncodingObjectWithSingleField = genericToEncoding optsObjectWithSingle
9697gNullaryParseJSONObjectWithSingleField :: Value -> Parser Nullary
9798gNullaryParseJSONObjectWithSingleField = genericParseJSON optsObjectWithSingleField
9899
100+keyOptions :: JSONKeyOptions
101+keyOptions = defaultJSONKeyOptions { keyModifier = ('k' :) }
102+
103+gNullaryToJSONKey :: Nullary -> Either String Text
104+gNullaryToJSONKey x = case genericToJSONKey keyOptions of
105+ ToJSONKeyText p _ -> Right (p x)
106+ _ -> Left "Should be a ToJSONKeyText"
107+
108+gNullaryFromJSONKey :: Text -> Parser Nullary
109+gNullaryFromJSONKey t = case genericFromJSONKey keyOptions of
110+ FromJSONKeyTextParser p -> p t
111+ _ -> fail "Not a TextParser"
99112
100113--------------------------------------------------------------------------------
101114-- SomeType encoders/decoders
@@ -175,7 +188,6 @@ gSomeTypeToEncoding2ElemArray = genericToEncoding opts2ElemArray
175188gSomeTypeParseJSON2ElemArray :: Value -> Parser (SomeType Int)
176189gSomeTypeParseJSON2ElemArray = genericParseJSON opts2ElemArray
177190
178−#if __GLASGOW_HASKELL__ >= 706
179191gSomeTypeLiftToEncoding2ElemArray :: LiftToEncoding SomeType a
180192gSomeTypeLiftToEncoding2ElemArray = genericLiftToEncoding opts2ElemArray
181193
@@ -184,7 +196,6 @@ gSomeTypeLiftToJSON2ElemArray = genericLiftToJSON opts2ElemArray
184196
185197gSomeTypeLiftParseJSON2ElemArray :: LiftParseJSON SomeType a
186198gSomeTypeLiftParseJSON2ElemArray = genericLiftParseJSON opts2ElemArray
187−#endif
188199
189200
190201gSomeTypeToJSONTaggedObject :: SomeType Int -> Value
@@ -196,7 +207,6 @@ gSomeTypeToEncodingTaggedObject = genericToEncoding optsTaggedObject
196207gSomeTypeParseJSONTaggedObject :: Value -> Parser (SomeType Int)
197208gSomeTypeParseJSONTaggedObject = genericParseJSON optsTaggedObject
198209
199−#if __GLASGOW_HASKELL__ >= 706
200210gSomeTypeLiftToEncodingTaggedObject :: LiftToEncoding SomeType a
201211gSomeTypeLiftToEncodingTaggedObject = genericLiftToEncoding optsTaggedObject
202212
@@ -205,7 +215,6 @@ gSomeTypeLiftToJSONTaggedObject = genericLiftToJSON optsTaggedObject
205215
206216gSomeTypeLiftParseJSONTaggedObject :: LiftParseJSON SomeType a
207217gSomeTypeLiftParseJSONTaggedObject = genericLiftParseJSON optsTaggedObject
208−#endif
209218
210219
211220gSomeTypeToJSONObjectWithSingleField :: SomeType Int -> Value
@@ -217,7 +226,6 @@ gSomeTypeToEncodingObjectWithSingleField = genericToEncoding optsObjectWithSingl
217226gSomeTypeParseJSONObjectWithSingleField :: Value -> Parser (SomeType Int)
218227gSomeTypeParseJSONObjectWithSingleField = genericParseJSON optsObjectWithSingleField
219228
220−#if __GLASGOW_HASKELL__ >= 706
221229gSomeTypeLiftToEncodingObjectWithSingleField :: LiftToEncoding SomeType a
222230gSomeTypeLiftToEncodingObjectWithSingleField = genericLiftToEncoding optsObjectWithSingleField
223231
@@ -226,7 +234,6 @@ gSomeTypeLiftToJSONObjectWithSingleField = genericLiftToJSON optsObjectWithSingl
226234
227235gSomeTypeLiftParseJSONObjectWithSingleField :: LiftParseJSON SomeType a
228236gSomeTypeLiftParseJSONObjectWithSingleField = genericLiftParseJSON optsObjectWithSingleField
229−#endif
230237
231238
232239gSomeTypeToJSONOmitNothingFields :: SomeType Int -> Value
@@ -235,6 +242,58 @@ gSomeTypeToJSONOmitNothingFields = genericToJSON optsOmitNothingFields
235242gSomeTypeToEncodingOmitNothingFields :: SomeType Int -> Encoding
236243gSomeTypeToEncodingOmitNothingFields = genericToEncoding optsOmitNothingFields
237244
245+
246+thSomeTypeParseJSONRejectUnknownFields :: Value -> Parser (SomeType Int)
247+thSomeTypeParseJSONRejectUnknownFields = $(mkParseJSON optsRejectUnknownFields ''SomeType)
248+
249+gSomeTypeParseJSONRejectUnknownFields :: Value -> Parser (SomeType Int)
250+gSomeTypeParseJSONRejectUnknownFields = genericParseJSON optsRejectUnknownFields
251+
252+
253+--------------------------------------------------------------------------------
254+-- Foo decoders
255+--------------------------------------------------------------------------------
256+
257+thFooParseJSONRejectUnknownFields :: Value -> Parser Foo
258+thFooParseJSONRejectUnknownFields = $(mkParseJSON optsRejectUnknownFields ''Foo)
259+
260+gFooParseJSONRejectUnknownFields :: Value -> Parser Foo
261+gFooParseJSONRejectUnknownFields = genericParseJSON optsRejectUnknownFields
262+
263+
264+thFooParseJSONRejectUnknownFieldsTagged :: Value -> Parser Foo
265+thFooParseJSONRejectUnknownFieldsTagged = $(mkParseJSON optsRejectUnknownFieldsTagged ''Foo)
266+
267+gFooParseJSONRejectUnknownFieldsTagged :: Value -> Parser Foo
268+gFooParseJSONRejectUnknownFieldsTagged = genericParseJSON optsRejectUnknownFieldsTagged
269+
270+
271+--------------------------------------------------------------------------------
272+-- Option fields
273+--------------------------------------------------------------------------------
274+
275+thOptionFieldToJSON :: OptionField -> Value
276+thOptionFieldToJSON = $(mkToJSON optsOptionField 'OptionField)
277+
278+thOptionFieldToEncoding :: OptionField -> Encoding
279+thOptionFieldToEncoding = $(mkToEncoding optsOptionField 'OptionField)
280+
281+thOptionFieldParseJSON :: Value -> Parser OptionField
282+thOptionFieldParseJSON = $(mkParseJSON optsOptionField 'OptionField)
283+
284+gOptionFieldToJSON :: OptionField -> Value
285+gOptionFieldToJSON = genericToJSON optsOptionField
286+
287+gOptionFieldToEncoding :: OptionField -> Encoding
288+gOptionFieldToEncoding = genericToEncoding optsOptionField
289+
290+gOptionFieldParseJSON :: Value -> Parser OptionField
291+gOptionFieldParseJSON = genericParseJSON optsOptionField
292+
293+thMaybeFieldToJSON :: MaybeField -> Value
294+thMaybeFieldToJSON = $(mkToJSON optsOptionField 'MaybeField)
295+
296+
238297--------------------------------------------------------------------------------
239298-- IncoherentInstancesNeeded
240299--------------------------------------------------------------------------------
@@ -252,6 +311,11 @@ incoherentInstancesNeededParseJSONString :: FromJSON a => Value -> Parser (Incoh
252311incoherentInstancesNeededParseJSONString = case () of
253312 _ | True -> $(mkParseJSON defaultOptions ''IncoherentInstancesNeeded)
254313 | False -> genericParseJSON defaultOptions
314+
315+incoherentInstancesNeededToJSON :: ToJSON a => IncoherentInstancesNeeded a -> Value
316+incoherentInstancesNeededToJSON = case () of
317+ _ | True -> $(mkToJSON defaultOptions ''IncoherentInstancesNeeded)
318+ | False -> genericToJSON defaultOptions
255319#endif
256320
257321-------------------------------------------------------------------------------
@@ -382,3 +446,13 @@ gOneConstructorToEncodingTagged = genericToEncoding optsTagSingleConstructors
382446
383447gOneConstructorParseJSONTagged :: Value -> Parser OneConstructor
384448gOneConstructorParseJSONTagged = genericParseJSON optsTagSingleConstructors
449+
450+--------------------------------------------------------------------------------
451+-- Product2 encoders/decoders
452+--------------------------------------------------------------------------------
453+
454+thProduct2ParseJSON :: Value -> Parser (Product2 Int Bool)
455+thProduct2ParseJSON = $(mkParseJSON defaultOptions ''Product2)
456+
457+gProduct2ParseJSON :: Value -> Parser (Product2 Int Bool)
458+gProduct2ParseJSON = genericParseJSON defaultOptions
tests/ErrorMessages.hs+208−41
@@ -1,3 +1,4 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
12{-# LANGUAGE OverloadedStrings #-}
23{-# LANGUAGE ScopedTypeVariables #-}
34
@@ -6,52 +7,218 @@ module ErrorMessages
67 tests
78 ) where
89
9−import Prelude ()
1010import Prelude.Compat
1111
12−import Data.Aeson (FromJSON(..), eitherDecode)
12+import Data.Aeson (FromJSON(..), Value, json)
13+import Data.Aeson.Types (Parser)
14+import Data.Aeson.Parser (eitherDecodeWith)
15+import Data.Aeson.Internal (formatError, iparse)
16+import Data.Algorithm.Diff (PolyDiff (..), getGroupedDiff)
1317import Data.Proxy (Proxy(..))
18+import Data.Semigroup ((<>))
19+import Data.Sequence (Seq)
1420import Instances ()
15−import Test.Framework (Test)
16−import Test.Framework.Providers.HUnit (testCase)
17−import Test.HUnit (Assertion, assertFailure, assertEqual)
21+import Numeric.Natural (Natural)
22+import Test.Tasty (TestTree, TestName)
23+import Test.Tasty.Golden.Advanced (goldenTest)
1824import qualified Data.ByteString.Lazy.Char8 as L
1925import qualified Data.HashMap.Strict as HM
2026
21−tests :: [Test]
27+import Encoders
28+import Types
29+
30+tests :: [TestTree]
2231tests =
23− [
24− testCase "Int" int
25− , testCase "String" string
26− , testCase "HashMap" hashMap
27− ]
28−
29−int :: Assertion
30−int = do
31− let t = test (Proxy :: Proxy Int)
32− t "\"\"" $ expected "Int" "String"
33− t "[]" $ expected "Int" "Array"
34− t "{}" $ expected "Int" "Object"
35− t "null" $ expected "Int" "Null"
36−
37−string :: Assertion
38−string = do
39− let t = test (Proxy :: Proxy String)
40− t "1" $ expected "String" "Number"
41− t "[]" $ expected "String" "Array"
42− t "{}" $ expected "String" "Object"
43− t "null" $ expected "String" "Null"
44−
45−hashMap :: Assertion
46−hashMap = do
47− let t = test (Proxy :: Proxy (HM.HashMap String Int))
48− t "\"\"" $ expected "HashMap k v" "String"
49− t "[]" $ expected "HashMap k v" "Array"
50−
51−expected :: String -> String -> String
52−expected ex enc = "Error in $: expected " ++ ex ++ ", encountered " ++ enc
53−
54−test :: forall a proxy . (FromJSON a, Show a) => proxy a -> L.ByteString -> String -> Assertion
55−test _ v msg = case eitherDecode v of
56− Left e -> assertEqual "Invalid error message" msg e
57− Right (x :: a) -> assertFailure $ "Expected parsing to fail but it suceeded with: " ++ show x
32+ [ aesonGoldenTest "simple" "tests/golden/simple.expected" output
33+ , aesonGoldenTest "generic" "tests/golden/generic.expected" (outputGeneric G)
34+ ]
35+
36+output :: Output
37+output = concat
38+ [ testFor "Int" (Proxy :: Proxy Int)
39+ [ "\"\""
40+ , "[]"
41+ , "{}"
42+ , "null"
43+ ]
44+
45+ , testFor "Integer" (Proxy :: Proxy Integer)
46+ [ "44.44"
47+ ]
48+
49+ , testFor "Natural" (Proxy :: Proxy Natural)
50+ [ "44.44"
51+ , "-50"
52+ ]
53+
54+ , testFor "String" (Proxy :: Proxy String)
55+ [ "1"
56+ , "[]"
57+ , "{}"
58+ , "null"
59+ ]
60+
61+ , testFor "HashMap" (Proxy :: Proxy (HM.HashMap String Int))
62+ [ "\"\""
63+ , "[]"
64+ ]
65+
66+ -- issue #356
67+ , testFor "Either" (Proxy :: Proxy (Int, Either (Int, Bool) ()))
68+ [ "[1,{\"Left\":[2,3]}]"
69+ ]
70+
71+ -- issue #358
72+ , testFor "Seq" (Proxy :: Proxy (Seq Int))
73+ [ "[0,1,true]"
74+ ]
75+ ]
76+
77+data Choice = TH | G
78+
79+outputGeneric :: Choice -> Output
80+outputGeneric choice = concat
81+ [ testWith "OneConstructor"
82+ (select
83+ thOneConstructorParseJSONDefault
84+ gOneConstructorParseJSONDefault)
85+ [ "\"X\""
86+ , "[0]"
87+ ]
88+
89+ , testWith "Nullary"
90+ (select
91+ thNullaryParseJSONString
92+ gNullaryParseJSONString)
93+ [ "\"X\""
94+ , "[]"
95+ ]
96+
97+ , testWithSomeType "SomeType (tagged)"
98+ (select
99+ thSomeTypeParseJSONTaggedObject
100+ gSomeTypeParseJSONTaggedObject)
101+ [ "{\"tag\": \"unary\", \"contents\": true}"
102+ , "{\"tag\": \"unary\"}"
103+ , "{\"tag\": \"record\"}"
104+ , "{\"tag\": \"record\", \"testone\": true, \"testtwo\": null, \"testthree\": null}"
105+ , "{\"tag\": \"X\"}"
106+ , "{}"
107+ , "[]"
108+ ]
109+
110+ , testWithSomeType "SomeType (single-field)"
111+ (select
112+ thSomeTypeParseJSONObjectWithSingleField
113+ gSomeTypeParseJSONObjectWithSingleField)
114+ [ "{\"unary\": {}}"
115+ , "{\"unary\": []}"
116+ , "{\"X\": []}"
117+ , "{\"record\": {}, \"W\":{}}"
118+ , "{}"
119+ , "[]"
120+ , "{\"unary\""
121+ , "{\"unary\":"
122+ , "{\"unary\":1"
123+ ]
124+
125+ , testWithSomeType "SomeType (two-element array)"
126+ (select
127+ thSomeTypeParseJSON2ElemArray
128+ gSomeTypeParseJSON2ElemArray)
129+ [ "[\"unary\", true]"
130+ , "[\"record\", null]"
131+ , "[\"X\", 0]"
132+ , "[null, 0]"
133+ , "[]"
134+ , "{}"
135+ , "[1"
136+ , "[1,"
137+ ]
138+
139+ , testWithSomeType "SomeType (reject unknown fields)"
140+ (select
141+ thSomeTypeParseJSONRejectUnknownFields
142+ gSomeTypeParseJSONRejectUnknownFields)
143+ [ "{\"tag\": \"record\", \"testOne\": 1.0, \"testZero\": 1}"
144+ , "{\"testZero\": 1}"
145+ , "{\"tag\": \"record\", \"testone\": true, \"testtwo\": null, \"testthree\": null}"
146+ ]
147+
148+ , testWithFoo "Foo (reject unknown fields)"
149+ (select
150+ thFooParseJSONRejectUnknownFields
151+ gFooParseJSONRejectUnknownFields)
152+ [ "{\"tag\": \"foo\"}"
153+ ]
154+
155+ , testWithFoo "Foo (reject unknown fields, tagged single)"
156+ (select
157+ thFooParseJSONRejectUnknownFieldsTagged
158+ gFooParseJSONRejectUnknownFieldsTagged)
159+ [ "{\"tag\": \"foo\", \"unknownField\": 0}"
160+ ]
161+
162+ , testWith "EitherTextInt"
163+ (select
164+ thEitherTextIntParseJSONUntaggedValue
165+ gEitherTextIntParseJSONUntaggedValue)
166+ [ "\"X\""
167+ , "[]"
168+ ]
169+
170+ , testWith "Product2 Int Bool"
171+ (select
172+ thProduct2ParseJSON
173+ gProduct2ParseJSON)
174+ [ "[1, null]"
175+ , "[]"
176+ , "{}"
177+ ]
178+ ]
179+ where
180+ select a b = case choice of
181+ TH -> a
182+ G -> b
183+
184+-- Test infrastructure
185+
186+type Output = [String]
187+
188+outputLine :: String -> Output
189+outputLine = pure
190+
191+aesonGoldenTest :: TestName -> FilePath -> Output -> TestTree
192+aesonGoldenTest name ref out = goldenTest name (L.readFile ref) act cmp upd
193+ where
194+ act = pure (L.pack (unlines out))
195+ upd = L.writeFile ref
196+ cmp x y | x == y = return Nothing
197+ cmp x y = return $ Just $ unlines $
198+ concatMap f (getGroupedDiff (L.lines x) (L.lines y))
199+ where
200+ f (First xs) = map (cons3 '-' . L.unpack) xs
201+ f (Second ys) = map (cons3 '+' . L.unpack) ys
202+ -- we print unchanged lines too. It shouldn't be a problem while we have
203+ -- reasonably small examples
204+ f (Both xs _) = map (cons3 ' ' . L.unpack) xs
205+ -- we add three characters, so the changed lines are easier to spot
206+ cons3 c cs = c : c : c : ' ' : cs
207+
208+testWith :: Show a => String -> (Value -> Parser a) -> [L.ByteString] -> Output
209+testWith name parser ts =
210+ outputLine name <>
211+ foldMap (\s ->
212+ case eitherDecodeWith json (iparse parser) s of
213+ Left err -> outputLine $ uncurry formatError err
214+ Right a -> outputLine $ show a) ts
215+
216+testFor :: forall a proxy. (FromJSON a, Show a)
217+ => String -> proxy a -> [L.ByteString] -> Output
218+testFor name _ = testWith name (parseJSON :: Value -> Parser a)
219+
220+testWithSomeType :: String -> (Value -> Parser (SomeType Int)) -> [L.ByteString] -> Output
221+testWithSomeType = testWith
222+
223+testWithFoo :: String -> (Value -> Parser Foo) -> [L.ByteString] -> Output
224+testWithFoo = testWith
tests/Functions.hs+2−1
@@ -1,10 +1,11 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
13module Functions
24 (
35 approxEq
46 , approxEqWith
57 ) where
68
7−import Prelude ()
89import Prelude.Compat
910
1011approxEq :: (Fractional a, Ord a) => a -> a -> Bool
tests/Instances.hs+7−69
@@ -1,22 +1,19 @@
1−{-# LANGUAGE CPP #-}
21{-# LANGUAGE FlexibleContexts #-}
32{-# LANGUAGE FlexibleInstances #-}
3+{-# LANGUAGE NoImplicitPrelude #-}
44{-# LANGUAGE OverloadedStrings #-}
55{-# LANGUAGE RecordWildCards #-}
6+
67{-# OPTIONS_GHC -fno-warn-orphans #-}
78
89module Instances () where
910
10−import Prelude ()
1111import Prelude.Compat
1212
1313import Control.Applicative (empty)
1414import Control.Monad
1515import Data.Aeson.Types
1616import Data.Function (on)
17−import Data.Functor.Compose (Compose (..))
18−import Data.Proxy (Proxy(..))
19−import Data.Tagged (Tagged(..))
2017import Data.Time (ZonedTime(..), TimeZone(..))
2118import Data.Time.Clock (UTCTime(..))
2219import Functions
@@ -24,32 +21,15 @@ import Test.QuickCheck (Arbitrary(..), elements, oneof)
2421import Types
2522import qualified Data.DList as DList
2623import qualified Data.HashMap.Strict as HM
27−import qualified Data.UUID.Types as UUID
28−
29−#if !MIN_VERSION_QuickCheck(2,9,0)
30−import Control.Applicative (Const(..))
31−import Data.Functor.Identity (Identity (..))
32−import Data.List.NonEmpty (NonEmpty(..))
33−import Data.Version
34−import Test.QuickCheck (getNonNegative, listOf1, resize)
35−#endif
3624
3725import Data.Orphans ()
3826import Test.QuickCheck.Instances ()
39−#if MIN_VERSION_base(4,7,0)
4027import Data.Hashable.Time ()
41−#endif
42−
43−#if !MIN_VERSION_base(4,8,0) && !MIN_VERSION_QuickCheck(2,8,3)
44−import Numeric.Natural
45−#endif
46−
47−{-# ANN module ("HLint: ignore Use fewer imports"::String) #-}
4828
4929-- "System" types.
5030
5131instance Arbitrary DotNetTime where
52− arbitrary = DotNetTime `liftM` arbitrary
32+ arbitrary = DotNetTime `fmap` arbitrary
5333 shrink = map DotNetTime . shrink . fromDotNetTime
5434
5535-- | Compare timezone part only on 'timeZoneMinutes'
@@ -173,57 +153,15 @@ instance Arbitrary EitherTextInt where
173153instance Arbitrary (GADT String) where
174154 arbitrary = GADT <$> arbitrary
175155
156+instance Arbitrary OptionField where
157+ arbitrary = OptionField <$> arbitrary
158+
159+
176160instance ApproxEq Char where
177161 (=~) = (==)
178162
179163instance (ApproxEq a) => ApproxEq [a] where
180164 a =~ b = length a == length b && all (uncurry (=~)) (zip a b)
181165
182−-- Version tags are deprecated, so we avoid using them in the Arbitrary
183−-- instance. However, the recommended constructor 'makeVersion' is not
184−-- exported by "Data.Version" until base-4.8.0.0. For previous versions,
185−-- a definition is given below.
186−
187−
188−#if !MIN_VERSION_base(4,8,0) && !MIN_VERSION_QuickCheck(2,8,3)
189−instance Arbitrary Natural where
190− arbitrary = fromInteger . abs <$> arbitrary
191−#endif
192−
193−instance Arbitrary (Proxy a) where
194− arbitrary = pure Proxy
195−
196−instance Arbitrary b => Arbitrary (Tagged a b) where
197− arbitrary = Tagged <$> arbitrary
198−
199166instance Arbitrary a => Arbitrary (DList.DList a) where
200167 arbitrary = DList.fromList <$> arbitrary
201−
202−instance Arbitrary (f (g a)) => Arbitrary (Compose f g a) where
203− arbitrary = Compose <$> arbitrary
204−
205−#if !MIN_VERSION_QuickCheck(2,9,0)
206−instance Arbitrary a => Arbitrary (Const a b) where
207− arbitrary = Const <$> arbitrary
208−
209−instance Arbitrary a => Arbitrary (NonEmpty a) where
210− arbitrary = (:|) <$> arbitrary <*> arbitrary
211−
212−instance Arbitrary Version where
213− arbitrary = makeVersion . fmap getNonNegative <$> resize 4 (listOf1 arbitrary)
214−
215−#if !MIN_VERSION_base(4,8,0)
216−makeVersion :: [Int] -> Version
217−makeVersion b = Version b []
218−#endif
219−
220−instance Arbitrary a => Arbitrary (Identity a) where
221− arbitrary = Identity <$> arbitrary
222−#endif
223−
224−instance Arbitrary UUID.UUID where
225− arbitrary = UUID.fromWords
226− <$> arbitrary
227− <*> arbitrary
228− <*> arbitrary
229− <*> arbitrary
tests/JSONTestSuite/parsers/test_haskell-aeson/src/Main.hs+1−1
@@ -1,6 +1,6 @@
11{-# LANGUAGE ScopedTypeVariables #-}
22
3−module Main where
3+module Main (main) where
44
55import qualified Data.Aeson as Aeson
66import qualified Data.ByteString as Bytes
tests/JSONTestSuite/parsers/test_haskell-aeson/testaeson.cabal+5−3
@@ -1,6 +1,8 @@
1−-- This file has been generated from package.yaml by hpack version 0.14.0.
1+-- This file has been generated from package.yaml by hpack version 0.28.2.
22--
33-- see: https://github.com/sol/hpack
4+--
5+-- hash: 716ef4c3e64849526f097b85ed05015e0072c2e2afcc1f91e58d8bea68b123b2
46
57name: testaeson
68version: 0.0.0
@@ -12,8 +14,8 @@ executable testaeson
1214 hs-source-dirs:
1315 src
1416 build-depends:
15− base >= 4.7 && < 5
16− , aeson
17+ aeson
18+ , base >=4.7 && <5
1719 , base-prelude
1820 , bytestring
1921 default-language: Haskell2010
tests/Options.hs+20−2
@@ -1,6 +1,7 @@
1−module Options where
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
3+module Options (module Options) where
24
3−import Prelude ()
45import Prelude.Compat
56
67import Data.Aeson.Types
@@ -48,3 +49,20 @@ optsTagSingleConstructors = optsDefault
4849 { tagSingleConstructors = True
4950 , allNullaryToStringTag = False
5051 }
52+
53+optsOptionField :: Options
54+optsOptionField = optsDefault
55+ { fieldLabelModifier = const "field"
56+ , omitNothingFields = True
57+ }
58+
59+optsRejectUnknownFields :: Options
60+optsRejectUnknownFields = optsDefault
61+ { rejectUnknownFields = True
62+ }
63+
64+optsRejectUnknownFieldsTagged :: Options
65+optsRejectUnknownFieldsTagged = optsDefault
66+ { rejectUnknownFields = True
67+ , tagSingleConstructors = True
68+ }
tests/PropUtils.hsnew file+208
@@ -0,0 +1,208 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+{-# LANGUAGE OverloadedStrings #-}
3+{-# LANGUAGE RankNTypes #-}
4+
5+module PropUtils (module PropUtils) where
6+
7+import Prelude.Compat
8+
9+import Data.Aeson (eitherDecode, encode)
10+import Data.Aeson.Encoding (encodingToLazyByteString)
11+import Data.Aeson.Internal (IResult(..), formatError, ifromJSON, iparse)
12+import qualified Data.Aeson.Internal as I
13+import Data.Aeson.Parser (value)
14+import Data.Aeson.Types
15+import Data.HashMap.Strict (HashMap)
16+import Data.Hashable (Hashable)
17+import Data.Int (Int8)
18+import Data.Map (Map)
19+import Data.Time (ZonedTime)
20+import Encoders
21+import Instances ()
22+import Test.QuickCheck (Arbitrary(..), Property, Testable, (===), (.&&.), counterexample)
23+import Types
24+import qualified Data.Attoparsec.Lazy as L
25+import qualified Data.ByteString.Lazy.Char8 as L
26+import qualified Data.HashMap.Strict as H
27+import qualified Data.Map as Map
28+import qualified Data.Text as T
29+import qualified Data.Vector as V
30+
31+
32+encodeDouble :: Double -> Double -> Property
33+encodeDouble num denom
34+ | isInfinite d || isNaN d = encode d === "null"
35+ | otherwise = (read . L.unpack . encode) d === d
36+ where d = num / denom
37+
38+encodeInteger :: Integer -> Property
39+encodeInteger i = encode i === L.pack (show i)
40+
41+toParseJSON :: (Eq a, Show a) =>
42+ (Value -> Parser a) -> (a -> Value) -> a -> Property
43+toParseJSON parsejson tojson x =
44+ case iparse parsejson . tojson $ x of
45+ IError path msg -> failure "parse" (formatError path msg) x
46+ ISuccess x' -> x === x'
47+
48+toParseJSON1
49+ :: (Eq (f Int), Show (f Int))
50+ => (forall a. LiftParseJSON f a)
51+ -> (forall a. LiftToJSON f a)
52+ -> f Int
53+ -> Property
54+toParseJSON1 parsejson1 tojson1 = toParseJSON parsejson tojson
55+ where
56+ parsejson = parsejson1 parseJSON (listParser parseJSON)
57+ tojson = tojson1 toJSON (listValue toJSON)
58+
59+roundTripEnc :: (FromJSON a, ToJSON a, Show a) =>
60+ (a -> a -> Property) -> a -> a -> Property
61+roundTripEnc eq _ i =
62+ case fmap ifromJSON . L.parse value . encode $ i of
63+ L.Done _ (ISuccess v) -> v `eq` i
64+ L.Done _ (IError path err) -> failure "fromJSON" (formatError path err) i
65+ L.Fail _ _ err -> failure "parse" err i
66+
67+roundTripNoEnc :: (FromJSON a, ToJSON a, Show a) =>
68+ (a -> a -> Property) -> a -> a -> Property
69+roundTripNoEnc eq _ i =
70+ case ifromJSON . toJSON $ i of
71+ (ISuccess v) -> v `eq` i
72+ (IError path err) -> failure "fromJSON" (formatError path err) i
73+
74+roundTripEq :: (Eq a, FromJSON a, ToJSON a, Show a) => a -> a -> Property
75+roundTripEq x y = roundTripEnc (===) x y .&&. roundTripNoEnc (===) x y
76+
77+-- We test keys by encoding HashMap and Map with it
78+roundTripKey
79+ :: (Ord a, Hashable a, FromJSONKey a, ToJSONKey a, Show a)
80+ => a -> HashMap a Int -> Map a Int -> Property
81+roundTripKey _ h m = roundTripEq h h .&&. roundTripEq m m
82+
83+infix 4 ==~
84+(==~) :: (ApproxEq a, Show a) => a -> a -> Property
85+x ==~ y =
86+ counterexample (show x ++ " /= " ++ show y) (x =~ y)
87+
88+toFromJSON :: (Arbitrary a, Eq a, FromJSON a, ToJSON a, Show a) => a -> Property
89+toFromJSON x = case ifromJSON (toJSON x) of
90+ IError path err -> failure "fromJSON" (formatError path err) x
91+ ISuccess x' -> x === x'
92+
93+modifyFailureProp :: String -> String -> Bool
94+modifyFailureProp orig added =
95+ result == Error (added ++ orig)
96+ where
97+ parser = const $ modifyFailure (added ++) $ fail orig
98+ result :: Result ()
99+ result = parse parser ()
100+
101+parserThrowErrorProp :: String -> Property
102+parserThrowErrorProp msg =
103+ result === Error msg
104+ where
105+ parser = const $ parserThrowError [] msg
106+ result :: Result ()
107+ result = parse parser ()
108+
109+-- | Tests (also) that we catch the JSONPath and it has elements in the right order.
110+parserCatchErrorProp :: [String] -> String -> Property
111+parserCatchErrorProp path msg =
112+ result === Success ([I.Key "outer", I.Key "inner"] ++ jsonPath, msg)
113+ where
114+ parser = parserCatchError outer (curry pure)
115+
116+ outer = inner I.<?> I.Key "outer"
117+ inner = parserThrowError jsonPath msg I.<?> I.Key "inner"
118+
119+ result :: Result (I.JSONPath, String)
120+ result = parse (const parser) ()
121+
122+ jsonPath = map (I.Key . T.pack) path
123+
124+-- | Perform a structural comparison of the results of two encoding
125+-- methods. Compares decoded values to account for HashMap-driven
126+-- variation in JSON object key ordering.
127+sameAs :: (a -> Value) -> (a -> Encoding) -> a -> Property
128+sameAs toVal toEnc v =
129+ counterexample (show s) $
130+ eitherDecode s === Right (toVal v)
131+ where
132+ s = encodingToLazyByteString (toEnc v)
133+
134+sameAs1
135+ :: (forall a. LiftToJSON f a)
136+ -> (forall a. LiftToEncoding f a)
137+ -> f Int
138+ -> Property
139+sameAs1 toVal1 toEnc1 v = lhs === rhs
140+ where
141+ rhs = Right $ toVal1 toJSON (listValue toJSON) v
142+ lhs = eitherDecode . encodingToLazyByteString $
143+ toEnc1 toEncoding (listEncoding toEncoding) v
144+
145+sameAs1Agree
146+ :: ToJSON a
147+ => (f a -> Encoding)
148+ -> (forall b. LiftToEncoding f b)
149+ -> f a
150+ -> Property
151+sameAs1Agree toEnc toEnc1 v = rhs === lhs
152+ where
153+ rhs = encodingToLazyByteString $ toEnc v
154+ lhs = encodingToLazyByteString $ toEnc1 toEncoding (listEncoding toEncoding) v
155+
156+type P6 = Product6 Int Bool String (Approx Double) (Int, Approx Double) ()
157+type S4 = Sum4 Int8 ZonedTime T.Text (Map.Map String Int)
158+
159+--------------------------------------------------------------------------------
160+-- Value properties
161+--------------------------------------------------------------------------------
162+
163+-- | Add the formatted @Value@ to the printed counterexample when the property
164+-- fails.
165+checkValue :: Testable a => (Value -> a) -> Value -> Property
166+checkValue prop v = counterexample (L.unpack (encode v)) (prop v)
167+
168+isString :: Value -> Bool
169+isString (String _) = True
170+isString _ = False
171+
172+is2ElemArray :: Value -> Bool
173+is2ElemArray (Array v) = V.length v == 2 && isString (V.head v)
174+is2ElemArray _ = False
175+
176+isTaggedObjectValue :: Value -> Bool
177+isTaggedObjectValue (Object obj) = "tag" `H.member` obj &&
178+ "contents" `H.member` obj
179+isTaggedObjectValue _ = False
180+
181+isNullaryTaggedObject :: Value -> Bool
182+isNullaryTaggedObject obj = isTaggedObject' obj && isObjectWithSingleField obj
183+
184+isTaggedObject :: Value -> Property
185+isTaggedObject = checkValue isTaggedObject'
186+
187+isTaggedObject' :: Value -> Bool
188+isTaggedObject' (Object obj) = "tag" `H.member` obj
189+isTaggedObject' _ = False
190+
191+isObjectWithSingleField :: Value -> Bool
192+isObjectWithSingleField (Object obj) = H.size obj == 1
193+isObjectWithSingleField _ = False
194+
195+-- | is untaggedValue of EitherTextInt
196+isUntaggedValueETI :: Value -> Bool
197+isUntaggedValueETI (String s)
198+ | s == "nonenullary" = True
199+isUntaggedValueETI (Bool _) = True
200+isUntaggedValueETI (Number _) = True
201+isUntaggedValueETI (Array a) = length a == 2
202+isUntaggedValueETI _ = False
203+
204+isEmptyArray :: Value -> Property
205+isEmptyArray = checkValue isEmptyArray'
206+
207+isEmptyArray' :: Value -> Bool
208+isEmptyArray' = (Array mempty ==)
tests/Properties.hs+17−488
@@ -1,302 +1,28 @@
1−{-# LANGUAGE CPP #-}
2−{-# LANGUAGE FlexibleContexts #-} -- For arbitrary Compose
3−{-# LANGUAGE OverloadedStrings #-}
4−{-# LANGUAGE RankNTypes #-}
5−{-# LANGUAGE ScopedTypeVariables #-}
1+{-# LANGUAGE NoImplicitPrelude #-}
62
7−module Properties where
3+module Properties (module Properties) where
84
9−import Prelude ()
105import Prelude.Compat
116
12−import Control.Applicative (Const)
13−import Data.Aeson (eitherDecode, encode)
14−import Data.Aeson.Encoding (encodingToLazyByteString)
15−import Data.Aeson.Internal (IResult(..), formatError, ifromJSON, iparse)
16−import Data.Aeson.Parser (value)
17−import Data.Aeson.Types
18−import Data.DList (DList)
19−import Data.Functor.Compose (Compose (..))
20−import Data.HashMap.Strict (HashMap)
21−import Data.Hashable (Hashable)
22−import Data.Int (Int8)
23−import Data.List.NonEmpty (NonEmpty)
24−import Data.Map (Map)
25−import Data.Proxy (Proxy)
26−import Data.Ratio (Ratio)
27−import Data.Sequence (Seq)
28−import Data.Tagged (Tagged)
29−import Data.Time (Day, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
30−import Data.Version (Version)
31−import Encoders
327import Instances ()
33−import Numeric.Natural (Natural)
34−import Test.Framework (Test, testGroup)
35−import Test.Framework.Providers.QuickCheck2 (testProperty)
36−import Test.QuickCheck (Arbitrary(..), Property, Testable, (===), (.&&.), counterexample)
37−import Types
38−import qualified Data.Attoparsec.Lazy as L
39−import qualified Data.ByteString.Lazy.Char8 as L
40−import qualified Data.HashMap.Strict as H
41−import qualified Data.Map as Map
42−import qualified Data.Text as T
43−import qualified Data.Text.Lazy as LT
44−import qualified Data.UUID.Types as UUID
45−import qualified Data.Vector as V
8+import Test.Tasty (TestTree, testGroup)
9+import Test.Tasty.QuickCheck (testProperty)
10+import Test.QuickCheck (Property)
11+import PropUtils
12+import PropertyGeneric
13+import PropertyKeys
14+import PropertyRoundTrip
15+import PropertyTH
4616
47−encodeDouble :: Double -> Double -> Property
48−encodeDouble num denom
49− | isInfinite d || isNaN d = encode d === "null"
50− | otherwise = (read . L.unpack . encode) d === d
51− where d = num / denom
5217
53−encodeInteger :: Integer -> Property
54−encodeInteger i = encode i === L.pack (show i)
55−
56−toParseJSON :: (Eq a, Show a) =>
57− (Value -> Parser a) -> (a -> Value) -> a -> Property
58−toParseJSON parsejson tojson x =
59− case iparse parsejson . tojson $ x of
60− IError path msg -> failure "parse" (formatError path msg) x
61− ISuccess x' -> x === x'
62−
63−toParseJSON1
64− :: (Eq (f Int), Show (f Int))
65− => (forall a. LiftParseJSON f a)
66− -> (forall a. LiftToJSON f a)
67− -> f Int
68− -> Property
69−toParseJSON1 parsejson1 tojson1 = toParseJSON parsejson tojson
70− where
71− parsejson = parsejson1 parseJSON (listParser parseJSON)
72− tojson = tojson1 toJSON (listValue toJSON)
73−
74−roundTripEnc :: (FromJSON a, ToJSON a, Show a) =>
75− (a -> a -> Property) -> a -> a -> Property
76−roundTripEnc eq _ i =
77− case fmap ifromJSON . L.parse value . encode $ i of
78− L.Done _ (ISuccess v) -> v `eq` i
79− L.Done _ (IError path err) -> failure "fromJSON" (formatError path err) i
80− L.Fail _ _ err -> failure "parse" err i
81−
82−roundTripNoEnc :: (FromJSON a, ToJSON a, Show a) =>
83− (a -> a -> Property) -> a -> a -> Property
84−roundTripNoEnc eq _ i =
85− case ifromJSON . toJSON $ i of
86− (ISuccess v) -> v `eq` i
87− (IError path err) -> failure "fromJSON" (formatError path err) i
88−
89−roundTripEq :: (Eq a, FromJSON a, ToJSON a, Show a) => a -> a -> Property
90−roundTripEq x y = roundTripEnc (===) x y .&&. roundTripNoEnc (===) x y
91−
92−-- We test keys by encoding HashMap and Map with it
93−roundTripKey
94− :: (Ord a, Hashable a, FromJSONKey a, ToJSONKey a, Show a)
95− => a -> HashMap a Int -> Map a Int -> Property
96−roundTripKey _ h m = roundTripEq h h .&&. roundTripEq m m
97−
98−infix 4 ==~
99−(==~) :: (ApproxEq a, Show a) => a -> a -> Property
100−x ==~ y =
101− counterexample (show x ++ " /= " ++ show y) (x =~ y)
102−
103−toFromJSON :: (Arbitrary a, Eq a, FromJSON a, ToJSON a, Show a) => a -> Property
104−toFromJSON x = case ifromJSON (toJSON x) of
105− IError path err -> failure "fromJSON" (formatError path err) x
106− ISuccess x' -> x === x'
107−
108−modifyFailureProp :: String -> String -> Bool
109−modifyFailureProp orig added =
110− result == Error (added ++ orig)
111− where
112− parser = const $ modifyFailure (added ++) $ fail orig
113− result :: Result ()
114− result = parse parser ()
115−
116−-- | Perform a structural comparison of the results of two encoding
117−-- methods. Compares decoded values to account for HashMap-driven
118−-- variation in JSON object key ordering.
119−sameAs :: (a -> Value) -> (a -> Encoding) -> a -> Property
120−sameAs toVal toEnc v =
121− eitherDecode (encodingToLazyByteString (toEnc v)) === Right (toVal v)
122−
123−sameAs1
124− :: (forall a. LiftToJSON f a)
125− -> (forall a. LiftToEncoding f a)
126− -> f Int
127− -> Property
128−sameAs1 toVal1 toEnc1 v = lhs === rhs
129− where
130− rhs = Right $ toVal1 toJSON (listValue toJSON) v
131− lhs = eitherDecode . encodingToLazyByteString $
132− toEnc1 toEncoding (listEncoding toEncoding) v
133−
134−sameAs1Agree
135− :: ToJSON a
136− => (f a -> Encoding)
137− -> (forall b. LiftToEncoding f b)
138− -> f a
139− -> Property
140−sameAs1Agree toEnc toEnc1 v = rhs === lhs
141− where
142− rhs = encodingToLazyByteString $ toEnc v
143− lhs = encodingToLazyByteString $ toEnc1 toEncoding (listEncoding toEncoding) v
144−
145−type P6 = Product6 Int Bool String (Approx Double) (Int, Approx Double) ()
146−type S4 = Sum4 Int8 ZonedTime T.Text (Map.Map String Int)
147−
148−--------------------------------------------------------------------------------
149−-- Value properties
150−--------------------------------------------------------------------------------
151−
152−-- | Add the formatted @Value@ to the printed counterexample when the property
153−-- fails.
154−checkValue :: Testable a => (Value -> a) -> Value -> Property
155−checkValue prop v = counterexample (L.unpack (encode v)) (prop v)
156−
157−isString :: Value -> Bool
158−isString (String _) = True
159−isString _ = False
160−
161−is2ElemArray :: Value -> Bool
162−is2ElemArray (Array v) = V.length v == 2 && isString (V.head v)
163−is2ElemArray _ = False
164−
165−isTaggedObjectValue :: Value -> Bool
166−isTaggedObjectValue (Object obj) = "tag" `H.member` obj &&
167− "contents" `H.member` obj
168−isTaggedObjectValue _ = False
169−
170−isNullaryTaggedObject :: Value -> Bool
171−isNullaryTaggedObject obj = isTaggedObject' obj && isObjectWithSingleField obj
172−
173−isTaggedObject :: Value -> Property
174−isTaggedObject = checkValue isTaggedObject'
175−
176−isTaggedObject' :: Value -> Bool
177−isTaggedObject' (Object obj) = "tag" `H.member` obj
178−isTaggedObject' _ = False
179−
180−isObjectWithSingleField :: Value -> Bool
181−isObjectWithSingleField (Object obj) = H.size obj == 1
182−isObjectWithSingleField _ = False
183−
184−-- | is untaggedValue of EitherTextInt
185−isUntaggedValueETI :: Value -> Bool
186−isUntaggedValueETI (String s)
187− | s == "nonenullary" = True
188−isUntaggedValueETI (Bool _) = True
189−isUntaggedValueETI (Number _) = True
190−isUntaggedValueETI (Array a) = length a == 2
191−isUntaggedValueETI _ = False
192−
193−isEmptyArray :: Value -> Property
194−isEmptyArray = checkValue isEmptyArray'
195−
196−isEmptyArray' :: Value -> Bool
197−isEmptyArray' = (Array mempty ==)
198−
199−
200−--------------------------------------------------------------------------------
201−
202−
203−tests :: Test
18+tests :: TestTree
20419tests = testGroup "properties" [
20520 testGroup "encode" [
20621 testProperty "encodeDouble" encodeDouble
20722 , testProperty "encodeInteger" encodeInteger
20823 ]
209− , testGroup "roundTrip" [
210− testProperty "Bool" $ roundTripEq True
211− , testProperty "Double" $ roundTripEq (1 :: Approx Double)
212− , testProperty "Int" $ roundTripEq (1 :: Int)
213− , testProperty "NonEmpty Char" $ roundTripEq (undefined :: NonEmpty Char)
214− , testProperty "Integer" $ roundTripEq (1 :: Integer)
215− , testProperty "String" $ roundTripEq ("" :: String)
216− , testProperty "Text" $ roundTripEq T.empty
217− , testProperty "Lazy Text" $ roundTripEq LT.empty
218− , testProperty "Foo" $ roundTripEq (undefined :: Foo)
219− , testProperty "Day" $ roundTripEq (undefined :: Day)
220− , testProperty "BCE Day" $ roundTripEq (undefined :: BCEDay)
221− , testProperty "DotNetTime" $ roundTripEq (undefined :: Approx DotNetTime)
222− , testProperty "LocalTime" $ roundTripEq (undefined :: LocalTime)
223− , testProperty "TimeOfDay" $ roundTripEq (undefined :: TimeOfDay)
224− , testProperty "UTCTime" $ roundTripEq (undefined :: UTCTime)
225− , testProperty "ZonedTime" $ roundTripEq (undefined :: ZonedTime)
226− , testProperty "NominalDiffTime" $ roundTripEq (undefined :: NominalDiffTime)
227− , testProperty "Version" $ roundTripEq (undefined :: Version)
228− , testProperty "Natural" $ roundTripEq (undefined :: Natural)
229− , testProperty "Proxy" $ roundTripEq (undefined :: Proxy Int)
230− , testProperty "Tagged" $ roundTripEq (undefined :: Tagged Int Char)
231− , testProperty "Const" $ roundTripEq (undefined :: Const Int Char)
232− , testProperty "DList" $ roundTripEq (undefined :: DList Int)
233− , testProperty "Seq" $ roundTripEq (undefined :: Seq Int)
234− , testProperty "Rational" $ roundTripEq (undefined :: Rational)
235− , testProperty "Ratio Int" $ roundTripEq (undefined :: Ratio Int)
236− , testProperty "UUID" $ roundTripEq UUID.nil
237− , testGroup "functors"
238− [ testProperty "Identity Char" $ roundTripEq (undefined :: I Int)
239−
240− , testProperty "Identity Char" $ roundTripEq (undefined :: I Char)
241− , testProperty "Identity [Char]" $ roundTripEq (undefined :: I String)
242− , testProperty "[Identity Char]" $ roundTripEq (undefined :: [I Char])
243−
244− , testProperty "Compose I I Int" $ roundTripEq (undefined :: LogScaled (Compose I I Int))
245− , testProperty "Compose [] I Int" $ roundTripEq (undefined :: LogScaled (Compose [] I Int))
246− , testProperty "Compose I [] Int" $ roundTripEq (undefined :: LogScaled (Compose I [] Int))
247− , testProperty "Compose [] [] Int" $ roundTripEq (undefined :: LogScaled (Compose [] [] Int))
248−
249− , testProperty "Compose I I Char" $ roundTripEq (undefined :: LogScaled (Compose I I Char))
250− , testProperty "Compose [] I Char" $ roundTripEq (undefined :: LogScaled (Compose [] I Char))
251− , testProperty "Compose I [] Char" $ roundTripEq (undefined :: LogScaled (Compose I [] Char))
252− , testProperty "Compose [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose [] [] Char))
253−
254− , testProperty "Compose3 I I I Char" $ roundTripEq (undefined :: LogScaled (Compose3 I I I Char))
255− , testProperty "Compose3 I [] I Char" $ roundTripEq (undefined :: LogScaled (Compose3 I [] I Char))
256− , testProperty "Compose3 I I [] Char" $ roundTripEq (undefined :: LogScaled (Compose3 I I [] Char))
257− , testProperty "Compose3 I [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose3 I [] [] Char))
258− , testProperty "Compose3 [] I I Char" $ roundTripEq (undefined :: LogScaled (Compose3 [] I I Char))
259− , testProperty "Compose3 [] [] I Char" $ roundTripEq (undefined :: LogScaled (Compose3 [] [] I Char))
260− , testProperty "Compose3 [] I [] Char" $ roundTripEq (undefined :: LogScaled (Compose3 [] I [] Char))
261− , testProperty "Compose3 [] [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose3 [] [] [] Char))
262−
263− , testProperty "Compose3' I I I Char" $ roundTripEq (undefined :: LogScaled (Compose3' I I I Char))
264− , testProperty "Compose3' I [] I Char" $ roundTripEq (undefined :: LogScaled (Compose3' I [] I Char))
265− , testProperty "Compose3' I I [] Char" $ roundTripEq (undefined :: LogScaled (Compose3' I I [] Char))
266− , testProperty "Compose3' I [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose3' I [] [] Char))
267− , testProperty "Compose3' [] I I Char" $ roundTripEq (undefined :: LogScaled (Compose3' [] I I Char))
268− , testProperty "Compose3' [] [] I Char" $ roundTripEq (undefined :: LogScaled (Compose3' [] [] I Char))
269− , testProperty "Compose3' [] I [] Char" $ roundTripEq (undefined :: LogScaled (Compose3' [] I [] Char))
270− , testProperty "Compose3' [] [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose3' [] [] [] Char))
271− ]
272− , testGroup "ghcGenerics" [
273− testProperty "OneConstructor" $ roundTripEq OneConstructor
274− , testProperty "Product2" $ roundTripEq (undefined :: Product2 Int Bool)
275− , testProperty "Product6" $ roundTripEq (undefined :: P6)
276− , testProperty "Sum4" $ roundTripEq (undefined :: S4)
277− ]
278− ]
279− , testGroup "roundTrip Key"
280− [ testProperty "Bool" $ roundTripKey True
281− , testProperty "Text" $ roundTripKey (undefined :: T.Text)
282− , testProperty "String" $ roundTripKey (undefined :: String)
283− , testProperty "Int" $ roundTripKey (undefined :: Int)
284− , testProperty "[Text]" $ roundTripKey (undefined :: LogScaled [T.Text])
285− , testProperty "(Int,Char)" $ roundTripKey (undefined :: (Int,Char))
286− , testProperty "Integer" $ roundTripKey (undefined :: Integer)
287− , testProperty "Natural" $ roundTripKey (undefined :: Natural)
288− , testProperty "Float" $ roundTripKey (undefined :: Float)
289− , testProperty "Double" $ roundTripKey (undefined :: Double)
290−#if MIN_VERSION_base(4,7,0)
291− , testProperty "Day" $ roundTripKey (undefined :: Day)
292− , testProperty "LocalTime" $ roundTripKey (undefined :: LocalTime)
293− , testProperty "TimeOfDay" $ roundTripKey (undefined :: TimeOfDay)
294− , testProperty "UTCTime" $ roundTripKey (undefined :: UTCTime)
295−#endif
296− , testProperty "Version" $ roundTripKey (undefined :: Version)
297− , testProperty "Lazy Text" $ roundTripKey (undefined :: LT.Text)
298− , testProperty "UUID" $ roundTripKey UUID.nil
299− ]
24+ , roundTripTests
25+ , keysTests
30026 , testGroup "toFromJSON" [
30127 testProperty "Integer" (toFromJSON :: Integer -> Property)
30228 , testProperty "Double" (toFromJSON :: Double -> Property)
@@ -306,206 +32,9 @@ tests = testGroup "properties" [
30632 ]
30733 , testGroup "failure messages" [
30834 testProperty "modify failure" modifyFailureProp
35+ , testProperty "parserThrowError" parserThrowErrorProp
36+ , testProperty "parserCatchError" parserCatchErrorProp
30937 ]
310− , testGroup "generic" [
311− testGroup "toJSON" [
312− testGroup "Nullary" [
313− testProperty "string" (isString . gNullaryToJSONString)
314− , testProperty "2ElemArray" (is2ElemArray . gNullaryToJSON2ElemArray)
315− , testProperty "TaggedObject" (isNullaryTaggedObject . gNullaryToJSONTaggedObject)
316− , testProperty "ObjectWithSingleField" (isObjectWithSingleField . gNullaryToJSONObjectWithSingleField)
317− , testGroup "roundTrip" [
318− testProperty "string" (toParseJSON gNullaryParseJSONString gNullaryToJSONString)
319− , testProperty "2ElemArray" (toParseJSON gNullaryParseJSON2ElemArray gNullaryToJSON2ElemArray)
320− , testProperty "TaggedObject" (toParseJSON gNullaryParseJSONTaggedObject gNullaryToJSONTaggedObject)
321− , testProperty "ObjectWithSingleField" (toParseJSON gNullaryParseJSONObjectWithSingleField gNullaryToJSONObjectWithSingleField)
322− ]
323− ]
324− , testGroup "EitherTextInt" [
325− testProperty "UntaggedValue" (isUntaggedValueETI . gEitherTextIntToJSONUntaggedValue)
326− , testProperty "roundtrip" (toParseJSON gEitherTextIntParseJSONUntaggedValue gEitherTextIntToJSONUntaggedValue)
327− ]
328− , testGroup "SomeType" [
329− testProperty "2ElemArray" (is2ElemArray . gSomeTypeToJSON2ElemArray)
330− , testProperty "TaggedObject" (isTaggedObject . gSomeTypeToJSONTaggedObject)
331− , testProperty "ObjectWithSingleField" (isObjectWithSingleField . gSomeTypeToJSONObjectWithSingleField)
332− , testGroup "roundTrip" [
333− testProperty "2ElemArray" (toParseJSON gSomeTypeParseJSON2ElemArray gSomeTypeToJSON2ElemArray)
334− , testProperty "TaggedObject" (toParseJSON gSomeTypeParseJSONTaggedObject gSomeTypeToJSONTaggedObject)
335− , testProperty "ObjectWithSingleField" (toParseJSON gSomeTypeParseJSONObjectWithSingleField gSomeTypeToJSONObjectWithSingleField)
336−
337−#if __GLASGOW_HASKELL__ >= 706
338− , testProperty "2ElemArray unary" (toParseJSON1 gSomeTypeLiftParseJSON2ElemArray gSomeTypeLiftToJSON2ElemArray)
339− , testProperty "TaggedObject unary" (toParseJSON1 gSomeTypeLiftParseJSONTaggedObject gSomeTypeLiftToJSONTaggedObject)
340− , testProperty "ObjectWithSingleField unary" (toParseJSON1 gSomeTypeLiftParseJSONObjectWithSingleField gSomeTypeLiftToJSONObjectWithSingleField)
341−#endif
342− ]
343− ]
344− , testGroup "OneConstructor" [
345− testProperty "default" (isEmptyArray . gOneConstructorToJSONDefault)
346− , testProperty "Tagged" (isTaggedObject . gOneConstructorToJSONTagged)
347− , testGroup "roundTrip" [
348− testProperty "default" (toParseJSON gOneConstructorParseJSONDefault gOneConstructorToJSONDefault)
349− , testProperty "Tagged" (toParseJSON gOneConstructorParseJSONTagged gOneConstructorToJSONTagged)
350− ]
351− ]
352− ]
353− , testGroup "toEncoding" [
354− testProperty "NullaryString" $
355− gNullaryToJSONString `sameAs` gNullaryToEncodingString
356− , testProperty "Nullary2ElemArray" $
357− gNullaryToJSON2ElemArray `sameAs` gNullaryToEncoding2ElemArray
358− , testProperty "NullaryTaggedObject" $
359− gNullaryToJSONTaggedObject `sameAs` gNullaryToEncodingTaggedObject
360− , testProperty "NullaryObjectWithSingleField" $
361− gNullaryToJSONObjectWithSingleField `sameAs`
362− gNullaryToEncodingObjectWithSingleField
363− -- , testProperty "ApproxUnwrap" $
364− -- gApproxToJSONUnwrap `sameAs` gApproxToEncodingUnwrap
365− , testProperty "ApproxDefault" $
366− gApproxToJSONDefault `sameAs` gApproxToEncodingDefault
367−
368− , testProperty "EitherTextInt UntaggedValue" $
369− gEitherTextIntToJSONUntaggedValue `sameAs` gEitherTextIntToEncodingUntaggedValue
370−
371− , testProperty "SomeType2ElemArray" $
372− gSomeTypeToJSON2ElemArray `sameAs` gSomeTypeToEncoding2ElemArray
373−#if __GLASGOW_HASKELL__ >= 706
374− , testProperty "SomeType2ElemArray unary" $
375− gSomeTypeLiftToJSON2ElemArray `sameAs1` gSomeTypeLiftToEncoding2ElemArray
376− , testProperty "SomeType2ElemArray unary agree" $
377− gSomeTypeToEncoding2ElemArray `sameAs1Agree` gSomeTypeLiftToEncoding2ElemArray
378−#endif
379−
380− , testProperty "SomeTypeTaggedObject" $
381− gSomeTypeToJSONTaggedObject `sameAs` gSomeTypeToEncodingTaggedObject
382−#if __GLASGOW_HASKELL__ >= 706
383− , testProperty "SomeTypeTaggedObject unary" $
384− gSomeTypeLiftToJSONTaggedObject `sameAs1` gSomeTypeLiftToEncodingTaggedObject
385− , testProperty "SomeTypeTaggedObject unary agree" $
386− gSomeTypeToEncodingTaggedObject `sameAs1Agree` gSomeTypeLiftToEncodingTaggedObject
387−#endif
388−
389− , testProperty "SomeTypeObjectWithSingleField" $
390− gSomeTypeToJSONObjectWithSingleField `sameAs` gSomeTypeToEncodingObjectWithSingleField
391−#if __GLASGOW_HASKELL__ >= 706
392− , testProperty "SomeTypeObjectWithSingleField unary" $
393− gSomeTypeLiftToJSONObjectWithSingleField `sameAs1` gSomeTypeLiftToEncodingObjectWithSingleField
394− , testProperty "SomeTypeObjectWithSingleField unary agree" $
395− gSomeTypeToEncodingObjectWithSingleField `sameAs1Agree` gSomeTypeLiftToEncodingObjectWithSingleField
396−#endif
397−
398− , testProperty "SomeTypeOmitNothingFields" $
399− gSomeTypeToJSONOmitNothingFields `sameAs` gSomeTypeToEncodingOmitNothingFields
400−
401− , testProperty "OneConstructorDefault" $
402− gOneConstructorToJSONDefault `sameAs` gOneConstructorToEncodingDefault
403− , testProperty "OneConstructorTagged" $
404− gOneConstructorToJSONTagged `sameAs` gOneConstructorToEncodingTagged
405− ]
406− ]
407− , testGroup "template-haskell" [
408− testGroup "toJSON" [
409− testGroup "Nullary" [
410− testProperty "string" (isString . thNullaryToJSONString)
411− , testProperty "2ElemArray" (is2ElemArray . thNullaryToJSON2ElemArray)
412− , testProperty "TaggedObject" (isNullaryTaggedObject . thNullaryToJSONTaggedObject)
413− , testProperty "ObjectWithSingleField" (isObjectWithSingleField . thNullaryToJSONObjectWithSingleField)
414−
415− , testGroup "roundTrip" [
416− testProperty "string" (toParseJSON thNullaryParseJSONString thNullaryToJSONString)
417− , testProperty "2ElemArray" (toParseJSON thNullaryParseJSON2ElemArray thNullaryToJSON2ElemArray)
418− , testProperty "TaggedObject" (toParseJSON thNullaryParseJSONTaggedObject thNullaryToJSONTaggedObject)
419− , testProperty "ObjectWithSingleField" (toParseJSON thNullaryParseJSONObjectWithSingleField thNullaryToJSONObjectWithSingleField)
420− ]
421− ]
422− , testGroup "EitherTextInt" [
423− testProperty "UntaggedValue" (isUntaggedValueETI . thEitherTextIntToJSONUntaggedValue)
424− , testProperty "roundtrip" (toParseJSON thEitherTextIntParseJSONUntaggedValue thEitherTextIntToJSONUntaggedValue)
425− ]
426− , testGroup "SomeType" [
427− testProperty "2ElemArray" (is2ElemArray . thSomeTypeToJSON2ElemArray)
428− , testProperty "TaggedObject" (isTaggedObject . thSomeTypeToJSONTaggedObject)
429− , testProperty "ObjectWithSingleField" (isObjectWithSingleField . thSomeTypeToJSONObjectWithSingleField)
430− , testGroup "roundTrip" [
431− testProperty "2ElemArray" (toParseJSON thSomeTypeParseJSON2ElemArray thSomeTypeToJSON2ElemArray)
432− , testProperty "TaggedObject" (toParseJSON thSomeTypeParseJSONTaggedObject thSomeTypeToJSONTaggedObject)
433− , testProperty "ObjectWithSingleField" (toParseJSON thSomeTypeParseJSONObjectWithSingleField thSomeTypeToJSONObjectWithSingleField)
434−
435− , testProperty "2ElemArray unary" (toParseJSON1 thSomeTypeLiftParseJSON2ElemArray thSomeTypeLiftToJSON2ElemArray)
436− , testProperty "TaggedObject unary" (toParseJSON1 thSomeTypeLiftParseJSONTaggedObject thSomeTypeLiftToJSONTaggedObject)
437− , testProperty "ObjectWithSingleField unary" (toParseJSON1 thSomeTypeLiftParseJSONObjectWithSingleField thSomeTypeLiftToJSONObjectWithSingleField)
438−
439− ]
440− ]
441− , testGroup "Approx" [
442− testProperty "string" (isString . thApproxToJSONUnwrap)
443− , testProperty "ObjectWithSingleField" (isObjectWithSingleField . thApproxToJSONDefault)
444− , testGroup "roundTrip" [
445− testProperty "string" (toParseJSON thApproxParseJSONUnwrap thApproxToJSONUnwrap)
446− , testProperty "ObjectWithSingleField" (toParseJSON thApproxParseJSONDefault thApproxToJSONDefault)
447− ]
448− ]
449− , testGroup "GADT" [
450− testProperty "string" (isString . thGADTToJSONUnwrap)
451− , testProperty "ObjectWithSingleField" (isObjectWithSingleField . thGADTToJSONDefault)
452− , testGroup "roundTrip" [
453− testProperty "string" (toParseJSON thGADTParseJSONUnwrap thGADTToJSONUnwrap)
454− , testProperty "ObjectWithSingleField" (toParseJSON thGADTParseJSONDefault thGADTToJSONDefault)
455− ]
456− ]
457− , testGroup "OneConstructor" [
458− testProperty "default" (isEmptyArray . thOneConstructorToJSONDefault)
459− , testProperty "Tagged" (isTaggedObject . thOneConstructorToJSONTagged)
460− , testGroup "roundTrip" [
461− testProperty "default" (toParseJSON thOneConstructorParseJSONDefault thOneConstructorToJSONDefault)
462− , testProperty "Tagged" (toParseJSON thOneConstructorParseJSONTagged thOneConstructorToJSONTagged)
463− ]
464− ]
465− ]
466− , testGroup "toEncoding" [
467− testProperty "NullaryString" $
468− thNullaryToJSONString `sameAs` thNullaryToEncodingString
469− , testProperty "Nullary2ElemArray" $
470− thNullaryToJSON2ElemArray `sameAs` thNullaryToEncoding2ElemArray
471− , testProperty "NullaryTaggedObject" $
472− thNullaryToJSONTaggedObject `sameAs` thNullaryToEncodingTaggedObject
473− , testProperty "NullaryObjectWithSingleField" $
474− thNullaryToJSONObjectWithSingleField `sameAs`
475− thNullaryToEncodingObjectWithSingleField
476− , testProperty "ApproxUnwrap" $
477− thApproxToJSONUnwrap `sameAs` thApproxToEncodingUnwrap
478− , testProperty "ApproxDefault" $
479− thApproxToJSONDefault `sameAs` thApproxToEncodingDefault
480−
481− , testProperty "EitherTextInt UntaggedValue" $
482− thEitherTextIntToJSONUntaggedValue `sameAs` thEitherTextIntToEncodingUntaggedValue
483−
484− , testProperty "SomeType2ElemArray" $
485− thSomeTypeToJSON2ElemArray `sameAs` thSomeTypeToEncoding2ElemArray
486− , testProperty "SomeType2ElemArray unary" $
487− thSomeTypeLiftToJSON2ElemArray `sameAs1` thSomeTypeLiftToEncoding2ElemArray
488− , testProperty "SomeType2ElemArray unary agree" $
489− thSomeTypeToEncoding2ElemArray `sameAs1Agree` thSomeTypeLiftToEncoding2ElemArray
490−
491− , testProperty "SomeTypeTaggedObject" $
492− thSomeTypeToJSONTaggedObject `sameAs` thSomeTypeToEncodingTaggedObject
493− , testProperty "SomeTypeTaggedObject unary" $
494− thSomeTypeLiftToJSONTaggedObject `sameAs1` thSomeTypeLiftToEncodingTaggedObject
495− , testProperty "SomeTypeTaggedObject unary agree" $
496− thSomeTypeToEncodingTaggedObject `sameAs1Agree` thSomeTypeLiftToEncodingTaggedObject
497−
498− , testProperty "SomeTypeObjectWithSingleField" $
499− thSomeTypeToJSONObjectWithSingleField `sameAs` thSomeTypeToEncodingObjectWithSingleField
500− , testProperty "SomeTypeObjectWithSingleField unary" $
501− thSomeTypeLiftToJSONObjectWithSingleField `sameAs1` thSomeTypeLiftToEncodingObjectWithSingleField
502− , testProperty "SomeTypeObjectWithSingleField unary agree" $
503− thSomeTypeToEncodingObjectWithSingleField `sameAs1Agree` thSomeTypeLiftToEncodingObjectWithSingleField
504−
505− , testProperty "OneConstructorDefault" $
506− thOneConstructorToJSONDefault `sameAs` thOneConstructorToEncodingDefault
507− , testProperty "OneConstructorTagged" $
508− thOneConstructorToJSONTagged `sameAs` thOneConstructorToEncodingTagged
509− ]
510− ]
38+ , genericTests
39+ , templateHaskellTests
51140 ]
tests/PropertyGeneric.hsnew file+116
@@ -0,0 +1,116 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE NoImplicitPrelude #-}
3+
4+module PropertyGeneric ( genericTests ) where
5+
6+import Prelude.Compat
7+
8+import Data.Semigroup (Option(..))
9+import Encoders
10+import Instances ()
11+import Test.Tasty (TestTree, testGroup)
12+import Test.Tasty.QuickCheck (testProperty)
13+import Test.QuickCheck ( (===) )
14+import Types
15+import PropUtils
16+
17+
18+genericTests :: TestTree
19+genericTests =
20+ testGroup "generic" [
21+ testGroup "toJSON" [
22+ testGroup "Nullary" [
23+ testProperty "string" (isString . gNullaryToJSONString)
24+ , testProperty "2ElemArray" (is2ElemArray . gNullaryToJSON2ElemArray)
25+ , testProperty "TaggedObject" (isNullaryTaggedObject . gNullaryToJSONTaggedObject)
26+ , testProperty "ObjectWithSingleField" (isObjectWithSingleField . gNullaryToJSONObjectWithSingleField)
27+ , testGroup "roundTrip" [
28+ testProperty "string" (toParseJSON gNullaryParseJSONString gNullaryToJSONString)
29+ , testProperty "2ElemArray" (toParseJSON gNullaryParseJSON2ElemArray gNullaryToJSON2ElemArray)
30+ , testProperty "TaggedObject" (toParseJSON gNullaryParseJSONTaggedObject gNullaryToJSONTaggedObject)
31+ , testProperty "ObjectWithSingleField" (toParseJSON gNullaryParseJSONObjectWithSingleField gNullaryToJSONObjectWithSingleField)
32+ ]
33+ ]
34+ , testGroup "EitherTextInt" [
35+ testProperty "UntaggedValue" (isUntaggedValueETI . gEitherTextIntToJSONUntaggedValue)
36+ , testProperty "roundtrip" (toParseJSON gEitherTextIntParseJSONUntaggedValue gEitherTextIntToJSONUntaggedValue)
37+ ]
38+ , testGroup "SomeType" [
39+ testProperty "2ElemArray" (is2ElemArray . gSomeTypeToJSON2ElemArray)
40+ , testProperty "TaggedObject" (isTaggedObject . gSomeTypeToJSONTaggedObject)
41+ , testProperty "ObjectWithSingleField" (isObjectWithSingleField . gSomeTypeToJSONObjectWithSingleField)
42+ , testGroup "roundTrip" [
43+ testProperty "2ElemArray" (toParseJSON gSomeTypeParseJSON2ElemArray gSomeTypeToJSON2ElemArray)
44+ , testProperty "TaggedObject" (toParseJSON gSomeTypeParseJSONTaggedObject gSomeTypeToJSONTaggedObject)
45+ , testProperty "ObjectWithSingleField" (toParseJSON gSomeTypeParseJSONObjectWithSingleField gSomeTypeToJSONObjectWithSingleField)
46+
47+ , testProperty "2ElemArray unary" (toParseJSON1 gSomeTypeLiftParseJSON2ElemArray gSomeTypeLiftToJSON2ElemArray)
48+ , testProperty "TaggedObject unary" (toParseJSON1 gSomeTypeLiftParseJSONTaggedObject gSomeTypeLiftToJSONTaggedObject)
49+ , testProperty "ObjectWithSingleField unary" (toParseJSON1 gSomeTypeLiftParseJSONObjectWithSingleField gSomeTypeLiftToJSONObjectWithSingleField)
50+ ]
51+ ]
52+ , testGroup "OneConstructor" [
53+ testProperty "default" (isEmptyArray . gOneConstructorToJSONDefault)
54+ , testProperty "Tagged" (isTaggedObject . gOneConstructorToJSONTagged)
55+ , testGroup "roundTrip" [
56+ testProperty "default" (toParseJSON gOneConstructorParseJSONDefault gOneConstructorToJSONDefault)
57+ , testProperty "Tagged" (toParseJSON gOneConstructorParseJSONTagged gOneConstructorToJSONTagged)
58+ ]
59+ ]
60+ , testGroup "OptionField" [
61+ testProperty "like Maybe" $
62+ \x -> gOptionFieldToJSON (OptionField (Option x)) === thMaybeFieldToJSON (MaybeField x)
63+ , testProperty "roundTrip" (toParseJSON gOptionFieldParseJSON gOptionFieldToJSON)
64+ ]
65+ ]
66+ , testGroup "toEncoding" [
67+ testProperty "NullaryString" $
68+ gNullaryToJSONString `sameAs` gNullaryToEncodingString
69+ , testProperty "Nullary2ElemArray" $
70+ gNullaryToJSON2ElemArray `sameAs` gNullaryToEncoding2ElemArray
71+ , testProperty "NullaryTaggedObject" $
72+ gNullaryToJSONTaggedObject `sameAs` gNullaryToEncodingTaggedObject
73+ , testProperty "NullaryObjectWithSingleField" $
74+ gNullaryToJSONObjectWithSingleField `sameAs`
75+ gNullaryToEncodingObjectWithSingleField
76+ -- , testProperty "ApproxUnwrap" $
77+ -- gApproxToJSONUnwrap `sameAs` gApproxToEncodingUnwrap
78+ , testProperty "ApproxDefault" $
79+ gApproxToJSONDefault `sameAs` gApproxToEncodingDefault
80+
81+ , testProperty "EitherTextInt UntaggedValue" $
82+ gEitherTextIntToJSONUntaggedValue `sameAs` gEitherTextIntToEncodingUntaggedValue
83+
84+ , testProperty "SomeType2ElemArray" $
85+ gSomeTypeToJSON2ElemArray `sameAs` gSomeTypeToEncoding2ElemArray
86+ , testProperty "SomeType2ElemArray unary" $
87+ gSomeTypeLiftToJSON2ElemArray `sameAs1` gSomeTypeLiftToEncoding2ElemArray
88+ , testProperty "SomeType2ElemArray unary agree" $
89+ gSomeTypeToEncoding2ElemArray `sameAs1Agree` gSomeTypeLiftToEncoding2ElemArray
90+
91+ , testProperty "SomeTypeTaggedObject" $
92+ gSomeTypeToJSONTaggedObject `sameAs` gSomeTypeToEncodingTaggedObject
93+ , testProperty "SomeTypeTaggedObject unary" $
94+ gSomeTypeLiftToJSONTaggedObject `sameAs1` gSomeTypeLiftToEncodingTaggedObject
95+ , testProperty "SomeTypeTaggedObject unary agree" $
96+ gSomeTypeToEncodingTaggedObject `sameAs1Agree` gSomeTypeLiftToEncodingTaggedObject
97+
98+ , testProperty "SomeTypeObjectWithSingleField" $
99+ gSomeTypeToJSONObjectWithSingleField `sameAs` gSomeTypeToEncodingObjectWithSingleField
100+ , testProperty "SomeTypeObjectWithSingleField unary" $
101+ gSomeTypeLiftToJSONObjectWithSingleField `sameAs1` gSomeTypeLiftToEncodingObjectWithSingleField
102+ , testProperty "SomeTypeObjectWithSingleField unary agree" $
103+ gSomeTypeToEncodingObjectWithSingleField `sameAs1Agree` gSomeTypeLiftToEncodingObjectWithSingleField
104+
105+ , testProperty "SomeTypeOmitNothingFields" $
106+ gSomeTypeToJSONOmitNothingFields `sameAs` gSomeTypeToEncodingOmitNothingFields
107+
108+ , testProperty "OneConstructorDefault" $
109+ gOneConstructorToJSONDefault `sameAs` gOneConstructorToEncodingDefault
110+ , testProperty "OneConstructorTagged" $
111+ gOneConstructorToJSONTagged `sameAs` gOneConstructorToEncodingTagged
112+
113+ , testProperty "OptionField" $
114+ gOptionFieldToJSON `sameAs` gOptionFieldToEncoding
115+ ]
116+ ]
tests/PropertyKeys.hsnew file+40
@@ -0,0 +1,40 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
3+module PropertyKeys ( keysTests ) where
4+
5+import Prelude.Compat
6+
7+import Data.Time (Day, LocalTime, TimeOfDay, UTCTime)
8+import Data.Version (Version)
9+import Instances ()
10+import Numeric.Natural (Natural)
11+import Test.Tasty (TestTree, testGroup)
12+import Test.Tasty.QuickCheck (testProperty)
13+import Types
14+import qualified Data.Text as T
15+import qualified Data.Text.Lazy as LT
16+import qualified Data.UUID.Types as UUID
17+import PropUtils
18+
19+
20+keysTests :: TestTree
21+keysTests =
22+ testGroup "roundTrip Key"
23+ [ testProperty "Bool" $ roundTripKey True
24+ , testProperty "Text" $ roundTripKey (undefined :: T.Text)
25+ , testProperty "String" $ roundTripKey (undefined :: String)
26+ , testProperty "Int" $ roundTripKey (undefined :: Int)
27+ , testProperty "[Text]" $ roundTripKey (undefined :: LogScaled [T.Text])
28+ , testProperty "(Int,Char)" $ roundTripKey (undefined :: (Int,Char))
29+ , testProperty "Integer" $ roundTripKey (undefined :: Integer)
30+ , testProperty "Natural" $ roundTripKey (undefined :: Natural)
31+ , testProperty "Float" $ roundTripKey (undefined :: Float)
32+ , testProperty "Double" $ roundTripKey (undefined :: Double)
33+ , testProperty "Day" $ roundTripKey (undefined :: Day)
34+ , testProperty "LocalTime" $ roundTripKey (undefined :: LocalTime)
35+ , testProperty "TimeOfDay" $ roundTripKey (undefined :: TimeOfDay)
36+ , testProperty "UTCTime" $ roundTripKey (undefined :: UTCTime)
37+ , testProperty "Version" $ roundTripKey (undefined :: Version)
38+ , testProperty "Lazy Text" $ roundTripKey (undefined :: LT.Text)
39+ , testProperty "UUID" $ roundTripKey UUID.nil
40+ ]
tests/PropertyRTFunctors.hsnew file+51
@@ -0,0 +1,51 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
3+module PropertyRTFunctors ( roundTripFunctorsTests ) where
4+
5+import Prelude.Compat
6+
7+import Data.Functor.Compose (Compose (..))
8+import Instances ()
9+import Test.Tasty (TestTree, testGroup)
10+import Test.Tasty.QuickCheck (testProperty)
11+import Types
12+import PropUtils
13+
14+
15+roundTripFunctorsTests :: TestTree
16+roundTripFunctorsTests =
17+ testGroup "functors"
18+ [ testProperty "Identity Char" $ roundTripEq (undefined :: I Int)
19+
20+ , testProperty "Identity Char" $ roundTripEq (undefined :: I Char)
21+ , testProperty "Identity [Char]" $ roundTripEq (undefined :: I String)
22+ , testProperty "[Identity Char]" $ roundTripEq (undefined :: [I Char])
23+
24+ , testProperty "Compose I I Int" $ roundTripEq (undefined :: LogScaled (Compose I I Int))
25+ , testProperty "Compose [] I Int" $ roundTripEq (undefined :: LogScaled (Compose [] I Int))
26+ , testProperty "Compose I [] Int" $ roundTripEq (undefined :: LogScaled (Compose I [] Int))
27+ , testProperty "Compose [] [] Int" $ roundTripEq (undefined :: LogScaled (Compose [] [] Int))
28+
29+ , testProperty "Compose I I Char" $ roundTripEq (undefined :: LogScaled (Compose I I Char))
30+ , testProperty "Compose [] I Char" $ roundTripEq (undefined :: LogScaled (Compose [] I Char))
31+ , testProperty "Compose I [] Char" $ roundTripEq (undefined :: LogScaled (Compose I [] Char))
32+ , testProperty "Compose [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose [] [] Char))
33+
34+ , testProperty "Compose3 I I I Char" $ roundTripEq (undefined :: LogScaled (Compose3 I I I Char))
35+ , testProperty "Compose3 I [] I Char" $ roundTripEq (undefined :: LogScaled (Compose3 I [] I Char))
36+ , testProperty "Compose3 I I [] Char" $ roundTripEq (undefined :: LogScaled (Compose3 I I [] Char))
37+ , testProperty "Compose3 I [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose3 I [] [] Char))
38+ , testProperty "Compose3 [] I I Char" $ roundTripEq (undefined :: LogScaled (Compose3 [] I I Char))
39+ , testProperty "Compose3 [] [] I Char" $ roundTripEq (undefined :: LogScaled (Compose3 [] [] I Char))
40+ , testProperty "Compose3 [] I [] Char" $ roundTripEq (undefined :: LogScaled (Compose3 [] I [] Char))
41+ , testProperty "Compose3 [] [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose3 [] [] [] Char))
42+
43+ , testProperty "Compose3' I I I Char" $ roundTripEq (undefined :: LogScaled (Compose3' I I I Char))
44+ , testProperty "Compose3' I [] I Char" $ roundTripEq (undefined :: LogScaled (Compose3' I [] I Char))
45+ , testProperty "Compose3' I I [] Char" $ roundTripEq (undefined :: LogScaled (Compose3' I I [] Char))
46+ , testProperty "Compose3' I [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose3' I [] [] Char))
47+ , testProperty "Compose3' [] I I Char" $ roundTripEq (undefined :: LogScaled (Compose3' [] I I Char))
48+ , testProperty "Compose3' [] [] I Char" $ roundTripEq (undefined :: LogScaled (Compose3' [] [] I Char))
49+ , testProperty "Compose3' [] I [] Char" $ roundTripEq (undefined :: LogScaled (Compose3' [] I [] Char))
50+ , testProperty "Compose3' [] [] [] Char" $ roundTripEq (undefined :: LogScaled (Compose3' [] [] [] Char))
51+ ]
tests/PropertyRoundTrip.hsnew file+74
@@ -0,0 +1,74 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
3+module PropertyRoundTrip ( roundTripTests ) where
4+
5+import Prelude.Compat
6+
7+import Control.Applicative (Const)
8+import Data.Aeson.Types
9+import Data.DList (DList)
10+import Data.List.NonEmpty (NonEmpty)
11+import Data.Proxy (Proxy)
12+import Data.Ratio (Ratio)
13+import Data.Sequence (Seq)
14+import Data.Tagged (Tagged)
15+import Data.Time (Day, DiffTime, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
16+import Data.Version (Version)
17+import Data.Time.Calendar.Compat (CalendarDiffDays, DayOfWeek)
18+import Data.Time.LocalTime.Compat (CalendarDiffTime)
19+import Data.Time.Clock.System.Compat (SystemTime)
20+import Instances ()
21+import Numeric.Natural (Natural)
22+import Test.Tasty (TestTree, testGroup)
23+import Test.Tasty.QuickCheck (testProperty)
24+import Types
25+import qualified Data.Text as T
26+import qualified Data.Text.Lazy as LT
27+import qualified Data.UUID.Types as UUID
28+import PropUtils
29+import PropertyRTFunctors
30+
31+
32+roundTripTests :: TestTree
33+roundTripTests =
34+ testGroup "roundTrip" [
35+ testProperty "Bool" $ roundTripEq True
36+ , testProperty "Double" $ roundTripEq (1 :: Approx Double)
37+ , testProperty "Int" $ roundTripEq (1 :: Int)
38+ , testProperty "NonEmpty Char" $ roundTripEq (undefined :: NonEmpty Char)
39+ , testProperty "Integer" $ roundTripEq (1 :: Integer)
40+ , testProperty "String" $ roundTripEq ("" :: String)
41+ , testProperty "Text" $ roundTripEq T.empty
42+ , testProperty "Lazy Text" $ roundTripEq LT.empty
43+ , testProperty "Foo" $ roundTripEq (undefined :: Foo)
44+ , testProperty "Day" $ roundTripEq (undefined :: Day)
45+ , testProperty "BCE Day" $ roundTripEq (undefined :: BCEDay)
46+ , testProperty "DotNetTime" $ roundTripEq (undefined :: Approx DotNetTime)
47+ , testProperty "LocalTime" $ roundTripEq (undefined :: LocalTime)
48+ , testProperty "TimeOfDay" $ roundTripEq (undefined :: TimeOfDay)
49+ , testProperty "UTCTime" $ roundTripEq (undefined :: UTCTime)
50+ , testProperty "ZonedTime" $ roundTripEq (undefined :: ZonedTime)
51+ , testProperty "NominalDiffTime" $ roundTripEq (undefined :: NominalDiffTime)
52+ , testProperty "DiffTime" $ roundTripEq (undefined :: DiffTime)
53+ , testProperty "DayOfWeek" $ roundTripEq (undefined :: DayOfWeek)
54+ , testProperty "SystemTime" $ roundTripEq (undefined :: SystemTime)
55+ , testProperty "CalendarDiffTime" $ roundTripEq (undefined :: CalendarDiffTime)
56+ , testProperty "CalendarDiffDays" $ roundTripEq (undefined :: CalendarDiffDays)
57+ , testProperty "Version" $ roundTripEq (undefined :: Version)
58+ , testProperty "Natural" $ roundTripEq (undefined :: Natural)
59+ , testProperty "Proxy" $ roundTripEq (undefined :: Proxy Int)
60+ , testProperty "Tagged" $ roundTripEq (undefined :: Tagged Int Char)
61+ , testProperty "Const" $ roundTripEq (undefined :: Const Int Char)
62+ , testProperty "DList" $ roundTripEq (undefined :: DList Int)
63+ , testProperty "Seq" $ roundTripEq (undefined :: Seq Int)
64+ , testProperty "Rational" $ roundTripEq (undefined :: Rational)
65+ , testProperty "Ratio Int" $ roundTripEq (undefined :: Ratio Int)
66+ , testProperty "UUID" $ roundTripEq UUID.nil
67+ , roundTripFunctorsTests
68+ , testGroup "ghcGenerics" [
69+ testProperty "OneConstructor" $ roundTripEq OneConstructor
70+ , testProperty "Product2" $ roundTripEq (undefined :: Product2 Int Bool)
71+ , testProperty "Product6" $ roundTripEq (undefined :: P6)
72+ , testProperty "Sum4" $ roundTripEq (undefined :: S4)
73+ ]
74+ ]
tests/PropertyTH.hsnew file+130
@@ -0,0 +1,130 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
3+module PropertyTH ( templateHaskellTests ) where
4+
5+import Prelude.Compat
6+
7+import Data.Semigroup (Option(..))
8+import Encoders
9+import Instances ()
10+import Test.Tasty (TestTree, testGroup)
11+import Test.Tasty.QuickCheck (testProperty)
12+import Test.QuickCheck ( (===) )
13+import Types
14+import PropUtils
15+
16+
17+templateHaskellTests :: TestTree
18+templateHaskellTests =
19+ testGroup "template-haskell" [
20+ testGroup "toJSON" [
21+ testGroup "Nullary" [
22+ testProperty "string" (isString . thNullaryToJSONString)
23+ , testProperty "2ElemArray" (is2ElemArray . thNullaryToJSON2ElemArray)
24+ , testProperty "TaggedObject" (isNullaryTaggedObject . thNullaryToJSONTaggedObject)
25+ , testProperty "ObjectWithSingleField" (isObjectWithSingleField . thNullaryToJSONObjectWithSingleField)
26+
27+ , testGroup "roundTrip" [
28+ testProperty "string" (toParseJSON thNullaryParseJSONString thNullaryToJSONString)
29+ , testProperty "2ElemArray" (toParseJSON thNullaryParseJSON2ElemArray thNullaryToJSON2ElemArray)
30+ , testProperty "TaggedObject" (toParseJSON thNullaryParseJSONTaggedObject thNullaryToJSONTaggedObject)
31+ , testProperty "ObjectWithSingleField" (toParseJSON thNullaryParseJSONObjectWithSingleField thNullaryToJSONObjectWithSingleField)
32+ ]
33+ ]
34+ , testGroup "EitherTextInt" [
35+ testProperty "UntaggedValue" (isUntaggedValueETI . thEitherTextIntToJSONUntaggedValue)
36+ , testProperty "roundtrip" (toParseJSON thEitherTextIntParseJSONUntaggedValue thEitherTextIntToJSONUntaggedValue)
37+ ]
38+ , testGroup "SomeType" [
39+ testProperty "2ElemArray" (is2ElemArray . thSomeTypeToJSON2ElemArray)
40+ , testProperty "TaggedObject" (isTaggedObject . thSomeTypeToJSONTaggedObject)
41+ , testProperty "ObjectWithSingleField" (isObjectWithSingleField . thSomeTypeToJSONObjectWithSingleField)
42+ , testGroup "roundTrip" [
43+ testProperty "2ElemArray" (toParseJSON thSomeTypeParseJSON2ElemArray thSomeTypeToJSON2ElemArray)
44+ , testProperty "TaggedObject" (toParseJSON thSomeTypeParseJSONTaggedObject thSomeTypeToJSONTaggedObject)
45+ , testProperty "ObjectWithSingleField" (toParseJSON thSomeTypeParseJSONObjectWithSingleField thSomeTypeToJSONObjectWithSingleField)
46+
47+ , testProperty "2ElemArray unary" (toParseJSON1 thSomeTypeLiftParseJSON2ElemArray thSomeTypeLiftToJSON2ElemArray)
48+ , testProperty "TaggedObject unary" (toParseJSON1 thSomeTypeLiftParseJSONTaggedObject thSomeTypeLiftToJSONTaggedObject)
49+ , testProperty "ObjectWithSingleField unary" (toParseJSON1 thSomeTypeLiftParseJSONObjectWithSingleField thSomeTypeLiftToJSONObjectWithSingleField)
50+
51+ ]
52+ ]
53+ , testGroup "Approx" [
54+ testProperty "string" (isString . thApproxToJSONUnwrap)
55+ , testProperty "ObjectWithSingleField" (isObjectWithSingleField . thApproxToJSONDefault)
56+ , testGroup "roundTrip" [
57+ testProperty "string" (toParseJSON thApproxParseJSONUnwrap thApproxToJSONUnwrap)
58+ , testProperty "ObjectWithSingleField" (toParseJSON thApproxParseJSONDefault thApproxToJSONDefault)
59+ ]
60+ ]
61+ , testGroup "GADT" [
62+ testProperty "string" (isString . thGADTToJSONUnwrap)
63+ , testProperty "ObjectWithSingleField" (isObjectWithSingleField . thGADTToJSONDefault)
64+ , testGroup "roundTrip" [
65+ testProperty "string" (toParseJSON thGADTParseJSONUnwrap thGADTToJSONUnwrap)
66+ , testProperty "ObjectWithSingleField" (toParseJSON thGADTParseJSONDefault thGADTToJSONDefault)
67+ ]
68+ ]
69+ , testGroup "OneConstructor" [
70+ testProperty "default" (isEmptyArray . thOneConstructorToJSONDefault)
71+ , testProperty "Tagged" (isTaggedObject . thOneConstructorToJSONTagged)
72+ , testGroup "roundTrip" [
73+ testProperty "default" (toParseJSON thOneConstructorParseJSONDefault thOneConstructorToJSONDefault)
74+ , testProperty "Tagged" (toParseJSON thOneConstructorParseJSONTagged thOneConstructorToJSONTagged)
75+ ]
76+ ]
77+ , testGroup "OptionField" [
78+ testProperty "like Maybe" $
79+ \x -> thOptionFieldToJSON (OptionField (Option x)) === thMaybeFieldToJSON (MaybeField x)
80+ , testProperty "roundTrip" (toParseJSON thOptionFieldParseJSON thOptionFieldToJSON)
81+ ]
82+ ]
83+ , testGroup "toEncoding" [
84+ testProperty "NullaryString" $
85+ thNullaryToJSONString `sameAs` thNullaryToEncodingString
86+ , testProperty "Nullary2ElemArray" $
87+ thNullaryToJSON2ElemArray `sameAs` thNullaryToEncoding2ElemArray
88+ , testProperty "NullaryTaggedObject" $
89+ thNullaryToJSONTaggedObject `sameAs` thNullaryToEncodingTaggedObject
90+ , testProperty "NullaryObjectWithSingleField" $
91+ thNullaryToJSONObjectWithSingleField `sameAs`
92+ thNullaryToEncodingObjectWithSingleField
93+ , testProperty "ApproxUnwrap" $
94+ thApproxToJSONUnwrap `sameAs` thApproxToEncodingUnwrap
95+ , testProperty "ApproxDefault" $
96+ thApproxToJSONDefault `sameAs` thApproxToEncodingDefault
97+
98+ , testProperty "EitherTextInt UntaggedValue" $
99+ thEitherTextIntToJSONUntaggedValue `sameAs` thEitherTextIntToEncodingUntaggedValue
100+
101+ , testProperty "SomeType2ElemArray" $
102+ thSomeTypeToJSON2ElemArray `sameAs` thSomeTypeToEncoding2ElemArray
103+ , testProperty "SomeType2ElemArray unary" $
104+ thSomeTypeLiftToJSON2ElemArray `sameAs1` thSomeTypeLiftToEncoding2ElemArray
105+ , testProperty "SomeType2ElemArray unary agree" $
106+ thSomeTypeToEncoding2ElemArray `sameAs1Agree` thSomeTypeLiftToEncoding2ElemArray
107+
108+ , testProperty "SomeTypeTaggedObject" $
109+ thSomeTypeToJSONTaggedObject `sameAs` thSomeTypeToEncodingTaggedObject
110+ , testProperty "SomeTypeTaggedObject unary" $
111+ thSomeTypeLiftToJSONTaggedObject `sameAs1` thSomeTypeLiftToEncodingTaggedObject
112+ , testProperty "SomeTypeTaggedObject unary agree" $
113+ thSomeTypeToEncodingTaggedObject `sameAs1Agree` thSomeTypeLiftToEncodingTaggedObject
114+
115+ , testProperty "SomeTypeObjectWithSingleField" $
116+ thSomeTypeToJSONObjectWithSingleField `sameAs` thSomeTypeToEncodingObjectWithSingleField
117+ , testProperty "SomeTypeObjectWithSingleField unary" $
118+ thSomeTypeLiftToJSONObjectWithSingleField `sameAs1` thSomeTypeLiftToEncodingObjectWithSingleField
119+ , testProperty "SomeTypeObjectWithSingleField unary agree" $
120+ thSomeTypeToEncodingObjectWithSingleField `sameAs1Agree` thSomeTypeLiftToEncodingObjectWithSingleField
121+
122+ , testProperty "OneConstructorDefault" $
123+ thOneConstructorToJSONDefault `sameAs` thOneConstructorToEncodingDefault
124+ , testProperty "OneConstructorTagged" $
125+ thOneConstructorToJSONTagged `sameAs` thOneConstructorToEncodingTagged
126+
127+ , testProperty "OptionField" $
128+ thOptionFieldToJSON `sameAs` thOptionFieldToEncoding
129+ ]
130+ ]
tests/SerializationFormatSpec.hs+181−132
@@ -1,10 +1,9 @@
11{-# LANGUAGE CPP #-}
22{-# LANGUAGE DeriveGeneric #-}
33{-# LANGUAGE GADTs #-}
4+{-# LANGUAGE NoImplicitPrelude #-}
45{-# LANGUAGE OverloadedStrings #-}
5−#if __GLASGOW_HASKELL__ >= 708
66{-# LANGUAGE DataKinds #-}
7−#endif
87
98------------------------------------------------------------------------------
109-- These tests assert that the JSON serialization doesn't change by accident.
@@ -15,13 +14,13 @@ module SerializationFormatSpec
1514 tests
1615 ) where
1716
18−import Prelude ()
1917import Prelude.Compat
2018
2119import Control.Applicative (Const(..))
2220import Data.Aeson (FromJSON(..), decode, encode, genericParseJSON, genericToEncoding, genericToJSON)
2321import Data.Aeson.Types (Options(..), SumEncoding(..), ToJSON(..), defaultOptions)
2422import Data.Fixed (Pico)
23+import Data.Foldable (for_, toList)
2524import Data.Functor.Compose (Compose(..))
2625import Data.Functor.Identity (Identity(..))
2726import Data.Functor.Product (Product(..))
@@ -31,12 +30,14 @@ import Data.Proxy (Proxy(..))
3130import Data.Scientific (Scientific)
3231import Data.Tagged (Tagged(..))
3332import Data.Time (fromGregorian)
33+import Data.Time.Calendar.Compat (CalendarDiffDays (..), DayOfWeek (..))
34+import Data.Time.LocalTime.Compat (CalendarDiffTime (..))
35+import Data.Time.Clock.System.Compat (SystemTime (..))
3436import Data.Word (Word8)
3537import GHC.Generics (Generic)
3638import Instances ()
37−import Test.Framework (Test, testGroup)
38−import Test.Framework.Providers.HUnit (testCase)
39−import Test.HUnit (assertFailure, assertEqual)
39+import Test.Tasty (TestTree, testGroup)
40+import Test.Tasty.HUnit (assertFailure, assertEqual, testCase)
4041import Types (Approx(..), Compose3, Compose3', I)
4142import qualified Data.ByteString.Lazy.Char8 as L
4243import qualified Data.DList as DList
@@ -53,7 +54,7 @@ import qualified Data.Tree as Tree
5354import qualified Data.UUID.Types as UUID
5455import qualified Data.Vector as Vector
5556
56−tests :: [Test]
57+tests :: [TestTree]
5758tests =
5859 [
5960 testGroup "To JSON representation" $ fmap assertJsonEncodingExample jsonEncodingExamples
@@ -65,132 +66,156 @@ tests =
6566jsonExamples :: [Example]
6667jsonExamples =
6768 [
68− Example "Either Left" "{\"Left\":1}" (Left 1 :: Either Int Int)
69− , Example "Either Right" "{\"Right\":1}" (Right 1 :: Either Int Int)
70− , Example "Nothing" "null" (Nothing :: Maybe Int)
71− , Example "Just" "1" (Just 1 :: Maybe Int)
72− , Example "Proxy Int" "null" (Proxy :: Proxy Int)
73− , Example "Tagged Char Int" "1" (Tagged 1 :: Tagged Char Int)
74−#if __GLASGOW_HASKELL__ >= 708
69+ example "Either Left" "{\"Left\":1}" (Left 1 :: Either Int Int)
70+ , example "Either Right" "{\"Right\":1}" (Right 1 :: Either Int Int)
71+ , example "Nothing" "null" (Nothing :: Maybe Int)
72+ -- Maybe serialising is lossy
73+ -- https://github.com/bos/aeson/issues/376
74+ , Example "Just Nothing" ["null"] (Just Nothing :: Maybe (Maybe Int)) Nothing
75+ , example "Just" "1" (Just 1 :: Maybe Int)
76+ , example "Proxy Int" "null" (Proxy :: Proxy Int)
77+ , example "Tagged Char Int" "1" (Tagged 1 :: Tagged Char Int)
7578 -- Test Tagged instance is polykinded
76− , Example "Tagged 123 Int" "1" (Tagged 1 :: Tagged 123 Int)
77−#endif
78− , Example "Const Char Int" "\"c\"" (Const 'c' :: Const Char Int)
79− , Example "Tuple" "[1,2]" ((1, 2) :: (Int, Int))
80− , Example "NonEmpty" "[1,2,3]" (1 :| [2, 3] :: NonEmpty Int)
81− , Example "Seq" "[1,2,3]" (Seq.fromList [1, 2, 3] :: Seq.Seq Int)
82− , Example "DList" "[1,2,3]" (DList.fromList [1, 2, 3] :: DList.DList Int)
83− , Example "()" "[]" ()
84−
85− , Example "HashMap Int Int" "{\"0\":1,\"2\":3}" (HM.fromList [(0,1),(2,3)] :: HM.HashMap Int Int)
86− , Example "Map Int Int" "{\"0\":1,\"2\":3}" (M.fromList [(0,1),(2,3)] :: M.Map Int Int)
87− , Example "Map (Tagged Int Int) Int" "{\"0\":1,\"2\":3}" (M.fromList [(Tagged 0,1),(Tagged 2,3)] :: M.Map (Tagged Int Int) Int)
88− , Example "Map [Int] Int" "[[[0],1],[[2],3]]" (M.fromList [([0],1),([2],3)] :: M.Map [Int] Int)
89− , Example "Map [Char] Int" "{\"ab\":1,\"cd\":3}" (M.fromList [("ab",1),("cd",3)] :: M.Map String Int)
90− , Example "Map [I Char] Int" "{\"ab\":1,\"cd\":3}" (M.fromList [(map pure "ab",1),(map pure "cd",3)] :: M.Map [I Char] Int)
91−
92− , Example "nan :: Double" "null" (Approx $ 0/0 :: Approx Double)
93−
94− , Example "Ordering LT" "\"LT\"" LT
95− , Example "Ordering EQ" "\"EQ\"" EQ
96− , Example "Ordering GT" "\"GT\"" GT
97−
98− , Example "Float" "3.14" (3.14 :: Float)
99− , Example "Pico" "3.14" (3.14 :: Pico)
100− , Example "Scientific" "3.14" (3.14 :: Scientific)
101−
102− , Example "UUID" "\"c2cc10e1-57d6-4b6f-9899-38d972112d8c\"" $ UUID.fromWords
79+ , example "Tagged 123 Int" "1" (Tagged 1 :: Tagged 123 Int)
80+ , example "Const Char Int" "\"c\"" (Const 'c' :: Const Char Int)
81+ , example "Tuple" "[1,2]" ((1, 2) :: (Int, Int))
82+ , example "NonEmpty" "[1,2,3]" (1 :| [2, 3] :: NonEmpty Int)
83+ , example "Seq" "[1,2,3]" (Seq.fromList [1, 2, 3] :: Seq.Seq Int)
84+ , example "DList" "[1,2,3]" (DList.fromList [1, 2, 3] :: DList.DList Int)
85+ , example "()" "[]" ()
86+
87+ , ndExample "HashMap Int Int"
88+ [ "{\"0\":1,\"2\":3}", "{\"2\":3,\"0\":1}"]
89+ (HM.fromList [(0,1),(2,3)] :: HM.HashMap Int Int)
90+ , ndExample "Map Int Int"
91+ [ "{\"0\":1,\"2\":3}", "{\"2\":3,\"0\":1}"]
92+ (M.fromList [(0,1),(2,3)] :: M.Map Int Int)
93+ , ndExample "Map (Tagged Int Int) Int"
94+ [ "{\"0\":1,\"2\":3}", "{\"2\":3,\"0\":1}"]
95+ (M.fromList [(Tagged 0,1),(Tagged 2,3)] :: M.Map (Tagged Int Int) Int)
96+ , example "Map [Int] Int"
97+ "[[[0],1],[[2],3]]"
98+ (M.fromList [([0],1),([2],3)] :: M.Map [Int] Int)
99+ , ndExample "Map [Char] Int"
100+ [ "{\"ab\":1,\"cd\":3}", "{\"cd\":3,\"ab\":1}" ]
101+ (M.fromList [("ab",1),("cd",3)] :: M.Map String Int)
102+ , ndExample "Map [I Char] Int"
103+ [ "{\"ab\":1,\"cd\":3}", "{\"cd\":3,\"ab\":1}" ]
104+ (M.fromList [(map pure "ab",1),(map pure "cd",3)] :: M.Map [I Char] Int)
105+
106+ , example "nan :: Double" "null" (Approx $ 0/0 :: Approx Double)
107+
108+ , example "Ordering LT" "\"LT\"" LT
109+ , example "Ordering EQ" "\"EQ\"" EQ
110+ , example "Ordering GT" "\"GT\"" GT
111+
112+ , example "Float" "3.14" (3.14 :: Float)
113+ , example "Pico" "3.14" (3.14 :: Pico)
114+ , example "Scientific" "3.14" (3.14 :: Scientific)
115+
116+ , example "UUID" "\"c2cc10e1-57d6-4b6f-9899-38d972112d8c\"" $ UUID.fromWords
103117 0xc2cc10e1 0x57d64b6f 0x989938d9 0x72112d8c
104118
105− , Example "Set Int" "[1,2,3]" (Set.fromList [3, 2, 1] :: Set.Set Int)
106− , Example "IntSet" "[1,2,3]" (IntSet.fromList [3, 2, 1])
107− , Example "IntMap" "[[1,2],[3,4]]" (IntMap.fromList [(3,4), (1,2)] :: IntMap.IntMap Int)
108− , Example "Vector" "[1,2,3]" (Vector.fromList [1, 2, 3] :: Vector.Vector Int)
109− , Example "HashSet Int" "[1,2,3]" (HashSet.fromList [3, 2, 1] :: HashSet.HashSet Int)
110− , Example "Tree Int" "[1,[[2,[[3,[]],[4,[]]]],[5,[]]]]" (let n = Tree.Node in n 1 [n 2 [n 3 [], n 4 []], n 5 []] :: Tree.Tree Int)
119+ , example "Set Int" "[1,2,3]" (Set.fromList [3, 2, 1] :: Set.Set Int)
120+ , example "IntSet" "[1,2,3]" (IntSet.fromList [3, 2, 1])
121+ , example "IntMap" "[[1,2],[3,4]]" (IntMap.fromList [(3,4), (1,2)] :: IntMap.IntMap Int)
122+ , example "Vector" "[1,2,3]" (Vector.fromList [1, 2, 3] :: Vector.Vector Int)
123+ , example "HashSet Int" "[1,2,3]" (HashSet.fromList [3, 2, 1] :: HashSet.HashSet Int)
124+ , example "Tree Int" "[1,[[2,[[3,[]],[4,[]]]],[5,[]]]]" (let n = Tree.Node in n 1 [n 2 [n 3 [], n 4 []], n 5 []] :: Tree.Tree Int)
111125
112126 -- Three separate cases, as ordering in HashMap is not defined
113− , Example "HashMap Float Int, NaN" "{\"NaN\":1}" (Approx $ HM.singleton (0/0) 1 :: Approx (HM.HashMap Float Int))
114− , Example "HashMap Float Int, Infinity" "{\"Infinity\":1}" (HM.singleton (1/0) 1 :: HM.HashMap Float Int)
115− , Example "HashMap Float Int, +Infinity" "{\"-Infinity\":1}" (HM.singleton (negate 1/0) 1 :: HM.HashMap Float Int)
127+ , example "HashMap Float Int, NaN" "{\"NaN\":1}" (Approx $ HM.singleton (0/0) 1 :: Approx (HM.HashMap Float Int))
128+ , example "HashMap Float Int, Infinity" "{\"Infinity\":1}" (HM.singleton (1/0) 1 :: HM.HashMap Float Int)
129+ , example "HashMap Float Int, +Infinity" "{\"-Infinity\":1}" (HM.singleton (negate 1/0) 1 :: HM.HashMap Float Int)
116130
117131 -- Functors
118− , Example "Identity Int" "1" (pure 1 :: Identity Int)
119−
120− , Example "Identity Char" "\"x\"" (pure 'x' :: Identity Char)
121− , Example "Identity String" "\"foo\"" (pure "foo" :: Identity String)
122− , Example "[Identity Char]" "\"xy\"" ([pure 'x', pure 'y'] :: [Identity Char])
123−
124− , Example "Maybe Char" "\"x\"" (pure 'x' :: Maybe Char)
125− , Example "Maybe String" "\"foo\"" (pure "foo" :: Maybe String)
126− , Example "Maybe [Identity Char]" "\"xy\"" (pure [pure 'x', pure 'y'] :: Maybe [Identity Char])
127−
128− , Example "Day; year >= 1000" "\"1999-10-12\"" (fromGregorian 1999 10 12)
129− , Example "Day; year > 0 && < 1000" "\"0500-03-04\"" (fromGregorian 500 3 4)
130− , Example "Day; year == 0" "\"0000-02-20\"" (fromGregorian 0 2 20)
131− , Example "Day; year < 0" "\"-0234-01-01\"" (fromGregorian (-234) 1 1)
132− , Example "Day; year < -1000" "\"-1234-01-01\"" (fromGregorian (-1234) 1 1)
133−
134− , Example "Product I Maybe Int" "[1,2]" (Pair (pure 1) (pure 2) :: Product I Maybe Int)
135− , Example "Product I Maybe Int" "[1,null]" (Pair (pure 1) Nothing :: Product I Maybe Int)
136− , Example "Product I [] Char" "[\"a\",\"foo\"]" (Pair (pure 'a') "foo" :: Product I [] Char)
137−
138− , Example "Sum I [] Int: InL" "{\"InL\":1}" (InL (pure 1) :: Sum I [] Int)
139− , Example "Sum I [] Int: InR" "{\"InR\":[1,2]}" (InR [1, 2] :: Sum I [] Int)
140− , Example "Sum I [] Char: InR" "{\"InR\":\"foo\"}" (InR "foo" :: Sum I [] Char)
141−
142− , Example "Compose I I Int" "1" (pure 1 :: Compose I I Int)
143− , Example "Compose I [] Int" "[1]" (pure 1 :: Compose I [] Int)
144− , Example "Compose [] I Int" "[1]" (pure 1 :: Compose [] I Int)
145− , Example "Compose [] [] Int" "[[1]]" (pure 1 :: Compose [] [] Int)
146−
147− , Example "Compose I I Char" "\"x\"" (pure 'x' :: Compose I I Char)
148− , Example "Compose I [] Char" "\"x\"" (pure 'x' :: Compose I [] Char)
149− , Example "Compose [] I Char" "\"x\"" (pure 'x' :: Compose [] I Char)
150− , Example "Compose [] [] Char" "[\"x\"]" (pure 'x' :: Compose [] [] Char)
151−
152− , Example "Compose3 I I I Char" "\"x\"" (pure 'x' :: Compose3 I I I Char)
153− , Example "Compose3 I I [] Char" "\"x\"" (pure 'x' :: Compose3 I I [] Char)
154− , Example "Compose3 I [] I Char" "\"x\"" (pure 'x' :: Compose3 I [] I Char)
155− , Example "Compose3 I [] [] Char" "[\"x\"]" (pure 'x' :: Compose3 I [] [] Char)
156− , Example "Compose3 [] I I Char" "\"x\"" (pure 'x' :: Compose3 [] I I Char)
157− , Example "Compose3 [] I [] Char" "[\"x\"]" (pure 'x' :: Compose3 [] I [] Char)
158− , Example "Compose3 [] [] I Char" "[\"x\"]" (pure 'x' :: Compose3 [] [] I Char)
159− , Example "Compose3 [] [] [] Char" "[[\"x\"]]" (pure 'x' :: Compose3 [] [] [] Char)
160−
161− , Example "Compose3' I I I Char" "\"x\"" (pure 'x' :: Compose3' I I I Char)
162− , Example "Compose3' I I [] Char" "\"x\"" (pure 'x' :: Compose3' I I [] Char)
163− , Example "Compose3' I [] I Char" "\"x\"" (pure 'x' :: Compose3' I [] I Char)
164− , Example "Compose3' I [] [] Char" "[\"x\"]" (pure 'x' :: Compose3' I [] [] Char)
165− , Example "Compose3' [] I I Char" "\"x\"" (pure 'x' :: Compose3' [] I I Char)
166− , Example "Compose3' [] I [] Char" "[\"x\"]" (pure 'x' :: Compose3' [] I [] Char)
167− , Example "Compose3' [] [] I Char" "[\"x\"]" (pure 'x' :: Compose3' [] [] I Char)
168− , Example "Compose3' [] [] [] Char" "[[\"x\"]]" (pure 'x' :: Compose3' [] [] [] Char)
169−
170− , Example "MyEither Int String: Left" "42" (MyLeft 42 :: MyEither Int String)
171− , Example "MyEither Int String: Right" "\"foo\"" (MyRight "foo" :: MyEither Int String)
132+ , example "Identity Int" "1" (pure 1 :: Identity Int)
133+
134+ , example "Identity Char" "\"x\"" (pure 'x' :: Identity Char)
135+ , example "Identity String" "\"foo\"" (pure "foo" :: Identity String)
136+ , example "[Identity Char]" "\"xy\"" ([pure 'x', pure 'y'] :: [Identity Char])
137+
138+ , example "Maybe Char" "\"x\"" (pure 'x' :: Maybe Char)
139+ , example "Maybe String" "\"foo\"" (pure "foo" :: Maybe String)
140+ , example "Maybe [Identity Char]" "\"xy\"" (pure [pure 'x', pure 'y'] :: Maybe [Identity Char])
141+
142+ , example "Day; year >= 1000" "\"1999-10-12\"" (fromGregorian 1999 10 12)
143+ , example "Day; year > 0 && < 1000" "\"0500-03-04\"" (fromGregorian 500 3 4)
144+ , example "Day; year == 0" "\"0000-02-20\"" (fromGregorian 0 2 20)
145+ , example "Day; year < 0" "\"-0234-01-01\"" (fromGregorian (-234) 1 1)
146+ , example "Day; year < -1000" "\"-1234-01-01\"" (fromGregorian (-1234) 1 1)
147+
148+ , example "Product I Maybe Int" "[1,2]" (Pair (pure 1) (pure 2) :: Product I Maybe Int)
149+ , example "Product I Maybe Int" "[1,null]" (Pair (pure 1) Nothing :: Product I Maybe Int)
150+ , example "Product I [] Char" "[\"a\",\"foo\"]" (Pair (pure 'a') "foo" :: Product I [] Char)
151+
152+ , example "Sum I [] Int: InL" "{\"InL\":1}" (InL (pure 1) :: Sum I [] Int)
153+ , example "Sum I [] Int: InR" "{\"InR\":[1,2]}" (InR [1, 2] :: Sum I [] Int)
154+ , example "Sum I [] Char: InR" "{\"InR\":\"foo\"}" (InR "foo" :: Sum I [] Char)
155+
156+ , example "Compose I I Int" "1" (pure 1 :: Compose I I Int)
157+ , example "Compose I [] Int" "[1]" (pure 1 :: Compose I [] Int)
158+ , example "Compose [] I Int" "[1]" (pure 1 :: Compose [] I Int)
159+ , example "Compose [] [] Int" "[[1]]" (pure 1 :: Compose [] [] Int)
160+
161+ , example "Compose I I Char" "\"x\"" (pure 'x' :: Compose I I Char)
162+ , example "Compose I [] Char" "\"x\"" (pure 'x' :: Compose I [] Char)
163+ , example "Compose [] I Char" "\"x\"" (pure 'x' :: Compose [] I Char)
164+ , example "Compose [] [] Char" "[\"x\"]" (pure 'x' :: Compose [] [] Char)
165+
166+ , example "Compose3 I I I Char" "\"x\"" (pure 'x' :: Compose3 I I I Char)
167+ , example "Compose3 I I [] Char" "\"x\"" (pure 'x' :: Compose3 I I [] Char)
168+ , example "Compose3 I [] I Char" "\"x\"" (pure 'x' :: Compose3 I [] I Char)
169+ , example "Compose3 I [] [] Char" "[\"x\"]" (pure 'x' :: Compose3 I [] [] Char)
170+ , example "Compose3 [] I I Char" "\"x\"" (pure 'x' :: Compose3 [] I I Char)
171+ , example "Compose3 [] I [] Char" "[\"x\"]" (pure 'x' :: Compose3 [] I [] Char)
172+ , example "Compose3 [] [] I Char" "[\"x\"]" (pure 'x' :: Compose3 [] [] I Char)
173+ , example "Compose3 [] [] [] Char" "[[\"x\"]]" (pure 'x' :: Compose3 [] [] [] Char)
174+
175+ , example "Compose3' I I I Char" "\"x\"" (pure 'x' :: Compose3' I I I Char)
176+ , example "Compose3' I I [] Char" "\"x\"" (pure 'x' :: Compose3' I I [] Char)
177+ , example "Compose3' I [] I Char" "\"x\"" (pure 'x' :: Compose3' I [] I Char)
178+ , example "Compose3' I [] [] Char" "[\"x\"]" (pure 'x' :: Compose3' I [] [] Char)
179+ , example "Compose3' [] I I Char" "\"x\"" (pure 'x' :: Compose3' [] I I Char)
180+ , example "Compose3' [] I [] Char" "[\"x\"]" (pure 'x' :: Compose3' [] I [] Char)
181+ , example "Compose3' [] [] I Char" "[\"x\"]" (pure 'x' :: Compose3' [] [] I Char)
182+ , example "Compose3' [] [] [] Char" "[[\"x\"]]" (pure 'x' :: Compose3' [] [] [] Char)
183+
184+ , example "MyEither Int String: Left" "42" (MyLeft 42 :: MyEither Int String)
185+ , example "MyEither Int String: Right" "\"foo\"" (MyRight "foo" :: MyEither Int String)
172186
173187 -- newtypes from Monoid/Semigroup
174− , Example "Monoid.Dual Int" "2" (pure 2 :: Monoid.Dual Int)
175− , Example "Monoid.First Int" "2" (pure 2 :: Monoid.First Int)
176− , Example "Monoid.Last Int" "2" (pure 2 :: Monoid.Last Int)
177− , Example "Semigroup.Min Int" "2" (pure 2 :: Semigroup.Min Int)
178− , Example "Semigroup.Max Int" "2" (pure 2 :: Semigroup.Max Int)
179− , Example "Semigroup.First Int" "2" (pure 2 :: Semigroup.First Int)
180− , Example "Semigroup.Last Int" "2" (pure 2 :: Semigroup.Last Int)
181− , Example "Semigroup.WrappedMonoid Int" "2" (Semigroup.WrapMonoid 2 :: Semigroup.WrappedMonoid Int)
182− , Example "Semigroup.Option Just" "2" (pure 2 :: Semigroup.Option Int)
183− , Example "Semigroup.Option Nothing" "null" (Semigroup.Option (Nothing :: Maybe Bool))
188+ , example "Monoid.Dual Int" "2" (pure 2 :: Monoid.Dual Int)
189+ , example "Monoid.First Int" "2" (pure 2 :: Monoid.First Int)
190+ , example "Monoid.Last Int" "2" (pure 2 :: Monoid.Last Int)
191+ , example "Semigroup.Min Int" "2" (pure 2 :: Semigroup.Min Int)
192+ , example "Semigroup.Max Int" "2" (pure 2 :: Semigroup.Max Int)
193+ , example "Semigroup.First Int" "2" (pure 2 :: Semigroup.First Int)
194+ , example "Semigroup.Last Int" "2" (pure 2 :: Semigroup.Last Int)
195+ , example "Semigroup.WrappedMonoid Int" "2" (Semigroup.WrapMonoid 2 :: Semigroup.WrappedMonoid Int)
196+ , example "Semigroup.Option Just" "2" (pure 2 :: Semigroup.Option Int)
197+ , example "Semigroup.Option Nothing" "null" (Semigroup.Option (Nothing :: Maybe Bool))
198+
199+ -- time 1.9
200+ , example "SystemTime" "123.123456789" (MkSystemTime 123 123456789)
201+ , Example "SystemTime" ["124.23456789"]
202+ (MkSystemTime 123 1234567890)
203+ (MkSystemTime 124 234567890)
204+ , ndExample "CalendarDiffTime"
205+ [ "{\"months\":12,\"time\":456.789}", "{\"time\":456.789,\"months\":12}" ]
206+ (CalendarDiffTime 12 456.789)
207+ , ndExample "CalendarDiffDays"
208+ [ "{\"months\":12,\"days\":20}", "{\"days\":20,\"months\":12}" ]
209+ (CalendarDiffDays 12 20)
210+ , example "DayOfWeek" "\"monday\"" Monday
184211 ]
185212
186213jsonEncodingExamples :: [Example]
187214jsonEncodingExamples =
188215 [
189− -- Maybe serialising is lossy
190− -- https://github.com/bos/aeson/issues/376
191− Example "Just Nothing" "null" (Just Nothing :: Maybe (Maybe Int))
192216 -- infinities cannot be recovered, null is decoded as NaN
193− , Example "inf :: Double" "null" (Approx $ 1/0 :: Approx Double)
217+ example "inf :: Double" "null" (Approx $ 1/0 :: Approx Double)
218+ , example "-inf :: Double" "null" (Approx $ -1/0 :: Approx Double)
194219 ]
195220
196221jsonDecodingExamples :: [Example]
@@ -212,12 +237,27 @@ jsonDecodingExamples = [
212237 ]
213238
214239data Example where
215− Example
216− :: (Eq a, Show a, ToJSON a, FromJSON a)
240+ Example
241+ :: (Eq a, Show a, ToJSON a, FromJSON a)
242+ => String -- name
243+ -> [L.ByteString] -- encoded variants
244+ -> a -- input
245+ -> a -- decoded
246+ -> Example -- empty bytestring will fail, any p [] == False
247+
248+ MaybeExample
249+ :: (Eq a, Show a, FromJSON a)
250+ => String -> L.ByteString -> Maybe a -> Example
251+
252+example :: (Eq a, Show a, ToJSON a, FromJSON a)
217253 => String -> L.ByteString -> a -> Example
218− MaybeExample
219− :: (Eq a, Show a, FromJSON a)
220− => String -> L.ByteString -> Maybe a -> Example
254+example n bs x = Example n [bs] x x
255+
256+-- | Non-deterministic example, input encodes to some of bytestrings.
257+ndExample :: (Eq a, Show a, ToJSON a, FromJSON a)
258+ => String -> [L.ByteString] -> a -> Example
259+ndExample n bss x = Example n bss x x
260+
221261
222262data MyEither a b = MyLeft a | MyRight b
223263 deriving (Generic, Show, Eq)
@@ -229,17 +269,26 @@ instance (ToJSON a, ToJSON b) => ToJSON (MyEither a b) where
229269instance (FromJSON a, FromJSON b) => FromJSON (MyEither a b) where
230270 parseJSON = genericParseJSON defaultOptions { sumEncoding = UntaggedValue }
231271
232−assertJsonExample :: Example -> Test
233−assertJsonExample (Example name bs val) = testCase name $ do
234− assertEqual "encode" bs (encode val)
235− assertEqual "encode/via value" bs (encode $ toJSON val)
236− assertEqual "decode" (Just val) (decode bs)
272+assertJsonExample :: Example -> TestTree
273+assertJsonExample (Example name bss val val') = testCase name $ do
274+ assertSomeEqual "encode" bss (encode val)
275+ assertSomeEqual "encode/via value" bss (encode $ toJSON val)
276+ for_ bss $ \bs ->
277+ assertEqual "decode" (Just val') (decode bs)
237278assertJsonExample (MaybeExample name bs mval) = testCase name $
238279 assertEqual "decode" mval (decode bs)
239280
240−assertJsonEncodingExample :: Example -> Test
241−assertJsonEncodingExample (Example name bs val) = testCase name $ do
242− assertEqual "encode" bs (encode val)
243− assertEqual "encode/via value" bs (encode $ toJSON val)
281+assertJsonEncodingExample :: Example -> TestTree
282+assertJsonEncodingExample (Example name bss val _) = testCase name $ do
283+ assertSomeEqual "encode" bss (encode val)
284+ assertSomeEqual "encode/via value" bss (encode $ toJSON val)
244285assertJsonEncodingExample (MaybeExample name _ _) = testCase name $
245286 assertFailure "cannot encode MaybeExample"
287+
288+assertSomeEqual :: (Eq a, Show a, Foldable f) => String -> f a -> a -> IO ()
289+assertSomeEqual preface expected actual
290+ | actual `elem` expected = return ()
291+ | otherwise = assertFailure $ preface
292+ ++ ": expecting one of " ++ show (toList expected)
293+ ++ ", got " ++ show actual
294+
tests/Tests.hs+5−3
@@ -1,9 +1,10 @@
1+{-# LANGUAGE NoImplicitPrelude #-}
2+
13module Main (main) where
24
3−import Prelude ()
45import Prelude.Compat
56
6−import Test.Framework (defaultMain)
7+import Test.Tasty (defaultMain, testGroup)
78import qualified DataFamilies.Properties as DF
89import qualified Properties
910import qualified UnitTests
@@ -11,4 +12,5 @@ import qualified UnitTests
1112main :: IO ()
1213main = do
1314 ioTests <- UnitTests.ioTests
14− defaultMain (DF.tests : Properties.tests : UnitTests.tests : ioTests)
15+ let allTests = DF.tests : Properties.tests : UnitTests.tests : ioTests
16+ defaultMain (testGroup "tests" allTests)
tests/Types.hs+11−6
@@ -4,19 +4,21 @@
44{-# LANGUAGE FlexibleInstances #-}
55{-# LANGUAGE GADTs #-}
66{-# LANGUAGE GeneralizedNewtypeDeriving #-}
7−{-# LANGUAGE StandaloneDeriving #-}
7+{-# LANGUAGE NoImplicitPrelude #-}
88{-# LANGUAGE ScopedTypeVariables #-}
9+{-# LANGUAGE StandaloneDeriving #-}
910
10−module Types where
11+module Types (module Types) where
1112
12−import Prelude ()
1313import Prelude.Compat
1414
1515import Math.NumberTheory.Logarithms (intLog2)
16+import Control.Applicative ((<$>))
1617import Data.Data
1718import Data.Functor.Compose (Compose (..))
1819import Data.Functor.Identity (Identity (..))
1920import Data.Hashable (Hashable (..))
21+import Data.Semigroup (Option)
2022import Data.Text
2123import Data.Time (Day (..), fromGregorian)
2224import GHC.Generics
@@ -104,6 +106,10 @@ deriving instance Data (GADT String)
104106deriving instance Eq (GADT a)
105107deriving instance Show (GADT a)
106108
109+newtype MaybeField = MaybeField { maybeField :: Maybe Int }
110+newtype OptionField = OptionField { optionField :: Option Int }
111+ deriving (Eq, Show)
112+
107113deriving instance Generic Foo
108114deriving instance Generic UFoo
109115deriving instance Generic OneConstructor
@@ -113,9 +119,8 @@ deriving instance Generic (Sum4 a b c d)
113119deriving instance Generic (Approx a)
114120deriving instance Generic Nullary
115121deriving instance Generic (SomeType a)
116−#if __GLASGOW_HASKELL__ >= 706
117122deriving instance Generic1 SomeType
118−#endif
123+deriving instance Generic OptionField
119124deriving instance Generic EitherTextInt
120125
121126failure :: Show a => String -> String -> a -> Property
@@ -146,7 +151,7 @@ instance Hashable a => Hashable (LogScaled a) where
146151 hashWithSalt salt (LogScaled a) = hashWithSalt salt a
147152
148153instance Arbitrary a => Arbitrary (LogScaled a) where
149− arbitrary = fmap LogScaled $ scale (\x -> intLog2 $ x + 1) arbitrary
154+ arbitrary = LogScaled <$> scale (\x -> intLog2 $ x + 1) arbitrary
150155 shrink = fmap LogScaled . shrink . getLogScaled
151156
152157instance ToJSON a => ToJSON (LogScaled a) where
tests/UnitTests.hs+295−38
@@ -1,55 +1,72 @@
11{-# LANGUAGE CPP #-}
22{-# LANGUAGE DeriveGeneric #-}
33{-# LANGUAGE GeneralizedNewtypeDeriving #-}
4+{-# LANGUAGE NoImplicitPrelude #-}
45{-# LANGUAGE OverloadedStrings #-}
56{-# LANGUAGE ScopedTypeVariables #-}
67{-# LANGUAGE TemplateHaskell #-}
8+{-# LANGUAGE QuasiQuotes #-}
79
810-- For Data.Aeson.Types.camelTo
911{-# OPTIONS_GHC -fno-warn-deprecations #-}
1012
13+#if MIN_VERSION_base(4,9,0)
14+{-# OPTIONS_GHC -fno-warn-unused-top-binds #-}
15+#endif
16+
1117module UnitTests
1218 (
1319 ioTests
1420 , tests
21+ , withEmbeddedJSONTest
1522 ) where
1623
17−import Prelude ()
1824import Prelude.Compat
1925
2026import Control.Monad (forM, forM_)
21−import Data.Aeson ((.=), (.:), (.:?), (.:!), FromJSON(..), FromJSONKeyFunction(..), FromJSONKey(..), ToJSON1(..), decode, eitherDecode, encode, genericToEncoding, genericToJSON, object, withObject)
27+import Data.Aeson ((.=), (.:), (.:?), (.:!), FromJSON(..), FromJSONKeyFunction(..), FromJSONKey(..), ToJSON1(..), decode, eitherDecode, encode, fromJSON, genericParseJSON, genericToEncoding, genericToJSON, object, withObject, withEmbeddedJSON)
2228import Data.Aeson.Internal (JSONPathElement(..), formatError)
29+import Data.Aeson.QQ.Simple (aesonQQ)
2330import Data.Aeson.TH (deriveJSON, deriveToJSON, deriveToJSON1)
2431import Data.Aeson.Text (encodeToTextBuilder)
25−import Data.Aeson.Types (Options(..), ToJSON(..), Value, camelTo, camelTo2, defaultOptions, omitNothingFields)
32+import Data.Aeson.Parser
33+ ( json, jsonLast, jsonAccum, jsonNoDup
34+ , json', jsonLast', jsonAccum', jsonNoDup')
35+import Data.Aeson.Types
36+ ( Options(..), Result(Success, Error), ToJSON(..)
37+ , Value(Array, Bool, Null, Number, Object, String), camelTo, camelTo2
38+ , defaultOptions, formatPath, formatRelativePath, omitNothingFields, parse)
39+import Data.Attoparsec.ByteString (Parser, parseOnly)
2640import Data.Char (toUpper)
2741import Data.Either.Compat (isLeft, isRight)
2842import Data.Hashable (hash)
29−import Data.List (sort)
43+import Data.HashMap.Strict (HashMap)
44+import Data.List (sort, isSuffixOf)
3045import Data.Maybe (fromMaybe)
31−import Data.Sequence (Seq)
46+import Data.Scientific (Scientific, scientific)
3247import Data.Tagged (Tagged(..))
3348import Data.Text (Text)
3449import Data.Time (UTCTime)
35−import Data.Time.Format (parseTime)
36−import Data.Time.Locale.Compat (defaultTimeLocale)
50+import Data.Time.Format.Compat (parseTimeM, defaultTimeLocale)
3751import GHC.Generics (Generic)
3852import Instances ()
53+import Numeric.Natural (Natural)
3954import System.Directory (getDirectoryContents)
4055import System.FilePath ((</>), takeExtension, takeFileName)
41−import Test.Framework (Test, testGroup)
42−import Test.Framework.Providers.HUnit (testCase)
43−import Test.HUnit (Assertion, assertBool, assertFailure, assertEqual)
56+import Test.Tasty (TestTree, testGroup)
57+import Test.Tasty.HUnit (Assertion, assertBool, assertFailure, assertEqual, testCase, (@?=))
4458import Text.Printf (printf)
4559import UnitTests.NullaryConstructors (nullaryConstructors)
60+import qualified Data.ByteString as S
4661import qualified Data.ByteString.Base16.Lazy as LBase16
4762import qualified Data.ByteString.Lazy.Char8 as L
4863import qualified Data.HashSet as HashSet
64+import qualified Data.HashMap.Lazy as HashMap
4965import qualified Data.Text.Lazy as LT
5066import qualified Data.Text.Lazy.Builder as TLB
5167import qualified Data.Text.Lazy.Encoding as LT
5268import qualified Data.Text.Lazy.Encoding as TLE
69+import qualified Data.Vector as Vector
5370import qualified ErrorMessages
5471import qualified SerializationFormatSpec
5572
@@ -57,7 +74,7 @@ import qualified SerializationFormatSpec
5774import Data.Aeson.Parser.UnescapeFFI ()
5875import Data.Aeson.Parser.UnescapePure ()
5976
60−tests :: Test
77+tests :: TestTree
6178tests = testGroup "unit" [
6279 testGroup "SerializationFormatSpec" SerializationFormatSpec.tests
6380 , testGroup "ErrorMessages" ErrorMessages.tests
@@ -84,14 +101,31 @@ tests = testGroup "unit" [
84101 testCase "example 1" formatErrorExample
85102 ]
86103 , testGroup ".:, .:?, .:!" $ fmap (testCase "-") dotColonMark
87− , testGroup "JSONPath" $ fmap (testCase "-") jsonPath
88104 , testGroup "Hashable laws" $ fmap (testCase "-") hashableLaws
105+ , testGroup "Object construction" $ fmap (testCase "-") objectConstruction
89106 , testGroup "Issue #351" $ fmap (testCase "-") issue351
90107 , testGroup "Nullary constructors" $ fmap (testCase "-") nullaryConstructors
91108 , testGroup "FromJSONKey" $ fmap (testCase "-") fromJSONKeyAssertions
92109 , testCase "PR #455" pr455
93110 , testCase "Unescape string (PR #477)" unescapeString
94111 , testCase "Show Options" showOptions
112+ , testGroup "SingleMaybeField" singleMaybeField
113+ , testCase "withEmbeddedJSON" withEmbeddedJSONTest
114+ , testCase "SingleFieldCon" singleFieldCon
115+ , testGroup "UnknownFields" unknownFields
116+ , testGroup "Ordering of object keys" keyOrdering
117+ , testCase "Ratio with denominator 0" ratioDenominator0
118+ , testCase "Rational parses number" rationalNumber
119+ , testCase "Big rational" bigRationalDecoding
120+ , testCase "Small rational" smallRationalDecoding
121+ , testCase "Big scientific exponent" bigScientificExponent
122+ , testCase "Big integer decoding" bigIntegerDecoding
123+ , testCase "Big natural decading" bigNaturalDecoding
124+ , testCase "Big integer key decoding" bigIntegerKeyDecoding
125+ , testGroup "QQ.Simple"
126+ [ testCase "example" $
127+ assertEqual "" (object ["foo" .= True]) [aesonQQ| {"foo": true } |]
128+ ]
95129 ]
96130
97131roundTripCamel :: String -> Assertion
@@ -184,10 +218,18 @@ utcTimeGood = do
184218 assertEqual "utctime" (parseWithRead "%F %H:%MZ" ts11) t11
185219 assertEqual "utctime" (parseWithRead "%FT%T%QZ" "2015-01-01T14:30:00Z") t12
186220
221+ -- leap seconds are included correctly
222+ let ts13 = "2015-08-23T23:59:60.128+00" :: LT.Text
223+ let (Just (t13 :: UTCTime)) = parseWithAeson ts13
224+ assertEqual "utctime" (parseWithRead "%FT%T%QZ" "2015-08-23T23:59:60.128Z") t13
225+ let ts14 = "2015-08-23T23:59:60.999999999999+00" :: LT.Text
226+ let (Just (t14 :: UTCTime)) = parseWithAeson ts14
227+ assertEqual "utctime" (parseWithRead "%FT%T%QZ" "2015-08-23T23:59:60.999999999999Z") t14
228+
187229 where
188230 parseWithRead :: String -> LT.Text -> UTCTime
189231 parseWithRead f s =
190− fromMaybe (error "parseTime input malformed") . parseTime defaultTimeLocale f . LT.unpack $ s
232+ fromMaybe (error "parseTime input malformed") . parseTimeM True defaultTimeLocale f . LT.unpack $ s
191233 parseWithAeson :: LT.Text -> Maybe UTCTime
192234 parseWithAeson s = decode . LT.encodeUtf8 $ LT.concat ["\"", s, "\""]
193235
@@ -203,6 +245,7 @@ utcTimeBad = do
203245 verifyFailParse "2015-01-01T12:30:00.00+00:00Z" -- no Zulu if offset given
204246 verifyFailParse "2015-01-03 12:13:00.Z" -- decimal at the end but no digits
205247 verifyFailParse "2015-01-03 12:13.000Z" -- decimal at the end, but no seconds
248+ verifyFailParse "2015-01-03 23:59:61Z" -- exceeds allowed seconds per day
206249 where
207250 verifyFailParse (s :: LT.Text) =
208251 let (dec :: Maybe UTCTime) = decode . LT.encodeUtf8 $ LT.concat ["\"", s, "\""] in
@@ -215,6 +258,18 @@ formatErrorExample =
215258 lhs = "Error in $[0].foo.bar['a.b.c']['']['\\'\\\\'].end: error msg"
216259 in assertEqual "formatError example" lhs rhs
217260
261+formatPathExample :: Assertion
262+formatPathExample =
263+ let rhs = formatPath [Key "x", Index 0]
264+ lhs = "$.x[0]"
265+ in assertEqual "formatPath example" lhs rhs
266+
267+formatRelativePathExample :: Assertion
268+formatRelativePathExample =
269+ let rhs = formatPath [Key "x", Index 0]
270+ lhs = ".x[0]"
271+ in assertEqual "formatRelativePath example" lhs rhs
272+
218273------------------------------------------------------------------------------
219274-- Comparison (.:?) and (.:!)
220275------------------------------------------------------------------------------
@@ -245,27 +300,6 @@ dotColonMark = [
245300 ex2 = "{\"value\": 42 }"
246301 ex3 = "{\"value\": null }"
247302
248−------------------------------------------------------------------------------
249−-- These tests check that JSONPath is tracked correctly
250−-----------------------------------------------------------------------------
251−
252−jsonPath :: [Assertion]
253−jsonPath = [
254− -- issue #356
255− assertEqual "Either"
256− (Left "Error in $[1].Left[1]: expected Bool, encountered Number")
257− (eitherDecode "[1,{\"Left\":[2,3]}]"
258− :: Either String (Int, Either (Int, Bool) ()))
259− -- issue #358
260− , assertEqual "Seq a"
261− (Left "Error in $[2]: expected Int, encountered Boolean")
262− (eitherDecode "[0,1,true]" :: Either String (Seq Int))
263− , assertEqual "Wibble"
264− (Left "Error in $.wibbleInt: expected Int, encountered Boolean")
265− (eitherDecode "{\"wibbleString\":\"\",\"wibbleInt\":true}"
266− :: Either String Wibble)
267− ]
268−
269303------------------------------------------------------------------------------
270304-- Check that the hashes of two equal Value are the same
271305------------------------------------------------------------------------------
@@ -278,6 +312,18 @@ hashableLaws = [
278312 a = object ["223" .= False, "807882556" .= True]
279313 b = object ["807882556" .= True, "223" .= False]
280314
315+------------------------------------------------------------------------------
316+-- Check that an alternative way to construct objects works
317+------------------------------------------------------------------------------
318+
319+objectConstruction :: [Assertion]
320+objectConstruction = [
321+ assertEqual "Equal objects constructed differently" recommended notRecommended
322+ ]
323+ where
324+ recommended = object ["foo" .= True, "bar" .= (-1 :: Int)]
325+ notRecommended = Object (mconcat ["foo" .= True, "bar" .= (-1 :: Int)])
326+
281327-------------------------------------------------------------------------------
282328-- ToJSONKey
283329-------------------------------------------------------------------------------
@@ -338,13 +384,13 @@ issue351 = [
338384-- Comparison between bytestring and text encoders
339385------------------------------------------------------------------------------
340386
341−ioTests :: IO [Test]
387+ioTests :: IO [TestTree]
342388ioTests = do
343389 enc <- encoderComparisonTests
344390 js <- jsonTestSuite
345391 return [enc, js]
346392
347−encoderComparisonTests :: IO Test
393+encoderComparisonTests :: IO TestTree
348394encoderComparisonTests = do
349395 encoderTests <- forM testFiles $ \file0 -> do
350396 let file = "benchmarks/json-data/" ++ file0
@@ -404,7 +450,7 @@ unescapeString = do
404450
405451-- JSONTestSuite
406452
407−jsonTestSuiteTest :: FilePath -> Test
453+jsonTestSuiteTest :: FilePath -> TestTree
408454jsonTestSuiteTest path = testCase fileName $ do
409455 payload <- L.readFile path
410456 let result = eitherDecode payload :: Either String Value
@@ -419,7 +465,7 @@ jsonTestSuiteTest path = testCase fileName $ do
419465-- Build a collection of tests based on the current contents of the
420466-- JSONTestSuite test directories.
421467
422−jsonTestSuite :: IO Test
468+jsonTestSuite :: IO TestTree
423469jsonTestSuite = do
424470 let suitePath = "tests/JSONTestSuite"
425471 let suites = ["test_parsing", "test_transform"]
@@ -494,10 +540,221 @@ showOptions =
494540 ++ ", sumEncoding = TaggedObject {tagFieldName = \"tag\", contentsFieldName = \"contents\"}"
495541 ++ ", unwrapUnaryRecords = False"
496542 ++ ", tagSingleConstructors = False"
543+ ++ ", rejectUnknownFields = False"
497544 ++ "}")
498545 (show defaultOptions)
499546
547+newtype SingleMaybeField = SingleMaybeField { smf :: Maybe Int }
548+ deriving (Eq, Show, Generic)
549+
550+singleMaybeField :: [TestTree]
551+singleMaybeField = do
552+ (gName, gToJSON, gToEncoding, gFromJSON) <-
553+ [ ("generic", genericToJSON opts, genericToEncoding opts, parse (genericParseJSON opts))
554+ , ("th", toJSON, toEncoding, fromJSON) ]
555+ return $
556+ testCase gName $ do
557+ assertEqual "toJSON" Null (gToJSON v)
558+ assertEqual "toEncoding" (toEncoding (gToJSON v)) (gToEncoding v)
559+ assertEqual "fromJSON" (Success v) (gFromJSON Null)
560+ where
561+ v = SingleMaybeField Nothing
562+ opts = defaultOptions{omitNothingFields=True,unwrapUnaryRecords=True}
563+
564+
565+newtype EmbeddedJSONTest = EmbeddedJSONTest Int
566+ deriving (Eq, Show)
567+
568+instance FromJSON EmbeddedJSONTest where
569+ parseJSON =
570+ withObject "Object" $ \o ->
571+ EmbeddedJSONTest <$> (o .: "prop" >>= withEmbeddedJSON "Quoted Int" parseJSON)
572+
573+withEmbeddedJSONTest :: Assertion
574+withEmbeddedJSONTest =
575+ assertEqual "Unquote embedded JSON" (Right $ EmbeddedJSONTest 1) (eitherDecode "{\"prop\":\"1\"}")
576+
577+-- Regression test for https://github.com/bos/aeson/issues/627
578+newtype SingleFieldCon = SingleFieldCon Int deriving (Eq, Show, Generic)
579+
580+instance FromJSON SingleFieldCon where
581+ parseJSON = genericParseJSON defaultOptions{unwrapUnaryRecords=True}
582+ -- This option should have no effect on this type
583+
584+singleFieldCon :: Assertion
585+singleFieldCon =
586+ assertEqual "fromJSON" (Right (SingleFieldCon 0)) (eitherDecode "0")
587+
588+newtype UnknownFields = UnknownFields { knownField :: Int }
589+ deriving (Eq, Show, Generic)
590+newtype UnknownFieldsTag = UnknownFieldsTag { tag :: Int }
591+ deriving (Eq, Show, Generic)
592+newtype UnknownFieldsUnaryTagged = UnknownFieldsUnaryTagged { knownFieldUnaryTagged :: Int }
593+ deriving (Eq, Show, Generic)
594+data UnknownFieldsSum
595+ = UnknownFields1 { knownField1 :: Int }
596+ | UnknownFields2 { knownField2 :: Int }
597+ deriving (Eq, Show, Generic)
598+
599+unknownFields :: [TestTree]
600+unknownFields = concat
601+ [ testsUnary
602+ "unary-unknown"
603+ (object [("knownField", Number 1), ("unknownField", Number 1)])
604+ (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFields)
605+ , testsUnary
606+ "unary-unknown-tag"
607+ (object [("knownField", Number 1), ("tag", String "UnknownFields")])
608+ (Error "nknown fields: [\"tag\"]" :: Result UnknownFields)
609+ , testsUnaryTag
610+ "unary-explicit-tag"
611+ (object [("tag", Number 1)])
612+ (Success $ UnknownFieldsTag 1)
613+ , testsSum
614+ "sum-tag"
615+ (object [("knownField1", Number 1), ("tag", String "UnknownFields1")])
616+ (Success $ UnknownFields1 1)
617+ , testsSum
618+ "sum-unknown-in-branch"
619+ (object [("knownField1", Number 1), ("knownField2", Number 1), ("tag", String "UnknownFields1")])
620+ (Error "nknown fields: [\"knownField2\"]" :: Result UnknownFieldsSum)
621+ , testsSum
622+ "sum-unknown"
623+ (object [("knownField1", Number 1), ("unknownField", Number 1), ("tag", String "UnknownFields1")])
624+ (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFieldsSum)
625+ , testsTagged
626+ "unary-tagged"
627+ (object [("knownFieldUnaryTagged", Number 1), ("tag", String "UnknownFieldsUnaryTagged")])
628+ (Success $ UnknownFieldsUnaryTagged 1)
629+ , -- Just a case to verify that the tag isn't optional, this is likely already tested by other unit tests
630+ testsTagged
631+ "unary-tagged-notag"
632+ (object [("knownFieldUnaryTagged", Number 1)])
633+ (Error "key \"tag\" not found" :: Result UnknownFieldsUnaryTagged)
634+ , testsTagged
635+ "unary-tagged-unknown"
636+ (object [ ("knownFieldUnaryTagged", Number 1), ("unknownField", Number 1)
637+ , ("tag", String "UnknownFieldsUnaryTagged")])
638+ (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFieldsUnaryTagged)
639+ ]
640+ where
641+ opts = defaultOptions{rejectUnknownFields=True}
642+ taggedOpts = opts{tagSingleConstructors=True}
643+ assertApprox :: (Show a, Eq a) => Result a -> Result a -> IO ()
644+ assertApprox (Error expected) (Error actual) | expected `isSuffixOf` actual = return ()
645+ assertApprox expected actual = assertEqual "fromJSON" expected actual
646+ testsBase :: (Show a, Eq a) => (Value -> Result a) -> (Value -> Result a)
647+ -> String -> Value -> Result a -> [TestTree]
648+ testsBase th g name value expected =
649+ [ testCase (name ++ "-th") $ assertApprox expected (th value)
650+ , testCase (name ++ "-generic") $ assertApprox expected (g value)
651+ ]
652+ testsUnary :: String -> Value -> Result UnknownFields -> [TestTree]
653+ testsUnary = testsBase fromJSON (parse (genericParseJSON opts))
654+ testsUnaryTag :: String -> Value -> Result UnknownFieldsTag -> [TestTree]
655+ testsUnaryTag = testsBase fromJSON (parse (genericParseJSON opts))
656+ testsSum :: String -> Value -> Result UnknownFieldsSum -> [TestTree]
657+ testsSum = testsBase fromJSON (parse (genericParseJSON opts))
658+ testsTagged :: String -> Value -> Result UnknownFieldsUnaryTagged -> [TestTree]
659+ testsTagged = testsBase fromJSON (parse (genericParseJSON taggedOpts))
660+
661+testParser :: (Eq a, Show a)
662+ => String -> Parser a -> S.ByteString -> Either String a -> TestTree
663+testParser name json_ s expected =
664+ testCase name (parseOnly json_ s @?= expected)
665+
666+keyOrdering :: [TestTree]
667+keyOrdering =
668+ [ testParser "json" json
669+ "{\"k\":true,\"k\":false}" $
670+ Right (Object (HashMap.fromList [("k", Bool True)]))
671+ , testParser "jsonLast" jsonLast
672+ "{\"k\":true,\"k\":false}" $
673+ Right (Object (HashMap.fromList [("k", Bool False)]))
674+ , testParser "jsonAccum" jsonAccum
675+ "{\"k\":true,\"k\":false}" $
676+ Right (Object (HashMap.fromList [("k", Array (Vector.fromList [Bool True, Bool False]))]))
677+ , testParser "jsonNoDup" jsonNoDup
678+ "{\"k\":true,\"k\":false}" $
679+ Left "Failed reading: found duplicate key: \"k\""
680+
681+ , testParser "json'" json'
682+ "{\"k\":true,\"k\":false}" $
683+ Right (Object (HashMap.fromList [("k", Bool True)]))
684+ , testParser "jsonLast'" jsonLast'
685+ "{\"k\":true,\"k\":false}" $
686+ Right (Object (HashMap.fromList [("k", Bool False)]))
687+ , testParser "jsonAccum'" jsonAccum'
688+ "{\"k\":true,\"k\":false}" $
689+ Right (Object (HashMap.fromList [("k", Array (Vector.fromList [Bool True, Bool False]))]))
690+ , testParser "jsonNoDup'" jsonNoDup'
691+ "{\"k\":true,\"k\":false}" $
692+ Left "Failed reading: found duplicate key: \"k\""
693+ ]
694+
695+ratioDenominator0 :: Assertion
696+ratioDenominator0 =
697+ assertEqual "Ratio with denominator 0"
698+ (Left "Error in $: Ratio denominator was 0")
699+ (eitherDecode "{ \"numerator\": 1, \"denominator\": 0 }" :: Either String Rational)
700+
701+rationalNumber :: Assertion
702+rationalNumber =
703+ assertEqual "Ratio with denominator 0"
704+ (Right 1.37)
705+ (eitherDecode "1.37" :: Either String Rational)
706+
707+bigRationalDecoding :: Assertion
708+bigRationalDecoding =
709+ assertEqual "Decoding an Integer with a large exponent should fail"
710+ (Left "Error in $: parsing Ratio failed, found a number with exponent 2000, but it must not be greater than 1024 or less than -1024")
711+ ((eitherDecode :: L.ByteString -> Either String Rational) "1e2000")
712+
713+smallRationalDecoding :: Assertion
714+smallRationalDecoding =
715+ assertEqual "Decoding an Integer with a large exponent should fail"
716+ (Left "Error in $: parsing Ratio failed, found a number with exponent -2000, but it must not be greater than 1024 or less than -1024")
717+ ((eitherDecode :: L.ByteString -> Either String Rational) "1e-2000")
718+
719+
720+bigScientificExponent :: Assertion
721+bigScientificExponent =
722+ assertEqual "Encoding an integral scientific with a large exponent should normalize it"
723+ "1.0e2000"
724+ (encode (scientific 1 2000 :: Scientific))
725+
726+bigIntegerDecoding :: Assertion
727+bigIntegerDecoding =
728+ assertEqual "Decoding an Integer with a large exponent should fail"
729+ (Left "Error in $: parsing Integer failed, found a number with exponent 2000, but it must not be greater than 1024")
730+ ((eitherDecode :: L.ByteString -> Either String Integer) "1e2000")
731+
732+bigNaturalDecoding :: Assertion
733+bigNaturalDecoding =
734+ assertEqual "Decoding a Natural with a large exponent should fail"
735+ (Left "Error in $: parsing Natural failed, found a number with exponent 2000, but it must not be greater than 1024")
736+ ((eitherDecode :: L.ByteString -> Either String Natural) "1e2000")
737+
738+bigIntegerKeyDecoding :: Assertion
739+bigIntegerKeyDecoding =
740+ assertEqual "Decoding an Integer key with a large exponent should fail"
741+ (Left "Error in $['1e2000']: parsing Integer failed, found a number with exponent 2000, but it must not be greater than 1024")
742+ ((eitherDecode :: L.ByteString -> Either String (HashMap Integer Value)) "{ \"1e2000\": null }")
743+
744+bigNaturalKeyDecoding :: Assertion
745+bigNaturalKeyDecoding =
746+ assertEqual "Decoding an Integer key with a large exponent should fail"
747+ (Left "Error in $['1e2000']: found a number with exponent 2000, but it must not be greater than 1024")
748+ ((eitherDecode :: L.ByteString -> Either String (HashMap Natural Value)) "{ \"1e2000\": null }")
749+
500750deriveJSON defaultOptions{omitNothingFields=True} ''MyRecord
501751
502752deriveToJSON defaultOptions ''Foo
503753deriveToJSON1 defaultOptions ''Foo
754+
755+deriveJSON defaultOptions{omitNothingFields=True,unwrapUnaryRecords=True} ''SingleMaybeField
756+
757+deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFields
758+deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFieldsTag
759+deriveJSON defaultOptions{tagSingleConstructors=True,rejectUnknownFields=True} ''UnknownFieldsUnaryTagged
760+deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFieldsSum
tests/UnitTests/NullaryConstructors.hs+8−3
@@ -1,4 +1,5 @@
1−{-# LANGUAGE OverloadedStrings #-}
1+{-# LANGUAGE NoImplicitPrelude #-}
2+{-# LANGUAGE OverloadedStrings #-}
23
34{-# OPTIONS_GHC -fno-warn-deprecations #-}
45
@@ -7,16 +8,16 @@ module UnitTests.NullaryConstructors
78 nullaryConstructors
89 ) where
910
10−import Prelude ()
1111import Prelude.Compat
1212
1313import Data.Aeson (decode, eitherDecode, fromEncoding, Value)
1414import Data.Aeson.Internal (IResult (..), iparse)
1515import Data.Aeson.Types (Parser)
1616import Data.ByteString.Builder (toLazyByteString)
17+import Data.Foldable (for_)
1718import Data.Maybe (fromJust)
1819import Encoders
19−import Test.HUnit ((@=?), Assertion)
20+import Test.Tasty.HUnit ((@=?), Assertion)
2021import Types
2122import qualified Data.ByteString.Lazy.Char8 as L
2223
@@ -52,6 +53,10 @@ nullaryConstructors =
5253 -- Make sure that the old `"contents" : []' is still allowed
5354 , ISuccess C1 @=? parse thNullaryParseJSONTaggedObject (dec "{\"tag\":\"c1\",\"contents\":[]}")
5455 , ISuccess C1 @=? parse gNullaryParseJSONTaggedObject (dec "{\"tag\":\"c1\",\"contents\":[]}")
56+
57+ , for_ [("kC1", C1), ("kC2", C2), ("kC3", C3)] $ \(jkey, key) -> do
58+ Right jkey @=? gNullaryToJSONKey key
59+ ISuccess key @=? parse gNullaryFromJSONKey jkey
5560 ]
5661 where
5762 enc = eitherDecode . toLazyByteString . fromEncoding
tests/golden/generic.expectednew file+48
@@ -0,0 +1,48 @@
1+OneConstructor
2+Error in $: parsing Types.OneConstructor(OneConstructor) failed, expected Array, but encountered String
3+Error in $: parsing Types.OneConstructor(OneConstructor) failed, expected an empty Array, but encountered an Array of length 1
4+Nullary
5+Error in $: parsing Types.Nullary failed, expected one of the tags ["C1","C2","C3"], but found tag "X"
6+Error in $: parsing Types.Nullary failed, expected String, but encountered Array
7+SomeType (tagged)
8+Error in $.contents: parsing Int failed, expected Number, but encountered Boolean
9+Error in $: parsing Types.SomeType(Unary) failed, key "contents" not found
10+Error in $: parsing Types.SomeType(Record) failed, key "testone" not found
11+Error in $.testone: parsing Double failed, unexpected Boolean
12+Error in $.tag: parsing Types.SomeType failed, expected tag field to be one of ["nullary","unary","product","record","list"], but found tag "X"
13+Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found
14+Error in $: parsing Types.SomeType failed, expected Object, but encountered Array
15+SomeType (single-field)
16+Error in $.unary: parsing Int failed, expected Number, but encountered Object
17+Error in $.unary: parsing Int failed, expected Number, but encountered Array
18+Error in $: parsing Types.SomeType failed, expected an Object with a single pair where the tag is one of ["nullary","unary","product","record","list"], but found tag "X"
19+Error in $: parsing Types.SomeType failed, expected an Object with a single pair, but found 2 pairs
20+Error in $: parsing Types.SomeType failed, expected an Object with a single pair, but found 0 pairs
21+Error in $: parsing Types.SomeType failed, expected Object, but encountered Array
22+Error in $: not enough input. Expecting ':'
23+Error in $: not enough input. Expecting object value
24+Error in $: not enough input. Expecting ',' or '}'
25+SomeType (two-element array)
26+Error in $[1]: parsing Int failed, expected Number, but encountered Boolean
27+Error in $[1]: parsing Types.SomeType(Record) failed, expected Object, but encountered Null
28+Error in $[0]: parsing Types.SomeType failed, expected tag of the 2-element Array to be one of ["nullary","unary","product","record","list"], but found tag "X"
29+Error in $[0]: parsing Types.SomeType failed, tag element is not a String
30+Error in $: parsing Types.SomeType failed, expected a 2-element Array, but encountered an Array of length 0
31+Error in $: parsing Types.SomeType failed, expected Array, but encountered Object
32+Error in $: not enough input. Expecting ',' or ']'
33+Error in $: not enough input. Expecting json list value
34+SomeType (reject unknown fields)
35+Error in $: parsing Types.SomeType(Record) failed, unknown fields: ["testZero"]
36+Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found
37+Error in $: parsing Types.SomeType(Record) failed, unknown fields: ["testtwo","testone","testthree"]
38+Foo (reject unknown fields)
39+Error in $: parsing Types.Foo(Foo) failed, unknown fields: ["tag"]
40+Foo (reject unknown fields, tagged single)
41+Error in $: parsing Types.Foo(Foo) failed, unknown fields: ["unknownField"]
42+EitherTextInt
43+Error in $: parsing Types.EitherTextInt(NoneNullary) failed, expected tag "nonenullary", but found tag "X"
44+Error in $: parsing Types.EitherTextInt(NoneNullary) failed, expected String, but encountered Array
45+Product2 Int Bool
46+Error in $[1]: expected Bool, but encountered Null
47+Error in $: parsing Types.Product2(Product2) failed, expected an Array of length 2, but encountered an Array of length 0
48+Error in $: parsing Types.Product2(Product2) failed, expected Array, but encountered Object
tests/golden/simple.expectednew file+22
@@ -0,0 +1,22 @@
1+Int
2+Error in $: parsing Int failed, expected Number, but encountered String
3+Error in $: parsing Int failed, expected Number, but encountered Array
4+Error in $: parsing Int failed, expected Number, but encountered Object
5+Error in $: parsing Int failed, expected Number, but encountered Null
6+Integer
7+Error in $: parsing Integer failed, unexpected floating number 44.44
8+Natural
9+Error in $: parsing Natural failed, unexpected floating number 44.44
10+Error in $: parsing Natural failed, unexpected negative number -50
11+String
12+Error in $: expected String, but encountered Number
13+Error in $: expected String, but encountered Array
14+Error in $: expected String, but encountered Object
15+Error in $: expected String, but encountered Null
16+HashMap
17+Error in $: parsing HashMap failed, expected Object, but encountered String
18+Error in $: parsing HashMap failed, expected Object, but encountered Array
19+Either
20+Error in $[1].Left[1]: expected Bool, but encountered Number
21+Seq
22+Error in $[2]: parsing Int failed, expected Number, but encountered Boolean
travis/cabal_macros.hnew file+448
@@ -0,0 +1,448 @@
1+/* DO NOT EDIT: This file is automatically generated by Cabal */
2+
3+/* package aeson-1.4.4.0 */
4+#ifndef VERSION_aeson
5+#define VERSION_aeson "1.4.4.0"
6+#endif /* VERSION_aeson */
7+#ifndef MIN_VERSION_aeson
8+#define MIN_VERSION_aeson(major1,major2,minor) (\
9+ (major1) < 1 || \
10+ (major1) == 1 && (major2) < 4 || \
11+ (major1) == 1 && (major2) == 4 && (minor) <= 4)
12+#endif /* MIN_VERSION_aeson */
13+
14+/* package Diff-0.3.4 */
15+#ifndef VERSION_Diff
16+#define VERSION_Diff "0.3.4"
17+#endif /* VERSION_Diff */
18+#ifndef MIN_VERSION_Diff
19+#define MIN_VERSION_Diff(major1,major2,minor) (\
20+ (major1) < 0 || \
21+ (major1) == 0 && (major2) < 3 || \
22+ (major1) == 0 && (major2) == 3 && (minor) <= 4)
23+#endif /* MIN_VERSION_Diff */
24+
25+/* package QuickCheck-2.13.1 */
26+#ifndef VERSION_QuickCheck
27+#define VERSION_QuickCheck "2.13.1"
28+#endif /* VERSION_QuickCheck */
29+#ifndef MIN_VERSION_QuickCheck
30+#define MIN_VERSION_QuickCheck(major1,major2,minor) (\
31+ (major1) < 2 || \
32+ (major1) == 2 && (major2) < 13 || \
33+ (major1) == 2 && (major2) == 13 && (minor) <= 1)
34+#endif /* MIN_VERSION_QuickCheck */
35+
36+/* package aeson-1.4.4.0 */
37+#ifndef VERSION_aeson
38+#define VERSION_aeson "1.4.4.0"
39+#endif /* VERSION_aeson */
40+#ifndef MIN_VERSION_aeson
41+#define MIN_VERSION_aeson(major1,major2,minor) (\
42+ (major1) < 1 || \
43+ (major1) == 1 && (major2) < 4 || \
44+ (major1) == 1 && (major2) == 4 && (minor) <= 4)
45+#endif /* MIN_VERSION_aeson */
46+
47+/* package attoparsec-0.13.2.2 */
48+#ifndef VERSION_attoparsec
49+#define VERSION_attoparsec "0.13.2.2"
50+#endif /* VERSION_attoparsec */
51+#ifndef MIN_VERSION_attoparsec
52+#define MIN_VERSION_attoparsec(major1,major2,minor) (\
53+ (major1) < 0 || \
54+ (major1) == 0 && (major2) < 13 || \
55+ (major1) == 0 && (major2) == 13 && (minor) <= 2)
56+#endif /* MIN_VERSION_attoparsec */
57+
58+/* package base-4.12.0.0 */
59+#ifndef VERSION_base
60+#define VERSION_base "4.12.0.0"
61+#endif /* VERSION_base */
62+#ifndef MIN_VERSION_base
63+#define MIN_VERSION_base(major1,major2,minor) (\
64+ (major1) < 4 || \
65+ (major1) == 4 && (major2) < 12 || \
66+ (major1) == 4 && (major2) == 12 && (minor) <= 0)
67+#endif /* MIN_VERSION_base */
68+
69+/* package base-compat-0.10.5 */
70+#ifndef VERSION_base_compat
71+#define VERSION_base_compat "0.10.5"
72+#endif /* VERSION_base_compat */
73+#ifndef MIN_VERSION_base_compat
74+#define MIN_VERSION_base_compat(major1,major2,minor) (\
75+ (major1) < 0 || \
76+ (major1) == 0 && (major2) < 10 || \
77+ (major1) == 0 && (major2) == 10 && (minor) <= 5)
78+#endif /* MIN_VERSION_base_compat */
79+
80+/* package base-orphans-0.8.1 */
81+#ifndef VERSION_base_orphans
82+#define VERSION_base_orphans "0.8.1"
83+#endif /* VERSION_base_orphans */
84+#ifndef MIN_VERSION_base_orphans
85+#define MIN_VERSION_base_orphans(major1,major2,minor) (\
86+ (major1) < 0 || \
87+ (major1) == 0 && (major2) < 8 || \
88+ (major1) == 0 && (major2) == 8 && (minor) <= 1)
89+#endif /* MIN_VERSION_base_orphans */
90+
91+/* package base16-bytestring-0.1.1.6 */
92+#ifndef VERSION_base16_bytestring
93+#define VERSION_base16_bytestring "0.1.1.6"
94+#endif /* VERSION_base16_bytestring */
95+#ifndef MIN_VERSION_base16_bytestring
96+#define MIN_VERSION_base16_bytestring(major1,major2,minor) (\
97+ (major1) < 0 || \
98+ (major1) == 0 && (major2) < 1 || \
99+ (major1) == 0 && (major2) == 1 && (minor) <= 1)
100+#endif /* MIN_VERSION_base16_bytestring */
101+
102+/* package bytestring-0.10.8.2 */
103+#ifndef VERSION_bytestring
104+#define VERSION_bytestring "0.10.8.2"
105+#endif /* VERSION_bytestring */
106+#ifndef MIN_VERSION_bytestring
107+#define MIN_VERSION_bytestring(major1,major2,minor) (\
108+ (major1) < 0 || \
109+ (major1) == 0 && (major2) < 10 || \
110+ (major1) == 0 && (major2) == 10 && (minor) <= 8)
111+#endif /* MIN_VERSION_bytestring */
112+
113+/* package containers-0.6.0.1 */
114+#ifndef VERSION_containers
115+#define VERSION_containers "0.6.0.1"
116+#endif /* VERSION_containers */
117+#ifndef MIN_VERSION_containers
118+#define MIN_VERSION_containers(major1,major2,minor) (\
119+ (major1) < 0 || \
120+ (major1) == 0 && (major2) < 6 || \
121+ (major1) == 0 && (major2) == 6 && (minor) <= 0)
122+#endif /* MIN_VERSION_containers */
123+
124+/* package directory-1.3.3.0 */
125+#ifndef VERSION_directory
126+#define VERSION_directory "1.3.3.0"
127+#endif /* VERSION_directory */
128+#ifndef MIN_VERSION_directory
129+#define MIN_VERSION_directory(major1,major2,minor) (\
130+ (major1) < 1 || \
131+ (major1) == 1 && (major2) < 3 || \
132+ (major1) == 1 && (major2) == 3 && (minor) <= 3)
133+#endif /* MIN_VERSION_directory */
134+
135+/* package dlist-0.8.0.6 */
136+#ifndef VERSION_dlist
137+#define VERSION_dlist "0.8.0.6"
138+#endif /* VERSION_dlist */
139+#ifndef MIN_VERSION_dlist
140+#define MIN_VERSION_dlist(major1,major2,minor) (\
141+ (major1) < 0 || \
142+ (major1) == 0 && (major2) < 8 || \
143+ (major1) == 0 && (major2) == 8 && (minor) <= 0)
144+#endif /* MIN_VERSION_dlist */
145+
146+/* package filepath-1.4.2.1 */
147+#ifndef VERSION_filepath
148+#define VERSION_filepath "1.4.2.1"
149+#endif /* VERSION_filepath */
150+#ifndef MIN_VERSION_filepath
151+#define MIN_VERSION_filepath(major1,major2,minor) (\
152+ (major1) < 1 || \
153+ (major1) == 1 && (major2) < 4 || \
154+ (major1) == 1 && (major2) == 4 && (minor) <= 2)
155+#endif /* MIN_VERSION_filepath */
156+
157+/* package generic-deriving-1.12.4 */
158+#ifndef VERSION_generic_deriving
159+#define VERSION_generic_deriving "1.12.4"
160+#endif /* VERSION_generic_deriving */
161+#ifndef MIN_VERSION_generic_deriving
162+#define MIN_VERSION_generic_deriving(major1,major2,minor) (\
163+ (major1) < 1 || \
164+ (major1) == 1 && (major2) < 12 || \
165+ (major1) == 1 && (major2) == 12 && (minor) <= 4)
166+#endif /* MIN_VERSION_generic_deriving */
167+
168+/* package ghc-prim-0.5.3 */
169+#ifndef VERSION_ghc_prim
170+#define VERSION_ghc_prim "0.5.3"
171+#endif /* VERSION_ghc_prim */
172+#ifndef MIN_VERSION_ghc_prim
173+#define MIN_VERSION_ghc_prim(major1,major2,minor) (\
174+ (major1) < 0 || \
175+ (major1) == 0 && (major2) < 5 || \
176+ (major1) == 0 && (major2) == 5 && (minor) <= 3)
177+#endif /* MIN_VERSION_ghc_prim */
178+
179+/* package hashable-1.3.0.0 */
180+#ifndef VERSION_hashable
181+#define VERSION_hashable "1.3.0.0"
182+#endif /* VERSION_hashable */
183+#ifndef MIN_VERSION_hashable
184+#define MIN_VERSION_hashable(major1,major2,minor) (\
185+ (major1) < 1 || \
186+ (major1) == 1 && (major2) < 3 || \
187+ (major1) == 1 && (major2) == 3 && (minor) <= 0)
188+#endif /* MIN_VERSION_hashable */
189+
190+/* package hashable-time-0.2.0.2 */
191+#ifndef VERSION_hashable_time
192+#define VERSION_hashable_time "0.2.0.2"
193+#endif /* VERSION_hashable_time */
194+#ifndef MIN_VERSION_hashable_time
195+#define MIN_VERSION_hashable_time(major1,major2,minor) (\
196+ (major1) < 0 || \
197+ (major1) == 0 && (major2) < 2 || \
198+ (major1) == 0 && (major2) == 2 && (minor) <= 0)
199+#endif /* MIN_VERSION_hashable_time */
200+
201+/* package integer-logarithms-1.0.3 */
202+#ifndef VERSION_integer_logarithms
203+#define VERSION_integer_logarithms "1.0.3"
204+#endif /* VERSION_integer_logarithms */
205+#ifndef MIN_VERSION_integer_logarithms
206+#define MIN_VERSION_integer_logarithms(major1,major2,minor) (\
207+ (major1) < 1 || \
208+ (major1) == 1 && (major2) < 0 || \
209+ (major1) == 1 && (major2) == 0 && (minor) <= 3)
210+#endif /* MIN_VERSION_integer_logarithms */
211+
212+/* package quickcheck-instances-0.3.21 */
213+#ifndef VERSION_quickcheck_instances
214+#define VERSION_quickcheck_instances "0.3.21"
215+#endif /* VERSION_quickcheck_instances */
216+#ifndef MIN_VERSION_quickcheck_instances
217+#define MIN_VERSION_quickcheck_instances(major1,major2,minor) (\
218+ (major1) < 0 || \
219+ (major1) == 0 && (major2) < 3 || \
220+ (major1) == 0 && (major2) == 3 && (minor) <= 21)
221+#endif /* MIN_VERSION_quickcheck_instances */
222+
223+/* package scientific-0.3.6.2 */
224+#ifndef VERSION_scientific
225+#define VERSION_scientific "0.3.6.2"
226+#endif /* VERSION_scientific */
227+#ifndef MIN_VERSION_scientific
228+#define MIN_VERSION_scientific(major1,major2,minor) (\
229+ (major1) < 0 || \
230+ (major1) == 0 && (major2) < 3 || \
231+ (major1) == 0 && (major2) == 3 && (minor) <= 6)
232+#endif /* MIN_VERSION_scientific */
233+
234+/* package tagged-0.8.6 */
235+#ifndef VERSION_tagged
236+#define VERSION_tagged "0.8.6"
237+#endif /* VERSION_tagged */
238+#ifndef MIN_VERSION_tagged
239+#define MIN_VERSION_tagged(major1,major2,minor) (\
240+ (major1) < 0 || \
241+ (major1) == 0 && (major2) < 8 || \
242+ (major1) == 0 && (major2) == 8 && (minor) <= 6)
243+#endif /* MIN_VERSION_tagged */
244+
245+/* package tasty-1.2.3 */
246+#ifndef VERSION_tasty
247+#define VERSION_tasty "1.2.3"
248+#endif /* VERSION_tasty */
249+#ifndef MIN_VERSION_tasty
250+#define MIN_VERSION_tasty(major1,major2,minor) (\
251+ (major1) < 1 || \
252+ (major1) == 1 && (major2) < 2 || \
253+ (major1) == 1 && (major2) == 2 && (minor) <= 3)
254+#endif /* MIN_VERSION_tasty */
255+
256+/* package tasty-golden-2.3.2 */
257+#ifndef VERSION_tasty_golden
258+#define VERSION_tasty_golden "2.3.2"
259+#endif /* VERSION_tasty_golden */
260+#ifndef MIN_VERSION_tasty_golden
261+#define MIN_VERSION_tasty_golden(major1,major2,minor) (\
262+ (major1) < 2 || \
263+ (major1) == 2 && (major2) < 3 || \
264+ (major1) == 2 && (major2) == 3 && (minor) <= 2)
265+#endif /* MIN_VERSION_tasty_golden */
266+
267+/* package tasty-hunit-0.10.0.2 */
268+#ifndef VERSION_tasty_hunit
269+#define VERSION_tasty_hunit "0.10.0.2"
270+#endif /* VERSION_tasty_hunit */
271+#ifndef MIN_VERSION_tasty_hunit
272+#define MIN_VERSION_tasty_hunit(major1,major2,minor) (\
273+ (major1) < 0 || \
274+ (major1) == 0 && (major2) < 10 || \
275+ (major1) == 0 && (major2) == 10 && (minor) <= 0)
276+#endif /* MIN_VERSION_tasty_hunit */
277+
278+/* package tasty-quickcheck-0.10.1 */
279+#ifndef VERSION_tasty_quickcheck
280+#define VERSION_tasty_quickcheck "0.10.1"
281+#endif /* VERSION_tasty_quickcheck */
282+#ifndef MIN_VERSION_tasty_quickcheck
283+#define MIN_VERSION_tasty_quickcheck(major1,major2,minor) (\
284+ (major1) < 0 || \
285+ (major1) == 0 && (major2) < 10 || \
286+ (major1) == 0 && (major2) == 10 && (minor) <= 1)
287+#endif /* MIN_VERSION_tasty_quickcheck */
288+
289+/* package template-haskell-2.14.0.0 */
290+#ifndef VERSION_template_haskell
291+#define VERSION_template_haskell "2.14.0.0"
292+#endif /* VERSION_template_haskell */
293+#ifndef MIN_VERSION_template_haskell
294+#define MIN_VERSION_template_haskell(major1,major2,minor) (\
295+ (major1) < 2 || \
296+ (major1) == 2 && (major2) < 14 || \
297+ (major1) == 2 && (major2) == 14 && (minor) <= 0)
298+#endif /* MIN_VERSION_template_haskell */
299+
300+/* package text-1.2.3.1 */
301+#ifndef VERSION_text
302+#define VERSION_text "1.2.3.1"
303+#endif /* VERSION_text */
304+#ifndef MIN_VERSION_text
305+#define MIN_VERSION_text(major1,major2,minor) (\
306+ (major1) < 1 || \
307+ (major1) == 1 && (major2) < 2 || \
308+ (major1) == 1 && (major2) == 2 && (minor) <= 3)
309+#endif /* MIN_VERSION_text */
310+
311+/* package time-1.8.0.2 */
312+#ifndef VERSION_time
313+#define VERSION_time "1.8.0.2"
314+#endif /* VERSION_time */
315+#ifndef MIN_VERSION_time
316+#define MIN_VERSION_time(major1,major2,minor) (\
317+ (major1) < 1 || \
318+ (major1) == 1 && (major2) < 8 || \
319+ (major1) == 1 && (major2) == 8 && (minor) <= 0)
320+#endif /* MIN_VERSION_time */
321+
322+/* package time-compat-1.9.2.2 */
323+#ifndef VERSION_time_compat
324+#define VERSION_time_compat "1.9.2.2"
325+#endif /* VERSION_time_compat */
326+#ifndef MIN_VERSION_time_compat
327+#define MIN_VERSION_time_compat(major1,major2,minor) (\
328+ (major1) < 1 || \
329+ (major1) == 1 && (major2) < 9 || \
330+ (major1) == 1 && (major2) == 9 && (minor) <= 2)
331+#endif /* MIN_VERSION_time_compat */
332+
333+/* package unordered-containers-0.2.10.0 */
334+#ifndef VERSION_unordered_containers
335+#define VERSION_unordered_containers "0.2.10.0"
336+#endif /* VERSION_unordered_containers */
337+#ifndef MIN_VERSION_unordered_containers
338+#define MIN_VERSION_unordered_containers(major1,major2,minor) (\
339+ (major1) < 0 || \
340+ (major1) == 0 && (major2) < 2 || \
341+ (major1) == 0 && (major2) == 2 && (minor) <= 10)
342+#endif /* MIN_VERSION_unordered_containers */
343+
344+/* package uuid-types-1.0.3 */
345+#ifndef VERSION_uuid_types
346+#define VERSION_uuid_types "1.0.3"
347+#endif /* VERSION_uuid_types */
348+#ifndef MIN_VERSION_uuid_types
349+#define MIN_VERSION_uuid_types(major1,major2,minor) (\
350+ (major1) < 1 || \
351+ (major1) == 1 && (major2) < 0 || \
352+ (major1) == 1 && (major2) == 0 && (minor) <= 3)
353+#endif /* MIN_VERSION_uuid_types */
354+
355+/* package vector-0.12.0.3 */
356+#ifndef VERSION_vector
357+#define VERSION_vector "0.12.0.3"
358+#endif /* VERSION_vector */
359+#ifndef MIN_VERSION_vector
360+#define MIN_VERSION_vector(major1,major2,minor) (\
361+ (major1) < 0 || \
362+ (major1) == 0 && (major2) < 12 || \
363+ (major1) == 0 && (major2) == 12 && (minor) <= 0)
364+#endif /* MIN_VERSION_vector */
365+
366+/* tool gcc-4.2.1 */
367+#ifndef TOOL_VERSION_gcc
368+#define TOOL_VERSION_gcc "4.2.1"
369+#endif /* TOOL_VERSION_gcc */
370+#ifndef MIN_TOOL_VERSION_gcc
371+#define MIN_TOOL_VERSION_gcc(major1,major2,minor) (\
372+ (major1) < 4 || \
373+ (major1) == 4 && (major2) < 2 || \
374+ (major1) == 4 && (major2) == 2 && (minor) <= 1)
375+#endif /* MIN_TOOL_VERSION_gcc */
376+
377+/* tool ghc-8.6.5 */
378+#ifndef TOOL_VERSION_ghc
379+#define TOOL_VERSION_ghc "8.6.5"
380+#endif /* TOOL_VERSION_ghc */
381+#ifndef MIN_TOOL_VERSION_ghc
382+#define MIN_TOOL_VERSION_ghc(major1,major2,minor) (\
383+ (major1) < 8 || \
384+ (major1) == 8 && (major2) < 6 || \
385+ (major1) == 8 && (major2) == 6 && (minor) <= 5)
386+#endif /* MIN_TOOL_VERSION_ghc */
387+
388+/* tool ghc-pkg-8.6.5 */
389+#ifndef TOOL_VERSION_ghc_pkg
390+#define TOOL_VERSION_ghc_pkg "8.6.5"
391+#endif /* TOOL_VERSION_ghc_pkg */
392+#ifndef MIN_TOOL_VERSION_ghc_pkg
393+#define MIN_TOOL_VERSION_ghc_pkg(major1,major2,minor) (\
394+ (major1) < 8 || \
395+ (major1) == 8 && (major2) < 6 || \
396+ (major1) == 8 && (major2) == 6 && (minor) <= 5)
397+#endif /* MIN_TOOL_VERSION_ghc_pkg */
398+
399+/* tool haddock-2.22.0 */
400+#ifndef TOOL_VERSION_haddock
401+#define TOOL_VERSION_haddock "2.22.0"
402+#endif /* TOOL_VERSION_haddock */
403+#ifndef MIN_TOOL_VERSION_haddock
404+#define MIN_TOOL_VERSION_haddock(major1,major2,minor) (\
405+ (major1) < 2 || \
406+ (major1) == 2 && (major2) < 22 || \
407+ (major1) == 2 && (major2) == 22 && (minor) <= 0)
408+#endif /* MIN_TOOL_VERSION_haddock */
409+
410+/* tool hpc-0.67 */
411+#ifndef TOOL_VERSION_hpc
412+#define TOOL_VERSION_hpc "0.67"
413+#endif /* TOOL_VERSION_hpc */
414+#ifndef MIN_TOOL_VERSION_hpc
415+#define MIN_TOOL_VERSION_hpc(major1,major2,minor) (\
416+ (major1) < 0 || \
417+ (major1) == 0 && (major2) < 67 || \
418+ (major1) == 0 && (major2) == 67 && (minor) <= 0)
419+#endif /* MIN_TOOL_VERSION_hpc */
420+
421+/* tool hsc2hs-0.68.5 */
422+#ifndef TOOL_VERSION_hsc2hs
423+#define TOOL_VERSION_hsc2hs "0.68.5"
424+#endif /* TOOL_VERSION_hsc2hs */
425+#ifndef MIN_TOOL_VERSION_hsc2hs
426+#define MIN_TOOL_VERSION_hsc2hs(major1,major2,minor) (\
427+ (major1) < 0 || \
428+ (major1) == 0 && (major2) < 68 || \
429+ (major1) == 0 && (major2) == 68 && (minor) <= 5)
430+#endif /* MIN_TOOL_VERSION_hsc2hs */
431+
432+/* tool runghc-8.6.5 */
433+#ifndef TOOL_VERSION_runghc
434+#define TOOL_VERSION_runghc "8.6.5"
435+#endif /* TOOL_VERSION_runghc */
436+#ifndef MIN_TOOL_VERSION_runghc
437+#define MIN_TOOL_VERSION_runghc(major1,major2,minor) (\
438+ (major1) < 8 || \
439+ (major1) == 8 && (major2) < 6 || \
440+ (major1) == 8 && (major2) == 6 && (minor) <= 5)
441+#endif /* MIN_TOOL_VERSION_runghc */
442+
443+#ifndef CURRENT_COMPONENT_ID
444+#define CURRENT_COMPONENT_ID "aeson-1.4.4.0-inplace-tests"
445+#endif /* CURRENT_COMPONENT_ID */
446+#ifndef CURRENT_PACKAGE_VERSION
447+#define CURRENT_PACKAGE_VERSION "1.4.4.0"
448+#endif /* CURRENT_PACKAGE_VERSION */
travis/install.sh+11
@@ -7,6 +7,11 @@ echo "$(ghc --version) [$(ghc --print-project-git-commit-id 2> /dev/null || echo
77stack --version
88
99case $BUILD in
10+ hlint)
11+ echo "Downloading hlint"
12+ curl -sSL https://raw.github.com/ndmitchell/hlint/master/misc/run.sh > hlint.sh
13+ chmod +x hlint.sh
14+ ;;
1015 stack)
1116 stack --no-terminal --skip-ghc-check setup
1217 stack --no-terminal --skip-ghc-check test --only-snapshot
@@ -44,4 +49,10 @@ case $BUILD in
4449 cp -a $HOME/.cabal/lib $HOME/.cabal/share $HOME/.cabal/bin installplan.txt $HOME/.cabsnap/;
4550 fi
4651 ;;
52+ cabal2)
53+ cabal v2-update -v
54+ sed -i 's/^jobs:/-- jobs:/' ${HOME}/.cabal/config
55+
56+ cabal v2-build --only-dependencies --enable-tests --enable-benchmarks --dry
57+ ;;
4758esac
travis/script.sh+4−2
@@ -19,9 +19,11 @@ case $BUILD in
1919 SRC_TGZ=$(cabal info . | awk '{print $2;exit}').tar.gz &&
2020 (cd dist && cabal install --force-reinstalls "$SRC_TGZ")
2121 ;;
22+ cabal2)
23+ cabal v2-build --enable-tests --enable-benchmarks
24+ cabal v2-test --enable-tests --enable-benchmarks
25+ ;;
2226 hlint)
23− stack build --fast aeson --stack-yaml stack-lts8.yaml --system-ghc --no-terminal
24− stack install hlint --resolver lts-8 --system-ghc --no-terminal
2527 make lint
2628 ;;
2729esac