on 85529fc help sign in
48 files changed+426−1644
since splitsnapshots
unifiedsplit
.gitignore−1 .hlint.yaml−11 .travis.yml+23−34 CONTRIBUTING.md−38 Data/Aeson.hs−9 Data/Aeson/Compat.hs+16 Data/Aeson/Parser.hs+1−11 Data/Aeson/Parser/Internal.hs+40−155 Data/Aeson/TH.hs+40−24 Data/Aeson/Types.hs−19 Data/Aeson/Types/Class.hs+1−5 Data/Aeson/Types/FromJSON.hs+88−204 Data/Aeson/Types/Generic.hs+1 Data/Aeson/Types/Internal.hs+5−105 Data/Aeson/Types/ToJSON.hs+52−98 HLint.hs+12 Makefile+1−1 aeson.cabal+23−20 attoparsec-iso8601/Data/Attoparsec/Time/Internal.hs+20 attoparsec-iso8601/attoparsec-iso8601.cabal+2−2 benchmarks/AesonEncode.hs+1−1 benchmarks/Compare/JsonBench.hs+3−4 benchmarks/CompareWithJSON.hs+1−1 benchmarks/Issue673.hs−1 benchmarks/JsonParse.hs+1−1 benchmarks/aeson-benchmarks.cabal+28−32 cabal.project+1−4 changelog.md+3−69 run-hlint.sh−7 stack-bench.yaml+1−2 stack-ffi-unescape.yaml+2−2 stack-lts12.yaml+1−6 stack-nightly.yaml+1−3 tests/Encoders.hs+6−38 tests/ErrorMessages.hs+1−27 tests/Instances.hs+4−1 tests/Options.hs−11 tests/PropertyGeneric.hs+8 tests/PropertyKeys.hs+3 tests/PropertyRoundTrip.hs−7 tests/SerializationFormatSpec.hs+23−47 tests/Types.hs+2 tests/UnitTests.hs+6−164 tests/UnitTests/NullaryConstructors.hs−5 tests/golden/generic.expected+3−11 travis/cabal_macros.h−448 travis/install.sh−11 travis/script.sh+2−4
.gitignore−1
@@ -5,7 +5,6 @@ dist-newstyle
55cabal.sandbox.config
66.stack-work/
77.stack-work-bench/
8−*.yaml.lock
98
109*.o
1110*.hi
.hlint.yamldeleted−11
@@ -1,11 +0,0 @@
1−# Ignore some builtin hints
2−- ignore:
3− name: "Reduce duplication"
4− within:
5− - Data.Aeson.Types.ToJSON
6−- ignore:
7− name: "Eta reduce"
8−- ignore:
9− name: "Use newtype instead of data"
10− within:
11− - Data.Aeson.Types.Internal
.travis.yml+23−34
@@ -12,58 +12,47 @@ cache:
1212 - $HOME/.stack
1313 - $HOME/.cabsnap
1414 - $HOME/.cabal/packages
15− - $HOME/.cabal/store
1615
1716before_cache:
1817 - rm -fv $HOME/.cabal/packages/hackage.haskell.org/build-reports.log
19− - rm -fv $HOME/.cabal/packages/hackage.haskell.org/00-index.*
20− - rm -fv $HOME/.cabal/packages/hackage.haskell.org/*.json
21− - rm -fv $HOME/.cabal/packages/hackage.haskell.org/01-index.cache
22− - rm -fv $HOME/.cabal/packages/hackage.haskell.org/01-index.tar
23− - rm -fv $HOME/.cabal/packages/hackage.haskell.org/01-index.tar.idx
18+ - rm -fv $HOME/.cabal/packages/hackage.haskell.org/00-index.tar
2419
2520matrix:
2621 include:
27−
28− - env: BUILD=hlint CABALVER=2.2 GHCVER=8.4.4
29− compiler: ": #GHC 8.4.4"
30− addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4], sources: [hvr-ghc]}}
31−
32− - env: BUILD=stack CABALVER=2.4 GHCVER=8.6.5 STACK_YAML=stack-bench.yaml
33− compiler: ": #GHC 8.6.5"
34− addons: {apt: {packages: [cabal-install-2.4,ghc-8.6.5], sources: [hvr-ghc]}}
35−
36− - env: BUILD=stack CABALVER=2.2 GHCVER=8.6.5 STACK_YAML=stack-ffi-unescape.yaml
37− compiler: ": #GHC 8.6.5"
38− addons: {apt: {packages: [cabal-install-2.2,ghc-8.6.5], sources: [hvr-ghc]}}
39−
40− - env: BUILD=cabal2 CABALVER=3.0 GHCVER=8.8.1
41− compiler: ": #GHC 8.8.1"
42− addons: {apt: {packages: [cabal-install-3.0,ghc-8.8.1], sources: [hvr-ghc]}}
43−
44− - env: BUILD=cabal CABALVER=2.4 GHCVER=8.6.5
45− compiler: ": #GHC 8.6.5"
46− addons: {apt: {packages: [cabal-install-2.4,ghc-8.6.5], sources: [hvr-ghc]}}
47−
48− - env: BUILD=cabal CABALVER=2.2 GHCVER=8.4.4
49− compiler: ": #GHC 8.4.4"
50− addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4], sources: [hvr-ghc]}}
51−
22+ - env: BUILD=hlint CABALVER=2.2 GHCVER=8.4.3
23+ compiler: ": #GHC 8.4.3"
24+ addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.3], sources: [hvr-ghc]}}
25+ - env: BUILD=stack CABALVER=2.2 GHCVER=8.4.3 STACK_YAML=stack-bench.yaml
26+ compiler: ": #GHC 8.4.3"
27+ addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.3], sources: [hvr-ghc]}}
28+ - env: BUILD=stack CABALVER=2.2 GHCVER=8.4.3 STACK_YAML=stack-ffi-unescape.yaml
29+ compiler: ": #GHC 8.4.3"
30+ addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.3], sources: [hvr-ghc]}}
31+
32+ - env: BUILD=cabal CABALVER=2.4 GHCVER=8.6.1
33+ compiler: ": #GHC 8.6.1"
34+ addons: {apt: {packages: [cabal-install-2.4,ghc-8.6.1], sources: [hvr-ghc]}}
35+ - env: BUILD=cabal CABALVER=2.2 GHCVER=8.4.3
36+ compiler: ": #GHC 8.4.3"
37+ addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.3], sources: [hvr-ghc]}}
5238 - env: BUILD=cabal CABALVER=2.0 GHCVER=8.2.2
5339 compiler: ": #GHC 8.2.2"
5440 addons: {apt: {packages: [cabal-install-2.0,ghc-8.2.2], sources: [hvr-ghc]}}
55−
5641 - env: BUILD=cabal CABALVER=2.0 GHCVER=8.0.2
5742 compiler: ": #GHC 8.0.2"
5843 addons: {apt: {packages: [cabal-install-2.0,ghc-8.0.2], sources: [hvr-ghc]}}
59−
6044 - env: BUILD=cabal CABALVER=1.22 GHCVER=7.10.3
6145 compiler: ": #GHC 7.10.3"
6246 addons: {apt: {packages: [cabal-install-1.22,ghc-7.10.3], sources: [hvr-ghc]}}
63−
6447 - env: BUILD=cabal CABALVER=1.18 GHCVER=7.8.4
6548 compiler: ": #GHC 7.8.4"
6649 addons: {apt: {packages: [cabal-install-1.18,ghc-7.8.4], sources: [hvr-ghc]}}
50+ - env: BUILD=cabal CABALVER=1.18 GHCVER=7.6.3
51+ compiler: ": #GHC 7.6.3"
52+ addons: {apt: {packages: [cabal-install-1.18,ghc-7.6.3], sources: [hvr-ghc]}}
53+ - env: BUILD=cabal CABALVER=1.18 GHCVER=7.4.2
54+ compiler: ": #GHC 7.4.2"
55+ addons: {apt: {packages: [cabal-install-1.18,ghc-7.4.2], sources: [hvr-ghc]}}
6756
6857before_install:
6958 - unset CC
CONTRIBUTING.md−38
@@ -58,41 +58,3 @@ import Foo as F
5858import Qux (Q(..), q)
5959import qualified A
6060```
61−
62−## Development Workflow (If you plan on using Stack)
63−
64−Here we outline a general workflow new contributors could adopt for a nice incremental development experience.
65−
66−The root folder consists of two stack-*.yaml config files.
67−
68−1. stack-nightly.yaml - Config file defines all the settings to build and test any changes.
69−2. stack-bench.yaml - Used to run benchmark tests.
70−3. stack-ffi-unescape.yaml - This is for replacing certain parts with a C-implementation.
71−
72−Therefore, a ghci development experience would be:
73−
74−1. `stack ghci --stack-yaml stack-nightly.yaml --test`
75−2. :r to recompile
76−3. `main` to run all tests, or `:main --pattern Foo` to run specific tests matched by pattern.
77−
78−Some discussion on this topic can also be found here [here](https://github.com/bos/aeson/issues/733)
79−
80−Of course before submitting a PR, the following steps are recommended:
81−
82−1. 'stack test --stack-yaml stack-nightly.yaml` - Run the entire suite of tests
83−2. `make hlint` - Run hlint on the source folders.
84−3. 'stack test --stack-yaml stack-bench.yaml` - Run the benchmark tests if you believe your changes could affect the benchmarks.
85−
86−## Development Workflow (If you plan on using Cabal)
87−
88−A ghci development experience would be:
89−
90−1. `cabal new-repl test:tests`
91−2. `:r` to recompile
92−3. `Main.main` to run all tests, or `:m Main; :main --pattern Foo` to run specific tests matched by pattern.
93−
94−Of course before submitting a PR, the following steps are recommended:
95−
96−1. `cabal new-test` - Run the entire suite of tests
97−2. `make hlint` - Run hlint on the source folders.
98−3. Uncomment the `benchmarks` line in `cabal.project` - Run the benchmark tests if you believe your changes could affect the benchmarks.
Data/Aeson.hs−9
@@ -70,11 +70,6 @@ module Data.Aeson
7070 , ToJSONKeyFunction(..)
7171 , FromJSONKey(..)
7272 , FromJSONKeyFunction(..)
73− -- *** Generic keys
74− , GToJSONKey()
75− , genericToJSONKey
76− , GFromJSONKey()
77− , genericFromJSONKey
7873 -- ** Liftings to unary and binary type constructors
7974 , FromJSON1(..)
8075 , parseJSON1
@@ -116,10 +111,6 @@ module Data.Aeson
116111 , SumEncoding(..)
117112 , camelTo2
118113 , defaultTaggedObject
119− -- ** Options for object keys
120− , JSONKeyOptions
121− , keyModifier
122− , defaultJSONKeyOptions
123114
124115 -- * Inspecting @'Value's@
125116 , withObject
Data/Aeson/Compat.hsnew file+16
@@ -0,0 +1,16 @@
1+{-# LANGUAGE CPP #-}
2+
3+module Data.Aeson.Compat
4+ (
5+ fromStrict
6+ ) where
7+
8+import qualified Data.ByteString as S
9+import qualified Data.ByteString.Lazy as L
10+
11+fromStrict :: S.ByteString -> L.ByteString
12+#if MIN_VERSION_bytestring(0, 9, 2)
13+fromStrict = L.fromChunks . (:[])
14+#else
15+fromStrict = L.fromStrict
16+#endif
Data/Aeson/Parser.hs+1−11
@@ -35,20 +35,10 @@ module Data.Aeson.Parser
3535 , value
3636 , jstring
3737 , scientific
38− -- ** Handling objects with duplicate keys
39− , jsonWith
40− , jsonLast
41− , jsonAccum
42− , jsonNoDup
4338 -- * Strict parsers
4439 -- $strict
4540 , json'
4641 , value'
47− -- ** Handling objects with duplicate keys
48− , jsonWith'
49− , jsonLast'
50− , jsonAccum'
51− , jsonNoDup'
5242 -- * Decoding without FromJSON instances
5343 , decodeWith
5444 , decodeStrictWith
@@ -57,7 +47,7 @@ module Data.Aeson.Parser
5747 ) where
5848
5949
60−import Data.Aeson.Parser.Internal
50+import Data.Aeson.Parser.Internal (decodeStrictWith, decodeWith, eitherDecodeStrictWith, eitherDecodeWith, json, json', jstring, scientific, value, value')
6151
6252-- $lazy
6353--
Data/Aeson/Parser/Internal.hs+40−155
@@ -5,10 +5,6 @@
55#if MIN_VERSION_ghc_prim(0,3,1)
66{-# LANGUAGE MagicHash #-}
77#endif
8−#if __GLASGOW_HASKELL__ <= 710 && __GLASGOW_HASKELL__ >= 706
9−-- Work around a compiler bug
10−{-# OPTIONS_GHC -fsimpl-tick-factor=200 #-}
11−#endif
128-- |
139-- Module: Data.Aeson.Parser.Internal
1410-- Copyright: (c) 2011-2016 Bryan O'Sullivan
@@ -25,43 +21,29 @@ module Data.Aeson.Parser.Internal
2521 (
2622 -- * Lazy parsers
2723 json, jsonEOF
28− , jsonWith
29− , jsonLast
30− , jsonAccum
31− , jsonNoDup
3224 , value
3325 , jstring
3426 , jstring_
3527 , scientific
3628 -- * Strict parsers
3729 , json', jsonEOF'
38− , jsonWith'
39− , jsonLast'
40− , jsonAccum'
41− , jsonNoDup'
4230 , value'
4331 -- * Helpers
4432 , decodeWith
4533 , decodeStrictWith
4634 , eitherDecodeWith
4735 , eitherDecodeStrictWith
48− -- ** Handling objects with duplicate keys
49− , fromListAccum
50− , parseListNoDup
5136 ) where
5237
5338import Prelude.Compat
5439
5540import Control.Applicative ((<|>))
5641import Control.Monad (void, when)
57−import Data.Aeson.Types.Internal (IResult(..), JSONPath, Object, Result(..), Value(..))
42+import Data.Aeson.Types.Internal (IResult(..), JSONPath, Result(..), Value(..))
5843import Data.Attoparsec.ByteString.Char8 (Parser, char, decimal, endOfInput, isDigit_w8, signed, string)
59−import Data.Function (fix)
60−import Data.Functor.Compat (($>))
6144import Data.Scientific (Scientific)
6245import Data.Text (Text)
63−import Data.Vector (Vector)
64−import qualified Data.Vector as Vector (empty, fromList, fromListN, reverse)
46+import Data.Vector as Vector (Vector, empty, fromListN, reverse)
6547import qualified Data.Attoparsec.ByteString as A
6648import qualified Data.Attoparsec.Lazy as L
6749import qualified Data.ByteString as B
@@ -93,7 +75,7 @@ import qualified Data.Text.Encoding as TE
9375#define C_n 110
9476#define C_t 116
9577
96−-- | Parse any JSON value.
78+-- | Parse a top-level JSON value.
9779--
9880-- The conversion of a parsed value to a Haskell value is deferred
9981-- until the Haskell value is needed. This may improve performance if
@@ -103,15 +85,10 @@ import qualified Data.Text.Encoding as TE
10385-- This function is an alias for 'value'. In aeson 0.8 and earlier, it
10486-- parsed only object or array types, in conformance with the
10587-- now-obsolete RFC 4627.
106−--
107−-- ==== Warning
108−--
109−-- If an object contains duplicate keys, only the first one will be kept.
110−-- For a more flexible alternative, see 'jsonWith'.
11188json :: Parser Value
11289json = value
11390
114−-- | Parse any JSON value.
91+-- | Parse a top-level JSON value.
11592--
11693-- This is a strict version of 'json' which avoids building up thunks
11794-- during parsing; it performs all conversions immediately. Prefer
@@ -120,35 +97,23 @@ json = value
12097-- This function is an alias for 'value''. In aeson 0.8 and earlier, it
12198-- parsed only object or array types, in conformance with the
12299-- now-obsolete RFC 4627.
123−--
124−-- ==== Warning
125−--
126−-- If an object contains duplicate keys, only the first one will be kept.
127−-- For a more flexible alternative, see 'jsonWith''.
128100json' :: Parser Value
129101json' = value'
130102
131−-- Open recursion: object_, object_', array_, array_' are parameterized by the
132−-- toplevel Value parser to be called recursively, to keep the parameter
133−-- mkObject outside of the recursive loop for proper inlining.
134−
135−object_ :: ([(Text, Value)] -> Either String Object) -> Parser Value -> Parser Value
136−object_ mkObject val = {-# SCC "object_" #-} Object <$> objectValues mkObject jstring val
137−{-# INLINE object_ #-}
103+object_ :: Parser Value
104+object_ = {-# SCC "object_" #-} Object <$> objectValues jstring value
138105
139−object_' :: ([(Text, Value)] -> Either String Object) -> Parser Value -> Parser Value
140−object_' mkObject val' = {-# SCC "object_'" #-} do
141− !vals <- objectValues mkObject jstring' val'
106+object_' :: Parser Value
107+object_' = {-# SCC "object_'" #-} do
108+ !vals <- objectValues jstring' value'
142109 return (Object vals)
143110 where
144111 jstring' = do
145112 !s <- jstring
146113 return s
147−{-# INLINE object_' #-}
148114
149−objectValues :: ([(Text, Value)] -> Either String Object)
150− -> Parser Text -> Parser Value -> Parser (H.HashMap Text Value)
151−objectValues mkObject str val = do
115+objectValues :: Parser Text -> Parser Value -> Parser (H.HashMap Text Value)
116+objectValues str val = do
152117 skipSpace
153118 w <- A.peekWord8'
154119 if w == CLOSE_CURLY
@@ -164,20 +129,16 @@ objectValues mkObject str val = do
164129 let acc' = (k, v) : acc
165130 if ch == COMMA
166131 then skipSpace >> loop acc'
167− else case mkObject acc' of
168− Left err -> fail err
169− Right obj -> pure obj
132+ else return (H.fromList acc')
170133{-# INLINE objectValues #-}
171134
172−array_ :: Parser Value -> Parser Value
173−array_ val = {-# SCC "array_" #-} Array <$> arrayValues val
174−{-# INLINE array_ #-}
135+array_ :: Parser Value
136+array_ = {-# SCC "array_" #-} Array <$> arrayValues value
175137
176−array_' :: Parser Value -> Parser Value
177−array_' val = {-# SCC "array_'" #-} do
178− !vals <- arrayValues val
138+array_' :: Parser Value
139+array_' = {-# SCC "array_'" #-} do
140+ !vals <- arrayValues value'
179141 return (Array vals)
180−{-# INLINE array_' #-}
181142
182143arrayValues :: Parser Value -> Parser (Vector Value)
183144arrayValues val = do
@@ -195,126 +156,50 @@ arrayValues val = do
195156 else return (Vector.reverse (Vector.fromListN len (v:acc)))
196157{-# INLINE arrayValues #-}
197158
198−-- | Parse any JSON value. Synonym of 'json'.
199−value :: Parser Value
200−value = jsonWith (pure . H.fromList)
201−
202−-- | Parse any JSON value.
203−--
204−-- This parser is parameterized by a function to construct an 'Object'
205−-- from a raw list of key-value pairs, where duplicates are preserved.
206−-- The pairs appear in __reverse order__ from the source.
207−--
208−-- ==== __Examples__
209−--
210−-- 'json' keeps only the first occurence of each key, using 'HashMap.Lazy.fromList'.
211−--
212−-- @
213−-- 'json' = 'jsonWith' ('Right' '.' 'H.fromList')
214−-- @
215−--
216−-- 'jsonLast' keeps the last occurence of each key, using
217−-- @'HashMap.Lazy.fromListWith' ('const' 'id')@.
218−--
219−-- @
220−-- 'jsonLast' = 'jsonWith' ('Right' '.' 'HashMap.Lazy.fromListWith' ('const' 'id'))
221−-- @
159+-- | Parse any JSON value. You should usually 'json' in preference to
160+-- this function, as this function relaxes the object-or-array
161+-- requirement of RFC 4627.
222162--
223−-- 'jsonAccum' keeps wraps all values in arrays to keep duplicates, using
224−-- 'fromListAccum'.
225−--
226−-- @
227−-- 'jsonAccum' = 'jsonWith' ('Right' . 'fromListAccum')
228−-- @
229−--
230−-- 'jsonNoDup' fails if any object contains duplicate keys, using 'parseListNoDup'.
231−--
232−-- @
233−-- 'jsonNoDup' = 'jsonWith' 'parseListNoDup'
234−-- @
235−jsonWith :: ([(Text, Value)] -> Either String Object) -> Parser Value
236−jsonWith mkObject = fix $ \value_ -> do
163+-- In particular, be careful in using this function if you think your
164+-- code might interoperate with Javascript. A na&#xef;ve Javascript
165+-- library that parses JSON data using @eval@ is vulnerable to attack
166+-- unless the encoded data represents an object or an array. JSON
167+-- implementations in other languages conform to that same restriction
168+-- to preserve interoperability and security.
169+value :: Parser Value
170+value = do
237171 skipSpace
238172 w <- A.peekWord8'
239173 case w of
240174 DOUBLE_QUOTE -> A.anyWord8 *> (String <$> jstring_)
241− OPEN_CURLY -> A.anyWord8 *> object_ mkObject value_
242− OPEN_SQUARE -> A.anyWord8 *> array_ value_
243− C_f -> string "false" $> Bool False
244− C_t -> string "true" $> Bool True
245− C_n -> string "null" $> Null
175+ OPEN_CURLY -> A.anyWord8 *> object_
176+ OPEN_SQUARE -> A.anyWord8 *> array_
177+ C_f -> string "false" *> pure (Bool False)
178+ C_t -> string "true" *> pure (Bool True)
179+ C_n -> string "null" *> pure Null
246180 _ | w >= 48 && w <= 57 || w == 45
247181 -> Number <$> scientific
248182 | otherwise -> fail "not a valid json value"
249−{-# INLINE jsonWith #-}
250−
251−-- | Variant of 'json' which keeps only the last occurence of every key.
252−jsonLast :: Parser Value
253−jsonLast = jsonWith (Right . H.fromListWith (const id))
254−
255−-- | Variant of 'json' wrapping all object mappings in 'Array' to preserve
256−-- key-value pairs with the same keys.
257−jsonAccum :: Parser Value
258−jsonAccum = jsonWith (Right . fromListAccum)
259−
260−-- | Variant of 'json' which fails if any object contains duplicate keys.
261−jsonNoDup :: Parser Value
262−jsonNoDup = jsonWith parseListNoDup
263183
264−-- | @'fromListAccum' kvs@ is an object mapping keys to arrays containing all
265−-- associated values from the original list @kvs@.
266−--
267−-- >>> fromListAccum [("apple", Bool True), ("apple", Bool False), ("orange", Bool False)]
268−-- fromList [("apple", [Bool False, Bool True]), ("orange", [Bool False])]
269−fromListAccum :: [(Text, Value)] -> Object
270−fromListAccum =
271− fmap (Array . Vector.fromList . ($ [])) . H.fromListWith (.) . (fmap . fmap) (:)
272−
273−-- | @'fromListNoDup' kvs@ fails if @kvs@ contains duplicate keys.
274−parseListNoDup :: [(Text, Value)] -> Either String Object
275−parseListNoDup =
276− H.traverseWithKey unwrap . H.fromListWith (\_ _ -> Nothing) . (fmap . fmap) Just
277− where
278− unwrap k Nothing = Left $ "found duplicate key: " ++ show k
279− unwrap _ (Just v) = Right v
280−
281−-- | Strict version of 'value'. Synonym of 'json''.
184+-- | Strict version of 'value'. See also 'json''.
282185value' :: Parser Value
283−value' = jsonWith' (pure . H.fromList)
284−
285−-- | Strict version of 'jsonWith'.
286−jsonWith' :: ([(Text, Value)] -> Either String Object) -> Parser Value
287−jsonWith' mkObject = fix $ \value_ -> do
186+value' = do
288187 skipSpace
289188 w <- A.peekWord8'
290189 case w of
291190 DOUBLE_QUOTE -> do
292191 !s <- A.anyWord8 *> jstring_
293192 return (String s)
294− OPEN_CURLY -> A.anyWord8 *> object_' mkObject value_
295− OPEN_SQUARE -> A.anyWord8 *> array_' value_
296− C_f -> string "false" $> Bool False
297− C_t -> string "true" $> Bool True
298− C_n -> string "null" $> Null
193+ OPEN_CURLY -> A.anyWord8 *> object_'
194+ OPEN_SQUARE -> A.anyWord8 *> array_'
195+ C_f -> string "false" *> pure (Bool False)
196+ C_t -> string "true" *> pure (Bool True)
197+ C_n -> string "null" *> pure Null
299198 _ | w >= 48 && w <= 57 || w == 45
300199 -> do
301200 !n <- scientific
302201 return (Number n)
303202 | otherwise -> fail "not a valid json value"
304−{-# INLINE jsonWith' #-}
305−
306−-- | Variant of 'json'' which keeps only the last occurence of every key.
307−jsonLast' :: Parser Value
308−jsonLast' = jsonWith' (pure . H.fromListWith (const id))
309−
310−-- | Variant of 'json'' wrapping all object mappings in 'Array' to preserve
311−-- key-value pairs with the same keys.
312−jsonAccum' :: Parser Value
313−jsonAccum' = jsonWith' (pure . fromListAccum)
314−
315−-- | Variant of 'json'' which fails if any object contains duplicate keys.
316−jsonNoDup' :: Parser Value
317−jsonNoDup' = jsonWith' parseListNoDup
318203
319204-- | Parse a quoted JSON string.
320205jstring :: Parser Text
Data/Aeson/TH.hs+40−24
@@ -135,15 +135,22 @@ import Data.Map (Map)
135135import Data.Maybe (catMaybes, fromMaybe, mapMaybe)
136136import qualified Data.Monoid as Monoid
137137import Data.Set (Set)
138+#if MIN_VERSION_template_haskell(2,8,0)
138139import Language.Haskell.TH hiding (Arity)
140+#else
141+import Language.Haskell.TH
142+#endif
139143import Language.Haskell.TH.Datatype
144+#if MIN_VERSION_template_haskell(2,7,0) && !(MIN_VERSION_template_haskell(2,8,0))
145+import Language.Haskell.TH.Lib (starK)
146+#endif
140147#if MIN_VERSION_template_haskell(2,8,0) && !(MIN_VERSION_template_haskell(2,10,0))
141148import Language.Haskell.TH.Syntax (mkNameG_tc)
142149#endif
143150import Text.Printf (printf)
144151import qualified Data.Aeson.Encoding.Internal as E
145152import qualified Data.Foldable as F (all)
146−import qualified Data.HashMap.Strict as H (difference, fromList, keys, lookup, toList)
153+import qualified Data.HashMap.Strict as H (lookup, toList)
147154import qualified Data.List.NonEmpty as NE (length, reverse)
148155import qualified Data.Map as M (fromList, keys, lookup , singleton, size)
149156import qualified Data.Semigroup as Semigroup (Option(..))
@@ -152,6 +159,8 @@ import qualified Data.Text as T (Text, pack, unpack)
152159import qualified Data.Vector as V (unsafeIndex, null, length, create, empty)
153160import qualified Data.Vector.Mutable as VM (unsafeNew, unsafeWrite)
154161
162+{-# ANN module "Hlint: ignore Reduce duplication" #-}
163+
155164--------------------------------------------------------------------------------
156165-- Convenience
157166--------------------------------------------------------------------------------
@@ -922,32 +931,12 @@ parseRecord :: JSONClass
922931 -> Name
923932 -> [Name]
924933 -> Name
925− -> Bool
926934 -> ExpQ
927−parseRecord jc tvMap argTys opts tName conName fields obj inTaggedObject =
928− (if rejectUnknownFields opts
929− then infixApp checkUnknownRecords [|(>>)|]
930− else id) $
935+parseRecord jc tvMap argTys opts tName conName fields obj =
931936 foldl' (\a b -> infixApp a [|(<*>)|] b)
932937 (infixApp (conE conName) [|(<$>)|] x)
933938 xs
934939 where
935− tagFieldNameAppender =
936− if inTaggedObject then (tagFieldName (sumEncoding opts) :) else id
937− knownFields = appE [|H.fromList|] $ listE $
938− map (\knownName -> tupE [appE [|T.pack|] $ litE $ stringL knownName, [|()|]]) $
939− tagFieldNameAppender $ map nameBase fields
940− checkUnknownRecords =
941− caseE (appE [|H.keys|] $ infixApp (varE obj) [|H.difference|] knownFields)
942− [ match (listP []) (normalB [|return ()|]) []
943− , newName "unknownFields" >>=
944− \unknownFields -> match (varP unknownFields)
945− (normalB $ appE [|fail|] $ infixApp
946− (litE (stringL "Unknown fields: "))
947− [|(++)|]
948− (appE [|show|] (varE unknownFields)))
949− []
950− ]
951940 x:xs = [ [|lookupField|]
952941 `appE` dispatchParseJSON jc conName tvMap argTy
953942 `appE` litE (stringL $ show tName)
@@ -1022,7 +1011,7 @@ parseArgs jc tvMap tName opts
10221011 , constructorFields = argTys }
10231012 (Left (_, obj)) = do
10241013 argTys' <- mapM resolveTypeSynonyms argTys
1025− parseRecord jc tvMap argTys' opts tName conName fields obj True
1014+ parseRecord jc tvMap argTys' opts tName conName fields obj
10261015parseArgs jc tvMap tName opts
10271016 info@ConstructorInfo { constructorName = conName
10281017 , constructorVariant = RecordConstructor fields
@@ -1037,7 +1026,7 @@ parseArgs jc tvMap tName opts
10371026 argTys' <- mapM resolveTypeSynonyms argTys
10381027 caseE (varE valName)
10391028 [ match (conP 'Object [varP obj]) (normalB $
1040− parseRecord jc tvMap argTys' opts tName conName fields obj False) []
1029+ parseRecord jc tvMap argTys' opts tName conName fields obj) []
10411030 , matchFailed tName conName "Object"
10421031 ]
10431032
@@ -1603,13 +1592,21 @@ type TyVarMap = Map Name (Name, Name)
16031592-- | Returns True if a Type has kind *.
16041593hasKindStar :: Type -> Bool
16051594hasKindStar VarT{} = True
1595+#if MIN_VERSION_template_haskell(2,8,0)
16061596hasKindStar (SigT _ StarT) = True
1597+#else
1598+hasKindStar (SigT _ StarK) = True
1599+#endif
16071600hasKindStar _ = False
16081601
16091602-- Returns True is a kind is equal to *, or if it is a kind variable.
16101603isStarOrVar :: Kind -> Bool
1604+#if MIN_VERSION_template_haskell(2,8,0)
16111605isStarOrVar StarT = True
16121606isStarOrVar VarT{} = True
1607+#else
1608+isStarOrVar StarK = True
1609+#endif
16131610isStarOrVar _ = False
16141611
16151612-- Generate a list of fresh names with a common prefix, and numbered suffixes.
@@ -1667,7 +1664,9 @@ isTyFamily (ConT n) = do
16671664#else
16681665 FamilyI (FamilyD TypeFam _ _ _) _ -> True
16691666#endif
1667+#if MIN_VERSION_template_haskell(2,9,0)
16701668 FamilyI ClosedTypeFamilyD{} _ -> True
1669+#endif
16711670 _ -> False
16721671isTyFamily _ = return False
16731672
@@ -1695,7 +1694,9 @@ mentionsName = go
16951694 go :: Type -> [Name] -> Bool
16961695 go (AppT t1 t2) names = go t1 names || go t2 names
16971696 go (SigT t _k) names = go t names
1697+#if MIN_VERSION_template_haskell(2,8,0)
16981698 || go _k names
1699+#endif
16991700 go (VarT n) names = n `elem` names
17001701 go _ _ = False
17011702
@@ -1751,14 +1752,23 @@ uncurryTy t = ([], t :| [])
17511752
17521753-- | Like uncurryType, except on a kind level.
17531754uncurryKind :: Kind -> NonEmpty Kind
1755+#if MIN_VERSION_template_haskell(2,8,0)
17541756uncurryKind = snd . uncurryTy
1757+#else
1758+uncurryKind (ArrowK k1 k2) = k1 <| uncurryKind k2
1759+uncurryKind k = k :| []
1760+#endif
17551761
17561762createKindChain :: Int -> Kind
17571763createKindChain = go starK
17581764 where
17591765 go :: Kind -> Int -> Kind
17601766 go k 0 = k
1767+#if MIN_VERSION_template_haskell(2,8,0)
17611768 go k !n = go (AppT (AppT ArrowT StarT) k) (n - 1)
1769+#else
1770+ go k !n = go (ArrowK StarK k) (n - 1)
1771+#endif
17621772
17631773-- | Makes a string literal expression from a constructor's name.
17641774conNameExp :: Options -> ConstructorInfo -> Q Exp
@@ -1812,7 +1822,11 @@ canEtaReduce remaining dropped =
18121822-------------------------------------------------------------------------------
18131823
18141824applySubstitutionKind :: Map Name Kind -> Type -> Type
1825+#if MIN_VERSION_template_haskell(2,8,0)
18151826applySubstitutionKind = applySubstitution
1827+#else
1828+applySubstitutionKind _ t = t
1829+#endif
18161830
18171831substNameWithKind :: Name -> Kind -> Type -> Type
18181832substNameWithKind n k = applySubstitutionKind (M.singleton n k)
@@ -1976,7 +1990,9 @@ data StarKindStatus = NotKindStar
19761990canRealizeKindStar :: Type -> StarKindStatus
19771991canRealizeKindStar t = case t of
19781992 _ | hasKindStar t -> KindStar
1993+#if MIN_VERSION_template_haskell(2,8,0)
19791994 SigT _ (VarT k) -> IsKindVar k
1995+#endif
19801996 _ -> NotKindStar
19811997
19821998-- | Returns 'Just' the kind variable 'Name' of a 'StarKindStatus' if it exists.
Data/Aeson/Types.hs−19
@@ -53,12 +53,6 @@ module Data.Aeson.Types
5353 , coerceFromJSONKeyFunction
5454 , mapFromJSONKeyFunction
5555
56− -- *** Generic keys
57− , GToJSONKey()
58− , genericToJSONKey
59− , GFromJSONKey()
60− , genericFromJSONKey
61−
6256 -- ** Liftings to unary and binary type constructors
6357 , FromJSON1(..)
6458 , parseJSON1
@@ -124,7 +118,6 @@ module Data.Aeson.Types
124118 , sumEncoding
125119 , unwrapUnaryRecords
126120 , tagSingleConstructors
127− , rejectUnknownFields
128121
129122 -- ** Options utilities
130123 , SumEncoding(..)
@@ -132,18 +125,6 @@ module Data.Aeson.Types
132125 , camelTo2
133126 , defaultOptions
134127 , defaultTaggedObject
135−
136− -- ** Options for object keys
137− , JSONKeyOptions
138− , keyModifier
139− , defaultJSONKeyOptions
140−
141− -- * Parsing context
142− , (<?>)
143− , JSONPath
144− , JSONPathElement(..)
145− , formatPath
146− , formatRelativePath
147128 ) where
148129
149130import Prelude.Compat
Data/Aeson/Types/Class.hs+1−5
@@ -6,6 +6,7 @@
66{-# LANGUAGE MultiParamTypeClasses #-}
77{-# LANGUAGE NoImplicitPrelude #-}
88{-# LANGUAGE ScopedTypeVariables #-}
9+{-# LANGUAGE TypeSynonymInstances #-}
910
1011-- |
1112-- Module: Data.Aeson.Types.Class
@@ -58,11 +59,6 @@ module Data.Aeson.Types.Class
5859 , fromJSONKeyCoerce
5960 , coerceFromJSONKeyFunction
6061 , mapFromJSONKeyFunction
61− -- ** Generic keys
62− , GToJSONKey()
63− , genericToJSONKey
64− , GFromJSONKey()
65− , genericFromJSONKey
6662 -- * Object key-value pairs
6763 , KeyValue(..)
6864
Data/Aeson/Types/FromJSON.hs+88−204
@@ -5,16 +5,20 @@
55{-# LANGUAGE FlexibleInstances #-}
66{-# LANGUAGE GADTs #-}
77{-# LANGUAGE MultiParamTypeClasses #-}
8+{-# LANGUAGE NamedFieldPuns #-}
89{-# LANGUAGE NoImplicitPrelude #-}
910{-# LANGUAGE OverloadedStrings #-}
10−{-# LANGUAGE PolyKinds #-}
1111{-# LANGUAGE RecordWildCards #-}
1212{-# LANGUAGE ScopedTypeVariables #-}
1313{-# LANGUAGE TypeOperators #-}
14−{-# LANGUAGE TupleSections #-}
14+{-# LANGUAGE TypeSynonymInstances #-}
1515{-# LANGUAGE UndecidableInstances #-}
1616{-# LANGUAGE ViewPatterns #-}
1717
18+#if __GLASGOW_HASKELL__ >= 706
19+{-# LANGUAGE PolyKinds #-}
20+#endif
21+
1822#include "incoherent-compat.h"
1923#include "overlapping-compat.h"
2024
@@ -42,9 +46,6 @@ module Data.Aeson.Types.FromJSON
4246 , coerceFromJSONKeyFunction
4347 , mapFromJSONKeyFunction
4448
45− , GFromJSONKey()
46− , genericFromJSONKey
47−
4849 -- * List functions
4950 , listParser
5051
@@ -87,7 +88,7 @@ import Data.Aeson.Parser.Internal (eitherDecodeWith, jsonEOF)
8788import Data.Aeson.Types.Generic
8889import Data.Aeson.Types.Internal
8990import Data.Bits (unsafeShiftR)
90−import Data.Fixed (Fixed, HasResolution (resolution), Nano)
91+import Data.Fixed (Fixed, HasResolution)
9192import Data.Functor.Compose (Compose(..))
9293import Data.Functor.Identity (Identity(..))
9394import Data.Functor.Product (Product(..))
@@ -103,10 +104,8 @@ import Data.Scientific (Scientific, base10Exponent)
103104import Data.Tagged (Tagged(..))
104105import Data.Text (Text, pack, unpack)
105106import Data.Time (Day, DiffTime, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
106−import Data.Time.Calendar.Compat (CalendarDiffDays (..), DayOfWeek (..))
107−import Data.Time.LocalTime.Compat (CalendarDiffTime (..))
108−import Data.Time.Clock.System.Compat (SystemTime (..))
109−import Data.Time.Format.Compat (parseTimeM, defaultTimeLocale)
107+import Data.Time.Format (parseTime)
108+import Data.Time.Locale.Compat (defaultTimeLocale)
110109import Data.Traversable as Tr (sequence)
111110import Data.Vector (Vector)
112111import Data.Version (Version, parseVersion)
@@ -118,9 +117,9 @@ import GHC.Generics
118117import Numeric.Natural (Natural)
119118import Text.ParserCombinators.ReadP (readP_to_S)
120119import Unsafe.Coerce (unsafeCoerce)
120+import qualified Data.Aeson.Compat as Compat
121121import qualified Data.Aeson.Parser.Time as Time
122122import qualified Data.Attoparsec.ByteString.Char8 as A (endOfInput, parseOnly, scientific)
123−import qualified Data.ByteString.Lazy as L
124123import qualified Data.DList as DList
125124import qualified Data.HashMap.Strict as H
126125import qualified Data.HashSet as HashSet
@@ -149,14 +148,22 @@ import qualified Data.Primitive.SmallArray as PM
149148import qualified Data.Primitive.Types as PM
150149
151150#if MIN_VERSION_primitive(0,6,4)
152−#if !MIN_VERSION_primitive(0,7,0)
153151import qualified Data.Primitive.UnliftedArray as PM
154−#endif
155152import qualified Data.Primitive.PrimArray as PM
156153#endif
157154
155+#ifndef HAS_COERCIBLE
156+#define HAS_COERCIBLE (__GLASGOW_HASKELL__ >= 707)
157+#endif
158158
159+#if HAS_COERCIBLE
159160import Data.Coerce (Coercible, coerce)
161+coerce' :: Coercible a b => a -> b
162+coerce' = coerce
163+#else
164+coerce' :: a -> b
165+coerce' = unsafeCoerce
166+#endif
160167
161168parseIndexedJSON :: (Value -> Parser a) -> Int -> Value -> Parser a
162169parseIndexedJSON p idx value = p value <?> Index idx
@@ -396,16 +403,6 @@ class FromJSON a where
396403-- > newtype SomeId = SomeId { getSomeId :: Text }
397404-- > deriving (Eq,Ord,Hashable,FromJSONKey)
398405--
399−-- If you have a sum of nullary constructors, you may use the generic
400−-- implementation:
401−--
402−-- @
403−-- data Color = Red | Green | Blue
404−-- deriving Generic
405−--
406−-- instance 'FromJSONKey' Color where
407−-- 'fromJSONKey' = 'genericFromJSONKey' 'defaultJSONKeyOptions'
408−-- @
409406class FromJSONKey a where
410407 -- | Strategy for parsing the key of a map-like container.
411408 fromJSONKey :: FromJSONKeyFunction a
@@ -428,7 +425,11 @@ class FromJSONKey a where
428425-- At the moment this type is intentionally not exported. 'FromJSONKeyFunction'
429426-- can be inspected, but cannot be constructed.
430427data CoerceText a where
428+#if HAS_COERCIBLE
431429 CoerceText :: Coercible Text a => CoerceText a
430+#else
431+ CoerceText :: CoerceText a
432+#endif
432433
433434-- | This type is related to 'ToJSONKeyFunction'. If 'FromJSONKeyValue' is used in the
434435-- 'FromJSONKey' instance, then 'ToJSONKeyValue' should be used in the 'ToJSONKey'
@@ -448,7 +449,7 @@ data FromJSONKeyFunction a
448449
449450-- | Only law abiding up to interpretation
450451instance Functor FromJSONKeyFunction where
451− fmap h (FromJSONKeyCoerce CoerceText) = FromJSONKeyText (h . coerce)
452+ fmap h (FromJSONKeyCoerce CoerceText) = FromJSONKeyText (h . coerce')
452453 fmap h (FromJSONKeyText f) = FromJSONKeyText (h . f)
453454 fmap h (FromJSONKeyTextParser f) = FromJSONKeyTextParser (fmap h . f)
454455 fmap h (FromJSONKeyValue f) = FromJSONKeyValue (fmap h . f)
@@ -462,7 +463,9 @@ instance Functor FromJSONKeyFunction where
462463--
463464-- On pre GHC 7.8 this is unconstrainted function.
464465fromJSONKeyCoerce ::
466+#if HAS_COERCIBLE
465467 Coercible Text a =>
468+#endif
466469 FromJSONKeyFunction a
467470fromJSONKeyCoerce = FromJSONKeyCoerce CoerceText
468471
@@ -470,52 +473,34 @@ fromJSONKeyCoerce = FromJSONKeyCoerce CoerceText
470473--
471474-- See note on 'fromJSONKeyCoerce'.
472475coerceFromJSONKeyFunction ::
476+#if HAS_COERCIBLE
473477 Coercible a b =>
478+#endif
474479 FromJSONKeyFunction a -> FromJSONKeyFunction b
480+#if HAS_COERCIBLE
475481coerceFromJSONKeyFunction = coerce
482+#else
483+coerceFromJSONKeyFunction (FromJSONKeyCoerce CoerceText) = FromJSONKeyCoerce CoerceText
484+coerceFromJSONKeyFunction (FromJSONKeyText f) = FromJSONKeyText (coerce' . f)
485+coerceFromJSONKeyFunction (FromJSONKeyTextParser f) = FromJSONKeyTextParser (fmap coerce' . f)
486+coerceFromJSONKeyFunction (FromJSONKeyValue f) = FromJSONKeyValue (fmap coerce' . f)
487+#endif
476488
477489{-# RULES
478490 "FromJSONKeyCoerce: fmap id" forall (x :: FromJSONKeyFunction a).
479491 fmap id x = x
480492 #-}
493+#if HAS_COERCIBLE
481494{-# RULES
482495 "FromJSONKeyCoerce: fmap coerce" forall x .
483496 fmap coerce x = coerceFromJSONKeyFunction x
484497 #-}
498+#endif
485499
486500-- | Same as 'fmap'. Provided for the consistency with 'ToJSONKeyFunction'.
487501mapFromJSONKeyFunction :: (a -> b) -> FromJSONKeyFunction a -> FromJSONKeyFunction b
488502mapFromJSONKeyFunction = fmap
489503
490−-- | 'fromJSONKey' for 'Generic' types.
491−-- These types must be sums of nullary constructors, whose names will be used
492−-- as keys for JSON objects.
493−--
494−-- See also 'genericToJSONKey'.
495−--
496−-- === __Example__
497−--
498−-- @
499−-- data Color = Red | Green | Blue
500−-- deriving 'Generic'
501−--
502−-- instance 'FromJSONKey' Color where
503−-- 'fromJSONKey' = 'genericFromJSONKey' 'defaultJSONKeyOptions'
504−-- @
505−genericFromJSONKey :: forall a. (Generic a, GFromJSONKey (Rep a))
506− => JSONKeyOptions
507− -> FromJSONKeyFunction a
508−genericFromJSONKey opts = FromJSONKeyTextParser $ \t ->
509− case parseSumFromString (keyModifier opts) t of
510− Nothing -> fail $
511− "invalid key " ++ show t ++ ", expected one of " ++ show cnames
512− Just k -> pure (to k)
513− where
514− cnames = unTagged2 (constructorTags (keyModifier opts) :: Tagged2 (Rep a) [String])
515−
516−class (ConstructorNames f, SumFromString f) => GFromJSONKey f where
517−instance (ConstructorNames f, SumFromString f) => GFromJSONKey f where
518−
519504-------------------------------------------------------------------------------
520505-- Functions needed for documentation
521506-------------------------------------------------------------------------------
@@ -768,13 +753,13 @@ withBoundedScientific' f v = withBoundedScientific_ id f v
768753-- | A variant of 'withBoundedScientific_' parameterized by a function to apply
769754-- to the 'Parser' in case of failure.
770755withBoundedScientific_ :: (Parser a -> Parser a) -> (Scientific -> Parser a) -> Value -> Parser a
771−withBoundedScientific_ whenFail f (Number scientific) =
772− if exp10 > 1024
756+withBoundedScientific_ whenFail f v@(Number scientific) =
757+ if exponent > 1024
773758 then whenFail (fail msg)
774759 else f scientific
775760 where
776− exp10 = base10Exponent scientific
777− msg = "found a number with exponent " ++ show exp10 ++ ", but it must not be greater than 1024"
761+ exponent = base10Exponent scientific
762+ msg = "found a number with exponent " ++ show exponent ++ ", but it must not be greater than 1024"
778763withBoundedScientific_ whenFail _ v =
779764 whenFail (typeMismatch "Number" v)
780765{-# INLINE withBoundedScientific_ #-}
@@ -794,7 +779,7 @@ withBool name _ v = prependContext name (typeMismatch "Boolean" v)
794779-- | Decode a nested JSON-encoded string.
795780withEmbeddedJSON :: String -> (Value -> Parser a) -> Value -> Parser a
796781withEmbeddedJSON _ innerParser (String txt) =
797− either fail innerParser $ eitherDecode (L.fromStrict $ T.encodeUtf8 txt)
782+ either fail innerParser $ eitherDecode (Compat.fromStrict $ T.encodeUtf8 txt)
798783 where
799784 eitherDecode = eitherFormatError . eitherDecodeWith jsonEOF ifromJSON
800785 eitherFormatError = either (Left . uncurry formatError) Right
@@ -863,7 +848,7 @@ parseFieldMaybe' = (.:!)
863848-- E.g. @'explicitParseField' 'parseJSON1' :: ('FromJSON1' f, 'FromJSON' a) -> 'Object' -> 'Text' -> 'Parser' (f a)@
864849explicitParseField :: (Value -> Parser a) -> Object -> Text -> Parser a
865850explicitParseField p obj key = case H.lookup key obj of
866− Nothing -> fail $ "key " ++ show key ++ " not found"
851+ Nothing -> fail $ "key " ++ show key ++ " not present"
867852 Just v -> p v <?> Key key
868853{-# INLINE explicitParseField #-}
869854
@@ -922,16 +907,6 @@ type ConName = String
922907contextType :: TypeName -> Parser a -> Parser a
923908contextType = prependContext
924909
925−-- | Add the tagKey that will be looked up while building an ADT
926−-- | Produce the error equivalent to
927−-- | Left "Error in $: parsing T failed, expected an object with keys "tag" and
928−-- | "contents", where "tag" i-- |s associated to one of ["Foo", "Bar"],
929−-- | The parser returned error was: could not find key "tag"
930−contextTag :: Text -> [String] -> Parser a -> Parser a
931−contextTag tagKey cnames = prependFailure
932− ("expected Object with key \"" ++ unpack tagKey ++ "\"" ++
933− " containing one of " ++ show cnames ++ ", ")
934−
935910-- | Add the name of the constructor being parsed to a parser's error messages.
936911contextCons :: ConName -> TypeName -> Parser a -> Parser a
937912contextCons cname tname = prependContext (showCons cname tname)
@@ -1042,46 +1017,41 @@ parseAllNullarySum :: (SumFromString f, ConstructorNames f)
10421017parseAllNullarySum tname opts =
10431018 withText tname $ \tag ->
10441019 maybe (badTag tag) return $
1045− parseSumFromString modifier tag
1020+ parseSumFromString opts tag
10461021 where
1047− badTag tag = failWithCTags tname modifier $ \cnames ->
1022+ badTag tag = failWithCTags tname opts $ \cnames ->
10481023 "expected one of the tags " ++ show cnames ++
10491024 ", but found tag " ++ show tag
1050− modifier = constructorTagModifier opts
10511025
10521026-- | Fail with an informative error message about a mismatched tag.
10531027-- The error message is parameterized by the list of expected tags,
10541028-- to be inferred from the result type of the parser.
10551029failWithCTags
1056− :: forall f a t. ConstructorNames f
1057− => TypeName -> (String -> t) -> ([t] -> String) -> Parser (f a)
1058−failWithCTags tname modifier f =
1030+ :: forall f a. ConstructorNames f
1031+ => TypeName -> Options -> ([String] -> String) -> Parser (f a)
1032+failWithCTags tname opts f =
10591033 contextType tname . fail $ f cnames
10601034 where
1061− cnames = unTagged2 (constructorTags modifier :: Tagged2 f [t])
1035+ cnames = unTagged2 (constructorTags opts :: Tagged2 f [String])
10621036
10631037class SumFromString f where
1064− parseSumFromString :: (String -> String) -> Text -> Maybe (f a)
1038+ parseSumFromString :: Options -> Text -> Maybe (f a)
10651039
10661040instance (SumFromString a, SumFromString b) => SumFromString (a :+: b) where
10671041 parseSumFromString opts key = (L1 <$> parseSumFromString opts key) <|>
10681042 (R1 <$> parseSumFromString opts key)
10691043
10701044instance (Constructor c) => SumFromString (C1 c U1) where
1071− parseSumFromString modifier key
1072− | key == name = Just $ M1 U1
1073− | otherwise = Nothing
1074− where
1075− name = pack $ modifier $ conName (undefined :: M1 _i c _f _p)
1076−
1077−-- For genericFromJSONKey
1078−instance SumFromString a => SumFromString (D1 d a) where
1079− parseSumFromString modifier key = M1 <$> parseSumFromString modifier key
1045+ parseSumFromString opts key | key == name = Just $ M1 U1
1046+ | otherwise = Nothing
1047+ where
1048+ name = pack $ constructorTagModifier opts $
1049+ conName (undefined :: M1 _i c _f _p)
10801050
10811051-- | List of all constructor tags.
1082−constructorTags :: ConstructorNames a => (String -> t) -> Tagged2 a [t]
1083−constructorTags modifier =
1084− fmap DList.toList (constructorNames' modifier)
1052+constructorTags :: ConstructorNames a => Options -> Tagged2 a [String]
1053+constructorTags opts =
1054+ fmap DList.toList (constructorNames' (constructorTagModifier opts))
10851055
10861056-- | List of all constructor names of an ADT, after a given conversion
10871057-- function. (Better inlining.)
@@ -1102,16 +1072,9 @@ instance Constructor c => ConstructorNames (C1 c a) where
11021072 where
11031073 cname = conName (undefined :: M1 _i c _f _p)
11041074
1105−-- For genericFromJSONKey
1106−instance ConstructorNames a => ConstructorNames (D1 d a) where
1107− constructorNames' = retag . constructorNames'
1108− where
1109− retag :: Tagged2 a u -> Tagged2 (D1 d a) u
1110− retag (Tagged2 x) = Tagged2 x
1111−
11121075--------------------------------------------------------------------------------
1113−parseNonAllNullarySum :: forall f c arity.
1114− ( FromPair arity f
1076+
1077+parseNonAllNullarySum :: ( FromPair arity f
11151078 , FromTaggedObject arity f
11161079 , FromUntaggedValue arity f
11171080 , ConstructorNames f
@@ -1121,7 +1084,7 @@ parseNonAllNullarySum p@(tname :* opts :* _) =
11211084 case sumEncoding opts of
11221085 TaggedObject{..} ->
11231086 withObject tname $ \obj -> do
1124− tag <- contextType tname . contextTag tagKey cnames_ $ obj .: tagKey
1087+ tag <- contextType tname $ obj .: tagKey
11251088 fromMaybe (badTag tag <?> Key tagKey) $
11261089 parseFromTaggedObject (tag :* contentsFieldName :* p) obj
11271090 where
@@ -1129,7 +1092,6 @@ parseNonAllNullarySum p@(tname :* opts :* _) =
11291092 badTag tag = failWith_ $ \cnames ->
11301093 "expected tag field to be one of " ++ show cnames ++
11311094 ", but found tag " ++ show tag
1132− cnames_ = unTagged2 (constructorTags (constructorTagModifier opts) :: Tagged2 f [String])
11331095
11341096 ObjectWithSingleField ->
11351097 withObject tname $ \obj -> case H.toList obj of
@@ -1161,7 +1123,7 @@ parseNonAllNullarySum p@(tname :* opts :* _) =
11611123
11621124 UntaggedValue -> parseUntaggedValue p
11631125 where
1164− failWith_ = failWithCTags tname (constructorTagModifier opts)
1126+ failWith_ = failWithCTags tname opts
11651127
11661128--------------------------------------------------------------------------------
11671129
@@ -1201,9 +1163,9 @@ class FromTaggedObject' arity f isRecord where
12011163 :: String :* ConName :* TypeName :* Options :* FromArgs arity a
12021164 -> Object -> Tagged isRecord (Parser (f a))
12031165
1204−instance (RecordFromJSON arity f, FieldNames f) => FromTaggedObject' arity f True where
1166+instance (RecordFromJSON arity f) => FromTaggedObject' arity f True where
12051167 -- Records are unpacked in the tagged object
1206− parseFromTaggedObject' (_ :* p) = Tagged . recordParseJSON (True :* p)
1168+ parseFromTaggedObject' (_ :* p) = Tagged . recordParseJSON p
12071169
12081170instance (ConsFromJSON arity f) => FromTaggedObject' arity f False where
12091171 -- Nonnullary nonrecords are encoded in the contents field
@@ -1244,11 +1206,11 @@ instance OVERLAPPING_
12441206 ) => ConsFromJSON' arity (S1 s a) True where
12451207 consParseJSON' p@(cname :* tname :* opts :* fargs)
12461208 | unwrapUnaryRecords opts = Tagged . fmap M1 . gParseJSON opts fargs
1247− | otherwise = Tagged . withObject (showCons cname tname) (recordParseJSON (False :* p))
1209+ | otherwise = Tagged . withObject (showCons cname tname) (recordParseJSON p)
12481210
12491211instance RecordFromJSON arity f => ConsFromJSON' arity f True where
12501212 consParseJSON' p@(cname :* tname :* _) =
1251− Tagged . withObject (showCons cname tname) (recordParseJSON (False :* p))
1213+ Tagged . withObject (showCons cname tname) (recordParseJSON p)
12521214
12531215instance OVERLAPPING_
12541216 ConsFromJSON' arity U1 False where
@@ -1274,55 +1236,21 @@ instance (ProductFromJSON arity f, ProductSize f
12741236
12751237--------------------------------------------------------------------------------
12761238
1277−class FieldNames f where
1278− fieldNames :: f a -> [Text] -> [Text]
1279−
1280−instance (FieldNames a, FieldNames b) => FieldNames (a :*: b) where
1281− fieldNames _ =
1282− fieldNames (undefined :: a x) .
1283− fieldNames (undefined :: b y)
1284−
1285−instance (Selector s) => FieldNames (S1 s f) where
1286− fieldNames _ = (pack (selName (undefined :: M1 _i s _f _p)) :)
1287−
12881239class RecordFromJSON arity f where
12891240 recordParseJSON
1290− :: Bool :* ConName :* TypeName :* Options :* FromArgs arity a
1291− -> Object -> Parser (f a)
1292−
1293−instance ( FieldNames f
1294− , RecordFromJSON' arity f
1295− ) => RecordFromJSON arity f where
1296− recordParseJSON (fromTaggedSum :* p@(cname :* tname :* opts :* _)) =
1297− \obj -> checkUnknown obj >> recordParseJSON' p obj
1298− where
1299− knownFields :: H.HashMap Text ()
1300− knownFields = H.fromList $ map (,()) $
1301− fieldNames (undefined :: f a)
1302− [pack (tagFieldName (sumEncoding opts)) | fromTaggedSum]
1303− checkUnknown =
1304− if not (rejectUnknownFields opts)
1305− then \_ -> return ()
1306− else \obj -> case H.keys (H.difference obj knownFields) of
1307− [] -> return ()
1308− unknownFields -> contextCons cname tname $
1309− fail ("unknown fields: " ++ show unknownFields)
1310−
1311−class RecordFromJSON' arity f where
1312− recordParseJSON'
13131241 :: ConName :* TypeName :* Options :* FromArgs arity a
13141242 -> Object -> Parser (f a)
13151243
1316−instance ( RecordFromJSON' arity a
1317− , RecordFromJSON' arity b
1318− ) => RecordFromJSON' arity (a :*: b) where
1319− recordParseJSON' p obj =
1320− (:*:) <$> recordParseJSON' p obj
1321− <*> recordParseJSON' p obj
1244+instance ( RecordFromJSON arity a
1245+ , RecordFromJSON arity b
1246+ ) => RecordFromJSON arity (a :*: b) where
1247+ recordParseJSON p obj =
1248+ (:*:) <$> recordParseJSON p obj
1249+ <*> recordParseJSON p obj
13221250
13231251instance OVERLAPPABLE_ (Selector s, GFromJSON arity a) =>
1324− RecordFromJSON' arity (S1 s a) where
1325− recordParseJSON' (cname :* tname :* opts :* fargs) obj = do
1252+ RecordFromJSON arity (S1 s a) where
1253+ recordParseJSON (cname :* tname :* opts :* fargs) obj = do
13261254 fv <- contextCons cname tname (obj .: label)
13271255 M1 <$> gParseJSON opts fargs fv <?> Key label
13281256 where
@@ -1330,16 +1258,16 @@ instance OVERLAPPABLE_ (Selector s, GFromJSON arity a) =>
13301258 sname = selName (undefined :: M1 _i s _f _p)
13311259
13321260instance INCOHERENT_ (Selector s, FromJSON a) =>
1333− RecordFromJSON' arity (S1 s (K1 i (Maybe a))) where
1334− recordParseJSON' (_ :* _ :* opts :* _) obj = M1 . K1 <$> obj .:? pack label
1261+ RecordFromJSON arity (S1 s (K1 i (Maybe a))) where
1262+ recordParseJSON (_ :* _ :* opts :* _) obj = M1 . K1 <$> obj .:? pack label
13351263 where
13361264 label = fieldLabelModifier opts sname
13371265 sname = selName (undefined :: M1 _i s _f _p)
13381266
13391267-- Parse an Option like a Maybe.
13401268instance INCOHERENT_ (Selector s, FromJSON a) =>
1341− RecordFromJSON' arity (S1 s (K1 i (Semigroup.Option a))) where
1342− recordParseJSON' p obj = wrap <$> recordParseJSON' p obj
1269+ RecordFromJSON arity (S1 s (K1 i (Semigroup.Option a))) where
1270+ recordParseJSON p obj = wrap <$> recordParseJSON p obj
13431271 where
13441272 wrap :: S1 s (K1 i (Maybe a)) p -> S1 s (K1 i (Semigroup.Option a)) p
13451273 wrap (M1 (K1 a)) = M1 (K1 (Semigroup.Option a))
@@ -1576,22 +1504,12 @@ instance FromJSONKey Float where
15761504 _ -> Scientific.toRealFloat <$> parseScientificText t
15771505
15781506instance (FromJSON a, Integral a) => FromJSON (Ratio a) where
1579− parseJSON (Number x)
1580− | exp10 <= 1024
1581− , exp10 >= -1024 = return $! realToFrac x
1582− | otherwise = prependContext "Ratio" $ fail msg
1583− where
1584− exp10 = base10Exponent x
1585− msg = "found a number with exponent " ++ show exp10
1586− ++ ", but it must not be greater than 1024 or less than -1024"
1587− parseJSON o = objParser o
1588− where
1589− objParser = withObject "Rational" $ \obj -> do
1590− numerator <- obj .: "numerator"
1591− denominator <- obj .: "denominator"
1592− if denominator == 0
1593− then fail "Ratio denominator was 0"
1594− else pure $ numerator % denominator
1507+ parseJSON = withObject "Rational" $ \obj -> do
1508+ numerator <- obj .: "numerator"
1509+ denominator <- obj .: "denominator"
1510+ if denominator == 0
1511+ then fail "Ratio denominator was 0"
1512+ else pure $ numerator % denominator
15951513 {-# INLINE parseJSON #-}
15961514
15971515-- | This instance includes a bounds check to prevent maliciously
@@ -1742,7 +1660,7 @@ instance FromJSON1 NonEmpty where
17421660 liftParseJSON p _ = withArray "NonEmpty" $
17431661 (>>= ne) . Tr.sequence . zipWith (parseIndexedJSON p) [0..] . V.toList
17441662 where
1745− ne [] = fail "parsing NonEmpty failed, unexpected empty list"
1663+ ne [] = fail "parsing NonEmpty failed, unpexpected empty list"
17461664 ne (x:xs) = pure (x :| xs)
17471665 {-# INLINE liftParseJSON #-}
17481666
@@ -1997,7 +1915,7 @@ instance FromJSON DotNetTime where
19971915 parseJSON = withText "DotNetTime" $ \t ->
19981916 let (s,m) = T.splitAt (T.length t - 5) t
19991917 t' = T.concat [s,".",m]
2000− in case parseTimeM True defaultTimeLocale "/Date(%s%Q)/" (unpack t') of
1918+ in case parseTime defaultTimeLocale "/Date(%s%Q)/" (unpack t') of
20011919 Just d -> pure (DotNetTime d)
20021920 _ -> fail "could not parse .NET time"
20031921 {-# INLINE parseJSON #-}
@@ -2006,6 +1924,7 @@ instance FromJSON DotNetTime where
20061924-- primitive
20071925-------------------------------------------------------------------------------
20081926
1927+#if MIN_VERSION_base(4,7,0)
20091928instance FromJSON a => FromJSON (PM.Array a) where
20101929 -- note: we could do better than this if vector exposed the data
20111930 -- constructor in Data.Vector.
@@ -2018,7 +1937,6 @@ instance FromJSON a => FromJSON (PM.SmallArray a) where
20181937instance (PM.Prim a,FromJSON a) => FromJSON (PM.PrimArray a) where
20191938 parseJSON = fmap Exts.fromList . parseJSON
20201939
2021−#if !MIN_VERSION_primitive(0,7,0)
20221940instance (PM.PrimUnlifted a,FromJSON a) => FromJSON (PM.UnliftedArray a) where
20231941 parseJSON = fmap Exts.fromList . parseJSON
20241942#endif
@@ -2091,40 +2009,6 @@ instance FromJSON DiffTime where
20912009 parseJSON = withBoundedScientific "DiffTime" $ pure . realToFrac
20922010 {-# INLINE parseJSON #-}
20932011
2094−instance FromJSON SystemTime where
2095− parseJSON v = prependContext "SystemTime" $ do
2096− n <- parseJSON v
2097− let n' = floor (n * fromInteger (resolution n) :: Nano)
2098− let (secs, nano) = n' `divMod` resolution n
2099− return (MkSystemTime (fromInteger secs) (fromInteger nano))
2100−
2101−instance FromJSON CalendarDiffTime where
2102− parseJSON = withObject "CalendarDiffTime" $ \obj -> CalendarDiffTime
2103− <$> obj .: "months"
2104− <*> obj .: "time"
2105−
2106−instance FromJSON CalendarDiffDays where
2107− parseJSON = withObject "CalendarDiffDays" $ \obj -> CalendarDiffDays
2108− <$> obj .: "months"
2109− <*> obj .: "days"
2110−
2111−instance FromJSON DayOfWeek where
2112− parseJSON = withText "DaysOfWeek" parseDayOfWeek
2113−
2114−parseDayOfWeek :: T.Text -> Parser DayOfWeek
2115−parseDayOfWeek t = case T.toLower t of
2116− "monday" -> return Monday
2117− "tuesday" -> return Tuesday
2118− "wednesday" -> return Wednesday
2119− "thursday" -> return Thursday
2120− "friday" -> return Friday
2121− "saturday" -> return Saturday
2122− "sunday" -> return Sunday
2123− _ -> fail "Invalid week day"
2124−
2125−instance FromJSONKey DayOfWeek where
2126− fromJSONKey = FromJSONKeyTextParser parseDayOfWeek
2127−
21282012-------------------------------------------------------------------------------
21292013-- base Monoid/Semigroup
21302014-------------------------------------------------------------------------------
Data/Aeson/Types/Generic.hs+1
@@ -5,6 +5,7 @@
55{-# LANGUAGE FlexibleInstances #-}
66{-# LANGUAGE FunctionalDependencies #-}
77{-# LANGUAGE KindSignatures #-}
8+{-# LANGUAGE MultiParamTypeClasses #-}
89{-# LANGUAGE NoImplicitPrelude #-}
910{-# LANGUAGE ScopedTypeVariables #-}
1011{-# LANGUAGE TypeOperators #-}
Data/Aeson/Types/Internal.hs+5−105
@@ -49,8 +49,6 @@ module Data.Aeson.Types.Internal
4949 , parserThrowError
5050 , parserCatchError
5151 , formatError
52− , formatPath
53− , formatRelativePath
5452 , (<?>)
5553 -- * Constructors and accessors
5654 , object
@@ -64,14 +62,11 @@ module Data.Aeson.Types.Internal
6462 , sumEncoding
6563 , unwrapUnaryRecords
6664 , tagSingleConstructors
67− , rejectUnknownFields
6865 )
6966
7067 , SumEncoding(..)
71− , JSONKeyOptions(keyModifier)
7268 , defaultOptions
7369 , defaultTaggedObject
74− , defaultJSONKeyOptions
7570
7671 -- * Used for changing CamelCase names into something else.
7772 , camelTo
@@ -102,7 +97,6 @@ import Data.Time.Format (FormatTime)
10297import Data.Typeable (Typeable)
10398import Data.Vector (Vector)
10499import GHC.Generics (Generic)
105−import qualified Control.Monad as Monad
106100import qualified Control.Monad.Fail as Fail
107101import qualified Data.HashMap.Strict as H
108102import qualified Data.Scientific as S
@@ -156,7 +150,7 @@ instance Functor Result where
156150 fmap _ (Error err) = Error err
157151 {-# INLINE fmap #-}
158152
159−instance Monad.Monad IResult where
153+instance Monad IResult where
160154 return = pure
161155 {-# INLINE return #-}
162156
@@ -164,16 +158,14 @@ instance Monad.Monad IResult where
164158 IError path err >>= _ = IError path err
165159 {-# INLINE (>>=) #-}
166160
167−#if !(MIN_VERSION_base(4,13,0))
168161 fail = Fail.fail
169162 {-# INLINE fail #-}
170−#endif
171163
172164instance Fail.MonadFail IResult where
173165 fail err = IError [] err
174166 {-# INLINE fail #-}
175167
176−instance Monad.Monad Result where
168+instance Monad Result where
177169 return = pure
178170 {-# INLINE return #-}
179171
@@ -181,10 +173,8 @@ instance Monad.Monad Result where
181173 Error err >>= _ = Error err
182174 {-# INLINE (>>=) #-}
183175
184−#if !(MIN_VERSION_base(4,13,0))
185176 fail = Fail.fail
186177 {-# INLINE fail #-}
187−#endif
188178
189179instance Fail.MonadFail Result where
190180 fail err = Error err
@@ -292,17 +282,14 @@ newtype Parser a = Parser {
292282 -> f r
293283 }
294284
295−instance Monad.Monad Parser where
285+instance Monad Parser where
296286 m >>= g = Parser $ \path kf ks -> let ks' a = runParser (g a) path kf ks
297287 in runParser m path kf ks'
298288 {-# INLINE (>>=) #-}
299289 return = pure
300290 {-# INLINE return #-}
301−
302−#if !(MIN_VERSION_base(4,13,0))
303291 fail = Fail.fail
304292 {-# INLINE fail #-}
305−#endif
306293
307294instance Fail.MonadFail Parser where
308295 fail msg = Parser $ \path kf _ks -> kf (reverse path) msg
@@ -461,17 +448,7 @@ parseEither m v = runParser (m v) [] onError Right
461448-- | Annotate an error message with a
462449-- <http://goessner.net/articles/JsonPath/ JSONPath> error location.
463450formatError :: JSONPath -> String -> String
464−formatError path msg = "Error in " ++ formatPath path ++ ": " ++ msg
465−
466−-- | Format a <http://goessner.net/articles/JsonPath/ JSONPath> as a 'String',
467−-- representing the root object as @$@.
468−formatPath :: JSONPath -> String
469−formatPath path = "$" ++ formatRelativePath path
470−
471−-- | Format a <http://goessner.net/articles/JsonPath/ JSONPath> as a 'String'
472−-- which represents the path relative to some root object.
473−formatRelativePath :: JSONPath -> String
474−formatRelativePath path = format "" path
451+formatError path msg = "Error in " ++ format "$" path ++ ": " ++ msg
475452 where
476453 format :: String -> JSONPath -> String
477454 format pfx [] = pfx
@@ -584,39 +561,6 @@ data Options = Options
584561 -- ^ If 'True' record fields with a 'Nothing' value will be
585562 -- omitted from the resulting object. If 'False' the resulting
586563 -- object will include those fields mapping to @null@.
587− --
588− -- === Note
589− --
590− -- Setting 'omitNothingFields' to 'True' only affects fields which are of
591− -- type 'Maybe' /uniformly/ in the 'ToJSON' or 'FromJSON' instance. In
592− -- particular, if the type of a field is declared as a type variable, it
593− -- will not be omitted from the JSON object, unless the field is
594− -- specialized upfront in the instance.
595− --
596− -- ==== __Example__
597− --
598− -- The generic instance for the following type @Fruit@ depends on whether
599− -- the instance head is @Fruit a@ or @Fruit (Maybe a)@.
600− --
601− -- @
602− -- data Fruit a =
603− -- { apples :: a -- A field whose type is a type variable.
604− -- , oranges :: 'Maybe' Int
605− -- }
606− --
607− -- options :: 'Options'
608− -- options = 'defaultOptions' { 'omitNothingFields' = 'True' }
609− --
610− -- -- apples required, oranges optional
611− -- -- Even if 'Data.Aeson.fromJSON' is then specialized to (Fruit ('Maybe' a)).
612− -- instance 'Data.Aeson.FromJSON' a => 'Data.Aeson.FromJSON' (Fruit a) where
613− -- 'Data.Aeson.fromJSON' = 'Data.Aeson.genericFromJSON' options
614− --
615− -- -- apples optional, oranges optional
616− -- -- In this instance, the field apples is uniformly of type ('Maybe' a).
617− -- instance 'Data.Aeson.FromJSON' a => 'Data.Aeson.FromJSON' (Fruit ('Maybe' a)) where
618− -- 'Data.Aeson.fromJSON' = 'Data.Aeson.genericFromJSON' options
619− -- @
620564 , sumEncoding :: SumEncoding
621565 -- ^ Specifies how to encode constructors of a sum datatype.
622566 , unwrapUnaryRecords :: Bool
@@ -625,14 +569,10 @@ data Options = Options
625569 , tagSingleConstructors :: Bool
626570 -- ^ Encode types with a single constructor as sums,
627571 -- so that `allNullaryToStringTag` and `sumEncoding` apply.
628− , rejectUnknownFields :: Bool
629− -- ^ Applies only to 'Data.Aeson.FromJSON' instances. If a field appears in
630− -- the parsed object map, but does not appear in the target object, parsing
631− -- will fail, with an error message indicating which fields were unknown.
632572 }
633573
634574instance Show Options where
635− show (Options f c a o s u t r) =
575+ show (Options f c a o s u t) =
636576 "Options {"
637577 ++ intercalate ", "
638578 [ "fieldLabelModifier =~ " ++ show (f "exampleField")
@@ -642,7 +582,6 @@ instance Show Options where
642582 , "sumEncoding = " ++ show s
643583 , "unwrapUnaryRecords = " ++ show u
644584 , "tagSingleConstructors = " ++ show t
645− , "rejectUnknownFields = " ++ show r
646585 ]
647586 ++ "}"
648587
@@ -686,33 +625,6 @@ data SumEncoding =
686625 -- contents of the constructor.
687626 deriving (Eq, Show)
688627
689−-- | Options for encoding keys with 'Data.Aeson.Types.genericFromJSONKey' and
690−-- 'Data.Aeson.Types.genericToJSONKey'.
691−data JSONKeyOptions = JSONKeyOptions
692− { keyModifier :: String -> String
693− -- ^ Function applied to keys. Its result is what goes into the encoded
694− -- 'Value'.
695− --
696− -- === __Example__
697− --
698− -- The following instances encode the constructor @Bar@ to lower-case keys
699− -- @\"bar\"@.
700− --
701− -- @
702− -- data Foo = Bar
703− -- deriving 'Generic'
704− --
705− -- opts :: 'JSONKeyOptions'
706− -- opts = 'defaultJSONKeyOptions' { 'keyModifier' = 'toLower' }
707− --
708− -- instance 'ToJSONKey' Foo where
709− -- 'toJSONKey' = 'genericToJSONKey' opts
710− --
711− -- instance 'FromJSONKey' Foo where
712− -- 'fromJSONKey' = 'genericFromJSONKey' opts
713− -- @
714− }
715−
716628-- | Default encoding 'Options':
717629--
718630-- @
@@ -724,7 +636,6 @@ data JSONKeyOptions = JSONKeyOptions
724636-- , 'sumEncoding' = 'defaultTaggedObject'
725637-- , 'unwrapUnaryRecords' = False
726638-- , 'tagSingleConstructors' = False
727−-- , 'rejectUnknownFields' = False
728639-- }
729640-- @
730641defaultOptions :: Options
@@ -736,7 +647,6 @@ defaultOptions = Options
736647 , sumEncoding = defaultTaggedObject
737648 , unwrapUnaryRecords = False
738649 , tagSingleConstructors = False
739− , rejectUnknownFields = False
740650 }
741651
742652-- | Default 'TaggedObject' 'SumEncoding' options:
@@ -753,16 +663,6 @@ defaultTaggedObject = TaggedObject
753663 , contentsFieldName = "contents"
754664 }
755665
756−-- | Default 'JSONKeyOptions':
757−--
758−-- @
759−-- defaultJSONKeyOptions = 'JSONKeyOptions'
760−-- { 'keyModifier' = 'id'
761−-- }
762−-- @
763−defaultJSONKeyOptions :: JSONKeyOptions
764−defaultJSONKeyOptions = JSONKeyOptions id
765−
766666-- | Converts from CamelCase to another lower case, interspersing
767667-- the character between all capital letters and their previous
768668-- entries, except those capital letters that appear together,
Data/Aeson/Types/ToJSON.hs+52−98
@@ -5,15 +5,21 @@
55{-# LANGUAGE FlexibleInstances #-}
66{-# LANGUAGE FunctionalDependencies #-}
77{-# LANGUAGE GADTs #-}
8+{-# LANGUAGE MultiParamTypeClasses #-}
9+{-# LANGUAGE NamedFieldPuns #-}
810{-# LANGUAGE NoImplicitPrelude #-}
911{-# LANGUAGE OverloadedStrings #-}
1012{-# LANGUAGE PatternGuards #-}
11−{-# LANGUAGE PolyKinds #-}
1213{-# LANGUAGE RecordWildCards #-}
1314{-# LANGUAGE ScopedTypeVariables #-}
1415{-# LANGUAGE TypeOperators #-}
16+{-# LANGUAGE TypeSynonymInstances #-}
1517{-# LANGUAGE UndecidableInstances #-}
1618
19+#if __GLASGOW_HASKELL__ >= 706
20+{-# LANGUAGE PolyKinds #-}
21+#endif
22+
1723#include "overlapping-compat.h"
1824#include "incoherent-compat.h"
1925
@@ -43,10 +49,6 @@ module Data.Aeson.Types.ToJSON
4349 , ToJSONKeyFunction(..)
4450 , toJSONKeyText
4551 , contramapToJSONKeyFunction
46−
47− , GToJSONKey()
48− , genericToJSONKey
49−
5052 -- * Object key-value pairs
5153 , KeyValue(..)
5254 , KeyValuePair(..)
@@ -69,7 +71,7 @@ import Data.Aeson.Types.Internal
6971import Data.Attoparsec.Number (Number(..))
7072import Data.Bits (unsafeShiftR)
7173import Data.DList (DList)
72−import Data.Fixed (Fixed, HasResolution, Nano)
74+import Data.Fixed (Fixed, HasResolution)
7375import Data.Foldable (toList)
7476import Data.Functor.Compose (Compose(..))
7577import Data.Functor.Contravariant (Contravariant (..))
@@ -86,10 +88,8 @@ import Data.Scientific (Scientific)
8688import Data.Tagged (Tagged(..))
8789import Data.Text (Text, pack)
8890import Data.Time (Day, DiffTime, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
89−import Data.Time.Calendar.Compat (CalendarDiffDays (..), DayOfWeek (..))
90−import Data.Time.LocalTime.Compat (CalendarDiffTime (..))
91−import Data.Time.Clock.System.Compat (SystemTime (..))
92−import Data.Time.Format.Compat (FormatTime, formatTime, defaultTimeLocale)
91+import Data.Time.Format (FormatTime, formatTime)
92+import Data.Time.Locale.Compat (defaultTimeLocale)
9393import Data.Vector (Vector)
9494import Data.Version (Version, showVersion)
9595import Data.Void (Void, absurd)
@@ -100,6 +100,7 @@ import GHC.Generics
100100import Numeric.Natural (Natural)
101101import qualified Data.Aeson.Encoding as E
102102import qualified Data.Aeson.Encoding.Internal as E (InArray, comma, econcat, retagEncoding)
103+import qualified Data.ByteString as S
103104import qualified Data.ByteString.Lazy as L
104105import qualified Data.DList as DList
105106import qualified Data.HashMap.Strict as H
@@ -134,12 +135,20 @@ import qualified Data.Primitive.SmallArray as PM
134135import qualified Data.Primitive.Types as PM
135136
136137#if MIN_VERSION_primitive(0,6,4)
137−#if !MIN_VERSION_primitive(0,7,0)
138138import qualified Data.Primitive.UnliftedArray as PM
139−#endif
140139import qualified Data.Primitive.PrimArray as PM
141140#endif
142141
142+#if !(MIN_VERSION_bytestring(0,10,0))
143+import Foreign.ForeignPtr (withForeignPtr)
144+import Foreign.Marshal.Utils (copyBytes)
145+import Foreign.Ptr (plusPtr)
146+import qualified Data.ByteString.Internal as S
147+import qualified Data.ByteString.Lazy.Internal as L
148+#endif
149+
150+{-# ANN module ("HLint: ignore Reduce duplication"::String) #-}
151+
143152toJSONPair :: (a -> Value) -> (b -> Value) -> (a, b) -> Value
144153toJSONPair a b = liftToJSON2 a (listValue a) b (listValue b)
145154{-# INLINE toJSONPair #-}
@@ -402,7 +411,7 @@ instance KeyValue Object where
402411-- newtype wrapper around 'Text'. The recommended approach is to use
403412-- generalized newtype deriving:
404413--
405−-- > newtype RecordId = RecordId { getRecordId :: Text }
414+-- > newtype RecordId = RecordId { getRecordId :: Text}
406415-- > deriving (Eq,Ord,ToJSONKey)
407416--
408417-- Then we may write:
@@ -417,18 +426,8 @@ instance KeyValue Object where
417426--
418427-- It is possible to get the 'ToJSONKey' instance for free as we did
419428-- with 'Foo'. However, in this case, we have a natural way to go to
420−-- and from 'Text' that does not require any escape sequences. So
421−-- 'ToJSONKeyText' can be used instead of 'ToJSONKeyValue' to encode maps
422−-- as objects instead of arrays of pairs. This instance may be
423−-- implemented using generics as follows:
424−--
425−-- @
426−-- instance 'ToJSONKey' Color where
427−-- 'toJSONKey' = 'genericToJSONKey' 'defaultJSONKeyOptions'
428−-- @
429−--
430−-- === __Low-level implementations__
431−--
429+-- and from 'Text' that does not require any escape sequences. So, in
430+-- this example, 'ToJSONKeyText' will be used instead of 'ToJSONKeyValue'.
432431-- The 'Show' instance can be used to help write 'ToJSONKey':
433432--
434433-- > instance ToJSONKey Color where
@@ -503,7 +502,7 @@ toJSONKeyTextEnc e = ToJSONKeyText tot e
503502 -- TODO: dropAround is also used in stringEncoding, which is unfortunate atm
504503 tot = T.dropAround (== '"')
505504 . T.decodeLatin1
506− . L.toStrict
505+ . lazyToStrictByteString
507506 . E.encodingToLazyByteString
508507 . e
509508
@@ -516,29 +515,6 @@ contramapToJSONKeyFunction h x = case x of
516515 ToJSONKeyText f g -> ToJSONKeyText (f . h) (g . h)
517516 ToJSONKeyValue f g -> ToJSONKeyValue (f . h) (g . h)
518517
519−-- 'toJSONKey' for 'Generic' types.
520−-- Deriving is supported for enumeration types, i.e. the sums of nullary
521−-- constructors. The names of constructors will be used as keys for JSON
522−-- objects.
523−--
524−-- See also 'genericFromJSONKey'.
525−--
526−-- === __Example__
527−--
528−-- @
529−-- data Color = Red | Green | Blue
530−-- deriving 'Generic'
531−--
532−-- instance 'ToJSONKey' Color where
533−-- 'toJSONKey' = 'genericToJSONKey' 'defaultJSONKeyOptions'
534−-- @
535−genericToJSONKey :: (Generic a, GToJSONKey (Rep a))
536− => JSONKeyOptions -> ToJSONKeyFunction a
537−genericToJSONKey opts = toJSONKeyText (pack . keyModifier opts . getConName . from)
538−
539−class GetConName f => GToJSONKey f
540−instance GetConName f => GToJSONKey f
541−
542518-------------------------------------------------------------------------------
543519-- Lifings of FromJSON and ToJSON to unary and binary type constructors
544520-------------------------------------------------------------------------------
@@ -968,9 +944,6 @@ instance (GetConName a, GetConName b) => GetConName (a :+: b) where
968944instance (Constructor c) => GetConName (C1 c a) where
969945 getConName = conName
970946
971−-- For genericToJSONKey
972−instance GetConName a => GetConName (D1 d a) where
973− getConName (M1 x) = getConName x
974947
975948--------------------------------------------------------------------------------
976949
@@ -1970,6 +1943,7 @@ formatMillis = take 3 . formatTime defaultTimeLocale "%q"
19701943-- primitive
19711944-------------------------------------------------------------------------------
19721945
1946+#if MIN_VERSION_base(4,7,0)
19731947instance ToJSON a => ToJSON (PM.Array a) where
19741948 -- note: we could do better than this if vector exposed the data
19751949 -- constructor in Data.Vector.
@@ -1985,7 +1959,6 @@ instance (PM.Prim a,ToJSON a) => ToJSON (PM.PrimArray a) where
19851959 toJSON = toJSON . Exts.toList
19861960 toEncoding = toEncoding . Exts.toList
19871961
1988−#if !MIN_VERSION_primitive(0,7,0)
19891962instance (PM.PrimUnlifted a,ToJSON a) => ToJSON (PM.UnliftedArray a) where
19901963 toJSON = toJSON . Exts.toList
19911964 toEncoding = toEncoding . Exts.toList
@@ -2040,7 +2013,7 @@ stringEncoding :: Encoding' Text -> Value
20402013stringEncoding = String
20412014 . T.dropAround (== '"')
20422015 . T.decodeLatin1
2043− . L.toStrict
2016+ . lazyToStrictByteString
20442017 . E.encodingToLazyByteString
20452018{-# INLINE stringEncoding #-}
20462019
@@ -2060,50 +2033,6 @@ instance ToJSON DiffTime where
20602033 toEncoding = E.scientific . realToFrac
20612034 {-# INLINE toEncoding #-}
20622035
2063−-- | Encoded as number
2064−instance ToJSON SystemTime where
2065− toJSON (MkSystemTime secs nsecs) =
2066− toJSON (fromIntegral secs + fromIntegral nsecs / 1000000000 :: Nano)
2067− toEncoding (MkSystemTime secs nsecs) =
2068− toEncoding (fromIntegral secs + fromIntegral nsecs / 1000000000 :: Nano)
2069−
2070−instance ToJSON CalendarDiffTime where
2071− toJSON (CalendarDiffTime m nt) = object
2072− [ "months" .= m
2073− , "time" .= nt
2074− ]
2075− toEncoding (CalendarDiffTime m nt) = E.pairs
2076− ("months" .= m <> "time" .= nt)
2077−
2078−instance ToJSON CalendarDiffDays where
2079− toJSON (CalendarDiffDays m d) = object
2080− [ "months" .= m
2081− , "days" .= d
2082− ]
2083− toEncoding (CalendarDiffDays m d) = E.pairs
2084− ("months" .= m <> "days" .= d)
2085−
2086−instance ToJSON DayOfWeek where
2087− toJSON Monday = "monday"
2088− toJSON Tuesday = "tuesday"
2089− toJSON Wednesday = "wednesday"
2090− toJSON Thursday = "thursday"
2091− toJSON Friday = "friday"
2092− toJSON Saturday = "saturday"
2093− toJSON Sunday = "sunday"
2094−
2095−toEncodingDayOfWeek :: DayOfWeek -> E.Encoding' Text
2096−toEncodingDayOfWeek Monday = E.unsafeToEncoding "\"monday\""
2097−toEncodingDayOfWeek Tuesday = E.unsafeToEncoding "\"tuesday\""
2098−toEncodingDayOfWeek Wednesday = E.unsafeToEncoding "\"wednesday\""
2099−toEncodingDayOfWeek Thursday = E.unsafeToEncoding "\"thursday\""
2100−toEncodingDayOfWeek Friday = E.unsafeToEncoding "\"friday\""
2101−toEncodingDayOfWeek Saturday = E.unsafeToEncoding "\"saturday\""
2102−toEncodingDayOfWeek Sunday = E.unsafeToEncoding "\"sunday\""
2103−
2104−instance ToJSONKey DayOfWeek where
2105− toJSONKey = toJSONKeyTextEnc toEncodingDayOfWeek
2106−
21072036-------------------------------------------------------------------------------
21082037-- base Monoid/Semigroup
21092038-------------------------------------------------------------------------------
@@ -2847,6 +2776,31 @@ instance (ToJSON a, ToJSON b, ToJSON c, ToJSON d, ToJSON e, ToJSON f, ToJSON g,
28472776 toEncoding = toEncoding2
28482777 {-# INLINE toEncoding #-}
28492778
2779+-------------------------------------------------------------------------------
2780+-- pre-bytestring-0.10 compatibility
2781+-------------------------------------------------------------------------------
2782+
2783+{-# INLINE lazyToStrictByteString #-}
2784+lazyToStrictByteString :: L.ByteString -> S.ByteString
2785+#if MIN_VERSION_bytestring(0,10,0)
2786+lazyToStrictByteString = L.toStrict
2787+#else
2788+lazyToStrictByteString = packChunks
2789+
2790+-- packChunks is taken from the blaze-builder package.
2791+
2792+-- | Pack the chunks of a lazy bytestring into a single strict bytestring.
2793+packChunks :: L.ByteString -> S.ByteString
2794+packChunks lbs =
2795+ S.unsafeCreate (fromIntegral $ L.length lbs) (copyChunks lbs)
2796+ where
2797+ copyChunks L.Empty _pf = return ()
2798+ copyChunks (L.Chunk (S.PS fpbuf o l) lbs') pf = do
2799+ withForeignPtr fpbuf $ \pbuf ->
2800+ copyBytes pf (pbuf `plusPtr` o) l
2801+ copyChunks lbs' (pf `plusPtr` l)
2802+#endif
2803+
28502804--------------------------------------------------------------------------------
28512805
28522806-- | Wrap a list of pairs as an object.
HLint.hsnew file+12
@@ -0,0 +1,12 @@
1+module HLint.HLint where
2+
3+import "hint" HLint.Default
4+import "hint" HLint.Builtin.All
5+import "hint" HLint.Dollar
6+
7+ignore "Avoid lambda"
8+ignore "Eta reduce"
9+ignore "Functor law"
10+ignore "Use >=>"
11+ignore "Use lambda-case"
12+ignore "Use $>"
Makefile+1−1
@@ -1,2 +1,2 @@
11lint:
2− ./run-hlint.sh --cpp-include include/ --cpp-file travis/cabal_macros.h Data/ attoparsec-iso8601/ benchmarks/ examples/ ffi/ pure/ tests/
2+ hlint --cpp-include include/ --cpp-file .stack-work/dist/*/*Cabal-*/build/autogen/cabal_macros.h Data/ attoparsec-iso8601/ benchmarks/ examples/ ffi/ pure/ tests/
aeson.cabal+23−20
@@ -1,5 +1,5 @@
11name: aeson
2−version: 1.4.6.0
2+version: 1.4.2.0
33license: BSD3
44license-file: LICENSE
55category: Text, Web, JSON
@@ -88,6 +88,7 @@ library
8888 Data.Aeson.Encode
8989
9090 other-modules:
91+ Data.Aeson.Compat
9192 Data.Aeson.Encoding.Builder
9293 Data.Aeson.Internal.Functions
9394 Data.Aeson.Parser.Unescape
@@ -102,22 +103,23 @@ library
102103
103104 -- GHC bundled libs
104105 build-depends:
105− base >= 4.7.0.0 && < 5,
106− bytestring >= 0.10.4.0 && < 0.11,
107− containers >= 0.5.5.1 && < 0.7,
106+ base >= 4.5.0.0 && < 5,
107+ containers >= 0.4.2.1 && < 0.7,
108108 deepseq >= 1.3.0.0 && < 1.5,
109109 ghc-prim >= 0.2 && < 0.6,
110− template-haskell >= 2.9.0.0 && < 2.16,
110+ template-haskell >= 2.7.0.0 && < 2.15,
111111 text >= 1.2.3.0 && < 1.3,
112− time >= 1.4 && < 1.10
113−
114− if impl(ghc >= 8.0)
115− build-depends: bytestring >= 0.10.8.1
112+ time >= 1.4 && < 1.9
116113
117114 -- Compat
118115 build-depends:
119− base-compat >= 0.9.1 && < 0.12,
120− time-compat >= 1.9.2.2 && < 1.10
116+ base-compat >= 0.9.1 && < 0.11
117+
118+ if flag(bytestring-builder)
119+ build-depends: bytestring >= 0.9.2 && < 0.10.4,
120+ bytestring-builder >= 0.10.4 && < 1
121+ else
122+ build-depends: bytestring >= 0.10.4 && < 0.11
121123
122124 if !impl(ghc >= 8.6)
123125 build-depends:
@@ -126,7 +128,7 @@ library
126128 if !impl(ghc >= 8.0)
127129 -- `Data.Semigroup` and `Control.Monad.Fail` and `Control.Monad.IO.Class` are available in base only since GHC 8.0 / base 4.9
128130 build-depends:
129− semigroups >= 0.18.5 && < 0.20,
131+ semigroups >= 0.18.5 && < 0.19,
130132 transformers >= 0.3.0.0 && < 0.6,
131133 transformers-compat >= 0.6.2 && < 0.7,
132134 fail == 4.9.*
@@ -142,15 +144,16 @@ library
142144
143145 -- not in LTS-12.10
144146 tagged >= 0.8.5 && < 0.9,
145− primitive >= 0.6.3.0 && < 0.8
147+ primitive >= 0.6.3.0 && < 0.7
146148
147149 -- Other dependencies
148150 build-depends:
149151 attoparsec >= 0.13.2.2 && < 0.14,
150152 dlist >= 0.8.0.4 && < 0.9,
151− hashable >= 1.2.7.0 && < 1.4,
153+ hashable >= 1.2.7.0 && < 1.3,
152154 scientific >= 0.3.6.2 && < 0.4,
153155 th-abstraction >= 0.2.8.0 && < 0.4,
156+ time-locale-compat >= 0.1.1.5 && < 0.2,
154157 uuid-types >= 1.0.3 && < 1.1,
155158 vector >= 0.12.0.1 && < 0.13
156159
@@ -208,7 +211,7 @@ test-suite tests
208211 UnitTests.NullaryConstructors
209212
210213 build-depends:
211− QuickCheck >= 2.10.0.1 && < 2.14,
214+ QuickCheck >= 2.10.0.1 && < 2.13,
212215 aeson,
213216 integer-logarithms >= 1 && <1.1,
214217 attoparsec,
@@ -219,9 +222,9 @@ test-suite tests
219222 containers,
220223 directory,
221224 dlist,
222− Diff >= 0.4 && < 0.5,
225+ Diff,
223226 filepath,
224− generic-deriving >= 1.10 && < 1.14,
227+ generic-deriving >= 1.10 && < 1.13,
225228 ghc-prim >= 0.2,
226229 hashable >= 1.2.4.0,
227230 scientific,
@@ -233,11 +236,11 @@ test-suite tests
233236 tasty-quickcheck,
234237 text,
235238 time,
236− time-compat,
239+ time-locale-compat,
237240 unordered-containers,
238241 uuid-types,
239242 vector,
240− quickcheck-instances >= 0.3.21 && <0.4
243+ quickcheck-instances >= 0.3.16
241244
242245 if flag(bytestring-builder)
243246 build-depends: bytestring >= 0.9 && < 0.10.4,
@@ -247,7 +250,7 @@ test-suite tests
247250
248251 if !impl(ghc >= 8.0)
249252 build-depends:
250− semigroups >= 0.18.2 && < 0.20,
253+ semigroups >= 0.18.2 && < 0.19,
251254 transformers >= 0.2.2.0,
252255 transformers-compat >= 0.3
253256
attoparsec-iso8601/Data/Attoparsec/Time/Internal.hs+20
@@ -29,8 +29,16 @@ import Data.Time.Clock (diffTimeToPicoseconds)
2929
3030#endif
3131
32+#if MIN_VERSION_base(4,7,0)
33+
3234import Data.Fixed (Pico, Fixed(MkFixed))
3335
36+#else
37+
38+import Data.Fixed (Pico)
39+
40+#endif
41+
3442#if !MIN_VERSION_time(1,6,0)
3543
3644diffTimeToPicoseconds :: DiffTime -> Integer
@@ -38,12 +46,24 @@ diffTimeToPicoseconds = unsafeCoerce
3846
3947#endif
4048
49+#if MIN_VERSION_base(4,7,0)
50+
4151toPico :: Integer -> Pico
4252toPico = MkFixed
4353
4454fromPico :: Pico -> Integer
4555fromPico (MkFixed i) = i
4656
57+#else
58+
59+toPico :: Integer -> Pico
60+toPico = unsafeCoerce
61+
62+fromPico :: Pico -> Integer
63+fromPico = unsafeCoerce
64+
65+#endif
66+
4767-- | Like TimeOfDay, but using a fixed-width integer for seconds.
4868data TimeOfDay64 = TOD {-# UNPACK #-} !Int
4969 {-# UNPACK #-} !Int
attoparsec-iso8601/attoparsec-iso8601.cabal+2−2
@@ -36,8 +36,8 @@ library
3636 Data.Attoparsec.Time
3737 build-depends:
3838 attoparsec >= 0.13.0.1,
39− base >= 4.7 && < 5,
40− base-compat >= 0.9.1 && < 0.12,
39+ base >= 4.5 && < 5,
40+ base-compat >= 0.9.1 && < 0.11,
4141 text >= 1.1.1.0,
4242 time >= 1.1.1.4
4343
benchmarks/AesonEncode.hs+1−1
@@ -7,7 +7,7 @@ module Main (main) where
77import Prelude.Compat
88
99import Control.DeepSeq
10−import Control.Monad (forM_)
10+import Control.Monad
1111import Data.Aeson
1212import Data.Attoparsec.ByteString (IResult(..), parseWith)
1313import Data.Char (isDigit)
benchmarks/Compare/JsonBench.hs+3−4
@@ -20,7 +20,6 @@ import Data.Aeson ((.:))
2020import Data.Monoid ((<>))
2121import Data.Text (Text)
2222import Typed.Common (load)
23−import qualified Control.Monad.Fail as Fail
2423import qualified Data.Aeson as Aeson
2524import qualified Data.BufferBuilder.Json as Json
2625
@@ -69,10 +68,10 @@ instance NFData Gender where rnf !_ = ()
6968instance NFData Fruit where rnf !_ = ()
7069
7170instance NFData Friend where
72− rnf Friend {..} = rnf fId `seq` rnf fName
71+ rnf Friend {..} = rnf fId `seq` rnf fName `seq` ()
7372
7473instance NFData User where
75− rnf User {..} = rnf uId `seq` rnf uIndex `seq` rnf uGuid `seq` rnf uIsActive `seq` rnf uBalance `seq` rnf uPicture `seq` rnf uAge `seq` rnf uEyeColor `seq` rnf uName `seq` rnf uGender `seq` rnf uCompany `seq` rnf uEmail `seq` rnf uPhone `seq` rnf uAddress `seq` rnf uAbout `seq` rnf uRegistered `seq` rnf uLatitude `seq` rnf uLongitude `seq` rnf uTags `seq` rnf uFriends `seq` rnf uGreeting `seq` rnf uFavouriteFruit
74+ rnf User {..} = rnf uId `seq` rnf uIndex `seq` rnf uGuid `seq` rnf uIsActive `seq` rnf uBalance `seq` rnf uPicture `seq` rnf uAge `seq` rnf uEyeColor `seq` rnf uName `seq` rnf uGender `seq` rnf uCompany `seq` rnf uEmail `seq` rnf uPhone `seq` rnf uAddress `seq` rnf uAbout `seq` rnf uRegistered `seq` rnf uLatitude `seq` rnf uLongitude `seq` rnf uTags `seq` rnf uFriends `seq` rnf uGreeting `seq` rnf uFavouriteFruit `seq` ()
7675
7776eyeColorTable :: [(Text, EyeColor)]
7877eyeColorTable = [("brown", Brown), ("green", Green), ("blue", Blue)]
@@ -83,7 +82,7 @@ genderTable = [("male", Male), ("female", Female)]
8382fruitTable :: [(Text, Fruit)]
8483fruitTable = [("apple", Apple), ("strawberry", Strawberry), ("banana", Banana)]
8584
86−enumFromJson :: Fail.MonadFail m => String -> [(Text, enum)] -> (json -> m Text) -> json -> m enum
85+enumFromJson :: Monad m => String -> [(Text, enum)] -> (json -> m Text) -> json -> m enum
8786enumFromJson enumName table extract v = do
8887 s <- extract v
8988 case lookup s table of
benchmarks/CompareWithJSON.hs+1−1
@@ -27,7 +27,7 @@ instance (NFData v) => NFData (J.JSObject v) where
2727instance NFData J.JSValue where
2828 rnf J.JSNull = ()
2929 rnf (J.JSBool b) = rnf b
30− rnf (J.JSRational a b) = rnf a `seq` rnf b
30+ rnf (J.JSRational a b) = rnf a `seq` rnf b `seq` ()
3131 rnf (J.JSString s) = rnf (J.fromJSString s)
3232 rnf (J.JSArray lst) = rnf lst
3333 rnf (J.JSObject o) = rnf o
benchmarks/Issue673.hs−1
@@ -18,7 +18,6 @@ import Criterion.Main
1818import Prelude.Compat
1919import Data.Int (Int64)
2020import Data.Scientific (Scientific)
21−import Data.Semigroup ((<>))
2221import Data.Aeson.Parser (scientific)
2322
2423import qualified Data.Attoparsec.ByteString.Lazy as AttoL
benchmarks/JsonParse.hs+1−1
@@ -17,7 +17,7 @@ import Text.JSON
1717instance NFData JSValue where
1818 rnf JSNull = ()
1919 rnf (JSBool b) = rnf b
20− rnf (JSRational b r) = rnf b `seq` rnf r
20+ rnf (JSRational b r) = rnf b `seq` rnf r `seq` ()
2121 rnf (JSString s) = rnf (fromJSString s)
2222 rnf (JSArray vs) = rnf vs
2323 rnf (JSObject kvs) = rnf (fromJSObject kvs)
benchmarks/aeson-benchmarks.cabal+28−32
@@ -28,42 +28,44 @@ library
2828 hs-source-dirs: .. ../ffi ../pure ../attoparsec-iso8601
2929 c-sources: ../cbits/unescape_string.c
3030 build-depends:
31− attoparsec,
32− base,
33− base-compat,
31+ attoparsec >= 0.13.0.1,
32+ base == 4.*,
33+ base-compat >= 0.9.1 && <0.11,
34+ time-locale-compat >=0.1.1 && <0.2,
3435 containers,
3536 deepseq,
36− dlist,
37− fail,
38− ghc-prim,
39− hashable,
37+ dlist >= 0.2,
38+ fail == 4.9.*,
39+ ghc-prim >= 0.2,
40+ hashable >= 1.1.2.0,
4041 mtl,
41− primitive,
42− scientific,
42+ primitive >= 0.6.1,
43+ scientific >= 0.3.4.7 && < 0.4,
4344 syb,
44− tagged,
45− template-haskell,
46− text,
47− th-abstraction,
48− time-compat,
45+ tagged >=0.8.3 && <0.9,
46+ template-haskell >= 2.4,
47+ text >= 1.2.3,
48+ th-abstraction >= 0.2.2 && < 0.4,
4949 time,
5050 transformers,
51− unordered-containers,
52− uuid-types,
53− vector
51+ unordered-containers >= 0.2.3.0,
52+ uuid-types >= 1.0.3 && <1.1,
53+ vector >= 0.7.1
5454
55− if !impl(ghc >= 8.6)
56− build-depends: contravariant
55+ if !impl(ghc >= 7.10)
56+ -- `Numeric.Natural` is available in base only since GHC 7.10 / base 4.8
57+ build-depends: nats >= 1 && < 1.2
58+
59+ if impl(ghc >=7.8)
60+ cpp-options: -DHAS_COERCIBLE
5761
5862 if !impl(ghc >= 8.0)
5963 -- `Data.Semigroup` is available in base only since GHC 8.0 / base 4.9
60− build-depends: semigroups,
61− transformers-compat
64+ build-depends: semigroups >= 0.18.2 && < 0.19
6265
63− if !impl(ghc >= 7.10)
64− -- `Numeric.Natural` is available in base only since GHC 7.10 / base 4.8
65− build-depends: nats,
66− void
66+ if !impl(ghc >= 8.6)
67+ build-depends:
68+ contravariant >=1.4.1 && <1.6
6769
6870 include-dirs: ../include
6971
@@ -72,6 +74,7 @@ library
7274
7375 exposed-modules:
7476 Data.Aeson
77+ Data.Aeson.Compat
7578 Data.Aeson.Encoding
7679 Data.Aeson.Encoding.Builder
7780 Data.Aeson.Encoding.Internal
@@ -175,9 +178,6 @@ executable aeson-benchmark-compare
175178 Compare.JsonBuilder
176179 build-depends:
177180 json-builder
178− if impl(ghc < 8.0)
179− build-depends:
180− semigroups
181181
182182executable aeson-benchmark-micro
183183 default-language: Haskell2010
@@ -224,8 +224,6 @@ executable aeson-benchmark-typed
224224 bytestring-builder >= 0.10.4 && < 1
225225 else
226226 build-depends: bytestring >= 0.10.4
227− if impl(ghc < 8.0)
228− build-depends: semigroups
229227
230228executable aeson-benchmark-compare-with-json
231229 default-language: Haskell2010
@@ -341,5 +339,3 @@ executable aeson-issue-673
341339 scientific,
342340 base-compat,
343341 criterion >= 1.0
344− if impl(ghc < 8.0)
345− build-depends: semigroups
cabal.project+1−4
@@ -1,5 +1,2 @@
11with-compiler: ghc
2−packages: .
3−packages: attoparsec-iso8601
4−-- packages: benchmarks
5−tests: true
2+packages: ., attoparsec-iso8601, benchmarks
changelog.md+3−69
@@ -1,74 +1,8 @@
11For the latest version of this document, please see [https://github.com/bos/aeson/blob/master/changelog.md](https://github.com/bos/aeson/blob/master/changelog.md).
22
3−### upcoming
4−
5−* `FromJSON` instance of `Ratio a` now parses numbers in addtion to
6− standard `{numerator=..., denumerator=...}` encoding.
7−
8−### 1.4.6.0
9−
10−* Provide a clearer error message when a required tagKey for a constructor is missing, thanks to Guru Devanla.
11− The error message now looks like this: `Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found`
12−
13−* Add `formatPath` and `formatRelativePath` functions to turn a `JSONPath` into a `String`, thanks to Robbie McMichael
14−
15−
16−### 1.4.5.0
17−
18−* Expose `(<?>)`, `JSONPath` and `JSONPathElement(..)` from `Data.Aeson.Types`. Previously only available through internal modules. Thanks to Luke Clifton.
19−
20−* Support for base-compat 0.11, thanks to Ryan Scott.
21−
22−* Travis build for GHC 8.8, thanks to Oleg Grenrus.
23−
24−### 1.4.4.0
25−
26−**New features**:
27−
28−* Adds a parameterized parser `jsonWith` that can be used to choose how to handle duplicate keys in objects, thanks to Xia Li-Yao.
29−
30−* Add generic implementations of `FromJSONKey` and `ToJSONKey`, thanks to Xia Li-Yao. Example:
31−
32−```haskell
33−data Foo = Bar
34− deriving Generic
35−
36−opts :: JSONKeyOptions
37−opts = defaultJSONKeyOptions { keyModifier = toLower }
38−
39−instance ToJSONKey Foo where
40− toJSONKey = genericToJSONKey opts
41−
42−instance FromJSONKey Foo where
43− fromJSONKey = genericFromJSONKey opts
44−```
45−
46−**Minor**:
47−* aeson now uses `time-compat` instead of `time-locale-compat`, thanks to Oleg Grenrus.
48−* Prepare for `MonadFail` breakages in GHC 8.8, thanks to Oleg Grenrus.
49−* Require `bytestring >= 0.10.8.1` for newer GHCs to avoid build failures, thanks to Oleg Grenrus.
50−* Support `primitive 0.7.*`, thanks to Adam Bergmark.
51−* Allow `semigroups 0.19.*` and `hashable 1.3.*`, thanks to Oleg Grenrus.
52−* Fix a typo in the error message when parsing `NonEmpty`, thanks to Colin Woodbury.
53−* Document surprising behavior when using `omitNothingFields` with type variables, thanks to Xia Li-Yao.
54−
55−**Internal changes**:
56−* Code cleanup by Oleg Grenrus
57−* Fix dependencies of the benchmarks on older GHC's, thanks to Xia Li-Yao.
58−
59−### 1.4.3.0
60−* Improve error messages for FromJSON in existing instances and GHC Generic implementation. Thanks to Xia Li-Yao & Igor Pashev.
61−* Tweak error-reporting combinators and their documentation. Thanks to Xia Li-Yao.
62− * `typeMismatch` is now about comparing JSON types (i.e., the expected and actual names of the Value constructor).
63− * `withObject` and other `with*` combinators now also mention the JSON types they expect
64− * New `unexpected` and `prependFailure` combinators.
65−* Add `Contravariant` `ToJSONKeyFunction` instance. Thanks to Oleg Grenrus.
66−* Add `KeyValue` instance for `Object`. Thanks to Robert Hensing.
67−* Improve performance when parsing certain large numbers, thanks to Oleg Grenrus.
68−* Add `Data.Aeson.QQ.Simple` - A limited version of aeson-qq. Thanks to Oleg Grenrus.
69−* Exposes internal helper functions like `<?>`, `JSONPath`, and `parseIndexedJSON` from `Data.Aeson` module. Thanks to Abid Uzair.
70−* Better error messages when there are syntax errors parsing objects and arrays. Thanks to Fintan Halpenny.
71−* Support building with `th-abstraction-0.3.0.0` or later. Thanks to Ryan Scott.
3+## Upcoming
4+* Exposes internal helper functions like `<?>`, `JSONPath`, and `parseIndexedJSON` from `Data.Aeson` module. Does not include any breaking changes.
5+* Support building with `th-abstraction-0.3.0.0` or later.
726
737### 1.4.2.0
748
run-hlint.shdeleted−7
@@ -1,7 +0,0 @@
1−#!/bin/bash
2−
3−if hash hlint 2>/dev/null; then
4− hlint "$@"
5−else
6− ./hlint.sh "$@"
7−fi
stack-bench.yaml+1−2
@@ -1,4 +1,4 @@
1−resolver: nightly-2019-09-21
1+resolver: lts-12.10
22# We use aeson in the snapshot to
33# - avoid recompilation of criterion
44# - compare against it
@@ -9,4 +9,3 @@ resolver: nightly-2019-09-21
99work-dir: .stack-work-bench
1010packages:
1111- benchmarks
12−extra-deps: []
stack-ffi-unescape.yaml+2−2
@@ -1,4 +1,4 @@
1−resolver: nightly-2019-09-21
1+resolver: lts-12.10
22packages:
33- '.'
44flags:
@@ -6,4 +6,4 @@ flags:
66 fast: true
77 cffi: true
88extra-deps:
9−- Diff-0.4.0
9+- hashable-time-0.2.0.1
stack-lts12.yaml+1−6
@@ -1,4 +1,4 @@
1−resolver: lts-12.26
1+resolver: lts-12.10
22packages:
33- '.'
44- attoparsec-iso8601
@@ -7,9 +7,4 @@ flags:
77 fast: true
88 cffi: true
99extra-deps:
10−- base-orphans-0.8.1
1110- hashable-time-0.2.0.1
12−- QuickCheck-2.13.1
13−- quickcheck-instances-0.3.21
14−- splitmix-0.0.2
15−- time-compat-1.9.2.2
stack-nightly.yaml+1−3
@@ -1,4 +1,4 @@
1−resolver: nightly-2019-10-14
1+resolver: nightly-2018-09-26
22packages:
33- '.'
44- attoparsec-iso8601
@@ -7,5 +7,3 @@ flags:
77 fast: true
88 attoparsec-iso8601:
99 fast: true
10−extra-deps:
11−- generic-deriving-1.12.4
tests/Encoders.hs+6−38
@@ -6,7 +6,6 @@
66module Encoders (module Encoders) where
77
88import Prelude.Compat
9−import Data.Text (Text)
109
1110import Data.Aeson.TH
1211import Data.Aeson.Types
@@ -97,18 +96,6 @@ gNullaryToEncodingObjectWithSingleField = genericToEncoding optsObjectWithSingle
9796gNullaryParseJSONObjectWithSingleField :: Value -> Parser Nullary
9897gNullaryParseJSONObjectWithSingleField = genericParseJSON optsObjectWithSingleField
9998
100−keyOptions :: JSONKeyOptions
101−keyOptions = defaultJSONKeyOptions { keyModifier = ('k' :) }
102−
103−gNullaryToJSONKey :: Nullary -> Either String Text
104−gNullaryToJSONKey x = case genericToJSONKey keyOptions of
105− ToJSONKeyText p _ -> Right (p x)
106− _ -> Left "Should be a ToJSONKeyText"
107−
108−gNullaryFromJSONKey :: Text -> Parser Nullary
109−gNullaryFromJSONKey t = case genericFromJSONKey keyOptions of
110− FromJSONKeyTextParser p -> p t
111− _ -> fail "Not a TextParser"
11299
113100--------------------------------------------------------------------------------
114101-- SomeType encoders/decoders
@@ -188,6 +175,7 @@ gSomeTypeToEncoding2ElemArray = genericToEncoding opts2ElemArray
188175gSomeTypeParseJSON2ElemArray :: Value -> Parser (SomeType Int)
189176gSomeTypeParseJSON2ElemArray = genericParseJSON opts2ElemArray
190177
178+#if __GLASGOW_HASKELL__ >= 706
191179gSomeTypeLiftToEncoding2ElemArray :: LiftToEncoding SomeType a
192180gSomeTypeLiftToEncoding2ElemArray = genericLiftToEncoding opts2ElemArray
193181
@@ -196,6 +184,7 @@ gSomeTypeLiftToJSON2ElemArray = genericLiftToJSON opts2ElemArray
196184
197185gSomeTypeLiftParseJSON2ElemArray :: LiftParseJSON SomeType a
198186gSomeTypeLiftParseJSON2ElemArray = genericLiftParseJSON opts2ElemArray
187+#endif
199188
200189
201190gSomeTypeToJSONTaggedObject :: SomeType Int -> Value
@@ -207,6 +196,7 @@ gSomeTypeToEncodingTaggedObject = genericToEncoding optsTaggedObject
207196gSomeTypeParseJSONTaggedObject :: Value -> Parser (SomeType Int)
208197gSomeTypeParseJSONTaggedObject = genericParseJSON optsTaggedObject
209198
199+#if __GLASGOW_HASKELL__ >= 706
210200gSomeTypeLiftToEncodingTaggedObject :: LiftToEncoding SomeType a
211201gSomeTypeLiftToEncodingTaggedObject = genericLiftToEncoding optsTaggedObject
212202
@@ -215,6 +205,7 @@ gSomeTypeLiftToJSONTaggedObject = genericLiftToJSON optsTaggedObject
215205
216206gSomeTypeLiftParseJSONTaggedObject :: LiftParseJSON SomeType a
217207gSomeTypeLiftParseJSONTaggedObject = genericLiftParseJSON optsTaggedObject
208+#endif
218209
219210
220211gSomeTypeToJSONObjectWithSingleField :: SomeType Int -> Value
@@ -226,6 +217,7 @@ gSomeTypeToEncodingObjectWithSingleField = genericToEncoding optsObjectWithSingl
226217gSomeTypeParseJSONObjectWithSingleField :: Value -> Parser (SomeType Int)
227218gSomeTypeParseJSONObjectWithSingleField = genericParseJSON optsObjectWithSingleField
228219
220+#if __GLASGOW_HASKELL__ >= 706
229221gSomeTypeLiftToEncodingObjectWithSingleField :: LiftToEncoding SomeType a
230222gSomeTypeLiftToEncodingObjectWithSingleField = genericLiftToEncoding optsObjectWithSingleField
231223
@@ -234,6 +226,7 @@ gSomeTypeLiftToJSONObjectWithSingleField = genericLiftToJSON optsObjectWithSingl
234226
235227gSomeTypeLiftParseJSONObjectWithSingleField :: LiftParseJSON SomeType a
236228gSomeTypeLiftParseJSONObjectWithSingleField = genericLiftParseJSON optsObjectWithSingleField
229+#endif
237230
238231
239232gSomeTypeToJSONOmitNothingFields :: SomeType Int -> Value
@@ -243,31 +236,6 @@ gSomeTypeToEncodingOmitNothingFields :: SomeType Int -> Encoding
243236gSomeTypeToEncodingOmitNothingFields = genericToEncoding optsOmitNothingFields
244237
245238
246−thSomeTypeParseJSONRejectUnknownFields :: Value -> Parser (SomeType Int)
247−thSomeTypeParseJSONRejectUnknownFields = $(mkParseJSON optsRejectUnknownFields ''SomeType)
248−
249−gSomeTypeParseJSONRejectUnknownFields :: Value -> Parser (SomeType Int)
250−gSomeTypeParseJSONRejectUnknownFields = genericParseJSON optsRejectUnknownFields
251−
252−
253−--------------------------------------------------------------------------------
254−-- Foo decoders
255−--------------------------------------------------------------------------------
256−
257−thFooParseJSONRejectUnknownFields :: Value -> Parser Foo
258−thFooParseJSONRejectUnknownFields = $(mkParseJSON optsRejectUnknownFields ''Foo)
259−
260−gFooParseJSONRejectUnknownFields :: Value -> Parser Foo
261−gFooParseJSONRejectUnknownFields = genericParseJSON optsRejectUnknownFields
262−
263−
264−thFooParseJSONRejectUnknownFieldsTagged :: Value -> Parser Foo
265−thFooParseJSONRejectUnknownFieldsTagged = $(mkParseJSON optsRejectUnknownFieldsTagged ''Foo)
266−
267−gFooParseJSONRejectUnknownFieldsTagged :: Value -> Parser Foo
268−gFooParseJSONRejectUnknownFieldsTagged = genericParseJSON optsRejectUnknownFieldsTagged
269−
270−
271239--------------------------------------------------------------------------------
272240-- Option fields
273241--------------------------------------------------------------------------------
tests/ErrorMessages.hs+1−27
@@ -13,7 +13,7 @@ import Data.Aeson (FromJSON(..), Value, json)
1313import Data.Aeson.Types (Parser)
1414import Data.Aeson.Parser (eitherDecodeWith)
1515import Data.Aeson.Internal (formatError, iparse)
16−import Data.Algorithm.Diff (PolyDiff (..), getGroupedDiff)
16+import Data.Algorithm.Diff (Diff(..), getGroupedDiff)
1717import Data.Proxy (Proxy(..))
1818import Data.Semigroup ((<>))
1919import Data.Sequence (Seq)
@@ -136,29 +136,6 @@ outputGeneric choice = concat
136136 , "[1,"
137137 ]
138138
139− , testWithSomeType "SomeType (reject unknown fields)"
140− (select
141− thSomeTypeParseJSONRejectUnknownFields
142− gSomeTypeParseJSONRejectUnknownFields)
143− [ "{\"tag\": \"record\", \"testOne\": 1.0, \"testZero\": 1}"
144− , "{\"testZero\": 1}"
145− , "{\"tag\": \"record\", \"testone\": true, \"testtwo\": null, \"testthree\": null}"
146− ]
147−
148− , testWithFoo "Foo (reject unknown fields)"
149− (select
150− thFooParseJSONRejectUnknownFields
151− gFooParseJSONRejectUnknownFields)
152− [ "{\"tag\": \"foo\"}"
153− ]
154−
155− , testWithFoo "Foo (reject unknown fields, tagged single)"
156− (select
157− thFooParseJSONRejectUnknownFieldsTagged
158− gFooParseJSONRejectUnknownFieldsTagged)
159− [ "{\"tag\": \"foo\", \"unknownField\": 0}"
160− ]
161−
162139 , testWith "EitherTextInt"
163140 (select
164141 thEitherTextIntParseJSONUntaggedValue
@@ -219,6 +196,3 @@ testFor name _ = testWith name (parseJSON :: Value -> Parser a)
219196
220197testWithSomeType :: String -> (Value -> Parser (SomeType Int)) -> [L.ByteString] -> Output
221198testWithSomeType = testWith
222−
223−testWithFoo :: String -> (Value -> Parser Foo) -> [L.ByteString] -> Output
224−testWithFoo = testWith
tests/Instances.hs+4−1
@@ -1,3 +1,4 @@
1+{-# LANGUAGE CPP #-}
12{-# LANGUAGE FlexibleContexts #-}
23{-# LANGUAGE FlexibleInstances #-}
34{-# LANGUAGE NoImplicitPrelude #-}
@@ -24,12 +25,14 @@ import qualified Data.HashMap.Strict as HM
2425
2526import Data.Orphans ()
2627import Test.QuickCheck.Instances ()
28+#if MIN_VERSION_base(4,7,0)
2729import Data.Hashable.Time ()
30+#endif
2831
2932-- "System" types.
3033
3134instance Arbitrary DotNetTime where
32− arbitrary = DotNetTime `fmap` arbitrary
35+ arbitrary = DotNetTime `liftM` arbitrary
3336 shrink = map DotNetTime . shrink . fromDotNetTime
3437
3538-- | Compare timezone part only on 'timeZoneMinutes'
tests/Options.hs−11
@@ -55,14 +55,3 @@ optsOptionField = optsDefault
5555 { fieldLabelModifier = const "field"
5656 , omitNothingFields = True
5757 }
58−
59−optsRejectUnknownFields :: Options
60−optsRejectUnknownFields = optsDefault
61− { rejectUnknownFields = True
62− }
63−
64−optsRejectUnknownFieldsTagged :: Options
65−optsRejectUnknownFieldsTagged = optsDefault
66− { rejectUnknownFields = True
67− , tagSingleConstructors = True
68− }
tests/PropertyGeneric.hs+8
@@ -44,9 +44,11 @@ genericTests =
4444 , testProperty "TaggedObject" (toParseJSON gSomeTypeParseJSONTaggedObject gSomeTypeToJSONTaggedObject)
4545 , testProperty "ObjectWithSingleField" (toParseJSON gSomeTypeParseJSONObjectWithSingleField gSomeTypeToJSONObjectWithSingleField)
4646
47+#if __GLASGOW_HASKELL__ >= 706
4748 , testProperty "2ElemArray unary" (toParseJSON1 gSomeTypeLiftParseJSON2ElemArray gSomeTypeLiftToJSON2ElemArray)
4849 , testProperty "TaggedObject unary" (toParseJSON1 gSomeTypeLiftParseJSONTaggedObject gSomeTypeLiftToJSONTaggedObject)
4950 , testProperty "ObjectWithSingleField unary" (toParseJSON1 gSomeTypeLiftParseJSONObjectWithSingleField gSomeTypeLiftToJSONObjectWithSingleField)
51+#endif
5052 ]
5153 ]
5254 , testGroup "OneConstructor" [
@@ -83,24 +85,30 @@ genericTests =
8385
8486 , testProperty "SomeType2ElemArray" $
8587 gSomeTypeToJSON2ElemArray `sameAs` gSomeTypeToEncoding2ElemArray
88+#if __GLASGOW_HASKELL__ >= 706
8689 , testProperty "SomeType2ElemArray unary" $
8790 gSomeTypeLiftToJSON2ElemArray `sameAs1` gSomeTypeLiftToEncoding2ElemArray
8891 , testProperty "SomeType2ElemArray unary agree" $
8992 gSomeTypeToEncoding2ElemArray `sameAs1Agree` gSomeTypeLiftToEncoding2ElemArray
93+#endif
9094
9195 , testProperty "SomeTypeTaggedObject" $
9296 gSomeTypeToJSONTaggedObject `sameAs` gSomeTypeToEncodingTaggedObject
97+#if __GLASGOW_HASKELL__ >= 706
9398 , testProperty "SomeTypeTaggedObject unary" $
9499 gSomeTypeLiftToJSONTaggedObject `sameAs1` gSomeTypeLiftToEncodingTaggedObject
95100 , testProperty "SomeTypeTaggedObject unary agree" $
96101 gSomeTypeToEncodingTaggedObject `sameAs1Agree` gSomeTypeLiftToEncodingTaggedObject
102+#endif
97103
98104 , testProperty "SomeTypeObjectWithSingleField" $
99105 gSomeTypeToJSONObjectWithSingleField `sameAs` gSomeTypeToEncodingObjectWithSingleField
106+#if __GLASGOW_HASKELL__ >= 706
100107 , testProperty "SomeTypeObjectWithSingleField unary" $
101108 gSomeTypeLiftToJSONObjectWithSingleField `sameAs1` gSomeTypeLiftToEncodingObjectWithSingleField
102109 , testProperty "SomeTypeObjectWithSingleField unary agree" $
103110 gSomeTypeToEncodingObjectWithSingleField `sameAs1Agree` gSomeTypeLiftToEncodingObjectWithSingleField
111+#endif
104112
105113 , testProperty "SomeTypeOmitNothingFields" $
106114 gSomeTypeToJSONOmitNothingFields `sameAs` gSomeTypeToEncodingOmitNothingFields
tests/PropertyKeys.hs+3
@@ -1,3 +1,4 @@
1+{-# LANGUAGE CPP #-}
12{-# LANGUAGE NoImplicitPrelude #-}
23
34module PropertyKeys ( keysTests ) where
@@ -30,10 +31,12 @@ keysTests =
3031 , testProperty "Natural" $ roundTripKey (undefined :: Natural)
3132 , testProperty "Float" $ roundTripKey (undefined :: Float)
3233 , testProperty "Double" $ roundTripKey (undefined :: Double)
34+#if MIN_VERSION_base(4,7,0)
3335 , testProperty "Day" $ roundTripKey (undefined :: Day)
3436 , testProperty "LocalTime" $ roundTripKey (undefined :: LocalTime)
3537 , testProperty "TimeOfDay" $ roundTripKey (undefined :: TimeOfDay)
3638 , testProperty "UTCTime" $ roundTripKey (undefined :: UTCTime)
39+#endif
3740 , testProperty "Version" $ roundTripKey (undefined :: Version)
3841 , testProperty "Lazy Text" $ roundTripKey (undefined :: LT.Text)
3942 , testProperty "UUID" $ roundTripKey UUID.nil
tests/PropertyRoundTrip.hs−7
@@ -14,9 +14,6 @@ import Data.Sequence (Seq)
1414import Data.Tagged (Tagged)
1515import Data.Time (Day, DiffTime, LocalTime, NominalDiffTime, TimeOfDay, UTCTime, ZonedTime)
1616import Data.Version (Version)
17−import Data.Time.Calendar.Compat (CalendarDiffDays, DayOfWeek)
18−import Data.Time.LocalTime.Compat (CalendarDiffTime)
19−import Data.Time.Clock.System.Compat (SystemTime)
2017import Instances ()
2118import Numeric.Natural (Natural)
2219import Test.Tasty (TestTree, testGroup)
@@ -50,10 +47,6 @@ roundTripTests =
5047 , testProperty "ZonedTime" $ roundTripEq (undefined :: ZonedTime)
5148 , testProperty "NominalDiffTime" $ roundTripEq (undefined :: NominalDiffTime)
5249 , testProperty "DiffTime" $ roundTripEq (undefined :: DiffTime)
53− , testProperty "DayOfWeek" $ roundTripEq (undefined :: DayOfWeek)
54− , testProperty "SystemTime" $ roundTripEq (undefined :: SystemTime)
55− , testProperty "CalendarDiffTime" $ roundTripEq (undefined :: CalendarDiffTime)
56− , testProperty "CalendarDiffDays" $ roundTripEq (undefined :: CalendarDiffDays)
5750 , testProperty "Version" $ roundTripEq (undefined :: Version)
5851 , testProperty "Natural" $ roundTripEq (undefined :: Natural)
5952 , testProperty "Proxy" $ roundTripEq (undefined :: Proxy Int)
tests/SerializationFormatSpec.hs+23−47
@@ -3,7 +3,9 @@
33{-# LANGUAGE GADTs #-}
44{-# LANGUAGE NoImplicitPrelude #-}
55{-# LANGUAGE OverloadedStrings #-}
6+#if __GLASGOW_HASKELL__ >= 708
67{-# LANGUAGE DataKinds #-}
8+#endif
79
810------------------------------------------------------------------------------
911-- These tests assert that the JSON serialization doesn't change by accident.
@@ -30,9 +32,6 @@ import Data.Proxy (Proxy(..))
3032import Data.Scientific (Scientific)
3133import Data.Tagged (Tagged(..))
3234import Data.Time (fromGregorian)
33−import Data.Time.Calendar.Compat (CalendarDiffDays (..), DayOfWeek (..))
34−import Data.Time.LocalTime.Compat (CalendarDiffTime (..))
35−import Data.Time.Clock.System.Compat (SystemTime (..))
3635import Data.Word (Word8)
3736import GHC.Generics (Generic)
3837import Instances ()
@@ -69,14 +68,13 @@ jsonExamples =
6968 example "Either Left" "{\"Left\":1}" (Left 1 :: Either Int Int)
7069 , example "Either Right" "{\"Right\":1}" (Right 1 :: Either Int Int)
7170 , example "Nothing" "null" (Nothing :: Maybe Int)
72− -- Maybe serialising is lossy
73− -- https://github.com/bos/aeson/issues/376
74− , Example "Just Nothing" ["null"] (Just Nothing :: Maybe (Maybe Int)) Nothing
7571 , example "Just" "1" (Just 1 :: Maybe Int)
7672 , example "Proxy Int" "null" (Proxy :: Proxy Int)
7773 , example "Tagged Char Int" "1" (Tagged 1 :: Tagged Char Int)
74+#if __GLASGOW_HASKELL__ >= 708
7875 -- Test Tagged instance is polykinded
7976 , example "Tagged 123 Int" "1" (Tagged 1 :: Tagged 123 Int)
77+#endif
8078 , example "Const Char Int" "\"c\"" (Const 'c' :: Const Char Int)
8179 , example "Tuple" "[1,2]" ((1, 2) :: (Int, Int))
8280 , example "NonEmpty" "[1,2,3]" (1 :| [2, 3] :: NonEmpty Int)
@@ -84,22 +82,22 @@ jsonExamples =
8482 , example "DList" "[1,2,3]" (DList.fromList [1, 2, 3] :: DList.DList Int)
8583 , example "()" "[]" ()
8684
87− , ndExample "HashMap Int Int"
85+ , Example "HashMap Int Int"
8886 [ "{\"0\":1,\"2\":3}", "{\"2\":3,\"0\":1}"]
8987 (HM.fromList [(0,1),(2,3)] :: HM.HashMap Int Int)
90− , ndExample "Map Int Int"
88+ , Example "Map Int Int"
9189 [ "{\"0\":1,\"2\":3}", "{\"2\":3,\"0\":1}"]
9290 (M.fromList [(0,1),(2,3)] :: M.Map Int Int)
93− , ndExample "Map (Tagged Int Int) Int"
91+ , Example "Map (Tagged Int Int) Int"
9492 [ "{\"0\":1,\"2\":3}", "{\"2\":3,\"0\":1}"]
9593 (M.fromList [(Tagged 0,1),(Tagged 2,3)] :: M.Map (Tagged Int Int) Int)
9694 , example "Map [Int] Int"
9795 "[[[0],1],[[2],3]]"
9896 (M.fromList [([0],1),([2],3)] :: M.Map [Int] Int)
99− , ndExample "Map [Char] Int"
97+ , Example "Map [Char] Int"
10098 [ "{\"ab\":1,\"cd\":3}", "{\"cd\":3,\"ab\":1}" ]
10199 (M.fromList [("ab",1),("cd",3)] :: M.Map String Int)
102− , ndExample "Map [I Char] Int"
100+ , Example "Map [I Char] Int"
103101 [ "{\"ab\":1,\"cd\":3}", "{\"cd\":3,\"ab\":1}" ]
104102 (M.fromList [(map pure "ab",1),(map pure "cd",3)] :: M.Map [I Char] Int)
105103
@@ -195,27 +193,16 @@ jsonExamples =
195193 , example "Semigroup.WrappedMonoid Int" "2" (Semigroup.WrapMonoid 2 :: Semigroup.WrappedMonoid Int)
196194 , example "Semigroup.Option Just" "2" (pure 2 :: Semigroup.Option Int)
197195 , example "Semigroup.Option Nothing" "null" (Semigroup.Option (Nothing :: Maybe Bool))
198−
199− -- time 1.9
200− , example "SystemTime" "123.123456789" (MkSystemTime 123 123456789)
201− , Example "SystemTime" ["124.23456789"]
202− (MkSystemTime 123 1234567890)
203− (MkSystemTime 124 234567890)
204− , ndExample "CalendarDiffTime"
205− [ "{\"months\":12,\"time\":456.789}", "{\"time\":456.789,\"months\":12}" ]
206− (CalendarDiffTime 12 456.789)
207− , ndExample "CalendarDiffDays"
208− [ "{\"months\":12,\"days\":20}", "{\"days\":20,\"months\":12}" ]
209− (CalendarDiffDays 12 20)
210− , example "DayOfWeek" "\"monday\"" Monday
211196 ]
212197
213198jsonEncodingExamples :: [Example]
214199jsonEncodingExamples =
215200 [
201+ -- Maybe serialising is lossy
202+ -- https://github.com/bos/aeson/issues/376
203+ example "Just Nothing" "null" (Just Nothing :: Maybe (Maybe Int))
216204 -- infinities cannot be recovered, null is decoded as NaN
217− example "inf :: Double" "null" (Approx $ 1/0 :: Approx Double)
218− , example "-inf :: Double" "null" (Approx $ -1/0 :: Approx Double)
205+ , example "inf :: Double" "null" (Approx $ 1/0 :: Approx Double)
219206 ]
220207
221208jsonDecodingExamples :: [Example]
@@ -237,27 +224,16 @@ jsonDecodingExamples = [
237224 ]
238225
239226data Example where
240− Example
241− :: (Eq a, Show a, ToJSON a, FromJSON a)
242− => String -- name
243− -> [L.ByteString] -- encoded variants
244− -> a -- input
245− -> a -- decoded
246− -> Example -- empty bytestring will fail, any p [] == False
247−
248− MaybeExample
249− :: (Eq a, Show a, FromJSON a)
250− => String -> L.ByteString -> Maybe a -> Example
227+ Example
228+ :: (Eq a, Show a, ToJSON a, FromJSON a)
229+ => String -> [L.ByteString] -> a -> Example -- empty bytestring will fail, any p [] == False
230+ MaybeExample
231+ :: (Eq a, Show a, FromJSON a)
232+ => String -> L.ByteString -> Maybe a -> Example
251233
252234example :: (Eq a, Show a, ToJSON a, FromJSON a)
253235 => String -> L.ByteString -> a -> Example
254−example n bs x = Example n [bs] x x
255−
256−-- | Non-deterministic example, input encodes to some of bytestrings.
257−ndExample :: (Eq a, Show a, ToJSON a, FromJSON a)
258− => String -> [L.ByteString] -> a -> Example
259−ndExample n bss x = Example n bss x x
260−
236+example n bs x = Example n [bs] x
261237
262238data MyEither a b = MyLeft a | MyRight b
263239 deriving (Generic, Show, Eq)
@@ -270,16 +246,16 @@ instance (FromJSON a, FromJSON b) => FromJSON (MyEither a b) where
270246 parseJSON = genericParseJSON defaultOptions { sumEncoding = UntaggedValue }
271247
272248assertJsonExample :: Example -> TestTree
273−assertJsonExample (Example name bss val val') = testCase name $ do
249+assertJsonExample (Example name bss val) = testCase name $ do
274250 assertSomeEqual "encode" bss (encode val)
275251 assertSomeEqual "encode/via value" bss (encode $ toJSON val)
276252 for_ bss $ \bs ->
277− assertEqual "decode" (Just val') (decode bs)
253+ assertEqual "decode" (Just val) (decode bs)
278254assertJsonExample (MaybeExample name bs mval) = testCase name $
279255 assertEqual "decode" mval (decode bs)
280256
281257assertJsonEncodingExample :: Example -> TestTree
282−assertJsonEncodingExample (Example name bss val _) = testCase name $ do
258+assertJsonEncodingExample (Example name bss val) = testCase name $ do
283259 assertSomeEqual "encode" bss (encode val)
284260 assertSomeEqual "encode/via value" bss (encode $ toJSON val)
285261assertJsonEncodingExample (MaybeExample name _ _) = testCase name $
tests/Types.hs+2
@@ -119,7 +119,9 @@ deriving instance Generic (Sum4 a b c d)
119119deriving instance Generic (Approx a)
120120deriving instance Generic Nullary
121121deriving instance Generic (SomeType a)
122+#if __GLASGOW_HASKELL__ >= 706
122123deriving instance Generic1 SomeType
124+#endif
123125deriving instance Generic OptionField
124126deriving instance Generic EitherTextInt
125127
tests/UnitTests.hs+6−164
@@ -29,44 +29,35 @@ import Data.Aeson.Internal (JSONPathElement(..), formatError)
2929import Data.Aeson.QQ.Simple (aesonQQ)
3030import Data.Aeson.TH (deriveJSON, deriveToJSON, deriveToJSON1)
3131import Data.Aeson.Text (encodeToTextBuilder)
32−import Data.Aeson.Parser
33− ( json, jsonLast, jsonAccum, jsonNoDup
34− , json', jsonLast', jsonAccum', jsonNoDup')
35−import Data.Aeson.Types
36− ( Options(..), Result(Success, Error), ToJSON(..)
37− , Value(Array, Bool, Null, Number, Object, String), camelTo, camelTo2
38− , defaultOptions, formatPath, formatRelativePath, omitNothingFields, parse)
39−import Data.Attoparsec.ByteString (Parser, parseOnly)
32+import Data.Aeson.Types (Options(..), Result(Success), ToJSON(..), Value(Null, Object), camelTo, camelTo2, defaultOptions, omitNothingFields, parse)
4033import Data.Char (toUpper)
4134import Data.Either.Compat (isLeft, isRight)
4235import Data.Hashable (hash)
4336import Data.HashMap.Strict (HashMap)
44−import Data.List (sort, isSuffixOf)
37+import Data.List (sort)
4538import Data.Maybe (fromMaybe)
4639import Data.Scientific (Scientific, scientific)
4740import Data.Tagged (Tagged(..))
4841import Data.Text (Text)
4942import Data.Time (UTCTime)
50−import Data.Time.Format.Compat (parseTimeM, defaultTimeLocale)
43+import Data.Time.Format (parseTime)
44+import Data.Time.Locale.Compat (defaultTimeLocale)
5145import GHC.Generics (Generic)
5246import Instances ()
5347import Numeric.Natural (Natural)
5448import System.Directory (getDirectoryContents)
5549import System.FilePath ((</>), takeExtension, takeFileName)
5650import Test.Tasty (TestTree, testGroup)
57−import Test.Tasty.HUnit (Assertion, assertBool, assertFailure, assertEqual, testCase, (@?=))
51+import Test.Tasty.HUnit (Assertion, assertBool, assertFailure, assertEqual, testCase)
5852import Text.Printf (printf)
5953import UnitTests.NullaryConstructors (nullaryConstructors)
60−import qualified Data.ByteString as S
6154import qualified Data.ByteString.Base16.Lazy as LBase16
6255import qualified Data.ByteString.Lazy.Char8 as L
6356import qualified Data.HashSet as HashSet
64−import qualified Data.HashMap.Lazy as HashMap
6557import qualified Data.Text.Lazy as LT
6658import qualified Data.Text.Lazy.Builder as TLB
6759import qualified Data.Text.Lazy.Encoding as LT
6860import qualified Data.Text.Lazy.Encoding as TLE
69−import qualified Data.Vector as Vector
7061import qualified ErrorMessages
7162import qualified SerializationFormatSpec
7263
@@ -112,12 +103,7 @@ tests = testGroup "unit" [
112103 , testGroup "SingleMaybeField" singleMaybeField
113104 , testCase "withEmbeddedJSON" withEmbeddedJSONTest
114105 , testCase "SingleFieldCon" singleFieldCon
115− , testGroup "UnknownFields" unknownFields
116− , testGroup "Ordering of object keys" keyOrdering
117106 , testCase "Ratio with denominator 0" ratioDenominator0
118− , testCase "Rational parses number" rationalNumber
119− , testCase "Big rational" bigRationalDecoding
120− , testCase "Small rational" smallRationalDecoding
121107 , testCase "Big scientific exponent" bigScientificExponent
122108 , testCase "Big integer decoding" bigIntegerDecoding
123109 , testCase "Big natural decading" bigNaturalDecoding
@@ -229,7 +215,7 @@ utcTimeGood = do
229215 where
230216 parseWithRead :: String -> LT.Text -> UTCTime
231217 parseWithRead f s =
232− fromMaybe (error "parseTime input malformed") . parseTimeM True defaultTimeLocale f . LT.unpack $ s
218+ fromMaybe (error "parseTime input malformed") . parseTime defaultTimeLocale f . LT.unpack $ s
233219 parseWithAeson :: LT.Text -> Maybe UTCTime
234220 parseWithAeson s = decode . LT.encodeUtf8 $ LT.concat ["\"", s, "\""]
235221
@@ -258,18 +244,6 @@ formatErrorExample =
258244 lhs = "Error in $[0].foo.bar['a.b.c']['']['\\'\\\\'].end: error msg"
259245 in assertEqual "formatError example" lhs rhs
260246
261−formatPathExample :: Assertion
262−formatPathExample =
263− let rhs = formatPath [Key "x", Index 0]
264− lhs = "$.x[0]"
265− in assertEqual "formatPath example" lhs rhs
266−
267−formatRelativePathExample :: Assertion
268−formatRelativePathExample =
269− let rhs = formatPath [Key "x", Index 0]
270− lhs = ".x[0]"
271− in assertEqual "formatRelativePath example" lhs rhs
272−
273247------------------------------------------------------------------------------
274248-- Comparison (.:?) and (.:!)
275249------------------------------------------------------------------------------
@@ -540,7 +514,6 @@ showOptions =
540514 ++ ", sumEncoding = TaggedObject {tagFieldName = \"tag\", contentsFieldName = \"contents\"}"
541515 ++ ", unwrapUnaryRecords = False"
542516 ++ ", tagSingleConstructors = False"
543− ++ ", rejectUnknownFields = False"
544517 ++ "}")
545518 (show defaultOptions)
546519
@@ -585,138 +558,12 @@ singleFieldCon :: Assertion
585558singleFieldCon =
586559 assertEqual "fromJSON" (Right (SingleFieldCon 0)) (eitherDecode "0")
587560
588−newtype UnknownFields = UnknownFields { knownField :: Int }
589− deriving (Eq, Show, Generic)
590−newtype UnknownFieldsTag = UnknownFieldsTag { tag :: Int }
591− deriving (Eq, Show, Generic)
592−newtype UnknownFieldsUnaryTagged = UnknownFieldsUnaryTagged { knownFieldUnaryTagged :: Int }
593− deriving (Eq, Show, Generic)
594−data UnknownFieldsSum
595− = UnknownFields1 { knownField1 :: Int }
596− | UnknownFields2 { knownField2 :: Int }
597− deriving (Eq, Show, Generic)
598−
599−unknownFields :: [TestTree]
600−unknownFields = concat
601− [ testsUnary
602− "unary-unknown"
603− (object [("knownField", Number 1), ("unknownField", Number 1)])
604− (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFields)
605− , testsUnary
606− "unary-unknown-tag"
607− (object [("knownField", Number 1), ("tag", String "UnknownFields")])
608− (Error "nknown fields: [\"tag\"]" :: Result UnknownFields)
609− , testsUnaryTag
610− "unary-explicit-tag"
611− (object [("tag", Number 1)])
612− (Success $ UnknownFieldsTag 1)
613− , testsSum
614− "sum-tag"
615− (object [("knownField1", Number 1), ("tag", String "UnknownFields1")])
616− (Success $ UnknownFields1 1)
617− , testsSum
618− "sum-unknown-in-branch"
619− (object [("knownField1", Number 1), ("knownField2", Number 1), ("tag", String "UnknownFields1")])
620− (Error "nknown fields: [\"knownField2\"]" :: Result UnknownFieldsSum)
621− , testsSum
622− "sum-unknown"
623− (object [("knownField1", Number 1), ("unknownField", Number 1), ("tag", String "UnknownFields1")])
624− (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFieldsSum)
625− , testsTagged
626− "unary-tagged"
627− (object [("knownFieldUnaryTagged", Number 1), ("tag", String "UnknownFieldsUnaryTagged")])
628− (Success $ UnknownFieldsUnaryTagged 1)
629− , -- Just a case to verify that the tag isn't optional, this is likely already tested by other unit tests
630− testsTagged
631− "unary-tagged-notag"
632− (object [("knownFieldUnaryTagged", Number 1)])
633− (Error "key \"tag\" not found" :: Result UnknownFieldsUnaryTagged)
634− , testsTagged
635− "unary-tagged-unknown"
636− (object [ ("knownFieldUnaryTagged", Number 1), ("unknownField", Number 1)
637− , ("tag", String "UnknownFieldsUnaryTagged")])
638− (Error "nknown fields: [\"unknownField\"]" :: Result UnknownFieldsUnaryTagged)
639− ]
640− where
641− opts = defaultOptions{rejectUnknownFields=True}
642− taggedOpts = opts{tagSingleConstructors=True}
643− assertApprox :: (Show a, Eq a) => Result a -> Result a -> IO ()
644− assertApprox (Error expected) (Error actual) | expected `isSuffixOf` actual = return ()
645− assertApprox expected actual = assertEqual "fromJSON" expected actual
646− testsBase :: (Show a, Eq a) => (Value -> Result a) -> (Value -> Result a)
647− -> String -> Value -> Result a -> [TestTree]
648− testsBase th g name value expected =
649− [ testCase (name ++ "-th") $ assertApprox expected (th value)
650− , testCase (name ++ "-generic") $ assertApprox expected (g value)
651− ]
652− testsUnary :: String -> Value -> Result UnknownFields -> [TestTree]
653− testsUnary = testsBase fromJSON (parse (genericParseJSON opts))
654− testsUnaryTag :: String -> Value -> Result UnknownFieldsTag -> [TestTree]
655− testsUnaryTag = testsBase fromJSON (parse (genericParseJSON opts))
656− testsSum :: String -> Value -> Result UnknownFieldsSum -> [TestTree]
657− testsSum = testsBase fromJSON (parse (genericParseJSON opts))
658− testsTagged :: String -> Value -> Result UnknownFieldsUnaryTagged -> [TestTree]
659− testsTagged = testsBase fromJSON (parse (genericParseJSON taggedOpts))
660−
661−testParser :: (Eq a, Show a)
662− => String -> Parser a -> S.ByteString -> Either String a -> TestTree
663−testParser name json_ s expected =
664− testCase name (parseOnly json_ s @?= expected)
665−
666−keyOrdering :: [TestTree]
667−keyOrdering =
668− [ testParser "json" json
669− "{\"k\":true,\"k\":false}" $
670− Right (Object (HashMap.fromList [("k", Bool True)]))
671− , testParser "jsonLast" jsonLast
672− "{\"k\":true,\"k\":false}" $
673− Right (Object (HashMap.fromList [("k", Bool False)]))
674− , testParser "jsonAccum" jsonAccum
675− "{\"k\":true,\"k\":false}" $
676− Right (Object (HashMap.fromList [("k", Array (Vector.fromList [Bool True, Bool False]))]))
677− , testParser "jsonNoDup" jsonNoDup
678− "{\"k\":true,\"k\":false}" $
679− Left "Failed reading: found duplicate key: \"k\""
680−
681− , testParser "json'" json'
682− "{\"k\":true,\"k\":false}" $
683− Right (Object (HashMap.fromList [("k", Bool True)]))
684− , testParser "jsonLast'" jsonLast'
685− "{\"k\":true,\"k\":false}" $
686− Right (Object (HashMap.fromList [("k", Bool False)]))
687− , testParser "jsonAccum'" jsonAccum'
688− "{\"k\":true,\"k\":false}" $
689− Right (Object (HashMap.fromList [("k", Array (Vector.fromList [Bool True, Bool False]))]))
690− , testParser "jsonNoDup'" jsonNoDup'
691− "{\"k\":true,\"k\":false}" $
692− Left "Failed reading: found duplicate key: \"k\""
693− ]
694−
695561ratioDenominator0 :: Assertion
696562ratioDenominator0 =
697563 assertEqual "Ratio with denominator 0"
698564 (Left "Error in $: Ratio denominator was 0")
699565 (eitherDecode "{ \"numerator\": 1, \"denominator\": 0 }" :: Either String Rational)
700566
701−rationalNumber :: Assertion
702−rationalNumber =
703− assertEqual "Ratio with denominator 0"
704− (Right 1.37)
705− (eitherDecode "1.37" :: Either String Rational)
706−
707−bigRationalDecoding :: Assertion
708−bigRationalDecoding =
709− assertEqual "Decoding an Integer with a large exponent should fail"
710− (Left "Error in $: parsing Ratio failed, found a number with exponent 2000, but it must not be greater than 1024 or less than -1024")
711− ((eitherDecode :: L.ByteString -> Either String Rational) "1e2000")
712−
713−smallRationalDecoding :: Assertion
714−smallRationalDecoding =
715− assertEqual "Decoding an Integer with a large exponent should fail"
716− (Left "Error in $: parsing Ratio failed, found a number with exponent -2000, but it must not be greater than 1024 or less than -1024")
717− ((eitherDecode :: L.ByteString -> Either String Rational) "1e-2000")
718−
719−
720567bigScientificExponent :: Assertion
721568bigScientificExponent =
722569 assertEqual "Encoding an integral scientific with a large exponent should normalize it"
@@ -753,8 +600,3 @@ deriveToJSON defaultOptions ''Foo
753600deriveToJSON1 defaultOptions ''Foo
754601
755602deriveJSON defaultOptions{omitNothingFields=True,unwrapUnaryRecords=True} ''SingleMaybeField
756−
757−deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFields
758−deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFieldsTag
759−deriveJSON defaultOptions{tagSingleConstructors=True,rejectUnknownFields=True} ''UnknownFieldsUnaryTagged
760−deriveJSON defaultOptions{rejectUnknownFields=True} ''UnknownFieldsSum
tests/UnitTests/NullaryConstructors.hs−5
@@ -14,7 +14,6 @@ import Data.Aeson (decode, eitherDecode, fromEncoding, Value)
1414import Data.Aeson.Internal (IResult (..), iparse)
1515import Data.Aeson.Types (Parser)
1616import Data.ByteString.Builder (toLazyByteString)
17−import Data.Foldable (for_)
1817import Data.Maybe (fromJust)
1918import Encoders
2019import Test.Tasty.HUnit ((@=?), Assertion)
@@ -53,10 +52,6 @@ nullaryConstructors =
5352 -- Make sure that the old `"contents" : []' is still allowed
5453 , ISuccess C1 @=? parse thNullaryParseJSONTaggedObject (dec "{\"tag\":\"c1\",\"contents\":[]}")
5554 , ISuccess C1 @=? parse gNullaryParseJSONTaggedObject (dec "{\"tag\":\"c1\",\"contents\":[]}")
56−
57− , for_ [("kC1", C1), ("kC2", C2), ("kC3", C3)] $ \(jkey, key) -> do
58− Right jkey @=? gNullaryToJSONKey key
59− ISuccess key @=? parse gNullaryFromJSONKey jkey
6055 ]
6156 where
6257 enc = eitherDecode . toLazyByteString . fromEncoding
tests/golden/generic.expected+3−11
@@ -6,11 +6,11 @@ Error in $: parsing Types.Nullary failed, expected one of the tags ["C1","C2","C
66Error in $: parsing Types.Nullary failed, expected String, but encountered Array
77SomeType (tagged)
88Error in $.contents: parsing Int failed, expected Number, but encountered Boolean
9−Error in $: parsing Types.SomeType(Unary) failed, key "contents" not found
10−Error in $: parsing Types.SomeType(Record) failed, key "testone" not found
9+Error in $: parsing Types.SomeType(Unary) failed, key "contents" not present
10+Error in $: parsing Types.SomeType(Record) failed, key "testone" not present
1111Error in $.testone: parsing Double failed, unexpected Boolean
1212Error in $.tag: parsing Types.SomeType failed, expected tag field to be one of ["nullary","unary","product","record","list"], but found tag "X"
13−Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found
13+Error in $: parsing Types.SomeType failed, key "tag" not present
1414Error in $: parsing Types.SomeType failed, expected Object, but encountered Array
1515SomeType (single-field)
1616Error in $.unary: parsing Int failed, expected Number, but encountered Object
@@ -31,14 +31,6 @@ Error in $: parsing Types.SomeType failed, expected a 2-element Array, but encou
3131Error in $: parsing Types.SomeType failed, expected Array, but encountered Object
3232Error in $: not enough input. Expecting ',' or ']'
3333Error in $: not enough input. Expecting json list value
34−SomeType (reject unknown fields)
35−Error in $: parsing Types.SomeType(Record) failed, unknown fields: ["testZero"]
36−Error in $: parsing Types.SomeType failed, expected Object with key "tag" containing one of ["nullary","unary","product","record","list"], key "tag" not found
37−Error in $: parsing Types.SomeType(Record) failed, unknown fields: ["testtwo","testone","testthree"]
38−Foo (reject unknown fields)
39−Error in $: parsing Types.Foo(Foo) failed, unknown fields: ["tag"]
40−Foo (reject unknown fields, tagged single)
41−Error in $: parsing Types.Foo(Foo) failed, unknown fields: ["unknownField"]
4234EitherTextInt
4335Error in $: parsing Types.EitherTextInt(NoneNullary) failed, expected tag "nonenullary", but found tag "X"
4436Error in $: parsing Types.EitherTextInt(NoneNullary) failed, expected String, but encountered Array
travis/cabal_macros.hdeleted−448
@@ -1,448 +0,0 @@
1−/* DO NOT EDIT: This file is automatically generated by Cabal */
2−
3−/* package aeson-1.4.4.0 */
4−#ifndef VERSION_aeson
5−#define VERSION_aeson "1.4.4.0"
6−#endif /* VERSION_aeson */
7−#ifndef MIN_VERSION_aeson
8−#define MIN_VERSION_aeson(major1,major2,minor) (\
9− (major1) < 1 || \
10− (major1) == 1 && (major2) < 4 || \
11− (major1) == 1 && (major2) == 4 && (minor) <= 4)
12−#endif /* MIN_VERSION_aeson */
13−
14−/* package Diff-0.3.4 */
15−#ifndef VERSION_Diff
16−#define VERSION_Diff "0.3.4"
17−#endif /* VERSION_Diff */
18−#ifndef MIN_VERSION_Diff
19−#define MIN_VERSION_Diff(major1,major2,minor) (\
20− (major1) < 0 || \
21− (major1) == 0 && (major2) < 3 || \
22− (major1) == 0 && (major2) == 3 && (minor) <= 4)
23−#endif /* MIN_VERSION_Diff */
24−
25−/* package QuickCheck-2.13.1 */
26−#ifndef VERSION_QuickCheck
27−#define VERSION_QuickCheck "2.13.1"
28−#endif /* VERSION_QuickCheck */
29−#ifndef MIN_VERSION_QuickCheck
30−#define MIN_VERSION_QuickCheck(major1,major2,minor) (\
31− (major1) < 2 || \
32− (major1) == 2 && (major2) < 13 || \
33− (major1) == 2 && (major2) == 13 && (minor) <= 1)
34−#endif /* MIN_VERSION_QuickCheck */
35−
36−/* package aeson-1.4.4.0 */
37−#ifndef VERSION_aeson
38−#define VERSION_aeson "1.4.4.0"
39−#endif /* VERSION_aeson */
40−#ifndef MIN_VERSION_aeson
41−#define MIN_VERSION_aeson(major1,major2,minor) (\
42− (major1) < 1 || \
43− (major1) == 1 && (major2) < 4 || \
44− (major1) == 1 && (major2) == 4 && (minor) <= 4)
45−#endif /* MIN_VERSION_aeson */
46−
47−/* package attoparsec-0.13.2.2 */
48−#ifndef VERSION_attoparsec
49−#define VERSION_attoparsec "0.13.2.2"
50−#endif /* VERSION_attoparsec */
51−#ifndef MIN_VERSION_attoparsec
52−#define MIN_VERSION_attoparsec(major1,major2,minor) (\
53− (major1) < 0 || \
54− (major1) == 0 && (major2) < 13 || \
55− (major1) == 0 && (major2) == 13 && (minor) <= 2)
56−#endif /* MIN_VERSION_attoparsec */
57−
58−/* package base-4.12.0.0 */
59−#ifndef VERSION_base
60−#define VERSION_base "4.12.0.0"
61−#endif /* VERSION_base */
62−#ifndef MIN_VERSION_base
63−#define MIN_VERSION_base(major1,major2,minor) (\
64− (major1) < 4 || \
65− (major1) == 4 && (major2) < 12 || \
66− (major1) == 4 && (major2) == 12 && (minor) <= 0)
67−#endif /* MIN_VERSION_base */
68−
69−/* package base-compat-0.10.5 */
70−#ifndef VERSION_base_compat
71−#define VERSION_base_compat "0.10.5"
72−#endif /* VERSION_base_compat */
73−#ifndef MIN_VERSION_base_compat
74−#define MIN_VERSION_base_compat(major1,major2,minor) (\
75− (major1) < 0 || \
76− (major1) == 0 && (major2) < 10 || \
77− (major1) == 0 && (major2) == 10 && (minor) <= 5)
78−#endif /* MIN_VERSION_base_compat */
79−
80−/* package base-orphans-0.8.1 */
81−#ifndef VERSION_base_orphans
82−#define VERSION_base_orphans "0.8.1"
83−#endif /* VERSION_base_orphans */
84−#ifndef MIN_VERSION_base_orphans
85−#define MIN_VERSION_base_orphans(major1,major2,minor) (\
86− (major1) < 0 || \
87− (major1) == 0 && (major2) < 8 || \
88− (major1) == 0 && (major2) == 8 && (minor) <= 1)
89−#endif /* MIN_VERSION_base_orphans */
90−
91−/* package base16-bytestring-0.1.1.6 */
92−#ifndef VERSION_base16_bytestring
93−#define VERSION_base16_bytestring "0.1.1.6"
94−#endif /* VERSION_base16_bytestring */
95−#ifndef MIN_VERSION_base16_bytestring
96−#define MIN_VERSION_base16_bytestring(major1,major2,minor) (\
97− (major1) < 0 || \
98− (major1) == 0 && (major2) < 1 || \
99− (major1) == 0 && (major2) == 1 && (minor) <= 1)
100−#endif /* MIN_VERSION_base16_bytestring */
101−
102−/* package bytestring-0.10.8.2 */
103−#ifndef VERSION_bytestring
104−#define VERSION_bytestring "0.10.8.2"
105−#endif /* VERSION_bytestring */
106−#ifndef MIN_VERSION_bytestring
107−#define MIN_VERSION_bytestring(major1,major2,minor) (\
108− (major1) < 0 || \
109− (major1) == 0 && (major2) < 10 || \
110− (major1) == 0 && (major2) == 10 && (minor) <= 8)
111−#endif /* MIN_VERSION_bytestring */
112−
113−/* package containers-0.6.0.1 */
114−#ifndef VERSION_containers
115−#define VERSION_containers "0.6.0.1"
116−#endif /* VERSION_containers */
117−#ifndef MIN_VERSION_containers
118−#define MIN_VERSION_containers(major1,major2,minor) (\
119− (major1) < 0 || \
120− (major1) == 0 && (major2) < 6 || \
121− (major1) == 0 && (major2) == 6 && (minor) <= 0)
122−#endif /* MIN_VERSION_containers */
123−
124−/* package directory-1.3.3.0 */
125−#ifndef VERSION_directory
126−#define VERSION_directory "1.3.3.0"
127−#endif /* VERSION_directory */
128−#ifndef MIN_VERSION_directory
129−#define MIN_VERSION_directory(major1,major2,minor) (\
130− (major1) < 1 || \
131− (major1) == 1 && (major2) < 3 || \
132− (major1) == 1 && (major2) == 3 && (minor) <= 3)
133−#endif /* MIN_VERSION_directory */
134−
135−/* package dlist-0.8.0.6 */
136−#ifndef VERSION_dlist
137−#define VERSION_dlist "0.8.0.6"
138−#endif /* VERSION_dlist */
139−#ifndef MIN_VERSION_dlist
140−#define MIN_VERSION_dlist(major1,major2,minor) (\
141− (major1) < 0 || \
142− (major1) == 0 && (major2) < 8 || \
143− (major1) == 0 && (major2) == 8 && (minor) <= 0)
144−#endif /* MIN_VERSION_dlist */
145−
146−/* package filepath-1.4.2.1 */
147−#ifndef VERSION_filepath
148−#define VERSION_filepath "1.4.2.1"
149−#endif /* VERSION_filepath */
150−#ifndef MIN_VERSION_filepath
151−#define MIN_VERSION_filepath(major1,major2,minor) (\
152− (major1) < 1 || \
153− (major1) == 1 && (major2) < 4 || \
154− (major1) == 1 && (major2) == 4 && (minor) <= 2)
155−#endif /* MIN_VERSION_filepath */
156−
157−/* package generic-deriving-1.12.4 */
158−#ifndef VERSION_generic_deriving
159−#define VERSION_generic_deriving "1.12.4"
160−#endif /* VERSION_generic_deriving */
161−#ifndef MIN_VERSION_generic_deriving
162−#define MIN_VERSION_generic_deriving(major1,major2,minor) (\
163− (major1) < 1 || \
164− (major1) == 1 && (major2) < 12 || \
165− (major1) == 1 && (major2) == 12 && (minor) <= 4)
166−#endif /* MIN_VERSION_generic_deriving */
167−
168−/* package ghc-prim-0.5.3 */
169−#ifndef VERSION_ghc_prim
170−#define VERSION_ghc_prim "0.5.3"
171−#endif /* VERSION_ghc_prim */
172−#ifndef MIN_VERSION_ghc_prim
173−#define MIN_VERSION_ghc_prim(major1,major2,minor) (\
174− (major1) < 0 || \
175− (major1) == 0 && (major2) < 5 || \
176− (major1) == 0 && (major2) == 5 && (minor) <= 3)
177−#endif /* MIN_VERSION_ghc_prim */
178−
179−/* package hashable-1.3.0.0 */
180−#ifndef VERSION_hashable
181−#define VERSION_hashable "1.3.0.0"
182−#endif /* VERSION_hashable */
183−#ifndef MIN_VERSION_hashable
184−#define MIN_VERSION_hashable(major1,major2,minor) (\
185− (major1) < 1 || \
186− (major1) == 1 && (major2) < 3 || \
187− (major1) == 1 && (major2) == 3 && (minor) <= 0)
188−#endif /* MIN_VERSION_hashable */
189−
190−/* package hashable-time-0.2.0.2 */
191−#ifndef VERSION_hashable_time
192−#define VERSION_hashable_time "0.2.0.2"
193−#endif /* VERSION_hashable_time */
194−#ifndef MIN_VERSION_hashable_time
195−#define MIN_VERSION_hashable_time(major1,major2,minor) (\
196− (major1) < 0 || \
197− (major1) == 0 && (major2) < 2 || \
198− (major1) == 0 && (major2) == 2 && (minor) <= 0)
199−#endif /* MIN_VERSION_hashable_time */
200−
201−/* package integer-logarithms-1.0.3 */
202−#ifndef VERSION_integer_logarithms
203−#define VERSION_integer_logarithms "1.0.3"
204−#endif /* VERSION_integer_logarithms */
205−#ifndef MIN_VERSION_integer_logarithms
206−#define MIN_VERSION_integer_logarithms(major1,major2,minor) (\
207− (major1) < 1 || \
208− (major1) == 1 && (major2) < 0 || \
209− (major1) == 1 && (major2) == 0 && (minor) <= 3)
210−#endif /* MIN_VERSION_integer_logarithms */
211−
212−/* package quickcheck-instances-0.3.21 */
213−#ifndef VERSION_quickcheck_instances
214−#define VERSION_quickcheck_instances "0.3.21"
215−#endif /* VERSION_quickcheck_instances */
216−#ifndef MIN_VERSION_quickcheck_instances
217−#define MIN_VERSION_quickcheck_instances(major1,major2,minor) (\
218− (major1) < 0 || \
219− (major1) == 0 && (major2) < 3 || \
220− (major1) == 0 && (major2) == 3 && (minor) <= 21)
221−#endif /* MIN_VERSION_quickcheck_instances */
222−
223−/* package scientific-0.3.6.2 */
224−#ifndef VERSION_scientific
225−#define VERSION_scientific "0.3.6.2"
226−#endif /* VERSION_scientific */
227−#ifndef MIN_VERSION_scientific
228−#define MIN_VERSION_scientific(major1,major2,minor) (\
229− (major1) < 0 || \
230− (major1) == 0 && (major2) < 3 || \
231− (major1) == 0 && (major2) == 3 && (minor) <= 6)
232−#endif /* MIN_VERSION_scientific */
233−
234−/* package tagged-0.8.6 */
235−#ifndef VERSION_tagged
236−#define VERSION_tagged "0.8.6"
237−#endif /* VERSION_tagged */
238−#ifndef MIN_VERSION_tagged
239−#define MIN_VERSION_tagged(major1,major2,minor) (\
240− (major1) < 0 || \
241− (major1) == 0 && (major2) < 8 || \
242− (major1) == 0 && (major2) == 8 && (minor) <= 6)
243−#endif /* MIN_VERSION_tagged */
244−
245−/* package tasty-1.2.3 */
246−#ifndef VERSION_tasty
247−#define VERSION_tasty "1.2.3"
248−#endif /* VERSION_tasty */
249−#ifndef MIN_VERSION_tasty
250−#define MIN_VERSION_tasty(major1,major2,minor) (\
251− (major1) < 1 || \
252− (major1) == 1 && (major2) < 2 || \
253− (major1) == 1 && (major2) == 2 && (minor) <= 3)
254−#endif /* MIN_VERSION_tasty */
255−
256−/* package tasty-golden-2.3.2 */
257−#ifndef VERSION_tasty_golden
258−#define VERSION_tasty_golden "2.3.2"
259−#endif /* VERSION_tasty_golden */
260−#ifndef MIN_VERSION_tasty_golden
261−#define MIN_VERSION_tasty_golden(major1,major2,minor) (\
262− (major1) < 2 || \
263− (major1) == 2 && (major2) < 3 || \
264− (major1) == 2 && (major2) == 3 && (minor) <= 2)
265−#endif /* MIN_VERSION_tasty_golden */
266−
267−/* package tasty-hunit-0.10.0.2 */
268−#ifndef VERSION_tasty_hunit
269−#define VERSION_tasty_hunit "0.10.0.2"
270−#endif /* VERSION_tasty_hunit */
271−#ifndef MIN_VERSION_tasty_hunit
272−#define MIN_VERSION_tasty_hunit(major1,major2,minor) (\
273− (major1) < 0 || \
274− (major1) == 0 && (major2) < 10 || \
275− (major1) == 0 && (major2) == 10 && (minor) <= 0)
276−#endif /* MIN_VERSION_tasty_hunit */
277−
278−/* package tasty-quickcheck-0.10.1 */
279−#ifndef VERSION_tasty_quickcheck
280−#define VERSION_tasty_quickcheck "0.10.1"
281−#endif /* VERSION_tasty_quickcheck */
282−#ifndef MIN_VERSION_tasty_quickcheck
283−#define MIN_VERSION_tasty_quickcheck(major1,major2,minor) (\
284− (major1) < 0 || \
285− (major1) == 0 && (major2) < 10 || \
286− (major1) == 0 && (major2) == 10 && (minor) <= 1)
287−#endif /* MIN_VERSION_tasty_quickcheck */
288−
289−/* package template-haskell-2.14.0.0 */
290−#ifndef VERSION_template_haskell
291−#define VERSION_template_haskell "2.14.0.0"
292−#endif /* VERSION_template_haskell */
293−#ifndef MIN_VERSION_template_haskell
294−#define MIN_VERSION_template_haskell(major1,major2,minor) (\
295− (major1) < 2 || \
296− (major1) == 2 && (major2) < 14 || \
297− (major1) == 2 && (major2) == 14 && (minor) <= 0)
298−#endif /* MIN_VERSION_template_haskell */
299−
300−/* package text-1.2.3.1 */
301−#ifndef VERSION_text
302−#define VERSION_text "1.2.3.1"
303−#endif /* VERSION_text */
304−#ifndef MIN_VERSION_text
305−#define MIN_VERSION_text(major1,major2,minor) (\
306− (major1) < 1 || \
307− (major1) == 1 && (major2) < 2 || \
308− (major1) == 1 && (major2) == 2 && (minor) <= 3)
309−#endif /* MIN_VERSION_text */
310−
311−/* package time-1.8.0.2 */
312−#ifndef VERSION_time
313−#define VERSION_time "1.8.0.2"
314−#endif /* VERSION_time */
315−#ifndef MIN_VERSION_time
316−#define MIN_VERSION_time(major1,major2,minor) (\
317− (major1) < 1 || \
318− (major1) == 1 && (major2) < 8 || \
319− (major1) == 1 && (major2) == 8 && (minor) <= 0)
320−#endif /* MIN_VERSION_time */
321−
322−/* package time-compat-1.9.2.2 */
323−#ifndef VERSION_time_compat
324−#define VERSION_time_compat "1.9.2.2"
325−#endif /* VERSION_time_compat */
326−#ifndef MIN_VERSION_time_compat
327−#define MIN_VERSION_time_compat(major1,major2,minor) (\
328− (major1) < 1 || \
329− (major1) == 1 && (major2) < 9 || \
330− (major1) == 1 && (major2) == 9 && (minor) <= 2)
331−#endif /* MIN_VERSION_time_compat */
332−
333−/* package unordered-containers-0.2.10.0 */
334−#ifndef VERSION_unordered_containers
335−#define VERSION_unordered_containers "0.2.10.0"
336−#endif /* VERSION_unordered_containers */
337−#ifndef MIN_VERSION_unordered_containers
338−#define MIN_VERSION_unordered_containers(major1,major2,minor) (\
339− (major1) < 0 || \
340− (major1) == 0 && (major2) < 2 || \
341− (major1) == 0 && (major2) == 2 && (minor) <= 10)
342−#endif /* MIN_VERSION_unordered_containers */
343−
344−/* package uuid-types-1.0.3 */
345−#ifndef VERSION_uuid_types
346−#define VERSION_uuid_types "1.0.3"
347−#endif /* VERSION_uuid_types */
348−#ifndef MIN_VERSION_uuid_types
349−#define MIN_VERSION_uuid_types(major1,major2,minor) (\
350− (major1) < 1 || \
351− (major1) == 1 && (major2) < 0 || \
352− (major1) == 1 && (major2) == 0 && (minor) <= 3)
353−#endif /* MIN_VERSION_uuid_types */
354−
355−/* package vector-0.12.0.3 */
356−#ifndef VERSION_vector
357−#define VERSION_vector "0.12.0.3"
358−#endif /* VERSION_vector */
359−#ifndef MIN_VERSION_vector
360−#define MIN_VERSION_vector(major1,major2,minor) (\
361− (major1) < 0 || \
362− (major1) == 0 && (major2) < 12 || \
363− (major1) == 0 && (major2) == 12 && (minor) <= 0)
364−#endif /* MIN_VERSION_vector */
365−
366−/* tool gcc-4.2.1 */
367−#ifndef TOOL_VERSION_gcc
368−#define TOOL_VERSION_gcc "4.2.1"
369−#endif /* TOOL_VERSION_gcc */
370−#ifndef MIN_TOOL_VERSION_gcc
371−#define MIN_TOOL_VERSION_gcc(major1,major2,minor) (\
372− (major1) < 4 || \
373− (major1) == 4 && (major2) < 2 || \
374− (major1) == 4 && (major2) == 2 && (minor) <= 1)
375−#endif /* MIN_TOOL_VERSION_gcc */
376−
377−/* tool ghc-8.6.5 */
378−#ifndef TOOL_VERSION_ghc
379−#define TOOL_VERSION_ghc "8.6.5"
380−#endif /* TOOL_VERSION_ghc */
381−#ifndef MIN_TOOL_VERSION_ghc
382−#define MIN_TOOL_VERSION_ghc(major1,major2,minor) (\
383− (major1) < 8 || \
384− (major1) == 8 && (major2) < 6 || \
385− (major1) == 8 && (major2) == 6 && (minor) <= 5)
386−#endif /* MIN_TOOL_VERSION_ghc */
387−
388−/* tool ghc-pkg-8.6.5 */
389−#ifndef TOOL_VERSION_ghc_pkg
390−#define TOOL_VERSION_ghc_pkg "8.6.5"
391−#endif /* TOOL_VERSION_ghc_pkg */
392−#ifndef MIN_TOOL_VERSION_ghc_pkg
393−#define MIN_TOOL_VERSION_ghc_pkg(major1,major2,minor) (\
394− (major1) < 8 || \
395− (major1) == 8 && (major2) < 6 || \
396− (major1) == 8 && (major2) == 6 && (minor) <= 5)
397−#endif /* MIN_TOOL_VERSION_ghc_pkg */
398−
399−/* tool haddock-2.22.0 */
400−#ifndef TOOL_VERSION_haddock
401−#define TOOL_VERSION_haddock "2.22.0"
402−#endif /* TOOL_VERSION_haddock */
403−#ifndef MIN_TOOL_VERSION_haddock
404−#define MIN_TOOL_VERSION_haddock(major1,major2,minor) (\
405− (major1) < 2 || \
406− (major1) == 2 && (major2) < 22 || \
407− (major1) == 2 && (major2) == 22 && (minor) <= 0)
408−#endif /* MIN_TOOL_VERSION_haddock */
409−
410−/* tool hpc-0.67 */
411−#ifndef TOOL_VERSION_hpc
412−#define TOOL_VERSION_hpc "0.67"
413−#endif /* TOOL_VERSION_hpc */
414−#ifndef MIN_TOOL_VERSION_hpc
415−#define MIN_TOOL_VERSION_hpc(major1,major2,minor) (\
416− (major1) < 0 || \
417− (major1) == 0 && (major2) < 67 || \
418− (major1) == 0 && (major2) == 67 && (minor) <= 0)
419−#endif /* MIN_TOOL_VERSION_hpc */
420−
421−/* tool hsc2hs-0.68.5 */
422−#ifndef TOOL_VERSION_hsc2hs
423−#define TOOL_VERSION_hsc2hs "0.68.5"
424−#endif /* TOOL_VERSION_hsc2hs */
425−#ifndef MIN_TOOL_VERSION_hsc2hs
426−#define MIN_TOOL_VERSION_hsc2hs(major1,major2,minor) (\
427− (major1) < 0 || \
428− (major1) == 0 && (major2) < 68 || \
429− (major1) == 0 && (major2) == 68 && (minor) <= 5)
430−#endif /* MIN_TOOL_VERSION_hsc2hs */
431−
432−/* tool runghc-8.6.5 */
433−#ifndef TOOL_VERSION_runghc
434−#define TOOL_VERSION_runghc "8.6.5"
435−#endif /* TOOL_VERSION_runghc */
436−#ifndef MIN_TOOL_VERSION_runghc
437−#define MIN_TOOL_VERSION_runghc(major1,major2,minor) (\
438− (major1) < 8 || \
439− (major1) == 8 && (major2) < 6 || \
440− (major1) == 8 && (major2) == 6 && (minor) <= 5)
441−#endif /* MIN_TOOL_VERSION_runghc */
442−
443−#ifndef CURRENT_COMPONENT_ID
444−#define CURRENT_COMPONENT_ID "aeson-1.4.4.0-inplace-tests"
445−#endif /* CURRENT_COMPONENT_ID */
446−#ifndef CURRENT_PACKAGE_VERSION
447−#define CURRENT_PACKAGE_VERSION "1.4.4.0"
448−#endif /* CURRENT_PACKAGE_VERSION */
travis/install.sh−11
@@ -7,11 +7,6 @@ echo "$(ghc --version) [$(ghc --print-project-git-commit-id 2> /dev/null || echo
77stack --version
88
99case $BUILD in
10− hlint)
11− echo "Downloading hlint"
12− curl -sSL https://raw.github.com/ndmitchell/hlint/master/misc/run.sh > hlint.sh
13− chmod +x hlint.sh
14− ;;
1510 stack)
1611 stack --no-terminal --skip-ghc-check setup
1712 stack --no-terminal --skip-ghc-check test --only-snapshot
@@ -49,10 +44,4 @@ case $BUILD in
4944 cp -a $HOME/.cabal/lib $HOME/.cabal/share $HOME/.cabal/bin installplan.txt $HOME/.cabsnap/;
5045 fi
5146 ;;
52− cabal2)
53− cabal v2-update -v
54− sed -i 's/^jobs:/-- jobs:/' ${HOME}/.cabal/config
55−
56− cabal v2-build --only-dependencies --enable-tests --enable-benchmarks --dry
57− ;;
5847esac
travis/script.sh+2−4
@@ -19,11 +19,9 @@ case $BUILD in
1919 SRC_TGZ=$(cabal info . | awk '{print $2;exit}').tar.gz &&
2020 (cd dist && cabal install --force-reinstalls "$SRC_TGZ")
2121 ;;
22− cabal2)
23− cabal v2-build --enable-tests --enable-benchmarks
24− cabal v2-test --enable-tests --enable-benchmarks
25− ;;
2622 hlint)
23+ stack build --fast aeson --stack-yaml stack-nightly.yaml --system-ghc --no-terminal
24+ stack install hlint --stack-yaml stack-nightly.yaml --system-ghc --no-terminal
2725 make lint
2826 ;;
2927esac