git.iko.soy/typeable/attoparsec
on master help sign in
.gitignore+1
since splitsnapshots
unifiedsplit
@@ -3,3 +3,4 @@
3/dist/
3/dist/
4.cabal-sandbox
4.cabal-sandbox
5cabal.sandbox.config
5cabal.sandbox.config
6+*.sw[op]
.hgtags+1
@@ -60,3 +60,4 @@ ef875ad3bebef2b6fb1bd7063de6a46a06d0d4b4 0.12.1.4
60dc1fcff28d13a508f677c7b06af6420877842493 0.12.1.5
60dc1fcff28d13a508f677c7b06af6420877842493 0.12.1.5
61013e04e4526bfd5e9e4a611b42e6f03c413bea91 0.12.1.6
61013e04e4526bfd5e9e4a611b42e6f03c413bea91 0.12.1.6
620ddbce995b77b8db391b4d6519f13feddf4b5bf3 0.13.0.0
620ddbce995b77b8db391b4d6519f13feddf4b5bf3 0.13.0.0
63+46c16463ec20ad46c9cd0bfb1050c4268f34b749 0.13.0.1
.travis.ymlnew file+161
@@ -0,0 +1,161 @@
1+# This Travis job script has been generated by a script via
2+#
3+# haskell-ci '--tests-jobs=>=7.4' '--no-benchmarks' 'attoparsec.cabal'
4+#
5+# For more information, see https://github.com/haskell-CI/haskell-ci
6+#
7+# version: 0.3.20190815
8+#
9+language: c
10+dist: xenial
11+git:
12+ # whether to recursively clone submodules
13+ submodules: false
14+cache:
15+ directories:
16+ - $HOME/.cabal/packages
17+ - $HOME/.cabal/store
18+before_cache:
19+ - rm -fv $CABALHOME/packages/hackage.haskell.org/build-reports.log
20+ # remove files that are regenerated by 'cabal update'
21+ - rm -fv $CABALHOME/packages/hackage.haskell.org/00-index.*
22+ - rm -fv $CABALHOME/packages/hackage.haskell.org/*.json
23+ - rm -fv $CABALHOME/packages/hackage.haskell.org/01-index.cache
24+ - rm -fv $CABALHOME/packages/hackage.haskell.org/01-index.tar
25+ - rm -fv $CABALHOME/packages/hackage.haskell.org/01-index.tar.idx
26+ - rm -rfv $CABALHOME/packages/head.hackage
27+matrix:
28+ include:
29+ - compiler: ghc-8.8.1
30+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.8.1","cabal-install-3.0"]}}
31+ - compiler: ghc-8.6.5
32+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.6.5","cabal-install-2.4"]}}
33+ - compiler: ghc-8.4.4
34+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.4.4","cabal-install-2.4"]}}
35+ - compiler: ghc-8.2.2
36+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.2.2","cabal-install-2.4"]}}
37+ - compiler: ghc-8.0.2
38+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-8.0.2","cabal-install-2.4"]}}
39+ - compiler: ghc-7.10.3
40+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-7.10.3","cabal-install-2.4"]}}
41+ - compiler: ghc-7.8.4
42+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-7.8.4","cabal-install-2.4"]}}
43+ - compiler: ghc-7.6.3
44+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-7.6.3","cabal-install-2.4"]}}
45+ - compiler: ghc-7.4.2
46+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-7.4.2","cabal-install-2.4"]}}
47+ - compiler: ghc-7.2.2
48+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-7.2.2","cabal-install-2.4"]}}
49+ - compiler: ghc-7.0.4
50+ addons: {"apt":{"sources":["hvr-ghc"],"packages":["ghc-7.0.4","cabal-install-2.4"]}}
51+before_install:
52+ - HC=$(echo "/opt/$CC/bin/ghc" | sed 's/-/\//')
53+ - WITHCOMPILER="-w $HC"
54+ - HCPKG="$HC-pkg"
55+ - unset CC
56+ - CABAL=/opt/ghc/bin/cabal
57+ - CABALHOME=$HOME/.cabal
58+ - export PATH="$CABALHOME/bin:$PATH"
59+ - TOP=$(pwd)
60+ - "HCNUMVER=$(${HC} --numeric-version|perl -ne '/^(\\d+)\\.(\\d+)\\.(\\d+)(\\.(\\d+))?$/; print(10000 * $1 + 100 * $2 + ($3 == 0 ? $5 != 1 : $3))')"
61+ - echo $HCNUMVER
62+ - CABAL="$CABAL -vnormal+nowrap+markoutput"
63+ - set -o pipefail
64+ - |
65+ echo 'function blue(s) { printf "\033[0;34m" s "\033[0m " }' >> .colorful.awk
66+ echo 'BEGIN { state = "output"; }' >> .colorful.awk
67+ echo '/^-----BEGIN CABAL OUTPUT-----$/ { state = "cabal" }' >> .colorful.awk
68+ echo '/^-----END CABAL OUTPUT-----$/ { state = "output" }' >> .colorful.awk
69+ echo '!/^(-----BEGIN CABAL OUTPUT-----|-----END CABAL OUTPUT-----)/ {' >> .colorful.awk
70+ echo ' if (state == "cabal") {' >> .colorful.awk
71+ echo ' print blue($0)' >> .colorful.awk
72+ echo ' } else {' >> .colorful.awk
73+ echo ' print $0' >> .colorful.awk
74+ echo ' }' >> .colorful.awk
75+ echo '}' >> .colorful.awk
76+ - cat .colorful.awk
77+ - |
78+ color_cabal_output () {
79+ awk -f $TOP/.colorful.awk
80+ }
81+ - echo text | color_cabal_output
82+install:
83+ - ${CABAL} --version
84+ - echo "$(${HC} --version) [$(${HC} --print-project-git-commit-id 2> /dev/null || echo '?')]"
85+ - TEST=--enable-tests
86+ - if [ $HCNUMVER -lt 70400 ] ; then TEST=--disable-tests ; fi
87+ - BENCH=--enable-benchmarks
88+ - BENCH=--disable-benchmarks
89+ - HEADHACKAGE=false
90+ - rm -f $CABALHOME/config
91+ - |
92+ echo "verbose: normal +nowrap +markoutput" >> $CABALHOME/config
93+ echo "remote-build-reporting: anonymous" >> $CABALHOME/config
94+ echo "write-ghc-environment-files: always" >> $CABALHOME/config
95+ echo "remote-repo-cache: $CABALHOME/packages" >> $CABALHOME/config
96+ echo "logs-dir: $CABALHOME/logs" >> $CABALHOME/config
97+ echo "world-file: $CABALHOME/world" >> $CABALHOME/config
98+ echo "extra-prog-path: $CABALHOME/bin" >> $CABALHOME/config
99+ echo "symlink-bindir: $CABALHOME/bin" >> $CABALHOME/config
100+ echo "installdir: $CABALHOME/bin" >> $CABALHOME/config
101+ echo "build-summary: $CABALHOME/logs/build.log" >> $CABALHOME/config
102+ echo "store-dir: $CABALHOME/store" >> $CABALHOME/config
103+ echo "install-dirs user" >> $CABALHOME/config
104+ echo " prefix: $CABALHOME" >> $CABALHOME/config
105+ echo "repository hackage.haskell.org" >> $CABALHOME/config
106+ echo " url: http://hackage.haskell.org/" >> $CABALHOME/config
107+ - cat $CABALHOME/config
108+ - rm -fv cabal.project cabal.project.local cabal.project.freeze
109+ - travis_retry ${CABAL} v2-update -v
110+ # Generate cabal.project
111+ - rm -rf cabal.project cabal.project.local cabal.project.freeze
112+ - touch cabal.project
113+ - |
114+ echo "packages: ." >> cabal.project
115+ - |
116+ - "for pkg in $($HCPKG list --simple-output); do echo $pkg | sed 's/-[^-]*$//' | (grep -vE -- '^(attoparsec)$' || true) | sed 's/^/constraints: /' | sed 's/$/ installed/' >> cabal.project.local; done"
117+ - cat cabal.project || true
118+ - cat cabal.project.local || true
119+ - if [ -f "./configure.ac" ]; then (cd "." && autoreconf -i); fi
120+ - ${CABAL} v2-freeze $WITHCOMPILER ${TEST} ${BENCH} | color_cabal_output
121+ - "cat cabal.project.freeze | sed -E 's/^(constraints: *| *)//' | sed 's/any.//'"
122+ - rm cabal.project.freeze
123+ - ${CABAL} v2-build $WITHCOMPILER ${TEST} ${BENCH} --dep -j2 all | color_cabal_output
124+ - ${CABAL} v2-build $WITHCOMPILER --disable-tests --disable-benchmarks --dep -j2 all | color_cabal_output
125+script:
126+ - DISTDIR=$(mktemp -d /tmp/dist-test.XXXX)
127+ # Packaging...
128+ - ${CABAL} v2-sdist all | color_cabal_output
129+ # Unpacking...
130+ - mv dist-newstyle/sdist/*.tar.gz ${DISTDIR}/
131+ - cd ${DISTDIR} || false
132+ - find . -maxdepth 1 -type f -name '*.tar.gz' -exec tar -xvf '{}' \;
133+ - find . -maxdepth 1 -type f -name '*.tar.gz' -exec rm '{}' \;
134+ - PKGDIR_attoparsec="$(find . -maxdepth 1 -type d -regex '.*/attoparsec-[0-9.]*')"
135+ # Generate cabal.project
136+ - rm -rf cabal.project cabal.project.local cabal.project.freeze
137+ - touch cabal.project
138+ - |
139+ echo "packages: ${PKGDIR_attoparsec}" >> cabal.project
140+ - |
141+ - "for pkg in $($HCPKG list --simple-output); do echo $pkg | sed 's/-[^-]*$//' | (grep -vE -- '^(attoparsec)$' || true) | sed 's/^/constraints: /' | sed 's/$/ installed/' >> cabal.project.local; done"
142+ - cat cabal.project || true
143+ - cat cabal.project.local || true
144+ # Building...
145+ # this builds all libraries and executables (without tests/benchmarks)
146+ - ${CABAL} v2-build $WITHCOMPILER --disable-tests --disable-benchmarks all | color_cabal_output
147+ # Building with tests and benchmarks...
148+ # build & run tests, build benchmarks
149+ - ${CABAL} v2-build $WITHCOMPILER ${TEST} ${BENCH} all | color_cabal_output
150+ # Testing...
151+ - if [ $HCNUMVER -ge 70400 ] ; then ${CABAL} v2-test $WITHCOMPILER ${TEST} ${BENCH} all | color_cabal_output ; fi
152+ # cabal check...
153+ - (cd ${PKGDIR_attoparsec} && ${CABAL} -vnormal check)
154+ # haddock...
155+ - ${CABAL} v2-haddock $WITHCOMPILER ${TEST} ${BENCH} all | color_cabal_output
156+ # Building without installed constraints for packages in global-db...
157+ - rm -f cabal.project.local
158+ - ${CABAL} v2-build $WITHCOMPILER --disable-tests --disable-benchmarks all | color_cabal_output
159+
160+# REGENDATA ["--tests-jobs=>=7.4","--no-benchmarks","attoparsec.cabal"]
161+# EOF
Data/Attoparsec/ByteString/Buffer.hs+10−8
@@ -1,4 +1,4 @@
1−{-# LANGUAGE BangPatterns, CPP #-}
1+{-# LANGUAGE BangPatterns #-}
2-- |
2-- |
3-- Module : Data.Attoparsec.ByteString.Buffer
3-- Module : Data.Attoparsec.ByteString.Buffer
4-- Copyright : Bryan O'Sullivan 2007-2015
4-- Copyright : Bryan O'Sullivan 2007-2015
@@ -57,9 +57,8 @@ import Control.Exception (assert)
57import Data.ByteString.Internal (ByteString(..), memcpy, nullForeignPtr)
57import Data.ByteString.Internal (ByteString(..), memcpy, nullForeignPtr)
58import Data.Attoparsec.Internal.Fhthagn (inlinePerformIO)
58import Data.Attoparsec.Internal.Fhthagn (inlinePerformIO)
59import Data.List (foldl1')
59import Data.List (foldl1')
60−#if !MIN_VERSION_base(4,8,0)
60+import Data.Monoid as Mon (Monoid(..))
61−import Data.Monoid (Monoid(..))
61+import Data.Semigroup (Semigroup(..))
62−#endif
63import Data.Word (Word8)
62import Data.Word (Word8)
64import Foreign.ForeignPtr (ForeignPtr, withForeignPtr)
63import Foreign.ForeignPtr (ForeignPtr, withForeignPtr)
65import Foreign.Ptr (castPtr, plusPtr)
64import Foreign.Ptr (castPtr, plusPtr)
@@ -88,14 +87,17 @@ buffer (PS fp off len) = Buf fp off len len 0
88unbuffer :: Buffer -> ByteString
87unbuffer :: Buffer -> ByteString
89unbuffer (Buf fp off len _ _) = PS fp off len
88unbuffer (Buf fp off len _ _) = PS fp off len
90
89
90+instance Semigroup Buffer where
91+ (Buf _ _ _ 0 _) <> b = b
92+ a <> (Buf _ _ _ 0 _) = a
93+ buf <> (Buf fp off len _ _) = append buf fp off len
94+
91instance Monoid Buffer where
95instance Monoid Buffer where
92 mempty = Buf nullForeignPtr 0 0 0 0
96 mempty = Buf nullForeignPtr 0 0 0 0
93
97
94− mappend (Buf _ _ _ 0 _) b = b
98+ mappend = (<>)
95− mappend a (Buf _ _ _ 0 _) = a
96− mappend buf (Buf fp off len _ _) = append buf fp off len
97
99
98− mconcat [] = mempty
100+ mconcat [] = Mon.mempty
99 mconcat xs = foldl1' mappend xs
101 mconcat xs = foldl1' mappend xs
100
102
101pappend :: Buffer -> ByteString -> Buffer
103pappend :: Buffer -> ByteString -> Buffer
Data/Attoparsec/ByteString/Char8.hs+2−3
@@ -444,9 +444,8 @@ hexadecimal = B8.foldl' step 0 `fmap` I.takeWhile1 isHexDigit
444
444
445-- | Parse and decode an unsigned decimal number.
445-- | Parse and decode an unsigned decimal number.
446decimal :: Integral a => Parser a
446decimal :: Integral a => Parser a
447−decimal = B8.foldl' step 0 `fmap` I.takeWhile1 isDig
447+decimal = B8.foldl' step 0 `fmap` I.takeWhile1 isDigit_w8
448− where isDig w = w >= 48 && w <= 57
449− step a w = a * 10 + fromIntegral (w - 48)
448+ where step a w = a * 10 + fromIntegral (w - 48)
450{-# SPECIALISE decimal :: Parser Int #-}
449{-# SPECIALISE decimal :: Parser Int #-}
451{-# SPECIALISE decimal :: Parser Int8 #-}
450{-# SPECIALISE decimal :: Parser Int8 #-}
452{-# SPECIALISE decimal :: Parser Int16 #-}
451{-# SPECIALISE decimal :: Parser Int16 #-}
Data/Attoparsec/ByteString/Internal.hs+16−9
@@ -257,15 +257,24 @@ takeTill p = takeWhile (not . p)
257-- parsers loop until a failure occurs. Careless use will thus result
257-- parsers loop until a failure occurs. Careless use will thus result
258-- in an infinite loop.
258-- in an infinite loop.
259takeWhile :: (Word8 -> Bool) -> Parser ByteString
259takeWhile :: (Word8 -> Bool) -> Parser ByteString
260−takeWhile p = (B.concat . reverse) `fmap` go []
260+takeWhile p = do
261+ s <- B8.takeWhile p <$> get
262+ continue <- inputSpansChunks (B.length s)
263+ if continue
264+ then takeWhileAcc p [s]
265+ else return s
266+{-# INLINE takeWhile #-}
267+
268+takeWhileAcc :: (Word8 -> Bool) -> [ByteString] -> Parser ByteString
269+takeWhileAcc p = go
261 where
270 where
262 go acc = do
271 go acc = do
263 s <- B8.takeWhile p <$> get
272 s <- B8.takeWhile p <$> get
264 continue <- inputSpansChunks (B.length s)
273 continue <- inputSpansChunks (B.length s)
265 if continue
274 if continue
266 then go (s:acc)
275 then go (s:acc)
267− else return (s:acc)
276+ else return $ concatReverse (s:acc)
268−{-# INLINE takeWhile #-}
277+{-# INLINE takeWhileAcc #-}
269
278
270takeRest :: Parser [ByteString]
279takeRest :: Parser [ByteString]
271takeRest = go []
280takeRest = go []
@@ -329,16 +338,13 @@ scan_ f s0 p = go [] s0
329-- parsers loop until a failure occurs. Careless use will thus result
338-- parsers loop until a failure occurs. Careless use will thus result
330-- in an infinite loop.
339-- in an infinite loop.
331scan :: s -> (s -> Word8 -> Maybe s) -> Parser ByteString
340scan :: s -> (s -> Word8 -> Maybe s) -> Parser ByteString
332−scan = scan_ $ \_ chunks ->
341+scan = scan_ $ \_ chunks -> return $! concatReverse chunks
333− case chunks of
334− [x] -> return x
335− xs -> return $! B.concat $ reverse xs
336{-# INLINE scan #-}
342{-# INLINE scan #-}
337
343
338-- | Like 'scan', but generalized to return the final state of the
344-- | Like 'scan', but generalized to return the final state of the
339-- scanner.
345-- scanner.
340runScanner :: s -> (s -> Word8 -> Maybe s) -> Parser (ByteString, s)
346runScanner :: s -> (s -> Word8 -> Maybe s) -> Parser (ByteString, s)
341−runScanner = scan_ $ \s xs -> return (B.concat (reverse xs), s)
347+runScanner = scan_ $ \s xs -> let !sx = concatReverse xs in return (sx, s)
342{-# INLINE runScanner #-}
348{-# INLINE runScanner #-}
343
349
344-- | Consume input as long as the predicate returns 'True', and return
350-- | Consume input as long as the predicate returns 'True', and return
@@ -358,8 +364,9 @@ takeWhile1 p = do
358 advance len
364 advance len
359 eoc <- endOfChunk
365 eoc <- endOfChunk
360 if eoc
366 if eoc
361− then (s<>) `fmap` takeWhile p
367+ then takeWhileAcc p [s]
362 else return s
368 else return s
369+{-# INLINE takeWhile1 #-}
363
370
364-- | Match any byte in a set.
371-- | Match any byte in a set.
365--
372--
Data/Attoparsec/Internal.hs+10
@@ -20,10 +20,12 @@ module Data.Attoparsec.Internal
20 , endOfInput
20 , endOfInput
21 , atEnd
21 , atEnd
22 , satisfyElem
22 , satisfyElem
23+ , concatReverse
23 ) where
24 ) where
24
25
25#if !MIN_VERSION_base(4,8,0)
26#if !MIN_VERSION_base(4,8,0)
26import Control.Applicative ((<$>))
27import Control.Applicative ((<$>))
28+import Data.Monoid (Monoid, mconcat)
27#endif
29#endif
28import Data.Attoparsec.Internal.Types
30import Data.Attoparsec.Internal.Types
29import Data.ByteString (ByteString)
31import Data.ByteString (ByteString)
@@ -159,3 +161,11 @@ satisfyElem p = Parser $ \t pos more lose succ ->
159 | otherwise -> lose t pos more [] "satisfyElem"
161 | otherwise -> lose t pos more [] "satisfyElem"
160 Nothing -> satisfySuspended p t pos more lose succ
162 Nothing -> satisfySuspended p t pos more lose succ
161{-# INLINE satisfyElem #-}
163{-# INLINE satisfyElem #-}
164+
165+-- | Concatenate a monoid after reversing its elements. Used to
166+-- glue together a series of textual chunks that have been accumulated
167+-- \"backwards\".
168+concatReverse :: Monoid m => [m] -> m
169+concatReverse [x] = x
170+concatReverse xs = mconcat (reverse xs)
171+{-# INLINE concatReverse #-}
Data/Attoparsec/Internal/Types.hs+37−27
@@ -1,4 +1,4 @@
1−{-# LANGUAGE BangPatterns, CPP, GeneralizedNewtypeDeriving, OverloadedStrings,
1+{-# LANGUAGE CPP, BangPatterns, GeneralizedNewtypeDeriving, OverloadedStrings,
2 Rank2Types, RecordWildCards, TypeFamilies #-}
2 Rank2Types, RecordWildCards, TypeFamilies #-}
3-- |
3-- |
4-- Module : Data.Attoparsec.Internal.Types
4-- Module : Data.Attoparsec.Internal.Types
@@ -25,13 +25,13 @@ module Data.Attoparsec.Internal.Types
25 , Chunk(..)
25 , Chunk(..)
26 ) where
26 ) where
27
27
28−#if !MIN_VERSION_base(4,8,0)
29−import Control.Applicative (Applicative(..), (<$>))
28+import Control.Applicative as App (Applicative(..), (<$>))
30−import Data.Monoid (Monoid(..))
31−#endif
32import Control.Applicative (Alternative(..))
29import Control.Applicative (Alternative(..))
33import Control.DeepSeq (NFData(rnf))
30import Control.DeepSeq (NFData(rnf))
34import Control.Monad (MonadPlus(..))
31import Control.Monad (MonadPlus(..))
32+import qualified Control.Monad.Fail as Fail (MonadFail(..))
33+import Data.Monoid as Mon (Monoid(..))
34+import Data.Semigroup (Semigroup(..))
35import Data.Word (Word8)
35import Data.Word (Word8)
36import Data.ByteString (ByteString)
36import Data.ByteString (ByteString)
37import qualified Data.ByteString as BS
37import qualified Data.ByteString as BS
@@ -39,7 +39,7 @@ import Data.ByteString.Internal (w2c)
39import Data.Text (Text)
39import Data.Text (Text)
40import qualified Data.Text as Text
40import qualified Data.Text as Text
41import Data.Text.Unsafe (Iter(..))
41import Data.Text.Unsafe (Iter(..))
42−import Prelude hiding (getChar, succ)
42+import Prelude hiding (succ)
43import qualified Data.Attoparsec.ByteString.Buffer as B
43import qualified Data.Attoparsec.ByteString.Buffer as B
44import qualified Data.Attoparsec.Text.Buffer as T
44import qualified Data.Attoparsec.Text.Buffer as T
45
45
@@ -127,17 +127,21 @@ type Success i t a r = t -> Pos -> More -> a -> IResult i r
127data More = Complete | Incomplete
127data More = Complete | Incomplete
128 deriving (Eq, Show)
128 deriving (Eq, Show)
129
129
130−instance Monoid More where
130+instance Semigroup More where
131− mappend c@Complete _ = c
131+ c@Complete <> _ = c
132− mappend _ m = m
132+ _ <> m = m
133+
134+instance Mon.Monoid More where
135+ mappend = (<>)
133− mempty = Incomplete
136+ mempty = Incomplete
134
137
135instance Monad (Parser i) where
138instance Monad (Parser i) where
136− fail err = Parser $ \t pos more lose _succ -> lose t pos more [] msg
139+#if !(MIN_VERSION_base(4,13,0))
137− where msg = "Failed reading: " ++ err
140+ fail = Fail.fail
138 {-# INLINE fail #-}
141 {-# INLINE fail #-}
142+#endif
139
143
140− return v = Parser $ \t pos more _lose succ -> succ t pos more v
144+ return = App.pure
141 {-# INLINE return #-}
145 {-# INLINE return #-}
142
146
143 m >>= k = Parser $ \t !pos more lose succ ->
147 m >>= k = Parser $ \t !pos more lose succ ->
@@ -145,6 +149,15 @@ instance Monad (Parser i) where
145 in runParser m t pos more lose succ'
149 in runParser m t pos more lose succ'
146 {-# INLINE (>>=) #-}
150 {-# INLINE (>>=) #-}
147
151
152+ (>>) = (*>)
153+ {-# INLINE (>>) #-}
154+
155+
156+instance Fail.MonadFail (Parser i) where
157+ fail err = Parser $ \t pos more lose _succ -> lose t pos more [] msg
158+ where msg = "Failed reading: " ++ err
159+ {-# INLINE fail #-}
160+
148plus :: Parser i a -> Parser i a -> Parser i a
161plus :: Parser i a -> Parser i a -> Parser i a
149plus f g = Parser $ \t pos more lose succ ->
162plus f g = Parser $ \t pos more lose succ ->
150 let lose' t' _pos' more' _ctx _msg = runParser g t' pos more' lose succ
163 let lose' t' _pos' more' _ctx _msg = runParser g t' pos more' lose succ
@@ -169,23 +182,23 @@ apP d e = do
169{-# INLINE apP #-}
182{-# INLINE apP #-}
170
183
171instance Applicative (Parser i) where
184instance Applicative (Parser i) where
172− pure = return
185+ pure v = Parser $ \t !pos more _lose succ -> succ t pos more v
173 {-# INLINE pure #-}
186 {-# INLINE pure #-}
174 (<*>) = apP
187 (<*>) = apP
175 {-# INLINE (<*>) #-}
188 {-# INLINE (<*>) #-}
176−
189+ m *> k = m >>= \_ -> k
177− -- These definitions are equal to the defaults, but this
178− -- way the optimizer doesn't have to work so hard to figure
179− -- that out.
180− (*>) = (>>)
181 {-# INLINE (*>) #-}
190 {-# INLINE (*>) #-}
182− x <* y = x >>= \a -> y >> return a
191+ x <* y = x >>= \a -> y >> pure a
183 {-# INLINE (<*) #-}
192 {-# INLINE (<*) #-}
184
193
194+instance Semigroup (Parser i a) where
195+ (<>) = plus
196+ {-# INLINE (<>) #-}
197+
185instance Monoid (Parser i a) where
198instance Monoid (Parser i a) where
186 mempty = fail "mempty"
199 mempty = fail "mempty"
187 {-# INLINE mempty #-}
200 {-# INLINE mempty #-}
188− mappend = plus
201+ mappend = (<>)
189 {-# INLINE mappend #-}
202 {-# INLINE mappend #-}
190
203
191instance Alternative (Parser i) where
204instance Alternative (Parser i) where
@@ -196,8 +209,9 @@ instance Alternative (Parser i) where
196 {-# INLINE (<|>) #-}
209 {-# INLINE (<|>) #-}
197
210
198 many v = many_v
211 many v = many_v
212+ where
199− where many_v = some_v <|> pure []
213+ many_v = some_v <|> pure []
200− some_v = (:) <$> v <*> many_v
214+ some_v = (:) <$> v <*> many_v
201 {-# INLINE many #-}
215 {-# INLINE many #-}
202
216
203 some v = some_v
217 some v = some_v
@@ -206,10 +220,6 @@ instance Alternative (Parser i) where
206 some_v = (:) <$> v <*> many_v
220 some_v = (:) <$> v <*> many_v
207 {-# INLINE some #-}
221 {-# INLINE some #-}
208
222
209−(<>) :: (Monoid m) => m -> m -> m
210−(<>) = mappend
211−{-# INLINE (<>) #-}
212−
213-- | A common interface for input chunks.
223-- | A common interface for input chunks.
214class Monoid c => Chunk c where
224class Monoid c => Chunk c where
215 type ChunkElem c
225 type ChunkElem c
Data/Attoparsec/Text.hs+1
@@ -72,6 +72,7 @@ module Data.Attoparsec.Text
72 , skipSpace
72 , skipSpace
73 , I.skipWhile
73 , I.skipWhile
74 , I.scan
74 , I.scan
75+ , I.runScanner
75 , I.take
76 , I.take
76 , I.takeWhile
77 , I.takeWhile
77 , I.takeWhile1
78 , I.takeWhile1
Data/Attoparsec/Text/Buffer.hs+12−8
@@ -40,9 +40,8 @@ module Data.Attoparsec.Text.Buffer
40import Control.Exception (assert)
40import Control.Exception (assert)
41import Data.Bits (shiftR)
41import Data.Bits (shiftR)
42import Data.List (foldl1')
42import Data.List (foldl1')
43−#if !MIN_VERSION_base(4,8,0)
43+import Data.Monoid as Mon (Monoid(..))
44−import Data.Monoid (Monoid(..))
44+import Data.Semigroup (Semigroup(..))
45−#endif
46import Data.Text ()
45import Data.Text ()
47import Data.Text.Internal (Text(..))
46import Data.Text.Internal (Text(..))
48import Data.Text.Internal.Encoding.Utf16 (chr2)
47import Data.Text.Internal.Encoding.Utf16 (chr2)
@@ -80,15 +79,20 @@ unbufferAt s (Buf arr off len _ _) =
80 assert (s >= 0 && s <= len) $
79 assert (s >= 0 && s <= len) $
81 Text arr (off+s) (len-s)
80 Text arr (off+s) (len-s)
82
81
82+instance Semigroup Buffer where
83+ (Buf _ _ _ 0 _) <> b = b
84+ a <> (Buf _ _ _ 0 _) = a
85+ buf <> (Buf arr off len _ _) = append buf arr off len
86+ {-# INLINE (<>) #-}
87+
83instance Monoid Buffer where
88instance Monoid Buffer where
84 mempty = Buf A.empty 0 0 0 0
89 mempty = Buf A.empty 0 0 0 0
90+ {-# INLINE mempty #-}
85
91
86− mappend (Buf _ _ _ 0 _) b = b
92+ mappend = (<>)
87− mappend a (Buf _ _ _ 0 _) = a
88− mappend buf (Buf arr off len _ _) = append buf arr off len
89
93
90− mconcat [] = mempty
94+ mconcat [] = Mon.mempty
91− mconcat xs = foldl1' mappend xs
95+ mconcat xs = foldl1' (<>) xs
92
96
93pappend :: Buffer -> Text -> Buffer
97pappend :: Buffer -> Text -> Buffer
94pappend (Buf _ _ _ 0 _) t = buffer t
98pappend (Buf _ _ _ 0 _) t = buffer t
Data/Attoparsec/Text/FastSet.hs+3−1
@@ -62,7 +62,9 @@ resolveCollisions (a:b:entries) = a' : resolveCollisions (b' : entries)
62
62
63pad :: Int -> [Entry] -> [Entry]
63pad :: Int -> [Entry] -> [Entry]
64pad = go 0
64pad = go 0
65+ where -- ensure that we pad enough so that lookups beyond the
66+ -- last hash in the table fall within the array
65− where go !_ !m [] = replicate (max 1 m) empty
67+ go !_ !m [] = replicate (max 1 m + 1) empty
66 go k m (e:entries) = map (const empty) [k..i - 1] ++ e :
68 go k m (e:entries) = map (const empty) [k..i - 1] ++ e :
67 go (i + 1) (m + i - k - 1) entries
69 go (i + 1) (m + i - k - 1) entries
68 where i = index e
70 where i = index e
Data/Attoparsec/Text/Internal.hs+32−25
@@ -1,4 +1,4 @@
1−{-# LANGUAGE BangPatterns, CPP, FlexibleInstances, GADTs, OverloadedStrings,
1+{-# LANGUAGE BangPatterns, FlexibleInstances, GADTs, OverloadedStrings,
2 Rank2Types, RecordWildCards, TypeFamilies, TypeSynonymInstances #-}
2 Rank2Types, RecordWildCards, TypeFamilies, TypeSynonymInstances #-}
3{-# OPTIONS_GHC -fno-warn-orphans #-}
3{-# OPTIONS_GHC -fno-warn-orphans #-}
4-- |
4-- |
@@ -65,17 +65,14 @@ module Data.Attoparsec.Text.Internal
65 , atEnd
65 , atEnd
66 ) where
66 ) where
67
67
68−#if !MIN_VERSION_base(4,8,0)
69−import Control.Applicative ((<$>))
68+import Control.Applicative ((<|>), (<$>), pure, (*>))
70−#endif
71−import Control.Applicative ((<|>))
72import Control.Monad (when)
69import Control.Monad (when)
73import Data.Attoparsec.Combinator ((<?>))
70import Data.Attoparsec.Combinator ((<?>))
74import Data.Attoparsec.Internal
71import Data.Attoparsec.Internal
75import Data.Attoparsec.Internal.Types hiding (Parser, Failure, Success)
72import Data.Attoparsec.Internal.Types hiding (Parser, Failure, Success)
76import qualified Data.Attoparsec.Text.Buffer as Buf
73import qualified Data.Attoparsec.Text.Buffer as Buf
77import Data.Attoparsec.Text.Buffer (Buffer, buffer)
74import Data.Attoparsec.Text.Buffer (Buffer, buffer)
78−import Data.Char (chr, ord)
75+import Data.Char (isAsciiUpper, isAsciiLower, toUpper, toLower)
79import Data.List (intercalate)
76import Data.List (intercalate)
80import Data.String (IsString(..))
77import Data.String (IsString(..))
81import Data.Text.Internal (Text(..))
78import Data.Text.Internal (Text(..))
@@ -225,15 +222,16 @@ stringCI s = go 0
225
222
226-- | Satisfy a literal string, ignoring case for characters in the ASCII range.
223-- | Satisfy a literal string, ignoring case for characters in the ASCII range.
227asciiCI :: Text -> Parser Text
224asciiCI :: Text -> Parser Text
228−asciiCI s = string_ (stringSuspended asciiToLower) asciiToLower s
225+asciiCI s = fmap fst $ match $ T.foldr ((*>) . asciiCharCI) (pure ()) s
229− where
230− asciiToLower = T.map f
231− where
232− offset = ord 'a' - ord 'A'
233− f c | 'A' <= c && c <= 'Z' = chr (ord c + offset)
234− | otherwise = c
235{-# INLINE asciiCI #-}
226{-# INLINE asciiCI #-}
236
227
228+asciiCharCI :: Char -> Parser Char
229+asciiCharCI c
230+ | isAsciiUpper c = char c <|> char (toLower c)
231+ | isAsciiLower c = char c <|> char (toUpper c)
232+ | otherwise = char c
233+{-# INLINE asciiCharCI #-}
234+
237-- | Skip past input for as long as the predicate returns 'True'.
235-- | Skip past input for as long as the predicate returns 'True'.
238skipWhile :: (Char -> Bool) -> Parser ()
236skipWhile :: (Char -> Bool) -> Parser ()
239skipWhile p = go
237skipWhile p = go
@@ -269,14 +267,25 @@ takeTill p = takeWhile (not . p)
269-- parsers loop until a failure occurs. Careless use will thus result
267-- parsers loop until a failure occurs. Careless use will thus result
270-- in an infinite loop.
268-- in an infinite loop.
271takeWhile :: (Char -> Bool) -> Parser Text
269takeWhile :: (Char -> Bool) -> Parser Text
272−takeWhile p = (T.concat . reverse) `fmap` go []
270+takeWhile p = do
271+ h <- T.takeWhile p <$> get
272+ continue <- inputSpansChunks (size h)
273+ -- only use slow concat path if necessary
274+ if continue
275+ then takeWhileAcc p [h]
276+ else return h
277+{-# INLINE takeWhile #-}
278+
279+takeWhileAcc :: (Char -> Bool) -> [Text] -> Parser Text
280+takeWhileAcc p = go
273 where
281 where
274 go acc = do
282 go acc = do
275 h <- T.takeWhile p <$> get
283 h <- T.takeWhile p <$> get
276 continue <- inputSpansChunks (size h)
284 continue <- inputSpansChunks (size h)
277 if continue
285 if continue
278 then go (h:acc)
286 then go (h:acc)
279− else return (h:acc)
287+ else return $ concatReverse (h:acc)
288+{-# INLINE takeWhileAcc #-}
280
289
281takeRest :: Parser [Text]
290takeRest :: Parser [Text]
282takeRest = go []
291takeRest = go []
@@ -299,7 +308,7 @@ takeLazyText :: Parser L.Text
299takeLazyText = L.fromChunks `fmap` takeRest
308takeLazyText = L.fromChunks `fmap` takeRest
300
309
301data Scan s = Continue s
310data Scan s = Continue s
302− | Finished {-# UNPACK #-} !Int Text
311+ | Finished s {-# UNPACK #-} !Int Text
303
312
304scan_ :: (s -> [Text] -> Parser r) -> s -> (s -> Char -> Maybe s) -> Parser r
313scan_ :: (s -> [Text] -> Parser r) -> s -> (s -> Char -> Maybe s) -> Parser r
305scan_ f s0 p = go [] s0
314scan_ f s0 p = go [] s0
@@ -308,7 +317,7 @@ scan_ f s0 p = go [] s0
308 case T.uncons t of
317 case T.uncons t of
309 Just (c,t') -> case p s c of
318 Just (c,t') -> case p s c of
310 Just s' -> scanner s' (n+1) t'
319 Just s' -> scanner s' (n+1) t'
311− Nothing -> Finished n t
320+ Nothing -> Finished s n t
312 Nothing -> Continue s
321 Nothing -> Continue s
313 go acc s = do
322 go acc s = do
314 input <- get
323 input <- get
@@ -317,8 +326,8 @@ scan_ f s0 p = go [] s0
317 if continue
326 if continue
318 then go (input : acc) s'
327 then go (input : acc) s'
319 else f s' (input : acc)
328 else f s' (input : acc)
320− Finished n t -> do advance (size input - size t)
329+ Finished s' n t -> do advance (size input - size t)
321− f s (T.take n input : acc)
330+ f s' (T.take n input : acc)
322{-# INLINE scan_ #-}
331{-# INLINE scan_ #-}
323
332
324-- | A stateful scanner. The predicate consumes and transforms a
333-- | A stateful scanner. The predicate consumes and transforms a
@@ -334,16 +343,13 @@ scan_ f s0 p = go [] s0
334-- parsers loop until a failure occurs. Careless use will thus result
343-- parsers loop until a failure occurs. Careless use will thus result
335-- in an infinite loop.
344-- in an infinite loop.
336scan :: s -> (s -> Char -> Maybe s) -> Parser Text
345scan :: s -> (s -> Char -> Maybe s) -> Parser Text
337−scan = scan_ $ \_ chunks ->
346+scan = scan_ $ \_ chunks -> return $! concatReverse chunks
338− case chunks of
339− [x] -> return x
340− xs -> return . T.concat . reverse $ xs
341{-# INLINE scan #-}
347{-# INLINE scan #-}
342
348
343-- | Like 'scan', but generalized to return the final state of the
349-- | Like 'scan', but generalized to return the final state of the
344-- scanner.
350-- scanner.
345runScanner :: s -> (s -> Char -> Maybe s) -> Parser (Text, s)
351runScanner :: s -> (s -> Char -> Maybe s) -> Parser (Text, s)
346−runScanner = scan_ $ \s xs -> return (T.concat (reverse xs), s)
352+runScanner = scan_ $ \s xs -> let !sx = concatReverse xs in return (sx, s)
347{-# INLINE runScanner #-}
353{-# INLINE runScanner #-}
348
354
349-- | Consume input as long as the predicate returns 'True', and return
355-- | Consume input as long as the predicate returns 'True', and return
@@ -361,8 +367,9 @@ takeWhile1 p = do
361 advance size'
367 advance size'
362 eoc <- endOfChunk
368 eoc <- endOfChunk
363 if eoc
369 if eoc
364− then (h<>) `fmap` takeWhile p
370+ then takeWhileAcc p [h]
365 else return h
371 else return h
372+{-# INLINE takeWhile1 #-}
366
373
367-- | Match any character in a set.
374-- | Match any character in a set.
368--
375--
Data/Attoparsec/Zepto.hs+17−8
@@ -38,18 +38,17 @@ module Data.Attoparsec.Zepto
38
38
39import Control.Applicative
39import Control.Applicative
40import Control.Monad (MonadPlus(..), ap)
40import Control.Monad (MonadPlus(..), ap)
41+import qualified Control.Monad.Fail as Fail
41import Control.Monad.IO.Class (MonadIO(..))
42import Control.Monad.IO.Class (MonadIO(..))
42import Data.ByteString (ByteString)
43import Data.ByteString (ByteString)
43import Data.Functor.Identity (Identity(runIdentity))
44import Data.Functor.Identity (Identity(runIdentity))
45+import Data.Monoid as Mon (Monoid(..))
46+import Data.Semigroup (Semigroup(..))
44import Data.Word (Word8)
47import Data.Word (Word8)
45import Prelude hiding (take, takeWhile)
48import Prelude hiding (take, takeWhile)
46import qualified Data.ByteString as B
49import qualified Data.ByteString as B
47import qualified Data.ByteString.Unsafe as B
50import qualified Data.ByteString.Unsafe as B
48
51
49−#if !MIN_VERSION_base(4,8,0)
50−import Data.Monoid (Monoid(..))
51−#endif
52−
53newtype S = S {
52newtype S = S {
54 input :: ByteString
53 input :: ByteString
55 }
54 }
@@ -83,7 +82,7 @@ instance MonadIO m => MonadIO (ZeptoT m) where
83 {-# INLINE liftIO #-}
82 {-# INLINE liftIO #-}
84
83
85instance Monad m => Monad (ZeptoT m) where
84instance Monad m => Monad (ZeptoT m) where
86− return a = Parser $ \s -> return (OK a s)
85+ return = pure
87 {-# INLINE return #-}
86 {-# INLINE return #-}
88
87
89 m >>= k = Parser $ \s -> do
88 m >>= k = Parser $ \s -> do
@@ -93,6 +92,12 @@ instance Monad m => Monad (ZeptoT m) where
93 Fail err -> return (Fail err)
92 Fail err -> return (Fail err)
94 {-# INLINE (>>=) #-}
93 {-# INLINE (>>=) #-}
95
94
95+#if !(MIN_VERSION_base(4,13,0))
96+ fail = Fail.fail
97+ {-# INLINE fail #-}
98+#endif
99+
100+instance Monad m => Fail.MonadFail (ZeptoT m) where
96 fail msg = Parser $ \_ -> return (Fail msg)
101 fail msg = Parser $ \_ -> return (Fail msg)
97 {-# INLINE fail #-}
102 {-# INLINE fail #-}
98
103
@@ -108,7 +113,7 @@ instance Monad m => MonadPlus (ZeptoT m) where
108 {-# INLINE mplus #-}
113 {-# INLINE mplus #-}
109
114
110instance (Monad m) => Applicative (ZeptoT m) where
115instance (Monad m) => Applicative (ZeptoT m) where
111− pure = return
116+ pure a = Parser $ \s -> return (OK a s)
112 {-# INLINE pure #-}
117 {-# INLINE pure #-}
113 (<*>) = ap
118 (<*>) = ap
114 {-# INLINE (<*>) #-}
119 {-# INLINE (<*>) #-}
@@ -137,10 +142,14 @@ parseT p bs = do
137 Fail err -> return (Left err)
142 Fail err -> return (Left err)
138{-# INLINE parseT #-}
143{-# INLINE parseT #-}
139
144
145+instance Monad m => Semigroup (ZeptoT m a) where
146+ (<>) = mplus
147+ {-# INLINE (<>) #-}
148+
140−instance Monad m => Monoid (ZeptoT m a) where
149+instance Monad m => Mon.Monoid (ZeptoT m a) where
141 mempty = fail "mempty"
150 mempty = fail "mempty"
142 {-# INLINE mempty #-}
151 {-# INLINE mempty #-}
143− mappend = mplus
152+ mappend = (<>)
144 {-# INLINE mappend #-}
153 {-# INLINE mappend #-}
145
154
146instance Monad m => Alternative (ZeptoT m) where
155instance Monad m => Alternative (ZeptoT m) where
README.markdown−6
@@ -16,12 +16,6 @@ Master [git repository](https://github.com/bos/attoparsec):
16
16
17* `git clone git://github.com/bos/attoparsec.git`
17* `git clone git://github.com/bos/attoparsec.git`
18
18
19−There's also a [Mercurial mirror](https://bitbucket.org/bos/attoparsec):
20−
21−* `hg clone https://bitbucket.org/bos/attoparsec`
22−
23−(You can create and contribute changes using either Mercurial or git.)
24−
25Authors
19Authors
26-------
20-------
27
21
attoparsec.cabal+53−13
@@ -1,12 +1,13 @@
1name: attoparsec
1name: attoparsec
2−version: 0.13.0.0
2+version: 0.13.2.2
3+x-revision: 3
3license: BSD3
4license: BSD3
4license-file: LICENSE
5license-file: LICENSE
5category: Text, Parsing
6category: Text, Parsing
6author: Bryan O'Sullivan <bos@serpentine.com>
7author: Bryan O'Sullivan <bos@serpentine.com>
7−maintainer: Bryan O'Sullivan <bos@serpentine.com>
8+maintainer: Bryan O'Sullivan <bos@serpentine.com>, Ben Gamari <ben@smart-cactus.org>
8stability: experimental
9stability: experimental
9−tested-with: GHC == 7.0, GHC == 7.2, GHC == 7.4, GHC == 7.6, GHC == 7.8, GHC == 7.10
10+tested-with: GHC == 7.0.4, GHC == 7.2.2, GHC == 7.4.2, GHC ==7.6.3, GHC ==7.8.4, GHC ==7.10.3, GHC ==8.0.2, GHC ==8.2.2, GHC==8.4.4, GHC==8.6.5, GHC==8.8.1
10synopsis: Fast combinator parsing for bytestrings and text
11synopsis: Fast combinator parsing for bytestrings and text
11cabal-version: >= 1.8
12cabal-version: >= 1.8
12homepage: https://github.com/bos/attoparsec
13homepage: https://github.com/bos/attoparsec
@@ -21,6 +22,7 @@ extra-source-files:
21 benchmarks/*.cabal
22 benchmarks/*.cabal
22 benchmarks/*.hs
23 benchmarks/*.hs
23 benchmarks/*.txt
24 benchmarks/*.txt
25+ benchmarks/json-data/*.json
24 benchmarks/Makefile
26 benchmarks/Makefile
25 benchmarks/med.txt.bz2
27 benchmarks/med.txt.bz2
26 changelog.md
28 changelog.md
@@ -38,17 +40,22 @@ Flag developer
38
40
39library
41library
40 build-depends: array,
42 build-depends: array,
41− base >= 4.2 && < 5,
43+ base >= 4.3 && < 5,
42 bytestring,
44 bytestring,
43 containers,
45 containers,
44 deepseq,
46 deepseq,
45 scientific >= 0.3.1 && < 0.4,
47 scientific >= 0.3.1 && < 0.4,
46− transformers,
48+ transformers >= 0.2 && (< 0.4 || >= 0.4.1.0) && < 0.6,
47 text >= 1.1.1.3
49 text >= 1.1.1.3
48 if impl(ghc < 7.4)
50 if impl(ghc < 7.4)
49 build-depends:
51 build-depends:
50 bytestring < 0.10.4.0
52 bytestring < 0.10.4.0
51
53
54+ if !impl(ghc >= 8.0)
55+ -- Data.Semigroup && Control.Monad.Fail are available in base-4.9+
56+ build-depends: fail == 4.9.*,
57+ semigroups >=0.16.1 && <0.20
58+
52 exposed-modules: Data.Attoparsec
59 exposed-modules: Data.Attoparsec
53 Data.Attoparsec.ByteString
60 Data.Attoparsec.ByteString
54 Data.Attoparsec.ByteString.Char8
61 Data.Attoparsec.ByteString.Char8
@@ -89,6 +96,26 @@ test-suite tests
89 QC.Rechunked
96 QC.Rechunked
90 QC.Simple
97 QC.Simple
91 QC.Text
98 QC.Text
99+ QC.Text.FastSet
100+ QC.Text.Regressions
101+
102+ other-modules: Data.Attoparsec.ByteString
103+ Data.Attoparsec.ByteString.Buffer
104+ Data.Attoparsec.ByteString.Char8
105+ Data.Attoparsec.ByteString.FastSet
106+ Data.Attoparsec.ByteString.Internal
107+ Data.Attoparsec.ByteString.Lazy
108+ Data.Attoparsec.Combinator
109+ Data.Attoparsec.Internal
110+ Data.Attoparsec.Internal.Fhthagn
111+ Data.Attoparsec.Internal.Types
112+ Data.Attoparsec.Number
113+ Data.Attoparsec.Text
114+ Data.Attoparsec.Text.Buffer
115+ Data.Attoparsec.Text.FastSet
116+ Data.Attoparsec.Text.Internal
117+ Data.Attoparsec.Text.Lazy
118+ Data.Attoparsec.Zepto
92
119
93 ghc-options:
120 ghc-options:
94 -Wall -threaded -rtsopts
121 -Wall -threaded -rtsopts
@@ -98,18 +125,23 @@ test-suite tests
98
125
99 build-depends:
126 build-depends:
100 array,
127 array,
101− base >= 4 && < 5,
128+ base,
102 bytestring,
129 bytestring,
103 deepseq >= 1.1,
130 deepseq >= 1.1,
104− QuickCheck >= 2.7,
131+ QuickCheck >= 2.13.2 && < 2.14,
105 quickcheck-unicode,
132 quickcheck-unicode,
106 scientific,
133 scientific,
107− test-framework >= 0.8.0.2,
134+ tasty >= 0.11,
108− test-framework-quickcheck2 >= 0.3.0.3,
135+ tasty-quickcheck >= 0.8,
109 text,
136 text,
110− transformers,
137+ transformers >= 0.2 && (< 0.4 || >= 0.4.1.0) && < 0.6,
111 vector
138 vector
112
139
140+ if !impl(ghc >= 8.0)
141+ -- Data.Semigroup && Control.Monad.Fail are available in base-4.9+
142+ build-depends: fail == 4.9.*,
143+ semigroups >=0.16.1 && <0.20
144+
113benchmark benchmarks
145benchmark benchmarks
114 type: exitcode-stdio-1.0
146 type: exitcode-stdio-1.0
115 hs-source-dirs: benchmarks benchmarks/warp-3.0.1.1 .
147 hs-source-dirs: benchmarks benchmarks/warp-3.0.1.1 .
@@ -121,7 +153,11 @@ benchmark benchmarks
121 HeadersByteString.Atto
153 HeadersByteString.Atto
122 HeadersText
154 HeadersText
123 Links
155 Links
156+ Network.Wai.Handler.Warp.ReadInt
157+ Network.Wai.Handler.Warp.RequestHeader
124 Numbers
158 Numbers
159+ Sets
160+ TextFastSet
125 Warp
161 Warp
126 ghc-options: -O2 -Wall
162 ghc-options: -O2 -Wall
127
163
@@ -133,6 +169,7 @@ benchmark benchmarks
133 base == 4.*,
169 base == 4.*,
134 bytestring >= 0.10.4.0,
170 bytestring >= 0.10.4.0,
135 case-insensitive,
171 case-insensitive,
172+ containers,
136 criterion >= 1.0,
173 criterion >= 1.0,
137 deepseq >= 1.1,
174 deepseq >= 1.1,
138 directory,
175 directory,
@@ -142,13 +179,16 @@ benchmark benchmarks
142 parsec >= 3.1.2,
179 parsec >= 3.1.2,
143 scientific,
180 scientific,
144 text >= 1.1.1.0,
181 text >= 1.1.1.0,
182+ transformers >= 0.2 && (< 0.4 || >= 0.4.1.0) && < 0.6,
145 unordered-containers,
183 unordered-containers,
146 vector
184 vector
147
185
186+ if !impl(ghc >= 8.0)
187+ -- Data.Semigroup && Control.Monad.Fail are available in base-4.9+
188+ build-depends: fail == 4.9.*,
189+ semigroups >=0.16.1 && <0.19
190+
148source-repository head
191source-repository head
149 type: git
192 type: git
150 location: https://github.com/bos/attoparsec
193 location: https://github.com/bos/attoparsec
151
194
152−source-repository head
153− type: mercurial
154− location: https://bitbucket.org/bos/attoparsec
benchmarks/Benchmarks.hs+6
@@ -28,6 +28,7 @@ import qualified HeadersByteString
28import qualified HeadersText
28import qualified HeadersText
29import qualified Links
29import qualified Links
30import qualified Text.Parsec as P
30import qualified Text.Parsec as P
31+import qualified Sets
31
32
32main :: IO ()
33main :: IO ()
33main = do
34main = do
@@ -70,10 +71,14 @@ main = do
70 , bench "isAlpha_ascii" $ nf (ABL.parse (AC.takeWhile AC.isAlpha_ascii)) bl
71 , bench "isAlpha_ascii" $ nf (ABL.parse (AC.takeWhile AC.isAlpha_ascii)) bl
71 , bench "isAlpha_iso8859_15" $
72 , bench "isAlpha_iso8859_15" $
72 nf (ABL.parse (AC.takeWhile AC.isAlpha_iso8859_15)) bl
73 nf (ABL.parse (AC.takeWhile AC.isAlpha_iso8859_15)) bl
74+ , bench "T isAlpha" $ nf (AT.parse (AT.takeWhile isAlpha)) t
75+ , bench "TL isAlpha" $ nf (ATL.parse (AT.takeWhile isAlpha)) tl
73 ]
76 ]
74 , bgroup "takeWhile1" [
77 , bgroup "takeWhile1" [
75 bench "isAlpha" $ nf (ABL.parse (AC.takeWhile1 isAlpha)) bl
78 bench "isAlpha" $ nf (ABL.parse (AC.takeWhile1 isAlpha)) bl
76 , bench "isAlpha_ascii" $ nf (ABL.parse (AC.takeWhile1 AC.isAlpha_ascii)) bl
79 , bench "isAlpha_ascii" $ nf (ABL.parse (AC.takeWhile1 AC.isAlpha_ascii)) bl
80+ , bench "T isAlpha" $ nf (AT.parse (AT.takeWhile1 isAlpha)) t
81+ , bench "TL isAlpha" $ nf (ATL.parse (AT.takeWhile1 isAlpha)) tl
77 ]
82 ]
78 , bench "word32LE" $ nf (AB.parse word32LE) b
83 , bench "word32LE" $ nf (AB.parse word32LE) b
79 , bgroup "scan" [
84 , bgroup "scan" [
@@ -86,6 +91,7 @@ main = do
86 , headersT
91 , headersT
87 , Links.links
92 , Links.links
88 , numbers
93 , numbers
94+ , Sets.benchmarks
89 , Warp.benchmarks
95 , Warp.benchmarks
90 ]
96 ]
91
97
benchmarks/HeadersByteString.hs+10−1
@@ -9,6 +9,15 @@ import qualified Data.Attoparsec.ByteString.Char8 as B
9import qualified Data.Attoparsec.ByteString.Lazy as BL
9import qualified Data.Attoparsec.ByteString.Lazy as BL
10import qualified Data.ByteString.Char8 as B
10import qualified Data.ByteString.Char8 as B
11
11
12+-- Note: In the benchmarks for parsing an http request
13+-- from a strict bytestring, we consider warp's implementation,
14+-- which has highly optimized code for handling the first
15+-- line in particular. It's treatment of the headers
16+-- is more relaxed from the treatment they are given by the
17+-- attoparsec parser benchmarked here. Consequently, it
18+-- is should not be possible to match its performance since
19+-- it accepts header names with disallowed characters.
20+
12headers :: IO Benchmark
21headers :: IO Benchmark
13headers = do
22headers = do
14 req <- B.readFile =<< pathTo "http-request.txt"
23 req <- B.readFile =<< pathTo "http-request.txt"
@@ -18,7 +27,7 @@ headers = do
18 return $ bgroup "headers" [
27 return $ bgroup "headers" [
19 bgroup "B" [
28 bgroup "B" [
20 bench "request" $ nf (B.parseOnly request) req
29 bench "request" $ nf (B.parseOnly request) req
21− , bench "warp" $ nfIO (parseHeaderLines [req])
30+ , bench "warp" $ nfIO (parseHeaderLines (B.split '\n' req))
22 , bench "response" $ nf (B.parseOnly response) resp
31 , bench "response" $ nf (B.parseOnly response) resp
23 ]
32 ]
24 , bgroup "BL" [
33 , bgroup "BL" [
benchmarks/HeadersByteString/Atto.hs+9−1
@@ -15,8 +15,16 @@ import qualified Data.ByteString.Char8 as B
15instance NFData HttpVersion where
15instance NFData HttpVersion where
16 rnf !_ = ()
16 rnf !_ = ()
17
17
18+isHeaderChar :: Char -> Bool
19+isHeaderChar c =
20+ (c >= 'a' && c <= 'z') ||
21+ (c >= 'A' && c <= 'Z') ||
22+ (c >= '0' && c <= '9') ||
23+ (c == '_') ||
24+ (c == '-')
25+
18header = do
26header = do
19− name <- B.takeWhile1 (B.inClass "a-zA-Z0-9_-") <* B.char ':' <* B.skipSpace
27+ name <- B.takeWhile1 isHeaderChar <* B.char ':' <* B.skipSpace
20 body <- bodyLine
28 body <- bodyLine
21 return (name, body)
29 return (name, body)
22
30
benchmarks/Sets.hsnew file+21
@@ -0,0 +1,21 @@
1+module Sets (benchmarks) where
2+
3+import Criterion
4+import Data.Char (ord)
5+import qualified Data.Attoparsec.Text.FastSet as FastSet
6+import qualified TextFastSet
7+import qualified Data.HashSet as HashSet
8+import qualified Data.IntSet as IntSet
9+
10+smallSet :: String
11+smallSet = ['a'..'z'] ++ ['A'..'Z'] ++ ['0'..'9']
12+
13+benchmarks :: Benchmark
14+benchmarks = bgroup "sets" [
15+ bench "Fast" $ whnf (FastSet.member '*') (FastSet.fromList smallSet)
16+ , bench "Hash" $ whnf (HashSet.member '*') (HashSet.fromList smallSet)
17+ , bench "Int" $ whnf (IntSet.member (ord '*'))
18+ (IntSet.fromList (map ord smallSet))
19+ , bench "TextFast" $ whnf (TextFastSet.member '*')
20+ (TextFastSet.fromList smallSet)
21+ ]
benchmarks/TextFastSet.hsnew file+121
@@ -0,0 +1,121 @@
1+{-# LANGUAGE BangPatterns #-}
2+
3+------------------------------------------------------------------------------
4+-- |
5+-- Module : Data.Attoparsec.FastSet
6+-- Copyright : Felipe Lessa 2010, Bryan O'Sullivan 2007-2015
7+-- License : BSD3
8+--
9+-- Maintainer : felipe.lessa@gmail.com
10+-- Stability : experimental
11+-- Portability : unknown
12+--
13+-- Fast set membership tests for 'Char' values. We test for
14+-- membership using a hashtable implemented with Robin Hood
15+-- collision resolution. The set representation is unboxed,
16+-- and the characters and hashes interleaved, for efficiency.
17+--
18+--
19+-----------------------------------------------------------------------------
20+module TextFastSet
21+ (
22+ -- * Data type
23+ FastSet
24+ -- * Construction
25+ , fromList
26+ , set
27+ -- * Lookup
28+ , member
29+ -- * Handy interface
30+ , charClass
31+ ) where
32+
33+import Data.Bits ((.|.), (.&.), shiftR)
34+import Data.Function (on)
35+import Data.List (sort, sortBy)
36+import qualified Data.Array.Base as AB
37+import qualified Data.Array.Unboxed as A
38+import qualified Data.Text as T
39+
40+data FastSet = FastSet {
41+ table :: {-# UNPACK #-} !(A.UArray Int Int)
42+ , mask :: {-# UNPACK #-} !Int
43+ }
44+
45+data Entry = Entry {
46+ key :: {-# UNPACK #-} !Char
47+ , initialIndex :: {-# UNPACK #-} !Int
48+ , index :: {-# UNPACK #-} !Int
49+ }
50+
51+offset :: Entry -> Int
52+offset e = index e - initialIndex e
53+
54+resolveCollisions :: [Entry] -> [Entry]
55+resolveCollisions [] = []
56+resolveCollisions [e] = [e]
57+resolveCollisions (a:b:entries) = a' : resolveCollisions (b' : entries)
58+ where (a', b')
59+ | index a < index b = (a, b)
60+ | offset a < offset b = (b { index=index a }, a { index=index a + 1 })
61+ | otherwise = (a, b { index=index a + 1 })
62+
63+pad :: Int -> [Entry] -> [Entry]
64+pad = go 0
65+ where -- ensure that we pad enough so that lookups beyond the
66+ -- last hash in the table fall within the array
67+ go !_ !m [] = replicate (max 1 m + 1) empty
68+ go k m (e:entries) = map (const empty) [k..i - 1] ++ e :
69+ go (i + 1) (m + i - k - 1) entries
70+ where i = index e
71+ empty = Entry '\0' maxBound 0
72+
73+nextPowerOf2 :: Int -> Int
74+nextPowerOf2 0 = 1
75+nextPowerOf2 x = go (x - 1) 1
76+ where go y 32 = y + 1
77+ go y k = go (y .|. (y `shiftR` k)) $ k * 2
78+
79+fastHash :: Char -> Int
80+fastHash = fromEnum
81+
82+fromList :: String -> FastSet
83+fromList s = FastSet (AB.listArray (0, length interleaved - 1) interleaved)
84+ mask'
85+ where s' = ordNub (sort s)
86+ l = length s'
87+ mask' = nextPowerOf2 ((5 * l) `div` 4) - 1
88+ entries = pad mask' .
89+ resolveCollisions .
90+ sortBy (compare `on` initialIndex) .
91+ zipWith (\c i -> Entry c i i) s' .
92+ map ((.&. mask') . fastHash) $ s'
93+ interleaved = concatMap (\e -> [fromEnum $ key e, initialIndex e])
94+ entries
95+
96+ordNub :: Eq a => [a] -> [a]
97+ordNub [] = []
98+ordNub (y:ys) = go y ys
99+ where go x (z:zs)
100+ | x == z = go x zs
101+ | otherwise = x : go z zs
102+ go x [] = [x]
103+
104+set :: T.Text -> FastSet
105+set = fromList . T.unpack
106+
107+-- | Check the set for membership.
108+member :: Char -> FastSet -> Bool
109+member c a = go (2 * i)
110+ where i = fastHash c .&. mask a
111+ lookupAt j b = (i' <= i) && (c == c' || b)
112+ where c' = toEnum $ AB.unsafeAt (table a) j
113+ i' = AB.unsafeAt (table a) $ j + 1
114+ go j = lookupAt j . lookupAt (j + 2) . lookupAt (j + 4) .
115+ lookupAt (j + 6) . go $ j + 8
116+
117+charClass :: String -> FastSet
118+charClass = fromList . go
119+ where go (a:'-':b:xs) = [a..b] ++ go xs
120+ go (x:xs) = x : go xs
121+ go _ = ""
benchmarks/attoparsec-benchmarks.cabal+4
@@ -16,6 +16,8 @@ executable attoparsec-benchmarks
16 Links
16 Links
17 Numbers
17 Numbers
18 Network.Wai.Handler.Warp.ReadInt
18 Network.Wai.Handler.Warp.ReadInt
19+ Sets
20+ TextFastSet
19 Warp
21 Warp
20 hs-source-dirs: .. . warp-3.0.1.1
22 hs-source-dirs: .. . warp-3.0.1.1
21 ghc-options: -O2 -Wall -rtsopts
23 ghc-options: -O2 -Wall -rtsopts
@@ -24,6 +26,7 @@ executable attoparsec-benchmarks
24 base == 4.*,
26 base == 4.*,
25 bytestring >= 0.10.4.0,
27 bytestring >= 0.10.4.0,
26 case-insensitive,
28 case-insensitive,
29+ containers,
27 criterion >= 1.0,
30 criterion >= 1.0,
28 deepseq >= 1.1,
31 deepseq >= 1.1,
29 directory,
32 directory,
@@ -33,5 +36,6 @@ executable attoparsec-benchmarks
33 parsec >= 3.1.2,
36 parsec >= 3.1.2,
34 scientific >= 0.3.1,
37 scientific >= 0.3.1,
35 text >= 1.1.1.0,
38 text >= 1.1.1.0,
39+ transformers,
36 unordered-containers,
40 unordered-containers,
37 vector
41 vector
benchmarks/http-request.txt+3−8
@@ -1,14 +1,9 @@
1GET / HTTP/1.1
1GET / HTTP/1.1
2Host: twitter.com
2Host: twitter.com
3−Accept: text/html, application/xhtml+xml, application/xml; q=0.9,
3+Accept: text/html, application/xhtml+xml, application/xml; q=0.9, image/webp, */*; q=0.8
4− image/webp, */*; q=0.8
5Accept-Encoding: gzip,deflate,sdch
4Accept-Encoding: gzip,deflate,sdch
6Accept-Language: en-GB,en-US;q=0.8,en;q=0.6
5Accept-Language: en-GB,en-US;q=0.8,en;q=0.6
7Cache-Control: max-age=0
6Cache-Control: max-age=0
8−Cookie: guest_id=v1%3A139; _twitter_sess=BAh7CSIKZmxhc2hJQz-e1e1;
7+Cookie: guest_id=v1%3A139; _twitter_sess=BAh7CSIKZmxhc2hJQz-e1e1; __utma=43838368.452555194.1399611824.1; __utmb=43838368; __utmc=43838368; __utmz=1399611824.1.1.utmcsr=(direct)|utmcmd=(none)
9− __utma=43838368.452555194.1399611824.1; __utmb=43838368;
10− __utmc=43838368; __utmz=1399611824.1.1.utmcsr=(direct)|utmcmd=(none)
11−User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5)
12− AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.86
8+User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.86 Safari/537.36
13− Safari/537.36
14
9
benchmarks/http-response.txt+2−4
@@ -3,10 +3,8 @@ Date: Fri, 09 May 2014 04:24:57 GMT
3Expires: -1
3Expires: -1
4Cache-Control: private, max-age=0
4Cache-Control: private, max-age=0
5Content-Type: text/html; charset=ISO-8859-1
5Content-Type: text/html; charset=ISO-8859-1
6−Set-Cookie: PREF=ID=1a871afc4240db5e:FF:LM=1399609497:S=e5MZ0itEekjVwNcU;
6+Set-Cookie: PREF=ID=1a871afc4240db5e:FF:LM=1399609497:S=e5MZ0itEekjVwNcU; expires=Sun, 08-May-2016 04:24:57 GMT; path=/; domain=.google.com
7− expires=Sun, 08-May-2016 04:24:57 GMT; path=/; domain=.google.com
8−Set-Cookie: NID=67=-WlfaDG6VSEPk7abAjrK98HBSoCD2ID6JKkUR95tEumzDmg7Fc8pSQ8;
7+Set-Cookie: NID=67=-WlfaDG6VSEPk7abAjrK98HBSoCD2ID6JKkUR95tEumzDmg7Fc8pSQ8; expires=Sat, 08-Nov-2014 04:24:57 GMT; path=/; domain=.google.com; HttpOnly
9− expires=Sat, 08-Nov-2014 04:24:57 GMT; path=/; domain=.google.com; HttpOnly
10P3P: CP="This is not a P3P policy! See http://www.google.com/support/accounts/bin/answer.py?hl=en&answer=151657 for more info."
8P3P: CP="This is not a P3P policy! See http://www.google.com/support/accounts/bin/answer.py?hl=en&answer=151657 for more info."
11Server: gws
9Server: gws
12X-XSS-Protection: 1; mode=block
10X-XSS-Protection: 1; mode=block
changelog.md+26
@@ -1,3 +1,29 @@
1+0.13.2.1
2+
3+* Improved performance of `Data.Attoparsec.Text.asciiCI`
4+
5+0.13.2.0
6+
7+* `pure` is now strict in `Position`
8+
9+0.13.1.0
10+
11+* `runScanner` now correctly returns the final state
12+ (https://github.com/bos/attoparsec/issues/105).
13+* `Parser`, `ZeptoT`, `Buffer`, and `More` now expose `Semigroup` instances.
14+* `Parser`, and `ZeptoT` now expose `MonadFail` instances.
15+
16+0.13.0.2
17+
18+* Restore the fast specialised character set implementation for Text
19+* Move testsuite from test-framework to tasty
20+* Performance optimization of takeWhile and takeWhile1
21+
22+0.13.0.1
23+
24+* Fixed a bug in the implementations of inClass and notInClass for
25+ Text (https://github.com/bos/attoparsec/issues/103)
26+
10.13.0.0
270.13.0.0
2
28
3* Made the parser type in the Zepto module a monad transformer
29* Made the parser type in the Zepto module a monad transformer
tests/QC.hs+2−2
@@ -6,11 +6,11 @@ import qualified QC.ByteString as ByteString
6import qualified QC.Combinator as Combinator
6import qualified QC.Combinator as Combinator
7import qualified QC.Simple as Simple
7import qualified QC.Simple as Simple
8import qualified QC.Text as Text
8import qualified QC.Text as Text
9−import Test.Framework (defaultMain, testGroup)
9+import Test.Tasty (defaultMain, testGroup)
10
10
11main = defaultMain tests
11main = defaultMain tests
12
12
13−tests = [
13+tests = testGroup "tests" [
14 testGroup "bs" ByteString.tests
14 testGroup "bs" ByteString.tests
15 , testGroup "buf" Buffer.tests
15 , testGroup "buf" Buffer.tests
16 , testGroup "combinator" Combinator.tests
16 , testGroup "combinator" Combinator.tests
tests/QC/Buffer.hs+3−3
@@ -8,8 +8,8 @@ import Control.Applicative ((<$>))
8import Data.Monoid (Monoid(mconcat))
8import Data.Monoid (Monoid(mconcat))
9#endif
9#endif
10import QC.Common ()
10import QC.Common ()
11−import Test.Framework (Test)
11+import Test.Tasty (TestTree)
12−import Test.Framework.Providers.QuickCheck2 (testProperty)
12+import Test.Tasty.QuickCheck (testProperty)
13import Test.QuickCheck
13import Test.QuickCheck
14import qualified Data.Attoparsec.ByteString.Buffer as BB
14import qualified Data.Attoparsec.ByteString.Buffer as BB
15import qualified Data.Attoparsec.Text.Buffer as BT
15import qualified Data.Attoparsec.Text.Buffer as BT
@@ -82,7 +82,7 @@ t_dropWord16 (BP _ts t buf) = do
82 i <- choose (0, T.lengthWord16 t)
82 i <- choose (0, T.lengthWord16 t)
83 return $ T.dropWord16 i t === BT.dropWord16 i buf
83 return $ T.dropWord16 i t === BT.dropWord16 i buf
84
84
85−tests :: [Test]
85+tests :: [TestTree]
86tests = [
86tests = [
87 testProperty "b_unbuffer" b_unbuffer
87 testProperty "b_unbuffer" b_unbuffer
88 , testProperty "t_unbuffer" t_unbuffer
88 , testProperty "t_unbuffer" t_unbuffer
tests/QC/ByteString.hs+7−5
@@ -9,8 +9,8 @@ import Data.Int (Int64)
9import Data.Word (Word8)
9import Data.Word (Word8)
10import Prelude hiding (take, takeWhile)
10import Prelude hiding (take, takeWhile)
11import QC.Common (ASCII(..), liftOp, parseBS, toStrictBS)
11import QC.Common (ASCII(..), liftOp, parseBS, toStrictBS)
12−import Test.Framework (Test)
12+import Test.Tasty (TestTree)
13−import Test.Framework.Providers.QuickCheck2 (testProperty)
13+import Test.Tasty.QuickCheck (testProperty)
14import Test.QuickCheck
14import Test.QuickCheck
15import qualified Data.Attoparsec.ByteString as P
15import qualified Data.Attoparsec.ByteString as P
16import qualified Data.Attoparsec.ByteString.Char8 as P8
16import qualified Data.Attoparsec.ByteString.Char8 as P8
@@ -26,9 +26,11 @@ import qualified Data.ByteString.Lazy.Char8 as L8
26satisfy :: Word8 -> L.ByteString -> Property
26satisfy :: Word8 -> L.ByteString -> Property
27satisfy w s = parseBS (P.satisfy (<=w)) (L.cons w s) === Just w
27satisfy w s = parseBS (P.satisfy (<=w)) (L.cons w s) === Just w
28
28
29−satisfyWith :: Char -> L.ByteString -> Property
29+satisfyWith :: Word8 -> L.ByteString -> Property
30−satisfyWith c s = parseBS (P.satisfyWith (chr . fromIntegral) (<=c))
30+satisfyWith w s = parseBS (P.satisfyWith (chr . fromIntegral) (<=c))
31 (L.cons (fromIntegral (ord c)) s) === Just c
31 (L.cons (fromIntegral (ord c)) s) === Just c
32+ where
33+ c = chr (fromIntegral w)
32
34
33word8 :: Word8 -> L.ByteString -> Property
35word8 :: Word8 -> L.ByteString -> Property
34word8 w s = parseBS (P.word8 w) (L.cons w s) === Just w
36word8 w s = parseBS (P.word8 w) (L.cons w s) === Just w
@@ -155,7 +157,7 @@ nonmembers :: [Word8] -> [Word8] -> Property
155nonmembers s s' = property . not . any (`S.memberWord8` set) $ filter (not . (`elem` s)) s'
157nonmembers s s' = property . not . any (`S.memberWord8` set) $ filter (not . (`elem` s)) s'
156 where set = S.fromList s
158 where set = S.fromList s
157
159
158−tests :: [Test]
160+tests :: [TestTree]
159tests = [
161tests = [
160 testProperty "anyWord8" anyWord8
162 testProperty "anyWord8" anyWord8
161 , testProperty "endOfInput" endOfInput
163 , testProperty "endOfInput" endOfInput
tests/QC/Combinator.hs+3−3
@@ -8,8 +8,8 @@ import Control.Applicative ((<*>), (<$>), (<*), (*>))
8import Data.Maybe (fromJust, isJust)
8import Data.Maybe (fromJust, isJust)
9import Data.Word (Word8)
9import Data.Word (Word8)
10import QC.Common (Repack, parseBS, repackBS, toLazyBS)
10import QC.Common (Repack, parseBS, repackBS, toLazyBS)
11−import Test.Framework (Test)
11+import Test.Tasty (TestTree)
12−import Test.Framework.Providers.QuickCheck2 (testProperty)
12+import Test.Tasty.QuickCheck (testProperty)
13import Test.QuickCheck
13import Test.QuickCheck
14import qualified Data.Attoparsec.ByteString.Char8 as P
14import qualified Data.Attoparsec.ByteString.Char8 as P
15import qualified Data.Attoparsec.Combinator as C
15import qualified Data.Attoparsec.Combinator as C
@@ -43,7 +43,7 @@ match n (NonNegative x) (NonNegative y) rs =
43 B8.replicate x 'x', B8.pack (show n), B8.replicate y 'y'
43 B8.replicate x 'x', B8.pack (show n), B8.replicate y 'y'
44 ]
44 ]
45
45
46−tests :: [Test]
46+tests :: [TestTree]
47tests = [
47tests = [
48 testProperty "choice" choice
48 testProperty "choice" choice
49 , testProperty "count" count
49 , testProperty "count" count
tests/QC/Simple.hs+3−3
@@ -10,8 +10,8 @@ import Data.ByteString (ByteString)
10import Data.List (foldl')
10import Data.List (foldl')
11import Data.Maybe (fromMaybe)
11import Data.Maybe (fromMaybe)
12import QC.Rechunked (rechunkBS)
12import QC.Rechunked (rechunkBS)
13−import Test.Framework (Test)
13+import Test.Tasty (TestTree)
14−import Test.Framework.Providers.QuickCheck2 (testProperty)
14+import Test.Tasty.QuickCheck (testProperty)
15import Test.QuickCheck (Property, counterexample, forAll)
15import Test.QuickCheck (Property, counterexample, forAll)
16import qualified Data.Attoparsec.ByteString.Char8 as A
16import qualified Data.Attoparsec.ByteString.Char8 as A
17
17
@@ -31,7 +31,7 @@ parse :: A.Parser r -> [ByteString] -> A.Result r
31parse p (x:xs) = foldl' A.feed (A.parse p x) xs
31parse p (x:xs) = foldl' A.feed (A.parse p x) xs
32parse p [] = A.parse p ""
32parse p [] = A.parse p ""
33
33
34−tests :: [Test]
34+tests :: [TestTree]
35tests = [
35tests = [
36 testProperty "issue75" t_issue75
36 testProperty "issue75" t_issue75
37 ]
37 ]
tests/QC/Text.hs+18−6
@@ -6,16 +6,21 @@ module QC.Text (tests) where
6import Control.Applicative ((<*>), (<$>))
6import Control.Applicative ((<*>), (<$>))
7#endif
7#endif
8import Data.Int (Int64)
8import Data.Int (Int64)
9+import Data.Word (Word8)
9import Prelude hiding (take, takeWhile)
10import Prelude hiding (take, takeWhile)
10import QC.Common (liftOp, parseT)
11import QC.Common (liftOp, parseT)
11−import Test.Framework (Test)
12+import qualified QC.Text.FastSet as FastSet
13+import qualified QC.Text.Regressions as Regressions
14+import Test.Tasty (TestTree, testGroup)
12−import Test.Framework.Providers.QuickCheck2 (testProperty)
15+import Test.Tasty.QuickCheck (testProperty)
13import Test.QuickCheck
16import Test.QuickCheck
14import qualified Data.Attoparsec.Text as P
17import qualified Data.Attoparsec.Text as P
15import qualified Data.Attoparsec.Text.Lazy as PL
18import qualified Data.Attoparsec.Text.Lazy as PL
16import qualified Data.Attoparsec.Text.FastSet as S
19import qualified Data.Attoparsec.Text.FastSet as S
20+import qualified Data.ByteString as BS
17import qualified Data.Char as Char
21import qualified Data.Char as Char
18import qualified Data.Text as T
22import qualified Data.Text as T
23+import qualified Data.Text.Encoding as TE
19import qualified Data.Text.Lazy as L
24import qualified Data.Text.Lazy as L
20
25
21-- Basic byte-level combinators.
26-- Basic byte-level combinators.
@@ -68,9 +73,12 @@ strings s t u =
68 === Just t'
73 === Just t'
69 where t' = toStrict t
74 where t' = toStrict t
70
75
76+-- | Note: "simple, and efficient" works for well formed input...
77+-- i.e. e.g. Latin1 texts
71−stringCI :: T.Text -> Property
78+stringCI :: [Word8] -> Property
72−stringCI s = P.parseOnly (P.stringCI fs) s === Right s
79+stringCI ws = P.parseOnly (P.stringCI fs) s === Right s
73 where fs = T.toCaseFold s
80 where fs = T.toCaseFold s
81+ s = TE.decodeLatin1 (BS.pack ws)
74
82
75asciiCI :: T.Text -> Gen Bool
83asciiCI :: T.Text -> Gen Bool
76asciiCI x =
84asciiCI x =
@@ -148,7 +156,9 @@ endOfLine s =
148 (c, fst <$> L.uncons s') === ('\r', Just '\n')
156 (c, fst <$> L.uncons s') === ('\r', Just '\n')
149
157
150scan :: L.Text -> Positive Int64 -> Property
158scan :: L.Text -> Positive Int64 -> Property
159+-- for some reason, if counterexample is removed, this test fails?
160+scan s (Positive k) = counterexample (show s)
151−scan s (Positive k) = parseT p s === Just (toStrict $ L.take k s)
161+ $ parseT p s === Just (toStrict $ L.take k s)
152 where p = P.scan k $ \ n _ ->
162 where p = P.scan k $ \ n _ ->
153 if n > 0 then let !n' = n - 1 in Just n' else Nothing
163 if n > 0 then let !n' = n - 1 in Just n' else Nothing
154
164
@@ -160,7 +170,7 @@ nonmembers :: String -> String -> Property
160nonmembers s s' = property . not . any (`S.member` set) $ filter (not . (`elem` s)) s'
170nonmembers s s' = property . not . any (`S.member` set) $ filter (not . (`elem` s)) s'
161 where set = S.fromList s
171 where set = S.fromList s
162
172
163−tests :: [Test]
173+tests :: [TestTree]
164tests = [
174tests = [
165 testProperty "anyChar" anyChar
175 testProperty "anyChar" anyChar
166 , testProperty "asciiCI" asciiCI
176 , testProperty "asciiCI" asciiCI
@@ -188,4 +198,6 @@ tests = [
188 , testProperty "takeWhile1_empty" takeWhile1_empty
198 , testProperty "takeWhile1_empty" takeWhile1_empty
189 , testProperty "members" members
199 , testProperty "members" members
190 , testProperty "nonmembers" nonmembers
200 , testProperty "nonmembers" nonmembers
201+ , testGroup "FastSet" FastSet.tests
202+ , testGroup "Regressions" Regressions.tests
191 ]
203 ]
tests/QC/Text/FastSet.hsnew file+15
@@ -0,0 +1,15 @@
1+module QC.Text.FastSet where
2+
3+import Test.Tasty (TestTree)
4+import Test.Tasty.QuickCheck (testProperty)
5+import Test.QuickCheck
6+import qualified Data.Attoparsec.Text.FastSet as FastSet
7+
8+membershipCorrect :: String -> String -> Property
9+membershipCorrect members others =
10+ let fs = FastSet.fromList members
11+ correct c = (c `FastSet.member` fs) == (c `elem` members)
12+ in property $ all correct (members ++ others)
13+
14+tests :: [TestTree]
15+tests = [ testProperty "membership is correct" membershipCorrect ]
tests/QC/Text/Regressions.hsnew file+54
@@ -0,0 +1,54 @@
1+{-# LANGUAGE OverloadedStrings #-}
2+
3+module QC.Text.Regressions (
4+ tests
5+ ) where
6+
7+import Data.Text (Text)
8+import qualified Data.Text as T
9+import Data.List (foldl')
10+import Data.Maybe (fromMaybe)
11+import Data.Char (isLower)
12+import Data.Monoid ((<>))
13+import QC.Rechunked (rechunkT)
14+import Test.Tasty (TestTree)
15+import Test.Tasty.QuickCheck (testProperty)
16+import Test.QuickCheck (Property, counterexample, forAll)
17+import qualified Data.Attoparsec.Text as A
18+
19+
20+--------------------------------------------------------------------------------
21+-- 105 was about runScanner not always returning the final state. The result
22+-- did depend on how the data was fed to the parser.
23+
24+t_issue105 :: Property
25+t_issue105 = expect issue105 "lowER" (A.Done "ER" "low")
26+
27+issue105 :: A.Parser Text
28+issue105 = do
29+ (_, firstFourLowercaseLetters) <- A.runScanner "" f
30+ return $ firstFourLowercaseLetters
31+
32+ where
33+ f :: Text -> Char -> Maybe Text
34+ f acc c = if T.length acc < 4 && isLower c
35+ then Just $ acc <> T.singleton c
36+ else Nothing
37+
38+
39+expect :: (Show r, Eq r) => A.Parser r -> Text -> A.Result r -> Property
40+expect p input wanted =
41+ forAll (rechunkT input) $ \in' ->
42+ let result = parse p in'
43+ in counterexample (show result ++ " /= " ++ show wanted) $
44+ fromMaybe False (A.compareResults result wanted)
45+
46+parse :: A.Parser r -> [Text] -> A.Result r
47+parse p (x:xs) = foldl' A.feed (A.parse p x) xs
48+parse p [] = A.parse p ""
49+
50+
51+tests :: [TestTree]
52+tests = [
53+ testProperty "issue105" t_issue105
54+ ]