git.iko.soy/typeable/elm-ui
on master help sign in
resolves #203, does not regress #147, and sheds some other light on stuff
42d0daemdgriffith
src/Internal/Model.elm+3−1
compare with master
unifiedsplit
@@ -1478,7 +1478,9 @@ renderHeight h =
1478 Single
1478 Single
1479 cls
1479 cls
1480 "min-height"
1480 "min-height"
1481+ -- This needs to be !important because we're using `min-height: min-content`
1482+ -- to correct for safari's incorrect implementation of flexbox.
1481− (String.fromInt minSize ++ "px")
1483+ (String.fromInt minSize ++ "px !important")
1482
1484
1483 ( newFlag, newAttrs, newStyle ) =
1485 ( newFlag, newAttrs, newStyle ) =
1484 renderHeight len
1486 renderHeight len
src/Internal/Style.elm+9−1
@@ -1384,7 +1384,15 @@ baseSheet =
1384 -- This apparently is a different story for columns.
1384 -- This apparently is a different story for columns.
1385 -- Safari has an issue if this is flex-basis: 0%, as it goes entirely to 0,
1385 -- Safari has an issue if this is flex-basis: 0%, as it goes entirely to 0,
1386 -- instead of the expected content size.
1386 -- instead of the expected content size.
1387+ -- So we add `min-height: min-content`, which isn't supported by IE, but works for all other browsers!
1388+ -- Separately, 0% is different than 0px, but only for columns
1389+ -- In columns, 0% will actually be calculated as `auto` for columns
1390+ -- So, 0px is the one we want.
1391+ [ Prop "flex-basis" "0px"
1392+ , Prop "min-height" "min-content"
1393+ , Descriptor (dot classes.heightExact)
1387− [ Prop "flex-basis" "auto"
1394+ [ Prop "flex-basis" "auto"
1395+ ]
1388 ]
1396 ]
1389 , Child (dot classes.heightFill)
1397 , Child (dot classes.heightFill)
1390 [ Prop "flex-grow" "100000"
1398 [ Prop "flex-grow" "100000"