git.iko.soy/typeable/generic-arbitrary
on master help sign in
27 files changed+791−128
since splitsnapshots
unifiedsplit
.github/workflows/haskell-ci.yml+29 .gitignore+2 .travis.yml+1 CHANGELOG.md+33 README.md+138−1 generic-arbitrary.cabal+50−36 ghc-8.10.7.yaml+1 ghc-8.10.7.yaml.lock+12 ghc-8.6.5.yaml+1 ghc-8.6.5.yaml.lock+12 ghc-9.0.2.yaml+1 ghc-9.0.2.yaml.lock+12 ghc-9.2.4.yaml+1 ghc-9.2.4.yaml.lock+12 ghc-9.4.3.yaml+1 ghc-9.4.3.yaml.lock+12 ghc-9.8.1.yaml+1 ghc-9.8.1.yaml.lock+12 src/Test/QuickCheck/Arbitrary/Generic.hs+216−51 stack.yaml+1−5 stack.yaml.lock+5−19 test/Auxiliary.hs+10 test/EnumTest.hs+24 test/LimitationDemo.hs+37 test/NoTypecheckTest.hs+23 test/ParametersTest.hs+34 test/RecursiveTest.hs+110−16
.github/workflows/haskell-ci.ymlnew file+29
@@ -0,0 +1,29 @@
1+name: Haskell-CI
2+on: [push, pull_request]
3+jobs:
4+ linux:
5+ name: GHC-${{ matrix.ghc-version }}
6+ runs-on: ubuntu-latest
7+ strategy:
8+ matrix:
9+ ghc-version:
10+ - 8.6.5
11+ - 8.10.7
12+ - 9.0.2
13+ - 9.2.4
14+ - 9.4.3
15+ - 9.8.1
16+ steps:
17+ - uses: actions/checkout@v3
18+ - uses: haskell/actions/setup@v2
19+ with:
20+ enable-stack: true
21+ ghc-version: ${{ matrix.ghc-version }}
22+ stack-version: 'latest'
23+ - uses: actions/cache@v3
24+ with:
25+ path: |
26+ ~/.stack
27+ ./.stack-work
28+ key: ${{ matrix.ghc-version }}
29+ - run: stack --stack-yaml ghc-${{ matrix.ghc-version }}.yaml --install-ghc test --fast --haddock
.gitignore+2
@@ -3,3 +3,5 @@ dist
33.stack-work
44.cabal-sandbox/
55cabal.sandbox.config
6+dist-newstyle
7+TAGS
.travis.yml+1
@@ -107,6 +107,7 @@ install:
107107 - rm cabal.project.freeze
108108 - travis_wait 40 ${CABAL} v2-build $WITHCOMPILER ${TEST} ${BENCH} --dep -j2 all
109109 - travis_wait 40 ${CABAL} v2-build $WITHCOMPILER --disable-tests --disable-benchmarks --dep -j2 all
110+ - travis_wait 40 ${CABAL} v2-install $WITHCOMPILER --disable-tests --disable-benchmarks -j2 tasty-discover
110111script:
111112 - DISTDIR=$(mktemp -d /tmp/dist-test.XXXX)
112113 # Packaging...
CHANGELOG.md+33
@@ -1,3 +1,36 @@
1+1.0.1.2
2+-------
3+
4+* Fix dependency bounds (including retroactively), and compilation with warnings.
5+
6+1.0.1.1
7+-------
8+
9+* Fix compilation with GHC 9.8.3
10+
11+1.0.1
12+-----
13+
14+* Compillability by GHC-9.2.4
15+* Fix cabal `tested-with` field
16+
17+1.0.0
18+-----
19+
20+* Fixed issue with too big terms in case of recursive types
21+* Recpect the `size` argument
22+* Types with parameters require `Arg` now
23+
24+0.2.2
25+-----
26+
27+* Resolved an issue where the size of the generators could become negative
28+
29+0.2.1
30+-----
31+
32+* Added compatibility with GHC 9.2.1
33+
1340.2.0
235-----
336
README.md+138−1
@@ -1,3 +1,140 @@
11# generic-arbitrary
22
3−[![Build Status](https://travis-ci.org/typeable/generic-arbitrary.svg?branch=master)](https://travis-ci.org/typeable/generic-arbitrary)
3+[![Haskell-CI](https://github.com/typeable/generic-arbitrary/actions/workflows/haskell-ci.yml/badge.svg)](https://github.com/typeable/generic-arbitrary/actions/workflows/haskell-ci.yml)
4+
5+# What?
6+
7+Package for deriving `Arbitrary` via `Generic`.
8+
9+``` haskell
10+import GHC.Generics (Generic)
11+import Test.QuickCheck
12+import Test.QuickCheck.Arbitrary.Generic
13+
14+data Expr
15+ = Lit Int
16+ | Add Expr Expr
17+ | Mul Expr Expr
18+ deriving (Eq, Show, Generic)
19+ deriving Arbitrary via (GenericArbitrary Expr)
20+```
21+
22+Older versions of this package had a problem with hanging `arbitrary`
23+method. Since `1.0.0` this problem almost solved.
24+
25+For `QuickCheck` older than `2.14.0` the `GenericArbitrary` is not available, so
26+you will need to write instances more verbosely
27+
28+``` haskell
29+data Expr
30+ = Lit Int
31+ | Add Expr Expr
32+ | Mul Expr Expr
33+ deriving (Eq, Show, Generic)
34+
35+instance Arbitrary Expr where
36+ arbitrary = genericArbitrary
37+ shrink = genericShrink
38+```
39+
40+Which is generally the same.
41+
42+# Infinite terms problem
43+
44+The `generic-arbitrary` can partially handle the problem with recursive
45+types. Assume the type `R`
46+
47+``` haskell
48+data R = R R
49+ deriving Generic
50+```
51+
52+there is no instance
53+
54+``` haskell
55+instance Arbitrary R where
56+ arbitrary = genericArbitrary
57+ shrink = genericShrink
58+```
59+
60+If you try to compile this you will get a type level error
61+
62+> • R refers to itself in all constructors
63+
64+Which means that there is no finite term for `R` because it is recursive in all
65+it's constructors. But, if you correct the definition of `R` like this.
66+
67+``` haskell
68+data R = R R | F
69+ deriving Generic
70+```
71+
72+Then it will compile. And the `arbitrary` generated will not hang forever,
73+because it respects the `size` parameter.
74+
75+## Limitation
76+
77+There is a limitation of recursion detection:
78+
79+``` haskell
80+data R1 = R1 R2
81+ deriving (Eq, Ord, Show, Generic)
82+ deriving anyclass NFData
83+ deriving Arbitrary via (GenericArbitrary R1)
84+
85+data R2 = R2 R1
86+ deriving (Eq, Ord, Show, Generic)
87+ deriving anyclass NFData
88+ deriving Arbitrary via (GenericArbitrary R2)
89+```
90+
91+This code will compile and the `arbitrary` generated will always hang. Yes,
92+there is a problem with mutually recursive types.
93+
94+# Type parameters
95+
96+Now let's see an example of datatype with parameters
97+
98+``` haskell
99+data A a = A a
100+ deriving (Eq, Ord, Show)
101+ deriving anyclass NFData
102+ deriving (Generic)
103+
104+instance (Arbitrary a) => Arbitrary (A a) where
105+ arbitrary = genericArbitrary
106+ shrink = genericShrink
107+```
108+
109+It should work from first glance, but when compile it will throw an error:
110+
111+```
112+• Could not deduce (Test.QuickCheck.Arbitrary.Generic.GArbitrary
113+ (A a)
114+ (GHC.Generics.D1
115+ ('GHC.Generics.MetaData "A" "ParametersTest" "main" 'False)
116+ (GHC.Generics.C1
117+ ('GHC.Generics.MetaCons "A" 'GHC.Generics.PrefixI 'False)
118+ (GHC.Generics.S1
119+ ('GHC.Generics.MetaSel
120+ 'Nothing
121+ 'GHC.Generics.NoSourceUnpackedness
122+ 'GHC.Generics.NoSourceStrictness
123+ 'GHC.Generics.DecidedLazy)
124+ (GHC.Generics.Rec0 a))))
125+ (TypesDiffer (A a) a))
126+ arising from a use of ‘genericArbitrary’
127+```
128+
129+Here the `TypesDiffer` is a type familty dealing with recursive types and
130+helping us to eliminate inproper instances. To convince the compiller, that the
131+`a` parameter is not an `A a` we must fix the instance with additional
132+constraint `Arg (A a) a`
133+
134+``` haskell
135+instance (Arg (A a) a, Arbitrary a) => Arbitrary (A a) where
136+ arbitrary = genericArbitrary
137+ shrink = genericShrink
138+```
139+
140+Now everything compiles and works as expected.
generic-arbitrary.cabal+50−36
@@ -1,10 +1,10 @@
11name: generic-arbitrary
2−version: 0.2.0
2+version: 1.0.1.2
33synopsis: Generic implementation for QuickCheck's Arbitrary
44description:
55 Generic implementations of methods of the 'Arbitrary' class from the
66 QuickCheck library. The approach taken here can lead to diverging instances
7− for recursive types but is safe for non-recursive ones and guarantees
7+ for mutually recursive types but is safe for simply recursive ones and guarantees
88 flat distribution for constructors of sum-types.
99
1010license: MIT
@@ -15,52 +15,41 @@ homepage: http://github.com/typeable/generic-arbitrary#readme
1515category: Generic
1616build-type: Simple
1717extra-source-files: CHANGELOG.md
18−cabal-version: >=1.22
19−tested-with: GHC == 7.10.3
20− , GHC == 8.0.2
21− , GHC == 8.2.2
22− , GHC == 8.4.1
23− , GHC == 8.6.5
24− , GHC == 8.10.1
18+ , README.md
19+cabal-version: 2.0
20+tested-with: GHC == 8.6.5
21+ , GHC == 8.10.7
22+ , GHC == 9.0.2
23+ , GHC == 9.2.4
24+ , GHC == 9.4.3
25+ , GHC == 9.8.1
26+
27+source-repository head
28+ type: git
29+ location: https://github.com/typeable/generic-arbitrary.git
2530
2631library
2732 exposed-modules: Test.QuickCheck.Arbitrary.Generic
2833 build-depends: base >=4.8 && <5
29− , QuickCheck >= 2.14
30− , type-fun
34+ , QuickCheck >=2.8
3135 hs-source-dirs: src
3236 default-language: Haskell2010
3337 default-extensions: AllowAmbiguousTypes
38+ , CPP
3439 , ConstraintKinds
3540 , DataKinds
36− , DeriveFoldable
37− , DeriveFunctor
3841 , DeriveGeneric
39− , DeriveTraversable
40− , DuplicateRecordFields
4142 , FlexibleContexts
4243 , FlexibleInstances
43− , FunctionalDependencies
44− , GADTs
4544 , GeneralizedNewtypeDeriving
4645 , LambdaCase
4746 , MultiParamTypeClasses
48− , MultiWayIf
49− , NamedFieldPuns
50− , NumDecimals
51− , OverloadedLabels
52− , OverloadedStrings
5347 , PolyKinds
54− , QuasiQuotes
5548 , RankNTypes
56− , RecordWildCards
5749 , ScopedTypeVariables
58− , StandaloneDeriving
59− , TemplateHaskell
60− , TupleSections
61− , TypeApplications
6250 , TypeFamilies
6351 , TypeOperators
52+ , TypeSynonymInstances
6453 , UndecidableInstances
6554 , ViewPatterns
6655
@@ -70,18 +59,43 @@ test-suite test
7059 hs-source-dirs: test
7160 main-is: Test.hs
7261 default-language: Haskell2010
73− build-depends: base >= 4.8 && <5
74− , QuickCheck
62+ build-depends: base >=4.12 && <5
63+ , QuickCheck >=2.10
7564 , deepseq
7665 , generic-arbitrary
77− , tasty
78− , tasty-discover
66+ , tasty >=1.4.2 || <1.4.0.1
67+ , tasty-discover >= 2.0.0
68+ , tasty-hunit >= 0.9.2
7969 , tasty-quickcheck
80− other-modules: RecursiveTest
81− build-tools: tasty-discover
70+ other-modules: Auxiliary
71+ , EnumTest
72+ , LimitationDemo
73+ , NoTypecheckTest
74+ , ParametersTest
75+ , RecursiveTest
76+ default-extensions: AllowAmbiguousTypes
77+ , CPP
78+ , DataKinds
79+ , DeriveAnyClass
80+ , DeriveGeneric
81+ , DerivingStrategies
82+ , DerivingVia
83+ , FlexibleContexts
84+ , FlexibleInstances
85+ , GeneralizedNewtypeDeriving
86+ , LambdaCase
87+ , MultiParamTypeClasses
88+ , PolyKinds
89+ , RankNTypes
90+ , ScopedTypeVariables
91+ , TypeApplications
92+ , TypeFamilies
93+ , TypeOperators
94+ , TypeSynonymInstances
95+ , UndecidableInstances
96+ , ViewPatterns
97+ build-tool-depends: tasty-discover:tasty-discover
8298 ghc-options: -Wall
8399 -threaded
84100 -rtsopts
85101 "-with-rtsopts=-N -A64m -qb0 -n4m -T -I1"
86− ghc-prof-options: -fprof-auto
87− default-extensions: DeriveGeneric
ghc-8.10.7.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: lts-18.18
ghc-8.10.7.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: 63539429076b7ebbab6daa7656cfb079393bf644971156dc349d7c0453694ac2
10+ size: 586296
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/18/18.yaml
12+ original: lts-18.18
ghc-8.6.5.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: lts-13.21
ghc-8.6.5.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: eff2de19a6d4691ccbf6edc1fba858f1918683047dce0f09adede874bbd2a8f3
10+ size: 498180
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/13/21.yaml
12+ original: lts-13.21
ghc-9.0.2.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: lts-19.20
ghc-9.0.2.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: be747117bed6d462806c883352c3206325b23480825103f5c87884e97e52819a
10+ size: 619173
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/19/20.yaml
12+ original: lts-19.20
ghc-9.2.4.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: nightly-2022-08-24
ghc-9.2.4.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: ff431937a638ebfaa5e6fec13c7ae575f01e02744d6ca5e5b1554f78cb5f88ad
10+ size: 631953
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/nightly/2022/8/24.yaml
12+ original: nightly-2022-08-24
ghc-9.4.3.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: nightly-2022-12-26
ghc-9.4.3.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: bbe432b2abd6d866aa37f65a8129a5f858b7c6eaae9464f8bc2814ce92ac2d15
10+ size: 573163
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/nightly/2022/12/26.yaml
12+ original: nightly-2022-12-26
ghc-9.8.1.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: nightly-2024-01-12
ghc-9.8.1.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: 8f06e87750f95bc8620644ea22344ad023c3c5aa6efa854747aa70093898fd79
10+ size: 556465
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/nightly/2024/1/12.yaml
12+ original: nightly-2024-01-12
src/Test/QuickCheck/Arbitrary/Generic.hs+216−51
@@ -1,6 +1,14 @@
1−{- |
1+#if __GLASGOW_HASKELL__ >= 806
2+{-# OPTIONS_GHC -Wno-star-is-type #-}
3+#endif
4+#if __GLASGOW_HASKELL__ >= 800
5+{-# OPTIONS_GHC -Wno-unticked-promoted-constructors #-}
6+#endif
27
3−Generic implementation of the 'arbitrary' method. Example usage:
8+{-|
9+
10+This module is a generic implementation of the 'arbitrary' method. Example
11+usage:
412
513@
614data Foo = Foo
@@ -25,57 +33,203 @@ data Foo = Foo
2533
2634The generated 'arbitrary' method is equivalent to
2735
28−@Foo <$> arbitrary <*> arbitrary@.
36+@
37+Foo '<$>' arbitrary '<*>' arbitrary
38+@.
39+
40+It can also handle a recursive types problem. Assuming a type
41+
42+@
43+data R = R R
44+ deriving Generic
45+@
46+
47+there is no instance
48+
49+@
50+instance Arbitrary R where
51+ arbitrary = genericArbitrary
52+ shrink = genericShrink
53+@
54+
55+If you try to compile this you will get a type level error
56+
57+> • R refers to itself in all constructors
58+
59+Which means that there is no finite term for @R@ because it is recursive. But,
60+if you correct the definition of @R@ like this.
61+
62+@
63+data R = R R | F
64+ deriving Generic
65+@
66+
67+Then it will compile. And the @arbitrary@ generated will not hang forever, because
68+it respects the @size@ parameter.
69+
70+There is a limitation of recursion detection:
71+
72+@
73+data R1 = R1 R2
74+ deriving (Eq, Ord, Show, Generic)
75+ deriving anyclass NFData
76+ deriving Arbitrary via (GenericArbitrary R1)
77+
78+data R2 = R2 R1
79+ deriving (Eq, Ord, Show, Generic)
80+ deriving anyclass NFData
81+ deriving Arbitrary via (GenericArbitrary R2)
82+@
83+
84+This code will compile and the @arbitrary@ generated will always hang. Yes,
85+there is a problem with mutually recursive types.
86+
87+Now lets see an example of datatype with parameters
88+
89+@
90+data A a = A a
91+ deriving (Eq, Ord, Show)
92+ deriving anyclass NFData
93+ deriving (Generic)
94+
95+instance (Arbitrary a) => Arbitrary (A a) where
96+ arbitrary = genericArbitrary
97+ shrink = genericShrink
98+@
99+
100+It should work from first glance, but when compile it will throw an error:
101+
102+@
103+ • Could not deduce (Test.QuickCheck.Arbitrary.Generic.GArbitrary
104+ (A a)
105+ (GHC.Generics.D1
106+ ('GHC.Generics.MetaData "A" "ParametersTest" "main" 'False)
107+ (GHC.Generics.C1
108+ ('GHC.Generics.MetaCons "A" 'GHC.Generics.PrefixI 'False)
109+ (GHC.Generics.S1
110+ ('GHC.Generics.MetaSel
111+ 'Nothing
112+ 'GHC.Generics.NoSourceUnpackedness
113+ 'GHC.Generics.NoSourceStrictness
114+ 'GHC.Generics.DecidedLazy)
115+ (GHC.Generics.Rec0 a))))
116+ (TypesDiffer (A a) a))
117+ arising from a use of ‘genericArbitrary’
118+@
119+
120+Here the @TypesDiffer@ is a type familty dealing with recursive types and
121+helping us to eliminate inproper instances. To convince the compiller, that the
122+@a@ parameter is not an @A a@ we must fix the instance with additional constraint
123+
124+@
125+instance (Arg (A a) a, Arbitrary a) => Arbitrary (A a) where
126+ arbitrary = genericArbitrary
127+ shrink = genericShrink
128+@
129+
130+Now everything compiles and works as expected.
29131
30132-}
31133
32134module Test.QuickCheck.Arbitrary.Generic
33− ( GenericArbitrary(..)
135+ ( -- * Main
136+ genericArbitrary
137+#if MIN_VERSION_QuickCheck(2, 14, 0)
138+ , GenericArbitrary(..)
139+#endif
140+ , Arg
141+ -- * Internal
142+ , GArbitrary
143+ , FiniteSum
144+ , FiniteSumElem
145+ , Finite
146+ , AllFieldsFinal
147+ , TypesDiffer
148+ , ArgumentsCount
149+ , SumLen
150+ -- * Reexports
34151 , Arbitrary(..)
35− , genericArbitrary
36152 , genericShrink
37153 ) where
38154
39155import Control.Applicative
40−import Data.Coerce (coerce)
41156import Data.Proxy
42157import Data.Type.Bool
43158import GHC.Generics as G
44159import GHC.TypeLits
160+import Prelude
45161import Test.QuickCheck as QC
162+#if MIN_VERSION_QuickCheck(2, 14, 0)
163+import Data.Coerce (coerce)
46164import Test.QuickCheck.Arbitrary (GSubterms, RecursivelyShrink)
47−import TypeFun.Data.Eq
48−import TypeFun.Data.List
49165
166+
167+
168+-- | Newtype for @DerivingVia@
169+--
170+-- Usage:
171+--
172+-- @
173+-- data Foo = Foo
174+-- { _fooX :: X
175+-- , _fooY :: Y
176+-- } deriving (Generic)
177+-- deriving (Arbitrary) via GenericArbitrary Foo
178+-- @
179+--
180+-- @since 1.0.0
50181newtype GenericArbitrary a = GenericArbitrary { unGenericArbitrary :: a }
51182 deriving (Show, Eq)
52183
53184instance
54185 ( Generic a,
55− GArbitrary a (Rep a) 'True,
186+ GArbitrary a (Rep a) some,
56187 RecursivelyShrink (Rep a),
57188 GSubterms (Rep a) a
58189 ) => Arbitrary (GenericArbitrary a) where
59190 arbitrary = coerce (genericArbitrary :: Gen a)
60191 shrink = coerce (genericShrink :: a -> [a])
192+#endif
193+
194+-- | Constraint helper for types with parameters
195+--
196+-- Usage:
197+--
198+-- @
199+-- data A a = A a
200+-- deriving (Generic)
201+-- instance (Arg (A a) a, Arbitrary a) => Arbitrary (A a) where
202+-- arbitrary = genericArbitrary
203+-- shrink = genericShrink
204+-- @
205+--
206+-- @since 1.0.0
207+
208+type Arg self field = (TypesDiffer self field ~ 'True)
209+
210+type family TypesDiffer a b where
211+ TypesDiffer a a = 'False
212+ TypesDiffer a b = 'True
61213
62214type family AllFieldsFinal self (a :: * -> *) :: Bool where
63215 AllFieldsFinal self U1 = 'True
64216 AllFieldsFinal self (a :*: b) = AllFieldsFinal self a && AllFieldsFinal self b
65− AllFieldsFinal self (M1 S t (K1 R self)) = 'False
66− AllFieldsFinal self (M1 S t (K1 R other)) = 'True
217+ AllFieldsFinal self (M1 S t (K1 R field)) = TypesDiffer self field
67218
68219type family Finite self (a :: * -> *) :: Bool where
69220 Finite self U1 = 'True
70− -- | The constructor field is the ADT itself. Not finite.
71− Finite self (K1 R self) = 'False
72− Finite self (K1 R other) = 'True
221+ Finite self (K1 R field) = TypesDiffer self field
73222 Finite self (a :*: b) = Finite self a && Finite self b
74223 Finite self (M1 D t f) = Finite self f
75224 Finite self (a :+: b) = Finite self a || Finite self b
76225 Finite self (M1 C c f) = AllFieldsFinal self f
77226 Finite self (M1 S s f) = Finite self f
78227
228+type family ArgumentsCount (a :: * -> *) :: Nat where
229+ ArgumentsCount U1 = 1
230+ ArgumentsCount (M1 S s f) = 1
231+ ArgumentsCount (a :*: b) = (ArgumentsCount a) + (ArgumentsCount b)
232+
79233-- | Calculates count of constructors encoded by particular ':+:'.
80234-- Internal use only.
81235type family SumLen a :: Nat where
@@ -89,37 +243,40 @@ type family SumLen a :: Nat where
89243-- * a: some part of the `Rep self`
90244-- * finite: Is `a` finite? Infinite type has no finite values (like Stream)
91245class (Finite self a ~ finite) => GArbitrary self a (finite :: Bool) where
92− gArbitrary :: QC.Gen (a x)
246+ gArbitrary :: Proxy self -> QC.Gen (a x)
93247
94248instance
95− ( GArbitrary self (C1 c f) 'True
96− ) => GArbitrary self (D1 t (C1 c f)) 'True where
97− gArbitrary = M1 <$> gArbitrary @self
249+ ( GArbitrary self (M1 C c f) 'True
250+ ) => GArbitrary self (M1 D t (M1 C c f)) 'True where
251+ gArbitrary _ = M1 <$> gArbitrary (Proxy :: Proxy self)
98252
99253-- | The constructor meta information
100254instance
101255 ( GArbitrary self f some
256+ , KnownNat (ArgumentsCount f)
102257 , AllFieldsFinal self f ~ some
103− ) => GArbitrary self (C1 c f) some where
104− gArbitrary = M1 <$> scale predNat (gArbitrary @self)
258+ ) => GArbitrary self (M1 C c f) some where
259+ gArbitrary _ = M1 <$> scale predNat (gArbitrary (Proxy :: Proxy self))
105260 where
106− predNat 0 = 0
107− predNat n = pred n
261+ argumentsCount = fromIntegral $ natVal (Proxy :: Proxy (ArgumentsCount f))
262+ predNat n = max 0 $ if argumentsCount > 1
263+ then n `div` argumentsCount
264+ else pred n
108265
109266-- | Unit type instance
110267instance GArbitrary self U1 'True where
111− gArbitrary = pure U1
268+ gArbitrary _ = pure U1
112269
113270-- | Constructor field meta information
114−instance GArbitrary self f some => GArbitrary self (S1 t f) some where
115− gArbitrary = M1 <$> gArbitrary @self
271+instance GArbitrary self f some => GArbitrary self (M1 S t f) some where
272+ gArbitrary _ = M1 <$> gArbitrary (Proxy :: Proxy self)
116273
117274-- | Data of the constructor field
118275instance
119276 ( Arbitrary t
120− , Finite self (Rec0 t) ~ some
121− ) => GArbitrary self (Rec0 t) some where
122− gArbitrary = K1 <$> arbitrary
277+ , Finite self (K1 R t) ~ some
278+ ) => GArbitrary self (K1 R t) some where
279+ gArbitrary _ = K1 <$> arbitrary
123280
124281-- | Product
125282instance
@@ -127,21 +284,26 @@ instance
127284 , GArbitrary self b bf
128285 , (af && bf) ~ some
129286 ) => GArbitrary self (a :*: b) some where
130− gArbitrary = liftA2 (:*:) (gArbitrary @self) (gArbitrary @self)
287+ gArbitrary _ = liftA2 (:*:)
288+ (gArbitrary (Proxy :: Proxy self)) (gArbitrary (Proxy :: Proxy self))
131289
290+#if __GLASGOW_HASKELL__ >= 800
132291instance
133292 ( TypeError (ShowType self :<>: Text " refers to itself in all constructors")
134293 , AllFieldsFinal self f ~ 'False
135− ) => GArbitrary self (D1 t (C1 c f)) 'False where
136− gArbitrary = error "Unreachable"
294+ ) => GArbitrary self (M1 D t (M1 C c f)) 'False where
295+ gArbitrary _ = error "Unreachable"
296+#endif
137297
138298-- | ADT declaration with multiple constructors
139299instance
140300 ( FiniteSum self a b af bf
141301 , GArbitrary self (a :+: b) 'True
142− ) => GArbitrary self (D1 t (a :+: b)) 'True where
143− gArbitrary = sized $ \s -> M1 <$>
144− if s > 1 then gArbitrary @self else oneof (finiteSum @self @a @b)
302+ ) => GArbitrary self (M1 D t (a :+: b)) 'True where
303+ gArbitrary _ = sized $ \s -> M1 <$>
304+ if s > 1
305+ then gArbitrary (Proxy :: Proxy self)
306+ else oneof (finiteSum (Proxy :: Proxy self))
145307
146308-- | Any sum inside of declaration
147309instance
@@ -149,9 +311,9 @@ instance
149311 , KnownNat (SumLen a), KnownNat (SumLen b)
150312 , (af || bf) ~ some
151313 ) => GArbitrary self (a :+: b) some where
152− gArbitrary = frequency
153− [ (lfreq, G.L1 <$> gArbitrary @self)
154− , (rfreq, G.R1 <$> gArbitrary @self) ]
314+ gArbitrary _ = frequency
315+ [ (lfreq, G.L1 <$> gArbitrary (Proxy :: Proxy self))
316+ , (rfreq, G.R1 <$> gArbitrary (Proxy :: Proxy self)) ]
155317 where
156318 lfreq = fromIntegral $ natVal (Proxy :: Proxy (SumLen a))
157319 rfreq = fromIntegral $ natVal (Proxy :: Proxy (SumLen b))
@@ -159,52 +321,55 @@ instance
159321class
160322 ( Finite self a ~ af, Finite self b ~ bf
161323 ) => FiniteSum self (a :: * -> *) (b :: * -> *) af bf where
162− finiteSum :: [Gen ((a :+: b) p)]
324+ finiteSum :: Proxy self -> [Gen ((a :+: b) p)]
163325
164326instance
165327 ( FiniteSumElem self a, FiniteSumElem self b
166328 , Finite self a ~ 'True
167329 , Finite self b ~ 'True
168330 ) => FiniteSum self a b 'True 'True where
169− finiteSum = concat
170− [ fmap L1 <$> finiteElem @self @a
171− , fmap R1 <$> finiteElem @self @b]
331+ finiteSum _ = concat
332+ [ fmap L1 <$> finiteElem (Proxy :: Proxy self)
333+ , fmap R1 <$> finiteElem (Proxy :: Proxy self)]
172334
173335instance
174336 ( FiniteSumElem self a
175337 , Finite self a ~ 'True
176338 , Finite self b ~ 'False
177339 ) => FiniteSum self a b 'True 'False where
178− finiteSum = fmap L1 <$> finiteElem @self @a
340+ finiteSum _ = fmap L1 <$> finiteElem (Proxy :: Proxy self)
179341
180342instance
181343 ( FiniteSumElem self b
182344 , Finite self a ~ 'False
183345 , Finite self b ~ 'True
184346 ) => FiniteSum self a b 'False 'True where
185− finiteSum = fmap R1 <$> finiteElem @self @b
347+ finiteSum _ = fmap R1 <$> finiteElem (Proxy :: Proxy self)
186348
187349class FiniteSumElem self a where
188− finiteElem :: [Gen (a p)]
350+ finiteElem :: Proxy self -> [Gen (a p)]
189351
190352instance
191353 ( FiniteSum self a b af bf
192354 ) => FiniteSumElem self (a :+: b) where
193− finiteElem = finiteSum @self
355+ finiteElem _ = finiteSum (Proxy :: Proxy self)
194356
195357instance
196− ( GArbitrary self (C1 c f) 'True
197− ) => FiniteSumElem self (C1 c f) where
198− finiteElem = [gArbitrary @self]
358+ ( GArbitrary self (M1 C c f) 'True
359+ ) => FiniteSumElem self (M1 C c f) where
360+ finiteElem _ = [gArbitrary (Proxy :: Proxy self)]
361+
199362
363+#if __GLASGOW_HASKELL__ >= 800
200364instance
201365 ( TypeError (ShowType self :<>: Text " refers to itself in all constructors")
202366 , (Finite self a || Finite self b) ~ 'False
203− ) => GArbitrary self (D1 t (a :+: b)) 'False where
204− gArbitrary = error "Unreachable"
367+ ) => GArbitrary self (M1 D t (a :+: b)) 'False where
368+ gArbitrary _ = error "Unreachable"
369+#endif
205370
206371genericArbitrary
207372 :: forall a ga some
208373 . (Generic a, GArbitrary a ga some, ga ~ Rep a)
209374 => Gen a
210−genericArbitrary = G.to <$> gArbitrary @a
375+genericArbitrary = G.to <$> gArbitrary (Proxy :: Proxy a)
stack.yaml+1−5
@@ -1,5 +1 @@
1−resolver: lts-13.21
2−
3−extra-deps:
4− - QuickCheck-2.14
5− - splitmix-0.0.5
1+resolver: lts-19.2
stack.yaml.lock+5−19
@@ -3,24 +3,10 @@
33# For more information, please see the documentation at:
44# https://docs.haskellstack.org/en/stable/lock_files
55
6−packages:
7−- completed:
8− hackage: QuickCheck-2.14@sha256:3f536a4b86bef7ec39025f04ef8d76c5ac5a78ba0b42e660b25d0a8f9c811045,7004
9− pantry-tree:
10− size: 2203
11− sha256: 7067593c50ff2e5e83c637ac73009f4bd8f43c29ff256e976bbb14674033abe9
12− original:
13− hackage: QuickCheck-2.14
14−- completed:
15− hackage: splitmix-0.0.5@sha256:4a49661be63f5aea0e132e9ab51be918789bb4dceb4ab9b15b85ba9cbbef5999,5412
16− pantry-tree:
17− size: 1148
18− sha256: b41d4f60cfabab8b02840906191013ee06fe2357371103a471c7cc55eda9e462
19− original:
20− hackage: splitmix-0.0.5
6+packages: []
217snapshots:
228- completed:
23− size: 498180
24− url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/13/21.yaml
25− sha256: eff2de19a6d4691ccbf6edc1fba858f1918683047dce0f09adede874bbd2a8f3
26− original: lts-13.21
9+ sha256: e7e57649a12f6178d1158e4b6f1f1885ed56d210ae6174385271cecc9b1ea974
10+ size: 617368
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/19/2.yaml
12+ original: lts-19.2
test/Auxiliary.hsnew file+10
@@ -0,0 +1,10 @@
1+module Auxiliary where
2+
3+import Control.Exception
4+import Test.QuickCheck
5+
6+failGeneration :: forall a. (Arbitrary a, Show a) => IO ()
7+failGeneration = do
8+ try (generate (arbitrary :: Gen a) >>= print) >>= \case
9+ Left (_ :: SomeException) -> pure ()
10+ Right _ -> error "Error expected"
test/EnumTest.hsnew file+24
@@ -0,0 +1,24 @@
1+#if __GLASGOW_HASKELL__ >= 806 && __GLASGOW_HASKELL__ <= 900
2+{-# OPTIONS_GHC -fconstraint-solver-iterations=5 #-}
3+#elif __GLASGOW_HASKELL__ >= 902
4+{-# OPTIONS_GHC -fconstraint-solver-iterations=6 #-}
5+#endif
6+
7+
8+
9+module EnumTest where
10+
11+import Control.DeepSeq
12+import GHC.Generics
13+import Test.QuickCheck
14+import Test.QuickCheck.Arbitrary.Generic
15+
16+data Country = PL | GB | RU | RO | CZ | HR | SK | DE | NL | ES | BR
17+ deriving (Generic, NFData, Show)
18+
19+instance Arbitrary Country where
20+ arbitrary = genericArbitrary
21+ shrink = genericShrink
22+
23+prop_CountryTest :: Country -> Property
24+prop_CountryTest = total
test/LimitationDemo.hsnew file+37
@@ -0,0 +1,37 @@
1+module LimitationDemo where
2+
3+import Control.DeepSeq
4+import GHC.Generics (Generic)
5+import Test.QuickCheck
6+import Test.QuickCheck.Arbitrary.Generic
7+
8+-- As you can see, we have this instance generated, but it will definitely lead
9+-- to generating an infinite term (and the only term). The recursion detection
10+-- doesn't work here
11+data R1 = R1 R2
12+ deriving (Eq, Ord, Show, Generic)
13+ deriving anyclass NFData
14+#if MIN_VERSION_QuickCheck(2, 14, 0)
15+ deriving Arbitrary via (GenericArbitrary R1)
16+#else
17+instance Arbitrary R1 where
18+ arbitrary = genericArbitrary
19+ shrink = genericShrink
20+#endif
21+
22+data R2 = R2 R1
23+ deriving (Eq, Ord, Show, Generic)
24+ deriving anyclass NFData
25+#if MIN_VERSION_QuickCheck(2, 14, 0)
26+ deriving Arbitrary via (GenericArbitrary R2)
27+#else
28+instance Arbitrary R2 where
29+ arbitrary = genericArbitrary
30+ shrink = genericShrink
31+#endif
32+
33+-- To force the instance realy be generated
34+usage :: IO ()
35+usage = do
36+ r1 :: R1 <- generate arbitrary
37+ print r1 -- haha
test/NoTypecheckTest.hsnew file+23
@@ -0,0 +1,23 @@
1+{-# OPTIONS_GHC -fdefer-type-errors #-}
2+{-# OPTIONS_GHC -Wno-deferred-type-errors #-}
3+
4+-- | Test that infinite types has no Arbitrary instance
5+
6+module NoTypecheckTest where
7+
8+import Auxiliary
9+import GHC.Generics (Generic)
10+import Test.QuickCheck
11+import Test.QuickCheck.Arbitrary.Generic
12+
13+-- | Recursive infinite type which can not have valid Arbitrary instance
14+data R = R R
15+ deriving (Eq, Show, Generic)
16+
17+-- | Instance which must not compile, but we are using deferred type errors
18+instance Arbitrary R where
19+ arbitrary = genericArbitrary
20+ shrink = genericShrink
21+
22+unit_mustFail :: IO ()
23+unit_mustFail = failGeneration @R
test/ParametersTest.hsnew file+34
@@ -0,0 +1,34 @@
1+{-# OPTIONS_GHC -fdefer-type-errors #-}
2+{-# OPTIONS_GHC -Wno-deferred-type-errors #-}
3+
4+module ParametersTest where
5+
6+import Auxiliary
7+import Control.DeepSeq
8+import GHC.Generics (Generic)
9+import Test.QuickCheck
10+import Test.QuickCheck.Arbitrary.Generic
11+
12+data A a = A a
13+ deriving (Eq, Ord, Show)
14+ deriving anyclass NFData
15+ deriving (Generic)
16+
17+instance (Arbitrary a) => Arbitrary (A a) where
18+ arbitrary = genericArbitrary
19+ shrink = genericShrink
20+
21+data B a = B a
22+ deriving (Eq, Ord, Show)
23+ deriving anyclass NFData
24+ deriving (Generic)
25+
26+instance (Arg (B a) a, Arbitrary a) => Arbitrary (B a) where
27+ arbitrary = genericArbitrary
28+ shrink = genericShrink
29+
30+unit_argumentConstraintFail :: IO ()
31+unit_argumentConstraintFail = failGeneration @(A Int)
32+
33+prop_properArgumentConstraint :: B Int -> Property
34+prop_properArgumentConstraint = total
test/RecursiveTest.hs+110−16
@@ -1,44 +1,138 @@
1+{-# LANGUAGE DerivingStrategies #-}
2+{-# LANGUAGE DerivingVia #-}
3+{-# LANGUAGE DeriveAnyClass #-}
4+{-# OPTIONS_GHC -fconstraint-solver-iterations=5 #-} -- GHC-9.2.4
5+
6+-- | Testing that our Arbitrary instances do not get stuck and respect the
7+-- `size` parameter while generating.
8+
19module RecursiveTest where
210
3−import Control.DeepSeq
11+import Control.DeepSeq (NFData)
412import GHC.Generics (Generic)
513import Test.QuickCheck
614import Test.QuickCheck.Arbitrary.Generic
715
16+data Unit = Unit
17+ deriving (Eq, Show, Generic)
18+ deriving anyclass NFData
19+#if MIN_VERSION_QuickCheck(2, 14, 0)
20+ deriving Arbitrary via (GenericArbitrary Unit)
21+#else
22+instance Arbitrary Unit where
23+ arbitrary = genericArbitrary
24+ shrink = genericShrink
25+#endif
26+
27+prop_unitTotal :: Unit -> Property
28+prop_unitTotal = total
29+
30+data Single = Single Int
31+ deriving (Eq, Show, Generic)
32+ deriving anyclass NFData
33+#if MIN_VERSION_QuickCheck(2, 14, 0)
34+ deriving Arbitrary via (GenericArbitrary Single)
35+#else
36+instance Arbitrary Single where
37+ arbitrary = genericArbitrary
38+ shrink = genericShrink
39+#endif
40+
41+prop_singleTotal :: Single -> Property
42+prop_singleTotal = total
43+
44+data Multiple = M1 | M2 | M3 Int
45+ deriving (Eq, Show, Generic)
46+ deriving anyclass NFData
47+#if MIN_VERSION_QuickCheck(2, 14, 0)
48+ deriving Arbitrary via (GenericArbitrary Multiple)
49+#else
50+instance Arbitrary Multiple where
51+ arbitrary = genericArbitrary
52+ shrink = genericShrink
53+#endif
54+
55+prop_multipleTotal :: Multiple -> Property
56+prop_multipleTotal = total
57+
58+data Rec = Rec
59+ { unit :: Unit
60+ , single :: Single
61+ , multiple :: Multiple
62+ } deriving (Eq, Show, Generic)
63+ deriving anyclass NFData
64+#if MIN_VERSION_QuickCheck(2, 14, 0)
65+ deriving Arbitrary via (GenericArbitrary Rec)
66+#else
67+instance Arbitrary Rec where
68+ arbitrary = genericArbitrary
69+ shrink = genericShrink
70+#endif
71+
72+prop_recTotal :: Rec -> Property
73+prop_recTotal = total
74+
875data Expr
9− = Lit
76+ = Lit Int
1077 | Add Expr Expr
1178 | Mul Expr Expr
1279 deriving (Eq, Show, Generic)
13−
14−-- | Instance with may fall into infinite loop
80+ deriving anyclass NFData
81+#if MIN_VERSION_QuickCheck(2, 14, 0)
82+ deriving Arbitrary via (GenericArbitrary Expr)
83+#else
1584instance Arbitrary Expr where
1685 arbitrary = genericArbitrary
1786 shrink = genericShrink
87+#endif
1888
19−instance NFData Expr
89+prop_exprTotal :: Expr -> Property
90+prop_exprTotal = total
2091
21−data Single = Single
92+data Recursive
93+ = R1 Recursive
94+ | R2 Recursive Int
95+ | N Int
96+ | R3 Recursive
97+ | R4 Recursive
98+ | R5 Recursive String
2299 deriving (Eq, Show, Generic)
23−
24−instance Arbitrary Single where
100+ deriving anyclass NFData
101+#if MIN_VERSION_QuickCheck(2, 14, 0)
102+ deriving Arbitrary via (GenericArbitrary Recursive)
103+#else
104+instance Arbitrary Recursive where
25105 arbitrary = genericArbitrary
26106 shrink = genericShrink
107+#endif
27108
28−data Multiple = M1 | M2
29− deriving (Eq, Show, Generic)
109+prop_recursiveTotal :: Recursive -> Property
110+prop_recursiveTotal = total
30111
31−instance Arbitrary Multiple where
112+data DeepRecursive
113+ = Deep DeepRecursive DeepRecursive DeepRecursive DeepRecursive DeepRecursive
114+ | Short
115+ deriving (Eq, Show, Generic)
116+ deriving anyclass NFData
117+#if MIN_VERSION_QuickCheck(2, 14, 0)
118+ deriving Arbitrary via (GenericArbitrary DeepRecursive)
119+#else
120+instance Arbitrary DeepRecursive where
32121 arbitrary = genericArbitrary
33122 shrink = genericShrink
123+#endif
124+
125+prop_deepRecursiveTotal :: DeepRecursive -> Property
126+prop_deepRecursiveTotal = total
34127
35−data Fail = Fail Fail | NotFail
128+data P p = NoP | P p
36129 deriving (Eq, Show, Generic)
130+ deriving anyclass NFData
37131
38−instance Arbitrary Fail where
132+-- Note that deriving via doesn't work for case with arguments
133+instance (Arg (P p) p, Arbitrary p) => Arbitrary (P p) where
39134 arbitrary = genericArbitrary
40135 shrink = genericShrink
41136
42−-- | Check that we are not generating infinite terms
43−prop_exprTotal :: Expr -> Property
44−prop_exprTotal = total
137+prop_Ptotal :: P (P Int) -> Property
138+prop_Ptotal = total