git.iko.soy/typeable/generic-arbitrary
on master help sign in
22 files changed+261−36
since splitsnapshots
unifiedsplit
.github/workflows/haskell-ci.yml+17−4 CHANGELOG.md+16 README.md+114−12 generic-arbitrary.cabal+18−13 lts-18.18.yaml → ghc-8.10.7.yaml lts-18.18.yaml.lock → ghc-8.10.7.yaml.lock lts-13.21.yaml → ghc-8.6.5.yaml lts-13.21.yaml.lock → ghc-8.6.5.yaml.lock ghc-9.0.2.yaml+1 ghc-9.0.2.yaml.lock+12 ghc-9.2.4.yaml+1 ghc-9.2.4.yaml.lock+12 ghc-9.4.3.yaml+1 ghc-9.4.3.yaml.lock+12 ghc-9.8.1.yaml+1 ghc-9.8.1.yaml.lock+12 src/Test/QuickCheck/Arbitrary/Generic.hs+15−3 test/Aux.hs → test/Auxiliary.hs+1−1 test/EnumTest.hs+24 test/NoTypecheckTest.hs+1−1 test/ParametersTest.hs+1−1 test/RecursiveTest.hs+2−1
.github/workflows/haskell-ci.yml+17−4
@@ -1,16 +1,29 @@
11name: Haskell-CI
2−on: [push]
2+on: [push, pull_request]
33jobs:
44 linux:
5− name: ${{ matrix.stack-yaml }}
5+ name: GHC-${{ matrix.ghc-version }}
66 runs-on: ubuntu-latest
77 strategy:
88 matrix:
9− stack-yaml: [stack.yaml, lts-18.18.yaml, lts-13.21.yaml]
9+ ghc-version:
10+ - 8.6.5
11+ - 8.10.7
12+ - 9.0.2
13+ - 9.2.4
14+ - 9.4.3
15+ - 9.8.1
1016 steps:
1117 - uses: actions/checkout@v3
1218 - uses: haskell/actions/setup@v2
1319 with:
1420 enable-stack: true
21+ ghc-version: ${{ matrix.ghc-version }}
1522 stack-version: 'latest'
16− - run: stack --stack-yaml ${{ matrix.stack-yaml }} --install-ghc test --fast --haddock
23+ - uses: actions/cache@v3
24+ with:
25+ path: |
26+ ~/.stack
27+ ./.stack-work
28+ key: ${{ matrix.ghc-version }}
29+ - run: stack --stack-yaml ghc-${{ matrix.ghc-version }}.yaml --install-ghc test --fast --haddock
CHANGELOG.md+16
@@ -1,3 +1,19 @@
1+1.0.1.2
2+-------
3+
4+* Fix dependency bounds (including retroactively), and compilation with warnings.
5+
6+1.0.1.1
7+-------
8+
9+* Fix compilation with GHC 9.8.3
10+
11+1.0.1
12+-----
13+
14+* Compillability by GHC-9.2.4
15+* Fix cabal `tested-with` field
16+
1171.0.0
218-----
319
README.md+114−12
@@ -1,14 +1,31 @@
11# generic-arbitrary
22
3−[![Build Status](https://travis-ci.org/typeable/generic-arbitrary.svg?branch=master)](https://travis-ci.org/typeable/generic-arbitrary)
3+[![Haskell-CI](https://github.com/typeable/generic-arbitrary/actions/workflows/haskell-ci.yml/badge.svg)](https://github.com/typeable/generic-arbitrary/actions/workflows/haskell-ci.yml)
44
5−Deriving `Arbitrary` via `Generic`.
5+# What?
6+
7+Package for deriving `Arbitrary` via `Generic`.
68
79``` haskell
810import GHC.Generics (Generic)
911import Test.QuickCheck
1012import Test.QuickCheck.Arbitrary.Generic
1113
14+data Expr
15+ = Lit Int
16+ | Add Expr Expr
17+ | Mul Expr Expr
18+ deriving (Eq, Show, Generic)
19+ deriving Arbitrary via (GenericArbitrary Expr)
20+```
21+
22+Older versions of this package had a problem with hanging `arbitrary`
23+method. Since `1.0.0` this problem almost solved.
24+
25+For `QuickCheck` older than `2.14.0` the `GenericArbitrary` is not available, so
26+you will need to write instances more verbosely
27+
28+``` haskell
1229data Expr
1330 = Lit Int
1431 | Add Expr Expr
@@ -20,19 +37,104 @@ instance Arbitrary Expr where
2037 shrink = genericShrink
2138```
2239
23−if type has an argument then `Arg` is required
40+Which is generally the same.
41+
42+# Infinite terms problem
43+
44+The `generic-arbitrary` can partially handle the problem with recursive
45+types. Assume the type `R`
46+
47+``` haskell
48+data R = R R
49+ deriving Generic
50+```
51+
52+there is no instance
2453
2554``` haskell
26−data Expr lit
27− = Lit lit
28− | Add Expr Expr
29− | Mul Expr Expr
30− deriving (Eq, Show, Generic)
55+instance Arbitrary R where
56+ arbitrary = genericArbitrary
57+ shrink = genericShrink
58+```
59+
60+If you try to compile this you will get a type level error
61+
62+> • R refers to itself in all constructors
63+
64+Which means that there is no finite term for `R` because it is recursive in all
65+it's constructors. But, if you correct the definition of `R` like this.
3166
32−instance
33− ( Arbitrary lit
34− , Arg (Expr lit) lit
35− ) => Arbitrary (Expr lit) where
67+``` haskell
68+data R = R R | F
69+ deriving Generic
70+```
71+
72+Then it will compile. And the `arbitrary` generated will not hang forever,
73+because it respects the `size` parameter.
74+
75+## Limitation
76+
77+There is a limitation of recursion detection:
78+
79+``` haskell
80+data R1 = R1 R2
81+ deriving (Eq, Ord, Show, Generic)
82+ deriving anyclass NFData
83+ deriving Arbitrary via (GenericArbitrary R1)
84+
85+data R2 = R2 R1
86+ deriving (Eq, Ord, Show, Generic)
87+ deriving anyclass NFData
88+ deriving Arbitrary via (GenericArbitrary R2)
89+```
90+
91+This code will compile and the `arbitrary` generated will always hang. Yes,
92+there is a problem with mutually recursive types.
93+
94+# Type parameters
95+
96+Now let's see an example of datatype with parameters
97+
98+``` haskell
99+data A a = A a
100+ deriving (Eq, Ord, Show)
101+ deriving anyclass NFData
102+ deriving (Generic)
103+
104+instance (Arbitrary a) => Arbitrary (A a) where
36105 arbitrary = genericArbitrary
37106 shrink = genericShrink
38107```
108+
109+It should work from first glance, but when compile it will throw an error:
110+
111+```
112+• Could not deduce (Test.QuickCheck.Arbitrary.Generic.GArbitrary
113+ (A a)
114+ (GHC.Generics.D1
115+ ('GHC.Generics.MetaData "A" "ParametersTest" "main" 'False)
116+ (GHC.Generics.C1
117+ ('GHC.Generics.MetaCons "A" 'GHC.Generics.PrefixI 'False)
118+ (GHC.Generics.S1
119+ ('GHC.Generics.MetaSel
120+ 'Nothing
121+ 'GHC.Generics.NoSourceUnpackedness
122+ 'GHC.Generics.NoSourceStrictness
123+ 'GHC.Generics.DecidedLazy)
124+ (GHC.Generics.Rec0 a))))
125+ (TypesDiffer (A a) a))
126+ arising from a use of ‘genericArbitrary’
127+```
128+
129+Here the `TypesDiffer` is a type familty dealing with recursive types and
130+helping us to eliminate inproper instances. To convince the compiller, that the
131+`a` parameter is not an `A a` we must fix the instance with additional
132+constraint `Arg (A a) a`
133+
134+``` haskell
135+instance (Arg (A a) a, Arbitrary a) => Arbitrary (A a) where
136+ arbitrary = genericArbitrary
137+ shrink = genericShrink
138+```
139+
140+Now everything compiles and works as expected.
generic-arbitrary.cabal+18−13
@@ -1,5 +1,5 @@
11name: generic-arbitrary
2−version: 1.0.0
2+version: 1.0.1.2
33synopsis: Generic implementation for QuickCheck's Arbitrary
44description:
55 Generic implementations of methods of the 'Arbitrary' class from the
@@ -15,9 +15,14 @@ homepage: http://github.com/typeable/generic-arbitrary#readme
1515category: Generic
1616build-type: Simple
1717extra-source-files: CHANGELOG.md
18−cabal-version: 1.22
19−tested-with: GHC == 8.10.7
20− , GHC == 9.0.2
18+ , README.md
19+cabal-version: 2.0
20+tested-with: GHC == 8.6.5
21+ , GHC == 8.10.7
22+ , GHC == 9.0.2
23+ , GHC == 9.2.4
24+ , GHC == 9.4.3
25+ , GHC == 9.8.1
2126
2227source-repository head
2328 type: git
@@ -26,7 +31,7 @@ source-repository head
2631library
2732 exposed-modules: Test.QuickCheck.Arbitrary.Generic
2833 build-depends: base >=4.8 && <5
29− , QuickCheck
34+ , QuickCheck >=2.8
3035 hs-source-dirs: src
3136 default-language: Haskell2010
3237 default-extensions: AllowAmbiguousTypes
@@ -54,15 +59,16 @@ test-suite test
5459 hs-source-dirs: test
5560 main-is: Test.hs
5661 default-language: Haskell2010
57− build-depends: base >= 4.8 && <5
58− , QuickCheck
62+ build-depends: base >=4.12 && <5
63+ , QuickCheck >=2.10
5964 , deepseq
6065 , generic-arbitrary
61− , tasty
62− , tasty-discover
63− , tasty-hunit
66+ , tasty >=1.4.2 || <1.4.0.1
67+ , tasty-discover >= 2.0.0
68+ , tasty-hunit >= 0.9.2
6469 , tasty-quickcheck
65− other-modules: Aux
70+ other-modules: Auxiliary
71+ , EnumTest
6672 , LimitationDemo
6773 , NoTypecheckTest
6874 , ParametersTest
@@ -88,9 +94,8 @@ test-suite test
8894 , TypeSynonymInstances
8995 , UndecidableInstances
9096 , ViewPatterns
91− build-tools: tasty-discover
97+ build-tool-depends: tasty-discover:tasty-discover
9298 ghc-options: -Wall
9399 -threaded
94100 -rtsopts
95101 "-with-rtsopts=-N -A64m -qb0 -n4m -T -I1"
96− default-extensions: DeriveGeneric
lts-18.18.yaml → ghc-8.10.7.yamlrenamed

The content is the same.

lts-18.18.yaml.lock → ghc-8.10.7.yaml.lockrenamed

The content is the same.

lts-13.21.yaml → ghc-8.6.5.yamlrenamed

The content is the same.

lts-13.21.yaml.lock → ghc-8.6.5.yaml.lockrenamed

The content is the same.

ghc-9.0.2.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: lts-19.20
ghc-9.0.2.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: be747117bed6d462806c883352c3206325b23480825103f5c87884e97e52819a
10+ size: 619173
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/19/20.yaml
12+ original: lts-19.20
ghc-9.2.4.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: nightly-2022-08-24
ghc-9.2.4.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: ff431937a638ebfaa5e6fec13c7ae575f01e02744d6ca5e5b1554f78cb5f88ad
10+ size: 631953
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/nightly/2022/8/24.yaml
12+ original: nightly-2022-08-24
ghc-9.4.3.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: nightly-2022-12-26
ghc-9.4.3.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: bbe432b2abd6d866aa37f65a8129a5f858b7c6eaae9464f8bc2814ce92ac2d15
10+ size: 573163
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/nightly/2022/12/26.yaml
12+ original: nightly-2022-12-26
ghc-9.8.1.yamlnew file+1
@@ -0,0 +1 @@
1+resolver: nightly-2024-01-12
ghc-9.8.1.yaml.locknew file+12
@@ -0,0 +1,12 @@
1+# This file was autogenerated by Stack.
2+# You should not edit this file by hand.
3+# For more information, please see the documentation at:
4+# https://docs.haskellstack.org/en/stable/lock_files
5+
6+packages: []
7+snapshots:
8+- completed:
9+ sha256: 8f06e87750f95bc8620644ea22344ad023c3c5aa6efa854747aa70093898fd79
10+ size: 556465
11+ url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/nightly/2024/1/12.yaml
12+ original: nightly-2024-01-12
src/Test/QuickCheck/Arbitrary/Generic.hs+15−3
@@ -1,3 +1,10 @@
1+#if __GLASGOW_HASKELL__ >= 806
2+{-# OPTIONS_GHC -Wno-star-is-type #-}
3+#endif
4+#if __GLASGOW_HASKELL__ >= 800
5+{-# OPTIONS_GHC -Wno-unticked-promoted-constructors #-}
6+#endif
7+
18{-|
29
310This module is a generic implementation of the 'arbitrary' method. Example
@@ -27,7 +34,7 @@ data Foo = Foo
2734The generated 'arbitrary' method is equivalent to
2835
2936@
30−Foo <$> arbitrary <*> arbitrary
37+Foo '<$>' arbitrary '<*>' arbitrary
3138@.
3239
3340It can also handle a recursive types problem. Assuming a type
@@ -127,7 +134,6 @@ Now everything compiles and works as expected.
127134module Test.QuickCheck.Arbitrary.Generic
128135 ( -- * Main
129136 genericArbitrary
130− , genericShrink
131137#if MIN_VERSION_QuickCheck(2, 14, 0)
132138 , GenericArbitrary(..)
133139#endif
@@ -143,16 +149,18 @@ module Test.QuickCheck.Arbitrary.Generic
143149 , SumLen
144150 -- * Reexports
145151 , Arbitrary(..)
152+ , genericShrink
146153 ) where
147154
148155import Control.Applicative
149−import Data.Coerce (coerce)
150156import Data.Proxy
151157import Data.Type.Bool
152158import GHC.Generics as G
153159import GHC.TypeLits
160+import Prelude
154161import Test.QuickCheck as QC
155162#if MIN_VERSION_QuickCheck(2, 14, 0)
163+import Data.Coerce (coerce)
156164import Test.QuickCheck.Arbitrary (GSubterms, RecursivelyShrink)
157165
158166
@@ -168,6 +176,8 @@ import Test.QuickCheck.Arbitrary (GSubterms, RecursivelyShrink)
168176-- } deriving (Generic)
169177-- deriving (Arbitrary) via GenericArbitrary Foo
170178-- @
179+--
180+-- @since 1.0.0
171181newtype GenericArbitrary a = GenericArbitrary { unGenericArbitrary :: a }
172182 deriving (Show, Eq)
173183
@@ -192,6 +202,8 @@ instance
192202-- arbitrary = genericArbitrary
193203-- shrink = genericShrink
194204-- @
205+--
206+-- @since 1.0.0
195207
196208type Arg self field = (TypesDiffer self field ~ 'True)
197209
test/Aux.hs → test/Auxiliary.hsrenamed+1−1
@@ -1,4 +1,4 @@
1−module Aux where
1+module Auxiliary where
22
33import Control.Exception
44import Test.QuickCheck
test/EnumTest.hsnew file+24
@@ -0,0 +1,24 @@
1+#if __GLASGOW_HASKELL__ >= 806 && __GLASGOW_HASKELL__ <= 900
2+{-# OPTIONS_GHC -fconstraint-solver-iterations=5 #-}
3+#elif __GLASGOW_HASKELL__ >= 902
4+{-# OPTIONS_GHC -fconstraint-solver-iterations=6 #-}
5+#endif
6+
7+
8+
9+module EnumTest where
10+
11+import Control.DeepSeq
12+import GHC.Generics
13+import Test.QuickCheck
14+import Test.QuickCheck.Arbitrary.Generic
15+
16+data Country = PL | GB | RU | RO | CZ | HR | SK | DE | NL | ES | BR
17+ deriving (Generic, NFData, Show)
18+
19+instance Arbitrary Country where
20+ arbitrary = genericArbitrary
21+ shrink = genericShrink
22+
23+prop_CountryTest :: Country -> Property
24+prop_CountryTest = total
test/NoTypecheckTest.hs+1−1
@@ -5,7 +5,7 @@
55
66module NoTypecheckTest where
77
8−import Aux
8+import Auxiliary
99import GHC.Generics (Generic)
1010import Test.QuickCheck
1111import Test.QuickCheck.Arbitrary.Generic
test/ParametersTest.hs+1−1
@@ -3,7 +3,7 @@
33
44module ParametersTest where
55
6−import Aux
6+import Auxiliary
77import Control.DeepSeq
88import GHC.Generics (Generic)
99import Test.QuickCheck
test/RecursiveTest.hs+2−1
@@ -1,13 +1,14 @@
11{-# LANGUAGE DerivingStrategies #-}
22{-# LANGUAGE DerivingVia #-}
33{-# LANGUAGE DeriveAnyClass #-}
4+{-# OPTIONS_GHC -fconstraint-solver-iterations=5 #-} -- GHC-9.2.4
45
56-- | Testing that our Arbitrary instances do not get stuck and respect the
67-- `size` parameter while generating.
78
89module RecursiveTest where
910
10−import Control.DeepSeq
11+import Control.DeepSeq (NFData)
1112import GHC.Generics (Generic)
1213import Test.QuickCheck
1314import Test.QuickCheck.Arbitrary.Generic