@@ -1,5 +1,5 @@
1#include "hexml.h"
1#include "hexml.h"
2−#include <stdlib.h>
2+#include <malloc.h>
3#include <string.h>
3#include <string.h>
4#include <assert.h>
4#include <assert.h>
5#include <ctype.h>
5#include <ctype.h>
@@ -10,18 +10,18 @@ typedef int bool;
10/////////////////////////////////////////////////////////////////////
10/////////////////////////////////////////////////////////////////////
13−static inline int end(str s) { return s.start + s.length; }
13+int static inline end(str s) { return s.start + s.length; }
15−static inline str start_length(int32_t start, int32_t length)
15+str static inline start_length(int32_t start, int32_t length)
17− assert(start >= 0 && length >= 0);
17+ if (start < 0 || length < 0) assert(0);
19 res.start = start;
19 res.start = start;
20 res.length = length;
20 res.length = length;
21 return res;
21 return res;
24−static inline str start_end(int32_t start, int32_t end)
24+str static inline start_end(int32_t start, int32_t end)
26 return start_length(start, end - start);
26 return start_length(start, end - start);
@@ -34,13 +34,23 @@ typedef struct
34 attr* alloc; // what to call free on
34 attr* alloc; // what to call free on
35} attr_buffer;
35} attr_buffer;
40+ str name; // tag name, e.g. <[foo]>
41+ str outer; // outer text, [<foo>bar</foo>]
42+ str inner; // inner text, <foo>[bar]</foo>
43+ str attrs; // all the attributes, in the attribute buffer
44+ str nodes; // all the nodes, in the node buffer
37typedef struct
47typedef struct
39 // have a cursor at the front, which is all the stuff I have written out, final
49 // have a cursor at the front, which is all the stuff I have written out, final
40 // have a cursor at the end, which is stack scoped, so children write out, then I do
50 // have a cursor at the end, which is stack scoped, so children write out, then I do
41 // when you commit, you copy over from end to front
51 // when you commit, you copy over from end to front
45 int used_front; // front entries, stored for good
55 int used_front; // front entries, stored for good
46 int used_back; // back entries, stack based, copied into front
56 int used_back; // back entries, stack based, copied into front
@@ -51,11 +61,11 @@ typedef struct
52struct document
62struct document
54− const char* body; // pointer to initial argument, not owned by us
64+ char* body; // pointer to initial argument, not owned by us
56 // things only used while parsing
66 // things only used while parsing
57− const char* cursor; // pointer to where we are in body
67+ char* cursor; // pointer to where we are in body
58− const char* end; // pointer to one past the last char
68+ char* end; // pointer to one past the last char
59 // if cursor is > end we have gone past the end
69 // if cursor is > end we have gone past the end
61 char* error_message;
71 char* error_message;
@@ -63,8 +73,8 @@ struct document
63 attr_buffer attrs;
73 attr_buffer attrs;
66−static inline int doc_length(const document* d) { return (int) (d->end - d->body); }
76+int static inline doc_length(document* d) { return d->end - d->body; }
67−static inline int doc_position(const document* d) { return (int) (d->cursor - d->body); }
77+int static inline doc_position(document* d) { return d->cursor - d->body; }
70/////////////////////////////////////////////////////////////////////
80/////////////////////////////////////////////////////////////////////
@@ -72,45 +82,51 @@ static inline int doc_position(const document* d) { return (int) (d->cursor - d-
73typedef struct
83typedef struct
75− const document* d;
85+ document* d;
76 char* buffer;
86 char* buffer;
77 int length;
87 int length;
78 int cursor;
88 int cursor;
81−static inline void render_char(render* r, char c)
91+void static inline render_char(render* r, char c)
83 if (r->cursor < r->length)
93 if (r->cursor < r->length)
84 r->buffer[r->cursor] = c;
94 r->buffer[r->cursor] = c;
85 r->cursor++;
95 r->cursor++;
88−static inline void bound(int idx, int mn, int mx)
98+void static inline bound(char* msg, int index, int mn, int mx)
100+ if (index < mn || index > mx)
102+ printf("Bounds checking failed %s, got %i, which should be in %i:%i\n", msg, index, mn, mx);
90− assert(idx >= mn && idx <= mx);
103+ assert(0);
93−static inline void bound_str(str s, int mn, int mx)
107+void static inline bound_str(char* msg, str s, int mn, int mx)
95− assert(s.length >= 0);
109+ if (s.length < 0) assert(0);
96− bound(s.start, mn, mx);
110+ bound(msg, s.start, mn, mx);
97− bound(end(s), mn, mx);
111+ bound(msg, end(s), mn, mx);
100−static void render_str(render* r, str s)
114+void render_str(render* r, str s)
102− bound_str(s, 0, doc_length(r->d));
116+ bound_str("render_str", s, 0, doc_length(r->d));
117+ render_char(r, '[');
103 for (int i = 0; i < s.length; i++)
118 for (int i = 0; i < s.length; i++)
104 render_char(r, r->d->body[s.start + i]);
119 render_char(r, r->d->body[s.start + i]);
120+ render_char(r, ']');
107−static void render_tag(render* r, const node* n);
123+void render_tag(render* r, node* n);
109−static void render_content(render* r, const node* n)
125+void render_content(render* r, node* n)
111− bound_str(n->inner, 0, doc_length(r->d));
127+ bound_str("render_conent inner", n->inner, 0, doc_length(r->d));
112− bound_str(n->nodes, 0, r->d->nodes.used_front);
128+ bound_str("render_conent nodes", n->nodes, 0, r->d->nodes.used_front);
113− bound_str(n->attrs, 0, r->d->attrs.used);
129+ bound_str("render_conent attrs", n->attrs, 0, r->d->attrs.used);
115 int done = n->inner.start;
131 int done = n->inner.start;
116 for (int i = 0; i < n->nodes.length; i++)
132 for (int i = 0; i < n->nodes.length; i++)
@@ -123,7 +139,7 @@ static void render_content(render* r, const node* n)
123 render_str(r, start_end(done, end(n->inner)));
139 render_str(r, start_end(done, end(n->inner)));
126−static void render_tag(render* r, const node* n)
142+void render_tag(render* r, node* n)
128 render_char(r, '<');
144 render_char(r, '<');
129 render_str(r, n->name);
145 render_str(r, n->name);
@@ -145,18 +161,14 @@ static void render_tag(render* r, const node* n)
145 render_char(r, '>');
161 render_char(r, '>');
148−int hexml_node_render(const document* d, const node* n, char* buffer, int length)
164+int document_render(document* d, char* buffer, int length)
150 render r;
166 render r;
152 r.buffer = buffer;
168 r.buffer = buffer;
153 r.length = length;
169 r.length = length;
154 r.cursor = 0;
170 r.cursor = 0;
155− // The root node (and only the root node) has an empty length, so just render its innards
156− if (n->name.length == 0)
157− render_content(&r, n);
171+ render_content(&r, document_node(d));
160 return r.cursor;
172 return r.cursor;
@@ -164,10 +176,12 @@ int hexml_node_render(const document* d, const node* n, char* buffer, int length
164/////////////////////////////////////////////////////////////////////
176/////////////////////////////////////////////////////////////////////
165// NOT THE PARSER
177// NOT THE PARSER
167−char* hexml_document_error(const document* d){return d->error_message;}
179+char* document_error(document* d){return d->error_message;}
168−node* hexml_document_node(const document* d){return &d->nodes.nodes[0];}
180+node* document_node(document* d){return &d->nodes.nodes[0];}
181+str node_inner(node* n){return n->inner;}
182+str node_outer(node* n){return n->outer;}
170−void hexml_document_free(document* d)
184+void document_free(document* d)
172 free(d->error_message);
186 free(d->error_message);
173 free(d->nodes.alloc);
187 free(d->nodes.alloc);
@@ -175,94 +189,93 @@ void hexml_document_free(document* d)
178−node* hexml_node_children(const document* d, const node* n, int* res)
192+node* node_children(document* d, node* n, int* res)
180 *res = n->nodes.length;
194 *res = n->nodes.length;
181 return &d->nodes.nodes[n->nodes.start];
195 return &d->nodes.nodes[n->nodes.start];
184−attr* hexml_node_attributes(const document* d, const node* n, int* res)
198+attr* node_attributes(document* d, node* n, int* res)
186 *res = n->attrs.length;
200 *res = n->attrs.length;
187 return &d->attrs.attrs[n->attrs.start];
201 return &d->attrs.attrs[n->attrs.start];
191−attr* hexml_node_attribute(const document* d, const node* n, const char* s, int slen)
205+attr* node_attributeBy(document* d, node* n, char* s, int slen)
193− if (slen == -1) slen = (int) strlen(s);
207+ assert(0);
194− const int limit = end(n->attrs);
195− for (int i = n->attrs.start; i < limit; i++)
197− attr* r = &d->attrs.attrs[i];
198− if (r->name.length == slen && memcmp(s, &d->body[r->name.start], slen) == 0)
201 return NULL;
208 return NULL;
204// Search for given strings within a node
211// Search for given strings within a node
205−node* hexml_node_child(const document* d, const node* parent, const node* prev, const char* s, int slen)
212+node* node_firstChildBy(document* d, node* n, char* s, int slen)
207− if (slen == -1) slen = (int) strlen(s);
214+ if (slen == -1) slen = strlen(s);
208− int i = prev == NULL ? parent->nodes.start : (int) (prev + 1 - d->nodes.nodes);
215+ int i = n->nodes.start;
209− const int limit = end(parent->nodes);
216+ int limit = i + n->nodes.length;
210 for (; i < limit; i++)
217 for (; i < limit; i++)
212− node* r = &d->nodes.nodes[i];
219+ if (d->nodes.nodes[i].name.length == slen &&
213− if (r->name.length == slen && memcmp(s, &d->body[r->name.start], slen) == 0)
220+ memcmp(s, &d->body[d->nodes.nodes[i].name.start], slen) == 0)
214− return r;
221+ return &d->nodes.nodes[i];
216 return NULL;
223 return NULL;
226+node* node_nextChildBy(document* d, node* parent, node* prev, char* s, int slen)
220/////////////////////////////////////////////////////////////////////
233/////////////////////////////////////////////////////////////////////
221// PARSE TABLE
234// PARSE TABLE
223−static const char tag_name1 = 0x1;
236+const char tag_name1 = 0x1;
224−static const char tag_name = 0x2;
237+const char tag_name = 0x2;
225−static const char tag_space = 0x4;
238+const char tag_space = 0x4;
227−static char parse_table[256];
240+char parse_table[256];
229−static void init_parse_table()
242+void init_parse_table()
231 static bool done = 0;
244 static bool done = 0;
232 if (done) return;
245 if (done) return;
233 for (int i = 0; i < 256; i++)
246 for (int i = 0; i < 256; i++)
235 bool name1 = i == ':' || i == '_' || (i >= 'a' && i <= 'z') || (i >= 'A' && i <= 'Z');
248 bool name1 = i == ':' || i == '_' || (i >= 'a' && i <= 'z') || (i >= 'A' && i <= 'Z');
236− bool name = name1 || i == '-' || i == '.' || (i >= '0' && i <= '9');
249+ bool name = name1 || i == '-' || (i >= '0' && i <= '9');
237 bool space = i == ' ' || i == '\t' || i == '\r' || i == '\n';
250 bool space = i == ' ' || i == '\t' || i == '\r' || i == '\n';
238 parse_table[i] = (name1 ? tag_name1 : 0) | (name ? tag_name : 0) | (space ? tag_space : 0);
251 parse_table[i] = (name1 ? tag_name1 : 0) | (name ? tag_name : 0) | (space ? tag_space : 0);
240 done = 1;
253 done = 1;
243−static inline bool is(char c, char tag) { return parse_table[(unsigned char) c] & tag; }
256+bool static inline is(char c, char tag) { return parse_table[c] & tag; }
244−static inline bool is_name1(char c) { return is(c, tag_name1); }
257+bool static inline is_name1(char c) { return is(c, tag_name1); }
245−static inline bool is_name(char c) { return is(c, tag_name); }
258+bool static inline is_name(char c) { return is(c, tag_name); }
246−static inline bool is_space(char c) { return is(c, tag_space); }
259+bool static inline is_space(char c) { return is(c, tag_space); }
249/////////////////////////////////////////////////////////////////////
262/////////////////////////////////////////////////////////////////////
250// PARSER COMBINATORS
263// PARSER COMBINATORS
252−static inline char peek_at(const document* d, int i) { return d->cursor[i]; }
265+char static inline peekAt(document* d, int i) { return d->cursor[i]; }
253−static inline char peek(const document* d) { return peek_at(d, 0); }
254−static inline void skip(document* d, int i) { d->cursor += i; }
266+void static inline skip(document* d, int i) { d->cursor += i; }
267+char static inline peek(document* d) { return peekAt(d, 0); }
255−static inline char get(document* d) { char c = peek(d); skip(d, 1); return c; }
268+char static inline get(document* d) { char c = peek(d); skip(d, 1); return c; }
257// Remove whitespace characters from the cursor while they are still whitespace
270// Remove whitespace characters from the cursor while they are still whitespace
258−static inline void trim(document* d)
271+void static inline trim(document* d)
260 while (is_space(peek(d)))
273 while (is_space(peek(d)))
261 skip(d, 1);
274 skip(d, 1);
264// Find this character form the cursor onwards, if true adjust the cursor to that char, otherwise leave it at the end
277// Find this character form the cursor onwards, if true adjust the cursor to that char, otherwise leave it at the end
265−static bool find(document* d, char c)
278+bool find(document* d, char c)
267 char* x = memchr(d->cursor, c, d->end - d->cursor);
280 char* x = memchr(d->cursor, c, d->end - d->cursor);
268 if (x == NULL)
281 if (x == NULL)
@@ -281,47 +294,30 @@ static bool find(document* d, char c)
281/////////////////////////////////////////////////////////////////////
294/////////////////////////////////////////////////////////////////////
282// PARSING CODE
295// PARSING CODE
284−static inline void node_alloc(node_buffer* b, int ask)
297+void static inline node_alloc(node_buffer* b, int ask)
286 int space = b->size - b->used_back - b->used_front;
299 int space = b->size - b->used_back - b->used_front;
287 if (space >= ask) return;
300 if (space >= ask) return;
288− int size2 = (b->size + 1000 + ask) * 2;
289− node* buf2 = malloc(size2 * sizeof(node));
290− assert(buf2);
301+ assert(0);
291− memcpy(buf2, b->nodes, b->used_front * sizeof(node));
292− memcpy(&buf2[size2 - b->used_back], &b->nodes[b->size - b->used_back], b->used_back * sizeof(node));
299−static inline void attr_alloc(attr_buffer* b, int ask)
304+void static inline attr_alloc(attr_buffer* b, int ask)
301 int space = b->size - b->used;
306 int space = b->size - b->used;
302 if (space >= ask) return;
307 if (space >= ask) return;
303 int size2 = (b->size + 1000 + ask) * 2;
308 int size2 = (b->size + 1000 + ask) * 2;
304 attr* buf2 = malloc(size2 * sizeof(attr));
309 attr* buf2 = malloc(size2 * sizeof(attr));
306 memcpy(buf2, b->attrs, b->used * sizeof(attr));
310 memcpy(buf2, b->attrs, b->used * sizeof(attr));
307 free(b->alloc);
311 free(b->alloc);
309 b->attrs = buf2;
312 b->attrs = buf2;
310 b->alloc = buf2;
313 b->alloc = buf2;
313−static void set_error(document* d, const char* msg)
315− if (d->error_message != NULL) return; // keep the first error message
316− d->error_message = malloc(strlen(msg)+1);
317− assert(d->error_message);
318− strcpy(d->error_message, msg);
321// you now expect a name, perhaps preceeded by whitespace
316// you now expect a name, perhaps preceeded by whitespace
322// the name may be empty
317// the name may be empty
323−static inline str parse_name(document* d)
318+str static inline parse_name(document* d)
325 int start = doc_position(d);
321 int start = doc_position(d);
326 if (!is_name1(peek(d)))
322 if (!is_name1(peek(d)))
327 return start_length(start, 0);
323 return start_length(start, 0);
@@ -331,14 +327,10 @@ static inline str parse_name(document* d)
331 return start_end(start, doc_position(d));
327 return start_end(start, doc_position(d));
334−static inline str parse_attrval(document* d)
330+str static inline parse_attrval(document* d)
339− set_error(d, "Expected = in attribute, but missing");
340− return start_length(0, 0);
333+ if (peek(d) != '=') return start_length(0,0);
342 skip(d, 1);
334 skip(d, 1);
344 char c = peek(d);
336 char c = peek(d);
@@ -348,29 +340,26 @@ static inline str parse_attrval(document* d)
348 int start = doc_position(d);
340 int start = doc_position(d);
349 if (!find(d, c))
341 if (!find(d, c))
351− set_error(d, "Couldn't find closing attribute bit");
343+ d->error_message = _strdup("Couldn't find closing attribute bit");
352 return start_length(0, 0);
344 return start_length(0, 0);
354 skip(d, 1);
346 skip(d, 1);
355 return start_end(start, doc_position(d) - 1);
347 return start_end(start, doc_position(d) - 1);
358− {
350+ return parse_name(d);
359− set_error(d, "Invalid attribute");
360− return start_length(0, 0);
366// seen a tag name, now looking for attributes terminated by >
355// seen a tag name, now looking for attributes terminated by >
367// puts the attributes it finds in the attribute buffer
356// puts the attributes it finds in the attribute buffer
368−static inline str parse_attributes(document* d)
357+str static inline parse_attributes(document* d)
370− int start = d->attrs.used;
360+ res.start = d->attrs.used;
371− while (d->error_message == NULL)
361+ for (int i = 0; ; i++)
374 str name = parse_name(d);
363 str name = parse_name(d);
375 if (name.length == 0) break;
364 if (name.length == 0) break;
376 attr_alloc(&d->attrs, 1);
365 attr_alloc(&d->attrs, 1);
@@ -378,80 +367,70 @@ static inline str parse_attributes(document* d)
378 d->attrs.attrs[d->attrs.used].value = parse_attrval(d);
367 d->attrs.attrs[d->attrs.used].value = parse_attrval(d);
379 d->attrs.used++;
368 d->attrs.used++;
381− return start_end(start, d->attrs.used);
370+ res.length = d->attrs.used - res.start;
384−static str parse_content(document* d);
374+str parse_content(document* d);
387// Add a new entry into tag, am at a '<'
377// Add a new entry into tag, am at a '<'
388−static inline void parse_tag(document* d)
378+void static inline parse_tag(document* d)
390 node_alloc(&d->nodes, 1);
380 node_alloc(&d->nodes, 1);
391 d->nodes.used_back++;
381 d->nodes.used_back++;
392− node* me = &d->nodes.nodes[d->nodes.size - d->nodes.used_back];
382+ int me = d->nodes.size - d->nodes.used_back;
394− me->outer.start = doc_position(d);
384+ d->nodes.nodes[me].outer.start = doc_position(d);
395 char c = get(d);
385 char c = get(d);
396 assert(c == '<');
386 assert(c == '<');
397 if (peek(d) == '?') skip(d, 1);
387 if (peek(d) == '?') skip(d, 1);
398− me->name = parse_name(d);
388+ d->nodes.nodes[me].name = parse_name(d);
399− if (me->name.length == 0)
401− set_error(d, "Missing tag name");
404− me->attrs = parse_attributes(d);
389+ d->nodes.nodes[me].attrs = parse_attributes(d);
405− if (d->error_message != NULL) return;
407− c = peek(d);
391+ c = get(d);
408− if ((c == '/' || c == '?') && peek_at(d, 1) == '>')
392+ if ((c == '/' || c == '?') && peek(d) == '>')
410− skip(d, 2);
394+ skip(d, 1);
411− me->nodes = start_length(0, 0);
395+ d->nodes.nodes[me].nodes = start_length(0, 0);
412− me->outer.length = start_end(me->outer.start, doc_position(d)).length;
396+ d->nodes.nodes[me].outer.length = start_end(d->nodes.nodes[me].outer.start, doc_position(d)).length;
413− me->inner = start_length(doc_position(d), 0);
397+ d->nodes.nodes[me].inner = start_length(doc_position(d), 0);
416 else if (c != '>')
400 else if (c != '>')
418− set_error(d, "Gunk at the end of the tag");
402+ d->error_message = _strdup("Gunk at the end of the tag");
423− me->inner.start = doc_position(d);
405+ d->nodes.nodes[me].inner.start = doc_position(d);
424− str content = parse_content(d);
406+ d->nodes.nodes[me].nodes = parse_content(d);
426− // parse_content may have allocated more nodes, so recompute me
427− me = &d->nodes.nodes[d->nodes.size - d->nodes.used_back];
428− me->nodes = content;
429− me->inner.length = start_end(me->inner.start, doc_position(d)).length;
407+ d->nodes.nodes[me].inner.length = start_end(d->nodes.nodes[me].inner.start, doc_position(d)).length;
431 if (d->error_message != NULL) return;
409 if (d->error_message != NULL) return;
432− if (peek(d) == '<' && peek_at(d, 1) == '/')
410+ if (peek(d) == '<' && peekAt(d, 1) == '/')
434 skip(d, 2);
412 skip(d, 2);
435− if (d->end - d->cursor >= me->name.length &&
414+ if (d->end - d->cursor >= d->nodes.nodes[me].name.length &&
436− memcmp(d->cursor, &d->body[me->name.start], me->name.length) == 0)
415+ memcmp(d->cursor, &d->body[d->nodes.nodes[me].name.start], d->nodes.nodes[me].name.length) == 0)
438− skip(d, me->name.length);
417+ skip(d, d->nodes.nodes[me].name.length);
440 if (get(d) == '>')
419 if (get(d) == '>')
442− me->outer.length = start_end(me->outer.start, doc_position(d)).length;
421+ d->nodes.nodes[me].outer.length = start_end(d->nodes.nodes[me].outer.start, doc_position(d)).length;
446− set_error(d, "Mismatch in closing tags");
425+ d->error_message = _strdup("Mismatch in closing tags");
449− set_error(d, "Weirdness when trying to close tags");
428+ d->error_message = _strdup("Weirdness when trying to close tags");
452// Parser until </, return the index of your node children
431// Parser until </, return the index of your node children
453// Not inline as it is recursive
432// Not inline as it is recursive
454−static str parse_content(document* d)
433+str parse_content(document* d)
456 int before = d->nodes.used_back;
435 int before = d->nodes.used_back;
457 while (d->error_message == NULL)
436 while (d->error_message == NULL)
@@ -461,33 +440,11 @@ static str parse_content(document* d)
464− else if (peek_at(d, 1) == '/')
443+ if (peekAt(d, 1) == '/')
466 // have found a </
445 // have found a </
469− else if (peek_at(d, 1) == '!' && peek_at(d, 2) == '-' && peek_at(d, 3) == '-')
472− // you can't reuse the two '-' characters for the closing as well
473− if (peek_at(d, 0) == '\0' || peek_at(d, 1) == '\0')
475− set_error(d, "Didn't get a closing comment");
476− return start_end(0, 0);
483− set_error(d, "Didn't get a closing comment");
484− return start_end(0, 0);
487− if (peek_at(d, -3) == '-' && peek_at(d, -2) == '-')
493 parse_tag(d);
450 parse_tag(d);
@@ -503,23 +460,20 @@ static str parse_content(document* d)
503 return res;
460 return res;
506−// Based on looking at ~50Kb XML documents, they seem to have ~700 attributes
507−// and ~300 nodes, so size appropriately to cope with that.
508typedef struct
463typedef struct
510 document document;
465 document document;
511 attr attrs[1000];
466 attr attrs[1000];
512− node nodes[500];
467+ node nodes[1000];
515−document* hexml_document_parse(const char* s, int slen)
470+document* document_parse(char* s, int slen)
517− if (slen == -1) slen = (int) strlen(s);
472+ if (slen == -1) slen = strlen(s);
518 assert(s[slen] == 0);
473 assert(s[slen] == 0);
519 init_parse_table();
474 init_parse_table();
521 buffer* buf = malloc(sizeof(buffer));
476 buffer* buf = malloc(sizeof(buffer));
523 document* d = &buf->document;
477 document* d = &buf->document;
524 d->body = s;
478 d->body = s;
525 d->cursor = s;
479 d->cursor = s;
@@ -529,7 +483,7 @@ document* hexml_document_parse(const char* s, int slen)
529 d->attrs.used = 0;
483 d->attrs.used = 0;
530 d->attrs.attrs = buf->attrs;
484 d->attrs.attrs = buf->attrs;
531 d->attrs.alloc = NULL;
485 d->attrs.alloc = NULL;
532− d->nodes.size = 500;
486+ d->nodes.size = 1000;
533 d->nodes.used_back = 0;
487 d->nodes.used_back = 0;
534 d->nodes.used_front = 1;
488 d->nodes.used_front = 1;
535 d->nodes.nodes = buf->nodes;
489 d->nodes.nodes = buf->nodes;
@@ -539,13 +493,11 @@ document* hexml_document_parse(const char* s, int slen)
539 d->nodes.nodes[0].outer = start_length(0, slen);
493 d->nodes.nodes[0].outer = start_length(0, slen);
540 d->nodes.nodes[0].inner = start_length(0, slen);
494 d->nodes.nodes[0].inner = start_length(0, slen);
541 d->nodes.nodes[0].attrs = start_length(0, 0);
495 d->nodes.nodes[0].attrs = start_length(0, 0);
496+ d->nodes.nodes[0].nodes = parse_content(d);
543− // Introduce an intermediate result, otherwise behaviour is undefined
544− // because there is no guaranteed ordering between LHS and RHS evaluation
545− str content = parse_content(d);
546− d->nodes.nodes[0].nodes = content;
548− if (d->cursor < d->end)
498+ if (d->cursor < d->end && d->error_message == NULL)
549− set_error(d, "Trailing junk at the end of the document");
500+ d->error_message = _strdup("Trailing junk at the end of the document");
550 return d;
502 return d;