on master help sign in
44 files changed+4263−1090
since splitsnapshots
unifiedsplit
.gitignore+1 .travis.yml+21−14 katip-datadog/LICENSE+30 katip-datadog/README.md+6 katip-datadog/changelog.md+7 katip-datadog/katip-datadog.cabal+78 katip-datadog/src/Katip/Scribes/Datadog/TCP.hs+191 katip-datadog/test/Katip/Tests/Scribes/Datadog/TCP.hs+105 katip-datadog/test/Main.hs+22 katip-elasticsearch/bench/Main.hs+14−16 katip-elasticsearch/changelog.md+73 katip-elasticsearch/docker-compose.yml+10 katip-elasticsearch/examples/example.hs+34 katip-elasticsearch/katip-elasticsearch.cabal+33−25 katip-elasticsearch/src/Katip/Scribes/ElasticSearch.hs+54−366 katip-elasticsearch/src/Katip/Scribes/ElasticSearch/Annotations.hs+2−2 katip-elasticsearch/src/Katip/Scribes/ElasticSearch/Internal.hs+577 katip-elasticsearch/test/Main.hs+293−70 katip-logzio/LICENSE+30 katip-logzio/README.md+4 katip-logzio/changelog.md+9 katip-logzio/katip-logzio.cabal+94 katip-logzio/src/Katip/Scribes/LogzIO/HTTPS.hs+639 katip-logzio/test/Katip/Tests/Scribes/LogzIO/HTTPS.hs+466 katip-logzio/test/Main.hs+22 katip/README.md+5−1 katip/bench/Main.hs+51−46 katip/changelog.md+123 katip/examples/example.hs+28−42 katip/examples/example_lens.hs+27−43 katip/katip.cabal+36−28 katip/src/Katip.hs+99−8 katip/src/Katip/Core.hs+423−127 katip/src/Katip/Monadic.hs+241−80 katip/src/Katip/Scribes/Handle.hs+115−73 katip/test/Katip/Tests.hs+168−7 katip/test/Katip/Tests/Scribes/Handle-json.golden+38 katip/test/Katip/Tests/Scribes/Handle-text.golden+38−38 katip/test/Katip/Tests/Scribes/Handle.hs+45−13 stack-lts-2.yaml−32 stack-lts-3.yaml−22 stack-lts-4.yaml−19 stack-lts-5.yaml−16 stack.yaml+11−2
.gitignore+1
@@ -7,3 +7,4 @@ TAGS
77*.hi
88*.dyn_o
99*.dyn_hi
10+stack.yaml.lock
.travis.yml+21−14
@@ -14,16 +14,14 @@ addons:
1414# change flags or use --stack-yaml to point to a different file.
1515matrix:
1616 include:
17− - env: ARGS="--stack-yaml=stack-lts-2.yaml"
18− - env: ARGS="--stack-yaml=stack-lts-3.yaml"
19− - env: ARGS="--stack-yaml=stack-lts-4.yaml"
20− - env: ARGS="--stack-yaml=stack-lts-5.yaml"
21− - env: ARGS="--resolver=lts-6"
22− - env: ARGS="--resolver=lts-7.19"
23− - env: ARGS="--resolver=lts-8"
24− - env: ARGS="--resolver=nightly"
17+ - env: ARGS="--resolver=lts-16" ESVERSION=5.5.0 ESURL=https://artifacts.elastic.co/downloads/elasticsearch ESTESTARGS="--es-version 5" ES_JAVA_OPTS="-Xms500m -Xmx750m"
18+ - env: ARGS="--resolver=lts-16" ESVERSION=6.2.2 ESURL=https://artifacts.elastic.co/downloads/elasticsearch ESTESTARGS="--es-version 5" ES_JAVA_OPTS="-Xms500m -Xmx750m"
19+ - env: ARGS="--resolver=nightly" ESVERSION=5.5.0 ESURL=https://artifacts.elastic.co/downloads/elasticsearch ESTESTARGS="--es-version 5" ES_JAVA_OPTS="-Xms500m -Xmx750m"
20+ - env: ARGS="--resolver=nightly" ESVERSION=6.2.2 ESURL=https://artifacts.elastic.co/downloads/elasticsearch ESTESTARGS="--es-version 5" ES_JAVA_OPTS="-Xms500m -Xmx750m"
21+ # nightlies may fail usually due to lagging dependencies
2522 allow_failures:
26− - env: ARGS="--resolver=nightly"
23+ - env: ARGS="--resolver=nightly" ESVERSION=5.5.0 ESURL=https://artifacts.elastic.co/downloads/elasticsearch ESTESTARGS="--es-version 5" ES_JAVA_OPTS="-Xms500m -Xmx750m"
24+ - env: ARGS="--resolver=nightly" ESVERSION=6.2.2 ESURL=https://artifacts.elastic.co/downloads/elasticsearch ESTESTARGS="--es-version 5" ES_JAVA_OPTS="-Xms500m -Xmx750m"
2725
2826before_install:
2927# Download and unpack the stack executable
@@ -32,9 +30,13 @@ before_install:
3230- travis_retry curl -L https://www.stackage.org/stack/linux-x86_64 | tar xz --wildcards --strip-components=1 -C ~/.local/bin '*/stack'
3331
3432install:
35− - wget --no-check-certificate https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.5.2.tar.gz
36− - tar xzf elasticsearch-1.5.2.tar.gz
37− - ./elasticsearch-1.5.2/bin/elasticsearch &
33+ - wget --no-check-certificate $ESURL/elasticsearch-$ESVERSION.tar.gz
34+ - tar xzf elasticsearch-$ESVERSION.tar.gz
35+ # set up a repo for snapshot testing. Required in ES >= 1.6
36+ - echo "path.repo = [\"/tmp\"]" >> ./elasticsearch-$ESVERSION/elasticsearch.yml
37+ - java -version
38+ - ./elasticsearch-$ESVERSION/bin/elasticsearch &
39+ # Bloodhound seems to take a while to build and can sometimes stall out the build when travis detects no output.
3840
3941
4042# This line does all of the work: installs GHC if necessary, build the library,
@@ -42,13 +44,18 @@ install:
4244# around some quirks in Travis's terminal implementation.
4345script:
4446 - stack $ARGS setup
45− - stack $ARGS test $BUILDFLAGS --no-terminal --haddock --no-haddock-deps
47+ # Prevent Inactivity timeouts. See https://github.com/travis-ci/travis-ci/issues/7020#issuecomment-288961580
48+ - travis_wait 45 sleep 1800 &
49+ - stack $ARGS test katip:test --no-terminal --haddock --no-haddock-deps
50+ - stack $ARGS test katip-elasticsearch:test --no-terminal --test-arguments="$ESTESTARGS"
4651 - stack $ARGS bench
47− - stack $ARGS build $BUILDFLAGS
52+ - stack $ARGS build
4853 - for f in katip/examples/*.hs; do stack $ARGS ghc -- -Wall -Werror $f -o /dev/null; done
54+ - for f in katip-elasticsearch/examples/*.hs; do stack $ARGS ghc -- -Wall -Werror $f -o /dev/null; done
4955 - stack $ARGS sdist
5056
5157# Caching so the next build will be fast too.
5258cache:
5359 directories:
5460 - $HOME/.stack
61+ - .stack-work
katip-datadog/LICENSEnew file+30
@@ -0,0 +1,30 @@
1+Copyright (c) 2018, Soostone Inc
2+
3+All rights reserved.
4+
5+Redistribution and use in source and binary forms, with or without
6+modification, are permitted provided that the following conditions are met:
7+
8+ * Redistributions of source code must retain the above copyright
9+ notice, this list of conditions and the following disclaimer.
10+
11+ * Redistributions in binary form must reproduce the above
12+ copyright notice, this list of conditions and the following
13+ disclaimer in the documentation and/or other materials provided
14+ with the distribution.
15+
16+ * Neither the name of Ozgun Ataman nor the names of other
17+ contributors may be used to endorse or promote products derived
18+ from this software without specific prior written permission.
19+
20+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
21+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
22+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
23+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
24+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
25+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
26+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
27+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
28+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
29+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
30+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
katip-datadog/README.mdnew file+6
@@ -0,0 +1,6 @@
1+# Katip Datadog [![Build Status](https://travis-ci.org/Soostone/katip.svg?branch=master)](https://travis-ci.org/Soostone/katip)
2+
3+katip-datadog is a scribe for the Katip logging framework that sends
4+structured logs to the Datadog logging service. It supports both
5+directly sending to the ingestion API and through a locally installed
6+datadog agent.
katip-datadog/changelog.mdnew file+7
@@ -0,0 +1,7 @@
1+0.2.0.0
2+==========
3+* Remove import of deprecated Network module
4+
5+0.1.0.0
6+==========
7+* Initial release
katip-datadog/katip-datadog.cabalnew file+78
@@ -0,0 +1,78 @@
1+name: katip-datadog
2+version: 0.2.0.0
3+synopsis: Datadog scribe for the Katip logging framework
4+description: See README.md for more details.
5+license: BSD3
6+license-file: LICENSE
7+author: Michael Xavier
8+maintainer: michael.xavier@soostone.com
9+copyright: Soostone Inc, 2018
10+category: Data, Text, Logging
11+homepage: https://github.com/Soostone/katip
12+bug-reports: https://github.com/Soostone/katip/issues
13+build-type: Simple
14+cabal-version: >=1.10
15+extra-source-files:
16+ README.md
17+ changelog.md
18+
19+--TODO: fill this in
20+tested-with: GHC == 8.4.3
21+
22+source-repository head
23+ type: git
24+ location: https://github.com/Soostone/katip.git
25+
26+flag lib-Werror
27+ default: False
28+ manual: True
29+
30+
31+library
32+ exposed-modules:
33+ Katip.Scribes.Datadog.TCP
34+ build-depends:
35+ base >=4.4.0.0 && <5
36+ , aeson >= 1.0.0.0
37+ , bytestring
38+ , katip >= 0.8.0.0
39+ , text
40+ , connection
41+ , resource-pool
42+ , time
43+ , binary
44+ , network
45+ , safe-exceptions
46+ , retry >= 0.7
47+ hs-source-dirs: src
48+ default-language: Haskell2010
49+ hs-source-dirs: src
50+ ghc-options: -Wall
51+ if flag(lib-Werror)
52+ ghc-options: -Werror
53+
54+
55+test-suite test
56+ type: exitcode-stdio-1.0
57+ main-is: Main.hs
58+ hs-source-dirs: test
59+ default-language: Haskell2010
60+ other-modules:
61+ Katip.Tests.Scribes.Datadog.TCP
62+ build-depends: base
63+ , katip
64+ , katip-datadog
65+ , conduit
66+ , conduit-extra
67+ , tasty
68+ , tasty-hunit
69+ , aeson
70+ , unordered-containers
71+ , containers
72+ , safe-exceptions
73+ , async
74+ , attoparsec
75+ , text
76+ ghc-options: -Wall
77+ if flag(lib-Werror)
78+ ghc-options: -Werror
katip-datadog/src/Katip/Scribes/Datadog/TCP.hsnew file+191
@@ -0,0 +1,191 @@
1+{-# LANGUAGE BangPatterns #-}
2+{-# LANGUAGE OverloadedStrings #-}
3+{-# LANGUAGE RankNTypes #-}
4+-- | Creates a scribe as a Custom Forwarder for Datadog that sends log
5+-- messages over TCP via their TLS endpoint.
6+module Katip.Scribes.Datadog.TCP
7+ ( -- * Types
8+ APIKey(..)
9+ , DatadogScribeSettings(..)
10+ , DatadogAuth(..)
11+ , directAPIConnectionParams
12+ , localAgentConnectionParams
13+ -- * Scribe construction
14+ , mkDatadogScribeSettings
15+ , mkDatadogScribe
16+ ) where
17+
18+
19+
20+-------------------------------------------------------------------------------
21+import qualified Control.Concurrent as Conc
22+import qualified Control.Exception.Safe as EX
23+import Control.Monad (void)
24+import qualified Control.Retry as Retry
25+import qualified Data.Aeson as A
26+import qualified Data.Binary.Builder as BB
27+import qualified Data.ByteString.Lazy as BSL
28+import Data.Monoid as Monoid
29+import qualified Data.Pool as Pool
30+import Data.Text (Text)
31+import qualified Data.Text.Encoding as T
32+import qualified Data.Text.Lazy.Builder as B
33+import Data.Time (NominalDiffTime)
34+import Katip
35+import Katip.Core (LocJs (..))
36+import qualified Network.Connection as C
37+import qualified Network.Socket as Net
38+import qualified System.Posix.Types as POSIX
39+-------------------------------------------------------------------------------
40+
41+
42+-- | When writing directly to the main intake API, you must specify an
43+-- API key
44+newtype APIKey = APIKey
45+ { apiKey :: Text
46+ } deriving (Show, Eq)
47+
48+
49+data DatadogAuth =
50+ NoAuthLocal
51+ -- ^ Writing to the local agent, no auth required
52+ | DirectAuth APIKey
53+ -- ^ Writing directly to the main intake API over TLS . API Key is
54+ -- required. Using a local agent is recommended.
55+
56+
57+data DatadogScribeSettings = DatadogScribeSettings
58+ { datadogScribeSettings_connectionParams :: C.ConnectionParams
59+ -- ^ Specify where the logs should go. If writing directly to the
60+ -- main intake API, you can use 'directAPIConnectionParams'. If
61+ -- writing to a local agent, we recommend
62+ -- 'localAgentConnectionParams'
63+ , datadogScribeSettings_auth :: DatadogAuth
64+ , datadogScribeSettings_poolStripes :: Int
65+ -- ^ How many stripes should be used in the connection pool. 1 is a reasonable default
66+ , datadogScribeSettings_connsPerStripe :: Int
67+ -- ^ How many TCP connections per stripe should be maintained in the pool.
68+ , datadogScribeSettings_connectionKeepalive :: NominalDiffTime
69+ -- ^ How long should a TCP connection be kept open. 30 (seconds) is a reasonable default. Anything around 60 will tend to time out a lot.
70+ , datadogScribeSettings_retry :: Retry.RetryPolicyM IO
71+ -- ^ How should exceptions during write be retried?
72+ }
73+
74+
75+-- | Configured for secure TLS communication to the main intake API at
76+-- intake.logs.datadoghq.com:10516. Must be combined with DirectAuth
77+-- authentication.
78+directAPIConnectionParams :: C.ConnectionParams
79+directAPIConnectionParams = C.ConnectionParams
80+ { C.connectionHostname = "intake.logs.datadoghq.com"
81+ , C.connectionPort = 10516
82+ , C.connectionUseSecure = Just $ C.TLSSettingsSimple
83+ { C.settingDisableCertificateValidation = False
84+ , C.settingDisableSession = False
85+ , C.settingUseServerName = False
86+ }
87+ , C.connectionUseSocks = Nothing
88+ }
89+
90+
91+-- | Configure to talk to a local Datadog agent at 127.0.0.1. TLS is not
92+-- utilized. This is the preferred type of connection because
93+-- authentication, buffering, and other more advanced features are
94+-- handled by the agent configuration.
95+localAgentConnectionParams :: Net.PortNumber -> C.ConnectionParams
96+localAgentConnectionParams port = C.ConnectionParams
97+ { C.connectionHostname = "127.0.0.1"
98+ , C.connectionPort = port
99+ , C.connectionUseSecure = Nothing
100+ , C.connectionUseSocks = Nothing
101+ }
102+
103+
104+-- | Reasonable defaults. Sets a 30s connection timeout, 1 stripe of
105+-- connections with a number of connections per stripe equal to
106+-- 'getNumCapabilities'. Retry policy will do an exponential backoff
107+-- with a 25ms base delay for up to 5 retries for a total cumulative delay of 775ms
108+mkDatadogScribeSettings :: C.ConnectionParams -> DatadogAuth -> IO DatadogScribeSettings
109+mkDatadogScribeSettings connectionParams auth = do
110+ capabilities <- Conc.getNumCapabilities
111+ pure $ DatadogScribeSettings
112+ { datadogScribeSettings_connectionParams = connectionParams
113+ , datadogScribeSettings_auth = auth
114+ , datadogScribeSettings_poolStripes = 1
115+ , datadogScribeSettings_connsPerStripe = capabilities
116+ , datadogScribeSettings_connectionKeepalive = 30
117+ , datadogScribeSettings_retry = Retry.exponentialBackoff 25000 <> Retry.limitRetries 5
118+ }
119+
120+
121+-------------------------------------------------------------------------------
122+mkDatadogScribe
123+ :: DatadogScribeSettings
124+ -> PermitFunc
125+ -- ^ Function on whether to permit items, e.g. @permitItem InfoS@
126+ -> Verbosity
127+ -- ^ Verbosity level to observe
128+ -> IO Scribe
129+mkDatadogScribe settings permit verb = do
130+ connectionContext <- C.initConnectionContext
131+ pool <- Pool.createPool
132+ (C.connectTo connectionContext (datadogScribeSettings_connectionParams settings))
133+ C.connectionClose
134+ (datadogScribeSettings_poolStripes settings)
135+ (datadogScribeSettings_connectionKeepalive settings)
136+ (datadogScribeSettings_connsPerStripe settings)
137+ pure $ Scribe
138+ { liPush = pushPool (datadogScribeSettings_retry settings) pool keyBuilder verb
139+ , scribeFinalizer = Pool.destroyAllResources pool
140+ , scribePermitItem = permit
141+ }
142+ where
143+ !keyBuilder = case datadogScribeSettings_auth settings of
144+ NoAuthLocal -> Nothing
145+ DirectAuth (APIKey k) -> Just (BB.fromByteString (T.encodeUtf8 k))
146+
147+
148+pushPool
149+ :: LogItem a
150+ => Retry.RetryPolicyM IO
151+ -> Pool.Pool C.Connection
152+ -> Maybe BB.Builder
153+ -- ^ Rendered API key
154+ -> Verbosity
155+ -> Item a
156+ -> IO ()
157+pushPool retryPolicy pool token verb item =
158+ void $ Retry.retrying retryPolicy (\_status shouldRetry -> pure shouldRetry) $ \_status -> do
159+ res <- EX.tryAny $ Pool.withResource pool $ \conn -> do
160+ C.connectionPut conn rendered
161+ pure $ case res of
162+ Left _ -> True
163+ Right _ -> False
164+ where
165+ payloadBuilder = A.fromEncoding (encodeDatadog verb item) Monoid.<> "\n"
166+ messageBuilder = case token of
167+ --TODO: lots of conversion going on here. could use a bench
168+ Nothing -> payloadBuilder
169+ Just directKey -> directKey <> " " <> payloadBuilder
170+ rendered = BSL.toStrict (BB.toLazyByteString messageBuilder)
171+
172+
173+encodeDatadog :: LogItem a => Verbosity -> Item a -> A.Encoding
174+encodeDatadog verb i = A.pairs $
175+ -- datadog seems to use "service" to denote appname
176+ "service" A..= _itemApp i <>
177+ -- datadog uses severity (or some other alternatives for sev)
178+ "severity" A..= _itemSeverity i <>
179+ "env" A..= _itemEnv i <>
180+ "thread" A..= getThreadIdText (_itemThread i) <>
181+ "host" A..= _itemHost i <>
182+ "pid" A..= pidInt <>
183+ "data" A..= payloadObject verb (_itemPayload i) <>
184+ -- datadog uses "message" instead of msg
185+ "message" A..= (B.toLazyText (unLogStr (_itemMessage i))) <>
186+ -- datadog uses "date" instead of "at"
187+ "date" A..= _itemTime i <>
188+ "ns" A..= _itemNamespace i <>
189+ "loc" A..= fmap LocJs (_itemLoc i)
190+ where
191+ POSIX.CPid pidInt = _itemProcess i
katip-datadog/test/Katip/Tests/Scribes/Datadog/TCP.hsnew file+105
@@ -0,0 +1,105 @@
1+{-# LANGUAGE OverloadedStrings #-}
2+module Katip.Tests.Scribes.Datadog.TCP
3+ ( tests
4+ ) where
5+
6+
7+-------------------------------------------------------------------------------
8+import Control.Concurrent.Async
9+import qualified Control.Exception.Safe as EX
10+import qualified Data.Aeson as A
11+import qualified Data.Char as Char
12+import qualified Data.Conduit as C
13+import qualified Data.Conduit.Binary as CB
14+import qualified Data.Conduit.List as CL
15+import qualified Data.Conduit.Network as CN
16+import Data.Foldable (toList)
17+import qualified Data.HashMap.Strict as HM
18+import Data.IORef
19+import Data.Sequence ((|>))
20+import Data.Text (Text)
21+import qualified Data.Text as T
22+import Test.Tasty
23+import Test.Tasty.HUnit
24+-------------------------------------------------------------------------------
25+import Katip
26+import Katip.Scribes.Datadog.TCP
27+-------------------------------------------------------------------------------
28+
29+
30+
31+tests :: TestTree
32+tests = testGroup "Katip.Scribes.Datadog.TCP"
33+ [ testCase "logs well-formed messages in order" $ do
34+ logs <- collectLogs $ do
35+ logItem (sl "foo" ("bar" :: Text)) "mynamespace" noLoc InfoS "a message"
36+ length logs @?= 1
37+ let (CapturedLog ns dta sev msg thread) = head logs
38+ ns @?= Namespace ["katip-datadog-tests", "mynamespace"]
39+ dta @?= A.Object (HM.singleton "foo" (A.String "bar"))
40+ sev @?= InfoS
41+ msg @?= "a message"
42+ if T.all Char.isNumber thread && T.length thread > 0
43+ then pure ()
44+ else assertFailure ("Expected thread id to just be a number but it was " <> T.unpack thread)
45+ ]
46+ where
47+ noLoc = Nothing
48+
49+
50+-------------------------------------------------------------------------------
51+-- | A log type parsed out of the fake datadog agent's buffer
52+data CapturedLog = CapturedLog
53+ { capturedLog_namespace :: Namespace
54+ , capturedLog_data :: A.Value
55+ , capturedLog_sev :: Severity
56+ , capturedLog_message :: Text
57+ , capturedLog_thread :: Text
58+ } deriving (Show, Eq)
59+
60+
61+instance A.FromJSON CapturedLog where
62+ parseJSON = A.withObject "CapturedLog" $ \o -> do
63+ message <- o A..: "message"
64+ sev <- o A..: "severity"
65+ dta <- o A..: "data"
66+ namespace <- o A..: "ns"
67+ thread <- o A..: "thread"
68+ pure $ CapturedLog
69+ { capturedLog_namespace = namespace
70+ , capturedLog_data = dta
71+ , capturedLog_sev = sev
72+ , capturedLog_message = message
73+ , capturedLog_thread = thread
74+ }
75+
76+
77+-------------------------------------------------------------------------------
78+collectLogs :: KatipT IO () -> IO [CapturedLog]
79+collectLogs f = do
80+ capturedRef <- newIORef mempty
81+ withAsync (startServer capturedRef) $ \_worker -> do
82+ EX.bracket mkLE closeLE $ \le -> do
83+ runKatipT le f
84+ toList <$> readIORef capturedRef
85+ where
86+ closeLE = closeScribes
87+ port = 1337
88+ mkLE = do
89+ datadogScribeSettings <- mkDatadogScribeSettings (localAgentConnectionParams (fromInteger port)) NoAuthLocal
90+ scribe <- mkDatadogScribe datadogScribeSettings (permitItem DebugS) V3
91+ registerScribe "datadog" scribe defaultScribeSettings =<< initLogEnv "katip-datadog-tests" "test"
92+ startServer capturedRef = CN.runTCPServer (CN.serverSettings (fromInteger port) "*") $ \appData -> C.runConduit $
93+ CN.appSource appData C..|
94+ CB.lines C..|
95+ CL.map A.eitherDecodeStrict C..|
96+ CL.mapM_ (\parseResult -> case parseResult of
97+ Left e -> EX.throwM (ParseError e)
98+ (Right capturedLog) -> modifyIORef' capturedRef (\captured -> captured |> capturedLog))
99+
100+
101+-------------------------------------------------------------------------------
102+newtype ParseError = ParseError String
103+ deriving (Show)
104+
105+instance EX.Exception ParseError
katip-datadog/test/Main.hsnew file+22
@@ -0,0 +1,22 @@
1+module Main
2+ ( main
3+ ) where
4+
5+
6+-------------------------------------------------------------------------------
7+import Test.Tasty
8+-------------------------------------------------------------------------------
9+import qualified Katip.Tests.Scribes.Datadog.TCP
10+-------------------------------------------------------------------------------
11+
12+
13+
14+main :: IO ()
15+main = defaultMain tests
16+
17+
18+-------------------------------------------------------------------------------
19+tests :: TestTree
20+tests = testGroup "katip-datadog"
21+ [ Katip.Tests.Scribes.Datadog.TCP.tests
22+ ]
katip-elasticsearch/bench/Main.hs+14−16
@@ -11,31 +11,31 @@ import Control.DeepSeq
1111import Control.Monad
1212import Criterion.Main
1313import Data.Aeson
14−import qualified Data.HashMap.Strict as HM
15−import Data.RNG
16−import qualified Data.Text as T
14+import qualified Data.HashMap.Strict as HM
15+import Data.Proxy (Proxy (..))
16+import System.Random
17+import qualified Data.Text as T
1718import Database.Bloodhound.Types
1819import Numeric
1920-------------------------------------------------------------------------------
2021import Katip.Scribes.ElasticSearch
21−import Katip.Scribes.ElasticSearch.Annotations
22+import Katip.Scribes.ElasticSearch.Internal (ESV5)
2223-------------------------------------------------------------------------------
2324
2425main :: IO ()
2526main = do
26− rng <- mkRNG
2727 defaultMain
2828 [
29− mkDocIdBenchmark rng
29+ mkDocIdBenchmark
3030 , deannotateValueBenchmark
3131 ]
3232
3333-------------------------------------------------------------------------------
34−mkDocIdBenchmark :: RNG -> Benchmark
35−mkDocIdBenchmark rng = bgroup "mkDocId"
34+mkDocIdBenchmark :: Benchmark
35+mkDocIdBenchmark = bgroup "mkDocId"
3636 [
37− bench "mkDocId (randomIO)" $ nfIO mkDocId
38− , bench "mkDocId' (shared )" $ nfIO $ mkDocId' rng
37+ bench "mkDocId (randomIO)" $ nfIO (mkDocId (Proxy :: Proxy ESV5))
38+ , bench "mkDocId' (shared )" $ nfIO mkDocId'
3939 ]
4040
4141
@@ -57,13 +57,11 @@ annotatedValue = Object $ HM.fromList [ ("a::string", String "whatever")
5757 ]
5858
5959-------------------------------------------------------------------------------
60−mkDocId' :: RNG -> IO DocId
61−mkDocId' rng = do
62− is <- withRNG rng $ \gen -> replicateM len $ mk gen
63− return . DocId . T.pack . concatMap (`showHex` "") $ is
60+mkDocId' :: IO DocId
61+mkDocId' = do
62+ is <- replicateM len (randomRIO (0, 15))
63+ return (DocId (T.pack (concatMap (`showHex` "") (is :: [Int]))))
6464 where
6565 len = 32
66− mk :: GenIO -> IO Int
67− mk = uniformR (0,15)
6866
6967deriving instance NFData DocId
katip-elasticsearch/changelog.md+73
@@ -1,3 +1,76 @@
1+0.7.0.0
2+=======
3+* Make compatible with unreleased bloodhound 0.17
4+* Deprecate use of ES version 1 which has been removed from bloodhound
5+ 0.17. All users should move over to ESV5 which should work for
6+ versions 5 and up.
7+* Default configuration to ESV5
8+* Add deprecation warnings for ESV1. Support for ESV1 will be removed
9+ in the future.
10+
11+0.6.0.0
12+=======
13+* Update to katip-0.8.0.0 `PermitFunc` convention. To update, for
14+ example, if you were passing `InfoS` to `mkEsScribe` to filter
15+ severities, instead you should pass `(permitItem InfoS)`.
16+* Update examples to add necessary type signature for the default
17+ scribe config.
18+* Bugfix: the default error retry policy was much more rapid than
19+ documented.
20+* Internally switch to safe-exceptions from encolosed-exceptions.
21+
22+0.5.1.1
23+=======
24+* Loosen katip dep
25+
26+0.5.1.0
27+=======
28+* Loosen deps
29+
30+0.5.0.0
31+=======
32+* Update template for ESv1 to not analyze certain fields like host and
33+ namespace. These are not fields that benefit from tokenization. If
34+ you're on ESv1, after running `mkEsScribe`, the logs template will
35+ be updated to stop analyzing those fields. That means the next
36+ index that is cut (e.g. tomorrow's logs if you're using daily index
37+ sharding) will no longer analyze some fields.
38+
39+0.4.2.0
40+=======
41+* Allow newer bloodhound, aeson, async.
42+
43+0.4.1.0
44+=======
45+* Fix bug where index was created in `mkEsScribe` when it would not be used due to index sharding.
46+* Update some index settings if index already exists and sharding is not used.
47+* For ES V5 and higher, stop using the deprecated (and in 6.x, removed) `string` type for index templates, instead using `text` and `keyword` as appropriate. This makes `katip-elasticsearch` compatible with ES 6.x.
48+
49+0.4.0.4
50+=======
51+* Allow http-types 0.12
52+
53+0.4.0.3
54+=======
55+* Fix benchmark and test builds for stackage nightly
56+
57+0.4.0.2
58+=======
59+* Add repository/homepage info to cabal file
60+
61+0.4.0.1
62+=======
63+* Bump dependencies to allow GHC 8.2.1
64+
65+0.4.0.0
66+=======
67+* Update to bloodhound >= 0.13.0.0. This version adds support for both ElasticSearch versions 1 and 5. Previously, we implicitly supported one and maybe would work on 5. The types in `EsScribeCfg` had to change to be able to specify which version was being targeted.
68+* Improved documentation.
69+
70+0.3.1.0
71+=======
72+* Widen dependency on katip
73+
1740.3.0.2
275=======
376* Loosen deps on aeson to allow 1.1.0.0
katip-elasticsearch/docker-compose.ymlnew file+10
@@ -0,0 +1,10 @@
1+version: "3.7"
2+services:
3+ # https://hub.docker.com/_/elasticsearch
4+ elasticsearch:
5+ image: elasticsearch:5-alpine
6+ ports:
7+ - target: 9200
8+ published: 9200
9+ protocol: tcp
10+ mode: host
katip-elasticsearch/examples/example.hsnew file+34
@@ -0,0 +1,34 @@
1+{-# LANGUAGE OverloadedStrings #-}
2+module Main
3+ ( main
4+ ) where
5+
6+
7+-------------------------------------------------------------------------------
8+import Control.Exception
9+import Database.Bloodhound
10+import Network.HTTP.Client
11+-------------------------------------------------------------------------------
12+import Katip
13+import Katip.Scribes.ElasticSearch
14+-------------------------------------------------------------------------------
15+
16+
17+main :: IO ()
18+main = do
19+ mgr <- newManager defaultManagerSettings
20+ let bhe = mkBHEnv (Server "http://localhost:9200") mgr
21+ -- You may need to specify the version in a type signature when customizing your index settings
22+ let _customizedExample = defaultEsScribeCfgV5 { essIndexSettings = IndexSettings (ShardCount 1) (ReplicaCount 0)} :: EsScribeCfg ESV5
23+ esScribe <- mkEsScribe
24+ -- Reasonable for production
25+ defaultEsScribeCfgV5
26+ -- Reasonable for single-node in development
27+ bhe
28+ (IndexName "all-indices-prefixed-with")
29+ (MappingName "application-logs")
30+ (permitItem DebugS)
31+ V3
32+ let mkLogEnv = registerScribe "es" esScribe defaultScribeSettings =<< initLogEnv "MyApp" "production"
33+ bracket mkLogEnv closeScribes $ \le -> runKatipT le $ do
34+ logMsg "ns" InfoS "This goes to elasticsearch"
katip-elasticsearch/katip-elasticsearch.cabal+33−25
@@ -1,21 +1,28 @@
11name: katip-elasticsearch
22synopsis: ElasticSearch scribe for the Katip logging framework.
33description: See README.md for more details.
4−version: 0.3.0.2
4+version: 0.7.0.0
55license: BSD3
66license-file: LICENSE
77author: Ozgun Ataman, Michael Xavier
88maintainer: michael.xavier@soostone.com
9−copyright: Soostone Inc, 2015-2016
10−category: Data
9+copyright: Soostone Inc, 2015-2017
10+category: Data, Text, Logging
11+homepage: https://github.com/Soostone/katip
12+bug-reports: https://github.com/Soostone/katip/issues
1113build-type: Simple
1214cabal-version: >=1.10
1315extra-source-files:
1416 README.md
1517 changelog.md
1618 bench/Main.hs
19+ examples/example.hs
1720 test/Main.hs
18−tested-with: GHC == 7.8.4, GHC== 7.10.3
21+tested-with: GHC == 7.8.4, GHC== 7.10.3, GHC == 8.0.1, GHC == 8.2.2, GHC == 8.4.3
22+
23+source-repository head
24+ type: git
25+ location: https://github.com/Soostone/katip.git
1926
2027flag lib-Werror
2128 default: False
@@ -25,29 +32,31 @@ library
2532 exposed-modules:
2633 Katip.Scribes.ElasticSearch
2734 Katip.Scribes.ElasticSearch.Annotations
35+ Katip.Scribes.ElasticSearch.Internal
2836 build-depends:
2937 base >=4.6 && <5
30− , katip >= 0.2.0.0 && < 0.4
31− , bloodhound >= 0.11.0.0 && < 0.13
32− , uuid >= 1.3.12 && < 1.4
33− , aeson >=0.6 && <1.2
34− , stm >= 2.4.3 && < 2.5
35− , stm-chans >= 3.0.0.2 && < 3.1
36− , async >= 2.0.1.0 && < 2.2
37− , enclosed-exceptions >= 1.0.0 && < 1.1
38− , http-client >= 0.3 && < 0.6
39− , text >= 0.11 && < 1.3
40− , retry >= 0.7 && < 0.8
38+ , katip >= 0.8.0.0
39+ , bloodhound >= 0.13.0.0
40+ , uuid >= 1.3.12
41+ , aeson >=0.6
42+ , stm >= 2.4.3
43+ , stm-chans >= 3.0.0.2
44+ , async >= 2.0.1.0
45+ , safe-exceptions >= 0.1.0.0
46+ , http-client >= 0.3
47+ , text >= 0.11
48+ , retry >= 0.7
4149 , exceptions
42− , scientific >= 0.3.0.0 && < 0.4
43− , unordered-containers >= 0.1.0.0 && < 0.3
44− , transformers >= 0.2 && < 0.6
45− , http-types >= 0.8 && < 0.10
46− , time >= 1 && < 1.7
50+ , scientific >= 0.3.0.0
51+ , unordered-containers >= 0.1.0.0
52+ , transformers >= 0.2
53+ , http-types >= 0.8
54+ , time >= 1
55+ , bytestring
56+ , semigroups
4757 hs-source-dirs: src
4858 default-language: Haskell2010
4959 hs-source-dirs: src
50− default-language: Haskell2010
5160 if flag(lib-Werror)
5261 ghc-options: -Wall -Werror
5362
@@ -63,7 +72,7 @@ benchmark bench
6372 , bloodhound
6473 , deepseq
6574 , criterion >= 1.1.0.0
66− , rng-utils
75+ , random
6776 , uuid
6877 , text
6978 , unordered-containers
@@ -96,8 +105,7 @@ test-suite test
96105 , scientific
97106 , time
98107 , stm
99−
100− if flag(lib-Werror)
101− ghc-options: -Wall -Werror
108+ , bytestring
109+ , tagged
102110
103111 ghc-options: -threaded -rtsopts
katip-elasticsearch/src/Katip/Scribes/ElasticSearch.hs+54−366
@@ -1,14 +1,41 @@
1−{-# LANGUAGE DeriveDataTypeable #-}
2−{-# LANGUAGE OverloadedStrings #-}
3−{-# LANGUAGE RankNTypes #-}
4−{-# LANGUAGE RecordWildCards #-}
5−{-# LANGUAGE ScopedTypeVariables #-}
1+{-# LANGUAGE CPP #-}
62-- | Includes a scribe that can be used to log structured, JSON log
73-- messages to ElasticSearch. These logs can be explored easily using
84-- <https://www.elastic.co/products/kibana kibana> or your tool of
9−-- choice.
5+-- choice. Supports ElasticSearch servers with version 1.x or 5.x by
6+-- way of different configs.
107--
11−-- == __Important Note on Index Settings__
8+-- Example of configuring for ES5:
9+--
10+-- @
11+--
12+-- import Control.Exception
13+-- import Database.V5.Bloodhound
14+-- import Network.HTTP.Client
15+-- import Katip
16+-- import Katip.Scribes.ElasticSearch
17+--
18+-- main :: IO ()
19+-- main = do
20+-- mgr <- newManager defaultManagerSettings
21+-- let bhe = mkBHEnv (Server "http://localhost:9200") mgr
22+-- esScribe <- mkEsScribe
23+-- -- Reasonable for production
24+-- defaultEsScribeCfgV5
25+-- -- Reasonable for single-node in development
26+-- -- defaultEsScribeCfgV5 { essIndexSettings = IndexSettings (ShardCound 1) (ReplicaCount 0)} :: EsScribeCfg ESV5
27+-- bhe
28+-- (IndexName "all-indices-prefixed-with")
29+-- (MappingName "application-logs")
30+-- DebugS
31+-- V3
32+-- let mkLogEnv = registerScribe "es" esScribe defaultScribeSettings =<< initLogEnv \"MyApp\" "production"
33+-- bracket mkLogEnv closeScribes $ \\le -> runKatipT le $ do
34+-- logMsg "ns" InfoS "This goes to elasticsearch"
35+--
36+-- @
37+--
38+-- __Important Note on Index Settings__
1239--
1340-- 'defaultEsScribeCfg' inherits a set of default index settings from
1441-- the @bloodhound@ package. These settings at this time of writing
@@ -30,6 +57,9 @@ module Katip.Scribes.ElasticSearch
3057 , mkEsQueueSize
3158 , EsPoolSize
3259 , mkEsPoolSize
60+ , IndexShardingPolicy(..)
61+ , IndexNameSegment(..)
62+ -- ** EsScribeCfg and fields
3363 , EsScribeCfg
3464 , essRetryPolicy
3565 , essQueueSize
@@ -37,375 +67,33 @@ module Katip.Scribes.ElasticSearch
3767 , essAnnotateTypes
3868 , essIndexSettings
3969 , essIndexSharding
40− , IndexShardingPolicy(..)
41− , IndexNameSegment(..)
4270 , defaultEsScribeCfg
71+#if !MIN_VERSION_bloodhound(0,17,0)
72+ , defaultEsScribeCfgV1
73+#endif
74+ , defaultEsScribeCfgV5
75+ -- ** Version-Proxied APIS
76+ -- $versionproxies
77+ , defaultEsScribeCfg'
78+#if !MIN_VERSION_bloodhound(0,17,0)
79+ , ESV1
80+#endif
81+ , ESV5
4382 -- * Utilities
4483 , mkDocId
4584 , module Katip.Scribes.ElasticSearch.Annotations
46− , roundToSunday
4785 ) where
4886
4987
5088-------------------------------------------------------------------------------
51−import Control.Applicative as A
52−import Control.Concurrent
53−import Control.Concurrent.Async
54−import Control.Concurrent.STM.TBMQueue
55−import Control.Exception.Base
56−import Control.Exception.Enclosed
57−import Control.Monad
58−import Control.Monad.Catch
59−import Control.Monad.IO.Class
60−import Control.Monad.STM
61−import Control.Retry (RetryPolicy,
62− exponentialBackoff,
63− limitRetries,
64− recovering)
65−import Data.Aeson
66−import Data.Monoid ((<>))
67−import Data.Text (Text)
68−import qualified Data.Text as T
69−import qualified Data.Text.Encoding as T
70−import Data.Time
71−import Data.Time.Calendar.WeekDate
72−import Data.Typeable
73−import Data.UUID
74−import qualified Data.UUID.V4 as UUID4
75−import Database.Bloodhound
76−import Network.HTTP.Client
77−import Network.HTTP.Types.Status
78−import Text.Printf (printf)
79−-------------------------------------------------------------------------------
80−import Katip.Core
8189import Katip.Scribes.ElasticSearch.Annotations
90+import Katip.Scribes.ElasticSearch.Internal
8291-------------------------------------------------------------------------------
8392
8493
85−data EsScribeCfg = EsScribeCfg {
86− essRetryPolicy :: RetryPolicy
87− -- ^ Retry policy when there are errors sending logs to the server
88− , essQueueSize :: EsQueueSize
89− -- ^ Maximum size of the bounded log queue
90− , essPoolSize :: EsPoolSize
91− -- ^ Worker pool size limit for sending data to the
92− , essAnnotateTypes :: Bool
93− -- ^ Different payload items coexist in the "data" attribute in
94− -- ES. It is possible for different payloads to have different
95− -- types for the same key, e.g. an "id" key that is sometimes a
96− -- number and sometimes a string. If you're having ES do dynamic
97− -- mapping, the first log item will set the type and any that
98− -- don't conform will be *discarded*. If you set this to True,
99− -- keys will recursively be appended with their ES core
100− -- type. e.g. "id" would become "id::l" and "id::s"
101− -- automatically, so they won't conflict. When this library
102− -- exposes a querying API, we will try to make deserialization and
103− -- querying transparently remove the type annotations if this is
104− -- enabled.
105− , essIndexSettings :: IndexSettings
106− , essIndexSharding :: IndexShardingPolicy
107− } deriving (Typeable)
108−
109−
110−-- | Reasonable defaults for a config:
111−--
112−-- * defaultManagerSettings
113−--
114−-- * exponential backoff with 25ms base delay up to 5 retries
115−--
116−-- * Queue size of 1000
117−--
118−-- * Pool size of 2
119−--
120−-- * Annotate types set to False
121−--
122−-- * DailyIndexSharding
123−defaultEsScribeCfg :: EsScribeCfg
124−defaultEsScribeCfg = EsScribeCfg {
125− essRetryPolicy = exponentialBackoff 25 <> limitRetries 5
126− , essQueueSize = EsQueueSize 1000
127− , essPoolSize = EsPoolSize 2
128− , essAnnotateTypes = False
129− , essIndexSettings = defaultIndexSettings
130− , essIndexSharding = DailyIndexSharding
131− }
132−
133−
134−-------------------------------------------------------------------------------
135−-- | How should katip store your log data?
136−--
137−-- * NoIndexSharding will store all logs in one index name. This is
138−-- the simplest option but is not advised in production. In practice,
139−-- the index will grow very large and will get slower to
140−-- search. Deleting records based on some sort of retention period is
141−-- also extremely slow.
142−--
143−-- * MonthlyIndexSharding, DailyIndexSharding, HourlyIndexSharding,
144−-- EveryMinuteIndexSharding will generate indexes based on the time of
145−-- the log. Index name is treated as a prefix. So if your index name
146−-- is @foo@ and DailySharding is used, logs will be stored in
147−-- @foo-2016-2-25@, @foo-2016-2-26@ and so on. Index templating will
148−-- be used to set up mappings automatically. Deletes based on date are
149−-- very fast and queries can be restricted to date ranges for better
150−-- performance. Queries against all dates should use @foo-*@ as an
151−-- index name. Note that index aliasing's glob feature is not suitable
152−-- for these date ranges as it matches index names as they are
153−-- declared, so new dates will be excluded. DailyIndexSharding is a
154−-- reasonable choice. Changing index sharding strategies is not
155−-- advisable.
156−--
157−-- * CustomSharding: supply your own function that decomposes an item
158−-- into its index name hierarchy which will be appended to the index
159−-- name. So for instance if your function return ["arbitrary",
160−-- "prefix"], the index will be @foo-arbitrary-prefix@ and the index
161−-- template will be set to match @foo-*@. In general, you want to use
162−-- segments of increasing granularity (like year, month, day for
163−-- dates). This makes it easier to address groups of indexes
164−-- (e.g. @foo-2016-*@).
165−data IndexShardingPolicy = NoIndexSharding
166− | MonthlyIndexSharding
167− | WeeklyIndexSharding
168− -- ^ A special case of daily which shards to sunday
169− | DailyIndexSharding
170− | HourlyIndexSharding
171− | EveryMinuteIndexSharding
172− | CustomIndexSharding (forall a. Item a -> [IndexNameSegment])
173−
174−
175−instance Show IndexShardingPolicy where
176− show NoIndexSharding = "NoIndexSharding"
177− show MonthlyIndexSharding = "MonthlyIndexSharding"
178− show WeeklyIndexSharding = "WeeklyIndexSharding"
179− show DailyIndexSharding = "DailyIndexSharding"
180− show HourlyIndexSharding = "HourlyIndexSharding"
181− show EveryMinuteIndexSharding = "EveryMinuteIndexSharding"
182− show (CustomIndexSharding _) = "CustomIndexSharding λ"
183−
184−
185−-------------------------------------------------------------------------------
186−newtype IndexNameSegment = IndexNameSegment {
187− indexNameSegment :: Text
188− } deriving (Show, Eq, Ord)
189−
190−
191−-------------------------------------------------------------------------------
192−shardPolicySegs :: IndexShardingPolicy -> Item a -> [IndexNameSegment]
193−shardPolicySegs NoIndexSharding _ = []
194−shardPolicySegs MonthlyIndexSharding Item {..} = [sis y, sis m]
195− where
196− (y, m, _) = toGregorian (utctDay _itemTime)
197−shardPolicySegs WeeklyIndexSharding Item {..} = [sis y, sis m, sis d]
198− where
199− (y, m, d) = toGregorian (roundToSunday (utctDay _itemTime))
200−shardPolicySegs DailyIndexSharding Item {..} = [sis y, sis m, sis d]
201− where
202− (y, m, d) = toGregorian (utctDay _itemTime)
203−shardPolicySegs HourlyIndexSharding Item {..} = [sis y, sis m, sis d, sis h]
204− where
205− (y, m, d) = toGregorian (utctDay _itemTime)
206− (h, _) = splitTime (utctDayTime _itemTime)
207−shardPolicySegs EveryMinuteIndexSharding Item {..} = [sis y, sis m, sis d, sis h, sis mn]
208− where
209− (y, m, d) = toGregorian (utctDay _itemTime)
210− (h, mn) = splitTime (utctDayTime _itemTime)
211−shardPolicySegs (CustomIndexSharding f) i = f i
212−
213−
214−-------------------------------------------------------------------------------
215−-- | If the given day is sunday, returns the input, otherwise returns
216−-- the previous sunday
217−roundToSunday :: Day -> Day
218−roundToSunday d
219− | dow == 7 = d
220− | w > 1 = fromWeekDate y (w - 1) 7
221− | otherwise = fromWeekDate (y - 1) 53 7
222− where
223− (y, w, dow) = toWeekDate d
224−
225−
226−-------------------------------------------------------------------------------
227−chooseIxn :: IndexName -> IndexShardingPolicy -> Item a -> IndexName
228−chooseIxn (IndexName ixn) p i =
229− IndexName (T.intercalate "-" (ixn:segs))
230− where
231− segs = indexNameSegment A.<$> shardPolicySegs p i
232−
233−
234−-------------------------------------------------------------------------------
235−sis :: Integral a => a -> IndexNameSegment
236−sis = IndexNameSegment . T.pack . fmt
237− where
238− fmt = printf "%02d" . toInteger
239−
94+{- $versionproxies
24095
241−-------------------------------------------------------------------------------
242−splitTime :: DiffTime -> (Int, Int)
243−splitTime t = asMins `divMod` 60
244− where
245− asMins = floor t `div` 60
246−
247−
248−-------------------------------------------------------------------------------
249−data EsScribeSetupError = CouldNotCreateIndex !Reply
250− | CouldNotCreateMapping !Reply deriving (Typeable, Show)
251−
252−
253−instance Exception EsScribeSetupError
254−
255−-------------------------------------------------------------------------------
256−mkEsScribe
257− :: EsScribeCfg
258− -> BHEnv
259− -> IndexName
260− -- ^ Treated as a prefix if index sharding is enabled
261− -> MappingName
262− -> Severity
263− -> Verbosity
264− -> IO (Scribe, IO ())
265− -- ^ Returns a finalizer that will gracefully flush all remaining logs before shutting down workers
266−mkEsScribe cfg@EsScribeCfg {..} env ix mapping sev verb = do
267− q <- newTBMQueueIO $ unEsQueueSize essQueueSize
268− endSig <- newEmptyMVar
269−
270− runBH env $ do
271− chk <- indexExists ix
272− -- note that this doesn't update settings. That's not available
273− -- through the Bloodhound API yet
274− unless chk $ void $ do
275− r1 <- createIndex essIndexSettings ix
276− unless (statusIsSuccessful (responseStatus r1)) $
277− liftIO $ throwIO (CouldNotCreateIndex r1)
278− r2 <- if shardingEnabled
279− then putTemplate tpl tplName
280− else putMapping ix mapping (baseMapping mapping)
281− unless (statusIsSuccessful (responseStatus r2)) $
282− liftIO $ throwIO (CouldNotCreateMapping r2)
283−
284− workers <- replicateM (unEsPoolSize essPoolSize) $ async $
285− startWorker cfg env mapping q
286−
287− _ <- async $ do
288− takeMVar endSig
289− atomically $ closeTBMQueue q
290− mapM_ waitCatch workers
291− putMVar endSig ()
292−
293− let scribe = Scribe $ \ i ->
294− when (_itemSeverity i >= sev) $
295− void $ atomically $ tryWriteTBMQueue q (chooseIxn ix essIndexSharding i, itemJson' i)
296− let finalizer = putMVar endSig () >> takeMVar endSig
297− return (scribe, finalizer)
298− where
299− tplName = TemplateName ixn
300− shardingEnabled = case essIndexSharding of
301− NoIndexSharding -> False
302− _ -> True
303− tpl = IndexTemplate (TemplatePattern (ixn <> "-*")) (Just essIndexSettings) [toJSON (baseMapping mapping)]
304− IndexName ixn = ix
305− itemJson' i
306− | essAnnotateTypes = itemJson verb (TypeAnnotated <$> i)
307− | otherwise = itemJson verb i
308−
309−
310−-------------------------------------------------------------------------------
311−baseMapping :: MappingName -> Value
312−baseMapping (MappingName mn) =
313− object [ mn .= object ["properties" .= object prs] ]
314− where prs = [ str "thread"
315− , str "sev"
316− , str "pid"
317− , str "ns"
318− , str "msg"
319− , "loc" .= locType
320− , str "host"
321− , str "env"
322− , "at" .= dateType
323− , str "app"
324− ]
325− str k = k .= object ["type" .= String "string"]
326− locType = object ["properties" .= object locPairs]
327− locPairs = [ str "loc_pkg"
328− , str "loc_mod"
329− , str "loc_ln"
330− , str "loc_fn"
331− , str "loc_col"
332− ]
333− dateType = object [ "format" .= esDateFormat
334− , "type" .= String "date"
335− ]
336−
337−
338−-------------------------------------------------------------------------------
339−-- | Handle both old-style aeson and picosecond-level precision
340−esDateFormat :: Text
341−esDateFormat = "yyyy-MM-dd'T'HH:mm:ssZ||yyyy-MM-dd'T'HH:mm:ss.SSSZ||yyyy-MM-dd'T'HH:mm:ss.SSSSSSSSSSSSZ"
342−
343−
344−-------------------------------------------------------------------------------
345−mkDocId :: IO DocId
346−mkDocId = (DocId . T.decodeUtf8 . toASCIIBytes) `fmap` UUID4.nextRandom
347−
348−
349−-------------------------------------------------------------------------------
350−newtype EsQueueSize = EsQueueSize {
351− unEsQueueSize :: Int
352− } deriving (Show, Eq, Ord)
353−
354−
355−instance Bounded EsQueueSize where
356− minBound = EsQueueSize 1
357− maxBound = EsQueueSize maxBound
358−
359−
360−mkEsQueueSize :: Int -> Maybe EsQueueSize
361−mkEsQueueSize = mkNonZero EsQueueSize
362−
363−
364−-------------------------------------------------------------------------------
365−newtype EsPoolSize = EsPoolSize {
366− unEsPoolSize :: Int
367− } deriving (Show, Eq, Ord)
368−
369−
370−instance Bounded EsPoolSize where
371− minBound = EsPoolSize 1
372− maxBound = EsPoolSize maxBound
373−
374−
375−mkEsPoolSize :: Int -> Maybe EsPoolSize
376−mkEsPoolSize = mkNonZero EsPoolSize
377−
378−
379−-------------------------------------------------------------------------------
380−mkNonZero :: (Int -> a) -> Int -> Maybe a
381−mkNonZero ctor n
382− | n > 0 = Just $ ctor n
383− | otherwise = Nothing
384−
385−
386−-------------------------------------------------------------------------------
387−startWorker
388− :: EsScribeCfg
389− -> BHEnv
390− -> MappingName
391− -> TBMQueue (IndexName, Value)
392− -> IO ()
393−startWorker EsScribeCfg {..} env mapping q = go
394− where
395− go = do
396− popped <- atomically $ readTBMQueue q
397− case popped of
398− Just (ixn, v) -> do
399− sendLog ixn v `catchAny` eat
400− go
401− Nothing -> return ()
402− sendLog :: IndexName -> Value -> IO ()
403− sendLog ixn v = void $ recovering essRetryPolicy [handler] $ const $ do
404− did <- mkDocId
405− res <- runBH env $ indexDocument ixn mapping defaultIndexDocumentSettings v did
406− return res
407− eat _ = return ()
408− handler _ = Handler $ \e ->
409− case fromException e of
410− Just (_ :: AsyncException) -> return False
411− _ -> return True
96+ You may need these these functions and types if type inference
97+ fails. For instance, you may need to hint to the compiler that a
98+ config is @:: EsScribeCfg ESV5@, for instance.
99+-}
katip-elasticsearch/src/Katip/Scribes/ElasticSearch/Annotations.hs+2−2
@@ -12,7 +12,7 @@ import Data.Aeson
1212import qualified Data.Foldable as FT
1313import qualified Data.HashMap.Strict as HM
1414import Data.Maybe
15−import Data.Monoid
15+import Data.Monoid as M
1616import Data.Scientific (isFloating)
1717import Data.Text (Text)
1818import qualified Data.Text as T
@@ -65,7 +65,7 @@ annotateKeys = HM.fromList . map go . HM.toList
6565 where
6666 go (k, Object o) = (k, Object $ annotateKeys o)
6767 go (k, Array a) = (k, Array (annotateValue <$> a))
68− go (k, s@(String _)) = (k <> stringAnn, s)
68+ go (k, s@(String _)) = (k M.<> stringAnn, s)
6969 go (k, n@(Number sci)) = if isFloating sci
7070 then (k <> doubleAnn, n)
7171 else (k <> longAnn, n)
katip-elasticsearch/src/Katip/Scribes/ElasticSearch/Internal.hsnew file+577
@@ -0,0 +1,577 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveDataTypeable #-}
3+{-# LANGUAGE FlexibleContexts #-}
4+{-# LANGUAGE OverloadedStrings #-}
5+{-# LANGUAGE RankNTypes #-}
6+{-# LANGUAGE RecordWildCards #-}
7+{-# LANGUAGE ScopedTypeVariables #-}
8+{-# LANGUAGE TypeFamilies #-}
9+-- | This is an internal module. No guarantees are made in this module
10+-- about API stability.
11+module Katip.Scribes.ElasticSearch.Internal where
12+
13+
14+-------------------------------------------------------------------------------
15+import Control.Applicative as A
16+import Control.Concurrent
17+import Control.Concurrent.Async
18+import Control.Concurrent.STM.TBMQueue
19+import qualified Control.Exception.Safe as EX
20+import Control.Monad
21+import Control.Monad.Catch
22+import Control.Monad.IO.Class
23+import Control.Monad.STM
24+import Control.Retry (RetryPolicy,
25+ exponentialBackoff,
26+ limitRetries,
27+ recovering)
28+import Data.Aeson
29+import Data.ByteString.Lazy (ByteString)
30+import Data.List.NonEmpty (NonEmpty (..))
31+import Data.Monoid as Monoid
32+import Data.Text (Text)
33+import qualified Data.Text as T
34+import qualified Data.Text.Encoding as T
35+import Data.Time
36+import Data.Time.Calendar.WeekDate
37+import Data.Typeable as Typeable
38+import Data.UUID
39+import qualified Data.UUID.V4 as UUID4
40+#if MIN_VERSION_bloodhound(0,17,0)
41+import qualified Database.Bloodhound as V5
42+#else
43+import qualified Database.V1.Bloodhound as V1
44+import qualified Database.V5.Bloodhound as V5
45+#endif
46+import Network.HTTP.Client
47+import Network.HTTP.Types.Status
48+import Text.Printf (printf)
49+-------------------------------------------------------------------------------
50+import Katip.Core
51+import Katip.Scribes.ElasticSearch.Annotations
52+-------------------------------------------------------------------------------
53+
54+
55+-- | EsScribeCfg now carries a type variable for the version of
56+-- ElasticSearch it targets, either 'ESV1' or 'ESV5'. You can use
57+-- 'defaultEsScribeCfgV1' and 'defaultESScribeCfgV5' for a good
58+-- starting point depending on the ES version you have.
59+data EsScribeCfg v = EsScribeCfg {
60+ essRetryPolicy :: RetryPolicy
61+ -- ^ Retry policy when there are errors sending logs to the server
62+ , essQueueSize :: EsQueueSize
63+ -- ^ Maximum size of the bounded log queue
64+ , essPoolSize :: EsPoolSize
65+ -- ^ Worker pool size limit for sending data to the
66+ , essAnnotateTypes :: Bool
67+ -- ^ Different payload items coexist in the "data" attribute in
68+ -- ES. It is possible for different payloads to have different
69+ -- types for the same key, e.g. an "id" key that is sometimes a
70+ -- number and sometimes a string. If you're having ES do dynamic
71+ -- mapping, the first log item will set the type and any that
72+ -- don't conform will be *discarded*. If you set this to True,
73+ -- keys will recursively be appended with their ES core
74+ -- type. e.g. "id" would become "id::l" and "id::s"
75+ -- automatically, so they won't conflict. When this library
76+ -- exposes a querying API, we will try to make deserialization and
77+ -- querying transparently remove the type annotations if this is
78+ -- enabled.
79+ , essIndexSettings :: IndexSettings v
80+ -- ^ This will be the IndexSettings type from the appropriate
81+ -- bloodhound module, either @Database.V1.Bloodhound@ or
82+ -- @Database.V5.Bloodhound@
83+ , essIndexSharding :: IndexShardingPolicy
84+ } deriving (Typeable)
85+
86+
87+-- | Reasonable defaults for a config:
88+--
89+-- * defaultManagerSettings
90+--
91+-- * exponential backoff with 25ms base delay up to 5 retries, for a total cumulative delay of 775ms
92+--
93+-- * Queue size of 1000
94+--
95+-- * Pool size of 2
96+--
97+-- * Annotate types set to False
98+--
99+-- * DailyIndexSharding
100+defaultEsScribeCfg' :: ESVersion v => proxy v -> EsScribeCfg v
101+defaultEsScribeCfg' prx = EsScribeCfg {
102+ essRetryPolicy = exponentialBackoff 25000 Monoid.<> limitRetries 5
103+ , essQueueSize = EsQueueSize 1000
104+ , essPoolSize = EsPoolSize 2
105+ , essAnnotateTypes = False
106+ , essIndexSettings = defaultIndexSettings prx
107+ , essIndexSharding = DailyIndexSharding
108+ }
109+
110+
111+
112+
113+-------------------------------------------------------------------------------
114+-- | Alias of 'defaultEsScribeCfgV5' to minimize API
115+-- breakage. Previous versions of katip-elasticsearch only supported
116+-- ES version 1 and defaulted to it.
117+defaultEsScribeCfg :: EsScribeCfg ESV5
118+defaultEsScribeCfg = defaultEsScribeCfgV5
119+
120+
121+-------------------------------------------------------------------------------
122+#if !MIN_VERSION_bloodhound(0,17,0)
123+-- | EsScribeCfg that will use ElasticSearch V1
124+defaultEsScribeCfgV1 :: EsScribeCfg ESV1
125+defaultEsScribeCfgV1 = defaultEsScribeCfg' (Typeable.Proxy :: Typeable.Proxy ESV1)
126+#endif
127+
128+-------------------------------------------------------------------------------
129+-- | EsScribeCfg that will use ElasticSearch V5
130+defaultEsScribeCfgV5 :: EsScribeCfg ESV5
131+defaultEsScribeCfgV5 = defaultEsScribeCfg' (Typeable.Proxy :: Typeable.Proxy ESV5)
132+
133+
134+-------------------------------------------------------------------------------
135+-- | How should katip store your log data?
136+--
137+-- * NoIndexSharding will store all logs in one index name. This is
138+-- the simplest option but is not advised in production. In practice,
139+-- the index will grow very large and will get slower to
140+-- search. Deleting records based on some sort of retention period is
141+-- also extremely slow.
142+--
143+-- * MonthlyIndexSharding, DailyIndexSharding, HourlyIndexSharding,
144+-- EveryMinuteIndexSharding will generate indexes based on the time of
145+-- the log. Index name is treated as a prefix. So if your index name
146+-- is @foo@ and DailySharding is used, logs will be stored in
147+-- @foo-2016-2-25@, @foo-2016-2-26@ and so on. Index templating will
148+-- be used to set up mappings automatically. Deletes based on date are
149+-- very fast and queries can be restricted to date ranges for better
150+-- performance. Queries against all dates should use @foo-*@ as an
151+-- index name. Note that index aliasing's glob feature is not suitable
152+-- for these date ranges as it matches index names as they are
153+-- declared, so new dates will be excluded. DailyIndexSharding is a
154+-- reasonable choice. Changing index sharding strategies is not
155+-- advisable.
156+--
157+-- * CustomSharding: supply your own function that decomposes an item
158+-- into its index name hierarchy which will be appended to the index
159+-- name. So for instance if your function return ["arbitrary",
160+-- "prefix"], the index will be @foo-arbitrary-prefix@ and the index
161+-- template will be set to match @foo-*@. In general, you want to use
162+-- segments of increasing granularity (like year, month, day for
163+-- dates). This makes it easier to address groups of indexes
164+-- (e.g. @foo-2016-*@).
165+data IndexShardingPolicy = NoIndexSharding
166+ | MonthlyIndexSharding
167+ | WeeklyIndexSharding
168+ -- ^ A special case of daily which shards to sunday
169+ | DailyIndexSharding
170+ | HourlyIndexSharding
171+ | EveryMinuteIndexSharding
172+ | CustomIndexSharding (forall a. Item a -> [IndexNameSegment])
173+
174+
175+instance Show IndexShardingPolicy where
176+ show NoIndexSharding = "NoIndexSharding"
177+ show MonthlyIndexSharding = "MonthlyIndexSharding"
178+ show WeeklyIndexSharding = "WeeklyIndexSharding"
179+ show DailyIndexSharding = "DailyIndexSharding"
180+ show HourlyIndexSharding = "HourlyIndexSharding"
181+ show EveryMinuteIndexSharding = "EveryMinuteIndexSharding"
182+ show (CustomIndexSharding _) = "CustomIndexSharding λ"
183+
184+
185+-------------------------------------------------------------------------------
186+newtype IndexNameSegment = IndexNameSegment {
187+ indexNameSegment :: Text
188+ } deriving (Show, Eq, Ord)
189+
190+
191+-------------------------------------------------------------------------------
192+shardPolicySegs :: IndexShardingPolicy -> Item a -> [IndexNameSegment]
193+shardPolicySegs NoIndexSharding _ = []
194+shardPolicySegs MonthlyIndexSharding Item {..} = [sis y, sis m]
195+ where
196+ (y, m, _) = toGregorian (utctDay _itemTime)
197+shardPolicySegs WeeklyIndexSharding Item {..} = [sis y, sis m, sis d]
198+ where
199+ (y, m, d) = toGregorian (roundToSunday (utctDay _itemTime))
200+shardPolicySegs DailyIndexSharding Item {..} = [sis y, sis m, sis d]
201+ where
202+ (y, m, d) = toGregorian (utctDay _itemTime)
203+shardPolicySegs HourlyIndexSharding Item {..} = [sis y, sis m, sis d, sis h]
204+ where
205+ (y, m, d) = toGregorian (utctDay _itemTime)
206+ (h, _) = splitTime (utctDayTime _itemTime)
207+shardPolicySegs EveryMinuteIndexSharding Item {..} = [sis y, sis m, sis d, sis h, sis mn]
208+ where
209+ (y, m, d) = toGregorian (utctDay _itemTime)
210+ (h, mn) = splitTime (utctDayTime _itemTime)
211+shardPolicySegs (CustomIndexSharding f) i = f i
212+
213+
214+-------------------------------------------------------------------------------
215+-- | If the given day is sunday, returns the input, otherwise returns
216+-- the previous sunday
217+roundToSunday :: Day -> Day
218+roundToSunday d
219+ | dow == 7 = d
220+ | w > 1 = fromWeekDate y (w - 1) 7
221+ | otherwise = fromWeekDate (y - 1) 53 7
222+ where
223+ (y, w, dow) = toWeekDate d
224+
225+
226+-------------------------------------------------------------------------------
227+chooseIxn :: ESVersion v => proxy v -> IndexName v -> IndexShardingPolicy -> Item a -> IndexName v
228+chooseIxn prx ixn p i =
229+ toIndexName prx (T.intercalate "-" ((fromIndexName prx ixn):segs))
230+ where
231+ segs = indexNameSegment A.<$> shardPolicySegs p i
232+
233+
234+-------------------------------------------------------------------------------
235+sis :: Integral a => a -> IndexNameSegment
236+sis = IndexNameSegment . T.pack . fmt
237+ where
238+ fmt = printf "%02d" . toInteger
239+
240+
241+-------------------------------------------------------------------------------
242+splitTime :: DiffTime -> (Int, Int)
243+splitTime t = asMins `divMod` 60
244+ where
245+ asMins = floor t `div` 60
246+
247+
248+-------------------------------------------------------------------------------
249+data EsScribeSetupError = CouldNotCreateIndex !(Response ByteString)
250+ | CouldNotUpdateIndexSettings !(Response ByteString)
251+ | CouldNotCreateMapping !(Response ByteString)
252+ | CouldNotPutTemplate !(Response ByteString)
253+ deriving (Typeable, Show)
254+
255+
256+instance Exception EsScribeSetupError
257+
258+
259+-------------------------------------------------------------------------------
260+-- | The Any field tagged with a @v@ corresponds to the type of the
261+-- same name in the corresponding @bloodhound@ module. For instance,
262+-- if you are configuring for ElasticSearch version 1, import
263+-- @Database.V1.Bloodhound@ and @BHEnv v@ will refer to @BHEnv@ from
264+-- that module, @IndexName v@ will repsond to @IndexName@ from that
265+-- module, etc.
266+mkEsScribe
267+ :: forall v. ( ESVersion v
268+ , MonadIO (BH v IO)
269+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
270+ , Functor (BH v IO)
271+#endif
272+ )
273+ => EsScribeCfg v
274+ -> BHEnv v
275+ -> IndexName v
276+ -- ^ Treated as a prefix if index sharding is enabled
277+ -> MappingName v
278+ -> PermitFunc
279+ -> Verbosity
280+ -> IO Scribe
281+mkEsScribe cfg@EsScribeCfg {..} env ix mapping permit verb = do
282+ q <- newTBMQueueIO $ unEsQueueSize essQueueSize
283+ endSig <- newEmptyMVar
284+
285+ runBH prx env $ do
286+ if shardingEnabled
287+ then do
288+ -- create or update
289+ res <- putTemplate prx tpl tplName
290+ unless (statusIsSuccessful (responseStatus res)) $
291+ liftIO $ EX.throwIO (CouldNotPutTemplate res)
292+ else do
293+ ixExists <- indexExists prx ix
294+ if ixExists
295+ then do
296+ res <- updateIndexSettings prx (toUpdatabaleIndexSettings prx essIndexSettings) ix
297+ unless (statusIsSuccessful (responseStatus res)) $
298+ liftIO $ EX.throwIO (CouldNotUpdateIndexSettings res)
299+ else do
300+ r1 <- createIndex prx essIndexSettings ix
301+ unless (statusIsSuccessful (responseStatus r1)) $
302+ liftIO $ EX.throwIO (CouldNotCreateIndex r1)
303+ r2 <- putMapping prx ix mapping base
304+ unless (statusIsSuccessful (responseStatus r2)) $
305+ liftIO $ EX.throwIO (CouldNotCreateMapping r2)
306+
307+ workers <- replicateM (unEsPoolSize essPoolSize) $ async $
308+ startWorker cfg env mapping q
309+
310+ _ <- async $ do
311+ takeMVar endSig
312+ atomically $ closeTBMQueue q
313+ mapM_ waitCatch workers
314+ putMVar endSig ()
315+
316+ let finalizer = putMVar endSig () >> takeMVar endSig
317+ return (Scribe (logger q) finalizer permit)
318+ where
319+ logger :: forall a. LogItem a => TBMQueue (IndexName v, Value) -> Item a -> IO ()
320+ logger q i =
321+ void $ atomically $ tryWriteTBMQueue q (chooseIxn prx ix essIndexSharding i, itemJson' i)
322+ prx :: Typeable.Proxy v
323+ prx = Typeable.Proxy
324+ tplName = toTemplateName prx ixn
325+ shardingEnabled = case essIndexSharding of
326+ NoIndexSharding -> False
327+ _ -> True
328+ tpl = toIndexTemplate prx (toTemplatePattern prx (ixn <> "-*")) (Just essIndexSettings) [toJSON base]
329+ base = baseMapping prx mapping
330+ ixn = fromIndexName prx ix
331+ itemJson' :: LogItem a => Item a -> Value
332+ itemJson' i
333+ | essAnnotateTypes = itemJson verb (TypeAnnotated <$> i)
334+ | otherwise = itemJson verb i
335+
336+
337+-------------------------------------------------------------------------------
338+baseMapping :: ESVersion v => proxy v -> MappingName v -> Value
339+baseMapping prx mn =
340+ object [ fromMappingName prx mn .= object ["properties" .= object prs] ]
341+ where prs = [ unanalyzedString "thread"
342+ , unanalyzedString "sev"
343+ , unanalyzedString "pid"
344+ -- ns is frequently fulltext searched
345+ , analyzedString "ns"
346+ -- we want message to be fulltext searchable
347+ , analyzedString "msg"
348+ , "loc" .= locType
349+ , unanalyzedString "host"
350+ , unanalyzedString "env"
351+ , "at" .= dateType
352+ , unanalyzedString "app"
353+ ]
354+ unanalyzedString k = k .= unanalyzedStringSpec prx
355+ analyzedString k = k .= analyzedStringSpec prx
356+ locType = object ["properties" .= object locPairs]
357+ locPairs = [ unanalyzedString "loc_pkg"
358+ , unanalyzedString "loc_mod"
359+ , unanalyzedString "loc_ln"
360+ , unanalyzedString "loc_fn"
361+ , unanalyzedString "loc_col"
362+ ]
363+ dateType = object [ "format" .= esDateFormat
364+ , "type" .= String "date"
365+ ]
366+
367+
368+-------------------------------------------------------------------------------
369+-- | Handle both old-style aeson and picosecond-level precision
370+esDateFormat :: Text
371+esDateFormat = "yyyy-MM-dd'T'HH:mm:ssZ||yyyy-MM-dd'T'HH:mm:ss.SSSZ||yyyy-MM-dd'T'HH:mm:ss.SSSSSSSSSSSSZ"
372+
373+
374+-------------------------------------------------------------------------------
375+mkDocId :: ESVersion v => proxy v -> IO (DocId v)
376+mkDocId prx = (toDocId prx . T.decodeUtf8 . toASCIIBytes) `fmap` UUID4.nextRandom
377+
378+
379+-------------------------------------------------------------------------------
380+newtype EsQueueSize = EsQueueSize {
381+ unEsQueueSize :: Int
382+ } deriving (Show, Eq, Ord)
383+
384+
385+instance Bounded EsQueueSize where
386+ minBound = EsQueueSize 1
387+ maxBound = EsQueueSize maxBound
388+
389+
390+mkEsQueueSize :: Int -> Maybe EsQueueSize
391+mkEsQueueSize = mkNonZero EsQueueSize
392+
393+
394+-------------------------------------------------------------------------------
395+newtype EsPoolSize = EsPoolSize {
396+ unEsPoolSize :: Int
397+ } deriving (Show, Eq, Ord)
398+
399+
400+instance Bounded EsPoolSize where
401+ minBound = EsPoolSize 1
402+ maxBound = EsPoolSize maxBound
403+
404+
405+mkEsPoolSize :: Int -> Maybe EsPoolSize
406+mkEsPoolSize = mkNonZero EsPoolSize
407+
408+
409+-------------------------------------------------------------------------------
410+mkNonZero :: (Int -> a) -> Int -> Maybe a
411+mkNonZero ctor n
412+ | n > 0 = Just $ ctor n
413+ | otherwise = Nothing
414+
415+
416+-------------------------------------------------------------------------------
417+startWorker
418+ :: forall v. (ESVersion v)
419+ => EsScribeCfg v
420+ -> BHEnv v
421+ -> MappingName v
422+ -> TBMQueue (IndexName v, Value)
423+ -> IO ()
424+startWorker EsScribeCfg {..} env mapping q = go
425+ where
426+ go = do
427+ popped <- atomically $ readTBMQueue q
428+ case popped of
429+ Just (ixn, v) -> do
430+ sendLog ixn v `EX.catchAny` eat
431+ go
432+ Nothing -> return ()
433+ prx :: Typeable.Proxy v
434+ prx = Typeable.Proxy
435+ sendLog :: IndexName v -> Value -> IO ()
436+ sendLog ixn v = void $ recovering essRetryPolicy [handler] $ const $ do
437+ did <- mkDocId prx
438+ res <- runBH prx env $ indexDocument prx ixn mapping (defaultIndexDocumentSettings prx) v did
439+ return res
440+ eat _ = return ()
441+ handler _ = Handler $ \e ->
442+ case fromException e of
443+ Just (_ :: EX.SomeAsyncException) -> return False
444+ _ -> return True
445+
446+
447+-------------------------------------------------------------------------------
448+-- We are spanning multiple versions of ES which use completely
449+-- separate types and APIs, but the subset we use is the same for both
450+-- versions. This will be kept up to date with bloodhound's supported
451+-- versions and should be minimally visible to the end user.
452+class ESVersion v where
453+ -- Types
454+ type BHEnv v
455+ type IndexSettings v
456+ defaultIndexSettings :: proxy v -> IndexSettings v
457+ type UpdatableIndexSetting v
458+ type IndexName v
459+ toIndexName :: proxy v -> Text -> IndexName v
460+ fromIndexName :: proxy v -> IndexName v -> Text
461+ type MappingName v
462+ fromMappingName :: proxy v -> MappingName v -> Text
463+ type DocId v
464+ toDocId :: proxy v -> Text -> DocId v
465+ type BH v :: (* -> *) -> * -> *
466+ runBH :: proxy v -> BHEnv v -> BH v m a -> m a
467+ type TemplateName v
468+ toTemplateName :: proxy v -> Text -> TemplateName v
469+ type TemplatePattern v
470+ toTemplatePattern :: proxy v -> Text -> TemplatePattern v
471+ type IndexTemplate v
472+ toIndexTemplate :: proxy v -> TemplatePattern v -> Maybe (IndexSettings v) -> [Value] -> IndexTemplate v
473+ type IndexDocumentSettings v
474+ defaultIndexDocumentSettings :: proxy v -> IndexDocumentSettings v
475+
476+ toUpdatabaleIndexSettings :: proxy v -> IndexSettings v -> NonEmpty (UpdatableIndexSetting v)
477+
478+ -- Operations
479+ -- We're deciding on IO here, but it isn't necessary
480+ indexExists :: proxy v -> IndexName v -> BH v IO Bool
481+ indexDocument :: ToJSON doc => proxy v -> IndexName v -> MappingName v -> IndexDocumentSettings v -> doc -> DocId v -> BH v IO (Response ByteString)
482+ createIndex :: proxy v -> IndexSettings v -> IndexName v -> BH v IO (Response ByteString)
483+ updateIndexSettings :: proxy v -> NonEmpty (UpdatableIndexSetting v) -> IndexName v -> BH v IO (Response ByteString)
484+ putTemplate :: proxy v -> IndexTemplate v -> TemplateName v -> BH v IO (Response ByteString)
485+ putMapping :: (ToJSON a) => proxy v -> IndexName v -> MappingName v -> a -> BH v IO (Response ByteString)
486+
487+ -- In ES 5 and beyond, "string" was deprecated in favor of text for
488+ -- fulltext and keyword for unanalyzed tokens
489+ unanalyzedStringSpec :: proxy v -> Value
490+ analyzedStringSpec :: proxy v -> Value
491+
492+
493+
494+#if !MIN_VERSION_bloodhound(0,17,0)
495+data ESV1 = ESV1
496+{-# DEPRECATED ESV1 "ESV1 is deprecated and removed in bloodhound >= 0.17.0" #-}
497+
498+
499+instance ESVersion ESV1 where
500+ type BHEnv ESV1 = V1.BHEnv
501+ type IndexSettings ESV1 = V1.IndexSettings
502+ defaultIndexSettings _ = V1.defaultIndexSettings
503+ type IndexName ESV1 = V1.IndexName
504+ type UpdatableIndexSetting ESV1 = V1.UpdatableIndexSetting
505+ toIndexName _ = V1.IndexName
506+ fromIndexName _ (V1.IndexName x) = x
507+ type MappingName ESV1 = V1.MappingName
508+ fromMappingName _ (V1.MappingName x) = x
509+ type DocId ESV1 = V1.DocId
510+ toDocId _ = V1.DocId
511+ type BH ESV1 = V1.BH
512+ runBH _ = V1.runBH
513+ type TemplateName ESV1 = V1.TemplateName
514+ toTemplateName _ = V1.TemplateName
515+ type TemplatePattern ESV1 = V1.TemplatePattern
516+ toTemplatePattern _ = V1.TemplatePattern
517+ type IndexTemplate ESV1 = V1.IndexTemplate
518+ toIndexTemplate _ = V1.IndexTemplate
519+ type IndexDocumentSettings ESV1 = V1.IndexDocumentSettings
520+ toUpdatabaleIndexSettings _ s =
521+ (V1.NumberOfReplicas (V1.indexReplicas s)) :| []
522+ defaultIndexDocumentSettings _ = V1.defaultIndexDocumentSettings
523+ indexExists _ = V1.indexExists
524+ indexDocument _ = V1.indexDocument
525+ createIndex _ = V1.createIndex
526+ updateIndexSettings _ = V1.updateIndexSettings
527+ putTemplate _ = V1.putTemplate
528+ putMapping _ = V1.putMapping
529+ unanalyzedStringSpec _ = object
530+ [ "type" .= String "string"
531+ , "index" .= String "not_analyzed"
532+ ]
533+ analyzedStringSpec _ = object
534+ [ "type" .= String "string"
535+ , "index" .= String "analyzed"
536+ ]
537+#endif
538+
539+
540+data ESV5 = ESV5
541+
542+instance ESVersion ESV5 where
543+ type BHEnv ESV5 = V5.BHEnv
544+ type IndexSettings ESV5 = V5.IndexSettings
545+ type UpdatableIndexSetting ESV5 = V5.UpdatableIndexSetting
546+ defaultIndexSettings _ = V5.defaultIndexSettings
547+ type IndexName ESV5 = V5.IndexName
548+ toIndexName _ = V5.IndexName
549+ fromIndexName _ (V5.IndexName x) = x
550+ type MappingName ESV5 = V5.MappingName
551+ fromMappingName _ (V5.MappingName x) = x
552+ type DocId ESV5 = V5.DocId
553+ toDocId _ = V5.DocId
554+ type BH ESV5 = V5.BH
555+ runBH _ = V5.runBH
556+ type TemplateName ESV5 = V5.TemplateName
557+ toTemplateName _ = V5.TemplateName
558+ type TemplatePattern ESV5 = V5.TemplatePattern
559+ toTemplatePattern _ = V5.TemplatePattern
560+ type IndexTemplate ESV5 = V5.IndexTemplate
561+ toIndexTemplate _ = V5.IndexTemplate
562+ type IndexDocumentSettings ESV5 = V5.IndexDocumentSettings
563+ toUpdatabaleIndexSettings _ s =
564+ (V5.NumberOfReplicas (V5.indexReplicas s)) :| []
565+ defaultIndexDocumentSettings _ = V5.defaultIndexDocumentSettings
566+ indexExists _ = V5.indexExists
567+ indexDocument _ = V5.indexDocument
568+ createIndex _ = V5.createIndex
569+ updateIndexSettings _ = V5.updateIndexSettings
570+ putTemplate _ = V5.putTemplate
571+ putMapping _ = V5.putMapping
572+ unanalyzedStringSpec _ = object
573+ [ "type" .= String "keyword"
574+ ]
575+ analyzedStringSpec _ = object
576+ [ "type" .= String "text"
577+ ]
katip-elasticsearch/test/Main.hs+293−70
@@ -1,7 +1,13 @@
1+{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveDataTypeable #-}
3+{-# LANGUAGE FlexibleContexts #-}
4+{-# LANGUAGE KindSignatures #-}
15{-# LANGUAGE OverloadedStrings #-}
6+{-# LANGUAGE RankNTypes #-}
27{-# LANGUAGE RecordWildCards #-}
38{-# LANGUAGE ScopedTypeVariables #-}
49{-# LANGUAGE TemplateHaskell #-}
10+{-# LANGUAGE TypeFamilies #-}
511{-# OPTIONS_GHC -fno-warn-orphans #-}
612module Main
713 ( main
@@ -9,117 +15,283 @@ module Main
915
1016
1117-------------------------------------------------------------------------------
12−import Control.Applicative as A
18+import Control.Applicative as A
1319import Control.Concurrent.STM
14−import Control.Lens hiding (mapping, (.=))
20+import Control.Exception
21+import Control.Lens hiding (mapping, (.=))
1522import Control.Monad
1623import Control.Monad.IO.Class
1724import Data.Aeson
1825import Data.Aeson.Lens
1926import Data.Aeson.Types
20−import qualified Data.HashMap.Strict as HM
21−import qualified Data.Map as M
22−import Data.Monoid
27+import Data.ByteString.Lazy (ByteString)
28+import qualified Data.HashMap.Strict as HM
29+import Data.Monoid as M
2330import Data.Scientific
31+import Data.Tagged
32+import Data.Text (Text)
2433import Data.Time
2534import Data.Time.Calendar.WeekDate
26−import qualified Data.Vector as V
27−import Database.Bloodhound hiding (key)
35+import Data.Typeable as Typeable
36+import qualified Data.Vector as V
37+#if MIN_VERSION_bloodhound(0,17,0)
38+import qualified Database.Bloodhound as V5
39+#else
40+import qualified Database.V1.Bloodhound as V1
41+import qualified Database.V5.Bloodhound as V5
42+#endif
2843import Network.HTTP.Client
2944import Network.HTTP.Types.Status
30−import Test.QuickCheck.Instances ()
45+import Test.QuickCheck.Instances ()
3146import Test.Tasty
3247import Test.Tasty.HUnit
48+import Test.Tasty.Options
3349import Test.Tasty.QuickCheck
3450-------------------------------------------------------------------------------
3551import Katip
36−import Katip.Scribes.ElasticSearch
52+import Katip.Scribes.ElasticSearch.Annotations
53+import Katip.Scribes.ElasticSearch.Internal
3754-------------------------------------------------------------------------------
3855
3956
4057main :: IO ()
41−main = defaultMain $ testGroup "katip-elasticsearch"
58+main = defaultMainWithIngredients ings $ askOption $ \vers -> testGroup "katip-elasticsearch"
4259 [
43− esTests
60+ case vers of
61+#if !MIN_VERSION_bloodhound(0,17,0)
62+ TestV1 -> esTests (Typeable.Proxy :: Typeable.Proxy ESV1)
63+#endif
64+ TestV5 -> esTests (Typeable.Proxy :: Typeable.Proxy ESV5)
4465 , typeAnnotatedTests
4566 , roundToSundayTests
4667 ]
68+ where
69+ ings = (includingOptions [Option (Typeable.Proxy :: Typeable.Proxy TestWithESVersion)]):defaultIngredients
4770
4871
4972-------------------------------------------------------------------------------
50−setupSearch :: (EsScribeCfg -> EsScribeCfg) -> IO (Scribe, IO ())
51−setupSearch modScribeCfg = do
52− bh dropESSchema
73+data TestWithESVersion = TestV5
74+#if !MIN_VERSION_bloodhound(0,17,0)
75+ | TestV1
76+#endif
77+ deriving (Typeable)
78+
79+
80+instance IsOption TestWithESVersion where
81+ defaultValue = TestV5
82+#if !MIN_VERSION_bloodhound(0,17,0)
83+ parseValue "1" = Just TestV1
84+#endif
85+ parseValue "5" = Just TestV5
86+ parseValue _ = Nothing
87+ optionName = Tagged "es-version"
88+#if MIN_VERSION_bloodhound(0,17,0)
89+ optionHelp = Tagged "Version of ES to test against, either 1 or 5, defaulting to 5."
90+#else
91+ optionHelp = Tagged "Version of ES to test against, only v5 is supported, but should work for higher versions."
92+#endif
93+
94+
95+class ESVersion v => TestESVersion v where
96+ type Server v
97+ toServer :: proxy v -> Text -> Server v
98+ toMappingName :: proxy v -> Text -> MappingName v
99+ type Search v
100+ type Query v
101+ type Filter v
102+ mkSearch :: proxy v -> Maybe (Query v) -> Maybe (Filter v) -> Search v
103+ mkBHEnv :: proxy v -> Server v -> Manager -> BHEnv v
104+ type ShardCount v
105+ toShardCount :: proxy v -> Int -> ShardCount v
106+ type ReplicaCount v
107+ toReplicaCount :: proxy v -> Int -> ReplicaCount v
108+ indexShards :: proxy v -> Lens' (IndexSettings v) (ShardCount v)
109+ indexReplicas :: proxy v -> Lens' (IndexSettings v) (ReplicaCount v)
110+
111+ deleteIndex :: proxy v -> IndexName v -> BH v IO (Response ByteString)
112+ deleteTemplate :: proxy v -> TemplateName v -> BH v IO (Response ByteString)
113+ refreshIndex :: proxy v -> IndexName v -> BH v IO (Response ByteString)
114+ withBH :: proxy v -> ManagerSettings -> Server v -> BH v IO a -> IO a
115+ searchByIndex :: proxy v -> IndexName v -> Search v -> BH v IO (Response ByteString)
116+
117+
118+#if !MIN_VERSION_bloodhound(0,17,0)
119+instance TestESVersion ESV1 where
120+ type Server ESV1 = V1.Server
121+ toServer _ = V1.Server
122+ toMappingName _ = V1.MappingName
123+ type Search ESV1 = V1.Search
124+ type Query ESV1 = V1.Query
125+ type Filter ESV1 = V1.Filter
126+ type ShardCount ESV1 = V1.ShardCount
127+ toShardCount _ = V1.ShardCount
128+ type ReplicaCount ESV1 = V1.ReplicaCount
129+ toReplicaCount _ = V1.ReplicaCount
130+ mkSearch _ = V1.mkSearch
131+ mkBHEnv _ = V1.mkBHEnv
132+ indexShards _ = lens V1.indexShards (\s v -> s { V1.indexShards = v})
133+ indexReplicas _ = lens V1.indexReplicas (\r v -> r { V1.indexReplicas = v})
134+
135+ deleteIndex _ = V1.deleteIndex
136+ deleteTemplate _ = V1.deleteTemplate
137+ refreshIndex _ = V1.refreshIndex
138+ withBH _ = V1.withBH
139+ searchByIndex _ = V1.searchByIndex
140+#endif
141+
142+
143+instance TestESVersion ESV5 where
144+ type Server ESV5 = V5.Server
145+ toServer _ = V5.Server
146+ toMappingName _ = V5.MappingName
147+ type Search ESV5 = V5.Search
148+ type Query ESV5 = V5.Query
149+ type Filter ESV5 = V5.Filter
150+ type ShardCount ESV5 = V5.ShardCount
151+ toShardCount _ = V5.ShardCount
152+ type ReplicaCount ESV5 = V5.ReplicaCount
153+ toReplicaCount _ = V5.ReplicaCount
154+ mkSearch _ = V5.mkSearch
155+ mkBHEnv _ = V5.mkBHEnv
156+ indexShards _ = lens V5.indexShards (\s v -> s { V5.indexShards = v})
157+ indexReplicas _ = lens V5.indexReplicas (\r v -> r { V5.indexReplicas = v})
158+
159+ deleteIndex _ = V5.deleteIndex
160+ deleteTemplate _ = V5.deleteTemplate
161+ refreshIndex _ = V5.refreshIndex
162+ withBH _ = V5.withBH
163+ searchByIndex _ = V5.searchByIndex
164+
165+
166+-------------------------------------------------------------------------------
167+setupSearch
168+ :: forall proxy v. ( TestESVersion v
169+ , MonadIO (BH v IO)
170+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
171+ , Functor (BH v IO)
172+#endif
173+ )
174+ => proxy v
175+ -> (EsScribeCfg v -> EsScribeCfg v)
176+ -> IO Scribe
177+setupSearch prx modScribeCfg = do
178+ bh prx (dropESSchema prx)
53179 mgr <- newManager defaultManagerSettings
54− mkEsScribe cfg (mkBHEnv svr mgr) ixn mn DebugS V3
180+ mkEsScribe cfg (mkBHEnv prx (svr prx) mgr) (ixn prx) (mn prx) (permitItem DebugS) V3
55181 where
56− cfg = modScribeCfg (defaultEsScribeCfg { essAnnotateTypes = True
57− , essIndexSettings = ixs
58− })
182+ cfg :: EsScribeCfg v
183+ cfg = modScribeCfg $
184+ (defaultEsScribeCfg' prx)
185+ { essAnnotateTypes = True
186+ , essIndexSettings = ixs prx
187+ }
59188
60189
61190-------------------------------------------------------------------------------
62−teardownSearch :: (Scribe, IO ()) -> IO ()
63−teardownSearch (_, finalizer) = do
64− finalizer
65− bh $ do
66− when False $ dropESSchema
67− when False $ dropESSTemplate --TODO: drop
191+teardownSearch
192+ :: ( TestESVersion v
193+ , Monad (BH v IO)
194+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
195+ , Functor (BH v IO)
196+#endif
197+ )
198+ => proxy v
199+ -> IO ()
200+teardownSearch prx = do
201+ bh prx $ do
202+ dropESSchema prx
203+ dropESSTemplate prx
68204
69205
70206-------------------------------------------------------------------------------
71−withSearch :: (IO (Scribe, IO ()) -> TestTree) -> TestTree
207+withSearch
208+ :: ( TestESVersion v
209+ , MonadIO (BH v IO)
210+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
211+ , Functor (BH v IO)
212+#endif
213+ )
214+ => proxy v
215+ -> (IO Scribe -> TestTree)
216+ -> TestTree
72217withSearch = withSearch' id
73218
74219
75220-------------------------------------------------------------------------------
76−withSearch' :: (EsScribeCfg -> EsScribeCfg) -> (IO (Scribe, IO ()) -> TestTree) -> TestTree
77−withSearch' modScribeCfg = withResource (setupSearch modScribeCfg) teardownSearch
221+withSearch'
222+ :: ( TestESVersion v
223+ , MonadIO (BH v IO)
224+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
225+ , Functor (BH v IO)
226+#endif
227+ )
228+ => (EsScribeCfg v -> EsScribeCfg v)
229+ -> proxy v
230+ -> (IO Scribe -> TestTree)
231+ -> TestTree
232+withSearch' modScribeCfg prx = withResource (setupSearch prx modScribeCfg) (const (teardownSearch prx))
78233
79234
80235-------------------------------------------------------------------------------
81−esTests :: TestTree
82−esTests = testGroup "elasticsearch scribe"
236+esTests
237+ :: ( TestESVersion v
238+ , MonadIO (BH v IO)
239+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
240+ , Functor (BH v IO)
241+#endif
242+ , Show (IndexName v)
243+ )
244+ => proxy v
245+ -> TestTree
246+esTests prx = testGroup "elasticsearch scribe"
83247 [
84− withSearch' (\c -> c { essIndexSharding = NoIndexSharding}) $ \setup -> testCase "it flushes to elasticsearch" $ withTestLogging setup $ \done -> do
85− $(logT) (ExampleCtx True) mempty InfoS "A test message"
248+ withSearch' (\c -> c { essIndexSharding = NoIndexSharding}) prx $ \setup -> testCase "it flushes to elasticsearch" $ withTestLogging prx setup $ \done -> do
249+ $(logT) (ExampleCtx True) M.mempty InfoS "A test message"
86250 liftIO $ do
87251 void done
88− logs <- getLogs
252+ logs <- getLogs prx
89253 length logs @?= 1
90254 let l = head logs
91255 l ^? key "_source" . key "msg" . _String @?= Just "A test message"
92256 l ^? key "_source" . key "data" . key "whatever::b" . _Bool @?= Just True
93− , withSearch $ \setup -> testCase "date-based index sharding" $ do
257+ , testCase "can set up twice with no sharding" $ do
258+ let setup = bracket_ (setupSearch prx (\c -> c { essIndexSharding = NoIndexSharding })) (teardownSearch prx)
259+ setup $ setup $
260+ return ()
261+ , testCase "can set up twice with sharding" $ do
262+ let setup = bracket_ (setupSearch prx (\c -> c { essIndexSharding = DailyIndexSharding })) (teardownSearch prx)
263+ setup $ setup $
264+ return ()
265+ , withSearch prx $ \setup -> testCase "date-based index sharding" $ do
94266 let t1 = mkTime 2016 1 2 3 4 5
95267 fakeClock <- newTVarIO t1
96− withTestLogging' (set logEnvTimer (readTVarIO fakeClock)) setup $ \done -> do
268+ withTestLogging' (set logEnvTimer (readTVarIO fakeClock)) prx setup $ \done -> do
97269 $(logT) (ExampleCtx True) mempty InfoS "today"
98270 let t2 = mkTime 2016 1 3 3 4 5
99271 liftIO (atomically (writeTVar fakeClock t2))
100272 $(logT) (ExampleCtx True) mempty InfoS "tomorrow"
101273 liftIO $ do
102274 void done
103− todayLogs <- getLogsByIndex (IndexName "katip-elasticsearch-tests-2016-01-02")
104− tomorrowLogs <- getLogsByIndex (IndexName "katip-elasticsearch-tests-2016-01-03")
275+ todayLogs <- getLogsByIndex prx (toIndexName prx "katip-elasticsearch-tests-2016-01-02")
276+ tomorrowLogs <- getLogsByIndex prx (toIndexName prx "katip-elasticsearch-tests-2016-01-03")
105277 assertBool ("todayLogs has " <> show (length todayLogs) <> " items") (length todayLogs == 1)
106278 assertBool ("tomorrowLogs has " <> show (length tomorrowLogs) <> " items") (length tomorrowLogs == 1)
107279 let logToday = head todayLogs
108280 let logTomorrow = head tomorrowLogs
109281 logToday ^? key "_source" . key "msg" . _String @?= Just "today"
110282 logTomorrow ^? key "_source" . key "msg" . _String @?= Just "tomorrow"
111− , withSearch' (\c -> c { essIndexSharding = WeeklyIndexSharding}) $ \setup -> testCase "weekly index sharding rounds to previous sunday" $ do
283+ , withSearch' (\c -> c { essIndexSharding = WeeklyIndexSharding}) prx $ \setup -> testCase "weekly index sharding rounds to previous sunday" $ do
112284 let t1 = mkTime 2016 3 5 0 0 0 -- saturday, march 5th
113285 fakeClock <- newTVarIO t1
114− withTestLogging' (set logEnvTimer (readTVarIO fakeClock)) setup $ \done -> do
286+ withTestLogging' (set logEnvTimer (readTVarIO fakeClock)) prx setup $ \done -> do
115287 $(logT) (ExampleCtx True) mempty InfoS "today"
116288 let t2 = mkTime 2016 3 6 0 0 0 -- sunday march 6th
117289 liftIO (atomically (writeTVar fakeClock t2))
118290 $(logT) (ExampleCtx True) mempty InfoS "tomorrow"
119291 liftIO $ do
120292 void done
121− todayLogs <- getLogsByIndex (IndexName "katip-elasticsearch-tests-2016-02-28") -- rounds back to previous sunday
122− tomorrowLogs <- getLogsByIndex (IndexName "katip-elasticsearch-tests-2016-03-06") -- is on sunday, so uses current date
293+ todayLogs <- getLogsByIndex prx (toIndexName prx "katip-elasticsearch-tests-2016-02-28") -- rounds back to previous sunday
294+ tomorrowLogs <- getLogsByIndex prx (toIndexName prx "katip-elasticsearch-tests-2016-03-06") -- is on sunday, so uses current date
123295 assertBool ("todayLogs has " <> show (length todayLogs) <> " items") (length todayLogs == 1)
124296 assertBool ("tomorrowLogs has " <> show (length tomorrowLogs) <> " items") (length tomorrowLogs == 1)
125297 let logToday = head todayLogs
@@ -232,76 +404,127 @@ annotatedExampleValue = Array $ V.fromList
232404
233405
234406-------------------------------------------------------------------------------
235−getLogs :: IO [Value]
236−getLogs = getLogsByIndex ixn
407+getLogs
408+ :: ( TestESVersion v
409+ , Monad (BH v IO)
410+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
411+ , Functor (BH v IO)
412+#endif
413+ , Show (IndexName v)
414+ )
415+ => proxy v
416+ -> IO [Value]
417+getLogs prx = getLogsByIndex prx (ixn prx)
237418
238419
239420-------------------------------------------------------------------------------
240−getLogsByIndex :: IndexName -> IO [Value]
241−getLogsByIndex i = do
242− r <- bh $ do
243− void (refreshIndex i)
244− searchByIndex i (mkSearch Nothing Nothing)
421+getLogsByIndex
422+ :: ( TestESVersion v
423+ , Monad (BH v IO)
424+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
425+ , Functor (BH v IO)
426+#endif
427+ , Show (IndexName v)
428+ )
429+ => proxy v
430+ -> IndexName v
431+ -> IO [Value]
432+getLogsByIndex prx i = do
433+ r <- bh prx $ do
434+ void (refreshIndex prx i)
435+ searchByIndex prx i (mkSearch prx Nothing Nothing)
245436 let actualCode = statusCode (responseStatus r)
246437 assertBool ("search by " <> show i <> " " <> show actualCode <> " /= 200") (actualCode == 200)
247438 return $ responseBody r ^.. key "hits" . key "hits" . values
248439
249440
250441-------------------------------------------------------------------------------
251−bh :: BH IO a -> IO a
252−bh = withBH defaultManagerSettings svr
442+bh :: TestESVersion v => proxy v -> BH v IO a -> IO a
443+bh prx = withBH prx defaultManagerSettings (svr prx)
253444
254445
255446-------------------------------------------------------------------------------
256447withTestLogging
257− :: IO (Scribe, IO a) -> (IO Reply -> KatipT IO b) -> IO b
448+ :: TestESVersion v
449+ => proxy v
450+ -> IO Scribe
451+ -> (IO (Response ByteString) -> KatipT IO b)
452+ -> IO b
258453withTestLogging = withTestLogging' id
259454
260455
261456-------------------------------------------------------------------------------
262457withTestLogging'
263− :: (LogEnv -> LogEnv)
264− -> IO (Scribe, IO a)
265− -> (IO Reply -> KatipT IO b)
458+ :: (TestESVersion v)
459+ => (LogEnv -> LogEnv)
460+ -> proxy v
461+ -> IO Scribe
462+ -> (IO (Response ByteString) -> KatipT IO b)
266463 -> IO b
267−withTestLogging' modEnv setup f = do
268− (scr, done) <- setup
464+withTestLogging' modEnv prx setup f = do
465+ scr <- setup
269466 le <- modEnv <$> initLogEnv ns env
270− let done' = done >> bh (refreshIndex ixn)
271− runKatipT le { _logEnvScribes = M.singleton "es" scr} (f done')
467+ le' <- registerScribe "es" scr defaultScribeSettings le
468+ let done' = do
469+ _ <- closeScribes le'
470+ bh prx (refreshIndex prx (ixn prx))
471+ runKatipT le' (f done')
272472 where
273473 ns = Namespace ["katip-test"]
274474 env = Environment "test"
275475
276476
277477-------------------------------------------------------------------------------
278−svr :: Server
279−svr = Server "http://localhost:9200"
478+svr :: TestESVersion v => proxy v -> Server v
479+svr prx = toServer prx "http://localhost:9200"
280480
281481
282482-------------------------------------------------------------------------------
283−ixn :: IndexName
284−ixn = IndexName "katip-elasticsearch-tests"
483+ixn :: TestESVersion v => proxy v -> IndexName v
484+ixn prx = toIndexName prx "katip-elasticsearch-tests"
285485
286486
287487-------------------------------------------------------------------------------
288−ixs :: IndexSettings
289−ixs = defaultIndexSettings { indexShards = ShardCount 1
290− , indexReplicas = ReplicaCount 1}
488+ixs :: TestESVersion v => proxy v -> IndexSettings v
489+ixs prx = defaultIndexSettings prx
490+ & indexShards prx .~ toShardCount prx 1
491+ & indexReplicas prx .~ toReplicaCount prx 1
492+
493+
494+-------------------------------------------------------------------------------
495+tn :: TestESVersion v => proxy v -> TemplateName v
496+tn prx = toTemplateName prx "katip-elasticsearch-tests"
497+
291498
292499-------------------------------------------------------------------------------
293−mn :: MappingName
294−mn = MappingName "logs"
500+mn :: TestESVersion v => proxy v -> MappingName v
501+mn prx = toMappingName prx "logs"
295502
296503
297504-------------------------------------------------------------------------------
298−dropESSchema :: BH IO ()
299−dropESSchema = void $ deleteIndex (IndexName "katip-elasticsearch-tests*")
505+dropESSchema
506+ :: ( TestESVersion v
507+ , Monad (BH v IO)
508+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
509+ , Functor (BH v IO)
510+#endif
511+ )
512+ => proxy v
513+ -> BH v IO ()
514+dropESSchema prx = void $ deleteIndex prx (toIndexName prx "katip-elasticsearch-tests*")
300515
301516
302517-------------------------------------------------------------------------------
303−dropESSTemplate :: BH IO ()
304−dropESSTemplate = void $ deleteTemplate (TemplateName "katip-elasticsearch-tests")
518+dropESSTemplate
519+ :: ( TestESVersion v
520+ , Monad (BH v IO)
521+#if defined(__GLASGOW_HASKELL__) && __GLASGOW_HASKELL__ < 800
522+ , Functor (BH v IO)
523+#endif
524+ )
525+ => proxy v
526+ -> BH v IO ()
527+dropESSTemplate prx = void $ deleteTemplate prx (tn prx)
305528
306529
307530-------------------------------------------------------------------------------
katip-logzio/LICENSEnew file+30
@@ -0,0 +1,30 @@
1+Copyright (c) 2018, Soostone Inc
2+
3+All rights reserved.
4+
5+Redistribution and use in source and binary forms, with or without
6+modification, are permitted provided that the following conditions are met:
7+
8+ * Redistributions of source code must retain the above copyright
9+ notice, this list of conditions and the following disclaimer.
10+
11+ * Redistributions in binary form must reproduce the above
12+ copyright notice, this list of conditions and the following
13+ disclaimer in the documentation and/or other materials provided
14+ with the distribution.
15+
16+ * Neither the name of Ozgun Ataman nor the names of other
17+ contributors may be used to endorse or promote products derived
18+ from this software without specific prior written permission.
19+
20+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
21+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
22+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
23+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
24+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
25+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
26+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
27+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
28+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
29+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
30+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
katip-logzio/README.mdnew file+4
@@ -0,0 +1,4 @@
1+# Katip Logz.IO [![Build Status](https://travis-ci.org/Soostone/katip.svg?branch=master)](https://travis-ci.org/Soostone/katip)
2+
3+katip-logzio is a scribe for the Katip logging framework that sends
4+structured logs to the logz.io centralized logging platform.
katip-logzio/changelog.mdnew file+9
@@ -0,0 +1,9 @@
1+0.1.1.0
2+=======
3+* Fixed bug where on scribe close, any items left in the buffer that
4+ hadn't timed out or been flushed already would be dropped rather
5+ than flushed. All users are encouraged to upgrade.
6+
7+0.1.0.0
8+==========
9+* Initial release
katip-logzio/katip-logzio.cabalnew file+94
@@ -0,0 +1,94 @@
1+name: katip-logzio
2+version: 0.1.1.0
3+synopsis: Logz.IO scribe for the Katip logging framework
4+description: See README.md for more details.
5+license: BSD3
6+license-file: LICENSE
7+author: Michael Xavier
8+maintainer: michael.xavier@soostone.com
9+copyright: Soostone Inc, 2018
10+category: Data, Text, Logging
11+homepage: https://github.com/Soostone/katip
12+bug-reports: https://github.com/Soostone/katip/issues
13+build-type: Simple
14+cabal-version: >=1.10
15+extra-source-files:
16+ README.md
17+ changelog.md
18+
19+tested-with: GHC == 8.4.3
20+
21+source-repository head
22+ type: git
23+ location: https://github.com/Soostone/katip.git
24+
25+flag lib-Werror
26+ default: False
27+ manual: True
28+
29+
30+library
31+ exposed-modules:
32+ Katip.Scribes.LogzIO.HTTPS
33+ build-depends:
34+ base >=4.8.0.0 && <5
35+ , katip >= 0.8.0.0
36+ , stm >= 2.1.1
37+ , async
38+ , time >= 1.8.0.2
39+ , aeson >= 0.10.0.0
40+ , unix
41+ , unordered-containers
42+ , http-client >= 0.1.0
43+ , http-client-tls >= 0.3.4
44+ , uri-bytestring
45+ , errors >= 2.0.0
46+ , safe-exceptions
47+ , retry
48+ , http-types
49+ , text
50+ , bytestring
51+ , scientific
52+ , stm-chans >= 2.0.0
53+ hs-source-dirs: src
54+ default-language: Haskell2010
55+ hs-source-dirs: src
56+ ghc-options: -Wall -Wall -Wnoncanonical-monad-instances
57+ if flag(lib-Werror)
58+ ghc-options: -Werror
59+
60+
61+test-suite test
62+ type: exitcode-stdio-1.0
63+ main-is: Main.hs
64+ hs-source-dirs: test
65+ default-language: Haskell2010
66+ other-modules:
67+ Katip.Tests.Scribes.LogzIO.HTTPS
68+ build-depends: base
69+ , katip
70+ , katip-logzio
71+ , tasty
72+ , tasty-hedgehog
73+ , tasty-hunit
74+ , hedgehog
75+ , vector
76+ , unordered-containers
77+ , text
78+ , bytestring
79+ , time
80+ , template-haskell
81+ , aeson
82+ , scientific
83+ , unix
84+ , hostname
85+ , scotty
86+ , stm
87+ , async
88+ , safe-exceptions
89+ , uri-bytestring
90+ , warp
91+ , http-types
92+ ghc-options: -Wall -threaded -rtsopts -with-rtsopts=-N -Wnoncanonical-monad-instances
93+ if flag(lib-Werror)
94+ ghc-options: -Werror
katip-logzio/src/Katip/Scribes/LogzIO/HTTPS.hsnew file+639
@@ -0,0 +1,639 @@
1+{-# LANGUAGE BangPatterns #-}
2+{-# LANGUAGE GADTs #-}
3+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
4+{-# LANGUAGE OverloadedStrings #-}
5+{-# LANGUAGE RankNTypes #-}
6+{-# LANGUAGE TypeApplications #-}
7+-- | This is a log scribe that writes logs to logz.io's bulk
8+-- <https://app.logz.io/#/dashboard/data-sources/Bulk-HTTPS HTTPS
9+-- API>.
10+module Katip.Scribes.LogzIO.HTTPS
11+ ( -- * Scribe construction
12+ mkLogzIOScribe
13+ -- * Types
14+ , BulkAPIError(..)
15+ , LogzIOScribeConfiguration(..)
16+ , Scheme(..)
17+ , APIToken(..)
18+ , LoggingError(..)
19+ -- ** Presets for configuration
20+ , usRegionHost
21+ , euRegionHost
22+ , httpsPort
23+ , httpPort
24+ , defaultRetryPolicy
25+ , defaultLogzIOScribeConfiguration
26+ -- * Internal API exported for testing
27+ , renderLineTruncated
28+ , renderLineTruncated'
29+ , maxPayloadBytes
30+ , maxLogLineLength
31+ , BulkBuffer (..)
32+ , LogAction (..)
33+ , bufferItem
34+ , bufferItem'
35+ , forceFlush
36+ , Bytes (..)
37+ ) where
38+
39+
40+-------------------------------------------------------------------------------
41+import Control.Applicative
42+import qualified Control.Concurrent.Async as Async
43+import qualified Control.Concurrent.STM as STM
44+import qualified Control.Concurrent.STM.TBMQueue as STM
45+import qualified Control.Error as E
46+import qualified Control.Exception.Safe as EX
47+import Control.Monad
48+import qualified Control.Retry as Retry
49+import qualified Data.Aeson as A
50+import qualified Data.ByteString.Builder as BB
51+import qualified Data.ByteString.Lazy as LBS
52+import qualified Data.ByteString.Lazy.Char8 as LBS8
53+import qualified Data.HashMap.Strict as HM
54+import Data.Int
55+import qualified Data.Scientific as Scientific
56+import Data.Semigroup as Semigroup
57+import Data.String (IsString)
58+import qualified Data.Text as T
59+import qualified Data.Text.Encoding as TE
60+import qualified Data.Text.Lazy as TL
61+import qualified Data.Text.Lazy.Builder as TB
62+import qualified Data.Time as Time
63+import qualified Katip as K
64+import Katip.Core (LocJs (..))
65+import qualified Network.HTTP.Client as HTTP
66+import qualified Network.HTTP.Client.TLS as HTTPS
67+import qualified Network.HTTP.Types as HTypes
68+import qualified System.Posix.Types as POSIX
69+import qualified URI.ByteString as URIBS
70+-------------------------------------------------------------------------------
71+
72+
73+
74+-- | This is returned when the bulk import was a partial success
75+data BulkAPIError = BulkAPIError
76+ { bulkAPIError_malformedLines :: Int
77+ -- ^ The number of log lines which are not well-formed JSON. This
78+ -- indicates a __library bug__. Please file an issue on GitHub.
79+ , bulkAPIError_successfulLines :: Int
80+ -- ^ The number of log lines received successfully.
81+ , bulkAPIError_oversizedLines :: Int
82+ -- ^ The number of log lines which exceed the line length
83+ -- limit. katip-logzio makes a best effort to truncate logs that
84+ -- exceed the size limit. This probably indicates a __library bug__
85+ -- and should be reported as an issue on GitHub.
86+ , bulkAPIError_emptyLogLines :: Int
87+ -- ^ The number of log lines which were empty. There isnt' really a
88+ -- concept of a truly empty log line in katip, so this most likely
89+ -- indicates a __library bug__ and should be reported as an issue on
90+ -- GitHub.
91+ } deriving (Show, Eq)
92+
93+
94+instance A.FromJSON BulkAPIError where
95+ parseJSON = A.withObject "BulkAPIError" $ \o -> do
96+ malformedLines <- o A..: "malformedLines"
97+ successfulLines <- o A..: "successfulLines"
98+ oversizedLines <- o A..: "oversizedLines"
99+ emptyLogLines <- o A..: "emptyLogLines"
100+ pure $ BulkAPIError
101+ { bulkAPIError_malformedLines = malformedLines
102+ , bulkAPIError_successfulLines = successfulLines
103+ , bulkAPIError_oversizedLines = oversizedLines
104+ , bulkAPIError_emptyLogLines = emptyLogLines
105+ }
106+
107+
108+-------------------------------------------------------------------------------
109+data LogzIOScribeConfiguration = LogzIOScribeConfiguration
110+ { logzIOScribeConfiguration_bufferItems :: Int
111+ -- ^ Will flush the log buffer if this many items is in the buffer
112+ -- __or__ 'logzIOScribeConfiguration_bufferTimeout' is reached,
113+ -- whichever is first
114+ , logzIOScribeConfiguration_bufferTimeout :: Time.NominalDiffTime
115+ -- ^ Will flush the buffer if it has been this long since the last
116+ -- flush __or__ 'logzIOScribeConfiguration_bufferItems' items are
117+ -- accumulated, whichever is first. NominalDiffTime has a Num
118+ -- instance, so you can use a literal to specify seconds, e.g. 30 =
119+ -- 30s.
120+ , logzIOScribeConfiguration_scheme :: Scheme
121+ , logzIOScribeConfiguration_host :: URIBS.Host
122+ , logzIOScribeConfiguration_port :: URIBS.Port
123+ , logzIOScribeConfiguration_token :: APIToken
124+ , logzIOScribeConfiguration_retry :: Retry.RetryPolicyM IO
125+ -- ^ How should exceptions during writes be retried?
126+ , logzIOScribeConfiguration_onError :: LoggingError -> IO ()
127+ }
128+
129+
130+-- | A default configuration:
131+--
132+-- * 100 item buffering
133+--
134+-- * 30 second buffer timeout
135+--
136+-- * US, HTTPS logging endpoint (listener.logz.io:8071)
137+--
138+-- * 'defaultRetryPolicy' of 25ms exponential backoff, 5 retries
139+--
140+-- * Ignore logging errors
141+defaultLogzIOScribeConfiguration :: APIToken -> LogzIOScribeConfiguration
142+defaultLogzIOScribeConfiguration token = LogzIOScribeConfiguration
143+ { logzIOScribeConfiguration_bufferItems = 100
144+ , logzIOScribeConfiguration_bufferTimeout = 30
145+ , logzIOScribeConfiguration_scheme = HTTPS
146+ , logzIOScribeConfiguration_host = usRegionHost
147+ , logzIOScribeConfiguration_port = httpsPort
148+ , logzIOScribeConfiguration_token = token
149+ , logzIOScribeConfiguration_retry = defaultRetryPolicy
150+ , logzIOScribeConfiguration_onError = const (pure ())
151+ }
152+
153+
154+-------------------------------------------------------------------------------
155+-- | You can retrieve your account or sub-account's API token on the
156+-- <https://app.logz.io/#/dashboard/settings/manage-accounts manage
157+-- accounts page>. Note that APIToken has an IsString instance,
158+-- meaning that you can use a string literal with OverloadedStrings
159+-- enabled.
160+newtype APIToken = APIToken
161+ { apiToken :: T.Text
162+ } deriving (Show, Eq, IsString)
163+
164+
165+-- | This particular bulk API only supports HTTP or HTTPS. HTTPS is
166+-- strongly recommended for security reasons.
167+data Scheme
168+ = HTTPS
169+ -- ^ HTTPs should always be used except for local testing.
170+ | HTTP
171+ deriving (Show, Eq)
172+
173+
174+-- | See
175+-- <https://support.logz.io/hc/en-us/articles/210206365-What-IP-addresses-should-I-open-in-my-firewall-to-ship-logs-to-Logz-io-
176+-- this> for a list of listeners. This is the US region host,
177+-- listener.logz.io
178+usRegionHost :: URIBS.Host
179+usRegionHost = URIBS.Host "listener.logz.io"
180+
181+
182+-- | See
183+-- <https://support.logz.io/hc/en-us/articles/210206365-What-IP-addresses-should-I-open-in-my-firewall-to-ship-logs-to-Logz-io-
184+-- this> for a list of listeners. This is the EU region host,
185+-- listener.logz.io
186+euRegionHost :: URIBS.Host
187+euRegionHost = URIBS.Host "listener-eu.logz.io"
188+
189+
190+-- | Logz.io uses port 8071 for HTTPS
191+httpsPort :: URIBS.Port
192+httpsPort = URIBS.Port 8071
193+
194+
195+-- | Logz.io uses port 8070 for HTTP
196+httpPort :: URIBS.Port
197+httpPort = URIBS.Port 8070
198+
199+
200+-- | A reasonable retry policy: exponential backoff with 25ms base
201+-- delay up to 5 retries, for a total cumulative delay of 775ms.
202+defaultRetryPolicy :: (Monad m) => Retry.RetryPolicyM m
203+defaultRetryPolicy = Retry.exponentialBackoff 25000 `mappend` Retry.limitRetries 5
204+
205+-------------------------------------------------------------------------------
206+mkLogzIOScribe
207+ :: LogzIOScribeConfiguration
208+ -> K.PermitFunc
209+ -> K.Verbosity
210+ -> IO K.Scribe
211+mkLogzIOScribe config permitItem verbosity = do
212+ -- This size is actually somewhat arbitrary. We're just making sure
213+ -- it isn't infinite so we don't consume the whole backlog right
214+ -- away and take up lots of memory.. Katip above us does bounded
215+ -- buffering and load-shedding when there's too much of a
216+ -- backlog. Our writes are blocking to apply backpressure up to
217+ -- katip. This value just holds onto values temporarily while we
218+ -- concatenate them into a buffer.
219+ ingestionQueue <- STM.newTBMQueueIO (itemBufferSize * 10)
220+
221+ let newTimer = STM.registerDelay itemBufferTimeoutMicros
222+ timerRef <- STM.newTVarIO =<< newTimer
223+
224+ -- Set up a connection manager for requests
225+ mgr <- case scheme of
226+ HTTPS -> HTTPS.newTlsManager
227+ HTTP -> HTTP.newManager HTTP.defaultManagerSettings
228+
229+ -- An STM transaction that will return true when writes are stopped
230+ -- and backlog is emptied.
231+ let workExhausted :: STM.STM Bool
232+ workExhausted = (&&)
233+ <$> STM.isClosedTBMQueue ingestionQueue
234+ <*> STM.isEmptyTBMQueue ingestionQueue
235+ -- Block until there's no more work
236+ let waitWorkExhausted :: STM.STM ()
237+ waitWorkExhausted = STM.check =<< workExhausted
238+ let pop :: STM.STM (Tick AnyLogItem)
239+ pop = maybe WorkExhausted NewItem <$> STM.readTBMQueue ingestionQueue
240+
241+ let timeExpired :: STM.STM (Tick a)
242+ timeExpired = do
243+ isExpired <- STM.readTVar =<< STM.readTVar timerRef
244+ STM.check isExpired
245+ pure TimeExpired
246+
247+ -- Circular transaction that checks for completion of work, time
248+ -- expiration, or new events.
249+ let nextTick :: STM.STM (Tick AnyLogItem)
250+ nextTick =
251+ timeExpired <|>
252+ pop <|>
253+ (WorkExhausted <$ waitWorkExhausted)
254+
255+ -- Blocking push. This applies backpressure upstream to katip, which does its own buffering
256+ let push :: AnyLogItem -> STM.STM ()
257+ push = void . STM.writeTBMQueue ingestionQueue
258+
259+ let sealQueue = STM.atomically (STM.closeTBMQueue ingestionQueue)
260+
261+ -- Replace the timer with a new one
262+ let resetTimer = STM.atomically . STM.writeTVar timerRef =<< newTimer
263+
264+ -- Send the buffer and then reset the timer
265+ let flush curBuffer = do
266+ res <- flushBuffer config mgr curBuffer
267+ case res of
268+ Left e -> onErrorSafe e
269+ Right () -> pure ()
270+ resetTimer
271+
272+ let flushLoop :: BulkBuffer -> IO ()
273+ flushLoop curBuffer = do
274+ tick <- STM.atomically nextTick
275+ case tick of
276+ WorkExhausted -> do
277+ flush curBuffer -- flush what you've got
278+ pure () -- stop looping
279+ TimeExpired -> do
280+ flush curBuffer
281+ flushLoop mempty
282+ NewItem (AnyLogItem item) -> do
283+ case bufferItem (logzIOScribeConfiguration_bufferItems config) verbosity item curBuffer of
284+ Buffered newBuffer -> flushLoop newBuffer
285+ FlushNow flushThis newBuffer -> do
286+ flush flushThis
287+ flushLoop newBuffer
288+
289+ flushThread <- Async.async (flushLoop mempty)
290+
291+ let close = do
292+ sealQueue
293+ _ <- Async.waitCatch flushThread
294+ pure ()
295+
296+ pure $ K.Scribe
297+ { K.liPush = STM.atomically . push . AnyLogItem
298+ , K.scribeFinalizer = close
299+ , K.scribePermitItem = permitItem
300+ }
301+ where
302+ itemBufferSize = logzIOScribeConfiguration_bufferItems config
303+ itemBufferTimeoutMicros = ndtToMicros (logzIOScribeConfiguration_bufferTimeout config)
304+ scheme = logzIOScribeConfiguration_scheme config
305+ onErrorSafe ex = do
306+ _ <- EX.tryAny (logzIOScribeConfiguration_onError config ex)
307+ pure ()
308+
309+
310+data AnyLogItem where
311+ AnyLogItem :: K.LogItem a => K.Item a -> AnyLogItem
312+
313+
314+-------------------------------------------------------------------------------
315+data Tick a =
316+ TimeExpired
317+ | NewItem !a
318+ | WorkExhausted
319+
320+
321+-------------------------------------------------------------------------------
322+-- Match the native resolution of NominalDiffTime, which is excessive
323+-- for our needs
324+ndtPicos :: Time.NominalDiffTime -> Int64
325+ndtPicos = round . (* picos)
326+ where
327+ picos :: Time.NominalDiffTime
328+ picos = 10 ^ (9 :: Int)
329+
330+
331+-------------------------------------------------------------------------------
332+ndtToMicros :: Time.NominalDiffTime -> Int
333+ndtToMicros t = round (((fromIntegral (ndtPicos t)) :: Double) / picosInMicro)
334+ where
335+ picosInMicro = 10 ^ (3 :: Int)
336+
337+
338+-------------------------------------------------------------------------------
339+data LoggingError =
340+ URIError HTTP.HttpException
341+ -- ^ The URI generated was invalid. Check your configuration
342+ | RequestError HTTP.HttpException
343+ -- ^ We encountered an exception while sending the batch request
344+ | PartialFailure BulkAPIError
345+ -- ^ Some or all of the request was rejected. Check the logz.io UI
346+ -- for indexing errors.
347+ | BadToken
348+ -- ^ Your API token was rejected.
349+ | UnknownFailureResponse HTypes.Status LBS.ByteString
350+ -- ^ An error returned, but it could not be decoded into a
351+ -- 'BulkAPIError'. This may indicate a __library bug__, which should
352+ -- be reported to the issue tracker.
353+ deriving (Show)
354+
355+-------------------------------------------------------------------------------
356+flushBuffer
357+ :: LogzIOScribeConfiguration
358+ -> HTTP.Manager
359+ -> BulkBuffer
360+ -> IO (Either LoggingError ())
361+flushBuffer config mgr bulkBuffer
362+ | bulkBuffer_itemCount bulkBuffer <= 0 = pure (Right ())
363+ | otherwise = do
364+ E.runExceptT $ do
365+ req <- E.fmapLT URIError (E.ExceptT (EX.try (configureRequest <$> HTTP.parseRequest uriStr)))
366+ resp <- E.fmapLT RequestError $ E.ExceptT $ EX.try $
367+ Retry.recovering retryPolicy [\_stat -> EX.Handler handleHttpException] $ \_stat ->
368+ HTTP.httpLbs req mgr
369+ let respLBS = HTTP.responseBody resp
370+ let respStatus = HTTP.responseStatus resp
371+ if HTypes.statusIsSuccessful respStatus
372+ then pure ()
373+ else case A.decode @BulkAPIError respLBS of
374+ Nothing
375+ | HTypes.statusCode respStatus == 401 -> E.throwE BadToken
376+ | otherwise -> E.throwE (UnknownFailureResponse respStatus respLBS)
377+ Just bulkError -> E.throwE (PartialFailure bulkError)
378+ where
379+ configureRequest req = req
380+ { HTTP.method = HTypes.methodPost
381+ , HTTP.requestBody = HTTP.RequestBodyLBS (BB.toLazyByteString (bulkBuffer_payload bulkBuffer))
382+ }
383+
384+ retryPolicy = logzIOScribeConfiguration_retry config
385+ apiTokenBS = TE.encodeUtf8 (apiToken (logzIOScribeConfiguration_token config))
386+
387+ handleHttpException :: (Applicative m) => HTTP.HttpException -> m Bool
388+ handleHttpException _ = pure True
389+
390+ uriStr = LBS8.unpack (BB.toLazyByteString (URIBS.serializeURIRef uri))
391+
392+ authority = URIBS.Authority
393+ { URIBS.authorityUserInfo = Nothing
394+ , URIBS.authorityHost = logzIOScribeConfiguration_host config
395+ , URIBS.authorityPort = Just (logzIOScribeConfiguration_port config)
396+ }
397+
398+ uri = URIBS.URI
399+ { URIBS.uriScheme = case logzIOScribeConfiguration_scheme config of
400+ HTTPS -> URIBS.Scheme "https"
401+ HTTP -> URIBS.Scheme "http"
402+ , URIBS.uriAuthority = Just authority
403+ , URIBS.uriPath = "/"
404+ , URIBS.uriQuery = URIBS.Query
405+ [ ("token", apiTokenBS)
406+ ]
407+ , URIBS.uriFragment = Nothing
408+ }
409+
410+
411+-------------------------------------------------------------------------------
412+newtype Bytes = Bytes
413+ { bytes :: Int64
414+ } deriving (Show, Eq, Num, Ord, Bounded)
415+
416+
417+-- | How big of a body can we send? The limit is defined
418+-- <https://app.logz.io/#/dashboard/data-sources/Bulk-HTTPS here>.
419+maxPayloadBytes :: Bytes
420+maxPayloadBytes = 10485760
421+
422+
423+-- | How long can each serialized payload be (let's assume including
424+-- the trailing newline). The limit is defined
425+-- <https://app.logz.io/#/dashboard/data-sources/Bulk-HTTPS here>.
426+maxLogLineLength :: Bytes
427+maxLogLineLength = 500000
428+
429+
430+measureJSONLine :: A.ToJSON a => a -> (BB.Builder, Bytes)
431+measureJSONLine a = (BB.lazyByteString lbs, Bytes (LBS.length lbs))
432+ where
433+ lbs = A.encode a <> "\n"
434+
435+
436+-- | Fully-rendered JSON object for an item
437+fullItemObject :: K.LogItem a => K.Verbosity -> K.Item a -> A.Object
438+fullItemObject verbosity item = HM.fromList
439+ [ "app" A..= K._itemApp item
440+ , "env" A..= K._itemEnv item
441+ , "sev" A..= K._itemSeverity item
442+ , "thread" A..= K.getThreadIdText (K._itemThread item)
443+ , "host" A..= K._itemHost item
444+ , "pid" A..= pidInt
445+ , "data" A..= annotateKeys (K.payloadObject verbosity (K._itemPayload item))
446+ -- Slight deviation, logz.io uses "message" instead of "msg"
447+ , "message" A..= TB.toLazyText (K.unLogStr (K._itemMessage item))
448+ -- Another slight deviation, logz.io uses "@timestamp" instead of
449+ -- "at". Note, your logs should be sent roughly close to when they
450+ -- are created. They are assigned to indexes based on index date, so
451+ -- time searches act strange if you backfill too far from the
452+ -- past. They seem to support 3 decimal places of
453+ -- precision. Formatting like this requires time 1.8.0.2, which is
454+ -- reflected in the cabal file.
455+ , "@timestamp" A..= A.String (T.pack (Time.formatTime Time.defaultTimeLocale "%Y-%m-%dT%H:%M:%S%03QZ" (K._itemTime item)))
456+ , "ns" A..= K._itemNamespace item
457+ , "loc" A..= (LocJs <$> K._itemLoc item)
458+ ]
459+ where
460+ POSIX.CPid pidInt = K._itemProcess item
461+
462+
463+-- | A version of 'renderLine' which renders a line and stays under
464+-- the maximum line size of 500,000 bytes. If the default rendering is
465+-- too large, the log will be reduced to a timestamp and a potentially
466+-- truncated message.
467+renderLineTruncated :: K.LogItem a => K.Verbosity -> K.Item a -> (BB.Builder, Bytes)
468+renderLineTruncated = renderLineTruncated' maxLogLineLength
469+
470+
471+-- | A generalized renderLineTruncated that takes a custom line length
472+-- limit. This is exclusively for testing.
473+renderLineTruncated'
474+ :: K.LogItem a
475+ => Bytes
476+ -- ^ Custom max log line length. Be careful, too low and no amount
477+ -- of shrinking can get under the size, breaking the invariant. For
478+ -- the production limit, we are guraanteed always able to come in
479+ -- under the limit.
480+ -> K.Verbosity
481+ -> K.Item a
482+ -> (BB.Builder, Bytes)
483+renderLineTruncated' customMaxLogLineLength verbosity item =
484+ if fullSize <= customMaxLogLineLength
485+ then (fullLine, fullSize)
486+ else (fallbackLine, fallbackSize)
487+ where
488+ fullObject = fullItemObject verbosity item
489+ (fullLine, fullSize) = measureJSONLine fullObject
490+ -- only the absolutely necessary keys, with message stripped out
491+ -- to help us calculate how much of the message we can keep. these
492+ -- are lazily evaluated and as such won't be computed unless the
493+ -- item is too big
494+ blankObject :: A.Object
495+ blankObject = HM.fromList
496+ [ "message" A..= A.String "" -- we'll start with a blank message
497+ , "@timestamp" A..= K._itemTime item
498+ ]
499+ (_, blankObjectSize) = measureJSONLine blankObject
500+ messageBytesAllowed = maxLogLineLength - blankObjectSize
501+ (fallbackLine, fallbackSize) = measureJSONLine fallbackObject
502+ fallbackObject :: A.Object
503+ fallbackObject = HM.fromList
504+ [ "message" A..= A.toJSON (TL.take (bytes messageBytesAllowed) (TB.toLazyText (K.unLogStr (K._itemMessage item))))
505+ , "@timestamp" A..= A.toJSON (K._itemTime item)
506+ ]
507+
508+
509+data BulkBuffer = BulkBuffer
510+ { bulkBuffer_bytesUsed :: !Bytes
511+ , bulkBuffer_payload :: !BB.Builder
512+ , bulkBuffer_itemCount :: !Int
513+ }
514+
515+
516+instance Semigroup.Semigroup BulkBuffer where
517+ (BulkBuffer bytesUsedA bufferA itemCountA) <>
518+ (BulkBuffer bytesUsedB bufferB itemCountB) = BulkBuffer
519+ (bytesUsedA + bytesUsedB)
520+ (bufferA <> bufferB)
521+ (itemCountA + itemCountB)
522+
523+
524+instance Monoid BulkBuffer where
525+ mempty = BulkBuffer 0 mempty 0
526+ mappend = (<>)
527+
528+
529+data LogAction buf =
530+ Buffered
531+ buf
532+ -- ^ New buffer
533+ | FlushNow
534+ buf
535+ -- ^ Buffer to flush
536+ buf
537+ -- ^ New buffer
538+
539+bufferItem
540+ :: K.LogItem a
541+ => Int
542+ -- ^ Maximum items before flushing
543+ -> K.Verbosity
544+ -> K.Item a
545+ -> BulkBuffer
546+ -> LogAction BulkBuffer
547+bufferItem = bufferItem' maxPayloadBytes maxLogLineLength
548+
549+
550+-- | An internal version with a configurable max item size and max
551+-- message size for testing. Be careful with this: if you set the
552+-- values too low, some of the guarantees about reducability of
553+-- messages break down.
554+bufferItem'
555+ :: (K.LogItem a)
556+ => Bytes
557+ -- ^ Max payload size
558+ -> Bytes
559+ -- ^ Max item size
560+ -> Int
561+ -- ^ Maximum items before flushing
562+ -> K.Verbosity
563+ -> K.Item a
564+ -> BulkBuffer
565+ -> LogAction BulkBuffer
566+bufferItem' customMaxPayload customMaxItem maxItems verb item bulkBuffer =
567+ let (encodedLine, spaceNeeded) = renderLineTruncated' customMaxItem verb item
568+ newBytesUsed = bulkBuffer_bytesUsed bulkBuffer + spaceNeeded
569+ newItemCount = bulkBuffer_itemCount bulkBuffer + 1
570+ in if newItemCount >= maxItems || newBytesUsed >= customMaxPayload
571+ then FlushNow
572+ bulkBuffer
573+ BulkBuffer
574+ { bulkBuffer_bytesUsed = spaceNeeded
575+ , bulkBuffer_payload = encodedLine
576+ , bulkBuffer_itemCount = 1
577+ }
578+ else Buffered $
579+ BulkBuffer
580+ { bulkBuffer_bytesUsed = newBytesUsed
581+ , bulkBuffer_payload = bulkBuffer_payload bulkBuffer <> encodedLine
582+ , bulkBuffer_itemCount = newItemCount
583+ }
584+
585+
586+-- | When time has run out on a flush, splits the buffer. n.b. this
587+-- will always return 'FlushNow' with an empty new buffer.
588+forceFlush :: (Monoid buf) => buf -> LogAction buf
589+forceFlush buf = FlushNow buf mempty
590+
591+
592+-------------------------------------------------------------------------------
593+-- Annotation borrowed from katip-elasticsearch. There are fixed
594+-- fields in katip logs which should stay the same type forever and
595+-- thus won't need annotation. However, any code in userland may
596+-- choose to add akey to their log's metadata with a type that's
597+-- incompatible with the mapping. If the first value that's picked up
598+-- restrictive (e.g. a long), subsequent values will be rejected. By
599+-- differentiating types by their name, this is guaranteed not to
600+-- happen.
601+
602+annotateValue :: A.Value -> A.Value
603+annotateValue (A.Object o) = A.Object (annotateKeys o)
604+annotateValue (A.Array a) = A.Array (annotateValue <$> a)
605+annotateValue x = x
606+
607+
608+annotateKeys :: A.Object -> A.Object
609+annotateKeys = HM.fromList . map go . HM.toList
610+ where
611+ go (k, A.Object o) = (k, A.Object (annotateKeys o))
612+ go (k, A.Array a) = (k, A.Array (annotateValue <$> a))
613+ go (k, s@(A.String _)) = (k <> stringAnn, s)
614+ go (k, n@(A.Number sci)) = if Scientific.isFloating sci
615+ then (k <> doubleAnn, n)
616+ else (k <> longAnn, n)
617+ go (k, b@(A.Bool _)) = (k <> booleanAnn, b)
618+ go (k, A.Null) = (k <> nullAnn, A.Null)
619+
620+
621+-------------------------------------------------------------------------------
622+-- Annotation Constants
623+-------------------------------------------------------------------------------
624+
625+
626+stringAnn :: T.Text
627+stringAnn = "::s"
628+
629+doubleAnn :: T.Text
630+doubleAnn = "::d"
631+
632+longAnn :: T.Text
633+longAnn = "::l"
634+
635+booleanAnn :: T.Text
636+booleanAnn = "::b"
637+
638+nullAnn :: T.Text
639+nullAnn = "::n"
katip-logzio/test/Katip/Tests/Scribes/LogzIO/HTTPS.hsnew file+466
@@ -0,0 +1,466 @@
1+{-# LANGUAGE OverloadedStrings #-}
2+module Katip.Tests.Scribes.LogzIO.HTTPS
3+ ( tests
4+ ) where
5+
6+
7+-------------------------------------------------------------------------------
8+import Control.Concurrent.Async
9+import Control.Concurrent.STM
10+import Control.Concurrent.STM.TSem
11+import Control.Exception.Safe
12+import Control.Monad
13+import Control.Monad.IO.Class
14+import Data.Aeson as A
15+import qualified Data.ByteString.Builder as BB
16+import qualified Data.ByteString.Lazy as LBS
17+import qualified Data.ByteString.Lazy.Char8 as LBS8
18+import qualified Data.HashMap.Strict as HM
19+import Data.Int
20+import Data.Scientific
21+import Data.Text (Text)
22+import Data.Time
23+import Data.Time.Clock.POSIX
24+import qualified Data.Vector as V
25+import Hedgehog as HH
26+import qualified Hedgehog.Gen as Gen
27+import qualified Hedgehog.Range as Range
28+import Katip
29+import Katip.Core
30+import Language.Haskell.TH (Loc (..))
31+import Network.HostName
32+import qualified Network.HTTP.Types.Status as HTypes
33+import qualified Network.Wai.Handler.Warp as Warp
34+import System.Posix
35+import System.Timeout
36+import Test.Tasty
37+import Test.Tasty.Hedgehog
38+import Test.Tasty.HUnit
39+import URI.ByteString
40+import qualified Web.Scotty as Scotty
41+-------------------------------------------------------------------------------
42+import Katip.Scribes.LogzIO.HTTPS
43+-------------------------------------------------------------------------------
44+
45+
46+tests :: TestTree
47+tests = testGroup "Katip.Scribes.LogzIO.HTTP"
48+ [ bufferItemTests
49+ , renderLineTruncatedTests
50+ , scribeTests
51+ ]
52+
53+
54+-------------------------------------------------------------------------------
55+-- We bind to a system port so we use a lock on these tests to avoid interleaved, concurrent requests
56+scribeTests :: TestTree
57+scribeTests = withLock $ \mkSem -> testGroup "scribe"
58+ [ testCase "writes well-formed log items as lines to the given API" $ do
59+ sem <- mkSem
60+ withServer sem $ \receivedMessages -> do
61+ withScribe (\cfg -> cfg { logzIOScribeConfiguration_bufferTimeout = 1}) $ \scribe -> do
62+ (liPush scribe) (genericLog "a message")
63+
64+ requestLog <- timeoutFailure (20 * second) (atomically (readTQueue receivedMessages))
65+ requestLog_token requestLog @?= testAPIToken
66+ let logs = requestLog_logs requestLog
67+ length logs @?= 1
68+ let firstLog = head logs
69+ receivedLog_message firstLog @?= "a message"
70+ , testCase "respects the items limit" $ do
71+ sem <- mkSem
72+ withServer sem $ \receivedMessages -> do
73+ withScribe (\cfg -> cfg { logzIOScribeConfiguration_bufferItems = 1, logzIOScribeConfiguration_bufferTimeout = 1}) $ \scribe -> do
74+ (liPush scribe) (genericLog "message 1")
75+ (liPush scribe) (genericLog "message 2")
76+
77+ log1 <- timeoutFailure (20 * second) (atomically (readTQueue receivedMessages))
78+ requestLog_token log1 @?= testAPIToken
79+ let logs1 = requestLog_logs log1
80+ length logs1 @?= 1
81+ let firstLog1 = head logs1
82+ receivedLog_message firstLog1 @?= "message 1"
83+
84+ log2 <- timeoutFailure (20 * second) (atomically (readTQueue receivedMessages))
85+ let logs2 = requestLog_logs log2
86+ length logs2 @?= 1
87+ let firstLog2 = head logs2
88+ receivedLog_message firstLog2 @?= "message 2"
89+ , testCase "respects the time limit" $ do
90+ sem <- mkSem
91+ withServer sem $ \receivedMessages -> do
92+ withScribe (\cfg -> cfg { logzIOScribeConfiguration_bufferItems = 2, logzIOScribeConfiguration_bufferTimeout = 1}) $ \scribe -> do
93+ (liPush scribe) (genericLog "a message")
94+ log1 <- timeoutFailure (20 * second) (atomically (readTQueue receivedMessages))
95+ requestLog_token log1 @?= testAPIToken
96+ let logs1 = requestLog_logs log1
97+ length logs1 @?= 1
98+ let firstLog1 = head logs1
99+ receivedLog_message firstLog1 @?= "a message"
100+ , testCase "reports errors" $ do
101+ sem <- mkSem
102+ let badToken = APIToken "badtoken"
103+ errorSignal <- newEmptyTMVarIO
104+ withServer sem $ \_receivedMessages -> do
105+ withScribe (\cfg -> cfg { logzIOScribeConfiguration_bufferItems = 1, logzIOScribeConfiguration_bufferTimeout = 1, logzIOScribeConfiguration_token = badToken, logzIOScribeConfiguration_onError = void . atomically . tryPutTMVar errorSignal}) $ \scribe -> do
106+ (liPush scribe) (genericLog "a message")
107+ loggingError <- timeoutFailure (20 * second) (atomically (takeTMVar errorSignal))
108+ case loggingError of
109+ BadToken -> pure ()
110+ _ -> assertFailure ("Expected BadToken error but got " <> show loggingError)
111+ , testCase "flushes all queued logs on close" $ do
112+ sem <- mkSem
113+ withServer sem $ \receivedMessages -> do
114+ withScribe (\cfg -> cfg { logzIOScribeConfiguration_bufferItems = 100, logzIOScribeConfiguration_bufferTimeout = 100}) $ \scribe -> do
115+ (liPush scribe) (genericLog "message 1")
116+ (liPush scribe) (genericLog "message 2")
117+ messages <- atomically (flushTQueue receivedMessages)
118+ let allLogs = receivedLog_message <$> mconcat (requestLog_logs <$> messages)
119+ allLogs @?= ["message 1", "message 2"]
120+ ]
121+ where
122+ second = 1000000
123+ timeoutFailure waitTime f = do
124+ res <- timeout waitTime f
125+ case res of
126+ Nothing -> assertFailure ("Operation timed out after " <> show waitTime <> "us")
127+ Just x -> pure x
128+ withLock = withResource (atomically (newTSem 1)) (const (return ()))
129+ withServer sem f = bracket_ (atomically (waitTSem sem)) (atomically (signalTSem sem)) $ do
130+ receivedMessages <- atomically newTQueue
131+ withAsync (startServer receivedMessages) $ \_async -> f receivedMessages
132+ testAPIToken = "bigSECRET"
133+ genericLog message = Item
134+ { _itemApp = "katip-logzio"
135+ , _itemEnv = "test"
136+ , _itemSeverity = InfoS
137+ , _itemThread = ThreadIdText "42"
138+ , _itemHost = "localhost"
139+ , _itemProcess = 111
140+ , _itemPayload = ()
141+ , _itemMessage = message
142+ , _itemTime = mkUTCTime 2019 1 2 3 4 5
143+ , _itemNamespace = "test"
144+ , _itemLoc = Nothing
145+ }
146+ startServer receivedMessages = Scotty.scottyOpts serverOpts $ do
147+ Scotty.post "/" $ do
148+ token <- APIToken <$> Scotty.param "token"
149+ if token == testAPIToken
150+ then do
151+ bodyLines <- LBS8.lines <$> Scotty.body
152+ receivedLogs <- mapM (either error pure . A.eitherDecode) bodyLines
153+ let requestLog = RequestLog
154+ { requestLog_token = token
155+ , requestLog_logs = receivedLogs
156+ }
157+ liftIO (atomically (writeTQueue receivedMessages requestLog))
158+ else Scotty.status HTypes.unauthorized401
159+ serverOpts = Scotty.Options
160+ { Scotty.verbose = 0
161+ , Scotty.settings = Warp.setPort 1337 Warp.defaultSettings
162+ }
163+ withScribe modConfig =
164+ bracket (mkLogzIOScribe (modConfig scribeConfig) (const (pure True)) V3) scribeFinalizer
165+ scribeConfig = LogzIOScribeConfiguration
166+ { logzIOScribeConfiguration_bufferItems = 5
167+ , logzIOScribeConfiguration_bufferTimeout = 10
168+ , logzIOScribeConfiguration_scheme = HTTP
169+ , logzIOScribeConfiguration_host = Host "127.0.0.1"
170+ , logzIOScribeConfiguration_port = Port 1337
171+ , logzIOScribeConfiguration_token = testAPIToken
172+ , logzIOScribeConfiguration_retry = defaultRetryPolicy
173+ , logzIOScribeConfiguration_onError = const (pure ())
174+ }
175+
176+
177+
178+data RequestLog = RequestLog
179+ { requestLog_token :: APIToken
180+ , requestLog_logs :: [ReceivedLog]
181+ }
182+
183+
184+-- | Simplified log that only parses the fields we want to assert on
185+data ReceivedLog = ReceivedLog
186+ { receivedLog_message :: Text
187+ }
188+
189+
190+instance FromJSON ReceivedLog where
191+ parseJSON = withObject "ReceivedLog" $ \o -> do
192+ message <- o .: "message"
193+ pure $ ReceivedLog
194+ { receivedLog_message = message
195+ }
196+
197+
198+-------------------------------------------------------------------------------
199+bufferItemTests :: TestTree
200+bufferItemTests = testGroup "bufferItem"
201+ [ testProperty "0 or negative maximum items always flushes immediately" $ property $ do
202+ item <- forAllWith showSimplePayloadItem genSimplePayloadItem
203+ verbosity <- forAll genVerbosity
204+ maxItems <- forAll (Gen.int (Range.linear minBound 0))
205+ bulkBuffer <- forAllWith inspectBulkBuffer genBulkBuffer
206+ let logAction = bufferItem' reducedMaxPayloadBytes reducedMaxLogLineLength maxItems verbosity item bulkBuffer
207+ assertFlushNow logAction
208+ , testProperty "never buffers too many items" $ property $ do
209+ item <- forAllWith showSimplePayloadItem genSimplePayloadItem
210+ verbosity <- forAll genVerbosity
211+ maxItems <- forAll (Gen.int (Range.linear 0 100))
212+ bulkBuffer <- forAllWith inspectBulkBuffer genBulkBuffer
213+ let logAction = bufferItem' reducedMaxPayloadBytes reducedMaxLogLineLength maxItems verbosity item bulkBuffer
214+ case logAction of
215+ Buffered newBuffer -> HH.assert (bulkBuffer_itemCount newBuffer <= maxItems)
216+ _ -> pure ()
217+ , testProperty "never produces too many bytes" $ property $ do
218+ item <- forAllWith showSimplePayloadItem genSimplePayloadItem
219+ verbosity <- forAll genVerbosity
220+ maxItems <- forAll (Gen.int (Range.linear 0 100))
221+ bulkBuffer <- forAllWith inspectBulkBuffer genBulkBuffer
222+ let logAction = bufferItem' reducedMaxPayloadBytes reducedMaxLogLineLength maxItems verbosity item bulkBuffer
223+ case logAction of
224+ Buffered newBuffer -> HH.assert (bulkBuffer_bytesUsed newBuffer <= reducedMaxPayloadBytes)
225+ _ -> pure ()
226+ , testProperty "never flushes more than 1 item" $ property $ do
227+ item <- forAllWith showSimplePayloadItem genSimplePayloadItem
228+ verbosity <- forAll genVerbosity
229+ maxItems <- forAll (Gen.int (Range.linear minBound 0))
230+ bulkBuffer <- forAllWith inspectBulkBuffer genBulkBuffer
231+ let logAction = bufferItem' reducedMaxPayloadBytes reducedMaxLogLineLength maxItems verbosity item bulkBuffer
232+ case logAction of
233+ FlushNow _ newBuffer -> bulkBuffer_itemCount newBuffer === 1
234+ _ -> pure ()
235+ , testProperty "flushes when the buffer is exactly at the limit" $ property $ do
236+ maxItems <- forAll (Gen.int (Range.linear 1 20))
237+ item <- forAllWith showSimplePayloadItem genSimplePayloadItem
238+ bulkBuffer <- forAllWith inspectBulkBuffer ((\b -> b { bulkBuffer_itemCount = maxItems - 1 }) <$> genBulkBuffer)
239+ verbosity <- forAll genVerbosity
240+ let logAction = bufferItem' maxBound maxBound maxItems verbosity item bulkBuffer
241+ case logAction of
242+ FlushNow _ _ -> pure ()
243+ Buffered _ -> fail "Expected a FlushNow but got a Buffered"
244+ ]
245+ where
246+ assertFlushNow (FlushNow _ _) = pure ()
247+ assertFlushNow (Buffered _) = fail ("Expceted FlushNow but got a Buffered")
248+ inspectBulkBuffer (BulkBuffer used _ itemCount) =
249+ "BulkBuffer (" <> show used <> ") ... " <> show itemCount
250+
251+
252+-------------------------------------------------------------------------------
253+-- | Reduced max log line length for more space and time efficient tests
254+reducedMaxLogLineLength :: Bytes
255+reducedMaxLogLineLength = Bytes (bytes maxLogLineLength `div` limitScalingFactor)
256+
257+
258+reducedMaxPayloadBytes :: Bytes
259+reducedMaxPayloadBytes = Bytes (bytes maxPayloadBytes `div` limitScalingFactor)
260+
261+
262+limitScalingFactor :: Int64
263+limitScalingFactor = 10
264+
265+-------------------------------------------------------------------------------
266+showSimplePayloadItem :: Item SimpleLogPayload -> String
267+showSimplePayloadItem item =
268+ show (item { _itemPayload = [(k, toJSON v) | (k, AnyLogPayload v) <- unSimpleLogPayload (_itemPayload item)]})
269+
270+
271+-------------------------------------------------------------------------------
272+renderLineTruncatedTests :: TestTree
273+renderLineTruncatedTests = testGroup "renderLineTruncated"
274+ [ testProperty "always produces an accurate byte count" $ property $ do
275+ item <- forAllWith showSimplePayloadItem genSimplePayloadItem
276+ verbosity <- forAll genVerbosity
277+ let (builder, Bytes byteCount) = renderLineTruncated' reducedMaxLogLineLength verbosity item
278+ builderLength builder === byteCount
279+ , testProperty "always produces a payload smaller than the line limit" $ property $ do
280+ let tinyMaxLineLength = 1024 -- set a really low one for speed
281+ let lowerBound = fromIntegral (bytes tinyMaxLineLength - 100)
282+ let upperBound = fromIntegral (bytes tinyMaxLineLength + 100)
283+ bigMessage <- forAll (genLogStr' (Range.linear lowerBound upperBound))
284+ item <- (\item -> item { _itemMessage = bigMessage}) <$> forAllWith showSimplePayloadItem genSimplePayloadItem
285+ verbosity <- forAll genVerbosity
286+ let (_, byteCount) = renderLineTruncated' tinyMaxLineLength verbosity item
287+ HH.assert (byteCount <= reducedMaxLogLineLength)
288+ ]
289+
290+
291+-------------------------------------------------------------------------------
292+builderLength :: BB.Builder -> Int64
293+builderLength = LBS.length . BB.toLazyByteString
294+
295+-------------------------------------------------------------------------------
296+genVerbosity :: Gen Verbosity
297+genVerbosity = Gen.enumBounded
298+
299+
300+-------------------------------------------------------------------------------
301+genBulkBuffer :: Gen BulkBuffer
302+genBulkBuffer = do
303+ bytesUsed <- genBytes
304+ -- generating a large bytestring string with hedghog seems quite slow, instead we'll generate a smaller string and replicate and merge it
305+ payloadMultiplier <- Gen.int (Range.linear 1 100)
306+ payloadSegment <- genBuilder (Range.linear 0 (round (toRational (bytes reducedMaxPayloadBytes) * 0.05)))
307+ let payload = mconcat (replicate payloadMultiplier payloadSegment)
308+ itemCount <- Gen.int (Range.linear 0 maxBound)
309+ pure $ BulkBuffer
310+ { bulkBuffer_bytesUsed = bytesUsed
311+ , bulkBuffer_payload = payload
312+ , bulkBuffer_itemCount = itemCount
313+ }
314+
315+
316+-------------------------------------------------------------------------------
317+genBytes :: Gen Bytes
318+genBytes = Bytes <$> Gen.int64 (Range.linear 0 maxBound)
319+
320+
321+-------------------------------------------------------------------------------
322+genBuilder :: Range Int -> Gen BB.Builder
323+genBuilder size = BB.byteString <$> Gen.bytes size
324+
325+
326+-------------------------------------------------------------------------------
327+genSimplePayloadItem :: Gen (Item SimpleLogPayload)
328+genSimplePayloadItem = do
329+ app <- genNamespace
330+ env <- genEnvironment
331+ severity <- genSeverity
332+ thread <- genThreadIdText
333+ host <- genHostName
334+ process <- genProcessID
335+ payload <- genSimpleLogPayload
336+ message <- genLogStr
337+ time <- genUTCTime
338+ namespace <- genNamespace
339+ loc <- Gen.maybe genLoc
340+ pure $ Item
341+ { _itemApp = app
342+ , _itemEnv = env
343+ , _itemSeverity = severity
344+ , _itemThread = thread
345+ , _itemHost = host
346+ , _itemProcess = process
347+ , _itemPayload = payload
348+ , _itemMessage = message
349+ , _itemTime = time
350+ , _itemNamespace = namespace
351+ , _itemLoc = loc
352+ }
353+
354+
355+genNamespace :: Gen Namespace
356+genNamespace = Namespace <$> Gen.list (Range.linear 0 20) genSmallText
357+
358+
359+genEnvironment :: Gen Environment
360+genEnvironment = Environment <$> genSmallText
361+
362+
363+genSeverity :: Gen Severity
364+genSeverity = Gen.enumBounded
365+
366+
367+genThreadIdText :: Gen ThreadIdText
368+genThreadIdText = ThreadIdText <$> genSmallText
369+
370+
371+genHostName :: Gen HostName
372+genHostName = genSmallString
373+
374+
375+genProcessID :: Gen ProcessID
376+genProcessID = Gen.enumBounded
377+
378+
379+genLogStr :: Gen LogStr
380+genLogStr = genLogStr' (Range.linear 0 1024)
381+
382+
383+genLogStr' :: Range Int -> Gen LogStr
384+genLogStr' sizeRange = ls <$> Gen.text sizeRange Gen.unicode
385+
386+
387+genUTCTime :: Gen UTCTime
388+genUTCTime = posixSecondsToUTCTime . fromIntegral
389+ <$> Gen.int (Range.linear 0 maxBound)
390+
391+
392+genLoc :: Gen Loc
393+genLoc = Loc
394+ <$> genSmallString
395+ <*> genSmallString
396+ <*> genSmallString
397+ <*> genCharPos
398+ <*> genCharPos
399+ where
400+ genCharPos = (,)
401+ <$> Gen.int (Range.linear 0 maxBound)
402+ <*> Gen.int (Range.linear 0 maxBound)
403+
404+
405+genSimpleLogPayload :: Gen SimpleLogPayload
406+genSimpleLogPayload = SimpleLogPayload
407+ <$> Gen.list (Range.linear 0 20) genPair
408+ where
409+ genPair = (,)
410+ <$> genSmallText
411+ <*> genAnyLogPayload
412+
413+
414+genAnyLogPayload :: Gen AnyLogPayload
415+genAnyLogPayload = AnyLogPayload
416+ <$> genValue
417+
418+
419+genValue :: Gen Value
420+genValue = Gen.recursive Gen.choice nonRecursiveGens recursiveGens
421+ where
422+ nonRecursiveGens =
423+ [ pure A.Null
424+ , A.String <$> genSmallText
425+ , A.Number <$> genScientific
426+ , A.Bool <$> Gen.bool
427+ ]
428+ recursiveGens =
429+ [ A.Object <$> genObject
430+ , A.Array <$> genArray
431+ ]
432+ genObject = HM.fromList <$> Gen.list (Range.linear 0 20) genPair
433+ where
434+ genPair = (,) <$> genSmallText <*> genValue
435+ genArray = V.fromList <$>
436+ Gen.list (Range.linear 0 20) genValue
437+
438+
439+
440+genScientific :: Gen Scientific
441+genScientific = scientific
442+ <$> Gen.integral (Range.linear (-999999) 999999)
443+ <*> Gen.int (Range.linear (-999) (999))
444+
445+
446+genSmallText :: Gen Text
447+genSmallText = Gen.text (Range.linear 0 128) Gen.unicode
448+
449+
450+genSmallString :: Gen String
451+genSmallString = Gen.string (Range.linear 0 128) Gen.unicode
452+
453+
454+-------------------------------------------------------------------------------
455+mkUTCTime :: Integer -> Int -> Int -> DiffTime -> DiffTime -> DiffTime -> UTCTime
456+mkUTCTime y m d hr mn s = UTCTime day dt
457+ where
458+ day = mkDay y m d
459+ dt = s + 60 * mn + 60 * 60 * hr
460+
461+
462+-------------------------------------------------------------------------------
463+mkDay :: Integer -> Int -> Int -> Day
464+mkDay y m d = day
465+ where
466+ Just day = fromGregorianValid y m d
katip-logzio/test/Main.hsnew file+22
@@ -0,0 +1,22 @@
1+module Main
2+ ( main
3+ ) where
4+
5+
6+-------------------------------------------------------------------------------
7+import Test.Tasty
8+-------------------------------------------------------------------------------
9+import qualified Katip.Tests.Scribes.LogzIO.HTTPS
10+-------------------------------------------------------------------------------
11+
12+
13+
14+main :: IO ()
15+main = defaultMain tests
16+
17+
18+-------------------------------------------------------------------------------
19+tests :: TestTree
20+tests = testGroup "katip-logzio"
21+ [ Katip.Tests.Scribes.LogzIO.HTTPS.tests
22+ ]
katip/README.md+5−1
@@ -16,7 +16,7 @@ Kâtip (pronounced kah-tip) is the Turkish word for scribe.
1616 add context that will be automatically merged in with existing log
1717 context.
1818
19−* *Easy to Integration:* Katip was designed to be easily integrated
19+* *Easy Integration:* Katip was designed to be easily integrated
2020 into existing monads. By using typeclasses for logging facilities,
2121 individual subsystems and even libraries can easily add their own
2222 namespacing and context without having any knowledge of their
@@ -83,3 +83,7 @@ stack.
8383* [Doug Beardsley](https://github.com/mightybyte)
8484* [Leonid Onokhov](https://github.com/sopvop)
8585* [Alexander Vershilov](https://github.com/qnikst)
86+* [Chris Martin](https://github.com/chris-martin)
87+* [Domen Kožar](https://github.com/domenkozar)
88+* [Tristan Bull](https://github.com/tmbull)
89+* [Aleksey Khudyakov](https://github.com/Shimuuar)
katip/bench/Main.hs+51−46
@@ -1,3 +1,4 @@
1+{-# LANGUAGE BangPatterns #-}
12{-# LANGUAGE GeneralizedNewtypeDeriving #-}
23{-# LANGUAGE OverloadedStrings #-}
34{-# LANGUAGE StandaloneDeriving #-}
@@ -10,11 +11,13 @@ module Main
1011-------------------------------------------------------------------------------
1112import Control.Concurrent
1213import Control.DeepSeq
14+import Control.Exception.Safe
15+import Control.Monad
1316import Criterion.Main
1417import Data.Aeson
15−import Data.Monoid as M
16−import Data.Time.Calendar
17−import Data.Time.Clock
18+import Data.Monoid as M
19+import System.Directory
20+import System.FilePath
1821import System.IO
1922import System.Posix
2023-------------------------------------------------------------------------------
@@ -30,36 +33,42 @@ main = defaultMain [
3033
3134-------------------------------------------------------------------------------
3235handleScribeBench :: Benchmark
33−handleScribeBench = bgroup "Katip.Scribes.Handle" [
34− env setupHandleEnv $ \ ~((Scribe push, _), tid) ->
35− bench "Bytestring Builder" $
36− whnfIO $ (push (exItem tid))
37− ]
36+handleScribeBench = bgroup "Katip.Scribes.Handle" $
37+ flip map destinations $ \dest -> bgroup (show dest) [
38+ -- This is variably wildly on disk performance but should be a
39+ -- better test since a push test basically just tests how fast your
40+ -- queue structure is.
41+ bench "full env, flush 1000 writes" $
42+ whnfIO $ do
43+ le <- setupHandleLogEnv dest
44+ runKatipT le $ replicateM_ 1000 $ logItem ExPayload "namespace" Nothing InfoS "example"
45+ closeScribes le
46+ ]
47+ where
48+ destinations = [DevNull, TempFile]
49+ --destinations = [DevNull]
50+
51+
52+-------------------------------------------------------------------------------
53+data HandleDest = DevNull | TempFile deriving (Show, Eq)
3854
3955
4056-------------------------------------------------------------------------------
41−setupHandleEnv :: IO ((Scribe, Finaliser), ThreadIdText)
42−setupHandleEnv = do
43− scribe <- setup
44− tid <- myThreadId
45− return (scribe, mkThreadIdText tid)
57+instance NFData LogEnv where
58+ rnf (LogEnv !_ !_ !_ !_ !_ !_) = ()
59+
60+setupHandleLogEnv :: HandleDest -> IO LogEnv
61+setupHandleLogEnv hd = do
62+ (scr, _) <- setupHandleEnv hd
63+ registerScribe "handle" scr defaultScribeSettings =<< initLogEnv "katip-bench" "bench"
4664
4765
4866-------------------------------------------------------------------------------
49−exItem :: ThreadIdText -> Item ExPayload
50−exItem tid = Item {
51− _itemApp = Namespace ["app"]
52− , _itemEnv = Environment "production"
53− , _itemSeverity = WarningS
54− , _itemThread = tid
55− , _itemHost = "example"
56− , _itemProcess = CPid 123
57− , _itemPayload = ExPayload
58− , _itemMessage = "message"
59− , _itemTime = mkUTCTime 2015 3 14 1 5 9
60− , _itemNamespace = Namespace ["foo"]
61− , _itemLoc = Nothing
62− }
67+setupHandleEnv :: HandleDest -> IO (Scribe, ThreadIdText)
68+setupHandleEnv dest = do
69+ scribe <- setup dest
70+ tid <- myThreadId
71+ return (scribe, mkThreadIdText tid)
6372
6473
6574-------------------------------------------------------------------------------
@@ -75,28 +84,24 @@ instance LogItem ExPayload where
7584
7685
7786-------------------------------------------------------------------------------
78−mkUTCTime :: Integer -> Int -> Int -> DiffTime -> DiffTime -> DiffTime -> UTCTime
79−mkUTCTime y mt d h mn s = UTCTime day dt
80− where
81− day = fromGregorian y mt d
82− dt = h * 60 * 60 + mn * 60 + s
83−
84−
85−-------------------------------------------------------------------------------
86−setup :: IO (Scribe, Finaliser)
87−setup = do
88− h <- openFile "/dev/null" WriteMode
89− (s, f) <- mkHandleScribe ColorIfTerminal h DebugS V0
90− return (s, F f)
87+setup :: HandleDest -> IO Scribe
88+setup dest = do
89+ outFile <- case dest of
90+ TempFile -> do
91+ tmp <- getTemporaryDirectory
92+ return (tmp </> "katip-bench.log")
93+ DevNull -> return ("/dev/null")
94+ h <- openFile outFile WriteMode
95+ s <- mkHandleScribe ColorIfTerminal h (permitItem DebugS) V0
96+ let cleanupHandle = hClose h `finally` (when (dest == TempFile) (removeLink outFile))
97+ return s { scribeFinalizer = scribeFinalizer s `finally` cleanupHandle}
9198
9299
93100-------------------------------------------------------------------------------
94101deriving instance NFData ThreadIdText
95102
96−newtype Finaliser = F (IO ())
97−
98103instance NFData Scribe where
99− rnf (Scribe _) = ()
100−
101−instance NFData Finaliser where
102− rnf (F _) = ()
104+ rnf (Scribe a b p) = (a :: Item ExPayload -> IO ())
105+ `seq` b
106+ `seq` (p :: Item ExPayload -> IO Bool)
107+ `seq` ()
katip/changelog.md+123
@@ -1,3 +1,126 @@
1+0.8.5.0
2+=======
3+* Add MonadResource instances [#121](https://github.com/Soostone/katip/pull/121)
4+
5+0.8.4.0
6+=======
7+* Add support for unliftio-core 0.2 while maintaining backwards-compatible support for 0.1
8+
9+0.8.3.0
10+=======
11+
12+* Add `logKatipItem` function and reimplement `logItem` to use it. [vlatkoB](https://github.com/vlatkoB)
13+
14+0.8.2.0
15+=======
16+* Add `MonadFail` instances for `base` >= 4.9.0.0 [Koray Al](https://github.com/korayal)
17+
18+0.8.1.0
19+=======
20+* Export `logLoc`. Credit to [Brian McKenna](https://github.com/puffnfresh)
21+
22+0.8.0.0
23+=======
24+* **Breaking change**: switch from severity based log level filtering to
25+ user-definable `PermitFunc`. To upgrade, any time you initialize one
26+ of the standard scribes, rather than providing a severity like
27+ `InfoS`, instead pass in `(permitItem InfoS)`. Credit to
28+ [vlatkoB](https://github.com/vlatkoB).
29+* Update some misformatted and outdated docs.
30+* Set lower bound of base to 4.9.0.0, the version shipped with GHC
31+ 8.0.2. Support for GHC versions older than that is removed.
32+* Update default formatter of Handle scribe to format pid as `[PID
33+ 1234]` instead of `[1234]` and `[ThreadId 1234]` instead of
34+ `[1234]`.
35+* Add missing `Bounded` instance for `Verbosity`. This allows you to
36+ easily enumerate all verbosities via `[minBound..maxBound]`.
37+
38+0.7.0.0
39+=======
40+* Exclusively use HasCallstack for location reporting in errors. Credit to [Domen Kožar](https://github.com/domenkozar)
41+* Drop support for GHC 7.x
42+
43+0.6.3.0
44+=======
45+* Add `ToJSON`/`FromJSON` instances for Verbosity. Credit to [Aleksey Khudyakov](https://github.com/Shimuuar).
46+
47+0.6.2.1
48+=======
49+* Add `mkHandleScribeWithFormatter`. This allows control over the format of log items going to a handle. Credit to [Tristan Bull](https://github.com/tmbull) for the implementation.
50+* Documentation fixes. Credit to [Domen Kožar](https://github.com/domenkozar) for the implementation.
51+* Add `jsonFormat` handle formatter.
52+* Deprecate `formatItem` which is now replaced by `bracketFormat`.
53+
54+0.6.1.0
55+=======
56+* Loosen deps
57+* Support latest STM
58+
59+0.6.0.0
60+=======
61+* Drop ListT instance due to deprecations.
62+* Loosen dependencies.
63+
64+0.5.5.1
65+=======
66+* Decrease default timer resolution from 1s to 1ms.
67+
68+0.5.5.0
69+=======
70+* Export `runNoLoggingT` and `NoLoggingT` constructor.
71+* Delegate MonadReader instance for `NoLoggingT`.
72+
73+0.5.4.0
74+=======
75+* Loosen bounds on resourcet and template-haskell.
76+* Add convenience function askLoggerIO.
77+
78+0.5.3.0
79+=======
80+* Add MonadUnliftIO instances.
81+* Add NoLoggingT
82+
83+0.5.2.0
84+=======
85+* Allow newer versions of either by conditionally adding instances for the removed EitherT interface.
86+
87+0.5.1.0
88+=======
89+* Add mkFileScribe, a specialization of mkHandleScribe for files that manages the handle automatically.
90+
91+0.5.0.4
92+=======
93+* Loosen Win32 upper bound to run with GHC 8.2 on Windows.
94+
95+0.5.0.3
96+=======
97+* Add worked example of Katip/KatipContext to the haddocks.
98+
99+0.5.0.2
100+=======
101+* Export Katip.Compat for Windows users.
102+
103+0.5.0.1
104+=======
105+* Fix numeric formatting in Handle scribe.
106+* Bump deps for GHC 8.2.1
107+
108+0.5.0.0
109+=======
110+* Improved documentation.
111+* Add built-in buffering to scribes.
112+ Scribes now allocate a bounded queue (with configurable size). Rather than writes being synchronous to all scribes, they simply attempt to write into the bounded queue of each scribe. If any of the scribes is too far behind and the queue is full, the write is dropped. This also means that closing scribes is now an IO operation that happens synchrounsly.
113+* Added local-like functions to Katip and KatipContext typeclasses. This allows us to generalize `katipNoLogging`, `katipAddNamespace`, and `katipAddContext` to be available to anything with a `Katip` or `KatipContext` instance rather than having to reimplement these functions all the time.
114+
115+0.4.1.0
116+=======
117+* Add Katip instances for Strict StateT, WriterT, RWST.
118+* Add Katip instances for Lazy RWST.
119+
120+0.4.0.0
121+=======
122+* Drop unsafe _ioLogEnv for safe ioLogEnv
123+
11240.3.1.5
2125=======
3126* Add Semigroup instance for LogStr.
katip/examples/example.hs+28−42
@@ -13,6 +13,7 @@ module Main
1313
1414-------------------------------------------------------------------------------
1515import qualified Control.Applicative as A
16+import Control.Exception
1617import Control.Monad.Base
1718import Control.Monad.Reader
1819import Control.Monad.Trans.Control
@@ -25,34 +26,36 @@ import Katip
2526
2627
2728-- | An example of advanced katip usage. Be sure to check out
28−-- lens_example for a slightly cleaner and more general pattern.
29+-- example_lens.hs for a slightly cleaner and more general pattern.
2930main :: IO ()
3031main = do
31− le <- initLogEnv "MyApp" "production"
3232 -- We'll set up a scribe that logs to stdout and will only log item
3333 -- fields permitted for Verbosity 2 and will throw out Debug
3434 -- messages entirely. Note that katip provides facilities like
3535 -- 'unregisterScribe' and 'registerScribe' to make it possible to
36− -- hot-swap scribes at runtime if you need to.
37− (handleScribe, finaliser) <- mkHandleScribe ColorIfTerminal stdout InfoS V2
38− let le' = registerScribe "stdout" handleScribe le
39− let s = MyState M.mempty mempty le'
40− runStack s $ do
41− $(logTM) InfoS "Started"
42− -- this will add "confrabulation" to the current namespace, making
43− -- logs made under this block have the namespace of
44− -- "main.confrabulation". Further, ConfrabLogCTX's key/value
45− -- context will also get merged with the context above it. You can
46− -- use this to stack up various contextual details throughout your
47− -- code and they will be flattened out and combined in the log
48− -- output.
49− addNamespace "confrabulation" $ addContext (ConfrabLogCTX 42) $ do
50− $(logTM) DebugS "Confrabulating widgets, with extra namespace and context"
51− confrabulateWidgets
52− $(logTM) InfoS "Namespace and context are back to normal"
53− noLogging $
54− $(logTM) DebugS "You'll never see this log message!"
55− finaliser
36+ -- hot-swap scribes at runtime if you need to. 'closeScribes' is
37+ -- blocking and flushes all messages out of a scribe and cleans up
38+ -- resources that were allocated at creation.
39+ handleScribe <- mkHandleScribe ColorIfTerminal stdout (permitItem InfoS) V2
40+ let mkLogEnv = registerScribe "stdout" handleScribe defaultScribeSettings =<< initLogEnv "MyApp" "production"
41+ bracket mkLogEnv closeScribes $ \le -> do
42+ let s = MyState M.mempty mempty le
43+ runStack s $ do
44+ $(logTM) InfoS "Started"
45+ -- this will add "confrabulation" to the current namespace, making
46+ -- logs made under this block have the namespace of
47+ -- "main.confrabulation". Further, ConfrabLogCTX's key/value
48+ -- context will also get merged with the context above it. You can
49+ -- use this to stack up various contextual details throughout your
50+ -- code and they will be flattened out and combined in the log
51+ -- output.
52+ katipAddNamespace "confrabulation" $ katipAddContext (ConfrabLogCTX 42) $ do
53+ $(logTM) DebugS "Confrabulating widgets, with extra namespace and context"
54+ confrabulateWidgets
55+ $(logTM) InfoS "Namespace and context are back to normal"
56+ katipNoLogging $
57+ $(logTM) DebugS "You'll never see this log message!"
58+
5659
5760-------------------------------------------------------------------------------
5861newtype ConfrabLogCTX = ConfrabLogCTX Int
@@ -110,31 +113,14 @@ instance MonadBaseControl b m => MonadBaseControl b (MyStack m) where
110113
111114instance (MonadIO m) => Katip (MyStack m) where
112115 getLogEnv = asks msLogEnv
116+ localLogEnv f (MyStack m) = MyStack (local (\s -> s { msLogEnv = f (msLogEnv s)}) m)
113117
114118
115119instance (MonadIO m) => KatipContext (MyStack m) where
116120 getKatipContext = asks msKContext
121+ localKatipContext f (MyStack m) = MyStack (local (\s -> s { msKContext = f (msKContext s)}) m)
117122 getKatipNamespace = asks msKNamespace
118−
119−
120−-------------------------------------------------------------------------------
121−-- | Merge some context into the log only for the given block
122−addContext :: (LogItem i, MonadReader MyState m) => i -> m a -> m a
123−addContext i = local (\r -> r { msKContext = msKContext r <> ctxs })
124− where
125− ctxs = liftPayload i
126−
127−
128−-------------------------------------------------------------------------------
129−-- | Add a layer of namespace to the logs only for the given block
130−addNamespace :: (MonadReader MyState m) => Namespace -> m a -> m a
131−addNamespace ns = local (\r -> r { msKNamespace = msKNamespace r <> ns })
132−
133−
134−-------------------------------------------------------------------------------
135−-- | Disable all log output temporarily
136−noLogging :: (MonadReader MyState m) => m a -> m a
137−noLogging = local (\r -> r { msLogEnv = clearScribes (msLogEnv r)})
123+ localKatipNamespace f (MyStack m) = MyStack (local (\s -> s { msKNamespace = f (msKNamespace s)}) m)
138124
139125
140126-------------------------------------------------------------------------------
katip/examples/example_lens.hs+27−43
@@ -13,6 +13,7 @@ module Main
1313
1414-------------------------------------------------------------------------------
1515import Control.Applicative as A
16+import Control.Exception
1617import Control.Lens hiding ((.=))
1718import Control.Monad.Base
1819import Control.Monad.Reader
@@ -40,35 +41,35 @@ makeClassy ''MyState
4041
4142
4243-------------------------------------------------------------------------------
43−-- | An example of advanced katip usage. Be sure to check out
44−-- lens_example for a slightly cleaner and more general pattern.
44+-- | An example of advanced katip usage with Lens.
4545main :: IO ()
4646main = do
47− le <- initLogEnv "MyApp" "production"
4847 -- We'll set up a scribe that logs to stdout and will only log item
4948 -- fields permitted for Verbosity 2 and will throw out Debug
5049 -- messages entirely. Note that katip provides facilities like
5150 -- 'unregisterScribe' and 'registerScribe' to make it possible to
52− -- hot-swap scribes at runtime if you need to.
53− (handleScribe, finaliser) <- mkHandleScribe ColorIfTerminal stdout InfoS V2
54− let le' = registerScribe "stdout" handleScribe le
55− let s = MyState M.mempty mempty le'
56− runStack s $ do
57− $(logTM) InfoS "Started"
58− -- this will add "confrabulation" to the current namespace, making
59− -- logs made under this block have the namespace of
60− -- "main.confrabulation". Further, ConfrabLogCTX's key/value
61− -- context will also get merged with the context above it. You can
62− -- use this to stack up various contextual details throughout your
63− -- code and they will be flattened out and combined in the log
64− -- output.
65− addNamespace "confrabulation" $ addContext (ConfrabLogCTX 42) $ do
66− $(logTM) DebugS "Confrabulating widgets, with extra namespace and context"
67− confrabulateWidgets
68− $(logTM) InfoS "Namespace and context are back to normal"
69− noLogging $
70− $(logTM) DebugS "You'll never see this log message!"
71− finaliser
51+ -- hot-swap scribes at runtime if you need to. 'closeScribes' is
52+ -- blocking and flushes all messages out of a scribe and cleans up
53+ -- resources that were allocated at creation.
54+ handleScribe <- mkHandleScribe ColorIfTerminal stdout (permitItem InfoS) V2
55+ let mkLogEnv = registerScribe "stdout" handleScribe defaultScribeSettings =<< initLogEnv "MyApp" "production"
56+ bracket mkLogEnv closeScribes $ \le -> do
57+ let s = MyState M.mempty mempty le
58+ runStack s $ do
59+ $(logTM) InfoS "Started"
60+ -- this will add "confrabulation" to the current namespace, making
61+ -- logs made under this block have the namespace of
62+ -- "main.confrabulation". Further, ConfrabLogCTX's key/value
63+ -- context will also get merged with the context above it. You can
64+ -- use this to stack up various contextual details throughout your
65+ -- code and they will be flattened out and combined in the log
66+ -- output.
67+ katipAddNamespace "confrabulation" $ katipAddContext (ConfrabLogCTX 42) $ do
68+ $(logTM) DebugS "Confrabulating widgets, with extra namespace and context"
69+ confrabulateWidgets
70+ $(logTM) InfoS "Namespace and context are back to normal"
71+ katipNoLogging $
72+ $(logTM) DebugS "You'll never see this log message!"
7273
7374
7475-------------------------------------------------------------------------------
@@ -118,31 +119,14 @@ instance MonadBaseControl b m => MonadBaseControl b (MyStack m) where
118119
119120instance (MonadIO m) => Katip (MyStack m) where
120121 getLogEnv = view msLogEnv
122+ localLogEnv f (MyStack m) = MyStack (local (over msLogEnv f) m)
121123
122124
123125instance (MonadIO m) => KatipContext (MyStack m) where
124126 getKatipContext = view msKContext
127+ localKatipContext f (MyStack m) = MyStack (local (over msKContext f) m)
125128 getKatipNamespace = view msKNamespace
126−
127−
128−-------------------------------------------------------------------------------
129−-- | Merge some context into the log only for the given block
130−addContext :: (LogItem i, MonadReader r m, HasMyState r) => i -> m a -> m a
131−addContext i = local (\r -> r & msKContext <>~ ctxs)
132− where
133− ctxs = liftPayload i
134−
135−
136−-------------------------------------------------------------------------------
137−-- | Add a layer of namespace to the logs only for the given block
138−addNamespace :: (MonadReader r m, HasMyState r) => Namespace -> m a -> m a
139−addNamespace ns = local (\r -> r & msKNamespace <>~ ns)
140−
141−
142−-------------------------------------------------------------------------------
143−-- | Disable all log output temporarily
144−noLogging :: (MonadReader r m, HasMyState r) => m a -> m a
145−noLogging = local (\r -> r & msLogEnv %~ clearScribes)
129+ localKatipNamespace f (MyStack m) = MyStack (local (over msKNamespace f) m)
146130
147131
148132-------------------------------------------------------------------------------
katip/katip.cabal+36−28
@@ -1,5 +1,5 @@
11name: katip
2−version: 0.3.1.5
2+version: 0.8.5.0
33synopsis: A structured logging framework.
44description:
55 Katip is a structured logging framework. See README.md for more details.
@@ -8,7 +8,7 @@ license: BSD3
88license-file: LICENSE
99author: Ozgun Ataman, Michael Xavier
1010maintainer: michael.xavier@soostone.com
11−copyright: Soostone Inc, 2015-2016
11+copyright: Soostone Inc, 2015-2017
1212category: Data, Text, Logging
1313homepage: https://github.com/Soostone/katip
1414bug-reports: https://github.com/Soostone/katip/issues
@@ -25,7 +25,7 @@ extra-source-files:
2525 test/Katip/Tests/Scribes/Handle.hs
2626 test/Katip/Tests/Scribes/Handle-text.golden
2727 test/Katip/Tests/Format/Time.hs
28−tested-with: GHC == 7.8.4, GHC== 7.10.3
28+tested-with: GHC == 8.0.1, GHC == 8.2.2, GHC == 8.4.3
2929
3030source-repository head
3131 type: git
@@ -53,31 +53,33 @@ library
5353 TemplateHaskell
5454 OverloadedStrings
5555
56− build-depends: base >=4.5 && <5
57− , aeson >=0.6 && <1.2
56+ build-depends: base >=4.9.0.0 && <5
57+ , aeson >=0.6
5858 , async < 3.0.0.0
59− , auto-update >= 0.1 && < 0.2
60− , bytestring >= 0.9 && < 0.11
61− , containers >=0.4 && <0.6
62− , either >= 4 && < 4.5
63− , exceptions >= 0.5 && < 0.9
64− , hostname >=1.0 && <1.1
65− , old-locale >= 1.0 && < 1.1
66− , string-conv >= 0.1 && < 0.2
67− , template-haskell >= 2.8 && < 2.12
68− , text >= 0.11 && <1.3
69− , time >= 1 && < 1.7
70− , transformers >= 0.3 && < 0.6
59+ , auto-update >= 0.1
60+ , bytestring >= 0.9
61+ , containers >=0.4
62+ , either >= 4
63+ , safe-exceptions >= 0.1.0.0
64+ , hostname >=1.0
65+ , old-locale >= 1.0
66+ , string-conv >= 0.1
67+ , template-haskell >= 2.8
68+ , text >= 0.11
69+ , time >= 1
70+ , transformers >= 0.3
7171 , transformers-compat
72− , unordered-containers >= 0.2 && < 0.3
73− , monad-control >= 1.0 && < 1.1
74− , mtl >= 2.0 && < 2.3
75− , transformers-base >= 0.3 && < 0.6
76− , resourcet >= 1.1 && < 1.2
77− , microlens >= 0.2.0.0 && < 0.5
78− , microlens-th >= 0.1.0.0 && < 0.5
72+ , unordered-containers >= 0.2
73+ , monad-control >= 1.0
74+ , mtl >= 2.0
75+ , transformers-base >= 0.3
76+ , resourcet >= 1.1
77+ , scientific >= 0.3.3.0
78+ , microlens >= 0.2.0.0
79+ , microlens-th >= 0.1.0.0
7980 , semigroups
80− , unagi-chan < 0.5.0.0
81+ , unliftio-core >= 0.1
82+ , stm >= 2.4
8183
8284 hs-source-dirs: src
8385 default-language: Haskell2010
@@ -85,8 +87,8 @@ library
8587 if flag(lib-Werror)
8688 ghc-options: -Werror
8789 if os(windows)
88− build-depends: Win32 >=2.3 && <2.5
89− other-modules: Katip.Compat
90+ build-depends: Win32 >=2.3 && <2.9
91+ exposed-modules: Katip.Compat
9092 else
9193 build-depends: unix >= 2.5 && <2.8
9294
@@ -112,11 +114,14 @@ test-suite test
112114 , template-haskell
113115 , text
114116 , time
115− , time-locale-compat >= 0.1.0.1 && < 0.2
117+ , time-locale-compat >= 0.1.0.1
116118 , directory
117119 , regex-tdfa
118120 , unordered-containers
119121 , microlens
122+ , containers
123+ , stm
124+ , safe-exceptions
120125 ghc-options: -Wall
121126 if flag(lib-Werror)
122127 ghc-options: -Werror
@@ -142,3 +147,6 @@ benchmark bench
142147 , transformers
143148 , deepseq
144149 , async
150+ , filepath
151+ , safe-exceptions
152+ , directory
katip/src/Katip.hs+99−8
@@ -1,7 +1,78 @@
1−-- | Includes all of the API's youll need to use Katip. Be sure to
1+-- | Includes all of the APIs youll need to use Katip. Be sure to
22-- check out the included @examples@ directory for an example of
33-- usage.
44--
5+-- Here's a basic example:
6+--
7+-- @
8+--
9+-- import Control.Exception
10+-- import Katip
11+--
12+-- main :: IO ()
13+-- main = do
14+-- handleScribe <- mkHandleScribe ColorIfTerminal stdout (permitItem InfoS) V2
15+-- let makeLogEnv = registerScribe "stdout" handleScribe defaultScribeSettings =<< initLogEnv \"MyApp\" \"production\"
16+-- -- closeScribes will stop accepting new logs, flush existing ones and clean up resources
17+-- bracket makeLogEnv closeScribes $ \le -> do
18+-- let initialContext = () -- this context will be attached to every log in your app and merged w/ subsequent contexts
19+-- let initialNamespace = "main"
20+-- runKatipContextT le initialContext initialNamespace $ do
21+-- $(logTM) InfoS "Hello Katip"
22+-- -- This adds a namespace to the current namespace and merges a piece of contextual data into your context
23+-- katipAddNamespace "additional_namespace" $ katipAddContext (sl "some_context" True) $ do
24+-- $(logTM) WarningS "Now we're getting fancy"
25+-- katipNoLogging $ do
26+-- $(logTM) DebugS "You will never see this!"
27+--
28+-- @
29+--
30+-- Another common case that you have some sort of App monad that's
31+-- based on ReaderT with some Config state. This is a perfect place to
32+-- insert read-only katip state:
33+--
34+-- @
35+--
36+-- import Katip as K
37+--
38+-- data Config = Config {
39+-- logNamespace :: K.Namespace
40+-- , logContext :: K.LogContexts
41+-- , logEnv :: K.LogEnv
42+-- -- whatever other read-only config you need
43+-- }
44+--
45+-- newtype App m a = App {
46+-- unApp :: ReaderT Config m a
47+-- } deriving (Functor, Applicative, Monad, MonadIO, MonadReader Config) -- these are necessary
48+--
49+--
50+-- -- These instances get even easier with lenses!
51+-- instance (MonadIO m) => K.Katip (App m) where
52+-- getLogEnv = asks logEnv
53+-- -- with lens:
54+-- -- getLogEnv = view logEnv
55+-- localLogEnv f (App m) = App (local (\\s -> s { logEnv = f (logEnv s)}) m)
56+-- -- with lens:
57+-- -- localLogEnv f (App m) = App (local (over logEnv f) m)
58+--
59+--
60+-- instance (MonadIO m) => K.KatipContext (App m) where
61+-- getKatipContext = asks logContext
62+-- -- with lens:
63+-- -- getKatipContext = view logContext
64+-- localKatipContext f (App m) = App (local (\\s -> s { logContext = f (logContext s)}) m)
65+-- -- with lens:
66+-- -- localKatipContext f (App m) = App (local (over logContext f) m)
67+-- getKatipNamespace = asks logNamespace
68+-- -- with lens:
69+-- -- getKatipNamespace = view logNamespace
70+-- localKatipNamespace f (App m) = App (local (\\s -> s { logNamespace = f (logNamespace s)}) m)
71+-- -- with lens:
72+-- -- localKatipNamespace f (App m) = App (local (over logNamespace f) m)
73+--
74+-- @
75+--
576-- To get up and running, the workflow is generally:
677--
778-- * Set up a 'LogEnv' using 'initLogEnv'.
@@ -40,6 +111,10 @@ module Katip
40111 , Scribe (..)
41112 , LogEnv (..)
42113 , SimpleLogPayload, sl
114+ , defaultScribeSettings
115+ , ScribeSettings
116+ , scribeBufferSize
117+ , _scribeBufferSize
43118
44119 -- ** @lens@-compatible Lenses
45120 , itemApp
@@ -60,43 +135,62 @@ module Katip
60135 , logEnvTimer
61136 , logEnvScribes
62137
63− -- * A Built-in Monad For Logging
138+ -- * A Built-in Monad For Simple Logging
64139 , KatipT (..)
65140 , runKatipT
66141
67142 -- * Initializing Loggers
68143 , initLogEnv
69144 , registerScribe
145+ -- * Dropping scribes temporarily
70146 , unregisterScribe
71147 , clearScribes
148+ -- * Finalizing scribes at shutdown
149+ , closeScribes
150+ , closeScribe
72151
73152 -- * Logging Functions
74153 , LogStr (..)
75154 , logStr, ls, showLS
76155
77− -- ** 'Katip' LoggingFunctions
156+ -- ** 'Katip' Logging Functions
78157 -- $katiplogging
79158 , Katip (..)
80159 , logF
81160 , logMsg
82161 , logT
162+ , logLoc
83163 , logItem
164+ , logKatipItem
84165 , logException
85− -- ** 'KatipContext' Logging Functions
166+ -- ** 'KatipContext': Logging With Context
86167 -- $katipcontextlogging
87168 , KatipContext (..)
88169 , logFM
89170 , logTM
171+ , logLocM
90172 , logItemM
91173 , logExceptionM
92174 , AnyLogContext
93175 , LogContexts, liftPayload
176+ -- *** Temporarily Changing Logging Behavior
177+ , katipAddNamespace
178+ , katipAddContext
179+ , katipNoLogging
94180
95181 -- * Included Scribes
96182 , mkHandleScribe
183+ , mkHandleScribeWithFormatter
184+ , mkFileScribe
97185 , ColorStrategy (..)
186+ , ItemFormatter
187+ , bracketFormat
188+ , jsonFormat
98189
99190 -- * Tools for implementing Scribes
191+ , PermitFunc
192+ , permitAND
193+ , permitOR
100194 , permitItem
101195 , payloadObject
102196 , itemJson
@@ -104,9 +198,6 @@ module Katip
104198 -- * KatipContextT - Utility transformer that provides Katip and KatipContext instances
105199 , KatipContextT
106200 , runKatipContextT
107− , katipAddNamespace
108− , katipAddContext
109− , katipNoLogging
110201 ) where
111202
112203-------------------------------------------------------------------------------
@@ -136,7 +227,7 @@ doDatabaseThings = do
136227@
137228
138229Another pain point to look out for is nesting actions that log in
139−eachother. Let's say you were writing a web app. You want to capture
230+each other. Let's say you were writing a web app. You want to capture
140231some detail such as the user's ID in the logs, but you also want that
141232info to show up in doDatabaseThings' logs so you can associate those
142233two pieces of information:
katip/src/Katip/Core.hs+423−127
@@ -5,8 +5,8 @@
55{-# LANGUAGE ExistentialQuantification #-}
66{-# LANGUAGE FlexibleContexts #-}
77{-# LANGUAGE FlexibleInstances #-}
8+{-# LANGUAGE GADTs #-}
89{-# LANGUAGE GeneralizedNewtypeDeriving #-}
9−{-# LANGUAGE ImplicitParams #-}
1010{-# LANGUAGE MultiParamTypeClasses #-}
1111{-# LANGUAGE OverloadedStrings #-}
1212{-# LANGUAGE RankNTypes #-}
@@ -22,36 +22,53 @@
2222module Katip.Core where
2323
2424-------------------------------------------------------------------------------
25−import Control.Applicative as A
25+import Control.Applicative as A
2626import Control.AutoUpdate
2727import Control.Concurrent
28+import qualified Control.Concurrent.Async as Async
29+import Control.Concurrent.STM
30+import qualified Control.Concurrent.STM.TBQueue as BQ
31+import Control.Exception.Safe
32+import Control.Monad (unless, void, when)
2833import Control.Monad.Base
29−import Control.Monad.Catch
34+#if MIN_VERSION_base(4, 9, 0)
35+import qualified Control.Monad.Fail as MF
36+#endif
3037import Control.Monad.IO.Class
38+import Control.Monad.IO.Unlift
3139import Control.Monad.Trans.Class
3240import Control.Monad.Trans.Control
41+#if !MIN_VERSION_either(4, 5, 0)
3342import Control.Monad.Trans.Either
43+#endif
3444import Control.Monad.Trans.Except
3545import Control.Monad.Trans.Maybe
3646import Control.Monad.Trans.Reader
37−import Control.Monad.Trans.Resource
38−import Control.Monad.Trans.State
39−import Control.Monad.Trans.Writer
40−import Data.Aeson (FromJSON (..), ToJSON (..),
41− object)
42−import qualified Data.Aeson as A
43−import Data.Foldable as FT
44−import qualified Data.HashMap.Strict as HM
47+import Control.Monad.Trans.Resource (MonadResource, ResourceT,
48+ transResourceT)
49+import Control.Monad.Trans.RWS.Lazy (RWST, mapRWST)
50+import qualified Control.Monad.Trans.RWS.Strict as Strict (RWST, mapRWST)
51+import Control.Monad.Trans.State.Lazy (StateT, mapStateT)
52+import qualified Control.Monad.Trans.State.Strict as Strict (StateT, mapStateT)
53+import Control.Monad.Trans.Writer.Lazy (WriterT, mapWriterT)
54+import qualified Control.Monad.Trans.Writer.Strict as Strict (WriterT,
55+ mapWriterT)
56+import Data.Aeson (FromJSON (..), ToJSON (..),
57+ object)
58+import qualified Data.Aeson as A
59+import Data.Foldable as FT
60+import qualified Data.HashMap.Strict as HM
4561import Data.List
46−import qualified Data.Map.Strict as M
47−import Data.Semigroup
62+import qualified Data.Map.Strict as M
63+import Data.Maybe (fromMaybe)
64+import Data.Semigroup as SG
4865import Data.String
4966import Data.String.Conv
50−import Data.Text (Text)
51−import qualified Data.Text as T
52−import qualified Data.Text.Lazy.Builder as B
67+import Data.Text (Text)
68+import qualified Data.Text as T
69+import qualified Data.Text.Lazy.Builder as B
5370import Data.Time
54−import GHC.Generics hiding (to)
71+import GHC.Generics hiding (to)
5572#if MIN_VERSION_base(4, 8, 0)
5673#if !MIN_VERSION_base(4, 9, 0)
5774import GHC.SrcLoc
@@ -59,7 +76,7 @@ import GHC.SrcLoc
5976import GHC.Stack
6077#endif
6178import Language.Haskell.TH
62−import qualified Language.Haskell.TH.Syntax as TH
79+import qualified Language.Haskell.TH.Syntax as TH
6380import Lens.Micro
6481import Lens.Micro.TH
6582import Network.HostName
@@ -75,8 +92,8 @@ import System.Posix
7592readMay :: Read a => String -> Maybe a
7693readMay s = case [x | (x,t) <- reads s, ("","") <- lex t] of
7794 [x] -> Just x
78− [] -> Nothing -- no parse
79− _ -> Nothing -- Ambiguous parse
95+ [] -> Nothing -- no parse
96+ _ -> Nothing -- Ambiguous parse
8097
8198
8299-------------------------------------------------------------------------------
@@ -86,7 +103,7 @@ readMay s = case [x | (x,t) <- reads s, ("","") <- lex t] of
86103-- IsString/OverloadedStrings, so "foo" will result in Namespace
87104-- ["foo"].
88105newtype Namespace = Namespace { unNamespace :: [Text] }
89− deriving (Eq,Show,Read,Ord,Generic,ToJSON,FromJSON,Semigroup,Monoid)
106+ deriving (Eq,Show,Read,Ord,Generic,ToJSON,FromJSON,SG.Semigroup,Monoid)
90107
91108instance IsString Namespace where
92109 fromString s = Namespace [fromString s]
@@ -126,19 +143,19 @@ data Severity
126143-- - 'V3' implies the maximum amount of payload information.
127144-- - Anything in between is left to the discretion of the developer.
128145data Verbosity = V0 | V1 | V2 | V3
129− deriving (Eq, Ord, Show, Read, Generic, Enum)
146+ deriving (Eq, Ord, Show, Read, Generic, Enum, Bounded)
130147
131148
132149-------------------------------------------------------------------------------
133150renderSeverity :: Severity -> Text
134151renderSeverity s = case s of
135− DebugS -> "Debug"
136− InfoS -> "Info"
137− NoticeS -> "Notice"
138− WarningS -> "Warning"
139− ErrorS -> "Error"
140− CriticalS -> "Critical"
141− AlertS -> "Alert"
152+ DebugS -> "Debug"
153+ InfoS -> "Info"
154+ NoticeS -> "Notice"
155+ WarningS -> "Warning"
156+ ErrorS -> "Error"
157+ CriticalS -> "Critical"
158+ AlertS -> "Alert"
142159 EmergencyS -> "Emergency"
143160
144161
@@ -164,14 +181,29 @@ instance FromJSON Severity where
164181 parseJSON = A.withText "Severity" parseSeverity
165182 where
166183 parseSeverity t = case textToSeverity t of
167− Just x -> return x
184+ Just x -> return x
168185 Nothing -> fail $ "Invalid Severity " ++ toS t
169186
187+instance ToJSON Verbosity where
188+ toJSON s = A.String $ case s of
189+ V0 -> "V0"
190+ V1 -> "V1"
191+ V2 -> "V2"
192+ V3 -> "V3"
193+
194+instance FromJSON Verbosity where
195+ parseJSON = A.withText "Verbosity" $ \s -> case s of
196+ "V0" -> return V0
197+ "V1" -> return V1
198+ "V2" -> return V2
199+ "V3" -> return V3
200+ _ -> fail $ "Invalid Verbosity " ++ toS s
201+
170202
171203-------------------------------------------------------------------------------
172204-- | Log message with Builder underneath; use '<>' to concat in O(1).
173205newtype LogStr = LogStr { unLogStr :: B.Builder }
174− deriving (Generic, Show)
206+ deriving (Generic, Show, Eq)
175207
176208instance IsString LogStr where
177209 fromString = LogStr . B.fromString
@@ -218,7 +250,9 @@ newtype ThreadIdText = ThreadIdText {
218250
219251
220252mkThreadIdText :: ThreadId -> ThreadIdText
221−mkThreadIdText = ThreadIdText . T.pack . show
253+mkThreadIdText = ThreadIdText . stripPrefix' "ThreadId " . T.pack . show
254+ where
255+ stripPrefix' pfx t = fromMaybe t (T.stripPrefix pfx t)
222256
223257
224258-------------------------------------------------------------------------------
@@ -238,31 +272,62 @@ data Item a = Item {
238272 } deriving (Generic, Functor)
239273makeLenses ''Item
240274
275+-- Manual instance because 'Loc' has no 'Eq' and 'Show' instances in old
276+-- versions of template-haskell (< 2.10)
277+instance Eq a => Eq (Item a) where
278+ a == b = FT.and [ _itemApp a == _itemApp b
279+ , _itemEnv a == _itemEnv b
280+ , _itemSeverity a == _itemSeverity b
281+ , _itemThread a == _itemThread b
282+ , _itemHost a == _itemHost b
283+ , _itemProcess a == _itemProcess b
284+ , _itemPayload a == _itemPayload b
285+ , _itemMessage a == _itemMessage b
286+ , _itemTime a == _itemTime b
287+ , _itemNamespace a == _itemNamespace b
288+ , case (_itemLoc a, _itemLoc b) of
289+ (Nothing, Nothing) -> True
290+ (Just l1, Just l2) -> FT.and [ loc_filename l1 == loc_filename l2
291+ , loc_package l1 == loc_package l2
292+ , loc_module l1 == loc_module l2
293+ , loc_start l1 == loc_start l2
294+ , loc_end l1 == loc_end l2
295+ ]
296+ _ -> False
297+ ]
241298
242299instance Show a => Show (Item a) where
243− show Item{..} = "Item {_itemApp = " ++ show _itemApp ++ ", " ++
244− "_itemEnv = " ++ show _itemEnv ++ ", " ++
245− "_itemSeverity = " ++ show _itemSeverity ++ ", " ++
246− "_itemThread = " ++ show _itemThread ++ ", " ++
247− "_itemHost = " ++ show _itemHost ++ ", " ++
248− "_itemProcess = " ++ show _itemProcess ++ ", " ++
249− "_itemPayload = " ++ show _itemPayload ++ ", " ++
250− "_itemMessage = " ++ show _itemMessage ++ ", " ++
251− "_itemTime = " ++ show _itemTime ++ ", " ++
252− "_itemNamespace = " ++ show _itemNamespace ++ ", " ++
253− "_itemLoc = " ++ show (LocShow <$> _itemLoc) ++ "}"
254−
300+ showsPrec d Item{..} = showParen (d >= 11) ( showString "Item {"
301+ . field "_itemApp" _itemApp
302+ . field "_itemEnv" _itemEnv
303+ . field "_itemSeverity" _itemSeverity
304+ . field "_itemThread" _itemThread
305+ . field "_itemHost" _itemHost
306+ . field "_itemProcess" _itemProcess
307+ . field "_itemPayload" _itemPayload
308+ . field "_itemMessage" _itemMessage
309+ . field "_itemTime" _itemTime
310+ . field "_itemNamespace" _itemNamespace
311+ . showString "_itemLoc = " . shows (LocShow <$> _itemLoc)
312+ . showChar '}'
313+ )
314+ where
315+ field n v = showString n . showString " = " . shows v . showString ", "
255316
256317newtype LocShow = LocShow Loc
257318
258319
259320instance Show LocShow where
260− show (LocShow Loc{..}) =
261− "Loc {loc_filename = " ++ show loc_filename ++ ", " ++
262− "loc_package = " ++ show loc_package ++ ", " ++
263− "loc_module = " ++ show loc_module ++ ", " ++
264− "loc_start = " ++ show loc_start ++ ", " ++
265− "loc_end = " ++ show loc_end ++ "}"
321+ showsPrec d (LocShow Loc{..}) = showParen (d >= 11) ( showString "Loc {"
322+ . field "loc_filename" loc_filename
323+ . field "loc_package" loc_package
324+ . field "loc_module" loc_module
325+ . field "loc_start" loc_start
326+ . showString "loc_end = " . shows loc_end
327+ . showChar '}'
328+ )
329+ where
330+ field n v = showString n . showString " = " . shows v . showString ", "
266331
267332
268333instance ToJSON a => ToJSON (Item a) where
@@ -343,7 +408,7 @@ instance FromJSON ProcessIDJs where
343408 parseJSON = A.withText "ProcessID" parseProcessID
344409 where
345410 parseProcessID t = case textToProcessID t of
346− Just p -> return $ ProcessIDJs p
411+ Just p -> return $ ProcessIDJs p
347412 Nothing -> fail $ "Invalid ProcessIDJs " ++ toS t
348413
349414
@@ -380,7 +445,7 @@ class ToObject a where
380445 default toObject :: ToJSON a => a -> A.Object
381446 toObject v = case toJSON v of
382447 A.Object o -> o
383− _ -> mempty
448+ _ -> mempty
384449
385450instance ToObject ()
386451instance ToObject A.Object
@@ -432,7 +497,7 @@ instance ToObject SimpleLogPayload
432497
433498instance LogItem SimpleLogPayload where
434499 payloadKeys V0 _ = SomeKeys []
435− payloadKeys _ _ = AllKeys
500+ payloadKeys _ _ = AllKeys
436501
437502
438503instance Semigroup SimpleLogPayload where
@@ -455,7 +520,7 @@ sl a b = SimpleLogPayload [(a, AnyLogPayload b)]
455520-- automatically bubble higher verbosity levels to lower ones.
456521payloadObject :: LogItem a => Verbosity -> a -> A.Object
457522payloadObject verb a = case FT.foldMap (flip payloadKeys a) [(V0)..verb] of
458− AllKeys -> toObject a
523+ AllKeys -> toObject a
459524 SomeKeys ks -> HM.filterWithKey (\ k _ -> k `FT.elem` ks) $ toObject a
460525
461526
@@ -475,49 +540,107 @@ itemJson verb a = toJSON $ a & itemPayload %~ payloadObject verb
475540--
476541-- Scribes should always take a 'Severity' and 'Verbosity'.
477542--
478−-- Severity is used to *exclude log messages* that are < the provided
479−-- Severity. For instance, if the user passes InfoS, DebugS items
480−-- should be ignored. Katip provides the 'permitItem' utility for this.
543+-- Severity is used to __exclude log messages__ that are lower than
544+-- the provided Severity. For instance, if the user passes InfoS,
545+-- DebugS items should be ignored. Katip provides the 'permitItem'
546+-- utility for this. The user or the scribe may use 'permitAND' and
547+-- 'permitOR' to further customize this filtering, even dynamically if
548+-- they wish to.
481549--
482550-- Verbosity is used to select keys from the log item's payload. Each
483551-- 'LogItem' instance describes what keys should be retained for each
484552-- Verbosity level. Use the 'payloadObject' utility for extracting the keys
485−-- that should be permitted.
486−--
487−-- There is no built-in mechanism in katip for telling a scribe that
488−-- its time to shut down. 'unregisterScribe' merely drops it from the
489−-- 'LogEnv'. This means there are 2 ways to handle resources as a scribe:
553+-- that should be written.
490554--
491−-- 1. Pass in the resource when the scribe is created. Handle
492−-- allocation and release of the resource elsewhere. This is what the
493−-- Handle scribe does.
555+-- Scribes provide a finalizer IO action ('scribeFinalizer') that is
556+-- meant to synchronously flush any remaining writes and clean up any
557+-- resources acquired when the scribe was created. Internally, katip
558+-- keeps a buffer for each scribe's writes. When 'closeScribe' or
559+-- 'closeScribes' is called, that buffer stops accepting new log
560+-- messages and after the last item in its buffer is sent to 'liPush',
561+-- calls the finalizer. Thus, when the finalizer returns, katip can
562+-- assume that all resources are cleaned up and all log messages are
563+-- durably written.
494564--
495−-- 2. Return a finalizing function that tells the scribe to shut
496−-- down. @katip-elasticsearch@'s @mkEsScribe@ returns an @IO (Scribe,
497−-- IO ())@. The finalizer will flush any queued log messages and shut
498−-- down gracefully before returning. This can be hooked into your
499−-- application's shutdown routine to ensure you never miss any log
500−-- messages on shutdown.
501−data Scribe = Scribe {
502− liPush :: forall a. LogItem a => Item a -> IO ()
503− }
565+-- While katip internally buffers messages per 'ScribeSettings', it
566+-- sends them one at a time to the scribe. Depending on the scribe
567+-- itself, it may make sense for that scribe to keep its own internal
568+-- buffer to batch-send logs if writing items one at a time is not
569+-- efficient. The scribe implementer must be sure that on
570+-- finalization, all writes are committed synchronously.
571+
572+-- | Signature of a function passed to `Scribe` constructor and
573+-- mkScribe* functions that decides which messages to be
574+-- logged. Typically filters based on 'Severity', but can be
575+-- combined with other, custom logic with 'permitAND' and 'permitOR'
576+type PermitFunc = forall a. Item a -> IO Bool
577+
578+
579+-- | AND together 2 permit functions
580+permitAND :: PermitFunc -> PermitFunc -> PermitFunc
581+permitAND f1 f2 = \a -> liftA2 (&&) (f1 a) (f2 a)
504582
583+-- | OR together 2 permit functions
584+permitOR :: PermitFunc -> PermitFunc -> PermitFunc
585+permitOR f1 f2 = \a -> liftA2 (||) (f1 a) (f2 a)
505586
587+
588+data Scribe = Scribe {
589+ liPush :: forall a. LogItem a => Item a -> IO ()
590+ -- ^ How do we write an item to the scribe's output?
591+ , scribeFinalizer :: IO ()
592+ -- ^ Provide a __blocking__ finalizer to call when your scribe is
593+ -- removed. All pending writes should be flushed synchronously. If
594+ -- this is not relevant to your scribe, return () is fine.
595+ , scribePermitItem :: PermitFunc
596+ -- ^ Provide a filtering function to allow the item to be logged,
597+ -- or not. It can check Severity or some string in item's
598+ -- body. The initial value of this is usually created from
599+ -- 'permitItem'. Scribes and users can customize this by ANDing
600+ -- or ORing onto the default with 'permitAND' or 'permitOR'
601+ }
602+
603+
604+whenM :: Monad m => m Bool -> m () -> m ()
605+whenM mbool = (>>=) mbool . flip when
606+
607+
608+-- | Combine two scribes. Publishes to the left scribe if the left
609+-- would permit the item and to the right scribe if the right would
610+-- permit the item. Finalizers are called in sequence from left to
611+-- right.
506612instance Semigroup Scribe where
507− (Scribe a) <> (Scribe b) = Scribe $ \ item -> do
508− a item
509− b item
613+ (Scribe pushA finA permitA) <> (Scribe pushB finB permitB) =
614+ Scribe (\item -> whenM (permitA item) (pushA item)
615+ >> whenM (permitB item) (pushB item)
616+ )
617+ (finA `finally` finB)
618+ (permitOR permitA permitB)
510619
511620
512621instance Monoid Scribe where
513− mempty = Scribe $ const $ return ()
622+ mempty = Scribe (const (return ())) (return ()) (permitItem DebugS)
514623 mappend = (<>)
515624
516625
626+-------------------------------------------------------------------------------
627+data ScribeHandle = ScribeHandle {
628+ shScribe :: Scribe
629+ , shChan :: BQ.TBQueue WorkerMessage
630+ }
631+
632+
633+-------------------------------------------------------------------------------
634+data WorkerMessage where
635+ NewItem :: LogItem a => Item a -> WorkerMessage
636+ PoisonPill :: WorkerMessage
637+
638+
517639-------------------------------------------------------------------------------
518640-- | Should this item be logged given the user's maximum severity?
519−permitItem :: Severity -> Item a -> Bool
520−permitItem sev i = _itemSeverity i >= sev
641+-- Most new scribes will use this as a base for their 'PermitFunc'
642+permitItem :: Monad m => Severity -> Item a -> m Bool
643+permitItem sev item = return (_itemSeverity item >= sev)
521644
522645
523646-------------------------------------------------------------------------------
@@ -536,16 +659,16 @@ data LogEnv = LogEnv {
536659 -- 'AutoUpdate' for high volume logs but note that this may cause
537660 -- some output forms to display logs out of order. Alternatively,
538661 -- you could just use 'getCurrentTime'.
539− , _logEnvScribes :: M.Map Text Scribe
662+ , _logEnvScribes :: M.Map Text ScribeHandle
540663 }
541664makeLenses ''LogEnv
542665
543666
544667-------------------------------------------------------------------------------
545−-- | Create a reasonable default InitLogEnv. Uses an 'AutoUdate' with
546−-- the default settings as the timer. If you are concerned about
547−-- timestamp precision or event ordering in log outputs like
548−-- ElasticSearch, you should replace the timer with 'getCurrentTime'
668+-- | Create a reasonable default InitLogEnv. Uses an 'AutoUpdate' which
669+-- updates the timer every 1ms. If you need even more timestamp
670+-- precision at the cost of performance, consider setting
671+-- '_logEnvTimer' with 'getCurrentTime'.
549672initLogEnv
550673 :: Namespace
551674 -- ^ A base namespace for this application
@@ -557,45 +680,123 @@ initLogEnv an env = LogEnv
557680 <*> getProcessID
558681 <*> pure an
559682 <*> pure env
560− <*> mkAutoUpdate defaultUpdateSettings { updateAction = getCurrentTime }
683+ <*> mkAutoUpdate defaultUpdateSettings { updateAction = getCurrentTime, updateFreq = 1000 }
561684 <*> pure mempty
562685
563686
564687-------------------------------------------------------------------------------
565688-- | Add a scribe to the list. All future log calls will go to this
566−-- scribe in addition to the others.
689+-- scribe in addition to the others. Writes will be buffered per the
690+-- ScribeSettings to prevent slow scribes from slowing down
691+-- logging. Writes will be dropped if the buffer fills.
567692registerScribe
568693 :: Text
569694 -- ^ Name the scribe
570695 -> Scribe
696+ -> ScribeSettings
571697 -> LogEnv
572− -> LogEnv
573−registerScribe nm h = logEnvScribes %~ M.insert nm h
698+ -> IO LogEnv
699+registerScribe nm scribe ScribeSettings {..} le = do
700+ queue <- atomically (BQ.newTBQueue (fromIntegral _scribeBufferSize))
701+ worker <- spawnScribeWorker scribe queue
702+ let fin = do
703+ atomically (BQ.writeTBQueue queue PoisonPill)
704+ -- wait for our worker to finish final write
705+ void (Async.waitCatch worker)
706+ -- wait for scribe to finish final write
707+ void (scribeFinalizer scribe)
708+
709+ let sh = ScribeHandle (scribe { scribeFinalizer = fin }) queue
710+ return (le & logEnvScribes %~ M.insert nm sh)
711+
712+
713+-------------------------------------------------------------------------------
714+spawnScribeWorker :: Scribe -> BQ.TBQueue WorkerMessage -> IO (Async.Async ())
715+spawnScribeWorker (Scribe write _ _) queue = Async.async go
716+ where
717+ go = do
718+ newCmd <- atomically (BQ.readTBQueue queue)
719+ case newCmd of
720+ NewItem a -> do
721+ -- Swallow any direct exceptions from the
722+ -- scribe. safe-exceptions won't catch async exceptions.
723+ void (tryAny (write a))
724+ go
725+ PoisonPill -> return ()
726+
727+
728+-------------------------------------------------------------------------------
729+data ScribeSettings = ScribeSettings {
730+ _scribeBufferSize :: Int
731+ }
732+ deriving (Show, Eq)
733+
734+makeLenses ''ScribeSettings
735+
736+
737+-- | Reasonable defaults for a scribe. Buffer
738+-- size of 4096.
739+defaultScribeSettings :: ScribeSettings
740+defaultScribeSettings = ScribeSettings 4096
574741
575742
576743-------------------------------------------------------------------------------
577−-- | Remove a scribe from the list. All future log calls will no
578−-- longer use this scribe. If the given scribe doesn't exist, its a no-op.
744+-- | Remove a scribe from the environment. This does __not__ finalize
745+-- the scribe. This mainly only makes sense to use with something like
746+-- MonadReader's @local@ function to temporarily disavow a single
747+-- logger for a block of code.
579748unregisterScribe
580749 :: Text
581750 -- ^ Name of the scribe
582751 -> LogEnv
583752 -> LogEnv
584−unregisterScribe nm = logEnvScribes %~ M.delete nm
753+unregisterScribe nm = logEnvScribes %~ M.delete nm
585754
586755
587756-------------------------------------------------------------------------------
588−-- | Unregister *all* scribes. Logs will go off into space from this
589−-- point onward until new scribes are added. Note that you could use
590−-- this with `local` if you're using a Reader based stack to
591−-- temporarily disable log output. See `katipNoLogging` for an
592−-- example.
757+-- | Unregister __all__ scribes. Note that this is __not__ for closing or
758+-- finalizing scribes, use 'closeScribes' for that. This mainly only
759+-- makes sense to use with something like MonadReader's @local@
760+-- function to temporarily disavow any loggers for a block of code.
593761clearScribes
594762 :: LogEnv
595763 -> LogEnv
596764clearScribes = logEnvScribes .~ mempty
597765
598766
767+-------------------------------------------------------------------------------
768+-- | Finalize a scribe. The scribe is removed from the environment,
769+-- its finalizer is called so that it can never be written to again
770+-- and all pending writes are flushed. Note that this will throw any
771+-- exceptions yoru finalizer will throw, and that LogEnv is immutable,
772+-- so it will not be removed in that case.
773+closeScribe
774+ :: Text
775+ -- ^ Name of the scribe
776+ -> LogEnv
777+ -> IO LogEnv
778+closeScribe nm le = do
779+ maybe (return ()) (scribeFinalizer . shScribe) (M.lookup nm (_logEnvScribes le))
780+ return (le & logEnvScribes %~ M.delete nm)
781+
782+
783+-------------------------------------------------------------------------------
784+-- | Call this at the end of your program. This is a blocking call
785+-- that stop writing to a scribe's queue, waits for the queue to
786+-- empty, finalizes each scribe in the log environment and then
787+-- removes it. Finalizers are all run even if one of them throws, but
788+-- the exception will be re-thrown at the end.
789+closeScribes
790+ :: LogEnv
791+ -> IO LogEnv
792+closeScribes le = do
793+ -- We want to run every finalizer here so we'll not save
794+ -- intermediate logenvs and just clear scribes at the end.
795+ let actions = [void (closeScribe k le) | k <- M.keys (_logEnvScribes le)]
796+ FT.foldr finally (return ()) actions
797+ return (le & logEnvScribes .~ mempty)
798+
799+
599800-------------------------------------------------------------------------------
600801-- | Monads where katip logging actions can be performed. Katip is the
601802-- most basic logging monad. You will typically use this directly if
@@ -606,44 +807,86 @@ clearScribes = logEnvScribes .~ mempty
606807-- which keeps a namespace and merged context. You can write simple
607808-- functions that add additional namespacing and merges additional
608809-- context on the fly.
810+--
811+-- 'localLogEnv' was added to allow for lexically-scoped modifications
812+-- of the log env that are reverted when the supplied monad
813+-- completes. 'katipNoLogging', for example, uses this to temporarily
814+-- pause log outputs.
609815class MonadIO m => Katip m where
610816 getLogEnv :: m LogEnv
817+ localLogEnv :: (LogEnv -> LogEnv) -> m a -> m a
611818
612819
613820instance Katip m => Katip (ReaderT s m) where
614821 getLogEnv = lift getLogEnv
822+ localLogEnv = mapReaderT . localLogEnv
615823
616824
825+#if !MIN_VERSION_either(4, 5, 0)
617826instance Katip m => Katip (EitherT s m) where
618827 getLogEnv = lift getLogEnv
828+ localLogEnv = mapEitherT . localLogEnv
829+#endif
830+
619831
620832instance Katip m => Katip (ExceptT s m) where
621833 getLogEnv = lift getLogEnv
834+ localLogEnv = mapExceptT . localLogEnv
835+
622836
623837instance Katip m => Katip (MaybeT m) where
624838 getLogEnv = lift getLogEnv
839+ localLogEnv = mapMaybeT . localLogEnv
625840
626841
627842instance Katip m => Katip (StateT s m) where
628843 getLogEnv = lift getLogEnv
844+ localLogEnv = mapStateT . localLogEnv
845+
846+
847+instance (Katip m, Monoid w) => Katip (RWST r w s m) where
848+ getLogEnv = lift getLogEnv
849+ localLogEnv = mapRWST . localLogEnv
850+
851+
852+instance (Katip m, Monoid w) => Katip (Strict.RWST r w s m) where
853+ getLogEnv = lift getLogEnv
854+ localLogEnv = Strict.mapRWST . localLogEnv
855+
856+
857+instance Katip m => Katip (Strict.StateT s m) where
858+ getLogEnv = lift getLogEnv
859+ localLogEnv = Strict.mapStateT . localLogEnv
629860
630861
631862instance (Katip m, Monoid s) => Katip (WriterT s m) where
632863 getLogEnv = lift getLogEnv
864+ localLogEnv = mapWriterT . localLogEnv
865+
866+
867+instance (Katip m, Monoid s) => Katip (Strict.WriterT s m) where
868+ getLogEnv = lift getLogEnv
869+ localLogEnv = Strict.mapWriterT . localLogEnv
870+
633871
634872instance (Katip m) => Katip (ResourceT m) where
635873 getLogEnv = lift getLogEnv
874+ localLogEnv = transResourceT . localLogEnv
636875
637876
638877-------------------------------------------------------------------------------
639−-- | A concrete monad you can use to run logging actions.
878+-- | A concrete monad you can use to run logging actions. Use this if
879+-- you prefer an explicit monad transformer stack and adding layers as
880+-- opposed to implementing 'Katip' for your monad.
640881newtype KatipT m a = KatipT { unKatipT :: ReaderT LogEnv m a }
641882 deriving ( Functor, Applicative, Monad, MonadIO
642− , MonadMask, MonadCatch, MonadThrow, MonadTrans, MonadBase b)
883+ , MonadMask, MonadCatch, MonadThrow, MonadResource, MonadTrans
884+ , MonadBase b)
643885
644886
645887instance MonadIO m => Katip (KatipT m) where
646888 getLogEnv = KatipT ask
889+ localLogEnv f (KatipT m) = KatipT $ local f m
647890
648891
649892instance MonadTransControl KatipT where
@@ -659,6 +902,21 @@ instance (MonadBaseControl b m) => MonadBaseControl b (KatipT m) where
659902 liftBaseWith = defaultLiftBaseWith
660903 restoreM = defaultRestoreM
661904
905+instance MonadUnliftIO m => MonadUnliftIO (KatipT m) where
906+#if MIN_VERSION_unliftio_core(0, 2, 0)
907+ withRunInIO inner = KatipT $ ReaderT $ \le -> withRunInIO $ \run ->
908+ inner (run . runKatipT le)
909+#else
910+ askUnliftIO = KatipT $
911+ withUnliftIO $ \u ->
912+ pure (UnliftIO (unliftIO u . unKatipT))
913+#endif
914+
915+#if MIN_VERSION_base(4, 9, 0)
916+instance MF.MonadFail m => MF.MonadFail (KatipT m) where
917+ fail msg = lift (MF.fail msg)
918+ {-# INLINE fail #-}
919+#endif
662920
663921-------------------------------------------------------------------------------
664922-- | Execute 'KatipT' on a log env.
@@ -666,6 +924,17 @@ runKatipT :: LogEnv -> KatipT m a -> m a
666924runKatipT le (KatipT f) = runReaderT f le
667925
668926
927+-------------------------------------------------------------------------------
928+-- | Disable all scribes for the given monadic action, then restore
929+-- them afterwards. Works in any Katip monad.
930+katipNoLogging
931+ :: ( Katip m
932+ )
933+ => m a
934+ -> m a
935+katipNoLogging = localLogEnv (\le -> set logEnvScribes mempty le)
936+
937+
669938-------------------------------------------------------------------------------
670939-- | Log with everything, including a source code location. This is
671940-- very low level and you typically can use 'logT' in its place.
@@ -679,20 +948,43 @@ logItem
679948 -> m ()
680949logItem a ns loc sev msg = do
681950 LogEnv{..} <- getLogEnv
682− liftIO $ do
683− item <- Item
684− <$> pure _logEnvApp
685− <*> pure _logEnvEnv
686− <*> pure sev
687− <*> (mkThreadIdText <$> myThreadId)
688− <*> pure _logEnvHost
689− <*> pure _logEnvPid
690− <*> pure a
691− <*> pure msg
692− <*> _logEnvTimer
693− <*> pure (_logEnvApp <> ns)
694− <*> pure loc
695− FT.forM_ (M.elems _logEnvScribes) $ \ (Scribe h) -> h item
951+ logKatipItem =<< liftIO
952+ (Item <$> pure _logEnvApp
953+ <*> pure _logEnvEnv
954+ <*> pure sev
955+ <*> (mkThreadIdText <$> myThreadId)
956+ <*> pure _logEnvHost
957+ <*> pure _logEnvPid
958+ <*> pure a
959+ <*> pure msg
960+ <*> _logEnvTimer
961+ <*> pure (_logEnvApp <> ns)
962+ <*> pure loc)
963+
964+-- | Log already constructed 'Item'. This is the lowest level function that other log*
965+-- functions use.
966+-- It can be useful when implementing centralised logging services.
967+logKatipItem
968+ :: (A.Applicative m, LogItem a, Katip m)
969+ => Item a
970+ -> m ()
971+logKatipItem item = do
972+ LogEnv{..} <- getLogEnv
973+ liftIO $
974+ FT.forM_ (M.elems _logEnvScribes) $ \ ScribeHandle {..} -> do
975+ whenM (scribePermitItem shScribe item) $
976+ void $ atomically (tryWriteTBQueue shChan (NewItem item))
977+
978+-------------------------------------------------------------------------------
979+tryWriteTBQueue
980+ :: TBQueue a
981+ -> a
982+ -> STM Bool
983+ -- ^ Did we write?
984+tryWriteTBQueue q a = do
985+ full <- isFullTBQueue q
986+ unless full (writeTBQueue q a)
987+ return (not full)
696988
697989
698990-------------------------------------------------------------------------------
@@ -724,10 +1016,10 @@ logException
7241016 -> Severity -- ^ Severity
7251017 -> m b -- ^ Main action being run
7261018 -> m b
727−logException a ns sev action = action `catchAll` \e -> f e >> throwM e
1019+logException a ns sev action = action `catchAny` \e -> f e >> throwM e
7281020 where
7291021 f e = logF a ns sev (msg e)
730− msg e = ls (T.pack "An exception has occured: ") <> showLS e
1022+ msg e = ls (T.pack "An exception has occurred: ") <> showLS e
7311023
7321024
7331025-------------------------------------------------------------------------------
@@ -755,14 +1047,14 @@ instance TH.Lift Verbosity where
7551047
7561048
7571049instance TH.Lift Severity where
758− lift DebugS = [| DebugS |]
759− lift InfoS = [| InfoS |]
760− lift NoticeS = [| NoticeS |]
761− lift WarningS = [| WarningS |]
762− lift ErrorS = [| ErrorS |]
1050+ lift DebugS = [| DebugS |]
1051+ lift InfoS = [| InfoS |]
1052+ lift NoticeS = [| NoticeS |]
1053+ lift WarningS = [| WarningS |]
1054+ lift ErrorS = [| ErrorS |]
7631055 lift CriticalS = [| CriticalS |]
764− lift AlertS = [| AlertS |]
765− lift EmergencyS = [| EmergencyS |]
1056+ lift AlertS = [| AlertS |]
1057+ lift EmergencyS = [| EmergencyS |]
7661058
7671059
7681060-- | Lift a location into an Exp.
@@ -781,11 +1073,15 @@ liftLoc (Loc a b c (d1, d2) (e1, e2)) = [|Loc
7811073-- fill the 'Maybe Loc' gap in 'logF' of this module, and relies on implicit
7821074-- callstacks when available (GHC > 7.8).
7831075#if MIN_VERSION_base(4, 8, 0)
784−getLoc :: (?loc :: CallStack) => Maybe Loc
785−getLoc = case getCallStack ?loc of
1076+getLoc :: HasCallStack => Maybe Loc
1077+getLoc = case getCallStack callStack of
7861078 [] -> Nothing
787− xs -> Just . toLoc . last $ xs
1079+ xs -> Just . toLoc . head $ filter filterKatip xs
7881080 where
1081+ filterKatip :: (String, SrcLoc) -> Bool
1082+ filterKatip (_, srcloc) = not $
1083+ "katip-" `isPrefixOf` srcLocPackage srcloc
1084+
7891085 toLoc :: (String, SrcLoc) -> Loc
7901086 toLoc (_, l) = Loc {
7911087 loc_filename = srcLocFile l
@@ -816,7 +1112,7 @@ logT = [| \ a ns sev msg -> logItem a ns (Just $(getLocTH)) sev msg |]
8161112
8171113
8181114-------------------------------------------------------------------------------
819−-- | 'Loc'-tagged logging using implicit-callstacks when available.
1115+-- | 'Loc'-tagged logging using 'GHC.Stack' when available.
8201116--
8211117-- This function does not require template-haskell as it
8221118-- automatically uses <https://hackage.haskell.org/package/base-4.8.2.0/docs/GHC-Stack.html#v:getCallStack implicit-callstacks>
@@ -827,7 +1123,7 @@ logT = [| \ a ns sev msg -> logItem a ns (Just $(getLocTH)) sev msg |]
8271123--
8281124-- @logLoc obj mempty InfoS "Hello world"@
8291125#if MIN_VERSION_base(4, 8, 0)
830−logLoc :: (Applicative m, LogItem a, Katip m, ?loc :: CallStack)
1126+logLoc :: (Applicative m, LogItem a, Katip m, HasCallStack)
8311127#else
8321128logLoc :: (Applicative m, LogItem a, Katip m)
8331129#endif
katip/src/Katip/Monadic.hs+241−80
@@ -33,30 +33,38 @@ module Katip.Monadic
3333 , runKatipContextT
3434 , katipAddNamespace
3535 , katipAddContext
36− , katipNoLogging
3736 , KatipContextTState(..)
37+ , NoLoggingT (..)
38+ , askLoggerIO
3839 ) where
3940
4041
4142-------------------------------------------------------------------------------
4243import Control.Applicative
44+import Control.Exception.Safe
4345import Control.Monad.Base
44−import Control.Monad.Catch
4546import Control.Monad.Error.Class
47+#if MIN_VERSION_base(4, 9, 0)
48+import qualified Control.Monad.Fail as MF
49+#endif
4650import Control.Monad.IO.Class
51+import Control.Monad.IO.Unlift
4752import Control.Monad.Reader
4853import Control.Monad.State
4954import Control.Monad.Trans.Control
50−import Control.Monad.Trans.Either (EitherT)
51−import Control.Monad.Trans.Except (ExceptT)
52−import Control.Monad.Trans.Identity (IdentityT)
53−import Control.Monad.Trans.List (ListT)
54−import Control.Monad.Trans.Maybe (MaybeT)
55−import Control.Monad.Trans.Resource (ResourceT)
56−import Control.Monad.Trans.RWS (RWST)
57−import qualified Control.Monad.Trans.RWS.Strict as Strict (RWST)
58−import qualified Control.Monad.Trans.State.Strict as Strict (StateT)
59−import qualified Control.Monad.Trans.Writer.Strict as Strict (WriterT)
55+#if !MIN_VERSION_either(4, 5, 0)
56+import Control.Monad.Trans.Either (EitherT, mapEitherT)
57+#endif
58+import Control.Monad.Trans.Except (ExceptT, mapExceptT)
59+import Control.Monad.Trans.Identity (IdentityT, mapIdentityT)
60+import Control.Monad.Trans.Maybe (MaybeT, mapMaybeT)
61+import Control.Monad.Trans.Resource (MonadResource,
62+ ResourceT, transResourceT)
63+import Control.Monad.Trans.RWS (RWST, mapRWST)
64+import qualified Control.Monad.Trans.RWS.Strict as Strict (RWST, mapRWST)
65+import qualified Control.Monad.Trans.State.Strict as Strict (StateT, mapStateT)
66+import qualified Control.Monad.Trans.Writer.Strict as Strict (WriterT,
67+ mapWriterT)
6068import Control.Monad.Writer hiding ((<>))
6169import Data.Aeson
6270import qualified Data.Foldable as FT
@@ -64,6 +72,12 @@ import qualified Data.HashMap.Strict as HM
6472import Data.Semigroup as Semi
6573import Data.Sequence as Seq
6674import Data.Text (Text)
75+#if MIN_VERSION_base(4, 8, 0)
76+#if !MIN_VERSION_base(4, 9, 0)
77+import GHC.SrcLoc
78+#endif
79+import GHC.Stack
80+#endif
6781import Language.Haskell.TH
6882-------------------------------------------------------------------------------
6983import Katip.Core
@@ -120,46 +134,118 @@ liftPayload = LogContexts . Seq.singleton . AnyLogContext
120134
121135
122136-------------------------------------------------------------------------------
123−-- | A monadic context that has an inherant way to get logging
124−-- context and namespace. Examples include a web application monad or
125−-- database monad.
137+-- | A monadic context that has an inherant way to get logging context
138+-- and namespace. Examples include a web application monad or database
139+-- monad. The @local@ variants are just like @local@ from Reader and
140+-- indeed you can easily implement them with @local@ if you happen to
141+-- be using a Reader in your monad. These give us 'katipAddNamespace'
142+-- and 'katipAddContext' that works with *any* 'KatipContext', as
143+-- opposed to making users have to implement these functions on their
144+-- own in each app.
126145class Katip m => KatipContext m where
127146 getKatipContext :: m LogContexts
128− getKatipNamespace :: m Namespace
129−
130−--TODO: is this INLINABLE?
131−#define TRANS(T) \
132− instance (KatipContext m, Katip (T m)) => KatipContext (T m) where \
133− getKatipContext = lift getKatipContext; \
134− getKatipNamespace = lift getKatipNamespace
135−
136−#define TRANS_CTX(CTX, T) \
137− instance (CTX, KatipContext m, Katip (T m)) => KatipContext (T m) where \
138− getKatipContext = lift getKatipContext; \
139− getKatipNamespace = lift getKatipNamespace
140−
141−TRANS(IdentityT)
142−TRANS(MaybeT)
143−TRANS(EitherT e)
144−TRANS(ListT)
145−TRANS(ReaderT r)
146−TRANS(ResourceT)
147−TRANS(Strict.StateT s)
148−TRANS(StateT s)
149−TRANS(ExceptT s)
150−TRANS_CTX(Monoid w, Strict.WriterT w)
151−TRANS_CTX(Monoid w, WriterT w)
152−TRANS_CTX(Monoid w, Strict.RWST r w s)
153−TRANS_CTX(Monoid w, RWST r w s)
147+ -- | Temporarily modify the current context for the duration of the
148+ -- supplied monad. Used in 'katipAddContext'
149+ localKatipContext :: (LogContexts -> LogContexts) -> m a -> m a
150+ getKatipNamespace :: m Namespace
151+ -- | Temporarily modify the current namespace for the duration of the
152+ -- supplied monad. Used in 'katipAddNamespace'
153+ localKatipNamespace :: (Namespace -> Namespace) -> m a -> m a
154+
155+instance (KatipContext m, Katip (IdentityT m)) => KatipContext (IdentityT m) where
156+ getKatipContext = lift getKatipContext
157+ localKatipContext = mapIdentityT . localKatipContext
158+ getKatipNamespace = lift getKatipNamespace
159+ localKatipNamespace = mapIdentityT . localKatipNamespace
160+
161+
162+instance (KatipContext m, Katip (MaybeT m)) => KatipContext (MaybeT m) where
163+ getKatipContext = lift getKatipContext
164+ localKatipContext = mapMaybeT . localKatipContext
165+ getKatipNamespace = lift getKatipNamespace
166+ localKatipNamespace = mapMaybeT . localKatipNamespace
167+
168+
169+#if !MIN_VERSION_either(4, 5, 0)
170+instance (KatipContext m, Katip (EitherT e m)) => KatipContext (EitherT e m) where
171+ getKatipContext = lift getKatipContext
172+ localKatipContext = mapEitherT . localKatipContext
173+ getKatipNamespace = lift getKatipNamespace
174+ localKatipNamespace = mapEitherT . localKatipNamespace
175+#endif
176+
177+
178+instance (KatipContext m, Katip (ReaderT r m)) => KatipContext (ReaderT r m) where
179+ getKatipContext = lift getKatipContext
180+ localKatipContext = mapReaderT . localKatipContext
181+ getKatipNamespace = lift getKatipNamespace
182+ localKatipNamespace = mapReaderT . localKatipNamespace
183+
184+
185+instance (KatipContext m, Katip (ResourceT m)) => KatipContext (ResourceT m) where
186+ getKatipContext = lift getKatipContext
187+ localKatipContext = transResourceT . localKatipContext
188+ getKatipNamespace = lift getKatipNamespace
189+ localKatipNamespace = transResourceT . localKatipNamespace
190+
191+
192+instance (KatipContext m, Katip (Strict.StateT s m)) => KatipContext (Strict.StateT s m) where
193+ getKatipContext = lift getKatipContext
194+ localKatipContext = Strict.mapStateT . localKatipContext
195+ getKatipNamespace = lift getKatipNamespace
196+ localKatipNamespace = Strict.mapStateT . localKatipNamespace
197+
198+
199+instance (KatipContext m, Katip (StateT s m)) => KatipContext (StateT s m) where
200+ getKatipContext = lift getKatipContext
201+ localKatipContext = mapStateT . localKatipContext
202+ getKatipNamespace = lift getKatipNamespace
203+ localKatipNamespace = mapStateT . localKatipNamespace
204+
205+
206+instance (KatipContext m, Katip (ExceptT e m)) => KatipContext (ExceptT e m) where
207+ getKatipContext = lift getKatipContext
208+ localKatipContext = mapExceptT . localKatipContext
209+ getKatipNamespace = lift getKatipNamespace
210+ localKatipNamespace = mapExceptT . localKatipNamespace
211+
212+
213+instance (Monoid w, KatipContext m, Katip (Strict.WriterT w m)) => KatipContext (Strict.WriterT w m) where
214+ getKatipContext = lift getKatipContext
215+ localKatipContext = Strict.mapWriterT . localKatipContext
216+ getKatipNamespace = lift getKatipNamespace
217+ localKatipNamespace = Strict.mapWriterT . localKatipNamespace
218+
219+
220+instance (Monoid w, KatipContext m, Katip (WriterT w m)) => KatipContext (WriterT w m) where
221+ getKatipContext = lift getKatipContext
222+ localKatipContext = mapWriterT . localKatipContext
223+ getKatipNamespace = lift getKatipNamespace
224+ localKatipNamespace = mapWriterT . localKatipNamespace
225+
226+
227+instance (Monoid w, KatipContext m, Katip (Strict.RWST r w s m)) => KatipContext (Strict.RWST r w s m) where
228+ getKatipContext = lift getKatipContext
229+ localKatipContext = Strict.mapRWST . localKatipContext
230+ getKatipNamespace = lift getKatipNamespace
231+ localKatipNamespace = Strict.mapRWST . localKatipNamespace
232+
233+
234+instance (Monoid w, KatipContext m, Katip (RWST r w s m)) => KatipContext (RWST r w s m) where
235+ getKatipContext = lift getKatipContext
236+ localKatipContext = mapRWST . localKatipContext
237+ getKatipNamespace = lift getKatipNamespace
238+ localKatipNamespace = mapRWST . localKatipNamespace
239+
154240
155241deriving instance (Monad m, KatipContext m) => KatipContext (KatipT m)
156242
157243-------------------------------------------------------------------------------
158244-- | Log with everything, including a source code location. This is
159245-- very low level and you typically can use 'logTM' in its
160−-- place. Automaticallysupplies payload and namespace.
246+-- place. Automatically supplies payload and namespace.
161247logItemM
162− :: (Applicative m, KatipContext m)
248+ :: (Applicative m, KatipContext m, HasCallStack)
163249 => Maybe Loc
164250 -> Severity
165251 -> LogStr
@@ -170,7 +256,6 @@ logItemM loc sev msg = do
170256 logItem ctx ns loc sev msg
171257
172258
173−
174259-------------------------------------------------------------------------------
175260-- | Log with full context, but without any code
176261-- location. Automatically supplies payload and namespace.
@@ -197,20 +282,21 @@ logTM = [| logItemM (Just $(getLocTH)) |]
197282
198283
199284-------------------------------------------------------------------------------
200−-- | 'Loc'-tagged logging when using template-haskell. Automatically
201−-- supplies payload and namespace.
285+-- | 'Loc'-tagged logging when using 'GHC.Stack.getCallStack' implicit-callstacks>.
286+-- Automatically supplies payload and namespace.
202287--
203288-- Same consideration as `logLoc` applies.
204289--
205−-- This function does not require template-haskell as it
206−-- automatically uses <https://hackage.haskell.org/package/base-4.8.2.0/docs/GHC-Stack.html#v:getCallStack implicit-callstacks>
207−-- when the code is compiled using GHC > 7.8. Using an older version of the
208−-- compiler will result in the emission of a log line without any location information,
209−-- so be aware of it. Users using GHC <= 7.8 may want to use the template-haskell function
290+-- Location will be logged from the module that invokes 'logLocM' so
291+-- be aware that wrapping 'logLocM' will make location reporting useless.
292+--
293+-- This function does not require template-haskell. Using GHC <= 7.8 will result
294+-- in the emission of a log line without any location information.
295+-- Users using GHC <= 7.8 may want to use the template-haskell function
210296-- `logTM` for maximum compatibility.
211297--
212298-- @logLocM InfoS "Hello world"@
213−logLocM :: (Applicative m, KatipContext m)
299+logLocM :: (Applicative m, KatipContext m, HasCallStack)
214300 => Severity
215301 -> LogStr
216302 -> m ()
@@ -227,18 +313,19 @@ logExceptionM
227313 => m a -- ^ Main action to run
228314 -> Severity -- ^ Severity
229315 -> m a
230−logExceptionM action sev = action `catchAll` \e -> f e >> throwM e
316+logExceptionM action sev = action `catchAny` \e -> f e >> throwM e
231317 where
232318 f e = logFM sev (msg e)
233− msg e = ls ("An exception has occured: " :: Text) Semi.<> showLS e
319+ msg e = ls ("An exception has occurred: " :: Text) Semi.<> showLS e
234320
235321
236322-------------------------------------------------------------------------------
237323-- | Provides a simple transformer that defines a 'KatipContext'
238−-- instance for a fixed namespace and context. You will typically only
239−-- use this if you are forced to run in IO but still want to have your
240−-- log context. This is the slightly more powerful version of KatipT
241−-- in that it provides KatipContext instead of just Katip. For instance:
324+-- instance for a fixed namespace and context. Just like 'KatipT', you
325+-- should use this if you prefer an explicit transformer stack and
326+-- don't want to (or cannot) define 'KatipContext' for your monad
327+-- . This is the slightly more powerful version of KatipT in that it
328+-- provides KatipContext instead of just Katip. For instance:
242329--
243330-- @
244331-- threadWithLogging = do
@@ -263,6 +350,7 @@ newtype KatipContextT m a = KatipContextT {
263350 , MonadWriter w
264351 , MonadError e
265352 , MonadPlus
353+ , MonadResource
266354 , Alternative
267355 , MonadFix
268356 , MonadTrans
@@ -299,12 +387,31 @@ instance (MonadReader r m) => MonadReader r (KatipContextT m) where
299387
300388instance (MonadIO m) => Katip (KatipContextT m) where
301389 getLogEnv = KatipContextT $ ReaderT $ \lts -> return (ltsLogEnv lts)
390+ localLogEnv f (KatipContextT m) = KatipContextT (local (\s -> s { ltsLogEnv = f (ltsLogEnv s)}) m)
302391
303392
304393instance (MonadIO m) => KatipContext (KatipContextT m) where
305394 getKatipContext = KatipContextT $ ReaderT $ \lts -> return (ltsContext lts)
395+ localKatipContext f (KatipContextT m) = KatipContextT $ local (\s -> s { ltsContext = f (ltsContext s)}) m
306396 getKatipNamespace = KatipContextT $ ReaderT $ \lts -> return (ltsNamespace lts)
397+ localKatipNamespace f (KatipContextT m) = KatipContextT $ local (\s -> s { ltsNamespace = f (ltsNamespace s)}) m
398+
399+instance MonadUnliftIO m => MonadUnliftIO (KatipContextT m) where
400+#if MIN_VERSION_unliftio_core(0, 2, 0)
401+ withRunInIO inner = KatipContextT $ ReaderT $ \lts -> withRunInIO $ \run ->
402+ inner (run . runKatipContextT (ltsLogEnv lts) (ltsContext lts) (ltsNamespace lts))
403+#else
404+ askUnliftIO = KatipContextT $
405+ withUnliftIO $ \u ->
406+ pure (UnliftIO (unliftIO u . unKatipContextT))
407+#endif
408+
307409
410+#if MIN_VERSION_base(4, 9, 0)
411+instance MF.MonadFail m => MF.MonadFail (KatipContextT m) where
412+ fail msg = lift (MF.fail msg)
413+ {-# INLINE fail #-}
414+#endif
308415
309416-------------------------------------------------------------------------------
310417runKatipContextT :: (LogItem c) => LogEnv -> c -> Namespace -> KatipContextT m a -> m a
@@ -316,14 +423,13 @@ runKatipContextT le ctx ns = flip runReaderT lts . unKatipContextT
316423-------------------------------------------------------------------------------
317424-- | Append a namespace segment to the current namespace for the given
318425-- monadic action, then restore the previous state
319−-- afterwards.
426+-- afterwards. Works with anything implementing KatipContext.
320427katipAddNamespace
321− :: (Monad m)
428+ :: (KatipContext m)
322429 => Namespace
323− -> KatipContextT m a
324− -> KatipContextT m a
325−katipAddNamespace ns (KatipContextT f) =
326− KatipContextT (local (\r -> r { ltsNamespace = (ltsNamespace r) <> ns}) f)
430+ -> m a
431+ -> m a
432+katipAddNamespace ns = localKatipNamespace (<> ns)
327433
328434
329435-------------------------------------------------------------------------------
@@ -336,25 +442,80 @@ katipAddNamespace ns (KatipContextT f) =
336442-- added. If you instead roll your own recursion and you're recursing
337443-- in the action you provide, you'll instead accumulate tons of
338444-- redundant contexts and even if they all merge on log, they are
339−-- stored in a sequence and will leak memory.
445+-- stored in a sequence and will leak memory. Works with anything
446+-- implementing KatipContext.
340447katipAddContext
341448 :: ( LogItem i
342− , Monad m
449+ , KatipContext m
343450 )
344451 => i
345− -> KatipContextT m a
346− -> KatipContextT m a
347−katipAddContext i (KatipContextT f) =
348− KatipContextT (local (\r -> r { ltsContext = (ltsContext r) <> liftPayload i}) f)
452+ -> m a
453+ -> m a
454+katipAddContext i = localKatipContext (<> (liftPayload i))
349455
456+newtype NoLoggingT m a = NoLoggingT {
457+ runNoLoggingT :: m a
458+ } deriving ( Functor
459+ , Applicative
460+ , Monad
461+ , MonadIO
462+ , MonadThrow
463+ , MonadCatch
464+ , MonadMask
465+ , MonadBase b
466+ , MonadState s
467+ , MonadWriter w
468+ , MonadError e
469+ , MonadPlus
470+ , Alternative
471+ , MonadFix
472+ , MonadReader r
473+ )
350474
351−-------------------------------------------------------------------------------
352−-- | Disable all scribes for the given monadic action, then restore
353−-- them afterwards.
354−katipNoLogging
355− :: ( Monad m
356− )
357− => KatipContextT m a
358− -> KatipContextT m a
359−katipNoLogging (KatipContextT f) =
360− KatipContextT (local (\r -> r { ltsLogEnv = clearScribes (ltsLogEnv r)}) f)
475+instance MonadTrans NoLoggingT where
476+ lift = NoLoggingT
477+
478+instance MonadTransControl NoLoggingT where
479+ type StT NoLoggingT a = a
480+ liftWith f = NoLoggingT $ f runNoLoggingT
481+ restoreT = NoLoggingT
482+ {-# INLINE liftWith #-}
483+ {-# INLINE restoreT #-}
484+
485+instance MonadBaseControl b m => MonadBaseControl b (NoLoggingT m) where
486+ type StM (NoLoggingT m) a = StM m a
487+ liftBaseWith f = NoLoggingT $
488+ liftBaseWith $ \runInBase ->
489+ f $ runInBase . runNoLoggingT
490+ restoreM = NoLoggingT . restoreM
491+
492+instance MonadUnliftIO m => MonadUnliftIO (NoLoggingT m) where
493+#if MIN_VERSION_unliftio_core(0, 2, 0)
494+ withRunInIO inner = NoLoggingT $ withRunInIO $ \run ->
495+ inner (run . runNoLoggingT)
496+#else
497+ askUnliftIO = NoLoggingT $
498+ withUnliftIO $ \u ->
499+ pure (UnliftIO (unliftIO u . runNoLoggingT))
500+#endif
501+
502+
503+instance MonadIO m => Katip (NoLoggingT m) where
504+ getLogEnv = liftIO (initLogEnv "NoLoggingT" "no-logging")
505+ localLogEnv = const id
506+
507+instance MonadIO m => KatipContext (NoLoggingT m) where
508+ getKatipContext = pure mempty
509+ localKatipContext = const id
510+ getKatipNamespace = pure mempty
511+ localKatipNamespace = const id
512+
513+
514+-- | Convenience function for when you have to integrate with a third
515+-- party API that takes a generic logging function as an argument.
516+askLoggerIO :: (Applicative m, KatipContext m) => m (Severity -> LogStr -> IO ())
517+askLoggerIO = do
518+ ctx <- getKatipContext
519+ ns <- getKatipNamespace
520+ logEnv <- getLogEnv
521+ pure (\sev msg -> runKatipT logEnv $ logF ctx ns sev msg)
katip/src/Katip/Scribes/Handle.hs+115−73
@@ -1,30 +1,28 @@
1−{-# LANGUAGE RecordWildCards #-}
2−
31module Katip.Scribes.Handle where
42
53-------------------------------------------------------------------------------
6−import Control.Applicative as A
7−import Control.Monad
8−import Control.Exception (onException)
4+import Control.Applicative as A
5+import Control.Concurrent
6+import Control.Exception (bracket_, finally)
97import Data.Aeson
10−import qualified Data.HashMap.Strict as HM
11−import Data.Monoid
12−import Data.Text (Text)
8+import Data.Text.Lazy (toStrict)
9+import Data.Text.Lazy.Encoding (decodeUtf8)
10+import qualified Data.HashMap.Strict as HM
11+import Data.Monoid as M
12+import Data.Scientific as S
13+import Data.Text (Text)
1314import Data.Text.Lazy.Builder
14−import Data.Text.Lazy.IO as T
15+import Data.Text.Lazy.IO as T
1516import System.IO
16−import System.IO.Unsafe (unsafePerformIO)
17−import qualified Control.Concurrent.Chan.Unagi.Bounded as U
18−import Control.Concurrent.Async
1917-------------------------------------------------------------------------------
2018import Katip.Core
21−import Katip.Format.Time (formatAsLogTime)
19+import Katip.Format.Time (formatAsLogTime)
2220-------------------------------------------------------------------------------
2321
2422
2523-------------------------------------------------------------------------------
2624brackets :: Builder -> Builder
27−brackets m = fromText "[" <> m <> fromText "]"
25+brackets m = fromText "[" M.<> m <> fromText "]"
2826
2927
3028-------------------------------------------------------------------------------
@@ -36,10 +34,13 @@ getKeys verb a = concat (renderPair A.<$> HM.toList (payloadObject verb a))
3634 case v of
3735 Object o -> concat [renderPair (k <> "." <> k', v') | (k', v') <- HM.toList o]
3836 String t -> [fromText (k <> ":" <> t)]
39− Number n -> [fromText (k <> ":") <> fromString (show n)]
37+ Number n -> [fromText (k <> ":") <> fromString (formatNumber n)]
4038 Bool b -> [fromText (k <> ":") <> fromString (show b)]
4139 Null -> [fromText (k <> ":null")]
4240 _ -> mempty -- Can't think of a sensible way to handle arrays
41+ formatNumber :: Scientific -> String
42+ formatNumber n =
43+ formatScientific Generic (if isFloating n then Nothing else Just 0) n
4344
4445
4546-------------------------------------------------------------------------------
@@ -48,72 +49,119 @@ data ColorStrategy
4849 -- ^ Whether to use color control chars in log output
4950 | ColorIfTerminal
5051 -- ^ Color if output is a terminal
51−
52−-------------------------------------------------------------------------------
53−data WorkerCmd =
54− NewItem Builder
55− | PoisonPill
52+ deriving (Show, Eq)
5653
5754-------------------------------------------------------------------------------
5855-- | Logs to a file handle such as stdout, stderr, or a file. Contexts
5956-- and other information will be flattened out into bracketed
6057-- fields. For example:
6158--
62−-- > [2016-05-11 21:01:15][MyApp][Info][myhost.example.com][1724][ThreadId 1154][main:Helpers.Logging Helpers/Logging.hs:32:7] Started
63−-- > [2016-05-11 21:01:15][MyApp.confrabulation][Debug][myhost.example.com][1724][ThreadId 1154][confrab_factor:42.0][main:Helpers.Logging Helpers/Logging.hs:41:9] Confrabulating widgets, with extra namespace and context
64−-- > [2016-05-11 21:01:15][MyApp][Info][myhost.example.com][1724][ThreadId 1154][main:Helpers.Logging Helpers/Logging.hs:43:7] Namespace and context are back to normal
59+-- > [2016-05-11 21:01:15][MyApp][Info][myhost.example.com][PID 1724][ThreadId 1154][main:Helpers.Logging Helpers/Logging.hs:32:7] Started
60+-- > [2016-05-11 21:01:15][MyApp.confrabulation][Debug][myhost.example.com][PID 1724][ThreadId 1154][confrab_factor:42.0][main:Helpers.Logging Helpers/Logging.hs:41:9] Confrabulating widgets, with extra namespace and context
61+-- > [2016-05-11 21:01:15][MyApp][Info][myhost.example.com][PID 1724][ThreadId 1154][main:Helpers.Logging Helpers/Logging.hs:43:7] Namespace and context are back to normal
62+--
63+-- Returns the newly-created `Scribe`. The finalizer flushes the
64+-- handle. Handle mode is set to 'LineBuffering' automatically.
65+mkHandleScribe :: ColorStrategy -> Handle -> PermitFunc -> Verbosity -> IO Scribe
66+mkHandleScribe = mkHandleScribeWithFormatter bracketFormat
67+
68+-- | Logs to a file handle such as stdout, stderr, or a file. Takes a custom
69+-- `ItemFormatter` that can be used to format `Item` as needed.
6570--
66−-- Returns the newly-created `Scribe` together with a finaliser the user needs to run to perform resource cleanup.
67−mkHandleScribe :: ColorStrategy -> Handle -> Severity -> Verbosity -> IO (Scribe, IO ())
68−mkHandleScribe cs h sev verb = do
69− (inChan, outChan) <- U.newChan 4096
70− worker <- async $ workerLoop outChan
71− flip onException (stopWorker worker inChan) $ do
71+-- Returns the newly-created `Scribe`. The finalizer flushes the
72+-- handle. Handle mode is set to 'LineBuffering' automatically.
73+mkHandleScribeWithFormatter :: (forall a . LogItem a => ItemFormatter a)
74+ -> ColorStrategy
75+ -> Handle
76+ -> PermitFunc
77+ -> Verbosity
78+ -> IO Scribe
79+mkHandleScribeWithFormatter itemFormatter cs h permitF verb = do
7280 hSetBuffering h LineBuffering
7381 colorize <- case cs of
7482 ColorIfTerminal -> hIsTerminalDevice h
75− ColorLog b -> return b
76− let scribe = Scribe $ \i ->
77− when (permitItem sev i) $ void (U.tryWriteChan inChan (NewItem (formatItem colorize verb i)))
78− return (scribe, stopWorker worker inChan)
83+ ColorLog b -> return b
84+ lock <- newMVar ()
85+ let logger i@Item{..} = do
86+ bracket_ (takeMVar lock) (putMVar lock ()) $
87+ T.hPutStrLn h $ toLazyText $ itemFormatter colorize verb i
88+ return $ Scribe logger (hFlush h) permitF
89+
90+
91+-------------------------------------------------------------------------------
92+-- | A specialization of 'mkHandleScribe' that takes a 'FilePath'
93+-- instead of a 'Handle'. It is responsible for opening the file in
94+-- 'AppendMode' and will close the file handle on
95+-- 'closeScribe'/'closeScribes'. Does not do log coloring. Sets handle
96+-- to 'LineBuffering' mode.
97+mkFileScribe :: FilePath -> PermitFunc -> Verbosity -> IO Scribe
98+mkFileScribe f permitF verb = do
99+ h <- openFile f AppendMode
100+ Scribe logger finalizer permit <- mkHandleScribe (ColorLog False) h permitF verb
101+ return (Scribe logger (finalizer `finally` hClose h) permit)
79102
80− where
81− stopWorker :: Async () -> U.InChan WorkerCmd -> IO ()
82− stopWorker worker inChan = do
83− U.writeChan inChan PoisonPill
84− void $ waitCatch worker
85−
86− workerLoop :: U.OutChan WorkerCmd -> IO ()
87− workerLoop outChan = do
88− newCmd <- U.readChan outChan
89− case newCmd of
90− NewItem b -> do
91− T.hPutStrLn h $ toLazyText b
92− workerLoop outChan
93− PoisonPill -> return ()
94103
95104-------------------------------------------------------------------------------
96−formatItem :: LogItem a => Bool -> Verbosity -> Item a -> Builder
97−formatItem withColor verb Item{..} =
105+-- | A custom ItemFormatter for logging `Item`s. Takes a `Bool` indicating
106+-- whether to colorize the output, `Verbosity` of output, and an `Item` to
107+-- format.
108+--
109+-- See `bracketFormat` and `jsonFormat` for examples.
110+type ItemFormatter a = Bool -> Verbosity -> Item a -> Builder
111+
112+
113+formatItem :: LogItem a => ItemFormatter a
114+formatItem = bracketFormat
115+{-# DEPRECATED formatItem "Use bracketFormat instead" #-}
116+
117+-- | A traditional 'bracketed' log format. Contexts and other information will
118+-- be flattened out into bracketed fields. For example:
119+--
120+-- > [2016-05-11 21:01:15][MyApp][Info][myhost.example.com][PID 1724][ThreadId 1154][main:Helpers.Logging Helpers/Logging.hs:32:7] Started
121+-- > [2016-05-11 21:01:15][MyApp.confrabulation][Debug][myhost.example.com][PID 1724][ThreadId 1154][confrab_factor:42.0][main:Helpers.Logging Helpers/Logging.hs:41:9] Confrabulating widgets, with extra namespace and context
122+-- > [2016-05-11 21:01:15][MyApp][Info][myhost.example.com][PID 1724][ThreadId 1154][main:Helpers.Logging Helpers/Logging.hs:43:7] Namespace and context are back to normal
123+bracketFormat :: LogItem a => ItemFormatter a
124+bracketFormat withColor verb Item{..} =
98125 brackets nowStr <>
99126 brackets (mconcat $ map fromText $ intercalateNs _itemNamespace) <>
100127 brackets (fromText (renderSeverity' _itemSeverity)) <>
101128 brackets (fromString _itemHost) <>
102− brackets (fromString (show _itemProcess)) <>
103− brackets (fromText (getThreadIdText _itemThread)) <>
129+ brackets ("PID " <> fromString (show _itemProcess)) <>
130+ brackets ("ThreadId " <> fromText (getThreadIdText _itemThread)) <>
104131 mconcat ks <>
105132 maybe mempty (brackets . fromString . locationToString) _itemLoc <>
106133 fromText " " <> (unLogStr _itemMessage)
107134 where
108135 nowStr = fromText (formatAsLogTime _itemTime)
109136 ks = map brackets $ getKeys verb _itemPayload
110− renderSeverity' s = case s of
111− EmergencyS -> red $ renderSeverity s
112− AlertS -> red $ renderSeverity s
113− CriticalS -> red $ renderSeverity s
114− ErrorS -> red $ renderSeverity s
115− WarningS -> yellow $ renderSeverity s
116− _ -> renderSeverity s
137+ renderSeverity' severity =
138+ colorBySeverity withColor severity (renderSeverity severity)
139+
140+-- | Logs items as JSON. This can be useful in circumstances where you already
141+-- have infrastructure that is expecting JSON to be logged to a standard stream
142+-- or file. For example:
143+--
144+-- > {"at":"2018-10-02T21:50:30.4523848Z","env":"production","ns":["MyApp"],"data":{},"app":["MyApp"],"msg":"Started","pid":"10456","loc":{"loc_col":9,"loc_pkg":"main","loc_mod":"Helpers.Logging","loc_fn":"Helpers\\Logging.hs","loc_ln":44},"host":"myhost.example.com","sev":"Info","thread":"ThreadId 139"}
145+-- > {"at":"2018-10-02T21:50:30.4523848Z","env":"production","ns":["MyApp","confrabulation"],"data":{"confrab_factor":42},"app":["MyApp"],"msg":"Confrabulating widgets, with extra namespace and context","pid":"10456","loc":{"loc_col":11,"loc_pkg":"main","loc_mod":"Helpers.Logging","loc_fn":"Helpers\\Logging.hs","loc_ln":53},"host":"myhost.example.com","sev":"Debug","thread":"ThreadId 139"}
146+-- > {"at":"2018-10-02T21:50:30.4523848Z","env":"production","ns":["MyApp"],"data":{},"app":["MyApp"],"msg":"Namespace and context are back to normal","pid":"10456","loc":{"loc_col":9,"loc_pkg":"main","loc_mod":"Helpers.Logging","loc_fn":"Helpers\\Logging.hs","loc_ln":55},"host":"myhost.example.com","sev":"Info","thread":"ThreadId 139"}
147+jsonFormat :: LogItem a => ItemFormatter a
148+jsonFormat withColor verb i =
149+ fromText $
150+ colorBySeverity withColor (_itemSeverity i) $
151+ toStrict $ decodeUtf8 $ encode $ itemJson verb i
152+
153+-- | Color a text message based on `Severity`. `ErrorS` and more severe errors
154+-- are colored red, `WarningS` is colored yellow, and all other messages are
155+-- rendered in the default color.
156+colorBySeverity :: Bool -> Severity -> Text -> Text
157+colorBySeverity withColor severity msg = case severity of
158+ EmergencyS -> red msg
159+ AlertS -> red msg
160+ CriticalS -> red msg
161+ ErrorS -> red msg
162+ WarningS -> yellow msg
163+ _ -> msg
164+ where
117165 red = colorize "31"
118166 yellow = colorize "33"
119167 colorize c s
@@ -121,18 +169,12 @@ formatItem withColor verb Item{..} =
121169 | otherwise = s
122170
123171
124−-------------------------------------------------------------------------------
125−-- | An implicit environment to enable logging directly ouf of the IO monad.
126−-- Be careful as this LogEnv won't perform any resource cleanup for you.
127−_ioLogEnv :: LogEnv
128−_ioLogEnv = unsafePerformIO $ do
129− le <- initLogEnv "io" "io"
130− (lh, _) <- mkHandleScribe ColorIfTerminal stdout DebugS V3
131− return $ registerScribe "stdout" lh le
132−{-# NOINLINE _ioLogEnv #-}
133−
134−
135−-- -------------------------------------------------------------------------------
136−-- -- | A default IO instance to make prototype development easy. User
137−-- -- your own 'Monad' for production.
138−-- instance Katip IO where getLogEnv = return _ioLogEnv
172+-- | Provides a simple log environment with 1 scribe going to
173+-- stdout. This is a decent example of how to build a LogEnv and is
174+-- best for scripts that just need a quick, reasonable set up to log
175+-- to stdout.
176+ioLogEnv :: PermitFunc -> Verbosity -> IO LogEnv
177+ioLogEnv permit verb = do
178+ le <- initLogEnv "io" "io"
179+ lh <- mkHandleScribe ColorIfTerminal stdout permit verb
180+ registerScribe "stdout" lh defaultScribeSettings le
katip/test/Katip/Tests.hs+168−7
@@ -1,9 +1,11 @@
11{-# LANGUAGE CPP #-}
2+{-# LANGUAGE DeriveDataTypeable #-}
23{-# LANGUAGE GeneralizedNewtypeDeriving #-}
34{-# LANGUAGE OverloadedStrings #-}
45{-# LANGUAGE RecordWildCards #-}
56{-# LANGUAGE ScopedTypeVariables #-}
67{-# LANGUAGE StandaloneDeriving #-}
8+{-# LANGUAGE TemplateHaskell #-}
79{-# OPTIONS_GHC -fno-warn-orphans #-}
810module Katip.Tests
911 ( tests
@@ -11,15 +13,19 @@ module Katip.Tests
1113
1214
1315-------------------------------------------------------------------------------
14−import Control.Applicative as A
16+import Control.Applicative as A
17+import Control.Concurrent.STM
18+import Control.Exception.Safe
1519import Data.Aeson
1620import qualified Data.HashMap.Strict as HM
17−import Data.Monoid
21+import qualified Data.Map.Strict as M
22+import Data.Monoid as Monoid
1823import Data.Text (Text)
1924import qualified Data.Text.Lazy.Builder as B
2025import Data.Time
2126import Data.Time.Clock.POSIX
2227import Language.Haskell.TH
28+import Lens.Micro (ASetter, (&), (.~))
2329import System.Posix.Types
2430import Test.QuickCheck.Instances ()
2531import Test.Tasty
@@ -36,6 +42,9 @@ tests = testGroup "Katip"
3642 [
3743 testProperty "JSON cycle Item" $ \(i :: Item ()) ->
3844 prop_json_cycle i
45+ , testProperty "JSON cycle verbosity" $ \(v :: Verbosity) ->
46+ prop_json_cycle v
47+ , eqItemTests
3948 , testProperty "renderSeverity/textToSeverity cycle" $ \sev ->
4049 textToSeverity(renderSeverity sev) === Just sev
4150 , testProperty "processIDToText/textToProcessID cycle" $ \pid ->
@@ -43,6 +52,9 @@ tests = testGroup "Katip"
4352 , testCase "processIDToText is just the number" $ do
4453 processIDToText 123 @?= "123"
4554 , logContextsTests
55+ , closeScribeTests
56+ , closeScribesTests
57+ , loggingTests
4658 ]
4759
4860
@@ -65,6 +77,128 @@ logContextsTests = testGroup "logContexts"
6577 ]
6678
6779
80+-------------------------------------------------------------------------------
81+closeScribeTests :: TestTree
82+closeScribeTests = testGroup "closeScribe"
83+ [ testCase "removes the specified scribe" $ do
84+ (scr, finalizerCalled) <- trivialScribe
85+ le <- registerScribe "trivial" scr defaultScribeSettings =<< initLogEnv "ns" "test"
86+ le' <- closeScribe "trivial" le
87+ closed <- atomically (readTVar finalizerCalled)
88+ assertBool "finalizer called" closed
89+ assertBool "should not have trivial key in scribes" (not (M.member "trivial" (_logEnvScribes le')))
90+ , testCase "does nothing for a missing scribe" $ do
91+ le <- initLogEnv "ns" "test"
92+ le' <- closeScribe "nah" le
93+ assertBool "does not affect scribes" (M.null (_logEnvScribes le'))
94+ , testCase "re-throws finalizer exceptions" $ do
95+ (scr, finalizerCalled) <- brokenScribe 1
96+ le <- registerScribe "broken" scr defaultScribeSettings =<< initLogEnv "ns" "test"
97+ res <- try (closeScribe "broken" le)
98+ closed <- atomically (readTVar finalizerCalled)
99+ assertBool "finalizer called" closed
100+ case res of
101+ Left (ScribeBroken scribeNo) -> scribeNo @?= 1
102+ Right _ -> assertFailure "Expected to throw a ScribeBroken but it did not"
103+ ]
104+
105+
106+-------------------------------------------------------------------------------
107+loggingTests :: TestTree
108+loggingTests = testGroup "logging"
109+ [ testCase "logs in order with contexts, namespaces, etc" $ do
110+ (le, items) <- recordingEnv
111+ runKatipContextT le (sl "base_context" (42 :: Int)) "base_namespace" $ do
112+ $(logTM) InfoS "basic log"
113+ katipNoLogging $ do
114+ $(logTM) InfoS "you cant see this"
115+ katipAddNamespace "added" $ do
116+ katipAddNamespace "namespace" $ do
117+ $(logTM) InfoS "with namespaces"
118+ katipAddContext (sl "additional" True) $ do
119+ $(logTM) InfoS "additional context"
120+ _ <- closeScribes le
121+ summary <- fmap summarizeItem <$> readTVarIO items
122+ let baseCtx = HM.singleton "base_context" (Number 42)
123+ let baseNS = "tests" <> "base_namespace"
124+ summary @?=
125+ [ (baseNS, baseCtx, "basic log")
126+ , (baseNS <> "added" <> "namespace", baseCtx, "with namespaces")
127+ , (baseNS <> "added", HM.insert "additional" (Bool True) baseCtx, "additional context")
128+ ]
129+ , testCase "Katip.Monadic.logLocM" $ do
130+ (le, items) <- recordingEnv
131+ runKatipContextT le (sl "base_context" (42 :: Int)) "base_namespace" $ logLocM InfoS "basic log"
132+ _ <- closeScribes le
133+ loggedItems <- readTVarIO items
134+ let loc = _itemLoc (head loggedItems)
135+ fmap loc_module loc @?= Just "Katip.Tests"
136+ ]
137+ where
138+ recordingEnv :: IO (LogEnv, TVar [Item Object])
139+ recordingEnv = do
140+ items <- newTVarIO Monoid.mempty
141+ let scribe = Scribe
142+ { liPush = \i -> atomically (modifyTVar' items (<> [toObject <$> i]))
143+ , scribeFinalizer = return ()
144+ , scribePermitItem = permitItem DebugS
145+ }
146+ le1 <- initLogEnv "tests" "test"
147+ le2 <- registerScribe "recorder" scribe defaultScribeSettings le1
148+ return (le2, items)
149+ summarizeItem :: Item Object -> (Namespace, Object, LogStr)
150+ summarizeItem Item {..} = (_itemNamespace, _itemPayload, _itemMessage)
151+
152+
153+-------------------------------------------------------------------------------
154+trivialScribe :: IO (Scribe, TVar Bool)
155+trivialScribe = do
156+ finalizerCalled <- newTVarIO False
157+ let finalizer = atomically (writeTVar finalizerCalled True)
158+ return (Scribe (const (return ())) finalizer (permitItem DebugS), finalizerCalled)
159+
160+
161+-------------------------------------------------------------------------------
162+brokenScribe :: Int -> IO (Scribe, TVar Bool)
163+brokenScribe scribeNum = do
164+ finalizerCalled <- newTVarIO False
165+ let finalizer = do
166+ atomically (writeTVar finalizerCalled True)
167+ throw (ScribeBroken scribeNum)
168+ return (Scribe (const (return ())) finalizer (permitItem DebugS), finalizerCalled)
169+
170+
171+-------------------------------------------------------------------------------
172+data BrokenScribeError = ScribeBroken Int deriving (Show, Typeable)
173+
174+
175+instance Exception BrokenScribeError
176+
177+-------------------------------------------------------------------------------
178+closeScribesTests :: TestTree
179+closeScribesTests = testGroup "closeScribes"
180+ [ testCase "returns a log env with no scribes" $ do
181+ (scr, finalizerCalled) <- trivialScribe
182+ le <- registerScribe "trivial" scr defaultScribeSettings =<< initLogEnv "ns" "test"
183+ le' <- closeScribes le
184+ closed <- atomically (readTVar finalizerCalled)
185+ assertBool "finalizer called" closed
186+ assertBool "remvoes all scribes" (M.null (_logEnvScribes le'))
187+ , testCase "throws the first exception encountered after closing all scribes" $ do
188+ (scr1, finalizerCalled1) <- brokenScribe 1
189+ (scr2, finalizerCalled2) <- brokenScribe 2
190+ le <- registerScribe "broken2" scr2 defaultScribeSettings =<< registerScribe "broken1" scr1 defaultScribeSettings =<< initLogEnv "ns" "test"
191+ res <- try (closeScribes le)
192+ closed1 <- atomically (readTVar finalizerCalled1)
193+ assertBool "finalizer 1 called" closed1
194+ closed2 <- atomically (readTVar finalizerCalled2)
195+ assertBool "finalizer 2 called" closed2
196+ case res of
197+ Left (ScribeBroken scribeNo) -> scribeNo @?= 1
198+ Right _ -> assertFailure "Expected to throw a ScribeBroken but it did not"
199+ ]
200+
201+
68202-------------------------------------------------------------------------------
69203data ConservativePayload = ConservativePayload {
70204 oftenShown :: Text
@@ -123,11 +257,6 @@ deriving instance Arbitrary Namespace
123257deriving instance Arbitrary Environment
124258deriving instance Arbitrary ThreadIdText
125259deriving instance Arbitrary CPid
126−#if !MIN_VERSION_base(4, 8, 0)
127−deriving instance Eq Loc
128−#endif
129−deriving instance Eq LogStr
130−deriving instance (Eq a) => Eq (Item a)
131260
132261
133262-------------------------------------------------------------------------------
@@ -140,6 +269,10 @@ instance Arbitrary Loc where
140269 return $ Loc f p m s s
141270
142271
272+-------------------------------------------------------------------------------
273+instance Arbitrary Verbosity where
274+ arbitrary = oneof $ map pure [V0, V1, V2, V3]
275+
143276-------------------------------------------------------------------------------
144277instance Arbitrary Severity where
145278 arbitrary = oneof $ map pure [ DebugS
@@ -156,3 +289,31 @@ instance Arbitrary Severity where
156289-------------------------------------------------------------------------------
157290instance Arbitrary LogStr where
158291 arbitrary = LogStr . B.fromText <$> arbitrary
292+
293+-------------------------------------------------------------------------------
294+-- Somewhat test whether all fields are taken into account in `==`
295+
296+#if !MIN_VERSION_template_haskell(2, 10, 0)
297+-- `testProperty` requires these instances
298+deriving instance Eq Loc
299+deriving instance Show Loc
300+#endif
301+
302+eqItemTests :: TestTree
303+eqItemTests = testGroup "Eq Item"
304+ [ testProperty "itemApp" $ prop_field itemApp
305+ , testProperty "itemEnv" $ prop_field itemEnv
306+ , testProperty "itemSeverity" $ prop_field itemSeverity
307+ , testProperty "itemThread" $ prop_field itemThread
308+ , testProperty "itemHost" $ prop_field itemHost
309+ , testProperty "itemProcess" $ prop_field itemProcess
310+ , testProperty "itemPayload" $ prop_field itemPayload
311+ , testProperty "itemMessage" $ prop_field itemMessage
312+ , testProperty "itemTime" $ prop_field itemTime
313+ , testProperty "itemNamespace" $ prop_field itemNamespace
314+ , testProperty "itemLoc" $ prop_field itemLoc
315+ ]
316+ where
317+ prop_field :: Eq a => ASetter (Item ()) (Item ()) a a -> Item () -> a -> a -> Bool
318+ prop_field field item f1 f2 =
319+ ((item & field .~ f1) == (item & field .~ f2)) == (f1 == f2)
katip/test/Katip/Tests/Scribes/Handle-json.goldennew file+38
@@ -0,0 +1,38 @@
1+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Debug","thread":"1337"}
2+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
3+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Notice","thread":"1337"}
4+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Warning","thread":"1337"}
5+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Error","thread":"1337"}
6+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Critical","thread":"1337"}
7+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Alert","thread":"1337"}
8+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Emergency","thread":"1337"}
9+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"0"}
10+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1"}
11+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
12+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"2147483647"}
13+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
14+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"www.example.com","sev":"Info","thread":"1337"}
15+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"127.0.0.1","sev":"Info","thread":"1337"}
16+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"0","loc":null,"host":"example","sev":"Info","thread":"1337"}
17+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"1","loc":null,"host":"example","sev":"Info","thread":"1337"}
18+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"1337","loc":null,"host":"example","sev":"Info","thread":"1337"}
19+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"2147483647","loc":null,"host":"example","sev":"Info","thread":"1337"}
20+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
21+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message\nwith newline","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
22+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":" a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
23+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"сообщение","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
24+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"哈囉世界","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
25+{"at":"2000-01-01T00:00:00Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
26+{"at":"2123-12-31T23:59:59.999999999999Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
27+{"at":"2016-10-10T01:01:05Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
28+{"at":"2100-12-31T12:59:10.1Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
29+{"at":"1982-01-01T12:30:00.000000000001Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
30+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
31+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo","bar"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
32+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["фу","бар"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
33+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["with\nnewline"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
34+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
35+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":{"loc_col":1,"loc_pkg":"main","loc_mod":"Some.Module","loc_fn":"path/Some/Module.hs","loc_ln":30},"host":"example","sev":"Info","thread":"1337"}
36+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"note":{"deep":"some note"}},"app":["app"],"msg":"message","pid":"7331","loc":{"loc_col":9000,"loc_pkg":"main","loc_mod":"Some.Module","loc_fn":"путь/Some/Module.hs","loc_ln":3000},"host":"example","sev":"Info","thread":"1337"}
37+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"sub":null,"list":[],"text":"","num":0,"float":0},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
38+{"at":"2016-06-12T12:34:56Z","env":"production","ns":["foo"],"data":{"sub":{"note":{"deep":"some note"}},"list":["one","two","three"],"text":"note","num":10,"float":5.5},"app":["app"],"msg":"message","pid":"7331","loc":null,"host":"example","sev":"Info","thread":"1337"}
katip/test/Katip/Tests/Scribes/Handle-text.golden+38−38
@@ -1,40 +1,40 @@
1−[2016-06-12 12:34:56][foo][Debug][example][7331][1337][note.deep:some note] message
2−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] message
3−[2016-06-12 12:34:56][foo][Notice][example][7331][1337][note.deep:some note] message
4−[2016-06-12 12:34:56][foo][Warning][example][7331][1337][note.deep:some note] message
5−[2016-06-12 12:34:56][foo][Error][example][7331][1337][note.deep:some note] message
6−[2016-06-12 12:34:56][foo][Critical][example][7331][1337][note.deep:some note] message
7−[2016-06-12 12:34:56][foo][Alert][example][7331][1337][note.deep:some note] message
8−[2016-06-12 12:34:56][foo][Emergency][example][7331][1337][note.deep:some note] message
9−[2016-06-12 12:34:56][foo][Info][example][7331][0][note.deep:some note] message
10−[2016-06-12 12:34:56][foo][Info][example][7331][1][note.deep:some note] message
11−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] message
12−[2016-06-12 12:34:56][foo][Info][example][7331][2147483647][note.deep:some note] message
13−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] message
14−[2016-06-12 12:34:56][foo][Info][www.example.com][7331][1337][note.deep:some note] message
15−[2016-06-12 12:34:56][foo][Info][127.0.0.1][7331][1337][note.deep:some note] message
16−[2016-06-12 12:34:56][foo][Info][example][0][1337][note.deep:some note] message
17−[2016-06-12 12:34:56][foo][Info][example][1][1337][note.deep:some note] message
18−[2016-06-12 12:34:56][foo][Info][example][1337][1337][note.deep:some note] message
19−[2016-06-12 12:34:56][foo][Info][example][2147483647][1337][note.deep:some note] message
20−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] message
21−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] message
1+[2016-06-12 12:34:56][foo][Debug][example][PID 7331][ThreadId 1337][note.deep:some note] message
2+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
3+[2016-06-12 12:34:56][foo][Notice][example][PID 7331][ThreadId 1337][note.deep:some note] message
4+[2016-06-12 12:34:56][foo][Warning][example][PID 7331][ThreadId 1337][note.deep:some note] message
5+[2016-06-12 12:34:56][foo][Error][example][PID 7331][ThreadId 1337][note.deep:some note] message
6+[2016-06-12 12:34:56][foo][Critical][example][PID 7331][ThreadId 1337][note.deep:some note] message
7+[2016-06-12 12:34:56][foo][Alert][example][PID 7331][ThreadId 1337][note.deep:some note] message
8+[2016-06-12 12:34:56][foo][Emergency][example][PID 7331][ThreadId 1337][note.deep:some note] message
9+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 0][note.deep:some note] message
10+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1][note.deep:some note] message
11+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
12+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 2147483647][note.deep:some note] message
13+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
14+[2016-06-12 12:34:56][foo][Info][www.example.com][PID 7331][ThreadId 1337][note.deep:some note] message
15+[2016-06-12 12:34:56][foo][Info][127.0.0.1][PID 7331][ThreadId 1337][note.deep:some note] message
16+[2016-06-12 12:34:56][foo][Info][example][PID 0][ThreadId 1337][note.deep:some note] message
17+[2016-06-12 12:34:56][foo][Info][example][PID 1][ThreadId 1337][note.deep:some note] message
18+[2016-06-12 12:34:56][foo][Info][example][PID 1337][ThreadId 1337][note.deep:some note] message
19+[2016-06-12 12:34:56][foo][Info][example][PID 2147483647][ThreadId 1337][note.deep:some note] message
20+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
21+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
2222with newline
23−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message
24−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] сообщение
25−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] 哈囉世界
26−[2000-01-01 00:00:00][foo][Info][example][7331][1337][note.deep:some note] message
27−[2123-12-31 23:59:59][foo][Info][example][7331][1337][note.deep:some note] message
28−[2016-10-10 01:01:05][foo][Info][example][7331][1337][note.deep:some note] message
29−[2100-12-31 12:59:10][foo][Info][example][7331][1337][note.deep:some note] message
30−[1982-01-01 12:30:00][foo][Info][example][7331][1337][note.deep:some note] message
31−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] message
32−[2016-06-12 12:34:56][foo.bar][Info][example][7331][1337][note.deep:some note] message
33−[2016-06-12 12:34:56][фу.бар][Info][example][7331][1337][note.deep:some note] message
23+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message a really long message
24+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] сообщение
25+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] 哈囉世界
26+[2000-01-01 00:00:00][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
27+[2123-12-31 23:59:59][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
28+[2016-10-10 01:01:05][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
29+[2100-12-31 12:59:10][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
30+[1982-01-01 12:30:00][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
31+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
32+[2016-06-12 12:34:56][foo.bar][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
33+[2016-06-12 12:34:56][фу.бар][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
3434[2016-06-12 12:34:56][with
35−newline][Info][example][7331][1337][note.deep:some note] message
36−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note] message
37−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note][main:Some.Module path/Some/Module.hs:30:1] message
38−[2016-06-12 12:34:56][foo][Info][example][7331][1337][note.deep:some note][main:Some.Module путь/Some/Module.hs:3000:9000] message
39−[2016-06-12 12:34:56][foo][Info][example][7331][1337][sub:null][text:][num:0.0][float:0.0] message
40−[2016-06-12 12:34:56][foo][Info][example][7331][1337][sub.note.deep:some note][text:note][num:10.0][float:5.5] message
35+newline][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
36+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note] message
37+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note][main:Some.Module path/Some/Module.hs:30:1] message
38+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][note.deep:some note][main:Some.Module путь/Some/Module.hs:3000:9000] message
39+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][sub:null][text:][num:0][float:0] message
40+[2016-06-12 12:34:56][foo][Info][example][PID 7331][ThreadId 1337][sub.note.deep:some note][text:note][num:10][float:5.5] message
katip/test/Katip/Tests/Scribes/Handle.hs+45−13
@@ -1,4 +1,5 @@
11{-# LANGUAGE OverloadedStrings #-}
2+{-# LANGUAGE RankNTypes #-}
23module Katip.Tests.Scribes.Handle
34 ( tests
45 ) where
@@ -6,9 +7,9 @@ module Katip.Tests.Scribes.Handle
67-------------------------------------------------------------------------------
78import Control.Monad
89import Data.Aeson
9−import qualified Data.ByteString.Lazy as BL
1010import qualified Data.ByteString.Char8 as B
11−import Data.Monoid
11+import qualified Data.ByteString.Lazy as BL
12+import Data.Monoid as M
1213import Data.Text (Text)
1314import qualified Data.Text as T
1415import qualified Data.Text.Encoding as T
@@ -25,7 +26,6 @@ import Test.Tasty.HUnit
2526import Text.Regex.TDFA
2627-------------------------------------------------------------------------------
2728import Katip
28−import Katip.Scribes.Handle
2929-------------------------------------------------------------------------------
3030
3131
@@ -36,15 +36,29 @@ tests = testGroup "Katip.Scribes.Handle"
3636 (path, h, fin, le) <- setupScribe
3737 runKatipT le $ logItem dummyLogItem "test" Nothing InfoS "test message"
3838 fin
39+ runKatipT le $ logItem dummyLogItem "test" Nothing InfoS "wont make it in"
3940 hClose h
4041 res <- readFile path
41− let pat = "\\[[[:digit:]]{4}-[[:digit:]]{2}-[[:digit:]]{2} [[:digit:]]{2}:[[:digit:]]{2}:[[:digit:]]{2}\\]\\[katip-test.test\\]\\[Info\\]\\[.+\\]\\[[[:digit:]]+\\]\\[ThreadId [[:digit:]]+\\]\\[note.deep:some note\\] test message" :: String
42+ let pat = "\\[[[:digit:]]{4}-[[:digit:]]{2}-[[:digit:]]{2} [[:digit:]]{2}:[[:digit:]]{2}:[[:digit:]]{2}\\]\\[katip-test.test\\]\\[Info\\]\\[.+\\]\\[[PID [:digit:]]+\\]\\[ThreadId [[:digit:]]+\\]\\[note.deep:some note\\] test message" :: String
4243 let matches = res =~ pat
43− assertBool (res <> " did not match") matches
44+ assertBool (show res M.<> " did not match") matches
45+ , withResource setupFile (const (return ())) $ \setupScribe -> testCase "logs correct data to a file" $ do
46+ (path, fin, le) <- setupScribe
47+ runKatipT le $ logItem dummyLogItem "test" Nothing InfoS "test message"
48+ fin
49+ runKatipT le $ logItem dummyLogItem "test" Nothing InfoS "wont make it in"
50+ res <- readFile path
51+ let pat = "\\[[[:digit:]]{4}-[[:digit:]]{2}-[[:digit:]]{2} [[:digit:]]{2}:[[:digit:]]{2}:[[:digit:]]{2}\\]\\[katip-test.test\\]\\[Info\\]\\[.+\\]\\[[PID [:digit:]]+\\]\\[ThreadId [[:digit:]]+\\]\\[note.deep:some note\\] test message" :: String
52+ let matches = res =~ pat
53+ assertBool (show res <> " did not match") matches
54+ , withResource setupTempFile teardownTempFile $ \setupFn ->
55+ goldenVsString "Text-golden"
56+ "test/Katip/Tests/Scribes/Handle-text.golden"
57+ (setupFn >>= writeTextLog)
4458 , withResource setupTempFile teardownTempFile $ \setupFn ->
45− goldenVsString "Text-golden"
46− "test/Katip/Tests/Scribes/Handle-text.golden"
47− (setupFn >>= writeTextLog)
59+ goldenVsString "Json-golden"
60+ "test/Katip/Tests/Scribes/Handle-json.golden"
61+ (setupFn >>= writeJsonLog)
4862 ]
4963
5064
@@ -78,18 +92,30 @@ setup :: IO (FilePath, Handle, IO (), LogEnv)
7892setup = do
7993 tempDir <- getTemporaryDirectory
8094 (fp, h) <- openTempFile tempDir "katip.log"
81− (s, finaliser) <- mkHandleScribe (ColorLog False) h DebugS V3
95+ s <- mkHandleScribe (ColorLog False) h (permitItem DebugS) V3
8296 le <- initLogEnv "katip-test" "test"
83− return (fp, h, finaliser, registerScribe "handle" s le)
97+ le' <- registerScribe "handle" s defaultScribeSettings le
98+ return (fp, h, void (closeScribes le'), le')
8499
85100
86101-------------------------------------------------------------------------------
87−teardown :: (FilePath, Handle, IO (), LogEnv) -> IO ()
102+teardown :: (a, Handle, b, c) -> IO ()
88103teardown (_, h, _, _) = do
89104 chk <- hIsOpen h
90105 when chk $ hClose h
91106
92107
108+-------------------------------------------------------------------------------
109+setupFile :: IO (FilePath, IO (), LogEnv)
110+setupFile = do
111+ tempDir <- getTemporaryDirectory
112+ (fp, h) <- openTempFile tempDir "katip.log"
113+ hClose h
114+ s <- mkFileScribe fp (permitItem DebugS) V3
115+ le <- initLogEnv "katip-test" "test"
116+ le' <- registerScribe "handle" s defaultScribeSettings le
117+ return (fp, void (closeScribes le'), le')
118+
93119
94120-- Following code tests Handle scribe output against a golden file.
95121-- This test will fail on non utf8 locales because golden file is in utf-8.
@@ -212,14 +238,20 @@ mkUTCTime y mt d h mn s = UTCTime day dt
212238
213239-------------------------------------------------------------------------------
214240writeTextLog :: (FilePath, Handle) -> IO (BL.ByteString)
215−writeTextLog (path, h) = do
241+writeTextLog = writeFormattedLog bracketFormat
242+
243+writeJsonLog :: (FilePath, Handle) -> IO (BL.ByteString)
244+writeJsonLog = writeFormattedLog jsonFormat
245+
246+writeFormattedLog :: (forall a . LogItem a => ItemFormatter a) -> (FilePath, Handle) -> IO (BL.ByteString)
247+writeFormattedLog format (path, h) = do
216248 mapM_ (put . formatOne) genItems
217249 mapM_ (put . formatOne) genTypedItems
218250 hClose h
219251 BL.readFile path
220252 where
221253 formatOne :: LogItem a => Item a -> Text
222− formatOne = LT.toStrict . LT.toLazyText . formatItem False V3
254+ formatOne = LT.toStrict . LT.toLazyText . format False V3
223255 put = B.hPutStrLn h . T.encodeUtf8
224256
225257setupTempFile :: IO (FilePath, Handle)
stack-lts-2.yamldeleted−32
@@ -1,32 +0,0 @@
1−resolver: lts-2.22
2−packages:
3− - katip
4− - katip-elasticsearch
5−extra-deps:
6− - bloodhound-0.12.0.0
7− - string-conv-0.1.2
8− - aeson-0.11.1.0
9− - http-client-0.5.4
10− - fail-4.9.0.0
11− - tagged-0.8.3
12− - uuid-1.3.12
13− - attoparsec-0.13.1.0
14− - retry-0.7.4.2
15− - tasty-0.11.0.4
16− - time-locale-compat-0.1.1.1
17− - cryptonite-0.20
18− - microlens-0.4.7.0
19− - microlens-th-0.4.1.0
20− - time-1.5.0.1
21− - memory-0.13
22− - rng-utils-0.2.1
23− - lens-aeson-1.0.0.5
24− - unagi-chan-0.4.0.0
25− - atomic-primops-0.8.0.4
26−flags:
27− katip:
28− lib-Werror: true
29− katip-elasticsearch:
30− lib-Werror: true
31− time-locale-compat:
32− old-locale: false
stack-lts-3.yamldeleted−22
@@ -1,22 +0,0 @@
1−resolver: lts-3.22
2−packages:
3− - katip
4− - katip-elasticsearch
5−extra-deps:
6− - bloodhound-0.12.0.0
7− - string-conv-0.1.2
8− - aeson-0.11.1.0
9− - http-client-0.5.4
10− - fail-4.9.0.0
11− - tagged-0.8.3
12− - uuid-1.3.12
13− - attoparsec-0.13.1.0
14− - retry-0.7.4.2
15− - tasty-0.11.0.4
16− - rng-utils-0.2.1
17− - unagi-chan-0.4.0.0
18−flags:
19− katip:
20− lib-Werror: true
21− katip-elasticsearch:
22− lib-Werror: true
stack-lts-4.yamldeleted−19
@@ -1,19 +0,0 @@
1−resolver: lts-4.2
2−packages:
3− - katip
4− - katip-elasticsearch
5−extra-deps:
6− - bloodhound-0.12.0.0
7− - string-conv-0.1.2
8− - aeson-0.11.1.0
9− - http-client-0.5.4
10− - fail-4.9.0.0
11− - tagged-0.8.3
12− - uuid-1.3.12
13− - rng-utils-0.2.1
14− - unagi-chan-0.4.0.0
15−flags:
16− katip:
17− lib-Werror: true
18− katip-elasticsearch:
19− lib-Werror: true
stack-lts-5.yamldeleted−16
@@ -1,16 +0,0 @@
1−resolver: lts-5.18
2−packages:
3− - katip
4− - katip-elasticsearch
5−extra-deps:
6− - bloodhound-0.12.0.0
7− - string-conv-0.1.2
8− - aeson-0.11.1.0
9− - http-client-0.5.4
10− - rng-utils-0.2.1
11− - unagi-chan-0.4.0.0
12−flags:
13− katip:
14− lib-Werror: true
15− katip-elasticsearch:
16− lib-Werror: true
stack.yaml+11−2
@@ -1,11 +1,20 @@
1−resolver: lts-7.9
1+resolver: lts-16.18
22packages:
33 - katip
44 - katip-elasticsearch
5+ - katip-datadog
6+ - katip-logzio
57extra-deps:
6− - unagi-chan-0.4.0.0
8+ # ghc 8.8 support
9+ - github: wireapp/bloodhound
10+ commit: b409f52b518f20a4c20651b5893c31b7b85cb9b1
11+allow-newer: true
712flags:
813 katip:
914 lib-Werror: true
1015 katip-elasticsearch:
1116 lib-Werror: true
17+ katip-datadog:
18+ lib-Werror: true
19+ katip-logzio:
20+ lib-Werror: true