git.iko.soy/typeable/nixpkgs
on master help sign in
brave: test rpath in installCheck

This check helps with making sure that we provide all the required shared libraries to brave. If something is missing, the command will get ENOENT, otherwise it should terminate normally.

commit051389eb1875b088be07aa5e9a15c19e88f9ba07 authorLouis Bettens <louis@bettens.info> dateThu 31 Dec 2020, 17:42 (6 years ago) parent37c9f30
1 file changed+6
pkgs/applications/networking/browsers/brave/default.nix+6
pkgs/applications/networking/browsers/brave/default.nix+6
@@ -98,6 +98,7 @@ stdenv.mkDerivation rec {
9898 dontConfigure = true;
9999 dontBuild = true;
100100 dontPatchELF = true;
101+ doInstallCheck = true;
101102
102103 nativeBuildInputs = [ dpkg wrapGAppsHook ];
103104
@@ -147,6 +148,11 @@ stdenv.mkDerivation rec {
147148 ln -sf ${xdg_utils}/bin/xdg-mime $out/opt/brave.com/brave/xdg-mime
148149 '';
149150
151+ installCheckPhase = ''
152+ # Bypass upstream wrapper which suppresses errors
153+ $out/opt/brave.com/brave/brave --version
154+ '';
155+
150156 passthru.updateScript = ./update.sh;
151157
152158 meta = with stdenv.lib; {