git.iko.soy/typeable/nixpkgs
on master help sign in
pythonPackages.greenlet: 0.4.17 -> 1.0.0

Update greenlet to 1.0.0. meinheld declares a dependency to greenlet <0.5, but according to [1] and [2], there are no API or ABI changes leading to greenlet-1.0.0, so it seems reasonable to drop the strict requirement. This commit uses substituteInPlace to patch setup.py since no upstream commit has landed in the main branch yet. Morehover, quoting [2]: Prior to greenlet 1.0 there were no semantic meanings attached to greenlet versions — API and ABI regularly changed from 0.4.x to 0.4.x+1, so their current pin doesn't make much sense anyway. nix-review reveals few broken packages that are also broken in master. [1] https://github.com/mopemope/meinheld/pull/123 [2] https://github.com/benoitc/gunicorn/issues/2541#issuecomment-800353993

commit14cae0af316bb561e432697f04c6bc61af9d5459 authorLancelot SIX <lsix@lancelotsix.com> dateMon 5 Apr 2021, 21:48 (6 years ago) parent448e3c4
2 files changed+8−7
pkgs/development/python-modules/greenlet/default.nix+2−7 pkgs/development/python-modules/meinheld/default.nix+6
pkgs/development/python-modules/greenlet/default.nix+2−7
@@ -8,21 +8,16 @@
88
99buildPythonPackage rec {
1010 pname = "greenlet";
11− version = "0.4.17";
11+ version = "1.0.0";
1212 disabled = isPyPy; # builtin for pypy
1313
1414 src = fetchPypi {
1515 inherit pname version;
16− sha256 = "0swdhrcq13bdszv3yz5645gi4ijbzmmhxpb6whcfg3d7d5f87n21";
16+ sha256 = "1y6wbg9yhm9dw6m768n4yslp56h85pnxkk3drz6icn15g6f1d7ki";
1717 };
1818
1919 propagatedBuildInputs = [ six ];
2020
21− # see https://github.com/python-greenlet/greenlet/issues/85
22− preCheck = ''
23− rm tests/test_leaks.py
24− '';
25−
2621 meta = {
2722 homepage = "https://pypi.python.org/pypi/greenlet";
2823 description = "Module for lightweight in-process concurrent programming";
pkgs/development/python-modules/meinheld/default.nix+6
@@ -9,6 +9,12 @@ buildPythonPackage rec {
99 sha256 = "008c76937ac2117cc69e032dc69cea9f85fc605de9bac1417f447c41c16a56d6";
1010 };
1111
12+ patchPhase = ''
13+ # Allow greenlet-1.0.0.
14+ # See https://github.com/mopemope/meinheld/pull/123
15+ substituteInPlace setup.py --replace "greenlet>=0.4.5,<0.5" "greenlet>=0.4.5,<2.0.0"
16+ '';
17+
1218 propagatedBuildInputs = [ greenlet ];
1319
1420 # No tests