git.iko.soy/typeable/nixpkgs
on master help sign in
firefox: place alsaLib in lib search patch

libcubeb has dlopened libraries for awhile now. In nixpkgs there was support for the PulseAudio backend doing this, however the ALSA backend support was missed and caused issue #79310 (no sound with ALSA). This gives ALSA users the ability to hear sound once again.

commit57ea265674f8e23ede036bd72cf437da7e110c4d authorS. Nordin Abouzahra <abouzahra.9@wright.edu> dateWed 21 Oct 2020, 21:47 (6 years ago) parent4506d17
2 files changed+4−1
pkgs/applications/networking/browsers/firefox/common.nix+1 pkgs/applications/networking/browsers/firefox/wrapper.nix+3−1
pkgs/applications/networking/browsers/firefox/common.nix+1
@@ -333,6 +333,7 @@ buildStdenv.mkDerivation ({
333333 version = ffversion;
334334 isFirefox3Like = true;
335335 gtk = gtk2;
336+ inherit alsaSupport;
336337 inherit nspr;
337338 inherit ffmpegSupport;
338339 inherit gssSupport;
pkgs/applications/networking/browsers/firefox/wrapper.nix+3−1
@@ -2,7 +2,7 @@
22
33## various stuff that can be plugged in
44, flashplayer, hal-flash
5−, ffmpeg, xorg, libpulseaudio, libcanberra-gtk2, libglvnd
5+, ffmpeg, xorg, alsaLib, libpulseaudio, libcanberra-gtk2, libglvnd
66, gnome3/*.gnome-shell*/
77, browserpass, chrome-gnome-shell, uget-integrator, plasma-browser-integration, bukubrow
88, tridactyl-native
@@ -39,6 +39,7 @@ let
3939 enableAdobeFlash = cfg.enableAdobeFlash or false;
4040 ffmpegSupport = browser.ffmpegSupport or false;
4141 gssSupport = browser.gssSupport or false;
42+ alsaSupport = browser.alsaSupport or false;
4243
4344 plugins =
4445 let
@@ -76,6 +77,7 @@ let
7677 (with xorg; [ stdenv.cc libX11 libXxf86dga libXxf86vm libXext libXt alsaLib zlib ])
7778 ++ lib.optional (enableAdobeFlash && (cfg.enableAdobeFlashDRM or false)) hal-flash
7879 ++ lib.optional (config.pulseaudio or true) libpulseaudio
80+ ++ lib.optional alsaSupport alsaLib
7981 ++ pkcs11Modules;
8082 gtk_modules = [ libcanberra-gtk2 ];
8183