@@ -1,8 +1,14 @@
1−{ lib, fetchurl, buildPythonApplication, pbr, requests, setuptools }:
1+{ lib
2+, fetchurl
3+, buildPythonApplication
4+, pbr
5+, requests
6+, setuptools
7+}:
28
39buildPythonApplication rec {
410 pname = "git-review";
5− version = "2.0.0";
11+ version = "2.1.0";
612
713 # Manually set version because prb wants to get it from the git
814 # upstream repository (and we are installing from tarball instead)
@@ -10,17 +16,28 @@ buildPythonApplication rec {
1016
1117 src = fetchurl {
1218 url = "https://opendev.org/opendev/${pname}/archive/${version}.tar.gz";
13− sha256 = "0dkyd5g2xmvsa114is3cd9qmki3hi6c06wjnra0f4xq3aqm0ajnj";
19+ hash = "sha256-3A1T+/iXhNeMS2Aww5jISoiNExdv9N9/kwyATSuwVTE=";
1420 };
1521
16− propagatedBuildInputs = [ pbr requests setuptools ];
22+ nativeBuildInputs = [
23+ pbr
24+ ];
1725
18− # Don't do tests because they require gerrit which is not packaged
26+ propagatedBuildInputs = [
27+ requests
28+ setuptools # implicit dependency, used to get package version through pkg_resources
29+ ];
30+
31+ # Don't run tests because they pull in external dependencies
32+ # (a specific build of gerrit + maven plugins), and I haven't figured
33+ # out how to work around this yet.
1934 doCheck = false;
2035
36+ pythonImportsCheck = [ "git_review" ];
37+
2138 meta = with lib; {
22− homepage = "https://opendev.org/opendev/git-review";
2339 description = "Tool to submit code to Gerrit";
40+ homepage = "https://opendev.org/opendev/git-review";
2441 license = licenses.asl20;
2542 maintainers = with maintainers; [ metadark ];
2643 };