git.iko.soy/typeable/nixpkgs
on master help sign in
nixos/buildbot-master: support reporters, migrate away from status

Since Buildbot 0.9.0, status targets were deprecated and ignored. There's a very small line on startup explaining that, and status simply isn't reported. Avoid others the same headaches, and do it right in the NixOS module. As there might have been changes in the way reporters are organized, and configuration might need to be migrated remove the old option, and not just provide an alias.

commit9538bf50aebdfb235932568f2e7b385e4571fef2 authorFlorian Klink <flokli@flokli.de> dateThu 18 Jun 2020, 16:32 (6 years ago) parent9d0c3ff
1 file changed+7−3
nixos/modules/services/continuous-integration/buildbot/master.nix+7−3
nixos/modules/services/continuous-integration/buildbot/master.nix+7−3
@@ -25,7 +25,7 @@ let
2525 change_source = [ ${concatStringsSep "," cfg.changeSource} ],
2626 schedulers = [ ${concatStringsSep "," cfg.schedulers} ],
2727 builders = [ ${concatStringsSep "," cfg.builders} ],
28− status = [ ${concatStringsSep "," cfg.status} ],
28+ services = [ ${concatStringsSep "," cfg.reporters} ],
2929 )
3030 for step in [ ${concatStringsSep "," cfg.factorySteps} ]:
3131 factory.addStep(step)
@@ -119,10 +119,10 @@ in {
119119 default = [ "worker.Worker('example-worker', 'pass')" ];
120120 };
121121
122− status = mkOption {
122+ reporters = mkOption {
123123 default = [];
124124 type = types.listOf types.str;
125− description = "List of status notification endpoints.";
125+ description = "List of reporter objects used to present build status to various users.";
126126 };
127127
128128 user = mkOption {
@@ -276,6 +276,10 @@ in {
276276
277277 imports = [
278278 (mkRenamedOptionModule [ "services" "buildbot-master" "bpPort" ] [ "services" "buildbot-master" "pbPort" ])
279+ (mkRemovedOptionModule [ "services" "buildbot-master" "status" ] ''
280+ Since Buildbot 0.9.0, status targets are deprecated and ignored.
281+ Review your configuration and migrate to reporters (available at services.buildbot-master.reporters).
282+ '')
279283 ];
280284
281285 meta.maintainers = with lib.maintainers; [ nand0p mic92 ];