git.iko.soy/typeable/nixpkgs
on master help sign in
beetsExternalPlugins.check: remove (broken)
commita2492b0831915aa9a24cdc4ff96b1288241898c7 authorBernardo Meurer <bernardo@meurer.org> dateMon 8 Mar 2021, 12:42 (6 years ago) parent6beb35e
4 files changed−56
pkgs/tools/audio/beets/default.nix−2 pkgs/tools/audio/beets/plugins/check-tests.patch−17 pkgs/tools/audio/beets/plugins/check.nix−36 pkgs/top-level/all-packages.nix−1
pkgs/tools/audio/beets/default.nix−2
@@ -32,7 +32,6 @@
3232
3333# External plugins
3434, enableAlternatives ? false
35−, enableCheck ? false, liboggz
3635, enableCopyArtifacts ? false
3736, enableExtraFiles ? false
3837
@@ -140,7 +139,6 @@ in pythonPackages.buildPythonApplication rec {
140139 || enableSubsonicplaylist
141140 || enableSubsonicupdate
142141 || enableAcousticbrainz) pythonPackages.requests
143− ++ lib.optional enableCheck beetsExternalPlugins.check
144142 ++ lib.optional enableConvert ffmpeg
145143 ++ lib.optional enableDiscogs pythonPackages.discogs_client
146144 ++ lib.optional enableKeyfinder keyfinder-cli
pkgs/tools/audio/beets/plugins/check-tests.patchdeleted−17
@@ -1,17 +0,0 @@
1−diff --git a/test/cli_test.py b/test/cli_test.py
2−index 26df140..2eb913c 100644
3−--- a/test/cli_test.py
4−+++ b/test/cli_test.py
5−@@ -372,12 +372,6 @@ class ToolListTest(TestHelper, TestCase):
6− self.assertIn('flac', stdout.getvalue())
7− self.assertIn('oggz-validate', stdout.getvalue())
8−
9−- def test_found_mp3val(self):
10−- shutil.copy('/bin/echo', os.path.join(self.temp_dir, 'mp3val'))
11−- with captureStdout() as stdout:
12−- beets.ui._raw_main(['check', '--list-tools'])
13−- self.assertRegexpMatches(stdout.getvalue(), r'mp3val *found')
14−-
15− def test_oggz_validate_not_found(self):
16− with captureStdout() as stdout:
17− beets.ui._raw_main(['check', '--list-tools'])
pkgs/tools/audio/beets/plugins/check.nixdeleted−36
@@ -1,36 +0,0 @@
1−{ lib, fetchFromGitHub, beets, pythonPackages, flac, liboggz, mp3val }:
2−
3−pythonPackages.buildPythonApplication rec {
4− name = "beets-check";
5− version = "0.12.0";
6−
7− src = fetchFromGitHub {
8− repo = "beets-check";
9− owner = "geigerzaehler";
10− rev = "v${version}";
11− sha256 = "0b2ijjf0gycs6b40sm33ida3sjygjiv4spb5mba52vysc7iwmnjn";
12− };
13−
14− nativeBuildInputs = [ beets ];
15− checkInputs = [ pythonPackages.nose flac liboggz mp3val ];
16− propagatedBuildInputs = [ flac liboggz mp3val ];
17−
18− # patch out broken tests
19− patches = [ ./check-tests.patch ];
20−
21− # patch out futures dependency, it is only needed for Python2 which we don't
22− # support.
23− prePatch = ''
24− sed -i "/futures/d" setup.py
25− '';
26−
27− checkPhase = "nosetests";
28−
29− meta = with lib; {
30− description = "Beets plugin to Verify and store checksums in your library";
31− homepage = "https://github.com/geigerzaehler/beets-check";
32− license = licenses.mit;
33− maintainers = with maintainers; [ lovesegfault ];
34− broken = true;
35− };
36−}
pkgs/top-level/all-packages.nix−1
@@ -3034,7 +3034,6 @@ in
30343034 };
30353035 in lib.recurseIntoAttrs {
30363036 alternatives = callPackage ../tools/audio/beets/plugins/alternatives.nix pluginArgs;
3037− check = callPackage ../tools/audio/beets/plugins/check.nix pluginArgs;
30383037 copyartifacts = callPackage ../tools/audio/beets/plugins/copyartifacts.nix pluginArgs;
30393038 extrafiles = callPackage ../tools/audio/beets/plugins/extrafiles.nix pluginArgs;
30403039 };