git.iko.soy/typeable/nixpkgs
on master help sign in
python3.pkgs.nbclient: always disable tests

Overriding a Python package in propagatedBuildInputs is a bad idea as you may end up with multiple versions in your closure. This happened, and when installing to $out the package for which the tests were run, the site packages folder was empty. Possible improvement is to add the tests as a separate derivation.

commitab0bd3aff91e64bbeab321b5a182ca24428de937 authorFrederik Rietdijk <fridh@fridh.nl> dateWed 4 May 2022, 22:00 (5 years ago) parente006a2a
2 files changed+2−3
compare with master
unifiedsplit
pkgs/development/python-modules/nbclient/default.nix+1−2 pkgs/development/python-modules/nbconvert/default.nix+1−1
pkgs/development/python-modules/nbclient/default.nix+1−2
@@ -1,7 +1,6 @@
11{ lib, buildPythonPackage, fetchPypi, pythonOlder,
22 async_generator, traitlets, nbformat, nest-asyncio, jupyter-client,
33 pytest, xmltodict, nbconvert, ipywidgets
4−, doCheck ? true
54}:
65
76buildPythonPackage rec {
@@ -14,7 +13,7 @@ buildPythonPackage rec {
1413 sha256 = "sha256-QMUsm148MfrsruafICs/U+ONfBxWPeD63enX7aD9r+g=";
1514 };
1615
17− inherit doCheck;
16+ doCheck = false; # Avoid infinite recursion
1817 checkInputs = [ pytest xmltodict nbconvert ipywidgets ];
1918 propagatedBuildInputs = [ async_generator traitlets nbformat nest-asyncio jupyter-client ];
2019
pkgs/development/python-modules/nbconvert/default.nix+1−1
@@ -47,7 +47,7 @@ buildPythonPackage rec {
4747 entrypoints bleach mistune jinja2 pygments traitlets testpath
4848 jupyter_core nbformat ipykernel pandocfilters tornado jupyter-client
4949 defusedxml beautifulsoup4
50− (nbclient.override { doCheck = false; }) # avoid infinite recursion
50+ nbclient
5151 jupyterlab-pygments
5252 ];
5353