git.iko.soy/typeable/nixpkgs
on master help sign in
nixos/slurm: fix creation of slurmdbd config file

replace cp/chmod by install to avoid security issues. See https://github.com/NixOS/nixpkgs/issues/121293

commitd07185f986c63fd062c6de0b59096365836a5679 authorMarkus Kowalewski <markus.kowalewski@gmail.com> dateSat 1 May 2021, 00:15 (6 years ago) parenta5c0b6f
1 file changed+1−3
nixos/modules/services/computing/slurm/slurm.nix+1−3
nixos/modules/services/computing/slurm/slurm.nix+1−3
@@ -403,9 +403,7 @@ in
403403 requires = [ "munged.service" "mysql.service" ];
404404
405405 preStart = ''
406− cp ${slurmdbdConf} ${configPath}
407− chmod 600 ${configPath}
408− chown ${cfg.user} ${configPath}
406+ install -m 600 -o ${cfg.user} -T ${slurmdbdConf} ${configPath}
409407 ${optionalString (cfg.dbdserver.storagePassFile != null) ''
410408 echo "StoragePass=$(cat ${cfg.dbdserver.storagePassFile})" \
411409 >> ${configPath}