nixos/keycloak: Set the postgresql database password securely
Feeding `psql` the password on the command line leaks it through the
`psql` process' `/proc/<pid>/cmdline` file. Using `echo` to put the
command in a file and then feeding `psql` the file should work around
this, since `echo` is a bash builtin and thus shouldn't spawn a new
process.
commitd6727d28e1c11887c8dad6860c0c204a21054d57
authortalyz <kim.lindberger@gmail.com>
dateTue 4 May 2021, 16:57 (6 years ago)
parentd3ad6d4
nixos/modules/services/web-apps/keycloak.nix+5−2
@@ -592,8 +592,11 @@ in
592592
593593 PSQL=${config.services.postgresql.package}/bin/psql
594594
595− db_password="$(<'${cfg.databasePasswordFile}')"
596− $PSQL -tAc "SELECT 1 FROM pg_roles WHERE rolname='keycloak'" | grep -q 1 || $PSQL -tAc "CREATE ROLE keycloak WITH LOGIN PASSWORD '$db_password' CREATEDB"
595+ create_role="$(mktemp)"
596+ trap 'rm -f "$create_role"' ERR EXIT
597+
598+ echo "CREATE ROLE keycloak WITH LOGIN PASSWORD '$(<'${cfg.databasePasswordFile}')' CREATEDB" > "$create_role"
599+ $PSQL -tAc "SELECT 1 FROM pg_roles WHERE rolname='keycloak'" | grep -q 1 || $PSQL -tA --file="$create_role"
597600 $PSQL -tAc "SELECT 1 FROM pg_database WHERE datname = 'keycloak'" | grep -q 1 || $PSQL -tAc 'CREATE DATABASE "keycloak" OWNER "keycloak"'
598601 '';
599602 };