git.iko.soy/typeable/nixpkgs
on master help sign in
suitesparse: remove custom fixDarwinDylibNames postInstall

This shadows the regular fixDarwinDylibNames function, which is a nativeBuildInput, and prevents it from converting some relative paths to absolute. According to the comment this can be removed as of 5.7.2.

commite10228defa08877593ca31d50e38a430e3cb3c64 authorGraham Bennett <graham@grahambennett.org> dateWed 2 Sep 2020, 23:55 (6 years ago) parenta2842c7
1 file changed−23
pkgs/development/libraries/science/math/suitesparse/default.nix−23
pkgs/development/libraries/science/math/suitesparse/default.nix−23
@@ -57,29 +57,6 @@ stdenv.mkDerivation rec {
5757 "library"
5858 ];
5959
60− # Likely fixed after 5.7.2
61− # https://github.com/DrTimothyAldenDavis/SuiteSparse/commit/f6daae26ee391e475e2295e77c839aa7c1a8b784
62− postInstall = stdenv.lib.optionalString stdenv.isDarwin ''
63− # The fixDarwinDylibNames in nixpkgs can't seem to fix all the libraries.
64− # We manually fix them up here.
65− fixDarwinDylibNames() {
66− local flags=()
67− local old_id
68−
69− for fn in "$@"; do
70− flags+=(-change "$PWD/lib/$(basename "$fn")" "$fn")
71− done
72−
73− for fn in "$@"; do
74− if [ -L "$fn" ]; then continue; fi
75− echo "$fn: fixing dylib"
76− install_name_tool -id "$fn" "''${flags[@]}" "$fn"
77− done
78− }
79−
80− fixDarwinDylibNames $(find "$out" -name "*.dylib")
81− '';
82−
8360 meta = with stdenv.lib; {
8461 homepage = "http://faculty.cse.tamu.edu/davis/suitesparse.html";
8562 description = "A suite of sparse matrix algorithms";