e1fad6f · typeable/nixpkgs

git.iko.soy/typeable/nixpkgs

go_1_17: enable on x86_64-darwin

Apparently this does not depend on stdenv's macOS SDK at all, and carries around its own go-specific toolchain. So this works fine as-is and doesn't need any changes in Nixpkgs to support a 10.13 deployment target.

commite1fad6fc50df6e8840a30f047a244413ec46f393 authorRyan Burns <rtburns@protonmail.com> dateThu 4 Nov 2021, 10:42 (5 years ago) parent642292c

2 files changed+4−8

compare with master

unifiedsplit

pkgs/development/compilers/go/1.17.nix−2 pkgs/top-level/all-packages.nix+4−6

pkgs/development/compilers/go/1.17.nix−2

@@ -273,7 +273,5 @@ stdenv.mkDerivation rec {

273273 license = licenses.bsd3;

274274 maintainers = teams.golang.members;

275275 platforms = platforms.linux ++ platforms.darwin;

276− # requires >=10.13 stdenv on x86_64-darwin

277− badPlatforms = [ "x86_64-darwin" ];

278276 };

279277}

pkgs/top-level/all-packages.nix+4−6

@@ -20228,9 +20228,8 @@ with pkgs;

2022820228 go = buildPackages.go_1_16;

2022920229 };

2023020230 # go_1_17 has go module changes which may not be portable

20231− # across different go versions and/or platforms,

20232− # it also requires >=10.13 stdenv on darwin which

20233− # is not currently available for x86_64-darwin

20231+ # across different go versions and/or platforms:

20232+ # https://github.com/NixOS/nixpkgs/issues/144667

2023420233 #

2023520234 # do not uncomment this without approval from the go CODEOWNERS

2023620235 #buildGo117Package = callPackage ../development/go-packages/generic {

@@ -20246,9 +20245,8 @@ with pkgs;

2024620245 go = buildPackages.go_1_16;

2024720246 };

2024820247 # go_1_17 has go module changes which may not be portable

20249− # across different go versions and/or platforms,

20250− # it also requires >=10.13 stdenv on darwin which

20251− # is not currently available for x86_64-darwin

20248+ # across different go versions and/or platforms:

20249+ # https://github.com/NixOS/nixpkgs/issues/144667

2025220250 #

2025320251 # do not uncomment this without approval from the go CODEOWNERS

2025420252 #buildGo117Module = callPackage ../development/go-modules/generic {