git.iko.soy/typeable/nixpkgs
on master help sign in
musikcube: pull pending upstream inclusion fix for ncurses-6.3

Without the fix build on ncurses-6.3 fails as: musikcube/cursespp/cursespp/curses_config.h:54:36: error: format not a string literal and no format arguments [-Werror=format-security] 54 | if (window && format) { wprintw(window, format, ##__VA_ARGS__); } | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ musikcube/src/musikcube/app/window/TransportWindow.cpp:640:5: note: in expansion of macro 'checked_wprintw' 640 | checked_wprintw(c, shuffleLabel.c_str(

commite699a0ade267e2c6308f29a30692662dcf27a291 authorSergei Trofimovich <slyich@gmail.com> dateWed 17 Nov 2021, 09:15 (5 years ago) parent5e39986
1 file changed+11
pkgs/applications/audio/musikcube/default.nix+11
pkgs/applications/audio/musikcube/default.nix+11
@@ -4,6 +4,7 @@
44, boost
55, curl
66, fetchFromGitHub
7+, fetchpatch
78, ffmpeg
89, lame
910, libev
@@ -26,6 +27,16 @@ stdenv.mkDerivation rec {
2627 sha256 = "1y00vwn1h10cfflxrm5bk271ak9gilhjycgi44hlkkhmf5bdgn35";
2728 };
2829
30+ patches = [
31+ # Fix pending upstream inclusion for ncuurses-6.3 support:
32+ # https://github.com/clangen/musikcube/pull/474
33+ (fetchpatch {
34+ name = "ncurses-6.3.patch";
35+ url = "https://github.com/clangen/musikcube/commit/1240720e27232fdb199a4da93ca6705864442026.patch";
36+ sha256 = "0bhjgwnj6d24wb1m9xz1vi1k9xk27arba1absjbcimggn54pinid";
37+ })
38+ ];
39+
2940 nativeBuildInputs = [
3041 cmake
3142 pkg-config