git.iko.soy/typeable/nixpkgs
on master help sign in
nixos/phosh: Fix unrestricted login because of insecure PAM config

The PAM config deployed would not check anything meaningful. Remove it and rely on the defaults in the security.pam module to fix login with arbitrary credentials. Resolves: #123435

commitec9cfba2d36726a008fcaa642cf97558d1a70857 authorMartin Weinelt <hexa@darmstadt.ccc.de> dateTue 18 May 2021, 05:40 (6 years ago) parent1525451
1 file changed+1−9
nixos/modules/programs/phosh.nix+1−9
nixos/modules/programs/phosh.nix+1−9
@@ -145,15 +145,7 @@ in {
145145
146146 programs.feedbackd.enable = true;
147147
148− # https://source.puri.sm/Librem5/phosh/-/issues/303
149− security.pam.services.phosh = {
150− text = ''
151− auth requisite pam_nologin.so
152− auth required pam_succeed_if.so user != root quiet_success
153− auth required pam_securetty.so
154− auth requisite pam_nologin.so
155− '';
156− };
148+ security.pam.services.phosh = {};
157149
158150 services.gnome.core-shell.enable = true;
159151 services.gnome.core-os-services.enable = true;