git.iko.soy/typeable/oauth2-proxy
on master help sign in
Add comment; update changelog
commit39d2f28a40ea7060575986dcf48fe35569103914 authorPhil Taprogge <philt@pusher.com> dateThu 9 May 2019, 10:14 (7 years ago) parent56da838
2 files changed+3
CHANGELOG.md+1 oauthproxy_test.go+2
CHANGELOG.md+1
@@ -2,6 +2,7 @@
22
33## Changes since v3.2.0
44
5+- [#146](https://github.com/pusher/oauth2_proxy/pull/146) Use full email address as `User` if the auth response did not contains a `User` field (@gargath)
56- [#144](https://github.com/pusher/oauth2_proxy/pull/144) Use GO 1.12 for ARM builds (@kskewes)
67- [#142](https://github.com/pusher/oauth2_proxy/pull/142) ARM Docker USER fix (@kskewes)
78- [#52](https://github.com/pusher/oauth2_proxy/pull/52) Logging Improvements (@MisterWil)
oauthproxy_test.go+2
@@ -334,6 +334,8 @@ func TestBasicAuthPassword(t *testing.T) {
334334 rw = httptest.NewRecorder()
335335 proxy.ServeHTTP(rw, req)
336336
337+ // The username in the basic auth credentials is expected to be equal to the email address from the
338+ // auth response, so we use the same variable here.
337339 expectedHeader := "Basic " + base64.StdEncoding.EncodeToString([]byte(emailAddress+":"+opts.BasicAuthPassword))
338340 assert.Equal(t, expectedHeader, rw.Body.String())
339341 providerServer.Close()