git.iko.soy/typeable/oauth2-proxy
on master help sign in
Clean up persistent SessionStore tests
commit42f14a41d906b3cf9a7f1bb5fa92f8978794b79f authorJoel Speed <Joel.speed@hotmail.co.uk> dateThu 16 May 2019, 17:25 (7 years ago) parenta7693cc
1 file changed+10−4
pkg/sessions/session_store_test.go+10−4
pkg/sessions/session_store_test.go+10−4
@@ -122,7 +122,7 @@ var _ = Describe("NewSessionStore", func() {
122122 Expect(err).ToNot(HaveOccurred())
123123 })
124124
125− It("sets a `set-cookie` header in the response and session to not be loadable after clear", func() {
125+ It("sets a `set-cookie` header in the response", func() {
126126 Expect(response.Header().Get("Set-Cookie")).ToNot(BeEmpty())
127127 })
128128
@@ -169,8 +169,9 @@ var _ = Describe("NewSessionStore", func() {
169169 })
170170 }
171171
172+ // The following should only be for server stores
172173 PersistentSessionStoreTests := func() {
173− Context("when Clear is called the session should not be recoverable", func() {
174+ Context("when Clear is called on a persistent store", func() {
174175 var loadedAfterClear *sessionsapi.SessionState
175176 BeforeEach(func() {
176177 req := httptest.NewRequest("GET", "http://example.com/", nil)
@@ -185,16 +186,21 @@ var _ = Describe("NewSessionStore", func() {
185186 err = ss.Clear(response, request)
186187 Expect(err).ToNot(HaveOccurred())
187188
188− // The following should only be for server stores
189189 loadReq := httptest.NewRequest("GET", "http://example.com/", nil)
190190 for _, c := range resultCookies {
191191 loadReq.AddCookie(c)
192192 }
193+
193194 loadedAfterClear, err = ss.Load(loadReq)
195+ // If we have cleared the session, Load should fail
196+ Expect(err).To(HaveOccurred())
194197 })
195198
196− It("sets a `set-cookie` header in the response and session to not be loadable after clear", func() {
199+ It("sets a `set-cookie` header in the response", func() {
197200 Expect(response.Header().Get("Set-Cookie")).ToNot(BeEmpty())
201+ })
202+
203+ It("attempting to Load returns an empty session", func() {
198204 Expect(loadedAfterClear).To(BeNil())
199205 })
200206