git.iko.soy/typeable/oauth2-proxy
on master help sign in
Merge pull request #1039 from oauth2-proxy/fix-test-logging

Ensure errors in tests are logged to the GinkgoWriter

commit465789b044ef945e656b9d1851fe57afde7bcf86 authorJoel Speed <Joel.speed@hotmail.co.uk> dateThu 11 Feb 2021, 09:48 (6 years ago) parent4fa607fb6cca79
17 files changed+20
compare with master
unifiedsplit
CHANGELOG.md+2 main_suite_test.go+1 pkg/apis/middleware/middleware_suite_test.go+1 pkg/apis/options/options_suite_test.go+1 pkg/apis/options/util/util_suite_test.go+1 pkg/authentication/basic/basic_suite_test.go+1 pkg/header/header_suite_test.go+1 pkg/middleware/middleware_suite_test.go+1 pkg/requests/requests_suite_test.go+1 pkg/requests/util/util_suite_test.go+1 pkg/sessions/cookie/session_store_test.go+2 pkg/sessions/persistence/persistence_suite_test.go+2 pkg/sessions/redis/redis_store_test.go+1 pkg/sessions/session_store_test.go+1 pkg/upstream/upstream_suite_test.go+1 pkg/validation/validation_suite_test.go+1 providers/providers_suite_test.go+1
CHANGELOG.md+2
@@ -8,6 +8,8 @@
88
99## Changes since v7.0.1
1010
11+- [#1039](https://github.com/oauth2-proxy/oauth2-proxy/pull/1039) Ensure errors in tests are logged to the GinkgoWriter (@JoelSpeed)
12+
1113# V7.0.1
1214
1315## Release Highlights
main_suite_test.go+1
@@ -10,6 +10,7 @@ import (
1010
1111func TestMainSuite(t *testing.T) {
1212 logger.SetOutput(GinkgoWriter)
13+ logger.SetErrOutput(GinkgoWriter)
1314
1415 RegisterFailHandler(Fail)
1516 RunSpecs(t, "Main Suite")
pkg/apis/middleware/middleware_suite_test.go+1
@@ -13,6 +13,7 @@ import (
1313// this functionality
1414func TestMiddlewareSuite(t *testing.T) {
1515 logger.SetOutput(GinkgoWriter)
16+ logger.SetErrOutput(GinkgoWriter)
1617
1718 RegisterFailHandler(Fail)
1819 RunSpecs(t, "Middleware API")
pkg/apis/options/options_suite_test.go+1
@@ -10,6 +10,7 @@ import (
1010
1111func TestOptionsSuite(t *testing.T) {
1212 logger.SetOutput(GinkgoWriter)
13+ logger.SetErrOutput(GinkgoWriter)
1314
1415 RegisterFailHandler(Fail)
1516 RunSpecs(t, "Options Suite")
pkg/apis/options/util/util_suite_test.go+1
@@ -10,6 +10,7 @@ import (
1010
1111func TestUtilSuite(t *testing.T) {
1212 logger.SetOutput(GinkgoWriter)
13+ logger.SetErrOutput(GinkgoWriter)
1314
1415 RegisterFailHandler(Fail)
1516 RunSpecs(t, "Options Util Suite")
pkg/authentication/basic/basic_suite_test.go+1
@@ -10,6 +10,7 @@ import (
1010
1111func TestBasicSuite(t *testing.T) {
1212 logger.SetOutput(GinkgoWriter)
13+ logger.SetErrOutput(GinkgoWriter)
1314
1415 RegisterFailHandler(Fail)
1516 RunSpecs(t, "Basic")
pkg/header/header_suite_test.go+1
@@ -17,6 +17,7 @@ var (
1717
1818func TestHeaderSuite(t *testing.T) {
1919 logger.SetOutput(GinkgoWriter)
20+ logger.SetErrOutput(GinkgoWriter)
2021
2122 RegisterFailHandler(Fail)
2223 RunSpecs(t, "Header")
pkg/middleware/middleware_suite_test.go+1
@@ -11,6 +11,7 @@ import (
1111
1212func TestMiddlewareSuite(t *testing.T) {
1313 logger.SetOutput(GinkgoWriter)
14+ logger.SetErrOutput(GinkgoWriter)
1415
1516 RegisterFailHandler(Fail)
1617 RunSpecs(t, "Middleware")
pkg/requests/requests_suite_test.go+1
@@ -21,6 +21,7 @@ var (
2121
2222func TestRequetsSuite(t *testing.T) {
2323 logger.SetOutput(GinkgoWriter)
24+ logger.SetErrOutput(GinkgoWriter)
2425 log.SetOutput(GinkgoWriter)
2526
2627 RegisterFailHandler(Fail)
pkg/requests/util/util_suite_test.go+1
@@ -13,6 +13,7 @@ import (
1313// this functionality
1414func TestRequestUtilSuite(t *testing.T) {
1515 logger.SetOutput(GinkgoWriter)
16+ logger.SetErrOutput(GinkgoWriter)
1617
1718 RegisterFailHandler(Fail)
1819 RunSpecs(t, "Request Utils")
pkg/sessions/cookie/session_store_test.go+2
@@ -19,6 +19,8 @@ import (
1919
2020func TestSessionStore(t *testing.T) {
2121 logger.SetOutput(GinkgoWriter)
22+ logger.SetErrOutput(GinkgoWriter)
23+
2224 RegisterFailHandler(Fail)
2325 RunSpecs(t, "Cookie SessionStore")
2426}
pkg/sessions/persistence/persistence_suite_test.go+2
@@ -10,6 +10,8 @@ import (
1010
1111func TestPersistenceSuite(t *testing.T) {
1212 logger.SetOutput(GinkgoWriter)
13+ logger.SetErrOutput(GinkgoWriter)
14+
1315 RegisterFailHandler(Fail)
1416 RunSpecs(t, "Persistence")
1517}
pkg/sessions/redis/redis_store_test.go+1
@@ -33,6 +33,7 @@ func (l *wrappedRedisLogger) Printf(_ context.Context, format string, v ...inter
3333
3434func TestSessionStore(t *testing.T) {
3535 logger.SetOutput(GinkgoWriter)
36+ logger.SetErrOutput(GinkgoWriter)
3637
3738 redisLogger := &wrappedRedisLogger{Logger: log.New(os.Stderr, "redis: ", log.LstdFlags|log.Lshortfile)}
3839 redisLogger.SetOutput(GinkgoWriter)
pkg/sessions/session_store_test.go+1
@@ -18,6 +18,7 @@ import (
1818
1919func TestSessionStore(t *testing.T) {
2020 logger.SetOutput(GinkgoWriter)
21+ logger.SetErrOutput(GinkgoWriter)
2122
2223 RegisterFailHandler(Fail)
2324 RunSpecs(t, "SessionStore")
pkg/upstream/upstream_suite_test.go+1
@@ -26,6 +26,7 @@ var (
2626
2727func TestUpstreamSuite(t *testing.T) {
2828 logger.SetOutput(GinkgoWriter)
29+ logger.SetErrOutput(GinkgoWriter)
2930 log.SetOutput(GinkgoWriter)
3031
3132 RegisterFailHandler(Fail)
pkg/validation/validation_suite_test.go+1
@@ -10,6 +10,7 @@ import (
1010
1111func TestValidationSuite(t *testing.T) {
1212 logger.SetOutput(GinkgoWriter)
13+ logger.SetErrOutput(GinkgoWriter)
1314
1415 RegisterFailHandler(Fail)
1516 RunSpecs(t, "Validation Suite")
providers/providers_suite_test.go+1
@@ -10,6 +10,7 @@ import (
1010
1111func TestProviderSuite(t *testing.T) {
1212 logger.SetOutput(GinkgoWriter)
13+ logger.SetErrOutput(GinkgoWriter)
1314
1415 RegisterFailHandler(Fail)
1516 RunSpecs(t, "Providers")