git.iko.soy/typeable/oauth2-proxy
on master help sign in
Remove EmailDomain verification from GitLab provider

This is handled globally

commit4a54c9421c505446168b2463aa9a5a0b24b752ad authorNick Meves <nick.meves@greenhouse.io> dateSun 27 Sep 2020, 15:30 (6 years ago) parentd9c141a
3 files changed+2−6
compare with master
unifiedsplit
CHANGELOG.md+1−2 pkg/validation/options.go−1 providers/gitlab.go+1−3
CHANGELOG.md+1−2
@@ -26,11 +26,10 @@
2626## Changes since v6.1.1
2727
2828- [#825](https://github.com/oauth2-proxy/oauth2-proxy/pull/825) Fix code coverage reporting on GitHub actions(@JoelSpeed)
29−- [#767](https://github.com/oauth2-proxy/oauth2-proxy/pull/796) Deprecate GetUserName & GetEmailAdress for EnrichSessionState (@NickMeves)
29+- [#796](https://github.com/oauth2-proxy/oauth2-proxy/pull/796) Deprecate GetUserName & GetEmailAdress for EnrichSessionState (@NickMeves)
3030- [#705](https://github.com/oauth2-proxy/oauth2-proxy/pull/705) Add generic Header injectors for upstream request and response headers (@JoelSpeed)
3131- [#753](https://github.com/oauth2-proxy/oauth2-proxy/pull/753) Pass resource parameter in login url (@codablock)
3232- [#789](https://github.com/oauth2-proxy/oauth2-proxy/pull/789) Add `--skip-auth-route` configuration option for `METHOD=pathRegex` based allowlists (@NickMeves)
33−- [#767](https://github.com/oauth2-proxy/oauth2-proxy/pull/796) Deprecate GetUserName & GetEmailAdress for EnrichSessionState (@NickMeves)
3433- [#575](https://github.com/oauth2-proxy/oauth2-proxy/pull/575) Stop accepting legacy SHA1 signed cookies (@NickMeves)
3534- [#722](https://github.com/oauth2-proxy/oauth2-proxy/pull/722) Validate Redis configuration options at startup (@NickMeves)
3635- [#791](https://github.com/oauth2-proxy/oauth2-proxy/pull/791) Remove GetPreferredUsername method from provider interface (@NickMeves)
pkg/validation/options.go−1
@@ -273,7 +273,6 @@ func parseProviderInfo(o *options.Options, msgs []string) []string {
273273 case *providers.GitLabProvider:
274274 p.AllowUnverifiedEmail = o.InsecureOIDCAllowUnverifiedEmail
275275 p.Groups = o.GitLabGroup
276− p.EmailDomains = o.EmailDomains
277276
278277 if o.GetOIDCVerifier() != nil {
279278 p.Verifier = o.GetOIDCVerifier()
providers/gitlab.go+1−3
@@ -15,9 +15,7 @@ import (
1515type GitLabProvider struct {
1616 *ProviderData
1717
18− Groups []string
19− EmailDomains []string
20−
18+ Groups []string
2119 Verifier *oidc.IDTokenVerifier
2220 AllowUnverifiedEmail bool
2321}