@@ -1,15 +1,18 @@
11package providers
22
33import (
4− "github.com/pusher/oauth2_proxy/pkg/apis/sessions"
54 "net/http"
65 "net/http/httptest"
76 "net/url"
87 "testing"
98
109 "github.com/bmizerany/assert"
10+ "github.com/pusher/oauth2_proxy/pkg/apis/sessions"
1111)
1212
13+const imaginaryAccessToken = "imaginary_access_token"
14+const bearerAccessToken = "Bearer " + imaginaryAccessToken
15+
1316func testKeycloakProvider(hostname, group string) *KeycloakProvider {
1417 p := NewKeycloakProvider(
1518 &ProviderData{
@@ -41,7 +44,7 @@ func testKeycloakBackend(payload string) *httptest.Server {
4144 url := r.URL
4245 if url.Path != path {
4346 w.WriteHeader(404)
44− } else if r.Header.Get("Authorization") != "Bearer imaginary_access_token" {
47+ } else if r.Header.Get("Authorization") != bearerAccessToken {
4548 w.WriteHeader(403)
4649 } else {
4750 w.WriteHeader(200)
@@ -94,10 +97,10 @@ func TestKeycloakProviderGetEmailAddress(t *testing.T) {
9497 b := testKeycloakBackend("{\"email\": \"michael.bland@gsa.gov\"}")
9598 defer b.Close()
9699
97− bUrl, _ := url.Parse(b.URL)
98− p := testKeycloakProvider(bUrl.Host, "")
100+ bURL, _ := url.Parse(b.URL)
101+ p := testKeycloakProvider(bURL.Host, "")
99102
100− session := &sessions.SessionState{AccessToken: "imaginary_access_token"}
103+ session := &sessions.SessionState{AccessToken: imaginaryAccessToken}
101104 email, err := p.GetEmailAddress(session)
102105 assert.Equal(t, nil, err)
103106 assert.Equal(t, "michael.bland@gsa.gov", email)
@@ -107,10 +110,10 @@ func TestKeycloakProviderGetEmailAddressAndGroup(t *testing.T) {
107110 b := testKeycloakBackend("{\"email\": \"michael.bland@gsa.gov\", \"groups\": [\"test-grp1\", \"test-grp2\"]}")
108111 defer b.Close()
109112
110− bUrl, _ := url.Parse(b.URL)
111− p := testKeycloakProvider(bUrl.Host, "test-grp1")
113+ bURL, _ := url.Parse(b.URL)
114+ p := testKeycloakProvider(bURL.Host, "test-grp1")
112115
113− session := &sessions.SessionState{AccessToken: "imaginary_access_token"}
116+ session := &sessions.SessionState{AccessToken: imaginaryAccessToken}
114117 email, err := p.GetEmailAddress(session)
115118 assert.Equal(t, nil, err)
116119 assert.Equal(t, "michael.bland@gsa.gov", email)
@@ -122,8 +125,8 @@ func TestKeycloakProviderGetEmailAddressFailedRequest(t *testing.T) {
122125 b := testKeycloakBackend("unused payload")
123126 defer b.Close()
124127
125− bUrl, _ := url.Parse(b.URL)
126− p := testKeycloakProvider(bUrl.Host, "")
128+ bURL, _ := url.Parse(b.URL)
129+ p := testKeycloakProvider(bURL.Host, "")
127130
128131 // We'll trigger a request failure by using an unexpected access
129132 // token. Alternatively, we could allow the parsing of the payload as
@@ -138,10 +141,10 @@ func TestKeycloakProviderGetEmailAddressEmailNotPresentInPayload(t *testing.T) {
138141 b := testKeycloakBackend("{\"foo\": \"bar\"}")
139142 defer b.Close()
140143
141− bUrl, _ := url.Parse(b.URL)
142− p := testKeycloakProvider(bUrl.Host, "")
144+ bURL, _ := url.Parse(b.URL)
145+ p := testKeycloakProvider(bURL.Host, "")
143146
144− session := &sessions.SessionState{AccessToken: "imaginary_access_token"}
147+ session := &sessions.SessionState{AccessToken: imaginaryAccessToken}
145148 email, err := p.GetEmailAddress(session)
146149 assert.NotEqual(t, nil, err)
147150 assert.Equal(t, "", email)