Use logger for sensitive data logging to be able to disable it (#1002)
* Add sensible logging flag to default setup for logger
* Use logger instead of fmt for info logging with sensible data
* Remove sensible logging flag
* Update CHANGELOG.md
Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
commit57640764c0e42e7d1ac3df08574e3fd0d846d3ba
authorKevin Kreitner <kevin.kreitner@real-digital.de>
dateWed 20 Jan 2021, 20:56 (6 years ago)
parent56075e3
CHANGELOG.md+1
@@ -63,6 +63,7 @@
6363 - Please note that `--cookie-refresh` must be 0 (the default) or equal to the token lifespan configured in Azure AD to make
6464 Azure token refresh reliable. Setting this value to 0 means that it relies on the provider implementation
6565 to decide if a refresh is required.
66+- [#1002](https://github.com/oauth2-proxy/oauth2-proxy/pull/1002) Use logger for logging refreshed session in azure and gitlab provider.
6667
6768## Changes since v6.1.1
6869
providers/azure.go+1−1
@@ -172,7 +172,7 @@ func (p *AzureProvider) RefreshSessionIfNeeded(ctx context.Context, s *sessions.
172172 return false, fmt.Errorf("unable to redeem refresh token: %v", err)
173173 }
174174
175− fmt.Printf("refreshed id token %s (expired on %s)\n", s, origExpiration)
175+ logger.Printf("refreshed id token %s (expired on %s)\n", s, origExpiration)
176176 return true, nil
177177}
178178
providers/gitlab.go+1−1
@@ -135,7 +135,7 @@ func (p *GitLabProvider) RefreshSessionIfNeeded(ctx context.Context, s *sessions
135135 return false, fmt.Errorf("unable to redeem refresh token: %v", err)
136136 }
137137
138− fmt.Printf("refreshed id token %s (expired on %s)\n", s, origExpiration)
138+ logger.Printf("refreshed id token %s (expired on %s)\n", s, origExpiration)
139139 return true, nil
140140}
141141