57a8ef0 · typeable/oauth2-proxy

git.iko.soy/typeable/oauth2-proxy

Fix method renaming in comments and tests

commit57a8ef06b48f1e92c32c4a7ffba13761bfd49809 authorNick Meves <nick.meves@greenhouse.io> dateThu 26 Nov 2020, 11:53 (6 years ago) parent5f8f856

3 files changed+7−5

unifiedsplit

providers/oidc_test.go+1−1

@@ -299,7 +299,7 @@ func TestOIDCProviderRefreshSessionIfNeededWithIdToken(t *testing.T) {

299299 assert.Equal(t, refreshToken, existingSession.RefreshToken)

300300}

301301

302−func TestCreateSessionStateFromBearerToken(t *testing.T) {

302+func TestOIDCProviderCreateSessionFromToken(t *testing.T) {

303303 const profileURLEmail = "janed@me.com"

304304

305305 testCases := map[string]struct {

providers/provider_default.go+1−2

@@ -124,8 +124,7 @@ func (p *ProviderData) RefreshSessionIfNeeded(_ context.Context, _ *sessions.Ses

124124 return false, nil

125125}

126126

127−// CreateSessionStateFromBearerToken should be implemented to allow providers

128−// to convert ID tokens into sessions

127+// CreateSessionFromToken converts Bearer IDTokens into sessions

129128func (p *ProviderData) CreateSessionFromToken(ctx context.Context, token string) (*sessions.SessionState, error) {

130129 if p.Verifier != nil {

131130 return middleware.CreateTokenToSessionFunc(p.Verifier.Verify)(ctx, token)

providers/provider_default_test.go+5−2

@@ -49,10 +49,13 @@ func TestAcrValuesConfigured(t *testing.T) {

4949 assert.Contains(t, result, "acr_values=testValue")

5050}

5151

52−func TestEnrichSessionState(t *testing.T) {

52+func TestProviderDataEnrichSession(t *testing.T) {

53+ g := NewWithT(t)

5354 p := &ProviderData{}

5455 s := &sessions.SessionState{}

55− assert.NoError(t, p.EnrichSession(context.Background(), s))

56+

57+ err := p.EnrichSession(context.Background(), s)

58+ g.Expect(err).ToNot(HaveOccurred())

5659}

5760

5861func TestProviderDataAuthorize(t *testing.T) {