6e54ac2 · typeable/oauth2-proxy

git.iko.soy/typeable/oauth2-proxy

Update LinkedIn provider validate URL (#1444)

* update LinkedIn validate URL Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com> * update changelog Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com> * update failed unit test Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>

commit6e54ac27459c45498df28402ac0df450d5f1117c authorJeeva Kandasamy <jkandasa@gmail.com> dateSat 20 Nov 2021, 03:06 (5 years ago) parent0693856

3 files changed+10−2

compare with master

unifiedsplit

CHANGELOG.md+1 providers/linkedin.go+8−1 providers/linkedin_test.go+1−1

CHANGELOG.md+1

@@ -10,6 +10,7 @@

1010

1111- [#1433](https://github.com/oauth2-proxy/oauth2-proxy/pull/1433) Let authentication fail when session validation fails (@stippi2)

1212- [#1445](https://github.com/oauth2-proxy/oauth2-proxy/pull/1445) Fix docker container multi arch build issue by passing GOARCH details to make build (@jkandasa)

13+- [#1444](https://github.com/oauth2-proxy/oauth2-proxy/pull/1444) Update LinkedIn provider validate URL (@jkandasa)

1314

1415# V7.2.0

1516

providers/linkedin.go+8−1

@@ -46,6 +46,13 @@ var (

4646 Host: "api.linkedin.com",

4747 Path: "/v2/emailAddress",

4848 }

49+

50+ // Default Validate URL for LinkedIn.

51+ linkedinDefaultValidateURL = &url.URL{

52+ Scheme: "https",

53+ Host: "api.linkedin.com",

54+ Path: "/v2/me",

55+ }

4956)

5057

5158// NewLinkedInProvider initiates a new LinkedInProvider

@@ -55,7 +62,7 @@ func NewLinkedInProvider(p *ProviderData) *LinkedInProvider {

5562 loginURL: linkedinDefaultLoginURL,

5663 redeemURL: linkedinDefaultRedeemURL,

5764 profileURL: linkedinDefaultProfileURL,

58− validateURL: linkedinDefaultProfileURL,

65+ validateURL: linkedinDefaultValidateURL,

5966 scope: linkedinDefaultScope,

6067 })

6168 return &LinkedInProvider{ProviderData: p}

providers/linkedin_test.go+1−1

@@ -54,7 +54,7 @@ func TestNewLinkedInProvider(t *testing.T) {

5454 g.Expect(providerData.LoginURL.String()).To(Equal("https://www.linkedin.com/oauth/v2/authorization"))

5555 g.Expect(providerData.RedeemURL.String()).To(Equal("https://www.linkedin.com/uas/oauth2/accessToken"))

5656 g.Expect(providerData.ProfileURL.String()).To(Equal("https://api.linkedin.com/v2/emailAddress"))

57− g.Expect(providerData.ValidateURL.String()).To(Equal("https://api.linkedin.com/v2/emailAddress"))

57+ g.Expect(providerData.ValidateURL.String()).To(Equal("https://api.linkedin.com/v2/me"))

5858 g.Expect(providerData.Scope).To(Equal("r_emailaddress r_liteprofile"))

5959}

6060