git.iko.soy/typeable/oauth2-proxy
on master help sign in
Merge pull request #488 from oauth2-proxy/fix-set-basic-default

Set-Basic-Auth should default to false

commit6fa3d6c74cdf3bff1cdc6d9e0ed89e7286d8131b authorHenry Jenkins <henry@henryjenkins.name> dateThu 16 Apr 2020, 10:27 (7 years ago) parentdd05e7f5fc6bd0
3 files changed+3−2
compare with master
unifiedsplit
CHANGELOG.md+1 docs/configuration/configuration.md+1−1 main.go+1−1
CHANGELOG.md+1
@@ -37,6 +37,7 @@
3737- [#412](https://github.com/pusher/oauth2_proxy/pull/412) Allow multiple cookie domains to be specified (@edahlseng)
3838- [#413](https://github.com/oauth2-proxy/oauth2-proxy/pull/413) Add -set-basic-auth param to set the Basic Authorization header for upstreams (@morarucostel).
3939- [#483](https://github.com/oauth2-proxy/oauth2-proxy/pull/483) Warn users when session cookies are split (@JoelSpeed)
40+- [#488](https://github.com/oauth2-proxy/oauth2-proxy/pull/488) Set-Basic-Auth should default to false (@JoelSpeed)
4041
4142# v5.1.0
4243
docs/configuration/configuration.md+1−1
@@ -103,7 +103,7 @@ An example [oauth2-proxy.cfg]({{ site.gitweb }}/contrib/oauth2-proxy.cfg.example
103103| `-session-store-type` | string | [Session data storage backend](configuration/sessions); redis or cookie | cookie |
104104| `-set-xauthrequest` | bool | set X-Auth-Request-User, X-Auth-Request-Email and X-Auth-Request-Preferred-Username response headers (useful in Nginx auth_request mode) | false |
105105| `-set-authorization-header` | bool | set Authorization Bearer response header (useful in Nginx auth_request mode) | false |
106−| `-set-basic-auth` | bool | set HTTP Basic Auth information in response (useful in Nginx auth_request mode) | true |
106+| `-set-basic-auth` | bool | set HTTP Basic Auth information in response (useful in Nginx auth_request mode) | false |
107107| `-signature-key` | string | GAP-Signature request signature key (algorithm:secretkey) | |
108108| `-silence-ping-logging` | bool | disable logging of requests to ping endpoint | false |
109109| `-skip-auth-preflight` | bool | will skip authentication for OPTIONS requests | false |
main.go+1−1
@@ -44,7 +44,7 @@ func main() {
4444 flagSet.Bool("set-xauthrequest", false, "set X-Auth-Request-User and X-Auth-Request-Email response headers (useful in Nginx auth_request mode)")
4545 flagSet.Var(&upstreams, "upstream", "the http url(s) of the upstream endpoint, file:// paths for static files or static://<status_code> for static response. Routing is based on the path")
4646 flagSet.Bool("pass-basic-auth", true, "pass HTTP Basic Auth, X-Forwarded-User and X-Forwarded-Email information to upstream")
47− flagSet.Bool("set-basic-auth", true, "set HTTP Basic Auth information in response (useful in Nginx auth_request mode)")
47+ flagSet.Bool("set-basic-auth", false, "set HTTP Basic Auth information in response (useful in Nginx auth_request mode)")
4848 flagSet.Bool("prefer-email-to-user", false, "Prefer to use the Email address as the Username when passing information to upstream. Will only use Username if Email is unavailable, eg. htaccess authentication. Used in conjunction with -pass-basic-auth and -pass-user-headers")
4949 flagSet.Bool("pass-user-headers", true, "pass X-Forwarded-User and X-Forwarded-Email information to upstream")
5050 flagSet.String("basic-auth-password", "", "the password to set when passing the HTTP Basic Auth header")