Merge pull request #185 from jonas/check-against-validate-url-string
Only validate tokens if ValidateURL resolves to a non-empty string
commit77e1fff7532bf7d3df7316c156163e6038634c9f
authorJoel Speed <Joel.speed@hotmail.co.uk>
dateSat 15 Jun 2019, 12:30 (7 years ago)
parent0d6fa627a8fb58
CHANGELOG.md+1
@@ -55,6 +55,7 @@
5555
5656- [#111](https://github.com/pusher/oauth2_proxy/pull/111) Add option for telling where to find a login.gov JWT key file (@timothy-spencer)
5757- [#170](https://github.com/pusher/oauth2_proxy/pull/170) Restore binary tarball contents to be compatible with bitlys original tarballs (@zeha)
58+- [#185](https://github.com/pusher/oauth2_proxy/pull/185) Fix an unsupported protocol scheme error during token validation when using the Azure provider (@jonas)
5859
5960# v3.2.0
6061
providers/internal_util.go+1−1
@@ -47,7 +47,7 @@ func stripParam(param, endpoint string) string {
4747
4848// validateToken returns true if token is valid
4949func validateToken(p Provider, accessToken string, header http.Header) bool {
50− if accessToken == "" || p.Data().ValidateURL == nil {
50+ if accessToken == "" || p.Data().ValidateURL == nil || p.Data().ValidateURL.String() == "" {
5151 return false
5252 }
5353 endpoint := p.Data().ValidateURL.String()