Fix login page fragment handling after soft reload on Firefox (#353)
* Fix login page fragment handling after soft reload on Firefox.
* Add comments.
* Move changelog entry to correct place.
Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
Co-authored-by: Felix Fontein <felix@fontein.de>
commit9670f54dd00fd75ffd0fb765f8fd60aa64c1fabd
authorFelix Fontein <ff@dybuster.com>
dateFri 31 Jan 2020, 12:11 (7 years ago)
parentc49d362
CHANGELOG.md+2
@@ -8,6 +8,8 @@
88
99## Changes since v5.0.0
1010
11+- [#353](https://github.com/pusher/oauth2_proxy/pull/353) Fix login page fragment handling after soft reload on Firefox (@ffdybuster)
12+
1113# v5.0.0
1214
1315## Release Hightlights
templates.go+6
@@ -135,6 +135,12 @@ func getTemplates() *template.Template {
135135 (function() {
136136 var inputs = document.getElementsByName('rd');
137137 for (var i = 0; i < inputs.length; i++) {
138+ // Add hash, but make sure it is only added once
139+ var idx = inputs[i].value.indexOf('#');
140+ if (idx >= 0) {
141+ // Remove existing hash from URL
142+ inputs[i].value = inputs[i].value.substr(0, idx);
143+ }
138144 inputs[i].value += window.location.hash;
139145 }
140146 })();