git.iko.soy/typeable/oauth2-proxy
on master help sign in
Improve default CreateSessionStateFromBearerToken tests
commita3eef1709a10eceaf19cace3130c9c7cdcb5aac2 authorNick Meves <nick.meves@greenhouse.io> dateThu 4 Jun 2020, 12:16 (6 years ago) parentc2c1caa
1 file changed+10−6
providers/provider_default_test.go+10−6
providers/provider_default_test.go+10−6
@@ -70,17 +70,21 @@ func TestCreateSessionStateFromBearerToken(t *testing.T) {
7070 &oidc.Config{ClientID: "asdf1234"},
7171 )
7272
73− key, _ := rsa.GenerateKey(rand.Reader, 2048)
74− rawIDToken, _ := jwt.NewWithClaims(jwt.SigningMethodRS256, minimalIDToken).SignedString(key)
75− idToken, _ := verifier.Verify(context.Background(), rawIDToken)
73+ key, err := rsa.GenerateKey(rand.Reader, 2048)
74+ assert.NoError(t, err)
75+ rawIDToken, err := jwt.NewWithClaims(jwt.SigningMethodRS256, minimalIDToken).SignedString(key)
76+ assert.NoError(t, err)
77+ // Pass to a dummy Verifier to get an oidc.IDToken from the rawIDToken for our actual test below
78+ idToken, err := verifier.Verify(context.Background(), rawIDToken)
79+ assert.NoError(t, err)
7680
7781 session, err := (*ProviderData)(nil).CreateSessionStateFromBearerToken(context.Background(), rawIDToken, idToken)
82+ assert.NoError(t, err)
7883
79− assert.Equal(t, nil, err)
8084 assert.Equal(t, rawIDToken, session.AccessToken)
8185 assert.Equal(t, rawIDToken, session.IDToken)
82− assert.Equal(t, "", session.RefreshToken)
8386 assert.Equal(t, "123456789", session.Email)
8487 assert.Equal(t, "123456789", session.User)
85− assert.Equal(t, "", session.PreferredUsername)
88+ assert.Empty(t, session.RefreshToken)
89+ assert.Empty(t, session.PreferredUsername)
8690}