dd46428 · typeable/oauth2-proxy

git.iko.soy/typeable/oauth2-proxy

Ignore spaces in authorized emails list

commitdd4642813bdabafb37436a3a9639ffbe3f9cc34e authorStan Hu <stanhu@packetzoom.com> dateWed 23 Dec 2015, 00:08 (11 years ago) parentbeebf4d

2 files changed+15−1

unifiedsplit

validator.go+2−1

@@ -53,7 +53,8 @@ func (um *UserMap) LoadAuthenticatedEmailsFile() {

5353 }

5454 updated := make(map[string]bool)

5555 for _, r := range records {

56− updated[strings.ToLower(r[0])] = true

56+ address := strings.ToLower(strings.TrimSpace(r[0]))

57+ updated[address] = true

5758 }

5859 atomic.StorePointer(&um.m, unsafe.Pointer(&updated))

5960}

validator_test.go+13

@@ -147,3 +147,16 @@ func TestValidatorComparisonsAreCaseInsensitive(t *testing.T) {

147147 t.Error("validated domains are not lower-cased")

148148 }

149149}

150+

151+func TestValidatorIgnoreSpacesInAuthEmails(t *testing.T) {

152+ vt := NewValidatorTest(t)

153+ defer vt.TearDown()

154+

155+ vt.WriteEmails(t, []string{" foo.bar@example.com "})

156+ domains := []string(nil)

157+ validator := vt.NewValidator(domains, nil)

158+

159+ if !validator("foo.bar@example.com") {

160+ t.Error("email should validate")

161+ }

162+}