git.iko.soy/typeable/oauth2-proxy
on master help sign in
Corrects request endpoint (#1650)

* Fixes typo in repo endpoint * Update CHANGELOG.md * Fix the test to mock the correct endpoint Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>

commitfc686ae95c0c6a9c6de131f971f8bc51a91df1f4 authoradamsong <adamsong@users.noreply.github.com> dateWed 25 May 2022, 15:05 (4 years ago) parentc6a9836
3 files changed+4−3
compare with master
unifiedsplit
CHANGELOG.md+1 providers/github.go+1−1 providers/github_test.go+2−2
CHANGELOG.md+1
@@ -41,6 +41,7 @@ If you are using an architecture specific tag (ex: v7.2.1-arm64) you should move
4141- [#1594](https://github.com/oauth2-proxy/oauth2-proxy/pull/1594) Release ARMv8 docker images (@braunsonm)
4242- [#1649](https://github.com/oauth2-proxy/oauth2-proxy/pull/1649) Return a 400 instead of a 500 when a request contains an invalid redirect target (@niksko)
4343- [#1638](https://github.com/oauth2-proxy/oauth2-proxy/pull/1638) Implement configurable upstream timeout (@jacksgt)
44+- [#1650](https://github.com/oauth2-proxy/oauth2-proxy/pull/1650) Fixed 500 when checking if user has repo (@adamsong)
4445- [#1635](https://github.com/oauth2-proxy/oauth2-proxy/pull/1635) Added description and unit tests for ipv6 address (@t-katsumura)
4546
4647# V7.2.1
providers/github.go+1−1
@@ -312,7 +312,7 @@ func (p *GitHubProvider) hasRepo(ctx context.Context, accessToken string) (bool,
312312 endpoint := &url.URL{
313313 Scheme: p.ValidateURL.Scheme,
314314 Host: p.ValidateURL.Host,
315− Path: path.Join(p.ValidateURL.Path, "/repo/", p.Repo),
315+ Path: path.Join(p.ValidateURL.Path, "/repos/", p.Repo),
316316 }
317317
318318 var repo repository
providers/github_test.go+2−2
@@ -34,7 +34,7 @@ func testGitHubProvider(hostname string, opts options.GitHubOptions) *GitHubProv
3434
3535func testGitHubBackend(payloads map[string][]string) *httptest.Server {
3636 pathToQueryMap := map[string][]string{
37− "/repo/oauth2-proxy/oauth2-proxy": {""},
37+ "/repos/oauth2-proxy/oauth2-proxy": {""},
3838 "/repos/oauth2-proxy/oauth2-proxy/collaborators/mbland": {""},
3939 "/user": {""},
4040 "/user/emails": {""},
@@ -229,7 +229,7 @@ func TestGitHubProvider_getEmailWithWriteAccessToPrivateRepo(t *testing.T) {
229229
230230func TestGitHubProvider_getEmailWithNoAccessToPrivateRepo(t *testing.T) {
231231 b := testGitHubBackend(map[string][]string{
232− "/repo/oauth2-proxy/oauth2-proxy": {`{}`},
232+ "/repos/oauth2-proxy/oauth2-proxy": {`{}`},
233233 })
234234 defer b.Close()
235235