git.iko.soy/typeable/pandoc
on 2.1 help sign in
typeable/pandoc/CONTRIBUTING.md
330 lines 13 kB history raw
1Contributing to pandoc
2======================
4Have a question?
5----------------
7Ask on [pandoc-discuss].
10Found a bug?
11------------
13Bug reports are welcome! Please report all bugs on pandoc's github
14[issue tracker].
16Before you submit a bug report, search the [open issues] *and* [closed issues]
17to make sure the issue hasn't come up before. Also, check the [User's Guide] and
18[FAQs] for anything relevant.
20Make sure you can reproduce the bug with the [latest released version] of pandoc
21(or, even better, the [development version]).
23Your report should give detailed, *reproducible* instructions, including
25 * the pandoc version (check using `pandoc -v`)
26 * the exact command line used
27 * the exact input used
28 * the output received
29 * the output you expected instead
31A small test case (just a few lines) is ideal. If your input is large,
32try to whittle it down to a *minimum working example*.
34Out of scope?
35-------------
37A less than perfect conversion does not necessarily mean there's
38a bug in pandoc. Quoting from the MANUAL:
40> Because pandoc's intermediate representation of a document is less
41> expressive than many of the formats it converts between, one should
42> not expect perfect conversions between every format and every other.
43> Pandoc attempts to preserve the structural elements of a document, but
44> not formatting details such as margin size. And some document elements,
45> such as complex tables, may not fit into pandoc's simple document
46> model. While conversions from pandoc's Markdown to all formats aspire
47> to be perfect, conversions from formats more expressive than pandoc's
48> Markdown can be expected to be lossy.
50For example, both `docx` and `odt` formats can represent margin size, but
51because pandoc's internal document model does not contain a representation of
52margin size, this information will be lost on converting from docx
53to `odt`. (You can, however, customize margin size using `--reference-doc`.)
55So before submitting a bug report, consider whether it might be
56"out of scope." If it concerns a feature of documents that isn't
57representable in pandoc's Markdown, then it very likely is.
58(If in doubt, you can always ask on [pandoc-discuss].)
60Fixing bugs from the issue tracker
61----------------------------------
63Almost all the bugs on the issue tracker have one or more associated
64tags. These are used to indicate the *complexity* and *nature* of a
65bug. There is not yet a way to indicate priority. An up to date
66summary of issues can be found on [GitHub labels].
68* [beginner-friendly] — The perfect starting point for new contributors. The
69 issue is generic and can be resolved without deep knowledge of the code
70 base.
71* [enhancement] — A feature which would be desirable. We recommend
72 you discuss any proposed enhancement on pandoc-discuss before
73 writing code.
74* [bug] — A problem which needs to be fixed.
75* [complexity:low] — The fix should only be a couple of lines.
76* [complexity:high] — The fix might require structural changes or in depth
77 knowledge of the code base.
78* [new:reader] — A request to add a new input format.
79* [new:writer] — A request to add a new output format.
80* [docs] — A discrepancy, or ambiguity in the documentation.
81* [status:in-progress] — Someone is actively working on or planning to work on the
82 ticket.
83* [status:more-discussion-needed] — It is unclear what the correct approach
84 to solving the ticket is. Before starting on tickets such as this it
85 would be advisable to post on the ticket.
86* [status:more-info-needed] — We require more information from a user before
87 we can classify a report properly.
89Issues related to a specific format are tagged accordingly, e.g. feature request
90or bug reports related to Markdown are labelled with [format:markdown].
92Have an idea for a new feature?
93-------------------------------
95First, search [pandoc-discuss] and the issue tracker (both [open issues] *and*
96[closed issues]) to make sure that the idea has not been discussed before.
98Explain the rationale for the feature you're requesting. Why would this
99feature be useful? Consider also any possible drawbacks, including backwards
100compatibility, new library dependencies, and performance issues.
102It is best to discuss a potential new feature on [pandoc-discuss]
103before opening an issue.
105Patches and pull requests
106-------------------------
108Patches and pull requests are welcome. Before you put time into a nontrivial
109patch, it is a good idea to discuss it on [pandoc-discuss], especially if it is
110for a new feature (rather than fixing a bug).
112Please follow these guidelines:
1141. Each patch (commit) should make a single logical change (fix a bug, add
115 a feature, clean up some code, add documentation). Everything
116 related to that change should be included (including tests and
117 documentation), and nothing unrelated should be included.
1192. The first line of the commit message should be a short description
120 of the whole commit (ideally <= 50 characters). Then there should
121 be a blank line, followed by a more detailed description of the
122 change.
1243. Follow the stylistic conventions you find in the existing
125 pandoc code. Use spaces, not tabs, and wrap code to 80 columns.
126 Always include type signatures for top-level functions.
127 Consider installing [EditorConfig], this will help you to follow the
128 coding style prevalent in pandoc.
1304. Your code should compile without warnings (`-Wall` clean).
1325. Run the tests to make sure your code does not introduce new bugs.
133 (See below under [Tests](#tests).) All tests should pass.
1356. It is a good idea to add test cases for the bug you are fixing. (See
136 below under [Tests](#tests).) If you are adding a new writer or reader,
137 you must include tests.
1397. If you are adding a new feature, include updates to `MANUAL.txt`.
1418. All code must be released under the general license governing pandoc
142 (GPL v2).
1449. It is better not to introduce new dependencies. Dependencies on
145 external C libraries should especially be avoided.
14710. We aim for compatibility with ghc versions from 7.8.3 to the
148 latest release. All pull requests and commits are tested
149 automatically on <travis-ci.org>, using GHC versions in the
150 `Tested-With` stanza of `pandoc.cabal`. We currently relax
151 the "`-Wall` clean" requirement for GHC 7.10.x, because
152 there are so many warnings relating to the addition of type
153 classes to the Prelude.
155Tests
156-----
158Tests can be run as follows:
160 cabal install --only-dependencies --enable-tests
161 cabal configure --enable-tests
162 cabal build
163 cabal test
165or, if you're using [stack],
167 stack setup
168 stack test
170The test program is `test/test-pandoc.hs`.
172Benchmarks
173----------
175To run benchmarks with cabal:
177 cabal configure --enable-benchmarks
178 cabal build
179 cabal bench
181With stack:
183 stack bench
185You can also build pandoc with the `weigh-pandoc` flag and
186run `weigh-pandoc` to get some statistics on memory usage.
187(Eventually this should be incorporated into the benchmark
188suite.)
190Using the REPL
191--------------
193With a recent version of cabal, you can do `cabal repl` and get
194a ghci REPL for working with pandoc. With [stack], use
195`cabal ghci`.
197We recommend using the following `.ghci` file (which can be
198placed in the source directory):
200 :set -fobject-code
201 :set -XTypeSynonymInstances
202 :set -XScopedTypeVariables
203 :set -XOverloadedStrings
205Profiling
206---------
208To use the GHC profiler with cabal:
210 cabal clean
211 cabal install --enable-library-profiling --enable-executable-profiling
212 pandoc +RTS -p -RTS [file]...
213 less pandoc.prof
215With stack:
217 stack clean
218 stack install --profile
219 pandoc +RTS -p -RTS [file]...
220 less pandoc.prof
222Templates
223---------
225The default templates live in `data/templates`, which is a git
226subtree linked to <https://github.com/jgm/pandoc-templates.git>.
227The purpose of maintaining a separate repository is to allow
228people to maintain variant templates as a fork.
230You can modify the templates and submit patches without worrying
231much about this: when these patches are merged, we will
232push them to the main templates repository by doing
234 git subtree push --prefix=data/templates templates master
236where `templates` is a remote pointing to the templates
237repository.
239The code
240--------
242Pandoc has a publicly accessible git repository on
243github: <http://github.com/jgm/pandoc>. To get a local copy of the source:
245 git clone https://github.com/jgm/pandoc.git
247The source for the main pandoc program is `pandoc.hs`. The source for
248the pandoc library is in `src/`, the source for the tests is in
249`test/`, and the source for the benchmarks is in `benchmark/`.
251The modules `Text.Pandoc.Definition`, `Text.Pandoc.Builder`, and
252`Text.Pandoc.Generic` are in a separate library `pandoc-types`. The code can
253be found in <http://github.com/jgm/pandoc-types>.
255To build pandoc, you will need a working installation of the
256[Haskell platform].
258The library is structured as follows:
260 - `Text.Pandoc` is a top-level module that exports what is needed
261 by most users of the library. Any patches that add new readers
262 or writers will need to make changes here, too.
263 - `Text.Pandoc.Definition` (in `pandoc-types`) defines the types
264 used for representing a pandoc document.
265 - `Text.Pandoc.Builder` (in `pandoc-types`) provides functions for
266 building pandoc documents programatically.
267 - `Text.Pandoc.Generics` (in `pandoc-types`) provides functions allowing
268 you to promote functions that operate on parts of pandoc documents
269 to functions that operate on whole pandoc documents, walking the
270 tree automatically.
271 - `Text.Pandoc.Readers.*` are the readers, and `Text.Pandoc.Writers.*`
272 are the writers.
273 - `Text.Pandoc.Biblio` is a utility module for formatting citations
274 using citeproc-hs.
275 - `Text.Pandoc.Data` is used to embed data files when the `embed_data_files`
276 cabal flag is used. It is generated from `src/Text/Pandoc/Data.hsb` using
277 the preprocessor [hsb2hs].
278 - `Text.Pandoc.Highlighting` contains the interface to the
279 skylighting library, which is used for code syntax highlighting.
280 - `Text.Pandoc.ImageSize` is a utility module containing functions for
281 calculating image sizes from the contents of image files.
282 - `Text.Pandoc.MIME` contains functions for associating MIME types
283 with extensions.
284 - `Text.Pandoc.Options` defines reader and writer options.
285 - `Text.Pandoc.PDF` contains functions for producing a PDF from a
286 LaTeX source.
287 - `Text.Pandoc.Parsing` contains parsing functions used in multiple readers.
288 - `Text.Pandoc.Pretty` is a pretty-printing library specialized to
289 the needs of pandoc.
290 - `Text.Pandoc.SelfContained` contains functions for making an HTML
291 file "self-contained," by importing remotely linked images, CSS,
292 and JavaScript and turning them into `data:` URLs.
293 - `Text.Pandoc.Shared` is a grab-bag of shared utility functions.
294 - `Text.Pandoc.Writers.Shared` contains utilities used in writers only.
295 - `Text.Pandoc.Slides` contains functions for splitting a markdown document
296 into slides, using the conventions described in the MANUAL.
297 - `Text.Pandoc.Templates` defines pandoc's templating system.
298 - `Text.Pandoc.UTF8` contains functions for converting text to and from
299 UTF8 bytestrings (strict and lazy).
300 - `Text.Pandoc.Asciify` contains functions to derive ascii versions of
301 identifiers that use accented characters.
302 - `Text.Pandoc.UUID` contains functions for generating UUIDs.
303 - `Text.Pandoc.XML` contains functions for formatting XML.
305[open issues]: https://github.com/jgm/pandoc/issues
306[closed issues]: https://github.com/jgm/pandoc/issues?q=is%3Aissue+is%3Aclosed
307[latest released version]: https://github.com/jgm/pandoc/releases/latest
308[development version]: https://github.com/pandoc-extras/pandoc-nightly/releases/latest
309[pandoc-discuss]: http://groups.google.com/group/pandoc-discuss
310[issue tracker]: https://github.com/jgm/pandoc/issues
311[User's Guide]: http://pandoc.org/MANUAL.html
312[FAQs]: http://pandoc.org/faqs.html
313[EditorConfig]: http://editorconfig.org/
314[Haskell platform]: http://www.haskell.org/platform/
315[hsb2hs]: http://hackage.haskell.org/package/hsb2hs
316[GitHub labels]: https://github.com/jgm/pandoc/labels
317[beginner-friendly]: https://github.com/jgm/pandoc/labels/beginner-friendly
318[enhancement]: https://github.com/jgm/pandoc/labels/enhancement
319[bug]: https://github.com/jgm/pandoc/labels/bug
320[complexity:low]: https://github.com/jgm/pandoc/labels/complexity:low
321[complexity:high]: https://github.com/jgm/pandoc/labels/complexity:high
322[docs]: https://github.com/jgm/pandoc/labels/docs
323[format:markdown]: https://github.com/jgm/pandoc/labels/format:markdown
324[new:reader]: https://github.com/jgm/pandoc/labels/new:reader
325[new:writer]: https://github.com/jgm/pandoc/labels/new:writer
326[status:in-progress]: https://github.com/jgm/pandoc/labels/status:in-progress
327[status:more-discussion-needed]: https://github.com/jgm/pandoc/labels/status:more-discussion-needed
328[status:more-info-needed]: https://github.com/jgm/pandoc/labels/status:more-info-needed
329[stack]: https://github.com/commercialhaskell/stack