git.iko.soy/typeable/pandoc
on master help sign in
Merge pull request #1495 from jkr/inline-drawings

Docx reader: Inline image fix

commit44dad5286631748b6ed8571f2bcf6a7828e06a79 authorJohn MacFarlane <jgm@berkeley.edu> dateThu 7 Aug 2014, 13:41 (12 years ago) parent482f7f898d14b2
6 files changed+30−4
compare with master
unifiedsplit
pandoc.cabal+1 src/Text/Pandoc/Readers/Docx.hs+7 src/Text/Pandoc/Readers/Docx/Parse.hs+15−3 tests/Tests/Readers/Docx.hs+5−1 tests/docx.inline_images.docx tests/docx.inline_images.native+2
pandoc.cabal+1
@@ -178,6 +178,7 @@ Extra-Source-Files:
178178 tests/docx.hanging_indent.docx,
179179 tests/docx.headers.docx,
180180 tests/docx.image.docx,
181+ tests/docx.inline_images.docx,
181182 tests/docx.inline_code.docx,
182183 tests/docx.inline_formatting.docx,
183184 tests/docx.links.docx,
src/Text/Pandoc/Readers/Docx.hs+7
@@ -321,6 +321,13 @@ runToInlines (Footnote bps) =
321321 concatMapM bodyPartToBlocks bps >>= (\blks -> return [Note blks])
322322runToInlines (Endnote bps) =
323323 concatMapM bodyPartToBlocks bps >>= (\blks -> return [Note blks])
324+runToInlines (InlineDrawing fp bs) = do
325+ mediaBag <- gets docxMediaBag
326+ modify $ \s -> s { docxMediaBag = insertMedia fp Nothing bs mediaBag }
327+ return [Image [] (fp, "")]
328+
329+
330+
324331
325332parPartToInlines :: ParPart -> DocxContext [Inline]
326333parPartToInlines (PlainRun r) = runToInlines r
src/Text/Pandoc/Readers/Docx/Parse.hs+15−3
@@ -282,6 +282,7 @@ defaultGroupStyle = GroupStyle {groupChr = Nothing, groupPos = Nothing}
282282data Run = Run RunStyle [RunElem]
283283 | Footnote [BodyPart]
284284 | Endnote [BodyPart]
285+ | InlineDrawing FilePath B.ByteString
285286 deriving Show
286287
287288data RunElem = TextRun String | LnBrk | Tab
@@ -874,14 +875,14 @@ lookupRelationship :: RelId -> [Relationship] -> Maybe Target
874875lookupRelationship relid rels =
875876 lookup relid (map (\(Relationship pair) -> pair) rels)
876877
877−expandDrawingId :: String -> D ParPart
878+expandDrawingId :: String -> D (FilePath, B.ByteString)
878879expandDrawingId s = do
879880 target <- asks (lookupRelationship s . envRelationships)
880881 case target of
881882 Just filepath -> do
882883 bytes <- asks (lookup (combine "word" filepath) . envMedia)
883884 case bytes of
884− Just bs -> return $ Drawing filepath bs
885+ Just bs -> return (filepath, bs)
885886 Nothing -> throwError DocxError
886887 Nothing -> throwError DocxError
887888
@@ -894,7 +895,7 @@ elemToParPart ns element
894895 >>= findAttr (QName "embed" (lookup "r" ns) (Just "r"))
895896 in
896897 case drawing of
897− Just s -> expandDrawingId s
898+ Just s -> expandDrawingId s >>= (\(fp, bs) -> return $ Drawing fp bs)
898899 Nothing -> throwError WrongElem
899900elemToParPart ns element
900901 | isElem ns "w" "r" element =
@@ -943,6 +944,17 @@ lookupEndnote :: String -> Notes -> Maybe Element
943944lookupEndnote s (Notes _ _ ens) = ens >>= (M.lookup s)
944945
945946elemToRun :: NameSpaces -> Element -> D Run
947+elemToRun ns element
948+ | isElem ns "w" "r" element
949+ , Just drawingElem <- findChild (elemName ns "w" "drawing") element =
950+ let a_ns = "http://schemas.openxmlformats.org/drawingml/2006/main"
951+ drawing = findElement (QName "blip" (Just a_ns) (Just "a")) drawingElem
952+ >>= findAttr (QName "embed" (lookup "r" ns) (Just "r"))
953+ in
954+ case drawing of
955+ Just s -> expandDrawingId s >>=
956+ (\(fp, bs) -> return $ InlineDrawing fp bs)
957+ Nothing -> throwError WrongElem
946958elemToRun ns element
947959 | isElem ns "w" "r" element
948960 , Just ref <- findChild (elemName ns "w" "footnoteReference") element
tests/Tests/Readers/Docx.hs+5−1
@@ -107,9 +107,13 @@ tests = [ testGroup "inlines"
107107 "docx.links.docx"
108108 "docx.links.native"
109109 , testCompare
110− "inline image with reference output"
110+ "inline image"
111111 "docx.image.docx"
112112 "docx.image_no_embed.native"
113+ , testCompare
114+ "inline image in links"
115+ "docx.inline_images.docx"
116+ "docx.inline_images.native"
113117 , testCompare
114118 "handling unicode input"
115119 "docx.unicode.docx"
tests/docx.inline_images.docxnew file

Binary file not shown.

tests/docx.inline_images.nativenew file+2
@@ -0,0 +1,2 @@
1+[Para [Str "This",Space,Str "picture",Space,Image [] ("media/image1.jpg",""),Space,Str "is",Space,Str "an",Space,Str "identicon."]
2+,Para [Str "Here",Space,Str "is",Space,Link [Str "one",Space,Image [] ("media/image2.jpg",""),Space,Str "that"] ("http://www.google.com",""),Space,Str "links."]]