git.iko.soy/typeable/pandoc
on master help sign in
HTML writer: don't include alignment attribute for default table columns.

Previously these were given "left" alignment. Better to leave off alignment attributes altogether. Closes #2694.

commit93a05dffd3d08bf2cb3a41e0523540c3c4bf5814 authorJohn MacFarlane <jgm@berkeley.edu> dateWed 3 Feb 2016, 13:31 (11 years ago) parent7a10507
2 files changed+19−16
compare with master
unifiedsplit
src/Text/Pandoc/Writers/HTML.hs+5−2 tests/tables.html+14−14
src/Text/Pandoc/Writers/HTML.hs+5−2
@@ -645,7 +645,7 @@ alignmentToString alignment = case alignment of
645645 AlignLeft -> "left"
646646 AlignRight -> "right"
647647 AlignCenter -> "center"
648− AlignDefault -> "left"
648+ AlignDefault -> ""
649649
650650tableItemToHtml :: WriterOptions
651651 -> (Html -> Html)
@@ -658,7 +658,10 @@ tableItemToHtml opts tag' align' item = do
658658 let attribs = if writerHtml5 opts
659659 then A.style (toValue $ "text-align: " ++ alignStr ++ ";")
660660 else A.align (toValue alignStr)
661− return $ (tag' ! attribs $ contents) >> nl opts
661+ let tag'' = if null alignStr
662+ then tag'
663+ else tag' ! attribs
664+ return $ (tag'' $ contents) >> nl opts
662665
663666toListItems :: WriterOptions -> [Html] -> [Html]
664667toListItems opts items = map (toListItem opts) items ++ [nl opts]
tests/tables.html+14−14
@@ -6,7 +6,7 @@
66<th align="right">Right</th>
77<th align="left">Left</th>
88<th align="center">Center</th>
9−<th align="left">Default</th>
9+<th>Default</th>
1010</tr>
1111</thead>
1212<tbody>
@@ -14,19 +14,19 @@
1414<td align="right">12</td>
1515<td align="left">12</td>
1616<td align="center">12</td>
17−<td align="left">12</td>
17+<td>12</td>
1818</tr>
1919<tr class="even">
2020<td align="right">123</td>
2121<td align="left">123</td>
2222<td align="center">123</td>
23−<td align="left">123</td>
23+<td>123</td>
2424</tr>
2525<tr class="odd">
2626<td align="right">1</td>
2727<td align="left">1</td>
2828<td align="center">1</td>
29−<td align="left">1</td>
29+<td>1</td>
3030</tr>
3131</tbody>
3232</table>
@@ -37,7 +37,7 @@
3737<th align="right">Right</th>
3838<th align="left">Left</th>
3939<th align="center">Center</th>
40−<th align="left">Default</th>
40+<th>Default</th>
4141</tr>
4242</thead>
4343<tbody>
@@ -45,19 +45,19 @@
4545<td align="right">12</td>
4646<td align="left">12</td>
4747<td align="center">12</td>
48−<td align="left">12</td>
48+<td>12</td>
4949</tr>
5050<tr class="even">
5151<td align="right">123</td>
5252<td align="left">123</td>
5353<td align="center">123</td>
54−<td align="left">123</td>
54+<td>123</td>
5555</tr>
5656<tr class="odd">
5757<td align="right">1</td>
5858<td align="left">1</td>
5959<td align="center">1</td>
60−<td align="left">1</td>
60+<td>1</td>
6161</tr>
6262</tbody>
6363</table>
@@ -69,7 +69,7 @@
6969<th align="right">Right</th>
7070<th align="left">Left</th>
7171<th align="center">Center</th>
72−<th align="left">Default</th>
72+<th>Default</th>
7373</tr>
7474</thead>
7575<tbody>
@@ -77,19 +77,19 @@
7777<td align="right">12</td>
7878<td align="left">12</td>
7979<td align="center">12</td>
80−<td align="left">12</td>
80+<td>12</td>
8181</tr>
8282<tr class="even">
8383<td align="right">123</td>
8484<td align="left">123</td>
8585<td align="center">123</td>
86−<td align="left">123</td>
86+<td>123</td>
8787</tr>
8888<tr class="odd">
8989<td align="right">1</td>
9090<td align="left">1</td>
9191<td align="center">1</td>
92−<td align="left">1</td>
92+<td>1</td>
9393</tr>
9494</tbody>
9595</table>
@@ -192,13 +192,13 @@
192192<td align="center">First</td>
193193<td align="left">row</td>
194194<td align="right">12.0</td>
195−<td align="left">Example of a row that spans multiple lines.</td>
195+<td>Example of a row that spans multiple lines.</td>
196196</tr>
197197<tr class="even">
198198<td align="center">Second</td>
199199<td align="left">row</td>
200200<td align="right">5.0</td>
201−<td align="left">Here's another one. Note the blank line between rows.</td>
201+<td>Here's another one. Note the blank line between rows.</td>
202202</tr>
203203</tbody>
204204</table>