on master help sign in
Use better default TLS settings

On versions of tls pre-2.0.6, the default `Supported` had an empty list of `supportedCiphers`. Per discussion on [their issue][1], it seems like everyone was overriding it to `ciphersuite_default` anyway, hence the change at version 2.0.6 to make that default. But we're not doing that here! Luckily, the [default for `TLSSettings`][2] does do that override, so we can use that to get the right behaviour regardless of tls version. [1]: https://github.com/haskell-tls/hs-tls/pull/471 [2]: https://hackage.haskell.org/package/crypton-connection-0.4.0/docs/src/Network.Connection.Types.html#line-86

commit835683c75df14142b7a33297d7c3431bfaa9356c authorBen Millwood <thebenmachine+git@gmail.com> dateSat 21 Sep 2024, 19:26 (2 years ago) parentc1aaff3
1 file changed+1−1
Network/HTTP/Req.hs+1−1
Network/HTTP/Req.hs+1−1
@@ -607,7 +607,7 @@ globalManager = unsafePerformIO $ do
607607 let settings =
608608 L.mkManagerSettingsContext
609609 (Just context)
610− (NC.TLSSettingsSimple False False False def)
610+ def
611611 Nothing
612612 manager <- L.newManager settings
613613 newIORef manager