on c2c2ba3 help sign in
12 files changed+756−1110
since splitsnapshots
unifiedsplit
.github/dependabot.yml−6 .github/workflows/ci.yaml−47 .gitignore−1 .travis.yml+42 CHANGELOG.md−105 Network/HTTP/Req.hs+181−466 README.md+124−28 Setup.hs+6 cabal.project−4 httpbin-tests/Network/HTTP/ReqSpec.hs+141−161 pure-tests/Network/HTTP/ReqSpec.hs+194−224 req.cabal+68−68
.github/dependabot.ymldeleted−6
@@ -1,6 +0,0 @@
1−version: 2
2−updates:
3− - package-ecosystem: "github-actions"
4− directory: "/"
5− schedule:
6− interval: "weekly"
.github/workflows/ci.yamldeleted−47
@@ -1,47 +0,0 @@
1−name: CI
2−on:
3− push:
4− branches:
5− - master
6− pull_request:
7− types:
8− - opened
9− - synchronize
10−jobs:
11− ormolu:
12− runs-on: ubuntu-latest
13− steps:
14− - uses: actions/checkout@v4
15− - uses: haskell-actions/run-ormolu@v17
16− build:
17− runs-on: ubuntu-latest
18− needs: ormolu
19− strategy:
20− matrix:
21− cabal: ["3.12"]
22− ghc: ["9.6.3", "9.8.2", "9.10.1"]
23− steps:
24− - uses: actions/checkout@v4
25− - uses: haskell-actions/setup@v2
26− id: setup-haskell-cabal
27− with:
28− ghc-version: ${{ matrix.ghc }}
29− cabal-version: ${{ matrix.cabal }}
30− - run: cabal update
31− - run: cabal freeze
32− - uses: actions/cache@v4.2.3
33− with:
34− path: |
35− ${{ steps.setup-haskell-cabal.outputs.cabal-store }}
36− dist-newstyle
37− key: ${{ runner.os }}-${{ matrix.ghc }}-${{ hashFiles('cabal.project.freeze') }}
38− restore-keys: |
39− ${{ runner.os }}-${{ matrix.ghc }}-
40− - run: cabal format && git diff --exit-code --color=always
41− - run: cabal build
42− - run: |
43− docker pull kennethreitz/httpbin
44− docker run -p 1234:80 kennethreitz/httpbin &
45− cabal test
46− - run: cabal haddock
47− - run: cabal sdist
.gitignore−1
@@ -25,6 +25,5 @@ cabal.project.local
2525cabal.sandbox.config
2626dist-*/
2727dist/
28−hie.yaml
2928stack.yaml
3029stack.yaml.lock
.travis.ymlnew file+42
@@ -0,0 +1,42 @@
1+language: c
2+
3+sudo: false
4+
5+cache:
6+ directories:
7+ - ~/.cabal/packages
8+ - ~/.cabal/store
9+
10+env:
11+ global:
12+ # To avoid re-compilation it is important to use exactly the same
13+ # configuration for all steps.
14+ - CABAL_CONFIG="--enable-tests --enable-benchmarks --flags=dev"
15+
16+matrix:
17+ include:
18+ - env: CABALVER=3.0 GHCVER=8.6.5
19+ addons: {apt: {packages: [cabal-install-3.0,ghc-8.6.5], sources: [hvr-ghc]}}
20+ - env: CABALVER=3.0 GHCVER=8.8.3
21+ addons: {apt: {packages: [cabal-install-3.0,ghc-8.8.3], sources: [hvr-ghc]}}
22+ - env: CABALVER=3.0 GHCVER=8.10.1
23+ addons: {apt: {packages: [cabal-install-3.0,ghc-8.10.1], sources: [hvr-ghc]}}
24+
25+before_install:
26+ - export PATH=/opt/ghc/$GHCVER/bin:/opt/cabal/$CABALVER/bin:$PATH
27+
28+install:
29+ - cabal --version
30+ - ghc --version
31+ - travis_retry cabal new-update
32+
33+script:
34+ - cabal format
35+ - git diff --exit-code --color=always
36+ - cabal new-build $CABAL_CONFIG
37+ - cabal new-test $CABAL_CONFIG
38+ - cabal new-haddock $CABAL_CONFIG
39+ - cabal new-sdist
40+
41+notifications:
42+ email: false
CHANGELOG.md−105
@@ -1,108 +1,3 @@
1−## Req 3.13.4
2−
3−* Fixed empty ciphersuite list when compiling against `tls < 2.0.6`
4− (see [PR 175](https://github.com/mrkkrp/req/pull/175)). As a side effect, now
5− compatible with older versions of `crypton-connection` (>= 0.3).
6−
7−## Req 3.13.3
8−
9−* Works with `crypton-connection-0.4` and newer.
10−
11−## Req 3.13.2
12−
13−* Disable the problematic `httpbin-tests` test suite by default. Only enable
14− it when the `dev` flag is enabled. In that case it is expected that an
15− httpbin server is run locally at `localhost:1234`.
16−
17−## Req 3.13.1
18−
19−* Switched the non-pure test suite to use https://httpbun.org instead of
20− https://httpbin.org since the latter proved to be highly unreliable
21− lately.
22−
23−* Switched from `connection` to `crypton-connection`.
24−
25−* Builds with GHC 9.6.1.
26−
27−## Req 3.13.0
28−
29−* Add `headerRedacted` function to add header fields, which will be with
30− redacted values on print.
31−
32−## Req 3.12.0
33−
34−* Add `isStatusCodeException` function.
35−* Add `instance HttpResponse (Network.HTTP.Client.Response ())`.
36−
37−## Req 3.11.0
38−
39−* Add the `queryParamToList` method to the `QueryParam` type class.
40−* Add the `formToQuery` function. [Issue 126](https://github.com/mrkkrp/req/issues/126).
41−* Add `FromForm` instances (in the `Web.FormUrlEncoded` module) to the
42− `Option` and `FormUrlEncodedParam` types.
43−
44−## Req 3.10.0
45−
46−* Add `MonadHttp` instances for `transformers` types.
47−
48−## Req 3.9.2
49−
50−* The test suite works with `aeson-2.x.x.x`.
51−
52−## Req 3.9.1
53−
54−* Builds with GHC 9.0.
55−
56−## Req 3.9.0
57−
58−* The `useHttpURI` and `useHttpsURI` functions now preserve trailing
59− slashes.
60−
61−## Req 3.8.0
62−
63−* Adjusted the value of the `httpConfigRetryJudgeException` field of
64− `defaultHttpConfig` to retry on response timeouts and connection timeouts.
65−
66−## Req 3.7.0
67−
68−* Added `reqCb`, a function that allows you to modify the `Request` object
69− but otherwise performs the requst for you.
70−
71−* Derived `MonadThrow`, `MonadCatch`, and `MonadMask` for the `Req` monad.
72−
73−## Req 3.6.0
74−
75−* Added the `httpConfigBodyPreviewLength` configuration parameter to
76− `HttpConfig`.
77−
78−## Req 3.5.0
79−
80−* Made `Req` an instance of `MonadUnliftIO`. [Issue
81− 100](https://github.com/mrkkrp/req/issues/100).
82−
83−## Req 3.4.0
84−
85−* Requests using `DELETE` method can now have a body. [Issue
86− 89](https://github.com/mrkkrp/req/issues/89).
87−
88−* Added the `httpConfigRetryJudgeException` field to `HttpConfig` so that
89− requests that result in exceptions can be retried. [Issue
90− 93](https://github.com/mrkkrp/req/issues/93).
91−
92−* Added the function `renderUrl`. [Issue
93− 83](https://github.com/mrkkrp/req/issues/83).
94−
95−## Req 3.3.0
96−
97−* Derived `Show` instances for response types `IgnoreResponse`,
98− `JsonResponse`, `BsResponse`, and `LbsResponse`.
99−
100−## Req 3.2.0
101−
102−* Made the tests pass with `http-client-0.7` and later.
103−
104−* Added a quasiquoter for URL creation, `urlQ`.
105−
1061## Req 3.1.0
1072
1083* Changed signature of `httpConfigRetryPolicy` to `RetryPolicyM IO`.
Network/HTTP/Req.hs+181−466
@@ -1,10 +1,17 @@
1+{-# LANGUAGE BangPatterns #-}
12{-# LANGUAGE DataKinds #-}
3+{-# LANGUAGE DeriveDataTypeable #-}
4+{-# LANGUAGE DeriveGeneric #-}
5+{-# LANGUAGE FlexibleInstances #-}
6+{-# LANGUAGE GeneralizedNewtypeDeriving #-}
7+{-# LANGUAGE KindSignatures #-}
28{-# LANGUAGE LambdaCase #-}
9+{-# LANGUAGE MultiParamTypeClasses #-}
310{-# LANGUAGE OverloadedStrings #-}
411{-# LANGUAGE QuasiQuotes #-}
12+{-# LANGUAGE RankNTypes #-}
513{-# LANGUAGE RecordWildCards #-}
6−{-# LANGUAGE RoleAnnotations #-}
7−{-# LANGUAGE TemplateHaskellQuotes #-}
14+{-# LANGUAGE ScopedTypeVariables #-}
815{-# LANGUAGE TypeFamilies #-}
916{-# LANGUAGE UndecidableInstances #-}
1017
@@ -19,40 +26,61 @@
1926--
2027-- The documentation below is structured in such a way that the most
2128-- important information is presented first: you learn how to do HTTP
22−-- requests, how to embed them in the monad you have, and then it gives you
29+-- requests, how to embed them in any monad you have, and then it gives you
2330-- details about less-common things you may want to know about. The
2431-- documentation is written with sufficient coverage of details and
2532-- examples, and it's designed to be a complete tutorial on its own.
2633--
34+-- /(A modest intro goes here, click on 'req' to start making requests.)/
35+--
2736-- === About the library
2837--
29−-- Req is an HTTP client library that attempts to be easy-to-use, type-safe,
30−-- and expandable.
31−--
32−-- “Easy-to-use” means that the library is designed to be beginner-friendly
33−-- so it's simple to add to your monad stack, intuitive to work with,
34−-- well-documented, and does not get in your way. Doing HTTP requests is a
35−-- common task and a Haskell library for this should be approachable and
36−-- clear to beginners, thus certain compromises were made. For example, one
37−-- cannot currently modify 'L.ManagerSettings' of the default manager
38−-- because the library always uses the same implicit global manager for
39−-- simplicity and maximal connection sharing. There is a way to use your own
40−-- manager with different settings, but it requires more typing.
41−--
42−-- “Type-safe” means that the library tries to eliminate certain classes of
43−-- errors. For example, we have correct-by-construction URLs; it is
44−-- guaranteed that the user does not send the request body when using
45−-- methods like GET or OPTIONS, and the amount of implicit assumptions is
46−-- minimized by making the user specify their intentions in an explicit
47−-- form. For example, it's not possible to avoid specifying the body or the
48−-- method of a request. Authentication methods that assume HTTPS force the
49−-- user to use HTTPS at the type level.
50−--
51−-- “Expandable” refers to the ability to create new components without
52−-- having to resort to hacking. For example, it's possible to define your
53−-- own HTTP methods, create new ways to construct the body of a request,
54−-- create new authorization options, perform a request in a different way,
55−-- and create your own methods to parse a response.
38+-- Req is an easy-to-use, type-safe, expandable, high-level HTTP client
39+-- library that just works without any fooling around.
40+--
41+-- What does the phrase “easy-to-use” mean? It means that the library is
42+-- designed to be beginner-friendly so it's simple to add to your monad
43+-- stack, intuitive to work with, well-documented, and does not get in your
44+-- way. Doing HTTP requests is a common task and Haskell library for this
45+-- should be very approachable and clear to beginners, thus certain
46+-- compromises were made. For example, one cannot currently modify
47+-- 'L.ManagerSettings' of the default manager because the library always
48+-- uses the same implicit global manager for simplicity and maximal
49+-- connection sharing. There is a way to use your own manager with different
50+-- settings, but it requires a bit more typing.
51+--
52+-- “Type-safe” means that the library is protective and eliminates certain
53+-- classes of errors. For example, we have correct-by-construction 'Url's,
54+-- it's guaranteed that the user does not send the request body when using
55+-- methods like 'GET' or 'OPTIONS', and the amount of implicit assumptions
56+-- is minimized by making the user specify his\/her intentions in an
57+-- explicit form (for example, it's not possible to avoid specifying the
58+-- body or method of request). Authentication methods that assume HTTPS
59+-- force the user to use HTTPS at the type level. The library also carefully
60+-- hides underlying types from the lower-level @http-client@ package because
61+-- those types are not safe enough (for example 'L.Request' is an instance
62+-- of 'Data.String.IsString' and, if it's malformed, it will blow up at
63+-- run-time).
64+--
65+-- “Expandable” refers to the ability of the library to be expanded without
66+-- having to resort to ugly hacking. For example, it's possible to define
67+-- your own HTTP methods, create new ways to construct the body of a
68+-- request, create new authorization options, perform a request in a
69+-- different way, and create your own methods to parse and represent a
70+-- response. As the user extends the library to satisfy his\/her special
71+-- needs, the new solutions will work just like the built-ins. However, all
72+-- of the common cases are also covered by the library out-of-the-box.
73+--
74+-- “High-level” means that there are less details to worry about. The
75+-- library is a result of my experiences as a Haskell consultant. Working
76+-- for several clients, who had very different projects, showed me that the
77+-- library should adapt easily to any particular style of writing Haskell
78+-- applications. For example, some people prefer throwing exceptions, while
79+-- others are concerned with purity. Just define 'handleHttpException'
80+-- accordingly when making your monad instance of 'MonadHttp' and it will
81+-- play together seamlessly. Finally, the library cuts down boilerplate
82+-- considerably, and helps you write concise, easy to read, and maintainable
83+-- code.
5684--
5785-- === Using with other libraries
5886--
@@ -81,7 +109,6 @@ module Network.HTTP.Req
81109 -- $making-a-request
82110 req,
83111 reqBr,
84− reqCb,
85112 req',
86113 withReqManager,
87114
@@ -118,8 +145,6 @@ module Network.HTTP.Req
118145 useHttpURI,
119146 useHttpsURI,
120147 useURI,
121− urlQ,
122− renderUrl,
123148
124149 -- ** Body
125150 -- $body
@@ -144,13 +169,11 @@ module Network.HTTP.Req
144169 -- $query-parameters
145170 (=:),
146171 queryFlag,
147− formToQuery,
148172 QueryParam (..),
149173
150174 -- *** Headers
151175 header,
152176 attachHeader,
153− headerRedacted,
154177
155178 -- *** Cookies
156179 -- $cookies
@@ -197,78 +220,52 @@ module Network.HTTP.Req
197220
198221 -- * Other
199222 HttpException (..),
200− isStatusCodeException,
201223 CanHaveBody (..),
202224 Scheme (..),
203225 )
204226where
205227
206−import Blaze.ByteString.Builder qualified as BB
228+import qualified Blaze.ByteString.Builder as BB
207229import Control.Applicative
208230import Control.Arrow (first, second)
209−import Control.Exception hiding (Handler (..), TypeError)
210−import Control.Monad (guard, void, (>=>))
231+import Control.Exception hiding (TypeError)
211232import Control.Monad.Base
212−import Control.Monad.Catch (Handler (..), MonadCatch, MonadMask, MonadThrow)
213233import Control.Monad.IO.Class
214−import Control.Monad.IO.Unlift
215−import Control.Monad.Reader (ReaderT (ReaderT), ask, lift, runReaderT)
216−import Control.Monad.Trans.Accum (AccumT)
217−import Control.Monad.Trans.Cont (ContT)
234+import Control.Monad.Reader
218235import Control.Monad.Trans.Control
219−import Control.Monad.Trans.Except (ExceptT)
220−import Control.Monad.Trans.Identity (IdentityT)
221−import Control.Monad.Trans.Maybe (MaybeT)
222−import Control.Monad.Trans.RWS.CPS qualified as RWS.CPS
223−import Control.Monad.Trans.RWS.Lazy qualified as RWS.Lazy
224−import Control.Monad.Trans.RWS.Strict qualified as RWS.Strict
225−import Control.Monad.Trans.Select (SelectT)
226−import Control.Monad.Trans.State.Lazy qualified as State.Lazy
227−import Control.Monad.Trans.State.Strict qualified as State.Strict
228−import Control.Monad.Trans.Writer.CPS qualified as Writer.CPS
229−import Control.Monad.Trans.Writer.Lazy qualified as Writer.Lazy
230−import Control.Monad.Trans.Writer.Strict qualified as Writer.Strict
231236import Control.Retry
232237import Data.Aeson (FromJSON (..), ToJSON (..))
233−import Data.Aeson qualified as A
238+import qualified Data.Aeson as A
234239import Data.ByteString (ByteString)
235−import Data.ByteString qualified as B
236−import Data.ByteString.Lazy qualified as BL
237−import Data.CaseInsensitive qualified as CI
240+import qualified Data.ByteString as B
241+import qualified Data.ByteString.Lazy as BL
242+import qualified Data.CaseInsensitive as CI
238243import Data.Data (Data)
239−import Data.Default.Class (def)
240244import Data.Function (on)
241245import Data.IORef
242246import Data.Kind (Constraint, Type)
243247import Data.List (foldl', nubBy)
244248import Data.List.NonEmpty (NonEmpty (..))
245−import Data.List.NonEmpty qualified as NE
249+import qualified Data.List.NonEmpty as NE
246250import Data.Maybe (fromMaybe)
247251import Data.Proxy
248−import Data.Semigroup (Endo (..))
249−import Data.Set qualified as S
252+import Data.Semigroup hiding (Option, option)
250253import Data.Text (Text)
251−import Data.Text qualified as T
252−import Data.Text.Encoding qualified as T
253−import Data.Typeable (Typeable, cast)
254+import qualified Data.Text.Encoding as T
255+import Data.Typeable (Typeable)
254256import GHC.Generics
255257import GHC.TypeLits
256−import Language.Haskell.TH qualified as TH
257−import Language.Haskell.TH.Quote qualified as TH
258−import Language.Haskell.TH.Syntax qualified as TH
259−import Network.Connection qualified as NC
260−import Network.HTTP.Client qualified as L
261−import Network.HTTP.Client.Internal qualified as LI
262−import Network.HTTP.Client.MultipartFormData qualified as LM
263−import Network.HTTP.Client.TLS qualified as L
264−import Network.HTTP.Types qualified as Y
258+import qualified Network.Connection as NC
259+import qualified Network.HTTP.Client as L
260+import qualified Network.HTTP.Client.Internal as LI
261+import qualified Network.HTTP.Client.MultipartFormData as LM
262+import qualified Network.HTTP.Client.TLS as L
263+import qualified Network.HTTP.Types as Y
265264import System.IO.Unsafe (unsafePerformIO)
266265import Text.URI (URI)
267−import Text.URI qualified as URI
268−import Text.URI.QQ qualified as QQ
269−import Web.Authenticate.OAuth qualified as OAuth
270−import Web.FormUrlEncoded (FromForm (..), ToForm (..))
271−import Web.FormUrlEncoded qualified as Form
266+import qualified Text.URI as URI
267+import qualified Text.URI.QQ as QQ
268+import qualified Web.Authenticate.OAuth as OAuth
272269import Web.HttpApiData (ToHttpApiData (..))
273270
274271----------------------------------------------------------------------------
@@ -293,7 +290,7 @@ import Web.HttpApiData (ToHttpApiData (..))
293290--
294291-- @body@ is a body option such as 'NoReqBody' or 'ReqBodyJson'. The
295292-- tutorial has a section about HTTP bodies, but usage is very
296−-- straightforward and should be clear from the examples.
293+-- straightforward and should be clear from the examples below.
297294--
298295-- @response@ is a type hint how to make and interpret response of an HTTP
299296-- request. Out-of-the-box it can be the following:
@@ -421,7 +418,12 @@ req ::
421418 -- | Response
422419 m response
423420req method url body responseProxy options =
424− reqCb method url body responseProxy options pure
421+ reqBr method url body (options <> extraOptions) getHttpResponse
422+ where
423+ extraOptions =
424+ case acceptHeader responseProxy of
425+ Nothing -> mempty
426+ Just accept -> header "Accept" accept
425427
426428-- | A version of 'req' that does not use one of the predefined instances of
427429-- 'HttpResponse' but instead allows the user to consume @'L.Response'
@@ -446,58 +448,7 @@ reqBr ::
446448 (L.Response L.BodyReader -> IO a) ->
447449 -- | Result
448450 m a
449−reqBr method url body options consume =
450− req' method url body options (reqHandler consume)
451−
452−-- | A version of 'req' that takes a callback to modify the 'L.Request', but
453−-- otherwise performs the request identically.
454−--
455−-- @since 3.7.0
456−reqCb ::
457− ( MonadHttp m,
458− HttpMethod method,
459− HttpBody body,
460− HttpResponse response,
461− HttpBodyAllowed (AllowsBody method) (ProvidesBody body)
462− ) =>
463− -- | HTTP method
464− method ->
465− -- | 'Url'—location of resource
466− Url scheme ->
467− -- | Body of the request
468− body ->
469− -- | A hint how to interpret response
470− Proxy response ->
471− -- | Collection of optional parameters
472− Option scheme ->
473− -- | Callback to modify the request
474− (L.Request -> m L.Request) ->
475− -- | Response
476− m response
477−reqCb method url body responseProxy options adjustRequest =
478− req' method url body (options <> extraOptions) $ \request manager -> do
479− request' <- adjustRequest request
480− reqHandler getHttpResponse request' manager
481− where
482− extraOptions =
483− case acceptHeader responseProxy of
484− Nothing -> mempty
485− Just accept -> header "Accept" accept
486−
487−-- | The default handler function that the higher-level request functions
488−-- pass to 'req''. Internal function.
489−--
490−-- @since 3.7.0
491−reqHandler ::
492− (MonadHttp m) =>
493− -- | How to get final result from a 'L.Response'
494− (L.Response L.BodyReader -> IO b) ->
495− -- | 'L.Request' to perform
496− L.Request ->
497− -- | 'L.Manager' to use
498− L.Manager ->
499− m b
500−reqHandler consume request manager = do
451+reqBr method url body options consume = req' method url body options $ \request manager -> do
501452 HttpConfig {..} <- getHttpConfig
502453 let wrapVanilla = handle (throwIO . VanillaHttpException)
503454 wrapExc = handle (throwIO . LI.toHttpException request)
@@ -513,23 +464,12 @@ reqHandler consume request manager = do
513464 r' <- L.responseOpen request manager
514465 writeIORef rref (Just r')
515466 return r'
516− exceptionRetryPolicies =
517− skipAsyncExceptions
518− ++ [ \retryStatus -> Handler $ \e ->
519− return $ httpConfigRetryJudgeException retryStatus e
520− ]
521467 r <-
522468 retrying
523469 httpConfigRetryPolicy
524− (\retryStatus r -> return $ httpConfigRetryJudge retryStatus r)
525− ( const
526− ( recovering
527− httpConfigRetryPolicy
528− exceptionRetryPolicies
529− (const openResponse)
530− )
531− )
532− (preview, r') <- grabPreview httpConfigBodyPreviewLength r
470+ (\st r -> return $ httpConfigRetryJudge st r)
471+ (const openResponse)
472+ (preview, r') <- grabPreview bodyPreviewLength r
533473 mapM_ LI.throwHttp (httpConfigCheckResponse request r' preview)
534474 consume r'
535475 )
@@ -578,22 +518,22 @@ req' method url body options m = do
578518 nubHeaders
579519 <> getRequestMod options
580520 <> getRequestMod config
581− <> getRequestMod (Tagged body :: Tagged "body" body)
521+ <> getRequestMod (Womb body :: Womb "body" body)
582522 <> getRequestMod url
583− <> getRequestMod (Tagged method :: Tagged "method" method)
523+ <> getRequestMod (Womb method :: Womb "method" method)
584524 request <- finalizeRequest options request'
585525 withReqManager (m request)
586526
587527-- | Perform an action using the global implicit 'L.Manager' that the rest
588−-- of the library uses. This allows us to reuse connections that the
528+-- of the library uses. This allows to reuse connections that the
589529-- 'L.Manager' controls.
590−withReqManager :: (MonadIO m) => (L.Manager -> m a) -> m a
591−withReqManager m = m globalManager
530+withReqManager :: MonadIO m => (L.Manager -> m a) -> m a
531+withReqManager m = liftIO (readIORef globalManager) >>= m
592532
593−-- | The global 'L.Manager' that 'req' uses. Here we just go with the
594−-- default settings, so users don't need to deal with this manager stuff at
595−-- all, but when we create a request, instance 'HttpConfig' can affect the
596−-- default settings via 'getHttpConfig'.
533+-- | Global 'L.Manager' that 'req' uses. Here we just go with the default
534+-- settings, so users don't need to deal with this manager stuff at all, but
535+-- when we create a request, instance 'HttpConfig' can affect the default
536+-- settings via 'getHttpConfig'.
597537--
598538-- A note about safety, in case 'unsafePerformIO' looks suspicious to you.
599539-- The value of 'globalManager' is named and lives on top level. This means
@@ -601,16 +541,16 @@ withReqManager m = m globalManager
601541-- manager. From that moment on the 'IORef' will be just reused—exactly the
602542-- behavior we want here in order to maximize connection sharing. GHC could
603543-- spoil the plan by inlining the definition, hence the @NOINLINE@ pragma.
604−globalManager :: L.Manager
544+globalManager :: IORef L.Manager
605545globalManager = unsafePerformIO $ do
606546 context <- NC.initConnectionContext
607547 let settings =
608548 L.mkManagerSettingsContext
609549 (Just context)
610− def
550+ (NC.TLSSettingsSimple False False False)
611551 Nothing
612552 manager <- L.newManager settings
613− return manager
553+ newIORef manager
614554{-# NOINLINE globalManager #-}
615555
616556----------------------------------------------------------------------------
@@ -624,13 +564,13 @@ globalManager = unsafePerformIO $ do
624564-- When writing a library, keep your API polymorphic in terms of
625565-- 'MonadHttp', only define instance of 'MonadHttp' in final application.
626566-- Another option is to use a @newtype@-wrapped monad stack and define
627−-- 'MonadHttp' for it. As of the version /0.4.0/, the 'Req' monad that
628−-- follows this strategy is provided out-of-the-box (see below).
567+-- 'MonadHttp' for it. As of version /0.4.0/, the 'Req' monad that follows
568+-- this strategy is provided out-of-the-box (see below).
629569
630570-- | A type class for monads that support performing HTTP requests.
631571-- Typically, you only need to define the 'handleHttpException' method
632572-- unless you want to tweak 'HttpConfig'.
633−class (MonadIO m) => MonadHttp m where
573+class MonadIO m => MonadHttp m where
634574 -- | This method describes how to deal with 'HttpException' that was
635575 -- caught by the library. One option is to re-throw it if you are OK with
636576 -- exceptions, but if you prefer working with something like
@@ -638,16 +578,17 @@ class (MonadIO m) => MonadHttp m where
638578 -- 'Control.Monad.Except.throwError'.
639579 handleHttpException :: HttpException -> m a
640580
641− -- | Return the 'HttpConfig' to be used when performing HTTP requests.
642− -- Default implementation returns its 'def' value, which is described in
643− -- the documentation for the type. Common usage pattern with manually
644− -- defined 'getHttpConfig' is to return some hard-coded value, or a value
581+ -- | Return 'HttpConfig' to be used when performing HTTP requests. Default
582+ -- implementation returns its 'def' value, which is described in the
583+ -- documentation for the type. Common usage pattern with manually defined
584+ -- 'getHttpConfig' is to return some hard-coded value, or a value
645585 -- extracted from 'Control.Monad.Reader.MonadReader' if a more flexible
646586 -- approach to configuration is desirable.
647587 getHttpConfig :: m HttpConfig
648588 getHttpConfig = return defaultHttpConfig
649589
650−-- | 'HttpConfig' contains settings to be used when making HTTP requests.
590+-- | 'HttpConfig' contains general and default settings to be used when
591+-- making HTTP requests.
651592data HttpConfig = HttpConfig
652593 { -- | Proxy to use. By default values of @HTTP_PROXY@ and @HTTPS_PROXY@
653594 -- environment variables are respected, this setting overwrites them.
@@ -691,8 +632,8 @@ data HttpConfig = HttpConfig
691632 -- | The retry policy to use for request retrying. By default 'def' is
692633 -- used (see 'RetryPolicyM').
693634 --
694− -- __Note__: signature of this function was changed to disallow 'IO' in
695− -- version /1.0.0/ and then changed back to its current form in /3.1.0/.
635+ -- __Note__: signature of this function was changed in the version
636+ -- /1.0.0/.
696637 --
697638 -- @since 0.3.0
698639 httpConfigRetryPolicy :: RetryPolicyM IO,
@@ -703,21 +644,11 @@ data HttpConfig = HttpConfig
703644 -- /1.0.0/.
704645 --
705646 -- @since 0.3.0
706− httpConfigRetryJudge :: forall b. RetryStatus -> L.Response b -> Bool,
707− -- | Similar to 'httpConfigRetryJudge', but is used to decide when to
708− -- retry requests that resulted in an exception. By default it retries
709− -- on response timeout and connection timeout (changed in version
710− -- /3.8.0/).
711− --
712− -- @since 3.4.0
713− httpConfigRetryJudgeException :: RetryStatus -> SomeException -> Bool,
714− -- | Max length of preview fragment of response body.
715− --
716− -- @since 3.6.0
717− httpConfigBodyPreviewLength :: forall a. (Num a) => a
647+ httpConfigRetryJudge :: forall b. RetryStatus -> L.Response b -> Bool
718648 }
649+ deriving (Typeable)
719650
720−-- | The default value of 'HttpConfig'.
651+-- | Default value of 'HttpConfig'.
721652--
722653-- @since 2.0.0
723654defaultHttpConfig :: HttpConfig
@@ -739,16 +670,7 @@ defaultHttpConfig =
739670 524, -- A timeout occurred
740671 598, -- (Informal convention) Network read timeout error
741672 599 -- (Informal convention) Network connect timeout error
742− ],
743− httpConfigRetryJudgeException = \_ e ->
744− case fromException e of
745− Just (L.HttpExceptionRequest _ c) ->
746− case c of
747− L.ResponseTimeout -> True
748− L.ConnectionTimeout -> True
749− _ -> False
750− _ -> False,
751− httpConfigBodyPreviewLength = 1024
673+ ]
752674 }
753675 where
754676 statusCode = Y.statusCode . L.responseStatus
@@ -761,7 +683,7 @@ instance RequestComponent HttpConfig where
761683 LI.requestManagerOverride = httpConfigAltManager
762684 }
763685
764−-- | A monad that allows us to run 'req' in any 'IO'-enabled monad without
686+-- | A monad that allows to run 'req' in any 'IO'-enabled monad without
765687-- having to define new instances.
766688--
767689-- @since 0.4.0
@@ -770,19 +692,9 @@ newtype Req a = Req (ReaderT HttpConfig IO a)
770692 ( Functor,
771693 Applicative,
772694 Monad,
773− MonadIO,
774− MonadUnliftIO
695+ MonadIO
775696 )
776697
777−-- | @since 3.7.0
778−deriving instance MonadThrow Req
779−
780−-- | @since 3.7.0
781−deriving instance MonadCatch Req
782−
783−-- | @since 3.7.0
784−deriving instance MonadMask Req
785−
786698instance MonadBase IO Req where
787699 liftBase = liftIO
788700
@@ -797,87 +709,12 @@ instance MonadHttp Req where
797709 handleHttpException = Req . lift . throwIO
798710 getHttpConfig = Req ask
799711
800−-- | @since 3.10.0
801−instance (MonadHttp m, Monoid w) => MonadHttp (AccumT w m) where
802− handleHttpException = lift . handleHttpException
803− getHttpConfig = lift getHttpConfig
804−
805−-- | @since 3.10.0
806−instance (MonadHttp m) => MonadHttp (ContT r m) where
807− handleHttpException = lift . handleHttpException
808− getHttpConfig = lift getHttpConfig
809−
810−-- | @since 3.10.0
811−instance (MonadHttp m) => MonadHttp (ExceptT e m) where
812− handleHttpException = lift . handleHttpException
813− getHttpConfig = lift getHttpConfig
814−
815−-- | @since 3.10.0
816−instance (MonadHttp m) => MonadHttp (IdentityT m) where
817− handleHttpException = lift . handleHttpException
818− getHttpConfig = lift getHttpConfig
819−
820−-- | @since 3.10.0
821−instance (MonadHttp m) => MonadHttp (MaybeT m) where
822− handleHttpException = lift . handleHttpException
823− getHttpConfig = lift getHttpConfig
824−
825−-- | @since 3.10.0
826−instance (MonadHttp m) => MonadHttp (ReaderT r m) where
827− handleHttpException = lift . handleHttpException
828− getHttpConfig = lift getHttpConfig
829−
830−-- | @since 3.10.0
831−instance (MonadHttp m, Monoid w) => MonadHttp (RWS.CPS.RWST r w s m) where
832− handleHttpException = lift . handleHttpException
833− getHttpConfig = lift getHttpConfig
834−
835−-- | @since 3.10.0
836−instance (MonadHttp m, Monoid w) => MonadHttp (RWS.Lazy.RWST r w s m) where
837− handleHttpException = lift . handleHttpException
838− getHttpConfig = lift getHttpConfig
839−
840−-- | @since 3.10.0
841−instance (MonadHttp m, Monoid w) => MonadHttp (RWS.Strict.RWST r w s m) where
842− handleHttpException = lift . handleHttpException
843− getHttpConfig = lift getHttpConfig
844−
845−-- | @since 3.10.0
846−instance (MonadHttp m) => MonadHttp (SelectT r m) where
847− handleHttpException = lift . handleHttpException
848− getHttpConfig = lift getHttpConfig
849−
850−-- | @since 3.10.0
851−instance (MonadHttp m) => MonadHttp (State.Lazy.StateT s m) where
852− handleHttpException = lift . handleHttpException
853− getHttpConfig = lift getHttpConfig
854−
855−-- | @since 3.10.0
856−instance (MonadHttp m) => MonadHttp (State.Strict.StateT s m) where
857− handleHttpException = lift . handleHttpException
858− getHttpConfig = lift getHttpConfig
859−
860−-- | @since 3.10.0
861−instance (MonadHttp m, Monoid w) => MonadHttp (Writer.CPS.WriterT w m) where
862− handleHttpException = lift . handleHttpException
863− getHttpConfig = lift getHttpConfig
864−
865−-- | @since 3.10.0
866−instance (MonadHttp m, Monoid w) => MonadHttp (Writer.Lazy.WriterT w m) where
867− handleHttpException = lift . handleHttpException
868− getHttpConfig = lift getHttpConfig
869−
870−-- | @since 3.10.0
871−instance (MonadHttp m, Monoid w) => MonadHttp (Writer.Strict.WriterT w m) where
872− handleHttpException = lift . handleHttpException
873− getHttpConfig = lift getHttpConfig
874−
875712-- | Run a computation in the 'Req' monad with the given 'HttpConfig'. In
876−-- the case of an exceptional situation an 'HttpException' will be thrown.
713+-- case of exceptional situation an 'HttpException' will be thrown.
877714--
878715-- @since 0.4.0
879716runReq ::
880− (MonadIO m) =>
717+ MonadIO m =>
881718 -- | 'HttpConfig' to use
882719 HttpConfig ->
883720 -- | Computation to run
@@ -925,15 +762,14 @@ instance HttpMethod PUT where
925762 type AllowsBody PUT = 'CanHaveBody
926763 httpMethodName Proxy = Y.methodPut
927764
928−-- | 'DELETE' method. RFC 7231 allows a payload in DELETE but without
929−-- semantics.
930−--
931−-- __Note__: before version /3.4.0/ this method did not allow request
932−-- bodies.
765+-- | 'DELETE' method. This data type does not allow having request body with
766+-- 'DELETE' requests, as it should be. However some APIs may expect 'DELETE'
767+-- requests to have bodies, in that case define your own variation of
768+-- 'DELETE' method and allow it to have a body.
933769data DELETE = DELETE
934770
935771instance HttpMethod DELETE where
936− type AllowsBody DELETE = 'CanHaveBody
772+ type AllowsBody DELETE = 'NoBody
937773 httpMethodName Proxy = Y.methodDelete
938774
939775-- | 'TRACE' method.
@@ -982,7 +818,7 @@ class HttpMethod a where
982818 -- | Return name of the method as a 'ByteString'.
983819 httpMethodName :: Proxy a -> ByteString
984820
985−instance (HttpMethod method) => RequestComponent (Tagged "method" method) where
821+instance HttpMethod method => RequestComponent (Womb "method" method) where
986822 getRequestMod _ = Endo $ \x ->
987823 x {L.method = httpMethodName (Proxy :: Proxy method)}
988824
@@ -1024,20 +860,7 @@ instance (HttpMethod method) => RequestComponent (Tagged "method" method) where
1024860-- > -- https://%D1%8E%D0%BD%D0%B8%D0%BA%D0%BE%D0%B4.%D1%80%D1%84
1025861data Url (scheme :: Scheme) = Url Scheme (NonEmpty Text)
1026862 -- NOTE The second value is the path segments in reversed order.
1027− deriving (Eq, Ord, Show, Data, Generic)
1028−
1029−type role Url nominal
1030−
1031−-- With template-haskell >=2.15 and text >=1.2.4 Lift can be derived, however
1032−-- the derived lift forgets the type of the scheme.
1033−instance (Typeable scheme) => TH.Lift (Url scheme) where
1034− lift url =
1035− TH.dataToExpQ (fmap liftText . cast) url `TH.sigE` case url of
1036− Url Http _ -> [t|Url 'Http|]
1037− Url Https _ -> [t|Url 'Https|]
1038− where
1039− liftText t = TH.AppE (TH.VarE 'T.pack) <$> TH.lift (T.unpack t)
1040− liftTyped = TH.Code . TH.unsafeTExpCoerce . TH.lift
863+ deriving (Eq, Ord, Show, Data, Typeable, Generic)
1041864
1042865-- | Given host name, produce a 'Url' which has “http” as its scheme and
1043866-- empty path. This also sets port to @80@.
@@ -1049,33 +872,20 @@ http = Url Http . pure
1049872https :: Text -> Url 'Https
1050873https = Url Https . pure
1051874
1052−-- | Grow a given 'Url' appending a single path segment to it. Note that the
875+-- | Grow given 'Url' appending a single path segment to it. Note that the
1053876-- path segment can be of any type that is an instance of 'ToHttpApiData'.
1054877infixl 5 /~
1055878
1056−(/~) :: (ToHttpApiData a) => Url scheme -> a -> Url scheme
879+(/~) :: ToHttpApiData a => Url scheme -> a -> Url scheme
1057880Url secure path /~ segment = Url secure (NE.cons (toUrlPiece segment) path)
1058881
1059−-- | A type-constrained version of @('/~')@ to remove ambiguity in the cases
882+-- | Type-constrained version of @('/~')@ to remove ambiguity in the cases
1060883-- when next URL piece is a 'Data.Text.Text' literal.
1061884infixl 5 /:
1062885
1063886(/:) :: Url scheme -> Text -> Url scheme
1064887(/:) = (/~)
1065888
1066−-- | Render a 'Url' as 'Text'.
1067−--
1068−-- @since 3.4.0
1069−renderUrl :: Url scheme -> Text
1070−renderUrl = \case
1071− Url Https parts ->
1072− "https://" <> renderParts parts
1073− Url Http parts ->
1074− "http://" <> renderParts parts
1075− where
1076− renderParts parts =
1077− T.intercalate "/" (reverse $ NE.toList parts)
1078−
1079889-- | The 'useHttpURI' function provides an alternative method to get 'Url'
1080890-- (possibly with some 'Option's) from a 'URI'. This is useful when you are
1081891-- given a URL to query dynamically and don't know it beforehand.
@@ -1089,7 +899,8 @@ useHttpURI uri = do
1089899 urlHead <- http <$> uriHost uri
1090900 let url = case URI.uriPath uri of
1091901 Nothing -> urlHead
1092− Just uriPath -> uriPathToUrl uriPath urlHead
902+ Just (_, xs) ->
903+ foldl' (/:) urlHead (URI.unRText <$> NE.toList xs)
1093904 return (url, uriOptions uri)
1094905
1095906-- | Just like 'useHttpURI', but expects the “https” scheme.
@@ -1101,21 +912,10 @@ useHttpsURI uri = do
1101912 urlHead <- https <$> uriHost uri
1102913 let url = case URI.uriPath uri of
1103914 Nothing -> urlHead
1104− Just uriPath -> uriPathToUrl uriPath urlHead
915+ Just (_, xs) ->
916+ foldl' (/:) urlHead (URI.unRText <$> NE.toList xs)
1105917 return (url, uriOptions uri)
1106918
1107−-- | Convert URI path to a 'Url'. Internal.
1108−--
1109−-- @since 3.9.0
1110−uriPathToUrl ::
1111− (Bool, NonEmpty (URI.RText 'URI.PathPiece)) ->
1112− Url scheme ->
1113− Url scheme
1114−uriPathToUrl (trailingSlash, xs) urlHead =
1115− if trailingSlash then path /: T.empty else path
1116− where
1117− path = foldl' (/:) urlHead (URI.unRText <$> NE.toList xs)
1118−
1119919-- | A combination of 'useHttpURI' and 'useHttpsURI' for cases when scheme
1120920-- is not known in advance.
1121921--
@@ -1137,29 +937,6 @@ uriHost uri = case URI.uriAuthority uri of
1137937 Right URI.Authority {..} ->
1138938 Just (URI.unRText authHost)
1139939
1140−-- | A quasiquoter to build an 'Url' and 'Option' tuple. The type of the
1141−-- generated expression is @('Url' scheme0, 'Option' scheme1)@ with
1142−-- @scheme0@ being either 'Http' or 'Https' depending on the input.
1143−--
1144−-- @since 3.2.0
1145−urlQ :: TH.QuasiQuoter
1146−urlQ =
1147− TH.QuasiQuoter
1148− { quoteExp = \str ->
1149− case URI.mkURI (T.pack str) of
1150− Left err -> fail (displayException err)
1151− Right uri -> case useURI uri of
1152− Nothing -> fail "Not a HTTP or HTTPS URL"
1153− Just eurl ->
1154− TH.tupE
1155− [ either (TH.lift . fst) (TH.lift . fst) eurl,
1156− [|uriOptions uri|]
1157− ],
1158− quotePat = error "This usage is not supported",
1159− quoteType = error "This usage is not supported",
1160− quoteDec = error "This usage is not supported"
1161− }
1162−
1163940-- | An internal helper function to extract 'Option's from a 'URI'.
1164941uriOptions :: forall scheme. URI -> Option scheme
1165942uriOptions uri =
@@ -1232,21 +1009,21 @@ data NoReqBody = NoReqBody
12321009instance HttpBody NoReqBody where
12331010 getRequestBody NoReqBody = L.RequestBodyBS B.empty
12341011
1235−-- | This body option allows us to use a JSON object as the request
1236−-- body—probably the most popular format right now. Just wrap a data type
1237−-- that is an instance of 'ToJSON' type class and you are done: it will be
1238−-- converted to JSON and inserted as request body.
1012+-- | This body option allows to use a JSON object as request body—probably
1013+-- the most popular format right now. Just wrap a data type that is an
1014+-- instance of 'ToJSON' type class and you are done: it will be converted to
1015+-- JSON and inserted as request body.
12391016--
12401017-- This body option sets the @Content-Type@ header to @\"application/json;
12411018-- charset=utf-8\"@ value.
12421019newtype ReqBodyJson a = ReqBodyJson a
12431020
1244−instance (ToJSON a) => HttpBody (ReqBodyJson a) where
1021+instance ToJSON a => HttpBody (ReqBodyJson a) where
12451022 getRequestBody (ReqBodyJson a) = L.RequestBodyLBS (A.encode a)
12461023 getRequestContentType _ = pure "application/json; charset=utf-8"
12471024
12481025-- | This body option streams request body from a file. It is expected that
1249−-- the file size does not change during streaming.
1026+-- the file size does not change during the streaming.
12501027--
12511028-- Using of this body option does not set the @Content-Type@ header.
12521029newtype ReqBodyFile = ReqBodyFile FilePath
@@ -1271,11 +1048,12 @@ newtype ReqBodyLbs = ReqBodyLbs BL.ByteString
12711048instance HttpBody ReqBodyLbs where
12721049 getRequestBody (ReqBodyLbs bs) = L.RequestBodyLBS bs
12731050
1274−-- | URL-encoded body. This can hold a collection of parameters which are
1275−-- encoded similarly to query parameters at the end of query string, with
1276−-- the only difference that they are stored in request body. The similarity
1277−-- is reflected in the API as well, as you can use the same combinators you
1278−-- would use to add query parameters: @('=:')@ and 'queryFlag'.
1051+-- | Form URL-encoded body. This can hold a collection of parameters which
1052+-- are encoded similarly to query parameters at the end of query string,
1053+-- with the only difference that they are stored in request body. The
1054+-- similarity is reflected in the API as well, as you can use the same
1055+-- combinators you would use to add query parameters: @('=:')@ and
1056+-- 'queryFlag'.
12791057--
12801058-- This body option sets the @Content-Type@ header to
12811059-- @\"application/x-www-form-urlencoded\"@ value.
@@ -1294,13 +1072,6 @@ newtype FormUrlEncodedParam = FormUrlEncodedParam [(Text, Maybe Text)]
12941072instance QueryParam FormUrlEncodedParam where
12951073 queryParam name mvalue =
12961074 FormUrlEncodedParam [(name, toQueryParam <$> mvalue)]
1297− queryParamToList (FormUrlEncodedParam p) = p
1298−
1299−-- | Use 'formToQuery'.
1300−--
1301−-- @since 3.11.0
1302−instance FromForm FormUrlEncodedParam where
1303− fromForm = Right . formToQuery
13041075
13051076-- | Multipart form data. Please consult the
13061077-- "Network.HTTP.Client.MultipartFormData" module for how to construct
@@ -1340,7 +1111,7 @@ instance HttpBody ReqBodyMultipart where
13401111-- | Create 'ReqBodyMultipart' request body from a collection of 'LM.Part's.
13411112--
13421113-- @since 0.2.0
1343−reqBodyMultipart :: (MonadIO m) => [LM.Part] -> m ReqBodyMultipart
1114+reqBodyMultipart :: MonadIO m => [LM.Part] -> m ReqBodyMultipart
13441115reqBodyMultipart parts = liftIO $ do
13451116 boundary <- LM.webkitBoundary
13461117 body <- LM.renderParts boundary parts
@@ -1368,6 +1139,9 @@ type family ProvidesBody body :: CanHaveBody where
13681139-- | This type function allows any HTTP body if method says it
13691140-- 'CanHaveBody'. When the method says it should have 'NoBody', the only
13701141-- body option to use is 'NoReqBody'.
1142+--
1143+-- __Note__: users of GHC 8.0.1 and later will see a slightly more friendly
1144+-- error message when method does not allow a body and body is provided.
13711145type family
13721146 HttpBodyAllowed
13731147 (allowsBody :: CanHaveBody)
@@ -1380,8 +1154,8 @@ type family
13801154 TypeError
13811155 ('Text "This HTTP method does not allow attaching a request body.")
13821156
1383−instance (HttpBody body) => RequestComponent (Tagged "body" body) where
1384− getRequestMod (Tagged body) = Endo $ \x ->
1157+instance HttpBody body => RequestComponent (Womb "body" body) where
1158+ getRequestMod (Womb body) = Endo $ \x ->
13851159 x
13861160 { L.requestBody = getRequestBody body,
13871161 L.requestHeaders =
@@ -1410,8 +1184,8 @@ data Option (scheme :: Scheme)
14101184 = Option (Endo (Y.QueryText, L.Request)) (Maybe (L.Request -> IO L.Request))
14111185
14121186-- NOTE 'QueryText' is just [(Text, Maybe Text)], we keep it along with
1413−-- Request to avoid appending to an existing query string in request every
1414−-- time new parameter is added. The additional Maybe (L.Request -> IO
1187+-- Request to avoid appending to existing query string in request every
1188+-- time new parameter is added. Additional Maybe (L.Request -> IO
14151189-- L.Request) is a finalizer that will be applied after all other
14161190-- transformations. This is for authentication methods that sign requests
14171191-- based on data in Request.
@@ -1426,12 +1200,6 @@ instance Monoid (Option scheme) where
14261200 mempty = Option mempty Nothing
14271201 mappend = (<>)
14281202
1429−-- | Use 'formToQuery'.
1430−--
1431−-- @since 3.11.0
1432−instance FromForm (Option scheme) where
1433− fromForm = Right . formToQuery
1434−
14351203-- | A helper to create an 'Option' that modifies only collection of query
14361204-- parameters. This helper is not a part of the public API.
14371205withQueryParams :: (Y.QueryText -> Y.QueryText) -> Option scheme
@@ -1450,7 +1218,7 @@ instance RequestComponent (Option scheme) where
14501218
14511219-- | Finalize given 'L.Request' by applying a finalizer from the given
14521220-- 'Option' (if it has any).
1453−finalizeRequest :: (MonadIO m) => Option scheme -> L.Request -> m L.Request
1221+finalizeRequest :: MonadIO m => Option scheme -> L.Request -> m L.Request
14541222finalizeRequest (Option _ mfinalizer) = liftIO . fromMaybe pure mfinalizer
14551223
14561224----------------------------------------------------------------------------
@@ -1474,7 +1242,7 @@ infix 7 =:
14741242(=:) :: (QueryParam param, ToHttpApiData a) => Text -> a -> param
14751243name =: value = queryParam name (pure value)
14761244
1477−-- | Construct a flag, that is, a valueless query parameter. For example, in
1245+-- | Construct a flag, that is, valueless query parameter. For example, in
14781246-- the following URL @\"a\"@ is a flag, while @\"b\"@ is a query parameter
14791247-- with a value:
14801248--
@@ -1483,27 +1251,9 @@ name =: value = queryParam name (pure value)
14831251-- This operator is defined in terms of 'queryParam':
14841252--
14851253-- > queryFlag name = queryParam name (Nothing :: Maybe ())
1486−queryFlag :: (QueryParam param) => Text -> param
1254+queryFlag :: QueryParam param => Text -> param
14871255queryFlag name = queryParam name (Nothing :: Maybe ())
14881256
1489−-- | Construct query parameters from a 'ToForm' instance. This function
1490−-- produces the same query params as 'Form.urlEncodeAsFormStable'.
1491−--
1492−-- Note that 'Form.Form' doesn't have the concept of parameters with the
1493−-- empty value (i.e. what you can get by @key =: ""@). If the value is
1494−-- empty, it will be encoded as a valueless parameter (i.e. what you can get
1495−-- by @queryFlag key@).
1496−--
1497−-- @since 3.11.0
1498−formToQuery :: (QueryParam param, Monoid param, ToForm f) => f -> param
1499−formToQuery f = mconcat . fmap toParam . Form.toListStable $ toForm f
1500− where
1501− toParam (key, val) =
1502− queryParam key $
1503− if val == ""
1504− then Nothing
1505− else Just val
1506−
15071257-- | A type class for query-parameter-like things. The reason to have an
15081258-- overloaded 'queryParam' is to be able to use it as an 'Option' and as a
15091259-- 'FormUrlEncodedParam' when constructing form URL encoded request bodies.
@@ -1513,17 +1263,11 @@ class QueryParam param where
15131263 -- 'Nothing', it won't be included at all (i.e. you create a flag this
15141264 -- way). It's recommended to use @('=:')@ and 'queryFlag' instead of this
15151265 -- method, because they are easier to read.
1516− queryParam :: (ToHttpApiData a) => Text -> Maybe a -> param
1517−
1518− -- | Get the query parameter names and values set by 'queryParam'.
1519− --
1520− -- @since 3.11.0
1521− queryParamToList :: param -> [(Text, Maybe Text)]
1266+ queryParam :: ToHttpApiData a => Text -> Maybe a -> param
15221267
15231268instance QueryParam (Option scheme) where
15241269 queryParam name mvalue =
15251270 withQueryParams ((:) (name, toQueryParam <$> mvalue))
1526− queryParamToList (Option f _) = fst $ appEndo f ([], L.defaultRequest)
15271271
15281272----------------------------------------------------------------------------
15291273-- Request—Optional parameters—Headers
@@ -1547,14 +1291,6 @@ attachHeader :: ByteString -> ByteString -> L.Request -> L.Request
15471291attachHeader name value x =
15481292 x {L.requestHeaders = (CI.mk name, value) : L.requestHeaders x}
15491293
1550−-- | Same as 'header', but with redacted values on print.
1551−--
1552−-- @since 3.13.0
1553−headerRedacted :: ByteString -> ByteString -> Option scheme
1554−headerRedacted name value = withRequest $ \x ->
1555− let y = attachHeader name value x
1556− in y {L.redactHeaders = CI.mk name `S.insert` L.redactHeaders y}
1557−
15581294----------------------------------------------------------------------------
15591295-- Request—Optional parameters—Cookies
15601296
@@ -1696,7 +1432,7 @@ customAuth = Option mempty . pure
16961432
16971433-- | Specify the port to connect to explicitly. Normally, 'Url' you use
16981434-- determines the default port: @80@ for HTTP and @443@ for HTTPS. This
1699−-- 'Option' allows us to choose an arbitrary port overwriting the defaults.
1435+-- 'Option' allows to choose an arbitrary port overwriting the defaults.
17001436port :: Int -> Option scheme
17011437port n = withRequest $ \x ->
17021438 x {L.port = n}
@@ -1711,8 +1447,8 @@ port n = withRequest $ \x ->
17111447--
17121448-- > decompress (const True)
17131449decompress ::
1714− -- | Predicate that is given MIME type, it returns 'True' when content
1715− -- should be decompressed on the fly.
1450+ -- | Predicate that is given MIME type, it
1451+ -- returns 'True' when content should be decompressed on the fly.
17161452 (ByteString -> Bool) ->
17171453 Option scheme
17181454decompress f = withRequest $ \x ->
@@ -1743,7 +1479,6 @@ httpVersion major minor = withRequest $ \x ->
17431479
17441480-- | Make a request and ignore the body of the response.
17451481newtype IgnoreResponse = IgnoreResponse (L.Response ())
1746− deriving (Show)
17471482
17481483instance HttpResponse IgnoreResponse where
17491484 type HttpResponseBody IgnoreResponse = ()
@@ -1760,9 +1495,8 @@ ignoreResponse = Proxy
17601495-- monad in which you use 'req' will determine what to do in the case when
17611496-- parsing fails (the 'JsonHttpException' constructor will be used).
17621497newtype JsonResponse a = JsonResponse (L.Response a)
1763− deriving (Show)
17641498
1765−instance (FromJSON a) => HttpResponse (JsonResponse a) where
1499+instance FromJSON a => HttpResponse (JsonResponse a) where
17661500 type HttpResponseBody (JsonResponse a) = a
17671501 toVanillaResponse (JsonResponse r) = r
17681502 getHttpResponse r = do
@@ -1780,7 +1514,6 @@ jsonResponse = Proxy
17801514-- | Make a request and interpret the body of the response as a strict
17811515-- 'ByteString'.
17821516newtype BsResponse = BsResponse (L.Response ByteString)
1783− deriving (Show)
17841517
17851518instance HttpResponse BsResponse where
17861519 type HttpResponseBody BsResponse = ByteString
@@ -1797,7 +1530,6 @@ bsResponse = Proxy
17971530-- | Make a request and interpret the body of the response as a lazy
17981531-- 'BL.ByteString'.
17991532newtype LbsResponse = LbsResponse (L.Response BL.ByteString)
1800− deriving (Show)
18011533
18021534instance HttpResponse LbsResponse where
18031535 type HttpResponseBody LbsResponse = BL.ByteString
@@ -1814,7 +1546,7 @@ lbsResponse = Proxy
18141546----------------------------------------------------------------------------
18151547-- Helpers for response interpretations
18161548
1817−-- | Fetch beginning of the response and return it together with a new
1549+-- | Fetch beginning of response and return it together with new
18181550-- @'L.Response' 'L.BodyReader'@ that can be passed to 'getHttpResponse' and
18191551-- such.
18201552grabPreview ::
@@ -1878,14 +1610,14 @@ brReadN br n = go 0 id id
18781610
18791611-- | Get the response body.
18801612responseBody ::
1881− (HttpResponse response) =>
1613+ HttpResponse response =>
18821614 response ->
18831615 HttpResponseBody response
18841616responseBody = L.responseBody . toVanillaResponse
18851617
18861618-- | Get the response status code.
18871619responseStatusCode ::
1888− (HttpResponse response) =>
1620+ HttpResponse response =>
18891621 response ->
18901622 Int
18911623responseStatusCode =
@@ -1893,7 +1625,7 @@ responseStatusCode =
18931625
18941626-- | Get the response status message.
18951627responseStatusMessage ::
1896− (HttpResponse response) =>
1628+ HttpResponse response =>
18971629 response ->
18981630 ByteString
18991631responseStatusMessage =
@@ -1901,7 +1633,7 @@ responseStatusMessage =
19011633
19021634-- | Lookup a particular header from a response.
19031635responseHeader ::
1904− (HttpResponse response) =>
1636+ HttpResponse response =>
19051637 -- | Response interpretation
19061638 response ->
19071639 -- | Header to lookup
@@ -1913,7 +1645,7 @@ responseHeader r h =
19131645
19141646-- | Get the response 'L.CookieJar'.
19151647responseCookieJar ::
1916− (HttpResponse response) =>
1648+ HttpResponse response =>
19171649 response ->
19181650 L.CookieJar
19191651responseCookieJar = L.responseCookieJar . toVanillaResponse
@@ -1926,9 +1658,9 @@ responseCookieJar = L.responseCookieJar . toVanillaResponse
19261658-- To create a new response interpretation you just need to make your data
19271659-- type an instance of the 'HttpResponse' type class.
19281660
1929−-- | A type class for response interpretations. It allows us to describe how
1930−-- to consume the response from a @'L.Response' 'L.BodyReader'@ and produce
1931−-- the final result that is to be returned to the user.
1661+-- | A type class for response interpretations. It allows to describe how to
1662+-- consume response from a @'L.Response' 'L.BodyReader'@ and produce the
1663+-- final result that is to be returned to the user.
19321664class HttpResponse response where
19331665 -- | The associated type is the type of body that can be extracted from an
19341666 -- instance of 'HttpResponse'.
@@ -1967,16 +1699,6 @@ class HttpResponse response where
19671699 acceptHeader :: Proxy response -> Maybe ByteString
19681700 acceptHeader Proxy = Nothing
19691701
1970−-- | This instance has been added to make it easier to inspect 'L.Response'
1971−-- using Req's functions like 'responseStatusCode', 'responseStatusMessage',
1972−-- etc.
1973−--
1974−-- @since 3.12.0
1975−instance HttpResponse (L.Response ()) where
1976− type HttpResponseBody (L.Response ()) = ()
1977− toVanillaResponse = id
1978− getHttpResponse = return . void
1979−
19801702----------------------------------------------------------------------------
19811703-- Other
19821704
@@ -2002,7 +1724,7 @@ class RequestComponent a where
20021724-- method@ and @'HttpBody' body => 'RequestComponent' body@ when it decides
20031725-- which instance to use (i.e. the constraints are taken into account later,
20041726-- when instance is already chosen).
2005−newtype Tagged (tag :: Symbol) a = Tagged a
1727+newtype Womb (tag :: Symbol) a = Womb a
20061728
20071729-- | Exceptions that this library throws.
20081730data HttpException
@@ -2011,24 +1733,10 @@ data HttpException
20111733 | -- | A wrapper with Aeson-produced 'String' describing why decoding
20121734 -- failed
20131735 JsonHttpException String
2014− deriving (Show, Generic)
1736+ deriving (Show, Typeable, Generic)
20151737
20161738instance Exception HttpException
20171739
2018−-- | Return 'Just' if the given 'HttpException' is wrapping a http-client's
2019−-- 'L.StatusCodeException'. Otherwise, return 'Nothing'.
2020−--
2021−-- @since 3.12.0
2022−isStatusCodeException :: HttpException -> Maybe (L.Response ())
2023−isStatusCodeException
2024− ( VanillaHttpException
2025− ( L.HttpExceptionRequest
2026− _
2027− (L.StatusCodeException r _)
2028− )
2029− ) = Just r
2030−isStatusCodeException _ = Nothing
2031−
20321740-- | A simple type isomorphic to 'Bool' that we only have for better error
20331741-- messages. We use it as a kind and its data constructors as type-level
20341742-- tags.
@@ -2048,4 +1756,11 @@ data Scheme
20481756 Http
20491757 | -- | HTTPS
20501758 Https
2051− deriving (Eq, Ord, Show, Data, Generic, TH.Lift)
1759+ deriving (Eq, Ord, Show, Data, Typeable, Generic)
1760+
1761+----------------------------------------------------------------------------
1762+-- Constants
1763+
1764+-- | Max length of preview fragment of response body.
1765+bodyPreviewLength :: Num a => a
1766+bodyPreviewLength = 1024
README.md+124−28
@@ -4,8 +4,10 @@
44[![Hackage](https://img.shields.io/hackage/v/req.svg?style=flat)](https://hackage.haskell.org/package/req)
55[![Stackage Nightly](http://stackage.org/package/req/badge/nightly)](http://stackage.org/nightly/package/req)
66[![Stackage LTS](http://stackage.org/package/req/badge/lts)](http://stackage.org/lts/package/req)
7−[![CI](https://github.com/mrkkrp/req/actions/workflows/ci.yaml/badge.svg)](https://github.com/mrkkrp/req/actions/workflows/ci.yaml)
7+[![Build Status](https://travis-ci.org/mrkkrp/req.svg?branch=master)](https://travis-ci.org/mrkkrp/req)
88
9+* [Motivation and Req vs other libraries](#motivation-and-req-vs-other-libraries)
10+* [Unsolved problems](#unsolved-problems)
911* [Related packages](#related-packages)
1012* [Blog posts](#blog-posts)
1113* [Contribution](#contribution)
@@ -41,33 +43,49 @@ main = runReq defaultHttpConfig $ do
4143 liftIO $ print (responseBody r :: Value)
4244```
4345
44−Req is an HTTP client library that attempts to be easy-to-use, type-safe,
45−and expandable.
46−
47−“Easy-to-use” means that the library is designed to be beginner-friendly so
48−it's simple to add to your monad stack, intuitive to work with,
49−well-documented, and does not get in your way. Doing HTTP requests is a
50−common task and a Haskell library for this should be approachable and clear
51−to beginners, thus certain compromises were made. For example, one cannot
52−currently modify `ManagerSettings` of the default manager because the
53−library always uses the same implicit global manager for simplicity and
54−maximal connection sharing. There is a way to use your own manager with
55−different settings, but it requires more typing.
56−
57−“Type-safe” means that the library tries to eliminate certain classes of
58−errors. For example, we have correct-by-construction URLs; it is guaranteed
59−that the user does not send the request body when using methods like GET or
60−OPTIONS, and the amount of implicit assumptions is minimized by making the
61−user specify their intentions in an explicit form. For example, it's not
62−possible to avoid specifying the body or the method of a request.
46+Req is an easy-to-use, type-safe, expandable, high-level HTTP client library
47+that just works without any fooling around.
48+
49+What does the phrase “easy-to-use” mean? It means that the library is
50+designed to be beginner-friendly so it's simple to add to your monad stack,
51+intuitive to work with, well-documented, and does not get in your way. Doing
52+HTTP requests is a common task and Haskell library for this should be very
53+approachable and clear to beginners, thus certain compromises were made. For
54+example, one cannot currently modify `ManagerSettings` of the default
55+manager because the library always uses the same implicit global manager for
56+simplicity and maximal connection sharing. There is a way to use your own
57+manager with different settings, but it requires a bit more typing.
58+
59+“Type-safe” means that the library is protective and eliminates certain
60+classes of errors. For example, we have correct-by-construction URLs, it's
61+guaranteed that the user does not send the request body when using methods
62+like GET or OPTIONS, and the amount of implicit assumptions is minimized by
63+making the user specify his/her intentions in an explicit form (for example,
64+it's not possible to avoid specifying the body or method of request).
6365Authentication methods that assume HTTPS force the user to use HTTPS at the
64−type level.
65−
66−“Expandable” refers to the ability to create new components without having
67−to resort to hacking. For example, it's possible to define your own HTTP
68−methods, create new ways to construct the body of a request, create new
69−authorization options, perform a request in a different way, and create your
70−own methods to parse a response.
66+type level. The library also carefully hides underlying types from the
67+lower-level `http-client` package because those types are not safe enough
68+(for example `Request` is an instance of `IsString` and, if it's malformed,
69+it will blow up at run-time).
70+
71+“Expandable” refers to the ability to create new components for dealing with
72+HTTP without having to resort to ugly hacking. For example, it's possible to
73+define your own HTTP methods, create new ways to construct the body of a
74+request, create new authorization options, perform a request in a different
75+way, and create your own methods to parse and represent a response. As the
76+user extends the library to satisfy his/her special needs, the new solutions
77+will work just like the built-ins. However, all of the common cases are also
78+covered by the library out-of-the-box.
79+
80+“High-level” means that there are less details to worry about. The library
81+is a result of my experiences as a Haskell consultant. Working for several
82+clients, who had very different projects, showed me that the library should
83+adapt easily to any particular style of writing Haskell applications. For
84+example, some people prefer throwing exceptions, while others are concerned
85+with purity. Just define `handleHttpException` accordingly when making your
86+monad instance of `MonadHttp` and it will play together seamlessly. Finally,
87+the library cuts down boilerplate considerably, and helps you write concise,
88+easy to read, and maintainable code.
7189
7290The library uses the following mature packages under the hood to guarantee
7391you the best experience:
@@ -77,11 +95,89 @@ you the best experience:
7795* [`http-client-tls`](https://hackage.haskell.org/package/http-client-tls)—TLS
7896 (HTTPS) support for `http-client`.
7997
80−It is important to note that since we leverage well-known libraries that the
98+It's important to note that since we leverage well-known libraries that the
8199whole Haskell ecosystem uses, there is no risk in using Req. The machinery
82100for performing requests is the same as with `http-conduit` and Wreq. The
83101only difference is the API.
84102
103+## Motivation and Req vs other libraries
104+
105+*This section is my opinion and it contains criticisms of other well-known
106+libraries. If you're a user/fan of one of these libraries, please remember
107+not to react aggressively and respect the fact that I may have different
108+views on API design from yours.*
109+
110+I have spent time to write the library because sending HTTP requests is a
111+common need, but there is no high-level library for that in Haskell that I
112+could use with pleasure. I'll explain why.
113+
114+First of all, there is `http-client` and `http-client-tls`. They just work.
115+I have no issues with the libraries except that they are too low-level for
116+my taste. Indeed, even the docs say that they are low-level and “intended as
117+a base layer for more user-friendly packages”. This is exactly how I use
118+them in Req, as base level. Req is nothing but a different API to
119+`http-client`, so it only works because of the hard work put into
120+`http-client`.
121+
122+`http-conduit` definitely has its place. For one thing it allows you to
123+stream request and response bodies in constant memory, what other library
124+allows you to do that? On the other hand if you take a look at
125+`Network.HTTP.Simple`, then although it's said that it's a “higher level
126+API”, it's mostly the same as vanilla `http-client` in spirit/approach and
127+just adds `conduit`-powered functions to perform requests and allows to use
128+global implicit `Manager` (Req does the same). If I tried to frame what
129+exactly I don't like about `http-conduit` in words, then it would be “the
130+way requests are constructed”. You *set* parameters instead of *being
131+forced* to declare necessary bits and *being allowed* to declare optional
132+bits in a way that their combination is valid. Also, with `http-conduit` you
133+parse request from a string without the protection of TH that otherwise
134+saves the day as in Yesod.
135+
136+Then there is Wreq. `wreq` [doesn't see much development
137+lately](https://github.com/bos/wreq/issues/93). `wreq` is by itself a weird
138+library, IMO. You have functions per method—not very good, as there may be
139+new methods, like PATCH which is not new but still missing (well, you have
140+`customMethod`, but what is the point of having per-method functions if you
141+have a more general way to use any method? you should be able to just insert
142+methods in the “argument slot” of `customMethod` and end up with a more
143+general solution). Now, every method function has a companion that takes
144+`Options` (like you have `get` and `getWith`). Why the duplication? Where is
145+generality and flexibility? This is not all though, because you cannot
146+really use `get` you see in the main module, because you want to have
147+connection sharing. Wreq's author does not take the gift of automatic
148+connection re-use `Manager` from `http-client` provides, he invents the
149+whole new thing of “sessions”. Only inside a session your connections will
150+be shared and re-used. However with the session stuff you have yet another
151+set of per-method functions like `get` and `getWith`—these are different
152+ones, to be used with sessions! Now if you have a multi-threaded app, here
153+is a surprise for you: you can't share connections between threads as
154+connections are shared only inside of the `withSession` friend and “session
155+will no longer be valid after that function returns”. There are valid uses
156+for sessions, but the point is that they are just too inconvenient for
157+common tasks.
158+
159+I used `servant-client` a couple of times but the amount of boilerplate it
160+requires is frightening. If you have several query parameters, and you use
161+just one of them, you'll have to pass lots of `Nothing`s.
162+
163+## Unsolved problems
164+
165+AWS request signing is problematic because request body can be in the form
166+of an action to execute (and all that “popper” stuff for streaming), not
167+just a `ByteString` and so getting its digest (hash) is not trivial without
168+running the action and consuming body in its entirety before the request in
169+made. In Wreq the author chose to just use `error` when body is not a
170+(strict or lazy) `ByteString`. Maybe it's OK for Wreq, but I don't consider
171+this a proper solution for Req as we support full variety of body options.
172+For example, what if I want to upload 1 Gb file to S3? I want to stream it
173+in constant memory but at the same time I need to calculate its hash before
174+I start streaming. One solution to the problem seems to be in taking the
175+hash explicitly (as an argument of the hypothetical `awsAuth`) and making it
176+a responsibility of the user to calculate the hash correctly. I don't like
177+this because it's not user-friendly. So the question stays open, for now
178+there is no AWS signing functionality provided out-of-the-box. The best
179+solution for talking to AWS is the `amazonka` package so far.
180+
85181## Related packages
86182
87183The following packages are designed to be used with Req:
Setup.hsnew file+6
@@ -0,0 +1,6 @@
1+module Main (main) where
2+
3+import Distribution.Simple
4+
5+main :: IO ()
6+main = defaultMain
cabal.projectdeleted−4
@@ -1,4 +0,0 @@
1−packages: .
2−tests: True
3−benchmarks: True
4−constraints: req +dev
httpbin-tests/Network/HTTP/ReqSpec.hs+141−161
@@ -1,62 +1,63 @@
1+{-# LANGUAGE CPP #-}
12{-# LANGUAGE DataKinds #-}
23{-# LANGUAGE FlexibleInstances #-}
3−{-# LANGUAGE LambdaCase #-}
44{-# LANGUAGE OverloadedStrings #-}
55{-# LANGUAGE RankNTypes #-}
66{-# OPTIONS_GHC -fno-warn-orphans #-}
77
8−module Network.HTTP.ReqSpec (spec) where
8+module Network.HTTP.ReqSpec
9+ ( spec,
10+ )
11+where
912
1013import Control.Exception
11−import Control.Monad (forM_)
14+import Control.Monad.Reader
1215import Control.Monad.Trans.Control
13−import Data.Aeson (ToJSON (..), Value (..), object, (.=))
14−import Data.Aeson qualified as A
15−import Data.Aeson.KeyMap qualified as Aeson.KeyMap
16−import Data.ByteString qualified as B
17−import Data.ByteString.Lazy qualified as BL
18−import Data.Functor.Identity (runIdentity)
19−import Data.Maybe (fromJust)
16+import Data.Aeson ((.=), ToJSON (..), Value (..), object)
17+import qualified Data.Aeson as A
18+import qualified Data.ByteString as B
19+import qualified Data.ByteString.Lazy as BL
20+import qualified Data.HashMap.Strict as HM
2021import Data.Proxy
2122import Data.Text (Text)
22−import Data.Text qualified as T
23−import Data.Text.Encoding qualified as T
24−import Data.Text.IO qualified as TIO
25−import Network.HTTP.Client qualified as L
26−import Network.HTTP.Client.MultipartFormData qualified as LM
27−import Network.HTTP.Req hiding (req)
28−import Network.HTTP.Req qualified as Req
29−import Network.HTTP.Types qualified as Y
23+import qualified Data.Text as T
24+import qualified Data.Text.Encoding as T
25+import qualified Data.Text.IO as TIO
26+import qualified Network.HTTP.Client as L
27+import qualified Network.HTTP.Client.MultipartFormData as LM
28+import Network.HTTP.Req
29+import qualified Network.HTTP.Types as Y
3030import Test.Hspec
3131import Test.QuickCheck
3232
33+#if !MIN_VERSION_base(4,13,0)
34+import Data.Semigroup ((<>))
35+#endif
36+
3337spec :: Spec
3438spec = do
35− describe "exception throwing on non-2xx status codes" $
36− it "throws indeed for non-2xx" $
37− req GET (httpbin /: "foo") NoReqBody ignoreResponse mempty
39+ describe "exception throwing on non-2xx status codes"
40+ $ it "throws indeed for non-2xx"
41+ $ req GET (httpbin /: "foo") NoReqBody ignoreResponse mempty
42+ `shouldThrow` selector404
43+
44+ describe "exception throwing on non-2xx status codes (Req monad)"
45+ $ it "throws indeed for non-2xx"
46+ $ asIO . runReq defaultHttpConfig
47+ $ liftBaseWith
48+ $ \run ->
49+ run (req GET (httpbin /: "foo") NoReqBody ignoreResponse mempty)
3850 `shouldThrow` selector404
3951
40− describe "exception throwing on non-2xx status codes (Req monad)" $
41− it "throws indeed for non-2xx" $
42− asIO . runReq defaultHttpConfig $
43− liftBaseWith $ \run ->
44− run (req GET (httpbin /: "foo") NoReqBody ignoreResponse mempty)
45− `shouldThrow` selector404
46−
47− describe "response check via httpConfigCheckResponse" $
48− context "if it's set to always throw" $
49− it "throws indeed" $
50− blindlyThrowing (req GET httpbin NoReqBody ignoreResponse mempty)
51− `shouldThrow` anyException
52−
53− describe "isStatusCodeException" $
54− it "extracts non-2xx response" $
55− req GET (httpbin /: "foo") NoReqBody ignoreResponse mempty
56− `shouldThrow` selector404ByStatusCodeException
57−
58− describe "receiving user-agent header back" $
59− it "works" $ do
52+ describe "response check via httpConfigCheckResponse"
53+ $ context "if it's set to always throw"
54+ $ it "throws indeed"
55+ $ blindlyThrowing (req GET httpbin NoReqBody ignoreResponse mempty)
56+ `shouldThrow` anyException
57+
58+ describe "receiving user-agent header back"
59+ $ it "works"
60+ $ do
6061 r <-
6162 req
6263 GET
@@ -70,8 +71,9 @@ spec = do
7071 responseStatusCode r `shouldBe` 200
7172 responseStatusMessage r `shouldBe` "OK"
7273
73− describe "receiving request headers back" $
74− it "works" $ do
74+ describe "receiving request headers back"
75+ $ it "works"
76+ $ do
7577 r <-
7678 req
7779 GET
@@ -85,30 +87,34 @@ spec = do
8587 .= object
8688 [ "Accept-Encoding" .= ("gzip" :: Text),
8789 "Foo" .= ("bar" :: Text),
88− "Baz" .= ("quux" :: Text)
90+ "Baz" .= ("quux" :: Text),
91+ "Host" .= ("httpbin.org" :: Text)
8992 ]
9093 ]
9194 responseStatusCode r `shouldBe` 200
9295 responseStatusMessage r `shouldBe` "OK"
9396
94− describe "receiving GET data back" $
95− it "works" $ do
97+ describe "receiving GET data back"
98+ $ it "works"
99+ $ do
96100 r <- req GET (httpbin /: "get") NoReqBody jsonResponse mempty
97101 (stripFunnyHeaders . stripOrigin) (responseBody r)
98102 `shouldBe` object
99103 [ "args" .= emptyObject,
100− "url" .= ("http://localhost:1234/get" :: Text),
104+ "url" .= ("https://httpbin.org/get" :: Text),
101105 "headers"
102106 .= object
103− [ "Accept-Encoding" .= ("gzip" :: Text)
107+ [ "Accept-Encoding" .= ("gzip" :: Text),
108+ "Host" .= ("httpbin.org" :: Text)
104109 ]
105110 ]
106111 responseHeader r "Content-Type" `shouldBe` return "application/json"
107112 responseStatusCode r `shouldBe` 200
108113 responseStatusMessage r `shouldBe` "OK"
109114
110− describe "receiving POST JSON data back" $
111− it "works" $ do
115+ describe "receiving POST JSON data back"
116+ $ it "works"
117+ $ do
112118 let text = "foo" :: Text
113119 reflected = reflectJSON text
114120 r <- req POST (httpbin /: "post") (ReqBodyJson text) jsonResponse mempty
@@ -117,11 +123,12 @@ spec = do
117123 [ "args" .= emptyObject,
118124 "json" .= text,
119125 "data" .= reflected,
120− "url" .= ("http://localhost:1234/post" :: Text),
126+ "url" .= ("https://httpbin.org/post" :: Text),
121127 "headers"
122128 .= object
123129 [ "Content-Type" .= ("application/json; charset=utf-8" :: Text),
124130 "Accept-Encoding" .= ("gzip" :: Text),
131+ "Host" .= ("httpbin.org" :: Text),
125132 "Content-Length" .= show (T.length reflected)
126133 ],
127134 "files" .= emptyObject,
@@ -131,25 +138,27 @@ spec = do
131138 responseStatusCode r `shouldBe` 200
132139 responseStatusMessage r `shouldBe` "OK"
133140
134− describe "receiving POST data back (multipart form data)" $
135− it "works" $ do
141+ describe "receiving POST data back (multipart form data)"
142+ $ it "works"
143+ $ do
136144 body <-
137145 reqBodyMultipart
138146 [ LM.partBS "foo" "foo data!",
139147 LM.partBS "bar" "bar data!"
140148 ]
141149 r <- req POST (httpbin /: "post") body jsonResponse mempty
142− let contentType = fromJust (getRequestContentType body)
150+ let Just contentType = getRequestContentType body
143151 (stripFunnyHeaders . stripOrigin) (responseBody r)
144152 `shouldBe` object
145153 [ "args" .= emptyObject,
146154 "json" .= Null,
147155 "data" .= ("" :: Text),
148− "url" .= ("http://localhost:1234/post" :: Text),
156+ "url" .= ("https://httpbin.org/post" :: Text),
149157 "headers"
150158 .= object
151159 [ "Content-Type" .= T.decodeUtf8 contentType,
152160 "Accept-Encoding" .= ("gzip" :: Text),
161+ "Host" .= ("httpbin.org" :: Text),
153162 "Content-Length" .= ("242" :: Text)
154163 ],
155164 "files" .= emptyObject,
@@ -163,8 +172,9 @@ spec = do
163172 responseStatusCode r `shouldBe` 200
164173 responseStatusMessage r `shouldBe` "OK"
165174
166− describe "receiving PATCHed file back" $
167− it "works" $ do
175+ describe "receiving PATCHed file back"
176+ $ it "works"
177+ $ do
168178 let file :: FilePath
169179 file = "httpbin-data/robots.txt"
170180 contents <- TIO.readFile file
@@ -174,10 +184,11 @@ spec = do
174184 [ "args" .= emptyObject,
175185 "json" .= Null,
176186 "data" .= contents,
177− "url" .= ("http://localhost:1234/patch" :: Text),
187+ "url" .= ("https://httpbin.org/patch" :: Text),
178188 "headers"
179189 .= object
180190 [ "Accept-Encoding" .= ("gzip" :: Text),
191+ "Host" .= ("httpbin.org" :: Text),
181192 "Content-Length" .= show (T.length contents)
182193 ],
183194 "files" .= emptyObject,
@@ -187,8 +198,9 @@ spec = do
187198 responseStatusCode r `shouldBe` 200
188199 responseStatusMessage r `shouldBe` "OK"
189200
190− describe "receiving PUT form URL-encoded data back" $
191− it "works" $ do
201+ describe "receiving PUT form URL-encoded data back"
202+ $ it "works"
203+ $ do
192204 let params =
193205 "foo" =: ("bar" :: Text)
194206 <> "baz" =: (5 :: Int)
@@ -199,11 +211,12 @@ spec = do
199211 [ "args" .= emptyObject,
200212 "json" .= Null,
201213 "data" .= ("" :: Text),
202− "url" .= ("http://localhost:1234/put" :: Text),
214+ "url" .= ("https://httpbin.org/put" :: Text),
203215 "headers"
204216 .= object
205217 [ "Content-Type" .= ("application/x-www-form-urlencoded" :: Text),
206218 "Accept-Encoding" .= ("gzip" :: Text),
219+ "Host" .= ("httpbin.org" :: Text),
207220 "Content-Length" .= ("18" :: Text)
208221 ],
209222 "files" .= emptyObject,
@@ -220,8 +233,9 @@ spec = do
220233
221234 -- TODO /delete
222235
223− describe "receiving UTF-8 encoded Unicode data" $
224− it "works" $ do
236+ describe "receiving UTF-8 encoded Unicode data"
237+ $ it "works"
238+ $ do
225239 r <-
226240 req
227241 GET
@@ -237,8 +251,9 @@ spec = do
237251 -- TODO /gzip
238252 -- TODO /deflate
239253
240− describe "retrying" $
241− it "retries as many times as specified" $ do
254+ describe "retrying"
255+ $ it "retries as many times as specified"
256+ $ do
242257 -- FIXME We no longer can count retries because all the functions
243258 -- responsible for controlling retrying are pure now.
244259 let status = 408 :: Int
@@ -261,8 +276,9 @@ spec = do
261276 -- TODO /response-headers
262277 -- TODO /redirect
263278
264− describe "redirects" $
265− it "follows redirects" $ do
279+ describe "redirects"
280+ $ it "follows redirects"
281+ $ do
266282 r <-
267283 req
268284 GET
@@ -281,8 +297,9 @@ spec = do
281297 let user, password :: Text
282298 user = "Scooby"
283299 password = "Doo"
284− context "when we do not send appropriate basic auth data" $
285− it "fails with 401" $ do
300+ context "when we do not send appropriate basic auth data"
301+ $ it "fails with 401"
302+ $ do
286303 r <-
287304 prepareForShit $
288305 req
@@ -293,15 +310,16 @@ spec = do
293310 mempty
294311 responseStatusCode r `shouldBe` 401
295312 responseStatusMessage r `shouldBe` "UNAUTHORIZED"
296− context "when we provide appropriate basic auth data" $
297− it "succeeds" $ do
313+ context "when we provide appropriate basic auth data"
314+ $ it "succeeds"
315+ $ do
298316 r <-
299317 req
300318 GET
301319 (httpbin /: "basic-auth" /~ user /~ password)
302320 NoReqBody
303321 ignoreResponse
304− (basicAuthUnsafe (T.encodeUtf8 user) (T.encodeUtf8 password))
322+ (basicAuth (T.encodeUtf8 user) (T.encodeUtf8 password))
305323 responseStatusCode r `shouldBe` 200
306324 responseStatusMessage r `shouldBe` "OK"
307325
@@ -313,8 +331,9 @@ spec = do
313331 -- TODO /range
314332 -- TODO /html
315333
316− describe "robots.txt" $
317− it "works" $ do
334+ describe "robots.txt"
335+ $ it "works"
336+ $ do
318337 r <- req GET (httpbin /: "robots.txt") NoReqBody bsResponse mempty
319338 robots <- B.readFile "httpbin-data/robots.txt"
320339 responseBody r `shouldBe` robots
@@ -325,8 +344,9 @@ spec = do
325344 -- TODO /cache
326345
327346 describe "getting random bytes" $ do
328− it "works" $
329− property $ \n' -> do
347+ it "works"
348+ $ property
349+ $ \n' -> do
330350 let n :: Word
331351 n = getSmall n'
332352 r <-
@@ -339,8 +359,9 @@ spec = do
339359 responseBody r `shouldSatisfy` ((== n) . fromIntegral . BL.length)
340360 responseStatusCode r `shouldBe` 200
341361 responseStatusMessage r `shouldBe` "OK"
342− context "when we try to interpret 1000 random bytes as JSON" $
343− it "throws correct exception" $ do
362+ context "when we try to interpret 1000 random bytes as JSON"
363+ $ it "throws correct exception"
364+ $ do
344365 let selector :: HttpException -> Bool
345366 selector (JsonHttpException _) = True
346367 selector _ = False
@@ -354,21 +375,22 @@ spec = do
354375 mempty
355376 `shouldThrow` selector
356377
357− describe "streaming random bytes" $
358− it "works" $
359− property $ \n' -> do
360− let n :: Word
361− n = getSmall n'
362− r <-
363− req
364− GET
365− (httpbin /: "stream-bytes" /~ n)
366− NoReqBody
367− bsResponse
368− mempty
369− responseBody r `shouldSatisfy` ((== n) . fromIntegral . B.length)
370− responseStatusCode r `shouldBe` 200
371− responseStatusMessage r `shouldBe` "OK"
378+ describe "streaming random bytes"
379+ $ it "works"
380+ $ property
381+ $ \n' -> do
382+ let n :: Word
383+ n = getSmall n'
384+ r <-
385+ req
386+ GET
387+ (httpbin /: "stream-bytes" /~ n)
388+ NoReqBody
389+ bsResponse
390+ mempty
391+ responseBody r `shouldSatisfy` ((== n) . fromIntegral . B.length)
392+ responseStatusCode r `shouldBe` 200
393+ responseStatusMessage r `shouldBe` "OK"
372394
373395-- TODO /links
374396-- TODO /image
@@ -388,87 +410,52 @@ instance MonadHttp IO where
388410----------------------------------------------------------------------------
389411-- Helpers
390412
391−-- | Run a request with such settings that it does not signal errors.
413+-- | Run request with such settings that it does not signal error on adverse
414+-- response status codes.
392415prepareForShit :: Req a -> IO a
393416prepareForShit = runReq defaultHttpConfig {httpConfigCheckResponse = noNoise}
394417 where
395418 noNoise _ _ _ = Nothing
396419
397−-- | Run a request with such settings that it throws on any response.
420+-- | Run request with such settings that it throws on any response.
398421blindlyThrowing :: Req a -> IO a
399422blindlyThrowing = runReq defaultHttpConfig {httpConfigCheckResponse = doit}
400423 where
401424 doit _ _ = error "Oops!"
402425
403426-- | 'Url' representing <https://httpbin.org>.
404−httpbin :: Url 'Http
405−httpbin = http "localhost"
406−
407−req ::
408− ( MonadHttp m,
409− HttpMethod method,
410− HttpBody body,
411− HttpResponse response,
412− HttpBodyAllowed (AllowsBody method) (ProvidesBody body)
413− ) =>
414− method ->
415− Url scheme ->
416− body ->
417− Proxy response ->
418− Option scheme ->
419− m response
420−req method url body responseProxy options =
421− Req.req method url body responseProxy (options <> defaultOptions)
422−
423−-- | Options to apply by default.
424−defaultOptions :: Option scheme
425−defaultOptions = port 1234
427+httpbin :: Url 'Https
428+httpbin = https "httpbin.org"
426429
427430-- | Remove “origin” field from JSON value. Origin may change, we don't want
428431-- to depend on that.
429432stripOrigin :: Value -> Value
430−stripOrigin (Object m) = Object (Aeson.KeyMap.delete "origin" m)
433+stripOrigin (Object m) = Object (HM.delete "origin" m)
431434stripOrigin value = value
432435
433436-- | Remove funny headers that might break the tests.
434437stripFunnyHeaders :: Value -> Value
435−stripFunnyHeaders = \case
436− Object m ->
437− Object
438− ( runIdentity
439− ( Aeson.KeyMap.alterF
440− (pure . fmap stripFunnyHeaders')
441− "headers"
442− m
443− )
444− )
445− value -> value
446−
447−-- | Similar to 'stripFunnyHeaders', but acts directly on the argument
448−-- without trying to access its "headers" field.
449−stripFunnyHeaders' :: Value -> Value
450−stripFunnyHeaders' = \case
451− Object p ->
452− Object $
453− Aeson.KeyMap.filterWithKey
454− (\k _ -> k `elem` whitelistedHeaders)
455− p
456− value -> value
457− where
458− whitelistedHeaders =
459− [ "Content-Type",
460− "Accept-Encoding",
461− "Content-Length",
462− "Foo",
463− "Baz"
464− ]
438+stripFunnyHeaders (Object m) =
439+ let f (Object p) = Object $ HM.filterWithKey (\k _ -> k `elem` hs) p
440+ f value = value
441+ hs =
442+ [ "Content-Type",
443+ "Accept-Encoding",
444+ "Host",
445+ "Content-Length",
446+ "Foo",
447+ "Baz"
448+ ]
449+ in Object (HM.adjust f "headers" m)
450+stripFunnyHeaders value = value
465451
466452-- | This is a complete test case that makes use of <https://httpbin.org> to
467453-- get various response status codes.
468454checkStatusCode :: Int -> SpecWith ()
469455checkStatusCode code =
470− describe ("receiving status code " ++ show code) $
471− it "works" $ do
456+ describe ("receiving status code " ++ show code)
457+ $ it "works"
458+ $ do
472459 r <-
473460 prepareForShit $
474461 req
@@ -491,19 +478,12 @@ selector404
491478 L.responseStatus response == Y.status404 && not (B.null chunk)
492479selector404 _ = False
493480
494−-- | Same as 'selector404' except that it uses 'isStatusCodeException'.
495−selector404ByStatusCodeException :: HttpException -> Bool
496−selector404ByStatusCodeException e =
497− case isStatusCodeException e of
498− Nothing -> False
499− Just r -> responseStatusCode r == 404
500−
501−-- | The empty JSON 'Object'.
481+-- | Empty JSON 'Object'.
502482emptyObject :: Value
503−emptyObject = Object Aeson.KeyMap.empty
483+emptyObject = Object HM.empty
504484
505−-- | Get a rendered JSON value as 'Text'.
506−reflectJSON :: (ToJSON a) => a -> Text
485+-- | Get rendered JSON value as 'Text'.
486+reflectJSON :: ToJSON a => a -> Text
507487reflectJSON = T.decodeUtf8 . BL.toStrict . A.encode
508488
509489-- | Clarify to the type checker that the inner computation is in the 'IO'
pure-tests/Network/HTTP/ReqSpec.hs+194−224
@@ -1,3 +1,4 @@
1+{-# LANGUAGE CPP #-}
12{-# LANGUAGE DataKinds #-}
23{-# LANGUAGE DeriveGeneric #-}
34{-# LANGUAGE FlexibleInstances #-}
@@ -7,56 +8,58 @@
78{-# LANGUAGE RankNTypes #-}
89{-# LANGUAGE RecordWildCards #-}
910{-# LANGUAGE ScopedTypeVariables #-}
10−{-# LANGUAGE TypeApplications #-}
1111{-# LANGUAGE NoMonomorphismRestriction #-}
1212{-# OPTIONS_GHC -fno-warn-orphans #-}
1313
14−module Network.HTTP.ReqSpec (spec) where
14+module Network.HTTP.ReqSpec
15+ ( spec,
16+ )
17+where
1518
16−import Blaze.ByteString.Builder qualified as BB
19+import qualified Blaze.ByteString.Builder as BB
1720import Control.Exception (throwIO)
1821import Control.Monad
1922import Control.Retry
2023import Data.Aeson (ToJSON (..))
21−import Data.Aeson qualified as A
24+import qualified Data.Aeson as A
2225import Data.ByteString (ByteString)
23−import Data.ByteString qualified as B
24−import Data.ByteString.Char8 qualified as B8
25−import Data.ByteString.Lazy qualified as BL
26−import Data.CaseInsensitive qualified as CI
26+import qualified Data.ByteString as B
27+import qualified Data.ByteString.Char8 as B8
28+import qualified Data.ByteString.Lazy as BL
29+import qualified Data.CaseInsensitive as CI
2730import Data.Either (isRight)
28−import Data.List.NonEmpty qualified as NE
29−import Data.Maybe (fromJust, fromMaybe, isJust, isNothing)
31+import qualified Data.List.NonEmpty as NE
32+import Data.Maybe (fromJust, fromMaybe, isNothing)
3033import Data.Proxy
3134import Data.Text (Text)
32−import Data.Text qualified as T
33−import Data.Text.Encoding qualified as T
35+import qualified Data.Text as T
36+import qualified Data.Text.Encoding as T
3437import Data.Time
35−import Data.Typeable (Typeable, eqT)
36−import GHC.Exts (IsList (..))
3738import GHC.Generics
38−import Language.Haskell.TH qualified as TH
39−import Language.Haskell.TH.Quote qualified as TH
40−import Network.HTTP.Client qualified as L
39+import qualified Network.HTTP.Client as L
4140import Network.HTTP.Req
42−import Network.HTTP.Types qualified as Y
43−import Network.HTTP.Types.Header qualified as Y
41+import qualified Network.HTTP.Types as Y
42+import qualified Network.HTTP.Types.Header as Y
4443import Test.Hspec
4544import Test.Hspec.Core.Spec (SpecM)
4645import Test.QuickCheck
4746import Text.URI (URI)
48−import Text.URI qualified as URI
49−import Text.URI.QQ qualified as QQ
50−import Web.FormUrlEncoded qualified as F
47+import qualified Text.URI as URI
48+import qualified Text.URI.QQ as QQ
49+
50+#if !MIN_VERSION_base(4,13,0)
51+import Data.Semigroup ((<>))
52+#endif
5153
5254spec :: Spec
5355spec = do
54− describe "config" $
55− it "getHttpConfig has effect on resulting request" $
56− property $ \config -> do
57− request <- runReq config (req_ GET url NoReqBody mempty)
58− L.proxy request `shouldBe` httpConfigProxy config
59− L.redirectCount request `shouldBe` httpConfigRedirectCount config
56+ describe "config"
57+ $ it "getHttpConfig has effect on resulting request"
58+ $ property
59+ $ \config -> do
60+ request <- runReq config (req_ GET url NoReqBody mempty)
61+ L.proxy request `shouldBe` httpConfigProxy config
62+ L.redirectCount request `shouldBe` httpConfigRedirectCount config
6063
6164 describe "methods" $ do
6265 let mnth ::
@@ -68,8 +71,9 @@ spec = do
6871 SpecM () ()
6972 mnth method = do
7073 let name = httpMethodName (Proxy :: Proxy method)
71− describe (B8.unpack name) $
72− it "affects name of HTTP method" $ do
74+ describe (B8.unpack name)
75+ $ it "affects name of HTTP method"
76+ $ do
7377 request <- req_ method url NoReqBody mempty
7478 L.method request `shouldBe` name
7579 mnth GET
@@ -83,42 +87,48 @@ spec = do
8387 mnth PATCH
8488
8589 describe "urls" $ do
86− describe "http" $
87− it "sets all the params correctly" $
88− property $ \host -> do
89− request <- req_ GET (http host) NoReqBody mempty
90− L.secure request `shouldBe` False
91− L.port request `shouldBe` 80
92− L.host request `shouldBe` urlEncode host
93− describe "https" $
94− it "sets all the params correctly" $
95− property $ \host -> do
96− request <- req_ GET (https host) NoReqBody mempty
97− L.secure request `shouldBe` True
98− L.port request `shouldBe` 443
99− L.host request `shouldBe` urlEncode host
100− describe "(/~)" $
101− it "attaches a path piece that is URL-encoded" $
102− property $ \host pieces -> do
103− let url' = foldl (/~) (https host) pieces
104− request <- req_ GET url' NoReqBody mempty
105− L.host request `shouldBe` urlEncode host
106− L.path request `shouldBe` encodePathPieces pieces
107− describe "(/:)" $
108− it "attaches a path piece that is URL-encoded" $
109− property $ \host pieces -> do
110− let url' = foldl (/:) (https host) pieces
111− request <- req_ GET url' NoReqBody mempty
112− L.host request `shouldBe` urlEncode host
113− L.path request `shouldBe` encodePathPieces pieces
90+ describe "http"
91+ $ it "sets all the params correctly"
92+ $ property
93+ $ \host -> do
94+ request <- req_ GET (http host) NoReqBody mempty
95+ L.secure request `shouldBe` False
96+ L.port request `shouldBe` 80
97+ L.host request `shouldBe` urlEncode host
98+ describe "https"
99+ $ it "sets all the params correctly"
100+ $ property
101+ $ \host -> do
102+ request <- req_ GET (https host) NoReqBody mempty
103+ L.secure request `shouldBe` True
104+ L.port request `shouldBe` 443
105+ L.host request `shouldBe` urlEncode host
106+ describe "(/~)"
107+ $ it "attaches a path piece that is URL-encoded"
108+ $ property
109+ $ \host pieces -> do
110+ let url' = foldl (/~) (https host) pieces
111+ request <- req_ GET url' NoReqBody mempty
112+ L.host request `shouldBe` urlEncode host
113+ L.path request `shouldBe` encodePathPieces pieces
114+ describe "(/:)"
115+ $ it "attaches a path piece that is URL-encoded"
116+ $ property
117+ $ \host pieces -> do
118+ let url' = foldl (/:) (https host) pieces
119+ request <- req_ GET url' NoReqBody mempty
120+ L.host request `shouldBe` urlEncode host
121+ L.path request `shouldBe` encodePathPieces pieces
114122
115123 describe "useHttpURI" $ do
116− it "does not recognize non-http schemes" $
117− property $ \uri ->
124+ it "does not recognize non-http schemes"
125+ $ property
126+ $ \uri ->
118127 when (URI.uriScheme uri /= Just [QQ.scheme|http|]) $
119128 useHttpURI uri `shouldSatisfy` isNothing
120− it "accepts correct URLs" $
121− property $ \uri' -> do
129+ it "accepts correct URLs"
130+ $ property
131+ $ \uri' -> do
122132 unless (isRight (URI.uriAuthority uri')) discard
123133 let uri = uri' {URI.uriScheme = Just [QQ.scheme|http|]}
124134 (url', options) = fromJust (useHttpURI uri)
@@ -130,12 +140,14 @@ spec = do
130140 lookup "Authorization" (L.requestHeaders request)
131141 `shouldBe` uriBasicAuth uri
132142 describe "useHttpsURI" $ do
133− it "does not recognize non-https schemes" $
134− property $ \uri ->
143+ it "does not recognize non-https schemes"
144+ $ property
145+ $ \uri ->
135146 when (URI.uriScheme uri /= Just [QQ.scheme|https|]) $
136147 useHttpsURI uri `shouldSatisfy` isNothing
137− it "parses correct URLs" $
138− property $ \uri' -> do
148+ it "parses correct URLs"
149+ $ property
150+ $ \uri' -> do
139151 unless (isRight (URI.uriAuthority uri')) discard
140152 let uri = uri' {URI.uriScheme = Just [QQ.scheme|https|]}
141153 (url', options) = fromJust (useHttpsURI uri)
@@ -147,27 +159,27 @@ spec = do
147159 lookup "Authorization" (L.requestHeaders request)
148160 `shouldBe` uriBasicAuth uri
149161 describe "useURI" $ do
150− it "does not recognize non-http and non-https schemes" $
151− property $ \uri ->
162+ it "does not recognize non-http and non-https schemes"
163+ $ property
164+ $ \uri ->
152165 when
153166 ( ( URI.uriScheme uri /= Just [QQ.scheme|http|]
154167 && (URI.uriScheme uri /= Just [QQ.scheme|https|])
155168 )
156169 )
157170 $ useURI uri `shouldSatisfy` isNothing
158− it "parses correct URLs" $
159− property $ \uri' -> do
171+ it "parses correct URLs"
172+ $ property
173+ $ \uri' -> do
160174 unless (isRight (URI.uriAuthority uri')) discard
161175 let uriHttp = uri' {URI.uriScheme = Just [QQ.scheme|http|]}
162176 uriHttps = uri' {URI.uriScheme = Just [QQ.scheme|https|]}
163177 requestHttp <-
164− case fromJust (useURI uriHttp) of
165− Left (url', options) -> req_ GET url' NoReqBody options
166− _ -> error "(useURI uriHttp) should have returned Left"
178+ let Left (url', options) = fromJust (useURI uriHttp)
179+ in req_ GET url' NoReqBody options
167180 requestHttps <-
168− case fromJust (useURI uriHttps) of
169− Right (url', options) -> req_ GET url' NoReqBody options
170− _ -> error "(useURI uriHttps) should have returned Right"
181+ let Right (url', options) = fromJust (useURI uriHttps)
182+ in req_ GET url' NoReqBody options
171183 L.host requestHttp `shouldBe` uriHost uriHttp
172184 L.host requestHttps `shouldBe` uriHost uriHttps
173185 L.port requestHttp `shouldBe` uriPort 80 uriHttp
@@ -181,83 +193,57 @@ spec = do
181193 lookup "Authorization" (L.requestHeaders requestHttps)
182194 `shouldBe` uriBasicAuth uriHttps
183195
184− describe "renderUrl" $ do
185− context "http" $ do
186− context "empty path" $
187− it "renders correctly" $ do
188− let (uriHttp, _) = [urlQ|http://httpbin.org|]
189− renderUrl uriHttp `shouldBe` "http://httpbin.org"
190− context "non-empty path" $
191− it "renders correctly" $ do
192− let (uriHttp, _) = [urlQ|http://httpbin.org/here/we/go|]
193− renderUrl uriHttp `shouldBe` "http://httpbin.org/here/we/go"
194− context "http" $ do
195− context "empty path" $
196− it "renders correctly" $ do
197− let (uriHttp, _) = [urlQ|https://httpbin.org|]
198− renderUrl uriHttp `shouldBe` "https://httpbin.org"
199− context "non-empty path" $
200− it "renders correctly" $ do
201− let (uriHttp, _) = [urlQ|https://httpbin.org/here/we/go|]
202− renderUrl uriHttp `shouldBe` "https://httpbin.org/here/we/go"
203−
204196 describe "bodies" $ do
205− describe "NoReqBody" $
206− it "sets body to empty byte string" $ do
197+ describe "NoReqBody"
198+ $ it "sets body to empty byte string"
199+ $ do
207200 request <- req_ POST url NoReqBody mempty
208201 case L.requestBody request of
209202 L.RequestBodyBS x -> x `shouldBe` B.empty
210203 _ -> expectationFailure "Wrong request body constructor."
211− describe "ReqBodyJson" $
212− it "sets body to correct lazy byte string" $
213− property $ \thing -> do
214− request <- req_ POST url (ReqBodyJson thing) mempty
215− case L.requestBody request of
216− L.RequestBodyLBS x -> x `shouldBe` A.encode (thing :: Thing)
217− _ -> expectationFailure "Wrong request body constructor."
218− describe "ReqBodyBs" $
219− it "sets body to specified strict byte string" $
220− property $ \bs -> do
221− request <- req_ POST url (ReqBodyBs bs) mempty
222− case L.requestBody request of
223− L.RequestBodyBS x -> x `shouldBe` bs
224− _ -> expectationFailure "Wrong request body constructor."
225− describe "ReqBodyLbs" $
226− it "sets body to specified lazy byte string" $
227− property $ \lbs -> do
228− request <- req_ POST url (ReqBodyLbs lbs) mempty
229− case L.requestBody request of
230− L.RequestBodyLBS x -> x `shouldBe` lbs
231− _ -> expectationFailure "Wrong request body constructor."
232− describe "ReqBodyUrlEnc" $
233− it "sets body to correct lazy byte string" $
234− property $ \params -> do
235− request <- req_ POST url (ReqBodyUrlEnc (formUrlEnc params)) mempty
236− case L.requestBody request of
237− L.RequestBodyLBS x -> x `shouldBe` renderQuery params
238− _ -> expectationFailure "Wrong request body constructor."
239−
240− describe "query params" $ do
241− describe "FormUrlEncodedParam" $ do
242− describe "formToQuery" $ do
243− it "should produce the same parameters as F.urlEncodeFormStable" $
244− property $ \form -> do
245− request <- req_ POST url (ReqBodyUrlEnc $ formToQuery form) mempty
246− case L.requestBody request of
247− L.RequestBodyLBS x -> x `shouldBe` F.urlEncodeFormStable form
248− _ -> expectationFailure "Wrong request body constructor"
249− specParamToList (Proxy :: Proxy FormUrlEncodedParam)
250− describe "Option" $ do
251− specParamToList (Proxy :: Proxy (Option 'Http))
204+ describe "ReqBodyJson"
205+ $ it "sets body to correct lazy byte string"
206+ $ property
207+ $ \thing -> do
208+ request <- req_ POST url (ReqBodyJson thing) mempty
209+ case L.requestBody request of
210+ L.RequestBodyLBS x -> x `shouldBe` A.encode (thing :: Thing)
211+ _ -> expectationFailure "Wrong request body constructor."
212+ describe "ReqBodyBs"
213+ $ it "sets body to specified strict byte string"
214+ $ property
215+ $ \bs -> do
216+ request <- req_ POST url (ReqBodyBs bs) mempty
217+ case L.requestBody request of
218+ L.RequestBodyBS x -> x `shouldBe` bs
219+ _ -> expectationFailure "Wrong request body constructor."
220+ describe "ReqBodyLbs"
221+ $ it "sets body to specified lazy byte string"
222+ $ property
223+ $ \lbs -> do
224+ request <- req_ POST url (ReqBodyLbs lbs) mempty
225+ case L.requestBody request of
226+ L.RequestBodyLBS x -> x `shouldBe` lbs
227+ _ -> expectationFailure "Wrong request body constructor."
228+ describe "ReqBodyUrlEnc"
229+ $ it "sets body to correct lazy byte string"
230+ $ property
231+ $ \params -> do
232+ request <- req_ POST url (ReqBodyUrlEnc (formUrlEnc params)) mempty
233+ case L.requestBody request of
234+ L.RequestBodyLBS x -> x `shouldBe` renderQuery params
235+ _ -> expectationFailure "Wrong request body constructor."
252236
253237 describe "optional parameters" $ do
254238 describe "header" $ do
255− it "sets specified header value" $
256− property $ \name value -> do
239+ it "sets specified header value"
240+ $ property
241+ $ \name value -> do
257242 request <- req_ GET url NoReqBody (header name value)
258243 lookup (CI.mk name) (L.requestHeaders request) `shouldBe` pure value
259− it "left header wins" $
260− property $ \name value0 value1 -> do
244+ it "left header wins"
245+ $ property
246+ $ \name value0 value1 -> do
261247 request <-
262248 req_
263249 GET
@@ -265,8 +251,9 @@ spec = do
265251 NoReqBody
266252 (header name value0 <> header name value1)
267253 lookup (CI.mk name) (L.requestHeaders request) `shouldBe` pure value0
268− it "overwrites headers set by other parts of the lib" $
269− property $ \value -> do
254+ it "overwrites headers set by other parts of the lib"
255+ $ property
256+ $ \value -> do
270257 request <-
271258 req_
272259 POST
@@ -274,19 +261,22 @@ spec = do
274261 (ReqBodyUrlEnc mempty)
275262 (header "Content-Type" value)
276263 lookup "Content-Type" (L.requestHeaders request) `shouldBe` pure value
277− describe "cookieJar" $
278− it "cookie jar is set without modifications" $
279− property $ \cjar -> do
280− request <- req_ GET url NoReqBody (cookieJar cjar)
281− L.cookieJar request `shouldSatisfy` (maybe False (L.equalCookieJar cjar))
264+ describe "cookieJar"
265+ $ it "cookie jar is set without modifications"
266+ $ property
267+ $ \cjar -> do
268+ request <- req_ GET url NoReqBody (cookieJar cjar)
269+ L.cookieJar request `shouldBe` pure cjar
282270 describe "basicAuth" $ do
283− it "sets Authorization header to correct value" $
284− property $ \username password -> do
271+ it "sets Authorization header to correct value"
272+ $ property
273+ $ \username password -> do
285274 request <- req_ GET url NoReqBody (basicAuth username password)
286275 lookup "Authorization" (L.requestHeaders request)
287276 `shouldBe` Just (basicAuthHeader username password)
288− it "overwrites manual setting of header" $
289− property $ \username password value -> do
277+ it "overwrites manual setting of header"
278+ $ property
279+ $ \username password value -> do
290280 request0 <-
291281 req_
292282 GET
@@ -302,8 +292,9 @@ spec = do
302292 let result = Just (basicAuthHeader username password)
303293 lookup "Authorization" (L.requestHeaders request0) `shouldBe` result
304294 lookup "Authorization" (L.requestHeaders request1) `shouldBe` result
305− it "left auth option wins" $
306− property $ \username0 password0 username1 password1 -> do
295+ it "left auth option wins"
296+ $ property
297+ $ \username0 password0 username1 password1 -> do
307298 request <-
308299 req_
309300 GET
@@ -313,13 +304,15 @@ spec = do
313304 lookup "Authorization" (L.requestHeaders request)
314305 `shouldBe` Just (basicAuthHeader username0 password0)
315306 describe "oAuth2Bearer" $ do
316− it "sets Authorization header to correct value" $
317− property $ \token -> do
307+ it "sets Authorization header to correct value"
308+ $ property
309+ $ \token -> do
318310 request <- req_ GET url NoReqBody (oAuth2Bearer token)
319311 lookup "Authorization" (L.requestHeaders request)
320312 `shouldBe` pure ("Bearer " <> token)
321− it "overwrites manual setting of header" $
322− property $ \token value -> do
313+ it "overwrites manual setting of header"
314+ $ property
315+ $ \token value -> do
323316 request0 <-
324317 req_
325318 GET
@@ -337,8 +330,9 @@ spec = do
337330 `shouldBe` pure result
338331 lookup "Authorization" (L.requestHeaders request1)
339332 `shouldBe` pure result
340− it "left auth option wins" $
341− property $ \token0 token1 -> do
333+ it "left auth option wins"
334+ $ property
335+ $ \token0 token1 -> do
342336 request <-
343337 req_
344338 GET
@@ -347,20 +341,23 @@ spec = do
347341 (oAuth2Bearer token0 <> oAuth2Bearer token1)
348342 lookup "Authorization" (L.requestHeaders request)
349343 `shouldBe` pure ("Bearer " <> token0)
350− describe "ProxyAuthorization" $
351− it "sets Authorization header to correct value" $
352− property $ \username password -> do
353− request <- req_ GET url NoReqBody (basicProxyAuth username password)
354− lookup "Proxy-Authorization" (L.requestHeaders request)
355− `shouldBe` pure (basicProxyAuthHeader username password)
344+ describe "ProxyAuthorization"
345+ $ it "sets Authorization header to correct value"
346+ $ property
347+ $ \username password -> do
348+ request <- req_ GET url NoReqBody (basicProxyAuth username password)
349+ lookup "Proxy-Authorization" (L.requestHeaders request)
350+ `shouldBe` pure (basicProxyAuthHeader username password)
356351 describe "oAuth2Token" $ do
357− it "sets Authorization header to correct value" $
358− property $ \token -> do
352+ it "sets Authorization header to correct value"
353+ $ property
354+ $ \token -> do
359355 request <- req_ GET url NoReqBody (oAuth2Token token)
360356 lookup "Authorization" (L.requestHeaders request)
361357 `shouldBe` pure ("token " <> token)
362− it "overwrites manual setting of header" $
363− property $ \token value -> do
358+ it "overwrites manual setting of header"
359+ $ property
360+ $ \token value -> do
364361 request0 <-
365362 req_
366363 GET
@@ -378,8 +375,9 @@ spec = do
378375 `shouldBe` pure result
379376 lookup "Authorization" (L.requestHeaders request1)
380377 `shouldBe` pure result
381− it "left auth option wins" $
382− property $ \token0 token1 -> do
378+ it "left auth option wins"
379+ $ property
380+ $ \token0 token1 -> do
383381 request <-
384382 req_
385383 GET
@@ -388,37 +386,27 @@ spec = do
388386 (oAuth2Token token0 <> oAuth2Token token1)
389387 lookup "Authorization" (L.requestHeaders request)
390388 `shouldBe` pure ("token " <> token0)
391− describe "port" $
392− it "sets port overwriting the defaults" $
393− property $ \n -> do
394− request <- req_ GET url NoReqBody (port n)
395− L.port request `shouldBe` n
396− describe "decompress" $
397− it "sets decompress function overwriting the defaults" $
398− property $ \token -> do
399− request <- req_ GET url NoReqBody (decompress (/= token))
400− L.decompress request token `shouldBe` False
389+ describe "port"
390+ $ it "sets port overwriting the defaults"
391+ $ property
392+ $ \n -> do
393+ request <- req_ GET url NoReqBody (port n)
394+ L.port request `shouldBe` n
395+ describe "decompress"
396+ $ it "sets decompress function overwriting the defaults"
397+ $ property
398+ $ \token -> do
399+ request <- req_ GET url NoReqBody (decompress (/= token))
400+ L.decompress request token `shouldBe` False
401401 -- FIXME Can't really test responseTimeout right new because the
402402 -- ResponseTimeout data type does not implement Eq and its constructors
403403 -- are also not exported. Sent a PR.
404− describe "httpVersion" $
405− it "sets HTTP version overwriting the defaults" $
406− property $ \major minor -> do
407− request <- req_ GET url NoReqBody (httpVersion major minor)
408− L.requestVersion request `shouldBe` Y.HttpVersion major minor
409−
410− describe "quasiquoter" $ do
411− it "works for valid urls" $
412− -- Doing it this way instead of just checking if [urlQ|...|] :: (Url
413− -- 'Https, Option _) type checks, so we can catch if the type of scheme
414− -- is unspecified.
415− let testTypeOfQuoterResult ::
416− forall a s. (Typeable a) => (a, Option s) -> Bool
417− testTypeOfQuoterResult _ = isJust $ eqT @a @(Url 'Https)
418− in property $ testTypeOfQuoterResult [urlQ|https://example.org/|]
419− it "doesn't work for invalid urls" $
420− property $
421− TH.runQ (TH.quoteExp urlQ "not a url") `shouldThrow` anyIOException
404+ describe "httpVersion"
405+ $ it "sets HTTP version overwriting the defaults"
406+ $ property
407+ $ \major minor -> do
408+ request <- req_ GET url NoReqBody (httpVersion major minor)
409+ L.requestVersion request `shouldBe` Y.HttpVersion major minor
422410
423411----------------------------------------------------------------------------
424412-- Instances
@@ -434,8 +422,6 @@ instance Arbitrary HttpConfig where
434422 httpConfigCheckResponse _ _ _ = Nothing
435423 httpConfigRetryPolicy = retryPolicyDefault
436424 httpConfigRetryJudge _ _ = False
437− httpConfigRetryJudgeException _ _ = False
438− httpConfigBodyPreviewLength = 1024
439425 return HttpConfig {..}
440426
441427instance Show HttpConfig where
@@ -503,9 +489,6 @@ instance Arbitrary Day where
503489instance Arbitrary DiffTime where
504490 arbitrary = secondsToDiffTime <$> arbitrary
505491
506−instance Arbitrary F.Form where
507− arbitrary = (F.Form . fromList) <$> arbitrary
508−
509492----------------------------------------------------------------------------
510493-- Helper types
511494
@@ -573,14 +556,13 @@ uriPort def uri =
573556 maybe def (fromIntegral) $
574557 either (const Nothing) Just (URI.uriAuthority uri) >>= URI.authPort
575558
576−-- | Get the path from a 'URI'.
559+-- | Get path from 'URI'.
577560uriPath :: URI -> ByteString
578561uriPath uri = fromMaybe "" $ do
579− (trailingSlash, xs) <- URI.uriPath uri
580− let pref = (encodePathPieces . fmap URI.unRText . NE.toList) xs
581− return $ if trailingSlash then pref <> "/" else pref
562+ (_, xs) <- URI.uriPath uri
563+ (return . encodePathPieces . fmap URI.unRText . NE.toList) xs
582564
583−-- | Get the query string from a 'URI'.
565+-- | Get query string from 'URI'.
584566uriQuery :: URI -> ByteString
585567uriQuery uri = do
586568 let liftQueryParam = \case
@@ -618,15 +600,3 @@ basicProxyAuthHeader :: ByteString -> ByteString -> ByteString
618600basicProxyAuthHeader username password =
619601 fromJust . lookup Y.hProxyAuthorization . L.requestHeaders $
620602 L.applyBasicProxyAuth username password L.defaultRequest
621−
622−-- | Spec about 'paramToList' for the type @p@.
623−specParamToList :: (QueryParam p, Monoid p) => Proxy p -> Spec
624−specParamToList typeProxy = do
625− describe "paramToList" $ do
626− it "should reproduce the parameters given by queryParam" $
627− property $ \(QueryParams params) -> do
628− let queryParam0 =
629− (mconcat $ fmap (uncurry queryParam) params)
630− `asProxyTypeOf` typeProxy
631− got = queryParamToList queryParam0
632− got `shouldBe` params
req.cabal+68−68
@@ -1,15 +1,19 @@
1−cabal-version: 2.4
1+cabal-version: 1.18
22name: req
3−version: 3.13.4
4−license: BSD-3-Clause
3+version: 3.1.0
4+license: BSD3
55license-file: LICENSE.md
66maintainer: Mark Karpov <markkarpov92@gmail.com>
77author: Mark Karpov <markkarpov92@gmail.com>
8−tested-with: ghc ==9.6.3 ghc ==9.8.2 ghc ==9.10.1
8+tested-with: ghc ==8.6.5 ghc ==8.8.3 ghc ==8.10.1
99homepage: https://github.com/mrkkrp/req
1010bug-reports: https://github.com/mrkkrp/req/issues
11−synopsis: HTTP client library
12−description: HTTP client library.
11+synopsis:
12+ Easy-to-use, type-safe, expandable, high-level HTTP client library
13+
14+description:
15+ Easy-to-use, type-safe, expandable, high-level HTTP client library.
16+
1317category: Network, Web
1418build-type: Simple
1519data-files:
@@ -31,97 +35,93 @@ flag dev
3135
3236library
3337 exposed-modules: Network.HTTP.Req
34− default-language: GHC2021
38+ default-language: Haskell2010
3539 build-depends:
36− aeson >=0.9 && <3,
37− authenticate-oauth >=1.5 && <1.8,
38− base >=4.15 && <5,
40+ aeson >=0.9 && <1.5,
41+ authenticate-oauth >=1.5 && <1.7,
42+ base >=4.12 && <5.0,
3943 blaze-builder >=0.3 && <0.5,
40− bytestring >=0.10.8 && <0.13,
44+ bytestring >=0.10.8 && <0.11,
4145 case-insensitive >=0.2 && <1.3,
42− containers >=0.5 && <0.8,
43− crypton-connection >=0.4.2 && <0.5,
44− data-default-class >=0.2.0.0,
45− exceptions >=0.6 && <0.11,
46− http-api-data >=0.2 && <0.7,
47− http-client >=0.7.13.1 && <0.8,
46+ connection >=0.2.2 && <0.4,
47+ http-api-data >=0.2 && <0.5,
48+ http-client >=0.5 && <0.7,
4849 http-client-tls >=0.3.2 && <0.4,
49− http-types >=0.8 && <10,
50+ http-types >=0.8 && <10.0,
5051 modern-uri >=0.3 && <0.4,
5152 monad-control >=1.0 && <1.1,
5253 mtl >=2.0 && <3.0,
53− retry >=0.8 && <0.10,
54− template-haskell >=2.19 && <2.23,
55− text >=0.2 && <2.2,
56− transformers >=0.5.3.0 && <0.7,
57− transformers-base,
58− unliftio-core >=0.1.1 && <0.3
54+ retry >=0.8 && <0.9,
55+ text >=0.2 && <1.3,
56+ time >=1.2 && <1.10,
57+ transformers >=0.4 && <0.6,
58+ transformers-base -any
5959
6060 if flag(dev)
61− ghc-options:
62− -Wall -Werror -Wpartial-fields -Wunused-packages
63− -Wno-unused-imports
61+ ghc-options: -O0 -Wall -Werror
6462
6563 else
6664 ghc-options: -O2 -Wall
6765
66+ if flag(dev)
67+ ghc-options:
68+ -Wcompat -Wincomplete-record-updates -Wincomplete-uni-patterns
69+ -Wnoncanonical-monad-instances
70+
6871test-suite pure-tests
69− type: exitcode-stdio-1.0
70− main-is: Spec.hs
71− build-tool-depends: hspec-discover:hspec-discover >=2 && <3
72− hs-source-dirs: pure-tests
73− other-modules: Network.HTTP.ReqSpec
74− default-language: GHC2021
72+ type: exitcode-stdio-1.0
73+ main-is: Spec.hs
74+ build-tools: hspec-discover >=2.0 && <3.0
75+ hs-source-dirs: pure-tests
76+ other-modules: Network.HTTP.ReqSpec
77+ default-language: Haskell2010
7578 build-depends:
76− QuickCheck >=2.7 && <3,
77− aeson >=0.9 && <3,
78− base >=4.15 && <5.0,
79+ QuickCheck >=2.7 && <3.0,
80+ aeson >=0.9 && <1.5,
81+ base >=4.12 && <5.0,
7982 blaze-builder >=0.3 && <0.5,
80− bytestring >=0.10.8 && <0.13,
83+ bytestring >=0.10.8 && <0.11,
8184 case-insensitive >=0.2 && <1.3,
82− hspec >=2.0 && <3,
83− hspec-core >=2.0 && <3,
84− http-api-data >=0.2 && <0.7,
85− http-client >=0.7 && <0.8,
86− http-types >=0.8 && <10,
85+ hspec >=2.0 && <3.0,
86+ hspec-core >=2.0 && <3.0,
87+ http-client >=0.5 && <0.7,
88+ http-types >=0.8 && <10.0,
8789 modern-uri >=0.3 && <0.4,
88− req,
89− retry >=0.8 && <0.10,
90− template-haskell >=2.19 && <2.23,
91− text >=0.2 && <2.2,
92− time >=1.2 && <1.15
90+ mtl >=2.0 && <3.0,
91+ req -any,
92+ retry >=0.8 && <0.9,
93+ text >=0.2 && <1.3,
94+ time >=1.2 && <1.10
9395
9496 if flag(dev)
95− ghc-options:
96− -Wall -Werror -Wredundant-constraints -Wpartial-fields
97− -Wunused-packages
97+ ghc-options: -O0 -Wall -Werror
9898
9999 else
100100 ghc-options: -O2 -Wall
101101
102102test-suite httpbin-tests
103− type: exitcode-stdio-1.0
104− main-is: Spec.hs
105− build-tool-depends: hspec-discover:hspec-discover >=2 && <3
106− hs-source-dirs: httpbin-tests
107− other-modules: Network.HTTP.ReqSpec
108− default-language: GHC2021
103+ type: exitcode-stdio-1.0
104+ main-is: Spec.hs
105+ build-tools: hspec-discover >=2.0 && <3.0
106+ hs-source-dirs: httpbin-tests
107+ other-modules: Network.HTTP.ReqSpec
108+ default-language: Haskell2010
109109 build-depends:
110− QuickCheck >=2.7 && <3,
111− aeson >=2 && <3,
112− base >=4.15 && <5,
113− bytestring >=0.10.8 && <0.13,
110+ QuickCheck >=2.7 && <3.0,
111+ aeson >=0.9 && <1.5,
112+ base >=4.12 && <5.0,
113+ bytestring >=0.10.8 && <0.11,
114114 hspec >=2.0 && <3.0,
115− http-client >=0.7 && <0.8,
116− http-types >=0.8 && <10,
115+ http-client >=0.5 && <0.7,
116+ http-types >=0.8 && <10.0,
117117 monad-control >=1.0 && <1.1,
118− req,
119− text >=0.2 && <2.2
118+ mtl >=2.0 && <3.0,
119+ req -any,
120+ text >=0.2 && <1.3,
121+ unordered-containers >=0.2.5 && <0.2.11
120122
121123 if flag(dev)
122− ghc-options:
123− -Wall -Werror -Wredundant-constraints -Wpartial-fields
124− -Wunused-packages
124+ ghc-options: -O0 -Wall -Werror
125125
126126 else
127− buildable: False
127+ ghc-options: -O2 -Wall