040db21 · typeable/servant

git.iko.soy/typeable/servant

Merge pull request #599 from chkl/clientm

changed ClientM to be a Reader of ClientEnv

commit040db21152ebe0da106e08550e7c11983453918a authorJulian Arni <jkarni@gmail.com> dateWed 7 Sep 2016, 20:03 (10 years ago) parent29af0bb 7a7f7d7

6 files changed+126−91

compare with master

unifiedsplit

doc/tutorial/Client.lhs+10−17 servant-client/CHANGELOG.md+8 servant-client/servant-client.cabal+1 servant-client/src/Servant/Client.hs+16−14 servant-client/src/Servant/Common/Req.hs+50−19 servant-client/test/Servant/ClientSpec.hs+41−41

doc/tutorial/Client.lhs+10−17

@@ -15,11 +15,10 @@ need to have some language extensions and imports:

1515

1616module Client where

1717

18−import Control.Monad.Trans.Except (ExceptT, runExceptT)

1918import Data.Aeson

2019import Data.Proxy

2120import GHC.Generics

22−import Network.HTTP.Client (Manager, newManager, defaultManagerSettings)

21+import Network.HTTP.Client (newManager, defaultManagerSettings)

2322import Servant.API

2423import Servant.Client

2524```

@@ -71,19 +70,13 @@ What we are going to get with **servant-client** here is 3 functions, one to que

7170``` haskell

7271position :: Int -- ^ value for "x"

7372 -> Int -- ^ value for "y"

74− -> Manager -- ^ the HTTP client to use

75− -> BaseUrl -- ^ the URL at which the API can be found

76− -> ExceptT ServantError IO Position

73+ -> ClientM Position

7774

7875hello :: Maybe String -- ^ an optional value for "name"

79− -> Manager -- ^ the HTTP client to use

80− -> BaseUrl -- ^ the URL at which the API can be found

81− -> ExceptT ServantError IO HelloMessage

76+ -> ClientM HelloMessage

8277

8378marketing :: ClientInfo -- ^ value for the request body

84− -> Manager -- ^ the HTTP client to use

85− -> BaseUrl -- ^ the URL at which the API can be found

86− -> ExceptT ServantError IO Email

79+ -> ClientM Email

8780```

8881

8982Each function makes available as an argument any value that the response may

@@ -120,17 +113,17 @@ data BaseUrl = BaseUrl

120113That's it. Let's now write some code that uses our client functions.

121114

122115``` haskell

123−queries :: Manager -> BaseUrl -> ExceptT ServantError IO (Position, HelloMessage, Email)

124−queries manager baseurl = do

125− pos <- position 10 10 manager baseurl

126− message <- hello (Just "servant") manager baseurl

127− em <- marketing (ClientInfo "Alp" "alp@foo.com" 26 ["haskell", "mathematics"]) manager baseurl

116+queries :: ClientM (Position, HelloMessage, Email)

117+queries = do

118+ pos <- position 10 10

119+ message <- hello (Just "servant")

120+ em <- marketing (ClientInfo "Alp" "alp@foo.com" 26 ["haskell", "mathematics"])

128121 return (pos, message, em)

129122

130123run :: IO ()

131124run = do

132125 manager <- newManager defaultManagerSettings

133− res <- runExceptT (queries manager (BaseUrl Http "localhost" 8081 ""))

126+ res <- runClientM queries (ClientEnv manager (BaseUrl Http "localhost" 8081 ""))

134127 case res of

135128 Left err -> putStrLn $ "Error: " ++ show err

136129 Right (pos, message, em) -> do

servant-client/CHANGELOG.md+8

@@ -1,3 +1,11 @@

1+0.8.1

2+-----

4+* BACKWARDS INCOMPATIBLE: `client` now returns a ClientM which is a Reader for

5+ BasicEnv. BasicEnv comprises the HttpManager and BaseUrl that have had to be

6+ passed to each method returned by `client`.

190.7.1

210-----

311

servant-client/servant-client.cabal+1

@@ -53,6 +53,7 @@ library

5353 , text >= 1.2 && < 1.3

5454 , transformers >= 0.3 && < 0.6

5555 , transformers-compat >= 0.4 && < 0.6

56+ , mtl

5657 hs-source-dirs: src

5758 default-language: Haskell2010

5859 ghc-options: -Wall

servant-client/src/Servant/Client.hs+16−14

@@ -20,6 +20,8 @@ module Servant.Client

2020 , client

2121 , HasClient(..)

2222 , ClientM

23+ , runClientM

24+ , ClientEnv (ClientEnv)

2325 , mkAuthenticateReq

2426 , ServantError(..)

2527 , module Servant.Common.BaseUrl

@@ -34,7 +36,7 @@ import Data.Proxy

3436import Data.String.Conversions

3537import Data.Text (unpack)

3638import GHC.TypeLits

37−import Network.HTTP.Client (Manager, Response)

39+import Network.HTTP.Client (Response)

3840import Network.HTTP.Media

3941import qualified Network.HTTP.Types as H

4042import qualified Network.HTTP.Types.Header as HTTP

@@ -154,17 +156,17 @@ instance OVERLAPPABLE_

154156 -- Note [Non-Empty Content Types]

155157 (MimeUnrender ct a, ReflectMethod method, cts' ~ (ct ': cts)

156158 ) => HasClient (Verb method status cts' a) where

157− type Client (Verb method status cts' a) = Manager -> BaseUrl -> ClientM a

158− clientWithRoute Proxy req manager baseurl =

159− snd <$> performRequestCT (Proxy :: Proxy ct) method req manager baseurl

159+ type Client (Verb method status cts' a) = ClientM a

160+ clientWithRoute Proxy req = do

161+ snd <$> performRequestCT (Proxy :: Proxy ct) method req

160162 where method = reflectMethod (Proxy :: Proxy method)

161163

162164instance OVERLAPPING_

163165 (ReflectMethod method) => HasClient (Verb method status cts NoContent) where

164166 type Client (Verb method status cts NoContent)

165− = Manager -> BaseUrl -> ClientM NoContent

166− clientWithRoute Proxy req manager baseurl =

167− performRequestNoBody method req manager baseurl >> return NoContent

167+ = ClientM NoContent

168+ clientWithRoute Proxy req = do

169+ performRequestNoBody method req >> return NoContent

168170 where method = reflectMethod (Proxy :: Proxy method)

169171

170172instance OVERLAPPING_

@@ -172,10 +174,10 @@ instance OVERLAPPING_

172174 ( MimeUnrender ct a, BuildHeadersTo ls, ReflectMethod method, cts' ~ (ct ': cts)

173175 ) => HasClient (Verb method status cts' (Headers ls a)) where

174176 type Client (Verb method status cts' (Headers ls a))

175− = Manager -> BaseUrl -> ClientM (Headers ls a)

176− clientWithRoute Proxy req manager baseurl = do

177+ = ClientM (Headers ls a)

178+ clientWithRoute Proxy req = do

177179 let method = reflectMethod (Proxy :: Proxy method)

178− (hdrs, resp) <- performRequestCT (Proxy :: Proxy ct) method req manager baseurl

180+ (hdrs, resp) <- performRequestCT (Proxy :: Proxy ct) method req

179181 return $ Headers { getResponse = resp

180182 , getHeadersHList = buildHeadersTo hdrs

181183 }

@@ -184,10 +186,10 @@ instance OVERLAPPING_

184186 ( BuildHeadersTo ls, ReflectMethod method

185187 ) => HasClient (Verb method status cts (Headers ls NoContent)) where

186188 type Client (Verb method status cts (Headers ls NoContent))

187− = Manager -> BaseUrl -> ClientM (Headers ls NoContent)

188− clientWithRoute Proxy req manager baseurl = do

189+ = ClientM (Headers ls NoContent)

190+ clientWithRoute Proxy req = do

189191 let method = reflectMethod (Proxy :: Proxy method)

190− hdrs <- performRequestNoBody method req manager baseurl

192+ hdrs <- performRequestNoBody method req

191193 return $ Headers { getResponse = NoContent

192194 , getHeadersHList = buildHeadersTo hdrs

193195 }

@@ -372,7 +374,7 @@ instance (KnownSymbol sym, HasClient api)

372374-- back the full `Response`.

373375instance HasClient Raw where

374376 type Client Raw

375− = H.Method -> Manager -> BaseUrl -> ClientM (Int, ByteString, MediaType, [HTTP.Header], Response ByteString)

377+ = H.Method -> ClientM (Int, ByteString, MediaType, [HTTP.Header], Response ByteString)

376378

377379 clientWithRoute :: Proxy Raw -> Req -> Client Raw

378380 clientWithRoute Proxy req httpMethod = do

servant-client/src/Servant/Common/Req.hs+50−19

@@ -1,7 +1,10 @@

11{-# LANGUAGE DeriveDataTypeable #-}

2+{-# LANGUAGE DeriveGeneric #-}

23{-# LANGUAGE CPP #-}

34{-# LANGUAGE OverloadedStrings #-}

45{-# LANGUAGE ScopedTypeVariables #-}

6+{-# LANGUAGE GeneralizedNewtypeDeriving #-}

58module Servant.Common.Req where

710#if !MIN_VERSION_base(4,8,0)

@@ -10,8 +13,18 @@ import Control.Applicative

1013import Control.Exception

1114import Control.Monad

1215import Control.Monad.Catch (MonadThrow)

13−import Control.Monad.IO.Class

16+

17+#if MIN_VERSION_mtl(2,2,0)

18+import Control.Monad.Except (MonadError(..))

19+#else

20+import Control.Monad.Error.Class (MonadError(..))

21+#endif

1422import Control.Monad.Trans.Except

23+

24+

25+import GHC.Generics

26+import Control.Monad.IO.Class ()

27+import Control.Monad.Reader

1528import Data.ByteString.Lazy hiding (pack, filter, map, null, elem)

1629import Data.String

1730import Data.String.Conversions

@@ -19,9 +32,9 @@ import Data.Proxy

1932import Data.Text (Text)

2033import Data.Text.Encoding

2134import Data.Typeable

22−import Network.HTTP.Client hiding (Proxy, path)

2335import Network.HTTP.Media

2436import Network.HTTP.Types

37+import Network.HTTP.Client hiding (Proxy, path)

2538import qualified Network.HTTP.Types.Header as HTTP

2639import Network.URI hiding (path)

2740import Servant.API.ContentTypes

@@ -149,20 +162,40 @@ parseRequest url = liftM disableStatusCheck (parseUrl url)

149162displayHttpRequest :: Method -> String

150163displayHttpRequest httpmethod = "HTTP " ++ cs httpmethod ++ " request"

151164

152−type ClientM = ExceptT ServantError IO

165+data ClientEnv

166+ = ClientEnv

167+ { manager :: Manager

168+ , baseUrl :: BaseUrl

169+ }

170+

171+

172+-- | @ClientM@ is the monad in which client functions run. Contains the

173+-- 'Manager' and 'BaseUrl' used for requests in the reader environment.

174+

175+newtype ClientM a = ClientM { runClientM' :: ReaderT ClientEnv (ExceptT ServantError IO) a }

176+ deriving ( Functor, Applicative, Monad, MonadIO, Generic

177+ , MonadReader ClientEnv

178+ , MonadError ServantError

179+ )

180+

181+runClientM :: ClientM a -> ClientEnv -> IO (Either ServantError a)

182+runClientM cm env = runExceptT $ (flip runReaderT env) $ runClientM' cm

183+

153184

154−performRequest :: Method -> Req -> Manager -> BaseUrl

185+performRequest :: Method -> Req

155186 -> ClientM ( Int, ByteString, MediaType

156187 , [HTTP.Header], Response ByteString)

157−performRequest reqMethod req manager reqHost = do

188+performRequest reqMethod req = do

189+ m <- asks manager

190+ reqHost <- asks baseUrl

158191 partialRequest <- liftIO $ reqToRequest req reqHost

159192

160193 let request = partialRequest { Client.method = reqMethod }

161194

162− eResponse <- liftIO $ catchConnectionError $ Client.httpLbs request manager

195+ eResponse <- liftIO $ catchConnectionError $ Client.httpLbs request m

163196 case eResponse of

164197 Left err ->

165− throwE . ConnectionError $ SomeException err

198+ throwError . ConnectionError $ SomeException err

166199

167200 Right response -> do

168201 let status = Client.responseStatus response

@@ -172,28 +205,26 @@ performRequest reqMethod req manager reqHost = do

172205 ct <- case lookup "Content-Type" $ Client.responseHeaders response of

173206 Nothing -> pure $ "application"//"octet-stream"

174207 Just t -> case parseAccept t of

175− Nothing -> throwE $ InvalidContentTypeHeader (cs t) body

208+ Nothing -> throwError $ InvalidContentTypeHeader (cs t) body

176209 Just t' -> pure t'

177210 unless (status_code >= 200 && status_code < 300) $

178− throwE $ FailureResponse status ct body

211+ throwError $ FailureResponse status ct body

179212 return (status_code, body, ct, hdrs, response)

180213

181−performRequestCT :: MimeUnrender ct result =>

182− Proxy ct -> Method -> Req -> Manager -> BaseUrl

214+performRequestCT :: MimeUnrender ct result => Proxy ct -> Method -> Req

183215 -> ClientM ([HTTP.Header], result)

184−performRequestCT ct reqMethod req manager reqHost = do

216+performRequestCT ct reqMethod req = do

185217 let acceptCT = contentType ct

186218 (_status, respBody, respCT, hdrs, _response) <-

187− performRequest reqMethod (req { reqAccept = [acceptCT] }) manager reqHost

188− unless (matches respCT (acceptCT)) $ throwE $ UnsupportedContentType respCT respBody

219+ performRequest reqMethod (req { reqAccept = [acceptCT] })

220+ unless (matches respCT (acceptCT)) $ throwError $ UnsupportedContentType respCT respBody

189221 case mimeUnrender ct respBody of

190− Left err -> throwE $ DecodeFailure err respCT respBody

222+ Left err -> throwError $ DecodeFailure err respCT respBody

191223 Right val -> return (hdrs, val)

192224

193−performRequestNoBody :: Method -> Req -> Manager -> BaseUrl

194− -> ClientM [HTTP.Header]

195−performRequestNoBody reqMethod req manager reqHost = do

196− (_status, _body, _ct, hdrs, _response) <- performRequest reqMethod req manager reqHost

225+performRequestNoBody :: Method -> Req -> ClientM [HTTP.Header]

226+performRequestNoBody reqMethod req = do

227+ (_status, _body, _ct, hdrs, _response) <- performRequest reqMethod req

197228 return hdrs

198229

199230catchConnectionError :: IO a -> IO (Either ServantError a)

servant-client/test/Servant/ClientSpec.hs+41−41

@@ -32,7 +32,7 @@ import Control.Applicative ((<$>))

3232import Control.Arrow (left)

3333import Control.Concurrent (forkIO, killThread, ThreadId)

3434import Control.Exception (bracket)

35−import Control.Monad.Trans.Except (throwE, runExceptT)

35+import Control.Monad.Trans.Except (throwE )

3636import Data.Aeson

3737import qualified Data.ByteString.Lazy as BS

3838import Data.Char (chr, isPrint)

@@ -123,22 +123,22 @@ type Api =

123123api :: Proxy Api

124124api = Proxy

125125

126−getGet :: C.Manager -> BaseUrl -> SCR.ClientM Person

127−getDeleteEmpty :: C.Manager -> BaseUrl -> SCR.ClientM NoContent

128−getCapture :: String -> C.Manager -> BaseUrl -> SCR.ClientM Person

129−getCaptureAll :: [String] -> C.Manager -> BaseUrl -> SCR.ClientM [Person]

130−getBody :: Person -> C.Manager -> BaseUrl -> SCR.ClientM Person

131−getQueryParam :: Maybe String -> C.Manager -> BaseUrl -> SCR.ClientM Person

132−getQueryParams :: [String] -> C.Manager -> BaseUrl -> SCR.ClientM [Person]

133−getQueryFlag :: Bool -> C.Manager -> BaseUrl -> SCR.ClientM Bool

134−getRawSuccess :: HTTP.Method -> C.Manager -> BaseUrl

126+getGet :: SCR.ClientM Person

127+getDeleteEmpty :: SCR.ClientM NoContent

128+getCapture :: String -> SCR.ClientM Person

129+getCaptureAll :: [String] -> SCR.ClientM [Person]

130+getBody :: Person -> SCR.ClientM Person

131+getQueryParam :: Maybe String -> SCR.ClientM Person

132+getQueryParams :: [String] -> SCR.ClientM [Person]

133+getQueryFlag :: Bool -> SCR.ClientM Bool

134+getRawSuccess :: HTTP.Method

135135 -> SCR.ClientM (Int, BS.ByteString, MediaType, [HTTP.Header], C.Response BS.ByteString)

136−getRawFailure :: HTTP.Method -> C.Manager -> BaseUrl

136+getRawFailure :: HTTP.Method

137137 -> SCR.ClientM (Int, BS.ByteString, MediaType, [HTTP.Header], C.Response BS.ByteString)

138−getMultiple :: String -> Maybe Int -> Bool -> [(String, [Rational])] -> C.Manager -> BaseUrl

138+getMultiple :: String -> Maybe Int -> Bool -> [(String, [Rational])]

139139 -> SCR.ClientM (String, Maybe Int, Bool, [(String, [Rational])])

140−getRespHeaders :: C.Manager -> BaseUrl -> SCR.ClientM (Headers TestHeaders Bool)

141−getDeleteContentType :: C.Manager -> BaseUrl -> SCR.ClientM NoContent

140+getRespHeaders :: SCR.ClientM (Headers TestHeaders Bool)

141+getDeleteContentType :: SCR.ClientM NoContent

142142getGet

143143 :<|> getDeleteEmpty

144144 :<|> getCapture

@@ -242,42 +242,42 @@ sucessSpec :: Spec

242242sucessSpec = beforeAll (startWaiApp server) $ afterAll endWaiApp $ do

243243

244244 it "Servant.API.Get" $ \(_, baseUrl) -> do

245− (left show <$> runExceptT (getGet manager baseUrl)) `shouldReturn` Right alice

245+ (left show <$> (runClientM getGet (ClientEnv manager baseUrl))) `shouldReturn` Right alice

246246

247247 describe "Servant.API.Delete" $ do

248248 it "allows empty content type" $ \(_, baseUrl) -> do

249− (left show <$> runExceptT (getDeleteEmpty manager baseUrl)) `shouldReturn` Right NoContent

249+ (left show <$> (runClientM getDeleteEmpty (ClientEnv manager baseUrl))) `shouldReturn` Right NoContent

250250

251251 it "allows content type" $ \(_, baseUrl) -> do

252− (left show <$> runExceptT (getDeleteContentType manager baseUrl)) `shouldReturn` Right NoContent

252+ (left show <$> (runClientM getDeleteContentType (ClientEnv manager baseUrl))) `shouldReturn` Right NoContent

253253

254254 it "Servant.API.Capture" $ \(_, baseUrl) -> do

255− (left show <$> runExceptT (getCapture "Paula" manager baseUrl)) `shouldReturn` Right (Person "Paula" 0)

255+ (left show <$> (runClientM (getCapture "Paula") (ClientEnv manager baseUrl))) `shouldReturn` Right (Person "Paula" 0)

256256

257257 it "Servant.API.CaptureAll" $ \(_, baseUrl) -> do

258258 let expected = [(Person "Paula" 0), (Person "Peta" 1)]

259− (left show <$> runExceptT (getCaptureAll ["Paula", "Peta"] manager baseUrl)) `shouldReturn` Right expected

259+ (left show <$> (runClientM (getCaptureAll ["Paula", "Peta"]) (ClientEnv manager baseUrl))) `shouldReturn` Right expected

260260

261261 it "Servant.API.ReqBody" $ \(_, baseUrl) -> do

262262 let p = Person "Clara" 42

263− (left show <$> runExceptT (getBody p manager baseUrl)) `shouldReturn` Right p

263+ (left show <$> runClientM (getBody p) (ClientEnv manager baseUrl)) `shouldReturn` Right p

264264

265265 it "Servant.API.QueryParam" $ \(_, baseUrl) -> do

266− left show <$> runExceptT (getQueryParam (Just "alice") manager baseUrl) `shouldReturn` Right alice

267− Left FailureResponse{..} <- runExceptT (getQueryParam (Just "bob") manager baseUrl)

266+ left show <$> runClientM (getQueryParam (Just "alice")) (ClientEnv manager baseUrl) `shouldReturn` Right alice

267+ Left FailureResponse{..} <- runClientM (getQueryParam (Just "bob")) (ClientEnv manager baseUrl)

268268 responseStatus `shouldBe` HTTP.Status 400 "bob not found"

269269

270270 it "Servant.API.QueryParam.QueryParams" $ \(_, baseUrl) -> do

271− (left show <$> runExceptT (getQueryParams [] manager baseUrl)) `shouldReturn` Right []

272− (left show <$> runExceptT (getQueryParams ["alice", "bob"] manager baseUrl))

271+ (left show <$> runClientM (getQueryParams []) (ClientEnv manager baseUrl)) `shouldReturn` Right []

272+ (left show <$> runClientM (getQueryParams ["alice", "bob"]) (ClientEnv manager baseUrl))

273273 `shouldReturn` Right [Person "alice" 0, Person "bob" 1]

274274

275275 context "Servant.API.QueryParam.QueryFlag" $

276276 forM_ [False, True] $ \ flag -> it (show flag) $ \(_, baseUrl) -> do

277− (left show <$> runExceptT (getQueryFlag flag manager baseUrl)) `shouldReturn` Right flag

277+ (left show <$> runClientM (getQueryFlag flag) (ClientEnv manager baseUrl)) `shouldReturn` Right flag

278278

279279 it "Servant.API.Raw on success" $ \(_, baseUrl) -> do

280− res <- runExceptT (getRawSuccess HTTP.methodGet manager baseUrl)

280+ res <- runClientM (getRawSuccess HTTP.methodGet) (ClientEnv manager baseUrl)

281281 case res of

282282 Left e -> assertFailure $ show e

283283 Right (code, body, ct, _, response) -> do

@@ -286,7 +286,7 @@ sucessSpec = beforeAll (startWaiApp server) $ afterAll endWaiApp $ do

286286 C.responseStatus response `shouldBe` HTTP.ok200

287287

288288 it "Servant.API.Raw should return a Left in case of failure" $ \(_, baseUrl) -> do

289− res <- runExceptT (getRawFailure HTTP.methodGet manager baseUrl)

289+ res <- runClientM (getRawFailure HTTP.methodGet) (ClientEnv manager baseUrl)

290290 case res of

291291 Right _ -> assertFailure "expected Left, but got Right"

292292 Left e -> do

@@ -294,7 +294,7 @@ sucessSpec = beforeAll (startWaiApp server) $ afterAll endWaiApp $ do

294294 Servant.Client.responseBody e `shouldBe` "rawFailure"

295295

296296 it "Returns headers appropriately" $ \(_, baseUrl) -> do

297− res <- runExceptT (getRespHeaders manager baseUrl)

297+ res <- runClientM getRespHeaders (ClientEnv manager baseUrl)

298298 case res of

299299 Left e -> assertFailure $ show e

300300 Right val -> getHeaders val `shouldBe` [("X-Example1", "1729"), ("X-Example2", "eg2")]

@@ -303,7 +303,7 @@ sucessSpec = beforeAll (startWaiApp server) $ afterAll endWaiApp $ do

303303 it "works for a combination of Capture, QueryParam, QueryFlag and ReqBody" $ \(_, baseUrl) ->

304304 property $ forAllShrink pathGen shrink $ \(NonEmpty cap) num flag body ->

305305 ioProperty $ do

306− result <- left show <$> runExceptT (getMultiple cap num flag body manager baseUrl)

306+ result <- left show <$> runClientM (getMultiple cap num flag body) (ClientEnv manager baseUrl)

307307 return $

308308 result === Right (cap, num, flag, body)

309309

@@ -315,9 +315,9 @@ wrappedApiSpec = describe "error status codes" $ do

315315 let test :: (WrappedApi, String) -> Spec

316316 test (WrappedApi api, desc) =

317317 it desc $ bracket (startWaiApp $ serveW api) endWaiApp $ \(_, baseUrl) -> do

318− let getResponse :: C.Manager -> BaseUrl -> SCR.ClientM ()

318+ let getResponse :: SCR.ClientM ()

319319 getResponse = client api

320− Left FailureResponse{..} <- runExceptT (getResponse manager baseUrl)

320+ Left FailureResponse{..} <- runClientM getResponse (ClientEnv manager baseUrl)

321321 responseStatus `shouldBe` (HTTP.Status 500 "error message")

322322 in mapM_ test $

323323 (WrappedApi (Proxy :: Proxy (Delete '[JSON] ())), "Delete") :

@@ -332,42 +332,42 @@ failSpec = beforeAll (startWaiApp failServer) $ afterAll endWaiApp $ do

332332 context "client returns errors appropriately" $ do

333333 it "reports FailureResponse" $ \(_, baseUrl) -> do

334334 let (_ :<|> getDeleteEmpty :<|> _) = client api

335− Left res <- runExceptT (getDeleteEmpty manager baseUrl)

335+ Left res <- runClientM getDeleteEmpty (ClientEnv manager baseUrl)

336336 case res of

337337 FailureResponse (HTTP.Status 404 "Not Found") _ _ -> return ()

338338 _ -> fail $ "expected 404 response, but got " <> show res

339339

340340 it "reports DecodeFailure" $ \(_, baseUrl) -> do

341341 let (_ :<|> _ :<|> getCapture :<|> _) = client api

342− Left res <- runExceptT (getCapture "foo" manager baseUrl)

342+ Left res <- runClientM (getCapture "foo") (ClientEnv manager baseUrl)

343343 case res of

344344 DecodeFailure _ ("application/json") _ -> return ()

345345 _ -> fail $ "expected DecodeFailure, but got " <> show res

346346

347347 it "reports ConnectionError" $ \_ -> do

348348 let (getGetWrongHost :<|> _) = client api

349− Left res <- runExceptT (getGetWrongHost manager (BaseUrl Http "127.0.0.1" 19872 ""))

349+ Left res <- runClientM getGetWrongHost (ClientEnv manager (BaseUrl Http "127.0.0.1" 19872 ""))

350350 case res of

351351 ConnectionError _ -> return ()

352352 _ -> fail $ "expected ConnectionError, but got " <> show res

353353

354354 it "reports UnsupportedContentType" $ \(_, baseUrl) -> do

355355 let (getGet :<|> _ ) = client api

356− Left res <- runExceptT (getGet manager baseUrl)

356+ Left res <- runClientM getGet (ClientEnv manager baseUrl)

357357 case res of

358358 UnsupportedContentType ("application/octet-stream") _ -> return ()

359359 _ -> fail $ "expected UnsupportedContentType, but got " <> show res

360360

361361 it "reports InvalidContentTypeHeader" $ \(_, baseUrl) -> do

362362 let (_ :<|> _ :<|> _ :<|> _ :<|> getBody :<|> _) = client api

363− Left res <- runExceptT (getBody alice manager baseUrl)

363+ Left res <- runClientM (getBody alice) (ClientEnv manager baseUrl)

364364 case res of

365365 InvalidContentTypeHeader "fooooo" _ -> return ()

366366 _ -> fail $ "expected InvalidContentTypeHeader, but got " <> show res

367367

368368data WrappedApi where

369369 WrappedApi :: (HasServer (api :: *) '[], Server api ~ Handler a,

370− HasClient api, Client api ~ (C.Manager -> BaseUrl -> SCR.ClientM ())) =>

370+ HasClient api, Client api ~ SCR.ClientM ()) =>

371371 Proxy api -> WrappedApi

372372

373373basicAuthSpec :: Spec

@@ -377,14 +377,14 @@ basicAuthSpec = beforeAll (startWaiApp basicAuthServer) $ afterAll endWaiApp $ d

377377 it "Authenticates a BasicAuth protected server appropriately" $ \(_,baseUrl) -> do

378378 let getBasic = client basicAuthAPI

379379 let basicAuthData = BasicAuthData "servant" "server"

380− (left show <$> runExceptT (getBasic basicAuthData manager baseUrl)) `shouldReturn` Right alice

380+ (left show <$> runClientM (getBasic basicAuthData) (ClientEnv manager baseUrl)) `shouldReturn` Right alice

381381

382382 context "Authentication is rejected when requests are not authenticated properly" $ do

383383

384384 it "Authenticates a BasicAuth protected server appropriately" $ \(_,baseUrl) -> do

385385 let getBasic = client basicAuthAPI

386386 let basicAuthData = BasicAuthData "not" "password"

387− Left FailureResponse{..} <- runExceptT (getBasic basicAuthData manager baseUrl)

387+ Left FailureResponse{..} <- runClientM (getBasic basicAuthData) (ClientEnv manager baseUrl)

388388 responseStatus `shouldBe` HTTP.Status 403 "Forbidden"

389389

390390genAuthSpec :: Spec

@@ -394,14 +394,14 @@ genAuthSpec = beforeAll (startWaiApp genAuthServer) $ afterAll endWaiApp $ do

394394 it "Authenticates a AuthProtect protected server appropriately" $ \(_, baseUrl) -> do

395395 let getProtected = client genAuthAPI

396396 let authRequest = mkAuthenticateReq () (\_ req -> SCR.addHeader "AuthHeader" ("cool" :: String) req)

397− (left show <$> runExceptT (getProtected authRequest manager baseUrl)) `shouldReturn` Right alice

397+ (left show <$> runClientM (getProtected authRequest) (ClientEnv manager baseUrl)) `shouldReturn` Right alice

398398

399399 context "Authentication is rejected when requests are not authenticated properly" $ do

400400

401401 it "Authenticates a AuthProtect protected server appropriately" $ \(_, baseUrl) -> do

402402 let getProtected = client genAuthAPI

403403 let authRequest = mkAuthenticateReq () (\_ req -> SCR.addHeader "Wrong" ("header" :: String) req)

404− Left FailureResponse{..} <- runExceptT (getProtected authRequest manager baseUrl)

404+ Left FailureResponse{..} <- runClientM (getProtected authRequest) (ClientEnv manager baseUrl)

405405 responseStatus `shouldBe` (HTTP.Status 401 "Unauthorized")

406406

407407-- * utils