@@ -1,34 +1,31 @@
1−{-# LANGUAGE AllowAmbiguousTypes #-}
1+{-# LANGUAGE CPP #-}
22{-# LANGUAGE ConstraintKinds #-}
33{-# LANGUAGE DataKinds #-}
44{-# LANGUAGE DeriveDataTypeable #-}
55{-# LANGUAGE FlexibleContexts #-}
66{-# LANGUAGE FlexibleInstances #-}
7−{-# LANGUAGE InstanceSigs #-}
87{-# LANGUAGE MultiParamTypeClasses #-}
98{-# LANGUAGE OverloadedStrings #-}
109{-# LANGUAGE PolyKinds #-}
11−{-# LANGUAGE QuantifiedConstraints #-}
1210{-# LANGUAGE RankNTypes #-}
1311{-# LANGUAGE ScopedTypeVariables #-}
1412{-# LANGUAGE TupleSections #-}
15−{-# LANGUAGE TypeApplications #-}
1613{-# LANGUAGE TypeFamilies #-}
1714{-# LANGUAGE TypeOperators #-}
1815{-# LANGUAGE UndecidableInstances #-}
1916
17+#if MIN_VERSION_base(4,9,0) && __GLASGOW_HASKELL__ >= 802
18+#define HAS_TYPE_ERROR
19+#endif
20+
2021module Servant.Server.Internal
2122 ( module Servant.Server.Internal
2223 , module Servant.Server.Internal.BasicAuth
2324 , module Servant.Server.Internal.Context
24− , module Servant.Server.Internal.Delayed
25− , module Servant.Server.Internal.DelayedIO
26− , module Servant.Server.Internal.ErrorFormatter
2725 , module Servant.Server.Internal.Handler
2826 , module Servant.Server.Internal.Router
29− , module Servant.Server.Internal.RouteResult
3027 , module Servant.Server.Internal.RoutingApplication
31− , module Servant.Server.Internal.ServerError
28+ , module Servant.Server.Internal.ServantErr
3229 ) where
3330
3431import Control.Monad
@@ -41,11 +38,12 @@ import qualified Data.ByteString as B
4138import qualified Data.ByteString.Builder as BB
4239import qualified Data.ByteString.Char8 as BC8
4340import qualified Data.ByteString.Lazy as BL
44−import Data.Constraint (Constraint, Dict(..))
4541import Data.Either
4642 (partitionEithers)
4743import Data.Maybe
4844 (fromMaybe, isNothing, mapMaybe, maybeToList)
45+import Data.Semigroup
46+ ((<>))
4947import Data.String
5048 (IsString (..))
5149import Data.String.Conversions
@@ -54,9 +52,8 @@ import Data.Tagged
5452 (Tagged (..), retag, untag)
5553import qualified Data.Text as T
5654import Data.Typeable
57−import GHC.Generics
5855import GHC.TypeLits
59− (KnownNat, KnownSymbol, TypeError, symbolVal)
56+ (KnownNat, KnownSymbol, natVal, symbolVal)
6057import qualified Network.HTTP.Media as NHM
6158import Network.HTTP.Types hiding
6259 (Header, ResponseHeaders)
@@ -64,52 +61,42 @@ import Network.Socket
6461 (SockAddr)
6562import Network.Wai
6663 (Application, Request, httpVersion, isSecure, lazyRequestBody,
67− queryString, remoteHost, getRequestBodyChunk, requestHeaders,
68− requestMethod, responseLBS, responseStream, vault)
64+ rawQueryString, remoteHost, requestHeaders, requestMethod,
65+ responseLBS, responseStream, vault)
6966import Prelude ()
7067import Prelude.Compat
7168import Servant.API
72− ((:<|>) (..), (:>), Accept (..), BasicAuth, Capture',
73− CaptureAll, Description, EmptyAPI, Fragment,
74− FramingRender (..), FramingUnrender (..), FromSourceIO (..),
75− Header', If, IsSecure (..), NoContentVerb, QueryFlag,
76− QueryParam', QueryParams, Raw, ReflectMethod (reflectMethod),
77− RemoteHost, ReqBody', SBool (..), SBoolI (..), SourceIO,
78− Stream, StreamBody', Summary, ToSourceIO (..), Vault, Verb,
79− WithNamedContext, NamedRoutes)
80−import Servant.API.Generic (GenericMode(..), ToServant, ToServantApi, GServantProduct, toServant, fromServant)
69+ ((:<|>) (..), (:>), Accept (..), BasicAuth,
70+ BoundaryStrategy (..), Capture', CaptureAll, Description,
71+ EmptyAPI, FramingRender (..), Header', If, IsSecure (..),
72+ QueryFlag, QueryParam', QueryParams, Raw,
73+ ReflectMethod (reflectMethod), RemoteHost, ReqBody',
74+ SBool (..), SBoolI (..), Stream, StreamGenerator (..),
75+ Summary, ToStreamGenerator (..), Vault, Verb,
76+ WithNamedContext)
8177import Servant.API.ContentTypes
8278 (AcceptHeader (..), AllCTRender (..), AllCTUnrender (..),
83− AllMime, MimeRender (..), MimeUnrender (..), NoContent,
84− canHandleAcceptH)
79+ AllMime, MimeRender (..), canHandleAcceptH)
8580import Servant.API.Modifiers
8681 (FoldLenient, FoldRequired, RequestArgument,
8782 unfoldRequestArgument)
8883import Servant.API.ResponseHeaders
8984 (GetHeaders, Headers, getHeaders, getResponse)
90−import Servant.API.Status
91− (statusFromNat)
92−import qualified Servant.Types.SourceT as S
93−import Servant.API.TypeErrors
9485import Web.HttpApiData
95− (FromHttpApiData, parseHeader, parseQueryParam, parseUrlPiece,
96− parseUrlPieces)
86+ (FromHttpApiData, parseHeader, parseQueryParam,
87+ parseUrlPieceMaybe, parseUrlPieces)
9788
9889import Servant.Server.Internal.BasicAuth
9990import Servant.Server.Internal.Context
100−import Servant.Server.Internal.Delayed
101−import Servant.Server.Internal.DelayedIO
102−import Servant.Server.Internal.ErrorFormatter
10391import Servant.Server.Internal.Handler
10492import Servant.Server.Internal.Router
105−import Servant.Server.Internal.RouteResult
10693import Servant.Server.Internal.RoutingApplication
107−import Servant.Server.Internal.ServerError
94+import Servant.Server.Internal.ServantErr
10895
96+#ifdef HAS_TYPE_ERROR
10997import GHC.TypeLits
11098 (ErrorMessage (..), TypeError)
111−import Servant.API.TypeLevel
112− (AtLeastOneFragment, FragmentUnique)
99+#endif
113100
114101class HasServer api context where
115102 type ServerT api (m :: * -> *) :: *
@@ -173,31 +160,22 @@ instance (HasServer a context, HasServer b context) => HasServer (a :<|> b) cont
173160-- > server = getBook
174161-- > where getBook :: Text -> Handler Book
175162-- > getBook isbn = ...
176−instance (KnownSymbol capture, FromHttpApiData a, Typeable a
177− , HasServer api context, SBoolI (FoldLenient mods)
178− , HasContextEntry (MkContextWithErrorFormatter context) ErrorFormatters
179− )
163+instance (KnownSymbol capture, FromHttpApiData a, HasServer api context)
180164 => HasServer (Capture' mods capture a :> api) context where
181165
182166 type ServerT (Capture' mods capture a :> api) m =
183− If (FoldLenient mods) (Either String a) a -> ServerT api m
167+ a -> ServerT api m
184168
185169 hoistServerWithContext _ pc nt s = hoistServerWithContext (Proxy :: Proxy api) pc nt . s
186170
187171 route Proxy context d =
188− CaptureRouter [hint] $
172+ CaptureRouter $
189173 route (Proxy :: Proxy api)
190174 context
191− (addCapture d $ \ txt -> withRequest $ \ request ->
192− case ( sbool :: SBool (FoldLenient mods)
193− , parseUrlPiece txt :: Either T.Text a) of
194− (SFalse, Left e) -> delayedFail $ formatError rep request $ cs e
195− (SFalse, Right v) -> return v
196− (STrue, piece) -> return $ (either (Left . cs) Right) piece)
197− where
198− rep = typeRep (Proxy :: Proxy Capture')
199− formatError = urlParseErrorFormatter $ getContextEntry (mkContextWithErrorFormatter context)
200− hint = CaptureHint (T.pack $ symbolVal $ Proxy @capture) (typeRep (Proxy :: Proxy a))
175+ (addCapture d $ \ txt -> case parseUrlPieceMaybe txt of
176+ Nothing -> delayedFail err400
177+ Just v -> return v
178+ )
201179
202180-- | If you use 'CaptureAll' in one of the endpoints for your API,
203181-- this automatically requires your server-side handler to be a
@@ -216,10 +194,7 @@ instance (KnownSymbol capture, FromHttpApiData a, Typeable a
216194-- > server = getSourceFile
217195-- > where getSourceFile :: [Text] -> Handler Book
218196-- > getSourceFile pathSegments = ...
219−instance (KnownSymbol capture, FromHttpApiData a, Typeable a
220− , HasServer api context
221− , HasContextEntry (MkContextWithErrorFormatter context) ErrorFormatters
222− )
197+instance (KnownSymbol capture, FromHttpApiData a, HasServer api context)
223198 => HasServer (CaptureAll capture a :> api) context where
224199
225200 type ServerT (CaptureAll capture a :> api) m =
@@ -228,18 +203,14 @@ instance (KnownSymbol capture, FromHttpApiData a, Typeable a
228203 hoistServerWithContext _ pc nt s = hoistServerWithContext (Proxy :: Proxy api) pc nt . s
229204
230205 route Proxy context d =
231− CaptureAllRouter [hint] $
206+ CaptureAllRouter $
232207 route (Proxy :: Proxy api)
233208 context
234− (addCapture d $ \ txts -> withRequest $ \ request ->
235− case parseUrlPieces txts of
236− Left e -> delayedFail $ formatError rep request $ cs e
237− Right v -> return v
209+ (addCapture d $ \ txts -> case parseUrlPieces txts of
210+ Left _ -> delayedFail err400
211+ Right v -> return v
238212 )
239− where
240− rep = typeRep (Proxy :: Proxy CaptureAll)
241− formatError = urlParseErrorFormatter $ getContextEntry (mkContextWithErrorFormatter context)
242− hint = CaptureHint (T.pack $ symbolVal $ Proxy @capture) (typeRep (Proxy :: Proxy [a]))
213+
243214
244215allowedMethodHead :: Method -> Request -> Bool
245216allowedMethodHead method request = method == methodGet && requestMethod request == methodHead
@@ -259,10 +230,10 @@ methodCheck method request
259230-- body check is no longer an option. However, we now run the accept
260231-- check before the body check and can therefore afford to make it
261232-- recoverable.
262−acceptCheck :: (AllMime list) => Proxy list -> AcceptHeader -> DelayedIO ()
233+acceptCheck :: (AllMime list) => Proxy list -> B.ByteString -> DelayedIO ()
263234acceptCheck proxy accH
264− | canHandleAcceptH proxy accH = return ()
265− | otherwise = delayedFail err406
235+ | canHandleAcceptH proxy (AcceptHeader accH) = return ()
236+ | otherwise = delayedFail err406
266237
267238methodRouter :: (AllCTRender ctypes a)
268239 => (b -> ([(HeaderName, B.ByteString)], a))
@@ -272,28 +243,17 @@ methodRouter :: (AllCTRender ctypes a)
272243methodRouter splitHeaders method proxy status action = leafRouter route'
273244 where
274245 route' env request respond =
275− let accH = getAcceptHeader request
246+ let accH = fromMaybe ct_wildcard $ lookup hAccept $ requestHeaders request
276247 in runAction (action `addMethodCheck` methodCheck method request
277248 `addAcceptCheck` acceptCheck proxy accH
278249 ) env request respond $ \ output -> do
279250 let (headers, b) = splitHeaders output
280− case handleAcceptH proxy accH b of
251+ case handleAcceptH proxy (AcceptHeader accH) b of
281252 Nothing -> FailFatal err406 -- this should not happen (checked before), so we make it fatal if it does
282253 Just (contentT, body) ->
283254 let bdy = if allowedMethodHead method request then "" else body
284255 in Route $ responseLBS status ((hContentType, cs contentT) : headers) bdy
285256
286−noContentRouter :: Method
287− -> Status
288− -> Delayed env (Handler b)
289− -> Router env
290−noContentRouter method status action = leafRouter route'
291− where
292− route' env request respond =
293− runAction (action `addMethodCheck` methodCheck method request)
294− env request respond $ \ _output ->
295− Route $ responseLBS status [] ""
296−
297257instance {-# OVERLAPPABLE #-}
298258 ( AllCTRender ctypes a, ReflectMethod method, KnownNat status
299259 ) => HasServer (Verb method status ctypes a) context where
@@ -303,7 +263,7 @@ instance {-# OVERLAPPABLE #-}
303263
304264 route Proxy _ = methodRouter ([],) method (Proxy :: Proxy ctypes) status
305265 where method = reflectMethod (Proxy :: Proxy method)
306− status = statusFromNat (Proxy :: Proxy status)
266+ status = toEnum . fromInteger $ natVal (Proxy :: Proxy status)
307267
308268instance {-# OVERLAPPING #-}
309269 ( AllCTRender ctypes a, ReflectMethod method, KnownNat status
@@ -315,46 +275,37 @@ instance {-# OVERLAPPING #-}
315275
316276 route Proxy _ = methodRouter (\x -> (getHeaders x, getResponse x)) method (Proxy :: Proxy ctypes) status
317277 where method = reflectMethod (Proxy :: Proxy method)
318− status = statusFromNat (Proxy :: Proxy status)
278+ status = toEnum . fromInteger $ natVal (Proxy :: Proxy status)
319279
320−instance (ReflectMethod method) =>
321− HasServer (NoContentVerb method) context where
322−
323− type ServerT (NoContentVerb method) m = m NoContent
324− hoistServerWithContext _ _ nt s = nt s
325−
326− route Proxy _ = noContentRouter method status204
327− where method = reflectMethod (Proxy :: Proxy method)
328280
329281instance {-# OVERLAPPABLE #-}
330− ( MimeRender ctype chunk, ReflectMethod method, KnownNat status,
331− FramingRender framing, ToSourceIO chunk a
332− ) => HasServer (Stream method status framing ctype a) context where
282+ ( MimeRender ctype a, ReflectMethod method, KnownNat status,
283+ FramingRender framing ctype, ToStreamGenerator b a
284+ ) => HasServer (Stream method status framing ctype b) context where
333285
334− type ServerT (Stream method status framing ctype a) m = m a
286+ type ServerT (Stream method status framing ctype b) m = m b
335287 hoistServerWithContext _ _ nt s = nt s
336288
337289 route Proxy _ = streamRouter ([],) method status (Proxy :: Proxy framing) (Proxy :: Proxy ctype)
338290 where method = reflectMethod (Proxy :: Proxy method)
339− status = statusFromNat (Proxy :: Proxy status)
340−
291+ status = toEnum . fromInteger $ natVal (Proxy :: Proxy status)
341292
342293instance {-# OVERLAPPING #-}
343− ( MimeRender ctype chunk, ReflectMethod method, KnownNat status,
344− FramingRender framing, ToSourceIO chunk a,
345− GetHeaders (Headers h a)
346− ) => HasServer (Stream method status framing ctype (Headers h a)) context where
294+ ( MimeRender ctype a, ReflectMethod method, KnownNat status,
295+ FramingRender framing ctype, ToStreamGenerator b a,
296+ GetHeaders (Headers h b)
297+ ) => HasServer (Stream method status framing ctype (Headers h b)) context where
347298
348− type ServerT (Stream method status framing ctype (Headers h a)) m = m (Headers h a)
299+ type ServerT (Stream method status framing ctype (Headers h b)) m = m (Headers h b)
349300 hoistServerWithContext _ _ nt s = nt s
350301
351302 route Proxy _ = streamRouter (\x -> (getHeaders x, getResponse x)) method status (Proxy :: Proxy framing) (Proxy :: Proxy ctype)
352303 where method = reflectMethod (Proxy :: Proxy method)
353− status = statusFromNat (Proxy :: Proxy status)
304+ status = toEnum . fromInteger $ natVal (Proxy :: Proxy status)
354305
355306
356−streamRouter :: forall ctype a c chunk env framing. (MimeRender ctype chunk, FramingRender framing, ToSourceIO chunk a) =>
357− (c -> ([(HeaderName, B.ByteString)], a))
307+streamRouter :: (MimeRender ctype a, FramingRender framing ctype, ToStreamGenerator b a) =>
308+ (c -> ([(HeaderName, B.ByteString)], b))
358309 -> Method
359310 -> Status
360311 -> Proxy framing
@@ -362,7 +313,7 @@ streamRouter :: forall ctype a c chunk env framing. (MimeRender ctype chunk, Fra
362313 -> Delayed env (Handler c)
363314 -> Router env
364315streamRouter splitHeaders method status framingproxy ctypeproxy action = leafRouter $ \env request respond ->
365− let AcceptHeader accH = getAcceptHeader request
316+ let accH = fromMaybe ct_wildcard $ lookup hAccept $ requestHeaders request
366317 cmediatype = NHM.matchAccept [contentType ctypeproxy] accH
367318 accCheck = when (isNothing cmediatype) $ delayedFail err406
368319 contentHeader = (hContentType, NHM.renderHeader . maybeToList $ cmediatype)
@@ -370,19 +321,28 @@ streamRouter splitHeaders method status framingproxy ctypeproxy action = leafRou
370321 `addAcceptCheck` accCheck
371322 ) env request respond $ \ output ->
372323 let (headers, fa) = splitHeaders output
373− sourceT = toSourceIO fa
374− S.SourceT kStepLBS = framingRender framingproxy (mimeRender ctypeproxy :: chunk -> BL.ByteString) sourceT
375− in Route $ responseStream status (contentHeader : headers) $ \write flush -> do
376− let loop S.Stop = flush
377− loop (S.Error err) = fail err -- TODO: throw better error
378− loop (S.Skip s) = loop s
379− loop (S.Effect ms) = ms >>= loop
380− loop (S.Yield lbs s) = do
381− write (BB.lazyByteString lbs)
382− flush
383− loop s
384−
385− kStepLBS loop
324+ k = getStreamGenerator . toStreamGenerator $ fa in
325+ Route $ responseStream status (contentHeader : headers) $ \write flush -> do
326+ write . BB.lazyByteString $ header framingproxy ctypeproxy
327+ case boundary framingproxy ctypeproxy of
328+ BoundaryStrategyBracket f ->
329+ let go x = let bs = mimeRender ctypeproxy x
330+ (before, after) = f bs
331+ in write ( BB.lazyByteString before
332+ <> BB.lazyByteString bs
333+ <> BB.lazyByteString after) >> flush
334+ in k go go
335+ BoundaryStrategyIntersperse sep -> k
336+ (\x -> do
337+ write . BB.lazyByteString . mimeRender ctypeproxy $ x
338+ flush)
339+ (\x -> do
340+ write . (BB.lazyByteString sep <>) . BB.lazyByteString . mimeRender ctypeproxy $ x
341+ flush)
342+ BoundaryStrategyGeneral f ->
343+ let go = (>> flush) . write . BB.lazyByteString . f . mimeRender ctypeproxy
344+ in k go go
345+ write . BB.lazyByteString $ trailer framingproxy ctypeproxy
386346
387347-- | If you use 'Header' in one of the endpoints for your API,
388348-- this automatically requires your server-side handler to be a function
@@ -407,7 +367,6 @@ streamRouter splitHeaders method status framingproxy ctypeproxy action = leafRou
407367instance
408368 (KnownSymbol sym, FromHttpApiData a, HasServer api context
409369 , SBoolI (FoldRequired mods), SBoolI (FoldLenient mods)
410− , HasContextEntry (MkContextWithErrorFormatter context) ErrorFormatters
411370 )
412371 => HasServer (Header' mods sym a :> api) context where
413372------
@@ -419,9 +378,6 @@ instance
419378 route Proxy context subserver = route (Proxy :: Proxy api) context $
420379 subserver `addHeaderCheck` withRequest headerCheck
421380 where
422− rep = typeRep (Proxy :: Proxy Header')
423− formatError = headerParseErrorFormatter $ getContextEntry (mkContextWithErrorFormatter context)
424−
425381 headerName :: IsString n => n
426382 headerName = fromString $ symbolVal (Proxy :: Proxy sym)
427383
@@ -432,13 +388,15 @@ instance
432388 mev :: Maybe (Either T.Text a)
433389 mev = fmap parseHeader $ lookup headerName (requestHeaders req)
434390
435− errReq = delayedFailFatal $ formatError rep req
436− $ "Header " <> headerName <> " is required"
391+ errReq = delayedFailFatal err400
392+ { errBody = "Header " <> headerName <> " is required"
393+ }
437394
438− errSt e = delayedFailFatal $ formatError rep req
439− $ cs $ "Error parsing header "
440− <> headerName
441− <> " failed: " <> e
395+ errSt e = delayedFailFatal err400
396+ { errBody = cs $ "Error parsing header "
397+ <> headerName
398+ <> " failed: " <> e
399+ }
442400
443401-- | If you use @'QueryParam' "author" Text@ in one of the endpoints for your API,
444402-- this automatically requires your server-side handler to be a function
@@ -464,7 +422,6 @@ instance
464422instance
465423 ( KnownSymbol sym, FromHttpApiData a, HasServer api context
466424 , SBoolI (FoldRequired mods), SBoolI (FoldLenient mods)
467− , HasContextEntry (MkContextWithErrorFormatter context) ErrorFormatters
468425 )
469426 => HasServer (QueryParam' mods sym a :> api) context where
470427------
@@ -474,12 +431,9 @@ instance
474431 hoistServerWithContext _ pc nt s = hoistServerWithContext (Proxy :: Proxy api) pc nt . s
475432
476433 route Proxy context subserver =
477− let querytext = queryToQueryText . queryString
434+ let querytext req = parseQueryText $ rawQueryString req
478435 paramname = cs $ symbolVal (Proxy :: Proxy sym)
479436
480− rep = typeRep (Proxy :: Proxy QueryParam')
481− formatError = urlParseErrorFormatter $ getContextEntry (mkContextWithErrorFormatter context)
482−
483437 parseParam :: Request -> DelayedIO (RequestArgument mods a)
484438 parseParam req =
485439 unfoldRequestArgument (Proxy :: Proxy mods) errReq errSt mev
@@ -487,12 +441,14 @@ instance
487441 mev :: Maybe (Either T.Text a)
488442 mev = fmap parseQueryParam $ join $ lookup paramname $ querytext req
489443
490− errReq = delayedFailFatal $ formatError rep req
491− $ cs $ "Query parameter " <> paramname <> " is required"
444+ errReq = delayedFailFatal err400
445+ { errBody = cs $ "Query parameter " <> paramname <> " is required"
446+ }
492447
493− errSt e = delayedFailFatal $ formatError rep req
494− $ cs $ "Error parsing query parameter "
495− <> paramname <> " failed: " <> e
448+ errSt e = delayedFailFatal err400
449+ { errBody = cs $ "Error parsing query parameter "
450+ <> paramname <> " failed: " <> e
451+ }
496452
497453 delayed = addParameterCheck subserver . withRequest $ \req ->
498454 parseParam req
@@ -518,8 +474,7 @@ instance
518474-- > server = getBooksBy
519475-- > where getBooksBy :: [Text] -> Handler [Book]
520476-- > getBooksBy authors = ...return all books by these authors...
521−instance (KnownSymbol sym, FromHttpApiData a, HasServer api context
522− , HasContextEntry (MkContextWithErrorFormatter context) ErrorFormatters)
477+instance (KnownSymbol sym, FromHttpApiData a, HasServer api context)
523478 => HasServer (QueryParams sym a :> api) context where
524479
525480 type ServerT (QueryParams sym a :> api) m =
@@ -530,23 +485,21 @@ instance (KnownSymbol sym, FromHttpApiData a, HasServer api context
530485 route Proxy context subserver = route (Proxy :: Proxy api) context $
531486 subserver `addParameterCheck` withRequest paramsCheck
532487 where
533− rep = typeRep (Proxy :: Proxy QueryParams)
534− formatError = urlParseErrorFormatter $ getContextEntry (mkContextWithErrorFormatter context)
535−
536488 paramname = cs $ symbolVal (Proxy :: Proxy sym)
537489 paramsCheck req =
538490 case partitionEithers $ fmap parseQueryParam params of
539491 ([], parsed) -> return parsed
540− (errs, _) -> delayedFailFatal $ formatError rep req
541− $ cs $ "Error parsing query parameter(s) "
542− <> paramname <> " failed: "
543− <> T.intercalate ", " errs
492+ (errs, _) -> delayedFailFatal err400
493+ { errBody = cs $ "Error parsing query parameter(s) "
494+ <> paramname <> " failed: "
495+ <> T.intercalate ", " errs
496+ }
544497 where
545498 params :: [T.Text]
546499 params = mapMaybe snd
547500 . filter (looksLikeParam . fst)
548− . queryToQueryText
549− . queryString
501+ . parseQueryText
502+ . rawQueryString
550503 $ req
551504
552505 looksLikeParam name = name == paramname || name == (paramname <> "[]")
@@ -572,7 +525,7 @@ instance (KnownSymbol sym, HasServer api context)
572525 hoistServerWithContext _ pc nt s = hoistServerWithContext (Proxy :: Proxy api) pc nt . s
573526
574527 route Proxy context subserver =
575− let querytext = queryToQueryText . queryString
528+ let querytext r = parseQueryText $ rawQueryString r
576529 param r = case lookup paramname (querytext r) of
577530 Just Nothing -> True -- param is there, with no value
578531 Just (Just v) -> examine v -- param with a value
@@ -614,7 +567,7 @@ instance HasServer Raw context where
614567-- The @Content-Type@ header is inspected, and the list provided is used to
615568-- attempt deserialization. If the request does not have a @Content-Type@
616569-- header, it is treated as @application/octet-stream@ (as specified in
617−-- [RFC 7231 section 3.1.1.5](http://tools.ietf.org/html/rfc7231#section-3.1.1.5)).
570+-- <http://tools.ietf.org/html/rfc7231#section-3.1.1.5 RFC7231>.
618571-- This lets servant worry about extracting it from the request and turning
619572-- it into a value of the type you specify.
620573--
@@ -630,7 +583,6 @@ instance HasServer Raw context where
630583-- > where postBook :: Book -> Handler Book
631584-- > postBook book = ...insert into your db...
632585instance ( AllCTUnrender list a, HasServer api context, SBoolI (FoldLenient mods)
633− , HasContextEntry (MkContextWithErrorFormatter context) ErrorFormatters
634586 ) => HasServer (ReqBody' mods list a :> api) context where
635587
636588 type ServerT (ReqBody' mods list a :> api) m =
@@ -642,9 +594,6 @@ instance ( AllCTUnrender list a, HasServer api context, SBoolI (FoldLenient mods
642594 = route (Proxy :: Proxy api) context $
643595 addBodyCheck subserver ctCheck bodyCheck
644596 where
645− rep = typeRep (Proxy :: Proxy ReqBody')
646− formatError = bodyParserErrorFormatter $ getContextEntry (mkContextWithErrorFormatter context)
647−
648597 -- Content-Type check, we only lookup we can try to parse the request body
649598 ctCheck = withRequest $ \ request -> do
650599 -- See HTTP RFC 2616, section 7.2.1
@@ -663,34 +612,9 @@ instance ( AllCTUnrender list a, HasServer api context, SBoolI (FoldLenient mods
663612 case sbool :: SBool (FoldLenient mods) of
664613 STrue -> return mrqbody
665614 SFalse -> case mrqbody of
666− Left e -> delayedFailFatal $ formatError rep request e
615+ Left e -> delayedFailFatal err400 { errBody = cs e }
667616 Right v -> return v
668617
669−instance
670− ( FramingUnrender framing, FromSourceIO chunk a, MimeUnrender ctype chunk
671− , HasServer api context
672− ) => HasServer (StreamBody' mods framing ctype a :> api) context
673− where
674− type ServerT (StreamBody' mods framing ctype a :> api) m = a -> ServerT api m
675−
676− hoistServerWithContext _ pc nt s = hoistServerWithContext (Proxy :: Proxy api) pc nt . s
677−
678− route Proxy context subserver = route (Proxy :: Proxy api) context $
679− addBodyCheck subserver ctCheck bodyCheck
680− where
681− ctCheck :: DelayedIO (SourceIO chunk -> a)
682− -- TODO: do content-type check
683− ctCheck = return fromSourceIO
684−
685− bodyCheck :: (SourceIO chunk -> a) -> DelayedIO a
686− bodyCheck fromRS = withRequest $ \req -> do
687− let mimeUnrender' = mimeUnrender (Proxy :: Proxy ctype) :: BL.ByteString -> Either String chunk
688− let framingUnrender' = framingUnrender (Proxy :: Proxy framing) mimeUnrender' :: SourceIO B.ByteString -> SourceIO chunk
689− let body = getRequestBodyChunk req
690− let rs = S.fromAction B.null body
691− let rs' = fromRS $ framingUnrender' rs
692− return rs'
693−
694618-- | Make sure the incoming request starts with @"/path"@, strip it and
695619-- pass the rest of the request path to @api@.
696620instance (KnownSymbol path, HasServer api context) => HasServer (path :> api) context where
@@ -755,12 +679,12 @@ data EmptyServer = EmptyServer deriving (Typeable, Eq, Show, Bounded, Enum)
755679emptyServer :: ServerT EmptyAPI m
756680emptyServer = Tagged EmptyServer
757681
758−-- | The server for an `EmptyAPI` is `emptyServer`.
682+-- | The server for an `EmptyAPI` is `emptyAPIServer`.
759683--
760684-- > type MyApi = "nothing" :> EmptyApi
761685-- >
762686-- > server :: Server MyApi
763−-- > server = emptyServer
687+-- > server = emptyAPIServer
764688instance HasServer EmptyAPI context where
765689 type ServerT EmptyAPI m = Tagged m EmptyServer
766690
@@ -789,10 +713,7 @@ instance ( KnownSymbol realm
789713-- * helpers
790714
791715ct_wildcard :: B.ByteString
792−ct_wildcard = "*" <> "/" <> "*"
793−
794−getAcceptHeader :: Request -> AcceptHeader
795−getAcceptHeader = AcceptHeader . fromMaybe ct_wildcard . lookup hAccept . requestHeaders
716+ct_wildcard = "*" <> "/" <> "*" -- Because CPP
796717
797718-- * General Authentication
798719
@@ -817,15 +738,39 @@ instance (HasContextEntry context (NamedContext name subContext), HasServer subA
817738 hoistServerWithContext _ _ nt s = hoistServerWithContext (Proxy :: Proxy subApi) (Proxy :: Proxy subContext) nt s
818739
819740-------------------------------------------------------------------------------
820−-- Custom type errors
741+-- TypeError helpers
821742-------------------------------------------------------------------------------
822743
823−-- Erroring instance for 'HasServer' when a combinator is not fully applied
824−instance TypeError (PartialApplication HasServer arr) => HasServer ((arr :: a -> b) :> sub) context
744+#ifdef HAS_TYPE_ERROR
745+-- | This instance catches mistakes when there are non-saturated
746+-- type applications on LHS of ':>'.
747+--
748+-- >>> serve (Proxy :: Proxy (Capture "foo" :> Get '[JSON] Int)) (error "...")
749+-- ...
750+-- ...Expected something of kind Symbol or *, got: k -> l on the LHS of ':>'.
751+-- ...Maybe you haven't applied enough arguments to
752+-- ...Capture' '[] "foo"
753+-- ...
754+--
755+-- >>> undefined :: Server (Capture "foo" :> Get '[JSON] Int)
756+-- ...
757+-- ...Expected something of kind Symbol or *, got: k -> l on the LHS of ':>'.
758+-- ...Maybe you haven't applied enough arguments to
759+-- ...Capture' '[] "foo"
760+-- ...
761+--
762+instance TypeError (HasServerArrowKindError arr) => HasServer ((arr :: k -> l) :> api) context
825763 where
826− type ServerT (arr :> sub) _ = TypeError (PartialApplication (HasServer :: * -> [*] -> Constraint) arr)
827− route = error "unreachable"
828− hoistServerWithContext _ _ _ _ = error "unreachable"
764+ type ServerT (arr :> api) m = TypeError (HasServerArrowKindError arr)
765+ -- it doens't really matter what sub route we peak
766+ route _ _ _ = error "servant-server panic: impossible happened in HasServer (arr :> api)"
767+ hoistServerWithContext _ _ _ = id
768+
769+-- Cannot have TypeError here, otherwise use of this symbol will error :)
770+type HasServerArrowKindError arr =
771+ 'Text "Expected something of kind Symbol or *, got: k -> l on the LHS of ':>'."
772+ ':$$: 'Text "Maybe you haven't applied enough arguments to"
773+ ':$$: 'ShowType arr
829774
830775-- | This instance prevents from accidentally using '->' instead of ':>'
831776--
@@ -859,103 +804,7 @@ type HasServerArrowTypeError a b =
859804 ':$$: 'ShowType a
860805 ':$$: 'Text "and"
861806 ':$$: 'ShowType b
862−
863−-- Erroring instances for 'HasServer' for unknown API combinators
864−
865−-- XXX: This omits the @context@ parameter, e.g.:
866−--
867−-- "There is no instance for HasServer (Bool :> …)". Do we care ?
868−instance {-# OVERLAPPABLE #-} TypeError (NoInstanceForSub HasServer ty) => HasServer (ty :> sub) context
869−
870−instance {-# OVERLAPPABLE #-} TypeError (NoInstanceFor (HasServer api context)) => HasServer api context
871−
872−-- | Ignore @'Fragment'@ in server handlers.
873−-- See <https://ietf.org/rfc/rfc2616.html#section-15.1.3> for more details.
874−--
875−-- Example:
876−--
877−-- > type MyApi = "books" :> Fragment Text :> Get '[JSON] [Book]
878−-- >
879−-- > server :: Server MyApi
880−-- > server = getBooks
881−-- > where getBooks :: Handler [Book]
882−-- > getBooks = ...return all books...
883−instance (AtLeastOneFragment api, FragmentUnique (Fragment a1 :> api), HasServer api context)
884− => HasServer (Fragment a1 :> api) context where
885− type ServerT (Fragment a1 :> api) m = ServerT api m
886−
887− route _ = route (Proxy :: Proxy api)
888−
889− hoistServerWithContext _ = hoistServerWithContext (Proxy :: Proxy api)
807+#endif
890808
891809-- $setup
892810-- >>> import Servant
893−
894−-- | A type that specifies that an API record contains a server implementation.
895−data AsServerT (m :: * -> *)
896−instance GenericMode (AsServerT m) where
897− type AsServerT m :- api = ServerT api m
898−
899−type AsServer = AsServerT Handler
900−
901−
902−-- | Set of constraints required to convert to / from vanilla server types.
903−type GServerConstraints api m =
904− ( ToServant api (AsServerT m) ~ ServerT (ToServantApi api) m
905− , GServantProduct (Rep (api (AsServerT m)))
906− )
907−
908−-- | This class is a necessary evil: in the implementation of 'HasServer' for
909−-- @'NamedRoutes' api@, we essentially need the quantified constraint @forall
910−-- m. 'GServerConstraints' m@ to hold.
911−--
912−-- We cannot require do that directly as the definition of 'GServerConstraints'
913−-- contains type family applications ('Rep' and 'ServerT'). The trick is to hide
914−-- those type family applications behind a typeclass providing evidence for
915−-- @'GServerConstraints' api m@ in the form of a dictionary, and require that
916−-- @forall m. 'GServer' api m@ instead.
917−--
918−-- Users shouldn't have to worry about this class, as the only possible instance
919−-- is provided in this module for all record APIs.
920−
921−class GServer (api :: * -> *) (m :: * -> *) where
922− gServerProof :: Dict (GServerConstraints api m)
923−
924−instance
925− ( ToServant api (AsServerT m) ~ ServerT (ToServantApi api) m
926− , GServantProduct (Rep (api (AsServerT m)))
927− ) => GServer api m where
928− gServerProof = Dict
929−
930−instance
931− ( HasServer (ToServantApi api) context
932− , forall m. Generic (api (AsServerT m))
933− , forall m. GServer api m
934− ) => HasServer (NamedRoutes api) context where
935−
936− type ServerT (NamedRoutes api) m = api (AsServerT m)
937−
938− route
939− :: Proxy (NamedRoutes api)
940− -> Context context
941− -> Delayed env (api (AsServerT Handler))
942− -> Router env
943− route _ ctx delayed =
944− case gServerProof @api @Handler of
945− Dict -> route (Proxy @(ToServantApi api)) ctx (toServant <$> delayed)
946−
947− hoistServerWithContext
948− :: forall m n. Proxy (NamedRoutes api)
949− -> Proxy context
950− -> (forall x. m x -> n x)
951− -> api (AsServerT m)
952− -> api (AsServerT n)
953− hoistServerWithContext _ pctx nat server =
954− case (gServerProof @api @m, gServerProof @api @n) of
955− (Dict, Dict) ->
956− fromServant servantSrvN
957− where
958− servantSrvM :: ServerT (ToServantApi api) m =
959− toServant server
960− servantSrvN :: ServerT (ToServantApi api) n =
961− hoistServerWithContext (Proxy @(ToServantApi api)) pctx nat servantSrvM